aboutsummaryrefslogtreecommitdiff
path: root/sys/dev
diff options
context:
space:
mode:
authorDavid Bright <dab@FreeBSD.org>2018-08-14 19:12:45 +0000
committerDavid Bright <dab@FreeBSD.org>2018-08-14 19:12:45 +0000
commit53e992cfb9bfbc5c77588165b3a250a1fa555a23 (patch)
tree4eecd7e9957d83f272000a0e57f81100ffc0d6ed /sys/dev
parente13a20dad7636a6953568929efdfd73338bf7373 (diff)
downloadsrc-53e992cfb9bfbc5c77588165b3a250a1fa555a23.tar.gz
src-53e992cfb9bfbc5c77588165b3a250a1fa555a23.zip
Fix several memory leaks.
The libkqueue tests have several places that leak memory by using an idiom like: puts(kevent_to_str(kevp)); Rework to save the pointer returned from kevent_to_str() and then free() it after it has been used. Reported by: asomers (pointer to Coverity), Coverity CID: 1296063, 1296064, 1296065, 1296066, 1296067, 1350287, 1394960 Sponsored by: Dell EMC
Notes
Notes: svn path=/head/; revision=337812
Diffstat (limited to 'sys/dev')
-rw-r--r--sys/dev/netmap/netmap_freebsd.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/dev/netmap/netmap_freebsd.c b/sys/dev/netmap/netmap_freebsd.c
index f4a97b370f68..b2882768297b 100644
--- a/sys/dev/netmap/netmap_freebsd.c
+++ b/sys/dev/netmap/netmap_freebsd.c
@@ -1498,7 +1498,7 @@ netmap_kqfilter(struct cdev *dev, struct knote *kn)
kn->kn_fop = (ev == EVFILT_WRITE) ?
&netmap_wfiltops : &netmap_rfiltops;
kn->kn_hook = priv;
- knlist_add(&si->si.si_note, kn, 1);
+ knlist_add(&si->si.si_note, kn, 0);
// XXX unlock(priv)
ND("register %p %s td %p priv %p kn %p np_nifp %p kn_fp/fpop %s",
na, na->ifp->if_xname, curthread, priv, kn,