diff options
| author | Jeffrey Hsu <hsu@FreeBSD.org> | 2003-02-15 02:37:57 +0000 |
|---|---|---|
| committer | Jeffrey Hsu <hsu@FreeBSD.org> | 2003-02-15 02:37:57 +0000 |
| commit | 4b40c56c28f672ba1cde3a8764655ced1edd0333 (patch) | |
| tree | 26fbf367f08970d5dc04f53922342ae379ba2006 /sys/netinet/udp_usrreq.c | |
| parent | 292dd8a87fab114f1a8e6861bd847d60b63dc7c6 (diff) | |
| download | src-4b40c56c28f672ba1cde3a8764655ced1edd0333.tar.gz src-4b40c56c28f672ba1cde3a8764655ced1edd0333.zip | |
Take advantage of pre-existing lock-free synchronization and type stable memory
to avoid acquiring SMP locks during expensive copyout process.
Notes
Notes:
svn path=/head/; revision=110896
Diffstat (limited to 'sys/netinet/udp_usrreq.c')
| -rw-r--r-- | sys/netinet/udp_usrreq.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/sys/netinet/udp_usrreq.c b/sys/netinet/udp_usrreq.c index 4331770ab001..7d2a9f37a8af 100644 --- a/sys/netinet/udp_usrreq.c +++ b/sys/netinet/udp_usrreq.c @@ -531,7 +531,7 @@ udp_ctlinput(cmd, sa, vip) ip->ip_src, uh->uh_sport, 0, NULL); if (inp != NULL) { INP_LOCK(inp); - if(inp->inp_socket != NULL) { + if (inp->inp_socket != NULL) { (*notify)(inp, inetctlerrmap[cmd]); } INP_UNLOCK(inp); @@ -568,8 +568,10 @@ udp_pcblist(SYSCTL_HANDLER_ARGS) * OK, now we're committed to doing something. */ s = splnet(); + INP_INFO_RLOCK(&udbinfo); gencnt = udbinfo.ipi_gencnt; n = udbinfo.ipi_count; + INP_INFO_RUNLOCK(&udbinfo); splx(s); sysctl_wire_old_buffer(req, 2 * (sizeof xig) @@ -604,7 +606,6 @@ udp_pcblist(SYSCTL_HANDLER_ARGS) error = 0; for (i = 0; i < n; i++) { inp = inp_list[i]; - INP_LOCK(inp); if (inp->inp_gencnt <= gencnt) { struct xinpcb xi; xi.xi_len = sizeof xi; @@ -612,9 +613,9 @@ udp_pcblist(SYSCTL_HANDLER_ARGS) bcopy(inp, &xi.xi_inp, sizeof *inp); if (inp->inp_socket) sotoxsocket(inp->inp_socket, &xi.xi_socket); + xi.xi_inp.inp_gencnt = inp->inp_gencnt; error = SYSCTL_OUT(req, &xi, sizeof xi); } - INP_UNLOCK(inp); } if (!error) { /* |