diff options
| author | Conrad Meyer <cem@FreeBSD.org> | 2017-04-13 17:47:44 +0000 |
|---|---|---|
| committer | Conrad Meyer <cem@FreeBSD.org> | 2017-04-13 17:47:44 +0000 |
| commit | bcd8d3b80510a291f3fcbe47e3851d323bd4ee1c (patch) | |
| tree | 667fb6fe4ae7bd9fa9ef4cfe895f51ee31af8b27 /sys/netpfil/ipfw/dn_aqm_pie.c | |
| parent | c6943f3abced25dfa1ea85bf2edbad8803111237 (diff) | |
| download | src-bcd8d3b80510a291f3fcbe47e3851d323bd4ee1c.tar.gz src-bcd8d3b80510a291f3fcbe47e3851d323bd4ee1c.zip | |
dummynet: Use strlcpy to appease static checkers
Some dummynet modules used strcpy() to copy from a larger buffer
(dn_aqm->name) to a smaller buffer (dn_extra_parms->name). It happens that
the lengths of the strings in the dn_aqm buffers were always hardcoded to be
smaller than the dn_extra_parms buffer ("CODEL", "PIE").
Use strlcpy() instead, to appease static checkers. No functional change.
Reported by: Coverity
CIDs: 1356163, 1356165
Sponsored by: Dell EMC Isilon
Notes
Notes:
svn path=/head/; revision=316777
Diffstat (limited to 'sys/netpfil/ipfw/dn_aqm_pie.c')
| -rw-r--r-- | sys/netpfil/ipfw/dn_aqm_pie.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/netpfil/ipfw/dn_aqm_pie.c b/sys/netpfil/ipfw/dn_aqm_pie.c index c2e4d43ca458..85062e258c9e 100644 --- a/sys/netpfil/ipfw/dn_aqm_pie.c +++ b/sys/netpfil/ipfw/dn_aqm_pie.c @@ -755,7 +755,7 @@ aqm_pie_getconfig (struct dn_fsk *fs, struct dn_extra_parms * ep) { struct dn_aqm_pie_parms *pcfg; if (fs->aqmcfg) { - strcpy(ep->name, pie_desc.name); + strlcpy(ep->name, pie_desc.name, sizeof(ep->name)); pcfg = fs->aqmcfg; ep->par[0] = pcfg->qdelay_ref / AQM_TIME_1US; ep->par[1] = pcfg->tupdate / AQM_TIME_1US; |