aboutsummaryrefslogtreecommitdiff
path: root/sys/vm/vm_fault.c
diff options
context:
space:
mode:
authorKonstantin Belousov <kib@FreeBSD.org>2009-07-03 22:17:37 +0000
committerKonstantin Belousov <kib@FreeBSD.org>2009-07-03 22:17:37 +0000
commit121fd461755428142f50c1d1d574c0291b00120c (patch)
tree90fec0503ef96a4f2264eedd1ad62f2525a5c443 /sys/vm/vm_fault.c
parent9e760f2578249fbdffff2bc90b86f16b2f6b8f69 (diff)
downloadsrc-121fd461755428142f50c1d1d574c0291b00120c.tar.gz
src-121fd461755428142f50c1d1d574c0291b00120c.zip
When forking a vm space that has wired map entries, do not forget to
charge the objects created by vm_fault_copy_entry. The object charge was set, but reserve not incremented. Reported by: Greg Rivers <gcr+freebsd-current tharned org> Reviewed by: alc (previous version) Approved by: re (kensmith)
Notes
Notes: svn path=/head/; revision=195329
Diffstat (limited to 'sys/vm/vm_fault.c')
-rw-r--r--sys/vm/vm_fault.c21
1 files changed, 11 insertions, 10 deletions
diff --git a/sys/vm/vm_fault.c b/sys/vm/vm_fault.c
index 43743f494f02..ff8852b1a9a9 100644
--- a/sys/vm/vm_fault.c
+++ b/sys/vm/vm_fault.c
@@ -1126,11 +1126,9 @@ vm_fault_unwire(vm_map_t map, vm_offset_t start, vm_offset_t end,
* entry corresponding to a main map entry that is wired down).
*/
void
-vm_fault_copy_entry(dst_map, src_map, dst_entry, src_entry)
- vm_map_t dst_map;
- vm_map_t src_map;
- vm_map_entry_t dst_entry;
- vm_map_entry_t src_entry;
+vm_fault_copy_entry(vm_map_t dst_map, vm_map_t src_map,
+ vm_map_entry_t dst_entry, vm_map_entry_t src_entry,
+ vm_ooffset_t *fork_charge)
{
vm_object_t backing_object, dst_object, object;
vm_object_t src_object;
@@ -1161,13 +1159,16 @@ vm_fault_copy_entry(dst_map, src_map, dst_entry, src_entry)
#endif
VM_OBJECT_LOCK(dst_object);
+ KASSERT(dst_entry->object.vm_object == NULL,
+ ("vm_fault_copy_entry: vm_object not NULL"));
dst_entry->object.vm_object = dst_object;
dst_entry->offset = 0;
- if (dst_entry->uip != NULL) {
- dst_object->uip = dst_entry->uip;
- dst_object->charge = dst_entry->end - dst_entry->start;
- dst_entry->uip = NULL;
- }
+ dst_object->uip = curthread->td_ucred->cr_ruidinfo;
+ uihold(dst_object->uip);
+ dst_object->charge = dst_entry->end - dst_entry->start;
+ KASSERT(dst_entry->uip == NULL,
+ ("vm_fault_copy_entry: leaked swp charge"));
+ *fork_charge += dst_object->charge;
prot = dst_entry->max_protection;
/*