netlink: allow creating sockets with SOCK_DGRAM.

Some existing applications setup Netlink socket with
SOCK_DGRAM instead of SOCK_RAW. Update the manpage to clarify
that the default way of creating the socket should be with
SOCK_RAW. Update the code to support both SOCK_RAW and SOCK_DGRAM.

Reviewed By: pauamma
Differential Revision: https://reviews.freebsd.org/D38075

2 files changed, 34 insertions, 0 deletions

diff --git a/tests/sys/netlink/Makefile b/tests/sys/netlink/Makefile
index 87cee15c9d33..880e5e6e4007 100644
--- a/tests/sys/netlink/Makefile
+++ b/tests/sys/netlink/Makefile
@@ -6,6 +6,7 @@ WARNS?=		1
 TESTSDIR=       ${TESTSBASE}/sys/netlink
 
 ATF_TESTS_C +=	test_snl
+ATF_TESTS_PYTEST +=	test_nl_core.py
 ATF_TESTS_PYTEST +=	test_rtnl_iface.py
 ATF_TESTS_PYTEST +=	test_rtnl_ifaddr.py
 
diff --git a/tests/sys/netlink/test_nl_core.py b/tests/sys/netlink/test_nl_core.py
new file mode 100644
index 000000000000..7af421a929dc
--- /dev/null
+++ b/tests/sys/netlink/test_nl_core.py
@@ -0,0 +1,33 @@
+import errno
+import socket
+
+import pytest
+from atf_python.sys.net.netlink import NetlinkTestTemplate
+from atf_python.sys.net.netlink import NlConst
+from atf_python.sys.net.vnet import SingleVnetTestTemplate
+
+
+class TestNlCore(NetlinkTestTemplate, SingleVnetTestTemplate):
+    @pytest.mark.parametrize(
+        "params",
+        [
+            pytest.param({"type": socket.SOCK_RAW}, id="SOCK_RAW"),
+            pytest.param({"type": socket.SOCK_DGRAM}, id="SOCK_DGRAM"),
+        ],
+    )
+    def test_socket_type(self, params):
+        s = socket.socket(NlConst.AF_NETLINK, params["type"], NlConst.NETLINK_ROUTE)
+        s.close()
+
+    @pytest.mark.parametrize(
+        "params",
+        [
+            pytest.param({"type": socket.SOCK_STREAM}, id="SOCK_STREAM"),
+            pytest.param({"type": socket.SOCK_RDM}, id="SOCK_RDM"),
+            pytest.param({"type": socket.SOCK_SEQPACKET}, id="SOCK_SEQPACKET"),
+        ],
+    )
+    def test_socket_type_unsup(self, params):
+        with pytest.raises(OSError) as exc_info:
+            socket.socket(NlConst.AF_NETLINK, params["type"], NlConst.NETLINK_ROUTE)
+        assert exc_info.value.errno == errno.EPROTOTYPE