diff options
| author | Ayrton Munoz <a.munoz3327@gmail.com> | 2026-10-22 16:40:50 +0000 |
|---|---|---|
| committer | Kyle Evans <kevans@FreeBSD.org> | 2026-10-22 16:40:50 +0000 |
| commit | 775e421dc38f18fa6b7fdc7b214a013cca44b58b (patch) | |
| tree | 6677cf0032655b0a11aa83e73d2ee879fd6d7711 /usr.sbin/config/configvers.h | |
| parent | 3200a274272d28cf6d2385a8ea46959f313866de (diff) | |
makeobjops.awk only accepts an uppercase DEFAULT before a default kobj
method. This commit fixes a typo introduced in 949804c81909 so non-PCI
drivers actually use nvme_is_storage_device_default instead of
kobj_error_method. Note that even though kobj_error_method returns
ENXIO (6), it does not get implicitly cast to a bool due to the function
pointer casting in the nvme_if.h generated by makeobjops. Instead the
codegen for the NVME_IS_STORAGE_DEVICE callsite shows that only the
lowest bit is being checked as if it were always a bool. Without this
any nvme driver that doesn't implement is_storage_device is not treated
as a storage device.
Reviewed by: imp, kevans
Differential Revision: https://reviews.freebsd.org/D60112
Diffstat (limited to 'usr.sbin/config/configvers.h')
0 files changed, 0 insertions, 0 deletions
