diff options
author | Jamie Gritton <jamie@FreeBSD.org> | 2012-02-08 23:51:46 +0000 |
---|---|---|
committer | Jamie Gritton <jamie@FreeBSD.org> | 2012-02-08 23:51:46 +0000 |
commit | 1ca35de4489bdbc57e65274bea3ecce32c8cd496 (patch) | |
tree | ab97c1c8fcd8613191432f5b22d123b1306595ff /usr.sbin/jail/command.c | |
parent | 7ca65ae0fe0b3e2c7b3cd618ae7599f158a5e771 (diff) | |
download | src-1ca35de4489bdbc57e65274bea3ecce32c8cd496.tar.gz src-1ca35de4489bdbc57e65274bea3ecce32c8cd496.zip |
Improvements in error messages:
Some errors printed the jail name for unnamed (command line) jails.
Attempting to create an already-existing jail from the command line
returned with no error (even for non-root) due to bad logic in
start_state.
Ignore kvm_proc errors, which are typically caused by permission
problems. Instead, stop ignoring permission errors when removing
a jail (but continue to silently ignore other errors, i.e. the
jail no longer existing). This makes non-root attempts at removing
a jail give a clearer error message.
Notes
Notes:
svn path=/projects/jailconf/; revision=231238
Diffstat (limited to 'usr.sbin/jail/command.c')
-rw-r--r-- | usr.sbin/jail/command.c | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/usr.sbin/jail/command.c b/usr.sbin/jail/command.c index 774cac34b11e..10ff3e2442e0 100644 --- a/usr.sbin/jail/command.c +++ b/usr.sbin/jail/command.c @@ -274,7 +274,11 @@ run_command(struct cfjail *j) case IP__OP: if (down) { - (void)jail_remove(j->jid); + if (jail_remove(j->jid) < 0 && errno == EPERM) { + jail_warnx(j, "jail_remove: %s", + strerror(errno)); + return -1; + } if (verbose > 0 || (verbose == 0 && (j->flags & JF_STOP ? note_remove : j->name != NULL))) jail_note(j, "removed\n"); @@ -711,14 +715,14 @@ term_procs(struct cfjail *j) return 0; if (kd == NULL) { - kd = kvm_open(NULL, NULL, NULL, O_RDONLY, "jail"); + kd = kvm_open(NULL, NULL, NULL, O_RDONLY, NULL); if (kd == NULL) - exit(1); + return 0; } ki = kvm_getprocs(kd, KERN_PROC_PROC, 0, &pcnt); if (ki == NULL) - exit(1); + return 0; noted = 0; for (i = 0; i < pcnt; i++) if (ki[i].ki_jid == j->jid && |