diff options
157 files changed, 22912 insertions, 10986 deletions
diff --git a/contrib/amd/AUTHORS b/contrib/amd/AUTHORS index 4cc9b9f1a4e9..3c241d016bb9 100644 --- a/contrib/amd/AUTHORS +++ b/contrib/amd/AUTHORS @@ -12,6 +12,11 @@ The most significant changes were made by Erez Zadok in terms of bug fixes, ports, and new features added. Erez Zadok is the current maintainer of am-utils, as of January 1997. +* Ion Badulescu <ion@cs.columbia.edu> + +Co-maintainer of am-utils since late 1999: Linux and Solaris autofs support, +Linux NFSv3 support, major code reorganization, etc... + * Randall S. Winchester <rsw@glue.umd.edu> May 7, 1997: contributed a special version of upl102 that included NFS V.3 @@ -154,7 +159,7 @@ that do not allow forwarding of RPC messages to other services. August 10, 1997: netbsd and other bsd systems have a mask flag for pcfs_args (msdos mount). -* Christos Zoulas <christos@deshaw.com> +* Christos Zoulas <christos@zoulas.com> September 25, 1997: fix to initialize uid/gid fields of pcfs_args_t on netbsd. @@ -163,9 +168,19 @@ October 10, 1997: compile time cleanups of printf()s in hlfsd code. If nfs server is down or does not support a portmapper call, then mark it down as version 2, and try again later. +November 29, 2002: compile fixes for NetBSD, a couple of bug fixes (one +already fixed by maintainers) + April 12, 2003: support new "unmount" option, useful to timeout removable local media mounts. +October 12, 2004: patch to support two new amd.conf options, domain_strip +and auto_attrcache. Patch to cleanup NFS attribute-cache flag computation. +Patch to fix an inconsistency in timeouts in the RPC code between socket and +TLI implementations. Patch to print version string (amd -v) after all +options had been initialized, so we can print domain, host, and hostd. +Linux patch to use umount2(2) if umount(2) fails. + * Bill Paul <wpaul@ctr.columbia.edu> November 5, 1997: NFS v.3 support for AIX 4.2.1, which does *not* include @@ -191,6 +206,8 @@ and proto. January 12, 1998: minor bug in output of amd -H. +June 23, 2005: assortment of small compile bugs on aix4, and solaris 5/6/7. + * Thomas Richter <richter@chemie.fu-berlin.de> January 13, 1998: use case insensitive comparisons for variables that need @@ -302,9 +319,13 @@ January 25, 2000: allow browsable auto maps. * Wolfram Klaus <klaus@physik.fu-berlin.de>. November 21, 2000: recognize proplist mnttab flag. -* Thomas Klausner <wiz@danbala.ifoer.tuwien.ac.at> +* Thomas Klausner <tk@giga.or.at> November 21, 2000: lots of NetBSD fixes (many of which are generic). +April 18, 2003: patch to reference am-utils info pages in man page. + +November 28, 2004: small fixes to typos in amd.conf(5) man page. + * Olaf Kirch <okir@caldera.de> February 1, 2001: important Linux NFS error number mapping fixed @@ -318,20 +339,92 @@ March 27, 2002: LDAP bug and port to HPUX-11. * Philippe Troin <phil@fifi.org> July 12, 2001: Proper handling of GNU getopt, support for optionally -disabling LDAP/Hesiod, fixes for the dev/nodev option on Linux +disabling LDAP/Hesiod, fixes for the dev/nodev option on Linux. Texi +documentation fix. November 28, 2001: Bug fix. Support "nolock" as an NFS option, not a generic mount option. -July 17, 2003: Debian fixes. Null am_pref free. +July 17, 2003: pref:=null core dump fix. libgdbm portability. tcpd/librap +support. And a few other things for the 6.0 branch. * Trond Myklebust <trond.myklebust@fys.uio.no> January 10, 2002: Proper initialization of the timeo parameter on Linux, TCP _must_ have a timeout 2 orders of magnitude larger than UDP +* George Ross <gdmr@dcs.ed.ac.uk> +April 29, 2002: Rework of old code, support for wildcards in LDAP queries, +and an FD leak fix. Amd -A support. + +October 21, 2002: ldap_unbind fix for SIGPIPE, and support for LDAPv3 +protocol version parameter (with Tim Colles <timc@inf.ed.ac.uk>). + +* Matthias Scheler <tron@zhadum.de> +June 14, 2002: patch to use "xlatecookie" NFS mount option. + +* Jun-ichiro itojun Hagino <itojun@iijlab.net>. +June 11, 2002: minor fixes to support NetBSD 1.6A. + * Sean Fagan <sef@apple.com> March 14, 2003: detect and use the MNT2_GEN_OPT_AUTOMNTFS mount flag on OS X / Darwin. * Hendrik Scholz <hscholz@raisdorf.net> June 9, 2003: mk-amd-map should open temp db file using O_EXCL. + +* Mark Davies <mark@mcs.vuw.ac.nz> +July 14, 2003: define "xlatecookie" mnttab option if not defined (for +NetBSD). Support null hesiod entries if they start with a ".". + +* Eric S. Raymond <esr@thyrsus.com> +December 9, 2003: fix unbalanced [] typo in fsinfo man page. + +* Martin Blapp <mb@imp.ch> +July 6, 2004: recognize fields in pcfs_args_t in FreeBSD 5. + +* Dan Nelson <dnelson@allantgroup.com> +August 2, 2004: pawd to recognize "host" type mounts. + +* Hauke Fath <hauke@Espresso.Rhein-Neckar.DE> +August 3, 2004: pawd to recognize "linkx" type mounts. + +* Michael van Elst <M.van.Elst@science-computing.de> +September 1, 2004: bug fix to avoid race condition in calls to mntctl on +AIX. + +* Jonathan Chen <jon+amd@spock.org> +October 22, 2004: patch/fix to move mlock/mlockall/plock code after the +fork(). +June 29, 2005: core dump going off end of exported_ap[] array. +September 29, 2005: patch/fix for pawd not to go into an infinite loop. +October 25, 2005: patch/fix for pawd to repeatedly resolve path. + +* David Rage <rage@ucl.ac.uk> +January 17, 2005: prevent Amd from logging 'Read-only filesystem' errors +when the mount point has an ancestor (i.e. '/') that is mounted read-only. + +* Kevin Layer <layer@franz.com> +January 28, 2005: basic instructions how to setup Amd on Mac OS-X. + +* Dan Ottavio <dottavio@ic.sunysb.edu> +March 2, 2005: new global amd.conf option debug_mtab_file, to set the debug +mtab file when using debug_options=mtab. Default has changed from "./mtab" +to "/tmp/mtab" to avoid security problem. Bug fixed to ensure that Amd +terminates properly even mtab file doesn't exist. + +* Erik Kline <ekline at ekline dot com> +January 3, 2005: implementation of executable maps for Amd. + +* Jim Zajkowski <jim.zajkowski@gmail.com> +March 14, 2005: small patch to amd2ldif. + +* Adam Morley <adam at gmi dot com> +January 27, 2005: synchronize what amd2ldif does vs. what the ldap.schema +expects. + +* Graeme Wilford <G.Wilford@surrey.ac.uk> +July 4, 2005: buffer overflow in pawd. + +* Steve Plite <splite-amutils@sigint.cs.purdue.edu> +September 22, 2005: repair reversed meaning of D_AMQ, so amq will unregister +on exit. diff --git a/contrib/amd/BUGS b/contrib/amd/BUGS index fd52779d8c9e..3a3ba6b367d4 100644 --- a/contrib/amd/BUGS +++ b/contrib/amd/BUGS @@ -1,5 +1,8 @@ LIST OF KNOWN BUGS IN AM-UTILS OR OPERATING SYSTEMS +Note: report am-utils bugs via Bugzilla to https://bugzilla.am-utils.org/ or +by email to the am-utils@am-utils.org mailing list. + (1) mips-sgi-irix* @@ -163,12 +166,15 @@ kernel will panic. The Linux kernels don't support Amd's direct mounts very well, leading to erratic behavior: shares that don't get remounted after the first timeout, -inability to restart Amd because its mount points cannot be unmounted, -etc. There are some kernel patches on the am-utils Web site, which solve -these problems. See http://www.am-utils.org/patches/. +inability to restart Amd because its mount points cannot be unmounted, etc. +There are some kernel patches on the am-utils Web site, which solve these +problems. See http://www.am-utils.org/patches/. + +Later 2.4.x kernels completely disallow the hack amd was using for direct +mounts, so another solution will have to be found. -UPDATE: kernels 2.4.10 and later completely disallow the direct mount hack, -so direct mounts are simply not possible on those Linux kernels. +Note: the above is for the old-style amd mount_type = nfs. The autofs mounts +don't support direct mounts at all (due to lack of kernel support). (12) *-aix5.1.0.0 and *-hpux9* @@ -177,14 +183,24 @@ to use /bin/ksh instead. The buildall script will do it for you; if for some reason you need to run configure directly, run it using 'ksh configure' instead of just 'configure'. -[12A] *-aix5.1.* +[12A] *-aix5.2.* Apparently there is an NFS client side bug in vmount() which causes amd to hang when it starts (and tries to NFS-mount itself). According to IBM engineers, this has to do with partial support code for IPv6: the NFS kernel code doesn't appear to recognize the sin_family of the amd vmount(), -although amd does the right thing. The bug appears to have been fixed in -AIX 5.2. No known fix/patch is available for AIX 5.1 as of now (1/25/2003). +although amd does the right thing. The bug doesn't appear to be in 5.1 or +4.3.3. A fix from IBM is available, APAR number IY41417. + +A binary built on 4.3.3 will not work on 5.2, because the kernel ABIs have +changed. + +[12C] *-aix* + +It is important that you install bos.net.nfs.adt before configuring and +building am-utils. If you don't, you will get compile-time or +configure-time errors, especially when configure tries to find AIX's +definition of struct nfs_args. (13) *-linux and *-darwin6.0 @@ -201,6 +217,87 @@ default). Nonetheless, if a TCP connection breaks, under certain unclear circumstances the kernel might "forget" about that flag and start using unprivileged ports, causing the same EPERM error above. +(14) Solaris + +The line "%option" in *.l files may cause Solaris /usr/ccs/bin/lex to abort +with the error "missing translation value." This is a bug in Solaris lex. + +Moreover, both Solaris yacc and lex produce code that does not pass strict +compilation such as "gcc -Wall -Werror". + +Use GNU Flex and Bison instead. You can download ready-made binaries from +www.sunfreeware.com. Note, however, that sometimes the binaries on +sunfreeware.com don't seem to work, often because they are built against an +older revision of Solaris or build tools. In that case, build a fresh +version of GNU flex and/or bison from the latest stable sources. See +http://www.gnu.org/software/flex/ and http://www.gnu.org/software/bison/. + +(15) Solaris 8 + patch 10899[34]-xx (18 <= xx < 25) or patch 11260[56]-xx + +With this patch, Sun updated the autofs kernel module and automountd +userspace daemon from version 3 to version 4. They also updated the +/usr/include/rpcsvc/autofs_prot.x file, but forgot to regenerate the +autofs_prot.h file. Thus, when amd is compiled, it uses the old header and +thinks it should use autofs version 3, when in fact the kernel now supports +(and expects) only version 4. + +The workaround is to run 'rpcgen -C -h /usr/include/rpcsvc/autofs_prot.x > +/usr/include/rpcsvc/autofs_prot.h' and completely reconfigure and rebuild +am-utils (removing config.cache before running configure). + +The problem is fixed in patch revisions 10899[34]-25 and up. + + +(16) Linux kernel 2.4+ and lofs mounts + +Lofs mounts are not supported by the linux kernel, at all, but since 2.4.0 +the kernel supports a similar type of mount called a bind mount. Its +semantics are closer to those of a hardlink than to those of lofs, and one +of the results is that bind mounts ignore any mount options paseed to them. + +Amd uses bind mounts internally to emulate lofs mounts, which means that +lofs mounts on linux will effectively ignore their mount parameters and +inherit whatever options the original filesystem mounted upon had. + + +(17) autoconf 2.57 + +If you see configure warnings of the following kind: + +configure: WARNING: sys/proc.h: present but cannot be compiled +configure: WARNING: sys/proc.h: check for missing prerequisite headers? +configure: WARNING: sys/proc.h: proceeding with the preprocessor's result +configure: WARNING: ## ------------------------------------ ## +configure: WARNING: ## Report this to bug-autoconf@gnu.org. ## +configure: WARNING: ## ------------------------------------ ## + +please ignore them. They are not real errors, and neither +bug-autoconf@gnu.org nor the am-utils maintainers are interested in hearing +about them. Autoconf simply tries to do more than we need and attempts to +compile each header in isolation, which fails for many system headers. +That's ok, because we only need to know if a header file exists -- we know +how to use it properly ourselves. + +While autoconf does offer a way to specify other files to be included with +the tested header, in order to avoid these warnings, using it would enlarge +the resulting configure script by an order of magnitude, and for no real +gain. Configure is big enough as it is, we don't need any more useless +baggage in it. + +(18) NetBSD 2.0.2, FreeBSD 5.4, OpenBSD 3.7, and quite possibly most other + BSDs and other OSs (as of September 2005) -Erez & Ion. +Some BSD kernels don't have a way to turn off the NFS attribute cache. They +don't have a 'noac' mount flag, and setting various cache timeout fields in +struct nfs_args doesn't turn off the attribute cache; instead, it sets the +attribute cache timeout to some internal hard-coded default (usually +anywhere from 5-30 seconds). If Amd cannot turn off the NFS attribute +cache, under heavy Amd usage, users could get ESTALE errors from automounted +symlinks, or find that those symlinks point to the wrong place. One +workaround which would minimize this effect is to set auto_attrcache=1 in +your amd.conf, but it doesn't eliminate the problem! The best solutions are +(1) to use Amd in Autofs mode, if it's supported in your OS, and (2) talk to +your OS vendor to support a true "noac" flag. See README.attrcache for more +details. +Erez & the am-utils team. diff --git a/contrib/amd/COPYING b/contrib/amd/COPYING index 24476dc841ea..035f6239c935 100644 --- a/contrib/amd/COPYING +++ b/contrib/amd/COPYING @@ -1,4 +1,4 @@ -Copyright (c) 1997-2004 Erez Zadok +Copyright (c) 1997-2006 Erez Zadok Copyright (c) 1989 Jan-Simon Pendry Copyright (c) 1989 Imperial College of Science, Technology & Medicine Copyright (c) 1989 The Regents of the University of California. diff --git a/contrib/amd/ChangeLog b/contrib/amd/ChangeLog index 329629fbbd20..12f2c5fb8e65 100644 --- a/contrib/amd/ChangeLog +++ b/contrib/amd/ChangeLog @@ -1,29 +1,2595 @@ -2004-05-12 Erez Zadok <ezk@cs.sunysb.edu> +2006-05-11 Erez Zadok <ezk@cs.sunysb.edu> - * m4/macros/check_map_funcs.m4: imported bug-fixed version from - 6.1 branch. + ******************************************************************* + *** Released am-utils-6.1.5 *** + ******************************************************************* - * config.guess, config.sub, ltmain.sh: updates from the latest GNU - distributions. +2006-05-10 Erez Zadok <ezk@cs.sunysb.edu> + + * Minor new ports: i386-unknown-freebsd6.1 (RELEASE) + powerpc-apple-darwin8.6.0, and i386-unknown-openbsd3.9. + + * libamu/mount_fs.c (compute_nfs_attrcache_flags): fix signedness + problems on IRIX-6.5. + + * conf/autofs/autofs_solaris_v1.c (xdr_umntrequest): fix + signedness problems on IRIX-6.5. + +2006-05-01 Erez Zadok <ezk@cs.sunysb.edu> + + * configure.in: check if libc already includes dbm functionality + (as in FreeBSD 6), then don't bother to check specific libraries + such as libdbm, gdbm, etc. + +2006-04-21 Erez Zadok <ezk@cs.sunysb.edu> + + * configure.in: detect G/DBM support via gdbm_compat library + (Debian 3.1). + + * minor new port: powerpc-apple-darwin8.5.0 + +2006-04-20 Erez Zadok <ezk@cs.sunysb.edu> + + * scripts/amd.conf-sample, scripts/amd.conf.5, doc/am-utils.texi, + NEWS: document new nfs_allow_any_interface parameter. + + * include/am_compat.h (INADDR_LOOPBACK): define INADDR_LOOPBACK if + not defined, since some systems don't have it. + +2006-04-20 Nick Williams <Nick.Williams@morganstanley.com> + + * libamu/wire.c (is_interface_local): new boolena function to + determine if address represents any of the local interfaces. + (getwire): more properly check if address equals INADDR_LOOPBACK, + not if IFF_LOOPBACK is not (the latter isn't as correct). + + * include/am_utils.h: extern for new is_interface_local() function. + + * conf/transp/transp_{sockets,tli}.c: don't define INADDR_LOOPBACK + here but in am_compat.h + + * amd/nfs_prot_svc.c (nfs_program_2): if + nfs_allow_any_interface=yes, then allow NFS packets from any local + interface (not just 127.0.0.1). + + * amd/conf.c (gopt_nfs_allow_any_interface): implement the new + amd.conf parameter nfs_allow_any_interface. + + * amd/amd.h (CFM_NFS_ANY_INTERFACE): define new global flag when + al interfaces are acceptable for local NFS packets. + +2006-04-18 Christos Zoulas <christos@zoulas.com> + + * amd/opts.c: Add support for optionally specifying the hostname + to match against the netgroup in the netgrp and netgrpd selectors. + +2006-04-16 Erez Zadok <ezk@cs.sunysb.edu> + + * libamu/mtab.c (hasmntval): fix inverted meaning of error from + hasmntvalerr(). + +2006-04-14 Erez Zadok <ezk@cs.sunysb.edu> + + * libamu/mount_fs.c (compute_nfs_attrcache_flags): use new + hasmntvalerr() function to set attribute cache values only if they + were set (regardless whether they were set to zero or a non-zero + value). Before, we were unable to distinguish between an error to + parse an option, and a user who actually wanted to set an + attribute-cache value to 0. This now fixes an important + performance bug that Amd was turning off the attribute caches even + for regular (non-automounter) NFS mounts. + + * libamu/mtab.c (hasmntvalerr): new function to set the value of + an option into an integer, but ONLY if that options was set and + parsed correctly. This function returns 1 on error, 0 on success + (instead of always setting the option value to 0). + (hasmntval): wrapper function around hasmntvalerr, which maintains + backwards compatibility (always sets option value to 0, even on + error to parse the option). + + * amd/nfs_subr.c (fh_to_mp3): use long int printf format for + fhh_pid. + +2006-04-05 Christos Zoulas <christos@zoulas.com> + + * amd/amfs_generic.c (amfs_lookup_mntfs): fix use-after-free bug + (Coverity). + +2006-03-27 Erez Zadok <ezk@cs.sunysb.edu> + + * doc/am-utils.texi, scripts/{amd.conf.5,amd.conf-sample}: + document new nfs_retransmit_counter_toplvl and + nfs_retry_interval_toplvl global amd.conf parameters. + + * amd/conf.c (gopt_nfs_retransmit_counter_toplvl, + (gopt_nfs_retry_interval_toplvl): parse amd.conf + nfs_retransmit_counter_toplvl and nfs_retry_interval_toplvl global + parameters. + + * amd/amfs_toplvl.c (amfs_toplvl_mount): support setting toplvl + timeo/retrans parameters for Amd's toplvl mounts, separately from + all other UDP or NFS mounts. + + * amd/amd.h: define a new timeo/retrans parameter for toplvl + mounts. + +2006-03-22 Erez Zadok <ezk@cs.sunysb.edu> + + * minor new port: i386-pc-linux-suse10.1 (beta 8). + +2006-03-21 Christos Zoulas <christos@zoulas.com> + + * amd/am_ops.c (merge_opts): Remove useless check found by + Coverity; xmalloc never returns NULL. + +2006-03-21 Erez Zadok <ezk@cs.sunysb.edu> + + * minor new ports: i386-pc-linux-fc5. + + * amd/info_ldap.c: as of Linux Fedora Core 5 (which comes with + openldap-2.3.9), the ldap.h headers deprecate several functions + used in this file, such as ldap_unbind. You get compile errors + about missing extern definitions. Those externs are still in + <ldap.h>, but surrounded by an ifdef LDAP_DEPRECATED. I am + turning on that ifdef at the top of info_ldap.c, under the + assumption that the functions may be deprecated, but they still + work for this (older?) version of the LDAP API. It gets am-utils + to compile, but it is not clear if it will work perfectly. + + * libamu/xdr_func.c (xdr_am_mountres3_ok), amq/amq_xdr.c + (xdr_amq_mount_tree, xdr_amq_mount_tree_p, + xdr_amq_mount_info_list, xdr_amq_mount_tree_list), amq/amq.c + (show_mti), amd/amq_subr.c (xdr_amq_setopt, xdr_amq_mount_subtree, + xdr_amq_mount_tree, xdr_amq_mount_tree_list, xdr_amq_mount_tree), + libamu/xdr_func.c (xdr_am_mountres3_ok): use casing magic to stop + GCC-4.1 from complaining about "dereferencing type-punned pointer + will break strict-aliasing rules" here (but not elsewhere). + +2006-03-20 Christos Zoulas <christos@zoulas.com> + + * libamu/wire.c: avoid potential dereferencing of a NULL pointer + (Coverity). + + * hlfsd/homedir.c (delay): remove unnecessary check for NULL + pointer (Coverity). + + * fsinfo/fsi_analyze.c (analyze_dkmounts, analyze_mounts, + analyze_mounts): avoid potential dereferencing of a NULL pointer + (Coverity). + + * conf/transp/transp_sockets.c (create_amq_service): avoid + potential dereferencing of a NULL pointer (Coverity). + + * amd/sched.c (sigchld): properly check for the end of the waiting + process list (Coverity). + + * amd/mapc.c (mapc_create): initialize 'modify' to zero (Coverity). + + * amd/autil.c (amfs_mkcacheref, am_unmounted): avoid potential + dereferencing of a NULL pointer (Coverity). + + * amd/amfs_generic.c (amfs_lookup_mntfs): free def_opts before + reusing it (memory leak bug detected by Coverity). + (amfs_bgmount): avoid potential dereferencing of a NULL pointer + (Coverity). + + * amd/am_ops.c (merge_opts): no need to check if newstr is NULL + (bug detected by Coverity). + +2006-03-08 Ion Badulescu <ionut@moisil.badula.org> + + * amd/nfs_subr.c (mp_to_fh): fixed old-style filehandles--the pid + comparison was failing. + +2006-03-08 Erez Zadok <ezk@cs.sunysb.edu> + + * configure.in: properly test for either <gdbm/ndbm.h> or + <gdbm-ndbm.h> (unfortunately, Autoconf will map both names to the + same $ac_cv_* variable name). Some systems support one header or + another. Patch inspired by work Debian did. + +2006-02-10 Erez Zadok <ezk@cs.sunysb.edu> + + ******************************************************************* + *** Released am-utils-6.1.4 *** + ******************************************************************* + +2006-01-04 Erez Zadok <ezk@cs.sunysb.edu> + + * doc/am-utils.texi (auto_attrcache Parameter): revise discussion + to mention pros and cons of turning on/off this parameter, + including impact on Amd's performance, and ways to improve + performance while minimizing the window of vulnerability in which + kernel may return the wrong (cached) attributes. + +2006-01-02 Erez Zadok <ezk@cs.sunysb.edu> + + * updated copyright year to 2006 on all files. + +2005-12-20 Erez Zadok <ezk@cs.sunysb.edu> + + * include/am_utils.h, conf/transp/transp_tli.c (amu_svc_register, + register_autofs_service): use a consistent prototype for the + dispatch function of the autofs service de/registration functions. + +2005-12-03 Erez Zadok <ezk@cs.sunysb.edu> + + * minor new ports: i386-unknown-netbsdelf2.1, + i386-unknown-netbsdelf3.0 (RELEASE), and i386-unknown-openbsd3.8. + +2005-12-02 Erez Zadok <ezk@cs.sunysb.edu> + + * m4/macros/check_field.m4: remove double inclusion of msdosfs + headers, which are included in mount_header1.h (netbsd 2.1 doesn't + protect <msdosfs/msdosfsmount.h> which causes compile errors). + +2005-11-08 Erez Zadok <ezk@cs.sunysb.edu> + + * minor new port: i386-unknown-freebsd6.0 (RELEASE) + +2005-10-26 Erez Zadok <ezk@cs.sunysb.edu> + + * amd/amq_subr.c (amqproc_pawd_1_svc): repeatedly resolve path in + Amd, not in pawd (to avoid repeated network RPCs). + + * amq/pawd.c (transform_dir): move repeated path resolution into Amd. + +2005-10-25 Erez Zadok <ezk@cs.sunysb.edu> + + * amq/pawd.c (transform_dir): resolve path repeatedly until + finished. Bug fix from Jonathan Chen <jon+amd-at-spock.org>. + Added safety check to prevent infinite loops. + +2005-10-19 Erez Zadok <ezk@cs.sunysb.edu> + + * doc/am-utils.texi (opts Option): document new pcfs options + longname, nowin95, shortname, user=N, group=N, mask=N, and + dirmask=N. + + * amd/ops_pcfs.c (mount_pcfs): process new pcfs options longname, + nowin95, shortname, user=N, group=N, mask=N, and dirmask=N. + + * include/am_compat.h: provide compatibility mnttab string names, + if needed, for pcfs mount options longname, nowin95, shortname, + user=N, group=N, mask=N, and dirmask=N. + + * include/am_utils.h: extern for hasmntstr(). + + * libamu/mtab.c (hasmntstr): new function to return the string + value following a mount option, up to the next comma-delimited + options. + + * configure.in: check for mnttab and pcfs options longname, + nowin95, and shortname. + + * Makefile.am (EXTRA_DIST_M4): distribute new macro + check_mnt2_pcfs_opt.m4. + + * m4/macros/check_mnt2_pcfs_opt.m4: new macro to check for pcfs + mnttab and mount options. + +2005-10-18 Erez Zadok <ezk@cs.sunysb.edu> + + * libamu/mount_fs.c (print_nfs_args): print nfs_args->addr + correctly, depending if it's a pointer or not. + + * conf/sa_dref/sa_dref_*.h: for each NFS_SA_DREF macro, also + #define NFS_ARGS_T_ADDR_IS_POINTER if nfs_args->addr is a pointer + or an embedded structure, so we can tell how to print it. + + * libamu/mount_fs.c (print_nfs_args): print nfs_args->addrlen + field, if it exists. + + * configure.in: check for nfs_args->addrlen field. + + * wire-test/wire-test.c (main), libamu/mount_fs.c + (print_nfs_args), fixmount/fixmount.c (inetresport, + clnt_create_timeout), amq/pawd.c (transform_dir), amq/amq.c + (main), amd/srvr_nfs.c (find_nfs_srvr), amd/autil.c + (amfs_mount): document that as per POSIX, we don't need to set the + sa_len/sin_len fields in struct sockaddr/sockaddr_in. The field + is used only internally in the kernel. See + www.awprofessional.com/articles/article.asp?p=169505&seqNum=2&rl=1 + + * fixmount/fixmount.c (inetresport): initialize sockaddr_in + structure before filling in some fields. + +2005-10-11 Erez Zadok <ezk@cs.sunysb.edu> + + * doc/am-utils.texi (nfs_vers, nfs_proto parameters): clarify and + correct mistaken description of nfs_proto. + +2005-10-10 Erez Zadok <ezk@cs.sunysb.edu> + + ******************************************************************* + *** Released am-utils-6.1.3 *** + ******************************************************************* + +2005-10-07 Erez Zadok <ezk@cs.sunysb.edu> + + * m4/macros/check_mnttab_type.m4: move the test for MOUNT_* to the + very end, after the test using getvfsbyname(). + + * m4/macros/expand_run_string.m4: if the string value returned is + empty, consider it invalid. + + * m4/macros/check_varargs_macros.m4: rewrite macro so it'll + try and compile the varargs test, not just cpp it. Some systems + pass the old cpp test, but not when you actually try to compile + the code (Tru64's cc). + + * conf/autofs/autofs_solaris_v1.h: redefine + autofs_strdup_space_hack as a macro to str3cat(NULL,(s)," ",""). + This works everywhere and we avoid linking problems, inline + functions, etc. + + * conf/autofs/autofs_solaris_v1.c (autofs_mount_fs): remove + autofs_strdup_space_hack() function altogether. + + * m4/macros/os_cflags.m4: remove hack that hardcodes pte_t=u_int. + + * configure.in: test for <sys/immu.h> header. + Test for pte_t, but only on IRIX6 systems. + + * Makefile.am (EXTRA_DIST_M4): distribute new type_pte_t.m4 file. + + * m4/macros/type_pte_t.m4: new test for existence of pte_t + typedef, needed on some IRIX-6.5/gcc systems. + + * m4/macros/header_templates.m4: add missing templates for + HAVE_EXTERN_GETDTABLESIZE, HAVE_EXTERN_GETWD, and + HAVE_EXTERN_UALARM. + + * amd/info_exec.c (exec_map_open): break assignment from inside + conditional, to work around an IRIX-6.5 cc bug. + + * fsinfo/fsi_util.c (set_ether_if), amd/map.c (unmount_mp), + libamu/xutil.c (expand_error), libamu/strutil.c (xsnprintf): avoid + comparison between signed and unsigned integers. + + * conf/autofs/autofs_solaris_v1.h, conf/autofs/autofs_solaris_v1.c + (autofs_strdup_space_hack): move "space_hack" function from static + inline in header, into the only source file that needs it. This + is cleaner and also prevents linking problem with some compilers + that won't apply CPP macros inside static inline functions (for + the strl* functions). + + * amq/pawd.c (find_mt, find_mlp): remove obsolete, inefficient + code. + (transform_dir): call the new, efficient amqproc_pawd_1() routine. + + * amq/amq_clnt.c (amqproc_pawd_1): AMQPROC_PAWD wrapper routine. + + * amq/amq.h (amqproc_pawd_1): extern for amq's AMQPROC_PAWD + wrapper routine. + + * amd/amq_svc.c (amq_program_1): dispatch point for + amqproc_pawd_1_svc. + + * amd/amq_subr.c (amqproc_pawd_1_svc): moved pawd's path-matching + functionality into Amd, where it can be done a lot more + efficiently. We don't have to construct and ship a whole export + tree from Amd to pawd. We just get a variable-length + xdr_wrapstring for the user's path, iterate over the entire export + list inside Amd, and return only a matched string if found + (otherwise we return "" to indicate that there was no match, and + let pawd printf the same string it sent over). + + * amd/amd.h: extern for amqproc_pawd_1_svc, amd's service routine + the AMQPROC_PAWD RPC. + +2005-10-06 Erez Zadok <ezk@cs.sunysb.edu> + + * ltmain.sh, m4/macros/libtool.m4: update to libtool-1.5.20. + Fixes Tru64 bugs when using ksh. + + * amd/amfs_toplvl.c (amfs_toplvl_mount): break complex ifdef macro + into two sections, to workaround a C99 varargs-macro bug in + gcc-3.2.2 (RH9). + + * libamu/wire.c (print_wires): convert argument-less xsnprintf to + xstrlcpy. + + * include/am_utils.h: use new HAVE_C99_VARARGS_MACROS or + HAVE_GCC_VARARGS_MACROS to pass file name and line number to + xsnprintf/xvsnprintf. + + * libamu/strutil.c (xsnprintf, xvsnprintf): if debugging is on, + then also print the source file name and line number that called + xsnprintf/xvsnprintf with a buffer that wasn't large enough (most + likely an am-utils bug). + + * Makefile.am (EXTRA_DIST_M4): distribute new + check_varargs_macros.m4 file. + + * configure.in: execute new AMU_VARARGS_MACROS test. + + * m4/macros/check_varargs_macros.m4: new test to check what style + of variable-length argument macros, if any, does the + compiler/pre-processor supports. + + * conf/autofs/autofs_solaris_v2_v3.c (autofs_lookup_2_req) + conf/autofs/autofs_solaris_v1.c (autofs_mount_1_req), amd/opts.c, + amd/nfs_subr.c (nfsproc_lookup_2_svc), amd/nfs_start.c + (mount_automounter), amd/get_args.c (get_args), amd/amfs_toplvl.c, + amd/amfs_auto.c (amfs_auto_mount), amd/amd.h, amd/amd.c (main): + use sizeof() instead of fixed SIZEOF_* macros. + + * libamu/strutil.c (xstrlcat, xstrlcpy), include/am_utils.h + (DEBUG): if debugging is on, then also print the source file name + and line number that called xstrl* with a buffer that wasn't large + enough (most likely an am-utils bug) + + * include/am_compat.h (INADDR_NONE): define in a common location, + if OS doesn't have it, use 0xffffffffU which should work with any + ANSI compiler. + + * fixmount/fixmount.c, libamu/wire.c: remove local definition of + INADDR_NONE. + + * amd/amfs_toplvl.c (amfs_toplvl_mount), amd/amfs_auto.c + (amfs_auto_mount): use common SIZEOF_OPTS in definition and call + to autofs_get_opts. + + * amd/amd.h (SIZEOF_OPTS): moved #define to common header. + +2005-10-06 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> + + * amd/opts.c (expand_op): Need to check BUFSPACE for env for + vlen+1. Likewise for cp and strlen(cp)+1. + + * amd/amfs_toplvl.c (amfs_toplvl_mount) [HAVE_FS_AUTOFS]: Pass new + size argument to autofs_get_opts. + +2005-10-05 Erez Zadok <ezk@cs.sunysb.edu> + + * amq/pawd.c (transform_dir): was using UDP only. Now will also + try TCP if UDP failed. Destroy client after use to avoid leftover + TCP sockets in the kernel. + + * libamu/hasmntopt.c (amu_hasmntopt): increase size of MNTMAXSTR + from 128 to to 256, because some users have really long option + strings. Suggestion from jon+amd-at-spock.org. + + * amd/opts.c (expand_op): should check BUFSPACE for vlen+1, not + just vlen. Bug discovered when started using xstrlcpy(). + + * ALL: convert from using strcat to the safer xstrlcat, and from + strcpy to safer xstrlcpy. + +2005-10-04 Erez Zadok <ezk@cs.sunysb.edu> + + * hlfsd/hlfsd.h: remove old fatalerror() and ERRM macros. + + * hlfsd/hlfsd.c (fatalerror): new function instead of macro. + Easier to use xstrlcat in this new function. + + * amd/amd.h, include/am_utils.h, amd/amd.c: moved 'hostd' extern + from am_utils.h to amd.h, and define its size as a macro that + could be passed to xstrl*(). + + * ALL: convert from using sprintf to the safer xsnprintf. + + * mk-amd-map/Makefile.am (LDADD): link with libamu to get + xsnprintf(). + + * amd/amd.h, amd/amd.c, include/am_utils.h: moved pid_fsname + extern from am_utils.h to amd.h, and define its size as a macro + that could be passed to xsnprintf(). + +2005-10-02 Erez Zadok <ezk@cs.sunysb.edu> + + * include/am_utils.h: extern for xvsnprintf(). + + * amd/autil.c: move strsplit() to libamu/strutil.c. + + * libamu/Makefile.am: use strutil.c, not util.c. + + * libamu/strutil.c: rename from util.c to explain better purpose + of file. Move xvsnprintf and xsnprintf from xutil.c to this + file. Sync up with 6.2 version of file. + + * libamu/xutil.c: explain purpose of file. Move mkdirs/rmdirs + code from old util.c. + +2005-10-01 Erez Zadok <ezk@cs.sunysb.edu> + + * m4/macros/header_templates.m4: templates for FFS. + + * m4/macros/check_mnttab_type.m4: on BSD44 systems, check for file + system mount table name via the MOUNT_* mount(2) macros (because + BSD44 keeps the mount table in the kernel). + + * configure.in: synchronise order of searching for mnttab entries + and mount names. The new order is "ext3 ext2 ffs ufs 4.2 4.3 4.4 + efs xfs jfs ultrix" (which would prefer ffs on BSD44 instead of + ufs, and ext3 instead of ext2 on Linux). + + * include/am_defs.h: include <sys/statvfs.h> if it exists. + + * conf/nfs_prot/nfs_prot_netbsd1_4.h: NetBSD 3 has both statfs() + and statvfs(), but the latter is preferred, so #define to use + statvfs. + + * configure.in: check for statfs(), statvfs(), and + <sys/statvfs.h>. + + * config.guess.long: strip trailing '.' on "netbsdelf3.0." + (Beta). Workaround for bug in config.guess. + + * config.{guess,sub}: update to latest versions. + +2005-09-30 Christos Zoulas <christos@zoulas.com> + + * fsinfo/fsi_util.c (set_ether_if): use INADDR_NONE instead of + hard-coded value of -1. + + * include/amq_defs.h (AMQ_STRLEN): increase default size from 2KB + to 16KB. We can afford it these days. + + * libamu/strcasecmp.c (strcasecmp): use unsigned chars in + tolower() to avoid sign/size promotion bugs. + + * libamu/xutil.c (switch_to_logfile): don't output to LOG_CONS by + default (it's unfriendly). If user really wants to, they can set + it in /etc/syslog.conf. + +2005-09-29 Erez Zadok <ezk@cs.sunysb.edu> + + * amq/pawd.c (find_mt): if the auto mount type is used, pawd could + go into an infinite loop since the mt_directory and mt_mountpoint + fields are the same for auto mounts. Solution: ignore type auto + mounts, similar to toplvl. Bug fix from Jonathan Chen + <jon+amd@spock.org>. + + * README.attrcache: document test-attrcache script. + + * scripts/Makefile.am (noinst_SCRIPTS): build test-attrcache + script. + + * configure.in: build scripts/test-attrcache script and chmod it + so it can be executed in place. + + * scripts/test-attrcache.in: script to test the NFS attribute + cache using Amd. + +2005-09-26 Erez Zadok <ezk@cs.sunysb.edu> + + * libamu/xutil.c (unregister_amq): repair broken meaning of D_AMQ, + which was reversed in am-utils-6.2. Bug fix from Steve Plite + <splite-amutils at sigint.cs.purdue.edu>. + + * hlfsd/stubs.c (nfsproc_getattr_2_svc, nfsproc_lookup_2_svc, + nfsproc_readlink_2_svc, nfsproc_readdir_2_svc), hlfsd/hlfsd.c + (hlfsd_init): use new clocktime() function. + +2005-09-18 Erez Zadok <ezk@cs.sunysb.edu> + + ******************************************************************* + *** Released am-utils-6.1.2.1 *** + ******************************************************************* + + * README.attrcache: Update status of freebsd and openbsd. + Document netbsd's patchs to support noac. + + * libamu/mount_fs.c (compute_nfs_attrcache_flags): cleanup the + code that sets the ac{reg,dir}{min,max} fields so it also sets the + appropriate nfs_args->flags such as MNT2_NFS_OPT_ACREGMIN. + + * configure.in: check for nfs_args fields acregmax and acdirmax. + + ******************************************************************* + *** Released am-utils-6.1.2 *** + ******************************************************************* + + * README.attrcache: new file documenting in detail OS bugs + relating to attribute caching, which can affect Amd's reliability + under heavy load. + + * doc/Makefile.am: install README.attrcache file as attrache.txt + file on am-utils Web site. + + * Makefile.am (EXTRA_DIST): include README.attrcache in distro. + + * BUGS, NEWS, doc/am-utils.texi (auto_attrcache Parameter), + scripts/amd.conf.5, scripts/amd.conf-sample: document attribute + cache bugs on some OSs. + +2005-09-17 Erez Zadok <ezk@cs.sunysb.edu> + + * libamu/xutil.c (clocktime): newly implemented routine. Uses + gettimeofday() each time to return a high-resolution clock time, + and does not "cache" the last time. Returns time in seconds, just + like the old implementation. If passed a non-null argument, will + fill it in with the current time in seconds+microseconds. + + * libamu/xutil.c: remove actual declaration of clock_valid, and + another never-used declaration for xclock_valid. + + * include/am_utils.h: remove defunct definition of clocktime() + macro and clock_valid variable. Add extern for new definition. + + * libamu/mount_fs.c (mount_fs), hlfsd/homedir.c (homedir, + hlfsd_diskspace, hlfsd_getpwent, plt_reset, table_add), + hlfsd/hlfsd.c (main, hlfsd_init, reload, cleanup), + conf/mtab/mtab_mach3.c (open_locked_mtab), conf/mtab/mtab_file.c + (open_locked_mtab), amd/nfs_start.c (do_select, run_rpc), + amd/autil.c (host_normalize): remove defunct clock_valid. + + * amd/nfs_subr.c (nfsproc_getattr_2_svc): Print microseconds for + node's mtime. + (fh_to_mp3): use new clocktime() to update mtime and get a better + time resolution. + + * amd/mapc.c (mapc_reload_map): change prototype from returning + void to returning an int. If reloading was needed and succeeded, + return 1; else return 0. + (mapc_sync): update mtime of parent node if needed. This is a + CRITICAL FIX, to ensure that the kernel flushes its DNLC/dcache + when we run "amq -f" manually or when a map is reloaded. + + * amd/map.c (new_ttl): update am_ttl and na_atime in one shot. + (init_map): use new clocktime(). + (unmount_mp): if the OS doesn't support a "symttl" option, then + update the mtime of the parent node using the clocktime(); but if + the time hasn't gotten changed because of rapid Amd accesses on + systems that don't have a micro-second NFS-client resolution, then + increment mtime by one arbitrarily (this could, on some systems + and under pathological cases, result in mtime's that are in the + future). + + * amd/autil.c (forcibly_timeout_mp): MAJOR BUG FIX: force mtime + update of parent dir, to prevent DNLC/dcache from caching the old + entry, which could result in ESTALE errors, bad symlinks, and + more. + (am_mounted): record mount time, and update am_stats at the same + time, using the double-action redone clocktime() routine. + (am_mounted): update parent's mtime from that of the child. + (am_unmounted): when unmounting an entry, update mtime of parent + node. + + * amd/amfs_generic.c (amfs_bgmount): now that clocktime() doesn't + remember it's last non-zero value, save it in a temporary variable + to avoid a TOCTOU problem (between an "if" and a "dlog"). + + * libamu/xutil.c (show_time_host_and_name), + conf/autofs/autofs_linux.c (autofs_mounted, autofs_timeout_mp), + amd/srvr_nfs.c (nfs_keepalive_callback, nfs_keepalive_timeout) + (find_nfs_srvr), amd/rpc_fwd.c (fwd_alloc), amd/nfs_subr.c + (nfsproc_getattr_2_svc), amd/nfs_start.c (do_select, run_rpc), + amd/mapc.c (root_init), amd/map.c(map_flush_srvr, timeout_mp), + amd/info_ndbm.c (ndbm_init), amd/info_ldap.c (amu_ldap_rebind), + amd/info_file.c (file_open), amd/info_exec.c (fgets_timed, + exec_search), amd/clock.c (timeout, softclock), amd/autil.c + (forcibly_timeout_mp), amd/amfs_generic.c (amfs_retry, + amfs_bgmount, amfs_generic_mount_child), amd/amd.c (main): pass + NULL to clocktime(). + +2005-09-07 Erez Zadok <ezk@cs.sunysb.edu> + + * minor new port: powerpc-apple-darwin8.2.0. + + * m4/macros/type_auth_create_gidlist.m4: Old macosx used "gid_t" + but all newer ones (10.4+) use int. + + * m4/macros/type_recvfrom_fromlen.m4: Old macosx used "int" for + 6th arg of recvfrom(), but all newer ones (10.4+) use socklen_t. + + * minor new port: i386-pc-linux-deb3.1. + +2005-09-02 Erez Zadok <ezk@cs.sunysb.edu> + + * conf/mount/mount_linux.c: If autoconf didn't find any disk-based + file system on this system (probably because /proc isn't mounted), + then provide some default definition for this file to compile. + +2005-08-27 Erez Zadok <ezk@cs.sunysb.edu> + + * Makefile.am (DISTCLEANFILES): also remove amu_autofs_prot.h, + config.cache.old, and dbgcf.h on "make distclean". + (CLEANFILES): remove dbgcf on plain "make clean". + + * amd/Makefile.am (DISTCLEANFILES): also remove ops_autofs.c on + "make distclean". + +2005-08-24 Erez Zadok <ezk@cs.sunysb.edu> + + * configure.in: wrap all LDAP and HESIOD tests in test whether + --with-OPT was used. + +2005-08-16 Erez Zadok <ezk@cs.sunysb.edu> + + * configure.in: sinclude([vers.m4]) version number file. + + * vers.m4: new file to separate version number out of + configure.in, useful for nightly snapshot script to generate + nightly version string. + + * Makefile.am (EXTRA_DIST_M4): include vers.m4 in distro. + +2005-08-11 Erez Zadok <ezk@cs.sunysb.edu> + + * configure.in: keep AC_INIT on same line, for nightly snapshot + build script. + +2005-08-06 Erez Zadok <ezk@cs.sunysb.edu> + + * scripts/amd.conf.5: selectors_in_defaults is a common parameter, + not just [global]. Use consistent capitalization of Amd/Amq. + + * scripts/amd.conf-sample: properly list all of the parameters + which are common to both the [global] and the per-map sections. + + * doc/am-utils.texi (Common Parameters): selectors_in_defaults is + a common parameter, not just [global]. + + * scripts/amd.conf-sample (sun_map_syntax): example of new flag. + + * cvs-server.txt: update instructions after branching 6.1-stable. + +2005-08-02 Erez Zadok <ezk@cs.sunysb.edu> + + ******************************************************************* + *** Released am-utils-6.1.1 *** + ******************************************************************* + + * libamu/xutil.c (xsnprintf): "unsafe" alternative to vsnprintf is + vsprintf, not sprintf. + + * conf/umount/umount_osf.c (umount_fs): refer to proper formal + parameter name. + (umount2_fs): pass second arg to umount(). + + * ALL: remove CVS ID and put actual file name in source. + + * conf/autofs/*.[hc]: proper copyright headers. + + * whitespace reformatting. Remove remaining '%W%' SCCS IDs. + + * amd/mntfs.c (free_mntfs): don't discard the last reference to an + mntfs that had been mounted already. It won't have the + MFF_RESTARTED flag on, as it gets turned off after the entry is + mounted, but it will have the MFF_RSTKEEP flag on. + + * amd/autil.c (mf_mounted), amd/restart.c (restart_fake_mntfs): + show the mntfs's flags. + +2005-08-01 Erez Zadok <ezk@cs.sunysb.edu> + + * conf/mtab/mtab_linux.c: removed unused code. Cleanup. + (handler): removed this bad signal handler. + (lock_mtab): Redhat's original code set a signal handler called + "handler()" for all non-ALRM signals. The handler called + unlock_mntlist(), plog'ed the signal name, and then exit(1)! + Never, ever, exit() from inside a utility function. This messed + up Amd's careful signal-handling code, and caused Amd to abort + uncleanly only any other "innocent" signal + (even simple SIGUSR1), leaving behind a hung Amd mnt point. That + code should have at least restored the signal handlers' states + upon a successful mtab unlocking. Anyway, that handler was + unnecessary, because will call unlock_mntlist() properly anyway on + exit. + + * conf/mtab/mtab_{file,isc3,mach3,linux}.c (unlock_mntlist): dlog + message that we're inside the unlock_mntlist function. + + * amd/amd.c (main): use new setup_sighandler() for Amd's four main + signals (INT, TERM, HUP, and CHLD). + (main) Add SIGINT and SIGTERM to masked_sigs, used in + nfs_start.c:do_select() for setjmp/longjmp code; the MASK was set + to all four signals if !HAVE_SIGACTION, but only to HUP+CHLD if we + HAVE_SIGACTION. So this change makes Amd behave consistently. + + * include/am_utils.h: extern for new setup_sighandler(). + + * libamu/xutil.c (setup_sighandler): new utility function to setup + a single signal-handler regardless of what method is supported by + this OS. + (going_down): call unlock_mntlist() when exiting, to ensure that + Amd will remove any leftover mtab lock files, if any. + + * amd/restart.c (restart_automounter_nodes): cleanup function. + + * minor new port: i386-pc-linuxoldld-deb3.1. + + * configure.in: include <sys/types.h> before <linux/socket.h> to + get the definition of size_t on Debian-3.1r0a. + +2005-07-29 Erez Zadok <ezk@cs.sunysb.edu> + + * amd/srvr_nfs.c (find_nfs_srvr): don't blindly copy the hostent + IP address. First check if it differs from the existing one of + the fserver, and copy only if it changed. If it did change, flush + the fhandle cache to avoid a stale fhandle being reused. This + allows Amd to detect IP address changes even for an fserver that + lost one or more NFS pings, but not enough to be declared totally + down. We handle the "totally down" fserver case in + check_fs_addr_change(). + + * amd/ops_nfs.c (nfs_umount), amd/sched.c (sched_task), + amd/nfs_subr.c (nfs_quick_reply): code clarity. + + * conf/mount/mount_linux.c (linux_nfs_error): dlog mappings of + errnos to NFS errors. + + * conf/umount/umount_linux.c (umount2_fs): cleanup code. Trying + stat() seems doomed to hang at times, so don't try stat at all, + because umount2() appears to be clever enough to never hang. + +2005-07-25 Erez Zadok <ezk@cs.sunysb.edu> + + * amd/amd.h (FSF_FORCE_UNMOUNT): new flag used to indicate that a + particular fserver may need forced/lazy unmounts when it's mntfs's + are unmounted. + + * amd/ops_nfs.c (nfs_umount): a simple unmount returned EBUSY, and + the user specified forced_unmounts=yes in amd.conf, and this + fserver was flagged with FSF_FORCE_UNMOUNT, and the OS supports + forced/lazy unmounts, then try forced/lazy unmounts. This should + allow a hung mount point to be removed. + + * amd/srvr_nfs.c (find_nfs_srvr): move away IP-address change + detection code to its own function. + (check_fs_addr_change): new function to detect if the IP address + of a downed host has changed, and do various cleanups and fixups + to try and recover as best from that situation (e.g., flushing + various caches). Also set the FSF_FORCE_UNMOUNT flag for the + fserver in question. + (flush_srvr_nfs_cache): pass fserver as argument, so we can + selectively flush the NFS cache for a single fserver (or all of + them, if you pass NULL). + + * libamu/xutil.c (switch_to_logfile): truncate a regular-file log + file if user passed non-zero "truncate_log" flag. + + * include/am_utils.h: switch_to_logfile() now takes a 3rd arg. + + * amd/get_args.c (get_args): pass "truncate_log" flag as per + amd.conf global settings. + + * amd/conf.c (gopt_truncate_log): store global value of + truncate_log flag. + + * amd/amq_subr.c (amqproc_setopt_1_svc), hlfsd/hlfsd.c (main, + reload): don't truncate log file when calling switch_to_logfile(). + + * amd/amd.h (CFM_TRUNCATE_LOG): new flag. Fix comment typo. + + * NEWS, doc/am-utils.texi (truncate_log Parameter), + scripts/amd.conf.5, scripts/amd.conf-sample (log_file): document + new truncate_log amd.conf parameter. + + * amd/conf.c (gopt_forced_unmounts): check Linux kernel version + and alert if your version may be too old for MNT_FORCE to work + (before 2.4.0) or for MNT_DETACH to work (before 2.6.0). + Otherwise it may be impossible to pin down the exact kernel + version in which we should enable this feature. + + * conf/umount/umount_linux.c (umount2_fs): if MNT_FORCE returned + EBUSY, then don't try to stat(2) before MNT_DETACH because it + could hang. + +2005-07-21 Erez Zadok <ezk@cs.sunysb.edu> + + * conf/umount/umount_linux.c (umount_fs): cleanup this function, + breaking long "if" statements using "goto out". + + * conf/umount/umount_{aix,bsd44,osf,default,linux}.c (umount_fs): + call new utility function umount2_fs() as needed (EBUSY, EIO, or + ESTALE). + + * conf/umount/umount_{aix,bsd44,osf,default,linux}.c (umount2_fs): + define a new utility function to invoke forcible/lazy unmounts + without touching any mtab files. This separate utility function + is useful because it can be called from elsewhere. + + * amd/amfs_toplvl.c (amfs_toplvl_init): new function, called + before Amd mounts toplvl mounts, which gives us a hook for cleanup + of a previously dead Amd. In our case, if the user asked for + forced_unmounts, and the OS supports it, then we try forced/lazy + unmounts on any previous toplvl mounts. This is useful if a + previous Amd died and left behind toplvl mount points (this Amd + will clean them up!). WARNING: Don't use forced/lazy unmounts if + you have another valid Amd running, because this code WILL force + those valid toplvl mount points to be detached as well! + + * amd/amfs_toplvl.c (amfs_toplvl_umount): don't unconditionally + try forced/lazy unmounts because it will prevent a normal Amd from + terminating and cleaning up properly (self-deadlocking: detached + mounts hang the parent Amd on a stat). Since we already do + unmounts in the background, then try a safer policy: after trying + the normal unmounts a few times (5 sec), escalate and try forced + unmounts a few times (5 more seconds), and if even that failed, + then try the ultimate -- detached unmounts (which always succeed). + This allows Amd to first try and shutdown cleanly, and gradually + try more forcible ways to shutdown. On Linux, this procedure will + cleanly shutdown Amd even if there are processes with their CWD on + Amd's mount points (which normally result in EBUSY). + +2005-07-20 Erez Zadok <ezk@cs.sunysb.edu> + + * Makefile.am (EXTRA_DIST_CONF): add new umount_aix.c to distro. + + * conf/umount/umount_aix.c: easier if AIX has its own unmount + helper file. + + * m4/macros/check_umount_style.m4: AIX needs its own unmount style + file. + + * doc/am-utils.texi (forced_unmounts Parameter): @xref -> @pxref. + +2005-07-19 Erez Zadok <ezk@cs.sunysb.edu> + + * conf/nfs_prot/nfs_prot_aix5_2.h: define compatible + forced-unmount flag. + + * conf/umount/umount_default.c (umount_fs): if regular umount got + EBUSY, EIO, or ESTALE, then try forced unmount, if supported. Try + umount2 (Solaris) or uvmount (AIX). + + * conf/umount/umount_{bsd44,osf}.c (umount_fs): if default + umount() failed with EIO or ESTALE, also try forced unmount. + +2005-07-18 Erez Zadok <ezk@cs.sunysb.edu> + + * amd/autil.c (amfs_mount), amd/amfs_toplvl.c + (amfs_toplvl_umount): enable forced/lazy unmounts only if user + asked for it (and dlog it). + + * scripts/amd.conf.5: document new force_unmount global parameter. + + * doc/am-utils.texi (forced_unmounts Parameter): document new + global parameter. + + * amd/conf.c (gopt_forced_unmounts): process forced_unmounts + option (default "no"). Exit with an error if user specified the + option as "yes" but configure couldn't find support for either the + MNT_FORCE or MNT_DETACH flags. + + * scripts/amd.conf-sample (forced_unmounts): example usage of new + option. + + * amd/amd.h (CFM_FORCED_UNMOUNTS): new flag for forced_unmounts + option. + + * m4/macros/header_templates.m4: templates for _DETACH and _FORCE. + + * configure.in: check for generic u/mount options "detach" and + "force". + + * include/am_utils.h (UMOUNT_FS, umount_fs): new prototypes. + Define AMU_UMOUNT flags for force, detach, and autofs. + + * amd/amfs_toplvl.c (amfs_toplvl_umount): pass _FORCE and _DETACH + unmount flags unconditionally. Pass them to UMOUNT_FS(). + + * conf/nfs_prot/nfs_prot_linux.h: define MNT_FORCE and MNT_DETACH + if needed, because some Linux systems don't define them + (presumably because it would be too dangerous to expose these + flags to users). + + * amd/autil.c (amfs_mount): if mount(2) failed with ESTALE or EIO, + then assume that we're in trouble, possibly because a previous + mount is hung. So, first try to force a lazy unmount of the old + mount. If the forced unmount worked, then try again to mount the + desired file system. If the forced unmount failed, then don't + retry: just return an error. + + * amd/amfs_generic.c (amfs_generic_umount), amd/amfs_host.c + (amfs_host_umount), amd/ops_cachefs.c (cachefs_umount), + amd/ops_cdfs.c (cdfs_umount), amd/ops_efs.c (efs_umount), + amd/ops_lofs.c (lofs_umount), amd/ops_nfs.c (nfs_umount), + amd/ops_pcfs.c (pcfs_umount), amd/ops_ufs.c (ufs_umount), + amd/ops_xfs.c (xfs_umount), conf/umount/umount_bsd44.c + (umount_fs), conf/umount/umount_default.c (umount_fs), + conf/umount/umount_linux.c (umount_fs), conf/umount/umount_osf.c + (umount_fs): compute and use unmount specific flags. + +2005-07-16 Erez Zadok <ezk@cs.sunysb.edu> + + * configure.in: better help for users, if nfs_args can't be found. + +2005-07-15 Erez Zadok <ezk@cs.sunysb.edu> + + * BUGS: more details on AIX's need to install bos.net.nfs.adt + before configuring am-utils (else configure cannot find struct + nfs_args on AIX). + +2005-07-10 Erez Zadok <ezk@cs.sunysb.edu> + + * amd/srvr_nfs.c (find_nfs_srvr): flush NFS handle cache if the IP + address of a down server had changed. + + * amd/info_union.c (union_reload): use safer xsnprintf() routine. + + * amd/srvr_nfs.c (find_nfs_srvr): check to see if the IP address + of a named but down fserver changed (i.e., the previous IP address + is no longer responding). If so, then reset the fserver to the + new IP address, and set the fserver's flags such that the function + will fall through to doing the usual NFS version/proto checks and + pinging. (This should fix one case of bug #308.) + + * conf/umount/umount_linux.c (umount_fs): warn if plain umount() + failed, before we try to ignore any errors or try optional + umount2(), possibly with forced/lazy unmount. + (umount_fs): dlog when unmount succeeded. + +2005-07-08 Erez Zadok <ezk@cs.sunysb.edu> + + * conf/mount/mount_linux.c: add a couple more NFSv2 error codes + that are compatible with NFSv3. + +2005-07-07 Erez Zadok <ezk@cs.sunysb.edu> + + * m4/macros/header_templates.m4: extern template for strlcat(). + + * amd/get_args.c (get_version_string): use safer strlcat (or + replacement strlcat). Use new wrapper xsnprintf() function, which + will use the safer vsnprintf() if available, else default to plain + sprintf. + + * configure.in: check for existence of strlcat() and its extern, + replacing with libamu/strlcat.c as needed. + + * libamu/Makefile.am (EXTRA_DIST): add strlcat.c to distro. + + * include/am_defs.h: optional strlcat() extern. + + * include/am_utils.h: extern for new xvsnprintf(). + + * configure.in: overdue new major libtool shlib version. + Check for snprintf function and extern. + +2005-07-06 Erez Zadok <ezk@cs.sunysb.edu> + + * conf/nfs_prot/nfs_prot_aix4_3.h: cleanup struct + aix4_nfs_args_bis. + + * Makefile.am (EXTRA_DIST_CONF): include mount_aix3.c in + distribution. + + * conf/mount/mount_aix.c: mount style for aix 5.x and newer. + + * conf/mount/mount_aix3.c: mount styles for aix 3.x/4.x. + + * m4/macros/check_mount_style.m4: split mount styles for + aix3.x/4.x and the newer (and better) aix 5.x code. + +2005-07-05 Erez Zadok <ezk@cs.sunysb.edu> + + * amq/pawd.c (getawd): avoid buffer overflow. Bug fix from Graeme + Wilford <G.Wilford@surrey.ac.uk>. + +2005-06-30 Erez Zadok <ezk@cs.sunysb.edu> + + * amd/map.c (get_next_exported_ap): Avoid running off the end of + the exported_ap[] array. Patch from jon+amd-at-spock.org. Fixed + bug #301. + +2005-06-25 Erez Zadok <ezk@cs.sunysb.edu> + + * Makefile.am (EXTRA_DIST_CONF): distribute new mtab_linux.c. + + * conf/mtab/mtab_linux.c (rewrite_mtab): variable declarations + must come before C code. + + * conf/mtab/mtab_linux.c: Linux-specific mount table hanlding + that's safe (uses locks, handles symlinks to /proc/mounts, etc.). + Patch from Red Hat, which they adapted from mtab_file.c. Minor + fixes to this file. + + * m4/macros/check_mnttab_style.m4: Use Linux-specific mount table + handling. + +2005-06-24 Erez Zadok <ezk@cs.sunysb.edu> + + * conf/mount/mount_aix.c (mount_aix3): minor cleanup of filehandle + copying code. + +2005-06-23 Erez Zadok <ezk@cs.sunysb.edu> + + * conf/nfs_prot/nfs_prot_hpux.h: add extern for h_errno, which may + be missing from older hpux10 systems. + + * configure.in: update bug-reporting address to list + https://bugzilla.am-utils.org/ as well as the mailing list. + + * Makefile.am (EXTRA_DIST_M4): distribute new type_rpcvers_t.m4 + macro. + + * conf/transp/transp_tli.c (get_nfs_version): always use + rpcvers_t, now that it'll be automatically discovered. + + * configure.in: check for rpcvers_t type. + + * m4/macros/type_rpcvers_t.m4: new macro to check for type of + rpcvers_t (Some Solaris versions need it). + + * conf/nfs_prot/nfs_prot_sunos5_8.h: don't define INADDR_NONE + here, but in the actual source files that may need it. + + * libamu/wire.c (INADDR_NONE): define INADDR_NONE if not defined + already. + + * include/am_defs.h: define extern for sleep(3) if needed. + + * m4/macros/header_templates.m4: template for sleep(3) extern. + + * configure.in: check for extern for sleep(3), which is missing + from some old (and buggy) versions of gcc's fixinc'ed headers. + + * conf/nfs_prot/nfs_prot_aix4_3.h: update definition of struct + nfs_args from actual system headers. + + * conf/mount/mount_aix.c (mount_aix3): fix name of aix4 "bis" + structure. + +2005-06-22 Erez Zadok <ezk@cs.sunysb.edu> + + * BUGS: update Solaris information about use of f/lex and + yacc/bison. + +2005-06-20 Erez Zadok <ezk@cs.sunysb.edu> + + * minor new port: i386-pc-linux-suse9.3. + +2005-06-20 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> + + * configure.in (linux/nfs_mount.h): Move __KERNEL__ definition up + so u32 is available for <linux/sunrpc/msg_prot.h>. + +2005-06-16 Erez Zadok <ezk@cs.sunysb.edu> + + * amd/mapc.c (maptypes): move MAP_EXEC after MAP_FILE, because + exec maps will always match when users use amd with command line + args (not amd.conf). Using that legacy way, unfortunately, means + that Amd will use it's hard-coded info-service search path, which + doesn't work for everyone. It's much better to use amd.conf and + specify what you want exactly. + +2005-06-15 Erez Zadok <ezk@cs.sunysb.edu> + + * minor new port: i386-pc-linux-fc4 (gcc4 catches more bugs). + + * m4/macros/type_recvfrom_fromlen.m4: linux systems use unsigned + int as the type of recvfrom()'s 6th argument. + + * m4/macros/type_yp_order_outorder.m4: linux systems use unsigned + int as the type of yp_order()'s 3rd argument. + +2005-06-15 Erez Zadok <ezk@cs.sunysb.edu> + + * scripts/amd.conf-sample (map_type): typo, said mount_type + instead of map_type for the 'exec' example. + +2005-06-11 Erez Zadok <ezk@cs.sunysb.edu> + + ******************************************************************* + *** Released am-utils-6.1 *** + ******************************************************************* + +2005-06-04 Erez Zadok <ezk@cs.sunysb.edu> + + * amd/ops_nfs.c (mount_nfs_fh): set timeo/retrans mount options + only if the user specified them in amd.conf or elsewhere. If they + were not specified, don't do anything, which would let the OS use + its own defaults. + + * amd/get_args.c (get_args): negative timeo/retrans are "good" in + that they represent uninitialized values (meaning to let the OS + use it's default values). So only check if user specified a value + equal to zero (invalid). + + * amd/amd.h: define AMU_TYPE_NONE so we know when users didn't + specify timeo/retrans at all. + +2005-06-03 Erez Zadok <ezk@cs.sunysb.edu> + + ******************************************************************* + *** Released am-utils-6.1-rc7 *** + ******************************************************************* + + * m4/macros/os_cflags.m4 (CFLAGS): use custom-OS C flags for + configuring, not just for building. That way the two phases + (configure and compile) are in sync. This fixes getwire() on + OSF/1 systems. + + * conf/nfs_prot/nfs_prot_sunos5_8.h: define INADDR_NONE if not + defined in system headers. + +2005-06-01 Erez Zadok <ezk@cs.sunysb.edu> + + * libamu/Makefile.am (EXTRA_DIST): remove alloca.c as it's no + longer needed. + +2005-05-28 Erez Zadok <ezk@cs.sunysb.edu> + + * completed set of fixes for irix6.5. + + * Minor new ports alpha-unknown-linux-gentoo1.4.16 + alphaev56-dec-osf4.0f, mips-unknown-linux-gentoo1.4.16, and + sparc64-unknown-linux-gentoo1.4.16, and mips-sgi-irix6.5. Test + those systems with both cc and gcc, where possible. + + * include/am_xdr_func.h: remove trailing comma at end of enum + list. + + * m4/macros/os_cflags.m4: with gcc 3.4.3 on irix-6.5, we get pte_t + undefined. So give it a dummy value. + + * libamu/alloca.c: remove file from distro. + + * configure.in: don't call AC_FUNC_ALLOCA any more. + + * include/am_defs.h: remove header fixups for <alloca.h>, now that + we don't need it. + + * amd/amq_svc.c (amqsvc_is_client_allowed): rewrite function to + avoid only use of alloca() in am-utils, and to use strdup + explicitly. This way we can avoid using alloca, a feature that's + not portable on various systems. + + * amq/amq.c: remove unused lint/rcsid cruft. + +2005-05-27 Erez Zadok <ezk@cs.sunysb.edu> + + * conf/checkmount/checkmount_osf.c (fixmount_check_mount): add + extra parentheses around assignments in "if" expressions (gcc + complains). + + * conf/nfs_prot/nfs_prot_osf4.h: add missing extern definitions + for plock, hstrerror, getmntinfo, alloca, xdr_exportnode, and + xdr_groups. + + * configure.in: check for <linux/socket.h>, which, if found, + appears to be preferable to <sys/socket.h>. Use it to find + <linux/nfs_mount.h>. On some Linux systems + (Gentoo), both exist but only one must be included, or else you + get redefined structure errors. + + * libamu/wire.c (is_network_member): check if masknum is + INADDR_NONE, not "< 0" because it's an unsigned quantity. + + * libamu/util.c (xstrlcpy): remove useless test for size_t < 0, + because it's an unsigned quantity. + +2005-05-26 Erez Zadok <ezk@cs.sunysb.edu> + + ******************************************************************* + *** Released am-utils-6.1-rc6 *** + ******************************************************************* + +2005-05-25 Erez Zadok <ezk@cs.sunysb.edu> + + * conf/nfs_prot/nfs_prot_aix5_2.h: AIX 5.3 complains about + missing definition of struct thread_credentials in <sys/vfs.h> + but trying to bring that definition in drags a whole lot of other + messy stuff. So just provide a dummy definition for this + structure. + +2005-05-24 Erez Zadok <ezk@cs.sunysb.edu> + + * Makefile.am (EXTRA_DIST_M4): distribute m4/macros/libtool.m4. + + * m4/macros/header_templates.m4: template for HAVE_EXTERN_MNTCTL. + + * m4/macros/check_extern.m4: include <sys/vmount.h> on AIX + systems, so we can find extern definition for mntctl(). + + * conf/mtab/mtab_aix.c, conf/checkmount/checkmount_aix.c: only + define an extern for mntctl() if needed. + + * amd/ops_nfs.c (prime_nfs_fhandle_cache): never, ever, use C++ + style comments in C code. Some C compilers don't accept it. + + * amd/info_ldap.c (amu_ldap_init, get_ldap_timestamp): force cast + of "time_t *ts" to u_long, to avoid complaints on AIX 5.2 with + xlC. + + * amd/get_args.c: rename symbol conf_file to amu_conf_file to + avoid conflict with libldap.a from openldap-2.0.21 on AIX 5.2. + Oh, when will people who develop libraries learn to always prefix + their exported symbols with a library-specific name? + + * configure.in: check for mntctl() extern on AIX systems. + + * ltmain.sh: update from latest libtool-1.5.18, so we can properly + build on AIX 5.2/5.3 with cc and with gcc. + + * m4/macros/libtool.m4: update from latest libtool-1.5.18. This + time, and from now on, we must include libtool.m4 from the libtool + distribution itself. That way we ensure that we use an ltmain.sh + that matches the appropriate libtool M4 macros. This makes + am-utils no longer dependent on having libtool installed on a + given system on which you run bootstrap. + +2005-05-23 Erez Zadok <ezk@cs.sunysb.edu> + + * minor new port: i386-pc-linux-deb3.0. + +2005-05-22 Erez Zadok <ezk@cs.sunysb.edu> + + * minor new ports: i386-unknown-netbsdelf2.0.2 and + i386-unknown-openbsd3.7. + +2005-05-20 Erez Zadok <ezk@cs.sunysb.edu> + + * minor new ports: i386-pc-linux-gentoo1.4.16 and + powerpc-unknown-linux-yellowdog2.3. + + * include/{mount_headers2.h, am_defs.h}: safer setup before + inclusion of <linux/nfs_mount.h>, which is broken on several + systems. + + * configure.in: test for <linux/nfs2.h>. Separate special test + for <linux/nfs_mount.h> because we need to define __KERNEL__ for + that test, as well as optionally define struct nfs2_fh for some + systems (gentoo with 2.4 kernel, yellowdog 2.3, and others). + + * config.guess.long: support Gentoo and Yellow Dog Linux distros. + +2005-05-18 Erez Zadok <ezk@cs.sunysb.edu> + + * minor new ports: i386-pc-linux-suse9.2 and + i386-unknown-freebsd5.4. + + * amd/nfs_subr.c: use NFS_FHSIZE, not FHSIZE. + +2005-05-17 Erez Zadok <ezk@cs.sunysb.edu> + + ******************************************************************* + *** Released am-utils-6.1-rc5 *** + ******************************************************************* + + * amd/info_ldap.c (amu_ldap_init): change plog to dlog, to avoid + sending annoying warning for a minor issue. + +2005-05-17 Ion Badulescu <ionut@moisil.badula.org> + + * amd/nfs_subr.c: check for NULL pointer before dereferencing it. + +2005-05-16 Erez Zadok <ezk@cs.sunysb.edu> + + * minor new ports: powerpc-apple-darwin7.9.0. + + * m4/macros/host_macros.m4: if a NetBSD system, remove 'elf' part + from OS name because it's no longer relevant. Also, don't include + the major OS version number in the OS name because that's also + unnecessary (and users can always use $osver in maps). + + * amd/nfs_subr.c: use [1] for out-of-band pointer at the end of + struct am_fh, because it's the most portable method. Bug fix + suggestion from Dan Riley <dsr at mail.lns.cornell.edu>. Better + fix from Ion Badulescu: use [FHSIZE-sizeof(u_int)] which is the + actual size we use. + + * amd/amfs_generic.c (amfs_lookup_mntfs): reset currently used + def_opts to options given in -opts, appended with the /default + options. Bug fix suggestion from Dan Riley <dsr at + mail.lns.cornell.edu>. + +2005-05-13 Erez Zadok <ezk@cs.sunysb.edu> + + ******************************************************************* + *** Released am-utils-6.1-rc4 *** + ******************************************************************* + +2005-05-11 Daniel P. Ottavio <dottavio@ic.sunysb.edu> + + * amd/amd.c (main) : fixed memory leak detected by valgrind + + * amd/info_ldap.c (amu_ldap_init) : fixed memory leak detected by + valgrind + +2005-05-11 Erez Zadok <ezk@cs.sunysb.edu> + + * m4/macros/{check_checkmount_style.m4, check_mnttab_style.m4, + check_nfs_fh_dref.m4, check_nfs_prot_headers.m4, + check_nfs_sa_dref.m4, check_umount_style.m4, os_cflags.m4}: check + for "macosx" as valid OS string, so we compile properly on Darwin + systems. + + ******************************************************************* + *** Released am-utils-6.1-rc3 *** + ******************************************************************* + + * rerun bootstrap to get a working configure script that actually + checks for limits.h and dependent linux autofs/nfs headers. + + * configure.in: remove redundant check for limits.h. + +2005-05-09 Erez Zadok <ezk@cs.sunysb.edu> + + ******************************************************************* + *** Released am-utils-6.1-rc2 *** + ******************************************************************* + +2005-05-08 Erez Zadok <ezk@cs.sunysb.edu> + + * amd/amfs_generic.c (amfs_lookup_mntfs): removed redundant use of + old_def_opts variable. + +2005-05-08 Daniel P. Ottavio <dottavio@ic.sunysb.edu> + + * amd/amfs_generic.c (amfs_lookup_mntfs) : Make sure when a map + entry has a single dash '-', that the default options are reset. + This functionality was somehow lost from earlier releases and + reported by Dan Riley <dsr@mail.lns.cornell.edu>. + +2005-05-05 Erez Zadok <ezk@cs.sunysb.edu> + + * config.guess.long: detect SuSE Enterprise Server and call it + "sles" not "suse". + +2005-05-02 Erez Zadok <ezk@cs.sunysb.edu> + + * doc/am-utils.texi (amd): document proper use of + /etc/hosts.allow. Don't spawn a new Amd process because Amd will + get confused if someone else waitpid's on its children (which + often do important un/mount work). Issue reported by Francis + Montagnac <Francis.Montagnac at sophia.inria.fr>. + + * minor new ports: powerpc64-unknown-linux-rhel4, and + powerpc64-unknown-linux-sles9. + +2005-05-01 Daniel P. Ottavio <dottavio@ic.sunysb.edu> + + * amd/amfs_host.c (amfs_host_umount): We do not want to pass + ENOENT as an error because if the directory does not exists our + work is done anyway. + + * conf/umount/umount_linux.c (umount_fs): If we are successful or + there was an ENOENT, remove the mount entry from the mtab file. + +2005-05-01 Ion Badulescu <ionut@moisil.badula.org> + + * amd/nfs_subr.c: am_fh definition moved here from amd.h; + restructured to better reflect its duality (old/new filehandles) + (fh_to_mp3): fhh_gen is always used, even for new style f/h + (mp_to_fh): ditto + + * amd/amd.h: moved am_fh definition to nfs_subr.c (which is the + only place where it's used) + +2005-04-30 Erez Zadok <ezk@cs.sunysb.edu> + + * m4/macros/host_macros.m4: use sw_vers on Apple machines to find + out more appropriate OS name (macosx) and OS version (10.3.x) than + uname(3) reports. + +2005-04-29 Erez Zadok <ezk@cs.sunysb.edu> + + * config.guess, config.sub, doc/texinfo.tex: updates from latest + official GNU distributions. + + * m4/macros/host_macros.m4: for macosx, change architecture value + from "Power Macintosh" to "powerpc". + + * libamu/util.c (xstrlcpy): format 'len' parameter as u_long, not + int (it's a size_t). + +2005-04-16 Erez Zadok <ezk@cs.sunysb.edu> + + * scripts/amd.conf.5, doc/am-utils.texi (normalize_slashes + Parameter), scripts/amd.conf-sample: document new + normalize_slashes global configuration parameter. + + * amd/opts.c (deslashify, normalize_slash): don't touch trailing + slashes, even if multiples of them, if user said + normalize_slashes=no in amd.conf. + + * amd/conf.c (gopt_normalize_slashes): new function to record if + to normalize slashes or not. + + * amd/amd.h (CFM_NORMALIZE_SLASHES): new flag to decide if to + normalize double-slashes or not ("yes" by default). + + * amd/autil.c (am_mounted): pass TRUE when calling mf_mounted. + This is the parent mntfs which does the mf->mf_fo + (am_opts type), and we're passing TRUE here to tell mf_mounted to + actually free the am_opts. - * configure.in: don't check for dbm_open unless needed. + * amd/autil.c (mf_mounted): Be careful when calling free_ops and + XFREE here. Some pseudo file systems like nfsx call this + function, even though it would be called by the lower-level amd + file system functions. nfsx needs to call this function because + of the other actions it takes. So we pass a boolean from the + caller (yes, not so clean workaround) to determine if we should + free or not. If we're not freeing (often because we're called + from a callback function), then just to be sure, we'll zero out + the am_opts structure and set the pointer to NULL. The parent + mntfs node owns this memory and is going to free it with a call to + mf_mounted(mntfs,TRUE). - * m4/macros/header_templates.m4: template for NEW_DBM_H header - file. This completes the migration of bison/flex and n/dbm fixes - from 6.1 to to 6.0. + * amd/amd.h: pass flag to mf_mounted, to free or not to free the + am_opts. - * include/am_defs.h: Move ALLOCA logic here. - Add new db/ndbm/gdbm logic here. + * amd/amfs_nfsx.c (amfs_nfsx_cont): call mf_mounted with FALSE to + tell it not to free the am_opts, to avoid double free. - * fsinfo/fsinfo.h, fsinfo/fsinfo.c, fsinfo/fsi_lex.l, - amd/conf_tok.l: Fixes to avoid problems with modern yacc/lex - implementations. + * include/am_defs.h: include limits.h if found. - * amd/conf_parse.y: move ALLOCA checks out of yacc code. Fixes to - avoid problems with modern yacc/lex implementations. + * configure.in: check for limits.h. Check for certain Linux + headers such as auto_fs.h after checking for limits.h, and include + the latter if it exists, because some Linux headers depend on + limits.h. This prevents warnings during configure time. - * configure.in: search for gdbm/ndbm.h. Add logic to deal with - db/ndbm/gdbm mess. +2005-04-12 Erez Zadok <ezk@cs.sunysb.edu> + + * amd/amfs_toplvl.c (amfs_toplvl_mount): do NOT set retrans/timeo + values from default global UDP settings, because it can cause + unexpected timeouts in Amd on slow systems. The default that each + OS provides for these toplvl NFS mounts should be OK, or else you + can use the map_options entry. + +2005-04-09 Daniel P. Ottavio <dottavio@ic.sunysb.edu> + + * amd/nfs_subr.c (mp_to_fh): Replace xstrlcpy with memcpy because the + source buffer is treated more as a filehandle than a string. + + * amd/nfs_subr.c (fh_to_mp3): Replace xstrlcpy with memcpy because the + source buffer is treated more as a filehandle than a string. + + * amd/opts.c (free_op): No longer need to assign pointer to NULL + after XFREE. + + * amd/opts.c (expand_op): Revert back to using strncpy() instead + of xstrlcpy. The code is correct and relies on the semantics of + strncpy. + + * libamu/mount_fs.c (compute_nfs_args): Leave XXX warning that use + of xstrlcpy in NFS_HN_DREF may corrupt a struct nfs_args, or + truncate our concocted "hostname:/path" string prematurely if the + nap->hostname field is ever less than 64 bytes long + (MAXHOSTNAMELEN). + + * libamu/util.c (xstrlcpy): Return immediately if len is 0 to + avoid unnecessary work. Log an error and return if len is less + than 0. + +2005-04-07 Erez Zadok <ezk@cs.sunysb.edu> + + * include/am_utils.h (XFREE): XFREE() should nullify the pointer + even when compiling without debugging. It's safer this way. + + * libamu/xutil.c (am_set_hostname), + hlfsd/stubs.c (nfsproc_lookup_2_svc), + fsinfo/fsinfo.c (fsi_get_args), + fixmount/fixmount.c (is_same_host, remove_mount, main), + conf/mtab/mtab_isc3.c (mnt_dup, mtab_of), + conf/mount/mount_svr4.c (mount_svr4), + conf/mount/mount_linux.c (setup_loop_device), + conf/hn_dref/hn_dref_linux.h (NFS_HN_DREF), + conf/hn_dref/hn_dref_isc3.h (NFS_HN_DREF), + amd/opts.c (expand_op), + amd/ops_nfs.c (mount_nfs_fh), + amd/nfs_subr.c (fh_to_mp3, mp_to_fh), + amd/amfs_host.c (amfs_host_mount), + amd/am_ops.c (merge_opts): + use the new xstrlcpy instead of strncpy. + + * conf/checkmount/checkmount_{default,svr4}.c + (fixmount_check_mount): document why NOT to use xstrlcpy. + + * libamu/xutil.c: am_hostname need not be MAXHOSTNAMELEN+1 any + more, just MAXHOSTNAMELEN. + + * libamu/xutil.c (real_plog): use strlcpy (not xstrlcpy to avoid + recursion, since xstrlcpy may use plog). + + * libamu/util.c (xstrlcpy): truncating a string is serious. Use + XLOG_ERROR not XLOG_WARNING. + +2005-04-06 Erez Zadok <ezk@cs.sunysb.edu> + + * include/am_utils.h: external definition for new xstrlcpy + function. + + * libamu/util.c (xstrlcpy): new function. Similar to strncpy, but + uses strlcpy to guarantee that the resulting string is null + terminated, and also warn if the resulting string was truncated. + + * libamu/xutil.c (get_server_pid): move this function from util.c + which is for general-purpose utilities. + + * m4/macros/header_templates.m4: template for HAVE_EXTERN_STRLCPY. + + * include/am_defs.h: provide extern definition for strlcpy, if + needed. + + * libamu/Makefile.am (EXTRA_DIST): include strlcpy.c in distro. + + * configure.in: search for strlcpy and its extern. + + * amq/pawd.c (find_mt): It only handles *some* filesystem types, + so it breaks on direct xfs mounts for example. The fix (from + Christos Zoulas) is simple: We need to exclude toplvl to avoid + infinite recursion, but all other fs's are game. + +2005-03-31 Erez Zadok <ezk@cs.sunysb.edu> + + * amd/nfs_subr.c (fh_to_mp3): strncpy may not null terminate if + copying exactly len bytes, so add null just to be safe. + +2005-03-30 Daniel P. Ottavio <dottavio@ic.sunysb.edu> + + * amd/nfs_subr.c (fh_to_mp3): Increased the n of strncpy() + to make sure it null terminates. + +2005-03-29 Daniel P. Ottavio <dottavio@ic.sunysb.edu> + + * amd/nfs_subr.c (fh_to_mp3): Fix memset bug. In this case + the memset can be removed because strncpy() should padd the + buffer with NULLs anyway. + +2005-03-21 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> + + * include/am_defs.h: Clarify comment. + +2005-03-21 Erez Zadok <ezk@cs.sunysb.edu> + + * include/am_defs.h: undefine "GROUP" so Solaris 10 with gcc-2.96 + won't complain about a conflict for this definition between + <rpcsvc/nis.h> and <sys/acl.h>. + +2005-03-20 Erez Zadok <ezk@cs.sunysb.edu> + + * amd/readdir.c (amfs_readdir_browsable): use %p, not %lx. + + * libamu/mount_fs.c (print_nfs_args): print pointer with %p, not + %lx. + +2005-03-18 Erez Zadok <ezk@cs.sunysb.edu> + + ******************************************************************* + *** Released am-utils-6.1-rc1 *** + ******************************************************************* + +2005-03-18 Erez Zadok <ezk@cs.sunysb.edu> + + * conf/transp/transp_tli.c (get_nfs_version): use proper type for + versout on Solaris (rpcvcers_t). + + * amd/mapc.c (mapc_showtypes): if last map type to print, don't + append newline or comma to it. + + * libamu/mount_fs.c (print_nfs_args): cast struct netbuf pointer + to %lx because on Solaris 10 sparc gcc-3.4.3 complains about + casting it to an int (size is different). + + * configure.in, NEWS: prepare for 6.1-rc1 release. + +2005-03-17 Erez Zadok <ezk@cs.sunysb.edu> + + * scripts/amd2ldif.in, ldap.schema: fixes by Adam Morley + <adam-at-gmi-dot-com> to synchronize what amd2ldif does vs. what + the ldap.schema expects. + + * amd/map.c (exported_ap_free): We're using a free-list data + structure and re-using malloc'ed objects. So, to be safe, memset + entire structure when it's freed, not just the pointer. + (umount_exported): bug fix to on-exit code. Don't run + am_unmounted() unless unmount_mp() didn't run, since the latter + already calls am_unmounted(). This way we avoid a double-free + bug. + +2005-03-15 Erez Zadok <ezk@cs.sunysb.edu> + + * tasks: updates. Executable maps is supported. NFSv4 and + FreeBSD autofs isn't. + + * Makefile.am (EXTRA_DIST): include FAQ in distro. + + * doc/Makefile.am (alldocs): install README.lda and README.osx. + + * FAQ: new file, better late than never. + +2005-03-14 Erez Zadok <ezk@cs.sunysb.edu> + + * scripts/amd2ldif.in: patch to add the amdMapName attribute to + the amdMapTimestamp object when amd2ldif converts it. This is + necessary if you are using type:=auto mounts and want those + mountmaps looked up through LDAP. Patch from Jim Zajkowski + <jim.zajkowski@gmail.com>. + +2005-03-12 Erez Zadok <ezk@cs.sunysb.edu> + + * minor new ports: i386-pc-linux-rhel4. + + * minor new ports: powerpc-apple-darwin7.8.0. + +2005-03-10 Erez Zadok <ezk@cs.sunysb.edu> + + * amd/ops_nfs.c (prime_nfs_fhandle_cache): rearrange code so it's + cleaner. + + * ltmain.sh: upgrade from libtool-1.5.6. + + * m4/macros/check_{fs_mntent,mnttab_type,mount_type}.m4: check for + Linux 2.6 kernel modules, which have a .ko extension, not .o. Now + we can properly detect which file systems exist on Linux 2.6 based + systems (SLES9, RHEL4, Fedora, etc.). + +2005-03-09 Erez Zadok <ezk@cs.sunysb.edu> + + * m4/macros/host_macros.m4: find out what's the OS software + distribution name, if any. + + * m4/macros/header_templates.m4: template for DISTRO_NAME. + + * amd/get_args.c (get_version_string): print again full_os, os, + osver, and vendor (bug fix). + (get_version_string): print distribution name, if known (e.g., + rh9, suse8, etc.). + + * amd/mapc.c (mapc_showtypes): wrap around list of supported map. + +2005-03-08 Erez Zadok <ezk@cs.sunysb.edu> + + * amd/map.c (umount_exported): when unmounting file systems on + exit (when amd.conf global unmount_on_exit=yes), use unmount_mp() + instead of unmount_node() because the latter always unmounts in + the foreground, whereas the former unmounts in the bg/fg as + needed. Unmounting always in the foreground has two problems: (1) + if the unmount hangs, amd hangs, and (2) for type:=program, the + unmount script is execve'd(!) thus replacing the main amd process, + which never gets to finish up, leaving the amd mount points hung. + + * NEWS: mention new feature of executable maps. + + * AUTHORS: Acknowledge Erik Kline. + + * scripts/amd.conf.5: document executable maps and + exec_map_timeout parameter. + + * scripts/amd.conf-sample: examples of an executable map and + exec_map_timeout. + + * m4/macros/header_templates.m4: template for HAVE_MAP_EXEC. + + * doc/am-utils.texi: document Executable maps and exec_map_timeout + parameter. + + * amd/conf.c (gopt_exec_map_timeout): function to parse + exec_map_timeout [global] parameter. + + * amd/amd.h (AMFS_EXEC_MAP_TIMEOUT): define default executable map + timeout to 10 seconds, and a global placeholder for the + configurable value. + + * amd/amd.c (init_global_options): initialize default executable + map timeout. + + * amd/Makefile.am (EXTRA_amd_SOURCES): include info_exec.c in + tarball. + + * configure.in: enable executable maps. + + * amd/mapc.c: define executable map functions and behavior. + + * amd/info_exec.c: executable map implementation from Erik Kline + <ekline at ekline dot com>, modified, cleaned-up, and fixed. + +2005-03-07 Erez Zadok <ezk@cs.sunysb.edu> + + * amd/info_file.c (file_init_or_mtime): consolidate identical + file_init and file_mtime into one function. + +2005-03-05 Erez Zadok <ezk@cs.sunysb.edu> + + * doc/am-utils.texi (Program Filesystem): if umount/unmount are + not specified, Amd uses "umount ${fs}" by default. + + * amd/amfs_program.c (amfs_program_match): if neither unmount nor + umount parameters are specified, use the default userland umount + program with "umount ${fs}". This way type:=program doesn't have + to specify the umount program for basic unmounting actions. + (amfs_program_init): save unmount program string in mf_private + only if it's NULL, not based on mf_refc. + + * configure.in: auto-detect name of userland unmount program. + + * aux_conf.h.in (UNMOUNT_PROGRAM): macro for default userland + unmount program. + + * amd/ops_cachefs.c (cachefs_init): save unmount program string in + mf_private only if it's NULL, not based on mf_refc. + + * configure.in: don't "discover" inheritance file system any more, + since we don't have the .c file for it. + + * amd/get_args.c (get_version_string): hack to still show that we + support the inherit file system in output of amd -v. + +2005-03-05 Ion Badulescu <ionut@moisil.badula.org> + + * amd/amfs_inherit.c: removed, dead code + + * amd/Makefile.am, + amd/am_ops.c, + amd/amd.h, + conf/autofs/autofs_linux.h, + conf/autofs/autofs_solaris_v1.h, + conf/autofs/autofs_solaris_v2_v3.h, + m4/macros/header_templates.m4: removed references to amfs_inherit.c + +2005-03-05 Erez Zadok <ezk@cs.sunysb.edu> + + * amd/autil.c (am_mounted): completely rewrite the unmount + no/timeout code to (1) make more sense for odd conditions, and (2) + allow utimeout=N mount options to override FS_NOTIMEOUT default + flags for disk-based file systems such as ufs, pcfs, cdfs, etc. + + * libamu/mount_fs.c (mount_fs): use safer XFREE() not free(). + + * conf/umount/umount_linux.c (umount_fs): strtok is destructive, + so use strdup'ed string. + + * conf/mount/mount_linux.c (parse_opts): strtok is destructive, so + use strdup'ed string. + +2005-03-04 Erez Zadok <ezk@cs.sunysb.edu> + + * scripts/amd.conf.5, doc/am-utils.texi (cache_duration + Parameter): clarify actual behavior: this Parameter affects + initial mount timeout as well as the linear backoff what happens + the initial failed EBUSY unmount. + + * doc/am-utils.texi (opts Option): better explanation of + utimeout=N mount pseudo-option. + + * amd/amd.h (AM_TTL, AM_TTL_W): better comments, minor cleanup. + +2005-03-02 Daniel P. Ottavio <dottavio@ic.sunysb.edu> + + * AUTHORS: add Dan Ottavio. + + * scripts/amd.conf.5: document new debug_mtab_file option. + + * scripts/amd.conf-sample (debug_mtab_file): show example. + + * doc/am-utils.texi (debug_mtab_file Parameter): document new + option. + + * conf/mtab/mtab_{file,mach3}.c (open_locked_mtab): if mtab file + doesn't exist by the time Amd tries to exist, return a 0 rather + than hang indefinitely. + + * amd/conf.c (gopt_debug_mtab_file): new function to parse + debug_mtab_file option. + + * amd/amd.h: placeholder for debug_mtab_file string. + Define default debug_mtab_file to "/tmp/mtab". + + * NEWS: document new debug_mtab_file option. + +2005-03-02 Erez Zadok <ezk@cs.sunysb.edu> + + * conf/transp/transp_{sockets,tli}.c (amu_get_myaddress): when + users want Amd's NFS service to bind to some arbitrary "localhost" + address, show which address was actually resolved and bound to. + +2005-03-01 Erez Zadok <ezk@cs.sunysb.edu> + + * amd/srvr_nfs.c (start_nfs_pings): move code from elsewhere + (update_nfs_pingval) that initializes the pinger, as well as turns + it on/off as needed, and handles changing its value. This is to + avoid races and other infinite-loop conditions that could result + in ping storms. + + * amd/srvr_amfs_auto.c (amfs_generic_find_srvr): when creating a + new file server structure, default the ping value to AM_PINGER + (30sec) and set the FSF_PING_UNINIT flag. + + * amd/amd.h (FSF_PING_UNINIT): new flag to tell whether the NFS + pinger had been initialized for a given file server. + + * scripts/ctl-amd.in (stop): no need to check if + /var/lock/subsys/amd file exists if you do an rm -f afterward. + Ensure that proper return value is returned from script. + + * NEWS, doc/am-utils.texi (opts Option): update meaning of ping=N + so that if N=-1, pings are off; if N=0, pings are set to the + default value (currently 30 seconds). + +2005-02-28 Erez Zadok <ezk@cs.sunysb.edu> + + * amd/nfs_prot_svc.c (nfs_program_2): on TLI system, try to call + __rpc_get_local_uid to verify if the RPC call through the + local host interface came from UID 0. + + * configure.in: look for internal libnsl function + __rpc_get_local_uid (seems to be available on all known TLI + systems, Solaris and HP-UX 11). + + * conf/transp/transp_tli.c (amu_svc_getcaller): unnecessary + function for TLI systems (and it violated a array's bounds, + discovered with libumem.so). + (bind_resv_port, bind_resv_port_only_udp, get_autofs_address): + just to be on the safe side, set struct t_bind's qlen field to non + zero (64 by default). This value cannot be zero for TCP + connections, and it's unclear if it's good to have it zero for UDP + connections, so setting it to 64 is safer. + +2005-02-27 Erez Zadok <ezk@cs.sunysb.edu> + + * doc/am-utils.texi (opts Option, Keep-alives): update text on + ping option. + + * amd/srvr_nfs.c (update_nfs_pingval): new function to update NFS + server ping values, turn them off, or re-enable them. + (find_nfs_srvr): call update_nfs_pingval() as needed. + + * hlfsd/hlfsd.c (reaper, cleanup): don't use exit(3) in a signal + handler, but use _exit(2) instead. + + * amd/amd.c (parent_exit): This signal handler is called during + Amd initialization. The parent forks a child to do all the hard + automounting work, and waits for a SIGQUIT signal from the child. + When the parent gets the signal it's supposed to call this handler + and exit(3), thus completing the daemonizing process. Alas, on + some systems, especially Linux 2.4/2.6 with Glibc, exit(3) doesn't + always terminate the parent process. Worse, the parent process + now refuses to accept any more SIGQUIT signals -- they are + blocked. What's really annoying is that this doesn't happen all + the time, suggesting a race condition somewhere. + (This happens even if I change the logic to use another signal.) + I traced this to something which exit(3) does in addition to + exiting the process, probably some atexit() stuff or other + side-effects related to signal handling. Either way, since at + this stage the parent process just needs to terminate, I'm simply + calling _exit(2). Note also that the OpenGroup doesn't list + exit(3) as a recommended "Base Interface" but they do list + _exit(2) as one. This fix seems to work reliably all the time. + + * scripts/wait4amd2die.in: change default to recognize that amd is + down more quickly (check every 3 seconds instead of 5). + +2005-02-26 Erez Zadok <ezk@cs.sunysb.edu> + + * libamu/xutil.c (amu_release_controlling_tty): warn if closing + stdin/stdout/stderr failed. No need for tempfd. + + * scripts/ctl-{amd,hlfsd}.in: before running any real program in + these shell scripts, chdir to "/" to avoid possible hangs with + existing NFS mounts. This was causing ctl-amd's forked + grand-child amd process to hang if restartable_mounts=no. Go + figure. + +2005-02-25 Erez Zadok <ezk@cs.sunysb.edu> + + * minor new port ia64-unknown-linux-rhel4 + + * fsinfo/fsi_util.c (set_ether_if): avoid u_long casting to -1 + (RHEL4 gcc 3.4.3 ia64 compiler complains). + +2005-02-24 Erez Zadok <ezk@cs.sunysb.edu> + + * minor new port i386-unknown-freebsd6.0 (6.0-CURRENT-SNAP001). + +2005-02-23 Erez Zadok <ezk@cs.sunysb.edu> + + * minor new port: i386-pc-linux-rhel3. + + * INSTALL: major update of the compatibility list. + + * m4/macros/os_cflags.m4: set AMU_CFLAGS not AM_CFLAGS. + +2005-02-22 Erez Zadok <ezk@cs.sunysb.edu> + + * scripts/amd.conf.5, doc/am-utils.texi (preferred_amq_port): + document new preferred_amq_port [global] option. + + * scripts/amd.conf-sample (preferred_amq_port): example. + + * include/am_utils.h: add preferred_amq_port to prototype. + + * conf/transp/transp_tli.c (bind_preferred_amq_port): new function + to bind the Amq RPC service for UDP and TCP to a preferred port + (or to any port if preferred_amq_port==0). + (create_amq_service): decide if to bind to RPC_ANYFD, or to a + requested port. + + * conf/transp/transp_sockets.c (create_amq_service): if + preferred_amq_port is greater than 0, then bind to that port for + both UDP and TCP. If preferred_amq_port==0, then bind to any + port. + + * amd/nfs_start.c (mount_automounter): pass global + preferred_amq_port value to create_amq_service(). + + * amd/conf.c (gopt_preferred_amq_port): new function to parse + amd.conf value for preferred_amq_port. + + * amd/amd.h: placeholder for preferred_amq_port. + +2005-02-21 Erez Zadok <ezk@cs.sunysb.edu> + + * conf/transp/transp_tli.c (bind_resv_port_only_udp): rename old + bindnfs_port to a more proper name. This function binds the NFS + service to a specified port, and only for UDP. + + * conf/transp/transp_tli.c: cleanup some code, rename some + functions, in preparation for RPC amq port specification code. + +2005-02-19 Erez Zadok <ezk@cs.sunysb.edu> + + * */Makefile.am: don't redefine CFLAGS or LDFLAGS; they are + reserved for users to pass them on the command line. Instead, use + autoconf's internal AM_CFLAGS and AM_LDFLAGS. + + * depcomp, install-sh, missing, mkinstalldirs: update from latest + versions of Automake 1.9.2. + + * m4/macros/*.m4: properly quote AC_DEFUN'ed macro name, and fix + regexp/patsubst M4 commands. Newer versions of autoconf (e.g., + v2.59) complain about those. + +2005-02-17 Erez Zadok <ezk@cs.sunysb.edu> + + * amd/opts.c (f_xhost): if we don't have hstrerror, just print the + value of h_errno. + + * configure.in: include -lresolv if it defines the hstrerror() + function and not already available in existing libraries. + + * minor new port: powerpc-apple-darwin7.7.0. + + * amd/nfs_subr.c (mp_to_fh): pathlen should be u_int because it is + later compared against an unsigned quantity (complaint from gcc + 3.3 on SuSE 8.2) + + * include/am_utils.h: remove unnecessary (and conflicting) extern + for bind_resv_port2(), which is declared as static in + transp_tli.c. + + * doc/am-utils.texi, scripts/amd.conf.5, scripts/amd.conf-sample, + NEWS: document four new amd.conf options: nfs_retry_interval_udp, + nfs_retransmit_counter_udp nfs_retry_interval_tcp, and + nfs_retransmit_counter_tcp. + + * amd/ops_nfs.c (mount_nfs_fh): set timeo/retrans values based on + wether nfs_proto was "udp" or "tcp". + + * amd/amfs_toplvl.c (amfs_toplvl_mount): set retrans/timeo values + from default UDP settings (because toplvl mounts are UDP for now). + + * amd/get_args.c (get_args): use parameters to -t option to set + both UDP and TCP timeo/retrans values. + + * amd/conf.c: (gopt_nfs_retransmit_counter_udp, + (gopt_nfs_retransmit_counter_tcp, gopt_nfs_retry_interval_udp + (gopt_nfs_retry_interval_tcp): new functions to parse UDP and TCP + retrans/timeo parameters separately. + (gopt_nfs_retry_interval, gopt_nfs_retransmit_counter): if + specified, use it to set defaults for both UDP and TCP. + + * amd/amd.c (init_global_options): initialize default values of + both UDP and TCP retrans/timeo values to -1. + + * amd/amd.h (AMU_TYPE_{TCP,UDP,MAX}): define separate retrans and + timeo values, one for udp mounts and another for tcp mounts. + +2005-02-16 Erez Zadok <ezk@cs.sunysb.edu> + + * README.osx: new file with some instructions for Mac OS-X users, + courtesy Kevin Layer. + + * amd/get_args.c (get_args): move call to switch_to_logfile() + after processing -v, so we don't print "no logfile defined; using + stderr" when we're about to print version info and exit anyway. + + * minor new port: powerpc-ibm-aix5.3.0.0. + + * hlfsd/hlfsd.c (main): rewrite code to avoid negative array + references. + + * conf/checkmount/checkmount_aix.c: remove extern definition for + mntctl(), since AIX 5.3 has it in <sys/vmount.h>. + + * amd/info_union.c (union_reload): rewrite code to avoid negative + array references. + + * amd/opts.c (split_opts, expand_op): rewrite code to avoid + negative array references. + + * conf/mtab/mtab_aix.c: remove extern definition for mntctl(), + since AIX 5.3 has it in <sys/vmount.h>. + + * libamu/xutil.c (real_plog): rewrite code to avoid negative array + references. + + * libamu/wire.c (is_network_member): rearrange code slightly to + avoid negative array references (AIX 5.3 xlC 7.0 compiler + complains about it). + +2005-01-26 Erez Zadok <ezk@cs.sunysb.edu> + + * doc/am-utils.texi (xhost Selector Function): document new + selector function. + + * amd/opts.c (f_xhost): new function for use when matching the + "host" selector for the current host's name. This function will + now match the primary host name as well as all known aliases + (CNAMES) that gethostbyname() returns. This function now supports + a new function selector called xhost(ARG); the old host==ARG + selector is unharmed. + +2005-01-17 Ion Badulescu <ionut@moisil.badula.org> + + * NEWS: document the ability to restart old mount points + + * amd/map.c (mount_auto_node): force the fileid of the + root to be 1, so that it won't change between restarts; use the + root filesystem's own methods instead of hard-coding the use of + the default methods + + * conf/transp/transp_tli.c (create_nfs_service): better cleanup on + error conditions. + (bind_resv_port2): allow the caller to request a certain port. + + * conf/transp/transp_sockets.c (bind_resv_port): allow the caller + to request a certain port. + (create_nfs_service): better cleanup on error conditions. + + * amd/restart.c (restart_automounter_nodes): new function, takes + care of restarting automounter NFS mount points (autofs will come + later). + (restart): skip all automounter mount points. + + * amd/nfs_subr.c (fh_to_mp3, mp_to_fh): new filehandle + implementation: if the path to the node is shorter than sizeof(fh) + chars (currently 32 chars for a NFSv2 fh), simply store it inside + the fh. For longer paths, keep the old implementation. + + * amd/nfs_start.c (mount_automounter): reorder things so that + restarting the toplvl filesystems occurs before anything else (so + that we can grab all the ports we need before we accidentally use + them for something else). + + * amd/mntfs.c (locate_mntfs): remove dead code; add special + handling of restarted toplvl filesystems. + + * amd/mapc.c (root_keyiter): fix up a comment. + + * amd/map.c (path_to_exported_ap): new function, searches for and + returns a node by the path to it. + (get_root_nfs_fh): remove unnecessary fiddling with the root fh. + + * config.guess.long: support Red Hat Enterprise Linux + +2005-01-17 Erez Zadok <ezk@cs.sunysb.edu> + + * libamu/util.c (rmdirs): prevent amd from logging 'Read-only + filesystem' errors when the mount point has an ancestor (i.e. '/') + that is mounted read-only. Patch from David Rage <rage@ucl.ac.uk>. + +2005-01-17 Ion Badulescu <ionut@moisil.badula.org> + + * conf/umount/umount_linux.c (umount_fs): Linux doesn't need the + autofs space hack + + * conf/umount/umount_default.c (umount_fs): there is no need for + HAVE_LOOP_DEV, now that Linux has its own dedicated umount_linux.c + +2005-01-17 Erez Zadok <ezk@cs.sunysb.edu> + + * doc/am-utils.texi (Automatic Unmounting): document new umount2() + behavior on Linux. + + * conf/umount/umount_linux.c (umount_fs): new file. On Linux, if + umount(2) failed with EIO or ESTALE, try umount2(2) with + MNT_FORCE+MNT_DETACH. Based on patch from Christos Zoulas + <christos@zoulas.com>. + + * m4/macros/check_umount_style.m4: pick new linux umount style. + + * Makefile.am (EXTRA_DIST_CONF): distribute new umount_linux.c + file. + +2005-01-16 Erez Zadok <ezk@cs.sunysb.edu> + + * conf/nfs_prot/nfs_prot_aix{4_2,4_3,5_1,5_2}.h, + m4/macros/struct_nfs_args.m4: minor cleanups for quicker execution + of "nfs_args" test. + +2005-01-13 Erez Zadok <ezk@cs.sunysb.edu> + + * amd/get_args.c (show_usage): separate function to print usage + string. + (get_args) Call show_usage() from get_args when needed, then exit. + + * amd/get_args.c (get_version_string): print also domain, host, + and hostd. + (get_args): print version string at the very end, after all other + values had been initialized. Patch from Christos Zoulas + <christos@zoulas.com>. + + * conf/transp/transp_sockets.c (check_pmap_up, get_nfs_version), + conf/transp/transp_tli.c (check_pmap_up): correct an inconsistency + in timeouts in the RPC code between socket and TLI + implementations. The clntudp_create timeout has a different + meaning than the clnt_call timeout. Set the timeout of the create + to 2 seconds which means retry if no answer in two seconds, and + the timeout call to 6 seconds, which will give us consistently 2 + to 3 pings. This is useful on occasional network UDP loss where a + single packet loss would wrongfully mark a server down. (The TLI + code is the one that had the problem occurs.) Patch from Christos + Zoulas <christos@zoulas.com>. + + * libamu/mount_fs.c (compute_nfs_attrcache_flags): make sure code + compiles even for systems that don't have the nfs_args + ac{reg,dir}{min,max} fields. + + * amd/amfs_toplvl.c (set_auto_attrcache_timeout): just to be safe, + add "noac" if amd.conf option auto_attrcache was set to 0. This + should hopefully make the compute_nfs_attrcache_flags patch even + safer. + + * libamu/mount_fs.c (compute_nfs_attrcache_flags): separate + function to compute attribute-cache values. This function now + computes attribute-cache flags for BOTH Amd's automount points + (NFS) as well as any normal NFS mount that Amd performs. + (compute_nfs_args, compute_automounter_nfs_args): call + compute_nfs_attrcache_flags to figure out attribute-cache related + flags. Patch from Christos Zoulas <christos@zoulas.com>. + + * scripts/amd.conf-sample: show examples of new global options + domain_strip and auto_attrcache. + + * scripts/amd.conf.5: document new global options domain_strip and + auto_attrcache. Add warning to auto_attrcache use in case of + ESTALE. + + * doc/am-utils.texi: minor cleanups and document new global + options domain_strip and auto_attrcache. Add warning to + auto_attrcache use in case of ESTALE. + + * amd/conf.c (gopt_auto_attrcache): parse new global amd.conf + option auto_attrcache. + (gopt_domain_strip): parse new global amd.conf option + domain_strip. Part of a patch from Christos Zoulas + <christos@zoulas.com>. + + * amd/autil.c (host_normalize): don't call domain_strip() + unconditionally, but depend on the new global amd.conf flag + domain_strip. + + * amd/amfs_toplvl.c (set_auto_attrcache_timeout): new function to + set attribute cache timeout value given other configured global + defaults. + (amfs_toplvl_mount): set automount point attribute cache option + value to "noac" if attrcache=0, else set it to whatever + set_auto_attrcache_timeout() returns. + + * amd/amd.h (CFM_DOMAIN_STRIP, CFM_DEFAULT_FLAGS): flag to decide + if to strip the domain from the host name or not, default options + set to strip the domain. + Store global value of automount attribute cache timeout value. + + * amd/amd.c (init_global_options): add flag to record automount + point attribute cache value. + + * amd/amd.c (do_memory_locking): new function to encapsulate all + of the memory-locking functionality, which was in main() before. + Also added a call to madvise(), just in case. + (main): call do_memory_locking() to pin process memory if amd.conf + asked for it, but do so after the main Amd process daemonizes, + because mlock/mlockall is not inherited by fork() by default. + Slightly restructured patch from Jonathan Chen + <jon+amd@spock.org>. + + * configure.in: check for madvise(2). + + * config.guess, config.sub: updates for latest official GNU + versions. + + * m4/GNUmakefile: update paths to "make update" + +2005-01-12 Erez Zadok <ezk@cs.sunysb.edu> + + * conf/nfs_prot/nfs_prot_hpux11.h: define an nfs_fh3 structure + that's compatible for HPUX11 as well as NFSv3. + + * include/am_defs.h: On AIX 5.2, both <resolv.h> and + <arpa/nameser_compat.h> define MAXDNAME, if compiling with gcc + -D_USE_IRS (so that we get extern definitions for hstrerror() and + others). So undef MAXDNAME before it gets redefined. + + * include/am_defs.h: Solaris 10 (build 72) defines GROUP_OBJ in + <sys/acl.h>, which is included in many other header files. + <rpcsvc/nis.h> uses GROUP_OBJ inside enum zotypes. So if you're + unlucky enough to include both headers, you get a compile error + because the two symbols conflict. Temp hack: undefine acl.h's + GROUP_OBJ before including nis.h, because we don't need acl.h for + am-utils. + + * m4/macros/os_cflags.m4: turn -D_USE_IRS for AIX5+ so that + certain extern definitions of resolver functions become available. + + * amd/opts.c (expand_op): use #define for expand_error string + because some compilers complain about the use of static const + char[] inside a varargs function. + + * minor new port i386-unknown-netbsdelf1.6.2. + + * new port i386-unknown-netbsdelf2.0. + + * minor port i386-unknown-freebsd5.3. + + * libamu/mount_fs.c (compute_nfs_args): don't compare + nap->maxgrouplist against NULL but against 0 directly, because on + FreeBSD 4.3, NULL is defined is (void *)0 and gcc 3.4 complains + about a type mismatch. + + * minor port i386-pc-linux-fc3 (Fedora Core 3). + +2005-01-11 Erez Zadok <ezk@cs.sunysb.edu> + + * hlfsd/hlfsd.c (main): use sigsuspend() over sigpause(), because + FC3 doesn't have proper extern definition for the defunct + sigpause(). + + * configure.in: look for sigsuspend(). + +2005-01-01 Erez Zadok <ezk@cs.sunysb.edu> + + * updated copyright year to 2005 on all files. + +2004-11-29 Erez Zadok <ezk@cs.sunysb.edu> + + * scripts/amd.conf.5: Small fixes to typos in man page, from + Thomas Klausner <tk@giga.or.at>. + +2004-10-22 Erez Zadok <ezk@cs.sunysb.edu> + + * ldap.schema: add this file to distribution. + +2004-09-15 Erez Zadok <ezk@cs.sunysb.edu> + + * doc/am-utils.texi: fix old URLs. + +2004-09-01 Erez Zadok <ezk@cs.sunysb.edu> + + * conf/mtab/mtab_aix.c (read_mtab): avoid a race condition between + multiple calls to mntctl(). Patch suggested by Michael van Elst + <M.van.Elst@science-computing.de>. + +2004-08-07 Erez Zadok <ezk@cs.sunysb.edu> + + * doc/am-utils.texi (Program Filesystem): document how to get + double slashes in Amd maps. + + * amd/opts.c (normalize_slash): support escaped slashes, needed + for SMB mounts. Use '\\\/\\\/' in a string to get a double slash. + +2004-08-06 Erez Zadok <ezk@cs.sunysb.edu> + + * amd/amfs_program.c (amfs_program_match): bug fix. Complain if + both opt_unmount and opt_umount are missing, not when just one of + them is missing. + +2004-08-03 Erez Zadok <ezk@cs.sunysb.edu> + + * amq/pawd.c (find_mt): recognize "linkx" type mounts. Patch from + Hauke Fath <hauke@Espresso.Rhein-Neckar.DE>. Support "nfsx" while + we're at it. + + * doc/am-utils.texi: mention bugzilla. Fix broken URL HREF's. + +2004-08-02 Erez Zadok <ezk@cs.sunysb.edu> + + * amq/pawd.c (find_mt): recognize "host" type mounts. Patch from + Dan Nelson <dnelson@allantgroup.com>. + +2004-07-30 Erez Zadok <ezk@cs.sunysb.edu> + + * doc/am-utils.texi, NEWS: minor typos fixed. + +2004-07-30 Erez Zadok <ezk@play.cs.columbia.edu> + + * include/am_xdr_func.h: cannot have field-less structure; put a + dummy field in. + + * conf/autofs/autofs_solaris_v2_v3.c (xdr_autofs_rddirargs): cast + 2nd arg of xdr_u_int to a u_int*, not int*. + (autofs_mount_2_req): don't use C++ // comments. + +2004-07-30 Erez Zadok <ezk@cs.sunysb.edu> + + * m4/macros/{try_compile_anyfs,check_field}.m4: include + <fs/msdosfs/msdosfsmount.h> if it exists. Part of a set of + FreeBSD 5 patches from Martin Blapp <mb@imp.ch>. + + * include/am_defs.h: include <fs/msdosfs/msdosfsmount.h> if it + exists. + + * amd/ops_pcfs.c (mount_pcfs): set pcfs_args_t.dirmask field to + 0777 by default. + + * configure.in: check for pcfs_args_t.dirmask field. Check for + existence of <fs/msdosfs/msdosfsmount.h>, new on FreeBSD 5. + +2004-07-29 Erez Zadok <ezk@cs.sunysb.edu> + + * minor new port: i386-pc-linux-fc2 (Fedora Core 2). + + * amd/info_ldap.c (amu_ldap_rebind): don't use ldap_enable_cache() + unless the function exists in libldap and the extern is in + <ldap.h>. Recently, openldap removed the extern from ldap.h, but + left the function in libldap, for binary compatibility; however + ldap_enable_cache and related functions have been deprecated (and + no longer listed in the header files), and therefore should be + avoided. + + * m4/macros/check_extern_ldap.m4: new macro to check for + LDAP-specific externs. This is separate from check_extern.m4 so + as to avoid breaking the general-purpose macro with LDAP-specific + headers. + + * m4/macros/header_templates.m4: extern template for new + HAVE_EXTERN_LDAP_ENABLE_CACHE. + + * configure.in: call new check_extern_ldap.m4 macro. + + * Makefile.am (EXTRA_DIST_M4): distribute new check_extern_ldap.m4 + macro. + + * config.guess.long: distinguish between redhat and fedora-core + releases. + +2004-07-23 Erez Zadok <ezk@cs.sunysb.edu> + + * Minor new port i386-pc-linux-suse8.2: minor new port to SuSE + 8.2. This systems' latest GCC (gcc version 3.3 20030226 + prerelease) correctly caught a lot of possibly bad comparisons + between signed and unsigned quantities. + + * hlfsd/homedir.c (table_add, plt_search): changed first arg of + both functions to u_int. + + * hlfsd/hlfsd.h, hlfsd/hlfsd.c: change 'cache_interval' to u_int. + Changed proto for plt_search arg to u_int. + + * amq/amq.c (show_mi, main): change 'i' to u_int. + + * amq/pawd.c (find_mlp): change 'i' to u_int. + + * amd/srvr_nfs.c (find_nfs_srvr): change proto_nfs_version to + u_int. + + * amd/amd.h: change prototype of vreaddir and amfs_error_readdir + to use u_int count parameter. + + * amd/ops_TEMPLATE.c (foofs_readdir), amd/amfs_error.c + (amfs_error_readdir): change 'count' parameter in proto to u_int. + + * amd/amd.h: change proto of amfs_generic_readdir() to use u_int + count parameter. + + * amd/readdir.c (make_entry_chain): preflen should be u_int. + (amfs_readdir_browsable): change 'count' to u_int. + (amfs_generic_readdir): change 'count' to u_int. + + * amd/amd.h: amu_global_options's portmap_program field should be + u_long, not int (to match RPC conventions). Change am_fh's + fhh_gen field to u_int, to match am_gen field in struct am_node. + + * amd/conf.c (gopt_portmap_program): use atol() instead of atoi() + to avoid size differences. + + * conf/mount/mount_linux.c (find_unused_loop_device): cast to int + to avoid comparison between chars and integers. + + * libamu/mount_fs.c (get_hex_string): change 'i' to u_int to avoid + comparisons between signed and unsigned integers. + +2004-07-13 Erez Zadok <ezk@cs.sunysb.edu> + + * minor new port: i386-pc-linux-suse9.1. + + * include/am_defs.h: don't use __kernel_dev_t for dev_t on Linux, + because SuSE wants __kernel_old_dev_t. Instead, just define it + directly to what they both use: an unsigned short. + +2004-05-27 Erez Zadok <ezk@cs.sunysb.edu> + + * minor new port: i386-unknown-freebsd4.10 + +2004-04-29 Ion Badulescu <ionut@moisil.badula.org> + + * amd/amfs_generic.c (amfs_lookup_one_mntfs): fix the creation of + mountpoints for autofs-based sublinks the right way + +2004-04-28 Ion Badulescu <ionut@moisil.badula.org> + + Fixes for various memory management problems discovered by + Rainer's purify run: + + * conf/transp/transp_tli.c (check_pmap_up): zero out struct + timeval before using; + (get_nfs_version): ditto + + * amd/map.c (umount_exported): make sure we don't try to free the + same am_node multiple times, by setting its corresponding + exported_ap slot to null + + * amd/get_args.c (get_version_string): a static pointer is pretty + pointless, make it automatic + + * amd/conf.c (gopt_debug_options): remove unnecessary strdup(); + (gopt_log_options): ditto + (gopt_print_version): free version string after using it + + * amd/autil.c (mf_mounted): free mntfs->mf_fo instead of leaking + it + + * amd/amfs_generic.c (amfs_lookup_one_mntfs): use the CALLOC macro + (amfs_lookup_mntfs): free def_opts on return + + * amd/amd.c (daemon_mode): zero out struct sigaction before using + it; + (main): ditto + +2004-04-27 Ion Badulescu <ionut@moisil.badula.org> + + * amd/amfs_generic.c (amfs_lookup_one_mntfs): force FS_MKMNT on + the real mount of an autofs-based sublink + +2004-04-25 Ion Badulescu <ionut@moisil.badula.org> + + * amd/map.c (free_map_if_success): avoid dereferencing a pointer + to potentially freed memory + +2004-02-26 Erez Zadok <ezk@cs.sunysb.edu> + + * minor new port: i386-unknown-freebsd5.2.1. + +2004-01-30 Ion Badulescu <ion@guppy.limebrokerage.com> + + * scripts/ctl-hlfsd.in: don't run hlfsd with -D fork + +2004-01-25 Erez Zadok <ezk@cs.sunysb.edu> + + * minor new port: sparc64-unknown-linux-deb3.0 + + * config.guess.long: recoognize Debian Linux. + +2004-01-22 Erez Zadok <ezk@cs.sunysb.edu> + + * conf/transp/transp_tli.c (amu_get_myaddress): use + htonl(INADDR_LOOPBACK) and define INADDR_LOOPBACK if not already + available. + +2004-01-21 Erez Zadok <ezk@cs.sunysb.edu> + + * wire-test/wire-test.c, hlfsd/hlfsd.c (main): pass NULL as second + parameter to amu_get_myaddress(). + + * conf/transp/transp_tli.c (amu_get_myaddress): resolve value of + localhost_address amd.conf parameter, if defined (else default to + HOST_SELF_CONNECT). + Removed htonl() around socket address copying (I think it was + wrong) since plog("My IP address is...") in amd.c was printing + addresses wrong on Solaris x86.. + + * conf/transp/transp_sockets.c (amu_get_myaddress): comment out + old DEBUG code that warns if 127.0.0.1 isn't the same as what + get_myaddress() reports. Add code to resolve value of + localhost_address amd.conf parameter, if defined (else default to + 127.0.0.1). + + * amd/conf.c (gopt_localhost_address): new function to parse + amd.conf parameter localhost_address. + + * amd/amd.h: global field to store amd.conf localhost_address + parameter. + + * amd/amd.c (main): call amu_get_myaddress with global option, + which could have been set in amd.conf. + + * NEWS, doc/am-utils.texi, scripts/amd.conf-sample, + scripts/amd.conf.5: document new option localhost_address. 2004-01-20 Ion Badulescu <ionut@moisil.badula.org> @@ -54,21 +2620,6 @@ * minor new port: i386-unknown-freebsd5.2. - * hlfsd/hlfsd.c (hlfsd_init), amd/amq_subr.c - (amqproc_mnttree_1_svc, amqproc_stats_1_svc, - amqproc_getmntfs_1_svc, xdr_amq_mount_tree): force double casting - to avoid gcc-3.3 complaints on Solaris 9 about "dereferencing - type-punned pointer will break strict-aliasing rules". - -2004-01-06 Erez Zadok <ezk@cs.sunysb.edu> - - * minor new port: i386-unknown-freebsd4.9. - - * include/am_defs.h: Don't include malloc.h if stdlib.h exists, - because modern systems (e.g., BSD) complain if you use malloc.h - instead of stdlib.h. Let's hope there are no systems out - there that need both. - 2004-01-05 Erez Zadok <ezk@cs.sunysb.edu> * MIRRORS.{txt,html}: verify each mirror site, update to new @@ -76,9 +2627,15 @@ * updated copyright year to 2004 on all files. +2004-01-03 Erez Zadok <ezk@cs.sunysb.edu> + + * MIRRORS.txt: track status. + * Makefile.am (install-snapshot): new directory to install snapshots (now that am-utils home page is moved). +2004-01-02 Erez Zadok <ezk@cs.sunysb.edu> + * INSTALL, README.autofs: remove forced text-mode. * doc/am-utils.texi: fix Amd book URL. @@ -89,20 +2646,657 @@ doc/am-utils.texi: revisions to use newer URLs for Web site, FTP, and mailing lists. - * MIRRORS.{html,txt}: copied from 6.1 branch. + * MIRRORS.{html,txt}: updates. * doc/Makefile.am: install mirror lists officially. +2004-01-01 Erez Zadok <ezk@cs.sunysb.edu> + + * tasks: things to do after migrating ftp/Web sites. + +2003-12-09 Erez Zadok <ezk@cs.sunysb.edu> + + * fsinfo/fsinfo.8: fixed typo (unbalanced []) in man page. Bug + report from Eric S. Raymond <esr@thyrsus.com>. + +2003-11-18 Erez Zadok <ezk@cs.sunysb.edu> + + * Makefile.am (EXTRA_DIST_M4): exclude removed file + m4/macros/struct_nfs_fh3.m4 from distro. + +2003-10-24 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> + + * libamu/xdr_func.c (xdr_am_nfs_fh3): Use AM_FHSIZE3 instead of + FHSIZE3 (may be undefined). + +2003-10-24 Ion Badulescu <ion@guppy.limebrokerage.com> + + Compile fix for Solaris7 with LDAP: + + * include/am_defs.h: moved the ldap headers before am_nfs_prot.h + to facilitate using ldap types in it + + * conf/nfs_prot/nfs_prot_sunos5_7.h: add a couple of ldap + definitions that Sun left out of their headers + +2003-10-24 Ion Badulescu <ionut@moisil.badula.org> + + * conf/nfs_prot/nfs_prot_*.h: remove all NFSv3-related + definitions, they are now defined globally + + * libamu/xdr_func.c: unconditionally define all xdr functions + needed for NFSv3, but with an am_ prefix to prevent namespace + collisions + + * amd/amfs_host.c, amd/ops_nfs.c, amd/srvr_nfs.c, + libamu/mount_fs.c: added the am_ prefix to all + structures and functions having to do with NFSv3 to prevent + namespace collisions + + * include/am_utils.h: moved definition of am_nfs_handle to ... + + * include/am_xdr_func.h: ... here. Also define AM_FHSIZE3, + am_nfs_fh3, AM_NFSPROC3_LOOKUP, am_nfsstat3, am_fhandle3, + am_mountstat3, am_mountres3_ok, am_mountres3, am_filename3, + am_diropargs3, am_LOOKUP3args, am_LOOKUP3resok, am_LOOKUP3resfail, + am_LOOKUP3res here; remove cross-platform compile helper macros + AMU_LOOKUP3RES_*. + + * include/am_defs.h: include am_xdr_func.h before am_utils.h to + provide definitions for NFS filehandles + + * amd/amd.h: removed declaration for xdr_mountres3 + + * doc/am-utils.text: minor warning fix + + * BUGS: document the autoconf warnings when trying to compile + system header files in isolation + +2003-10-23 Ion Badulescu <ionut@moisil.badula.org> + + * m4/macros/struct_nfs_fh3.m4: removed, not needed + + * configure.in: check if struct mounta has the optptr field; + removed all NFSv3-related checks, we implement everything + internally now + + * conf/autofs/autofs_solaris_v2_v3.c (autofs_mount_2_free): don't + touch mnt->optptr unless HAVE_MOUNTA_OPTPTR is defined + +2003-10-22 Ion Badulescu <ionut@moisil.badula.org> + + * m4/macros/struct_nfs_fh3.m4: removed, not used anymore + + * libamu/xdr_func.c (xdr_am_nfs_fh3): update xdr_am_nfs_fh3 + comments + + * configure.in: don't check for xdr_nfs_fh3 and struct nfs_fh3, we + always use our own + +2003-10-22 Ion Badulescu <ion@guppy.limebrokerage.com> + + * BUGS: document the limitations of bind mounts on Linux + 2003-10-21 Ion Badulescu <ionut@moisil.badula.org> - * buildall: added support for -i (make install), other fixes from - the trunk + * buildall: added support for -i (make install) + +2003-10-16 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> + + * NEWS: New minor port i386-pc-solaris2.10 (Solaris 10). + * INSTALL: Mention its test status. + +2003-10-16 Erez Zadok <ezk@cs.sunysb.edu> + + * amd/ops_nfs.c (nfs_init): declare as static to match forward + definition at top of file. + + * conf/nfs_prot/nfs_prot_{hpux11, netbsd1_4,openbsd,aix5_2}.h: + added missing definitions for LOOKUP3res, diropargs3, etc. + +2003-10-15 Erez Zadok <ezk@cs.sunysb.edu> + + * libamu/xdr_func.c (xdr_LOOKUP3res, xdr_am_nfs_fh3), + libamu/mount_fs.c (compute_nfs_args), amd/ops_nfs.c + (got_nfs_fh_mount, got_nfs_fh_webnfs, prime_nfs_fhandle_cache, + webnfs_lookup), amd/amfs_host.c (fetch_fhandle): Attempt to + cleanup some inconsistencies with how we treat NFSv3 file handles. + Whenever we need to get data out of a filehandle given to us, we + assume that it uses the OS's native fhandle structure + (often struct nfs_fh3). When we store the fhandle data for our + own use, however, we store it in one of two ways. The first, is + that we use the system's default nfs_fh3 structure; the second is + that we define out own struct am_nfs_fh3 in nfs_prot.h (and go + through an elaborate autoconf song-and-dance to "discover" it as a + native fh3 handle structure). It appears that we do the latter, + instead of using the system's default fhandle structure, simply to + avoid extra malloc's and free's, because whereas nfsv2's fhandle + structure is a simple 32-byte buffer, nfsv3's fhandle structures + often just define a "char *" for the fhandle data, and the caller + must malloc/free the space inside as needed. Our code was never + written with constructor/destructor callbacks for these nfsv3 + filehandles. Moreover, we carefully wrote our own am_nfs_fh3 + structure so IT JUST SO HAPPENS to align with most (hopefully all) + of the fhandle structures for v3: first four bytes are the length + fields and the next four bytes are the fhandle data. Sigh. + Having this inconsistent use of v3 filehandles can be a real bear, + because we simply cannot avoid using the system's default fhandle + structure indirectly, through things like diropargs3 in + xdr_diropargs3(), which has inside of it a reference to the + system's default nfs_fh3 structure. ANYWAY, the current fix I've + come up with is to generalize the way we dereference field names + within the nfs_fh3 structure (whether ours or the system's) and + the same for the system's LOOKUP3res structure. I'm not pleased + with this fix; I'd rather we don't use our own am_nfs_fh3 + structure at all. + + * libamu/xdr_func.c (xdr_am_nfs_fh3): always define this + function if we have NFS3, because we often use our own, + incompatible am_nfs_fh3 structure. + + * include/am_xdr_func.h: We cannot use the native system's + xdr_nfs_fh3 because we are defining our own incompatible + am_hfs_fh3 structure for some systems. + + * include/am_xdr_func.h: Define default values for field names of + struct nfs_fh3 and LOOKUP3res. + + * doc/am-utils.texi (debug_options Parameter): minor typo fixed. + + * conf/nfs_prot/nfs_prot_freebsd3.h: FreeBSD uses different fields + names for struct nfs_fh3 and LOOKUP3res, so override the default + names here. + + * configure.in: AMU_CHECK_FS_MNTENT(nfs3) test before + AMU_STRUCT_NFS_FH3, because the latter depends on the former. + + * amd/ops_nfs.c (prime_nfs_fhandle_cache): add {} to disambiguate + and clarify if-the-else clauses. + +2003-10-13 Ion Badulescu <ionut@moisil.badula.org> + + * amd/get_args.c (get_version_string): change "Built by" to + "Configured by", and add a new "Built by" line using the variables + below + + * m4/update_build_version (vers): add BUILD_USER, BUILD_HOST, and + BUILD_DATE to build_version.h + + * amd/mntfs.c (locate_mntfs): fix restarted filesystems: mf_fo + must be initialized even for them, otherwise we lose opt_sublink + (and perhaps other options as well). Report from Rainer Orth. + + * amd/amfs_generic.c (amfs_bgmount): The fix for the mf_fo NULL + pointer dereferencing was a bit too aggressive and could end up + not processing the sublink option if the filesystem was already + mounted. + +2003-10-11 Ion Badulescu <ionut@moisil.badula.org> + + Fix restarted filesystem by disabling the amfs_inherit filesystem + and moving the restarting logic into the generic code. The old + code is still there, will be removed sometime in the near future. + + * amd/mntfs.c (locate_mntfs): disable amfs_inherit and simply + return the pointer to the restarted filesystem + (free_mntfs): check for the MFF_RESTART flag instead of the + amfs_inherit ops + + * amd/autil.c (mf_mounted): remove the MFF_RESTART flag once the + filesystem is in use + + * amd/amfs_nfsx.c (amfs_nfsx_init): only call fs_init() if the + filesystem is not being restarted + (amfs_nfsx_remount): if the filesystem is already mounted, + short-circuit the code and just continue + + * amd/amfs_generic.c (amfs_bgmount): only call fs_init() if the + filesystem is not being restarted; remove hack that was used to + work around an amfs_inherit problem + +2003-10-09 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> + + Use WebNFS to obtain file handles for mount(2). + + * NEWS: Document WebNFS support. + + * configure.in: Check for public mount option. + * include/am_compat.h (MNTTAB_OPT_PUBLIC): Define if missing. + * doc/am-utils.texi (opts Option): Renamed webnfs to public, + update description. + + * amd/amd.h (FSF_WEBNFS): New mntfs flag. + * include/am_utils.h (RPC_XID_WEBNFS): New XID type. + + * amd/amfs_host.c (amfs_host_mount, amfs_host_umounted): Reject + WebNFS mount/umount attempts. + * amd/ops_nfs.c (got_nfs_fh_mount): Renamed from got_nfs_fh. + (got_nfs_fh_webnfs): New function. + (flush_nfs_fhandle_cache): Don't invalidate port for WebNFS servers. + (prime_nfs_fhandle_cache): Likewise. + Remove unconditional return of public file handle for WebNFS, but + get NFS file handles via mountd or WebNFS instead. + (webnfs_lookup): New function. + (nfs_umounted): Don't inform mountd if MFF_WEBNFS. + * amd/rpc_fwd.c (fwd_packet, fwd_reply): Send/receive WebNFS + packets. + * amd/srvr_nfs.c (recompute_portmap): Don't contact portmap for + WebNFS servers. + Mention host in info message. + (find_nfs_srvr): Handle public mount option. + Prefer NFSv3/tcp if the client supports it. + Allow port mount option to override default or result from portmap + lookup. + + * libamu/xdr_func.c (xdr_diropargs3, xdr_filename3, + xdr_LOOKUP3args, xdr_LOOKUP3res, xdr_LOOKUP3resfail, + xdr_LOOKUP3resok, xdr_nfs_fh3, xdr_nfsstat3): New functions. + * include/am_xdr_func.h: Declare them. + * configure.in: Check for them. + * conf/nfs_prot/nfs_prot_linux.h: Provide missing NFSv3 + definitions and types. + +2003-10-09 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> + + Support IRIX 6 private mount option. + + * configure.in (AC_CHECK_MNTTAB_OPTS): Check for private option + name string. + (AC_CHECK_MNT2_NFS_OPTS): Check for private NFS mount option (IRIX 6). + * aux/macros/header_templates.m4 (MNTTAB_OPT_PRIVATE, + MNT2_NFS_OPT_PRIVATE): Provide templates. + * include/am_compat.h (MNTTAB_OPT_PRIVATE): Define if missing. + * doc/am-utils.texi (opts Option): Document it. + +2003-10-09 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> + + * doc/am-utils.texi (opts Option): Fix Tru64 UNIX name in proplist + mount option. + +2003-10-09 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> + + * libamu/mount_fs.c (compute_nfs_args) [HAVE_NFS_ARGS_T_FH_LEN]: + Don't reference removed fh3. + +2003-10-09 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> + + * NEWS: New minor port sparc-sun-solaris2.10 (Solaris 10). + + * INSTALL: Mention test status of various ports. + Describe IRIX 6 autofs status. + +2003-10-09 Ion Badulescu <ionut@moisil.badula.org> + + * NEWS: updated + + * amd/amfs_generic.c (amfs_bgmount): don't use mf_fo until after + we've done all the tests and we know we have a valid and mountable + mntfs. Otherwise we could end up dereferencing null pointers. + + * amd/amd.h: fixed a copy&paste comment bug + + * amd/am_ops.c (ops_match): minor code cleanup + + * doc/am-utils.texi: fixed various typos; added warning about the + racy nature of nfsx; removed duplicated listing of debug options; + added paragraph about signals supported by hlfsd; removed the long + list of (maybe) supported platforms since it duplicates the list + in INSTALL. + +2003-10-02 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> + + Simplify FD_SET etc. use. + + * include/am_defs.h (FD_SET, FD_ISSET, FD_CLR, FD_ZERO): Provide + if missing. + (rpc_pending_now, run_rpc): Use them. + * configure.in: Check for fds_bits field in fd_set. + * amd/nfs_start.c (run_rpc): Use it. + +2003-10-02 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> + + Improve RPC XID handling. + + * amd/rpc_fwd.c (fwd_packet, fwd_reply): Always log xid. + Convert xid to/from host/network byte order. + +2003-10-02 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> + + Use NFS V2/V3 file handles instead of mount results. + + * include/am_utils.h (am_nfs_fhandle): Use NFS V2/V3 file handles + only, not MOUNTPROC_MNT results. + * amd/amfs_host.c (fetch_fhandle): Use local variables to store + MOUNTPROC_MNT results. + * amd/autil.c (amfs_mount): Use new am_nfs_fhandle_t. + * amd/ops_nfs.c (struct fh_cache): New member fh_status. + (got_nfs_fh): Use local variables to store MOUNTPROC_MNT results. + Store MOUNTPROC_MNT errors in fh_status. + (prime_nfs_fhandle_cache): Get fh_error from fh_status. + * hlfsd/hlfsd.c (main): Use new am_nfs_fhandle_t. + * libamu/mount_fs.c (compute_nfs_args): Copy NFS V2/V3 file + handles straight from new am_nfs_fhandle_t. + +2003-10-02 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> + + * amd/clock.c (CID_ALLOC): Remove unused argument. + (timeout): Likewise. + + * amd/ops_nfs.c (FHID_ALLOC): Remove unused argument. + (prime_nfs_fhandle_cache): Likewise. + (call_mountd): Use UDPMSGSIZE instead of magic constant. + + * amd/rpc_fwd.c (XID_ALLOC): Remove unused argument. + (fwd_packet): Likewise. + Handle TLOOK error from t_rcvudata(). + +2003-09-30 Ion Badulescu <ionut@moisil.badula.org> + + * NEWS: updated + + * libamu/mount_fs.c (mount_fs): don't try to recreate the mount + point if the mount fails with ENOENT: in the best case we would be + papering over a bug, and in the worst case we could cause a + deadlock (with autofs). If there are races, they need to be + exposed and fixed properly. + + * conf/autofs/autofs_solaris_v1.h, + conf/autofs/autofs_solaris_v2_v3.h, + conf/autofs/autofs_linux.h: (AUTOFS_NFSX_FS_FLAGS): autofs + semantics don't allow us to mount nfsx directly onto an autofs + mountpoint, so disallow it + + * amd/amfs_nfsx.c (amfs_nfsx_match): more restrictive sanity check + to avoid trying to memmove(foo, bar, (unsigned)-1) due to invalid + map entries... + (amfs_nfsx_cont): amfs_retry does most of the cleanup work for us + in the upper layer, so don't do anything else beside wakeup() on + success + (amfs_nfsx_remount): only create the mountpoints as we need them, + avoids creating them on the wrong filesystem in the case of + hierarchical mounts; fix crash-generating typo (m should really be + mf and I swear I hate single-character variable names) + + * amd/amfs_generic.c (amfs_cont): one more dlog + (amfs_bgmount): amazingly enough, even foreground mounts can be + backgrounded (in the case of nfsx), so account for this + possibility and permit retries + + * m4/macros/check_autofs_style.m4 (AMU_AUTOFS_PROT_HEADER): define + and AC_SUBST it as ${top_builddir}/amu_autofs_prot.h + + * amd/Makefile.am ($(amd_OBJECTS) $(EXTRA_amd_OBJECTS)): depend on + @AMU_AUTOFS_PROT_HEADER@ + +2003-09-29 Erez Zadok <ezk@urd.fsl.cs.sunysb.edu> + + * minor new port mipsel-unknown-linux-rhPS2 (Linux on Sony + PlayStation 2) + + * amd/srvr_nfs.c (find_nfs_srvr): don't run code that expects + "char protocols[]" unless MNTTAB_OPT_PROTO is defined. + +2003-09-26 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> + + Consolidate alloca support. + + * amd/amq_svc.c: Move alloca support ... + * include/am_defs.h: ... here. + * amd/conf_parse.y: Remove alloca support. + * fsinfo/fsi_gram.y: Likewise. + +2003-09-25 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> + + Handle Solaris 10. + * m4/macros/check_nfs_prot_headers.m4 + (AMU_CHECK_NFS_PROT_HEADERS): Don't use wildcards for + sunos5.[0-3], solaris 2.[0-3], there were no micro releases. + Explicitly match sunos5*, solaris2* for Solaris 8 and beyond. + + * m4/macros/os_cflags.m4 (AMU_OS_CFLAGS): Dont use wildcards for + solaris2.[0-5], sunos5.[0-5], but explicitly handle Solaris 2.5 + micro releases to cope with Solaris 2.5.1. + Explicitly match solaris2*, sunos5*. + +2003-09-25 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> + + * amd/amq_svc.c: Provide alloca prerequisites. + + * conf/transp/transp_tli.c (register_autofs_service): Fix typo. + +2003-09-23 Ion Badulescu <ion@opteron.tower-research.com> + + * minor new port: x86_64-unknown-linux-rh2.9.5AS. (Red Hat + Enterprise Linux 3.0 beta running on a 64-bit AMD64 platform) + +2003-09-22 Ion Badulescu <ionut@buggy.badula.org> + + * conf/autofs/autofs_solaris_v1.c (autofs_mount_fs): compile fix + +2003-09-19 Ion Badulescu <ionut@moisil.badula.org> + + * amd/amfs_nfsl.c (amfs_nfsl_match): checking opt_fs is not always + enough, we should lstat() the sublink if it's defined. + (amfs_nfsl_ffserver): ditto + (ALL): Removed some obsolete comments. The nfsl code is now little + more than a very straight-forward switch between link and nfs. + + * amd/amfs_link.c (amfs_link_match): more up-to-date explanation + for the prepend-the-dot hack for type link; also, the sublink is + already normalized and absolute, so take advantage of that + + * amd/amfs_generic.c (amfs_lookup_one_mntfs): the sublink is + already normalized and absolute, so take advantage of that + + * amd/am_ops.c (ops_match): normalize the sublink here, early into + the matching process + + * amd/autil.c (am_mounted): be consistent and accept both + "nounmount" and "noumount" as pseudo mount options (same as + "unmount" and "umount" nearby) + + * amd/Makefile.am (build_version.h): fixed dependencies (depends + on amd_OBJECTS, not OBJECTS -- which doesn't even exist) + +2003-09-19 Erez Zadok <ezk@dhcp8.fsl.cs.sunysb.edu> + + * amd/amq_subr.c (amqproc_export_1_svc): force double casting to + avoid gcc-3.3 complaints on Solaris 9 about "dereferencing + type-punned pointer will break strict-aliasing rules". + +2003-09-16 Ion Badulescu <ionut@moisil.badula.org> + + * Released beta version 6.1b4 + +2003-09-15 Ion Badulescu <ionut@moisil.badula.org> + + * doc/am-utils.texi (opts Option): removed documentation for old + ignore_portmapper mount option, documented the new webnfs option + + * NEWS: webnfs support + + * amd/srvr_nfs.c (find_nfs_srvr): set MFF_WEBNFS if the "webnfs" + (former "ignore_portmapper") mount option is present + + * amd/ops_nfs.c (prime_nfs_fhandle_cache): generate a public + filehandle (all zeros) if MFF_WEBNFS is set + (nfs_umounted): don't talk to mountd if MFF_WEBNFS is set + + * amd/amd.h (MFF_WEBNFS): new flag, obvious meaning + +2003-09-13 Ion Badulescu <ionut@moisil.badula.org> + + * amd/srvr_nfs.c: renamed np_xid to global_xid; sanitized the + NPXID_ALLOC macro and renamed it to XID_ALLOC; renamed start_ping + to create_ping_payload; renamed nfs_pinged to + nfs_keepalive_callback; renamed nfs_timed_out to + nfs_keepalive_timeout; renamed nfs_srvr_port to get_mountd_port; + made ping_buf and ping_len arrays with one element for each + supported nfs version + + * amd/amd.h: renamed nfs_srvr_port() to get_mountd_port() + + * amd/amfs_host.c (amfs_host_init): ditto + + * amd/ops_nfs.c (call_mountd): ditto + +2003-09-03 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> + + * BUGS: Mention fix for broken Solaris 8 <rpcsvc/autofs_prot.h> + patches. + +2003-08-31 Erez Zadok <ezk@filer.fsl.cs.sunysb.edu> + + * amd/autil.c (strealloc): don't call malloc_verify() unless it + exists. + + * configure.in: move "OPTION PROCESSING" section (opt_debug etc.) + after we figure out PROG_CC and other compiler features, because + some of the option processing macros need a compiler to function. + + * libamu/xutil.c: don't define variables that won't be used unless + mallinfo() and malloc_verify() exist. + (real_plog): don't call checkup_mem unless + mallocinfo() and malloc_verify() exist. + (checkup_mem): don't define this function unless mallocinfo() and + malloc_verify() exist. + + * m4/macros/opt_debug.m4: check for functions malloc_verify and + mallinfo in general libraries and then in libmapmalloc and + libmalloc. These seem to have disappeared in FreeBSD 5.x. + + * libamu/xutil.c (dxfree): print pointer using %p + +2003-08-29 Erez Zadok <ezk@a-opendarwin.fsl.cs.sunysb.edu> + + * configure.in: start 6.1b4-pre officially (belated) + + * minor new port: i686-apple-darwin6.6 + +2003-08-27 Ion Badulescu <ionut@moisil.badula.org> + + * conf/autofs/autofs_solaris_v1.c: convert relative targets to + absolute paths when using lofs mounts + + * conf/autofs/autofs_solaris_v2_v3.c: ditto + + * conf/autofs/autofs_linux.c: ditto 2003-08-27 Ion Badulescu <ionut@buggy.badula.org> - * conf/nfs_prot/nfs_prot_freebsd3.h (na_uid): freebsd4.5 uses nfs - atttributes field named "uid". So #define na_uid to it. [backport - of Erez's 6.1 change from 2002-02-26] + * README.autofs: added a paragraph about the resource consumption + of auto maps over autofs + + * amd/amfs_generic.c (amfs_lookup_one_mntfs): moved the setting of + the MFF_IS_AUTOFS flag from init_mntfs() to + amfs_lookup_one_mntfs(), where it belongs + + * amd/mntfs.c (init_mntfs): ditto + +2003-08-27 Ion Badulescu <ion@guppy.limebrokerage.com> + + * amd/ops_nfs.c (got_nfs_fh): make the error EACCES if we are + denied a filehandle by the server (used to be EIO) + +2003-08-27 Erez Zadok <ezk@a-bsdi42.fsl.cs.sunysb.edu> + + * conf/nfs_prot/nfs_prot_bsdi3.h: support na_uid and na_gid. + +2003-08-27 Ion Badulescu <ionut@moisil.badula.org> + + * conf/autofs/autofs_linux.c (autofs_mount_succeeded): force + daemon-initiated timeouts on autofs filesystems, since apparently + they appear as "always busy" to the kernel-based expiration routine + +2003-08-26 Ion Badulescu <ionut@buggy.badula.org> + + * NEWS: updated + + * conf/autofs/autofs_linux.h (AUTOFS_LINK_FS_FLAGS): remove + FS_ON_AUTOFS + (AUTOFS_LINKX_FS_FLAGS): ditto + + * conf/autofs/autofs_solaris_v1.h (AUTOFS_LINK_FS_FLAGS): remove + FS_ON_AUTOFS + (AUTOFS_LINKX_FS_FLAGS): ditto + + * conf/autofs/autofs_solaris_v2_v3.h (AUTOFS_LINK_FS_FLAGS): remove + FS_ON_AUTOFS + (AUTOFS_LINKX_FS_FLAGS): ditto + + * amd/amfs_generic.c (amfs_lookup_one_mntfs): don't modify the + original opt_fs, instead store the new mount point for autofs in a + temporary variable and pass it around. Fixes a problem with the + link side of nfsl. + +2003-08-25 Ion Badulescu <ionut@moisil.badula.org> + + * NEWS: updated + + * amd/ops_nfs.c (prime_nfs_fhandle_cache): use get_mntfs_wchan to + initialize the fh_wchan member of the cache entry + (prime_nfs_fhandle_cache): use get_mntfs_wchan for the wchan_t + argument of call_mountd() + + * amd/map.c (free_map_if_success): use get_mntfs_wchan for the + wchan_t argument of wakeup() + + * amd/amfs_nfsx.c (amfs_nfsx_cont): use get_mntfs_wchan for the + wchan_t argument of wakeup_task() and wakeup() + + * amd/amfs_host.c (amfs_host_init): use get_mntfs_wchan for the + wchan_t argument of nfs_srvr_port() + + * amd/amfs_generic.c (ALL): use get_mntfs_wchan for the wchan_t + argument of sched_task() and wakeup() + (amfs_retry): minor cleanup + (amfs_bgmount): call nfs_quick_reply on failure + + * amd/sched.c (get_mntfs_wchan): new function which calls the + member function get_wchan if defined, otherwise returns the mntfs + pointer itself + + * amd/amfs_inherit.c (amfs_inherit_get_wchan): new function, + calls get_mntfs_wchan() on the inherited filesystem + + * amd/amfs_*.c, amd/ops_*.c: initialize the new get_wchan member + of the ops to 0 + + * amd/amd.h: new function type vget_wchan + (struct mntfs): new member get_wchan which returns the waiting + channel associated with the mntfs (normally itself) + +2003-08-22 Ion Badulescu <ion@guppy.limebrokerage.com> + + * conf/mount/mount_linux.c (parse_opts): minor cleanup + + * conf/autofs/autofs_linux.c (autofs_handle_fdset): added missing + break in case autofs_ptype_expire_multi + +2003-08-22 Ion Badulescu <ionut@moisil.badula.org> + + * conf/autofs/autofs_solaris_v1.h: undefine autofs support if + autofs_args_t cannot be determined (hopefully fixes a reported + IRIX 6.5.4 problem). + + * conf/autofs/autofs_solaris_v1.c: wrap entire file in #ifdef + HAVE_FS_AUTOFS / #endif (see above) + + * conf/autofs/autofs_linux.h: undefine autofs support if the + necessary header files are not found (fixes a reported RedHat 6.2 + Sparc problem). + + * conf/autofs/autofs_linux.c: wrap entire file in #ifdef + HAVE_FS_AUTOFS / #endif (see above) + + * libamu/mount_fs.c (compute_nfs_args): only use MNT2_NFS_OPT_SOFT + if autoconf detected it (fixes a reported RedHat 6.2 Alpha problem). + + * amd/map.c (unmount_mp, unmount_exported): move the code that + changes the fattr from NFLNK to NFDIR from unmount_mp to + unmount_exported, it was causing troubles (ESTALE) after failed + unmounts. This is still very very unclean, but it's the same as the + old 6.0 code. 2003-08-22 Nick Williams <Nick.Williams@morganstanley.com> @@ -110,16 +3304,870 @@ pointer as a string to plog, Solaris (and other OS's) don't like it and will dump core. +2003-08-13 Ion Badulescu <ion@guppy.limebrokerage.com> + + * amd/amd.h: introduced two new types, wchan_t and opaque_t, as + aliases of voidp. This makes reading the code easier on the eyes. :) + + * ALL: replace various instances of voidp with wchan_t and + opaque_t, as appropriate + +2003-08-13 Ion Badulescu <ionut@nicu.badula.org> + + * NEWS, configure.in: bumped version up to 6.1b4-pre + +2003-08-13 Ion Badulescu <ionut@moisil.badula.org> + + * Released beta version 6.1b3 + +2003-08-13 Ion Badulescu <ion@guppy.limebrokerage.com> + + * conf/autofs/autofs_linux.c (autofs_mount_fs): HACK: always use + symlinks for host mounts; assorted fixes for the symlink mode + +2003-08-05 Ion Badulescu <ionut@moisil.badula.org> + + * conf/umount/umount_default.c (umount_fs): enable space hack + handling for autofs v1 + + * amd/map.c (get_first_exported_ap, get_next_exported_ap): new + functions that facilitate iterating through the list of + mountpoints + + * amd/amfs_union.c (amfs_union_mounted): use get_first_exported_ap + and get_next_exported_ap + + * conf/autofs/autofs_solaris_v2_v3.c (autofs_unmount_2_req): ditto + +2003-08-04 Erez Zadok <ezk@ulkesh.dyn.optonline.net> + + * configure.in: check if system stores mount tables in files + (usually in /etc), and configure couldn't find a definition for + either struct mntent or struct mnttab. If so, abort configure + because this could be a new/misconfigured system, or a bug in + am-utils. + +2003-08-04 Ion Badulescu <ionut@moisil.badula.org> + + * conf/autofs/autofs_solaris_v2_v3.c (autofs_umount_fs): fix + compile warning + +2003-08-04 Ion Badulescu <ionut@buggy.badula.org> + + * conf/autofs/autofs_linux.c (autofs_mount_fs): don't call + ops->mount_fs() for an already mounted filesystem + (autofs_umount_fs): only call ops->umount_fs() if we're holding + the last reference to the filesystem + + * conf/autofs/autofs_solaris_v1.c (autofs_mount_fs): ditto + (autofs_umount_fs): ditto + + * conf/autofs/autofs_solaris_v2_v3.c (autofs_mount_fs): ditto + (autofs_umount_fs): ditto + + * amd/amfs_generic.c (amfs_lookup_mntfs): remove the shortcut for + already-mounted filesystems + (amfs_cont): only release the autofs_fh if the filesystem is not + mounted; add another comment about the NFS_SCALEDOWN hack + (amfs_bgmount): if the mntfs is already mounted, skip just the + filesystem initialization, but do call mount_node() + + * amd/map.c (mount_node): always call autofs_mount_fs(), but only + call ops->mount_fs() if the mntfs is not yet mounted + (unmount_node): always call autofs_umount_fs(), but only call + ops->umount_fs() if the refcount on the mntfs equals 1. + +2003-08-02 Erez Zadok <ezk@filer.fsl.cs.sunysb.edu> + + * conf/nfs_prot/nfs_prot_openbsd.h: include <ufs/ufs/ufsmount.h> + here with the proper workarounds for openbsd3.3 (define MAXQUOTAS, + define dummy struct netexport, and include <ufs/ufs/extattr.h> + wrapped in _KERNEL). + + * conf/nfs_prot/nfs_prot_freebsd3.h: include <ufs/ufs/ufsmount.h> + here with the proper workarounds for freebsd5.1 (define dummy + struct ufs_extattr_per_mount). + + * conf/nfs_prot/nfs_prot_bsdi2.h: include <ufs/ufs/ufsmount.h> + here with the proper workarounds for bsdi2 (define MAXQUOTAS and + dummy struct netexport). + + * include/mount_headers1.h: do not include <ufs/ufs/ufsmount.h> + here, b/c every *BSD system has some sort of problem in including + this header file, which includes ugly workarounds. Inclusion of + this header was already moved out of am_defs.h (used to compile + amd), but we forgot to move it out of mount_headers1.h (used to + configure). The specific inclusion of ufsmount.h is now in the OS + specific nfs_prot.h file. + + * configure.in: if configure could not find any definition for + "struct nfs_args", abort configure with an explanatory message. + There's no point in continuing, as this could be a system bug, + buggy am-utils, or a new system to which am-utils wasn't ported to + yet. + + * minor new port: i386-pc-solaris2.9 + +2003-08-01 Ion Badulescu <ionut@buggy.badula.org> + + * doc/am-utils.texi (NFS-Link Filesystem): make the documentation + match the code (as well as basic logic operations: the negation of + 'a or b' is 'not a and not b', not 'not a or not b') + +2003-08-01 Erez Zadok <ezk@filer.fsl.cs.sunysb.edu> + + * minor new port: i386-unknown-openbsd3.3. + + * m4/macros/check_libwrap_severity.m4: new macro to check if + libwrap includes the integer variables deny_severity and + allow_severity, since some libwrap implementations do and others + don't. The test tries to compile and run a simple empty main() + program, then the same program while defining these two variables: + comparing the results of the two tests, we can tell whether we + should define NEED_LIBWRAP_SEVERITY_VARIABLES. + + * Makefile.am (EXTRA_DIST_M4): distribute new macro + check_libwrap_severity.m4. + + * m4/macros/header_templates.m4: template for HAVE_LIBWRAP (which + we must define explicitly since we've overridden the + action-if-found in AC_CHECK_LIB(wrap). Also template for + NEED_LIBWRAP_SEVERITY_VARIABLES. + + * amd/amq_svc.c: if libwrap does not include the severity + variables, then define and initialize them here. + + * amd/Makefile.am (LIBS): explicitly include @WRAPLIB@ only for + Amd binary. Other am-utils binaries don't need -lwrap. + + * configure.in: if libwrap is found, only define it in @WRAPLIB@, + so we don't automatically link every am-utils binary with -lwrap. + Run test for existence of severity variables in libwrap. + +2003-07-31 Erez Zadok <ezk@filer.fsl.cs.sunysb.edu> + + * conf/nfs_prot/nfs_prot_openbsd.h: define struct fattr fields uid + and gid. + + * configure.in: move check for AC_CHECK_LIB(libwrap) as far down + as possible because on modern tcpwrapper systems such as openbsd, + the caller must provide two symbols: deny_severity and + allow_severity, which determine the logging level of rejected and + requested requests, respectively. If this check happens too + early, then $LIBS includes -lwrap, which causes many subsequent + tests that need to run a compiled program to fail with missing + symbols. + + * m4/macros/header_templates.m4: fix typo in template for + readdirplus. + + * configure.in: check for <ufs/ufs/extattr.h> (OpenBSD 3.3) + + * minor new port: i386-unknown-netbsdelf1.6.1. + + * configure.in: save state before system-specific tests are run. + + * m4/macros/check_gnu_getopt.m4: do NOT abort ./configure just + because the compiled test program failed to run. + +2003-08-01 Ion Badulescu <ionut@buggy.badula.org> + + * NEWS, README.autofs: updated + + * libamu/mount_fs.c (mount_fs): added support for the space hack + + * doc/am-utils.texi: mention than UFS/XFS/EFS/CacheFS filesystems + are not expired by default; correct and expand the section + describing the program filesystem + + * conf/autofs/autofs_solaris_v2_v3.h (AUTOFS_*_FS_FLAGS): add + FS_ON_AUTOFS for supported filesystems + + * conf/autofs/autofs_solaris_v2_v3.c (autofs_mount_fs): call + mf->mount_fs() + (autofs_umount_fs): call mf->umount_fs() + + * conf/autofs/autofs_solaris_v1.h (autofs_strdup_space_hack): add + prototype for malloc() + (AUTOFS_*_FS_FLAGS): lose the FS_MKMNT flags, add FS_ON_AUTOFS for + supported filesystems + + * conf/autofs/autofs_solaris_v1.c (autofs_mount_fs): add support + for the space hack; call mf->mount_fs() + (autofs_umount_fs): add support for the space hack; call + mf->umount_fs() + (autofs_mount_succeeded): add support for the space hack + + * conf/autofs/autofs_linux.h: lose the FS_MKMNT flags, add + FS_ON_AUTOFS for supported filesystems + + * conf/autofs/autofs_linux.c (AUTOFS_MAX_VERSION): define to + AUTOFS_MAX_PROTO_VERSION instead of hardcoding to 4 + (autofs_mounted): host mounts are now supported on all autofs + versions, remove the hack to turn it off on v3 + (autofs_mount_fs): call mf->mount_fs(), create/remove mountpoints + as needed + (autofs_umount_fs): call mf->umount_fs(), remove mountpoints on + success + (ALL): use '#if AUTOFS_MAX_VERSION >= 4' instead of + '#ifdef autofs_ptype_expire_multi' + + * amd/map.c (mount_node): autofs_mount_fs() now calls + mf->mount_fs() internally + (unmount_node): autofs_umount_fs() now calls mf->umount_fs() + internally + + * amd/autil.c (am_mounted): minor cleanup + + * amd/amfs_program.c (amfs_program_ops): added FS_MKMNT to + nfs_fs_flags + + * amd/amfs_generic.c (amfs_lookup_one_mntfs): use the FS_ON_AUTOFS + flag instead of hardcoding filesystem types + (amfs_bgmount): better mount_type logging + + * amd/amd.h (FS_ON_AUTOFS): new flag which tells the code that + this filesystem can be mounted directly onto an autofs mountpoint + +2003-07-31 Ion Badulescu <ionut@buggy.badula.org> + + * amd/amfs_nfsl.c (amfs_nfsl_umount): fix copy&paste error (was + calling amfs_link_ops.umount_fs() for NFS filesystems) + (amfs_nfsl_umounted): remove rmdirs() hack, it is now handled + properly elsewhere + (amfs_nfsl_ffserver): remove FS_MKMNT from mf_fsflags if we're + using link (not NFS) + +2003-07-31 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> + + * README.autofs: Correct IRIX spelling. + AutoFS support exists only on IRIX 6. + Update IRIX 6 status. + + Allow AutoFS V1 support to compile on IRIX 6. + * conf/autofs/autofs_solaris_v1.c (autofs_mount_1_req): Add + SVCXPRT * arg. + Remove superfluous \n from dlog messages. + (autofs_unmount_1_req): Likewise. + Switch to get_exported_ap. + (autofs_program_1): Invoke handlers with additional transp arg. + * conf/autofs/autofs_solaris_v1.h: Use autofs_args_t to define + autofs_fh_t, struct auto_args doesn't exist on IRIX 6. + + * conf/mount/mount_irix6.c (mount_irix) [HAVE_FS_AUTOFS]: Support + AutoFS mounts. + [HAVE_FS_LOFS]: Likewise for lofs mounts. + + * conf/nfs_prot/nfs_prot_irix6.h (AUTOFS_CONFTYPE): Define. + Don't disable AutoFS support any more. + + * conf/transp/transp_sockets.c [HAVE_FS_AUTOFS && AUTOFS_PROG] + (register_autofs_service): Define autofs_xprt. + + * m4/macros/check_autofs_style.m4 (AMU_CHECK_AUTOFS_STYLE): Update + Solaris 8+ comment to mention AutoFS V4. + (irix6*): Enable AutoFS V1 support on IRIX 6. + +2003-07-30 Erez Zadok <ezk@agora.fsl.cs.sunysb.edu> + + * NEWS, doc/am-utils.texi, scripts/amd.conf.5: revised explanation + of autofs_use_lofs. + +2003-07-30 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> + + * amd/ops_efs.c (efs_mount): Replace on_autofs arg with + MFF_ON_AUTOFS flag. + (efs_umount): Likewise. + +2003-07-30 Erez Zadok <ezk@filer.fsl.cs.sunysb.edu> + + * conf/umount/umount_bsd44.c (umount_fs): convert to new way of + unmounting which takes autofs into account. + +2003-07-30 Ion Badulescu <ionut@moisil.badula.org> + + * ALL: renamed MFF_AUTOFS to MFF_IS_AUTOFS; removed mf_real_mount + hack; pass a new on_autofs argument to mount/umount function, + based on the MFF_ON_AUTOFS mntfs flag + + * NEWS, README.autofs: updated + + * scripts/amd.conf.5: document new option autofs_use_lofs + + * scripts/amd.conf-sample (autofs_use_lofs): document new option + + * m4/macros/check_autofs_style.m4 (am_utils_link_files): symlink + the autofs header as amu_autofs_prot.h instead of slurping it into + aux_conf.h + + * libamu/mount_fs.c (mount_fs): removed old stub, renamed + mount_fs2 to mount_fs, added new argument on_autofs + + * doc/am-utils.texi (Direct Automount Filesystem): document + problems with nfs direct mounts on modern kernels, document good + autofs support for direct mounts on Solaris + (autofs_use_lofs Parameter): document this new option + (browsable_dirs Parameter): note that mount storms are avoided + when using autofs + + * conf/umount/umount_bsd44.c (umount_fs): removed old stub, + renamed umount_fs2 to umount_fs + + * conf/umount/umount_osf.c (umount_fs): removed old stub, + renamed umount_fs2 to umount_fs, added new argument on_autofs + + * conf/umount/umount_default.c (umount_fs): ditto as above; return + an error on ENOENT instead of faking success + + * conf/autofs/autofs_solaris_v2_v3.c (autofs_lookup_2_req): much + simplified, now only consults the map for existance of the key and + returns success if key is found + (autofs_mount_2_req): request symlinks if CFM_AUTOFS_USE_LOFS is + not on; + (autofs_mount_2_free): implemented + (autofs_unmount_2_req): use get_exported_ap() instead of + referencing export_ap directly + (autofs_mount_succeeded): remove code for replying to lookup + requests, now only mount requests can end up here + (autofs_mount_failed): ditto + + * conf/autofs/autofs_solaris_v1.h (AUTOFS_HOST_FS_FLAGS): removed + FS_AUTOFS + (AUTOFS_DIRECT_FS_FLAGS): added FS_DIRECTORY + + * conf/autofs/autofs_solaris_v2_v3.h (AUTOFS_HOST_FS_FLAGS): removed + FS_AUTOFS + (AUTOFS_DIRECT_FS_FLAGS): added FS_DIRECTORY + (AUTOFS_LINK_FS_FLAGS): added FS_MBACKGROUND + + * conf/autofs/autofs_linux.c (autofs_bind_umount): new function, + factored out of autofs_umount_fs() + (autofs_mount_fs): renamed from autofs_link_mount() and expanded + to deal with filesystems mounted indirectly (via lofs/bind + mounts) on autofs and to observe the new CFM_AUTOFS_USE_LOFS flag + (autofs_umount_fs): ditto, from autofs_link_umount() + + * conf/autofs/autofs_solaris_v1.c (autofs_mount_fs): ditto + * (autofs_umount_fs): ditto + + * conf/autofs/autofs_solaris_v2_v3.c (autofs_mount_fs): ditto + * (autofs_umount_fs): ditto + + * amd/opts.c: made fs_static static + + * amd/ops_nfs.c: made nfs_init, nfs_match, nfs_mount, nfs_umount + and nfs_umounted static + (mount_nfs_fh): removed unnecessary arguments + + * amd/ops_cachefs.c (cachefs_ops): use amfs_generic_find_srvr for + the ffserver method, because using NULL causes problems + + * amd/ops_cdfs.c (cdfs_ops): ditto + + * amd/ops_efs.c (efs_ops): ditto + + * amd/ops_lofs.c (lofs_ops): ditto + + * amd/ops_pcfs.c (pcfs_ops): ditto + + * amd/ops_ufs.c (ufs_ops): ditto + + * amd/ops_xfs.c (xfs_ops): ditto + + * amd/nfs_subr.c (fh_to_mp3, fh_to_mp, mp_to_fh): moved here from + map.c + + * amd/nfs_start.c: use get_exported_ap() instead of referencing + exported_ap directly + + * amd/mntfs.c (locate_mntfs): new function, factored out of + find_mntfs + (locate_mntfs): special-case FS_DIRECT filesystems: for direct + mounts we will have two filesystems mounted on the same m/p + (realloc_mntfs): removed the old EZK hack for failovers + + * amd/map.c (get_exported_ap): new function that returns an + exported_ap member by its index + (root_node,exported_ap,exported_ap_size,first_free_map,last_used_map): + made static + (fh_to_mp3, fh_to_mp, mp_to_fh): moved to nfs_subr.c + (get_root_ap): removed unused second argument + (unmount_mp): moved the mk_fattr(NFDIR) here from umount_exported + to catch more cases + (mount_node): call autofs_mount_fs after ops->mount_fs for autofs + nodes + (unmount_node): call autofs_umount_fs before ops->umount_fs for + autofs nodes + + * amd/conf.c: new global option "autofs_use_lofs", takes yes/no + values + + * amd/autil.c (amfs_mount): take an extra argument (mf) + (amfs_mount): call autofs_compute_mount_flags() for mounts + directly on autofs m/p + (am_unmounted): document and avoid the race between am_umounted() + at shutdown time and amfs_cont() + + * amd/amfs_union.c (amfs_union_mounted): use get_exported_ap() + instead of referencing internal map variables directly + + * amd/amq_subr.c (amqproc_export_1_svc): ditto + + * amd/amfs_toplvl.c (amfs_toplvl_ops): removed FS_AUTOFS from + nfs_fs_flags + (amfs_toplvl_mount): pass extra argument (mf) to amfs_mount() + (amfs_toplvl_umount): refuse to attempt the unmount if the + mountpoint is not a directory + + * amd/amfs_nfsx.c (amfs_nfsx_init): propagate the MFF_ON_AUTOFS + flag into the nfs f/s at the bottom of the stack + + * amd/amfs_nfsl.c: call nfs and link member functions through + their respective am_ops structures, not directly + + * amd/amfs_linkx.c (amfs_linkx_umount): new static stub + + * amd/amfs_link.c: made amfs_link_mount() and amfs_link_umount() + static functions + (amfs_link_mount): removed call to autofs_link_mount() + (amfs_link_umount): removed call to autofs_link_umount() + + * amd/amfs_host.c (amfs_host_ops): removed FS_AUTOFS from + nfs_fs_flags + (do_mount): removed superfluous function arguments + + * amd/amfs_direct.c (amfs_direct_ops): removed FS_AUTOFS from + nfs_fs_flags + + * amd/amfs_auto.c (amfs_auto_ops): removed FS_AUTOFS from + nfs_fs_flags + (amfs_auto_mount): pass extra argument (mf) to amfs_mount + + * amd/amd.h (CFM_AUTOFS_USE_LOFS): new flag, tells amd whether to + use lofs-mounts or symlinks when mounting on autofs + (CFM_DEFAULT_FLAGS): added CFM_AUTOFS_USE_LOFS + (VLOOK_LOOKUP): new flag, will merely check if a key exists + (MFF_IS_AUTOFS): renamed from MFF_AUTOFS + (MFF_ON_AUTOFS): new flag, tells amd if a f/s is mounted directly + on an autofs m/p, or indirectly via a lofs mount/symlink + (fh_to_mp2): macro expanded throughout the code and removed + (mntfs): removed mf_real_mount hack + (autofs_mount_fs): renamed from autofs_link_mount + (autofs_umount_fs): renamed from autofs_link_umount + (mount_lofs): exposed + various other cleanups, functions/variables made static and removed + + * aux_conf.h.in: removed @am_utils_autofs_style@, it is now + included directly as amu_autofs_prot.h + +2003-07-24 Erez Zadok <ezk@whitestar.dyn.optonline.net> + + * doc/am-utils.texi, scripts/amd.conf.5: document that + use_tcpwrappers is "yes" by default. + + * amd/amd.c (init_global_options): set default global options. + + * amd/amd.h (CFM_DEFAULT_FLAGS): define default options which + are always on (plock and use_tcpwrappers). + + * scripts/amd.conf-sample: reorganize values per option so default + one is listed first. + +2003-07-23 Erez Zadok <ezk@filer.fsl.cs.sunysb.edu> + + * tasks: trim old stuff. Discuss new parser. + + * amd/conf.c (set_conf_kv): initialize the very first map in conf + file from global defaults. Bug fix which was introduced after + conf.c code restructuring. + +2003-07-18 Erez Zadok <ezk@filer.fsl.cs.sunysb.edu> + + * m4/macros/header_templates.m4: template for + HAVE_EXTERN_HOSTS_CTL. + + * include/am_defs.h: define extern for hosts_ctl() if needed. + + * configure.in (AMU_CHECK_EXTERNS): check for extern definition + for libwrap's hosts_ctl() (FreeBSD 5.0 doesn't have it). + + * m4/macros/check_extern.m4: include tcpd.h if it and libwrap exist. + +2003-07-18 Erez Zadok <ezk@cs.sunysb.edu> + + * hlfsd/hlfsd.h: redundant extern for mboxfile removed. + + * amd/amq_svc.c (amq_program_1): only check for tcpwrappers if + amd.conf global option use_tcpwrappers=yes. + + * scripts/amd.conf.5, scripts/amd.conf-sample (use_tcpwrappers), + doc/am-utils.texi (use_tcpwrappers Parameter): document new + amd.conf global option. + + * amd/conf.c (gopt_use_tcpwrappers): define a new amd.conf global + option called use_tcpwrappers ("no" by default). + + * amd/amq_svc.c (amqsvc_is_client_allowed): include tcpd/libwrap + code only if both libwrap and tcpd.h exist. + (amq_program_1): log warning when an Amq service client is denied, + and a debug message when a client is allowed. + + * amd/amd.h (CFM_USE_TCPWRAPPERS): define [global] amd.conf flag. + (AMD_SERVICE_NAME): define AMD_SERVICE_NAME for tcpd/libwrap. + + * include/am_defs.h: include tcpd.h if available and libwrap + available. + + * configure.in: check for tcpd.h. + +2003-07-18 Erez Zadok <ezk@filer.fsl.cs.sunysb.edu> + + * scripts/expn.1, amd/amd.8 amq/amq.8, fixmount/fixmount.8, + hlfsd/hlfsd.8, scripts/expn.1: remove ".PD 0" nroff command + because it removes useful spaces in between paragraphs. Based on + smaller patch from Philippe Troin <phil@fifi.org>. + +2003-07-17 Philippe Troin <phil@fifi.org> + + * amq/amq.8: Document the libwrap/amd behavior. + + * amd/amq_svc.c (libwrap_check_client): New function to validate + an amq connection with libwrap. + (amq_program_1): Call libwrap_check_client() and close the + connection if libwrap does not allow it. + + * configure.in: Check for the tcp wrappers library. + 2003-07-17 Erez Zadok <ezk@filer.fsl.cs.sunysb.edu> + * amd/amq_subr.c (amqproc_mnttree_1_svc, amqproc_stats_1_svc, + amqproc_getmntfs_1_svc, xdr_amq_mount_tree), hlfsd/hlfsd.c + (hlfsd_init): cast pointers to void* before casting them to + another type, to avoid gcc-3.3 -Wall warnings. + * fsinfo/*.[hc]: rename fsinfo function log() to fsi_log(), to avoid conflict with builtin function in gcc-3.3. -2003-07-17 Philippe Troin <phil@fifi.org> +2003-07-17 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> + + * scripts/amd.conf-sample: Remove obsolete comment. + +2003-07-16 Erez Zadok <ezk@cs.sunysb.edu> + + * amd/info_file.c (read_line): check for errors from fgets(). + Although rare, they can occur upon disk or network failures. + Patch from Nick Williams <Nick.Williams@morganstanley.com>. + +2003-07-16 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> + + * BUGS (Solaris 8): Update patch revisions, mention old autofs + patches, fix filenames and rpcgen command. + +2003-07-15 Erez Zadok <ezk@agora.fsl.cs.sunysb.edu> + + * doc/am-utils.texi (map_defaults Parameter): document new + map_defaults option. + + * scripts/amd.conf.5: document new map_defaults option. + + * scripts/amd.conf-sample (map_type): show examples of new + map_defaults option. + + * amd/mapc.c (mapc_create): initialize mnt_map->cfm field to NULL. + + * amd/get_args.c (get_args): call process_all_regular_maps(). + + * amd/conf.c: keep head and tail of cfm list. + (init_cf_map): reworked reset_cf_map. This one doesn't reset a + globaly reused cfm, but rather just inherits [global] options. + (set_conf_kv): just store global/map options without actually + creating any mnt_map's. Essentially, we now parse the whole + amd.conf file, and then try to process the maps one at a time. + (process_one_regular_map): new function to process one map, just + renamed from process_regular_map. + (process_all_regular_maps): new exported function to process all + maps. No need for hacky process_last_map(). + (find_cf_map): new exported function to return a cf_map_t given a + map's mount point (e.g., /home or /net). + + * amd/amfs_generic.c (amfs_parse_defaults): find if amd.conf + specificed a map_defaults for a given map. If so, use that + instead of the /defaults that came from the map itself. Also + restructure code a bit so it's not one huge long "if" statement. + + HACK ALERT: there's no easy way to find out what the map mount + point is at this point, so I am forced to initialize the + mnt_map->cfm field here for the first time, upon the very first + search for a /defaults entry in this map. This initialization is + much better done in mapc_create(), but it's impossible to do that + there with the current code structure. + + * amd/amd.h: struct cf_map becomes linked list. struct mnt_map + includes pointer to cf_map_t, amd.conf defaults and options for a + given map. extern cleanups. + +2003-07-15 Erez Zadok <ezk@filer.fsl.cs.sunysb.edu> + + * amd/info_hesiod.c (hesiod_search): It's not possible to have a + key such as ".access" in a hesiod map as that would imply a null + node in the DNS tree. So a lookup for such a key must clearly + fail. With the current info_hesiod.c it does (after calling + hes{,iod}_resolve) but returns an error that confuses some + programs - eg. apache. This patch shortcuts the process and just + returns ENOENT for any key starting with ".". Patch submitted by + by Mark Davies <mark@mcs.vuw.ac.nz>. + + * include/am_utils.h (CALLOC): redefine macro to use xzalloc, not + fsinfo's own xcalloc. + + * fsinfo/fsi_util.c (xcalloc): remove redundant function. + +2003-07-14 Erez Zadok <ezk@cs.sunysb.edu> + + * include/am_compat.h (MNTTAB_OPT_XLATECOOKIE): The NetBSD + xlatecookie NFS option doesn't work as MNTTAB_OPT_XLATECOOKIE is + never defined. Define it as needed. Patch from Mark Davies + <mark@mcs.vuw.ac.nz>. + +2003-07-14 Ion Badulescu <lionut@gonzales.badula.org> + + * BUGS (Note): document the Solaris 8 bug (the upgrade to autofs + v4 without updating all the header files) + +2003-07-13 Ion Badulescu <lionut@gonzales.badula.org> + + * NEWS, tasks: updated + + * amd/amfs_generic.c (free_continuation): free _all_ mntfs's in + the am_mfarray, unconditionally + (amfs_bgmount): call free_mntfs when we're done with a mntfs, call + dup_mntfs when starting processing of a new one; make sure we + always go through 'goto failed' for a failed mntfs; use the error + code returned by autofs_get_fh() + + * conf/autofs/autofs_linux.c (autofs_get_fh): return proper error + codes in case of problems + +2003-07-13 Erez Zadok <ezk@filer.fsl.cs.sunysb.edu> + + * BUGS: Document buggy behavior of Solaris /usr/ccs/bin/lex. In + short, use flex. + +2003-07-13 Erez Zadok <ezk@a-hpux11.fsl.cs.sunysb.edu> + + * fsinfo/fsi_lex.l, amd/conf_tok.l: allocate more output slots so + lex scanners don't run out of mem. + +2003-07-13 Ion Badulescu <lionut@gonzales.badula.org> + + * amd/amfs_generic.c (amfs_lookup_mntfs): ditto as below for the + special provision + + * amd/mntfs.c (find_mntfs): compare the filesystem type + (i.e. mf_ops) in addition to mf_info; the special provision + mentioned below is really for any filesystem already mounted on + our mount point, not just for inherited filesystems + +2003-07-13 Erez Zadok <ezk@whitestar.dyn.optonline.net> + + * doc/Makefile.am (install-html): build per-chapter HTML manual, + as well as manual in one big HTML file. + + * doc/am-utils.texi: Minor corrections. Ack Ion's autofs work. + Ack maintainers. New section on How to get additionl info, + including the Amd book. Correct stale URLs and Emails. + + * amd/amd.8, amq/amq.8, amq/pawd.1, fixmount/fixmount.8, + fsinfo/fsinfo.8, hlfsd/hlfsd.8, mk-amd-map/mk-amd-map.8, + scripts/amd.conf.5, scripts/automount2amd.8, + wire-test/wire-test.8: include references to info pages, proper + authors, am-utils Web page, and amd book. + +2003-07-13 Ion Badulescu <lionut@gonzales.badula.org> + + * amd/mntfs.c (find_mntfs): re-add the check for mf_info, but with + a special provision for inherited filesystems. This unbreaks the + handling of parallel mounts + + * amd/amfs_generic.c (amfs_lookup_mntfs): for restarted + filesystems, there can be no alternative mntfs to try to mount + +2003-07-13 Erez Zadok <ezk@cs.sunysb.edu> + + * amd/amd.8: reference am-utils info page in amd man page, as per + Thomas Klausner <wiz@danbala.ifoer.tuwien.ac.at>. - * amd/amfs_auto.c (amfs_auto_mount): When pref:=NULL set am_pref - to strdup("") instead of NULL since this value will be - freed. Contributed by Matt Chapman <matthewc@cse.unsw.edu.au>. + * fsinfo/fsinfo.h, fsinfo/fsinfo.c (fsi_get_args): don't use + yywrap() if it doesn't exist. + + * amd/conf_parse.y, amd/conf_tok.l, fsinfo/fsi_gram.y, + fsinfo/fsi_lex.l: fixes to support old flex 2.5.4, as well as the + newer flex 2.5.31 (beta development). These include resolving + conflicts with yylineno, unput() vs. nounput(), etc. + +2003-07-13 Ion Badulescu <lionut@gonzales.badula.org> + + * amd/amfs_generic.c (amfs_cont): check for (am_error > 0) before + calling assign_error_mntfs() + (amfs_generic_mount_child): ditto + + * amd/autil.c (assign_error_mntfs): move the check for + (am_error > 0) up into the caller, it's less confusing that way + + * tasks: some updates + + * conf/transp/transp_tli.c (check_pmap_up): new function which + detects if the remote portmapper is functional + (amu_clnt_create_best_version): removed + (get_nfs_version): use a much simplified version of the old + amu_clnt_create_best_version(), based on clnt_create_vers() and + its _timed() counterpart + + * conf/transp/transp_sockets.c (check_pmap_up): new function which + detects if the remote portmapper is functional + (pmap_ping): deleted + (get_nfs_version): removed calls to pmap_ping, already done by + caller + + * amd/srvr_nfs.c: call check_pmap_up() before continuing with + get_nfs_version() + + * amd/amfs_generic.c: updated a couple of log messages + + * configure.in: detect clnt_create_vers and clnt_create_vers_timed; + changed LIBTOOL versioning to 3:0:0 + +2003-07-12 Ion Badulescu <lionut@gonzales.badula.org> + + * conf/autofs/autofs_linux.h (AUTOFS_HOST_FS_FLAGS): removed + FS_AUTOFS because the host mount cannot be a top level mount + (AUTOFS_DIRECT_FS_FLAGS): removed FS_AUTOFS because Linux autofs + doesn't support direct mounts + +2003-07-12 Erez Zadok <ezk@whitestar.dyn.optonline.net> + + * amd/conf_parse.y, amd/conf_tok.l: pretty comments on # cpp + macros. + +2003-07-10 Ion Badulescu <ionut@buggy.badula.org> + + * include/am_utils.h (dlog): improved version for gcc, using + vararg macros + + * amd/rpc_fwd.c (fwd_packet): unused variable when compiling + without debugging + +2003-07-10 Erez Zadok <ezk@filer.fsl.cs.sunysb.edu> + + * include/am_utils.h (dlog): change the #define of non-debugging + dlog to "nothing" so that all that'll be left behind is a list of + args in parenthesis (arg,arg,...). GCC and other native C + compilers seem OK with it, even if it doesn't optimize away the + whole debugging line. + + * ltmain.sh: was from libtool 1.4.2. updated to libtool 1.4.3, + the latest on RH9 systems (but is not the latest libtool + available). Stay with stable version in preparation for 6.1 + release. + + * config.{guess,sub}, doc/texinfo.tex: update to latest off of + ftp.gnu.org. + +2003-07-09 Erez Zadok <ezk@filer.fsl.cs.sunysb.edu> + + * amd/amfs_inherit.c (amfs_inherit_inherit): don't use // C++ + style comments: breaks non-C++ compilers (like AIX xlC 6) + +2003-07-02 Ion Badulescu <ionut@buggy.badula.org> + + * doc/am-utils.texi (opts Option): document ignore_portmapper option + + * conf/transp/transp_sockets.c (get_nfs_version): better + protocol/version cycling while probing remote server; better log + messages + + * amd/srvr_nfs.c (start_ping): improved log message + (find_nfs_srvr): always use requested nfs_version/nfs_proto; make + sure we have a valid NFS port; start the server as "valid, down" if + the remote portmapper tells us the NFS service is not running; + implement the "ignore_portmapper" pseudo-mount option + + * amd/rpc_fwd.c (fwd_packet): better debug messages + + * amd/ops_nfs.c (got_nfs_fh): log a messages if a root fh is + denied; call wakeup even if mountd call fails + + * amd/amq_subr.c (xdr_amq_mount_info_qelem): use FSRV_ISUP/ISDOWN + instead of checking the flags directly + * amd/srvr_amfs_auto.c (free_srvr): ditto + + * amd/amfs_generic.c (amfs_bgmount): refined some error/debug + messages + + * amd/amd.h (FSRV_ERROR): new macro + (FSRV_ISDOWN, FSRV_ISUP): a server that doesn't exist (i.e. it's a + local filesystem) is always up + +2003-06-30 Erez Zadok <ezk@cs.sunysb.edu> + + * amd/autil.c (am_mounted): set AMF_NOTIMEOUT if either unmount or + umount options are present. + + * doc/am-utils.texi (Program Filesystem): document alias options + to unmount:=, umount:=. + + * amd/opts.c (expansions): initialize opt_umount. + (to_free): initialize opt_umount. + + * amd/amfs_program.c (amfs_program_match): ensure that only one of + umount:= or unmount:= options are specified, but that at least one + of them is listed. + + * amd/amd.h: support unmount:=XXX as well as umount:=XXX (too + annoying in type:program, when one forgets the 'n' in "unmount"). + They are two separate fields, so we can catch mistakes when + someone tries to define both options. + + * doc/am-utils.texi (Program Filesystem): explain that both mount + and unmount options must be specified. Correct example to show + both. + +2003-06-25 Erez Zadok <ezk@cs.sunysb.edu> + + * XXX: beginning of new amd.conf option map_defaults: will parse + the option and set remember it in the right places. Need to + document this and actually hook it up with the rest of the code. + Any volunteers? :-) + + * scripts/amd.conf-sample (map_defaults): example of map_defaults + amd.conf option. + + * amd/conf.c (reset_cf_map): initialize global and per-mount + map_defaults. + (gopt_map_defaults): parse global map_defaults. + (process_regular_option,ropt_map_defaults): parse per-map + map_defaults amd.conf option. + + * amd/amd.h: a place to store global and per-mount map_defaults. + + * BUGS: more notes about AIX 5.2 problems and how to overcome + them. + +2003-06-10 Erez Zadok <ezk@cs.sunysb.edu> + + * doc/Makefile.am: force version.texi to be rebuilt regardless of + maintainer mode. Silly Automake will not build version.texi if + maintainer mode is off (this is hardcoded into the automake perl + script!). According to the Automake maintainers, users should + always build in CVS trees with maintainer-mode on; but what if I + don't want to?! I don't want to distribute Makefiles with + maintained rules in them to users. The Automake maintainers also + say that "make dist" will rebuild version.texi no matter what. I + find that not to be the case. It failed to run a "make" before + "make dist" because version.texi doesn't exist! Chicken and Egg + situation. So, until Automake deals with version.texi in a more + flexible and friendly manner, I adapted a rule to build + version.texi and inserted it in this Makefile.am. 2003-06-09 Erez Zadok <ezk@agora.fsl.cs.sunysb.edu> @@ -130,12 +4178,15 @@ 2003-05-08 Ion Badulescu <ion@guppy.limebrokerage.com> * libamu/mount_fs.c (compute_automounter_mount_flags): use - MNT2_GEN_OPT_AUTOMNTFS if available; minor cleanup, removed - redundant code for MNT2_GEN_OPT_OVERLAY + MNT2_GEN_OPT_AUTOMNTFS if available; minor cleanup * m4/macros/header_templates.m4: added template for MNT2_GEN_OPT_AUTOMOUNTED +2003-05-01 Ion Badulescu <ionut@nicu.badula.org> + + * amd/ops_xfs.c (mount_xfs): compile fix (s/genflags/flags/) + 2003-04-23 Erez Zadok <ezk@agora.fsl.cs.sunysb.edu> * conf/transp/transp_sockets.c (create_amq_service): minor cpp @@ -143,10 +4194,15 @@ 2003-04-22 Ion Badulescu <ionut@moisil.badula.org> - * conf/transp/transp_sockets.c (create_amq_service): Ugly *BSD fix for - an RPC library DoS issue (original patch from Martin Blapp, + * conf/transp/transp_sockets.c (create_amq_service): Ugly *BSD fix + for an RPC library DoS issue (original patch from Martin Blapp, massaged into something more digestable by me) +2003-04-14 Ion Badulescu <ionut@moisil.badula.org> + + * conf/autofs/autofs_solaris_v2_v3.c: removed autofs_free_data(), + left over from the recent cleanup + 2003-04-13 Erez Zadok <ezk@agora.fsl.cs.sunysb.edu> * doc/Makefile.am (DVIPS): use proper options for dvips. @@ -155,7 +4211,7 @@ and better explain the 'nounmount' option. Also some misc options for better generation of html manual. - * doc/Makefile.am (install-html): support newer text2html 4.0 + * doc/Makefile.am (install-html): support newer texi2html 4.0 options, as older options were renamed or changed behavior. * amd/autil.c (am_mounted): support new 'unmount' option, to allow @@ -172,6 +4228,11 @@ do not get added to Makefiles by default (they are confusing to users who don't have autotools installed). +2003-04-09 Ion Badulescu <ion@guppy.limebrokerage.com> + + * amd/mntfs.c (find_mntfs): revert the "change of philosophy" (see + the 2001-05-23 entry) back to the 6.0 code + 2003-04-04 Erez Zadok <ezk@agora.fsl.cs.sunysb.edu> * libamu/xutil.c (switch_to_logfile): don't try to print logfile @@ -183,6 +4244,13 @@ * fsinfo/fsinfo.8: typo co-ordinate -> coordinate. Typo report from Perry E. Metzger" <perry@piermont.com>. +2003-03-25 Erez Zadok <ezk@filer.fsl.cs.sunysb.edu> + + * include/am_defs.h: Don't include malloc.h if stdlib.h exists, + because modern systems (e.g., BSD) complain if you use malloc.h + instead of stdlib.h. Let's hope there are no systems out + there that need both. + 2003-03-20 Erez Zadok <ezk@suse73.fsl.cs.sunysb.edu> * minor new port: sparc64-unknown-linux-suse7.3. @@ -202,6 +4270,186 @@ scripts/amd.conf.5, scripts/expn.1: minor spell checking and extraneous space elimination. +2003-03-07 Ion Badulescu <ionut@buggy.badula.org> + + * conf/autofs/autofs_linux.c (autofs_get_fh): don't leak file + descriptors if limit exceeded + (autofs_mounted): call autofs_get_mp(); init am_autofs_ttl + (autofs_release_fh): release pending_mounts and pending_umounts + queues + (autofs_timeout_mp): update am_autofs_ttl instead of am_ttl + + * amd/mntfs.c (init_mntfs): delete initialization of removed + mf_autofs_fh + (uninit_mntfs): delete call to autofs_release_fh() + + * amd/map.c (init_map): init autofs_fh to 0, delete initialization + of removed autofs_data + (free_map): release autofs_fh after unmounting map; delete call to + autofs_free_data() + (umount_exported): call autofs_release_mp() prior to unmounting + autofs f/s + (unmount_mp): ditto + (free_map_if_success): call autofs_get_mp() if unmounting fails + (timeout_mp): use the dedicated am_autofs_ttl timeout for f/s-wide + timeouts instead of the per-mountpoint am_ttl + + * amd/autil.c (am_unmounted): release autofs_fh after unmounting + autofs f/s + + * amd/amfs_generic.c (amfs_cont): release autofs_fh if mounting + autofs f/s fails; + (amfs_bgmount): ditto + + * amd/amd.h: moved autofs_fh from mntfs to am_node, since it's + more related to the mount point than to the f/s mounted; + added am_autofs_ttl to am_node, for running expirations on entire + filesystems + + * conf/autofs/autofs_*: autofs_get_fh() returns int instead of + autofs_fh_t *; autofs_release_fh() now takes an am_node * parameter + instead of autofs_fh_t *, in an effort to not deal with + autofs-specific data structures outside autofs code; + new methods autofs_get_mp() and autofs_release_mp(), which + acquire/release autofs resources to allow clean unmount attempts; + nuke autofs_data_t, never used + + * amd/amd.h: prototypes for new and changed autofs functions + +2003-03-07 Ion Badulescu <ion@guppy.limebrokerage.com> + + * amd/nfs_subr.c (do_readlink): eliminate third argument, never used + (nfsproc_getattr_2_svc): reorganize the code a bit + + * amd/map.c (mk_fattr): take a nfsfattr * argument instead of an + am_node * argument + + * amd/amd.h: changed prototype for mk_fattr() + + * amd/autil.c (am_unmounted): when remounting, use the parent + node's lookup_child() and mount_child() operations, not the + generic ones + + * amd/amfs_generic.c (amfs_cont): minor code optimization + +2003-03-06 Ion Badulescu <ion@guppy.limebrokerage.com> + + * amd/amfs_auto.c: lots of renames and code moving: + amfs_auto_match() -> amfs_generic_match(), moved to generic; + amfs_auto_mkcacheref() -> amfs_mkcacheref(), moved to autil.c; + amfs_auto_mounted() -> amfs_generic_mounted(), moved to generic; + amfs_auto_umount() -> amfs_generic_umount(), moved to generic; + free_continuation(): moved to generic, made static; + assign_error_mntfs(): moved to autil.c; + amfs_auto_cont() -> amfs_cont(), moved to generic, made static; + amfs_auto_retry() -> amfs_retry(), moved to generic, made static; + try_mount() + mount_node() -> mount_node(), moved to map.c + amfs_auto_bgmount() -> amfs_bgmount(), moved to generic; + amfs_parse_defaults(): moved to generic; + amfs_auto_lookup_node() -> amfs_lookup_node(), moved to generic; + amfs_auto_lookup_one_mntfs() -> amfs_lookup_one_mntfs(), in generic; + amfs_auto_lookup_mntfs() -> amfs_lookup_mntfs(), moved to generic; + amfs_auto_mount_child() -> amfs_generic_mount_child(), in generic; + amfs_auto_lookup_child() -> amfs_generic_lookup_child(), in generic; + next_nonerror_node(): moved to autil.c; + amfs_auto_readdir() -> amfs_generic_readdir(), moved to readdir; + amfs_auto_readdir_browsable() -> amfs_readdir_browsable(), in readdir; + + * amd/amfs_toplvl.c: mount_amfs_toplvl() renamed to amfs_mount() + and moved to autil.c + + * amd/readdir.c, amd/amfs_generic.c: new files with stuff ripped + out of amd/amfs_auto.c + + * amd/amd.h: struct continuation moved to generic.c; prototypes + for the renamed functions; NumChild renamed to NumChildren + + * amd/map.c: collaped unmount_node_wrap() and unmount_node() into + the latter + + * amd/mapc.c: key_already_in_chain(): moved to readdir.c; + make_entry_chain(): moved to readdir.c; + + * amd/srvr_amfs_auto.c: find_amfs_auto_srvr() renamed to + amfs_generic_find_srvr() + + * amd/amfs_*.c: adjustments for the renames above + + * amd/ops_*.c: low-level filesystems don't need a find_server() + method + + * amd/Makefile.am: added amfs_generic.c and readdir.c + + * doc/am-utils.texi: minor clarification for auto maps + +2003-03-06 Ion Badulescu <ion@guppy.limebrokerage.com> + + * amd/amd.h: moved lots and lots of amd-only stuff here, from + include/am_utils.h; changed task_fun, cb_fun and fwd_fun typedefs + to be function typedefs, not pointer to function typedefs + + * include/am_utils.h: see above + + * amd/ops_nfs.c, amd/rpc_fwd.c, amd/sched.c: adjustments for + function typedef changes + +2003-03-05 Erez Zadok <ezk@cs.sunysb.edu> + + * BUGS: record IBM's patch number for the AIX 5.2 NFS over IPv6 + bug. + +2003-02-02 Erez Zadok <ezk@siamese.fsl.cs.sunysb.edu> + + * NEWS: minor new port: ia64-unknown-linux-rh2.1AS + +2003-01-31 Ion Badulescu <ion@console.limebrokerage.com> + + * m4/macros/os_cflags.m4: rhapsody and darwin are the same + + * amd/autil.c (mount_node): vastly simplified, just a wrapper now + + * amd/amfs_inherit.c (amfs_inherit_mount): remove the am_mounted() + hack, we now do it properly in the generic code + + * amd/amfs_auto.c (amfs_auto_bgmount): get the autofs_fh _before_ + forking the child; set and reset MFF_MOUNTING here, not in + mount_node(), because the latter might be running in child + context; call am_mounted() after a successful foreground mount + +2003-01-29 Ion Badulescu <ionut@moisil.badula.org> + + * configure.in: new flag --with[out]-ndbm; don't pull in libldap + if building --without-ldap; look for the gdbm/ndbm.h header; make + explicit the dependency between the ndbm headers and libraries; + define NEW_DBM_H as the ndbm header that should be used + + * include/am_defs.h: simply include NEW_DBM_H for ndbm stuff, + instead of trying to second-guess configure + + * m4/macros/header_templates.m4: new template for NEW_DBM_H + + * m4/macros/check_map_funcs.m4: + (ac_upcase_map_name): use the third argument correctly + + * ltmain.sh: working version from libtool-1.4.2-7 + + * buildall: print the entire configure command, including extra + arguments; pass each of the extra arguments separately, not + commingled into one + +2003-01-28 Ion Badulescu <ion@guppy.limebrokerage.com> + + * include/am_utils.h (DEBUG_MNTTAB): define outside of #ifdef + DEBUG; it is not used without DEBUG, but it is referenced at + compile time. Bug report from John Kilburg <john@physics.unlv.edu>. + (D_ALL): don't include D_XDRTRACE, too verbose and normally + unnecessary + +2003-01-28 Erez Zadok <ezk@cs.sunysb.edu> + + * ltmain.sh, config.guess, config.sub, doc/texinfo.tex: updates + from latest official GNU versions. + 2003-01-25 Erez Zadok <ezk@cs.sunysb.edu> * BUGS (Note): document AIX-5.1 NFS-client side bug (hangs in @@ -209,25 +4457,58 @@ 2003-01-25 Ion Badulescu <ionut@moisil.badula.org> - ******************************************************************* - *** Released am-utils-6.0.9 *** - ******************************************************************* + * Released beta version 6.1b2 -2003-01-23 Ion Badulescu <ion@guppy.limebrokerage.com> +2003-01-24 Ion Badulescu <ionut@moisil.badula.org> - * NEWS: updated for Darwin changes + * amd/autil.c (am_unmounted): reset MFF_MKMNT from mf_flags when + calling rmdirs() on mountpoint + + * amd/amfs_auto.c (amfs_auto_bgmount): ditto - * .cvsignore: added A.i386-apple-darwin6.0 and - A.sparc-sun-solaris2.9 + * amd/amfs_nfsl.c (amfs_nfsl_umounted): ditto + + * doc/am-utils.texi (opts Option): "sftlookup" -> "softlookup" + + * NEWS: "sftlookup" -> "softlookup" + + * amd/ops_nfs.c (nfs_mount): "sftlookup" -> "softlookup", also + check for "nosoftlookup" in combination with "soft" + +2003-01-23 Ion Badulescu <ion@guppy.limebrokerage.com> * m4/macros/check_nfs_fh_dref.m4: darwin/rhapsody is another freebsd22 derivative + * NEWS: updated for Darwin changes + + * .cvsignore: added A.i386-apple-darwin6.0 + + * m4/macros/os_cflags.m4: add -D_P1003_1B_VISIBLE to cflags for + Darwin + +2003-01-23 Erez Zadok <ezk@cs.sunysb.edu> + + * conf/mount/mount_aix.c (mount_aix3): clean back this file from + all the debugging cruft that is no longer needed (and really was + never needed in the first place). + +2003-01-10 Erez Zadok <ezk@cs.sunysb.edu> + + * scripts/test-amd.{misc,conf}: simple amd.conf and amd.misc + (map) files for testing basic amd functionality such as whether it + can mount its own mount NFS points. + 2002-12-28 Ion Badulescu <ionut@moisil.badula.org> * amd/srvr_nfs.c (start_nfs_pings): don't set FSF_PINGING if pings are disabled + * libamu/xdr_func.c (xdr_ftype): use a local enum_t variable + instead of casting the pointer to (enum_t *) + (xdr_mountstat3): ditto + (xdr_nfsstat): ditto + * libamu/misc_rpc.c (make_rpc_packet): fix make_rpc_packet() on 64-bit big-endian platforms, bug report from Bill Fenner <fenner@research.att.com> @@ -241,20 +4522,79 @@ * updated copyright year to 2003 on all files -2002-12-11 Ion Badulescu <ionut@moisil.badula.org> +2002-12-10 Erez Zadok <ezk@localhost.localdomain> - Solaris9 build fixes: + * rename "aux/" subdir into "m4/" so as to avoid problems with + MS-DOS systems (where "AUX" is a reserved name). This required + fixing numerous files. + +2002-12-10 Erez Zadok <ezk@filer.fsl.cs.sunysb.edu> - * amd/info_ldap.c (amu_ldap_rebind): call ldap_enable_cache() only - if configure detected it + * configure.in: don't check for bad hasmntopt() function if + hasmntopt() doesn't exist on the system, because we will replace + it with our own version anyway. - * configure.in: check for ldap_enable_cache() + * conf/transp/transp_sockets.c (amu_get_myaddress): use "%lx" in + dlog because htonl() returns a u_long. 2002-12-10 Erez Zadok <ezk@localhost.localdomain> - * rename "aux/" subdir into "m4/" so as to avoid problems with - MS-DOS systems (where "AUX" is a reserved name). This required - fixing numerous files. + * include/am_defs.h: use system's hasmntopt() only if it is found + and it is not buggy. + + * libamu/hasmntopt.c (nextmntopt): isspace() takes an int, not a + char. + + * amd/am_ops.c, amd/amfs_auto.c, amd/autil.c, amd/nfs_subr.c, + amd/ops_cdfs.c, amd/ops_nfs.c, amd/srvr_nfs.c, libamu/hasmntopt.c, + libamu/mount_fs.c, libamu/mtab.c: rename all uses of hasmntopt() + to amu_hasmntopt(). Don't use hasmntopt() directly any more! + + * aux/macros/func_bad_hasmntopt.m4: new M4 macro to test for a bad + hasmntopt() function, which incorrectly finds the option "soft" in + a string "hard,softlookup,ro". + + * libamu/hasmntopt.c (hasmntopt): use 'const' on two args to + hasmntopt(), to match what most systems use. + + * aux/macros/header_templates.m4: template for HAVE_BAD_HASMNTOPT. + + * configure.in: invoke test for bad hasmntopt() + + * NEWS: minor new port, i386-pc-linux-rh8.0. + Mention autofs-v4 on solaris9 works. + + * bootstrap: remove any autom4te-*.cache directories, now that + autoconf uses a version number for them. + +2002-12-09 Ion Badulescu <ionut@moisil.badula.org> + + Patches from Christos Zoulas: + + -1- am_utils.h: add full prototypes + -2- amfs_auto.c make functions static and add prototypes + -3- map.c: kill double free + -5- transp_sockets.c: add full prototypes + +2002-12-09 Ion Badulescu <ionut@moisil.badula.org> + + * NEWS: updated + + * doc/am-utils.texi (opts Option): document sftlookup + + * conf/autofs/autofs_solaris_v2_v3.c: compile fixes + +2002-11-22 Erez Zadok <ezk@filer.fsl.cs.sunysb.edu> + + * amd/info_ldap.c (amu_ldap_rebind): gopt.ldap_cache_seconds is + %ld not %d. + +2002-11-21 Erez Zadok <ezk@agora.fsl.cs.sunysb.edu> + + * {amd,fsinfo}/Makefile.am: remove special rules for processing + yacc/lex files, now that autoconf/automake properly handle them + better (esp. now that bison 1.75 behaves differently than older + bison versions). 2002-11-21 Erez Zadok <ezk@cs.sunysb.edu> @@ -263,79 +4603,402 @@ Linux Advanced Workstation release 2.1AW (Derry)". The script now will report ia64-unknown-linux-rh2.1AW. +2002-11-20 Ion Badulescu <ionut@moisil.badula.org> + + * amfs_auto_bgmount(): almost complete rewrite + + * fixed amfs_inherit to do the right thing and not dereference + freed mntfs'es + + * #if 0'ed bogus code in fh_to_mp3() -- it is now done properly in + amfs_autofs_lookup_child() + + * release the autofs_fh only in one place + + * remove the mountpoint only if mf_refc == 1 + + * print the mntfs type in free_mntfs() + + * new pseudo-mount option 'sftlookup' which causes lookups to + mounted shares from downed servers to return EIO; the default + depends on whether the mount is 'hard' or 'soft' + + * improved querying of supported NFS versions on the server -- + don't even try if it's known to be down + + * solaris autofs mount code moved to transp_{sockets,tli}.c + + * incipient (non-functional) AIX autofs support + 2002-11-11 Ion Badulescu <ion@guppy.limebrokerage.com> * doc/am-utils.texi (Keep-alives): removed outdated info about not maintaining the state of TCP NFS servers -2002-10-01 Ion Badulescu <ion@guppy.limebrokerage.com> +2002-11-04 Ion Badulescu <ion@guppy.limebrokerage.com> - * hlfsd/hlfsd.h: removed sys_nerr declaration + * include/am_utils.h: prototype for ops_search() - * amq/amq.c, hlfsd/hlfsd.c, libamu/xutil.c: always use strerror() + * amd/am_ops.c (ops_search): new function for searching the right + set of ops for a given filesystem type - * libamu/strerror.c: new file, strerror() implementation for - systems that don't have it + * amd/restart.c (restart): cleanup and split into two functions in + preparation for handling the restart of amd's own mount points + (restart_fake_mntfs): new function, factored out from restart() - * libamu/Makefile.am: added strerror.c +2002-11-04 Ion Badulescu <ionut@buggy.badula.org> - * include/am_utils.h: debug code improvements ported from 6.1 + * amd/ops_cdfs.c (mount_cdfs): remove special code for loop device + (cdfs_umount): ditto - * conf/mount/mount_aix.c: compile fix for --disable-debug + * conf/mount/mount_linux.c (mount_linux): factor it out to + mount_linux_nfs() and mount_linux_nonfs() + (mount_linux_nonfs): generalize loop device support to all + filesystems (not just cdfs); make it automatic for anything that's + a regular file + (parse_opts): deprecate the explicit "loop" mount option + (do_mount_linux): minor cleanup -2002-09-09 Ion Badulescu <ion@guppy.limebrokerage.com> + * conf/umount/umount_default.c (umount_fs2): release loop device + on umount() - ******************************************************************* - *** Released am-utils-6.0.8 *** - ******************************************************************* +2002-11-03 Erez Zadok <ezk@cnm20> + + * include/am_defs.h: moved #include of net/if.h above net/route.h, + because on AIX 5.2 if.h is needed for route.h (let's hope it + doesn't break things on other systems). + + * include/am_defs.h: AIX 5.2 needs struct sigevent from signal.h + to be defined, but I don't want to move the inclusion of signal.h + this early into this file. Luckily, amd doesn't need the size of + this structure in any other structure that it uses. So we + sidestep it for now. + + * conf/nfs_prot/nfs_prot_aix5_2.h: AIX 5.2 wants 'struct pathcnf', + but I couldn't find its definition anywhere. Luckily, amd doesn't + need the size of this structure in any other structure that it + uses. So we sidestep it for now. + +2002-11-02 Erez Zadok <ezk@cs.sunysb.edu> + + * config.guess, config.sub, doc/texinfo.tex: updates from + the latest GNU distributions (2002-09-05). + +2002-10-30 Erez Zadok <ezk@agora.fsl.cs.sunysb.edu> + + * conf/nfs_prot/nfs_prot_aix5_2.h: add more definitions from + mount.h for NFSOPT_* and NFSMNT_*. + Don't use typedefs that aren't found in system header files. + +2002-10-30 Erez Zadok <ezk@cs.sunysb.edu> + + * Makefile.am (EXTRA_DIST_CONF): distribute nfs_prot_aix5_2.h. + + * conf/nfs_prot/nfs_prot_aix5_2.h: new file. + + * aux/macros/struct_nfs_args.m4 (ac_cv_have_struct_nfs_args): look + for "struct aux52_nfs_args". + + * aux/macros/check_nfs_prot_headers.m4: define new header file for + AIX 5.2. -2002-09-09 Ion Badulescu <ion@guppy.limebrokerage.com> +2002-10-21 Erez Zadok <ezk@agora.fsl.cs.sunysb.edu> - * amd/srvr_nfs.c (nfs_timed_out): add #ifdef DEBUG around dlog + * scripts/amd.conf.5 (ldap_proto_version): document in amd.conf + man page. + + * scripts/amd.conf-sample (ldap_proto_version): show example of use + + * doc/am-utils.texi (ldap_proto_version Parameter): document new + amd.conf option. + + * amd/conf.c (gopt_ldap_proto_version): new conf function to + support ldap_proto_version amd.conf parameter. + + * amd/amd.h: field to hold LDAP protocol version. + + * amd/amd.c (init_global_options): set default for + ldap_proto_version. ldap_proto_version patch from George Ross + <gdmr@dcs.ed.ac.uk> and Tim Colles <timc@inf.ed.ac.uk>. + + * amd/info_ldap.c (amu_ldap_unbind): ignore SIGPIPE errors while + unbinding from an LDAP server that may have been restarted. Fix + from George Ross <gdmr@dcs.ed.ac.uk>. + +2002-09-17 Ion Badulescu <ion@guppy.limebrokerage.com> + + * remove all autoconf stuff added for sys_nerr + + * amq/amq.c, libamu/xutil.c, hlfsd/hlfsd.c: always use strerror + + * libamu/strerror.c: more explicit text for unknown errno's + +2002-10-01 Erez Zadok <ezk@cs.sunysb.edu> + + * include/am_defs.h: define "extern int sys_err" if needed. + + * aux/macros/header_templates.m4: template for + HAVE_EXTERN_SYS_NERR. + + * hlfsd/hlfsd.h, libamu/xutil.c (expand_error), amq/amq.c + (show_mi): remove "extern int sys_err" + + * configure.in: execute test for "extern int sys_err" + + * Makefile.am (EXTRA_DIST_AUX): distribute new extern_sys_err.m4 file. + + * aux/macros/extern_sys_nerr.m4: new test to check for existence + of "extern int sys_nerr" definition in system headers. + +2002-09-17 Ion Badulescu <ion@guppy.limebrokerage.com> + + * libamu/xutil.c (dbg_opt): bring comments in line with the code + + * hlfsd/hlfsd.c (main): use amuDebug() instead of touching + debug_flags directly + + * amd/amd.c (main): don't init debug_flags, leave it as zero (no + debugging by default) + +2002-09-11 Ion Badulescu <ion@guppy.limebrokerage.com> + + Debug code sanitization: + + - amuDebug() becomes an expression, and explicit if() statements + are added around it throughout the code + - amuDebugNo() goes away (ugh!) + - D_AMQ, D_DAEMON and D_FORK reverse their meaning + - D_ALL contains only options that don't affect amd's functionality 2002-09-04 Ion Badulescu <ion@guppy.limebrokerage.com> - * amd/mntfs.c (free_mntfs): sanity check for mf_refc [patch from - George Ross ported from 6.1] + * amd/amfs_auto.c (free_continuation): avoid double-free'ing the + mntfs if there was an error/timeout + +2002-09-04 Ion Badulescu <ion@guppy.limebrokerage.com> + + * amd/amfs_auto.c (amfs_auto_lookup_mntfs): use ereturn() instead + of "return NULL" to signal an error to the upper layers + (amfs_auto_mount): use strdup so the string can be free'd later on + [Debian bug report from Matt Chapman <matthewc@cse.unsw.edu.au>] + +2002-09-03 Ion Badulescu <ion@guppy.limebrokerage.com> + + Patches from George Ross <gdmr@dcs.ed.ac.uk>: + + * amd/amfs_auto.c (assign_error_mntfs): do not discard old mntfs, + it will be done in free_continuation(); assorted debugging messages * amd/srvr_nfs.c (nfs_timed_out): allocate a new XID on server - timeout to avoid problems with late ping replies [patch from - George Ross ported from 6.1] + timeout to avoid problems with late ping replies + + * amd/mntfs.c (free_mntfs): sanity check for mf_refc; assorted + debugging messages + + * amd/map.c (unmount_node): more verbose debug message + +2002-07-29 Ion Badulescu <ion@guppy.limebrokerage.com> + + * amd/amfs_auto.c (amfs_auto_lookup_mntfs): prevent deferencing + de-allocated memory in str3cat + (amfs_auto_lookup_mntfs): check for buffer overflow 2002-07-11 Erez Zadok <ezk@agora.fsl.cs.sunysb.edu> * scripts/expn.{1,in}: fixed typos as reported by Thomas Klausner <wiz@danbala.ifoer.tuwien.ac.at>. -2002-06-26 <ezk@agora.fsl.cs.sunysb.edu> +2002-06-26 Erez Zadok <ezk@agora.fsl.cs.sunysb.edu> * doc/Makefile.am (install-html): don't use locally hacked texi2html features. + * conf/transp/transp_sockets.c (amu_get_myaddress): Most modern + systems should use 127.0.0.1 as the localhost address over which + you can do NFS mounts. In the past we found that some NFS clients + may not allow mounts from localhost. So we used get_myaddress() + and that seemed to work. Alas, on some other systems, + get_myaddress() may return one of the interface addresses at + random, and thus use a less efficient IP address than 127.0.0.1. + The solution is to hard-code 127.0.0.1, but still check if + get_myaddress() returns a different value and warn about it. + * doc/am-utils.texi: don't use ':' in @cindex entries. -2002-06-24 Ion Badulescu <ionut@moisil.badula.org> +2002-06-25 Ion Badulescu <ion@guppy.limebrokerage.com> - * doc/am-utils.texi (automount2amd): minor rewording + * Released beta version 6.1b1 + +2002-06-24 Ion Badulescu <ionut@moisil.badula.org> * aux/macros/struct_nfs_args.m4: added test for aix51_nfs_args * conf/nfs_prot/nfs_prot_aix5_1.h: rename aix42_nfs_args to - aix51_nfs_args, rename unknown fields to u<number> + aix51_nfs_args, rename unknown fields to u<number>, add the + unknown new field into the middle of the old 4.2 structure 2002-06-24 Ion Badulescu <ion@guppy.limebrokerage.com> - * buildall: use ksh for configure on aix5.1; pass the extra - arguments after "--" to configure, not to make; fix 'buildall -b' - on hpux9 and aix5.1 + * include/am_compat.h: better test for struct netconfig + (!HAVE_NETCONFIG_H && !HAVE_SYS_NETCONFIG_H) + + * aux/macros/check_nfs_prot_headers.m4: added new header for aix5.1+ + + * buildall: fix 'buildall -b' on hpux9 and aix5.1 + +2002-06-24 Ion Badulescu <ionut@buggy.badula.org> + + * INSTALL: updated + + * conf/autofs/autofs_solaris_v1.c (autofs_link_mount): compile fix + (autofs_link_umount): ditto + + * amd/mntfs.c (init_mntfs): don't use autofs if !amd_use_autofs + +2002-06-23 Ion Badulescu <ionut@moisil.badula.org> + + * conf/autofs/autofs_linux.c: compile fixes for autofs v3 + +2002-06-23 Ion Badulescu <ionut@moisil.badula.org> + + * conf/autofs/autofs_solaris_v2_v3.c (autofs_mounted): no + expirations needed; + (autofs_timeout_mp): likewise + + * conf/autofs/autofs_solaris_v1.c (autofs_mounted): no expirations + needed; + (autofs_timeout_mp): likewise + + * conf/autofs/autofs_linux.c (autofs_mounted): set the first + expiration interval + + * amd/autil.c (am_mounted): call autofs_mounted here, instead of + in mf_mounted() + + * amd/amd.h (NEVER): moved here from map.c + (autofs_mounted): change argument from mntfs* to am_node* + +2002-06-23 Ion Badulescu <lionut@gonzales.badula.org> + + * conf/autofs/autofs_linux.c (autofs_mounted): set the kernel + timeout on the autofs mountpoint to cache_duration (gopt.am_timeo) + (autofs_timeout_mp): don't update the ttl if we're going down + + * amd/map.c (timeout_mp): don't call autofs_timeout_mp unless the + timeout on that particular am_node has expired + + * conf/autofs/autofs_linux.c (autofs_timeout_mp): really update + the ttl, as per the comment (compilers are not very good at + translating comments into code...) + + * amd/amfs_auto.c (amfs_auto_lookup_one_mntfs): strdup am_path + instead of opt_rfs into opt_fs for autofs, thus avoiding conflicts + between link mounts pointing to the same target + +2002-06-23 Ion Badulescu <lionut@gonzales.badula.org> + + * conf/autofs/autofs_linux.c (send_fail, send_ready): new helper + functions for sending messages back to the kernel + (autofs_expire_one): initial implementation of the kernel-based + expiration handler + (autofs_handle_expire): call autofs_expire_one() + (autofs_handle_expire_multi): ditto + (autofs_umount_succeeded): search pending_umounts, send message + back to the kernel + (autofs_umount_failed): ditto + (autofs_mount_succeeded): tell amd core not to expire autofs entries + (autofs_timeout_mp): expiration function for autofs filesystems + (autofs_timeout_mp_task): helper function for autofs_timeout_mp + + * conf/autofs/autofs_linux.h: new struct autofs_pending_umount for + keeping tracking of pending umounts + (autofs_fh_t) rename pending to pending_mounts, add pending_umounts + + * conf/autofs/autofs_solaris_v1.c (autofs_timeout_mp): stub + + * conf/autofs/autofs_solaris_v2_v3.c (autofs_timeout_mp): stub + + * amd/map.c (timeout_mp): call autofs_timeout_mp() for autofs + filesystems + + * amd/autil.c (mf_mounted): move here the call autofs_mounted() + from amfs_auto_mounted(). + +2002-06-22 Erez Zadok <ezk@whitestar.dyn.optonline.net> + + * amd/nfs_start.c (mount_automounter): Security fix. if user sets + -D noamq, don't even create listening socket. Suggestion by Ed + Ravin <eravin@panix.com>. 2002-06-22 Ion Badulescu <lionut@gonzales.badula.org> * hlfsd/homedir.c (homedir): use setgid() instead of setegid() - * buildall: use ksh for configure on aix5.1 + * ALL: #ifdef cleanups, unify some TLI/socket function prototypes -2002-06-21 Ion Badulescu <ion@guppy.limebrokerage.com> +2002-06-22 Erez Zadok <ezk@whitestar.dyn.optonline.net> + + * conf/nfs_prot/nfs_prot_netbsd1_4.h: minor port to support + na_gid and na_uid. NetBSD patch from Jun-ichiro itojun Hagino + <itojun@iijlab.net>. + + * doc/am-utils.texi (Option): document xlatecookie mount option. + + * libamu/mount_fs.c (compute_nfs_args): support "xlatecookie" + NFS mount option. Patch from Matthias Scheler <tron@zhadum.de> + for NetBSD. + +2002-06-22 Ion Badulescu <ionut@edgar.badula.org> + + * conf/autofs/autofs_solaris_v1.h: add FS_MBACKGROUND to + AUTOFS_LINK_FS_FLAGS + + * conf/autofs/autofs_solaris_v1.c: convert link mounts to lofs + mounts in autofs_link_mount/umount + +2002-06-22 Ion Badulescu <lionut@gonzales.badula.org> + + * configure.in: check for devid inside struct umntrequest + + * conf/autofs/autofs_solaris_v2_v3.c (xdr_umntrequest): handle the + new umntrequest structure in v4. + (autofs_unmount_2_req): ditto + + * README.autofs: updated for Solaris 2.5/2.5.1 + +2002-06-22 Erez Zadok <ezk@whitestar.dyn.optonline.net> + + * configure.in: only define LDAP/Hesiod if both the headers and + the libraries exist, and the user didn't explicitly disable those + maps. + +2002-06-22 Erez Zadok <ezk@agora.fsl.cs.sunysb.edu> + + * doc/am-utils.texi: fix typos. Can't use ":" in @cindex entries. + +2002-06-22 Erez Zadok <ezk@whitestar.dyn.optonline.net> + + * doc/am-utils.texi, scripts/amd.conf.5, scripts/amd.conf-sample, + amd/amd.8, amd/get_args.c (get_args): document amd -A option. + + * amd/get_args.c (get_args): support "amd -A arg" option to + override the system's detected architecture. Patch from George + Ross <gdmr@dcs.ed.ac.uk>. + + * amd/info_ldap.c (amu_ldap_rebind): don't use ldap_enable_cache() + if the system doesn't have it. + + * configure.in: detect existence of ldap_enable_cache function, + because it doesn't exist on Solaris 9's latest ldap libraries. + + * amd/info_ldap.c: LDAP patches from George Ross + <gdmr@dcs.ed.ac.uk>. Rework of old code, support for wildcards in + LDAP queries, and an FD leak fix. + +2002-06-22 Ion Badulescu <lionut@gonzales.badula.org> + + * buildall: use ksh for configure on aix5.1; pass the extra + arguments after "--" to configure, not to make * Makefile.am: added nfs_prot_aix4_3.h to EXTRA_DIST_CONF @@ -354,14 +5017,19 @@ * BUGS: update for direct mounts on Linux; document the brokenness of /bin/sh on AIX 5.1 and HP-UX 9 -2002-06-21 Erez Zadok <ezk@agora.fsl.cs.sunysb.edu> + * NEWS: aix5.1 port, aix4.3 workaround - * ALL source/header files: change use of HAVE_FIELD_* macros to - HAVE_*, since aux/macros/check_field.m4 changed as well. +2002-06-22 Erez Zadok <ezk@agora.fsl.cs.sunysb.edu> - * configure.in, Makefile.am, bootstrap, aux/amdgrep, - aux/macros/*.m4: MAJOR port of autotool files from 6.1 branch, to - work with newer autotools. + * ltmain.sh: use libtool 1.4d, needed support for newer AIX. + +2002-06-21 Ion Badulescu <ion@guppy.limebrokerage.com> + + * aux/macros/check_autofs_style.m4: enable autofs_v2_v3 for + all solaris2.6+, not just for 2.[6-8] + + * conf/autofs/autofs_default.h: disable autofs if configure + detects it 2002-06-21 Erez Zadok <ezk@agora.fsl.cs.sunysb.edu> @@ -382,28 +5050,143 @@ * config.guess, config.sub, doc/texinfo.tex, ltmain: updates from the latest GNU distributions. +2002-06-11 Ion Badulescu <ion@guppy.limebrokerage.com> + + * amd/amfs_auto.c (amfs_auto_lookup_child): split part of this + function into the new amfs_auto_lookup_one_child function; return + null if all ivecs failed to match + 2002-05-30 Erez Zadok <ezk@agora.fsl.cs.sunysb.edu> * config.guess.long: support SuSE version names in long config.guess format. -2002-05-03 Ion Badulescu <ion@guppy.limebrokerage.com> - - * hlfsd/homedir.c (homedir): last chance checking for zombies; - (interlock): anal-retentive checking for all sorts of error - conditions during child recovery - - * hlfsd/hlfsd.c (main): use SA_RESTART in sigaction - (cleanup): indentation - 2002-05-01 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> * scripts/lostaltmail.in (vrfy_user): unlink temp files if too small. +2002-04-07 Ion Badulescu <ionut@moisil.badula.org> + + * hlfsd/hlfsd.c (main): compile fix for --enable-debug=no + 2002-03-29 Ion Badulescu <ionut@moisil.badula.org> - * amd/nfs_start.c: use plog() instead of perror() + * README.autofs: solaris 2.5/2.5.1 info, other minor changes + + * doc/am-utils.texi (History): document solaris 2.5+ support + + * include/am_utils.h: new member in struct mntfs: mfs_real_mount; + autofs_fs_flags becomes conditional of HAVE_AUTOFS_FS; new + prototype for umount_fs2(); extra argument for UMOUNT_FS() + + * hlfsd/hlfsd.c: use the new mount_fs2() and UMOUNT_FS() + + * libamu/mount_fs.c (mount_fs): wrapper around the new mount_fs2() + function; swap mntdir and real_mntdir as necessary for solaris 2.5 + autofs support + + * conf/umount/umount_default.c (umount_fs2): swap mntdir and + real_mntdir as necessary for solaris 2.5 autofs support + + * conf/umount/umount_*.c (umount_fs): wrapper around the new + umount_fs2() function + (umount_fs2): new function which takes the real mountpoint as an + extra argument + + * conf/nfs_prot/nfs_prot_sunos5_5.h: allow autofs support to be + compiled in + + * conf/autofs/autofs_solaris_v1.h (autofs_strdup_space_hack): new + function that appends a space at the end of a string (the famous + "Autofs Space Protocol") + + * conf/autofs/autofs_solaris_v1.c: almost complete reimplementation + + * conf/autofs/autofs_*.h (AUTOFS_*_FS_FLAGS): add + system-specific definitions for these macros + + * conf/autofs/autofs_linux.c (create_autofs_service): remove hacks + which are now handled properly by more generic code + (autofs_link_umount): complain if umount_fs() fails, rmdir the + mountpoint on success + (autofs_umount_succeeded): remove the rmdirs() code, now handled + by generic code + (autofs_mount_succeeded): ditto + + * amd/nfs_start.c (checkup): implement it as an emtpy stub if + DEBUG is not defined + (run_rpc): call autofs_add_fdset() after umount_exported() to + avoid passing invalid file descriptors to select(); use plog() + instead of perror() + + * amd/mntfs.c (init_mntfs): initialize mf_real_mount from mp + (uninit_mntfs): free mf_real_mount + + * amd/autil.c (am_unmounted): don't remove the mount point if a + remount is pending, also don't make the removal conditional on not + being an autofs mount point + + * amd/amfs_nfsx.c (amfs_nfsx_remount): call mkdirs() on + mf->mf_real_mount instead of mf->mf_mount + + * amd/amfs_nfsl.c, amd/amfs_nfsx.c: (amfs_nfsl_umounted): call + rmdirs() on mf->mf_real_mount instead of mf->mf_mount + + * amd/amfs_host.c (make_mntpt): change the third argument to be + the mountpoint, not the entire mntfs structure + (do_mount): takes real_mntdir as an extra argument + + * amd/amfs_auto.c (amfs_auto_bgmount): move the creation of the + mountpoint here from try_mount(), otherwise the change to mf_flags + is lost for background mounts; remove the mountpoint if we created + it and the mount fails + (amfs_auto_lookup_mntfs): re-initialize mf->mf_real_mount using + autofs_strdup_space_hack() if NEED_AUTOFS_SPACE_HACK is defined + + * amfs_*.c, ops_*.c: initialize autofs_fs_flags using the + AUTOFS_*_FS_FLAGS macro defined in the system-specific autofs + header; UMOUNT_FS() takes mf->mf_real_mount as an extra argument; + mount_fs() becomes mount_fs2() and takes mf->mf_real_mount as an + extra argument + + * amd/amd.h, amd/ops_nfs.c, amd/amfs_host.c: mount_nfs_fh takes + the real mountpoint as an additional argument + +2002-03-28 Erez Zadok <ezk@agora.fsl.cs.sunysb.edu> + + * amd/ops_cdfs.c (mount_cdfs): correctly interpret error return + values back from mount_fs(). Return correct error number from + this function. + + * conf/mount/mount_linux.c (do_mount_linux): cleanup loop mount + cruft from this function, moved elsewhere. + (mount_linux): prepare for loop-device mounts of ISO images. + +2002-03-28 Ion Badulescu <ionut@buggy.badula.org> + + * libamu/Makefile.am (EXTRA_DIST): added strerror.c + + * libamu/strerror.c: strerror() implementation for systems lacking it + + * doc/am-utils.texi (History): rewrote the history :) about autofs + support + + * conf/autofs/autofs_solaris_v2_v3.c: updated copyright; + (autofs_unmount_2_req): minor cleanup + (create_autofs_service): print log message + (destroy_autofs_service): ditto + + * conf/autofs/autofs_linux.c: updated copyright + + * amd/nfs_start.c (mount_automounter): move the debug message into + create_autofs_service() + + * amd/amd.c (main): call destroy_autofs_service() before + going_down(), not after + + * configure.in: added strerror to AC_CHECK_FUNCS(); disable ldap + if the ldap headers are not found 2002-03-28 Erez Zadok <ezk@agora.fsl.cs.sunysb.edu> @@ -411,30 +5194,121 @@ <sebastien.bahloul@medasys.org> to fix a simple initialization bug and change "HE" to HE_ENT so as to compile on HPUX. +2002-02-26 Erez Zadok <ezk@t3.fsl.cs.sunysb.edu> + + * conf/nfs_prot/nfs_prot_freebsd3.h (na_uid): freebsd4.5 uses nfs + atttributes field named "uid". So #define na_uid to it. + 2002-02-12 Erez Zadok <ezk@agora.fsl.cs.sunysb.edu> * scripts/lostaltmail.in: don't verify user if -noverify option was turned on. fix comment typo. -2002-02-11 Ion Badulescu <ion@guppy.limebrokerage.com> +2002-02-11 Erez Zadok <ezk@agora.fsl.cs.sunysb.edu> + + * amd/Makefile.am (TESTS): enable one test script, test1.sh. - * Ripped out all traces of autofs support + * amd/test1.sh: re-commit simple test script. 2002-02-11 Ion Badulescu <ion@guppy.limebrokerage.com> + * Released snapshot 6.1a5 + + * NEWS: Solaris autofs readdir() support, Linux autofs sublink fix + * README: require newer auto-tools, update mailing list address - * README.autofs: point to the 6.1 branch for autofs support + * README.autofs: major update -2002-01-20 Erez Zadok <ezk@localhost.localdomain> + * configure.in: version changed to 6.1a5 - * updated copyright year to 2002 on all files +2002-02-11 Ion Badulescu <ionut@moisil.badula.org> + + * conf/autofs/autofs_linux.c (autofs_link_mount): don't do a + stat() on the am_link if called from the parent amd, to prevent + deadlocks + + * amd/autil.c (am_unmounted): call amfs_link_ops.umount_fs if the + fstype is not link but we have a sublink (Linux autofs needs this) + (am_mounted): call amfs_link_ops.mount_fs if the fstype is not + link but we have a sublink (Linux autofs needs this) + + * amd/amfs_auto.c (amfs_auto_bgmount): print the real mountpoint, + not the amd entry point + +2002-02-09 Ion Badulescu <ionut@moisil.badula.org> + + * conf/autofs/autofs_solaris_v2_v3.c (amd_rddirres): new custom + structure for returning the results from readdir_2() + (xdr_amd_putrddirres): renamed from xdr_autofs_putrddirres, + changed to process our internal format (which is essentially the + NFS readdir format) + (xdr_autofs_getrddirres): not needed, deleted + (xdr_amd_rddirres): renamed from xdr_autofs_rddirres, other + changes to handle amd_rddirres instead of autofs_rddirres + (autofs_lookup_2_req): return AUTOFS_NONE instead of + AUTOFS_MOUNT_RQ, to prevent mount storms during ls -F + (autofs_readdir_2_req): implemented + (autofs_readdir_2_free): not needed, deleted + (autofs_program_2): changes from autofs_rddirres to amd_rddirres + (autofs_get_fh): changed initialization of the fh->map member, it + now gets the mountpoint path because it makes it easier to + implement readdir + (autofs_release_fh): put #ifdef HAVE_AUTOFS_ARGS_T_ADDR around + code touching fh->addr + (destroy_autofs_service): new function, deregister the autofs + service with the portmapper on exit + + * conf/autofs/autofs_linux.c (autofs_handle_missing): update + statistics + (destroy_autofs_service): new stub + + * amd/mapc.c (mapc_find): fixed indentation + + * amd/map.c (find_ap_recursive): renamed from find_ap2(), made + static + + * amd/amd.h: removed prototype for find_ap2(), added prototype for + destroy_autofs_service() + + * amd/amd.c (main): call destroy_autofs_service() before going + down + +2002-02-07 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> + + * aux/macros/check_field.m4: need also a new version of + AC_CHECK_MEMBERS (plural). + +2002-02-06 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> + + * aux/macros/check_field.m4: include a fixed version of + AC_CHECK_MEMBER. g/cc will fail to check a member if the .member + is itself a data structure, because you cannot compare, in C, a + data structure against NULL; you can compare a native data type + (int, char) or a pointer. Solution: do what I did in my original + member checking macro: try to take the address of the member. You + can always take the address of anything. + +2002-01-31 Erez Zadok <ezk@localhost.localdomain> + + * remove old '%W%' SCCS IDs from all sources. + +2002-01-21 Ion Badulescu <ionut@moisil.badula.org> + + * conf/mount/mount_linux.c (mount_linux): fix breakage introduced + by the loop device mount support. Linux mount takes a real string + as the last argument, unless the mount type is NFS, NCP, or SMB. + +2002-01-20 Erez Zadok <ezk@localhost.localdomain> * hlfsd/hlfsd.h (HLFSD_VERSION): up version of hlfsd to 1.2, because we made some important changes. 2002-01-20 Ion Badulescu <lionut@gonzales.badula.org> + * include/am_utils.h (D_ALL): do not include D_MTAB and D_HRTIME + by default + * NEWS: document latest changes * amd/map.c (unmount_mp): same fix as for hlfsd, update the @@ -447,26 +5321,88 @@ 2002-01-20 Ion Badulescu <lionut@gonzales.badula.org> * hlfsd/homedir.c (homedir): don't special case uid 0 as having / - as home; instead use the root accounts home + as home; instead use the root account's home (plt_init): properly initialize root_home from the root account's home directory, or as "" if root doesn't exist (plt_reset): free root_home -2002-01-20 Ion Badulescu <lionut@gonzales.badula.org> +2002-01-20 Erez Zadok <ezk@localhost.localdomain> + + * hlfsd/stubs.c (nfsproc_{lookup,getattr}_2_svc): non-SYMTTL code. + Increment seconds, not microseconds (which are ignored by NFS). + Set symlink owner to euid. + + * hlfsd/homedir.c (homedir): pass gid to this function, so we can + also change the effective GID of the process writing to the user's + home dir, as well as the group of the hlfsd symlink. + (homedir): run setegid in the right places. + +2002-01-15 Erez Zadok <ezk@agora.fsl.cs.sunysb.edu> - * hlfsd/hlfsd.h: update prototype for homedir() + * scripts/redhat-ctl-amd.in: refer to @sbindir@ not + ${prefix}/sbin. - * hlfsd/stubs.c (nfsproc_lookup_2_svc): get the credentials at the - begining of the function and assign the uid to the symlink - attributes; increment the mtime's seconds field each time the uid - changes - (nfsproc_lookup_2_svc): ditto - (nfsproc_readlink_2_svc): pass the groupid to homedir(); + * scripts/ctl-{amd,hlfsd}.in: refer to @sysconfdir@ not + ${prefix}/etc. Bug report from "A Braunsdorf" + <ab@eas.purdue.edu>. - * hlfsd/homedir.c (homedir): take a second argument, the user's - primary gid, and switch to it when doing filesystem operations; - save the old uid and gid and revert to them instead of the - hardcoded uid 0 +2002-01-13 Erez Zadok <ezk@localhost.localdomain> + + * configure.in: only check for clock_gettime if --enable-debug was + used. + + * aux/macros/opt_debug.m4: define a cache variable to record value + of debug option used. + + * libamu/xutil.c (show_time_host_and_name): do not use + clock_gettime unless debugging was compiled in. This way, if + debugging is not compiled, we don't bother linking with librt, + libpthread, and a whole lot of other libraries that aren't that + necessary (esp. on Linux). + +2002-01-12 Erez Zadok <ezk@wavy.dyn.optonline.net> + + * doc/am-utils.texi (opts Option): document loop option. + + * include/am_utils.h: each mounted file system (mntfs) should + optionally store the loop device used in the field mf_loopdev. + + * conf/nfs_prot/nfs_prot_linux.h: define HAVE_LOOP_DEVICE and some + loop function extern definitions. For now this code is here + because we only support loop devices on Linux. + + * conf/mount/mount_linux.c: recognize "loop" as a valid iso9660 + mount option. + (parse_opts): when skipping over unknown mount options, skip over + "loop" (since it was given in amd map entry), but not over + loop=/dev/loopX, because the latter will go into /etc/mtab. + (do_mount_linux): override actual cdfs mounted device name + because with loop devices you don't mount the .iso file directly, + but the /dev/loopX device that was setup for it. + (show_loop, is_loop_device, find_unused_loop_device, + setup_loop_device, delete_loop_device): support code for loop + devices. + + * amd/ops_cdfs.c (mount_cdfs): pass loop device name to function. + setup loop device before isofs mount, if "loop" option was given, + before actual mount(2). + (cdfs_mount): pass loopdev name to mount_cdfs(). + (cdfs_umount): delete/unset loop device after a successful + unmount, if a loop device was used. + + * amd/mntfs.c (init_mntfs): initialize mf_loopdev to NULL. + + * include/am_compat.h: If loop device (header file) exists, define + mount table option MNTTTAB_OPT_LOOP. + + * conf/nfs_prot/nfs_prot_linux.h: hack: define HAVE_LOOP_DEVICE + here until we have a better way to detect /dev/loop devices. + + * include/am_defs.h: include <linux/loop.h> if it exists. Define + LARGEFILE support macros, possibly needed for loop devices. + Redefine dev_t apropriately for loop devices. + + * configure.in: check for <linux/loop.h>. 2002-01-10 Ion Badulescu <ion@guppy.limebrokerage.com> @@ -474,6 +5410,166 @@ parameter 2 orders of magnitude larger than udp (patch from Trond Myklebust) +2002-01-09 Erez Zadok <ezk@localhost.localdomain> + + * aux/macros/linux_headers.m4: properly [quote] a long string in + m4 and use AC_MSG_WARN. + + * ALL: put /* comments */ on #else/#endif lines everywhere. + + * configure.in, aux/macros/with_addon.m4: due to limitation of + AC_HELP_STRING, pass 2nd arg to AMU_WITH_ADDON, listing name of + package for help string. + + * doc/am-utils.texi (FSinfo): fixed various texinfo errors in the + FSinfo section of the manual. + (map_reload_interval Parameter): document new amd.conf global + parameter. + + * scripts/amd.conf.5 document new global option + map_reload_interval. Sort entries for nfs_vers and nfs_proto + alphabetically. + + * amd/nfs_start.c (do_select): increment do_mapc_reload's value by + global map_reload_interval value, not by fixed ONE_HOUR. + + * amd/amd.c (main): increment do_mapc_reload's value by global + map_reload_interval value, not by fixed ONE_HOUR. + + * scripts/amd.conf-sample (map_reload_interval): usage example + + * amd/amd.c (init_global_options): initialize map_reload_interval + to 3600 seconds. + + * amd/conf.c (gopt_map_reload_interval): support a new global + amd.conf option map_reload_interval, to determine how often (in + seconds) Amd should check if the map source has changed and then + reload it it. This value was hard-coded to one hour, now it's the + default if not otherwise specified. + + * doc/am-utils.texi (plock Parameter): document plock=yes option + as using mlockall(2) if found. + + * scripts/amd.conf.5: document -S option as using mlockall(2) if + found. + + * include/am_defs.h: include <sys/mman.h> if it exists. + + * configure.in: check for mlockall() function. Check for + sys/mman.h. + + * amd/amd.c (main): support mlockall() on systems that have it and + don't have plock(3) for plock=yes. On systems that have both, + will try plock() first and then mlockall(), until one of them (if + any) succeeds. + +2002-01-09 Erez Zadok <ezk@whitestar.dyn.optonline.net> + + * aux/macros/opt_debug.m4, opt_cppflags.m4, opt_amu_cflags.m4, + with_addon.m4 (ac_upcase): fix help string formatting using + AC_HELP_STRING. + + * amd/test1.sh: simple test script for "make check". Runs "amd + -v". + + * amd/Makefile.am (TESTS): add one simple test script, running + "amd -v" and checking its return value. More tests can be added. + + * aux/macros/linux_headers.m4: use AC_MSG_WARN directly. + + * aux/macros/*.m4: avoid the cumbersome "changequote" M4 command. + Instead, list bracketed regexp patterns in [[double brackets]]. + + * aux/macros/header_templates.m4: remove all unnecessary + HAVE_FIELD_* definitions, now that we're using autoconf's new + AC_CHECK_MEMBERS. + + * aux/macros/field_mntent_t_mnt_time_string.m4: don't call + + * configure.in: use new syntax for AMU_CHECK_FIELD + + * aux/macros/check_field.m4: use new and simpler macro + AC_CHECK_MEMBERS. Change all sources to use HAVE_aggregate.member + instead of HAVE_FIELD_aggregate.member. + + * aux/amdgrep: simple utility script to egrep the am-utils sources + for any pattern. + + * aux/macros/{check_mnttab_style.m4, check_mount_style.m4, + check_umount_style.m4, check_network_transport_type.m4}: use newer + AC_LIBOBJ macros instead of modifying $LIBOBJS directly + + * aux/macros/func_bad_memcmp.m4: redefine to use native + AC_FUNC_MEMCMP, and then define HAVE_BAD_MEMCMP as needed. + + * fsinfo/fsi_gram.y, amd/conf_parse.y: indent #pragma command so + pre-ANSI C compilers will ignore it. + + * conf/autofs/autofs_linux.c (autofs_link_mount): call s/getpgrp() + correctly depending on whether it takes a void or a 0. + + * configure.in: check if s/getpgrp() takes void or a 0. + +2002-01-08 Erez Zadok <ezk@whitestar.dyn.optonline.net> + + * configure.in: use the newer AC_CONFIG_LINKS instead of + AC_LINK_FILES. + + * aux/macros/check_autofs_style.m4, check_checkmount_style.m4, + check_mnttab_style.m4, check_mount_style.m4, + check_network_transport_type.m4, check_umount_style.m4, + check_nfs_prot_headers.m4: removed backward compatible code for + pre-autoconf-2.14. + +2002-01-07 Erez Zadok <ezk@whitestar.dyn.optonline.net> + + * doc/Makefile.am: define @SET_MAKE@ for AC_PROG_MAKE_SET macro, since + this Makefile could explicitly chdir to other directories and run + make there. + (install-ps): use ${MAKE} with ${MFLAGS}. + + * Makefile.am (EXTRA_DIST_AUX): distribute new package_*.m4 files. + Define @SET_MAKE@ for AC_PROG_MAKE_SET macro, since this Makefile + could explicitly chdir to other directories and run make there. + (install-snapshot): use ${MAKE} ${MFLAGS}, not hardcoded "make". + + * configure.in: call AC_PROG_MAKE_SET to check if make program + defines $MAKE variable. + + * amd/get_args.c (get_version_string): use new PACKAGE_* macros + and also report the bug-reporting address. + + * aux/macros/package_{name,version}.m4, header_templates.m4: using + new PACKAGE_{NAME,VERSION,BUGREPORT} macros. + + * aux/macros/name_bugreport.m4: simple macro to print out the + bug-reporting address which was configured in AC_INIT. + + * bootstrap: remove new autoconf messages about misuse of + m4_patsubst and m4_regexp (internal GNU M4 macros). + + * configure.in: remove old comment above AC_OUTPUT. + Use AC_CONFIG_FILES and AC_OUTPUT separately. + Fix AC_REVISION use. + Add AC_COPYRIGHT. + Use new style for AC_INIT, listing package name, version, and + bug-reporting address. + Call new AMU_PACKAGE_* macros. + + * updated copyright year to 2002 on all files + + * configure.in: using newly renamed am-utils macros (AMU_*) + + * aux/macros/*.m4: renamed ALL am-utils specific macros so they + start with AMU_*, not AC_*. That way it is easier to distinguish + between macros that come with am-utils and those that are part of + Autoconf or Automake. It helps to identify those am-utils macros + that can be removed once there is generic support for them in a + future version of Autoconf. + + * bootstrap: run automake --copy + remove autom4te.cache dir before rerunning autoconf + 2001-12-13 Erez Zadok <ezk@agora.fsl.cs.sunysb.edu> * scripts/amd.conf.5: correct title to section 5, not 8. Correct @@ -486,17 +5582,45 @@ * scripts/ctl-hlfsd.in: run "test" or "[" in front of -x/-f +2001-12-02 Ion Badulescu <ionut@moisil.badula.org> + + * hlfsd/homedir.c (plt_print): fix typo (s/plot/plog/) in + non-mkstemp code + + * scripts/ctl-amd.in: touch/remove /var/lock/subsys/amd to make RH + happy + + * scripts/ctl-hlfsd.in: ditto (for hlfsd) + + * conf/mtab/mtab_file.c (rewrite_mtab): fchmod(644) the file we + get from mkstemp(), otherwise samba becomes very unhappy (sigsegv) + + * conf/mtab/mtab_mach3.c (rewrite_mtab): ditto + 2001-11-29 Ion Badulescu <ion@guppy.limebrokerage.com> * tasks: updated + * NEWS: document the fixed autofs fd leak + * amq/amq.8: better document the -f option 2001-11-29 Erez Zadok <ezk@agora.fsl.cs.sunysb.edu> - * libamu/mount_fs.c (mnt_flags): same as for nolock option + * libamu/mount_fs.c (mnt_flags): same this as for nolock option handling, do for maxgrps. +2001-11-29 Ion Badulescu <ion@guppy.limebrokerage.com> + + * conf/autofs/autofs_linux.c (hash_init): determine the max number + of fd's at runtime, use it to dynamically scale the hash and list + arrays + (autofs_get_fh): sanity check, don't allow a pipe() fd greater + than autofs_max_fds + (autofs_release_fh): close our end of the pipe here (no clue why + or when it got commented out) + (autofs_mounted): set kernelfd to -1 after closing it + 2001-11-28 Philippe Troin <phil@fifi.org> * libamu/mount_fs.c (mnt_flags): Drop nolock from generic mount @@ -508,8 +5632,7 @@ * ported to ia64-hp-hpux11.20 using HP's ANSI/C compiler. Couldn't use bison/flex because of 32-bit vs. 64-bit binaries - issues. Had to use HP's own yacc/lex. This was discovered by - using HP's non-GNU make program. + issues. Had to use HP's own yacc/lex. 2001-11-26 Erez Zadok <ezk@a-hpux11i.fsl.cs.sunysb.edu> @@ -517,7 +5640,8 @@ longer automatically defined now that Automake has automatic dependency tracking (which I turn off). Instead, hard-code minimal dependencies on am-utils' header files to depend on - PROG_OBJECTS (where PROG is the program name being built) + PROG_OBJECTS (where PROG is the program name being built). This + was discovered by using HP's non-GNU make program. * amd/nfs_start.c (checkup): cast getpagesize() return val to long, to avoid conflicts in division of a long by an int (on @@ -553,7 +5677,7 @@ * bootstrap (cmd): turn back on --ignore-deps (this Automake may have problems) - * libamu/xutil.c: remove __attribute__ format_arg statement for + * libamu/xutil.c: remove __attribute__ format_arg statement for expand_error() because this function, although taking a printf-like string, does not use it in a printf function; it only expands a non-printf amd-special syntax %m. @@ -583,11 +5707,11 @@ * aux/macros/host_macros.m4: use proper M4 quoting ([], not "") * config.{guess,sub}: upated from latest prep ftp distributions - + * depcomp, missing, mkinstalldirs: upated from latest Automake 1.5 * ltmain.sh: updated from latest Libtool 1.4.2 - + * bootstrap: finally, new autoconf doesn't print silly "AC_TRY_RUN called without default to allow cross compiling" warnings. And, it only took like 3+ years to fix this. But, now it has anoter, @@ -606,7 +5730,7 @@ header templates using AH_TEMPLATE macros and such. * aux/macros/msg.m4: removed. Replaced with new macro - AC_MSG_NOTICE + AC_MSG_NOTICE * Makefile.am (EXTRA_DIST_AUX): remove aux/macros/msg.m4. Add aux/macros/header_templates.m4 @@ -640,6 +5764,11 @@ be on a separate line, as per new Autoconf manual, to avoid some Bourne Shell syntactical bizarreness. +2001-11-13 Erez Zadok <ezk@a-rh71i.fsl.cs.suunysb.edu> + + * amd/amfs_auto.c (amfs_auto_readdir_browsable): cast to u_long, + for IA64 Linux. + 2001-11-12 Ion Badulescu <ionut@buggy.badula.org> * libamu/mtab.c (hasmntval): strtol can return a non-NULL pointer @@ -649,11 +5778,130 @@ * configure.in: increased library patchlevel - * NEWS: document the parsing bug; document other previous changes + * NEWS: document the parsing bug + +2001-10-29 Ion Badulescu <ionut@moisil.badula.org> + + * configure.in: bumped version up to 6.1a5-pre + + * NEWS: fixed speeling mistaike + +2001-10-29 Ion Badulescu <ionut@moisil.badula.org> + + * released snapshot am-utils-6.1a4 + +2001-10-26 Ion Badulescu <ionut@moisil.badula.org> + + These changes fix autofs support for sublinks. While it is not + perfect by any means and is hardly better than non-autofs, at + least it works. + + * conf/autofs/autofs_solaris_v2_v3.c (autofs_lookup_2_req): don't + reply if the mount is in progress + (autofs_mount_succeeded): handle both delayed lookups and mounts + (autofs_mount_failed): ditto + + * amd/amfs_auto.c (amfs_auto_lookup_mntfs): don't dispose of the + original opt_fs if we have a sublink + +2001-10-23 Ion Badulescu <ionut@moisil.badula.org> + + * amd/amfs_auto.c (amfs_auto_lookup_mntfs): fixed silly typo (mf + instead of new_mf) which was causing null pointer error when + sublinks were being used + +2001-10-22 Ion Badulescu <ionut@moisil.badula.org> + + * README.autofs: updated + + * NEWS: updated + + * INSTALL: updated + + * AUTHORS: added myself + + * doc/am-utils.texi: updated + + * conf/autofs/autofs_solaris_v2_v3.c (xdr_autofs_rddirargs): use + xdr_u_int() and cast things to (int) to appease Solaris 2.7 compile + (autofs_readdir_2_req): cast req->rda_offset to (int), same as + above + +2001-10-22 Ion Badulescu <ionut@moisil.badula.org> + + Autofs direct mounts have been verified to work on Solaris2.[67]. + + * conf/autofs/autofs_solaris_v2_v3.c (autofs_lookup_2_req): + retrieve the uid and gid from the lookup request + (autofs_mount_2_req): skip the first char in the name (it's a + leading '/') if this is a direct mount + + * amd/amfs_direct.c (amfs_direct_ops): use amfs_auto_lookup_child + and amfs_auto_mount_child for amfs_direct's methods + + * amd/amfs_auto.c (amfs_auto_lookup_child): don't leak an am_node + if the mntfs lookup fails + +2001-10-21 Ion Badulescu <ionut@moisil.badula.org> + + * include/am_utils.h (AMF_REMOUNT): new flag, marks the node as + pending a remount + (mntfs): new member mf_fsflags, holds a copy of the filesystem's + fs_flags + (am_ops): new member autofs_fs_flags, holds the filesystem's flags + when mounted onto an autofs node; fs_flags renamed to nfs_fs_flags + + * conf/autofs/autofs_linux.c (create_autofs_service): turn on + FS_MKMNT for amfs_auto and FS_MBACKGROUND for amfs_link + (autofs_umount_succeeded): don't rmdir the mountpoint if a remount + is needed [lest the access that triggered the remount will fail] + + * amd/mntfs.c (init_mntfs): copy the filesystem's nfs_fs_flags + into mf_fsflags on initialization + + * amd/autil.c (am_unmounted): start the remounting right away if + the node is marked as needing a remount [fixes the Linux autofs + deadlock when mount/unmount collide] + + * amd/amfs_auto.c (amfs_auto_lookup_node): mark the node as + needing a remount if a mount request comes in while we're + unmounting it + (amfs_auto_lookup_mntfs): copy the filesystem's autofs_fs_flags + into mf_fsflags if this is an autofs node + + * amd/amfs_*.c, amd/ops_*.c: added initialization for the new + autofs_fs_flags member of am_ops + +2001-10-20 Ion Badulescu <ionut@moisil.badula.org> + + With these changes, Solaris 2.[67] autofs support is finally + functional! + + * conf/autofs/autofs_solaris_v2_v3.c (autofs_readdir_2_req): stub + (autofs_readdir_2_free, xdr_autofs_rddirargs, xdr_autofs_putrddirres, + xdr_autofs_getrddirres, xdr_autofs_rddirres): new functions + (autofs_lookup_2_req): do an actual lookup here, and tell the + kernel to create a symlink if necessary + (autofs_mount_2_req): no need to am_autofs_data + (autofs_program_2): enable AUTOFS_READDIR + (autofs_link_mount): no code needed here + (autofs_link_umount): return success + (autofs_mount_succeeded): lstat real mount points; don't mark + symlinks as NOTIMEOUT + + * amd/mntfs.c (init_mntfs): mf_dev and mf_rdev don't exist anymore + + * amd/map.c (init_map): init am_dev and am_rdev to -1 + (free_map): free am_mfarray and all mntfs's listed + + * amd/autil.c (mf_mounted): move the lstat of the node to the + autofs-specific code + + * amd/amfs_link.c (amfs_link_ops): don't background symlink creation 2001-10-18 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> - * aux/macros/os_cflags.m4 (irix6*): Enforce N32 ABI/mips3 ISA with cc. + * aux/macros/os_cflags.m4 (irix6*): Enforce N32 ABI/mips3 ISA with cc. * BUGS: Explain this. 2001-10-02 Erez Zadok <ezk@agora.fsl.cs.sunysb.edu> @@ -665,7 +5913,7 @@ * scripts/redhat-ctl-amd.in: new script, useful to correctly control Amd on Red Hat Linux systems. Script adapted from ctl-amd and Red Hat's own rc.d script. - + 2001-10-02 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> * conf/nfs_prot/nfs_prot_osf5.h: Renamed from nfs_prot_osf5_1.h. @@ -689,6 +5937,68 @@ * libamu/wire.c (is_network_member): support for network/netmask as well as network/bits syntax in in_network() +2001-08-11 Erez Zadok <ezk@a-linux64.fsl.cs.sunysb.edu> + + * amq/amq.c (show_mti): print full four digits for year, and print + it in MM/DD/YYYY format, not in YY/MM/DD format. + +2001-08-11 Ion Badulescu <lionut@gonzales.badula.org> + + * conf/autofs/autofs_solaris_v2_v3.c (autofs_lookup_2_req): + initial attempt to do something useful -- but commented out for now + (autofs_link_mount): create an action structure with a link + request and pass it up + (autofs_mount_2_req): pass the link request to the kernel + (autofs_free_data): new helper function + + * conf/autofs/autofs_linux.h: added definition for autofs_data_t + + * conf/autofs/autofs_solaris_v2_v3.h: ditto + + * amd/map.c (init_map): initialize am_autofs_data + (free_map): call the autofs cleanup function if necessary + + * include/am_utils.h (am_node): added private data and cleanup + function for autofs + + * tasks: removed some obsolete entries + +2001-08-11 Erez Zadok <ezk@a-solaris8.fsl.cs.sunysb.edu> + + * amd/map.c (free_map_if_success): run autofs_umount_failed() only + if this mount node is of type autofs. + +2001-08-11 Ion Badulescu <lionut@gonzales.badula.org> + + * amd/amd.h: removed mf_array from struct continuation (moved into + am_node) + + * include/am_utils.h: removed VLOOK_LOOKUP; renamed vlookuppn to + vlookup_child; added vmount_child; added mount_child to the fs_ops + API; added prototypes for amfs_auto_mount_child and + amfs_error_mount_child + + * amd/map.c (init_map): initialize am_mfarray to 0 + + * amd/amfs_*, amd/ops_*: new API function mount_child, old API + function lookuppn renamed to lookup_child + + * amd/amfs_auto.c: renamed amfs_auto_lookuppn1 to + amfs_auto_lookup_node; renamed amfs_auto_lookuppn2 to + amfs_auto_lookup_mntfs; renamed amfs_auto_lookuppn3 to + amfs_auto_mount_child; moved the freeing of the error mntfs in the + newly allocated am_node from lookup_mntfs to mount_child; make + sure lookup_child returns a negative error if the node needs to be + mounted; removed the call to lookuppn3 from lookup_child + + * amd/amfs_error.c: added stub implementations of + amfs_error_lookup_child and amfs_error_mount_child + + * amd/amfs_direct.c, amd/amfs_union.c, amd/map.c, amd/nfs_subr.c, + conf/autofs/autofs_linux.c, conf/autofs/autofs_solaris_v2_v3.c: + call both lookup_child and mount_child, instead of the old + lookuppn API method + 2001-07-19 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> * amd/get_args.c (get_args): a better way to handle GNU and @@ -700,7 +6010,7 @@ amu_ldap_init, aldh->ldap is not set. So when amu_ldap_rebind is called, this function is absolutely sure to return 0. Then amu_ldap_init return 0 without having opened any LDAP connection. - This is not the correct behaviour. + This is not the correct behavior. (get_ldap_timestamp, amu_ldap_search): error to free an object ("entry") that is automatically freed by the library. Patch from Sebastien Bahloul <sebastien.bahloul@mangoosta.fr>. @@ -711,18 +6021,16 @@ * Makefile.am (EXTRA_DIST): added bootstrap - * amd/map.c (unmount_node_wrap): fix a couple of comments (already - fixed in 6.1) - - * amd/amfs_auto.c (try_mount): print the path for the request that - failed (already in 6.1) - * include/am_compat.h (xfs_args_t): define as u_int if the filesystem is supported but we can't autodetect the type for xfs_args_t. This allows Linux to mount xfs filesystems. 2001-07-12 Philippe Troin <phil@fifi.org> + * doc/am-utils.texi: Added @dircategory Administration. + +2001-07-12 Philippe Troin <phil@fifi.org> + * aux/macros/with_addon.m4: Created. Wrapper around AC_ARG_WITH with only the `yes' and `no' as possible answers. @@ -755,28 +6063,40 @@ * Makefile.am (EXTRA_DIST_AUX): Added check_gnu_getopt.m4 macro file. -2001-06-27 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> - - ******************************************************************* - *** Released am-utils-6.0.7 *** - ******************************************************************* - 2001-06-25 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> - * config.guess, config.sub, doc/texinfo.tex: updates from the - latest GNU distributions. - - * INSTALL, doc/am-utils.texi (Supported Platforms): update info on - freebsd5.0 - * LSM.am-utils, NEWS, README.y2k, ChangeLog: make sure all am-utils URL references use www.am-utils.org, not the columbia URL. -2001-05-24 Erez Zadok <ezk@fsl-gw.fsl.cs.sunysb.edu> +2001-06-08 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> + + * conf/transp/transp_sockets.c (create_nfs_service): cast to + u_long to ensure clean compile on freebsd5 and bsdi2. - * conf/transp/transp_sockets.c (create_nfs_service): cast to u_long - to ensure clean compile on freebsd5 and bsdi2. +2001-05-23 Ion Badulescu <ionut@moisil.badula.org> + + WARNING: WORK IN PROGRESS + + It works for me on Linux (both autofs and nfs mounts), for nfs and + link, but I won't make any guarantees outside those. + + * amd/mntfs.c (find_mntfs): reuse the mntfs only if both the mount + point and the device/fileserver are the same. This is an important + change of philosophy, watch out for memory leaks! + + * amd/map.c (get_ap_child): helper function for + amfs_auto_lookuppn, creates a new am_node for key fname, inits it, + and inserts it into all necessary structures + + * amd/amfs_auto.c (free_continuation): free unused mntfs's; don't + free any of the removed fields + (amfs_auto_lookuppn, amfs_auto_bgmount): split lookuppn into three + subfunctions, including some code stolen from bgmount; lookuppn + now generates an array of possible mntfs to try mounting, and + bgmount will actually try to mount each of them. + (amfs_auto_lookuppn[123]): the three new subfunctions for lookuppn + (amfs_parse_defaults): new helper function for lookuppn 2001-05-19 Erez Zadok <ezk@kosh.dyn.optonline.net> @@ -784,6 +6104,12 @@ 2001-05-19 Ion Badulescu <ionut@moisil.dev.hydraweb.com> + * conf/autofs/autofs_linux.c (AUTOFS_MAX_VERSION): allow using + autofs-v4 again + (autofs_get_opts): don't pass pgrp, the kernel will get it + automatically anyway, not to mention that we were passing bogus + data if amd was not daemonized. + * conf/mount/mount_linux.c (linux_nfs_error): don't special case the 0 result, just put it into the translation list @@ -797,11 +6123,43 @@ * amd/amfs_host.c (amfs_host_mount): don't fail the mount if at least one share is already mounted -2001-05-02 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> +2001-05-17 Ion Badulescu <ionut@moisil.dev.hydraweb.com> - ******************************************************************* - *** Released am-utils-6.0.6 *** - ******************************************************************* + * libamu/util.c (str3cat): updated comment + + * include/am_utils.h: added VLOOK_LOOKUP and FS_DIRECT + + * conf/autofs/autofs_linux.c (autofs_get_fh): removed obsolete comment + (autofs_mounted): disable autofs support for host f/s if version < 4 + (create_autofs_service): turn on FS_MKMNT on auto f/s if using autofs + (autofs_umount_succeeded): use rmdirs instead of rmdir + (autofs_mount_failed): ditto + + * amd/opts.c (expand_op): align the debugging messages + + * amd/map.c (mount_auto_node): use am_node *mp instead of casting + the void *arg; update the comment + + * amd/autil.c (am_mounted): check the FS_DIRECT flag instead of + comparing to &amfs_direct_ops + (mount_node): ifs_mount doesn't exist, make note of it in the + comment + + * amd/amfs_direct.c (amfs_direct_ops): added FS_DIRECT to fs_flags + + * amd/amfs_auto.c (amfs_auto_mount): removed the autofs hack to + create the mountpoint directory for auto f/s; it is now handled in + autofs_linux.c + (amfs_auto_bgmount): renamed the mpe parameter to mp_error; + renamed dont_retry to retry and reverted its meaning as well; + moved the mp variable up one scope and made use of it throughout + the function; + (amfs_auto_readdir): whitespace + (amfs_auto_readdir_browsable): whitespace, also some debugging + + * amd/am_ops.c (vops): updated a comment + + * .cvsignore: added A.i386-pc-linux-rh7.[01] 2001-05-01 Ion Badulescu <ionut@gonzales.dev.hydraweb.com> @@ -813,14 +6171,17 @@ * BUGS: added info about the direct mount problems on Linux and about the kernel patches on www.am-utils.org. + * conf/autofs/autofs_solaris_v2_v3.c (autofs_unmount_2_req): + removed obsolete comment + * amd/autil.c (forcibly_timeout_mp): always log a message when the forced unmount request is ignored + (mf_mounted): don't lstat unless this is an autofs mount point, + lest we deadlock -2001-04-23 Ion Badulescu <ionut@buggy.dev.hydraweb.com> - - * amd/ops_autofs.c (autofs_lookuppn): renamed - CFM_ENABLE_DEFAULT_SELECTORS to CFM_SELECTORS_IN_DEFAULTS - (leftover from 03/29/01) + * amd/amfs_auto.c (amfs_auto_bgmount): don't gratuitously add + MFF_MKMNT to the flags, it causes deadlocks later on when + unmounting 2001-04-14 Erez Zadok <ezk@whitestar.dyn.optonline.net> @@ -841,16 +6202,17 @@ function's name to the beginning of the function, before any other messages are logged. +2001-04-14 Ion Badulescu <ionut@moisil.dev.hydraweb.com> + + * conf/mount/mount_linux.c (do_mount_linux): removed plog() of + binary data + 2001-04-05 Ion Badulescu <ionut@moisil.dev.hydraweb.com> * include/am_defs.h: define NFSCLIENT, NFS, PCFS, LOFS, RFS, MSDOSFS, MFS and CD9660 to 1, so that both #if FOO and #ifdef FOO work (needed for MacOS X); removed duplicate definition of NFS. -2001-04-05 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> - - * released snapshot am-utils-6.0.6s2 - 2001-03-29 Ion Badulescu <ionut@moisil.dev.hydraweb.com> * amd/amd.h, amd/amfs_auto.c, amd/conf.c, @@ -861,8 +6223,36 @@ renamed CFM_ENABLE_DEFAULT_SELECTORS to CFM_SELECTORS_IN_DEFAULTS; renamed gopt_selectors_on_default() to gopt_selectors_in_defaults() +2001-03-19 Ion Badulescu <ionut@moisil.dev.hydraweb.com> + + * amd/amfs_toplvl.c, amd/amfs_auto.c, amd/srvr_nfs.c, + include/am_utils.h: compile fixes for --enable-debug=no + 2001-03-15 Ion Badulescu <ionut@moisil.dev.hydraweb.com> + * NEWS: updated + + * README.autofs: updated + + * conf/mount/mount_linux.c (linux_version_code): export the fn + + * conf/nfs_prot/nfs_prot_linux.h: ditto + + * conf/autofs/autofs_linux.c (create_autofs_service): verify the + kernel version here, and turn off bind_works if the kernel is + older than 2.4.0. + (autofs_link_mount): don't touch bind_works here, it's useless + b/c we're in a child process; remove the mountpoint directory if + the bind mount fails + + * amd/opts.c (eval_fs_opts): changed some annoying debugging plogs + into dlogs + + * conf/autofs/autofs_linux.c (autofs_link_mount): zero out the + mntent struct before initializing it + +2001-03-14 Ion Badulescu <ionut@moisil.dev.hydraweb.com> + * conf/mount/mount_linux.c (parse_opts): added support for lofs (mount_linux): support lofs through bind mounts and/or FiST lofs @@ -873,10 +6263,39 @@ kernel is newer than 2.4.0 (MNTTYPE_LOFS): ditto - * acconfig.h: added MNT2_GEN_OPT_BIND + * conf/autofs/autofs_solaris_v2_v3.c (autofs_link_umount): new stub + (autofs_lookup_failed): removed stub + + * conf/autofs/autofs_linux.c (autofs_lookup_failed): moved up in + the file, made static; + (autofs_link_mount): activate MNT2_GEN_OPT_BIND code; use stat() + and friends to determine if bind mounts can be used and to trigger + further cascading mounts; return proper error codes + (autofs_link_umount): distinguish between symlinks and bind mounts + and handle both correctly + (autofs_umount_succeeded): remove call to autofs_link_umount() + + * amd/map.c (umount_exported): try to unmount all mount points on + an autofs filesystem; this isn't really needed and will be removed + when we start handling restarting autofs mounts + + * amd/amfs_link.c (amfs_link_[u]mount): call autofs_link_[u]mount, + if necessary + + * amd/amfs_auto.c (amfs_auto_bgmount): fixed a bug that was + causing the wrong mntfs to be selected when using autofs; removed + call to autofs_link_mount() (moved where it belongs, in + amfs_link.c) - * configure.in: bumped up library patchlevel; added detection for - the MS_BIND generic mount option + * amd/amfs_link.c: added FS_MBACKGROUND to fs flags -- cleaner + solution is needed, because background mounting is only necessary + for linux autofs + bind mounts + + * amd/amd.h: removed prototype for autofs_lookup_failed (internal + static function for linux autofs); added prototype for + autofs_link_umount + + * configure.in: bump up library patchlevel 2001-02-28 Ion Badulescu <ionut@moisil.dev.hydraweb.com> @@ -919,11 +6338,25 @@ freebsd5, not the stuff for freebsd2. This makes configure more likely to succeed on new systems/versions. + * Makefile.am (EXTRA_DIST_AUX): added check_autofs_style.m4 (grr) + +2001-02-24 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> + + * Makefile.am (install-snapshot): use a different symlink target + for the experimental snapshots. + 2001-02-23 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> * Makefile.am (EXTRA_DIST_CONF): include nfs_prot_darwin.h in distributions. +2001-02-22 Erez Zadok <ezk@earth.cs.columbia.edu> + + * released snapshot am-utils-6.1a3 + + * amd/Makefile.am (EXTRA_amd_SOURCES): don't forget to distribute + get_args.c + 2001-02-21 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> * libamu/mtab.c: added the functions hasmnteq and haseq to @@ -960,8 +6393,6 @@ 2001-02-18 Erez Zadok <ezk@earth.cs.columbia.edu> - * released snapshot am-utils-6.0.6s1 - * aux/macros/mount_headers.m4, include/mount_headers[12].h: split mount_headers.h in two because one relative header (nfs_prot.h) file cannot be included inside another from the start directory of @@ -984,11 +6415,12 @@ * conf/mount/mount_linux.c: made linux_nfs_error() more robust. -2001-02-02 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> +2001-02-01 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> - ******************************************************************* - *** Released am-utils-6.0.5 *** - ******************************************************************* + * released snapshot am-utils-6.1a2 + + * updated ltmain.sh and ltconfig from latest stable version of + libtool-1.3.5 2001-02-01 Ion Badulescu <ionut@moisil.dev.hydraweb.com> @@ -1000,11 +6432,6 @@ nfs_errormap array, lest the following errno's get shifted up by one! -2001-01-12 Ion Badulescu <ionut@buggy.dev.hydraweb.com> - - * include/am_defs.h: don't allow linux/fs.h to be sucked in via - linux/auto_fs.h, it breaks the compile on glibc platforms. - Sat Jan 13 00:04:38 2001 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> * amd/amd.h (autofs_lookuppn): Fixup whitespace. @@ -1015,9 +6442,10 @@ Sat Jan 13 00:04:38 2001 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> * amd/info_file.c (read_line): Likewise. (search_or_reload_file): Likewise. * amd/info_ldap.c (get_ldap_timestamp): Likewise. + * amd/map.c (get_root_ap): Likewise. * amd/nfs_prot_svc.c: Likewise. * amd/ops_TEMPLATE.c (foofs_match, foofs_lookuppn, - foofs_readlink, foofs_ffserver): Likewise. + foofs_readlink, foofs_ffserver): Likewise. * amd/ops_autofs.c (autofs_bgmount): Likewise. * amd/ops_lofs.c (lofs_match): Likewise. * amd/ops_nfs.c (got_nfs_fh): Fixup whitespace. @@ -1044,10 +6472,6 @@ Sat Jan 13 00:04:38 2001 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> amq_program_1): Likewise. (nfsxprt): Moved declaration. -Fri Jan 12 23:46:31 2001 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> - - * hlfsd/hlfsd.h (HLFSD_VERSION): Bump copyright year to 2001. - Fri Jan 12 23:31:45 2001 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> Removed support for amq -M. @@ -1072,6 +6496,39 @@ Fri Jan 12 23:31:45 2001 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> * tasks: Removed this task. +Fri Jan 12 23:18:26 2001 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> + + * conf/autofs/autofs_*.c: Bump copyright year to 2001. + * hlfsd/hlfsd.h (HLFSD_VERSION): Likewise. + + * aux/macros/check_autofs_style.m4: Renamed solaris[12] styles to + solaris_v1, solaris_v2_v3 to reflect that these are AutoFS + protocol version numbers, not solaris versions. + * conf/autofs/autofs_solaris[12].[ch]: Renamed to + autofs_solaris_{v1, 2_v3}.[ch] to reflect this. + * Makefile.am (EXTRA_DIST_CONF): Likewise. + + * aux/macros/check_autofs_style.m4: Use solaris2 style for both + versions 2 and 3 of the AutoFS protocol. + + Handle missing AUTOFS_POSTUNMOUNT, AUTOFS_POSTMOUNT (unnecessary + with Solaris 8 mntfs). + + * conf/autofs/autofs_solaris2.c (xdr_postumntreq, xdr_postumntres, + xdr_postmountreq, xdr_postmountres, autofs_postunmount_2_req, + autofs_postmount_2_req ): Don't define for version 3. + (autofs_program_2): Don't handle AUTOFS_POSTUNMOUNT, + AUTOFS_POSTMOUNT if missing. + + * conf/nfs_prot/nfs_prot_sunos5_8.h: Enable AutoFS support. + + * aux/macros/check_autofs_style.m4: Use empty autofs_default.[ch] + files on systems without existing autofs port. + * conf/autofs/autofs_default.[ch]: New files, empty. + * Makefile.am (EXTRA_DIST_CONF): Distribute them. + * INSTALL: With this change, Solaris 8 and Tru64 5.1 compile and + link. + 2001-01-12 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> * Makefile.am (EXTRA_DIST): distribute new LDAP files. @@ -1117,41 +6574,118 @@ Fri Jan 5 05:12:02 2001 Erez Zadok <ezk@subzero.cs.columbia.edu> * include/am_xdr_func.h: prototype should take "groups *" as 2nd arg. - * libamu/xdr_func.c (xdr_groupnode, xdr_exportnode): change + * libamu/xdr_func.c (xdr_groupnode, xdr_exportnode): change casting of second arg of xdr_groups to "groups *". It's only needed for irix6, due to problems with xdr_groups on that platform. (xdr_groups): prototype should take "groups *" as 2nd arg. * conf/nfs_prot/nfs_prot_aix*.h: correct xdr_groups extern - definition. Report from Ahmon Dancy <dancy@franz.com>. - -2000-12-14 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> + definition. Report from Ahmon Dancy <dancy@franz.com>. - * released snapshot am-utils-6.0.5s4 +2000-12-06 Ion Badulescu <ionut@moisil.dev.hydraweb.com> - * minor port i386-unknown-freebsd4.2 (documented) + * include/am_defs.h: force non-inclusion of <linux/fs.h> via + <linux/auto_fs.h> -2000-12-07 Ion Badulescu <lionut@gonzales.dev.hydraweb.com> + * conf/autofs/autofs_linux.c (autofs_mounted): rename + AUTOFS_MIN_PROTO_VERSION to AUTOFS_MIN_VERSION (leftover from + previous commit) - * configure.in (LIBTOOL_LDFLAGS): fix libtool version + * configure.in: fixed libtool version 2000-12-02 Ion Badulescu <ionut@moisil.dev.hydraweb.com> * doc/am-utils.texi (opts Option): document lock/nolock +2000-12-02 Ion Badulescu <ionut@moisil.dev.hydraweb.com> + + * conf/autofs/autofs_linux.h: added struct autofs_pending_mount; + modified autofs_fh_t to have a linked list of autofs_pending_mount; + added some support for autofs4 + + * conf/autofs/autofs_linux.c: use a linked list for pending + request, to allow for handling multiple simultaneous request; + incipient non-functional support for autofs4; incipient + non-functional support for bind-mounting + + * amd/amd.c (main): print a warning if PROCLOCK is requested but + the O/S doesn't support it + * libamu/mount_fs.c (mnt_flags): allow the use of the "nolock" option - * include/am_defs.h: don't include <linux/fs.h> on a glibc2 system + * include/am_defs.h: don't include <linux/fs.h> on a glibc2 + system; include <linux/auto_fs4.h> if it exists, instead of + <linux/auto_fs.h> * include/am_compat.h: define the "nolock" mnttab option if the NONLM NFS mount option is defined - * acconfig.h: added MNT2_NFS_OPT_NONLM + * acconfig.h: added MNT2_NFS_OPT_NONLM, MNT2_GEN_OPT_BIND * configure.in: added detection of the NONLM Linux NFS mount option; added a clarification for the library versioning rules and - increased the patchlevel + increased the minor level; added detection of <linux/auto_fs4.h> + and the MS_BIND generic mount option + +2000-11-29 Ion Badulescu <ionut@moisil.dev.hydraweb.com> + + * Enabled Solaris 2.7 autofs support (tested, works) + + * Updated NEWS, README.autofs + + * Updated Makefile's, make dist is now fixed + + * Fixed potential memory leak in map.c + + * Fixed autofs style detection for solaris 2.[67] + + * Added a few casts in autofs_solaris2.c, needed on Solaris 2.7 + +2000-11-28 Ion Badulescu <ionut@moisil.dev.hydraweb.com> + + More Solaris 2.[67] work in progress: + + * changed the API for the mount/umount methods: fmount/fumount are + gone, and mount/umount now take two arguments (am_node and mntfs) + + * changed the semantics of the MFF_AUTOFS flag: MFF_AUTOFS now + means the mntfs is a filesystem of type autofs, and AMF_AUTOFS + means the am_node is a node on a filesystem of type autofs. + + * renamed nfs_program_2_transp to current_transp so it can be used + with autofs + + * renamed quick_reply() to nfs_quick_reply() + + * added two more autofs methods: autofs_umount_failed() and + autofs_compute_mount_flags() -- it turns out that on sol2.6 the + autofs mounts MUST be overlay'ed + + * moved the autofs_mount_succeeded() into am_mounted() + + * made amd *not* timeout autofs mounts -- the kernel will do it + for us + + * store dev and rdev of a mounted filesystem in the mntfs + structure, to help autofs + + * moved the rmdirs() call from uninit_mntfs() to am_umounted(), to + prevent deadlocking with autofs + + * amd/Makefile.am: shuffled things around to make + update_build_version be the last thing that runs + +2000-11-27 Ion Badulescu <ionut@moisil.dev.hydraweb.com> + + * split amd/ops_autofs.c into conf/autofs/autofs_<system>.c files + and made configure create a symlink to the appropriate one + + * moved the xdr autofs functions from libamu/xdr_func.c into the + system-specific conf/autofs/autofs*.c + + * added some more experimental code to the sol2.6 autofs support, + but it's by no means functional 2000-11-27 Ion Badulescu <ionut@moisil.dev.hydraweb.com> @@ -1178,13 +6712,12 @@ Fri Jan 5 05:12:02 2001 Erez Zadok <ezk@subzero.cs.columbia.edu> * amd/srvr_nfs.c: comment on NFS proto search order. * libamu/xutil.c (real_plog): don't try to write the last byte of - the fmt buf. Security suggestion from NetBSD: Thomas Klausner + the fmt buf. security suggtion from NetBSD: Thomas Klausner <wiz@danbala.ifoer.tuwien.ac.at> 2000-11-22 Ion Badulescu <ionut@moisil.dev.hydraweb.com> - * amd/amfs_auto.c (amfs_auto_bgmount), - amd/ops_autofs.c (autofs_bgmount): removed the initialization of + * amd/amfs_auto.c (amfs_auto_bgmount): removed the initialization of fattr.na_fileid, it is now done in map.c when the map is initialized * amd/map.c (init_map): initialize fattr.na_fileid to am_gen, not @@ -1239,8 +6772,6 @@ Fri Jan 5 05:12:02 2001 Erez Zadok <ezk@subzero.cs.columbia.edu> 2000-11-19 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> - * released snapshot am-utils-6.0.5s3 - * updated config.guess, config.sub, and doc/texinfo.tex from mirrors @@ -1250,10 +6781,6 @@ Fri Jan 5 05:12:02 2001 Erez Zadok <ezk@subzero.cs.columbia.edu> * aux/macros/check_nfs_prot_headers.m4: newer netbsd systems reports their system name as "netbsdelf" in config.guess. -2000-11-15 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> - - * released snapshot am-utils-6.0.5s2 - 2000-11-13 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> * doc/am-utils.texi (opts Option): document new mount option @@ -1266,19 +6793,35 @@ Fri Jan 5 05:12:02 2001 Erez Zadok <ezk@subzero.cs.columbia.edu> option in Amd, useful under DU-4.0 to process ACLs over NFS mounts. -2000-11-10 Ion Badulescu <ib42@earth.cs.columbia.edu> +2000-11-10 Ion Badulescu <ionut@moisil.dev.hydraweb.com> * conf/mount/mount_linux.c (mount_linux): removed unnecessary rsize/wsize defaults -- performance killers on 2.2.18+ and 2.4.0+ -2000-11-01 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> - - * MIRRORS (Note): added a mirror at ufl.edu - 2000-10-16 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> * scripts/am-eject.in: accept "cdrom" and "floppy" as arguments. +2000-11-05 Ion Badulescu <ionut@moisil.dev.hydraweb.com> + + Too many changes to list them here. Here's a high level + description: + + * Forward-ported the Linux fixes from 6.0.5pre + + * Got rid of a mountain of #ifdef DEBUG, replaced with smart + header-file #ifdef's + + * and, the grand finale: initial Solaris 2.6 autofs + support. Compiles, mounts, gets requests; all the + infrastructure is in place to actually implement the calls. Linux + autofs might be a bit broken, but only compile-time so it'll be + easy to fix. + +2000-11-01 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> + + * MIRRORS (Note): added a mirror at ufl.edu + 2000-10-11 Erez Zadok <ezk@lorien.dev.hydraweb.com> * amq/amq.8: synchronize Amq's options with reality @@ -1295,21 +6838,6 @@ Fri Jan 5 05:12:02 2001 Erez Zadok <ezk@subzero.cs.columbia.edu> * scripts/lostaltmail.in (vrfy_user): ensure that MAILDIR is defined. -2000-10-02 Ion Badulescu <ionut@moisil.dev.hydraweb.com> - - * aux/macros/mount_headers.m4: only include <linux/fs.h> - on a non-glibc2 system - - * aux/macros/try_compile_anyfs.m4: ditto - - * aux/macros/check_mount_type.m4: linux 2.4 stores loadable modules - in a different directory structure - - * aux/macros/check_mnttab_type.m4: ditto - - * aux/macros/check_fs_mntent.m4: ditto; also, replace the nfs3 - linux hack with a hopefully more stable hack - 2000-09-18 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> * amd/opts.c (backslash): Bell char (ASCII 007) should be \g, not @@ -1321,15 +6849,6 @@ Fri Jan 5 05:12:02 2001 Erez Zadok <ezk@subzero.cs.columbia.edu> * amd/opts.c: removed unused variable $autopref -2000-09-15 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> - - * released snapshot am-utils-6.0.5s1 - -2000-09-11 Ion Badulescu <ionut@moisil.dev.hydraweb.com> - - * aux/macros/check_fs_mntent.m4 (_LINUX_NFS_XDR_H): define it so - linux/nfs_xdr.h doesn't get included (not intended for user space) - 2000-09-05 Erez Zadok <ezk@aladdin.dev.hydraweb.com> * conf/mtab/mtab_svr4.c (lockfile): function not needed unless @@ -1371,20 +6890,8 @@ Fri Jan 5 05:12:02 2001 Erez Zadok <ezk@subzero.cs.columbia.edu> * doc/am-utils.texi: updated URLs to www.am-utils.org. -2000-07-08 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> - - ******************************************************************* - *** Released am-utils-6.0.4 *** - ******************************************************************* - -2000-07-08 Erez Zadok <ezk@earth.cs.columbia.edu> - - * configure.in: update shared library information - 2000-07-04 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> - * INSTALL: document osf4.0f - * doc/am-utils.texi (Supported Platforms): document osf4.0f 2000-06-19 Erez Zadok <ezk@vir.cs.columbia.edu> @@ -1396,9 +6903,33 @@ Fri Jan 5 05:12:02 2001 Erez Zadok <ezk@subzero.cs.columbia.edu> literal '$' sign. Otherwise there is no way to include a literal dollar symbol in an amd map. +2000-06-11 Ion Badulescu <ib42@moisil.cs.columbia.edu> + + * amd/opts.c (eval_selectors): don't deref opt after it's been + XFREE'd + 2000-06-11 Erez Zadok <ezk@earth.cs.columbia.edu> - * amd/opts.c: correct comment name at top of opt_fields. + * amd/opts.c: move mount_type expansion until later in the list, + so common variable are "hit" first. + +2000-06-11 Ion Badulescu <ib42@moisil.cs.columbia.edu> + + * amd/opts.c (split_opts, eval_selectors): split old function + eval_opts into two, one that only splits non-selectors and + assigns the values to fs_static, and one that only evaluates + selectors; also simplified the rather obfuscated logic inside + these functions + (expand_op): made it take a char * instead of a structure from + which it was using only one field (a char *). Also now returns a + char * instead of modifying said structure in place + (expand_opts): deal with the change above + (expand_selectors): renamed from expand_key + (expand_options): new function, expands non-selectors; it's the + complement of expand_selectors, both of which are just wrappers + around expand_op() + (eval_fs_opts): use the new split_opts, eval_selectors to allow + using options (like ${rhost}) in selectors 2000-06-11 Ion Badulescu <ionut@moisil.cs.columbia.edu> @@ -1423,8 +6954,6 @@ Fri Jun 9 16:06:56 2000 Erez Zadok <ezk@defiant.dev.hydraweb.com> 2000-06-07 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> - * released snapshot am-utils-6.0.4s5 - * Makefile.am, aux/GNUmakefile: fix maintainer rules to update config.* and texinfo.tex files. @@ -1432,8 +6961,8 @@ Fri Jun 9 16:06:56 2000 Erez Zadok <ezk@defiant.dev.hydraweb.com> mtime update of the symlinks on the SYMTTL option, but rather delay unmount of what was looked up using am_timeo_w. Patch from Nick Williams <Nick.Williams@msdw.com>. As Nick says "Basically: - during unmount, increment the parent dir's mtime (fixes people - doing amq -u). During stat, increase the TTL (to fix bad-luck + during unmount, increment the parent dir's mtime (fixes + people doing amq -u). During stat, increase the TTL (to fix bad-luck timeouts), but leave the mtime alone." (nfsproc_lookup_2_svc, nfsproc_readlink_2_svc, unlink_or_rmdir, @@ -1488,6 +7017,12 @@ Fri Jun 9 16:06:56 2000 Erez Zadok <ezk@defiant.dev.hydraweb.com> * cvs-server.txt: instructions for maintainers to access the CVS server for am-utils. +2000-06-03 Ion Badulescu <ionut@moisil.cs.columbia.edu> + + * amd/restart.c (restart): grr.. passing around initialized + structures is *really* bad habit. memset(mo, 0) so at least we can + test for NULL pointers... + 2000-06-02 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> * amd/am_ops.c (ops_match): changed XLOG_USER messages about @@ -1497,32 +7032,115 @@ Fri Jun 9 16:06:56 2000 Erez Zadok <ezk@defiant.dev.hydraweb.com> * config.{guess,sub}: make sure chmod'ed a+rx. Updated from latest GNU copies. -2000-05-30 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> +2000-05-30 Ion Badulescu <ionut@moisil.cs.columbia.edu> + + * aux/configure.in: bump up the version to 6.1a2 + +2000-05-29 Ion Badulescu <ionut@moisil.cs.columbia.edu> - * released snapshot am-utils-6.0.4s4 + * released snapshot am-utils-6.1a1 2000-05-29 Ion Badulescu <ionut@moisil.cs.columbia.edu> + * amd/ops_autofs.c (autofs_mounted): retrieve the autofs protocol + version and store it in the fh + (autofs_get_opts): support protocol version 4 + + * amd/mntfs.c (uninit_mntfs): clear the autofs fh pointer after + releasing it + * conf/transp/transp_sockets.c (amu_svc_getcaller): cast result of svc_getcaller() to sockaddr_in, to appease glibc 2.2 + * amd/amfs_auto.c (amfs_auto_bgmount): if the filesystem wants + autofs handling and the parent is already handled by autofs, + handle this filesystem as well + (amfs_auto_mount): create the mountpoint for an autofs mount + (amfs_auto_umount): do a real UMOUNT_FS() call for autofs mounts + + * include/am_utils.h (FS_AUTOFS): new flag signalling that the + filesystem wants autofs handling; toplvl, auto, host and direct + have this flag, at least for now + 2000-05-28 Erez Zadok <ezk@mulberry.mcl.cs.columbia.edu> * doc/am-utils.texi (Network Filesystem Group): minor typos -2000-05-27 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> +2000-05-28 Ion Badulescu <ionut@moisil.cs.columbia.edu> + + * amd/autil.c (am_unmounted): check mp->am_parent before dereferencing + + * amd/srvr_nfs.c (find_nfs_srvr): if NFS_SCALEDOWN, force + version=2 and proto=udp and try again + + * amd/ops_nfs.c (prime_nfs_fhandle_cache): take an explicit mntfs + instead of a voidp; handle the NFS_SCALEDOWN case by removing the + cached server entry and re-querying the server + + * amd/amfs_toplvl.c (amfs_toplvl_mount): removed ugly if + statement, assign mnttype from the fs-specific mf_ops->fs_type + instead + + * amd/amfs_nfsx.c (amfs_nfsx_init): call fs_init() only if it's + defined; + (amfs_nfsx_remount): removed superfluous check for fmount_fs -- it + always exists + (amfs_nfsx_umount): removed the hacked am_node -- umounted() now + takes an mntfs; call umounted() only if it's defined + + * amd/amfs_auto.c: removed amfs_auto_umounted and moved its + functionality into am_umounted(). + (amfs_auto_cont): Linux hack: if we got an EINVAL, mark the mntfs + as needing an "NFS scaledown" and retry the operation + + * amd/amfs_*.c: changed all fmount/fumount functions to + mount/umount and made them take an am_node instead of an + mntfs. This is a first step towards an amfs/ops API separation. + + * amd/{amfs,ops}_*.c: changed the umounted() function to take an + mntfs instead of an am_node + +2000-05-28 Ion Badulescu <ionut@moisil.cs.columbia.edu> - * amd/amfs_auto.c (amfs_auto_readdir_browsable): cast pointers to - long for 64-bit architectures. + * amd/amfs_toplvl.c (mount_amfs_toplvl): init error to 0 to shut + up gcc - * libamu/xutil.c (amu_release_controlling_tty): eliminate an - unused variable "tempfile" + * aux/macros/check_hide_mount_type.m4: revert to the 6.0 version + which always defines HIDE_MOUNT_TYPE + + * amd/ops_autofs.c (autofs_mounted): remove MFF_AUTOFS + initialization -- now done in init_mntfs() + + * amd/mntfs.c (init_mntfs): init mf_flags to MFF_AUTOFS if we are + mounting an autofs-style map + + * amd/*.c: use the MFF_AUTOFS flag instead of doing a costly STREQ + + * amd/amfs_toplvl.c (mount_amfs_toplvl): MTYPE_TYPE is not + necessarily a string type, so handle the nfs/autofs separation + differently + + * amd/amfs_auto.c (amfs_auto_bgmount): removed initialization of + opt_mount_type (now done in ops_match()) + + * amd/am_ops.c (ops_match): need to initialize opt_mount_type if + it's not initialized yet + +2000-05-27 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> * libamu/wire.c (getwire_lookup): handle calling irs_gen_acc with one or two arguments (bsdi3 vs. bsdi4) +2000-05-27 Ion Badulescu <ib42@chestnut.mcl.cs.columbia.edu> + + * libamu/xutil.c (amu_release_controlling_tty): removed an unused + variable from the previous patch + 2000-05-26 Ion Badulescu <ionut@moisil.cs.columbia.edu> + * aux/macros/check_autofs_style.m4: fixed substitution for default + case + * libamu/xutil.c (amu_release_controlling_tty): close standard file descriptors, re-open them as /dev/null @@ -1536,6 +7154,50 @@ Fri Jun 9 16:06:56 2000 Erez Zadok <ezk@defiant.dev.hydraweb.com> getattr). This fixes the problem introduced by the Linux nfsv3 patches. +2000-05-12 Ion Badulescu <ionut@moisil.cs.columbia.edu> + + * Makefile.am (EXTRA_DIST_CONF): added conf/autofs/autofs_linux.h + +2000-05-10 Ion Badulescu <ib42@earth.cs.columbia.edu> + + * amd/ops_autofs.c (autofs_handle_fdset): call + autofs_lookup_failed instead of autofs_mount_failed, if the name + is not in the map + (autofs_umount_{succeeded,failed}): pass the actual mount point, + not its parent, as it's needed for clean-up; + + * amd/autil.c (am_unmounted): notify autofs that the umount + succeeded + + * amd/amfs_link.c (amfs_link_[u]mount): autofs link notification + moved elsewhere + +2000-05-09 Ion Badulescu <ionut@moisil.cs.columbia.edu> + + * amd/amfs_auto.c (amfs_auto_bgmount): initialize opt_mount_type + if necessary; + (amfs_auto_mounted): test if opt_mount_type is NULL first + (amfs_auto_mount): revert earlier change + + * amd/ops_autofs.c (autofs_mount_failed): remove autofs directory + if mount failed + +2000-05-09 Ion Badulescu <ionut@moisil.cs.columbia.edu> + + * amd/ops_autofs.c (autofs_link_mount): use am_link as target + + * amd/map.c (unmount_mp): release file handle for autofs f/s about + to be unmounted; this leak was preventing the unmount altogether + + * amd/amfs_auto.c (amfs_auto_umount): removed autofs-specific + code, was broken + (amfs_auto_bgmount): nfs mounts + sublinks is a valid combination, + handle it + +2000-05-07 Ion Badulescu <ib42@moisil.cs.columbia.edu> + + * Merged changes from stable branch + 2000-04-30 Erez Zadok <ezk@beetle.mcl.cs.columbia.edu> * include/am_defs.h, aux/macros/mount_headers.m4, @@ -1583,6 +7245,58 @@ Fri Jun 9 16:06:56 2000 Erez Zadok <ezk@defiant.dev.hydraweb.com> (main): add amq -H option to show usage. (main): new amq -w option, translates getpwd() into an amd path. +2000-02-25 Ion Badulescu <ionut@moisil.cs.columbia.edu> + + * libamu/util.c (get_server_pid): new function + + * hlfsd/hlfsd.c (main): make use of HIDE_MOUNT_TYPE + + * conf/transp/transp_sockets.c: removed create_autofs_service + + * conf/mount/mount_linux.c: added autofs mount options; split + mount_linux into two functions, itself and do_mount_linux + + * aux/macros/check_hide_mount_type.m4: better failover + + * aux/configure.in: changed version to 6.1a1; added + AC_CHECK_AUTOFS_STYLE + + * aux/aux_conf.h.in: added @am_utils_autofs_style@ + + * amd/opts.c: added "mount_type" option + + * amd/ops_autofs.c: ifdef-ed out solaris code; moved all autofs + variables in here; split create_autofs_service into sun and linux + specific functions + + * amd/nfs_start.c: removed autofs-specific variables + + * amd/map.c (get_root_nfs_fh): renamed root_fh to get_root_nfs_fh + (get_root_ap): renamed root_ap to get_root_ap + + * amd/amfs_toplvl.c (amfs_toplvl_ops): replaced + amfs_toplvl_mounted with amfs_auto_mounted + (mount_amfs_toplvl): moved code around, added autofs handling + (amfs_toplvl_mounted): removed + + * amd/amfs_nfsl.c (amfs_nfsl_ops): removed amfs_auto_fu?mount, + replaced with amfs_nfsl_u?mount + + * amd/amfs_linkx.c (amfs_linkx_ops): removed amfs_auto_fumount, + replaced with amfs_link_umount + + * amd/amfs_link.c (amfs_link_ops): removed amfs_auto_fu?mount, + replaced with amfs_link_u?mount + + * amd/amfs_direct.c (amfs_direct_ops): changed "mounted" function + from amfs_toplvl_mounted to amfs_auto_mounted + + * all: added autofs hooks throughout the code + + * amd/am_ops.c (vops): autofs_ops doesn't belong in here, removed + + * README.autofs: linux status update + 2000-02-24 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> * minor new port: alphaev6-dec-osf5.0 @@ -1605,7 +7319,7 @@ Fri Jun 9 16:06:56 2000 Erez Zadok <ezk@defiant.dev.hydraweb.com> * Makefile.am: removed struct_nfs_mount_data.m4 * aux/macros/struct_nfs_mount_data.m4: deleted - + * aux/acconfig.h: removed definition for HAVE_NFS_MOUNT_DATA * aux/configure.in: removed check for struct nfs_mount_data @@ -1854,10 +7568,10 @@ Fri Dec 10 01:31:53 1999 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> mount_svr4(). (mount_svr4): Adapt prototype. * conf/mount/mount_svr4.c (mount_svr4): Pass them to kernel so - they are evaluated and show up in Solaris 8 in-kernel mnttab. + they are evaluated and show up in Solaris 8 in-kernel mnttab. * aux/configure.in: Check for new Solaris 8 MS_OPTIONSTR mount(2) - option. + option. * aux/acconfig.h (MNT2_GEN_OPT_OPTIONSTR): Provide template. 1999-12-10 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> @@ -1910,7 +7624,7 @@ Thu Dec 9 19:09:38 1999 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> * aux/macros/os_cflags.m4: Treat Solaris 8 and higher like 2.6/7. * aux/macros/check_fs_headers.m4: Revert test for duplicate - objects. + objects. * aux/macros/check_fs_mntent.m4: Likewise * aux/macros/HEADER: Fixed typo. @@ -2780,12 +8494,12 @@ Tue Jan 12 00:05:42 1999 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> (hlfsd_getpwent): Likewise for pw_uid. * amd/info_nis.c (nis_init): Cast order to unsigned long, adapt - format. + format. * conf/transp/transp_tli.c (amu_clnt_create_best_vers): Cast tv_sec to int to match format. (get_nfs_version): Cast nfs_version, NFS_VERSION to int to match - formats. + formats. * amd/amfs_program.c (amfs_program_exec): Cast ptr difference to long, adapt format. @@ -2807,7 +8521,7 @@ Mon Jan 11 13:46:44 1999 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> format. * hlfsd/homedir.c (homedir): Cast uid, child to long, adapt - format. + format. * amd/info_hesiod.c (hesiod_search): Cast m, pval, tp to unsigned long, adapt format. @@ -2816,7 +8530,7 @@ Mon Jan 11 13:46:44 1999 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> unsigned long, adapt format. (got_nfs_fh): Likewise. (prime_nfs_fhandle_cache): Cast fh_nfs_version to int to match - format. + format. (call_mountd): Likewise, mnt_version also. (mount_nfs_fh): Likewise. @@ -2829,13 +8543,13 @@ Mon Jan 11 13:46:44 1999 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> (autofs_lookuppn): Removed superfluous arg. * amd/srvr_nfs.c (start_ping): Cast nfs_version to int to match - format. + format. (got_portmap): Likewise for port. (recompute_portmap): Likewise for fs->fs_version, mnt_version. (find_nfs_srvr): Likewise for nfs_version. * amd/sched.c (sched_task): Cast wchan to unsigned long, adapt - format. + format. * amd/nfs_start.c (checkup): Cast ptr difference to long, next_mem to unsigned long, adapt format. @@ -2885,7 +8599,7 @@ Mon Jan 11 13:46:44 1999 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> Fri Jan 8 15:24:15 1999 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> * aux/macros/check_mtype_type.m4: Ultrix uses an int mount type, - too. + too. * aux/macros/check_mtype_printf_type.m4: Adapt corresponding printf type. @@ -3245,7 +8959,7 @@ Tue Apr 28 15:12:36 1998 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> support. Fri Apr 24 23:02:11 1998 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> - + * libamu/xutil.c (get_syslog_facility): Don't use LOG_DAEMON unconditionally, may be missing on Ultrix V4.3. @@ -3253,7 +8967,7 @@ Thu Apr 23 20:24:33 1998 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> * conf/nfs_prot/nfs_prot_sunos5_4.h (MNTTYPE_CACHEFS): Define, missing from <sys/mntent.h>. - + * conf/mtab/mtab_ultrix.c: Need separate inclusion of <sys/fs_types.h> without KERNEL defined here. @@ -3352,7 +9066,7 @@ Sun Apr 19 16:30:35 1998 Erez Zadok <ezk@lorien.cs.columbia.edu> before writing log file and restore it afterwards. Patch from Donald Buczek <buczek@MPIMG-Berlin-Dahlem.MPG.DE>. - * amd/get_args.c (get_args): + * amd/get_args.c (get_args): * doc/am-utils.texi (-F Option), amd/amd.8: mention that amd.conf file specified by -F is always processed last. @@ -3727,7 +9441,7 @@ Thu Jan 29 00:44:28 1998 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> into that file. * amd/get_args.c (get_args): print correct -l option depending if - system supports syslog and/or syslog facilities. Patch from + system supports syslog and/or syslog facilities. Patch from Tom Schmidt <tschmidt@micron.com>. * doc/am-utils.texi (opts Option): updates for documentation for @@ -4993,7 +10707,7 @@ Fri Jul 25 03:16:31 1997 Erez Zadok <ezk@felix.psl.cs.columbia.edu> structure to actual char[], because the structure was passed to xdr_fhandle as data and not a pointer. Surprisingly, gcc -fpcc-struct-return did not help. - + * conf/nfs_prot/nfs_prot_sunos5_4.h: special nfs protocol definitions for solaris 2.4 have to be different from 2.3, and different from 2.5. @@ -5048,7 +10762,7 @@ Wed Jul 23 16:11:49 1997 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> * amd/ops_afs.c (afs_retry): patches from Debian Linux. If afs_mount timed out, then explicitly forbid further retries after - the timeout. (afs_bgmount): buf fix from Debian Linux. Timeout + the timeout. (afs_bgmount): bug fix from Debian Linux. Timeout values (17 and 5) were mistakenly swapped. Wed Jul 23 15:53:25 1997 Erez Zadok <ezk@felix.psl.cs.columbia.edu> @@ -5307,7 +11021,7 @@ Tue Jul 8 12:42:03 1997 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> Mon Jul 7 19:10:44 1997 Erez Zadok <ezk@prometheus.soscorp.com> - * NFS V3 now works under Irix5, thanks to patches from + * NFS V3 now works under Irix5, thanks to patches from Andreas Stolcke <stolcke@speech.sri.com>. * conf/mount/mount_irix5.c: sparate mount_irix.c into an irix5 @@ -5326,7 +11040,7 @@ Sun Jul 6 14:22:24 1997 Erez Zadok <ezk@glory.soscorp.com> * aux/{configure.in,acconfig.h}: added checks for struct nfs_args's fields proto and sotype (bsdi3). - + * amd/ops_nfs.c (mount_nfs_fh): added nfsv3 option to nfs_args.flags for bsdi3. Set field proto to 0. Set sotype field to SOCK_STREAM or SOCK_DGRAM. @@ -5405,7 +11119,7 @@ Thu Jul 3 17:49:00 1997 Erez Zadok <ezk@prometheus.soscorp.com> * aux/configure.in: some cleanup of which libraries are needed. Espectially ensure that libnsl is included only on Solaris, where so far it is the only system on which it is absolutely necessary. - Also no longer need to include libc explicitly. + Also no longer need to include libc explicitly. * amd/amd.c,wire-test/wire-test.c (main): convert IP address to network-long order before printing it. @@ -5418,7 +11132,7 @@ Thu Jul 3 17:49:00 1997 Erez Zadok <ezk@prometheus.soscorp.com> Wed Jul 2 18:19:02 1997 Erez Zadok <ezk@starblazers.soscorp.com> * scripts/ctl-amd.in: don't use full pathname so killproc() works - better. Also run bsd44 and irix style ps programs. + better. Also run bsd44 and irix style ps programs. * aux/macros/check_lib_funcs.m4: bug fixed: used to define usage of library no matter if it was found or not. @@ -5588,7 +11302,7 @@ Sat May 24 13:40:50 1997 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> * scripts/ctl-hlfsd.in: new script ctl-hlfsd. Used to start, stop, or restart hlfsd. - + * scripts/expn.1: man page for expn command. * scripts/ctl-amd.in: new script ctl-amd. Used to start, stop, or @@ -5609,7 +11323,7 @@ Sat May 24 13:40:50 1997 Erez Zadok <ezk@shekel.mcl.cs.columbia.edu> linux-specific mounts. Handles fs-type specific mount-options correctly. Currently implemented: msdos, iso9660. - * amd/ops_pcfs.c (pcfs_ops): don't timeout cdfs mounts by default + * amd/ops_pcfs.c (pcfs_ops): don't timeout pcfs mounts by default (fix for linux). * amd/ops_cdfs.c (cdfs_ops): don't timeout cdfs mounts by default @@ -5733,7 +11447,7 @@ Sat May 6 10:20:17 2000 Erez Zadok <ezk@glory.soscorp.com> possible children. * hlfsd/homedir.c: signal handler must waitpid() for all possible - children. + children. * aux/macros/check_restartable_signals.m4: new macro to determine if need to reinstall signal handlers per OS is better than trying @@ -5814,7 +11528,7 @@ Sat Mar 15 19:37:48 1997 Erez "HWank1" Zadok <ezk@shekel.mcl.cs.columbia.edu> Sat Mar 14 10:11:03 1997 Erez "HWank1" Zadok <ezk@lorien.cs.columbia.edu> - * SHARED LIBRARIES: too many change to list individually. Now, + * SHARED LIBRARIES: too many changes to list individually. Now, libamu can be built as a shared library, and other programs link with it. @@ -6010,7 +11724,7 @@ Sun Feb 23 15:25:26 1997 Erez "HWank1" Zadok <ezk@shekel.mcl.cs.columbia.edu> * aux/acconfig.h: define and use HAVE_NFS_PROT_HEADERS as needed. * aux/macros/check_nfs_prot_header.m4: new test to determine what - NFS protocol headers to use. + NFS protocol headers to use. * conf/nfs_prot/nfs_prot_{irix6,sunos4,bsdi2}.h: new headers to complete missing system headers for NFS protocol definitions. @@ -6300,7 +12014,7 @@ Wed Dec 18 22:20:23 1996 Erez "HWank1" Zadok <ezk@shekel.mcl.cs.columbia.edu> Wed Dec 11 22:19:29 1996 Erez "HWank1" Zadok <ezk@shekel.mcl.cs.columbia.edu> - * At this point the initial genration of config.h via autoconf and + * At this point the initial generation of config.h via autoconf and some preliminary makefiles via automake is done. I will not begin modifying sources, so it's a good time to document from here. diff --git a/contrib/amd/FAQ b/contrib/amd/FAQ new file mode 100644 index 000000000000..18e73a3fab20 --- /dev/null +++ b/contrib/amd/FAQ @@ -0,0 +1,69 @@ + Am-utils Frequently Asked Questions + +Note: we started this FAQ only on March 15, 2005; so it's not long or +comprehensive, yet. Amd is much older than that, and so there's a lot of +information that's already available in other forms. If this FAQ doesn't +answer your questions, see information in the following sources: + +1. The Am-utils book: http://www.am-utils.org/docs/amd-book/ + +2. The Am-utils user manual, which is part of the distribution and is also + available from www.am-utils.org. + +3. The www.am-utils.org Web site resources, especially the "am-utils" mailing + list (and its archives). + +4. In the am-utils distribution (always use the latest ones), see all of the + various README files (README, README.autofs, README.ldap, README.osx, and + README.y2k). The "BUGS" file also lists useful information about bugs + and problems with specific OSs which affect Amd. All of these text files + are also available from www.am-utils.org. + +5. Some FAQ questions (including newbie questions) are available here: + http://www.kernelcorp.com/resources_faqs.html + +6. Some problems are known bugs but have not been fixed yet: this are + listed in bugzilla in https://bugzilla.am-utils.org/ + +If you have additions to this FAQ, please let us know at +am-utils@am-utils.org. + +Thank you, +The Am-utils development team. + +<FAQ> + +*** Linux Questions + +Q1. When I use Amd with Autofs and I restart Amd, how come it cannot remount + the Autofs partitions? + +A1. This is a limitation of the Linux Autofs kernel module (for both autofs + v2. and v3). The Linux Autofs does not allow restarting automounted + points. There's nothing Amd can do about this. In fact, the same + problem exists if you use the userland "automount" daemon instead of + Amd. Hopefully Autofs-v4 or the separate effort of Autofs-NG will + address this serious problem. + + Note that Amd itself can restart autofs automounted points just fine on + OSs that support it, for example Solaris. + + +Q2. When I use Amd, I get this console message frequently: "mount version + older than kernel." Is it a problem? + +A2. No, it's a harmless warning message that the Linux kernel prints for NFS + mounts. The intent was to alert administrators that the kernel has + supposedly a different version of the mount(2) code than a userland + program used. This happens if you compile Amd against kernel headers + that are different than the kernel you're running. If the message + really bothers you, then one way to "fix" the problem is to recompile + Amd against the same kernel headers as the running kernel. + + Nevertheless, it is a relatively useless message because as far as we + know, the NFS v2 and v3 mount codes have been in perfect sync between + the userland and kernel sides, and were "standardized" for years + already. This warning message caused more unnecessary worry among + administrators than helping alert them to legitimate problems. + +</FAQ> diff --git a/contrib/amd/INSTALL b/contrib/amd/INSTALL index 25f75d711583..273fe02f4548 100644 --- a/contrib/amd/INSTALL +++ b/contrib/amd/INSTALL @@ -1,113 +1,91 @@ - am-utils 6.0 compatibility list + am-utils 6.1 compatibility list For each system, list if it autoconfigures, compiles, or runs. Fill in email id of person who confirms the fact. A missing entry means unverified. A 'no' or 'X' means verified broken or nonexistent (static library). -SYSTEM CONFIG COMPILE RUN SHLIB -========================= ====== ======= ===== ===== -alpha-dec-osf2.1 ezk[0] ezk ezk ezk[X] -alpha-dec-osf4.0 ezk[0] ezk dsr[3] ezk -alpha-dec-osf4.0f ezk[0] ezk dsr[3] ezk -alpha-dec-osf5.1 ro[0] ro ro ro -alphaev5-unknown-linux ezk[0] ezk finkel ezk -alphaev5-unknown-linux-rh5.2 ezk[0] ezk ezk ezk -alphaev6-dec-osf5.0 ezk[0] ezk dsr[3] ezk -hppa1.0-hp-hpux11.00 ezk[0] ezk ezk ezk -hppa1.1-hp-hpux10.10 ezk[0] ezk ezk ezk -hppa1.1-hp-hpux10.20 ezk[0] ezk ezk ezk -hppa1.1-hp-hpux11.00 ezk[0] ezk ezk ezk -hppa1.1-hp-hpux9.01 ezk[0,4]ezk[4] nrh/ezk ezk -hppa1.1-hp-hpux9.05 ezk[0,4]ezk[4] nrh/ezk ezk -hppa1.1-hp-hpux9.07 ezk[0,4]ezk[4] nrh/ezk ezk -hppa2.0w-hp-hpux11.00 ezk[0] ezk ezk ezk -i386-pc-bsdi2.1 ion ion ion ion[X] -i386-pc-bsdi3.0 ezk[0] ezk ezk ezk[X] -i386-pc-bsdi3.1 ezk[0] ezk ezk ezk[X] -i386-pc-bsdi4.0 ezk[0] ezk ezk ezk -i386-pc-bsdi4.0.1 ezk[0] ezk ezk ezk -i386-pc-bsdi4.1 ezk[0] ezk ezk ezk -i386-pc-linux ezk[0] ezk ezk ezk -i386-pc-linux-libc1 ezk[0] ezk ezk ezk -i386-pc-linux-libc1-rh4.2 ezk[0] ezk ezk ezk -i386-pc-linux-rh5.2 ezk[0] ezk ezk ezk -i386-pc-linux-rh6.0 ezk[0] ezk ezk ezk -i386-pc-linux-rh6.1 ezk[0] ezk ezk ezk -i386-pc-linux-rh6.2 ion ion ion ion -i386-pc-linux-rh7.1 ion ion ion ion -i386-pc-linux-rh7.2 ion ion ion ion -i386-pc-linux-rh7.3 ion ion ion ion -i386-pc-solaris2.5.1 ezk[0] ezk ezk ezk -i386-pc-solaris2.6 ezk[0] ezk ezk ezk -i386-pc-solaris2.7 ezk[0] ezk ezk ezk -i386-unknown-freebsd2.1.0 ezk[0] ezk ezk -i386-unknown-freebsd2.2.1 ezk[0] ezk ezk ezk -i386-unknown-freebsd2.2.6 ezk[0] ezk ezk ezk -i386-unknown-freebsd2.2.7 ezk[0] ezk ezk ezk -i386-unknown-freebsd2.2.8 ezk[0] ezk ezk ezk -i386-unknown-freebsd3.0 ezk[0] ezk ezk ezk -i386-unknown-freebsd4.2 ezk[0] ezk ezk ezk -i386-unknown-freebsd4.4 ezk[0] ezk ezk ezk -i386-unknown-freebsd5.0 ezk[0] ezk ezk ezk -i386-unknown-freebsdelf3.0 ezk[0] ezk ezk ezk -i386-unknown-freebsdelf3.1 ezk[0] ezk ezk ezk -i386-unknown-freebsdelf3.2 ezk[0] ezk ezk ezk -i386-unknown-freebsdelf3.3 ezk[0] ezk ezk ezk -i386-unknown-freebsdelf3.4 ezk[0] ezk ezk ezk -i386-unknown-freebsdelf4.0 ezk[0] ezk ezk ezk -i386-unknown-netbsd1.2.1 ezk[0] ezk ezk ezk -i386-unknown-netbsd1.3 ezk[0] ezk ezk ezk -i386-unknown-netbsd1.3.1 ezk[0] ezk ezk ezk -i386-unknown-netbsd1.3.2 ezk[0] ezk ezk ezk -i386-unknown-netbsd1.3.3 ezk[0] ezk ezk ezk -i386-unknown-netbsd1.4 ezk[0] ezk ezk ezk -i386-unknown-netbsd1.4.1 ezk[0] ezk ezk ezk -i386-unknown-openbsd2.1 ezk[0] ezk ezk ezk -i386-unknown-openbsd2.2 ezk[0] ezk ezk ezk -i386-unknown-openbsd2.3 ezk[0] ezk ezk ezk -i386-unknown-openbsd2.4 ezk[0] ezk ezk ezk -i386-unknown-openbsd2.5 ezk[0] ezk ezk ezk -i486-ncr-sysv4.3.03 ezk[0] ezk ezk -ia64-hp-hpux11.20 ezk[0] ezk ezk ezk -ia64-unknown-linux-rh7.1 ezk[0] ezk ezk ezk -ia64-unknown-linux-rh7.2 ezk[0] ezk ezk ezk -ia64-unknown-linux-rh2.1AS ezk[0] ezk ezk ezk -ia64-unknown-linux-rh2.1AW ezk[0] ezk ezk ezk -m68k-hp-hpux9.00 ezk[0,4]ezk[4] nrh/ezk -m68k-next-nextstep3 ezk[0] ezk ezk ezk[X] -m68k-sun-sunos4.1.1 ezk[0] ezk ezk[X] -mips-dec-ultrix4.3 ro[0] ro ro -mips-sgi-irix5.3 ezk[0] ezk ezk ezk -mips-sgi-irix6.2 ezk[0,1]ezk[1] ezk[1] ezk -mips-sgi-irix6.4 ezk[0] ezk ezk ezk -mips-sgi-irix6.5 ezk[0] ezk ezk -powerpc-ibm-aix4.1.5.0 ezk[0] ezk wpaul ezk[X] -powerpc-ibm-aix4.2.1.0 ezk[0] ezk ezk ezk[X] -powerpc-ibm-aix4.3.1.0 ezk[0] ezk ezk[X] -powerpc-ibm-aix5.1.0.0 ion ion ion ion[X] -powerpc-unknown-linux jose[0] jose jose -rs6000-ibm-aix3.2 ezk[0] ezk ezk -rs6000-ibm-aix3.2.5 ezk[0] ezk ezk -rs6000-ibm-aix4.1.4.0 ezk[0] ezk ezk[X] -rs6000-ibm-aix4.1.5.0 ezk[0] ezk ezk[X] -sparc-sun-solaris2.3 ezk[0] ezk ezk ezk -sparc-sun-solaris2.4 ezk[0] ezk ezk ezk -sparc-sun-solaris2.5 ezk[0] ezk ezk ezk -sparc-sun-solaris2.5.1 ion ion ion ion -sparc-sun-solaris2.6 ion ion ion ion -sparc-sun-solaris2.7 ion ion ion ion -sparc-sun-solaris2.8 ion ion ion ion -sparc-sun-sunos4.1.1 ezk[0] ezk ezk ezk -sparc-sun-sunos4.1.3 ezk[0] ezk ezk ezk -sparc-sun-sunos4.1.3C ezk[0] ezk ezk ezk -sparc-sun-sunos4.1.3_U1 ezk[0] ezk ezk ezk -sparc-sun-sunos4.1.4 ezk[0] ezk ezk ezk -sparc-unknown-linux-libc1 ezk[0] ezk ezk ezk -sparc-unknown-linux-rh6.2 ion ion ion ion -sparc-unknown-netbsd1.2E ezk[0] ezk ezk -sparc-unknown-netbsd1.2G ezk[0] ezk ezk -sparc64-unknown-linux-rh6.2 ion ion ion ion -sparc64-unknown-linux-suse7.3 ezk[0] ezk ezk ezk +SYSTEM CONFIG COMPILE RUN SHLIB AUTOFS +========================= ======= ======= ======= ======= ====== +alpha-dec-osf4.0f ro ro ro - - +alpha-dec-osf5.1 ro ro ro - - +alpha-unknown-linux-gentoo1.4.16 ezk ezk ezk ezk - +alphaev56-dec-osf4.0f ezk ezk ezk ezk - +i386-apple-darwin6.0 ezk ezk ezk ezk - +i386-pc-bsdi2.1 ion ion ion ion[X] ion[X] +i386-pc-linux-deb3.0 ezk ezk ezk ezk - +i386-pc-linux-deb3.1 ezk ezk ezk ezk - +i386-pc-linux-fc1 ezk ezk ezk ezk - +i386-pc-linux-fc2 ezk ezk ezk ezk - +i386-pc-linux-fc3 ezk ezk ezk ezk - +i386-pc-linux-fc4 ezk ezk ezk ezk - +i386-pc-linux-gentoo1.4.16 ezk ezk ezk ezk - +i386-pc-linux-rh6.2 ion ion ion ion ion +i386-pc-linux-rh7.1 ion ion ion ion ion +i386-pc-linux-rh7.2 ion ion ion ion ion +i386-pc-linux-rh7.3 ion ion ion ion ion +i386-pc-linux-rh8.0 ezk ezk ezk ezk - +i386-pc-linux-rh9 ion ion ion ion ion +i386-pc-linux-rhel3 ezk ezk ezk ezk - +i386-pc-linux-rhel4 ezk ezk ezk ezk - +i386-pc-linux-suse8.2 ezk ezk ezk ezk - +i386-pc-linux-suse9.1 ezk ezk ezk ezk - +i386-pc-linux-suse9.2 ezk ezk ezk ezk - +i386-pc-linux-suse9.3 ezk ezk ezk ezk - +i386-pc-solaris2.10 ro ro ro - - +i386-pc-solaris2.9 ro ro ro - - +i386-unknown-freebsd4.10 ezk ezk ezk ezk - +i386-unknown-freebsd4.11 ezk ezk ezk ezk - +i386-unknown-freebsd4.8 ezk ezk ezk ezk - +i386-unknown-freebsd4.9 ezk ezk ezk ezk - +i386-unknown-freebsd5.0 ezk ezk - ezk - +i386-unknown-freebsd5.1 ezk ezk ezk ezk - +i386-unknown-freebsd5.2 ezk ezk ezk ezk - +i386-unknown-freebsd5.2.1 ezk ezk ezk ezk - +i386-unknown-freebsd5.3 ezk ezk ezk ezk - +i386-unknown-freebsd5.4 ezk ezk ezk ezk - +i386-unknown-freebsd6 (BETA5) ezk ezk ezk ezk - +i386-unknown-netbsd1.6A ezk ezk ezk ezk - +i386-unknown-netbsdelf1.6.1 ezk ezk ezk ezk - +i386-unknown-netbsdelf1.6.2 ezk ezk ezk ezk - +i386-unknown-netbsdelf2.0 ezk ezk ezk ezk - +i386-unknown-netbsdelf2.0.2 ezk ezk ezk ezk - +i386-unknown-netbsdelf3.0 ezk ezk ezk ezk - +i386-unknown-openbsd3.3 ezk ezk ezk ezk - +i386-unknown-openbsd3.6 ezk ezk ezk ezk - +i386-unknown-openbsd3.7 ezk ezk ezk ezk - +i686-apple-darwin6.6 ezk ezk ezk ezk - +ia64-hp-hpux11.20 ezk ezk ezk ezk - +ia64-unknown-linux-rh2.1AS ezk ezk - ezk - +ia64-unknown-linux-rh2.1AW ezk ezk ezk ezk - +ia64-unknown-linux-rhel4 ezk ezk ezk ezk - +mips-sgi-irix6.2 ro ro ro - -[3] +mips-sgi-irix6.5 ro ro ro - -[3] +mips-unknown-linux-gentoo1.4.16 ezk ezk ezk ezk - +mipsel-unknown-linux-rhPS2 ezk ezk ezk ezk - +powerpc-apple-darwin7.6.0 ezk ezk ezk ezk - +powerpc-apple-darwin7.7.0 ezk ezk ezk ezk - +powerpc-apple-darwin7.8.0 ezk ezk ezk ezk - +powerpc-apple-darwin7.9.0 ezk ezk ezk ezk - +powerpc-apple-darwin8.2.0 ezk ezk ezk ezk - +powerpc-ibm-aix5.1.0.0 ion ion ion ion[X] ion[1,2] +powerpc-ibm-aix5.2.0.0 ezk ezk ezk ezk - +powerpc-ibm-aix5.3.0.0 ezk ezk ezk ezk - +powerpc-unknown-linux-yellowdog2.3 ezk ezk ezk ezk - +sparc-sun-solaris2.10 ro ro ro - - +sparc-sun-solaris2.5.1 ion ion ion ion ion[1] +sparc-sun-solaris2.6 ion ion ion ion ion +sparc-sun-solaris2.7 ion ion ion ion ion +sparc-sun-solaris2.8 ion ion ion ion ion +sparc-sun-solaris2.9 ro ro ro - - +sparc-unknown-linux-rh62 ion ion ion ion ion +sparc64-unknown-linux-aurora10 ion ion ion ion ion +sparc64-unknown-linux-deb3.0 ezk ezk ezk ezk - +sparc64-unknown-linux-gentoo1.4.16 ezk ezk ezk ezk - +sparc64-unknown-linux-rh62 ion ion ion ion ion +sparc64-unknown-linux-suse7.3 ezk ezk - ezk - +x86_64-unknown-linux-rh2.9.5AS ezk ezk ezk ezk - +x86_64-unknown-linux-rh3.0.0AS ion ion ion ion ion + EMAIL ID LEGEND: @@ -125,39 +103,22 @@ wpaul: Bill Paul <wpaul@ctr.columbia.edu> FOOTNOTES: -[0] These entries were tested with older 6.0 releases, but not with the - latest version. They probably still work, however. - -[1] If compiling with cc on Irix 6, then use - - CC="cc -32 -Wl,-woff,84" ./buildall - -to build (good) "old style" 32 bit code and suppress stupid linker warnings -about unused libraries. - -Also, to get NFS V3 working, you need these two patches from SGI: - - patch 1615: NFS over TCP - patch 2041: NFS roll-up patch - -and then add "-p tcp" to /etc/config/nfsd.options. - -[2] ... has gone missing ... - -[3] DU-4.0 may not use NFS (server-side) V3 by default. You may need to -adjust /etc/init.d/nfs, and change the nfsd startup line from to - - if /usr/sbin/nfsd $NUM_NFSD; then -to - if /usr/sbin/nfsd -t 8 -u 8 ; then - -[4] HPUX 9.X has a bad /bin/sh that runs out of fixed memory allocations. -If you use the configure script, you must run it as - - /bin/ksh ./configure - -Also, this system has a bad /bin/make that cannot handle VPATH well. You -cannot use --srcdir or the buildall script with it. I suggest you install -GNU make or configure locally with "/bin/ksh ./configure". - -Erez. +[1] Due to limitations in the Sun autofs v1 implementation, some amd features +cannot be properly supported. More precisely, trying to access a link mount +pointing to another amd entry will result in failure and/or deadlock. +Ordinary nfs and link mounts work well, however. + +[2] AIX autofs appears to be a variant of the Sun autofs v1 protocol, but +IBM don't provide any sort of documentation or even header files from it. +It is currently unsupported; we may add some experimental support for it at +some point, though it won't be pretty. Assistance from IBM-ers would be +highly appreciated, hint hint. + +[3] IRIX 6 autofs uses the Sun autofs v1 protocol, too. The header files +are part of the onc3_eoe.sw.autofs (IRIX 6.2) or nfs.sw.autofs (IRIX 6.5) +package, which may not be installed. The autofs code is known to compile, +but hasn't been run yet. SGI's autofsd uses a barely documented system +call, syssgi(SGI_AUTOFS_SYS, ...), which may be required to get working +autofs support. Additional help from SGI would be highly appreciated. + +Erez & Ion diff --git a/contrib/amd/NEWS b/contrib/amd/NEWS index 60d58a990508..5cde984ed518 100644 --- a/contrib/amd/NEWS +++ b/contrib/amd/NEWS @@ -1,147 +1,663 @@ -*** Notes specific to am-utils version 6.0.10-pre: +*** Notes specific to am-utils version 6.1.5 + +New amd.conf global parameter: nfs_allow_any_interface. By default it is +set to 'no' which means that Amd accepts local NFS packets only from +127.0.0.1. If set to 'yes' then Amd will accept local NFS packets from any +local interface; this is useful on hosts that may have multiple interfaces +where the system is forced to send all outgoing packets (even those bound to +the same host) via an address other than 127.0.0.1. + +Add support for specifying the host to match in the mount selectors netgrp +and netgrpd. Now one can use either netgrp(<group-name>) or +netgrp(<group-name>,<host-name>). + +- Bugs fixed: + * handle old-style filehandles correctly (for mount points longer + than 28 chars) + * don't turn off attribute cache for regular NFS mounts (improves + performance) + * detect G/DBM support via gdbm_compat library (Debian) + * detect NDBM support in libc (FreeBSD 6) - minor new ports: - ia64-unknown-linux-rh2.1AS (Red Hat Itanium Advanced Server) - i386-unknown-freebsd5.0 (5.0-RELEASE) - sparc64-unknown-linux-suse7.3 + i386-unknown-freebsd6.1 (RELEASE) + i386-unknown-openbsd3.9 + powerpc-apple-darwin8.6.0 + +*** Notes specific to am-utils version 6.1.4 + +Support new mount options for type:=pcfs mounts: longname, nowin95, +shortname, user=N, group=N, mask=N, and dirmask=N. + +Two new amd.conf [global] parameters: nfs_retry_interval_toplvl and +nfs_retransmit_counter_toplvl. They are similar to nfs_retry_interval and +nfs_retransmit_counter, and allow you to set the "timeo" and "retrans" NFS +mount parameters, respectively, but ONLY for Amd's top-level mounts (which +are NFSv2/UDP currently). This is useful because on some systems you may +wish to set these parameters differently than the OS default, so as to +better tune Amd's responsiveness under heavy scheduler loads. + +- minor new ports: + i386-pc-linux-fc5 (Fedora Core 5) + i386-pc-linux-suse10.1 (beta 8) + i386-unknown-freebsd6.0 (RELEASE) + i386-unknown-netbsdelf2.1 + i386-unknown-netbsdelf3.0 (RELEASE) + i386-unknown-openbsd3.8 + powerpc-apple-darwin8.5.0 + +- Bugs fixed: + * one serious memory leak in amfs_generic (caught by Coverity) + * assorted potential (but rare) NULL pointer dereferences (Coverity) + * correctly print nfs_args->addr info (sin_family/port/addr) + * pawd should resolve path repeatedly until no more to do + * use-after-free bug in amfs_lookup_mntfs (Coverity) + +*** Notes specific to am-utils version 6.1.3 + +- Bugs fixed: + * amq should de-register properly on exit + * convert all sprintf to safer xsnprintf + * convert all strcat to safer xstrlcat + * convert all strcpy to safer xstrlcpy + * fix three buffer overruns in expand_op (amd/opts.c) + * pawd was trying UDP only, now try TCP if UDP failed + +Moved pawd's path-matching functionality into Amd, where it can be done a +lot more efficiently (we no longer need to construct and send the whole +mounted tree, only to match small parts of it). This will lessen the CPU +and network load on systems that use pawd heavily, and also minimize the +chance that we exceed default or hard-coded UDP/TCP RPC packet sizes. + +*** Notes specific to am-utils version 6.1.2.1 + +- Bugs fixed: + * properly turn off the attrcache in freebsd and openbsd + * can turn off attrcache on netbsd, but need kernel patch, see + README.attrcache + * pawd goes into an infinite loop on type:=auto + * consistent search for file system mnttab/mount names + +*** Notes specific to am-utils version 6.1.2 + +MAJOR BUG FIXES: Synchronize Amd's view of its file systems with the +kernel's NFS client-side DNLC/dcache. Amd changes its view when it reloads +maps (automatically or via "amq -f") because new map entries could be added, +old one removed, or existing ones changed. Amd also changes its view when a +simple entry has expired and was flushed, or was forced out via "amq -u". +Amd was not updating the mtime of its parent directory (often the amd +automount point): this resulted in the kernel re-using cached entries, which +are now possibly stale. Many users had seen this problem in the form of +occasional ESTALE errors, or dangling/broken automounted symlinks, +especially on systems under heavy use. To tell the kernel to ignore (flush) +its old entries for an directory, the mtime of the directory must be updated +(monotonically incremented). Amd was indeed doing so in several places, but +unfortunately it was using time(2) which only provides a one-second +resolution clock: this was fine a decade ago, but not good enough on today's +fast systems; using only a one-second resolution clock meant that on busy +systems that invoke Amd many times a second, some rapidly changing entries +do not get flushed from the kernel, and the kernel thus uses stale entries. +The solution to all of these was to rework the whole clock timer updates to +use gettimeofday(), using a micro-second resolution timer, and to use that +time whenever Amd needs to update an mtime/atime/ctime of any node. +Finally, we now update the mtime in places that were never updated before +(when a whole map is flushed or a single entry times out). + +Warning: some OSs, we discovered, are incapable of turning off their +NFS attribute cache entirely. This means that Amd cannot work fully +reliability on these systems, not under heavy load. This is documented in +detail in the README.attrcache file included with this distribution. + +Include test-attrcache script to test the NFS attribute cache behavior using +Amd. + +Tell syslog not to log automatically to /dev/console; it's unfriendly. If +user really wants to, they can set it in /etc/syslog.conf. + +- minor new ports: + i386-pc-linux-deb3.1 + i386-unknown-netbsdelf3.0 + powerpc-apple-darwin8.2.0 + +- bugs fixed: + * minor documentation corrections + +*** Notes specific to am-utils version 6.1.1 + +New amd.conf global parameter: forced_unmounts (default to "no"). If set to +"yes," and the client OS supports forced or lazy unmounts, then Amd will +attempt to use them if it gets any of three serious error conditions when +trying to unmount an existing mount point or mount on top of one: EIO, +ESTALE, or EBUSY. This could be useful to recover from serious conditions +such as hardware failure of mounted disks, or NFS servers which are down +permanently, were migrated, or changed their IP address. Only +"type:=toplvl" mounts hung with EBUSY are forcibly unmounted using this +option: this is useful to ensure that a new Amd can mount itself even if a +previous Amd died and left its mount points hung, or to force Amd to +shutdown cleanly, even if some processes (i.e., user shells) have their CWD +on Amd's own mount point. This functionality is available for Linux, BSD44 +systems, Solaris, OSF/1, and partially for AIX. + +New amd.conf global parameter: truncate_log (default to "no"). If set to +"yes", then Amd will truncate the log file (if it's a regular file) on +startup. This could be useful when conducting extensive testing on Amd maps +(or Amd itself) and you don't want to see log data from a previous run in +the same file. + +- minor new ports: + i386-pc-linux-fc4 + i386-pc-linux-suse9.3 + i386-pc-linuxoldld-deb3.1 + +- bugs fixed: + * safer mtab handling for Linux (locks + handles /proc/mounts) + * small compile problems on Solaris 6 (rpcvers_t) + * small compile problems on HPUX 10 (h_errno) + * possibly missing definition of INADDR_NONE in wire.c + * extern for sleep(3) may be missing on older gcc systems + * updated nfs_args structure on aix4. + * possible running off end of exported_ap[] array. + * buffer overflow in pawd. + * aix4 clean build. + * use strlcat/snprintf in a few places for safety. + * recover from IP address change of a down NFS server + * don't discard restarted mntfs that was used. + +*** Notes specific to am-utils version 6.1 + +- bugs fixed: + * set timeo/retrans for type:=nfs only if user asked + +Also, if you want to know what's new in 6.1 compared to 6.0.x, it's +EVERYTHING below this line, up to "6.0.4." Yes, that's a lot of stuff. + +*** Notes specific to am-utils version 6.1-rc7 + +Remove alloca from am-utils, and rewrite code that used it. + +Assorted minor code cleanups. + +- minor new ports: + alpha-unknown-linux-gentoo1.4.16 + alphaev56-dec-osf4.0f (using both cc and gcc) + mips-sgi-irix6.5 (using both cc and gcc) + mips-unknown-linux-gentoo1.4.16 + sparc64-unknown-linux-gentoo1.4.16 + +- bugs fixed: + * getwire() detects networks correctly on OSF/1 + +*** Notes specific to am-utils version 6.1-rc6 + +- minor new ports: + i386-pc-linux-deb3.0 + i386-pc-linux-gentoo1.4.16 + i386-pc-linux-suse9.2 + i386-unknown-freebsd5.4 + i386-unknown-netbsdelf2.0.2 + i386-unknown-openbsd3.7 + powerpc-unknown-linux-yellowdog2.3 + +- bugs fixed: + * minor compile error of nfs_subr.c on some systems. + * AIX 5.2/5.3 PPC compile fixes. + +*** Notes specific to am-utils version 6.1-rc5 + +For NetBSD systems, $os used to say "netbsdelf1" or "netbsdelf2." Now it +just says "netbsd." + +- minor new ports: + powerpc-apple-darwin7.9.0 + +- bugs fixed: + * silly (but nasty) null pointer dereferencing + * improved fix for '-opts' syntax for resetting map options + +*** Notes specific to am-utils version 6.1-rc4 + +- bugs fixed: + * check for "macosx" in M4 macros properly + * minor memory leaks (thanks to Valgrind) + +*** Notes specific to am-utils version 6.1-rc3 + +Minor fix to configure.in. Reran bootstrap to get a working configure +script that indeed checks for certain Linux nfs/autofs headers. + +*** Notes specific to am-utils version 6.1-rc2 + +New amd.conf global parameter: normalize_slashes (default to "yes"). If set +to "no," then Amd will not condense repeated slashes or remove trailing ones +from strings representing pathnames. This is sometimes useful with SMB +mounts, which often require multiple slash characters in pathnames. + +Using a custom version of strlcpy instead of strncpy (but only where it +makes sense), to minimize string overflow changes. Audited all use of +strncpy/strlcpy to ensure safety. + +On Apple machines, use "powerpc" for $arch, instead of "Power Macintosh". +Also, use sw_vers to find out more appropriate OS name (macosx) and OS +version (10.3.x) than uname(3) reports. + +- minor new ports: + powerpc64-unknown-linux-rhel4 + powerpc64-unknown-linux-sles9 + +- bugs fixed: + * pawd handles all file systems + * fix double-free in type:=nfsx + * timeo and retrans shouldn't be set for type:=toplvl + * fix inconsistency in handling filehandle generation number + * document proper use of hosts.allow (don't spawn) + * single dash '-' map entry now resets the defaults + +*** Notes specific to am-utils version 6.1-rc1 + +- minor new ports: + i386-pc-linux-fc2 (Fedora Core 2). + i386-pc-linux-fc3 (Fedora Core 3). + i386-pc-linux-rhel3 + i386-pc-linux-rhel4 + i386-pc-linux-suse8.2 + i386-pc-linux-suse9.1 + i386-pc-solaris2.10 + i386-unknown-freebsd4.8 i386-unknown-freebsd4.9 + i386-unknown-freebsd4.10 + i386-unknown-freebsd4.11 + i386-unknown-freebsd5.1 (5.1-RELEASE) i386-unknown-freebsd5.2 (5.2-RELEASE) - -- new amd.conf directive "nfs_allow_insecure_port". Used to work around + i386-unknown-freebsd5.2.1 (5.2.1-RELEASE) + i386-unknown-freebsd5.3 (5.3-RELEASE) + i386-unknown-freebsd6.0 (6.0-CURRENT-SNAP001) + i386-unknown-netbsdelf1.6.1 + i386-unknown-netbsdelf2.0 + i386-unknown-openbsd3.6 + ia64-hp-hpux11.20 + ia64-unknown-linux-rhel4 + mipsel-unknown-linux-rhPS2 (Linux on Sony PlayStation 2) + powerpc-apple-darwin7.6.0 + powerpc-apple-darwin7.7.0 + powerpc-apple-darwin7.8.0 + powerpc-ibm-aix5.2.0.0 + powerpc-ibm-aix5.3.0.0 + sparc-sun-solaris2.10 + sparc64-unknown-linux-deb3.0 + x86_64-unknown-linux-rh2.9.5AS + +- support for executable maps ala Sun automounter. Set map_type=exec in + amd.conf, and map_name to a program/script that takes a key as argv[1], + and returns key-value pair on stdout. See also exec_map_timeout [global] + parameter which defines how many seconds (default 10 sec) Amd will wait + for an executable map program to return output before timing out. See + am-utils manual for full details. + +- new amd.conf parameter "nfs_allow_insecure_port". Used to work around bugs in certain kernels, which cause them to try and talk to amd from unprivileged ports. -- bug fixes: - rename log() in fsinfo to avoid glibc/gcc-3.3 conflict - am_pref free NULL pointer - compiles with modern bison/flex versions - handles sites with various combos of db, n/dbm, and gdbm +- new amd.conf parameter: localhost_address. Used to override the localhost + (often 127.0.0.1) address Amd uses to connect to for the local NFS server + and RPC server. + +- new amd.conf [global] parameter: domain_strip (default "yes"). If set to + "no," Amd won't strip domain names from host names, which is useful if + your Amd maps are served by multiple domains and you want to tell from the + logs which exact host did what. + +- new amd.conf [global] parameter: auto_attrcache (default to 0). Sets + Amd's own NFS attribute-cache timeout in seconds. A value of 0 turns off + attribute caching, meaning that Amd will be consulted via a kernel-RPC + each time someone stat's the mount point (which could be abused as a + denial-of-service attack). If you're concerned, set this to something + greater than zero (a value of 1 second is currently recommended). + Warning: if you set this option to any non-zero value, especially a large + value, and you get ESTALE errors on your particular OS, then set this + value back to 0 seconds. + +- four new amd.conf [global] parameters, similar to nfs_retry_interval and + nfs_retransmit_counter, which allow you to set the "timeo" and "retrans" + NFS mount parameters, respectively. Now you can set those parameters + globally and separately for UDP vs. TCP, using any of these: + nfs_retry_interval_udp, nfs_retransmit_counter_udp nfs_retry_interval_tcp, + and nfs_retransmit_counter_tcp. + +- new amd.conf [global] parameter: preferred_amq_port. Allows you to select + the UDP+TCP port that Amd's amq service will use with the RPC portmapper. + Useful with firewalls and NAT'ed environments. + +- new amd.conf option "debug_mtab_file". Allows user to define the mtab + file during debug-mtab mode. The default path is "/tmp/mnttab". + +- new function selector xhost(ARG) which will match ARG against the current + host name. This works even if ARG is a CNAME (unlike the host==ARG + selector). + +- support restarting the automounter's own mount points (only over NFS, + for now). + +- fully support WebNFS as per RFC 2054. It now tries v3/TCP first, falling + back to v2/UDP if this doesn't work. The "webnfs" pseudo-mount options + has been renamed (again) to "public" to match Solaris 2. + +- restructured the restarting of already-mounted filesystems, in the process + also fixing a problem with restarting nfsx components. + +- support escaped slashes, needed for SMB mounts. Use '\\\/\\\/' in a + string to get a double slash. + +- amd -v now prints domain, host, and hostd values: foo, example.com, and + foo.example.com, respectively. + +- On Linux, if umount(2) failed with EIO or ESTALE, try the new umount2(2) + system call with MNT_FORCE+MNT_DETACH. This could be quite helpful to + unmounting hung mount points that otherwise cannot be fixed without a + reboot. + +- The ping=N mount option now works. N defaults to 30 seconds for all NFS + servers. It can now be set to any value for each server separately. + Setting it to a large value can reduce the amount of NFS_NULL chatter on + your network considerably, especially in large sites. Setting this to -1 + will turn off pings for that server (useful in NFS-HA setups). Setting N + to 0 will pick the default ping value in Amd (currently 30 seconds). Note + that if you have multiple Amd entries using the same file server, and each + entry sets a different value of N, then each time Amd mounts a new entry, + the ping value will be re-evaluated (and updated, turned off, or turned + back on as needed). Note that NFS_NULL pings are sent for both UDP and + TCP mounts, because even a hung TCP mount can cause user processes to + hang. + +- file system inheritance code restructured, so it's no longer a pseudo file + system, but actually integrated into Amd (as it should have been). + +- for type:=program, the "umount" program doesn't have to be defined; it'll + default to "unmount ${fs}". + +- "amd -v" now prints the distribution name if it's known (e.g., rh9, fc3, + suse8, etc.). -*** Notes specific to am-utils version 6.0.9: +- bugs fixed: + * various memory management problems (leaks, etc) + * fixed nfsx support + * fixed a race involving late replies to network queries which + arrive after the file system has already been mounted + * recognize pcfs_args_t fields in FreeBSD 5 + * recognize other mount types in pawd: host, linkx, and nfsx + * allow exactly one of umount and unmount in type:=program + * race condition between calls to mntctl() on AIX + * plock/mlockall wasn't inherited by fork(); moved after + daemonizing. + * fix inconsistency between Socket and TLI RPC timeouts. + * don't warn when couldn't rmdir a dir with a readonly ancestor. + * avoid hangs of amd in ctl-amd (must chdir to /) + * workaround occasional daemonizing problems (parent won't die) + * don't hang on exit if debug_options=mtab was used + * utimeout=N mount option works with non-nfs types (ufs, pcfs, etc.) + * SEGV (null pointer deref) in type:=program and type:=cachefs + * unmount_on_exit of type:=program caused amd to hang + * match amd2ldif output with ldap.schema + +*** Notes specific to am-utils version 6.1b4 + +- minor new ports: + i686-apple-darwin6.6 + +- speed up the recovery of inherited (restarted) filesystems by using the + proper waiting channels + +- added support for mounting webnfs filesystems, see entry below. It doesn't + do any probing currently, so it will default to v2/UDP unless another + version and/or protocol are explicitly specified. + +- pseudo-mount option "ignore_portmapper" renamed to "webnfs" + +- bugs fixed: + * properly time out autofs filesystems on Linux + * link mounts with relative targets weren't working on autofs + * the link side of the nfsl file system wasn't working on autofs + * umount code was accidentally turning all symlinks into directories + during attempted umounts, causing stale filehandles + * various minor build fixes for "impossible" configurations + * prevent ldap code from dereferencing a null pointer + +*** Notes specific to am-utils version 6.1b3 + +- new amd.conf option autofs_use_lofs, set by default to "yes". "yes" means + using in-place mounts (lofs, bind mounts, etc.), thus utilizing one of + Autofs's main advantages. "no" means using symlinks instead, which has + the "/bin/pwd" problem and certain efficiency issues on Solaris 2.6+ and + is also not supported on Solaris Autofs v1 and derivatives; however, the + autofs code that uses symlinks is simpler and more thoroughly tested. + +- new amd.conf option map_default (can be used in [global] and overwritten + in the per-map section). This will overwrite the /defaults entry of the + map itself, to allow people to set defaults in amd.conf (useful when you + cannot control your amd maps, or you'd rather not modify them globally). + +- for type:=program, you can use either unmount:=XXX or umount:=XXX (but not + both). This new 'unmount' name is an alias for convenience. + +- fixed the "multiple matching sub-entries in a map entry" semantics to try + mounting those sub-entries one by one, until either one succeeds or all + fail. The old semantics of trying to mount everything in parallel and use + the one that mounted fastest hasn't worked in a long time; in fact, 6.0 + currently simply ignores all but the first matching sub-entry. + +- made amd fail much faster (instantly, in fact) if the remote server + doesn't have a functional portmapper or NFS service. Also reduced the + total timeout to 3 seconds for a completely downed server. + +- new pseudo-mount option "ignore_portmapper"; not very useful currently, + will make more sense when we also accept hard-coded ports for mountd and + nfsd. + +- amd will no longer query the portmapper for all possible NFS versions and + protocols if the user requested to use specific ones. + +- increased the major number for the library, so that 6.0 and 6.1 can't + share libraries anymore. + +- support tcpd/libwrap tcpwrappers. If your system supports libwrap, then + you can use /etc/hosts.allow and /etc/hosts.deny to control remote Amq + access to Amd. The new amd.conf parameter use_tcpwrappers is set to "yes" + by default. + +- support NULL entries in Hesiod maps, if they start with a ".". + +- code reorganization + +- documentation cleanup, corrections, and general updates. Better + references to all man pages. Support newer texi2html. Proper building of + DVI and PSI files. Allow building of am-utils manual in one long Web + page. + +- minor new ports: + + ia64-unknown-linux-rh2.1AS (Red Hat Itanium Advanced Server) + i386-unknown-freebsd5.0 (5.0-RELEASE) + sparc64-unknown-linux-suse7.3 + i386-unknown-netbsdelf1.6.1 + i386-unknown-openbsd3.3 + i386-pc-solaris2.9 + +- bugs fixed: + + * autofs mode on Linux was segfaulting on a silly error (and noone + complained, which proves that I'm probably the only one testing + these beta releases, tsk tsk). + * fixed handling of host entries over autofs. + * fixed handling of nfsl entries over autofs. + * the matching in find_mntfs() was causing problems for inherited + filesystems, so make an exception for them. Tighten the + matching even more, to take into account the f/s type as well. + * recognize xlatecookie mnttab option on netbsd + * document Solaris lex bug (use flex) + * document AIX 5.x NFS bug (need patch) + * document Solaris 8 autofs version change (need to fix system + header file) + * ensure lex doesn't run out of output slots + * support GNU flex-2.5.31+ + * force version.texi to be rebuilt unconditionally + * mk-amd-map open db file exclusively (security) + * turn off maintainer-only rules in distros + * don't core dump if log_file is NULL (Solaris) + * don't include malloc.h if stdlib.h exists + * recognize file system failures (EIO) upon reading file maps + +*** Notes specific to am-utils version 6.1b2 + +- new mount flag "softlookup", which determines how amd will respond to + lookups of NFS shares already mounted (return a valid symlink or return + EIO). The default, if "softlookup" is not specified, depends on whether the + mount is "soft" or "hard". + +- return EIO instead of ENOENT if amd thinks the server is down; this allows + well-written applications to sleep and retry the operation. + +- minor new ports: -- Minor new ports: i386-apple-darwin6.0 + i386-pc-linux-rh8.0 + ia64-unknown-linux-rh2.1AW sparc-sun-solaris2.9 +- automatic support for loop mounts on Linux (deprecates the "loop" mount + option) + +- new amd.conf parameter ldap_proto_version (default 2) for setting the LDAP + protocol version to use. + - bugs fixed: + * redundancy mode (multiple servers for the same share) wasn't working + * non-autofs mode had some rather nasty hangs on downed file servers + * double-free'ing problem in assign_error_mntfs and free_continuation + * free'ing non-malloc'ed memory in amfs_auto_mount + * late server ping replies were not ignored + * amfs_auto_lookup_mntfs wasn't propagating errors up to callers + * autofs-v4 on Solaris 9 works * handle std{in,out,err} correctly when releasing controlling tty (for real this time) * don't cast pointers between enum_t and u_long, it doesn't work on 64-bit big-endian platforms + * fix compile problem with mlockall() on Darwin -*** Notes specific to am-utils version 6.0.8: +*** Notes specific to am-utils version 6.1b1 + +- Major Autofs work + Partial support for Sun Autofs v1 + Documented known problems with Sun Autofs v1 (possible deadlocks) + Fixes for Sun Autofs v2/v3 + Preliminary support for Sun Autofs v4 (Solaris 9) + Kernel-based expirations for Linux Autofs - Minor new ports: - i386-pc-linux-rh7.2 - i386-pc-linux-rh7.3 - i386-unknown-freebsd4.4 - i386-unknown-freebsd5.0 - ia64-hp-hpux11.20 - ia64-unknown-linux-rh7.1 powerpc-ibm-aix5.1.0.0 + i386-unknown-netbsd1.6A - Work around IBM's NFSv3 ABI change in aix4.3 -- Support network/netmask and network/masklen syntax in in_network() +- trivial regression test suite started: run "make check" on a built + am-utils to execute tests. Currently only one test which checks to see if + "amd -v" executes correctly. + +- new command line option "amd -A arch" to overwrite the value of $arch. + +- bugs fixed: + + * Linux loop mounts of ISO images + * assorted LDAP fixes + * strerror not found on some systems + * small fixes for hpux9 and aix43 + * exclude ldap/hesiod support unless both libraries+headers exist + * fully support "xlatecookie" mount option + * security: if -D noamq option, don't listen on socket. + +*** Notes specific to am-utils version 6.1a5: -- Support disabling LDAP and Hesiod support using configure +- browsable_dirs support for Solaris autofs, *without* mount storms! -- Support xfs on Linux +- new amd.conf global parameter: map_reload_interval (default 1 hour). + Determines how often Amd checks to see if maps have changed at the source + (and then reloading only those that have changed). -- Red Hat specific Amd startup script included +- "amd -v" now lists bug-reporting address. -- Remove (non-functional) autofs code and detection support. If you want - autofs support, use am-utils-6.1. +- assorted code cleanups and porting to use latest versions of GNU + Autotools. + +- opts:=loop works for type:=cdfs, for mounting ISO-9660 files on Linux. - bugs fixed: + * fixed sublink support in Linux autofs (broken in a4) * hlfsd takes uid 0's home from root's passwd entry instead of defaulting to '/' * (not really our bug) Linux ignores the microseconds field in mtime, so hlfsd and amd need to increment the seconds field all the time to prevent symlink caching - * generic map parsing bug which was rejecting a numerical mount option - if it was the last option in the string - * MacOS X compile bug - * minor fix for GNU getopt - * Linux has no "dev" mtab option - * "nolock" is an NFS mount option, not a generic one - * Irix N32 ABI fixes with cc - * security: use mkstemp instead of mktemp - * correct timeo values for Linux tcp/udp NFS mounts - * hlfsd use of setuid() not seteuid() - * AIX ABI changes to nfs_args fixes - -*** Notes specific to am-utils version 6.0.7: - -- minor new ports: i386-unknown-freebsd5.0 + * generic map parsing bug which was rejecting a numerical mount + option if it was the last option in the string. + * file descriptor leak in Linux autofs. + * "nolock" is an NFS mount option, not a generic one. + * use mlockall(2) on systems that have it, for plock=yes. Now + pinning Amd's pages in memory works on Linux. + * ctl-amd/ctl-hlfsd correctly refer to @sysconfdir@ for alternate + location of configuration files. -- bug fixes: - type:=host, don't fail mount if one share is already mounted - don't report NFS NE_IO error as success (Linux) +*** Notes specific to am-utils version 6.1a4: -*** Notes specific to am-utils version 6.0.6: +- full autofs support for Solaris 2.[67], including symlinks, sublinks and + direct mounts -- new ports: - Mac OS X support (Darwin, Rhapsody) +- fixed mount/umount deadlock in Linux autofs -- reworked autoconf scripts so that newer versions of known OSs will default - their configuration to the last known version (better chance that it will - pass autoconf and work). +- fixed sublinks in Linux autofs -- linux support for lofs and "bind" mounts, so type:=lofs can work (whether - you're using autofs or not) +- support for network/netmask pairs in the in_network() selector -- renamed amd.conf option "selectors_on_default" to "selectors_in_defaults" - (on -> in, and added "s"). Old name remains in place for compatibility. +- support disabling LDAP and Hesiod support using configure -- lots of cleanups of debugging and logging messages +- forward-ported all the fixes from the stable branch (MacOS X support, + minor Linux fixes) -- Bugs fixed: - lots of Linux-related ones, so it compiles for recent kernels - better checking on various mount options of the form foo=N or foo=STR - fixed NFS errno mapping bug which mapped ENOENT to success on Linux +- bind-mount support for type==link and type==lofs with Linux 2.4+ + +- FiST lofs support under Linux (also in 6.0.6s2) + +*** Notes specific to am-utils version 6.1a3: + +- various things from the 6.0 branch: + compile fixes for Linux 2.4-ac and 2.2.19pre+ + Darwin/Rhapsody/OS X support + much reduced configure script (works around a bug in Darwin's cpp) -*** Notes specific to am-utils version 6.0.5: +*** Notes specific to am-utils version 6.1a2: -- Minor ports: - alphaev6-dec-osf5.1 - i386-unknown-freebsd4.2 - support for Linux 2.4 kernels and newer GLIBC versions - cleanup of AIX and IRIX6 ports +- working autofs support for Solaris 2.[67], but incomplete -- Support new mount options: - proplist (ACLs over NFS, DU-4.0) - kerb, rdirplus, readdirsize, and xlatecookie (NetBSD-1.5K+) - nonlm, lock, nolock (Linux) +- forward-ported all the changes up to 6.0.5s2 -- Don't force rsize/wsize on Linux 2.2.18+ and 2.4.x. Improves performance - a lot. +- removed support for amq -M -- Lots of documentation updates: texinfo, man pages, scripts, and more. +- known bugs + nfsx support is broken + linux NFS codes fixes + NFS cache aliasing fixes + lots of stuff ported from 6.0 branch -- LDAP: included proposed Schema and Internet Draft for LDAP Schema. See - README.ldap for more information. +*** Notes specific to am-utils version 6.1a1: -- Removed all remains of the dangerous amq -M code. +- working autofs (v3 and v4) support for Linux! -- Major bug fix: initialize NFS fileid field correctly, to avoid cache - aliasing problems, esp. on Linux. +- forward-ported all the changes in 6.0.4s4 -- Major Linux bug fix: map errnos to NFS errors (mistakenly turned off a - while back). Also support unused errno 41. +- bugs fixed + client-side fail-over to NFSv2/UDP -- Other bugs fixes: - default MAXHOSTNAMELEN (if undefined) is 256, not 64 - truncate hostnames to MAXHOSTNAMELEN (security fix) - alignment problem in getwire() on ALPHA - other buf overflow problems (security fixes) - ctl-amd supports "condrestart" (Red Hat) - bell char is \g not \a - lostaltmail verify MAILDIR is defined - am-eject accepts "floppy" and "cdrom" as args - other assorted small bug fixes +- known bugs + autofs v3 will probably break with host maps *** Notes specific to am-utils version 6.0.4: @@ -514,7 +1030,7 @@ the functions compute_nfs_args() and compute_automounter_nfs_args(). - bugs fixed: mnttab name ufs/cdfs/pcfs/etc filesystems corrected use pmap_ping for amq (a must for secure portmappers, bsdi2/3) - test for xfs (irix) as a disk-based filesystem + test for xfs (irix) as a disk-based file system set correct nfs_prot headers for Solaris 2.5 removed stale code from lostaltmail.in lostaltmail will look for conf file in multiple locations @@ -931,11 +1447,11 @@ used anywhere were removed. --enable-libs[=ARG] configure/compile with ARG (-L/-l) library flags -- filesystem, mount table entries, and mount type tests can now look in +- file system, mount table entries, and mount type tests can now look in /lib/modules and /proc/filesystems for statically/dyadically loadable kernel modules (linux) -- prefer vfat over msdos/pc/etc filesystem for PCFS. +- prefer vfat over msdos/pc/etc file system for PCFS. - moved all fixed headers to include/am_defs. Left only #define/#undef entries in aux/acconfig.h. diff --git a/contrib/amd/README.attrcache b/contrib/amd/README.attrcache new file mode 100644 index 000000000000..e8522d226ebe --- /dev/null +++ b/contrib/amd/README.attrcache @@ -0,0 +1,129 @@ + NFS Attribute Caching OS Problems and Amd + Last updated September 18, 2005 + +* Summary: + +Some OSs don't seem to have a way to turn off the NFS attribute cache, which +breaks the Amd automounter so badly that it is not recommend using Amd on +such OS for heavy use, not until this is fixed. + + +* Details: + +Amd is a user-level NFSv2 server that manages automounts of all other file +systems. The kernel contacts Amd via RPCs, and Amd in turn performs the +actual mounts, and then responds back to the kernel's RPCs. Every kernel +caches attributes of files, in a cache called the Directory Name Lookup +Cache (DNLC), or a Directory Cache (dcache). + +Amd manages its namespace in the user level, but the kernel caches names +itself. So the two must coordinate to ensure that both namespaces are in +sync. If the kernel uses a cached entry from the DNLC, without consulting +Amd, users may see corruption of the automounter namespace (symlinks +pointing to the wrong places, ESTALE errors, and more). For example, +suppose Amd timed out an entry and removed the entry from Amd's namespace. +Amd has to tell the kernel to purge its corresponding DNLC entry too. The +way Amd often does that is by incrementing the last modification time +(mtime) of the parent directory. This is the most common method for kernels +to check if their DNLC entries are stale: if the parent directory mtime is +newer, the kernel will discard all cached entries for that directory, and +will re-issue lookup methods. Those lookups will result in +NFS_GETATTR/NFS_LOOKUP calls sent from the kernel down to Amd, and Amd can +then properly inform the kernel of the new state of automounted entries. + +In order to ensure that Amd is "in charge" of its namespace without +interference from the kernel, Amd will try to turn off the NFS attribute +cache. It does so by using the NFSMNT_NOAC flag, if it exists, or by +setting various "cache timeout" fields in struct nfs_args to 0 (acregmin, +acregmax, acdirmin, or acdirmax). + +We have released a major new version of am-utils, version 6.1, in June 2005. +Since then, a lot of people have experimented with Amd, in anticipation of +migrating from the very old am-utils 6.0 to the new 6.1. For a couple of +months since the release of 6.1, we have received reports of problems with +Amd, especially under heavy use. Users reported getting ESTALE errors from +time to time, or seeing automounted entries whose symlinks don't point to +where it should be. After much debugging, we traced it to a few places in +Amd where it wasn't updating the parent directory mtime as it should have; +in some places where Amd was indeed updating the mtime, it was using a +resolution of only 1 second, which was not fine enough under heavy load. We +fixed this problem and switched to using a microsecond resolution mtime. + +After fixing this in Amd, we went on to verify that things work for other +OSs. When we got to test certain BSDs, we found out that they always cache +directory entries, and there is no way to turn it off completely. +Specifically, if we set the ac{reg,dir}{min,max} fields in struct nfs_args +all to zero, the kernel seems to cache the entries for a default number of +seconds (something like 5-30 seconds). On some OSs, setting these four +fields to 0 turns off the attribute cache, but not on some BSDs. We were +able to verify this using Amd and a script that exercises the interaction of +the kernel's attrcache and Amd. (If you're interested, the script can be +made available.) + +We then experimented by setting the ac{reg,dir}{min,max} fields in struct +nfs_args all to 1, the smallest non-zero value we could. When we ran the +Amd exercising script, we found that the value of 1 reduced the race between +the DNLC and Amd, and the script took a little longer to run before it +detected an incoherency. That makes sense: the smaller the DNLC cache +interval is, the shorter the window of vulnerability is. (BTW, the man +pages on some OSs say that the ac{reg,dir}{min,max} fields use a 1 second +resolution, but experimentation indicated it was in 0.1 second units.) + +Clearly, setting the ac{reg,dir}{min,max} fields to 0 is worse than setting +it to 1 on those OSs that don't have a way to turn off the attribute cache. +So the current workaround I've implemented in am-utils is to create a +configuration parameter called "broken_attrcache" which, if turned on, will +set these nfs_args fields to 1 instead of 0. I wish I didn't have to create +such ugly workaround features in Amd, but I've got no choice. + +The near term solution is for every OS to support a true 'noac' flag, which +can be added fairly easily. This'd make Amd work reliably. + +The long term solution is to implement Autofs support for all OSs and to +support it in Amd. Currently, Amd supports autofs on Solaris and Linux; +FreeBSD is next. Still, we found that even with autofs support, many +sysadmins still prefer to use the good 'ol non-autofs mode. + + +* Confirmed Status + +This is the confirmed status of various OSs' vulnerability to this attribute +cache bug. We are slowly checking the status of other OSs. The status of +any OS not listed is unknown as of the date at the top of this file. + +** Not Vulnerable (support a proper "noac" flag): + +Sun Solaris 8 and 9 (10 probably works fine) +Linux: 2.6.11 kernel (2.4.latest probably works fine) +FreeBSD 5.4 and 6.0-SNAP001 (older versions probably work fine) +OpenBSD 3.7 (older versions probably work fine) + +** Vulnerable (don't support a proper "noac" flag natively): + +NetBSD 2.0.2 (older versions are also probably affected) + +Note: NetBSD has promised to support a noac flag hopefully after 2.1.0 is +released (maybe in 3.0 or 2.2). In the mean time, you can apply one of +these two kernel patchs to support a 'noac' flag in NetBSD 2.x or 3.x: + ftp://ftp.netbsd.org/pub/NetBSD/misc/christos/2x.nfs.noac.diff + ftp://ftp.netbsd.org/pub/NetBSD/misc/christos/3x.nfs.noac.diff +After applying this patch and rebuilding your kernel, reboot with the new +kernel. Then copy the new nfs.h and nfsmount.h from /sys/nfs/ to +/usr/include/nfs/, and finally rebuild am-utils from scratch. + +** Testing + +When you build am-utils, a script named scripts/test-attrcache is built, +which can be used to test the NFS attribute cache behavior of the current +OS. You can run this script as root as follows: + +# make install +# cd scripts +# sh test-attrcache + +If you run this script on an OS whose status is known (and not listed +above), please report it to am-utils@am-utils.org, so we can record it in +this file. + +Sincerely, +Erez. diff --git a/contrib/amd/README.ldap b/contrib/amd/README.ldap index 9280639efc51..715113442552 100644 --- a/contrib/amd/README.ldap +++ b/contrib/amd/README.ldap @@ -2,14 +2,17 @@ LDAP support for am-utils was originally done by Leif Johansson <leifj@it.su.se>. He no longer maintains it. The current LDAP support for am-utils is for LDAPv2 only. Reportedly, -small changes are needed to support LDAPv3. Volunteers and patches are -welcome. +LDAPv3 mostly works. Volunteers and patches are welcome. The IANA has assigned the following Private Enterprise Number to: 10180 Am-utils Organization Erez Zadok ezk@am-utils.org -There are two files in this directory that relate to LDAP: +There are three files in this directory that relate to LDAP: + +ldap.schema: + + This is the most current schema. ldap-id.txt: diff --git a/contrib/amd/amd/am_ops.c b/contrib/amd/amd/am_ops.c index 3097aee67703..5a5c33650eca 100644 --- a/contrib/amd/amd/am_ops.c +++ b/contrib/amd/amd/am_ops.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: am_ops.c,v 1.6.2.7 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/am_ops.c * */ @@ -87,9 +86,6 @@ static am_ops *vops[] = #ifdef HAVE_AMU_FS_UNION &amfs_union_ops, /* union F/S */ #endif /* HAVE_AMU_FS_UNION */ -#ifdef HAVE_AMU_FS_INHERIT - &amfs_inherit_ops, /* inheritance F/S */ -#endif /* HAVE_AMU_FS_INHERIT */ /* * A few more native filesystems. @@ -126,7 +122,7 @@ static am_ops *vops[] = #endif /* HAVE_FS_UMAPFS */ /* - * These 5 should be last, in the order: + * These 4 should be last, in the order: * (1) amfs_auto * (2) amfs_direct * (3) amfs_toplvl @@ -149,107 +145,111 @@ static am_ops *vops[] = void -ops_showamfstypes(char *buf) +ops_showamfstypes(char *buf, size_t l) { struct am_ops **ap; - int l = 0; + int linesize = 0; buf[0] = '\0'; for (ap = vops; *ap; ap++) { - strcat(buf, (*ap)->fs_type); + xstrlcat(buf, (*ap)->fs_type, l); if (ap[1]) - strcat(buf, ", "); - l += strlen((*ap)->fs_type) + 2; - if (l > 62) { - l = 0; - strcat(buf, "\n "); + xstrlcat(buf, ", ", l); + linesize += strlen((*ap)->fs_type) + 2; + if (linesize > 62) { + linesize = 0; + xstrlcat(buf, "\n ", l); } } } static void -ops_show1(char *buf, int *lp, const char *name) +ops_show1(char *buf, size_t l, int *linesizep, const char *name) { - strcat(buf, name); - strcat(buf, ", "); - *lp += strlen(name) + 2; - if (*lp > 60) { - strcat(buf, "\t\n"); - *lp = 0; + xstrlcat(buf, name, l); + xstrlcat(buf, ", ", l); + *linesizep += strlen(name) + 2; + if (*linesizep > 60) { + xstrlcat(buf, "\t\n", l); + *linesizep = 0; } } void -ops_showfstypes(char *buf) +ops_showfstypes(char *buf, size_t l) { - int l = 0; + int linesize = 0; buf[0] = '\0'; +#ifdef MNTTAB_TYPE_AUTOFS + ops_show1(buf, l, &linesize, MNTTAB_TYPE_AUTOFS); +#endif /* MNTTAB_TYPE_AUTOFS */ + #ifdef MNTTAB_TYPE_CACHEFS - ops_show1(buf, &l, MNTTAB_TYPE_CACHEFS); + ops_show1(buf, l, &linesize, MNTTAB_TYPE_CACHEFS); #endif /* MNTTAB_TYPE_CACHEFS */ #ifdef MNTTAB_TYPE_CDFS - ops_show1(buf, &l, MNTTAB_TYPE_CDFS); + ops_show1(buf, l, &linesize, MNTTAB_TYPE_CDFS); #endif /* MNTTAB_TYPE_CDFS */ #ifdef MNTTAB_TYPE_CFS - ops_show1(buf, &l, MNTTAB_TYPE_CFS); + ops_show1(buf, l, &linesize, MNTTAB_TYPE_CFS); #endif /* MNTTAB_TYPE_CFS */ #ifdef MNTTAB_TYPE_LOFS - ops_show1(buf, &l, MNTTAB_TYPE_LOFS); + ops_show1(buf, l, &linesize, MNTTAB_TYPE_LOFS); #endif /* MNTTAB_TYPE_LOFS */ #ifdef MNTTAB_TYPE_EFS - ops_show1(buf, &l, MNTTAB_TYPE_EFS); + ops_show1(buf, l, &linesize, MNTTAB_TYPE_EFS); #endif /* MNTTAB_TYPE_EFS */ #ifdef MNTTAB_TYPE_MFS - ops_show1(buf, &l, MNTTAB_TYPE_MFS); + ops_show1(buf, l, &linesize, MNTTAB_TYPE_MFS); #endif /* MNTTAB_TYPE_MFS */ #ifdef MNTTAB_TYPE_NFS - ops_show1(buf, &l, MNTTAB_TYPE_NFS); + ops_show1(buf, l, &linesize, MNTTAB_TYPE_NFS); #endif /* MNTTAB_TYPE_NFS */ #ifdef MNTTAB_TYPE_NFS3 - ops_show1(buf, &l, "nfs3"); /* always hard-code as nfs3 */ + ops_show1(buf, l, &linesize, "nfs3"); /* always hard-code as nfs3 */ #endif /* MNTTAB_TYPE_NFS3 */ #ifdef MNTTAB_TYPE_NULLFS - ops_show1(buf, &l, MNTTAB_TYPE_NULLFS); + ops_show1(buf, l, &linesize, MNTTAB_TYPE_NULLFS); #endif /* MNTTAB_TYPE_NULLFS */ #ifdef MNTTAB_TYPE_PCFS - ops_show1(buf, &l, MNTTAB_TYPE_PCFS); + ops_show1(buf, l, &linesize, MNTTAB_TYPE_PCFS); #endif /* MNTTAB_TYPE_PCFS */ #ifdef MNTTAB_TYPE_TFS - ops_show1(buf, &l, MNTTAB_TYPE_TFS); + ops_show1(buf, l, &linesize, MNTTAB_TYPE_TFS); #endif /* MNTTAB_TYPE_TFS */ #ifdef MNTTAB_TYPE_TMPFS - ops_show1(buf, &l, MNTTAB_TYPE_TMPFS); + ops_show1(buf, l, &linesize, MNTTAB_TYPE_TMPFS); #endif /* MNTTAB_TYPE_TMPFS */ #ifdef MNTTAB_TYPE_UFS - ops_show1(buf, &l, MNTTAB_TYPE_UFS); + ops_show1(buf, l, &linesize, MNTTAB_TYPE_UFS); #endif /* MNTTAB_TYPE_UFS */ #ifdef MNTTAB_TYPE_UMAPFS - ops_show1(buf, &l, MNTTAB_TYPE_UMAPFS); + ops_show1(buf, l, &linesize, MNTTAB_TYPE_UMAPFS); #endif /* MNTTAB_TYPE_UMAPFS */ #ifdef MNTTAB_TYPE_UNIONFS - ops_show1(buf, &l, MNTTAB_TYPE_UNIONFS); + ops_show1(buf, l, &linesize, MNTTAB_TYPE_UNIONFS); #endif /* MNTTAB_TYPE_UNIONFS */ #ifdef MNTTAB_TYPE_XFS - ops_show1(buf, &l, MNTTAB_TYPE_XFS); + ops_show1(buf, l, &linesize, MNTTAB_TYPE_XFS); #endif /* MNTTAB_TYPE_XFS */ /* terminate with a period, newline, and NULL */ @@ -257,7 +257,7 @@ ops_showfstypes(char *buf) buf[strlen(buf) - 4] = '\0'; else buf[strlen(buf) - 2] = '\0'; - strcat(buf, ".\n"); + xstrlcat(buf, ".\n", l); } @@ -289,11 +289,11 @@ reverse_option(const char *opt) /* check if string starts with 'no' and chop it */ if (NSTREQ(opt, "no", 2)) { - strcpy(buf, &opt[2]); + xstrlcpy(buf, &opt[2], sizeof(buf)); } else { /* finally return a string prepended with 'no' */ - strcpy(buf, "no"); - strcat(buf, opt); + xstrlcpy(buf, "no", sizeof(buf)); + xstrlcat(buf, opt, sizeof(buf)); } return buf; } @@ -315,7 +315,7 @@ merge_opts(const char *opts1, const char *opts2) char *eq; /* pointer to whatever follows '=' within temp */ char oneopt[80]; /* one option w/o value if any */ char *revoneopt; /* reverse of oneopt */ - int len = strlen(opts1) + strlen(opts2) + 2; /* space for "," and NULL */ + size_t len = strlen(opts1) + strlen(opts2) + 2; /* space for "," and NULL */ char *s1 = strdup(opts1); /* copy of opts1 to munge */ /* initialization */ @@ -327,31 +327,30 @@ merge_opts(const char *opts1, const char *opts2) tmpstr; tmpstr = strtok(NULL, ",")) { /* copy option to temp buffer */ - strncpy(oneopt, tmpstr, 80); - oneopt[79] = '\0'; + xstrlcpy(oneopt, tmpstr, 80); /* if option has a value such as rsize=1024, chop the value part */ if ((eq = haseq(oneopt))) *eq = '\0'; /* find reverse option of oneopt */ revoneopt = reverse_option(oneopt); /* if option orits reverse exist in opts2, ignore it */ - if (hasmntopt(&mnt2, oneopt) || hasmntopt(&mnt2, revoneopt)) + if (amu_hasmntopt(&mnt2, oneopt) || amu_hasmntopt(&mnt2, revoneopt)) continue; /* add option to returned string */ - if (newstr && newstr[0]) { - strcat(newstr, ","); - strcat(newstr, tmpstr); + if (newstr[0]) { + xstrlcat(newstr, ",", len); + xstrlcat(newstr, tmpstr, len); } else { - strcpy(newstr, tmpstr); + xstrlcpy(newstr, tmpstr, len); } } /* finally, append opts2 itself */ - if (newstr && newstr[0]) { - strcat(newstr, ","); - strcat(newstr, opts2); + if (newstr[0]) { + xstrlcat(newstr, ",", len); + xstrlcat(newstr, opts2, len); } else { - strcpy(newstr, opts2); + xstrlcpy(newstr, opts2, len); } XFREE(s1); @@ -360,10 +359,22 @@ merge_opts(const char *opts1, const char *opts2) am_ops * -ops_match(am_opts *fo, char *key, char *g_key, char *path, char *keym, char *map) +ops_search(char *type) { am_ops **vp; am_ops *rop = 0; + for (vp = vops; (rop = *vp); vp++) + if (STREQ(rop->fs_type, type)) + break; + return rop; +} + + +am_ops * +ops_match(am_opts *fo, char *key, char *g_key, char *path, char *keym, char *map) +{ + am_ops *rop = 0; + char *link_dir; /* * First crack the global opts and the local opts @@ -377,9 +388,7 @@ ops_match(am_opts *fo, char *key, char *g_key, char *path, char *keym, char *map /* * Next find the correct filesystem type */ - for (vp = vops; (rop = *vp); vp++) - if (STREQ(rop->fs_type, fo->opt_type)) - break; + rop = ops_search(fo->opt_type); if (!rop) { plog(XLOG_USER, "fs type \"%s\" not recognized", fo->opt_type); rop = &amfs_error_ops; @@ -434,17 +443,33 @@ ops_match(am_opts *fo, char *key, char *g_key, char *path, char *keym, char *map } /* + * Initialize opt_mount_type to "nfs", if it's not initialized already + */ + if (!fo->opt_mount_type) + fo->opt_mount_type = "nfs"; + + /* Normalize the sublink and make it absolute */ + link_dir = fo->opt_sublink; + if (link_dir && link_dir[0] && link_dir[0] != '/') { + link_dir = str3cat((char *) 0, fo->opt_fs, "/", link_dir); + normalize_slash(link_dir); + XFREE(fo->opt_sublink); + fo->opt_sublink = link_dir; + } + + /* * Check the filesystem is happy */ if (fo->fs_mtab) XFREE(fo->fs_mtab); - if ((fo->fs_mtab = (*rop->fs_match) (fo))) + fo->fs_mtab = rop->fs_match(fo); + if (fo->fs_mtab) return rop; /* * Return error file system */ - fo->fs_mtab = (*amfs_error_ops.fs_match) (fo); + fo->fs_mtab = amfs_error_ops.fs_match(fo); return &amfs_error_ops; } diff --git a/contrib/amd/amd/amd.8 b/contrib/amd/amd/amd.8 index a3967a67c7b7..565a5505b8c2 100644 --- a/contrib/amd/amd/amd.8 +++ b/contrib/amd/amd/amd.8 @@ -1,5 +1,5 @@ .\" -.\" Copyright (c) 1997-2004 Erez Zadok +.\" Copyright (c) 1997-2006 Erez Zadok .\" Copyright (c) 1989 Jan-Simon Pendry .\" Copyright (c) 1989 Imperial College of Science, Technology & Medicine .\" Copyright (c) 1989 The Regents of the University of California. @@ -38,7 +38,7 @@ .\" .\" %W% (Berkeley) %G% .\" -.\" $Id: amd.8,v 1.4.2.5 2004/01/06 03:15:16 ezk Exp $ +.\" $Id: amd.8,v 1.14.2.1 2006/01/02 18:48:23 ezk Exp $ .\" .TH AMD 8 "3 November 1989" .SH NAME @@ -76,6 +76,8 @@ amd \- automatically mount file systems ] [ .BI \-y " YP-domain" ] [ +.BI \-A " arch" +] [ .BI \-C " cluster-name" ] [ .BI \-D " option" @@ -244,6 +246,11 @@ The default is the system domain name. This option is ignored if NIS support is not available. .TP +.BI \-A " arch" +Specifies the OS architecture. This is used solely to set the ${arch} +selector. + +.TP .BI \-C " cluster-name" Specify an alternative HP-UX cluster name to use. @@ -310,14 +317,12 @@ Map entries that are tagged with a tag other than will not be processed. .SH FILES -.PD 0 .TP 5 .B /a directory under which filesystems are dynamically mounted .TP 5 .B /etc/amd.conf default configuration file -.PD .SH CAVEATS Some care may be required when creating a mount map. .LP @@ -345,12 +350,21 @@ the features. .BR mtab (5), .BR syslog (3). .LP +``am-utils'' +.BR info (1) +entry. +.LP +.I "Linux NFS and Automounter Administration" +by Erez Zadok, ISBN 0-7821-2739-8, (Sybex, 2001). +.LP +.I http://www.am-utils.org +.LP .I "Amd \- The 4.4 BSD Automounter" .SH AUTHORS Jan-Simon Pendry <jsp@doc.ic.ac.uk>, Department of Computing, Imperial College, London, UK. .P -Erez Zadok <ezk@cs.columbia.edu>, Department of Computer Science, Columbia -University, New York, USA. +Erez Zadok <ezk@cs.sunysb.edu>, Computer Science Department, Stony Brook +University, Stony Brook, New York, USA. .P Other authors and contributors to am-utils are listed in the .B AUTHORS diff --git a/contrib/amd/amd/amd.c b/contrib/amd/amd/amd.c index e2631aed2b68..37eab5d8442c 100644 --- a/contrib/amd/amd/amd.c +++ b/contrib/amd/amd/amd.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: amd.c,v 1.8.2.6 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/amd.c * */ @@ -54,9 +53,10 @@ struct amu_global_options gopt; /* where global options are stored */ -char pid_fsname[16 + MAXHOSTNAMELEN]; /* "kiska.southseas.nz:(pid%d)" */ +char pid_fsname[SIZEOF_PID_FSNAME]; /* "kiska.southseas.nz:(pid%d)" */ char *hostdomain = "unknown.domain"; -char hostd[2 * MAXHOSTNAMELEN + 1]; /* Host+domain */ +#define SIZEOF_HOSTD (2 * MAXHOSTNAMELEN + 1) /* Host+domain */ +char hostd[SIZEOF_HOSTD]; /* Host+domain */ char *endian = ARCH_ENDIAN; /* Big or Little endian */ char *cpu = HOST_CPU; /* CPU type */ char *PrimNetName; /* name of primary network */ @@ -71,6 +71,10 @@ struct amd_stats amd_stats; /* Server statistics */ struct in_addr myipaddr; /* (An) IP address of this host */ time_t do_mapc_reload = 0; /* mapc_reload() call required? */ +#ifdef HAVE_FS_AUTOFS +int amd_use_autofs = 0; +#endif /* HAVE_FS_AUTOFS */ + #ifdef HAVE_SIGACTION sigset_t masked_sigs; #endif /* HAVE_SIGACTION */ @@ -118,10 +122,8 @@ sighup(int sig) signal(sig, sighup); #endif /* REINSTALL_SIGNAL_HANDLER */ -#ifdef DEBUG if (sig != SIGHUP) dlog("spurious call to sighup"); -#endif /* DEBUG */ /* * Force a reload by zero'ing the timer */ @@ -133,7 +135,26 @@ sighup(int sig) static RETSIGTYPE parent_exit(int sig) { - exit(0); + /* + * This signal handler is called during Amd initialization. The parent + * forks a child to do all the hard automounting work, and waits for a + * SIGQUIT signal from the child. When the parent gets the signal it's + * supposed to call this handler and exit(3), thus completing the + * daemonizing process. Alas, on some systems, especially Linux 2.4/2.6 + * with Glibc, exit(3) doesn't always terminate the parent process. + * Worse, the parent process now refuses to accept any more SIGQUIT + * signals -- they are blocked. What's really annoying is that this + * doesn't happen all the time, suggesting a race condition somewhere. + * (This happens even if I change the logic to use another signal.) I + * traced this to something which exit(3) does in addition to exiting the + * process, probably some atexit() stuff or other side-effects related to + * signal handling. Either way, since at this stage the parent process + * just needs to terminate, I'm simply calling _exit(2). Note also that + * the OpenGroup doesn't list exit(3) as a recommended "Base Interface" + * but they do list _exit(2) as one. This fix seems to work reliably all + * the time. -Erez (2/27/2005) + */ + _exit(0); } @@ -145,6 +166,7 @@ daemon_mode(void) #ifdef HAVE_SIGACTION struct sigaction sa, osa; + memset(&sa, 0, sizeof(sa)); sa.sa_handler = parent_exit; sa.sa_flags = 0; sigemptyset(&(sa.sa_mask)); @@ -217,6 +239,7 @@ init_global_options(void) #if defined(HAVE_SYS_UTSNAME_H) && defined(HAVE_UNAME) static struct utsname un; #endif /* defined(HAVE_SYS_UTSNAME_H) && defined(HAVE_UNAME) */ + int i; memset(&gopt, 0, sizeof(struct amu_global_options)); @@ -226,9 +249,15 @@ init_global_options(void) /* automounter temp dir */ gopt.auto_dir = "/a"; + /* toplevel attribute cache timeout */ + gopt.auto_attrcache = 0; + /* cluster name */ gopt.cluster = NULL; + /* executable map timeout */ + gopt.exec_map_timeout = AMFS_EXEC_MAP_TIMEOUT; + /* * kernel architecture: this you must get from uname() if possible. */ @@ -260,11 +289,11 @@ init_global_options(void) /* local domain */ gopt.sub_domain = NULL; - /* NFS retransmit counter */ - gopt.amfs_auto_retrans = -1; - - /* NFS retry interval */ - gopt.amfs_auto_timeo = -1; + /* reset NFS (and toplvl) retransmit counter and retry interval */ + for (i=0; i<AMU_TYPE_MAX; ++i) { + gopt.amfs_auto_retrans[i] = -1; /* -1 means "never set before" */ + gopt.amfs_auto_timeo[i] = -1; /* -1 means "never set before" */ + } /* cache duration */ gopt.am_timeo = AM_TTL; @@ -272,11 +301,13 @@ init_global_options(void) /* dismount interval */ gopt.am_timeo_w = AM_TTL_W; + /* map reload intervl */ + gopt.map_reload_interval = ONE_HOUR; + /* - * various CFM_* flags. - * by default, only the "plock" option is on (if available). + * various CFM_* flags that are on by default. */ - gopt.flags = CFM_PROCESS_LOCK; + gopt.flags = CFM_DEFAULT_FLAGS; #ifdef HAVE_MAP_HESIOD /* Hesiod rhs zone */ @@ -293,6 +324,9 @@ init_global_options(void) /* LDAP cache */ gopt.ldap_cache_seconds = 0; gopt.ldap_cache_maxmem = 131072; + + /* LDAP protocol version */ + gopt.ldap_proto_version = 2; #endif /* HAVE_MAP_LDAP */ #ifdef HAVE_MAP_NIS @@ -302,17 +336,58 @@ init_global_options(void) } +/* + * Lock process text and data segment in memory (after forking the daemon) + */ +static void +do_memory_locking(void) +{ +#if defined(HAVE_PLOCK) || defined(HAVE_MLOCKALL) + int locked_ok = 0; +#else /* not HAVE_PLOCK and not HAVE_MLOCKALL */ + plog(XLOG_WARNING, "Process memory locking not supported by the OS"); +#endif /* not HAVE_PLOCK and not HAVE_MLOCKALL */ +#ifdef HAVE_PLOCK +# ifdef _AIX + /* + * On AIX you must lower the stack size using ulimit() before calling + * plock. Otherwise plock will reserve a lot of memory space based on + * your maximum stack size limit. Since it is not easily possible to + * tell what should the limit be, I print a warning before calling + * plock(). See the manual pages for ulimit(1,3,4) on your AIX system. + */ + plog(XLOG_WARNING, "AIX: may need to lower stack size using ulimit(3) before calling plock"); +# endif /* _AIX */ + if (!locked_ok && plock(PROCLOCK) != 0) + plog(XLOG_WARNING, "Couldn't lock process pages in memory using plock(): %m"); + else + locked_ok = 1; +#endif /* HAVE_PLOCK */ +#ifdef HAVE_MLOCKALL + if (!locked_ok && mlockall(MCL_CURRENT|MCL_FUTURE) != 0) + plog(XLOG_WARNING, "Couldn't lock process pages in memory using mlockall(): %m"); + else + locked_ok = 1; +#endif /* HAVE_MLOCKALL */ +#if defined(HAVE_PLOCK) || defined(HAVE_MLOCKALL) + if (locked_ok) + plog(XLOG_INFO, "Locked process pages in memory"); +#endif /* HAVE_PLOCK || HAVE_MLOCKALL */ + +#if defined(HAVE_MADVISE) && defined(MADV_PROTECT) + madvise(0, 0, MADV_PROTECT); /* may be redundant of the above worked out */ +#endif /* defined(HAVE_MADVISE) && defined(MADV_PROTECT) */ +} + + int main(int argc, char *argv[]) { - char *domdot, *verstr; + char *domdot, *verstr, *vertmp; int ppid = 0; int error; char *progname = NULL; /* "amd" */ char hostname[MAXHOSTNAMELEN + 1] = "localhost"; /* Hostname */ -#ifdef HAVE_SIGACTION - struct sigaction sa; -#endif /* HAVE_SIGACTION */ /* * Make sure some built-in assumptions are true before we start @@ -363,11 +438,6 @@ main(int argc, char *argv[]) going_down(1); } -#ifdef DEBUG - /* initialize debugging flags (Register AMQ, Enter daemon mode) */ - debug_flags = D_AMQ | D_DAEMON; -#endif /* DEBUG */ - /* * Initialize global options structure. */ @@ -386,73 +456,31 @@ main(int argc, char *argv[]) *domdot++ = '\0'; hostdomain = domdot; } - strcpy(hostd, hostname); + xstrlcpy(hostd, hostname, sizeof(hostd)); am_set_hostname(hostname); /* - * Trap interrupts for shutdowns. - */ -#ifdef HAVE_SIGACTION - sa.sa_handler = sigterm; - sa.sa_flags = 0; - sigemptyset(&(sa.sa_mask)); - sigaddset(&(sa.sa_mask), SIGINT); - sigaddset(&(sa.sa_mask), SIGTERM); - sigaction(SIGINT, &sa, NULL); - sigaction(SIGTERM, &sa, NULL); -#else /* not HAVE_SIGACTION */ - (void) signal(SIGINT, sigterm); -#endif /* not HAVE_SIGACTION */ - - /* - * Trap Terminate so that we can shutdown gracefully (some chance) - */ -#ifdef HAVE_SIGACTION - sa.sa_handler = sigterm; - sa.sa_flags = 0; - sigemptyset(&(sa.sa_mask)); - sigaddset(&(sa.sa_mask), SIGTERM); - sigaction(SIGTERM, &sa, NULL); -#else /* not HAVE_SIGACTION */ - (void) signal(SIGTERM, sigterm); -#endif /* not HAVE_SIGACTION */ - - /* - * Hangups tell us to reload the cache + * Setup signal handlers */ -#ifdef HAVE_SIGACTION - sa.sa_handler = sighup; - sa.sa_flags = 0; - sigemptyset(&(sa.sa_mask)); - sigaddset(&(sa.sa_mask), SIGHUP); - sigaction(SIGHUP, &sa, NULL); -#else /* not HAVE_SIGACTION */ - (void) signal(SIGHUP, sighup); -#endif /* not HAVE_SIGACTION */ - + /* SIGINT: trap interrupts for shutdowns */ + setup_sighandler(SIGINT, sigterm); + /* SIGTERM: trap terminate so we can shutdown cleanly (some chance) */ + setup_sighandler(SIGTERM, sigterm); + /* SIGHUP: hangups tell us to reload the cache */ + setup_sighandler(SIGHUP, sighup); /* - * Trap Death-of-a-child. These allow us to - * pick up the exit status of backgrounded mounts. - * See "sched.c". + * SIGCHLD: trap Death-of-a-child. These allow us to pick up the exit + * status of backgrounded mounts. See "sched.c". */ + setup_sighandler(SIGCHLD, sigchld); #ifdef HAVE_SIGACTION - sa.sa_handler = sigchld; - sa.sa_flags = 0; - sigemptyset(&(sa.sa_mask)); - sigaddset(&(sa.sa_mask), SIGCHLD); - sigaction(SIGCHLD, &sa, NULL); - - /* - * construct global "masked_sigs" used in nfs_start.c - */ + /* construct global "masked_sigs" used in nfs_start.c */ sigemptyset(&masked_sigs); + sigaddset(&masked_sigs, SIGINT); + sigaddset(&masked_sigs, SIGTERM); sigaddset(&masked_sigs, SIGHUP); sigaddset(&masked_sigs, SIGCHLD); - sigaddset(&masked_sigs, SIGTERM); - sigaddset(&masked_sigs, SIGINT); -#else /* not HAVE_SIGACTION */ - (void) signal(SIGCHLD, sigchld); -#endif /* not HAVE_SIGACTION */ +#endif /* HAVE_SIGACTION */ /* * Fix-up any umask problems. Most systems default @@ -473,18 +501,21 @@ main(int argc, char *argv[]) /* * Log version information. */ - verstr = strtok(get_version_string(), "\n"); + vertmp = get_version_string(); + verstr = strtok(vertmp, "\n"); plog(XLOG_INFO, "AM-UTILS VERSION INFORMATION:"); while (verstr) { plog(XLOG_INFO, "%s", verstr); verstr = strtok(NULL, "\n"); } + XFREE(vertmp); /* - * Get our own IP address so that we - * can mount the automounter. + * Get our own IP address so that we can mount the automounter. We pass + * localhost_address which could be used as the default localhost + * name/address in amu_get_myaddress(). */ - amu_get_myaddress(&myipaddr); + amu_get_myaddress(&myipaddr, gopt.localhost_address); plog(XLOG_INFO, "My ip addr is %s", inet_ntoa(myipaddr)); /* avoid hanging on other NFS servers if started elsewhere */ @@ -499,29 +530,6 @@ main(int argc, char *argv[]) going_down(1); } - /* - * Lock process text and data segment in memory. - */ -#ifdef HAVE_PLOCK - if (gopt.flags & CFM_PROCESS_LOCK) { -# ifdef _AIX - /* - * On AIX you must lower the stack size using ulimit() before calling - * plock. Otherwise plock will reserve a lot of memory space based on - * your maximum stack size limit. Since it is not easily possible to - * tell what should the limit be, I print a warning before calling - * plock(). See the manual pages for ulimit(1,3,4) on your AIX system. - */ - plog(XLOG_WARNING, "AIX: may need to lower stack size using ulimit(3) before calling plock"); -# endif /* _AIX */ - if (plock(PROCLOCK) != 0) { - plog(XLOG_WARNING, "Couldn't lock process text and data segment in memory: %m"); - } else { - plog(XLOG_INFO, "Locked process text and data segment in memory"); - } - } -#endif /* HAVE_PLOCK */ - #ifdef HAVE_MAP_NIS /* * If the domain was specified then bind it here @@ -534,14 +542,17 @@ main(int argc, char *argv[]) } #endif /* HAVE_MAP_NIS */ -#ifdef DEBUG - amuDebug(D_DAEMON) -#endif /* DEBUG */ + if (!amuDebug(D_DAEMON)) ppid = daemon_mode(); - sprintf(pid_fsname, "%s:(pid%ld)", am_get_hostname(), (long) am_mypid); + /* + * Lock process text and data segment in memory. + */ + if (gopt.flags & CFM_PROCESS_LOCK) { + do_memory_locking(); + } - do_mapc_reload = clocktime() + ONE_HOUR; + do_mapc_reload = clocktime(NULL) + gopt.map_reload_interval; /* * Register automounter with system. @@ -549,6 +560,16 @@ main(int argc, char *argv[]) error = mount_automounter(ppid); if (error && ppid) kill(ppid, SIGALRM); + +#ifdef HAVE_FS_AUTOFS + /* + * XXX this should be part of going_down(), but I can't move it there + * because it would be calling non-library code from the library... ugh + */ + if (amd_use_autofs) + destroy_autofs_service(); +#endif /* HAVE_FS_AUTOFS */ + going_down(error); abort(); diff --git a/contrib/amd/amd/amd.h b/contrib/amd/amd/amd.h index e5e4e445c790..0e371b72a5b0 100644 --- a/contrib/amd/amd/amd.h +++ b/contrib/amd/amd/amd.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: amd.h,v 1.8.2.8 2004/01/21 04:04:58 ib42 Exp $ + * File: am-utils/amd/amd.h * */ @@ -50,33 +49,160 @@ * MACROS: */ +/* + * Define a default debug mtab path for systems + * that support mtab on file. + */ +#ifdef MOUNT_TABLE_ON_FILE +# define DEBUG_MNTTAB_FILE "/tmp/mnttab" +#endif /* MOUNT_TABLE_ON_FILE */ + /* options for amd.conf */ -#define CFM_BROWSABLE_DIRS 0x0001 -#define CFM_MOUNT_TYPE_AUTOFS 0x0002 -#define CFM_SELECTORS_IN_DEFAULTS 0x0004 -#define CFM_NORMALIZE_HOSTNAMES 0x0008 -#define CFM_PROCESS_LOCK 0x0010 -#define CFM_PRINT_PID 0x0020 -#define CFM_RESTART_EXISTING_MOUNTS 0x0040 -#define CFM_SHOW_STATFS_ENTRIES 0x0080 -#define CFM_FULLY_QUALIFIED_HOSTS 0x0100 -#define CFM_BROWSABLE_DIRS_FULL 0x0200 /* allow '/' in readdir() */ -#define CFM_UNMOUNT_ON_EXIT 0x0400 /* when amd finishing */ -#define CFM_NFS_INSECURE_PORT 0x0800 +#define CFM_BROWSABLE_DIRS 0x00000001 +#define CFM_MOUNT_TYPE_AUTOFS 0x00000002 /* use kernel autofs support */ +#define CFM_SELECTORS_IN_DEFAULTS 0x00000004 +#define CFM_NORMALIZE_HOSTNAMES 0x00000008 +#define CFM_PROCESS_LOCK 0x00000010 +#define CFM_PRINT_PID 0x00000020 +#define CFM_RESTART_EXISTING_MOUNTS 0x00000040 +#define CFM_SHOW_STATFS_ENTRIES 0x00000080 +#define CFM_FULLY_QUALIFIED_HOSTS 0x00000100 +#define CFM_BROWSABLE_DIRS_FULL 0x00000200 /* allow '/' in readdir() */ +#define CFM_UNMOUNT_ON_EXIT 0x00000400 /* when amd finishing */ +#define CFM_USE_TCPWRAPPERS 0x00000800 +#define CFM_AUTOFS_USE_LOFS 0x00001000 +#define CFM_NFS_INSECURE_PORT 0x00002000 +#define CFM_DOMAIN_STRIP 0x00004000 +#define CFM_NORMALIZE_SLASHES 0x00008000 /* normalize slashes? */ +#define CFM_FORCED_UNMOUNTS 0x00010000 /* forced unmounts? */ +#define CFM_TRUNCATE_LOG 0x00020000 /* truncate log file? */ +#if 0 +/* XXX: reserved to sync up with am-utils-6.2 */ +#define CFM_SUN_MAP_SYNTAX 0x00040000 /* Sun map syntax? */ +#endif +#define CFM_NFS_ANY_INTERFACE 0x00080000 /* all interfaces are acceptable */ + +/* defaults global flags: plock, tcpwrappers, and autofs/lofs */ +#define CFM_DEFAULT_FLAGS (CFM_PROCESS_LOCK|CFM_USE_TCPWRAPPERS|CFM_AUTOFS_USE_LOFS|CFM_DOMAIN_STRIP|CFM_NORMALIZE_SLASHES) + +/* + * macro definitions for automounter vfs/vnode operations. + */ +#define VLOOK_CREATE 0x1 +#define VLOOK_DELETE 0x2 +#define VLOOK_LOOKUP 0x3 + +/* + * macro definitions for automounter vfs capabilities + */ +#define FS_DIRECTORY 0x0001 /* This looks like a dir, not a link */ +#define FS_MBACKGROUND 0x0002 /* Should background this mount */ +#define FS_NOTIMEOUT 0x0004 /* Don't bother with timeouts */ +#define FS_MKMNT 0x0008 /* Need to make the mount point */ +#define FS_UBACKGROUND 0x0010 /* Unmount in background */ +#define FS_BACKGROUND (FS_MBACKGROUND|FS_UBACKGROUND) +#define FS_DISCARD 0x0020 /* Discard immediately on last reference */ +#define FS_AMQINFO 0x0040 /* Amq is interested in this fs type */ +#define FS_AUTOFS 0x0080 /* This filesystem can be an autofs f/s */ +#define FS_DIRECT 0x0100 /* Direct mount */ +#define FS_ON_AUTOFS 0x0200 /* This filesystem can be mounted directly + onto an autofs mountpoint */ + +/* + * macros for struct am_node (map of auto-mount points). + */ +#define AMF_NOTIMEOUT 0x0001 /* This node never times out */ +#define AMF_ROOT 0x0002 /* This is a root node */ +#define AMF_AUTOFS 0x0004 /* This node is part of an autofs filesystem */ +#define AMF_REMOUNT 0x0008 /* This node needs to be remounted */ +#define AMF_SOFTLOOKUP 0x0010 /* This node returns EIO if server is down */ + +/* + * macros for struct mntfs (list of mounted filesystems) + */ +#define MFF_MOUNTED 0x0001 /* Node is mounted */ +#define MFF_MOUNTING 0x0002 /* Mount is in progress */ +#define MFF_UNMOUNTING 0x0004 /* Unmount is in progress */ +#define MFF_RESTART 0x0008 /* Restarted node */ +#define MFF_MKMNT 0x0010 /* Delete this node's am_mount */ +#define MFF_ERROR 0x0020 /* This node failed to mount */ +#define MFF_LOGDOWN 0x0040 /* Logged that this mount is down */ +#define MFF_RSTKEEP 0x0080 /* Don't timeout this filesystem - restarted */ +#define MFF_WANTTIMO 0x0100 /* Need a timeout call when not busy */ +#define MFF_NFSLINK 0x0200 /* nfsl type, and deemed a link */ +#define MFF_IS_AUTOFS 0x0400 /* this filesystem is of type autofs */ +#define MFF_NFS_SCALEDOWN 0x0800 /* the mount failed, retry with v2/UDP */ +#define MFF_ON_AUTOFS 0x1000 /* autofs has a lofs/link to this f/s */ +#define MFF_WEBNFS 0x2000 /* use public filehandle */ + +/* + * macros for struct fserver. + */ +#define FSF_VALID 0x0001 /* Valid information available */ +#define FSF_DOWN 0x0002 /* This fileserver is thought to be down */ +#define FSF_ERROR 0x0004 /* Permanent error has occurred */ +#define FSF_WANT 0x0008 /* Want a wakeup call */ +#define FSF_PINGING 0x0010 /* Already doing pings */ +#define FSF_WEBNFS 0x0020 /* Don't try to contact portmapper */ +#define FSF_PING_UNINIT 0x0040 /* ping values have not been initilized */ +#define FSF_FORCE_UNMOUNT 0x0080 /* force umount of this fserver */ +#define FSRV_ERROR(fs) ((fs) && (((fs)->fs_flags & FSF_ERROR) == FSF_ERROR)) +#define FSRV_ISDOWN(fs) ((fs) && (((fs)->fs_flags & (FSF_DOWN|FSF_VALID)) == (FSF_DOWN|FSF_VALID))) +#define FSRV_ISUP(fs) (!(fs) || (((fs)->fs_flags & (FSF_DOWN|FSF_VALID)) == (FSF_VALID))) /* some systems (SunOS 4.x) neglect to define the mount null message */ #ifndef MOUNTPROC_NULL # define MOUNTPROC_NULL ((u_long)(0)) #endif /* not MOUNTPROC_NULL */ +/* + * Error to return if remote host is not available. + * Try, in order, "host down", "host unreachable", "invalid argument". + */ +#ifdef EHOSTDOWN +# define AM_ERRNO_HOST_DOWN EHOSTDOWN +#else /* not EHOSTDOWN */ +# ifdef EHOSTUNREACH +# define AM_ERRNO_HOST_DOWN EHOSTUNREACH +# else /* not EHOSTUNREACH */ +# define AM_ERRNO_HOST_DOWN EINVAL +# endif /* not EHOSTUNREACH */ +#endif /* not EHOSTDOWN */ + /* Hash table size */ #define NKVHASH (1 << 2) /* Power of two */ +/* Max entries to return in one call */ +#define MAX_READDIR_ENTRIES 16 + +/* + * default amfs_auto retrans - 1/10th seconds + */ +#define AMFS_AUTO_RETRANS(x) ((ALLOWED_MOUNT_TIME*10+5*gopt.amfs_auto_timeo[(x)])/gopt.amfs_auto_timeo[(x)] * 2) + +/* + * The following values can be tuned... + */ +#define AM_TTL (300) /* Default cache period (5 min) */ +#define AM_TTL_W (120) /* Default unmount interval (2 min) */ +#define AM_PINGER 30 /* NFS ping interval for live systems */ +#define AMFS_AUTO_TIMEO 8 /* Default amfs_auto timeout - .8s */ +#define AMFS_EXEC_MAP_TIMEOUT 10 /* default 10sec exec map timeout */ + /* interval between forced retries of a mount */ #define RETRY_INTERVAL 2 -#define ereturn(x) { *error_return = x; return 0; } +#ifndef ROOT_MAP +# define ROOT_MAP "\"root\"" +#endif /* not ROOT_MAP */ +#define ereturn(x) do { *error_return = x; return 0; } while (0) + +#define NEVER (time_t) 0 + +#if defined(HAVE_TCPD_H) && defined(HAVE_LIBWRAP) +# define AMD_SERVICE_NAME "amd" /* for tcpwrappers */ +#endif /* defined(HAVE_TCPD_H) && defined(HAVE_LIBWRAP) */ /* * TYPEDEFS: @@ -84,6 +210,16 @@ typedef struct cf_map cf_map_t; typedef struct kv kv; +typedef struct am_node am_node; +typedef struct mntfs mntfs; +typedef struct am_opts am_opts; +typedef struct am_ops am_ops; +typedef struct am_stats am_stats; +typedef struct fserver fserver; + +typedef voidp wchan_t; +typedef voidp opaque_t; + /* * Cache map operations */ @@ -93,6 +229,28 @@ typedef int mtime_fn(mnt_map *, char *, time_t *); typedef int isup_fn(mnt_map *, char *); typedef int reload_fn(mnt_map *, char *, add_fn *); typedef int search_fn(mnt_map *, char *, char *, char **, time_t *); +typedef int task_fun(opaque_t); +typedef void cb_fun(int, int, opaque_t); +typedef void fwd_fun(voidp, int, struct sockaddr_in *, + struct sockaddr_in *, opaque_t, int); +typedef int key_fun(char *, opaque_t); +typedef void callout_fun(opaque_t); + +/* + * automounter vfs/vnode operations. + */ +typedef char *(*vfs_match) (am_opts *); +typedef int (*vfs_init) (mntfs *); +typedef int (*vmount_fs) (am_node *, mntfs *); +typedef int (*vumount_fs) (am_node *, mntfs *); +typedef am_node *(*vlookup_child) (am_node *, char *, int *, int); +typedef am_node *(*vmount_child) (am_node *, int *); +typedef int (*vreaddir) (am_node *, nfscookie, nfsdirlist *, nfsentry *, u_int); +typedef am_node *(*vreadlink) (am_node *, int *); +typedef void (*vmounted) (mntfs *); +typedef void (*vumounted) (mntfs *); +typedef fserver *(*vffserver) (mntfs *); +typedef wchan_t (*vget_wchan) (mntfs *); @@ -104,6 +262,7 @@ typedef int search_fn(mnt_map *, char *, char *, char **, time_t *); struct amu_global_options { char *arch; /* name of current architecture */ char *auto_dir; /* automounter temp dir */ + int auto_attrcache; /* attribute cache timeout for auto dirs */ char *cluster; /* cluster name */ char *karch; /* kernel architecture */ char *logfile; /* amd log file */ @@ -113,16 +272,33 @@ struct amu_global_options { char *op_sys_vendor; /* name of OS vendor ${vendor} */ char *pid_file; /* PID file */ char *sub_domain; /* local domain */ + char *localhost_address; /* localhost address (NULL means use 127.0.0.1) */ + char *map_defaults; /* global map /default options */ char *map_options; /* global map options */ + int map_reload_interval; /* map reload interval */ char *map_type; /* global map type */ char *search_path; /* search path for maps */ char *mount_type; /* mount type for map */ + char *debug_mtab_file; /* path for the mtab file during debug mode */ u_int flags; /* various CFM_* flags */ - int amfs_auto_retrans; /* NFS retransmit counter */ - int amfs_auto_timeo; /* NFS retry interval */ + +#define AMU_TYPE_NONE -1 /* for amfs_auto_{timeo,retrans,toplvl} */ +#define AMU_TYPE_UDP 0 /* for amfs_auto_{timeo,retrans,toplvl} */ +#define AMU_TYPE_TCP 1 /* for amfs_auto_{timeo,retrans,toplvl} */ + /* + * Note: toplvl is only UDP, but we want to separate it from regular + * NFS mounts which Amd makes, because the toplvl mount is a localhost + * mount for which different timeo/retrans parameters may be desired. + */ +#define AMU_TYPE_TOPLVL 2 /* for amfs_auto_{timeo,retrans,toplvl} */ +#define AMU_TYPE_MAX 3 /* for amfs_auto_{timeo,retrans,toplvl} */ + int amfs_auto_retrans[AMU_TYPE_MAX]; /* NFS retransmit counter */ + int amfs_auto_timeo[AMU_TYPE_MAX]; /* NFS retry interval */ + int am_timeo; /* cache duration */ int am_timeo_w; /* dismount interval */ - int portmap_program; /* amd RPC program number */ + u_long portmap_program; /* amd RPC program number */ + u_short preferred_amq_port; /* preferred amq service RPC port number (0 means "any") */ #ifdef HAVE_MAP_HESIOD char *hesiod_base; /* Hesiod rhs */ #endif /* HAVE_MAP_HESIOD */ @@ -131,12 +307,14 @@ struct amu_global_options { char *ldap_hostports; /* LDAP host ports */ long ldap_cache_seconds; /* LDAP internal cache - keep seconds */ long ldap_cache_maxmem; /* LDAP internal cache - max memory (bytes) */ + long ldap_proto_version; /* LDAP protocol version */ #endif /* HAVE_MAP_LDAP */ #ifdef HAVE_MAP_NIS char *nis_domain; /* YP domain name */ #endif /* HAVE_MAP_NIS */ char *nfs_proto; /* NFS protocol (NULL, udp, tcp) */ int nfs_vers; /* NFS version (0, 2, 3, 4) */ + u_int exec_map_timeout; /* timeout (seconds) for executable maps */ }; /* if you add anything here, update conf.c:reset_cf_map() */ @@ -144,10 +322,12 @@ struct cf_map { char *cfm_dir; /* /home, /u, /src */ char *cfm_name; /* amd.home, /etc/amd.home ... */ char *cfm_type; /* file, hesiod, ndbm, nis ... */ + char *cfm_defaults; /* map /defaults options in amd.conf */ char *cfm_opts; /* -cache:=all, etc. */ char *cfm_search_path; /* /etc/local:/etc/amdmaps:/misc/yp */ char *cfm_tag; /* optional map tag for amd -T */ u_int cfm_flags; /* browsable_dirs? mount_type? */ + struct cf_map *cfm_next; /* pointer to next in list (if any) */ }; /* @@ -176,52 +356,173 @@ struct mnt_map { search_fn *search; /* Function to be used for searching */ mtime_fn *mtime; /* Modify time function */ kv *kvhash[NKVHASH]; /* Cached data */ - /* options available via amd conf file */ - char *cf_map_type; /* file, hesiod, ndbm, nis, etc. */ - char *cf_search_path; /* /etc/local:/etc/amdmaps:/misc/yp */ + cf_map_t *cfm; /* pointer to per-map amd.conf opts, if any */ void *map_data; /* Map data black box */ }; /* - * Mounting a file system may take a significant period of time. The - * problem is that if this is done in the main process thread then the - * entire automounter could be blocked, possibly hanging lots of processes - * on the system. Instead we use a continuation scheme to allow mounts to - * be attempted in a sub-process. When the sub-process exits we pick up the - * exit status (by convention a UN*X error number) and continue in a - * notifier. The notifier gets handed a data structure and can then - * determine whether the mount was successful or not. If not, it updates - * the data structure and tries again until there are no more ways to try - * the mount, or some other permanent error occurs. In the mean time no RPC - * reply is sent, even after the mount is successful. We rely on the RPC - * retry mechanism to resend the lookup request which can then be handled. - */ -struct continuation { - char **ivec; /* Current mount info */ - am_node *mp; /* Node we are trying to mount */ - char *key; /* Map key */ - char *info; /* Info string */ - char **xivec; /* Saved strsplit vector */ - char *auto_opts; /* Automount options */ - am_opts fs_opts; /* Filesystem options */ - char *def_opts; /* Default automount options */ - int retry; /* Try again? */ - int tried; /* Have we tried any yet? */ - time_t start; /* Time we started this mount */ - int callout; /* Callout identifier */ + * Options + */ +struct am_opts { + char *fs_glob; /* Smashed copy of global options */ + char *fs_local; /* Expanded copy of local options */ + char *fs_mtab; /* Mount table entry */ + /* Other options ... */ + char *opt_dev; + char *opt_delay; + char *opt_dir; + char *opt_fs; + char *opt_group; + char *opt_mount; + char *opt_opts; + char *opt_remopts; + char *opt_pref; + char *opt_cache; + char *opt_rfs; + char *opt_rhost; + char *opt_sublink; + char *opt_type; + char *opt_mount_type; /* "nfs" or "autofs" */ + char *opt_unmount; + char *opt_umount; /* an "alias" for opt_unmount (type:=program) */ + char *opt_user; + char *opt_maptype; /* map type: file, nis, hesiod, etc. */ + char *opt_cachedir; /* cache directory */ + char *opt_addopts; /* options to add to opt_opts */ }; +struct am_ops { + char *fs_type; /* type of filesystems e.g. "nfsx" */ + vfs_match fs_match; /* fxn: match */ + vfs_init fs_init; /* fxn: initialization */ + vmount_fs mount_fs; /* fxn: mount my own vnode */ + vumount_fs umount_fs; /* fxn: unmount my own vnode */ + vlookup_child lookup_child; /* fxn: lookup path-name */ + vmount_child mount_child; /* fxn: mount path-name */ + vreaddir readdir; /* fxn: read directory */ + vreadlink readlink; /* fxn: read link */ + vmounted mounted; /* fxn: after-mount extra actions */ + vumounted umounted; /* fxn: after-umount extra actions */ + vffserver ffserver; /* fxn: find a file server */ + vget_wchan get_wchan; /* fxn: get the waiting channel */ + int nfs_fs_flags; /* filesystem flags FS_* for nfs mounts */ +#ifdef HAVE_FS_AUTOFS + int autofs_fs_flags;/* filesystem flags FS_* for autofs mounts */ +#endif /* HAVE_FS_AUTOFS */ +}; + +/* + * List of mounted filesystems + */ +struct mntfs { + qelem mf_q; /* List of mounted filesystems */ + am_ops *mf_ops; /* Operations on this mountpoint */ + am_opts *mf_fo; /* File opts */ + char *mf_mount; /* "/a/kiska/home/kiska" */ + char *mf_info; /* Mount info */ + char *mf_auto; /* Automount opts */ + char *mf_mopts; /* FS mount opts */ + char *mf_remopts; /* Remote FS mount opts */ + char *mf_loopdev; /* loop device name for /dev/loop mounts */ + fserver *mf_server; /* File server */ + int mf_fsflags; /* Flags FS_* copied from mf_ops->*_fs_flags */ + int mf_flags; /* Flags MFF_* */ + int mf_error; /* Error code from background mount */ + int mf_refc; /* Number of references to this node */ + int mf_cid; /* Callout id */ + void (*mf_prfree) (opaque_t); /* Free private space */ + opaque_t mf_private; /* Private - per-fs data */ +}; + +/* + * List of fileservers + */ +struct fserver { + qelem fs_q; /* List of fileservers */ + int fs_refc; /* Number of references to this server */ + char *fs_host; /* Normalized hostname of server */ + struct sockaddr_in *fs_ip; /* Network address of server */ + int fs_cid; /* Callout id */ + int fs_pinger; /* Ping (keepalive) interval */ + int fs_flags; /* Flags */ + char *fs_type; /* File server type */ + u_long fs_version; /* NFS version of server (2, 3, etc.)*/ + char *fs_proto; /* NFS protocol of server (tcp, udp, etc.) */ + opaque_t fs_private; /* Private data */ + void (*fs_prfree) (opaque_t); /* Free private data */ +}; + +/* + * Per-mountpoint statistics + */ +struct am_stats { + time_t s_mtime; /* Mount time */ + u_short s_uid; /* Uid of mounter */ + int s_getattr; /* Count of getattrs */ + int s_lookup; /* Count of lookups */ + int s_readdir; /* Count of readdirs */ + int s_readlink; /* Count of readlinks */ + int s_statfs; /* Count of statfs */ +}; + +/* + * System statistics + */ +struct amd_stats { + int d_drops; /* Dropped requests */ + int d_stale; /* Stale NFS handles */ + int d_mok; /* Successful mounts */ + int d_merr; /* Failed mounts */ + int d_uerr; /* Failed unmounts */ +}; +extern struct amd_stats amd_stats; + +/* + * Map of auto-mount points. + */ +struct am_node { + int am_mapno; /* Map number */ + mntfs *am_mnt; /* Mounted filesystem */ + mntfs **am_mfarray; /* Filesystem sources to try to mount */ + char *am_name; /* "kiska": name of this node */ + char *am_path; /* "/home/kiska": path of this node's mount point */ + char *am_link; /* "/a/kiska/home/kiska/this/that": link to sub-dir */ + am_node *am_parent; /* Parent of this node */ + am_node *am_ysib; /* Younger sibling of this node */ + am_node *am_osib; /* Older sibling of this node */ + am_node *am_child; /* First child of this node */ + nfsattrstat am_attr; /* File attributes */ +#define am_fattr am_attr.ns_u.ns_attr_u + int am_flags; /* Boolean flags AMF_* */ + int am_error; /* Specific mount error */ + time_t am_ttl; /* Time to live */ + int am_timeo_w; /* Dismount wait interval */ + int am_timeo; /* Cache timeout interval */ + u_int am_gen; /* Generation number */ + char *am_pref; /* Mount info prefix */ + am_stats am_stats; /* Statistics gathering */ + SVCXPRT *am_transp; /* Info for quick reply */ + dev_t am_dev; /* Device number */ + dev_t am_rdev; /* Remote/real device number */ +#ifdef HAVE_FS_AUTOFS + autofs_fh_t *am_autofs_fh; + time_t am_autofs_ttl; /* Time to expire autofs nodes */ +#endif /* HAVE_FS_AUTOFS */ +}; /* * EXTERNALS: */ -/* Amq server global functions */ +/* + * Amq server global functions + */ extern amq_mount_info_list *amqproc_getmntfs_1_svc(voidp argp, struct svc_req *rqstp); extern amq_mount_stats *amqproc_stats_1_svc(voidp argp, struct svc_req *rqstp); extern amq_mount_tree_list *amqproc_export_1_svc(voidp argp, struct svc_req *rqstp); extern amq_mount_tree_p *amqproc_mnttree_1_svc(voidp argp, struct svc_req *rqstp); extern amq_string *amqproc_getvers_1_svc(voidp argp, struct svc_req *rqstp); +extern amq_string *amqproc_pawd_1_svc(voidp argp, struct svc_req *rqstp); extern int *amqproc_getpid_1_svc(voidp argp, struct svc_req *rqstp); extern int *amqproc_mount_1_svc(voidp argp, struct svc_req *rqstp); extern int *amqproc_setopt_1_svc(voidp argp, struct svc_req *rqstp); @@ -229,44 +530,134 @@ extern voidp amqproc_null_1_svc(voidp argp, struct svc_req *rqstp); extern voidp amqproc_umnt_1_svc(voidp argp, struct svc_req *rqstp); /* other external definitions */ -extern am_nfs_fh *root_fh(char *dir); +extern am_nfs_fh *get_root_nfs_fh(char *dir); extern am_node *find_ap(char *); -extern am_node *find_ap2(char *, am_node *); +extern am_node *get_ap_child(am_node *, char *); extern bool_t xdr_amq_mount_info_qelem(XDR *xdrs, qelem *qhead); extern fserver *find_nfs_srvr(mntfs *mf); -extern int auto_fmount(am_node *mp); -extern int auto_fumount(am_node *mp); -extern int mount_nfs_fh(am_nfs_handle_t *fhp, char *dir, char *fs_name, char *opts, mntfs *mf); -extern int process_last_regular_map(void); +extern int mount_nfs_fh(am_nfs_handle_t *fhp, char *mntdir, char *fs_name, mntfs *mf); +extern int process_all_regular_maps(void); +extern cf_map_t *find_cf_map(const char *name); extern int set_conf_kv(const char *section, const char *k, const char *v); -extern int try_mount(voidp mvp); +extern int mount_node(opaque_t arg); +extern int unmount_mp(am_node *mp); extern int yyparse (void); -extern nfsentry *make_entry_chain(am_node *mp, const nfsentry *current_chain, int fully_browsable); -extern void amfs_auto_cont(int rc, int term, voidp closure); -extern void amfs_auto_mkcacheref(mntfs *mf); -extern void amfs_auto_retry(int rc, int term, voidp closure); + +extern void amfs_mkcacheref(mntfs *mf); +extern int amfs_mount(am_node *mp, mntfs *mf, char *opts); extern void assign_error_mntfs(am_node *mp); -extern void flush_srvr_nfs_cache(void); -extern void free_continuation(struct continuation *cp); -extern void mf_mounted(mntfs *mf); -extern void quick_reply(am_node *mp, int error); +extern am_node *next_nonerror_node(am_node *xp); +extern void flush_srvr_nfs_cache(fserver *fs); +extern void am_mounted(am_node *); +extern void mf_mounted(mntfs *mf, bool_t call_free_opts); +extern void am_unmounted(am_node *); +extern am_node *get_exported_ap(int index); +extern am_node *get_first_exported_ap(int *index); +extern am_node *get_next_exported_ap(int *index); +extern am_node *path_to_exported_ap(char *path); +extern am_node *exported_ap_alloc(void); +extern am_node *find_mf(mntfs *); +extern am_node *next_map(int *); +extern am_ops *ops_match(am_opts *, char *, char *, char *, char *, char *); +extern am_ops *ops_search(char *); +extern fserver *dup_srvr(fserver *); +extern void srvrlog(fserver *, char *); +extern int get_mountd_port(fserver *, u_short *, wchan_t); +extern void flush_nfs_fhandle_cache(fserver *); + +extern mntfs *dup_mntfs(mntfs *); +extern mntfs *find_mntfs(am_ops *, am_opts *, char *, char *, char *, char *, char *); +extern mntfs *locate_mntfs(am_ops *, am_opts *, char *, char *, char *, char *, char *); +extern mntfs *new_mntfs(void); +extern mntfs *realloc_mntfs(mntfs *, am_ops *, am_opts *, char *, char *, char *, char *, char *); +extern void flush_mntfs(void); +extern void free_mntfs(voidp); + + +extern void amq_program_1(struct svc_req *rqstp, SVCXPRT *transp); +extern int background(void); +extern void deslashify(char *); +extern void do_task_notify(void); +extern int eval_fs_opts(am_opts *, char *, char *, char *, char *, char *); +extern void forcibly_timeout_mp(am_node *); +extern void free_map(am_node *); +extern void free_opts(am_opts *); +extern void free_srvr(fserver *); +extern int fwd_init(void); +extern int fwd_packet(int, char *, int, struct sockaddr_in *, struct sockaddr_in *, opaque_t, fwd_fun *); +extern void fwd_reply(void); +extern void get_args(int argc, char *argv[]); +extern wchan_t get_mntfs_wchan(mntfs *mf); +extern void host_normalize(char **); +extern void init_map(am_node *, char *); +extern void ins_que(qelem *, qelem *); +extern void insert_am(am_node *, am_node *); +extern int make_nfs_auth(void); +extern void make_root_node(void); +extern void map_flush_srvr(fserver *); +extern void mapc_add_kv(mnt_map *, char *, char *); +extern mnt_map *mapc_find(char *, char *, const char *); +extern void mapc_free(opaque_t); +extern int mapc_keyiter(mnt_map *, key_fun, opaque_t); +extern void mapc_reload(void); +extern int mapc_search(mnt_map *, char *, char **); +extern void mapc_showtypes(char *buf, size_t l); +extern int mapc_type_exists(const char *type); +extern void mk_fattr(nfsfattr *, nfsftype); +extern int mount_auto_node(char *, opaque_t); +extern int mount_automounter(int); +extern int mount_exported(void); +extern void mp_to_fh(am_node *, am_nfs_fh *); +extern void new_ttl(am_node *); +extern void nfs_quick_reply(am_node *mp, int error); +extern void normalize_slash(char *); +extern void ops_showamfstypes(char *buf, size_t l); +extern void ops_showfstypes(char *outbuf, size_t l); +extern void rem_que(qelem *); +extern void reschedule_timeout_mp(void); +extern void restart(void); +extern void restart_automounter_nodes(void); +extern int root_keyiter(key_fun *, opaque_t); extern void root_newmap(const char *, const char *, const char *, const cf_map_t *); +extern void run_task(task_fun *, opaque_t, cb_fun *, opaque_t); +extern void sched_task(cb_fun *, opaque_t, wchan_t); +extern int softclock(void); +extern int timeout(u_int, void (*fn)(opaque_t), opaque_t); +extern void timeout_mp(opaque_t); +extern void untimeout(int); +extern void umount_exported(void); +extern int valid_key(char *); +extern void wakeup(wchan_t); +extern void wakeup_srvr(fserver *); +extern void wakeup_task(int, int, wchan_t); +#define SIZEOF_PID_FSNAME (16 + MAXHOSTNAMELEN) +extern char pid_fsname[SIZEOF_PID_FSNAME]; /* "kiska.southseas.nz:(pid%d)" */ +#define SIZEOF_HOSTD (2 * MAXHOSTNAMELEN + 1) +extern char hostd[SIZEOF_HOSTD]; /* Host+domain */ +#define SIZEOF_OPTS 256 /* used for char opts[] and preopts[] */ -/* amd global variables */ +/* + * Global variables. + */ extern FILE *yyin; -extern SVCXPRT *nfs_program_2_transp; /* For quick_reply() */ +extern SVCXPRT *current_transp; /* For nfs_quick_reply() */ extern char *conf_tag; -extern char *opt_gid; -extern char *opt_uid; -extern int NumChild; +#define SIZEOF_UID_STR 12 +#define SIZEOF_GID_STR 12 +extern char *opt_gid, gid_str[SIZEOF_GID_STR]; +extern char *opt_uid, uid_str[SIZEOF_UID_STR]; +extern int NumChildren; extern int fwd_sock; extern int select_intr_valid; +extern int immediate_abort; /* Should close-down unmounts be retried */ extern int usage; extern int use_conf_file; /* use amd configuration file */ +extern int task_notify_todo; /* Task notifier needs running */ extern jmp_buf select_intr; extern qelem mfhead; -extern struct am_opts fs_static; /* copy of the options to play with */ extern struct amu_global_options gopt; /* where global options are stored */ +extern time_t do_mapc_reload; /* Flush & reload mount map cache */ +extern time_t next_softclock; /* Time to call softclock() */ #ifdef HAVE_SIGACTION extern sigset_t masked_sigs; @@ -274,16 +665,88 @@ extern sigset_t masked_sigs; #if defined(HAVE_AMU_FS_LINK) || defined(HAVE_AMU_FS_LINKX) extern char *amfs_link_match(am_opts *fo); -extern int amfs_link_fumount(mntfs *mf); #endif /* defined(HAVE_AMU_FS_LINK) || defined(HAVE_AMU_FS_LINKX) */ -#ifdef HAVE_AMU_FS_NFSL -extern char *nfs_match(am_opts *fo); -#endif /* HAVE_AMU_FS_NFSL */ +#ifdef HAVE_FS_AUTOFS +extern int amd_use_autofs; + +extern int autofs_get_fh(am_node *mp); +extern void autofs_release_fh(am_node *mp); +extern void autofs_get_mp(am_node *mp); +extern void autofs_release_mp(am_node *mp); +extern void autofs_add_fdset(fd_set *readfds); +extern int autofs_handle_fdset(fd_set *readfds, int nsel); +extern void autofs_mounted(am_node *mp); +extern void autofs_mount_succeeded(am_node *mp); +extern void autofs_mount_failed(am_node *mp); +extern int autofs_umount_succeeded(am_node *mp); +extern int autofs_umount_failed(am_node *mp); +extern int autofs_mount_fs(am_node *mp, mntfs *mf); +extern int autofs_umount_fs(am_node *mp, mntfs *mf); +extern void autofs_get_opts(char *opts, size_t l, autofs_fh_t *fh); +extern int autofs_compute_mount_flags(mntent_t *); +extern void autofs_timeout_mp(am_node *); +extern int create_autofs_service(void); +extern int destroy_autofs_service(void); +#endif /* HAVE_FS_AUTOFS */ + +/**************************************************************************/ +/*** Generic file-system types, implemented as part of the native O/S. ***/ +/**************************************************************************/ + +/* + * Loopback File System + * Many systems can't support this, and in any case most of the + * functionality is available with Symlink FS. + */ +#ifdef HAVE_FS_LOFS +extern am_ops lofs_ops; +extern int mount_lofs(char *mntdir, char *fs_name, char *opts, int on_autofs); +#endif /* HAVE_FS_LOFS */ -#if defined(HAVE_FS_NFS3) && !defined(HAVE_XDR_MOUNTRES3) -extern bool_t xdr_mountres3(XDR *xdrs, mountres3 *objp); -#endif /* defined(HAVE_FS_NFS3) && !defined(HAVE_XDR_MOUNTRES3) */ +/* + * CD-ROM File System (CD-ROM) + * (HSFS: High Sierra F/S on some machines) + * Many systems can't support this, and in any case most of the + * functionality is available with program FS. + */ +#ifdef HAVE_FS_CDFS +extern am_ops cdfs_ops; +#endif /* HAVE_FS_CDFS */ + +/* + * PC File System (MS-DOS) + * Many systems can't support this, and in any case most of the + * functionality is available with program FS. + */ +#ifdef HAVE_FS_PCFS +extern am_ops pcfs_ops; +#endif /* HAVE_FS_PCFS */ + +/* + * Caching File System (Solaris) + */ +#ifdef HAVE_FS_CACHEFS +extern am_ops cachefs_ops; +#endif /* HAVE_FS_CACHEFS */ + +/* + * Network File System + * Good, slow, NFS V.2. + */ +#ifdef HAVE_FS_NFS +extern am_ops nfs_ops; /* NFS */ +extern fserver *find_nfs_srvr (mntfs *); +extern qelem nfs_srvr_list; +#endif /* HAVE_FS_NFS */ + +/* + * Un*x File System + * Normal local disk file system. + */ +#ifdef HAVE_FS_UFS +extern am_ops ufs_ops; /* Un*x file system */ +#endif /* HAVE_FS_UFS */ /* Unix file system (irix) */ #ifdef HAVE_FS_XFS @@ -295,4 +758,110 @@ extern am_ops xfs_ops; /* Un*x file system */ extern am_ops efs_ops; /* Un*x file system */ #endif /* HAVE_FS_EFS */ +/**************************************************************************/ +/*** Automounter file-system types, implemented by amd. ***/ +/**************************************************************************/ + +/* + * Root AMD File System + */ +extern am_ops amfs_root_ops; /* Root file system */ + +/* + * Generic amfs helper methods + */ +extern am_node *amfs_generic_lookup_child(am_node *mp, char *fname, int *error_return, int op); +extern am_node *amfs_generic_mount_child(am_node *ap, int *error_return); +extern int amfs_generic_readdir(am_node *mp, nfscookie cookie, nfsdirlist *dp, nfsentry *ep, u_int count); +extern int amfs_generic_umount(am_node *mp, mntfs *mf); +extern void amfs_generic_mounted(mntfs *mf); +extern char *amfs_generic_match(am_opts *fo); +extern fserver *amfs_generic_find_srvr(mntfs *); + +/* + * Automount File System + */ +#ifdef HAVE_AMU_FS_AUTO +extern am_ops amfs_auto_ops; /* Automount file system (this!) */ +#endif /* HAVE_AMU_FS_AUTO */ + +/* + * Toplvl Automount File System + */ +#ifdef HAVE_AMU_FS_TOPLVL +extern am_ops amfs_toplvl_ops; /* Toplvl Automount file system */ +extern int amfs_toplvl_mount(am_node *mp, mntfs *mf); +extern int amfs_toplvl_umount(am_node *mp, mntfs *mf); +#endif /* HAVE_AMU_FS_TOPLVL */ + +/* + * Direct Automount File System + */ +#ifdef HAVE_AMU_FS_DIRECT +extern am_ops amfs_direct_ops; /* Direct Automount file system (this too) */ +#endif /* HAVE_AMU_FS_DIRECT */ + +/* + * Error File System + */ +#ifdef HAVE_AMU_FS_ERROR +extern am_ops amfs_error_ops; /* Error file system */ +extern am_node *amfs_error_lookup_child(am_node *mp, char *fname, int *error_return, int op); +extern am_node *amfs_error_mount_child(am_node *ap, int *error_return); +extern int amfs_error_readdir(am_node *mp, nfscookie cookie, nfsdirlist *dp, nfsentry *ep, u_int count); +#endif /* HAVE_AMU_FS_ERROR */ + +/* + * NFS mounts with local existence check. + */ +#ifdef HAVE_AMU_FS_NFSL +extern am_ops amfs_nfsl_ops; /* NFSL */ +#endif /* HAVE_AMU_FS_NFSL */ + +/* + * Multi-nfs mounts. + */ +#ifdef HAVE_AMU_FS_NFSX +extern am_ops amfs_nfsx_ops; /* NFSX */ +#endif /* HAVE_AMU_FS_NFSX */ + +/* + * NFS host - a whole tree. + */ +#ifdef HAVE_AMU_FS_HOST +extern am_ops amfs_host_ops; /* NFS host */ +#endif /* HAVE_AMU_FS_HOST */ + +/* + * Program File System + * This is useful for things like RVD. + */ +#ifdef HAVE_AMU_FS_PROGRAM +extern am_ops amfs_program_ops; /* Program File System */ +#endif /* HAVE_AMU_FS_PROGRAM */ + +/* + * Symbolic-link file system. + * A "filesystem" which is just a symbol link. + */ +#ifdef HAVE_AMU_FS_LINK +extern am_ops amfs_link_ops; /* Symlink FS */ +#endif /* HAVE_AMU_FS_LINK */ + +/* + * Symbolic-link file system, which also checks that the target of + * the symlink exists. + * A "filesystem" which is just a symbol link. + */ +#ifdef HAVE_AMU_FS_LINKX +extern am_ops amfs_linkx_ops; /* Symlink FS with existence check */ +#endif /* HAVE_AMU_FS_LINKX */ + +/* + * Union file system + */ +#ifdef HAVE_AMU_FS_UNION +extern am_ops amfs_union_ops; /* Union FS */ +#endif /* HAVE_AMU_FS_UNION */ + #endif /* not _AMD_H */ diff --git a/contrib/amd/amd/amfs_auto.c b/contrib/amd/amd/amfs_auto.c index ad0539309a79..75a451fd111d 100644 --- a/contrib/amd/amd/amfs_auto.c +++ b/contrib/amd/amd/amfs_auto.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: amfs_auto.c,v 1.9.2.12 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/amfs_auto.c * */ @@ -55,9 +54,7 @@ /**************************************************************************** *** MACROS *** ****************************************************************************/ -#define IN_PROGRESS(cp) ((cp)->mp->am_mnt->mf_flags & MFF_MOUNTING) -#define DOT_DOT_COOKIE (u_int) 1 /**************************************************************************** *** STRUCTURES *** @@ -67,10 +64,7 @@ /**************************************************************************** *** FORWARD DEFINITIONS *** ****************************************************************************/ -static int amfs_auto_bgmount(struct continuation *cp, int mpe); -static int amfs_auto_mount(am_node *mp); -static int amfs_auto_readdir_browsable(am_node *mp, nfscookie cookie, nfsdirlist *dp, nfsentry *ep, int count, int fully_browsable); -static void amfs_auto_umounted(am_node *mp); +static int amfs_auto_mount(am_node *mp, mntfs *mf); /**************************************************************************** @@ -79,19 +73,22 @@ static void amfs_auto_umounted(am_node *mp); am_ops amfs_auto_ops = { "auto", - amfs_auto_match, + amfs_generic_match, 0, /* amfs_auto_init */ amfs_auto_mount, - 0, - amfs_auto_umount, - 0, - amfs_auto_lookuppn, - amfs_auto_readdir, + amfs_generic_umount, + amfs_generic_lookup_child, + amfs_generic_mount_child, + amfs_generic_readdir, 0, /* amfs_auto_readlink */ - 0, /* amfs_auto_mounted */ - amfs_auto_umounted, - find_amfs_auto_srvr, - FS_AMQINFO | FS_DIRECTORY + amfs_generic_mounted, + 0, /* amfs_auto_umounted */ + amfs_generic_find_srvr, + 0, /* amfs_auto_get_wchan */ + FS_AMQINFO | FS_DIRECTORY, +#ifdef HAVE_FS_AUTOFS + AUTOFS_AUTO_FS_FLAGS, +#endif /* HAVE_FS_AUTOFS */ }; @@ -99,65 +96,11 @@ am_ops amfs_auto_ops = *** FUNCTIONS *** ****************************************************************************/ /* - * AMFS_AUTO needs nothing in particular. - */ -char * -amfs_auto_match(am_opts *fo) -{ - char *p = fo->opt_rfs; - - if (!fo->opt_rfs) { - plog(XLOG_USER, "auto: no mount point named (rfs:=)"); - return 0; - } - if (!fo->opt_fs) { - plog(XLOG_USER, "auto: no map named (fs:=)"); - return 0; - } - - /* - * Swap round fs:= and rfs:= options - * ... historical (jsp) - */ - fo->opt_rfs = fo->opt_fs; - fo->opt_fs = p; - - /* - * mtab entry turns out to be the name of the mount map - */ - return strdup(fo->opt_rfs ? fo->opt_rfs : "."); -} - - - - -/* - * Build a new map cache for this node, or re-use - * an existing cache for the same map. - */ -void -amfs_auto_mkcacheref(mntfs *mf) -{ - char *cache; - - if (mf->mf_fo && mf->mf_fo->opt_cache) - cache = mf->mf_fo->opt_cache; - else - cache = "none"; - mf->mf_private = (voidp) mapc_find(mf->mf_info, cache, - mf->mf_fo->opt_maptype); - mf->mf_prfree = mapc_free; -} - - -/* * Mount a sub-mount */ static int -amfs_auto_mount(am_node *mp) +amfs_auto_mount(am_node *mp, mntfs *mf) { - mntfs *mf = mp->am_mnt; - /* * Pseudo-directories are used to provide some structure * to the automounted directories instead @@ -207,1432 +150,27 @@ amfs_auto_mount(am_node *mp) mp->am_pref = str3cat((char *) 0, ppref, mp->am_name, "/"); } - /* - * Attach a map cache - */ - amfs_auto_mkcacheref(mf); - - return 0; -} - - - - -/* - * Unmount an automount sub-node - */ -int -amfs_auto_umount(am_node *mp) -{ - return 0; -} - - -/* - * Unmount an automount node - */ -static void -amfs_auto_umounted(am_node *mp) -{ - /* - * If this is a pseudo-directory then just adjust the link count - * in the parent, otherwise call the generic unmount routine - */ - if (mp->am_parent && mp->am_parent->am_parent) - --mp->am_parent->am_fattr.na_nlink; -} - - -/* - * Discard an old continuation - */ -void -free_continuation(struct continuation *cp) -{ - if (cp->callout) - untimeout(cp->callout); - XFREE(cp->key); - XFREE(cp->xivec); - XFREE(cp->info); - XFREE(cp->auto_opts); - XFREE(cp->def_opts); - free_opts(&cp->fs_opts); - XFREE(cp); -} +#ifdef HAVE_FS_AUTOFS + if (mf->mf_flags & MFF_IS_AUTOFS) { + char opts[SIZEOF_OPTS]; + int error; + autofs_get_opts(opts, sizeof(opts), mp->am_autofs_fh); -/* - * Discard the underlying mount point and replace - * with a reference to an error filesystem. - */ -void -assign_error_mntfs(am_node *mp) -{ - if (mp->am_error > 0) { - /* - * Save the old error code - */ - int error = mp->am_error; - if (error <= 0) - error = mp->am_mnt->mf_error; - /* - * Discard the old filesystem - */ - free_mntfs(mp->am_mnt); - /* - * Allocate a new error reference - */ - mp->am_mnt = new_mntfs(); - /* - * Put back the error code - */ - mp->am_mnt->mf_error = error; - mp->am_mnt->mf_flags |= MFF_ERROR; - /* - * Zero the error in the mount point - */ - mp->am_error = 0; - } -} - - -/* - * The continuation function. This is called by - * the task notifier when a background mount attempt - * completes. - */ -void -amfs_auto_cont(int rc, int term, voidp closure) -{ - struct continuation *cp = (struct continuation *) closure; - mntfs *mf = cp->mp->am_mnt; - - /* - * Definitely not trying to mount at the moment - */ - mf->mf_flags &= ~MFF_MOUNTING; - - /* - * While we are mounting - try to avoid race conditions - */ - new_ttl(cp->mp); - - /* - * Wakeup anything waiting for this mount - */ - wakeup((voidp) mf); - - /* - * Check for termination signal or exit status... - */ - if (rc || term) { - am_node *xmp; - - if (term) { - /* - * Not sure what to do for an error code. - */ - mf->mf_error = EIO; /* XXX ? */ - mf->mf_flags |= MFF_ERROR; - plog(XLOG_ERROR, "mount for %s got signal %d", cp->mp->am_path, term); - } else { - /* - * Check for exit status... - */ - mf->mf_error = rc; - mf->mf_flags |= MFF_ERROR; - errno = rc; /* XXX */ - if (!STREQ(cp->mp->am_mnt->mf_ops->fs_type, "linkx")) - plog(XLOG_ERROR, "%s: mount (amfs_auto_cont): %m", cp->mp->am_path); + /* now do the mount */ + error = amfs_mount(mp, mf, opts); + if (error) { + errno = error; + plog(XLOG_FATAL, "amfs_auto_mount: amfs_mount failed: %m"); + return error; } - - /* - * If we get here then that attempt didn't work, so - * move the info vector pointer along by one and - * call the background mount routine again - */ - amd_stats.d_merr++; - cp->ivec++; - xmp = cp->mp; - (void) amfs_auto_bgmount(cp, 0); - assign_error_mntfs(xmp); - } else { - /* - * The mount worked. - */ - am_mounted(cp->mp); - free_continuation(cp); - } - - reschedule_timeout_mp(); -} - - -/* - * Retry a mount - */ -void -amfs_auto_retry(int rc, int term, voidp closure) -{ - struct continuation *cp = (struct continuation *) closure; - int error = 0; - -#ifdef DEBUG - dlog("Commencing retry for mount of %s", cp->mp->am_path); -#endif /* DEBUG */ - - new_ttl(cp->mp); - - if ((cp->start + ALLOWED_MOUNT_TIME) < clocktime()) { - /* - * The entire mount has timed out. Set the error code and skip past all - * the info vectors so that amfs_auto_bgmount will not have any more - * ways to try the mount, so causing an error. - */ - plog(XLOG_INFO, "mount of \"%s\" has timed out", cp->mp->am_path); - error = ETIMEDOUT; - while (*cp->ivec) - cp->ivec++; - /* explicitly forbid further retries after timeout */ - cp->retry = FALSE; - } - if (error || !IN_PROGRESS(cp)) { - (void) amfs_auto_bgmount(cp, error); - } - reschedule_timeout_mp(); -} - - -/* - * Try to mount a file system. Can be called - * directly or in a sub-process by run_task. - */ -int -try_mount(voidp mvp) -{ - int error = 0; - am_node *mp = (am_node *) mvp; - mntfs *mf = mp->am_mnt; - - /* - * If the directory is not yet made and it needs to be made, then make it! - * This may be run in a background process in which case the flag setting - * won't be noticed later - but it is set anyway just after run_task is - * called. It should probably go away totally... - */ - if (!(mf->mf_flags & MFF_MKMNT) && mf->mf_ops->fs_flags & FS_MKMNT) { - error = mkdirs(mf->mf_mount, 0555); - if (!error) - mf->mf_flags |= MFF_MKMNT; - } - - /* - * Mount it! - */ - error = mount_node(mp); - -#ifdef DEBUG - if (error > 0) { - errno = error; - dlog("amfs_auto: call to mount_node(%s) failed: %m", mp->am_path); - } -#endif /* DEBUG */ - - return error; -} - - -/* - * Pick a file system to try mounting and - * do that in the background if necessary - * -For each location: - if it is new -defaults then - extract and process - continue; - fi - if it is a cut then - if a location has been tried then - break; - fi - continue; - fi - parse mount location - discard previous mount location if required - find matching mounted filesystem - if not applicable then - this_error = No such file or directory - continue - fi - if the filesystem failed to be mounted then - this_error = error from filesystem - elif the filesystem is mounting or unmounting then - this_error = -1 - elif the fileserver is down then - this_error = -1 - elif the filesystem is already mounted - this_error = 0 - break - fi - if no error on this mount then - this_error = initialize mount point - fi - if no error on this mount and mount is delayed then - this_error = -1 - fi - if this_error < 0 then - retry = true - fi - if no error on this mount then - make mount point if required - fi - if no error on this mount then - if mount in background then - run mount in background - return -1 - else - this_error = mount in foreground - fi - fi - if an error occurred on this mount then - update stats - save error in mount point - fi -endfor - */ -static int -amfs_auto_bgmount(struct continuation *cp, int mpe) -{ - mntfs *mf = cp->mp->am_mnt; /* Current mntfs */ - mntfs *mf_retry = 0; /* First mntfs which needed retrying */ - int this_error = -1; /* Per-mount error */ - int hard_error = -1; - int mp_error = mpe; - - /* - * Try to mount each location. - * At the end: - * hard_error == 0 indicates something was mounted. - * hard_error > 0 indicates everything failed with a hard error - * hard_error < 0 indicates nothing could be mounted now - */ - for (; this_error && *cp->ivec; cp->ivec++) { - am_ops *p; - am_node *mp = cp->mp; - char *link_dir; - int dont_retry; - - if (hard_error < 0) - hard_error = this_error; - - this_error = -1; - - if (**cp->ivec == '-') { - /* - * Pick up new defaults - */ - if (cp->auto_opts && *cp->auto_opts) - cp->def_opts = str3cat(cp->def_opts, cp->auto_opts, ";", *cp->ivec + 1); - else - cp->def_opts = strealloc(cp->def_opts, *cp->ivec + 1); -#ifdef DEBUG - dlog("Setting def_opts to \"%s\"", cp->def_opts); -#endif /* DEBUG */ - continue; - } - /* - * If a mount has been attempted, and we find - * a cut then don't try any more locations. - */ - if (STREQ(*cp->ivec, "/") || STREQ(*cp->ivec, "||")) { - if (cp->tried) { -#ifdef DEBUG - dlog("Cut: not trying any more locations for %s", - mp->am_path); -#endif /* DEBUG */ - break; - } - continue; - } - - /* match the operators */ - p = ops_match(&cp->fs_opts, *cp->ivec, cp->def_opts, mp->am_path, cp->key, mp->am_parent->am_mnt->mf_info); - - /* - * Find a mounted filesystem for this node. - */ - mp->am_mnt = mf = realloc_mntfs(mf, p, &cp->fs_opts, - cp->fs_opts.opt_fs, - cp->fs_opts.fs_mtab, - cp->auto_opts, - cp->fs_opts.opt_opts, - cp->fs_opts.opt_remopts); - - p = mf->mf_ops; -#ifdef DEBUG - dlog("Got a hit with %s", p->fs_type); -#endif /* DEBUG */ - - /* - * Note whether this is a real mount attempt - */ - if (p == &amfs_error_ops) { - plog(XLOG_MAP, "Map entry %s for %s did not match", *cp->ivec, mp->am_path); - if (this_error <= 0) - this_error = ENOENT; - continue; - } else { - if (cp->fs_opts.fs_mtab) { - plog(XLOG_MAP, "Trying mount of %s on %s fstype %s", - cp->fs_opts.fs_mtab, mp->am_path, p->fs_type); - } - cp->tried = TRUE; - } - - this_error = 0; - dont_retry = FALSE; - - if (mp->am_link) { - XFREE(mp->am_link); - mp->am_link = 0; - } - link_dir = mf->mf_fo->opt_sublink; - - if (link_dir && *link_dir) { - if (*link_dir == '/') { - mp->am_link = strdup(link_dir); - } else { - /* - * Try getting fs option from continuation, not mountpoint! - * Don't try logging the string from mf, since it may be bad! - */ - if (cp->fs_opts.opt_fs != mf->mf_fo->opt_fs) - plog(XLOG_ERROR, "use %s instead of 0x%lx", - cp->fs_opts.opt_fs, (unsigned long) mf->mf_fo->opt_fs); - - mp->am_link = str3cat((char *) 0, - cp->fs_opts.opt_fs, "/", link_dir); - - normalize_slash(mp->am_link); - } - } - - if (mf->mf_error > 0) { - this_error = mf->mf_error; - } else if (mf->mf_flags & (MFF_MOUNTING | MFF_UNMOUNTING)) { - /* - * Still mounting - retry later - */ -#ifdef DEBUG - dlog("Duplicate pending mount fstype %s", p->fs_type); -#endif /* DEBUG */ - this_error = -1; - } else if (FSRV_ISDOWN(mf->mf_server)) { - /* - * Would just mount from the same place - * as a hung mount - so give up - */ -#ifdef DEBUG - dlog("%s is already hung - giving up", mf->mf_mount); -#endif /* DEBUG */ - mp_error = EWOULDBLOCK; - dont_retry = TRUE; - this_error = -1; - } else if (mf->mf_flags & MFF_MOUNTED) { -#ifdef DEBUG - dlog("duplicate mount of \"%s\" ...", mf->mf_info); -#endif /* DEBUG */ - - /* - * Just call mounted() - */ - am_mounted(mp); - - this_error = 0; - break; - } - - /* - * Will usually need to play around with the mount nodes - * file attribute structure. This must be done here. - * Try and get things initialized, even if the fileserver - * is not known to be up. In the common case this will - * progress things faster. - */ - if (!this_error) { - /* - * Fill in attribute fields. - */ - if (mf->mf_ops->fs_flags & FS_DIRECTORY) - mk_fattr(mp, NFDIR); - else - mk_fattr(mp, NFLNK); - - if (p->fs_init) - this_error = (*p->fs_init) (mf); - } - - /* - * Make sure the fileserver is UP before doing any more work - */ - if (!FSRV_ISUP(mf->mf_server)) { -#ifdef DEBUG - dlog("waiting for server %s to become available", mf->mf_server->fs_host); -#endif /* DEBUG */ - this_error = -1; - } - - if (!this_error && mf->mf_fo->opt_delay) { - /* - * If there is a delay timer on the mount - * then don't try to mount if the timer - * has not expired. - */ - int i = atoi(mf->mf_fo->opt_delay); - if (i > 0 && clocktime() < (cp->start + i)) { -#ifdef DEBUG - dlog("Mount of %s delayed by %lds", mf->mf_mount, (long) (i - clocktime() + cp->start)); -#endif /* DEBUG */ - this_error = -1; - } - } - - if (this_error < 0 && !dont_retry) { - if (!mf_retry) - mf_retry = dup_mntfs(mf); - cp->retry = TRUE; -#ifdef DEBUG - dlog("will retry ...\n"); -#endif /* DEBUG */ - break; - } - - if (!this_error) { - if (p->fs_flags & FS_MBACKGROUND) { - mf->mf_flags |= MFF_MOUNTING; /* XXX */ -#ifdef DEBUG - dlog("backgrounding mount of \"%s\"", mf->mf_mount); -#endif /* DEBUG */ - if (cp->callout) { - untimeout(cp->callout); - cp->callout = 0; - } - - /* actually run the task, backgrounding as necessary */ - run_task(try_mount, (voidp) mp, amfs_auto_cont, (voidp) cp); - - mf->mf_flags |= MFF_MKMNT; /* XXX */ - if (mf_retry) - free_mntfs(mf_retry); - return -1; - } else { -#ifdef DEBUG - dlog("foreground mount of \"%s\" ...", mf->mf_info); -#endif /* DEBUG */ - this_error = try_mount((voidp) mp); - if (this_error < 0) { - if (!mf_retry) - mf_retry = dup_mntfs(mf); - cp->retry = TRUE; - } - } - } - - if (this_error >= 0) { - if (this_error > 0) { - amd_stats.d_merr++; - if (mf != mf_retry) { - mf->mf_error = this_error; - mf->mf_flags |= MFF_ERROR; - } - } - - /* - * Wakeup anything waiting for this mount - */ - wakeup((voidp) mf); - } - } - - if (this_error && cp->retry) { - free_mntfs(mf); - mf = cp->mp->am_mnt = mf_retry; - /* - * Not retrying again (so far) - */ - cp->retry = FALSE; - cp->tried = FALSE; - /* - * Start at the beginning. - * Rewind the location vector and - * reset the default options. - */ -#ifdef DEBUG - dlog("(skipping rewind)\n"); -#endif /* DEBUG */ - /* - * Arrange that amfs_auto_bgmount is called - * after anything else happens. - */ -#ifdef DEBUG - dlog("Arranging to retry mount of %s", cp->mp->am_path); -#endif /* DEBUG */ - sched_task(amfs_auto_retry, (voidp) cp, (voidp) mf); - if (cp->callout) - untimeout(cp->callout); - cp->callout = timeout(RETRY_INTERVAL, wakeup, (voidp) mf); - - cp->mp->am_ttl = clocktime() + RETRY_INTERVAL; - - /* - * Not done yet - so don't return anything - */ - return -1; - } - - if (hard_error < 0 || this_error == 0) - hard_error = this_error; - - /* - * Discard handle on duff filesystem. - * This should never happen since it - * should be caught by the case above. - */ - if (mf_retry) { - if (hard_error) - plog(XLOG_ERROR, "discarding a retry mntfs for %s", mf_retry->mf_mount); - free_mntfs(mf_retry); } +#endif /* HAVE_FS_AUTOFS */ /* - * If we get here, then either the mount succeeded or - * there is no more mount information available. - */ - if (hard_error < 0 && mp_error) - hard_error = cp->mp->am_error = mp_error; - if (hard_error > 0) { - /* - * Set a small(ish) timeout on an error node if - * the error was not a time out. - */ - switch (hard_error) { - case ETIMEDOUT: - case EWOULDBLOCK: - cp->mp->am_timeo = 17; - break; - default: - cp->mp->am_timeo = 5; - break; - } - new_ttl(cp->mp); - } - - /* - * Make sure that the error value in the mntfs has a - * reasonable value. - */ - if (mf->mf_error < 0) { - mf->mf_error = hard_error; - if (hard_error) - mf->mf_flags |= MFF_ERROR; - } - - /* - * In any case we don't need the continuation any more - */ - free_continuation(cp); - - return hard_error; -} - - -/* - * Automount interface to RPC lookup routine - * Find the corresponding entry and return - * the file handle for it. - */ -am_node * -amfs_auto_lookuppn(am_node *mp, char *fname, int *error_return, int op) -{ - am_node *ap, *new_mp, *ap_hung; - char *info; /* Mount info - where to get the file system */ - char **ivec, **xivec; /* Split version of info */ - char *auto_opts; /* Automount options */ - int error = 0; /* Error so far */ - char path_name[MAXPATHLEN]; /* General path name buffer */ - char *pfname; /* Path for database lookup */ - struct continuation *cp; /* Continuation structure if need to mount */ - int in_progress = 0; /* # of (un)mount in progress */ - char *dflts; - mntfs *mf; - -#ifdef DEBUG - dlog("in amfs_auto_lookuppn"); -#endif /* DEBUG */ - - /* - * If the server is shutting down - * then don't return information - * about the mount point. - */ - if (amd_state == Finishing) { -#ifdef DEBUG - if ((mf = mp->am_mnt) == 0 || mf->mf_ops == &amfs_direct_ops) { - dlog("%s mount ignored - going down", fname); - } else { - dlog("%s/%s mount ignored - going down", mp->am_path, fname); - } -#endif /* DEBUG */ - ereturn(ENOENT); - } - - /* - * Handle special case of "." and ".." - */ - if (fname[0] == '.') { - if (fname[1] == '\0') - return mp; /* "." is the current node */ - if (fname[1] == '.' && fname[2] == '\0') { - if (mp->am_parent) { -#ifdef DEBUG - dlog(".. in %s gives %s", mp->am_path, mp->am_parent->am_path); -#endif /* DEBUG */ - return mp->am_parent; /* ".." is the parent node */ - } - ereturn(ESTALE); - } - } - - /* - * Check for valid key name. - * If it is invalid then pretend it doesn't exist. - */ - if (!valid_key(fname)) { - plog(XLOG_WARNING, "Key \"%s\" contains a disallowed character", fname); - ereturn(ENOENT); - } - - /* - * Expand key name. - * fname is now a private copy. - */ - fname = expand_key(fname); - - for (ap_hung = 0, ap = mp->am_child; ap; ap = ap->am_osib) { - /* - * Otherwise search children of this node - */ - if (FSTREQ(ap->am_name, fname)) { - mf = ap->am_mnt; - if (ap->am_error) { - error = ap->am_error; - continue; - } - /* - * If the error code is undefined then it must be - * in progress. - */ - if (mf->mf_error < 0) - goto in_progrss; - - /* - * Check for a hung node - */ - if (FSRV_ISDOWN(mf->mf_server)) { -#ifdef DEBUG - dlog("server hung"); -#endif /* DEBUG */ - error = ap->am_error; - ap_hung = ap; - continue; - } - /* - * If there was a previous error with this node - * then return that error code. - */ - if (mf->mf_flags & MFF_ERROR) { - error = mf->mf_error; - continue; - } - if (!(mf->mf_flags & MFF_MOUNTED) || (mf->mf_flags & MFF_UNMOUNTING)) { - in_progrss: - /* - * If the fs is not mounted or it is unmounting then there - * is a background (un)mount in progress. In this case - * we just drop the RPC request (return nil) and - * wait for a retry, by which time the (un)mount may - * have completed. - */ -#ifdef DEBUG - dlog("ignoring mount of %s in %s -- flags (%x) in progress", - fname, mf->mf_mount, mf->mf_flags); -#endif /* DEBUG */ - in_progress++; - continue; - } - - /* - * Otherwise we have a hit: return the current mount point. - */ -#ifdef DEBUG - dlog("matched %s in %s", fname, ap->am_path); -#endif /* DEBUG */ - XFREE(fname); - return ap; - } - } - - if (in_progress) { -#ifdef DEBUG - dlog("Waiting while %d mount(s) in progress", in_progress); -#endif /* DEBUG */ - XFREE(fname); - ereturn(-1); - } - - /* - * If an error occurred then return it. - */ - if (error) { -#ifdef DEBUG - errno = error; /* XXX */ - dlog("Returning error: %m"); -#endif /* DEBUG */ - XFREE(fname); - ereturn(error); - } - - /* - * If doing a delete then don't create again! - */ - switch (op) { - case VLOOK_DELETE: - ereturn(ENOENT); - - case VLOOK_CREATE: - break; - - default: - plog(XLOG_FATAL, "Unknown op to amfs_auto_lookuppn: 0x%x", op); - ereturn(EINVAL); - } - - /* - * If the server is going down then just return, - * don't try to mount any more file systems - */ - if ((int) amd_state >= (int) Finishing) { -#ifdef DEBUG - dlog("not found - server going down anyway"); -#endif /* DEBUG */ - XFREE(fname); - ereturn(ENOENT); - } - - /* - * If we get there then this is a reference to an, - * as yet, unknown name so we need to search the mount - * map for it. - */ - if (mp->am_pref) { - sprintf(path_name, "%s%s", mp->am_pref, fname); - pfname = path_name; - } else { - pfname = fname; - } - - mf = mp->am_mnt; - -#ifdef DEBUG - dlog("will search map info in %s to find %s", mf->mf_info, pfname); -#endif /* DEBUG */ - /* - * Consult the oracle for some mount information. - * info is malloc'ed and belongs to this routine. - * It ends up being free'd in free_continuation(). - * - * Note that this may return -1 indicating that information - * is not yet available. - */ - error = mapc_search((mnt_map *) mf->mf_private, pfname, &info); - if (error) { - if (error > 0) - plog(XLOG_MAP, "No map entry for %s", pfname); - else - plog(XLOG_MAP, "Waiting on map entry for %s", pfname); - XFREE(fname); - ereturn(error); - } -#ifdef DEBUG - dlog("mount info is %s", info); -#endif /* DEBUG */ - - /* - * Split info into an argument vector. - * The vector is malloc'ed and belongs to - * this routine. It is free'd in free_continuation() - */ - xivec = ivec = strsplit(info, ' ', '\"'); - - /* - * Default error code... - */ - if (ap_hung) - error = EWOULDBLOCK; - else - error = ENOENT; - - /* - * Allocate a new map - */ - new_mp = exported_ap_alloc(); - if (new_mp == 0) { - XFREE(xivec); - XFREE(info); - XFREE(fname); - ereturn(ENOSPC); - } - if (mf->mf_auto) - auto_opts = mf->mf_auto; - else - auto_opts = ""; - - auto_opts = strdup(auto_opts); - -#ifdef DEBUG - dlog("searching for /defaults entry"); -#endif /* DEBUG */ - if (mapc_search((mnt_map *) mf->mf_private, "/defaults", &dflts) == 0) { - char *dfl; - char **rvec; -#ifdef DEBUG - dlog("/defaults gave %s", dflts); -#endif /* DEBUG */ - if (*dflts == '-') - dfl = dflts + 1; - else - dfl = dflts; - - /* - * Chop the defaults up - */ - rvec = strsplit(dfl, ' ', '\"'); - - if (gopt.flags & CFM_SELECTORS_IN_DEFAULTS) { - /* - * Pick whichever first entry matched the list of selectors. - * Strip the selectors from the string, and assign to dfl the - * rest of the string. - */ - if (rvec) { - am_opts ap; - am_ops *pt; - char **sp = rvec; - while (*sp) { /* loop until you find something, if any */ - memset((char *) &ap, 0, sizeof(am_opts)); - /* - * This next routine cause many spurious "expansion of ... is" - * messages, which are ignored, b/c all we need out of this - * routine is to match selectors. These spurious messages may - * be wrong, esp. if they try to expand ${key} b/c it will - * get expanded to "/defaults" - */ - pt = ops_match(&ap, *sp, "", mp->am_path, "/defaults", - mp->am_parent->am_mnt->mf_info); - free_opts(&ap); /* don't leak */ - if (pt == &amfs_error_ops) { - plog(XLOG_MAP, "did not match defaults for \"%s\"", *sp); - } else { - dfl = strip_selectors(*sp, "/defaults"); - plog(XLOG_MAP, "matched default selectors \"%s\"", dfl); - break; - } - ++sp; - } - } - } else { /* not enable_default_selectors */ - /* - * Extract first value - */ - dfl = rvec[0]; - } - - /* - * If there were any values at all... - */ - if (dfl) { - /* - * Log error if there were other values - */ - if (!(gopt.flags & CFM_SELECTORS_IN_DEFAULTS) && rvec[1]) { -# ifdef DEBUG - dlog("/defaults chopped into %s", dfl); -# endif /* DEBUG */ - plog(XLOG_USER, "More than a single value for /defaults in %s", mf->mf_info); - } - - /* - * Prepend to existing defaults if they exist, - * otherwise just use these defaults. - */ - if (*auto_opts && *dfl) { - char *nopts = (char *) xmalloc(strlen(auto_opts) + strlen(dfl) + 2); - sprintf(nopts, "%s;%s", dfl, auto_opts); - XFREE(auto_opts); - auto_opts = nopts; - } else if (*dfl) { - auto_opts = strealloc(auto_opts, dfl); - } - } - XFREE(dflts); - /* - * Don't need info vector any more - */ - XFREE(rvec); - } - - /* - * Fill it in - */ - init_map(new_mp, fname); - - /* - * Put it in the table - */ - insert_am(new_mp, mp); - - /* - * Fill in some other fields, - * path and mount point. - * - * bugfix: do not prepend old am_path if direct map - * <wls@astro.umd.edu> William Sebok - */ - new_mp->am_path = str3cat(new_mp->am_path, - mf->mf_ops == &amfs_direct_ops ? "" : mp->am_path, - *fname == '/' ? "" : "/", fname); - -#ifdef DEBUG - dlog("setting path to %s", new_mp->am_path); -#endif /* DEBUG */ - - /* - * Take private copy of pfname - */ - pfname = strdup(pfname); - - /* - * Construct a continuation - */ - cp = ALLOC(struct continuation); - cp->callout = 0; - cp->mp = new_mp; - cp->xivec = xivec; - cp->ivec = ivec; - cp->info = info; - cp->key = pfname; - cp->auto_opts = auto_opts; - cp->retry = FALSE; - cp->tried = FALSE; - cp->start = clocktime(); - cp->def_opts = strdup(auto_opts); - memset((voidp) &cp->fs_opts, 0, sizeof(cp->fs_opts)); - - /* - * Try and mount the file system. If this succeeds immediately (possible - * for a ufs file system) then return the attributes, otherwise just - * return an error. - */ - error = amfs_auto_bgmount(cp, error); - reschedule_timeout_mp(); - if (!error) { - XFREE(fname); - return new_mp; - } - - /* - * Code for quick reply. If nfs_program_2_transp is set, then - * its the transp that's been passed down from nfs_program_2(). - * If new_mp->am_transp is not already set, set it by copying in - * nfs_program_2_transp. Once am_transp is set, quick_reply() can - * use it to send a reply to the client that requested this mount. - */ - if (nfs_program_2_transp && !new_mp->am_transp) { - new_mp->am_transp = (SVCXPRT *) xmalloc(sizeof(SVCXPRT)); - *(new_mp->am_transp) = *nfs_program_2_transp; - } - if (error && (new_mp->am_mnt->mf_ops == &amfs_error_ops)) - new_mp->am_error = error; - - assign_error_mntfs(new_mp); - - XFREE(fname); - - ereturn(error); -} - - -/* - * Locate next node in sibling list which is mounted - * and is not an error node. - */ -am_node * -next_nonerror_node(am_node *xp) -{ - mntfs *mf; - - /* - * Bug report (7/12/89) from Rein Tollevik <rein@ifi.uio.no> - * Fixes a race condition when mounting direct automounts. - * Also fixes a problem when doing a readdir on a directory - * containing hung automounts. - */ - while (xp && - (!(mf = xp->am_mnt) || /* No mounted filesystem */ - mf->mf_error != 0 || /* There was a mntfs error */ - xp->am_error != 0 || /* There was a mount error */ - !(mf->mf_flags & MFF_MOUNTED) || /* The fs is not mounted */ - (mf->mf_server->fs_flags & FSF_DOWN)) /* The fs may be down */ - ) - xp = xp->am_osib; - - return xp; -} - - -/* - * This readdir function which call a special version of it that allows - * browsing if browsable_dirs=yes was set on the map. - */ -int -amfs_auto_readdir(am_node *mp, nfscookie cookie, nfsdirlist *dp, nfsentry *ep, int count) -{ - u_int gen = *(u_int *) cookie; - am_node *xp; - mntent_t mnt; -#ifdef DEBUG - nfsentry *ne; - static int j; -#endif /* DEBUG */ - - dp->dl_eof = FALSE; /* assume readdir not done */ - - /* check if map is browsable */ - if (mp->am_mnt && mp->am_mnt->mf_mopts) { - mnt.mnt_opts = mp->am_mnt->mf_mopts; - if (hasmntopt(&mnt, "fullybrowsable")) - return amfs_auto_readdir_browsable(mp, cookie, dp, ep, count, TRUE); - if (hasmntopt(&mnt, "browsable")) - return amfs_auto_readdir_browsable(mp, cookie, dp, ep, count, FALSE); - } - - /* when gen is 0, we start reading from the beginning of the directory */ - if (gen == 0) { - /* - * In the default instance (which is used to start a search) we return - * "." and "..". - * - * This assumes that the count is big enough to allow both "." and ".." - * to be returned in a single packet. If it isn't (which would be - * fairly unbelievable) then tough. - */ -#ifdef DEBUG - dlog("amfs_auto_readdir: default search"); -#endif /* DEBUG */ - /* - * Check for enough room. This is extremely approximate but is more - * than enough space. Really need 2 times: - * 4byte fileid - * 4byte cookie - * 4byte name length - * 4byte name - * plus the dirlist structure */ - if (count < (2 * (2 * (sizeof(*ep) + sizeof("..") + 4) + sizeof(*dp)))) - return EINVAL; - - xp = next_nonerror_node(mp->am_child); - dp->dl_entries = ep; - - /* construct "." */ - ep[0].ne_fileid = mp->am_gen; - ep[0].ne_name = "."; - ep[0].ne_nextentry = &ep[1]; - *(u_int *) ep[0].ne_cookie = 0; - - /* construct ".." */ - if (mp->am_parent) - ep[1].ne_fileid = mp->am_parent->am_gen; - else - ep[1].ne_fileid = mp->am_gen; - ep[1].ne_name = ".."; - ep[1].ne_nextentry = 0; - *(u_int *) ep[1].ne_cookie = (xp ? xp->am_gen : DOT_DOT_COOKIE); - - if (!xp) - dp->dl_eof = TRUE; /* by default assume readdir done */ - -#ifdef DEBUG - amuDebug(D_READDIR) - for (j=0,ne=ep; ne; ne=ne->ne_nextentry) - plog(XLOG_DEBUG, "gen1 key %4d \"%s\" fi=%d ck=%d", - j++, ne->ne_name, ne->ne_fileid, *(u_int *)ne->ne_cookie); -#endif /* DEBUG */ - return 0; - } -#ifdef DEBUG - dlog("amfs_auto_readdir: real child"); -#endif /* DEBUG */ - - if (gen == DOT_DOT_COOKIE) { -#ifdef DEBUG - dlog("amfs_auto_readdir: End of readdir in %s", mp->am_path); -#endif /* DEBUG */ - dp->dl_eof = TRUE; - dp->dl_entries = 0; -#ifdef DEBUG - amuDebug(D_READDIR) - plog(XLOG_DEBUG, "end of readdir eof=TRUE, dl_entries=0\n"); -#endif /* DEBUG */ - return 0; - } - - /* non-browsable directories code */ - xp = mp->am_child; - while (xp && xp->am_gen != gen) - xp = xp->am_osib; - - if (xp) { - int nbytes = count / 2; /* conservative */ - int todo = MAX_READDIR_ENTRIES; - - dp->dl_entries = ep; - do { - am_node *xp_next = next_nonerror_node(xp->am_osib); - - if (xp_next) { - *(u_int *) ep->ne_cookie = xp_next->am_gen; - } else { - *(u_int *) ep->ne_cookie = DOT_DOT_COOKIE; - dp->dl_eof = TRUE; - } - - ep->ne_fileid = xp->am_gen; - ep->ne_name = xp->am_name; - nbytes -= sizeof(*ep) + 1; - if (xp->am_name) - nbytes -= strlen(xp->am_name); - - xp = xp_next; - - if (nbytes > 0 && !dp->dl_eof && todo > 1) { - ep->ne_nextentry = ep + 1; - ep++; - --todo; - } else { - todo = 0; - } - } while (todo > 0); - - ep->ne_nextentry = 0; - -#ifdef DEBUG - amuDebug(D_READDIR) - for (j=0,ne=ep; ne; ne=ne->ne_nextentry) - plog(XLOG_DEBUG, "gen2 key %4d \"%s\" fi=%d ck=%d", - j++, ne->ne_name, ne->ne_fileid, *(u_int *)ne->ne_cookie); -#endif /* DEBUG */ - return 0; - } - return ESTALE; -} - - -/* This one is called only if map is browsable */ -static int -amfs_auto_readdir_browsable(am_node *mp, nfscookie cookie, nfsdirlist *dp, nfsentry *ep, int count, int fully_browsable) -{ - u_int gen = *(u_int *) cookie; - int chain_length, i; - static nfsentry *te, *te_next; -#ifdef DEBUG - nfsentry *ne; - static int j; -#endif /* DEBUG */ - - dp->dl_eof = FALSE; /* assume readdir not done */ - -#ifdef DEBUG - amuDebug(D_READDIR) - plog(XLOG_DEBUG, "amfs_auto_readdir_browsable gen=%u, count=%d", - gen, count); -#endif /* DEBUG */ - - if (gen == 0) { - /* - * In the default instance (which is used to start a search) we return - * "." and "..". - * - * This assumes that the count is big enough to allow both "." and ".." - * to be returned in a single packet. If it isn't (which would be - * fairly unbelievable) then tough. - */ -#ifdef DEBUG - dlog("amfs_auto_readdir_browsable: default search"); -#endif /* DEBUG */ - /* - * Check for enough room. This is extremely approximate but is more - * than enough space. Really need 2 times: - * 4byte fileid - * 4byte cookie - * 4byte name length - * 4byte name - * plus the dirlist structure */ - if (count < (2 * (2 * (sizeof(*ep) + sizeof("..") + 4) + sizeof(*dp)))) - return EINVAL; - - /* - * compute # of entries to send in this chain. - * heuristics: 128 bytes per entry. - * This is too much probably, but it seems to work better because - * of the re-entrant nature of nfs_readdir, and esp. on systems - * like OpenBSD 2.2. - */ - chain_length = count / 128; - - /* reset static state counters */ - te = te_next = NULL; - - dp->dl_entries = ep; - - /* construct "." */ - ep[0].ne_fileid = mp->am_gen; - ep[0].ne_name = "."; - ep[0].ne_nextentry = &ep[1]; - *(u_int *) ep[0].ne_cookie = 0; - - /* construct ".." */ - if (mp->am_parent) - ep[1].ne_fileid = mp->am_parent->am_gen; - else - ep[1].ne_fileid = mp->am_gen; - - ep[1].ne_name = ".."; - ep[1].ne_nextentry = 0; - *(u_int *) ep[1].ne_cookie = DOT_DOT_COOKIE; - - /* - * If map is browsable, call a function make_entry_chain() to construct - * a linked list of unmounted keys, and return it. Then link the chain - * to the regular list. Get the chain only once, but return - * chunks of it each time. - */ - te = make_entry_chain(mp, dp->dl_entries, fully_browsable); - if (!te) - return 0; -#ifdef DEBUG - amuDebug(D_READDIR) - for (j=0,ne=te; ne; ne=ne->ne_nextentry) - plog(XLOG_DEBUG, "gen1 key %4d \"%s\"", j++, ne->ne_name); -#endif /* DEBUG */ - - /* return only "chain_length" entries */ - te_next = te; - for (i=1; i<chain_length; ++i) { - te_next = te_next->ne_nextentry; - if (!te_next) - break; - } - if (te_next) { - nfsentry *te_saved = te_next->ne_nextentry; - te_next->ne_nextentry = NULL; /* terminate "te" chain */ - te_next = te_saved; /* save rest of "te" for next iteration */ - dp->dl_eof = FALSE; /* tell readdir there's more */ - } else { - dp->dl_eof = TRUE; /* tell readdir that's it */ - } - ep[1].ne_nextentry = te; /* append this chunk of "te" chain */ -#ifdef DEBUG - amuDebug(D_READDIR) { - for (j=0,ne=te; ne; ne=ne->ne_nextentry) - plog(XLOG_DEBUG, "gen2 key %4d \"%s\"", j++, ne->ne_name); - for (j=0,ne=ep; ne; ne=ne->ne_nextentry) - plog(XLOG_DEBUG, "gen2+ key %4d \"%s\" fi=%d ck=%d", - j++, ne->ne_name, ne->ne_fileid, *(u_int *)ne->ne_cookie); - plog(XLOG_DEBUG, "EOF is %d", dp->dl_eof); - } -#endif /* DEBUG_READDIR */ - return 0; - } /* end of "if (gen == 0)" statement */ - -#ifdef DEBUG - dlog("amfs_auto_readdir_browsable: real child"); -#endif /* DEBUG */ - - if (gen == DOT_DOT_COOKIE) { -#ifdef DEBUG - dlog("amfs_auto_readdir_browsable: End of readdir in %s", mp->am_path); -#endif /* DEBUG */ - dp->dl_eof = TRUE; - dp->dl_entries = 0; - return 0; - } - - /* - * If browsable directories, then continue serving readdir() with another - * chunk of entries, starting from where we left off (when gen was equal - * to 0). Once again, assume last chunk served to readdir. - */ - dp->dl_eof = TRUE; - dp->dl_entries = ep; - - te = te_next; /* reset 'te' from last saved te_next */ - if (!te) { /* another indicator of end of readdir */ - dp->dl_entries = 0; - return 0; - } - /* - * compute # of entries to send in this chain. - * heuristics: 128 bytes per entry. + * Attach a map cache */ - chain_length = count / 128; + amfs_mkcacheref(mf); - /* return only "chain_length" entries */ - for (i=1; i<chain_length; ++i) { - te_next = te_next->ne_nextentry; - if (!te_next) - break; - } - if (te_next) { - nfsentry *te_saved = te_next->ne_nextentry; - te_next->ne_nextentry = NULL; /* terminate "te" chain */ - te_next = te_saved; /* save rest of "te" for next iteration */ - dp->dl_eof = FALSE; /* tell readdir there's more */ - } - ep = te; /* send next chunk of "te" chain */ - dp->dl_entries = ep; -#ifdef DEBUG - amuDebug(D_READDIR) { - plog(XLOG_DEBUG, "dl_entries=0x%lx, te_next=0x%lx, dl_eof=%d", - (long) dp->dl_entries, (long) te_next, dp->dl_eof); - for (ne=te; ne; ne=ne->ne_nextentry) - plog(XLOG_DEBUG, "gen3 key %4d \"%s\"", j++, ne->ne_name); - } -#endif /* DEBUG */ return 0; } - - -int -amfs_auto_fmount(am_node *mp) -{ - mntfs *mf = mp->am_mnt; - return (*mf->mf_ops->fmount_fs) (mf); -} - - -int -amfs_auto_fumount(am_node *mp) -{ - mntfs *mf = mp->am_mnt; - return (*mf->mf_ops->fumount_fs) (mf); -} diff --git a/contrib/amd/amd/amfs_direct.c b/contrib/amd/amd/amfs_direct.c index 2ea0ae6ce2ca..dbef743d0d7e 100644 --- a/contrib/amd/amd/amfs_direct.c +++ b/contrib/amd/amd/amfs_direct.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: amfs_direct.c,v 1.3.2.4 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/amfs_direct.c * */ @@ -63,19 +62,22 @@ static am_node *amfs_direct_readlink(am_node *mp, int *error_return); am_ops amfs_direct_ops = { "direct", - amfs_auto_match, + amfs_generic_match, 0, /* amfs_direct_init */ amfs_toplvl_mount, - 0, amfs_toplvl_umount, - 0, - amfs_error_lookuppn, + amfs_generic_lookup_child, + amfs_generic_mount_child, amfs_error_readdir, amfs_direct_readlink, - amfs_toplvl_mounted, - 0, /* amfs_auto_umounted */ - find_amfs_auto_srvr, - FS_MKMNT | FS_NOTIMEOUT | FS_BACKGROUND | FS_AMQINFO + amfs_generic_mounted, + 0, /* amfs_direct_umounted */ + amfs_generic_find_srvr, + 0, /* amfs_direct_get_wchan */ + FS_DIRECT | FS_MKMNT | FS_NOTIMEOUT | FS_BACKGROUND | FS_AMQINFO, +#ifdef HAVE_FS_AUTOFS + AUTOFS_DIRECT_FS_FLAGS, +#endif /* HAVE_FS_AUTOFS */ }; @@ -92,8 +94,10 @@ amfs_direct_readlink(am_node *mp, int *error_return) xp = next_nonerror_node(mp->am_child); if (!xp) { if (!mp->am_mnt->mf_private) - amfs_auto_mkcacheref(mp->am_mnt); /* XXX */ - xp = amfs_auto_lookuppn(mp, mp->am_path + 1, &rc, VLOOK_CREATE); + amfs_mkcacheref(mp->am_mnt); /* XXX */ + xp = amfs_generic_lookup_child(mp, mp->am_path + 1, &rc, VLOOK_CREATE); + if (xp && rc < 0) + xp = amfs_generic_mount_child(xp, &rc); } if (xp) { new_ttl(xp); /* (7/12/89) from Rein Tollevik */ diff --git a/contrib/amd/amd/amfs_error.c b/contrib/amd/amd/amfs_error.c index ca6203390e91..51bdaa6db14d 100644 --- a/contrib/amd/amd/amfs_error.c +++ b/contrib/amd/amd/amfs_error.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: amfs_error.c,v 1.3.2.5 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/amfs_error.c * */ @@ -57,9 +56,8 @@ #include <amd.h> static char *amfs_error_match(am_opts *fo); -static int amfs_error_fmount(mntfs *mf); -static int amfs_error_fumount(mntfs *mf); -static void amfs_error_umounted(am_node *mp); +static int amfs_error_mount(am_node *am, mntfs *mf); +static int amfs_error_umount(am_node *am, mntfs *mf); /* @@ -70,17 +68,20 @@ am_ops amfs_error_ops = "error", amfs_error_match, 0, /* amfs_error_init */ - amfs_auto_fmount, - amfs_error_fmount, - amfs_auto_fumount, - amfs_error_fumount, - amfs_error_lookuppn, + amfs_error_mount, + amfs_error_umount, + amfs_error_lookup_child, + amfs_error_mount_child, amfs_error_readdir, 0, /* amfs_error_readlink */ 0, /* amfs_error_mounted */ - amfs_error_umounted, - find_amfs_auto_srvr, - FS_DISCARD + 0, /* amfs_error_umounted */ + amfs_generic_find_srvr, + 0, /* amfs_error_get_wchan */ + FS_DISCARD, /* nfs_fs_flags */ +#ifdef HAVE_FS_AUTOFS + AUTOFS_ERROR_FS_FLAGS, +#endif /* HAVE_FS_AUTOFS */ }; @@ -96,14 +97,14 @@ amfs_error_match(am_opts *fo) static int -amfs_error_fmount(mntfs *mf) +amfs_error_mount(am_node *am, mntfs *mf) { return ENOENT; } static int -amfs_error_fumount(mntfs *mf) +amfs_error_umount(am_node *am, mntfs *mf) { /* * Always succeed @@ -118,7 +119,7 @@ amfs_error_fumount(mntfs *mf) * If we do then just give an error. */ am_node * -amfs_error_lookuppn(am_node *mp, char *fname, int *error_return, int op) +amfs_error_lookup_child(am_node *mp, char *fname, int *error_return, int op) { *error_return = ESTALE; return 0; @@ -126,25 +127,25 @@ amfs_error_lookuppn(am_node *mp, char *fname, int *error_return, int op) /* - * EFS interface to RPC readdir() routine. + * EFS interface to RPC lookup() routine. * Should never get here in the automounter. * If we do then just give an error. */ -int -amfs_error_readdir(am_node *mp, nfscookie cookie, nfsdirlist *dp, nfsentry *ep, int count) +am_node * +amfs_error_mount_child(am_node *ap, int *error_return) { - return ESTALE; + *error_return = ESTALE; + return 0; } /* - * umounted() callback for EFS. - * - * This prevents core-dumps on callbacks to error file-systems from - * nfsx_fumount. + * EFS interface to RPC readdir() routine. + * Should never get here in the automounter. + * If we do then just give an error. */ -static void -amfs_error_umounted(am_node *mp) +int +amfs_error_readdir(am_node *mp, nfscookie cookie, nfsdirlist *dp, nfsentry *ep, u_int count) { - /* nothing to do */ + return ESTALE; } diff --git a/contrib/amd/amd/amfs_generic.c b/contrib/amd/amd/amfs_generic.c new file mode 100644 index 000000000000..3e7c365a7593 --- /dev/null +++ b/contrib/amd/amd/amfs_generic.c @@ -0,0 +1,1262 @@ +/* + * Copyright (c) 1997-2006 Erez Zadok + * Copyright (c) 1990 Jan-Simon Pendry + * Copyright (c) 1990 Imperial College of Science, Technology & Medicine + * Copyright (c) 1990 The Regents of the University of California. + * All rights reserved. + * + * This code is derived from software contributed to Berkeley by + * Jan-Simon Pendry at Imperial College, London. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * 3. All advertising materials mentioning features or use of this software + * must display the following acknowledgment: + * This product includes software developed by the University of + * California, Berkeley and its contributors. + * 4. Neither the name of the University nor the names of its contributors + * may be used to endorse or promote products derived from this software + * without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF + * SUCH DAMAGE. + * + * + * File: am-utils/amd/amfs_generic.c + * + */ + +/* + * generic functions used by amfs filesystems, ripped out of amfs_auto.c. + */ + +#ifdef HAVE_CONFIG_H +# include <config.h> +#endif /* HAVE_CONFIG_H */ +#include <am_defs.h> +#include <amd.h> + + +/**************************************************************************** + *** MACROS *** + ****************************************************************************/ +#define IN_PROGRESS(cp) ((cp)->mp->am_mnt->mf_flags & MFF_MOUNTING) + + +/**************************************************************************** + *** STRUCTURES *** + ****************************************************************************/ +/* + * Mounting a file system may take a significant period of time. The + * problem is that if this is done in the main process thread then the + * entire automounter could be blocked, possibly hanging lots of processes + * on the system. Instead we use a continuation scheme to allow mounts to + * be attempted in a sub-process. When the sub-process exits we pick up the + * exit status (by convention a UN*X error number) and continue in a + * notifier. The notifier gets handed a data structure and can then + * determine whether the mount was successful or not. If not, it updates + * the data structure and tries again until there are no more ways to try + * the mount, or some other permanent error occurs. In the mean time no RPC + * reply is sent, even after the mount is successful. We rely on the RPC + * retry mechanism to resend the lookup request which can then be handled. + */ +struct continuation { + am_node *mp; /* Node we are trying to mount */ + int retry; /* Try again? */ + time_t start; /* Time we started this mount */ + int callout; /* Callout identifier */ + mntfs **mf; /* Current mntfs */ +}; + + +/**************************************************************************** + *** FORWARD DEFINITIONS *** + ****************************************************************************/ +static am_node *amfs_lookup_node(am_node *mp, char *fname, int *error_return); +static mntfs *amfs_lookup_one_mntfs(am_node *new_mp, mntfs *mf, char *ivec, + char *def_opts, char *pfname); +static mntfs **amfs_lookup_mntfs(am_node *new_mp, int *error_return); +static void amfs_cont(int rc, int term, opaque_t arg); +static void amfs_retry(int rc, int term, opaque_t arg); +static void free_continuation(struct continuation *cp); +static int amfs_bgmount(struct continuation *cp); +static char *amfs_parse_defaults(am_node *mp, mntfs *mf, char *def_opts); + + +/**************************************************************************** + *** FUNCTIONS *** + ****************************************************************************/ +static am_node * +amfs_lookup_node(am_node *mp, char *fname, int *error_return) +{ + am_node *new_mp; + int error = 0; /* Error so far */ + int in_progress = 0; /* # of (un)mount in progress */ + mntfs *mf; + char *expanded_fname = 0; + + dlog("in amfs_lookup_node"); + + /* + * If the server is shutting down + * then don't return information + * about the mount point. + */ + if (amd_state == Finishing) { + if (mp->am_mnt == 0 || mp->am_mnt->mf_fsflags & FS_DIRECT) { + dlog("%s mount ignored - going down", fname); + } else { + dlog("%s/%s mount ignored - going down", mp->am_path, fname); + } + ereturn(ENOENT); + } + + /* + * Handle special case of "." and ".." + */ + if (fname[0] == '.') { + if (fname[1] == '\0') + return mp; /* "." is the current node */ + if (fname[1] == '.' && fname[2] == '\0') { + if (mp->am_parent) { + dlog(".. in %s gives %s", mp->am_path, mp->am_parent->am_path); + return mp->am_parent; /* ".." is the parent node */ + } + ereturn(ESTALE); + } + } + + /* + * Check for valid key name. + * If it is invalid then pretend it doesn't exist. + */ + if (!valid_key(fname)) { + plog(XLOG_WARNING, "Key \"%s\" contains a disallowed character", fname); + ereturn(ENOENT); + } + + /* + * Expand key name. + * expanded_fname is now a private copy. + */ + expanded_fname = expand_selectors(fname); + + /* + * Search children of this node + */ + for (new_mp = mp->am_child; new_mp; new_mp = new_mp->am_osib) { + if (FSTREQ(new_mp->am_name, expanded_fname)) { + if (new_mp->am_error) { + error = new_mp->am_error; + continue; + } + + /* + * If the error code is undefined then it must be + * in progress. + */ + mf = new_mp->am_mnt; + if (mf->mf_error < 0) + goto in_progrss; + + /* + * If there was a previous error with this node + * then return that error code. + */ + if (mf->mf_flags & MFF_ERROR) { + error = mf->mf_error; + continue; + } + if (!(mf->mf_flags & MFF_MOUNTED) || (mf->mf_flags & MFF_UNMOUNTING)) { + in_progrss: + /* + * If the fs is not mounted or it is unmounting then there + * is a background (un)mount in progress. In this case + * we just drop the RPC request (return nil) and + * wait for a retry, by which time the (un)mount may + * have completed. + */ + dlog("ignoring mount of %s in %s -- %smounting in progress, flags %x", + expanded_fname, mf->mf_mount, + (mf->mf_flags & MFF_UNMOUNTING) ? "un" : "", mf->mf_flags); + in_progress++; + if (mf->mf_flags & MFF_UNMOUNTING) { + dlog("will remount later"); + new_mp->am_flags |= AMF_REMOUNT; + } + continue; + } + + /* + * Otherwise we have a hit: return the current mount point. + */ + dlog("matched %s in %s", expanded_fname, new_mp->am_path); + XFREE(expanded_fname); + return new_mp; + } + } + + if (in_progress) { + dlog("Waiting while %d mount(s) in progress", in_progress); + XFREE(expanded_fname); + ereturn(-1); + } + + /* + * If an error occurred then return it. + */ + if (error) { + dlog("Returning error: %s", strerror(error)); + XFREE(expanded_fname); + ereturn(error); + } + + /* + * If the server is going down then just return, + * don't try to mount any more file systems + */ + if ((int) amd_state >= (int) Finishing) { + dlog("not found - server going down anyway"); + ereturn(ENOENT); + } + + /* + * Allocate a new map + */ + new_mp = get_ap_child(mp, expanded_fname); + XFREE(expanded_fname); + if (new_mp == 0) + ereturn(ENOSPC); + + *error_return = -1; + return new_mp; +} + + + +static mntfs * +amfs_lookup_one_mntfs(am_node *new_mp, mntfs *mf, char *ivec, + char *def_opts, char *pfname) +{ + am_ops *p; + am_opts *fs_opts; + mntfs *new_mf; + char *mp_dir = 0; +#ifdef HAVE_FS_AUTOFS + int on_autofs = 1; +#endif /* HAVE_FS_AUTOFS */ + + /* match the operators */ + fs_opts = CALLOC(am_opts); + p = ops_match(fs_opts, ivec, def_opts, new_mp->am_path, + pfname, mf->mf_info); +#ifdef HAVE_FS_AUTOFS + /* XXX: this should be factored out into an autofs-specific function */ + if (new_mp->am_flags & AMF_AUTOFS) { + /* ignore user-provided fs if we're using autofs */ + if (fs_opts->opt_sublink) { + /* + * For sublinks we need to use a hack with autofs: + * mount the filesystem on the original opt_fs (which is NOT an + * autofs mountpoint) and symlink (or lofs-mount) to it from + * the autofs mountpoint. + */ + on_autofs = 0; + mp_dir = fs_opts->opt_fs; + } else { + if (p->autofs_fs_flags & FS_ON_AUTOFS) { + mp_dir = new_mp->am_path; + } else { + mp_dir = fs_opts->opt_fs; + on_autofs = 0; + } + } + } else +#endif /* HAVE_FS_AUTOFS */ + mp_dir = fs_opts->opt_fs; + + /* + * Find or allocate a filesystem for this node. + */ + new_mf = find_mntfs(p, fs_opts, + mp_dir, + fs_opts->fs_mtab, + def_opts, + fs_opts->opt_opts, + fs_opts->opt_remopts); + + /* + * See whether this is a real filesystem + */ + p = new_mf->mf_ops; + if (p == &amfs_error_ops) { + plog(XLOG_MAP, "Map entry %s for %s did not match", ivec, new_mp->am_path); + free_mntfs(new_mf); + return NULL; + } + + dlog("Got a hit with %s", p->fs_type); + +#ifdef HAVE_FS_AUTOFS + if (new_mp->am_flags & AMF_AUTOFS && on_autofs) { + new_mf->mf_flags |= MFF_ON_AUTOFS; + new_mf->mf_fsflags = new_mf->mf_ops->autofs_fs_flags; + } + /* + * A new filesystem is an autofs filesystems if: + * 1. it claims it can be one (has the FS_AUTOFS flag) + * 2. autofs is enabled system-wide + * 3. either has an autofs parent, + * or it is explicitly requested to be autofs. + */ + if (new_mf->mf_ops->autofs_fs_flags & FS_AUTOFS && + amd_use_autofs && + ((mf->mf_flags & MFF_IS_AUTOFS) || + (new_mf->mf_fo && new_mf->mf_fo->opt_mount_type && + STREQ(new_mf->mf_fo->opt_mount_type, "autofs")))) + new_mf->mf_flags |= MFF_IS_AUTOFS; +#endif /* HAVE_FS_AUTOFS */ + + return new_mf; +} + + +static mntfs ** +amfs_lookup_mntfs(am_node *new_mp, int *error_return) +{ + am_node *mp; + char *info; /* Mount info - where to get the file system */ + char **ivecs, **cur_ivec; /* Split version of info */ + int num_ivecs; + char *orig_def_opts; /* Original Automount options */ + char *def_opts; /* Automount options */ + int error = 0; /* Error so far */ + char path_name[MAXPATHLEN]; /* General path name buffer */ + char *pfname; /* Path for database lookup */ + mntfs *mf, **mf_array; + int count; + + dlog("in amfs_lookup_mntfs"); + + mp = new_mp->am_parent; + + /* + * If we get here then this is a reference to an, + * as yet, unknown name so we need to search the mount + * map for it. + */ + if (mp->am_pref) { + if (strlen(mp->am_pref) + strlen(new_mp->am_name) >= sizeof(path_name)) + ereturn(ENAMETOOLONG); + xsnprintf(path_name, sizeof(path_name), "%s%s", mp->am_pref, new_mp->am_name); + pfname = path_name; + } else { + pfname = new_mp->am_name; + } + + mf = mp->am_mnt; + + dlog("will search map info in %s to find %s", mf->mf_info, pfname); + /* + * Consult the oracle for some mount information. + * info is malloc'ed and belongs to this routine. + * It ends up being free'd in free_continuation(). + * + * Note that this may return -1 indicating that information + * is not yet available. + */ + error = mapc_search((mnt_map *) mf->mf_private, pfname, &info); + if (error) { + if (error > 0) + plog(XLOG_MAP, "No map entry for %s", pfname); + else + plog(XLOG_MAP, "Waiting on map entry for %s", pfname); + ereturn(error); + } + dlog("mount info is %s", info); + + /* + * Split info into an argument vector. + * The vector is malloc'ed and belongs to + * this routine. It is free'd further down. + * + * Note: the vector pointers point into info, so don't free it! + */ + ivecs = strsplit(info, ' ', '\"'); + + if (mf->mf_auto) + def_opts = mf->mf_auto; + else + def_opts = ""; + + orig_def_opts = amfs_parse_defaults(mp, mf, strdup(def_opts)); + def_opts = strdup(orig_def_opts); + + /* first build our defaults */ + num_ivecs = 0; + for (cur_ivec = ivecs; *cur_ivec; cur_ivec++) { + if (**cur_ivec == '-') { + /* + * Pick up new defaults + */ + char *new_def_opts = str3cat(NULL, def_opts, ";", *cur_ivec + 1); + XFREE(def_opts); + def_opts = new_def_opts; + dlog("Setting def_opts to \"%s\"", def_opts); + continue; + } else + num_ivecs++; + } + + mf_array = calloc(num_ivecs + 1, sizeof(mntfs *)); + + /* construct the array of struct mntfs for this mount point */ + for (count = 0, cur_ivec = ivecs; *cur_ivec; cur_ivec++) { + mntfs *new_mf; + + if (**cur_ivec == '-') { + XFREE(def_opts); + if ((*cur_ivec)[1] == '\0') { + /* + * If we have a single dash '-' than we need to reset the + * default options. + */ + def_opts = strdup(orig_def_opts); + dlog("Resetting the default options, a single dash '-' was found."); + } else { + /* append options to /default options */ + def_opts = str3cat((char *) 0, orig_def_opts, ";", *cur_ivec + 1); + dlog("Resetting def_opts to \"%s\"", def_opts); + } + continue; + } + + /* + * If a mntfs has already been found, and we find + * a cut then don't try any more locations. + * + * XXX: we do not know when the "/" was added as an equivalent for "||". + * It's undocumented, it might go away at any time. Caveat emptor. + */ + if (STREQ(*cur_ivec, "/") || STREQ(*cur_ivec, "||")) { + if (count > 0) { + dlog("Cut: not trying any more locations for %s", mp->am_path); + break; + } + continue; + } + + new_mf = amfs_lookup_one_mntfs(new_mp, mf, *cur_ivec, def_opts, pfname); + if (new_mf == NULL) + continue; + mf_array[count++] = new_mf; + } + + /* We're done with ivecs */ + XFREE(ivecs); + XFREE(info); + XFREE(orig_def_opts); + XFREE(def_opts); + if (count == 0) { /* no match */ + XFREE(mf_array); + ereturn(ENOENT); + } + + return mf_array; +} + + +/* + * The continuation function. This is called by + * the task notifier when a background mount attempt + * completes. + */ +static void +amfs_cont(int rc, int term, opaque_t arg) +{ + struct continuation *cp = (struct continuation *) arg; + am_node *mp = cp->mp; + mntfs *mf = mp->am_mnt; + + dlog("amfs_cont: '%s'", mp->am_path); + + /* + * Definitely not trying to mount at the moment + */ + mf->mf_flags &= ~MFF_MOUNTING; + + /* + * While we are mounting - try to avoid race conditions + */ + new_ttl(mp); + + /* + * Wakeup anything waiting for this mount + */ + wakeup(get_mntfs_wchan(mf)); + + /* + * Check for termination signal or exit status... + */ + if (rc || term) { +#ifdef HAVE_FS_AUTOFS + if (mf->mf_flags & MFF_IS_AUTOFS && + !(mf->mf_flags & MFF_MOUNTED)) + autofs_release_fh(mp); +#endif /* HAVE_FS_AUTOFS */ + + if (term) { + /* + * Not sure what to do for an error code. + */ + mf->mf_error = EIO; /* XXX ? */ + mf->mf_flags |= MFF_ERROR; + plog(XLOG_ERROR, "mount for %s got signal %d", mp->am_path, term); + } else { + /* + * Check for exit status... + */ +#ifdef __linux__ + /* + * HACK ALERT! + * + * On Linux (and maybe not only) it's possible to run + * an amd which "knows" how to mount certain combinations + * of nfs_proto/nfs_version which the kernel doesn't grok. + * So if we got an EINVAL and we have a server that's not + * using NFSv2/UDP, try again with NFSv2/UDP. + * + * Too bad that there is no way to dynamically determine + * what combinations the _client_ supports, as opposed to + * what the _server_ supports... + */ + if (rc == EINVAL && + mf->mf_server && + (mf->mf_server->fs_version != 2 || + !STREQ(mf->mf_server->fs_proto, "udp"))) + mf->mf_flags |= MFF_NFS_SCALEDOWN; + else +#endif /* __linux__ */ + { + mf->mf_error = rc; + mf->mf_flags |= MFF_ERROR; + errno = rc; /* XXX */ + if (!STREQ(mp->am_mnt->mf_ops->fs_type, "linkx")) + plog(XLOG_ERROR, "%s: mount (amfs_cont): %m", mp->am_path); + } + } + + if (!(mf->mf_flags & MFF_NFS_SCALEDOWN)) { + /* + * If we get here then that attempt didn't work, so + * move the info vector pointer along by one and + * call the background mount routine again + */ + amd_stats.d_merr++; + cp->mf++; + } + amfs_bgmount(cp); + if (mp->am_error > 0) + assign_error_mntfs(mp); + } else { + /* + * The mount worked. + */ + dlog("Mounting %s returned success", cp->mp->am_path); + am_mounted(cp->mp); + free_continuation(cp); + } + + reschedule_timeout_mp(); +} + + +/* + * Retry a mount + */ +static void +amfs_retry(int rc, int term, opaque_t arg) +{ + struct continuation *cp = (struct continuation *) arg; + am_node *mp = cp->mp; + int error = 0; + + dlog("Commencing retry for mount of %s", mp->am_path); + + new_ttl(mp); + + if ((cp->start + ALLOWED_MOUNT_TIME) < clocktime(NULL)) { + /* + * The entire mount has timed out. Set the error code and skip past all + * the mntfs's so that amfs_bgmount will not have any more + * ways to try the mount, thus causing an error. + */ + plog(XLOG_INFO, "mount of \"%s\" has timed out", mp->am_path); + error = ETIMEDOUT; + while (*cp->mf) + cp->mf++; + /* explicitly forbid further retries after timeout */ + cp->retry = FALSE; + } + if (error || !IN_PROGRESS(cp)) + error = amfs_bgmount(cp); + + reschedule_timeout_mp(); +} + + +/* + * Discard an old continuation + */ +static void +free_continuation(struct continuation *cp) +{ + mntfs **mfp; + + dlog("free_continuation"); + if (cp->callout) + untimeout(cp->callout); + /* + * we must free the mntfs's in the list. + * so free all of them if there was an error, + * or free all but the used one, if the mount succeeded. + */ + for (mfp = cp->mp->am_mfarray; *mfp; mfp++) { + free_mntfs(*mfp); + } + XFREE(cp->mp->am_mfarray); + cp->mp->am_mfarray = 0; + XFREE(cp); +} + + +/* + * Pick a file system to try mounting and + * do that in the background if necessary + * +For each location: + discard previous mount location if required + fetch next mount location + if the filesystem failed to be mounted then + this_error = error from filesystem + goto failed + if the filesystem is mounting or unmounting then + goto retry; + if the fileserver is down then + this_error = EIO + continue; + if the filesystem is already mounted + break + fi + + this_error = initialize mount point + + if no error on this mount and mount is delayed then + this_error = -1 + fi + if this_error < 0 then + retry = true + fi + if no error on this mount then + if mount in background then + run mount in background + return -1 + else + this_error = mount in foreground + fi + fi + if an error occurred on this mount then + update stats + save error in mount point + fi +endfor + */ +static int +amfs_bgmount(struct continuation *cp) +{ + am_node *mp = cp->mp; + mntfs *mf; /* Current mntfs */ + int this_error = -1; /* Per-mount error */ + int hard_error = -1; /* Cumulative per-node error */ + + if (mp->am_mnt) + free_mntfs(mp->am_mnt); + + /* + * Try to mount each location. + * At the end: + * hard_error == 0 indicates something was mounted. + * hard_error > 0 indicates everything failed with a hard error + * hard_error < 0 indicates nothing could be mounted now + */ + for (mp->am_mnt = *cp->mf; *cp->mf; cp->mf++, mp->am_mnt = *cp->mf) { + am_ops *p; + + mf = dup_mntfs(mp->am_mnt); + p = mf->mf_ops; + + if (hard_error < 0) + hard_error = this_error; + this_error = 0; + + if (mf->mf_error > 0) { + this_error = mf->mf_error; + goto failed; + } + + if (mf->mf_flags & (MFF_MOUNTING | MFF_UNMOUNTING)) { + /* + * Still mounting - retry later + */ + dlog("mount of \"%s\" already pending", mf->mf_info); + goto retry; + } + + if (FSRV_ISDOWN(mf->mf_server)) { + /* + * Would just mount from the same place + * as a hung mount - so give up + */ + dlog("%s is already hung - giving up", mf->mf_server->fs_host); + this_error = EIO; + goto failed; + } + + if (mp->am_link) { + XFREE(mp->am_link); + mp->am_link = NULL; + } + if (mf->mf_fo && mf->mf_fo->opt_sublink) + mp->am_link = strdup(mf->mf_fo->opt_sublink); + + /* + * Will usually need to play around with the mount nodes + * file attribute structure. This must be done here. + * Try and get things initialized, even if the fileserver + * is not known to be up. In the common case this will + * progress things faster. + */ + + /* + * Fill in attribute fields. + */ + if (mf->mf_fsflags & FS_DIRECTORY) + mk_fattr(&mp->am_fattr, NFDIR); + else + mk_fattr(&mp->am_fattr, NFLNK); + + if (mf->mf_flags & MFF_MOUNTED) { + dlog("duplicate mount of \"%s\" ...", mf->mf_info); + /* + * Skip initial processing of the mountpoint if already mounted. + * This could happen if we have multiple sublinks into the same f/s, + * or if we are restarting an already-mounted filesystem. + */ + goto already_mounted; + } + + if (mf->mf_fo && mf->mf_fo->fs_mtab) { + plog(XLOG_MAP, "Trying mount of %s on %s fstype %s mount_type %s", + mf->mf_fo->fs_mtab, mf->mf_mount, p->fs_type, + mp->am_flags & AMF_AUTOFS ? "autofs" : "non-autofs"); + } + + if (p->fs_init && !(mf->mf_flags & MFF_RESTART)) + this_error = p->fs_init(mf); + + if (this_error > 0) + goto failed; + if (this_error < 0) + goto retry; + + if (mf->mf_fo && mf->mf_fo->opt_delay) { + /* + * If there is a delay timer on the mount + * then don't try to mount if the timer + * has not expired. + */ + int i = atoi(mf->mf_fo->opt_delay); + time_t now = clocktime(NULL); + if (i > 0 && now < (cp->start + i)) { + dlog("Mount of %s delayed by %lds", mf->mf_mount, (long) (i - now + cp->start)); + goto retry; + } + } + + /* + * If the directory is not yet made and it needs to be made, then make it! + */ + if (!(mf->mf_flags & MFF_MKMNT) && mf->mf_fsflags & FS_MKMNT) { + plog(XLOG_INFO, "creating mountpoint directory '%s'", mf->mf_mount); + this_error = mkdirs(mf->mf_mount, 0555); + if (this_error) { + plog(XLOG_ERROR, "mkdirs failed: %s", strerror(this_error)); + goto failed; + } + mf->mf_flags |= MFF_MKMNT; + } + +#ifdef HAVE_FS_AUTOFS + if (mf->mf_flags & MFF_IS_AUTOFS) + if ((this_error = autofs_get_fh(mp))) + goto failed; +#endif /* HAVE_FS_AUTOFS */ + + already_mounted: + mf->mf_flags |= MFF_MOUNTING; + if (mf->mf_fsflags & FS_MBACKGROUND) { + dlog("backgrounding mount of \"%s\"", mf->mf_mount); + if (cp->callout) { + untimeout(cp->callout); + cp->callout = 0; + } + + /* actually run the task, backgrounding as necessary */ + run_task(mount_node, (opaque_t) mp, amfs_cont, (opaque_t) cp); + return -1; + } else { + dlog("foreground mount of \"%s\" ...", mf->mf_mount); + this_error = mount_node((opaque_t) mp); + } + + mf->mf_flags &= ~MFF_MOUNTING; + if (this_error > 0) + goto failed; + if (this_error == 0) { + am_mounted(mp); + break; /* Success */ + } + + retry: + if (!cp->retry) + continue; + dlog("will retry ...\n"); + + /* + * Arrange that amfs_bgmount is called + * after anything else happens. + */ + dlog("Arranging to retry mount of %s", mp->am_path); + sched_task(amfs_retry, (opaque_t) cp, get_mntfs_wchan(mf)); + if (cp->callout) + untimeout(cp->callout); + cp->callout = timeout(RETRY_INTERVAL, wakeup, + (opaque_t) get_mntfs_wchan(mf)); + + mp->am_ttl = clocktime(NULL) + RETRY_INTERVAL; + + /* + * Not done yet - so don't return anything + */ + return -1; + + failed: + amd_stats.d_merr++; + mf->mf_error = this_error; + mf->mf_flags |= MFF_ERROR; +#ifdef HAVE_FS_AUTOFS + if (mp->am_autofs_fh) + autofs_release_fh(mp); +#endif /* HAVE_FS_AUTOFS */ + if (mf->mf_flags & MFF_MKMNT) { + rmdirs(mf->mf_mount); + mf->mf_flags &= ~MFF_MKMNT; + } + /* + * Wakeup anything waiting for this mount + */ + wakeup(get_mntfs_wchan(mf)); + free_mntfs(mf); + /* continue */ + } + + /* + * If we get here, then either the mount succeeded or + * there is no more mount information available. + */ + if (this_error) { + mp->am_mnt = mf = new_mntfs(); + +#ifdef HAVE_FS_AUTOFS + if (mp->am_flags & AMF_AUTOFS) + autofs_mount_failed(mp); + else +#endif /* HAVE_FS_AUTOFS */ + nfs_quick_reply(mp, this_error); + + if (hard_error <= 0) + hard_error = this_error; + if (hard_error < 0) + hard_error = ETIMEDOUT; + + /* + * Set a small(ish) timeout on an error node if + * the error was not a time out. + */ + switch (hard_error) { + case ETIMEDOUT: + case EWOULDBLOCK: + case EIO: + mp->am_timeo = 17; + break; + default: + mp->am_timeo = 5; + break; + } + new_ttl(mp); + } else { + mf = mp->am_mnt; + /* + * Wakeup anything waiting for this mount + */ + wakeup(get_mntfs_wchan(mf)); + hard_error = 0; + } + + /* + * Make sure that the error value in the mntfs has a + * reasonable value. + */ + if (mf->mf_error < 0) { + mf->mf_error = hard_error; + if (hard_error) + mf->mf_flags |= MFF_ERROR; + } + + /* + * In any case we don't need the continuation any more + */ + free_continuation(cp); + + return hard_error; +} + + +static char * +amfs_parse_defaults(am_node *mp, mntfs *mf, char *def_opts) +{ + char *dflts; + char *dfl; + char **rvec = NULL; + struct mnt_map *mm = (mnt_map *) mf->mf_private; + + dlog("determining /defaults entry value"); + + /* + * Find out if amd.conf overrode any map-specific /defaults. + * + * HACK ALERT: there's no easy way to find out what the map mount point is + * at this point, so I am forced to initialize the mnt_map->cfm field here + * for the first time, upon the very first search for a /defaults entry in + * this map. This initialization is much better done in mapc_create(), + * but it's impossible to do that there with the current code structure. + */ + if (mm->cfm == NULL) { /* then initialize it for first time */ + mm->cfm = find_cf_map(mf->mf_mount); + } + if (mm->cfm && mm->cfm->cfm_defaults) { + dlog("map %s map_defaults override: %s", mf->mf_mount, mm->cfm->cfm_defaults); + dflts = strdup(mm->cfm->cfm_defaults); + } else if (mapc_search(mm, "/defaults", &dflts) == 0) { + dlog("/defaults gave %s", dflts); + } else { + return def_opts; /* if nothing found */ + } + + /* trim leading '-' in case thee's one */ + if (*dflts == '-') + dfl = dflts + 1; + else + dfl = dflts; + + /* + * Chop the defaults up + */ + rvec = strsplit(dfl, ' ', '\"'); + + if (gopt.flags & CFM_SELECTORS_IN_DEFAULTS) { + /* + * Pick whichever first entry matched the list of selectors. + * Strip the selectors from the string, and assign to dfl the + * rest of the string. + */ + if (rvec) { + am_opts ap; + am_ops *pt; + char **sp = rvec; + while (*sp) { /* loop until you find something, if any */ + memset((char *) &ap, 0, sizeof(am_opts)); + /* + * This next routine cause many spurious "expansion of ... is" + * messages, which are ignored, b/c all we need out of this + * routine is to match selectors. These spurious messages may + * be wrong, esp. if they try to expand ${key} b/c it will + * get expanded to "/defaults" + */ + pt = ops_match(&ap, *sp, "", mp->am_path, "/defaults", + mp->am_parent->am_mnt->mf_info); + free_opts(&ap); /* don't leak */ + if (pt == &amfs_error_ops) { + plog(XLOG_MAP, "did not match defaults for \"%s\"", *sp); + } else { + dfl = strip_selectors(*sp, "/defaults"); + plog(XLOG_MAP, "matched default selectors \"%s\"", dfl); + break; + } + ++sp; + } + } + } else { /* not selectors_in_defaults */ + /* + * Extract first value + */ + dfl = rvec[0]; + } + + /* + * If there were any values at all... + */ + if (dfl) { + /* + * Log error if there were other values + */ + if (!(gopt.flags & CFM_SELECTORS_IN_DEFAULTS) && rvec[1]) { + dlog("/defaults chopped into %s", dfl); + plog(XLOG_USER, "More than a single value for /defaults in %s", mf->mf_info); + } + + /* + * Prepend to existing defaults if they exist, + * otherwise just use these defaults. + */ + if (*def_opts && *dfl) { + size_t l = strlen(def_opts) + strlen(dfl) + 2; + char *nopts = (char *) xmalloc(l); + xsnprintf(nopts, l, "%s;%s", dfl, def_opts); + XFREE(def_opts); + def_opts = nopts; + } else if (*dfl) { + def_opts = strealloc(def_opts, dfl); + } + } + + XFREE(dflts); + + /* don't need info vector any more */ + if (rvec) + XFREE(rvec); + + return def_opts; +} + + +am_node * +amfs_generic_mount_child(am_node *new_mp, int *error_return) +{ + int error; + struct continuation *cp; /* Continuation structure if need to mount */ + + dlog("in amfs_generic_mount_child"); + + *error_return = error = 0; /* Error so far */ + + /* we have an errorfs attached to the am_node, free it */ + free_mntfs(new_mp->am_mnt); + new_mp->am_mnt = 0; + + /* + * Construct a continuation + */ + cp = ALLOC(struct continuation); + cp->callout = 0; + cp->mp = new_mp; + cp->retry = TRUE; + cp->start = clocktime(NULL); + cp->mf = new_mp->am_mfarray; + + /* + * Try and mount the file system. If this succeeds immediately (possible + * for a ufs file system) then return the attributes, otherwise just + * return an error. + */ + error = amfs_bgmount(cp); + reschedule_timeout_mp(); + if (!error) + return new_mp; + + /* + * Code for quick reply. If current_transp is set, then it's the + * transp that's been passed down from nfs_program_2() or from + * autofs_program_[123](). + * If new_mp->am_transp is not already set, set it by copying in + * current_transp. Once am_transp is set, nfs_quick_reply() and + * autofs_mount_succeeded() can use it to send a reply to the + * client that requested this mount. + */ + if (current_transp && !new_mp->am_transp) { + dlog("Saving RPC transport for %s", new_mp->am_path); + new_mp->am_transp = (SVCXPRT *) xmalloc(sizeof(SVCXPRT)); + *(new_mp->am_transp) = *current_transp; + } + if (error && (new_mp->am_mnt->mf_ops == &amfs_error_ops)) + new_mp->am_error = error; + + if (new_mp->am_error > 0) + assign_error_mntfs(new_mp); + + ereturn(error); +} + + +/* + * Automount interface to RPC lookup routine + * Find the corresponding entry and return + * the file handle for it. + */ +am_node * +amfs_generic_lookup_child(am_node *mp, char *fname, int *error_return, int op) +{ + am_node *new_mp; + mntfs **mf_array; + int mp_error; + + dlog("in amfs_generic_lookup_child"); + + *error_return = 0; + new_mp = amfs_lookup_node(mp, fname, error_return); + + /* return if we got an error */ + if (!new_mp || *error_return > 0) + return new_mp; + + /* also return if it's already mounted and known to be up */ + if (*error_return == 0 && FSRV_ISUP(new_mp->am_mnt->mf_server)) + return new_mp; + + switch (op) { + case VLOOK_DELETE: + /* + * If doing a delete then don't create again! + */ + ereturn(ENOENT); + case VLOOK_LOOKUP: + return new_mp; + } + + /* save error_return */ + mp_error = *error_return; + + mf_array = amfs_lookup_mntfs(new_mp, error_return); + if (!mf_array) { + new_mp->am_error = new_mp->am_mnt->mf_error = *error_return; + free_map(new_mp); + return NULL; + } + + /* + * Already mounted but known to be down: + * check if we have any alternatives to mount + */ + if (mp_error == 0) { + mntfs **mfp; + for (mfp = mf_array; *mfp; mfp++) + if (*mfp != new_mp->am_mnt) + break; + if (*mfp != NULL) { + /* + * we found an alternative, so try mounting again. + */ + *error_return = -1; + } else { + for (mfp = mf_array; *mfp; mfp++) + free_mntfs(*mfp); + XFREE(mf_array); + if (new_mp->am_flags & AMF_SOFTLOOKUP) { + ereturn(EIO); + } else { + *error_return = 0; + return new_mp; + } + } + } + + /* store the array inside the am_node */ + new_mp->am_mfarray = mf_array; + + /* + * Note: while it might seem like a good idea to prioritize + * the list of mntfs's we got here, it probably isn't. + * It would ignore the ordering of entries specified by the user, + * which is counterintuitive and confusing. + */ + return new_mp; +} + + +void +amfs_generic_mounted(mntfs *mf) +{ + amfs_mkcacheref(mf); +} + + +/* + * Unmount an automount sub-node + */ +int +amfs_generic_umount(am_node *mp, mntfs *mf) +{ + int error = 0; + +#ifdef HAVE_FS_AUTOFS + int unmount_flags = (mf->mf_flags & MFF_ON_AUTOFS) ? AMU_UMOUNT_AUTOFS : 0; + if (mf->mf_flags & MFF_IS_AUTOFS) + error = UMOUNT_FS(mp->am_path, mnttab_file_name, unmount_flags); +#endif /* HAVE_FS_AUTOFS */ + + return error; +} + + +char * +amfs_generic_match(am_opts *fo) +{ + char *p; + + if (!fo->opt_rfs) { + plog(XLOG_USER, "amfs_generic_match: no mount point named (rfs:=)"); + return 0; + } + if (!fo->opt_fs) { + plog(XLOG_USER, "amfs_generic_match: no map named (fs:=)"); + return 0; + } + + /* + * Swap round fs:= and rfs:= options + * ... historical (jsp) + */ + p = fo->opt_rfs; + fo->opt_rfs = fo->opt_fs; + fo->opt_fs = p; + + /* + * mtab entry turns out to be the name of the mount map + */ + return strdup(fo->opt_rfs ? fo->opt_rfs : "."); +} diff --git a/contrib/amd/amd/amfs_host.c b/contrib/amd/amd/amfs_host.c index ad0887ccf0c8..55423c46ea33 100644 --- a/contrib/amd/amd/amfs_host.c +++ b/contrib/amd/amd/amfs_host.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: amfs_host.c,v 1.4.2.7 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/amfs_host.c * */ @@ -57,10 +56,10 @@ #include <amd.h> static char *amfs_host_match(am_opts *fo); -static int amfs_host_fmount(mntfs *mf); -static int amfs_host_fumount(mntfs *mf); static int amfs_host_init(mntfs *mf); -static void amfs_host_umounted(am_node *mp); +static int amfs_host_mount(am_node *am, mntfs *mf); +static int amfs_host_umount(am_node *am, mntfs *mf); +static void amfs_host_umounted(mntfs *mf); /* * Ops structure @@ -70,17 +69,20 @@ am_ops amfs_host_ops = "host", amfs_host_match, amfs_host_init, - amfs_auto_fmount, - amfs_host_fmount, - amfs_auto_fumount, - amfs_host_fumount, - amfs_error_lookuppn, + amfs_host_mount, + amfs_host_umount, + amfs_error_lookup_child, + amfs_error_mount_child, amfs_error_readdir, 0, /* amfs_host_readlink */ 0, /* amfs_host_mounted */ amfs_host_umounted, find_nfs_srvr, - FS_MKMNT | FS_BACKGROUND | FS_AMQINFO + 0, /* amfs_host_get_wchan */ + FS_MKMNT | FS_BACKGROUND | FS_AMQINFO, +#ifdef HAVE_FS_AUTOFS + AUTOFS_HOST_FS_FLAGS, +#endif /* HAVE_FS_AUTOFS */ }; @@ -95,21 +97,21 @@ am_ops amfs_host_ops = * allows the entire PC disk to be mounted. */ static void -make_mntpt(char *mntpt, const exports ex, const mntfs *mf) +make_mntpt(char *mntpt, size_t l, const exports ex, const char *mf_mount) { if (ex->ex_dir[0] == '/') { if (ex->ex_dir[1] == 0) - strcpy(mntpt, (mf)->mf_mount); + xstrlcpy(mntpt, mf_mount, l); else - sprintf(mntpt, "%s%s", mf->mf_mount, ex->ex_dir); + xsnprintf(mntpt, l, "%s%s", mf_mount, ex->ex_dir); } else if (ex->ex_dir[0] >= 'a' && ex->ex_dir[0] <= 'z' && ex->ex_dir[1] == ':' && ex->ex_dir[2] == '/' && ex->ex_dir[3] == 0) - sprintf(mntpt, "%s/%c%%", mf->mf_mount, ex->ex_dir[0]); + xsnprintf(mntpt, l, "%s/%c%%", mf_mount, ex->ex_dir[0]); else - sprintf(mntpt, "%s/%s", mf->mf_mount, ex->ex_dir); + xsnprintf(mntpt, l, "%s/%s", mf_mount, ex->ex_dir); } @@ -134,8 +136,7 @@ amfs_host_match(am_opts *fo) static int amfs_host_init(mntfs *mf) { - fserver *fs; - u_short port; + u_short mountd_port; if (strchr(mf->mf_info, ':') == 0) return ENOENT; @@ -152,41 +153,39 @@ amfs_host_init(mntfs *mf) */ /* * First, we find the fileserver for this mntfs and then call - * nfs_srvr_port with our mntfs passed as the wait channel. - * nfs_srvr_port will check some things and then schedule + * get_mountd_port with our mntfs passed as the wait channel. + * get_mountd_port will check some things and then schedule * it so that when the fileserver is ready, a wakeup is done - * on this mntfs. amfs_auto_cont() is already sleeping on this mntfs - * so as soon as that wakeup happens amfs_auto_cont() is called and + * on this mntfs. amfs_cont() is already sleeping on this mntfs + * so as soon as that wakeup happens amfs_cont() is called and * this mount is retried. */ - if ((fs = mf->mf_server)) + if (mf->mf_server) /* * We don't really care if there's an error returned. * Since this is just to help speed things along, the * error will get handled properly elsewhere. */ - (void) nfs_srvr_port(fs, &port, (voidp) mf); + get_mountd_port(mf->mf_server, &mountd_port, get_mntfs_wchan(mf)); return 0; } static int -do_mount(am_nfs_handle_t *fhp, char *dir, char *fs_name, char *opts, mntfs *mf) +do_mount(am_nfs_handle_t *fhp, char *mntdir, char *fs_name, mntfs *mf) { struct stat stb; -#ifdef DEBUG - dlog("amfs_host: mounting fs %s on %s\n", fs_name, dir); -#endif /* DEBUG */ + dlog("amfs_host: mounting fs %s on %s\n", fs_name, mntdir); - (void) mkdirs(dir, 0555); - if (stat(dir, &stb) < 0 || (stb.st_mode & S_IFMT) != S_IFDIR) { - plog(XLOG_ERROR, "No mount point for %s - skipping", dir); + (void) mkdirs(mntdir, 0555); + if (stat(mntdir, &stb) < 0 || (stb.st_mode & S_IFMT) != S_IFDIR) { + plog(XLOG_ERROR, "No mount point for %s - skipping", mntdir); return ENOENT; } - return mount_nfs_fh(fhp, dir, fs_name, opts, mf); + return mount_nfs_fh(fhp, mntdir, fs_name, mf); } @@ -208,6 +207,10 @@ fetch_fhandle(CLIENT *client, char *dir, am_nfs_handle_t *fhp, u_long nfs_versio { struct timeval tv; enum clnt_stat clnt_stat; + struct fhstatus res; +#ifdef HAVE_FS_NFS3 + struct am_mountres3 res3; +#endif /* HAVE_FS_NFS3 */ /* * Pick a number, any number... @@ -215,9 +218,7 @@ fetch_fhandle(CLIENT *client, char *dir, am_nfs_handle_t *fhp, u_long nfs_versio tv.tv_sec = 20; tv.tv_usec = 0; -#ifdef DEBUG dlog("Fetching fhandle for %s", dir); -#endif /* DEBUG */ /* * Call the mount daemon on the remote host to @@ -227,25 +228,28 @@ fetch_fhandle(CLIENT *client, char *dir, am_nfs_handle_t *fhp, u_long nfs_versio plog(XLOG_INFO, "fetch_fhandle: NFS version %d", (int) nfs_version); #ifdef HAVE_FS_NFS3 if (nfs_version == NFS_VERSION3) { - memset((char *) &fhp->v3, 0, sizeof(fhp->v3)); + memset((char *) &res3, 0, sizeof(res3)); clnt_stat = clnt_call(client, MOUNTPROC_MNT, (XDRPROC_T_TYPE) xdr_dirpath, (SVC_IN_ARG_TYPE) &dir, - (XDRPROC_T_TYPE) xdr_mountres3, - (SVC_IN_ARG_TYPE) &fhp->v3, + (XDRPROC_T_TYPE) xdr_am_mountres3, + (SVC_IN_ARG_TYPE) &res3, tv); if (clnt_stat != RPC_SUCCESS) { plog(XLOG_ERROR, "mountd rpc failed: %s", clnt_sperrno(clnt_stat)); return EIO; } /* Check the status of the filehandle */ - if ((errno = fhp->v3.fhs_status)) { -#ifdef DEBUG + if ((errno = res3.fhs_status)) { dlog("fhandle fetch for mount version 3 failed: %m"); -#endif /* DEBUG */ return errno; } + memset((voidp) &fhp->v3, 0, sizeof(am_nfs_fh3)); + fhp->v3.am_fh3_length = res3.mountres3_u.mountinfo.fhandle.fhandle3_len; + memmove(fhp->v3.am_fh3_data, + res3.mountres3_u.mountinfo.fhandle.fhandle3_val, + fhp->v3.am_fh3_length); } else { /* not NFS_VERSION3 mount */ #endif /* HAVE_FS_NFS3 */ clnt_stat = clnt_call(client, @@ -253,20 +257,19 @@ fetch_fhandle(CLIENT *client, char *dir, am_nfs_handle_t *fhp, u_long nfs_versio (XDRPROC_T_TYPE) xdr_dirpath, (SVC_IN_ARG_TYPE) &dir, (XDRPROC_T_TYPE) xdr_fhstatus, - (SVC_IN_ARG_TYPE) &fhp->v2, + (SVC_IN_ARG_TYPE) &res, tv); if (clnt_stat != RPC_SUCCESS) { plog(XLOG_ERROR, "mountd rpc failed: %s", clnt_sperrno(clnt_stat)); return EIO; } /* Check status of filehandle */ - if (fhp->v2.fhs_status) { - errno = fhp->v2.fhs_status; -#ifdef DEBUG + if (res.fhs_status) { + errno = res.fhs_status; dlog("fhandle fetch for mount version 1 failed: %m"); -#endif /* DEBUG */ return errno; } + memmove(&fhp->v2, &res.fhs_fh, NFS_FHSIZE); #ifdef HAVE_FS_NFS3 } /* end of "if (nfs_version == NFS_VERSION3)" statement */ #endif /* HAVE_FS_NFS3 */ @@ -291,11 +294,8 @@ already_mounted(mntlist *mlist, char *dir) } -/* - * Mount the export tree from a host - */ static int -amfs_host_fmount(mntfs *mf) +amfs_host_mount(am_node *am, mntfs *mf) { struct timeval tv2; CLIENT *client; @@ -317,6 +317,14 @@ amfs_host_fmount(mntfs *mf) u_long mnt_version; /* + * WebNFS servers don't necessarily run mountd. + */ + if (mf->mf_flags & MFF_WEBNFS) { + plog(XLOG_ERROR, "amfs_host_mount: cannot support WebNFS"); + return EIO; + } + + /* * Read the mount list */ mlist = read_mtab(mf->mf_mount, mnttab_file_name); @@ -334,10 +342,10 @@ amfs_host_fmount(mntfs *mf) */ host = mf->mf_server->fs_host; sin = *mf->mf_server->fs_ip; - plog(XLOG_INFO, "amfs_host_fmount: NFS version %d", (int) mf->mf_server->fs_version); + plog(XLOG_INFO, "amfs_host_mount: NFS version %d", (int) mf->mf_server->fs_version); #ifdef HAVE_FS_NFS3 if (mf->mf_server->fs_version == NFS_VERSION3) - mnt_version = MOUNTVERS3; + mnt_version = AM_MOUNTVERS3; else #endif /* HAVE_FS_NFS3 */ mnt_version = MOUNTVERS; @@ -374,9 +382,7 @@ amfs_host_fmount(mntfs *mf) } client->cl_auth = nfs_auth; -#ifdef DEBUG dlog("Fetching export list from %s", host); -#endif /* DEBUG */ /* * Fetch the export list @@ -392,7 +398,7 @@ amfs_host_fmount(mntfs *mf) tv2); if (clnt_stat != RPC_SUCCESS) { const char *msg = clnt_sperrno(clnt_stat); - plog(XLOG_ERROR, "host_fmount rpc failed: %s", msg); + plog(XLOG_ERROR, "host_mount rpc failed: %s", msg); /* clnt_perror(client, "rpc"); */ error = EIO; goto out; @@ -412,7 +418,7 @@ amfs_host_fmount(mntfs *mf) */ ep = (exports *) xmalloc(n_export * sizeof(exports)); for (j = 0, ex = exlist; ex; ex = ex->ex_next) { - make_mntpt(mntpt, ex, mf); + make_mntpt(mntpt, sizeof(mntpt), ex, mf->mf_mount); if (already_mounted(mlist, mntpt)) /* we have at least one mounted f/s, so don't fail the mount */ ok = TRUE; @@ -442,9 +448,7 @@ amfs_host_fmount(mntfs *mf) for (j = k = 0; j < n_export; j++) { /* Check and avoid a duplicated export entry */ if (j > k && ep[k] && STREQ(ep[j]->ex_dir, ep[k]->ex_dir)) { -#ifdef DEBUG dlog("avoiding dup fhandle requested for %s", ep[j]->ex_dir); -#endif /* DEBUG */ ep[j] = 0; } else { k = j; @@ -461,9 +465,9 @@ amfs_host_fmount(mntfs *mf) * error code 0 at the end. If they all fail then return * the last error code. */ - strncpy(fs_name, mf->mf_info, sizeof(fs_name)); + xstrlcpy(fs_name, mf->mf_info, MAXPATHLEN); if ((rfs_dir = strchr(fs_name, ':')) == (char *) 0) { - plog(XLOG_FATAL, "amfs_host_fmount: mf_info has no colon"); + plog(XLOG_FATAL, "amfs_host_mount: mf_info has no colon"); error = EINVAL; goto out; } @@ -471,9 +475,15 @@ amfs_host_fmount(mntfs *mf) for (j = 0; j < n_export; j++) { ex = ep[j]; if (ex) { - strcpy(rfs_dir, ex->ex_dir); - make_mntpt(mntpt, ex, mf); - if (do_mount(&fp[j], mntpt, fs_name, mf->mf_mopts, mf) == 0) + /* + * Note: the sizeof space left in rfs_dir is what's left in fs_name + * after strchr() above returned a pointer _inside_ fs_name. The + * calculation below also takes into account that rfs_dir was + * incremented by the ++ above. + */ + xstrlcpy(rfs_dir, ex->ex_dir, sizeof(fs_name) - (rfs_dir - fs_name)); + make_mntpt(mntpt, sizeof(mntpt), ex, mf->mf_mount); + if (do_mount(&fp[j], mntpt, fs_name, mf) == 0) ok = TRUE; } } @@ -522,9 +532,10 @@ directory_prefix(char *pref, char *dir) * Unmount a mount tree */ static int -amfs_host_fumount(mntfs *mf) +amfs_host_umount(am_node *am, mntfs *mf) { mntlist *ml, *mprev; + int unmount_flags = (mf->mf_flags & MFF_ON_AUTOFS) ? AMU_UMOUNT_AUTOFS : 0; int xerror = 0; /* @@ -559,18 +570,24 @@ amfs_host_fumount(mntfs *mf) char *dir = ml->mnt->mnt_dir; if (directory_prefix(mf->mf_mount, dir)) { int error; -#ifdef DEBUG dlog("amfs_host: unmounts %s", dir); -#endif /* DEBUG */ /* * Unmount "dir" */ - error = UMOUNT_FS(dir, mnttab_file_name); + error = UMOUNT_FS(dir, mnttab_file_name, unmount_flags); /* * Keep track of errors */ if (error) { - if (!xerror) + /* + * If we have not already set xerror and error is not ENOENT, + * then set xerror equal to error and log it. + * 'xerror' is the return value for this function. + * + * We do not want to pass ENOENT as an error because if the + * directory does not exists our work is done anyway. + */ + if (!xerror && error != ENOENT) xerror = error; if (error != EBUSY) { errno = error; @@ -591,7 +608,7 @@ amfs_host_fumount(mntfs *mf) * Try to remount, except when we are shutting down. */ if (xerror && amd_state != Finishing) { - xerror = amfs_host_fmount(mf); + xerror = amfs_host_mount(am, mf); if (!xerror) { /* * Don't log this - it's usually too verbose @@ -611,9 +628,8 @@ amfs_host_fumount(mntfs *mf) * mountd protocol is badly broken anyway. */ static void -amfs_host_umounted(am_node *mp) +amfs_host_umounted(mntfs *mf) { - mntfs *mf = mp->am_mnt; char *host; CLIENT *client; enum clnt_stat clnt_stat; @@ -626,6 +642,14 @@ amfs_host_umounted(am_node *mp) return; /* + * WebNFS servers shouldn't ever get here. + */ + if (mf->mf_flags & MFF_WEBNFS) { + plog(XLOG_ERROR, "amfs_host_umounted: cannot support WebNFS"); + return; + } + + /* * Take a copy of the server hostname, address, and NFS version * to mount version conversion. */ @@ -634,7 +658,7 @@ amfs_host_umounted(am_node *mp) plog(XLOG_INFO, "amfs_host_umounted: NFS version %d", (int) mf->mf_server->fs_version); #ifdef HAVE_FS_NFS3 if (mf->mf_server->fs_version == NFS_VERSION3) - mnt_version = MOUNTVERS3; + mnt_version = AM_MOUNTVERS3; else #endif /* HAVE_FS_NFS3 */ mnt_version = MOUNTVERS; @@ -661,9 +685,7 @@ amfs_host_umounted(am_node *mp) } client->cl_auth = nfs_auth; -#ifdef DEBUG dlog("Unmounting all from %s", host); -#endif /* DEBUG */ clnt_stat = clnt_call(client, MOUNTPROC_UMNTALL, diff --git a/contrib/amd/amd/amfs_link.c b/contrib/amd/amd/amfs_link.c index 55552ae91d5d..e75ab862f8bc 100644 --- a/contrib/amd/amd/amfs_link.c +++ b/contrib/amd/amd/amfs_link.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: amfs_link.c,v 1.3.2.4 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/amfs_link.c * */ @@ -52,6 +51,9 @@ #include <am_defs.h> #include <amd.h> +/* forward declarations */ +static int amfs_link_mount(am_node *mp, mntfs *mf); +static int amfs_link_umount(am_node *mp, mntfs *mf); /* * Ops structures @@ -61,17 +63,20 @@ am_ops amfs_link_ops = "link", amfs_link_match, 0, /* amfs_link_init */ - amfs_auto_fmount, - amfs_link_fmount, - amfs_auto_fumount, - amfs_link_fumount, - amfs_error_lookuppn, + amfs_link_mount, + amfs_link_umount, + amfs_error_lookup_child, + amfs_error_mount_child, amfs_error_readdir, 0, /* amfs_link_readlink */ 0, /* amfs_link_mounted */ 0, /* amfs_link_umounted */ - find_amfs_auto_srvr, - 0 + amfs_generic_find_srvr, + 0, /* nfs_fs_flags */ + 0, /* amfs_link_get_wchan */ +#ifdef HAVE_FS_AUTOFS + AUTOFS_LINK_FS_FLAGS, +#endif /* HAVE_FS_AUTOFS */ }; @@ -88,54 +93,41 @@ amfs_link_match(am_opts *fo) } /* - * Bug report (14/12/89) from Jay Plett <jay@princeton.edu> - * If an automount point has the same name as an existing - * link type mount Amd hits a race condition and either hangs - * or causes a symlink loop. + * If the link target points to another mount point, then we could + * end up with an unpleasant situation, where the link f/s simply + * "assumes" the mntfs of that mount point. * - * If fs begins with a '/' change the opt_fs & opt_sublink - * fields so that the fs option doesn't end up pointing at - * an existing symlink. + * For example, if the link points to /usr, and /usr is a real ufs + * filesystem, then the link f/s will use the inherited ufs mntfs, + * and the end result will be that it will become unmountable. * - * If sublink is nil then set sublink to fs - * else set sublink to fs / sublink + * To prevent this, we use a hack: we prepend a dot ('.') to opt_fs if + * its original value was an absolute path, so that it will never match + * any other mntfs. * - * Finally set fs to ".". + * XXX: a less hacky solution should be used... */ - if (*fo->opt_fs == '/') { - char *fullpath; - char *link = fo->opt_sublink; - if (link) { - if (*link == '/') - fullpath = strdup(link); - else - fullpath = str3cat((char *) 0, fo->opt_fs, "/", link); - } else { - fullpath = strdup(fo->opt_fs); - } - - if (fo->opt_sublink) - XFREE(fo->opt_sublink); - fo->opt_sublink = fullpath; - fo->opt_fs = str3cat(fo->opt_fs, ".", fullpath, ""); + if (fo->opt_fs[0] == '/') { + char *link_hack = str3cat(NULL, ".", fo->opt_fs, ""); + if (!fo->opt_sublink) + fo->opt_sublink = strdup(fo->opt_fs); + XFREE(fo->opt_fs); + fo->opt_fs = link_hack; } return strdup(fo->opt_fs); } -int -amfs_link_fmount(mntfs *mf) +static int +amfs_link_mount(am_node *mp, mntfs *mf) { - /* - * Wow - this is hard to implement! :-) - */ return 0; } -int -amfs_link_fumount(mntfs *mf) +static int +amfs_link_umount(am_node *mp, mntfs *mf) { return 0; } diff --git a/contrib/amd/amd/amfs_linkx.c b/contrib/amd/amd/amfs_linkx.c index c7c9b7998ca7..e306eda91d3b 100644 --- a/contrib/amd/amd/amfs_linkx.c +++ b/contrib/amd/amd/amfs_linkx.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: amfs_linkx.c,v 1.3.2.4 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/amfs_linkx.c * */ @@ -53,7 +52,8 @@ #include <amd.h> /* forward declarations */ -static int amfs_linkx_mount(am_node *mp); +static int amfs_linkx_mount(am_node *mp, mntfs *mf); +static int amfs_linkx_umount(am_node *mp, mntfs *mf); /* * linkx operations @@ -64,21 +64,24 @@ struct am_ops amfs_linkx_ops = amfs_link_match, 0, /* amfs_linkx_init */ amfs_linkx_mount, - 0, - amfs_auto_fumount, - amfs_link_fumount, - amfs_error_lookuppn, + amfs_linkx_umount, + amfs_error_lookup_child, + amfs_error_mount_child, amfs_error_readdir, 0, /* amfs_linkx_readlink */ 0, /* amfs_linkx_mounted */ 0, /* amfs_linkx_umounted */ - find_amfs_auto_srvr, - FS_MBACKGROUND + amfs_generic_find_srvr, + 0, /* amfs_linkx_get_wchan */ + FS_MBACKGROUND, +#ifdef HAVE_FS_AUTOFS + AUTOFS_LINKX_FS_FLAGS, +#endif /* HAVE_FS_AUTOFS */ }; static int -amfs_linkx_mount(am_node *mp) +amfs_linkx_mount(am_node *mp, mntfs *mf) { /* * Check for existence of target. @@ -89,7 +92,7 @@ amfs_linkx_mount(am_node *mp) if (mp->am_link) ln = mp->am_link; else /* should never occur */ - ln = mp->am_mnt->mf_mount; + ln = mf->mf_mount; /* * Use lstat, not stat, since we don't @@ -101,3 +104,10 @@ amfs_linkx_mount(am_node *mp) return 0; } + + +static int +amfs_linkx_umount(am_node *mp, mntfs *mf) +{ + return 0; +} diff --git a/contrib/amd/amd/amfs_nfsl.c b/contrib/amd/amd/amfs_nfsl.c index bed6f4db438e..bb48f0efd255 100644 --- a/contrib/amd/amd/amfs_nfsl.c +++ b/contrib/amd/amd/amfs_nfsl.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: amfs_nfsl.c,v 1.4.2.4 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/amfs_nfsl.c * */ @@ -60,9 +59,9 @@ /* forward declarations */ static char *amfs_nfsl_match(am_opts *fo); static int amfs_nfsl_init(mntfs *mf); -static int amfs_nfsl_fmount(mntfs *mf); -static int amfs_nfsl_fumount(mntfs *mf); -static void amfs_nfsl_umounted(am_node *mp); +static int amfs_nfsl_mount(am_node *mp, mntfs *mf); +static int amfs_nfsl_umount(am_node *mp, mntfs *mf); +static void amfs_nfsl_umounted(mntfs *mf); static fserver *amfs_nfsl_ffserver(mntfs *mf); /* @@ -70,20 +69,23 @@ static fserver *amfs_nfsl_ffserver(mntfs *mf); */ am_ops amfs_nfsl_ops = { - "nfsl", /* name of file system */ - amfs_nfsl_match, /* match */ - amfs_nfsl_init, /* initialize */ - amfs_auto_fmount, /* mount vnode */ - amfs_nfsl_fmount, /* mount vfs */ - amfs_auto_fumount, /* unmount vnode */ - amfs_nfsl_fumount, /* unmount VFS */ - amfs_error_lookuppn, /* lookup path-name */ - amfs_error_readdir, /* read directory */ - 0, /* read link */ - 0, /* after-mount extra actions */ - amfs_nfsl_umounted, /* after-umount extra actions */ - amfs_nfsl_ffserver, /* find a file server */ - FS_MKMNT | FS_BACKGROUND | FS_AMQINFO /* flags */ + "nfsl", + amfs_nfsl_match, + amfs_nfsl_init, + amfs_nfsl_mount, + amfs_nfsl_umount, + amfs_error_lookup_child, + amfs_error_mount_child, + amfs_error_readdir, + 0, /* amfs_nfsl_readlink */ + 0, /* amfs_nfsl_mounted */ + amfs_nfsl_umounted, + amfs_nfsl_ffserver, + 0, /* amfs_nfsl_get_wchan */ + FS_MKMNT | FS_BACKGROUND | FS_AMQINFO, /* nfs_fs_flags */ +#ifdef HAVE_FS_AUTOFS + AUTOFS_NFSL_FS_FLAGS, +#endif /* HAVE_FS_AUTOFS */ }; @@ -94,10 +96,16 @@ am_ops amfs_nfsl_ops = static char * amfs_nfsl_match(am_opts *fo) { - char *cp = fo->opt_fs; + char *cp; char *ho = fo->opt_rhost; + char *retval; struct stat stb; + if (fo->opt_sublink) + cp = fo->opt_sublink; + else + cp = fo->opt_fs; + if (!cp || !ho) { plog(XLOG_USER, "amfs_nfsl: host $fs and $rhost must be specified"); return NULL; @@ -105,20 +113,20 @@ amfs_nfsl_match(am_opts *fo) /* * If this host is not the same as $rhost, or if link does not exist, - * perform nfs_match(), same as for type:=nfs. - * If link value exists (or same host), then perform amfs_link_match(), - * same as for linkx. + * call nfs_ops.fs_match(). + * If link value exists (or same host), call amfs_link_ops.fs_match(). */ if (!STRCEQ(ho, am_get_hostname())) { plog(XLOG_INFO, "amfs_nfsl: \"%s\" is not local host, using type:=nfs", ho); - return nfs_match(fo); + retval = nfs_ops.fs_match(fo); } else if (lstat(cp, &stb) < 0) { plog(XLOG_INFO, "amfs_nfsl: \"%s\" does not exist, using type:=nfs", cp); - return nfs_match(fo); + retval = nfs_ops.fs_match(fo); } else { plog(XLOG_INFO, "amfs_nfsl: \"%s\" exists, using type:=link", cp); - return amfs_link_match(fo); + retval = amfs_link_ops.fs_match(fo); } + return retval; } @@ -129,15 +137,15 @@ amfs_nfsl_match(am_opts *fo) static int amfs_nfsl_init(mntfs *mf) { - /* - * If a link, do nothing (same as type:=link). - * If non-link, do nfs_init (same as type:=nfs). - */ + int ret = 0; if (mf->mf_flags & MFF_NFSLINK) { - return 0; + if (amfs_link_ops.fs_init) + ret = amfs_link_ops.fs_init(mf); } else { - return nfs_init(mf); + if (nfs_ops.fs_init) + ret = nfs_ops.fs_init(mf); } + return ret; } @@ -146,17 +154,17 @@ amfs_nfsl_init(mntfs *mf) * Returns: 0 if OK, non-zero (errno) if failed. */ static int -amfs_nfsl_fmount(mntfs *mf) +amfs_nfsl_mount(am_node *mp, mntfs *mf) { - /* - * If a link, do run amfs_link_fmount() (same as type:=link) - * If non-link, do nfs_fmount (same as type:=nfs). - */ + int ret = 0; if (mf->mf_flags & MFF_NFSLINK) { - return amfs_link_fmount(mf); + if (amfs_link_ops.mount_fs) + ret = amfs_link_ops.mount_fs(mp, mf); } else { - return nfs_fmount(mf); + if (nfs_ops.mount_fs) + ret = nfs_ops.mount_fs(mp, mf); } + return ret; } @@ -165,17 +173,17 @@ amfs_nfsl_fmount(mntfs *mf) * Returns: 0 if OK, non-zero (errno) if failed. */ static int -amfs_nfsl_fumount(mntfs *mf) +amfs_nfsl_umount(am_node *mp, mntfs *mf) { - /* - * If a link, do run amfs_link_fumount() (same as type:=link) - * If non-link, do nfs_fumount (same as type:=nfs). - */ + int ret = 0; if (mf->mf_flags & MFF_NFSLINK) { - return amfs_link_fumount(mf); + if (amfs_link_ops.umount_fs) + ret = amfs_link_ops.umount_fs(mp, mf); } else { - return nfs_fumount(mf); + if (nfs_ops.umount_fs) + ret = nfs_ops.umount_fs(mp, mf); } + return ret; } @@ -186,27 +194,14 @@ amfs_nfsl_fumount(mntfs *mf) * See amfs_auto_umounted(), host_umounted(), nfs_umounted(). */ static void -amfs_nfsl_umounted(am_node *mp) +amfs_nfsl_umounted(mntfs *mf) { - mntfs *mf = mp->am_mnt; - - /* - * If a link, do nothing (same as type:=link) - * If non-link, do nfs_fumount (same as type:=nfs). - */ if (mf->mf_flags & MFF_NFSLINK) { - return; + if (amfs_link_ops.umounted) + amfs_link_ops.umounted(mf); } else { - nfs_umounted(mp); - /* - * MUST remove mount point directories, because if they remain - * behind, the next nfsl access will think they are a link - * type file system, and not NFS! (when it performs link target - * existence test) - */ - if (mf->mf_flags & MFF_MKMNT) - rmdirs(mf->mf_mount); - return; + if (nfs_ops.umounted) + nfs_ops.umounted(mf); } } @@ -218,20 +213,26 @@ amfs_nfsl_umounted(am_node *mp) static fserver * amfs_nfsl_ffserver(mntfs *mf) { - char *cp = mf->mf_fo->opt_fs; + char *cp; char *ho = mf->mf_fo->opt_rhost; struct stat stb; + if (mf->mf_fo->opt_sublink) + cp = mf->mf_fo->opt_sublink; + else + cp = mf->mf_fo->opt_fs; + /* * If this host is not the same as $rhost, or if link does not exist, - * perform find_nfs_srvr(), same as for type:=nfs. - * If link value exists (or same host), then perform - * find_amfs_auto_srvr(), same as for linkx. + * call amfs_link_ops.ffserver(). + * If link value exists (or same host), then call ops_nfs.ffserver(). */ if (!STRCEQ(ho, am_get_hostname()) || lstat(cp, &stb) < 0) { - return find_nfs_srvr(mf); + return nfs_ops.ffserver(mf); } else { mf->mf_flags |= MFF_NFSLINK; - return find_amfs_auto_srvr(mf); + /* remove the FS_MKMNT flag, we don't want amd touching the mountpoint */ + mf->mf_fsflags &= ~FS_MKMNT; + return amfs_link_ops.ffserver(mf); } } diff --git a/contrib/amd/amd/amfs_nfsx.c b/contrib/amd/amd/amfs_nfsx.c index 7d8949bcd171..91be8af47e11 100644 --- a/contrib/amd/amd/amfs_nfsx.c +++ b/contrib/amd/amd/amfs_nfsx.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: amfs_nfsx.c,v 1.3.2.5 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/amfs_nfsx.c * */ @@ -67,13 +66,13 @@ struct amfs_nfsx { int nx_c; /* Number of elements in nx_v */ amfs_nfsx_mnt *nx_v; /* Underlying mounts */ amfs_nfsx_mnt *nx_try; + am_node *nx_mp; }; /* forward definitions */ static char *amfs_nfsx_match(am_opts *fo); -static int amfs_nfsx_fmount (mntfs *); -static int amfs_nfsx_fmount(mntfs *mf); -static int amfs_nfsx_fumount(mntfs *mf); +static int amfs_nfsx_mount(am_node *am, mntfs *mf); +static int amfs_nfsx_umount(am_node *am, mntfs *mf); static int amfs_nfsx_init(mntfs *mf); /* @@ -84,17 +83,20 @@ am_ops amfs_nfsx_ops = "nfsx", amfs_nfsx_match, amfs_nfsx_init, - amfs_auto_fmount, - amfs_nfsx_fmount, - amfs_auto_fumount, - amfs_nfsx_fumount, - amfs_error_lookuppn, + amfs_nfsx_mount, + amfs_nfsx_umount, + amfs_error_lookup_child, + amfs_error_mount_child, amfs_error_readdir, 0, /* amfs_nfsx_readlink */ 0, /* amfs_nfsx_mounted */ 0, /* amfs_nfsx_umounted */ find_nfs_srvr, /* XXX */ - /* FS_UBACKGROUND| */ FS_AMQINFO + 0, /* amfs_nfsx_get_wchan */ + /* FS_UBACKGROUND| */ FS_AMQINFO, /* nfs_fs_flags */ +#ifdef HAVE_FS_AUTOFS + AUTOFS_NFSX_FS_FLAGS, +#endif /* HAVE_FS_AUTOFS */ }; @@ -118,7 +120,7 @@ amfs_nfsx_match(am_opts *fo) /* set default sublink */ if (fo->opt_sublink == 0) { ptr = strchr(fo->opt_rfs, ','); - if (ptr && ptr != (fo->opt_rfs + 1)) + if (ptr && ptr > (fo->opt_rfs + 1)) fo->opt_sublink = strnsave(fo->opt_rfs + 1, ptr - fo->opt_rfs - 1); } @@ -148,17 +150,15 @@ amfs_nfsx_match(am_opts *fo) * Determine magic cookie to put in mtab */ xmtab = str3cat((char *) 0, fo->opt_rhost, ":", fo->opt_rfs); -#ifdef DEBUG dlog("NFSX: mounting remote server \"%s\", remote fs \"%s\" on \"%s\"", fo->opt_rhost, fo->opt_rfs, fo->opt_fs); -#endif /* DEBUG */ return xmtab; } static void -amfs_nfsx_prfree(voidp vp) +amfs_nfsx_prfree(opaque_t vp) { struct amfs_nfsx *nx = (struct amfs_nfsx *) vp; int i; @@ -201,7 +201,7 @@ amfs_nfsx_init(mntfs *mf) error = EINVAL; goto errexit; } - pref = host +1; + pref = host + 1; host = info; /* @@ -212,14 +212,16 @@ amfs_nfsx_init(mntfs *mf) /* * Count array size */ - for (i = 0; ivec[i]; i++) ; + for (i = 0; ivec[i]; i++) + /* nothing */; nx = ALLOC(struct amfs_nfsx); - mf->mf_private = (voidp) nx; + mf->mf_private = (opaque_t) nx; mf->mf_prfree = amfs_nfsx_prfree; nx->nx_c = i - 1; /* i-1 because we don't want the prefix */ nx->nx_v = (amfs_nfsx_mnt *) xmalloc(nx->nx_c * sizeof(amfs_nfsx_mnt)); + nx->nx_mp = 0; { char *mp = 0; char *xinfo = 0; @@ -243,11 +245,11 @@ amfs_nfsx_init(mntfs *mf) normalize_slash(xinfo); if (pref[1] != '\0') deslashify(xinfo); -#ifdef DEBUG dlog("amfs_nfsx: init mount for %s on %s", xinfo, mp); -#endif /* DEBUG */ nx->nx_v[i].n_error = -1; nx->nx_v[i].n_mnt = find_mntfs(&nfs_ops, mf->mf_fo, mp, xinfo, "", mf->mf_mopts, mf->mf_remopts); + /* propagate the on_autofs flag */ + nx->nx_v[i].n_mnt->mf_flags |= mf->mf_flags & MFF_ON_AUTOFS; } if (rfs) XFREE(rfs); @@ -274,7 +276,9 @@ amfs_nfsx_init(mntfs *mf) for (i = 0; i < nx->nx_c; i++) { amfs_nfsx_mnt *n = &nx->nx_v[i]; mntfs *m = n->n_mnt; - int error = (*m->mf_ops->fs_init) (m); + int error = 0; + if (m->mf_ops->fs_init && !(mf->mf_flags & MFF_RESTART)) + error = m->mf_ops->fs_init(m); /* * if you just "return error" here, you will have made a failure * in any submounts to fail the whole group. There was old unused code @@ -287,7 +291,7 @@ amfs_nfsx_init(mntfs *mf) glob_error = -1; if (!asked_for_wakeup) { asked_for_wakeup = 1; - sched_task(wakeup_task, (voidp) mf, (voidp) m); + sched_task(wakeup_task, (opaque_t) mf, get_mntfs_wchan(m)); } } } @@ -297,10 +301,11 @@ amfs_nfsx_init(mntfs *mf) static void -amfs_nfsx_cont(int rc, int term, voidp closure) +amfs_nfsx_cont(int rc, int term, opaque_t arg) { - mntfs *mf = (mntfs *) closure; + mntfs *mf = (mntfs *) arg; struct amfs_nfsx *nx = (struct amfs_nfsx *) mf->mf_private; + am_node *mp = nx->nx_mp; amfs_nfsx_mnt *n = nx->nx_try; n->n_mnt->mf_flags &= ~(MFF_ERROR | MFF_MOUNTING); @@ -309,7 +314,7 @@ amfs_nfsx_cont(int rc, int term, voidp closure) /* * Wakeup anything waiting for this mount */ - wakeup((voidp) n->n_mnt); + wakeup(get_mntfs_wchan(n->n_mnt)); if (rc || term) { if (term) { @@ -334,52 +339,41 @@ amfs_nfsx_cont(int rc, int term, voidp closure) /* * The mount worked. */ - mf_mounted(n->n_mnt); + mf_mounted(n->n_mnt, FALSE); /* FALSE => don't free the n_mnt->am_opts */ n->n_error = 0; } /* * Do the remaining bits */ - if (amfs_nfsx_fmount(mf) >= 0) { - wakeup((voidp) mf); - mf->mf_flags &= ~MFF_MOUNTING; - mf_mounted(mf); - } + if (amfs_nfsx_mount(mp, mf) >= 0) + wakeup(get_mntfs_wchan(mf)); } static int -try_amfs_nfsx_mount(voidp mv) +try_amfs_nfsx_mount(opaque_t mv) { mntfs *mf = (mntfs *) mv; + struct amfs_nfsx *nx = (struct amfs_nfsx *) mf->mf_private; + am_node *mp = nx->nx_mp; int error; - mf->mf_flags |= MFF_MOUNTING; - error = (*mf->mf_ops->fmount_fs) (mf); - mf->mf_flags &= ~MFF_MOUNTING; + error = mf->mf_ops->mount_fs(mp, mf); return error; } static int -amfs_nfsx_remount(mntfs *mf, int fg) +amfs_nfsx_remount(am_node *am, mntfs *mf, int fg) { struct amfs_nfsx *nx = (struct amfs_nfsx *) mf->mf_private; amfs_nfsx_mnt *n; int glob_error = -1; - for (n = nx->nx_v; n < nx->nx_v + nx->nx_c; n++) { - mntfs *m = n->n_mnt; - if (n->n_error < 0) { - if (!(m->mf_flags & MFF_MKMNT) && m->mf_ops->fs_flags & FS_MKMNT) { - int error = mkdirs(m->mf_mount, 0555); - if (!error) - m->mf_flags |= MFF_MKMNT; - } - } - } + /* Save the am_node pointer for later use */ + nx->nx_mp = am; /* * Iterate through the mntfs's and mount each filesystem @@ -387,40 +381,38 @@ amfs_nfsx_remount(mntfs *mf, int fg) */ for (n = nx->nx_v; n < nx->nx_v + nx->nx_c; n++) { mntfs *m = n->n_mnt; + + if (m->mf_flags & MFF_MOUNTING) + break; + + if (m->mf_flags & MFF_MOUNTED) { + mf_mounted(m, FALSE); /* FALSE => don't free the m->am_opts */ + n->n_error = glob_error = 0; + continue; + } + if (n->n_error < 0) { - /* - * Check fmount entry pt. exists - * and then mount... - */ - if (!m->mf_ops->fmount_fs) { - n->n_error = EINVAL; - } else { -#ifdef DEBUG - dlog("calling underlying fmount on %s", m->mf_mount); -#endif /* DEBUG */ - if (!fg && foreground && (m->mf_ops->fs_flags & FS_MBACKGROUND)) { - m->mf_flags |= MFF_MOUNTING; /* XXX */ -#ifdef DEBUG - dlog("backgrounding mount of \"%s\"", m->mf_info); -#endif /* DEBUG */ - nx->nx_try = n; - run_task(try_amfs_nfsx_mount, (voidp) m, amfs_nfsx_cont, (voidp) mf); - n->n_error = -1; - return -1; - } else { -#ifdef DEBUG - dlog("foreground mount of \"%s\" ...", mf->mf_info); -#endif /* DEBUG */ - n->n_error = (*m->mf_ops->fmount_fs) (m); - } + /* Create the mountpoint, if and as required */ + if (!(m->mf_flags & MFF_MKMNT) && m->mf_fsflags & FS_MKMNT) { + if (!mkdirs(m->mf_mount, 0555)) + m->mf_flags |= MFF_MKMNT; } -#ifdef DEBUG - if (n->n_error > 0) { - errno = n->n_error; /* XXX */ - dlog("underlying fmount of %s failed: %m", m->mf_mount); + dlog("calling underlying mount on %s", m->mf_mount); + if (!fg && foreground && (m->mf_fsflags & FS_MBACKGROUND)) { + m->mf_flags |= MFF_MOUNTING; + dlog("backgrounding mount of \"%s\"", m->mf_info); + nx->nx_try = n; + run_task(try_amfs_nfsx_mount, (opaque_t) m, amfs_nfsx_cont, (opaque_t) mf); + n->n_error = -1; + return -1; + } else { + dlog("foreground mount of \"%s\" ...", mf->mf_info); + n->n_error = m->mf_ops->mount_fs(am, m); } -#endif /* DEBUG */ + + if (n->n_error > 0) + dlog("underlying fmount of %s failed: %s", m->mf_mount, strerror(n->n_error)); if (n->n_error == 0) { glob_error = 0; @@ -435,9 +427,9 @@ amfs_nfsx_remount(mntfs *mf, int fg) static int -amfs_nfsx_fmount(mntfs *mf) +amfs_nfsx_mount(am_node *am, mntfs *mf) { - return amfs_nfsx_remount(mf, FALSE); + return amfs_nfsx_remount(am, mf, FALSE); } @@ -447,7 +439,7 @@ amfs_nfsx_fmount(mntfs *mf) * and so may hang under extremely rare conditions. */ static int -amfs_nfsx_fumount(mntfs *mf) +amfs_nfsx_umount(am_node *am, mntfs *mf) { struct amfs_nfsx *nx = (struct amfs_nfsx *) mf->mf_private; amfs_nfsx_mnt *n; @@ -469,10 +461,8 @@ amfs_nfsx_fumount(mntfs *mf) * which had been successfully unmounted. */ if (n->n_error == 0) { -#ifdef DEBUG dlog("calling underlying fumount on %s", m->mf_mount); -#endif /* DEBUG */ - n->n_error = (*m->mf_ops->fumount_fs) (m); + n->n_error = m->mf_ops->umount_fs(am, m); if (n->n_error) { glob_error = n->n_error; n->n_error = 0; @@ -490,7 +480,7 @@ amfs_nfsx_fumount(mntfs *mf) * whole lot... */ if (glob_error) { - glob_error = amfs_nfsx_remount(mf, TRUE); + glob_error = amfs_nfsx_remount(am, mf, TRUE); if (glob_error) { errno = glob_error; /* XXX */ plog(XLOG_USER, "amfs_nfsx: remount of %s failed: %m", mf->mf_mount); @@ -502,22 +492,12 @@ amfs_nfsx_fumount(mntfs *mf) */ for (n = nx->nx_v; n < nx->nx_v + nx->nx_c; n++) { mntfs *m = n->n_mnt; - am_node am; - - /* - * XXX: all the umounted handler needs is a - * mntfs pointer, so pass an am_node with the right - * pointer in it. - */ - memset((voidp) &am, 0, sizeof(am)); - am.am_mnt = m; -#ifdef DEBUG dlog("calling underlying umounted on %s", m->mf_mount); -#endif /* DEBUG */ - (*m->mf_ops->umounted) (&am); + if (m->mf_ops->umounted) + m->mf_ops->umounted(m); if (n->n_error < 0) { - if (m->mf_ops->fs_flags & FS_MKMNT) { + if (m->mf_fsflags & FS_MKMNT) { (void) rmdirs(m->mf_mount); m->mf_flags &= ~MFF_MKMNT; } diff --git a/contrib/amd/amd/amfs_program.c b/contrib/amd/amd/amfs_program.c index 795c596bef8e..843e8050c11b 100644 --- a/contrib/amd/amd/amfs_program.c +++ b/contrib/amd/amd/amfs_program.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: amfs_program.c,v 1.6.2.4 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/amfs_program.c * */ @@ -54,8 +53,8 @@ /* forward definitions */ static char *amfs_program_match(am_opts *fo); -static int amfs_program_fmount(mntfs *mf); -static int amfs_program_fumount(mntfs *mf); +static int amfs_program_mount(am_node *am, mntfs *mf); +static int amfs_program_umount(am_node *am, mntfs *mf); static int amfs_program_init(mntfs *mf); /* @@ -66,17 +65,20 @@ am_ops amfs_program_ops = "program", amfs_program_match, amfs_program_init, - amfs_auto_fmount, - amfs_program_fmount, - amfs_auto_fumount, - amfs_program_fumount, - amfs_error_lookuppn, + amfs_program_mount, + amfs_program_umount, + amfs_error_lookup_child, + amfs_error_mount_child, amfs_error_readdir, 0, /* amfs_program_readlink */ 0, /* amfs_program_mounted */ 0, /* amfs_program_umounted */ - find_amfs_auto_srvr, - FS_BACKGROUND | FS_AMQINFO + amfs_generic_find_srvr, + 0, /* amfs_program_get_wchan */ + FS_MKMNT | FS_BACKGROUND | FS_AMQINFO, /* nfs_fs_flags */ +#ifdef HAVE_FS_AUTOFS + AUTOFS_PROGRAM_FS_FLAGS, +#endif /* HAVE_FS_AUTOFS */ }; @@ -88,10 +90,19 @@ amfs_program_match(am_opts *fo) { char *prog; - if (!fo->opt_mount || !fo->opt_unmount) { - plog(XLOG_ERROR, "program: both mount and unmount must be specified"); + if (fo->opt_unmount && fo->opt_umount) { + plog(XLOG_ERROR, "program: cannot specify both unmount and umount options"); return 0; } + if (!fo->opt_mount) { + plog(XLOG_ERROR, "program: must specify mount command"); + return 0; + } + if (!fo->opt_unmount && !fo->opt_umount) { + fo->opt_unmount = str3cat(NULL, UNMOUNT_PROGRAM, " umount ", fo->opt_fs); + plog(XLOG_INFO, "program: un/umount not specified; using default \"%s\"", + fo->opt_unmount); + } prog = strchr(fo->opt_mount, ' '); return strdup(prog ? prog + 1 : fo->opt_mount); @@ -101,13 +112,16 @@ amfs_program_match(am_opts *fo) static int amfs_program_init(mntfs *mf) { - /* - * Save unmount command - */ - if (mf->mf_refc == 1) { - mf->mf_private = (voidp) strdup(mf->mf_fo->opt_unmount); - mf->mf_prfree = (void (*)(voidp)) free; - } + /* check if already saved value */ + if (mf->mf_private != NULL) + return 0; + + /* save unmount (or umount) command */ + if (mf->mf_fo->opt_unmount != NULL) + mf->mf_private = (opaque_t) strdup(mf->mf_fo->opt_unmount); + else + mf->mf_private = (opaque_t) strdup(mf->mf_fo->opt_umount); + mf->mf_prfree = (void (*)(opaque_t)) free; return 0; } @@ -142,8 +156,7 @@ amfs_program_exec(char *info) /* * Try the exec */ -#ifdef DEBUG - amuDebug(D_FULL) { + if (amuDebug(D_FULL)) { char **cp = xivec; plog(XLOG_DEBUG, "executing (un)mount command..."); while (*cp) { @@ -151,7 +164,6 @@ amfs_program_exec(char *info) cp++; } } -#endif /* DEBUG */ if (xivec[0] == 0 || xivec[1] == 0) { errno = EINVAL; @@ -180,14 +192,14 @@ amfs_program_exec(char *info) static int -amfs_program_fmount(mntfs *mf) +amfs_program_mount(am_node *am, mntfs *mf) { return amfs_program_exec(mf->mf_fo->opt_mount); } static int -amfs_program_fumount(mntfs *mf) +amfs_program_umount(am_node *am, mntfs *mf) { return amfs_program_exec((char *) mf->mf_private); } diff --git a/contrib/amd/amd/amfs_root.c b/contrib/amd/amd/amfs_root.c index 9d121bb4662f..243267e71e86 100644 --- a/contrib/amd/amd/amfs_root.c +++ b/contrib/amd/amd/amfs_root.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: amfs_root.c,v 1.3.2.4 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/amfs_root.c * */ @@ -55,7 +54,7 @@ /**************************************************************************** *** FORWARD DEFINITIONS *** ****************************************************************************/ -static int amfs_root_mount(am_node *mp); +static int amfs_root_mount(am_node *mp, mntfs *mf); /**************************************************************************** *** OPS STRUCTURES *** @@ -66,16 +65,19 @@ am_ops amfs_root_ops = 0, /* amfs_root_match */ 0, /* amfs_root_init */ amfs_root_mount, - 0, - amfs_auto_umount, - 0, - amfs_auto_lookuppn, - amfs_auto_readdir, + amfs_generic_umount, + amfs_generic_lookup_child, + amfs_generic_mount_child, + amfs_generic_readdir, 0, /* amfs_root_readlink */ 0, /* amfs_root_mounted */ 0, /* amfs_root_umounted */ - find_amfs_auto_srvr, - FS_NOTIMEOUT | FS_AMQINFO | FS_DIRECTORY + amfs_generic_find_srvr, + 0, /* amfs_root_get_wchan */ + FS_NOTIMEOUT | FS_AMQINFO | FS_DIRECTORY, /* nfs_fs_flags */ +#ifdef HAVE_FS_AUTOFS + AUTOFS_ROOT_FS_FLAGS, +#endif /* HAVE_FS_AUTOFS */ }; @@ -87,12 +89,10 @@ am_ops amfs_root_ops = * Mount the root... */ static int -amfs_root_mount(am_node *mp) +amfs_root_mount(am_node *mp, mntfs *mf) { - mntfs *mf = mp->am_mnt; - mf->mf_mount = strealloc(mf->mf_mount, pid_fsname); - mf->mf_private = (voidp) mapc_find(mf->mf_info, "", NULL); + mf->mf_private = (opaque_t) mapc_find(mf->mf_info, "", NULL); mf->mf_prfree = mapc_free; return 0; diff --git a/contrib/amd/amd/amfs_toplvl.c b/contrib/amd/amd/amfs_toplvl.c index c0e7604b2292..1b968f197f55 100644 --- a/contrib/amd/amd/amfs_toplvl.c +++ b/contrib/amd/amd/amfs_toplvl.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: amfs_toplvl.c,v 1.7.2.5 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/amfs_toplvl.c * */ @@ -55,7 +54,7 @@ /**************************************************************************** *** FORWARD DEFINITIONS *** ****************************************************************************/ - +static int amfs_toplvl_init(mntfs *mf); /**************************************************************************** *** OPS STRUCTURES *** @@ -63,19 +62,23 @@ am_ops amfs_toplvl_ops = { "toplvl", - amfs_auto_match, - 0, /* amfs_auto_init */ + amfs_generic_match, + amfs_toplvl_init, /* amfs_toplvl_init */ amfs_toplvl_mount, - 0, amfs_toplvl_umount, - 0, - amfs_auto_lookuppn, - amfs_auto_readdir, /* browsable version of readdir() */ + amfs_generic_lookup_child, + amfs_generic_mount_child, + amfs_generic_readdir, 0, /* amfs_toplvl_readlink */ - amfs_toplvl_mounted, + amfs_generic_mounted, 0, /* amfs_toplvl_umounted */ - find_amfs_auto_srvr, - FS_MKMNT | FS_NOTIMEOUT | FS_BACKGROUND | FS_AMQINFO | FS_DIRECTORY + amfs_generic_find_srvr, + 0, /* amfs_toplvl_get_wchan */ + FS_MKMNT | FS_NOTIMEOUT | FS_BACKGROUND | + FS_AMQINFO | FS_DIRECTORY, /* nfs_fs_flags */ +#ifdef HAVE_FS_AUTOFS + AUTOFS_TOPLVL_FS_FLAGS, +#endif /* HAVE_FS_AUTOFS */ }; @@ -83,166 +86,79 @@ am_ops amfs_toplvl_ops = *** FUNCTIONS *** ****************************************************************************/ -/* - * Mount an automounter directory. - * The automounter is connected into the system - * as a user-level NFS server. mount_amfs_toplvl constructs - * the necessary NFS parameters to be given to the - * kernel so that it will talk back to us. - * - * NOTE: automounter mounts in themselves are using NFS Version 2. - */ -static int -mount_amfs_toplvl(char *dir, char *opts) +static void +set_auto_attrcache_timeout(char *preopts, char *opts, size_t l) { - char fs_hostname[MAXHOSTNAMELEN + MAXPATHLEN + 1]; - int retry, error, genflags; - mntent_t mnt; - nfs_args_t nfs_args; - am_nfs_fh *fhp; - am_nfs_handle_t anh; - MTYPE_TYPE type = MOUNT_TYPE_NFS; -#ifndef HAVE_TRANSPORT_TYPE_TLI - u_short port; - struct sockaddr_in sin; -#endif /* not HAVE_TRANSPORT_TYPE_TLI */ - - memset((voidp) &mnt, 0, sizeof(mnt)); - mnt.mnt_dir = dir; - mnt.mnt_fsname = pid_fsname; - mnt.mnt_opts = opts; - - /* - * Make sure that amd's top-level NFS mounts are hidden by default - * from df. - * If they don't appear to support the either the "ignore" mnttab - * option entry, or the "auto" one, set the mount type to "nfs". - */ - mnt.mnt_type = HIDE_MOUNT_TYPE; - - retry = hasmntval(&mnt, MNTTAB_OPT_RETRY); - if (retry <= 0) - retry = 2; /* XXX */ - - /* - * SET MOUNT ARGS - */ - /* - * get fhandle of remote path for automount point - */ - fhp = root_fh(dir); - if (!fhp) { - plog(XLOG_FATAL, "Can't find root file handle for %s", dir); - return EINVAL; - } -#ifndef HAVE_TRANSPORT_TYPE_TLI +#ifdef MNTTAB_OPT_NOAC /* - * Create sockaddr to point to the local machine. 127.0.0.1 - * is not used since that will not work in HP-UX clusters and - * this is no more expensive. + * Don't cache attributes - they are changing under the kernel's feet. + * For example, IRIX5.2 will dispense with nfs lookup calls and hand stale + * filehandles to getattr unless we disable attribute caching on the + * automount points. */ - memset((voidp) &sin, 0, sizeof(sin)); - sin.sin_family = AF_INET; - sin.sin_addr = myipaddr; - port = hasmntval(&mnt, MNTTAB_OPT_PORT); - if (port) { - sin.sin_port = htons(port); - } else { - plog(XLOG_ERROR, "no port number specified for %s", dir); - return EINVAL; + if (gopt.auto_attrcache == 0) { + xsnprintf(preopts, l, ",%s", MNTTAB_OPT_NOAC); + xstrlcat(opts, preopts, l); } -#endif /* not HAVE_TRANSPORT_TYPE_TLI */ +#endif /* MNTTAB_OPT_NOAC */ /* - * Make a ``hostname'' string for the kernel - */ - sprintf(fs_hostname, "pid%ld@%s:%s", - (long) (foreground ? am_mypid : getppid()), - am_get_hostname(), - dir); - /* - * Most kernels have a name length restriction (64 bytes)... + * XXX: note that setting these to 0 in the past resulted in an error on + * some systems, which is why it's better to use "noac" if possible. For + * now, we're setting everything possible, but if this will cause trouble, + * then we'll have to condition the remainder of this on OPT_NOAC. */ - if (strlen(fs_hostname) >= MAXHOSTNAMELEN) - strcpy(fs_hostname + MAXHOSTNAMELEN - 3, ".."); -#ifdef HOSTNAMESZ - /* - * ... and some of these restrictions are 32 bytes (HOSTNAMESZ) - * If you need to get the definition for HOSTNAMESZ found, you may - * add the proper header file to the conf/nfs_prot/nfs_prot_*.h file. - */ - if (strlen(fs_hostname) >= HOSTNAMESZ) - strcpy(fs_hostname + HOSTNAMESZ - 3, ".."); -#endif /* HOSTNAMESZ */ +#ifdef MNTTAB_OPT_ACTIMEO + xsnprintf(preopts, l, ",%s=%d", MNTTAB_OPT_ACTIMEO, gopt.auto_attrcache); + xstrlcat(opts, preopts, l); +#else /* MNTTAB_OPT_ACTIMEO */ +# ifdef MNTTAB_OPT_ACDIRMIN + xsnprintf(preopts, l, ",%s=%d", MNTTAB_OPT_ACTDIRMIN, gopt.auto_attrcache); + xstrlcat(opts, preopts, l); +# endif /* MNTTAB_OPT_ACDIRMIN */ +# ifdef MNTTAB_OPT_ACDIRMAX + xsnprintf(preopts, l, ",%s=%d", MNTTAB_OPT_ACTDIRMAX, gopt.auto_attrcache); + xstrlcat(opts, preopts, l); +# endif /* MNTTAB_OPT_ACDIRMAX */ +# ifdef MNTTAB_OPT_ACREGMIN + xsnprintf(preopts, l, ",%s=%d", MNTTAB_OPT_ACTREGMIN, gopt.auto_attrcache); + xstrlcat(opts, preopts, l); +# endif /* MNTTAB_OPT_ACREGMIN */ +# ifdef MNTTAB_OPT_ACREGMAX + xsnprintf(preopts, l, ",%s=%d", MNTTAB_OPT_ACTREGMAX, gopt.auto_attrcache); + xstrlcat(opts, preopts, l); +# endif /* MNTTAB_OPT_ACREGMAX */ +#endif /* MNTTAB_OPT_ACTIMEO */ +} - /* - * Finally we can compute the mount genflags set above, - * and add any automounter specific flags. - */ - genflags = compute_mount_flags(&mnt); - genflags |= compute_automounter_mount_flags(&mnt); - /* setup the many fields and flags within nfs_args */ - memmove(&anh.v2.fhs_fh, fhp, sizeof(*fhp)); -#ifdef HAVE_TRANSPORT_TYPE_TLI - compute_nfs_args(&nfs_args, - &mnt, - genflags, - nfsncp, - NULL, /* remote host IP addr is set below */ - NFS_VERSION, /* version 2 */ - "udp", - &anh, - fs_hostname, - pid_fsname); - /* - * IMPORTANT: set the correct IP address AFTERWARDS. It cannot - * be done using the normal mechanism of compute_nfs_args(), because - * that one will allocate a new address and use NFS_SA_DREF() to copy - * parts to it, while assuming that the ip_addr passed is always - * a "struct sockaddr_in". That assumption is incorrect on TLI systems, - * because they define a special macro HOST_SELF which is DIFFERENT - * than localhost (127.0.0.1)! - */ - nfs_args.addr = &nfsxprt->xp_ltaddr; -#else /* not HAVE_TRANSPORT_TYPE_TLI */ - compute_nfs_args(&nfs_args, - &mnt, - genflags, - &sin, - NFS_VERSION, /* version 2 */ - "udp", - &anh, - fs_hostname, - pid_fsname); -#endif /* not HAVE_TRANSPORT_TYPE_TLI */ - - /************************************************************************* - * NOTE: while compute_nfs_args() works ok for regular NFS mounts * - * the toplvl one is not, and so some options must be corrected by hand * - * more carefully, *after* compute_nfs_args() runs. * - *************************************************************************/ - compute_automounter_nfs_args(&nfs_args, &mnt); +/* + * Initialize a top-level mount. In our case, if the user asked for + * forced_unmounts, and the OS supports it, then we try forced/lazy unmounts + * on any previous toplvl mounts. This is useful if a previous Amd died and + * left behind toplvl mount points (this Amd will clean them up). + * + * WARNING: Don't use forced/lazy unmounts if you have another valid Amd + * running, because this code WILL force those valid toplvl mount points to + * be detached as well! + */ +static int +amfs_toplvl_init(mntfs *mf) +{ + int error = 0; - /* This is it! Here we try to mount amd on its mount points */ -#ifdef DEBUG - amuDebug(D_TRACE) { - print_nfs_args(&nfs_args, 0); - plog(XLOG_DEBUG, "Generic mount flags 0x%x", genflags); +#if defined(MNT2_GEN_OPT_FORCE) || defined(MNT2_GEN_OPT_DETACH) + if (gopt.flags & CFM_FORCED_UNMOUNTS) { + plog(XLOG_INFO, "amfs_toplvl_init: trying forced/lazy unmount of %s", + mf->mf_mount); + error = umount2_fs(mf->mf_mount, AMU_UMOUNT_FORCE | AMU_UMOUNT_DETACH); + if (error) + plog(XLOG_INFO, "amfs_toplvl_init: forced/lazy unmount failed: %m"); + else + dlog("amfs_toplvl_init: forced/lazy unmount succeeded"); } -#endif /* DEBUG */ - error = mount_fs(&mnt, genflags, (caddr_t) &nfs_args, retry, type, - 0, NULL, mnttab_file_name); - -#ifdef HAVE_TRANSPORT_TYPE_TLI - free_knetconfig(nfs_args.knconf); - /* - * local automounter mounts do not allocate a special address, so - * no need to XFREE(nfs_args.addr) under TLI. - */ -#endif /* HAVE_TRANSPORT_TYPE_TLI */ - +#endif /* MNT2_GEN_OPT_FORCE || MNT2_GEN_OPT_DETACH */ return error; } @@ -251,13 +167,11 @@ mount_amfs_toplvl(char *dir, char *opts) * Mount the top-level */ int -amfs_toplvl_mount(am_node *mp) +amfs_toplvl_mount(am_node *mp, mntfs *mf) { - mntfs *mf = mp->am_mnt; struct stat stb; - char opts[256], preopts[256]; + char opts[SIZEOF_OPTS], preopts[SIZEOF_OPTS], toplvl_opts[40]; int error; - char *mnttype; /* * Mounting the automounter. @@ -271,16 +185,6 @@ amfs_toplvl_mount(am_node *mp) plog(XLOG_WARNING, "%s is not a directory", mp->am_path); return ENOTDIR; } - if (mf->mf_ops == &amfs_toplvl_ops) - mnttype = "indirect"; - else if (mf->mf_ops == &amfs_direct_ops) - mnttype = "direct"; -#ifdef HAVE_AMU_FS_UNION - else if (mf->mf_ops == &amfs_union_ops) - mnttype = "union"; -#endif /* HAVE_AMU_FS_UNION */ - else - mnttype = "auto"; /* * Construct some mount options: @@ -288,49 +192,71 @@ amfs_toplvl_mount(am_node *mp) * Tack on magic map=<mapname> option in mtab to emulate * SunOS automounter behavior. */ - preopts[0] = '\0'; + +#ifdef HAVE_FS_AUTOFS + if (mf->mf_flags & MFF_IS_AUTOFS) { + autofs_get_opts(opts, sizeof(opts), mp->am_autofs_fh); + } else +#endif /* HAVE_FS_AUTOFS */ + { + preopts[0] = '\0'; #ifdef MNTTAB_OPT_INTR - strcat(preopts, MNTTAB_OPT_INTR); - strcat(preopts, ","); + xstrlcat(preopts, MNTTAB_OPT_INTR, sizeof(preopts)); + xstrlcat(preopts, ",", sizeof(preopts)); #endif /* MNTTAB_OPT_INTR */ #ifdef MNTTAB_OPT_IGNORE - strcat(preopts, MNTTAB_OPT_IGNORE); - strcat(preopts, ","); + xstrlcat(preopts, MNTTAB_OPT_IGNORE, sizeof(preopts)); + xstrlcat(preopts, ",", sizeof(preopts)); #endif /* MNTTAB_OPT_IGNORE */ - sprintf(opts, "%s%s,%s=%d,%s=%d,%s=%d,%s,map=%s", - preopts, - MNTTAB_OPT_RW, - MNTTAB_OPT_PORT, nfs_port, - MNTTAB_OPT_TIMEO, gopt.amfs_auto_timeo, - MNTTAB_OPT_RETRANS, gopt.amfs_auto_retrans, - mnttype, mf->mf_info); + /* write most of the initial options + preopts */ + xsnprintf(opts, sizeof(opts), "%s%s,%s=%d,%s,map=%s", + preopts, + MNTTAB_OPT_RW, + MNTTAB_OPT_PORT, nfs_port, + mf->mf_ops->fs_type, mf->mf_info); + + /* process toplvl timeo/retrans options, if any */ + if (gopt.amfs_auto_timeo[AMU_TYPE_TOPLVL] > 0) { + xsnprintf(toplvl_opts, sizeof(toplvl_opts), ",%s=%d", + MNTTAB_OPT_TIMEO, gopt.amfs_auto_timeo[AMU_TYPE_TOPLVL]); + xstrlcat(opts, toplvl_opts, sizeof(opts)); + } + if (gopt.amfs_auto_retrans[AMU_TYPE_TOPLVL] > 0) { + xsnprintf(toplvl_opts, sizeof(toplvl_opts), ",%s=%d", + MNTTAB_OPT_RETRANS, gopt.amfs_auto_retrans[AMU_TYPE_TOPLVL]); + xstrlcat(opts, toplvl_opts, sizeof(opts)); + } + +#ifdef MNTTAB_OPT_NOAC + if (gopt.auto_attrcache == 0) { + xstrlcat(opts, ",", sizeof(opts)); + xstrlcat(opts, MNTTAB_OPT_NOAC, sizeof(opts)); + } else +#endif /* MNTTAB_OPT_NOAC */ + set_auto_attrcache_timeout(preopts, opts, sizeof(preopts)); + } /* now do the mount */ - error = mount_amfs_toplvl(mf->mf_mount, opts); + error = amfs_mount(mp, mf, opts); if (error) { errno = error; - plog(XLOG_FATAL, "amfs_toplvl_mount: mount_amfs_toplvl failed: %m"); + plog(XLOG_FATAL, "amfs_toplvl_mount: amfs_mount failed: %m"); return error; } return 0; } -void -amfs_toplvl_mounted(mntfs *mf) -{ - amfs_auto_mkcacheref(mf); -} - - /* * Unmount a top-level automount node */ int -amfs_toplvl_umount(am_node *mp) +amfs_toplvl_umount(am_node *mp, mntfs *mf) { - int error; struct stat stb; + int unmount_flags = (mf->mf_flags & MFF_ON_AUTOFS) ? AMU_UMOUNT_AUTOFS : 0; + int error; + int count = 0; /* how many times did we try to unmount? */ again: /* @@ -345,15 +271,48 @@ again: * actually fixed the problem - so simulate an ls -ld here. */ if (lstat(mp->am_path, &stb) < 0) { -#ifdef DEBUG + error = errno; dlog("lstat(%s): %m", mp->am_path); -#endif /* DEBUG */ + goto out; } - error = UMOUNT_FS(mp->am_path, mnttab_file_name); + if ((stb.st_mode & S_IFMT) != S_IFDIR) { + plog(XLOG_ERROR, "amfs_toplvl_umount: %s is not a directory, aborting.", mp->am_path); + error = ENOTDIR; + goto out; + } + + error = UMOUNT_FS(mp->am_path, mnttab_file_name, unmount_flags); if (error == EBUSY) { +#ifdef HAVE_FS_AUTOFS + /* + * autofs mounts are "in place", so it is possible + * that we can't just unmount our mount points and go away. + * If that's the case, just give up. + */ + if (mf->mf_flags & MFF_IS_AUTOFS) + return error; +#endif /* HAVE_FS_AUTOFS */ plog(XLOG_WARNING, "amfs_toplvl_unmount retrying %s in 1s", mp->am_path); - sleep(1); /* XXX */ + count++; + sleep(1); + /* + * If user wants forced/lazy unmount semantics, then set those flags, + * but only after we've tried normal lstat/umount a few times -- + * otherwise forced unmounts may hang this very same Amd (by preventing + * it from achieving a clean unmount). + */ + if (gopt.flags & CFM_FORCED_UNMOUNTS) { + if (count == 5) { /* after 5 seconds, try MNT_FORCE */ + dlog("enabling forced unmounts for toplvl node %s", mp->am_path); + unmount_flags |= AMU_UMOUNT_FORCE; + } + if (count == 10) { /* after 10 seconds, try MNT_DETACH */ + dlog("enabling detached unmounts for toplvl node %s", mp->am_path); + unmount_flags |= AMU_UMOUNT_DETACH; + } + } goto again; } +out: return error; } diff --git a/contrib/amd/amd/amfs_union.c b/contrib/amd/amd/amfs_union.c index 2a74d8cb43d7..6adb5b0bd9cb 100644 --- a/contrib/amd/amd/amfs_union.c +++ b/contrib/amd/amd/amfs_union.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: amfs_union.c,v 1.3.2.5 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/amfs_union.c * */ @@ -55,6 +54,7 @@ /**************************************************************************** *** FORWARD DEFINITIONS *** ****************************************************************************/ +static int create_amfs_union_node(char *dir, opaque_t arg); static void amfs_union_mounted(mntfs *mf); @@ -64,19 +64,22 @@ static void amfs_union_mounted(mntfs *mf); am_ops amfs_union_ops = { "union", - amfs_auto_match, - 0, /* amfs_auto_init */ + amfs_generic_match, + 0, /* amfs_union_init */ amfs_toplvl_mount, - 0, amfs_toplvl_umount, - 0, - amfs_auto_lookuppn, - amfs_auto_readdir, - 0, /* amfs_toplvl_readlink */ + amfs_generic_lookup_child, + amfs_generic_mount_child, + amfs_generic_readdir, + 0, /* amfs_union_readlink */ amfs_union_mounted, - 0, /* amfs_toplvl_umounted */ - find_amfs_auto_srvr, - FS_MKMNT | FS_NOTIMEOUT | FS_BACKGROUND | FS_AMQINFO | FS_DIRECTORY + 0, /* amfs_union_umounted */ + amfs_generic_find_srvr, + 0, /* amfs_union_get_wchan */ + FS_MKMNT | FS_NOTIMEOUT | FS_BACKGROUND | FS_AMQINFO | FS_DIRECTORY, +#ifdef HAVE_FS_AUTOFS + AUTOFS_UNION_FS_FLAGS, +#endif /* HAVE_FS_AUTOFS */ }; @@ -85,11 +88,14 @@ am_ops amfs_union_ops = * XXX: this function may not be used anywhere... */ static int -create_amfs_union_node(char *dir, voidp arg) +create_amfs_union_node(char *dir, opaque_t arg) { if (!STREQ(dir, "/defaults")) { int error = 0; - (void) amfs_toplvl_ops.lookuppn(arg, dir, &error, VLOOK_CREATE); + am_node *am; + am = amfs_generic_lookup_child(arg, dir, &error, VLOOK_CREATE); + if (am && error < 0) + am = amfs_generic_mount_child(am, &error); if (error > 0) { errno = error; /* XXX */ plog(XLOG_ERROR, "unionfs: could not mount %s: %m", dir); @@ -103,20 +109,22 @@ create_amfs_union_node(char *dir, voidp arg) static void amfs_union_mounted(mntfs *mf) { - int i; + int index; + am_node *mp; - amfs_auto_mkcacheref(mf); + amfs_mkcacheref(mf); /* * Having made the union mount point, * populate all the entries... */ - for (i = 0; i <= last_used_map; i++) { - am_node *mp = exported_ap[i]; - if (mp && mp->am_mnt == mf) { + for (mp = get_first_exported_ap(&index); + mp; + mp = get_next_exported_ap(&index)) { + if (mp->am_mnt == mf) { /* return value from create_amfs_union_node is ignored by mapc_keyiter */ (void) mapc_keyiter((mnt_map *) mp->am_mnt->mf_private, - (void (*)(char *, voidp)) create_amfs_union_node, + create_amfs_union_node, mp); break; } diff --git a/contrib/amd/amd/amq_subr.c b/contrib/amd/amd/amq_subr.c index d0e49bad43a6..79ecafc3d9b3 100644 --- a/contrib/amd/amd/amq_subr.c +++ b/contrib/amd/amd/amq_subr.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: amq_subr.c,v 1.6.2.6 2004/01/19 00:25:55 ezk Exp $ + * File: am-utils/amd/amq_subr.c * */ /* @@ -111,8 +110,10 @@ amq_mount_tree_list * amqproc_export_1_svc(voidp argp, struct svc_req *rqstp) { static amq_mount_tree_list aml; + static am_node *mp; - aml.amq_mount_tree_list_val = (amq_mount_tree_p *) &exported_ap[0]; + mp = get_exported_ap(0); + aml.amq_mount_tree_list_val = (amq_mount_tree_p *) ((void *) &mp); aml.amq_mount_tree_list_len = 1; /* XXX */ return &aml; @@ -130,16 +131,14 @@ amqproc_setopt_1_svc(voidp argp, struct svc_req *rqstp) switch (opt->as_opt) { case AMOPT_DEBUG: -#ifdef DEBUG if (debug_option(opt->as_str)) -#endif /* DEBUG */ rc = EINVAL; break; case AMOPT_LOGFILE: if (gopt.logfile && opt->as_str && STREQ(gopt.logfile, opt->as_str)) { - if (switch_to_logfile(opt->as_str, orig_umask)) + if (switch_to_logfile(opt->as_str, orig_umask, 0)) rc = EINVAL; } else { rc = EACCES; @@ -155,8 +154,8 @@ amqproc_setopt_1_svc(voidp argp, struct svc_req *rqstp) if (amd_state == Run) { plog(XLOG_INFO, "amq says flush cache"); do_mapc_reload = 0; - flush_nfs_fhandle_cache((fserver *) 0); - flush_srvr_nfs_cache(); + flush_nfs_fhandle_cache((fserver *) NULL); + flush_srvr_nfs_cache((fserver *) NULL); } break; } @@ -168,7 +167,7 @@ amqproc_setopt_1_svc(voidp argp, struct svc_req *rqstp) amq_mount_info_list * amqproc_getmntfs_1_svc(voidp argp, struct svc_req *rqstp) { - return (amq_mount_info_list *) ((void *)&mfhead); /* XXX */ + return (amq_mount_info_list *) ((void *)&mfhead); /* XXX */ } @@ -194,6 +193,64 @@ amqproc_getpid_1_svc(voidp argp, struct svc_req *rqstp) /* + * Process PAWD string of remote pawd tool. + * + * We repeat the resolution of the string until the resolved string resolves + * to itself. This ensures that we follow path resolutions through all + * possible Amd mount points until we reach some sort of convergence. To + * prevent possible infinite loops, we break out of this loop if the strings + * do not converge after MAX_PAWD_TRIES times. + */ +amq_string * +amqproc_pawd_1_svc(voidp argp, struct svc_req *rqstp) +{ + static amq_string res; +#define MAX_PAWD_TRIES 10 + int index, len, maxagain = MAX_PAWD_TRIES; + am_node *mp; + char *mountpoint; + char *dir = *(char **) argp; + static char tmp_buf[MAXPATHLEN]; + char prev_buf[MAXPATHLEN]; + + tmp_buf[0] = prev_buf[0] = '\0'; /* default is empty string: no match */ + do { + for (mp = get_first_exported_ap(&index); + mp; + mp = get_next_exported_ap(&index)) { + if (STREQ(mp->am_mnt->mf_ops->fs_type, "toplvl")) + continue; + if (STREQ(mp->am_mnt->mf_ops->fs_type, "auto")) + continue; + mountpoint = (mp->am_link ? mp->am_link : mp->am_mnt->mf_mount); + len = strlen(mountpoint); + if (len == 0) + continue; + if (!NSTREQ(mountpoint, dir, len)) + continue; + if (dir[len] != '\0' && dir[len] != '/') + continue; + xstrlcpy(tmp_buf, mp->am_path, sizeof(tmp_buf)); + xstrlcat(tmp_buf, &dir[len], sizeof(tmp_buf)); + break; + } /* end of "for" loop */ + /* once tmp_buf and prev_buf are equal, break out of "do" loop */ + if (STREQ(tmp_buf, prev_buf)) + break; + else + xstrlcpy(prev_buf, tmp_buf, sizeof(prev_buf)); + } while (--maxagain); + /* check if we couldn't resolve the string after MAX_PAWD_TRIES times */ + if (maxagain <= 0) + plog(XLOG_WARNING, "path \"%s\" did not resolve after %d tries", + tmp_buf, MAX_PAWD_TRIES); + + res = tmp_buf; + return &res; +} + + +/* * XDR routines. */ @@ -201,7 +258,7 @@ amqproc_getpid_1_svc(voidp argp, struct svc_req *rqstp) bool_t xdr_amq_setopt(XDR *xdrs, amq_setopt *objp) { - if (!xdr_enum(xdrs, (enum_t *) & objp->as_opt)) { + if (!xdr_enum(xdrs, (enum_t *) ((voidp) &objp->as_opt))) { return (FALSE); } if (!xdr_string(xdrs, &objp->as_str, AMQ_STRLEN)) { @@ -266,10 +323,16 @@ xdr_amq_mount_subtree(XDR *xdrs, amq_mount_tree *objp) if (!xdr_amq_mount_tree_node(xdrs, objp)) { return (FALSE); } - if (!xdr_pointer(xdrs, (char **) &mp->am_osib, sizeof(amq_mount_tree), (XDRPROC_T_TYPE) xdr_amq_mount_subtree)) { + if (!xdr_pointer(xdrs, + (char **) ((voidp) &mp->am_osib), + sizeof(amq_mount_tree), + (XDRPROC_T_TYPE) xdr_amq_mount_subtree)) { return (FALSE); } - if (!xdr_pointer(xdrs, (char **) &mp->am_child, sizeof(amq_mount_tree), (XDRPROC_T_TYPE) xdr_amq_mount_subtree)) { + if (!xdr_pointer(xdrs, + (char **) ((voidp) &mp->am_child), + sizeof(amq_mount_tree), + (XDRPROC_T_TYPE) xdr_amq_mount_subtree)) { return (FALSE); } return (TRUE); @@ -280,15 +343,21 @@ bool_t xdr_amq_mount_tree(XDR *xdrs, amq_mount_tree *objp) { am_node *mp = (am_node *) objp; - am_node *mnil = 0; + am_node *mnil = NULL; if (!xdr_amq_mount_tree_node(xdrs, objp)) { return (FALSE); } - if (!xdr_pointer(xdrs, (char **) ((void *)&mnil), sizeof(amq_mount_tree), (XDRPROC_T_TYPE) xdr_amq_mount_subtree)) { + if (!xdr_pointer(xdrs, + (char **) ((voidp) &mnil), + sizeof(amq_mount_tree), + (XDRPROC_T_TYPE) xdr_amq_mount_subtree)) { return (FALSE); } - if (!xdr_pointer(xdrs, (char **) &mp->am_child, sizeof(amq_mount_tree), (XDRPROC_T_TYPE) xdr_amq_mount_subtree)) { + if (!xdr_pointer(xdrs, + (char **) ((voidp) &mp->am_child), + sizeof(amq_mount_tree), + (XDRPROC_T_TYPE) xdr_amq_mount_subtree)) { return (FALSE); } return (TRUE); @@ -332,7 +401,7 @@ bool_t xdr_amq_mount_tree_list(XDR *xdrs, amq_mount_tree_list *objp) { if (!xdr_array(xdrs, - (char **) &objp->amq_mount_tree_list_val, + (char **) ((voidp) &objp->amq_mount_tree_list_val), (u_int *) &objp->amq_mount_tree_list_len, ~0, sizeof(amq_mount_tree_p), @@ -354,7 +423,7 @@ xdr_amq_mount_info_qelem(XDR *xdrs, qelem *qhead) u_int len = 0; for (mf = AM_LAST(mntfs, qhead); mf != HEAD(mntfs, qhead); mf = PREV(mntfs, mf)) { - if (!(mf->mf_ops->fs_flags & FS_AMQINFO)) + if (!(mf->mf_fsflags & FS_AMQINFO)) continue; len++; } @@ -365,7 +434,7 @@ xdr_amq_mount_info_qelem(XDR *xdrs, qelem *qhead) */ for (mf = AM_LAST(mntfs, qhead); mf != HEAD(mntfs, qhead); mf = PREV(mntfs, mf)) { int up; - if (!(mf->mf_ops->fs_flags & FS_AMQINFO)) + if (!(mf->mf_fsflags & FS_AMQINFO)) continue; if (!xdr_amq_string(xdrs, &mf->mf_ops->fs_type)) { @@ -386,20 +455,12 @@ xdr_amq_mount_info_qelem(XDR *xdrs, qelem *qhead) if (!xdr_int(xdrs, &mf->mf_refc)) { return (FALSE); } - if (mf->mf_server->fs_flags & FSF_ERROR) + if (FSRV_ERROR(mf->mf_server) || FSRV_ISDOWN(mf->mf_server)) up = 0; + else if (FSRV_ISUP(mf->mf_server)) + up = 1; else - switch (mf->mf_server->fs_flags & (FSF_DOWN | FSF_VALID)) { - case FSF_DOWN | FSF_VALID: - up = 0; - break; - case FSF_VALID: - up = 1; - break; - default: - up = -1; - break; - } + up = -1; if (!xdr_int(xdrs, &up)) { return (FALSE); } diff --git a/contrib/amd/amd/amq_svc.c b/contrib/amd/amd/amq_svc.c index 84685676fa38..6fadb160c121 100644 --- a/contrib/amd/amd/amq_svc.c +++ b/contrib/amd/amd/amq_svc.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: amq_svc.c,v 1.4.2.5 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/amq_svc.c * */ @@ -51,6 +50,65 @@ /* typedefs */ typedef char *(*amqsvcproc_t)(voidp, struct svc_req *); +#if defined(HAVE_TCPD_H) && defined(HAVE_LIBWRAP) +# ifdef NEED_LIBWRAP_SEVERITY_VARIABLES +/* + * Some systems that define libwrap already define these two variables + * in libwrap, while others don't: so I need to know precisely iff + * to define these two severity variables. + */ +int allow_severity=0, deny_severity=0; +# endif /* NEED_LIBWRAP_SEVERITY_VARIABLES */ + +/* + * check if remote amq is authorized to access this amd. + * Returns: 1=allowed, 0=denied. + */ +static int +amqsvc_is_client_allowed(const struct sockaddr_in *addr, char *remote) +{ + struct hostent *h; + char *name = NULL, **ad; + int ret = 0; /* default is 0==denied */ + + /* Check IP address */ + if (hosts_ctl(AMD_SERVICE_NAME, "", remote, "")) { + ret = 1; + goto out; + } + /* Get address */ + if (!(h = gethostbyaddr((const char *)&(addr->sin_addr), + sizeof(addr->sin_addr), + AF_INET))) + goto out; + if (!(name = strdup(h->h_name))) + goto out; + /* Paranoia check */ + if (!(h = gethostbyname(name))) + goto out; + for (ad = h->h_addr_list; *ad; ad++) + if (!memcmp(*ad, &(addr->sin_addr), h->h_length)) + break; + if (!*ad) + goto out; + if (hosts_ctl(AMD_SERVICE_NAME, "", h->h_name, "")) { + return 1; + goto out; + } + /* Check aliases */ + for (ad = h->h_aliases; *ad; ad++) + if (hosts_ctl(AMD_SERVICE_NAME, "", *ad, "")) { + return 1; + goto out; + } + + out: + if (name) + XFREE(name); + return ret; +} +#endif /* defined(HAVE_TCPD_H) && defined(HAVE_LIBWRAP) */ + void amq_program_1(struct svc_req *rqstp, SVCXPRT *transp) @@ -64,6 +122,21 @@ amq_program_1(struct svc_req *rqstp, SVCXPRT *transp) xdrproc_t xdr_argument, xdr_result; amqsvcproc_t local; +#if defined(HAVE_TCPD_H) && defined(HAVE_LIBWRAP) + if (gopt.flags & CFM_USE_TCPWRAPPERS) { + struct sockaddr_in *remote_addr = svc_getcaller(rqstp->rq_xprt); + char *remote_hostname = inet_ntoa(remote_addr->sin_addr); + + if (!amqsvc_is_client_allowed(remote_addr, remote_hostname)) { + plog(XLOG_WARNING, "Amd denied remote amq service to %s", remote_hostname); + svcerr_auth(transp, AUTH_FAILED); + return; + } else { + dlog("Amd allowed remote amq service to %s", remote_hostname); + } + } +#endif /* defined(HAVE_TCPD_H) && defined(HAVE_LIBWRAP) */ + switch (rqstp->rq_proc) { case AMQPROC_NULL: @@ -120,6 +193,12 @@ amq_program_1(struct svc_req *rqstp, SVCXPRT *transp) local = (amqsvcproc_t) amqproc_getpid_1_svc; break; + case AMQPROC_PAWD: + xdr_argument = (xdrproc_t) xdr_amq_string; + xdr_result = (xdrproc_t) xdr_amq_string; + local = (amqsvcproc_t) amqproc_pawd_1_svc; + break; + default: svcerr_noproc(transp); return; diff --git a/contrib/amd/amd/autil.c b/contrib/amd/amd/autil.c index bb439187bf07..a5ecd6d0d1f3 100644 --- a/contrib/amd/amd/autil.c +++ b/contrib/amd/amd/autil.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: autil.c,v 1.4.2.6 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/autil.c * */ @@ -52,100 +51,49 @@ #include <am_defs.h> #include <amd.h> -int NumChild = 0; /* number of children of primary amd */ +int NumChildren = 0; /* number of children of primary amd */ static char invalid_keys[] = "\"'!;@ \t\n"; +/**************************************************************************** + *** MACROS *** + ****************************************************************************/ + #ifdef HAVE_TRANSPORT_TYPE_TLI # define PARENT_USLEEP_TIME 100000 /* 0.1 seconds */ #endif /* HAVE_TRANSPORT_TYPE_TLI */ +/**************************************************************************** + *** FORWARD DEFINITIONS *** + ****************************************************************************/ +static void domain_strip(char *otherdom, char *localdom); +static int dofork(void); + + +/**************************************************************************** + *** FUNCTIONS *** + ****************************************************************************/ + +/* + * Copy s into p, reallocating p if necessary + */ char * strealloc(char *p, char *s) { - int len = strlen(s) + 1; + size_t len = strlen(s) + 1; p = (char *) xrealloc((voidp) p, len); - strcpy(p, s); + xstrlcpy(p, s, len); #ifdef DEBUG_MEM +# if defined(HAVE_MALLINFO) && defined(HAVE_MALLOC_VERIFY) malloc_verify(); +# endif /* not defined(HAVE_MALLINFO) && defined(HAVE_MALLOC_VERIFY) */ #endif /* DEBUG_MEM */ return p; } -char ** -strsplit(char *s, int ch, int qc) -{ - char **ivec; - int ic = 0; - int done = 0; - - ivec = (char **) xmalloc((ic + 1) * sizeof(char *)); - - while (!done) { - char *v; - - /* - * skip to split char - */ - while (*s && (ch == ' ' ? (isascii(*s) && isspace((int)*s)) : *s == ch)) - *s++ = '\0'; - - /* - * End of string? - */ - if (!*s) - break; - - /* - * remember start of string - */ - v = s; - - /* - * skip to split char - */ - while (*s && !(ch == ' ' ? (isascii(*s) && isspace((int)*s)) : *s == ch)) { - if (*s++ == qc) { - /* - * Skip past string. - */ - s++; - while (*s && *s != qc) - s++; - if (*s == qc) - s++; - } - } - - if (!*s) - done = 1; - *s++ = '\0'; - - /* - * save string in new ivec slot - */ - ivec[ic++] = v; - ivec = (char **) xrealloc((voidp) ivec, (ic + 1) * sizeof(char *)); -#ifdef DEBUG - amuDebug(D_STR) - plog(XLOG_DEBUG, "strsplit saved \"%s\"", v); -#endif /* DEBUG */ - } - -#ifdef DEBUG - amuDebug(D_STR) - plog(XLOG_DEBUG, "strsplit saved a total of %d strings", ic); -#endif /* DEBUG */ - - ivec[ic] = 0; - - return ivec; -} - - /* * Strip off the trailing part of a domain * to produce a short-form domain relative @@ -170,7 +118,8 @@ domain_strip(char *otherdom, char *localdom) /* - * Normalize a host name + * Normalize a host name: replace cnames with real names, and decide if to + * strip domain name or not. */ void host_normalize(char **chp) @@ -182,20 +131,18 @@ host_normalize(char **chp) */ if (gopt.flags & CFM_NORMALIZE_HOSTNAMES) { struct hostent *hp; - clock_valid = 0; hp = gethostbyname(*chp); if (hp && hp->h_addrtype == AF_INET) { -#ifdef DEBUG dlog("Hostname %s normalized to %s", *chp, hp->h_name); -#endif /* DEBUG */ *chp = strealloc(*chp, (char *) hp->h_name); } } - domain_strip(*chp, hostd); + if (gopt.flags & CFM_DOMAIN_STRIP) { + domain_strip(*chp, hostd); + } } - /* * Keys are not allowed to contain " ' ! or ; to avoid * problems with macro expansions. @@ -226,14 +173,20 @@ forcibly_timeout_mp(am_node *mp) } else { plog(XLOG_INFO, "\"%s\" forcibly timed out", mp->am_path); mp->am_flags &= ~AMF_NOTIMEOUT; - mp->am_ttl = clocktime(); + mp->am_ttl = clocktime(NULL); + /* + * Force mtime update of parent dir, to prevent DNLC/dcache from caching + * the old entry, which could result in ESTALE errors, bad symlinks, and + * more. + */ + clocktime(&mp->am_parent->am_fattr.na_mtime); reschedule_timeout_mp(); } } void -mf_mounted(mntfs *mf) +mf_mounted(mntfs *mf, bool_t call_free_opts) { int quoted; int wasmounted = mf->mf_flags & MFF_MOUNTED; @@ -250,10 +203,33 @@ mf_mounted(mntfs *mf) /* * Do mounted callback */ - if (mf->mf_ops->mounted) { - (*mf->mf_ops->mounted) (mf); + if (mf->mf_ops->mounted) + mf->mf_ops->mounted(mf); + + /* + * Be careful when calling free_ops and XFREE here. Some pseudo file + * systems like nfsx call this function (mf_mounted), even though it + * would be called by the lower-level amd file system functions. nfsx + * needs to call this function because of the other actions it takes. + * So we pass a boolean from the caller (yes, not so clean workaround) + * to determine if we should free or not. If we're not freeing (often + * because we're called from a callback function), then just to be sure, + * we'll zero out the am_opts structure and set the pointer to NULL. + * The parent mntfs node owns this memory and is going to free it with a + * call to mf_mounted(mntfs,TRUE) (see comment in the am_mounted code). + */ + if (call_free_opts) { + free_opts(mf->mf_fo); /* this free is needed to prevent leaks */ + XFREE(mf->mf_fo); /* (also this one) */ + } else { + memset(mf->mf_fo, 0, sizeof(am_opts)); + mf->mf_fo = NULL; } - mf->mf_fo = 0; + } + + if (mf->mf_flags & MFF_RESTART) { + mf->mf_flags &= ~MFF_RESTART; + dlog("Restarted filesystem %s, flags 0x%x", mf->mf_mount, mf->mf_flags); } /* @@ -272,40 +248,61 @@ mf_mounted(mntfs *mf) void am_mounted(am_node *mp) { + int notimeout = 0; /* assume normal timeouts initially */ mntfs *mf = mp->am_mnt; - mf_mounted(mf); + /* + * This is the parent mntfs which does the mf->mf_fo (am_opts type), and + * we're passing TRUE here to tell mf_mounted to actually free the + * am_opts. See a related comment in mf_mounted(). + */ + mf_mounted(mf, TRUE); + +#ifdef HAVE_FS_AUTOFS + if (mf->mf_flags & MFF_IS_AUTOFS) + autofs_mounted(mp); +#endif /* HAVE_FS_AUTOFS */ /* * Patch up path for direct mounts */ - if (mp->am_parent && mp->am_parent->am_mnt->mf_ops == &amfs_direct_ops) + if (mp->am_parent && mp->am_parent->am_mnt->mf_fsflags & FS_DIRECT) mp->am_path = str3cat(mp->am_path, mp->am_parent->am_path, "/", "."); /* - * Check whether this mount should be cached permanently + * Check whether this mount should be cached permanently or not, + * and handle user-requested timeouts. */ - if (mf->mf_ops->fs_flags & FS_NOTIMEOUT) { + /* first check if file system was set to never timeout */ + if (mf->mf_fsflags & FS_NOTIMEOUT) + notimeout = 1; + /* next, alter that decision by map flags */ + if (mf->mf_mopts) { mntent_t mnt; mnt.mnt_opts = mf->mf_mopts; - if (mf->mf_mopts && hasmntopt(&mnt, "unmount")) - mp->am_flags &= ~AMF_NOTIMEOUT; + /* umount option: user wants to unmount this entry */ + if (amu_hasmntopt(&mnt, "unmount") || amu_hasmntopt(&mnt, "umount")) + notimeout = 0; + /* noumount option: user does NOT want to unmount this entry */ + if (amu_hasmntopt(&mnt, "nounmount") || amu_hasmntopt(&mnt, "noumount")) + notimeout = 1; + /* utimeout=N option: user wants to unmount this option AND set timeout */ + if ((mp->am_timeo = hasmntval(&mnt, "utimeout")) == 0) + mp->am_timeo = gopt.am_timeo; /* otherwise use default timeout */ else - mp->am_flags |= AMF_NOTIMEOUT; - } else if (mf->mf_mount[1] == '\0' && mf->mf_mount[0] == '/') { + notimeout = 0; + /* special case: don't try to unmount "/" (it can never succeed) */ + if (mf->mf_mount[0] == '/' && mf->mf_mount[1] == '\0') + notimeout = 1; + } + /* finally set actual flags */ + if (notimeout) { mp->am_flags |= AMF_NOTIMEOUT; + plog(XLOG_INFO, "%s set to never timeout", mp->am_path); } else { - mntent_t mnt; - if (mf->mf_mopts) { - mnt.mnt_opts = mf->mf_mopts; - if (hasmntopt(&mnt, "nounmount")) - mp->am_flags |= AMF_NOTIMEOUT; - if (hasmntopt(&mnt, "unmount")) - mp->am_flags &= ~AMF_NOTIMEOUT; - if ((mp->am_timeo = hasmntval(&mnt, "utimeout")) == 0) - mp->am_timeo = gopt.am_timeo; - } + mp->am_flags &= ~AMF_NOTIMEOUT; + plog(XLOG_INFO, "%s set to timeout in %d seconds", mp->am_path, mp->am_timeo); } /* @@ -313,25 +310,38 @@ am_mounted(am_node *mp) * compute the length of the returned string. */ if (mp->am_fattr.na_type == NFLNK) - mp->am_fattr.na_size = strlen(mp->am_link ? mp->am_link : mp->am_mnt->mf_mount); + mp->am_fattr.na_size = strlen(mp->am_link ? mp->am_link : mf->mf_mount); /* - * Record mount time + * Record mount time, and update am_stats at the same time. */ - mp->am_fattr.na_mtime.nt_seconds = mp->am_stats.s_mtime = clocktime(); + mp->am_stats.s_mtime = clocktime(&mp->am_fattr.na_mtime); new_ttl(mp); /* - * Update mtime of parent node + * Update mtime of parent node (copying "struct nfstime" in '=' below) */ if (mp->am_parent && mp->am_parent->am_mnt) - mp->am_parent->am_fattr.na_mtime.nt_seconds = mp->am_stats.s_mtime; + mp->am_parent->am_fattr.na_mtime = mp->am_fattr.na_mtime; /* - * Now, if we can, do a reply to our NFS client here + * This is ugly, but essentially unavoidable + * Sublinks must be treated separately as type==link + * when the base type is different. + */ + if (mp->am_link && mf->mf_ops != &amfs_link_ops) + amfs_link_ops.mount_fs(mp, mf); + + /* + * Now, if we can, do a reply to our client here * to speed things up. */ - quick_reply(mp, 0); +#ifdef HAVE_FS_AUTOFS + if (mp->am_flags & AMF_AUTOFS) + autofs_mount_succeeded(mp); + else +#endif /* HAVE_FS_AUTOFS */ + nfs_quick_reply(mp, 0); /* * Update stats @@ -340,21 +350,303 @@ am_mounted(am_node *mp) } +/* + * Replace mount point with a reference to an error filesystem. + * The mount point (struct mntfs) is NOT discarded, + * the caller must do it if it wants to _before_ calling this function. + */ +void +assign_error_mntfs(am_node *mp) +{ + int error; + dlog("assign_error_mntfs"); + /* + * Save the old error code + */ + error = mp->am_error; + if (error <= 0) + error = mp->am_mnt->mf_error; + /* + * Allocate a new error reference + */ + mp->am_mnt = new_mntfs(); + /* + * Put back the error code + */ + mp->am_mnt->mf_error = error; + mp->am_mnt->mf_flags |= MFF_ERROR; + /* + * Zero the error in the mount point + */ + mp->am_error = 0; +} + + +/* + * Build a new map cache for this node, or re-use + * an existing cache for the same map. + */ +void +amfs_mkcacheref(mntfs *mf) +{ + char *cache; + + if (mf->mf_fo && mf->mf_fo->opt_cache) + cache = mf->mf_fo->opt_cache; + else + cache = "none"; + mf->mf_private = (opaque_t) mapc_find(mf->mf_info, + cache, + (mf->mf_fo ? mf->mf_fo->opt_maptype : NULL)); + mf->mf_prfree = mapc_free; +} + + +/* + * Locate next node in sibling list which is mounted + * and is not an error node. + */ +am_node * +next_nonerror_node(am_node *xp) +{ + mntfs *mf; + + /* + * Bug report (7/12/89) from Rein Tollevik <rein@ifi.uio.no> + * Fixes a race condition when mounting direct automounts. + * Also fixes a problem when doing a readdir on a directory + * containing hung automounts. + */ + while (xp && + (!(mf = xp->am_mnt) || /* No mounted filesystem */ + mf->mf_error != 0 || /* There was a mntfs error */ + xp->am_error != 0 || /* There was a mount error */ + !(mf->mf_flags & MFF_MOUNTED) || /* The fs is not mounted */ + (mf->mf_server->fs_flags & FSF_DOWN)) /* The fs may be down */ + ) + xp = xp->am_osib; + + return xp; +} + + +/* + * Mount an automounter directory. + * The automounter is connected into the system + * as a user-level NFS server. amfs_mount constructs + * the necessary NFS parameters to be given to the + * kernel so that it will talk back to us. + * + * NOTE: automounter mounts in themselves are using NFS Version 2 (UDP). + * + * NEW: on certain systems, mounting can be done using the + * kernel-level automount (autofs) support. In that case, + * we don't need NFS at all here. + */ int -mount_node(am_node *mp) +amfs_mount(am_node *mp, mntfs *mf, char *opts) { - mntfs *mf = mp->am_mnt; - int error = 0; + char fs_hostname[MAXHOSTNAMELEN + MAXPATHLEN + 1]; + int retry, error = 0, genflags; + int on_autofs = mf->mf_flags & MFF_ON_AUTOFS; + char *dir = mf->mf_mount; + mntent_t mnt; + MTYPE_TYPE type; + int forced_unmount = 0; /* are we using forced unmounts? */ + + memset((voidp) &mnt, 0, sizeof(mnt)); + mnt.mnt_dir = dir; + mnt.mnt_fsname = pid_fsname; + mnt.mnt_opts = opts; + +#ifdef HAVE_FS_AUTOFS + if (mf->mf_flags & MFF_IS_AUTOFS) { + type = MOUNT_TYPE_AUTOFS; + /* + * Make sure that amd's top-level autofs mounts are hidden by default + * from df. + * XXX: It works ok on Linux, might not work on other systems. + */ + mnt.mnt_type = "autofs"; + } else +#endif /* HAVE_FS_AUTOFS */ + { + type = MOUNT_TYPE_NFS; + /* + * Make sure that amd's top-level NFS mounts are hidden by default + * from df. + * If they don't appear to support the either the "ignore" mnttab + * option entry, or the "auto" one, set the mount type to "nfs". + */ + mnt.mnt_type = HIDE_MOUNT_TYPE; + } - mf->mf_flags |= MFF_MOUNTING; - error = (*mf->mf_ops->mount_fs) (mp); + retry = hasmntval(&mnt, MNTTAB_OPT_RETRY); + if (retry <= 0) + retry = 2; /* XXX: default to 2 retries */ - mf = mp->am_mnt; - if (error >= 0) - mf->mf_flags &= ~MFF_MOUNTING; - if (!error && !(mf->mf_ops->fs_flags & FS_MBACKGROUND)) { - /* ...but see ifs_mount */ - am_mounted(mp); + /* + * SET MOUNT ARGS + */ + + /* + * Make a ``hostname'' string for the kernel + */ + xsnprintf(fs_hostname, sizeof(fs_hostname), "pid%ld@%s:%s", + get_server_pid(), am_get_hostname(), dir); + /* + * Most kernels have a name length restriction (64 bytes)... + */ + if (strlen(fs_hostname) >= MAXHOSTNAMELEN) + xstrlcpy(fs_hostname + MAXHOSTNAMELEN - 3, "..", + sizeof(fs_hostname) - MAXHOSTNAMELEN + 3); +#ifdef HOSTNAMESZ + /* + * ... and some of these restrictions are 32 bytes (HOSTNAMESZ) + * If you need to get the definition for HOSTNAMESZ found, you may + * add the proper header file to the conf/nfs_prot/nfs_prot_*.h file. + */ + if (strlen(fs_hostname) >= HOSTNAMESZ) + xstrlcpy(fs_hostname + HOSTNAMESZ - 3, "..", + sizeof(fs_hostname) - HOSTNAMESZ + 3); +#endif /* HOSTNAMESZ */ + + /* + * Finally we can compute the mount genflags set above, + * and add any automounter specific flags. + */ + genflags = compute_mount_flags(&mnt); +#ifdef HAVE_FS_AUTOFS + if (on_autofs) + genflags |= autofs_compute_mount_flags(&mnt); +#endif /* HAVE_FS_AUTOFS */ + genflags |= compute_automounter_mount_flags(&mnt); + +again: + if (!(mf->mf_flags & MFF_IS_AUTOFS)) { + nfs_args_t nfs_args; + am_nfs_fh *fhp; + am_nfs_handle_t anh; +#ifndef HAVE_TRANSPORT_TYPE_TLI + u_short port; + struct sockaddr_in sin; +#endif /* not HAVE_TRANSPORT_TYPE_TLI */ + + /* + * get fhandle of remote path for automount point + */ + fhp = get_root_nfs_fh(dir); + if (!fhp) { + plog(XLOG_FATAL, "Can't find root file handle for %s", dir); + return EINVAL; + } + +#ifndef HAVE_TRANSPORT_TYPE_TLI + /* + * Create sockaddr to point to the local machine. + */ + memset((voidp) &sin, 0, sizeof(sin)); + /* as per POSIX, sin_len need not be set (used internally by kernel) */ + sin.sin_family = AF_INET; + sin.sin_addr = myipaddr; + port = hasmntval(&mnt, MNTTAB_OPT_PORT); + if (port) { + sin.sin_port = htons(port); + } else { + plog(XLOG_ERROR, "no port number specified for %s", dir); + return EINVAL; + } +#endif /* not HAVE_TRANSPORT_TYPE_TLI */ + + /* setup the many fields and flags within nfs_args */ + memmove(&anh.v2, fhp, sizeof(*fhp)); +#ifdef HAVE_TRANSPORT_TYPE_TLI + compute_nfs_args(&nfs_args, + &mnt, + genflags, + nfsncp, + NULL, /* remote host IP addr is set below */ + NFS_VERSION, /* version 2 */ + "udp", + &anh, + fs_hostname, + pid_fsname); + /* + * IMPORTANT: set the correct IP address AFTERWARDS. It cannot + * be done using the normal mechanism of compute_nfs_args(), because + * that one will allocate a new address and use NFS_SA_DREF() to copy + * parts to it, while assuming that the ip_addr passed is always + * a "struct sockaddr_in". That assumption is incorrect on TLI systems, + * because they define a special macro HOST_SELF which is DIFFERENT + * than localhost (127.0.0.1)! + */ + nfs_args.addr = &nfsxprt->xp_ltaddr; +#else /* not HAVE_TRANSPORT_TYPE_TLI */ + compute_nfs_args(&nfs_args, + &mnt, + genflags, + NULL, + &sin, + NFS_VERSION, /* version 2 */ + "udp", + &anh, + fs_hostname, + pid_fsname); +#endif /* not HAVE_TRANSPORT_TYPE_TLI */ + + /************************************************************************* + * NOTE: while compute_nfs_args() works ok for regular NFS mounts * + * the toplvl one is not quite regular, and so some options must be * + * corrected by hand more carefully, *after* compute_nfs_args() runs. * + *************************************************************************/ + compute_automounter_nfs_args(&nfs_args, &mnt); + + if (amuDebug(D_TRACE)) { + print_nfs_args(&nfs_args, 0); + plog(XLOG_DEBUG, "Generic mount flags 0x%x", genflags); + } + + /* This is it! Here we try to mount amd on its mount points */ + error = mount_fs(&mnt, genflags, (caddr_t) &nfs_args, + retry, type, 0, NULL, mnttab_file_name, on_autofs); + +#ifdef HAVE_TRANSPORT_TYPE_TLI + free_knetconfig(nfs_args.knconf); + /* + * local automounter mounts do not allocate a special address, so + * no need to XFREE(nfs_args.addr) under TLI. + */ +#endif /* HAVE_TRANSPORT_TYPE_TLI */ + +#ifdef HAVE_FS_AUTOFS + } else { + /* This is it! Here we try to mount amd on its mount points */ + error = mount_fs(&mnt, genflags, (caddr_t) mp->am_autofs_fh, + retry, type, 0, NULL, mnttab_file_name, on_autofs); +#endif /* HAVE_FS_AUTOFS */ + } + if (error == 0 || forced_unmount) + return error; + + /* + * If user wants forced/lazy unmount semantics, then try it iff the + * current mount failed with EIO or ESTALE. + */ + if (gopt.flags & CFM_FORCED_UNMOUNTS) { + switch (errno) { + case ESTALE: + case EIO: + forced_unmount = errno; + plog(XLOG_WARNING, "Mount %s failed (%m); force unmount.", mp->am_path); + if ((error = UMOUNT_FS(mp->am_path, mnttab_file_name, + AMU_UMOUNT_FORCE | AMU_UMOUNT_DETACH)) < 0) { + plog(XLOG_WARNING, "Forced umount %s failed: %m.", mp->am_path); + errno = forced_unmount; + } else + goto again; + default: + break; + } } return error; @@ -373,15 +665,79 @@ am_unmounted(am_node *mp) * Do unmounted callback */ if (mf->mf_ops->umounted) - (*mf->mf_ops->umounted) (mp); + mf->mf_ops->umounted(mf); + + /* + * This is ugly, but essentially unavoidable. + * Sublinks must be treated separately as type==link + * when the base type is different. + */ + if (mp->am_link && mf->mf_ops != &amfs_link_ops) + amfs_link_ops.umount_fs(mp, mf); + +#ifdef HAVE_FS_AUTOFS + if (mf->mf_flags & MFF_IS_AUTOFS) + autofs_release_fh(mp); + if (mp->am_flags & AMF_AUTOFS) + autofs_umount_succeeded(mp); +#endif /* HAVE_FS_AUTOFS */ + + /* + * Clean up any directories that were made + * + * If we remove the mount point of a pending mount, any queued access + * to it will fail. So don't do it in that case. + * Also don't do it if the refcount is > 1. + */ + if (mf->mf_flags & MFF_MKMNT && + mf->mf_refc == 1 && + !(mp->am_flags & AMF_REMOUNT)) { + plog(XLOG_INFO, "removing mountpoint directory '%s'", mf->mf_mount); + rmdirs(mf->mf_mount); + mf->mf_flags &= ~MFF_MKMNT; + } + + /* + * If this is a pseudo-directory then adjust the link count + * in the parent + */ + if (mp->am_parent && mp->am_fattr.na_type == NFDIR) + --mp->am_parent->am_fattr.na_nlink; /* * Update mtime of parent node */ if (mp->am_parent && mp->am_parent->am_mnt) - mp->am_parent->am_fattr.na_mtime.nt_seconds = clocktime(); - - free_map(mp); + clocktime(&mp->am_parent->am_fattr.na_mtime); + + if (mp->am_parent && (mp->am_flags & AMF_REMOUNT)) { + char *fname = strdup(mp->am_name); + am_node *mp_parent = mp->am_parent; + mntfs *mf_parent = mp_parent->am_mnt; + int error = 0; + + free_map(mp); + plog(XLOG_INFO, "am_unmounted: remounting %s", fname); + mp = mf_parent->mf_ops->lookup_child(mp_parent, fname, &error, VLOOK_CREATE); + if (mp && error < 0) + mp = mf_parent->mf_ops->mount_child(mp, &error); + if (error > 0) { + errno = error; + plog(XLOG_ERROR, "am_unmounted: could not remount %s: %m", fname); + } + XFREE(fname); + } else + /* + * We have a race here. + * If this node has a pending mount and amd is going down (unmounting + * everything in the process), then we could potentially free it here + * while a struct continuation still has a reference to it. So when + * amfs_cont is called, it blows up. + * We avoid the race by refusing to free any nodes that have + * pending mounts (defined as having a non-NULL am_mfarray). + */ + if (!mp->am_mfarray) + free_map(mp); } @@ -406,7 +762,7 @@ top: am_set_mypid(); foreground = 0; } else { /* parent process, has one more child */ - NumChild++; + NumChildren++; } return pid; @@ -419,10 +775,9 @@ background(void) int pid = dofork(); if (pid == 0) { -#ifdef DEBUG dlog("backgrounded"); -#endif /* DEBUG */ foreground = 0; - } + } else + dlog("forked process %d", pid); return pid; } diff --git a/contrib/amd/amd/clock.c b/contrib/amd/amd/clock.c index 9f1a06820a07..0caa7dff2c73 100644 --- a/contrib/amd/amd/clock.c +++ b/contrib/amd/amd/clock.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: clock.c,v 1.4.2.4 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/clock.c * */ @@ -59,14 +58,13 @@ #include <am_defs.h> #include <amd.h> -int timeout(u_int secs, void (*fn) (voidp), voidp closure); void reschedule_timeouts(time_t now, time_t then); typedef struct callout callout; struct callout { callout *c_next; /* List of callouts */ - void (*c_fn) (voidp); /* Function to call */ - voidp c_closure; /* Closure to pass to call */ + callout_fun *c_fn; /* Function to call */ + opaque_t c_arg; /* Argument to pass to call */ time_t c_time; /* Time of call */ int c_id; /* Unique identifier */ }; @@ -87,7 +85,7 @@ time_t next_softclock; /* Time of next call to softclock() */ /* * Global assumption: valid id's are non-zero. */ -#define CID_ALLOC(struct ) (++callout_id) +#define CID_ALLOC() (++callout_id) #define CID_UNDEF (0) @@ -121,22 +119,22 @@ free_callout(callout *cp) /* * Schedule a callout. * - * (*fn)(closure) will be called at clocktime() + secs + * (*fn)(fn_arg) will be called at clocktime(NULL) + secs */ int -timeout(u_int secs, void (*fn) (voidp), voidp closure) +timeout(u_int secs, callout_fun *fn, opaque_t fn_arg) { callout *cp, *cp2; - time_t t = clocktime() + secs; + time_t t = clocktime(NULL) + secs; /* * Allocate and fill in a new callout structure */ callout *cpnew = alloc_callout(); - cpnew->c_closure = closure; + cpnew->c_arg = fn_arg; cpnew->c_fn = fn; cpnew->c_time = t; - cpnew->c_id = CID_ALLOC(struct ); + cpnew->c_id = CID_ALLOC(); if (t < next_softclock) next_softclock = t; @@ -189,10 +187,8 @@ reschedule_timeouts(time_t now, time_t then) for (cp = callouts.c_next; cp; cp = cp->c_next) { if (cp->c_time >= now && cp->c_time <= then) { plog(XLOG_WARNING, "job %d rescheduled to run immediately", cp->c_id); -#ifdef DEBUG dlog("rescheduling job %d back %ld seconds", cp->c_id, (long) (cp->c_time - now)); -#endif /* DEBUG */ next_softclock = cp->c_time = now; } } @@ -212,14 +208,14 @@ softclock(void) if (task_notify_todo) do_task_notify(); - now = clocktime(); + now = clocktime(NULL); /* * While there are more callouts waiting... */ while ((cp = callouts.c_next) && cp->c_time <= now) { /* - * Extract first from list, save fn & closure and + * Extract first from list, save fn & fn_arg and * unlink callout from list and free. * Finally call function. * @@ -228,12 +224,12 @@ softclock(void) * function will call timeout() * and try to allocate a callout */ - void (*fn) (voidp) = cp->c_fn; - voidp closure = cp->c_closure; + callout_fun *fn = cp->c_fn; + opaque_t fn_arg = cp->c_arg; callouts.c_next = cp->c_next; free_callout(cp); - (*fn) (closure); + (*fn) (fn_arg); } } while (task_notify_todo); diff --git a/contrib/amd/amd/conf.c b/contrib/amd/amd/conf.c index 90bbdda8cbd7..2fc587b0cadb 100644 --- a/contrib/amd/amd/conf.c +++ b/contrib/amd/amd/conf.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: conf.c,v 1.7.2.8 2004/01/21 04:04:58 ib42 Exp $ + * File: am-utils/amd/conf.c * */ @@ -76,12 +75,18 @@ struct _func_map { * FORWARD DECLARATIONS: */ static int gopt_arch(const char *val); +static int gopt_auto_attrcache(const char *val); static int gopt_auto_dir(const char *val); +static int gopt_autofs_use_lofs(const char *val); static int gopt_browsable_dirs(const char *val); static int gopt_cache_duration(const char *val); static int gopt_cluster(const char *val); +static int gopt_debug_mtab_file(const char *val); static int gopt_debug_options(const char *val); static int gopt_dismount_interval(const char *val); +static int gopt_domain_strip(const char *val); +static int gopt_exec_map_timeout(const char *val); +static int gopt_forced_unmounts(const char *val); static int gopt_full_os(const char *val); static int gopt_fully_qualified_hosts(const char *val); static int gopt_hesiod_base(const char *val); @@ -90,21 +95,34 @@ static int gopt_ldap_base(const char *val); static int gopt_ldap_cache_maxmem(const char *val); static int gopt_ldap_cache_seconds(const char *val); static int gopt_ldap_hostports(const char *val); +static int gopt_ldap_proto_version(const char *val); static int gopt_local_domain(const char *val); +static int gopt_localhost_address(const char *val); static int gopt_log_file(const char *val); static int gopt_log_options(const char *val); +static int gopt_map_defaults(const char *val); static int gopt_map_options(const char *val); +static int gopt_map_reload_interval(const char *val); static int gopt_map_type(const char *val); static int gopt_mount_type(const char *val); static int gopt_pid_file(const char *val); static int gopt_portmap_program(const char *val); +static int gopt_preferred_amq_port(const char *val); +static int gopt_nfs_allow_any_interface(const char *val); static int gopt_nfs_allow_insecure_port(const char *val); static int gopt_nfs_proto(const char *val); static int gopt_nfs_retransmit_counter(const char *val); +static int gopt_nfs_retransmit_counter_udp(const char *val); +static int gopt_nfs_retransmit_counter_tcp(const char *val); +static int gopt_nfs_retransmit_counter_toplvl(const char *val); static int gopt_nfs_retry_interval(const char *val); +static int gopt_nfs_retry_interval_udp(const char *val); +static int gopt_nfs_retry_interval_tcp(const char *val); +static int gopt_nfs_retry_interval_toplvl(const char *val); static int gopt_nfs_vers(const char *val); static int gopt_nis_domain(const char *val); static int gopt_normalize_hostnames(const char *val); +static int gopt_normalize_slashes(const char *val); static int gopt_os(const char *val); static int gopt_osver(const char *val); static int gopt_plock(const char *val); @@ -114,33 +132,43 @@ static int gopt_restart_mounts(const char *val); static int gopt_search_path(const char *val); static int gopt_selectors_in_defaults(const char *val); static int gopt_show_statfs_entries(const char *val); +static int gopt_truncate_log(const char *val); static int gopt_unmount_on_exit(const char *val); +static int gopt_use_tcpwrappers(const char *val); static int gopt_vendor(const char *val); static int process_global_option(const char *key, const char *val); -static int process_regular_map(cf_map_t *cfm); +static int process_one_regular_map(const cf_map_t *cfm); static int process_regular_option(const char *section, const char *key, const char *val, cf_map_t *cfm); static int ropt_browsable_dirs(const char *val, cf_map_t *cfm); static int ropt_map_name(const char *val, cf_map_t *cfm); +static int ropt_map_defaults(const char *val, cf_map_t *cfm); static int ropt_map_options(const char *val, cf_map_t *cfm); static int ropt_map_type(const char *val, cf_map_t *cfm); static int ropt_mount_type(const char *val, cf_map_t *cfm); static int ropt_search_path(const char *val, cf_map_t *cfm); static int ropt_tag(const char *val, cf_map_t *cfm); -static void reset_cf_map(cf_map_t *cfm); +static void init_cf_map(cf_map_t *cfm); /* * STATIC VARIABLES: */ -static cf_map_t cur_map; +static cf_map_t *head_map, *cur_map; + static struct _func_map glob_functable[] = { {"arch", gopt_arch}, + {"auto_attrcache", gopt_auto_attrcache}, {"auto_dir", gopt_auto_dir}, + {"autofs_use_lofs", gopt_autofs_use_lofs}, {"browsable_dirs", gopt_browsable_dirs}, {"cache_duration", gopt_cache_duration}, {"cluster", gopt_cluster}, + {"debug_mtab_file", gopt_debug_mtab_file}, {"debug_options", gopt_debug_options}, {"dismount_interval", gopt_dismount_interval}, + {"domain_strip", gopt_domain_strip}, + {"exec_map_timeout", gopt_exec_map_timeout}, + {"forced_unmounts", gopt_forced_unmounts}, {"fully_qualified_hosts", gopt_fully_qualified_hosts}, {"full_os", gopt_full_os}, {"hesiod_base", gopt_hesiod_base}, @@ -149,21 +177,34 @@ static struct _func_map glob_functable[] = { {"ldap_cache_maxmem", gopt_ldap_cache_maxmem}, {"ldap_cache_seconds", gopt_ldap_cache_seconds}, {"ldap_hostports", gopt_ldap_hostports}, + {"ldap_proto_version", gopt_ldap_proto_version}, {"local_domain", gopt_local_domain}, + {"localhost_address", gopt_localhost_address}, {"log_file", gopt_log_file}, {"log_options", gopt_log_options}, + {"map_defaults", gopt_map_defaults}, {"map_options", gopt_map_options}, + {"map_reload_interval", gopt_map_reload_interval}, {"map_type", gopt_map_type}, {"mount_type", gopt_mount_type}, {"pid_file", gopt_pid_file}, {"portmap_program", gopt_portmap_program}, + {"preferred_amq_port", gopt_preferred_amq_port}, + {"nfs_allow_any_interface", gopt_nfs_allow_any_interface}, {"nfs_allow_insecure_port", gopt_nfs_allow_insecure_port}, {"nfs_proto", gopt_nfs_proto}, {"nfs_retransmit_counter", gopt_nfs_retransmit_counter}, + {"nfs_retransmit_counter_udp", gopt_nfs_retransmit_counter_udp}, + {"nfs_retransmit_counter_tcp", gopt_nfs_retransmit_counter_tcp}, + {"nfs_retransmit_counter_toplvl", gopt_nfs_retransmit_counter_toplvl}, {"nfs_retry_interval", gopt_nfs_retry_interval}, + {"nfs_retry_interval_udp", gopt_nfs_retry_interval_udp}, + {"nfs_retry_interval_tcp", gopt_nfs_retry_interval_tcp}, + {"nfs_retry_interval_toplvl", gopt_nfs_retry_interval_toplvl}, {"nfs_vers", gopt_nfs_vers}, {"nis_domain", gopt_nis_domain}, {"normalize_hostnames", gopt_normalize_hostnames}, + {"normalize_slashes", gopt_normalize_slashes}, {"os", gopt_os}, {"osver", gopt_osver}, {"plock", gopt_plock}, @@ -174,61 +215,43 @@ static struct _func_map glob_functable[] = { {"selectors_on_default", gopt_selectors_in_defaults}, {"selectors_in_defaults", gopt_selectors_in_defaults}, {"show_statfs_entries", gopt_show_statfs_entries}, + {"truncate_log", gopt_truncate_log}, {"unmount_on_exit", gopt_unmount_on_exit}, + {"use_tcpwrappers", gopt_use_tcpwrappers}, {"vendor", gopt_vendor}, {NULL, NULL} }; /* - * Reset a map. + * Initialize a map from [global] defaults. */ static void -reset_cf_map(cf_map_t *cfm) +init_cf_map(cf_map_t *cfm) { if (!cfm) return; - if (cfm->cfm_dir) { - XFREE(cfm->cfm_dir); - cfm->cfm_dir = NULL; - } - - if (cfm->cfm_name) { - XFREE(cfm->cfm_name); - cfm->cfm_name = NULL; - } - - if (cfm->cfm_tag) { - XFREE(cfm->cfm_tag); - cfm->cfm_tag = NULL; - } - /* - * reset/initialize a regular map's flags and other variables from the + * Initialize a regular map's flags and other variables from the * global ones, so that they are applied to all maps. Of course, each map * can then override the flags individually. * * NOTES: * (1): Will only work for maps that appear after [global]. - * (2): Also be careful not to free() a global option. - * (3): I'm doing direct char* pointer comparison, and not strcmp(). This - * is correct! + * (2): I'm assigning pointers directly from the global map. */ /* initialize map_type from [global] */ - if (cfm->cfm_type && cfm->cfm_type != gopt.map_type) - XFREE(cfm->cfm_type); cfm->cfm_type = gopt.map_type; + /* initialize map_defaults from [global] */ + cfm->cfm_defaults = gopt.map_defaults; + /* initialize map_opts from [global] */ - if (cfm->cfm_opts && cfm->cfm_opts != gopt.map_options) - XFREE(cfm->cfm_opts); cfm->cfm_opts = gopt.map_options; /* initialize search_path from [global] */ - if (cfm->cfm_search_path && cfm->cfm_search_path != gopt.search_path) - XFREE(cfm->cfm_search_path); cfm->cfm_search_path = gopt.search_path; /* @@ -242,7 +265,7 @@ reset_cf_map(cf_map_t *cfm) /* - * Process configuration file options. + * Process configuration file options (called from YACC parser). * Return 0 if OK, 1 otherwise. */ int @@ -251,50 +274,67 @@ set_conf_kv(const char *section, const char *key, const char *val) int ret; #ifdef DEBUG_CONF - fprintf(stderr,"set_conf_kv: section=%s, key=%s, val=%s\n", + fprintf(stderr, "set_conf_kv: section=%s, key=%s, val=%s\n", section, key, val); #endif /* DEBUG_CONF */ /* - * If global section, process them one at a time. + * If global section, process kv pairs one at a time. */ if (STREQ(section, "global")) { /* * Check if a regular map was configured before "global", - * and process it as needed. + * and warn about it. */ - if (cur_map.cfm_dir) { - fprintf(stderr,"processing regular map \"%s\" before global one.\n", - section); - ret = process_regular_map(&cur_map); /* will reset map */ - if (ret != 0) - return ret; + if (cur_map && cur_map->cfm_dir) { + static short printed_this_error; + if (!printed_this_error) { + fprintf(stderr, "found regular map \"%s\" before global one.\n", + cur_map->cfm_dir); + printed_this_error = 1; + } } /* process the global option first */ ret = process_global_option(key, val); - /* reset default options for regular maps from just updated globals */ - if (ret == 0) - reset_cf_map(&cur_map); - /* return status from the processing of the global option */ return ret; } /* - * otherwise save options and process a single map all at once. + * Otherwise we found a non-global option: store it after some testing. */ - /* check if we found a new map, so process one already collected */ - if (cur_map.cfm_dir && !STREQ(cur_map.cfm_dir, section)) { - ret = process_regular_map(&cur_map); /* will reset map */ - if (ret != 0) - return ret; + /* initialize (static) global list head and current map pointer */ + if (!head_map && !cur_map) { + cur_map = CALLOC(cf_map_t); + if (!cur_map) { + perror("calloc"); + exit(1); + } + /* initialize first head map from global defaults */ + init_cf_map(cur_map); + head_map = cur_map; + } + + /* check if we found a new map, then allocate and initialize it */ + if (cur_map->cfm_dir && !STREQ(cur_map->cfm_dir, section)) { + /* allocate new map struct */ + cf_map_t *tmp_map = CALLOC(cf_map_t); + if (!tmp_map) { + perror("calloc"); + exit(1); + } + /* initialize it from global defaults */ + init_cf_map(tmp_map); + /* append it to end of linked list */ + cur_map->cfm_next = tmp_map; + cur_map = tmp_map; } /* now process a single entry of a regular map */ - return process_regular_option(section, key, val, &cur_map); + return process_regular_option(section, key, val, cur_map); } @@ -332,6 +372,18 @@ gopt_arch(const char *val) static int +gopt_auto_attrcache(const char *val) +{ + gopt.auto_attrcache = atoi(val); + if (gopt.auto_attrcache < 0) { + fprintf(stderr, "conf: bad attrcache value: \"%s\"\n", val); + return 1; + } + return 0; +} + + +static int gopt_auto_dir(const char *val) { gopt.auto_dir = strdup((char *)val); @@ -340,6 +392,22 @@ gopt_auto_dir(const char *val) static int +gopt_autofs_use_lofs(const char *val) +{ + if (STREQ(val, "yes")) { + gopt.flags |= CFM_AUTOFS_USE_LOFS; + return 0; + } else if (STREQ(val, "no")) { + gopt.flags &= ~CFM_AUTOFS_USE_LOFS; + return 0; + } + + fprintf(stderr, "conf: unknown value to autofs_use_lofs \"%s\"\n", val); + return 1; /* unknown value */ +} + + +static int gopt_browsable_dirs(const char *val) { if (STREQ(val, "full")) { @@ -377,10 +445,18 @@ gopt_cluster(const char *val) static int +gopt_debug_mtab_file(const char *val) +{ + gopt.debug_mtab_file = strdup((char*)val); + return 0; +} + + +static int gopt_debug_options(const char *val) { #ifdef DEBUG - usage += debug_option(strdup((char *)val)); + usage += debug_option((char *)val); return 0; #else /* not DEBUG */ fprintf(stderr, "%s: not compiled with DEBUG option -- sorry.\n", @@ -401,6 +477,74 @@ gopt_dismount_interval(const char *val) static int +gopt_domain_strip(const char *val) +{ + if (STREQ(val, "yes")) { + gopt.flags |= CFM_DOMAIN_STRIP; + return 0; + } else if (STREQ(val, "no")) { + gopt.flags &= ~CFM_DOMAIN_STRIP; + return 0; + } + + fprintf(stderr, "conf: unknown value to domain_strip \"%s\"\n", val); + return 1; /* unknown value */ +} + + +static int +gopt_exec_map_timeout(const char *val) +{ + gopt.exec_map_timeout = atoi(val); + if (gopt.exec_map_timeout <= 0) + gopt.exec_map_timeout = AMFS_EXEC_MAP_TIMEOUT; /* default exec map timeout */ + return 0; +} + + +static int +gopt_forced_unmounts(const char *val) +{ + if (STREQ(val, "yes")) { +#if !defined(MNT2_GEN_OPT_DETACH) && !defined(MNT2_GEN_OPT_FORCE) + fprintf(stderr, "conf: forced_unmounts unsupported on this system.\n"); + return 1; +#else /* defined(MNT2_GEN_OPT_DETACH) || defined(MNT2_GEN_OPT_FORCE) */ +# ifdef __linux__ + /* + * HACK ALERT: Linux has had MNT_FORCE since 2.2, but it hasn't gotten + * stable until 2.4. And it had MNT_DETACH since 2.4, but it hasn't + * gotten stable since 2.6. So alert users if they're trying to use a + * feature that may not work well on their older kernel. + */ + { + struct utsname un; + if (uname(&un) >= 0) { +# ifdef MNT2_GEN_OPT_FORCE + if (strcmp(un.release, "2.4.0") < 0) + fprintf(stderr, "warning: forced-unmounts (MNT_FORCE) may not work well before 2.4.0\n"); +# endif /* MNT2_GEN_OPT_FORCE */ +# ifdef MNT2_GEN_OPT_DETACH + if (strcmp(un.release, "2.6.0") < 0) + fprintf(stderr, "warning: lazy-unmounts (MNT_DETACH) may not work well before 2.6.0\n"); +# endif /* MNT2_GEN_OPT_DETACH */ + } + } +# endif /* __linux__ */ + gopt.flags |= CFM_FORCED_UNMOUNTS; + return 0; +#endif /* defined(MNT2_GEN_OPT_DETACH) || defined(MNT2_GEN_OPT_FORCE) */ + } else if (STREQ(val, "no")) { + gopt.flags &= ~CFM_FORCED_UNMOUNTS; + return 0; + } + + fprintf(stderr, "conf: unknown value to unmount_on_exit \"%s\"\n", val); + return 1; /* unknown value */ +} + + +static int gopt_full_os(const char *val) { gopt.op_sys_full = strdup((char *)val); @@ -462,6 +606,14 @@ gopt_local_domain(const char *val) static int +gopt_localhost_address(const char *val) +{ + gopt.localhost_address = strdup((char *)val); + return 0; +} + + +static int gopt_ldap_base(const char *val) { #ifdef HAVE_MAP_LDAP @@ -527,6 +679,44 @@ gopt_ldap_hostports(const char *val) static int +gopt_ldap_proto_version(const char *val) +{ +#ifdef HAVE_MAP_LDAP + char *end; + + gopt.ldap_proto_version = strtol((char *)val, &end, 10); + if (end == val) { + fprintf(stderr, "conf: bad ldap_proto_version option: %s\n",val); + return 1; + } + + if (gopt.ldap_proto_version < 0 || gopt.ldap_proto_version > LDAP_VERSION_MAX) { + fprintf(stderr, "conf: bad ldap_proto_version option value: %s\n",val); + return 1; + } + switch (gopt.ldap_proto_version) { + /* XXX: what about LDAP_VERSION1? */ + case LDAP_VERSION2: +#ifdef LDAP_VERSION3 + case LDAP_VERSION3: +#endif /* LDAP_VERSION3 */ +#ifdef LDAP_VERSION4 + case LDAP_VERSION4: +#endif /* LDAP_VERSION4 */ + break; + default: + fprintf(stderr, "conf: unsupported ldap_proto_version option value: %s\n",val); + return 1; + } + return 0; +#else /* not HAVE_MAP_LDAP */ + fprintf(stderr, "conf: ldap_proto_version option ignored. No LDAP support available.\n"); + return 1; +#endif /* not HAVE_MAP_LDAP */ +} + + +static int gopt_log_file(const char *val) { gopt.logfile = strdup((char *)val); @@ -537,7 +727,15 @@ gopt_log_file(const char *val) static int gopt_log_options(const char *val) { - usage += switch_option(strdup((char *)val)); + usage += switch_option((char *)val); + return 0; +} + + +static int +gopt_map_defaults(const char *val) +{ + gopt.map_defaults = strdup((char *)val); return 0; } @@ -551,6 +749,16 @@ gopt_map_options(const char *val) static int +gopt_map_reload_interval(const char *val) +{ + gopt.map_reload_interval = atoi(val); + if (gopt.map_reload_interval <= 0) + gopt.map_reload_interval = ONE_HOUR; + return 0; +} + + +static int gopt_map_type(const char *val) { /* check if map type exist */ @@ -567,9 +775,14 @@ static int gopt_mount_type(const char *val) { if (STREQ(val, "autofs")) { - fprintf(stderr, "conf: no autofs support available, turning it off\n"); - gopt.flags &= ~CFM_MOUNT_TYPE_AUTOFS; +#ifdef HAVE_FS_AUTOFS + gopt.flags |= CFM_MOUNT_TYPE_AUTOFS; + amd_use_autofs++; return 0; +#else /* not HAVE_FS_AUTOFS */ + fprintf(stderr, "conf: no autofs support available\n"); + return 1; +#endif /* not HAVE_FS_AUTOFS */ } else if (STREQ(val, "nfs")) { gopt.flags &= ~CFM_MOUNT_TYPE_AUTOFS; return 0; @@ -583,7 +796,7 @@ gopt_mount_type(const char *val) static int gopt_portmap_program(const char *val) { - gopt.portmap_program = atoi(val); + gopt.portmap_program = atol(val); /* * allow alternate program numbers to be no more than 10 offset from * official amd program number (300019). @@ -602,6 +815,35 @@ gopt_portmap_program(const char *val) static int +gopt_preferred_amq_port(const char *val) +{ + gopt.preferred_amq_port = atoi(val); + + /* + * No need to check value: preferred_amq_port is an unsigned short and 0 + * is a valid number, meaning "any port". + */ + return 0; /* all is OK */ +} + + +static int +gopt_nfs_allow_any_interface(const char *val) +{ + if (STREQ(val, "yes")) { + gopt.flags |= CFM_NFS_ANY_INTERFACE; + return 0; + } else if (STREQ(val, "no")) { + gopt.flags &= ~CFM_NFS_ANY_INTERFACE; + return 0; + } + + fprintf(stderr, "conf: unknown value to nfs_allow_insecure_port \"%s\"\n", val); + return 1; /* unknown value */ +} + + +static int gopt_nfs_allow_insecure_port(const char *val) { if (STREQ(val, "yes")) { @@ -632,7 +874,34 @@ gopt_nfs_proto(const char *val) static int gopt_nfs_retransmit_counter(const char *val) { - gopt.amfs_auto_retrans = atoi(val); + int i; + + for (i=0; i<AMU_TYPE_MAX; ++i) + gopt.amfs_auto_retrans[i] = atoi(val); + return 0; +} + + +static int +gopt_nfs_retransmit_counter_udp(const char *val) +{ + gopt.amfs_auto_retrans[AMU_TYPE_UDP] = atoi(val); + return 0; +} + + +static int +gopt_nfs_retransmit_counter_tcp(const char *val) +{ + gopt.amfs_auto_retrans[AMU_TYPE_TCP] = atoi(val); + return 0; +} + + +static int +gopt_nfs_retransmit_counter_toplvl(const char *val) +{ + gopt.amfs_auto_retrans[AMU_TYPE_TOPLVL] = atoi(val); return 0; } @@ -640,7 +909,34 @@ gopt_nfs_retransmit_counter(const char *val) static int gopt_nfs_retry_interval(const char *val) { - gopt.amfs_auto_timeo = atoi(val); + int i; + + for (i=0; i<AMU_TYPE_MAX; ++i) + gopt.amfs_auto_timeo[i] = atoi(val); + return 0; +} + + +static int +gopt_nfs_retry_interval_udp(const char *val) +{ + gopt.amfs_auto_timeo[AMU_TYPE_UDP] = atoi(val); + return 0; +} + + +static int +gopt_nfs_retry_interval_tcp(const char *val) +{ + gopt.amfs_auto_timeo[AMU_TYPE_TCP] = atoi(val); + return 0; +} + + +static int +gopt_nfs_retry_interval_toplvl(const char *val) +{ + gopt.amfs_auto_timeo[AMU_TYPE_TOPLVL] = atoi(val); return 0; } @@ -689,6 +985,22 @@ gopt_normalize_hostnames(const char *val) static int +gopt_normalize_slashes(const char *val) +{ + if (STREQ(val, "yes")) { + gopt.flags |= CFM_NORMALIZE_SLASHES; + return 0; + } else if (STREQ(val, "no")) { + gopt.flags &= ~CFM_NORMALIZE_SLASHES; + return 0; + } + + fprintf(stderr, "conf: unknown value to normalize_slashes \"%s\"\n", val); + return 1; /* unknown value */ +} + + +static int gopt_os(const char *val) { gopt.op_sys = strdup((char *)val); @@ -740,7 +1052,9 @@ static int gopt_print_version(const char *val) { if (STREQ(val, "yes")) { - fputs(get_version_string(), stderr); + char *vers = get_version_string(); + fputs(vers, stderr); + XFREE(vers); return 0; } else if (STREQ(val, "no")) { return 0; @@ -808,6 +1122,22 @@ gopt_show_statfs_entries(const char *val) static int +gopt_truncate_log(const char *val) +{ + if (STREQ(val, "yes")) { + gopt.flags |= CFM_TRUNCATE_LOG; + return 0; + } else if (STREQ(val, "no")) { + gopt.flags &= ~CFM_TRUNCATE_LOG; + return 0; + } + + fprintf(stderr, "conf: unknown value to truncate_log \"%s\"\n", val); + return 1; /* unknown value */ +} + + +static int gopt_unmount_on_exit(const char *val) { if (STREQ(val, "yes")) { @@ -824,6 +1154,27 @@ gopt_unmount_on_exit(const char *val) static int +gopt_use_tcpwrappers(const char *val) +{ +#if defined(HAVE_TCPD_H) && defined(HAVE_LIBWRAP) + if (STREQ(val, "yes")) { + gopt.flags |= CFM_USE_TCPWRAPPERS; + return 0; + } else if (STREQ(val, "no")) { + gopt.flags &= ~CFM_USE_TCPWRAPPERS; + return 0; + } +#else /* not defined(HAVE_TCPD_H) && defined(HAVE_LIBWRAP) */ + fprintf(stderr, "conf: no tcpd/libwrap support available\n"); + return 1; +#endif /* not defined(HAVE_TCPD_H) && defined(HAVE_LIBWRAP) */ + + fprintf(stderr, "conf: unknown value to use_tcpwrappers \"%s\"\n", val); + return 1; /* unknown value */ +} + + +static int gopt_vendor(const char *val) { gopt.op_sys_vendor = strdup((char *)val); @@ -857,6 +1208,9 @@ process_regular_option(const char *section, const char *key, const char *val, cf if (STREQ(key, "map_name")) return ropt_map_name(val, cfm); + if (STREQ(key, "map_defaults")) + return ropt_map_defaults(val, cfm); + if (STREQ(key, "map_options")) return ropt_map_options(val, cfm); @@ -906,6 +1260,14 @@ ropt_map_name(const char *val, cf_map_t *cfm) static int +ropt_map_defaults(const char *val, cf_map_t *cfm) +{ + cfm->cfm_defaults = strdup((char *)val); + return 0; +} + + +static int ropt_map_options(const char *val, cf_map_t *cfm) { cfm->cfm_opts = strdup((char *)val); @@ -930,9 +1292,14 @@ static int ropt_mount_type(const char *val, cf_map_t *cfm) { if (STREQ(val, "autofs")) { - fprintf(stderr, "conf: no autofs support available, turning it off\n"); - cfm->cfm_flags &= ~CFM_MOUNT_TYPE_AUTOFS; +#ifdef HAVE_FS_AUTOFS + cfm->cfm_flags |= CFM_MOUNT_TYPE_AUTOFS; + amd_use_autofs++; return 0; +#else /* not HAVE_FS_AUTOFS */ + fprintf(stderr, "conf: no autofs support available\n"); + return 1; +#endif /* not HAVE_FS_AUTOFS */ } else if (STREQ(val, "nfs")) { cfm->cfm_flags &= ~CFM_MOUNT_TYPE_AUTOFS; return 0; @@ -963,9 +1330,8 @@ ropt_tag(const char *val, cf_map_t *cfm) * Process one collected map. */ static int -process_regular_map(cf_map_t *cfm) +process_one_regular_map(const cf_map_t *cfm) { - if (!cfm->cfm_name) { fprintf(stderr, "conf: map_name must be defined for map \"%s\"\n", cfm->cfm_dir); return 1; @@ -989,22 +1355,52 @@ process_regular_map(cf_map_t *cfm) fprintf(stderr, "skipping map %s...\n", cfm->cfm_dir); } - reset_cf_map(cfm); return 0; } /* - * Process last map in conf file (if any) + * Process all regular maps in conf file (if any) */ int -process_last_regular_map(void) +process_all_regular_maps(void) { + cf_map_t *tmp_map = head_map; + /* * If the amd.conf file only has a [global] section (pretty useless - * IMHO), do not try to process a map that does not exist. + * IMHO), there's nothing to process */ - if (!cur_map.cfm_dir) + if (!tmp_map) return 0; - return process_regular_map(&cur_map); + + while (tmp_map) { + if (process_one_regular_map(tmp_map) != 0) + return 1; + tmp_map = tmp_map->cfm_next; + } + return 0; +} + + +/* + * Find a cf_map_t for a given map name. + * Return NULL if not found. + */ +cf_map_t * +find_cf_map(const char *name) +{ + + cf_map_t *tmp_map = head_map; + + if (!tmp_map || !name) + return NULL; + + while (tmp_map) { + if (STREQ(tmp_map->cfm_dir,name)) { + return tmp_map; + } + tmp_map = tmp_map->cfm_next; + } + return NULL; } diff --git a/contrib/amd/amd/conf_parse.y b/contrib/amd/amd/conf_parse.y index 992d321f1c54..b397b0573242 100644 --- a/contrib/amd/amd/conf_parse.y +++ b/contrib/amd/amd/conf_parse.y @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -37,7 +37,7 @@ * SUCH DAMAGE. * * - * $Id: conf_parse.y,v 1.4.2.5 2004/05/12 15:54:31 ezk Exp $ + * File: am-utils/amd/conf_parse.y * */ diff --git a/contrib/amd/amd/conf_tok.l b/contrib/amd/amd/conf_tok.l index 2216993fb844..b572e4d7d5a3 100644 --- a/contrib/amd/amd/conf_tok.l +++ b/contrib/amd/amd/conf_tok.l @@ -1,6 +1,6 @@ %{ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -38,7 +38,7 @@ * SUCH DAMAGE. * * - * $Id: conf_tok.l,v 1.3.2.5 2004/05/12 15:54:31 ezk Exp $ + * File: am-utils/amd/conf_tok.l * */ diff --git a/contrib/amd/amd/get_args.c b/contrib/amd/amd/get_args.c index df85683ae931..12a7d07efd59 100644 --- a/contrib/amd/amd/get_args.c +++ b/contrib/amd/amd/get_args.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: get_args.c,v 1.7.2.6 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/get_args.c * */ @@ -55,17 +54,12 @@ /* include auto-generated version file */ #include <build_version.h> -char *conf_file = "/etc/amd.conf"; /* default amd configuration file */ +char *amu_conf_file = "/etc/amd.conf"; /* default amd configuration file */ char *conf_tag = NULL; /* default conf file tags to use */ int usage = 0; int use_conf_file = 0; /* default don't use amd.conf file */ char *mnttab_file_name = NULL; /* symbol must be available always */ -#if 0 -#ifdef DEBUG -int debug_flags = D_AMQ /* Register AMQ */ - | D_DAEMON; /* Enter daemon mode */ -#endif /* DEBUG */ -#endif + /* * Return the version string (dynamic buffer) @@ -73,48 +67,61 @@ int debug_flags = D_AMQ /* Register AMQ */ char * get_version_string(void) { - static char *vers = NULL; + char *vers = NULL; char tmpbuf[1024]; char *wire_buf; int wire_buf_len = 0; + size_t len; /* max allocated length (to avoid buf overflow) */ - /* first get dynamic string listing all known networks */ + /* + * First get dynamic string listing all known networks. + * This could be a long list, if host has lots of interfaces. + */ wire_buf = print_wires(); if (wire_buf) wire_buf_len = strlen(wire_buf); - vers = xmalloc(2048 + wire_buf_len); - sprintf(vers, "%s\n%s\n%s\n%s\n", - "Copyright (c) 1997-2004 Erez Zadok", - "Copyright (c) 1990 Jan-Simon Pendry", - "Copyright (c) 1990 Imperial College of Science, Technology & Medicine", - "Copyright (c) 1990 The Regents of the University of California."); - sprintf(tmpbuf, "%s version %s (build %d).\n", - PACKAGE, VERSION, AMU_BUILD_VERSION); - strcat(vers, tmpbuf); - sprintf(tmpbuf, "Built by %s@%s on date %s.\n", - USER_NAME, HOST_NAME, CONFIG_DATE); - strcat(vers, tmpbuf); - sprintf(tmpbuf, "cpu=%s (%s-endian), arch=%s, karch=%s.\n", - cpu, endian, gopt.arch, gopt.karch); - strcat(vers, tmpbuf); - sprintf(tmpbuf, "full_os=%s, os=%s, osver=%s, vendor=%s.\n", - gopt.op_sys_full, gopt.op_sys, gopt.op_sys_ver, gopt.op_sys_vendor); - strcat(vers, tmpbuf); - - strcat(vers, "Map support for: "); - mapc_showtypes(tmpbuf); - strcat(vers, tmpbuf); - strcat(vers, ".\nAMFS: "); - ops_showamfstypes(tmpbuf); - strcat(vers, tmpbuf); - strcat(vers, ".\nFS: "); - ops_showfstypes(tmpbuf); - strcat(vers, tmpbuf); + len = 2048 + wire_buf_len; + vers = xmalloc(len); + xsnprintf(vers, len, "%s\n%s\n%s\n%s\n", + "Copyright (c) 1997-2006 Erez Zadok", + "Copyright (c) 1990 Jan-Simon Pendry", + "Copyright (c) 1990 Imperial College of Science, Technology & Medicine", + "Copyright (c) 1990 The Regents of the University of California."); + xsnprintf(tmpbuf, sizeof(tmpbuf), "%s version %s (build %d).\n", + PACKAGE_NAME, PACKAGE_VERSION, AMU_BUILD_VERSION); + strlcat(vers, tmpbuf, len); + xsnprintf(tmpbuf, sizeof(tmpbuf), "Report bugs to %s.\n", PACKAGE_BUGREPORT); + strlcat(vers, tmpbuf, len); + xsnprintf(tmpbuf, sizeof(tmpbuf), "Configured by %s@%s on date %s.\n", + USER_NAME, HOST_NAME, CONFIG_DATE); + strlcat(vers, tmpbuf, len); + xsnprintf(tmpbuf, sizeof(tmpbuf), "Built by %s@%s on date %s.\n", + BUILD_USER, BUILD_HOST, BUILD_DATE); + strlcat(vers, tmpbuf, len); + xsnprintf(tmpbuf, sizeof(tmpbuf), "cpu=%s (%s-endian), arch=%s, karch=%s.\n", + cpu, endian, gopt.arch, gopt.karch); + strlcat(vers, tmpbuf, len); + xsnprintf(tmpbuf, sizeof(tmpbuf), "full_os=%s, os=%s, osver=%s, vendor=%s, distro=%s.\n", + gopt.op_sys_full, gopt.op_sys, gopt.op_sys_ver, gopt.op_sys_vendor, DISTRO_NAME); + strlcat(vers, tmpbuf, len); + xsnprintf(tmpbuf, sizeof(tmpbuf), "domain=%s, host=%s, hostd=%s.\n", + hostdomain, am_get_hostname(), hostd); + strlcat(vers, tmpbuf, len); + + strlcat(vers, "Map support for: ", len); + mapc_showtypes(tmpbuf, sizeof(tmpbuf)); + strlcat(vers, tmpbuf, len); + strlcat(vers, ".\nAMFS: ", len); + ops_showamfstypes(tmpbuf, sizeof(tmpbuf)); + strlcat(vers, tmpbuf, len); + strlcat(vers, ", inherit.\nFS: ", len); /* hack: "show" that we support type:=inherit */ + ops_showfstypes(tmpbuf, sizeof(tmpbuf)); + strlcat(vers, tmpbuf, len); /* append list of networks if available */ if (wire_buf) { - strcat(vers, wire_buf); + strlcat(vers, wire_buf, len); XFREE(wire_buf); } @@ -122,13 +129,48 @@ get_version_string(void) } +static void +show_usage(void) +{ + fprintf(stderr, + "Usage: %s [-nprvHS] [-a mount_point] [-c cache_time] [-d domain]\n\ +\t[-k kernel_arch] [-l logfile%s\n\ +\t[-t timeout.retrans] [-w wait_timeout] [-A arch] [-C cluster_name]\n\ +\t[-o op_sys_ver] [-O op_sys_name]\n\ +\t[-F conf_file] [-T conf_tag]", am_get_progname(), +#ifdef HAVE_SYSLOG +# ifdef LOG_DAEMON + "|\"syslog[:facility]\"]" +# else /* not LOG_DAEMON */ + "|\"syslog\"]" +# endif /* not LOG_DAEMON */ +#else /* not HAVE_SYSLOG */ + "]" +#endif /* not HAVE_SYSLOG */ + ); + +#ifdef HAVE_MAP_NIS + fputs(" [-y nis-domain]\n", stderr); +#else /* not HAVE_MAP_NIS */ + fputc('\n', stderr); +#endif /* HAVE_MAP_NIS */ + + show_opts('x', xlog_opt); +#ifdef DEBUG + show_opts('D', dbg_opt); +#endif /* DEBUG */ + fprintf(stderr, "\t[directory mapname [-map_options]] ...\n"); +} + + void get_args(int argc, char *argv[]) { - int opt_ch; + int opt_ch, i; FILE *fp = stdin; - char getopt_arguments[] = "+nprvSa:c:d:k:l:o:t:w:x:y:C:D:F:T:O:H"; + char getopt_arguments[] = "+nprvSa:c:d:k:l:o:t:w:x:y:C:D:F:T:O:HA:"; char *getopt_args; + int print_version = 0; /* 1 means we should print version info */ #ifdef HAVE_GNU_GETOPT getopt_args = getopt_arguments; @@ -187,24 +229,30 @@ get_args(int argc, char *argv[]) break; case 't': - /* timeo.retrans */ + /* timeo.retrans (also affects toplvl mounts) */ { char *dot = strchr(optarg, '.'); + int i; if (dot) *dot = '\0'; if (*optarg) { - gopt.amfs_auto_timeo = atoi(optarg); + for (i=0; i<AMU_TYPE_MAX; ++i) + gopt.amfs_auto_timeo[i] = atoi(optarg); } if (dot) { - gopt.amfs_auto_retrans = atoi(dot + 1); + for (i=0; i<AMU_TYPE_MAX; ++i) + gopt.amfs_auto_retrans[i] = atoi(dot + 1); *dot = '.'; } } break; case 'v': - fputs(get_version_string(), stderr); - exit(0); + /* + * defer to print version info after every variable had been + * initialized. + */ + print_version++; break; case 'w': @@ -225,6 +273,10 @@ get_args(int argc, char *argv[]) #endif /* not HAVE_MAP_NIS */ break; + case 'A': + gopt.arch = optarg; + break; + case 'C': gopt.cluster = optarg; break; @@ -239,12 +291,13 @@ get_args(int argc, char *argv[]) break; case 'F': - conf_file = optarg; + amu_conf_file = optarg; use_conf_file = 1; break; case 'H': - goto show_usage; + show_usage(); + exit(1); break; case 'O': @@ -269,18 +322,19 @@ get_args(int argc, char *argv[]) * specified, then use that amd.conf file. If the file cannot be opened, * abort amd. If it can be found, open it, parse it, and then close it. */ - if (use_conf_file && conf_file) { - fp = fopen(conf_file, "r"); + if (use_conf_file && amu_conf_file) { + fp = fopen(amu_conf_file, "r"); if (!fp) { char buf[128]; - sprintf(buf, "Amd configuration file (%s)", conf_file); + xsnprintf(buf, sizeof(buf), "Amd configuration file (%s)", + amu_conf_file); perror(buf); exit(1); } yyin = fp; yyparse(); fclose(fp); - if (process_last_regular_map() != 0) + if (process_all_regular_maps() != 0) exit(1); } @@ -293,8 +347,8 @@ get_args(int argc, char *argv[]) #endif /* DEBUG */ /* log information regarding amd.conf file */ - if (use_conf_file && conf_file) - plog(XLOG_INFO, "using configuration file %s", conf_file); + if (use_conf_file && amu_conf_file) + plog(XLOG_INFO, "using configuration file %s", amu_conf_file); #ifdef HAVE_MAP_LDAP /* ensure that if ldap_base is specified, that also ldap_hostports is */ @@ -304,8 +358,10 @@ get_args(int argc, char *argv[]) } #endif /* HAVE_MAP_LDAP */ - if (usage) - goto show_usage; + if (usage) { + show_usage(); + exit(1); + } while (optind <= argc - 2) { char *dir = argv[optind++]; @@ -327,76 +383,55 @@ get_args(int argc, char *argv[]) hostdomain = gopt.sub_domain; if (*hostdomain == '.') hostdomain++; - strcat(hostd, "."); - strcat(hostd, hostdomain); + xstrlcat(hostd, ".", sizeof(hostd)); + xstrlcat(hostd, hostdomain, sizeof(hostd)); #ifdef MOUNT_TABLE_ON_FILE -# ifdef DEBUG - if (debug_flags & D_MTAB) - mnttab_file_name = DEBUG_MNTTAB; + if (amuDebug(D_MTAB)) + if (gopt.debug_mtab_file) + mnttab_file_name = gopt.debug_mtab_file; /* user supplied debug mtab path */ + else + mnttab_file_name = DEBUG_MNTTAB_FILE; /* default debug mtab path */ else -# endif /* DEBUG */ mnttab_file_name = MNTTAB_FILE_NAME; #else /* not MOUNT_TABLE_ON_FILE */ -# ifdef DEBUG - if (debug_flags & D_MTAB) + if (amuDebug(D_MTAB)) dlog("-D mtab option ignored"); -# endif /* DEBUG */ # ifdef MNTTAB_FILE_NAME mnttab_file_name = MNTTAB_FILE_NAME; # endif /* MNTTAB_FILE_NAME */ #endif /* not MOUNT_TABLE_ON_FILE */ - if (switch_to_logfile(gopt.logfile, orig_umask) != 0) - plog(XLOG_USER, "Cannot switch logfile"); - /* * If the kernel architecture was not specified * then use the machine architecture. */ - if (gopt.karch == 0) + if (gopt.karch == NULL) gopt.karch = gopt.arch; - if (gopt.cluster == 0) + if (gopt.cluster == NULL) gopt.cluster = hostdomain; - if (gopt.amfs_auto_timeo <= 0) - gopt.amfs_auto_timeo = AMFS_AUTO_TIMEO; - if (gopt.amfs_auto_retrans <= 0) - gopt.amfs_auto_retrans = AMFS_AUTO_RETRANS; - if (gopt.amfs_auto_retrans <= 0) - gopt.amfs_auto_retrans = 3; /* XXX */ - return; + /* sanity checking, normalize values just in case (toplvl too) */ + for (i=0; i<AMU_TYPE_MAX; ++i) { + if (gopt.amfs_auto_timeo[i] == 0) + gopt.amfs_auto_timeo[i] = AMFS_AUTO_TIMEO; + if (gopt.amfs_auto_retrans[i] == 0) + gopt.amfs_auto_retrans[i] = AMFS_AUTO_RETRANS(i); + if (gopt.amfs_auto_retrans[i] == 0) + gopt.amfs_auto_retrans[i] = 3; /* under very unusual circumstances, could be zero */ + } } -show_usage: - fprintf(stderr, - "Usage: %s [-nprvHS] [-a mount_point] [-c cache_time] [-d domain]\n\ -\t[-k kernel_arch] [-l logfile%s\n\ -\t[-t timeout.retrans] [-w wait_timeout] [-C cluster_name]\n\ -\t[-o op_sys_ver] [-O op_sys_name]\n\ -\t[-F conf_file] [-T conf_tag]", am_get_progname(), -#ifdef HAVE_SYSLOG -# ifdef LOG_DAEMON - "|\"syslog[:facility]\"]" -# else /* not LOG_DAEMON */ - "|\"syslog\"]" -# endif /* not LOG_DAEMON */ -#else /* not HAVE_SYSLOG */ - "]" -#endif /* not HAVE_SYSLOG */ - ); + /* finally print version string and exit, if asked for */ + if (print_version) { + fputs(get_version_string(), stderr); + exit(0); + } -#ifdef HAVE_MAP_NIS - fputs(" [-y nis-domain]\n", stderr); -#else /* not HAVE_MAP_NIS */ - fputc('\n', stderr); -#endif /* HAVE_MAP_NIS */ + if (switch_to_logfile(gopt.logfile, orig_umask, + (gopt.flags & CFM_TRUNCATE_LOG)) != 0) + plog(XLOG_USER, "Cannot switch logfile"); - show_opts('x', xlog_opt); -#ifdef DEBUG - show_opts('D', dbg_opt); -#endif /* DEBUG */ - fprintf(stderr, "\t[directory mapname [-map_options]] ...\n"); - exit(1); + return; } diff --git a/contrib/amd/amd/info_exec.c b/contrib/amd/amd/info_exec.c new file mode 100644 index 000000000000..8ccab9aee579 --- /dev/null +++ b/contrib/amd/amd/info_exec.c @@ -0,0 +1,423 @@ +/* + * Copyright (c) 1997-2006 Erez Zadok + * Copyright (c) 1990 Jan-Simon Pendry + * Copyright (c) 1990 Imperial College of Science, Technology & Medicine + * Copyright (c) 1990 The Regents of the University of California. + * All rights reserved. + * + * This code is derived from software contributed to Berkeley by + * Jan-Simon Pendry at Imperial College, London. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * 3. All advertising materials mentioning features or use of this software + * must display the following acknowledgment: + * This product includes software developed by the University of + * California, Berkeley and its contributors. + * 4. Neither the name of the University nor the names of its contributors + * may be used to endorse or promote products derived from this software + * without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF + * SUCH DAMAGE. + * + * + * File: am-utils/amd/info_exec.c + * + */ + +/* + * Get info from executable map + * + * Original from Erik Kline, 2004. + */ + +#ifdef HAVE_CONFIG_H +# include <config.h> +#endif /* HAVE_CONFIG_H */ +#include <am_defs.h> +#include <amd.h> + +#define MAX_LINE_LEN 1500 + +/* forward declarations */ +int exec_init(mnt_map *m, char *map, time_t *tp); +int exec_search(mnt_map *m, char *map, char *key, char **pval, time_t *tp); + + +/* + * a timed fgets() + */ +static char * +fgets_timed(char *s, int size, int rdfd, int secs) +{ + fd_set fds; + struct timeval timeo; + time_t start, now; + int rval=0, i=0; + + if (!s || size < 0 || rdfd < 0) + return 0; + + s[0] = 0; + if (size == 0) + return s; + + start = clocktime(NULL); + while (s[i] != '\n' && i < size-1) { + s[i+1] = 0; /* places the requisite trailing '\0' */ + + /* ready for reading */ + rval = read(rdfd, (void *)(s+i), 1); + if (rval == 1) { + if (s[i] == 0) { + rval = 0; + break; + } + i++; + continue; + } else if (rval == 0) { + break; + } else if (rval < 0 && errno != EAGAIN && errno != EINTR) { + plog(XLOG_WARNING, "fgets_timed read error: %m"); + break; + } + + timeo.tv_usec = 0; + now = clocktime(NULL) - start; + if (secs <= 0) + timeo.tv_sec = 0; + else if (now < secs) + timeo.tv_sec = secs - now; + else { + /* timed out (now>=secs) */ + plog(XLOG_WARNING, "executable map read timed out (> %d secs)", secs); + rval = -1; + break; + } + + FD_ZERO(&fds); + FD_SET(rdfd, &fds); + + rval = select(rdfd+1, &fds, 0, 0, &timeo); + if (rval < 0) { + /* error selecting */ + plog(XLOG_WARNING, "fgets_timed select error: %m"); + if (errno == EINTR) + continue; + rval = -1; + break; + } else if (rval == 0) { + /* timed out */ + plog(XLOG_WARNING, "executable map read timed out (> %d secs)", secs); + rval = -1; + break; + } + } + + if (rval > 0) + return s; + + close(rdfd); + return (rval == 0 ? s : 0); +} + + +static int +read_line(char *buf, int size, int fd) +{ + int done = 0; + + while (fgets_timed(buf, size, fd, gopt.exec_map_timeout)) { + int len = strlen(buf); + done += len; + if (len > 1 && buf[len - 2] == '\\' && + buf[len - 1] == '\n') { + buf += len - 2; + size -= len - 2; + *buf = '\n'; + buf[1] = '\0'; + } else { + return done; + } + } + + return done; +} + + +/* + * Try to locate a value in a query answer + */ +static int +exec_parse_qanswer(int fd, char *map, char *key, char **pval, time_t *tp) +{ + char qanswer[MAX_LINE_LEN], *dc = 0; + int chuck = 0; + int line_no = 0; + + while (read_line(qanswer, sizeof(qanswer), fd)) { + char *cp; + char *hash; + int len = strlen(qanswer); + line_no++; + + /* + * Make sure we got the whole line + */ + if (qanswer[len - 1] != '\n') { + plog(XLOG_WARNING, "line %d in \"%s\" is too long", line_no, map); + chuck = 1; + } else { + qanswer[len - 1] = '\0'; + } + + /* + * Strip comments + */ + hash = strchr(qanswer, '#'); + if (hash) + *hash = '\0'; + + /* + * Find beginning of value (query answer) + */ + for (cp = qanswer; *cp && !isascii((int)*cp) && !isspace((int)*cp); cp++) + ;; + + /* Ignore blank lines */ + if (!*cp) + goto again; + + /* + * Return a copy of the data + */ + dc = strdup(cp); + *pval = dc; + dlog("%s returns %s", key, dc); + + close(fd); + return 0; + + again: + /* + * If the last read didn't get a whole line then + * throw away the remainder before continuing... + */ + if (chuck) { + while (fgets_timed(qanswer, sizeof(qanswer), fd, gopt.exec_map_timeout) && + !strchr(qanswer, '\n')) ; + chuck = 0; + } + } + + return ENOENT; +} + + +static int +set_nonblock(int fd) +{ + int val; + + if (fd < 0) + return 0; + + if ((val = fcntl(fd, F_GETFL, 0)) < 0) { + plog(XLOG_WARNING, "set_nonblock fcntl F_GETFL error: %m"); + return 0; + } + + val |= O_NONBLOCK; + if (fcntl(fd, F_SETFL, val) < 0) { + plog(XLOG_WARNING, "set_nonblock fcntl F_SETFL error: %m"); + return 0; + } + + return 1; +} + + +static int +exec_map_open(char *emap, char *key) +{ + pid_t p1, p2; + int pdes[2], nullfd, i; + char *argv[3]; + + if (!emap) + return 0; + + argv[0] = emap; + argv[1] = key; + argv[2] = NULL; + + if ((nullfd = open("/dev/null", O_WRONLY|O_NOCTTY)) < 0) + return -1; + + if (pipe(pdes) < 0) { + close(nullfd); + return -1; + } + + switch ((p1 = vfork())) { + case -1: + /* parent: fork error */ + close(nullfd); + close(pdes[0]); + close(pdes[1]); + return -1; + case 0: + /* child #1 */ + p2 = vfork(); + switch (p2) { + case -1: + /* child #1: fork error */ + exit(errno); + case 0: + /* child #2: init will reap our status */ + if (pdes[1] != STDOUT_FILENO) { + dup2(pdes[1], STDOUT_FILENO); + close(pdes[1]); + } + + if (nullfd != STDERR_FILENO) { + dup2(nullfd, STDERR_FILENO); + close(nullfd); + } + + for (i=0; i<FD_SETSIZE; i++) + if (i != STDOUT_FILENO && i != STDERR_FILENO) + close(i); + + /* make the write descriptor non-blocking */ + if (!set_nonblock(STDOUT_FILENO)) { + close(STDOUT_FILENO); + exit(-1); + } + + execve(emap, argv, NULL); + exit(errno); /* in case execve failed */ + } + + /* child #1 */ + exit(0); + } + + /* parent */ + close(nullfd); + close(pdes[1]); + + /* anti-zombie insurance */ + while (waitpid(p1,0,0) < 0) + if (errno != EINTR) + exit(errno); + + /* make the read descriptor non-blocking */ + if (!set_nonblock(pdes[0])) { + close(pdes[0]); + return -1; + } + + return pdes[0]; +} + + +/* + * Check for various permissions on executable map without trying to + * fork a new executable-map process. + * + * return: >0 (errno) if failed + * 0 if ok + */ +static int +exec_check_perm(char *map) +{ + struct stat sb; + + /* sanity and permission checks */ + if (!map) { + dlog("exec_check_permission got a NULL map"); + return EINVAL; + } + if (stat(map, &sb)) { + plog(XLOG_ERROR, "map \"%s\" stat failure: %m", map); + return errno; + } + if (!S_ISREG(sb.st_mode)) { + plog(XLOG_ERROR, "map \"%s\" should be regular file", map); + return EINVAL; + } + if (sb.st_uid != 0) { + plog(XLOG_ERROR, "map \"%s\" owned by uid %u (must be 0)", map, (u_int) sb.st_uid); + return EACCES; + } + if (!(sb.st_mode & S_IXUSR)) { + plog(XLOG_ERROR, "map \"%s\" should be executable", map); + return EACCES; + } + if (sb.st_mode & (S_ISUID|S_ISGID)) { + plog(XLOG_ERROR, "map \"%s\" should not be setuid/setgid", map); + return EACCES; + } + if (sb.st_mode & S_IWOTH) { + plog(XLOG_ERROR, "map \"%s\" should not be world writeable", map); + return EACCES; + } + + return 0; /* all is well */ +} + + +int +exec_init(mnt_map *m, char *map, time_t *tp) +{ + /* + * Basically just test that the executable map can be found + * and has proper permissions. + */ + return exec_check_perm(map); +} + + +int +exec_search(mnt_map *m, char *map, char *key, char **pval, time_t *tp) +{ + int mapfd, ret; + + if ((ret = exec_check_perm(map)) != 0) { + return ret; + } + + if (!key) + return 0; + + if (logfp) + fflush(logfp); + dlog("exec_search \"%s\", key: \"%s\"", map, key); + mapfd = exec_map_open(map, key); + + if (mapfd >= 0) { + if (tp) + *tp = clocktime(NULL); + + return exec_parse_qanswer(mapfd, map, key, pval, tp); + } + + return errno; +} diff --git a/contrib/amd/amd/info_file.c b/contrib/amd/amd/info_file.c index 8f78868d1dce..3777a2aebe94 100644 --- a/contrib/amd/amd/info_file.c +++ b/contrib/amd/amd/info_file.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: info_file.c,v 1.3.2.5 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/info_file.c * */ @@ -55,10 +54,9 @@ #define MAX_LINE_LEN 1500 /* forward declarations */ -int file_init(mnt_map *m, char *map, time_t *tp); +int file_init_or_mtime(mnt_map *m, char *map, time_t *tp); int file_reload(mnt_map *m, char *map, void (*fn) (mnt_map *, char *, char *)); int file_search(mnt_map *m, char *map, char *key, char **pval, time_t *tp); -int file_mtime(mnt_map *m, char *map, time_t *tp); static int @@ -87,7 +85,7 @@ read_line(char *buf, int size, FILE *fp) return done; } } - } while (size > 0 && !feof(fp)); + } while (size > 0 && !feof(fp) && !ferror(fp)); return done; } @@ -97,7 +95,12 @@ read_line(char *buf, int size, FILE *fp) * Try to locate a key in a file */ static int -search_or_reload_file(FILE *fp, char *map, char *key, char **val, mnt_map *m, void (*fn) (mnt_map *m, char *, char *)) +file_search_or_reload(FILE *fp, + char *map, + char *key, + char **val, + mnt_map *m, + void (*fn) (mnt_map *m, char *, char *)) { char key_val[MAX_LINE_LEN]; int chuck = 0; @@ -161,9 +164,7 @@ search_or_reload_file(FILE *fp, char *map, char *key, char **val, mnt_map *m, vo (*fn) (m, strdup(kp), dc); } else { *val = dc; -#ifdef DEBUG dlog("%s returns %s", key, dc); -#endif /* DEBUG */ } if (!fn) return 0; @@ -196,7 +197,7 @@ file_open(char *map, time_t *tp) if (mapf && tp) { struct stat stb; if (fstat(fileno(mapf), &stb) < 0) - *tp = clocktime(); + *tp = clocktime(NULL); else *tp = stb.st_mtime; } @@ -205,7 +206,7 @@ file_open(char *map, time_t *tp) int -file_init(mnt_map *m, char *map, time_t *tp) +file_init_or_mtime(mnt_map *m, char *map, time_t *tp) { FILE *mapf = file_open(map, tp); @@ -223,7 +224,7 @@ file_reload(mnt_map *m, char *map, void (*fn) (mnt_map *, char *, char *)) FILE *mapf = file_open(map, (time_t *) 0); if (mapf) { - int error = search_or_reload_file(mapf, map, 0, 0, m, fn); + int error = file_search_or_reload(mapf, map, 0, 0, m, fn); (void) fclose(mapf); return error; } @@ -243,23 +244,10 @@ file_search(mnt_map *m, char *map, char *key, char **pval, time_t *tp) *tp = t; error = -1; } else { - error = search_or_reload_file(mapf, map, key, pval, 0, 0); + error = file_search_or_reload(mapf, map, key, pval, 0, 0); } (void) fclose(mapf); return error; } return errno; } - - -int -file_mtime(mnt_map *m, char *map, time_t *tp) -{ - FILE *mapf = file_open(map, tp); - - if (mapf) { - (void) fclose(mapf); - return 0; - } - return errno; -} diff --git a/contrib/amd/amd/info_hesiod.c b/contrib/amd/amd/info_hesiod.c index fdcdd569209d..e345c9961508 100644 --- a/contrib/amd/amd/info_hesiod.c +++ b/contrib/amd/amd/info_hesiod.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: info_hesiod.c,v 1.6.2.4 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/info_hesiod.c * */ @@ -75,13 +74,11 @@ int hesiod_isup(mnt_map *m, char *map); int amu_hesiod_init(mnt_map *m, char *map, time_t *tp) { -#ifdef DEBUG dlog("amu_hesiod_init(%s)", map); -#endif /* DEBUG */ *tp = 0; #ifdef HAVE_HESIOD_INIT - if(!hesiod_context && hesiod_init(&hesiod_context) != 0) + if (!hesiod_context && hesiod_init(&hesiod_context) != 0) return ENOENT; #endif /* HAVE_HESIOD_INIT */ @@ -102,22 +99,21 @@ hesiod_search(mnt_map *m, char *map, char *key, char **pval, time_t *tp) int error; #endif /* not HAVE_HESIOD_INIT */ -#ifdef DEBUG dlog("hesiod_search(m=%lx, map=%s, key=%s, pval=%lx tp=%lx)", (unsigned long) m, map, key, (unsigned long) pval, (unsigned long) tp); -#endif /* DEBUG */ - sprintf(hes_key, "%s.%s", key, map + HES_PREFLEN); + if (key[0] == '.') + return ENOENT; + + xsnprintf(hes_key, sizeof(hes_key), "%s.%s", key, map + HES_PREFLEN); /* * Call the resolver */ -#ifdef DEBUG dlog("Hesiod base is: %s\n", gopt.hesiod_base); dlog("hesiod_search: hes_resolve(%s, %s)", hes_key, gopt.hesiod_base); - if (debug_flags & D_INFO) + if (amuDebug(D_INFO)) _res.options |= RES_DEBUG; -#endif /* DEBUG */ #ifdef HAVE_HESIOD_INIT /* new style hesiod */ @@ -144,9 +140,7 @@ hesiod_search(mnt_map *m, char *map, char *key, char **pval, time_t *tp) /* * Otherwise reflect the hesiod error into a Un*x error */ -# ifdef DEBUG dlog("hesiod_search: Error: %d", hes_error()); -# endif /* DEBUG */ switch (hes_error()) { case HES_ER_NOTFOUND: error = ENOENT; @@ -161,9 +155,7 @@ hesiod_search(mnt_map *m, char *map, char *key, char **pval, time_t *tp) error = EINVAL; break; } -# ifdef DEBUG dlog("hesiod_search: Returning: %d", error); -# endif /* DEBUG */ return error; #endif /* not HAVE_HESIOD_INIT */ } @@ -183,9 +175,7 @@ hesiod_isup(mnt_map *m, char *map) static int last_status = 1; /* assume up by default */ error = hesiod_search(m, map, "/defaults", &val, &mtime); -#ifdef DEBUG dlog("hesiod_isup(%s): %s", map, strerror(error)); -#endif /* DEBUG */ if (error != 0 && error != ENOENT) { plog(XLOG_ERROR, "hesiod_isup: error getting `/defaults' entry in map %s: %m", map); diff --git a/contrib/amd/amd/info_ldap.c b/contrib/amd/amd/info_ldap.c index 77ae9c4461db..36ce1c8693d3 100644 --- a/contrib/amd/amd/info_ldap.c +++ b/contrib/amd/amd/info_ldap.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: info_ldap.c,v 1.9.2.9 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/info_ldap.c * */ @@ -48,6 +47,20 @@ * LDAP Home Page: http://www.umich.edu/~rsug/ldap/ */ +/* + * WARNING: as of Linux Fedora Core 5 (which comes with openldap-2.3.9), the + * ldap.h headers deprecate several functions used in this file, such as + * ldap_unbind. You get compile errors about missing extern definitions. + * Those externs are still in <ldap.h>, but surrounded by an ifdef + * LDAP_DEPRECATED. I am turning on that ifdef here, under the assumption + * that the functions may be deprecated, but they still work for this + * (older?) version of the LDAP API. It gets am-utils to compile, but it is + * not clear if it will work perfectly. + */ +#ifndef LDAP_DEPRECATED +# define LDAP_DEPRECATED 1 +#endif /* not LDAP_DEPRECATED */ + #ifdef HAVE_CONFIG_H # include <config.h> #endif /* HAVE_CONFIG_H */ @@ -109,7 +122,7 @@ struct he_ent { * FORWARD DECLARATIONS: */ static int amu_ldap_rebind(ALD *a); -static int get_ldap_timestamp(LDAP *ld, char *map, time_t *ts); +static int get_ldap_timestamp(ALD *a, char *map, time_t *ts); /* @@ -167,13 +180,54 @@ cr_free(CR *c) } +/* + * Special ldap_unbind function to handle SIGPIPE. + * We first ignore SIGPIPE, in case a remote LDAP server was + * restarted, then we reinstall the handler. + */ +static int +amu_ldap_unbind(LDAP *ld) +{ + int e; +#ifdef HAVE_SIGACTION + struct sigaction sa; +#else /* not HAVE_SIGACTION */ + void (*handler)(int); +#endif /* not HAVE_SIGACTION */ + + dlog("amu_ldap_unbind()\n"); + +#ifdef HAVE_SIGACTION + sa.sa_handler = SIG_IGN; + sa.sa_flags = 0; + sigemptyset(&(sa.sa_mask)); + sigaddset(&(sa.sa_mask), SIGPIPE); + sigaction(SIGPIPE, &sa, &sa); /* set IGNORE, and get old action */ +#else /* not HAVE_SIGACTION */ + handler = signal(SIGPIPE, SIG_IGN); +#endif /* not HAVE_SIGACTION */ + + e = ldap_unbind(ld); + +#ifdef HAVE_SIGACTION + sigemptyset(&(sa.sa_mask)); + sigaddset(&(sa.sa_mask), SIGPIPE); + sigaction(SIGPIPE, &sa, NULL); +#else /* not HAVE_SIGACTION */ + (void) signal(SIGPIPE, handler); +#endif /* not HAVE_SIGACTION */ + + return e; +} + + static void ald_free(ALD *a) { he_free(a->hostent); cr_free(a->credentials); if (a->ldap != NULL) - ldap_unbind(a->ldap); + amu_ldap_unbind(a->ldap); XFREE(a); } @@ -184,27 +238,29 @@ amu_ldap_init(mnt_map *m, char *map, time_t *ts) ALD *aldh; CR *creds; + dlog("-> amu_ldap_init: map <%s>\n", map); + /* * XXX: by checking that map_type must be defined, aren't we * excluding the possibility of automatic searches through all * map types? */ if (!gopt.map_type || !STREQ(gopt.map_type, AMD_LDAP_TYPE)) { - return (ENOENT); - } -#ifdef DEBUG - else { + dlog("amu_ldap_init called with map_type <%s>\n", + (gopt.map_type ? gopt.map_type : "null")); + } else { dlog("Map %s is ldap\n", map); } -#endif /* DEBUG */ aldh = ALLOC(ALD); creds = ALLOC(CR); - aldh->ldap = NULL ; + aldh->ldap = NULL; aldh->hostent = string2he(gopt.ldap_hostports); if (aldh->hostent == NULL) { plog(XLOG_USER, "Unable to parse hostport %s for ldap map %s", gopt.ldap_hostports ? gopt.ldap_hostports : "(null)", map); + XFREE(creds); + XFREE(aldh); return (ENOENT); } creds->who = ""; @@ -212,22 +268,17 @@ amu_ldap_init(mnt_map *m, char *map, time_t *ts) creds->method = LDAP_AUTH_SIMPLE; aldh->credentials = creds; aldh->timestamp = 0; -#ifdef DEBUG + aldh->ldap = NULL; dlog("Trying for %s:%d\n", aldh->hostent->host, aldh->hostent->port); -#endif /* DEBUG */ if (amu_ldap_rebind(aldh)) { ald_free(aldh); return (ENOENT); } m->map_data = (void *) aldh; -#ifdef DEBUG dlog("Bound to %s:%d\n", aldh->hostent->host, aldh->hostent->port); -#endif /* DEBUG */ - if (get_ldap_timestamp(aldh->ldap, map, ts)) + if (get_ldap_timestamp(aldh, map, ts)) return (ENOENT); -#ifdef DEBUG - dlog("Got timestamp for map %s: %ld\n", map, *ts); -#endif /* DEBUG */ + dlog("Got timestamp for map %s: %ld\n", map, (u_long) *ts); return (0); } @@ -239,16 +290,21 @@ amu_ldap_rebind(ALD *a) LDAP *ld; HE_ENT *h; CR *c = a->credentials; - time_t now = clocktime(); + time_t now = clocktime(NULL); int try; + dlog("-> amu_ldap_rebind\n"); + if (a->ldap != NULL) { if ((a->timestamp - now) > AMD_LDAP_TTL) { -#ifdef DEBUG - dlog("Reestablishing ldap connection\n"); -#endif /* DEBUG */ - ldap_unbind(a->ldap); + dlog("Re-establishing ldap connection\n"); + amu_ldap_unbind(a->ldap); a->timestamp = now; + a->ldap = NULL; + } else { + /* Assume all is OK. If it wasn't we'll be back! */ + dlog("amu_ldap_rebind: timestamp OK\n"); + return (0); } } @@ -258,21 +314,34 @@ amu_ldap_rebind(ALD *a) plog(XLOG_WARNING, "Unable to ldap_open to %s:%d\n", h->host, h->port); break; } +#if LDAP_VERSION_MAX > LDAP_VERSION2 + /* handle LDAPv3 and heigher, if available and amd.conf-igured */ + if (gopt.ldap_proto_version > LDAP_VERSION2) { + if (!ldap_set_option(ld, LDAP_OPT_PROTOCOL_VERSION, &gopt.ldap_proto_version)) { + dlog("amu_ldap_rebind: LDAP protocol version set to %ld\n", + gopt.ldap_proto_version); + } else { + plog(XLOG_WARNING, "Unable to set ldap protocol version to %ld\n", + gopt.ldap_proto_version); + break; + } + } +#endif /* LDAP_VERSION_MAX > LDAP_VERSION2 */ if (ldap_bind_s(ld, c->who, c->pw, c->method) != LDAP_SUCCESS) { plog(XLOG_WARNING, "Unable to ldap_bind to %s:%d as %s\n", h->host, h->port, c->who); break; } if (gopt.ldap_cache_seconds > 0) { -#ifdef HAVE_LDAP_ENABLE_CACHE +#if defined(HAVE_LDAP_ENABLE_CACHE) && defined(HAVE_EXTERN_LDAP_ENABLE_CACHE) ldap_enable_cache(ld, gopt.ldap_cache_seconds, gopt.ldap_cache_maxmem); -#else /* HAVE_LDAP_ENABLE_CACHE */ - plog(XLOG_WARNING, "ldap_enable_cache(%ld) does not exist on this system!\n", gopt.ldap_cache_seconds); -#endif /* HAVE_LDAP_ENABLE_CACHE */ - a->ldap = ld; - a->timestamp = now; - return (0); +#else /* not defined(HAVE_LDAP_ENABLE_CACHE) && defined(HAVE_EXTERN_LDAP_ENABLE_CACHE) */ + plog(XLOG_WARNING, "ldap_enable_cache(%ld) is not available on this system!\n", gopt.ldap_cache_seconds); +#endif /* not defined(HAVE_LDAP_ENABLE_CACHE) && defined(HAVE_EXTERN_LDAP_ENABLE_CACHE) */ } + a->ldap = ld; + a->timestamp = now; + return (0); } plog(XLOG_WARNING, "Exhausted list of ldap servers, looping.\n"); } @@ -283,24 +352,24 @@ amu_ldap_rebind(ALD *a) static int -get_ldap_timestamp(LDAP *ld, char *map, time_t *ts) +get_ldap_timestamp(ALD *a, char *map, time_t *ts) { struct timeval tv; char **vals, *end; char filter[MAXPATHLEN]; int i, err = 0, nentries = 0; - LDAPMessage *res, *entry; + LDAPMessage *res = NULL, *entry; + + dlog("-> get_ldap_timestamp: map <%s>\n", map); tv.tv_sec = 3; tv.tv_usec = 0; - sprintf(filter, AMD_LDAP_TSFILTER, map); -#ifdef DEBUG + xsnprintf(filter, sizeof(filter), AMD_LDAP_TSFILTER, map); dlog("Getting timestamp for map %s\n", map); dlog("Filter is: %s\n", filter); dlog("Base is: %s\n", gopt.ldap_base); -#endif /* DEBUG */ for (i = 0; i < AMD_LDAP_RETRIES; i++) { - err = ldap_search_st(ld, + err = ldap_search_st(a->ldap, gopt.ldap_base, LDAP_SCOPE_SUBTREE, filter, @@ -310,19 +379,32 @@ get_ldap_timestamp(LDAP *ld, char *map, time_t *ts) &res); if (err == LDAP_SUCCESS) break; -#ifdef DEBUG - dlog("Timestamp search timed out, trying again...\n"); -#endif /* DEBUG */ + if (res) { + ldap_msgfree(res); + res = NULL; + } + plog(XLOG_USER, "Timestamp LDAP search attempt %d failed: %s\n", + i + 1, ldap_err2string(err)); + if (err != LDAP_TIMEOUT) { + dlog("get_ldap_timestamp: unbinding...\n"); + amu_ldap_unbind(a->ldap); + a->ldap = NULL; + if (amu_ldap_rebind(a)) + return (ENOENT); + } + dlog("Timestamp search failed, trying again...\n"); } if (err != LDAP_SUCCESS) { *ts = 0; plog(XLOG_USER, "LDAP timestamp search failed: %s\n", ldap_err2string(err)); + if (res) + ldap_msgfree(res); return (ENOENT); } - nentries = ldap_count_entries(ld, res); + nentries = ldap_count_entries(a->ldap, res); if (nentries == 0) { plog(XLOG_USER, "No timestamp entry for map %s\n", map); *ts = 0; @@ -330,8 +412,8 @@ get_ldap_timestamp(LDAP *ld, char *map, time_t *ts) return (ENOENT); } - entry = ldap_first_entry(ld, res); - vals = ldap_get_values(ld, entry, AMD_LDAP_TSATTR); + entry = ldap_first_entry(a->ldap, res); + vals = ldap_get_values(a->ldap, entry, AMD_LDAP_TSATTR); if (ldap_count_values(vals) == 0) { plog(XLOG_USER, "Missing timestamp value for map %s\n", map); *ts = 0; @@ -339,9 +421,7 @@ get_ldap_timestamp(LDAP *ld, char *map, time_t *ts) ldap_msgfree(res); return (ENOENT); } -#ifdef DEBUG dlog("TS value is:%s:\n", vals[0]); -#endif /* DEBUG */ if (vals[0]) { *ts = (time_t) strtol(vals[0], &end, 10); @@ -352,7 +432,7 @@ get_ldap_timestamp(LDAP *ld, char *map, time_t *ts) } if (!*ts > 0) { plog(XLOG_USER, "Nonpositive timestamp %ld for map %s\n", - *ts, map); + (u_long) *ts, map); err = ENOENT; } } else { @@ -363,9 +443,7 @@ get_ldap_timestamp(LDAP *ld, char *map, time_t *ts) ldap_value_free(vals); ldap_msgfree(res); -#ifdef DEBUG - dlog("The timestamp for %s is %ld (err=%d)\n", map, *ts, err); -#endif /* DEBUG */ + dlog("The timestamp for %s is %ld (err=%d)\n", map, (u_long) *ts, err); return (err); } @@ -373,12 +451,15 @@ get_ldap_timestamp(LDAP *ld, char *map, time_t *ts) int amu_ldap_search(mnt_map *m, char *map, char *key, char **pval, time_t *ts) { - char **vals, filter[MAXPATHLEN]; + char **vals, filter[MAXPATHLEN], filter2[2 * MAXPATHLEN]; + char *f1, *f2; struct timeval tv; int i, err = 0, nvals = 0, nentries = 0; - LDAPMessage *entry, *res; + LDAPMessage *entry, *res = NULL; ALD *a = (ALD *) (m->map_data); + dlog("-> amu_ldap_search: map <%s>, key <%s>\n", map, key); + tv.tv_sec = 2; tv.tv_usec = 0; if (a == NULL) { @@ -388,43 +469,63 @@ amu_ldap_search(mnt_map *m, char *map, char *key, char **pval, time_t *ts) if (amu_ldap_rebind(a)) /* Check that's the handle is still valid */ return (ENOENT); - sprintf(filter, AMD_LDAP_FILTER, map, key); -#ifdef DEBUG - dlog("Search with filter: %s\n", filter); -#endif /* DEBUG */ + xsnprintf(filter, sizeof(filter), AMD_LDAP_FILTER, map, key); + /* "*" is special to ldap_search(); run through the filter escaping it. */ + f1 = filter; f2 = filter2; + while (*f1) { + if (*f1 == '*') { + *f2++ = '\\'; *f2++ = '2'; *f2++ = 'a'; + f1++; + } else { + *f2++ = *f1++; + } + } + *f2 = '\0'; + dlog("Search with filter: <%s>\n", filter2); for (i = 0; i < AMD_LDAP_RETRIES; i++) { err = ldap_search_st(a->ldap, gopt.ldap_base, LDAP_SCOPE_SUBTREE, - filter, + filter2, 0, 0, &tv, &res); if (err == LDAP_SUCCESS) break; + if (res) { + ldap_msgfree(res); + res = NULL; + } + plog(XLOG_USER, "LDAP search attempt %d failed: %s\n", + i + 1, ldap_err2string(err)); + if (err != LDAP_TIMEOUT) { + dlog("amu_ldap_search: unbinding...\n"); + amu_ldap_unbind(a->ldap); + a->ldap = NULL; + if (amu_ldap_rebind(a)) + return (ENOENT); + } } switch (err) { case LDAP_SUCCESS: break; case LDAP_NO_SUCH_OBJECT: -#ifdef DEBUG dlog("No object\n"); -#endif /* DEBUG */ - ldap_msgfree(res); + if (res) + ldap_msgfree(res); return (ENOENT); default: plog(XLOG_USER, "LDAP search failed: %s\n", ldap_err2string(err)); - ldap_msgfree(res); + if (res) + ldap_msgfree(res); return (EIO); } nentries = ldap_count_entries(a->ldap, res); -#ifdef DEBUG dlog("Search found %d entries\n", nentries); -#endif /* DEBUG */ if (nentries == 0) { ldap_msgfree(res); return (ENOENT); @@ -438,9 +539,7 @@ amu_ldap_search(mnt_map *m, char *map, char *key, char **pval, time_t *ts) ldap_msgfree(res); return (EIO); } -#ifdef DEBUG dlog("Map %s, %s => %s\n", map, key, vals[0]); -#endif /* DEBUG */ if (vals[0]) { *pval = strdup(vals[0]); err = 0; @@ -461,15 +560,13 @@ amu_ldap_mtime(mnt_map *m, char *map, time_t *ts) ALD *aldh = (ALD *) (m->map_data); if (aldh == NULL) { -#ifdef DEBUG dlog("LDAP panic: unable to find map data\n"); -#endif /* DEBUG */ return (ENOENT); } if (amu_ldap_rebind(aldh)) { return (ENOENT); } - if (get_ldap_timestamp(aldh->ldap, map, ts)) { + if (get_ldap_timestamp(aldh, map, ts)) { return (ENOENT); } return (0); diff --git a/contrib/amd/amd/info_ndbm.c b/contrib/amd/amd/info_ndbm.c index bd92c137f7cf..8a52ba9e201d 100644 --- a/contrib/amd/amd/info_ndbm.c +++ b/contrib/amd/amd/info_ndbm.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: info_ndbm.c,v 1.3.2.4 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/info_ndbm.c * */ @@ -86,8 +85,8 @@ ndbm_search(mnt_map *m, char *map, char *key, char **pval, time_t *tp) #ifdef DBM_SUFFIX char dbfilename[256]; - strcpy(dbfilename, map); - strcat(dbfilename, DBM_SUFFIX); + xstrlcpy(dbfilename, map, sizeof(dbfilename)); + xstrlcat(dbfilename, DBM_SUFFIX, sizeof(dbfilename)); error = stat(dbfilename, &stb); #else /* not DBM_SUFFIX */ error = fstat(dbm_pagfno(db), &stb); @@ -117,14 +116,14 @@ ndbm_init(mnt_map *m, char *map, time_t *tp) #ifdef DBM_SUFFIX char dbfilename[256]; - strcpy(dbfilename, map); - strcat(dbfilename, DBM_SUFFIX); + xstrlcpy(dbfilename, map, sizeof(dbfilename)); + xstrlcat(dbfilename, DBM_SUFFIX, sizeof(dbfilename)); error = stat(dbfilename, &stb); #else /* not DBM_SUFFIX */ error = fstat(dbm_pagfno(db), &stb); #endif /* not DBM_SUFFIX */ if (error < 0) - *tp = clocktime(); + *tp = clocktime(NULL); else *tp = stb.st_mtime; dbm_close(db); diff --git a/contrib/amd/amd/info_nis.c b/contrib/amd/amd/info_nis.c index b59123f78cfc..bcb87d5d02aa 100644 --- a/contrib/amd/amd/info_nis.c +++ b/contrib/amd/amd/info_nis.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: info_nis.c,v 1.6.2.5 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/info_nis.c * */ @@ -107,9 +106,7 @@ determine_nis_domain(void) } if (!*default_domain) { nis_not_running = 1; -#ifdef DEBUG plog(XLOG_WARNING, "NIS domain name is not set. NIS ignored."); -#endif /* DEBUG */ return ENOENT; } gopt.nis_domain = strdup(default_domain); @@ -144,12 +141,8 @@ callback(int status, char *key, int kl, char *val, int vl, char *data) /* check what went wrong */ int e = ypprot_err(status); -#ifdef DEBUG plog(XLOG_ERROR, "yp enumeration of %s: %s, status=%d, e=%d", ncdp->ncd_map, yperr_string(e), status, e); -#else /* not DEBUG */ - plog(XLOG_ERROR, "yp enumeration of %s: %s", ncdp->ncd_map, yperr_string(e)); -#endif /* not DEBUG */ } return TRUE; } @@ -350,9 +343,7 @@ nis_init(mnt_map *m, char *map, time_t *tp) /* NIS server found */ has_yp_order = 1; *tp = (time_t) order; -#ifdef DEBUG dlog("NIS master for %s@%s has order %lu", map, gopt.nis_domain, (unsigned long) order); -#endif /* DEBUG */ break; case YPERR_YPERR: /* NIS+ server found ! */ @@ -361,9 +352,7 @@ nis_init(mnt_map *m, char *map, time_t *tp) if (yp_master(gopt.nis_domain, map, &master)) { return ENOENT; } else { -#ifdef DEBUG dlog("NIS master for %s@%s is a NIS+ server", map, gopt.nis_domain); -#endif /* DEBUG */ /* Use fake timestamps */ *tp = time(NULL); } @@ -442,11 +431,9 @@ am_yp_all(char *indomain, char *inmap, struct ypall_callback *incallback) &outvallen); XFREE(outkey_old); } while (!i); -#ifdef DEBUG if (i) { dlog("yp_next() returned error: %s\n", yperr_string(i)); } -#endif /* DEBUG */ if (i == YPERR_NOMORE) return 0; return i; diff --git a/contrib/amd/amd/info_nisplus.c b/contrib/amd/amd/info_nisplus.c index 46018bccd229..d392b48fed6a 100644 --- a/contrib/amd/amd/info_nisplus.c +++ b/contrib/amd/amd/info_nisplus.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: info_nisplus.c,v 1.3.2.5 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/info_nisplus.c * */ @@ -74,9 +73,7 @@ nisplus_callback(const nis_name key, const nis_object *value, voidp opaquedata) char *vp = strnsave(ENTRY_VAL(value, 1), ENTRY_LEN(value, 1)); struct nis_callback_data *data = (struct nis_callback_data *) opaquedata; -#ifdef DEBUG dlog("NISplus callback for <%s,%s>", kp, vp); -#endif /* DEBUG */ (*data->ncd_fn) (data->ncd_m, kp, vp); @@ -95,6 +92,7 @@ nisplus_reload(mnt_map *m, char *map, void (*fn) ()) nis_result *result; char *org; /* if map does not have ".org_dir" then append it */ nis_name map_name; + size_t l; org = strstr(map, NISPLUS_ORGDIR); if (org == NULL) @@ -103,21 +101,20 @@ nisplus_reload(mnt_map *m, char *map, void (*fn) ()) org = ""; /* make some room for the NIS map_name */ - map_name = xmalloc(strlen(map) + sizeof(NISPLUS_ORGDIR)); + l = strlen(map) + sizeof(NISPLUS_ORGDIR); + map_name = xmalloc(l); if (map_name == NULL) { plog(XLOG_ERROR, "Unable to create map_name %s: %s", map, strerror(ENOMEM)); return ENOMEM; } - sprintf(map_name, "%s%s", map, org); + xsnprintf(map_name, l, "%s%s", map, org); data.ncd_m = m; data.ncd_map = map_name; data.ncd_fn = fn; -#ifdef DEBUG dlog("NISplus reload for %s", map); -#endif /* DEBUG */ result = nis_list(map_name, EXPAND_NAME | FOLLOW_LINKS | FOLLOW_PATH, @@ -145,10 +142,8 @@ nisplus_search_callback(const nis_name key, const nis_object *value, voidp opaqu { struct nisplus_search_callback_data *data = (struct nisplus_search_callback_data *) opaquedata; -#ifdef DEBUG dlog("NISplus search callback for <%s>", ENTRY_VAL(value, 0)); dlog("NISplus search callback value <%s>", ENTRY_VAL(value, 1)); -#endif /* DEBUG */ data->value = strnsave(ENTRY_VAL(value, 1), ENTRY_LEN(value, 1)); return TRUE; @@ -166,6 +161,7 @@ nisplus_search(mnt_map *m, char *map, char *key, char **val, time_t *tp) struct nisplus_search_callback_data data; nis_name index; char *org; /* if map does not have ".org_dir" then append it */ + size_t l; org = strstr(map, NISPLUS_ORGDIR); if (org == NULL) @@ -174,14 +170,14 @@ nisplus_search(mnt_map *m, char *map, char *key, char **val, time_t *tp) org = ""; /* make some room for the NIS index */ - index = xmalloc(sizeof('[') /* for opening selection criteria */ - +sizeof(NISPLUS_KEY) - + strlen(key) - + sizeof(']') /* for closing selection criteria */ - +sizeof(',') /* + 1 for , separator */ - +strlen(map) - + sizeof(NISPLUS_ORGDIR) - ); + l = sizeof('[') /* for opening selection criteria */ + + sizeof(NISPLUS_KEY) + + strlen(key) + + sizeof(']') /* for closing selection criteria */ + + sizeof(',') /* + 1 for , separator */ + + strlen(map) + + sizeof(NISPLUS_ORGDIR); + index = xmalloc(l); if (index == NULL) { plog(XLOG_ERROR, "Unable to create index %s: %s", @@ -189,14 +185,12 @@ nisplus_search(mnt_map *m, char *map, char *key, char **val, time_t *tp) strerror(ENOMEM)); return ENOMEM; } - sprintf(index, "[%s%s],%s%s", NISPLUS_KEY, key, map, org); + xsnprintf(index, l, "[%s%s],%s%s", NISPLUS_KEY, key, map, org); data.key = key; data.value = NULL; -#ifdef DEBUG dlog("NISplus search for %s", index); -#endif /* DEBUG */ result = nis_list(index, EXPAND_NAME | FOLLOW_LINKS | FOLLOW_PATH, @@ -220,11 +214,9 @@ nisplus_search(mnt_map *m, char *map, char *key, char **val, time_t *tp) if (data.value == NULL) { nis_object *value = result->objects.objects_val; -#ifdef DEBUG dlog("NISplus search found <nothing>"); dlog("NISplus search for %s: %s(%d)", map, nis_sperrno(result->status), result->status); -#endif /* DEBUG */ if (value != NULL) data.value = strnsave(ENTRY_VAL(value, 1), ENTRY_LEN(value, 1)); @@ -233,23 +225,17 @@ nisplus_search(mnt_map *m, char *map, char *key, char **val, time_t *tp) if (*val) { error = 0; -#ifdef DEBUG dlog("NISplus search found %s", *val); -#endif /* DEBUG */ } else { error = ENOENT; -#ifdef DEBUG dlog("NISplus search found nothing"); -#endif /* DEBUG */ } *tp = 0; break; case NIS_NOSUCHNAME: -#ifdef DEBUG dlog("NISplus search returned %d", result->status); -#endif /* DEBUG */ error = ENOENT; break; @@ -271,6 +257,7 @@ nisplus_init(mnt_map *m, char *map, time_t *tp) char *org; /* if map does not have ".org_dir" then append it */ nis_name map_name; int error = 0; + size_t l; org = strstr(map, NISPLUS_ORGDIR); if (org == NULL) @@ -279,7 +266,8 @@ nisplus_init(mnt_map *m, char *map, time_t *tp) org = ""; /* make some room for the NIS map_name */ - map_name = xmalloc(strlen(map) + sizeof(NISPLUS_ORGDIR)); + l = strlen(map) + sizeof(NISPLUS_ORGDIR); + map_name = xmalloc(l); if (map_name == NULL) { plog(XLOG_ERROR, "Unable to create map_name %s: %s", @@ -287,7 +275,7 @@ nisplus_init(mnt_map *m, char *map, time_t *tp) strerror(ENOMEM)); return ENOMEM; } - sprintf(map_name, "%s%s", map, org); + xsnprintf(map_name, l, "%s%s", map, org); result = nis_lookup(map_name, (EXPAND_NAME | FOLLOW_LINKS | FOLLOW_PATH)); @@ -300,10 +288,8 @@ nisplus_init(mnt_map *m, char *map, time_t *tp) } if (result->status != NIS_SUCCESS) { -#ifdef DEBUG dlog("NISplus init <%s>: %s (%d)", map, nis_sperrno(result->status), result->status); -#endif /* DEBUG */ error = ENOENT; } diff --git a/contrib/amd/amd/info_passwd.c b/contrib/amd/amd/info_passwd.c index a14ac120acff..c8bf388b1d65 100644 --- a/contrib/amd/amd/info_passwd.c +++ b/contrib/amd/amd/info_passwd.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: info_passwd.c,v 1.3.2.4 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/info_passwd.c * */ @@ -151,11 +150,11 @@ passwd_search(mnt_map *m, char *map, char *key, char **pval, time_t *tp) do { q = strrchr(p, '/'); if (q) { - strcat(rhost, q + 1); - strcat(rhost, "."); + xstrlcat(rhost, q + 1, sizeof(rhost)); + xstrlcat(rhost, ".", sizeof(rhost)); *q = '\0'; } else { - strcat(rhost, p); + xstrlcat(rhost, p, sizeof(rhost)); } } while (q); @@ -176,11 +175,9 @@ passwd_search(mnt_map *m, char *map, char *key, char **pval, time_t *tp) p++; else p = "type:=nfs;rfs:=/${var0}/${var1};rhost:=${var1};sublink:=${var2};fs:=${autodir}${var3}"; - sprintf(val, "var0:=%s;var1:=%s;var2:=%s;var3:=%s;%s", - dir+1, rhost, user, pw->pw_dir, p); -#ifdef DEBUG + xsnprintf(val, sizeof(val), "var0:=%s;var1:=%s;var2:=%s;var3:=%s;%s", + dir+1, rhost, user, pw->pw_dir, p); dlog("passwd_search: map=%s key=%s -> %s", map, key, val); -#endif /* DEBUG */ if (q) *q = '.'; *pval = strdup(val); diff --git a/contrib/amd/amd/info_union.c b/contrib/amd/amd/info_union.c index 8613f6290099..8f0631c64ac9 100644 --- a/contrib/amd/amd/info_union.c +++ b/contrib/amd/amd/info_union.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: info_union.c,v 1.3.2.4 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/info_union.c * */ @@ -81,10 +80,12 @@ union_search(mnt_map *m, char *map, char *key, char **pval, time_t *tp) char *mapd = strdup(map + UNION_PREFLEN); char **v = strsplit(mapd, ':', '\"'); char **p; + size_t l; for (p = v; p[1]; p++) ; - *pval = xmalloc(strlen(*p) + 5); - sprintf(*pval, "fs:=%s", *p); + l = strlen(*p) + 5; + *pval = xmalloc(l); + xsnprintf(*pval, l, "fs:=%s", *p); XFREE(mapd); XFREE(v); return 0; @@ -104,7 +105,7 @@ union_reload(mnt_map *m, char *map, void (*fn) (mnt_map *, char *, char *)) (*fn) (m, strdup("/defaults"), strdup("type:=link;opts:=nounmount;sublink:=${key}")); for (dir = v; *dir; dir++) { - int dlen; + size_t l; struct dirent *dp; DIR *dirp = opendir(*dir); @@ -112,11 +113,9 @@ union_reload(mnt_map *m, char *map, void (*fn) (mnt_map *, char *, char *)) plog(XLOG_USER, "Cannot read directory %s: %m", *dir); continue; } - dlen = strlen(*dir); + l = strlen(*dir) + 5; -#ifdef DEBUG dlog("Reading directory %s...", *dir); -#endif /* DEBUG */ while ((dp = readdir(dirp))) { char *val, *dpname = &dp->d_name[0]; if (dpname[0] == '.' && @@ -124,11 +123,9 @@ union_reload(mnt_map *m, char *map, void (*fn) (mnt_map *, char *, char *)) (dpname[1] == '.' && dpname[2] == '\0'))) continue; -#ifdef DEBUG dlog("... gives %s", dp->d_name); -#endif /* DEBUG */ - val = xmalloc(dlen + 5); - sprintf(val, "fs:=%s", *dir); + val = xmalloc(l); + xsnprintf(val, l + 5, "fs:=%s", *dir); (*fn) (m, strdup(dp->d_name), val); } closedir(dirp); @@ -138,9 +135,10 @@ union_reload(mnt_map *m, char *map, void (*fn) (mnt_map *, char *, char *)) * Add wildcard entry */ { - char *val = xmalloc(strlen(dir[-1]) + 5); + size_t l = strlen(*(dir-1)) + 5; + char *val = xmalloc(l); - sprintf(val, "fs:=%s", dir[-1]); + xsnprintf(val, l, "fs:=%s", *(dir-1)); (*fn) (m, strdup("*"), val); } XFREE(mapd); diff --git a/contrib/amd/amd/map.c b/contrib/amd/amd/map.c index dfec3a1038ee..8696dfd6984d 100644 --- a/contrib/amd/amd/map.c +++ b/contrib/amd/amd/map.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: map.c,v 1.6.2.8 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/map.c * */ @@ -50,7 +49,6 @@ #define smallest_t(t1, t2) (t1 != NEVER ? (t2 != NEVER ? (t1 < t2 ? t1 : t2) : t1) : t2) #define IGNORE_FLAGS (MFF_MOUNTING|MFF_UNMOUNTING|MFF_RESTART) -#define NEVER (time_t) 0 #define new_gen() (am_gen++) /* @@ -70,11 +68,11 @@ static u_int am_gen = 2; /* Initial generation number */ static int timeout_mp_id; /* Id from last call to timeout */ -am_node *root_node; /* The root of the mount tree */ -am_node **exported_ap = (am_node **) 0; -int exported_ap_size = 0; -int first_free_map = 0; /* First available free slot */ -int last_used_map = -1; /* Last unavailable used slot */ +static am_node *root_node; /* The root of the mount tree */ +static am_node **exported_ap = (am_node **) 0; +static int exported_ap_size = 0; +static int first_free_map = 0; /* First available free slot */ +static int last_used_map = -1; /* Last unavailable used slot */ /* @@ -103,9 +101,65 @@ static nfsfattr gen_fattr = }; /* forward declarations */ -static int unmount_node(am_node *mp); +static int unmount_node(opaque_t arg); static void exported_ap_free(am_node *mp); static void remove_am(am_node *mp); +static am_node *get_root_ap(char *dir); + + +/* + * Iterator functions for exported_ap[] + */ +am_node * +get_first_exported_ap(int *index) +{ + *index = -1; + return get_next_exported_ap(index); +} + + +am_node * +get_next_exported_ap(int *index) +{ + (*index)++; + while (*index < exported_ap_size) { + if (exported_ap[*index] != NULL) + return exported_ap[*index]; + (*index)++; + } + return NULL; +} + + +/* + * Get exported_ap by index + */ +am_node * +get_exported_ap(int index) +{ + if (index < 0 || index >= exported_ap_size) + return 0; + return exported_ap[index]; +} + + +/* + * Get exported_ap by path + */ +am_node * +path_to_exported_ap(char *path) +{ + int index; + am_node *mp; + + mp = get_first_exported_ap(&index); + while (mp != NULL) { + if (STREQ(mp->am_path, path)) + break; + mp = get_next_exported_ap(&index); + } + return mp; +} /* @@ -131,6 +185,46 @@ exported_ap_realloc_map(int nsize) } + +am_node * +get_ap_child(am_node *mp, char *fname) +{ + am_node *new_mp; + mntfs *mf = mp->am_mnt; + + /* + * Allocate a new map + */ + new_mp = exported_ap_alloc(); + if (new_mp) { + /* + * Fill it in + */ + init_map(new_mp, fname); + + /* + * Put it in the table + */ + insert_am(new_mp, mp); + + /* + * Fill in some other fields, + * path and mount point. + * + * bugfix: do not prepend old am_path if direct map + * <wls@astro.umd.edu> William Sebok + */ + new_mp->am_path = str3cat(new_mp->am_path, + (mf->mf_fsflags & FS_DIRECT) + ? "" + : mp->am_path, + *fname == '/' ? "" : "/", fname); + dlog("setting path to %s", new_mp->am_path); + } + + return new_mp; +} + /* * Allocate a new mount slot and create * a new node. @@ -154,7 +248,7 @@ exported_ap_alloc(void) */ mpp = exported_ap + first_free_map; mp = *mpp = ALLOC(struct am_node); - memset((char *) mp, 0, sizeof(*mp)); + memset((char *) mp, 0, sizeof(struct am_node)); mp->am_mapno = first_free_map++; @@ -199,8 +293,9 @@ exported_ap_free(am_node *mp) first_free_map = mp->am_mapno; /* - * Free the mount node + * Free the mount node, and zero out it's internal struct data. */ + memset((char *) mp, 0, sizeof(am_node)); XFREE(mp); } @@ -229,6 +324,10 @@ insert_am(am_node *mp, am_node *p_mp) if (mp->am_osib) mp->am_osib->am_ysib = mp; p_mp->am_child = mp; +#ifdef HAVE_FS_AUTOFS + if (p_mp->am_mnt->mf_flags & MFF_IS_AUTOFS) + mp->am_flags |= AMF_AUTOFS; +#endif /* HAVE_FS_AUTOFS */ } @@ -268,27 +367,26 @@ void new_ttl(am_node *mp) { mp->am_timeo_w = 0; - mp->am_ttl = clocktime(); - mp->am_fattr.na_atime.nt_seconds = mp->am_ttl; + mp->am_ttl = clocktime(&mp->am_fattr.na_atime); mp->am_ttl += mp->am_timeo; /* sun's -tl option */ } void -mk_fattr(am_node *mp, nfsftype vntype) +mk_fattr(nfsfattr *fattr, nfsftype vntype) { switch (vntype) { case NFDIR: - mp->am_fattr.na_type = NFDIR; - mp->am_fattr.na_mode = NFSMODE_DIR | 0555; - mp->am_fattr.na_nlink = 2; - mp->am_fattr.na_size = 512; + fattr->na_type = NFDIR; + fattr->na_mode = NFSMODE_DIR | 0555; + fattr->na_nlink = 2; + fattr->na_size = 512; break; case NFLNK: - mp->am_fattr.na_type = NFLNK; - mp->am_fattr.na_mode = NFSMODE_LNK | 0777; - mp->am_fattr.na_nlink = 1; - mp->am_fattr.na_size = 0; + fattr->na_type = NFLNK; + fattr->na_mode = NFSMODE_LNK | 0777; + fattr->na_nlink = 1; + fattr->na_size = 0; break; default: plog(XLOG_FATAL, "Unknown fattr type %d - ignored", vntype); @@ -308,24 +406,30 @@ init_map(am_node *mp, char *dir) { /* * mp->am_mapno is initialized by exported_ap_alloc - * other fields don't need to be initialized. + * other fields don't need to be set to zero. */ mp->am_mnt = new_mntfs(); + mp->am_mfarray = 0; mp->am_name = strdup(dir); mp->am_path = strdup(dir); mp->am_gen = new_gen(); +#ifdef HAVE_FS_AUTOFS + mp->am_autofs_fh = 0; +#endif /* HAVE_FS_AUTOFS */ mp->am_timeo = gopt.am_timeo; mp->am_attr.ns_status = NFS_OK; mp->am_fattr = gen_fattr; mp->am_fattr.na_fsid = 42; mp->am_fattr.na_fileid = mp->am_gen; - mp->am_fattr.na_atime.nt_seconds = clocktime(); - mp->am_fattr.na_atime.nt_useconds = 0; + clocktime(&mp->am_fattr.na_atime); + /* next line copies a "struct nfstime" among several fields */ mp->am_fattr.na_mtime = mp->am_fattr.na_ctime = mp->am_fattr.na_atime; new_ttl(mp); mp->am_stats.s_mtime = mp->am_fattr.na_atime.nt_seconds; + mp->am_dev = -1; + mp->am_rdev = -1; } @@ -336,7 +440,6 @@ init_map(am_node *mp, char *dir) void free_map(am_node *mp) { - remove_am(mp); if (mp->am_link) @@ -353,188 +456,24 @@ free_map(am_node *mp) if (mp->am_mnt) free_mntfs(mp->am_mnt); - exported_ap_free(mp); -} - - -/* - * Convert from file handle to automount node. - */ -am_node * -fh_to_mp3(am_nfs_fh *fhp, int *rp, int c_or_d) -{ - struct am_fh *fp = (struct am_fh *) fhp; - am_node *ap = 0; - - /* - * Check process id matches - * If it doesn't then it is probably - * from an old kernel cached filehandle - * which is now out of date. - */ - if (fp->fhh_pid != am_mypid) - goto drop; - - /* - * Make sure the index is valid before - * exported_ap is referenced. - */ - if (fp->fhh_id < 0 || fp->fhh_id >= exported_ap_size) - goto drop; - - /* - * Get hold of the supposed mount node - */ - ap = exported_ap[fp->fhh_id]; - - /* - * If it exists then maybe... - */ - if (ap) { - /* - * Check the generation number in the node - * matches the one from the kernel. If not - * then the old node has been timed out and - * a new one allocated. - */ - if (ap->am_gen != fp->fhh_gen) { - ap = 0; - goto drop; - } - /* - * If the node is hung then locate a new node - * for it. This implements the replicated filesystem - * retries. - */ - if (ap->am_mnt && FSRV_ISDOWN(ap->am_mnt->mf_server) && ap->am_parent) { - int error; - am_node *orig_ap = ap; - -#ifdef DEBUG - dlog("fh_to_mp3: %s (%s) is hung:- call lookup", - orig_ap->am_path, orig_ap->am_mnt->mf_info); -#endif /* DEBUG */ - - /* - * Update modify time of parent node. - * With any luck the kernel will re-stat - * the child node and get new information. - */ - orig_ap->am_fattr.na_mtime.nt_seconds = clocktime(); - - /* - * Call the parent's lookup routine for an object - * with the same name. This may return -1 in error - * if a mount is in progress. In any case, if no - * mount node is returned the error code is propagated - * to the caller. - */ - if (c_or_d == VLOOK_CREATE) { - ap = (*orig_ap->am_parent->am_mnt->mf_ops->lookuppn) - (orig_ap->am_parent, orig_ap->am_name, &error, c_or_d); - } else { - ap = 0; - error = ESTALE; - } - if (ap == 0) { - if (error < 0 && amd_state == Finishing) - error = ENOENT; - *rp = error; - return 0; - } - - /* - * Update last access to original node. This - * avoids timing it out and so sending ESTALE - * back to the kernel. - * XXX - Not sure we need this anymore (jsp, 90/10/6). - */ - new_ttl(orig_ap); - - } - - /* - * Disallow references to objects being unmounted, unless - * they are automount points. - */ - if (ap->am_mnt && (ap->am_mnt->mf_flags & MFF_UNMOUNTING) && - !(ap->am_flags & AMF_ROOT)) { - if (amd_state == Finishing) - *rp = ENOENT; - else - *rp = -1; - return 0; - } - new_ttl(ap); - } - -drop: - if (!ap || !ap->am_mnt) { - /* - * If we are shutting down then it is likely - * that this node has disappeared because of - * a fast timeout. To avoid things thrashing - * just pretend it doesn't exist at all. If - * ESTALE is returned, some NFS clients just - * keep retrying (stupid or what - if it's - * stale now, what's it going to be in 5 minutes?) - */ - if (amd_state == Finishing) - *rp = ENOENT; - else - *rp = ESTALE; - amd_stats.d_stale++; + if (mp->am_mfarray) { + mntfs **temp_mf; + for (temp_mf = mp->am_mfarray; *temp_mf; temp_mf++) + free_mntfs(*temp_mf); + XFREE(mp->am_mfarray); } - return ap; -} - - -am_node * -fh_to_mp(am_nfs_fh *fhp) -{ - int dummy; - - return fh_to_mp2(fhp, &dummy); -} - - -/* - * Convert from automount node to file handle. - */ -void -mp_to_fh(am_node *mp, am_nfs_fh *fhp) -{ - struct am_fh *fp = (struct am_fh *) fhp; - - memset((char *) fhp, 0, sizeof(am_nfs_fh)); - - /* - * Take the process id - */ - fp->fhh_pid = am_mypid; - - /* - * ... the map number - */ - fp->fhh_id = mp->am_mapno; +#ifdef HAVE_FS_AUTOFS + if (mp->am_autofs_fh) + autofs_release_fh(mp); +#endif /* HAVE_FS_AUTOFS */ - /* - * ... and the generation number - */ - fp->fhh_gen = mp->am_gen; - - /* - * ... to make a "unique" triple that will never - * be reallocated except across reboots (which doesn't matter) - * or if we are unlucky enough to be given the same - * pid as a previous amd (very unlikely). - */ + exported_ap_free(mp); } -am_node * -find_ap2(char *dir, am_node *mp) +static am_node * +find_ap_recursive(char *dir, am_node *mp) { if (mp) { am_node *mp2; @@ -545,10 +484,10 @@ find_ap2(char *dir, am_node *mp) STREQ(mp->am_mnt->mf_mount, dir)) return mp; - mp2 = find_ap2(dir, mp->am_osib); + mp2 = find_ap_recursive(dir, mp->am_osib); if (mp2) return mp2; - return find_ap2(dir, mp->am_child); + return find_ap_recursive(dir, mp->am_child); } return 0; @@ -567,7 +506,7 @@ find_ap(char *dir) for (i = last_used_map; i >= 0; --i) { am_node *mp = exported_ap[i]; if (mp && (mp->am_flags & AMF_ROOT)) { - mp = find_ap2(dir, exported_ap[i]); + mp = find_ap_recursive(dir, exported_ap[i]); if (mp) { return mp; } @@ -603,22 +542,12 @@ find_mf(mntfs *mf) * the filehandles of the initial automount points. */ am_nfs_fh * -root_fh(char *dir) +get_root_nfs_fh(char *dir) { static am_nfs_fh nfh; - am_node *mp = root_ap(dir, TRUE); + am_node *mp = get_root_ap(dir); if (mp) { mp_to_fh(mp, &nfh); - /* - * Patch up PID to match main server... - */ - if (!foreground) { - long pid = getppid(); - ((struct am_fh *) &nfh)->fhh_pid = pid; -#ifdef DEBUG - dlog("root_fh substitutes pid %ld", (long) pid); -#endif /* DEBUG */ - } return &nfh; } @@ -631,8 +560,8 @@ root_fh(char *dir) } -am_node * -root_ap(char *dir, int path) +static am_node * +get_root_ap(char *dir) { am_node *mp = find_ap(dir); @@ -657,7 +586,7 @@ map_flush_srvr(fserver *fs) am_node *mp = exported_ap[i]; if (mp && mp->am_mnt && mp->am_mnt->mf_server == fs) { plog(XLOG_INFO, "Flushed %s; dependent on %s", mp->am_path, fs->fs_host); - mp->am_ttl = clocktime(); + mp->am_ttl = clocktime(NULL); done = 1; } } @@ -673,11 +602,23 @@ map_flush_srvr(fserver *fs) * automount node to be automounted. */ int -mount_auto_node(char *dir, voidp arg) +mount_auto_node(char *dir, opaque_t arg) { int error = 0; + am_node *mp = (am_node *) arg; + am_node *new_mp; + + new_mp = mp->am_mnt->mf_ops->lookup_child(mp, dir, &error, VLOOK_CREATE); + if (new_mp && error < 0) { + /* + * We can't allow the fileid of the root node to change. + * Should be ok to force it to 1, always. + */ + new_mp->am_gen = new_mp->am_fattr.na_fileid = 1; + + new_mp = mp->am_mnt->mf_ops->mount_child(new_mp, &error); + } - (void) amfs_auto_ops.lookuppn((am_node *) arg, dir, &error, VLOOK_CREATE); if (error > 0) { errno = error; /* XXX */ plog(XLOG_ERROR, "Could not mount %s: %m", dir); @@ -696,7 +637,7 @@ mount_exported(void) /* * Iterate over all the nodes to be started */ - return root_keyiter((void (*)P((char *, voidp))) mount_auto_node, root_node); + return root_keyiter(mount_auto_node, root_node); } @@ -735,7 +676,7 @@ make_root_node(void) /* * Mount the root */ - root_mnt->mf_error = (*root_mnt->mf_ops->mount_fs) (root_node); + root_mnt->mf_error = root_mnt->mf_ops->mount_fs(root_node, root_mnt); } @@ -750,143 +691,136 @@ umount_exported(void) for (i = last_used_map; i >= 0; --i) { am_node *mp = exported_ap[i]; + mntfs *mf; - if (mp) { - mntfs *mf = mp->am_mnt; - if (mf->mf_flags & MFF_UNMOUNTING) { - /* - * If this node is being unmounted then just ignore it. However, - * this could prevent amd from finishing if the unmount gets blocked - * since the am_node will never be free'd. am_unmounted needs - * telling about this possibility. - XXX - */ - continue; - } + if (!mp) + continue; - if (mf && !(mf->mf_ops->fs_flags & FS_DIRECTORY)) { - /* - * When shutting down this had better - * look like a directory, otherwise it - * can't be unmounted! - */ - mk_fattr(mp, NFDIR); - } + mf = mp->am_mnt; + if (mf->mf_flags & MFF_UNMOUNTING) { + /* + * If this node is being unmounted then just ignore it. However, + * this could prevent amd from finishing if the unmount gets blocked + * since the am_node will never be free'd. am_unmounted needs + * telling about this possibility. - XXX + */ + continue; + } - if ((--immediate_abort < 0 && - !(mp->am_flags & AMF_ROOT) && mp->am_parent) || - (mf->mf_flags & MFF_RESTART)) { + if (!(mf->mf_fsflags & FS_DIRECTORY)) + /* + * When shutting down this had better + * look like a directory, otherwise it + * can't be unmounted! + */ + mk_fattr(&mp->am_fattr, NFDIR); - /* - * Just throw this node away without bothering to unmount it. If - * the server is not known to be up then don't discard the mounted - * on directory or Amd might hang... - */ - if (mf->mf_server && - (mf->mf_server->fs_flags & (FSF_DOWN | FSF_VALID)) != FSF_VALID) - mf->mf_flags &= ~MFF_MKMNT; - if (gopt.flags & CFM_UNMOUNT_ON_EXIT) { - plog(XLOG_INFO, "on-exit attempt to unmount %s", mf->mf_mount); - unmount_node(mp); - } - am_unmounted(mp); + if ((--immediate_abort < 0 && + !(mp->am_flags & AMF_ROOT) && mp->am_parent) || + (mf->mf_flags & MFF_RESTART)) { - } else { + /* + * Just throw this node away without bothering to unmount it. If + * the server is not known to be up then don't discard the mounted + * on directory or Amd might hang... + */ + if (mf->mf_server && + (mf->mf_server->fs_flags & (FSF_DOWN | FSF_VALID)) != FSF_VALID) + mf->mf_flags &= ~MFF_MKMNT; + if (gopt.flags & CFM_UNMOUNT_ON_EXIT || mp->am_flags & AMF_AUTOFS) { + plog(XLOG_INFO, "on-exit attempt to unmount %s", mf->mf_mount); /* - * Any other node gets forcibly timed out. + * use unmount_mp, not unmount_node, so that unmounts be + * backgrounded as needed. */ - mp->am_flags &= ~AMF_NOTIMEOUT; - mp->am_mnt->mf_flags &= ~MFF_RSTKEEP; - mp->am_ttl = 0; - mp->am_timeo = 1; - mp->am_timeo_w = 0; + unmount_mp((opaque_t) mp); + } else { + am_unmounted(mp); } + exported_ap[i] = 0; + } else { + /* + * Any other node gets forcibly timed out. + */ + mp->am_flags &= ~AMF_NOTIMEOUT; + mp->am_mnt->mf_flags &= ~MFF_RSTKEEP; + mp->am_ttl = 0; + mp->am_timeo = 1; + mp->am_timeo_w = 0; } } } +/* + * Try to mount a file system. Can be called directly or in a sub-process by run_task. + * + * Warning: this function might be running in a child process context. + * Don't expect any changes made here to survive in the parent amd process. + */ +int +mount_node(opaque_t arg) +{ + am_node *mp = (am_node *) arg; + mntfs *mf = mp->am_mnt; + int error = 0; + +#ifdef HAVE_FS_AUTOFS + if (mp->am_flags & AMF_AUTOFS) + error = autofs_mount_fs(mp, mf); + else +#endif /* HAVE_FS_AUTOFS */ + if (!(mf->mf_flags & MFF_MOUNTED)) + error = mf->mf_ops->mount_fs(mp, mf); + + if (error > 0) + dlog("mount_node: call to mf_ops->mount_fs(%s) failed: %s", + mp->am_path, strerror(error)); + return error; +} + + static int -unmount_node(am_node *mp) +unmount_node(opaque_t arg) { + am_node *mp = (am_node *) arg; mntfs *mf = mp->am_mnt; - int error; + int error = 0; - if ((mf->mf_flags & MFF_ERROR) || mf->mf_refc > 1) { + if (mf->mf_flags & MFF_ERROR) { /* * Just unlink */ -#ifdef DEBUG - if (mf->mf_flags & MFF_ERROR) - dlog("No-op unmount of error node %s", mf->mf_info); -#endif /* DEBUG */ - error = 0; + dlog("No-op unmount of error node %s", mf->mf_info); } else { -#ifdef DEBUG - dlog("Unmounting %s (%s)", mf->mf_mount, mf->mf_info); -#endif /* DEBUG */ - error = (*mf->mf_ops->umount_fs) (mp); + dlog("Unmounting <%s> <%s> (%s) flags %x", + mp->am_path, mf->mf_mount, mf->mf_info, mf->mf_flags); +#ifdef HAVE_FS_AUTOFS + if (mp->am_flags & AMF_AUTOFS) + error = autofs_umount_fs(mp, mf); + else +#endif /* HAVE_FS_AUTOFS */ + if (mf->mf_refc == 1) + error = mf->mf_ops->umount_fs(mp, mf); } + /* do this again, it might have changed */ + mf = mp->am_mnt; if (error) { errno = error; /* XXX */ -#ifdef DEBUG dlog("%s: unmount: %m", mf->mf_mount); -#endif /* DEBUG */ } return error; } -static int -unmount_node_wrap(voidp vp) -{ - return unmount_node((am_node *) vp); - - /* - * Below is the comment left from the old code - * that was dependent on the macro FLUSH_KERNEL_NAME_CACHE - */ - /* - * This code should just say: - * return unmount_node((am_node *) vp); - * - * However... - * The kernel keeps a cached copy of filehandles, - * and doesn't ever uncache them (apparently). So - * when Amd times out a node the kernel will have a - * stale filehandle. When the kernel next uses the - * filehandle it gets ESTALE. - * - * The workaround: - * Arrange that when a node is removed an unlink or - * rmdir is done on that path so that the kernel - * cache is done. Yes - yuck. - * - * This can all be removed (and the background - * unmount flag in amfs_link_ops) if/when the kernel does - * something smarter. - * - * If the unlink or rmdir failed then just log a warning, - * don't fail the unmount. This can occur if the kernel - * client code decides that the object is still referenced - * and should be renamed rather than discarded. - * - * There is still a race condition here... - * if another process is trying to access the same - * filesystem at the time we get here, then - * it will block, since the MFF_UNMOUNTING flag will - * be set. That may, or may not, cause the entire - * system to deadlock. Hmmm... - */ -} - - static void -free_map_if_success(int rc, int term, voidp closure) +free_map_if_success(int rc, int term, opaque_t arg) { - am_node *mp = (am_node *) closure; + am_node *mp = (am_node *) arg; mntfs *mf = mp->am_mnt; + wchan_t wchan = get_mntfs_wchan(mf); /* * Not unmounting any more @@ -912,14 +846,22 @@ free_map_if_success(int rc, int term, voidp closure) am_unmounted(mp); } #endif /* DEBUG */ +#ifdef HAVE_FS_AUTOFS + if (mp->am_flags & AMF_AUTOFS) + autofs_umount_failed(mp); +#endif /* HAVE_FS_AUTOFS */ amd_stats.d_uerr++; } else if (rc) { - if (mf->mf_ops == &amfs_program_ops || rc == EBUSY) { + if (mf->mf_ops == &amfs_program_ops || rc == EBUSY) plog(XLOG_STATS, "\"%s\" on %s still active", mp->am_path, mf->mf_mount); - } else { - errno = rc; /* XXX */ - plog(XLOG_ERROR, "%s: unmount: %m", mp->am_path); - } + else + plog(XLOG_ERROR, "%s: unmount: %s", mp->am_path, strerror(rc)); +#ifdef HAVE_FS_AUTOFS + if (mf->mf_flags & MFF_IS_AUTOFS) + autofs_get_mp(mp); + if (mp->am_flags & AMF_AUTOFS) + autofs_umount_failed(mp); +#endif /* HAVE_FS_AUTOFS */ amd_stats.d_uerr++; } else { am_unmounted(mp); @@ -928,16 +870,21 @@ free_map_if_success(int rc, int term, voidp closure) /* * Wakeup anything waiting for this unmount */ - wakeup((voidp) mf); + wakeup(wchan); } -static int +int unmount_mp(am_node *mp) { int was_backgrounded = 0; mntfs *mf = mp->am_mnt; +#ifdef notdef + plog(XLOG_INFO, "\"%s\" on %s timed out (flags 0x%x)", + mp->am_path, mp->am_mnt->mf_mount, (int) mf->mf_flags); +#endif /* notdef */ + #ifndef MNT2_NFS_OPT_SYMTTL /* * This code is needed to defeat Solaris 2.4's (and newer) symlink @@ -946,56 +893,48 @@ unmount_mp(am_node *mp) * symlink-cache at mount time (such as Irix 5.x and 6.x). -Erez. * * Additionally, Linux currently ignores the nt_useconds field, - * so we must update the nt_seconds field every time. + * so we must update the nt_seconds field every time if clocktime(NULL) + * didn't return a new number of seconds. */ - if (mp->am_parent) + if (mp->am_parent) { + time_t last = mp->am_parent->am_attr.ns_u.ns_attr_u.na_mtime.nt_seconds; + clocktime(&mp->am_parent->am_attr.ns_u.ns_attr_u.na_mtime); /* defensive programming... can't we assert the above condition? */ - mp->am_parent->am_attr.ns_u.ns_attr_u.na_mtime.nt_seconds++; + if (last == (time_t) mp->am_parent->am_attr.ns_u.ns_attr_u.na_mtime.nt_seconds) + mp->am_parent->am_attr.ns_u.ns_attr_u.na_mtime.nt_seconds++; + } #endif /* not MNT2_NFS_OPT_SYMTTL */ -#ifdef notdef - plog(XLOG_INFO, "\"%s\" on %s timed out", mp->am_path, mp->am_mnt->mf_mount); -#endif /* notdef */ + if (mf->mf_refc == 1 && !FSRV_ISUP(mf->mf_server)) { + /* + * Don't try to unmount from a server that is known to be down + */ + if (!(mf->mf_flags & MFF_LOGDOWN)) { + /* Only log this once, otherwise gets a bit boring */ + plog(XLOG_STATS, "file server %s is down - timeout of \"%s\" ignored", mf->mf_server->fs_host, mp->am_path); + mf->mf_flags |= MFF_LOGDOWN; + } + return 0; + } + + dlog("\"%s\" on %s timed out", mp->am_path, mp->am_mnt->mf_mount); + mf->mf_flags |= MFF_UNMOUNTING; - if ((mf->mf_ops->fs_flags & FS_UBACKGROUND) && +#ifdef HAVE_FS_AUTOFS + if (mf->mf_flags & MFF_IS_AUTOFS) + autofs_release_mp(mp); +#endif /* HAVE_FS_AUTOFS */ + + if ((mf->mf_fsflags & FS_UBACKGROUND) && (mf->mf_flags & MFF_MOUNTED)) { - if (mf->mf_refc == 1 && !FSRV_ISUP(mf->mf_server)) { - /* - * Don't try to unmount from a server that is known to be down - */ - if (!(mf->mf_flags & MFF_LOGDOWN)) { - /* Only log this once, otherwise gets a bit boring */ - plog(XLOG_STATS, "file server %s is down - timeout of \"%s\" ignored", mf->mf_server->fs_host, mp->am_path); - mf->mf_flags |= MFF_LOGDOWN; - } - } else { - /* Clear logdown flag - since the server must be up */ - mf->mf_flags &= ~MFF_LOGDOWN; -#ifdef DEBUG - dlog("\"%s\" on %s timed out", mp->am_path, mp->am_mnt->mf_mount); - /* dlog("Will background the unmount attempt"); */ -#endif /* DEBUG */ - /* - * Note that we are unmounting this node - */ - mf->mf_flags |= MFF_UNMOUNTING; - run_task(unmount_node_wrap, (voidp) mp, - free_map_if_success, (voidp) mp); - was_backgrounded = 1; -#ifdef DEBUG - dlog("unmount attempt backgrounded"); -#endif /* DEBUG */ - } + dlog("Trying unmount in background"); + run_task(unmount_node, (opaque_t) mp, + free_map_if_success, (opaque_t) mp); + was_backgrounded = 1; } else { -#ifdef DEBUG - dlog("\"%s\" on %s timed out", mp->am_path, mp->am_mnt->mf_mount); dlog("Trying unmount in foreground"); -#endif /* DEBUG */ - mf->mf_flags |= MFF_UNMOUNTING; - free_map_if_success(unmount_node(mp), 0, (voidp) mp); -#ifdef DEBUG + free_map_if_success(unmount_node((opaque_t) mp), 0, (opaque_t) mp); dlog("unmount attempt done"); -#endif /* DEBUG */ } return was_backgrounded; @@ -1003,25 +942,23 @@ unmount_mp(am_node *mp) void -timeout_mp(voidp v) +timeout_mp(opaque_t v) /* argument not used?! */ { int i; time_t t = NEVER; - time_t now = clocktime(); - int backoff = NumChild / 4; + time_t now = clocktime(NULL); + int backoff = NumChildren / 4; -#ifdef DEBUG dlog("Timing out automount points..."); -#endif /* DEBUG */ for (i = last_used_map; i >= 0; --i) { am_node *mp = exported_ap[i]; mntfs *mf; /* - * Just continue if nothing mounted, or can't be timed out. + * Just continue if nothing mounted */ - if (!mp || (mp->am_flags & AMF_NOTIMEOUT)) + if (!mp) continue; /* @@ -1031,6 +968,17 @@ timeout_mp(voidp v) if (!mf) continue; +#ifdef HAVE_FS_AUTOFS + if (mf->mf_flags & MFF_IS_AUTOFS && mp->am_autofs_ttl != NEVER) { + if (now >= mp->am_autofs_ttl) + autofs_timeout_mp(mp); + t = smallest_t(t, mp->am_autofs_ttl); + } +#endif /* HAVE_FS_AUTOFS */ + + if (mp->am_flags & AMF_NOTIMEOUT) + continue; + /* * Don't delete last reference to a restarted filesystem. */ @@ -1087,9 +1035,7 @@ timeout_mp(voidp v) } if (t == NEVER) { -#ifdef DEBUG dlog("No further timeouts"); -#endif /* DEBUG */ t = now + ONE_HOUR; } @@ -1108,9 +1054,7 @@ timeout_mp(voidp v) */ if ((int) amd_state >= (int) Finishing) t = now + 1; -#ifdef DEBUG dlog("Next mount timeout in %lds", (long) (t - now)); -#endif /* DEBUG */ timeout_mp_id = timeout(t - now, timeout_mp, 0); } diff --git a/contrib/amd/amd/mapc.c b/contrib/amd/amd/mapc.c index 591c4f3cd49f..d7efdbcfd217 100644 --- a/contrib/amd/amd/mapc.c +++ b/contrib/amd/amd/mapc.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: mapc.c,v 1.7.2.7 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/mapc.c * */ @@ -85,8 +84,6 @@ #define MREC_PART 1 #define MREC_NONE 0 -#define MAX_CHAIN 2048 - static struct opt_tab mapc_opt[] = { {"all", MAPC_ALL}, @@ -201,12 +198,17 @@ extern int ndbm_search(mnt_map *, char *, char *, char **, time_t *); extern int ndbm_mtime(mnt_map *, char *, time_t *); #endif /* HAVE_MAP_NDBM */ +/* EXECUTABLE MAPS */ +#ifdef HAVE_MAP_EXEC +extern int exec_init(mnt_map *, char *, time_t *); +extern int exec_search(mnt_map *, char *, char *, char **, time_t *); +#endif /* HAVE_MAP_EXEC */ + /* FILE MAPS */ #ifdef HAVE_MAP_FILE -extern int file_init(mnt_map *, char *, time_t *); +extern int file_init_or_mtime(mnt_map *, char *, time_t *); extern int file_reload(mnt_map *, char *, add_fn *); extern int file_search(mnt_map *, char *, char *, char **, time_t *); -extern int file_mtime(mnt_map *, char *, time_t *); #endif /* HAVE_MAP_FILE */ @@ -302,14 +304,25 @@ static map_type maptypes[] = #ifdef HAVE_MAP_FILE { "file", - file_init, + file_init_or_mtime, file_reload, NULL, /* isup function */ file_search, - file_mtime, + file_init_or_mtime, MAPC_ALL }, #endif /* HAVE_MAP_FILE */ +#ifdef HAVE_MAP_EXEC + { + "exec", + exec_init, + error_reload, + NULL, /* isup function */ + exec_search, + error_mtime, + MAPC_INC + }, +#endif /* HAVE_MAP_EXEC */ { "error", error_init, @@ -337,16 +350,27 @@ kvhash_of(char *key) void -mapc_showtypes(char *buf) +mapc_showtypes(char *buf, size_t l) { - map_type *mt; - char *sep = ""; + map_type *mt=NULL, *lastmt; + int linesize = 0, i; + i = sizeof(maptypes) / sizeof(maptypes[0]); + lastmt = maptypes + i; buf[0] = '\0'; - for (mt = maptypes; mt < maptypes + sizeof(maptypes) / sizeof(maptypes[0]); mt++) { - strcat(buf, sep); - strcat(buf, mt->name); - sep = ", "; + for (mt = maptypes; mt < lastmt; mt++) { + xstrlcat(buf, mt->name, l); + if (mt == (lastmt-1)) + break; /* if last one, don't do xstrlcat's that follows */ + linesize += strlen(mt->name); + if (--i > 0) { + xstrlcat(buf, ", ", l); + linesize += 2; + } + if (linesize > 54) { + linesize = 0; + xstrlcat(buf, "\n\t\t ", l); + } } } @@ -386,9 +410,7 @@ mapc_add_kv(mnt_map *m, char *key, char *val) regex_t re; #endif /* HAVE_REGEXEC */ -#ifdef DEBUG dlog("add_kv: %s -> %s", key, val); -#endif /* DEBUG */ #ifdef HAVE_REGEXEC if (MAPC_ISRE(m)) { @@ -398,7 +420,7 @@ mapc_add_kv(mnt_map *m, char *key, char *val) /* * Make sure the string is bound to the start and end */ - sprintf(pattern, "^%s$", key); + xsnprintf(pattern, sizeof(pattern), "^%s$", key); retval = regcomp(&re, pattern, REG_ICASE); if (retval != 0) { char errstr[256]; @@ -492,11 +514,12 @@ mapc_find_wildcard(mnt_map *m) * Do a map reload. * Attempt to reload without losing current data by switching the hashes * round. + * If reloading was needed and succeeded, return 1; else return 0. */ -static void +static int mapc_reload_map(mnt_map *m) { - int error; + int error, ret = 0; kv *maphash[NKVHASH], *tmphash[NKVHASH]; time_t t; @@ -512,11 +535,9 @@ mapc_reload_map(mnt_map *m) if (m->reloads != 0 && do_mapc_reload != 0) { if (t <= m->modify) { plog(XLOG_INFO, "reload of map %s is not needed (in sync)", m->map_name); -#ifdef DEBUG dlog("map %s last load time is %d, last modify time is %d", m->map_name, (int) m->modify, (int) t); -#endif /* DEBUG */ - return; + return ret; } } @@ -524,9 +545,7 @@ mapc_reload_map(mnt_map *m) memcpy((voidp) maphash, (voidp) m->kvhash, sizeof(m->kvhash)); memset((voidp) m->kvhash, 0, sizeof(m->kvhash)); -#ifdef DEBUG dlog("calling map reload on %s", m->map_name); -#endif /* DEBUG */ error = (*m->reload) (m, m->map_name, mapc_add_kv); if (error) { if (m->reloads == 0) @@ -547,15 +566,15 @@ mapc_reload_map(mnt_map *m) mapc_clear(m); memcpy((voidp) m->kvhash, (voidp) tmphash, sizeof(m->kvhash)); m->modify = t; + ret = 1; } m->wildcard = 0; -#ifdef DEBUG dlog("calling mapc_search for wildcard"); -#endif /* DEBUG */ error = mapc_search(m, wildcard, &m->wildcard); if (error) m->wildcard = 0; + return ret; } @@ -567,7 +586,7 @@ mapc_create(char *map, char *opt, const char *type) { mnt_map *m = ALLOC(struct mnt_map); map_type *mt; - time_t modify; + time_t modify = 0; int alloc = 0; cmdoption(opt, mapc_opt, &alloc); @@ -603,9 +622,7 @@ mapc_create(char *map, char *opt, const char *type) for (mt = maptypes; mt < maptypes + sizeof(maptypes) / sizeof(maptypes[0]); mt++) { -#ifdef DEBUG dlog("trying to initialize map %s of type %s ...", map, mt->name); -#endif /* DEBUG */ if ((*mt->init) (m, map, &modify) == 0) { break; } @@ -652,9 +669,7 @@ mapc_create(char *map, char *opt, const char *type) #endif /* HAVE_REGEXEC */ } -#ifdef DEBUG dlog("Map for %s coming from maptype %s", map, mt->name); -#endif /* DEBUG */ m->alloc = alloc; m->reload = mt->reload; @@ -667,6 +682,8 @@ mapc_create(char *map, char *opt, const char *type) m->refc = 1; m->wildcard = 0; m->reloads = 0; + /* Unfortunately with current code structure, this cannot be initialized here */ + m->cfm = NULL; /* * synchronize cache with reality @@ -732,7 +749,7 @@ mapc_find(char *map, char *opt, const char *maptype) * add it to the list of maps */ ITER(m, mnt_map, &map_list_head) - if (STREQ(m->map_name, map)) + if (STREQ(m->map_name, map)) return mapc_dup(m); m = mapc_create(map, opt, maptype); ins_que(&m->hdr, &map_list_head); @@ -745,9 +762,9 @@ mapc_find(char *map, char *opt, const char *maptype) * Free a map. */ void -mapc_free(voidp v) +mapc_free(opaque_t arg) { - mnt_map *m = v; + mnt_map *m = (mnt_map *) arg; /* * Decrement the reference count. @@ -883,12 +900,15 @@ mapc_meta_search(mnt_map *m, char *key, char **pval, int recurse) * For example: * "src/gnu/gcc" -> "src / gnu / *" -> "src / *" */ - strcpy(wildname, key); + xstrlcpy(wildname, key, sizeof(wildname)); while (error && (subp = strrchr(wildname, '/'))) { - strcpy(subp, "/*"); -#ifdef DEBUG + /* + * sizeof space left in subp is sizeof wildname minus what's left + * after the strchr above returned a pointer inside wildname into + * subp. + */ + xstrlcpy(subp, "/*", sizeof(wildname) - (subp - wildname)); dlog("mapc recurses on %s", wildname); -#endif /* DEBUG */ error = mapc_meta_search(m, wildname, pval, MREC_PART); if (error) *subp = 0; @@ -917,25 +937,42 @@ mapc_search(mnt_map *m, char *key, char **pval) static void mapc_sync(mnt_map *m) { - if (m->alloc != MAPC_ROOT) { + int need_mtime_update = 0; - /* do not clear map if map service is down */ - if (m->isup) { - if (!((*m->isup)(m, m->map_name))) { - plog(XLOG_ERROR, "mapc_sync: map %s is down: not clearing map", m->map_name); - return; - } + if (m->alloc == MAPC_ROOT) + return; /* nothing to do */ + + /* do not clear map if map service is down */ + if (m->isup) { + if (!((*m->isup)(m, m->map_name))) { + plog(XLOG_ERROR, "mapc_sync: map %s is down: not clearing map", m->map_name); + return; } + } + + if (m->alloc >= MAPC_ALL) { + /* mapc_reload_map() always works */ + need_mtime_update = mapc_reload_map(m); + } else { + mapc_clear(m); + /* + * Attempt to find the wildcard entry + */ + mapc_find_wildcard(m); + need_mtime_update = 1; /* because mapc_clear always works */ + } - if (m->alloc >= MAPC_ALL) { - /* mapc_reload_map() always works */ - mapc_reload_map(m); + /* + * To be safe, update the mtime of the mnt_map's own node, so that the + * kernel will flush all of its cached entries. + */ + if (need_mtime_update && m->cfm) { + am_node *mp = find_ap(m->cfm->cfm_dir); + if (mp) { + clocktime(&mp->am_fattr.na_mtime); } else { - mapc_clear(m); - /* - * Attempt to find the wildcard entry - */ - mapc_find_wildcard(m); + plog(XLOG_ERROR, "cannot find map %s to update its mtime", + m->cfm->cfm_dir); } } } @@ -972,7 +1009,7 @@ mapc_reload(void) static int root_init(mnt_map *m, char *map, time_t *tp) { - *tp = clocktime(); + *tp = clocktime(NULL); return STREQ(map, ROOT_MAP) ? 0 : ENOENT; } @@ -1007,36 +1044,39 @@ root_newmap(const char *dir, const char *opts, const char *map, const cf_map_t * if (cfm) { if (map) { - sprintf(str, "cache:=mapdefault;type:=toplvl;fs:=\"%s\"", - get_full_path(map, cfm->cfm_search_path, cfm->cfm_type)); + xsnprintf(str, sizeof(str), + "cache:=mapdefault;type:=toplvl;mount_type:=%s;fs:=\"%s\"", + cfm->cfm_flags & CFM_MOUNT_TYPE_AUTOFS ? "autofs" : "nfs", + get_full_path(map, cfm->cfm_search_path, cfm->cfm_type)); if (opts && opts[0] != '\0') { - strcat(str, ";"); - strcat(str, opts); + xstrlcat(str, ";", sizeof(str)); + xstrlcat(str, opts, sizeof(str)); } if (cfm->cfm_flags & CFM_BROWSABLE_DIRS_FULL) - strcat(str, ";opts:=rw,fullybrowsable"); + xstrlcat(str, ";opts:=rw,fullybrowsable", sizeof(str)); if (cfm->cfm_flags & CFM_BROWSABLE_DIRS) - strcat(str, ";opts:=rw,browsable"); + xstrlcat(str, ";opts:=rw,browsable", sizeof(str)); if (cfm->cfm_type) { - strcat(str, ";maptype:="); - strcat(str, cfm->cfm_type); + xstrlcat(str, ";maptype:=", sizeof(str)); + xstrlcat(str, cfm->cfm_type, sizeof(str)); } } else { - strcpy(str, opts); + xstrlcpy(str, opts, sizeof(str)); } } else { if (map) - sprintf(str, "cache:=mapdefault;type:=toplvl;fs:=\"%s\";%s", - map, opts ? opts : ""); + xsnprintf(str, sizeof(str), + "cache:=mapdefault;type:=toplvl;fs:=\"%s\";%s", + map, opts ? opts : ""); else - strcpy(str, opts); + xstrlcpy(str, opts, sizeof(str)); } mapc_repl_kv(root_map, strdup((char *)dir), strdup(str)); } int -mapc_keyiter(mnt_map *m, void (*fn) (char *, voidp), voidp arg) +mapc_keyiter(mnt_map *m, key_fun *fn, opaque_t arg) { int i; int c = 0; @@ -1056,10 +1096,10 @@ mapc_keyiter(mnt_map *m, void (*fn) (char *, voidp), voidp arg) /* * Iterate on the root map and call (*fn)() on the key of all the nodes. - * Finally throw away the root map. + * Returns the number of entries in the root map. */ int -root_keyiter(void (*fn)(char *, voidp), voidp arg) +root_keyiter(key_fun *fn, opaque_t arg) { if (root_map) { int c = mapc_keyiter(root_map, fn, arg); @@ -1071,132 +1111,6 @@ root_keyiter(void (*fn)(char *, voidp), voidp arg) /* - * Was: NEW_TOPLVL_READDIR - * Search a chain for an entry with some name. - * -Erez Zadok <ezk@cs.columbia.edu> - */ -static int -key_already_in_chain(char *keyname, const nfsentry *chain) -{ - const nfsentry *tmpchain = chain; - - while (tmpchain) { - if (keyname && tmpchain->ne_name && STREQ(keyname, tmpchain->ne_name)) - return 1; - tmpchain = tmpchain->ne_nextentry; - } - - return 0; -} - - -/* - * Create a chain of entries which are not linked. - * -Erez Zadok <ezk@cs.columbia.edu> - */ -nfsentry * -make_entry_chain(am_node *mp, const nfsentry *current_chain, int fully_browsable) -{ - static u_int last_cookie = (u_int) 2; /* monotonically increasing */ - static nfsentry chain[MAX_CHAIN]; - static int max_entries = MAX_CHAIN; - char *key; - int num_entries = 0, preflen = 0, i; - nfsentry *retval = (nfsentry *) NULL; - mntfs *mf; - mnt_map *mmp; - - if (!mp) { - plog(XLOG_DEBUG, "make_entry_chain: mp is (NULL)"); - return retval; - } - mf = mp->am_mnt; - if (!mf) { - plog(XLOG_DEBUG, "make_entry_chain: mp->am_mnt is (NULL)"); - return retval; - } - mmp = (mnt_map *) mf->mf_private; - if (!mmp) { - plog(XLOG_DEBUG, "make_entry_chain: mp->am_mnt->mf_private is (NULL)"); - return retval; - } - - if (mp->am_pref) - preflen = strlen(mp->am_pref); - - /* iterate over keys */ - for (i = 0; i < NKVHASH; i++) { - kv *k; - for (k = mmp->kvhash[i]; k ; k = k->next) { - - /* - * Skip unwanted entries which are either not real entries or - * very difficult to interpret (wildcards...) This test needs - * lots of improvement. Any takers? - */ - key = k->key; - if (!key) - continue; - - /* Skip '*' */ - if (!fully_browsable && strchr(key, '*')) - continue; - - /* - * If the map has a prefix-string then check if the key starts with - * this string, and if it does, skip over this prefix. If it has a - * prefix and it doesn't match the start of the key, skip it. - */ - if (preflen && (preflen <= (strlen(key)))) { - if (!NSTREQ(key, mp->am_pref, preflen)) - continue; - key += preflen; - } else if (preflen) { - continue; - } - - /* no more '/' are allowed, unless browsable_dirs=full was used */ - if (!fully_browsable && strchr(key, '/')) - continue; - - /* no duplicates allowed */ - if (key_already_in_chain(key, current_chain)) - continue; - - /* fill in a cell and link the entry */ - if (num_entries >= max_entries) { - /* out of space */ - plog(XLOG_DEBUG, "make_entry_chain: no more space in chain"); - if (num_entries > 0) { - chain[num_entries - 1].ne_nextentry = 0; - retval = &chain[0]; - } - return retval; - } - - /* we have space. put entry in next cell */ - ++last_cookie; - chain[num_entries].ne_fileid = (u_int) last_cookie; - *(u_int *) chain[num_entries].ne_cookie = (u_int) last_cookie; - chain[num_entries].ne_name = key; - if (num_entries < max_entries - 1) { /* link to next one */ - chain[num_entries].ne_nextentry = &chain[num_entries + 1]; - } - ++num_entries; - } /* end of "while (k)" */ - } /* end of "for (i ... NKVHASH ..." */ - - /* terminate chain */ - if (num_entries > 0) { - chain[num_entries - 1].ne_nextentry = 0; - retval = &chain[0]; - } - - return retval; -} - - -/* * Error map */ static int @@ -1260,15 +1174,15 @@ get_full_path(const char *map, const char *path, const char *type) return map; /* now break path into components, and search in each */ - strcpy(component, path); + xstrlcpy(component, path, sizeof(component)); str = strtok(component, ":"); do { - strcpy(full_path, str); + xstrlcpy(full_path, str, sizeof(full_path)); len = strlen(full_path); if (full_path[len - 1] != '/') /* add trailing "/" if needed */ - strcat(full_path, "/"); - strcat(full_path, map); + xstrlcat(full_path, "/", sizeof(full_path)); + xstrlcat(full_path, map, sizeof(full_path)); if (access(full_path, R_OK) == 0) return full_path; str = strtok(NULL, ":"); diff --git a/contrib/amd/amd/mntfs.c b/contrib/amd/amd/mntfs.c index 02bcae3aa1de..6021838425c0 100644 --- a/contrib/amd/amd/mntfs.c +++ b/contrib/amd/amd/mntfs.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: mntfs.c,v 1.5.2.5 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/mntfs.c * */ @@ -71,12 +70,14 @@ static void init_mntfs(mntfs *mf, am_ops *ops, am_opts *mo, char *mp, char *info, char *auto_opts, char *mopts, char *remopts) { mf->mf_ops = ops; + mf->mf_fsflags = ops->nfs_fs_flags; mf->mf_fo = mo; mf->mf_mount = strdup(mp); mf->mf_info = strdup(info); mf->mf_auto = strdup(auto_opts); mf->mf_mopts = strdup(mopts); mf->mf_remopts = strdup(remopts); + mf->mf_loopdev = NULL; mf->mf_refc = 1; mf->mf_flags = 0; mf->mf_error = -1; @@ -104,17 +105,25 @@ alloc_mntfs(am_ops *ops, am_opts *mo, char *mp, char *info, char *auto_opts, cha } +/* find a matching mntfs in our list */ mntfs * -find_mntfs(am_ops *ops, am_opts *mo, char *mp, char *info, char *auto_opts, char *mopts, char *remopts) +locate_mntfs(am_ops *ops, am_opts *mo, char *mp, char *info, char *auto_opts, char *mopts, char *remopts) { mntfs *mf; -#ifdef DEBUG - dlog("Locating mntfs reference to %s", mp); -#endif /* DEBUG */ + dlog("Locating mntfs reference to (%s,%s)", mp, info); ITER(mf, mntfs, &mfhead) { - if (STREQ(mf->mf_mount, mp)) { + /* + * For backwards compatibility purposes, we treat already-mounted + * filesystems differently and only require a match of their mount point, + * not of their server info. After all, there is little we can do if + * the user asks us to mount two different things onto the same mount: one + * will always cover the other one. + */ + if (STREQ(mf->mf_mount, mp) && + ((mf->mf_flags & MFF_MOUNTED && !(mf->mf_fsflags & FS_DIRECT)) + || (STREQ(mf->mf_info, info) && mf->mf_ops == ops))) { /* * Handle cases where error ops are involved */ @@ -125,35 +134,32 @@ find_mntfs(am_ops *ops, am_opts *mo, char *mp, char *info, char *auto_opts, char */ if (mf->mf_ops != &amfs_error_ops) continue; - else - return dup_mntfs(mf); - } else { /* ops != &amfs_error_ops */ - /* - * If the existing ops are amfs_error_ops - * then continue... - */ - if (mf->mf_ops == &amfs_error_ops) - continue; + return dup_mntfs(mf); } - if ((mf->mf_flags & MFF_RESTART) && amd_state == Run) { + dlog("mf->mf_flags = %#x", mf->mf_flags); + mf->mf_fo = mo; + if ((mf->mf_flags & MFF_RESTART) && amd_state < Finishing) { /* * Restart a previously mounted filesystem. */ - mntfs *mf2 = alloc_mntfs(&amfs_inherit_ops, mo, mp, info, auto_opts, mopts, remopts); -#ifdef DEBUG dlog("Restarting filesystem %s", mf->mf_mount); -#endif /* DEBUG */ /* - * Remember who we are restarting + * If we are restarting an amd internal filesystem, + * we need to initialize it a bit. + * + * We know it's internal because it is marked as toplvl. */ - mf2->mf_private = (voidp) dup_mntfs(mf); - mf2->mf_prfree = free_mntfs; - return mf2; + if (mf->mf_ops == &amfs_toplvl_ops) { + mf->mf_ops = ops; + mf->mf_info = strealloc(mf->mf_info, info); + ops->mounted(mf); /* XXX: not right, but will do for now */ + } + + return mf; } - mf->mf_fo = mo; if (!(mf->mf_flags & (MFF_MOUNTED | MFF_MOUNTING | MFF_UNMOUNTING))) { fserver *fs; mf->mf_flags &= ~MFF_ERROR; @@ -164,7 +170,7 @@ find_mntfs(am_ops *ops, am_opts *mo, char *mp, char *info, char *auto_opts, char mf->mf_info = strealloc(mf->mf_info, info); if (mf->mf_private && mf->mf_prfree) { - (*mf->mf_prfree) (mf->mf_private); + mf->mf_prfree(mf->mf_private); mf->mf_private = 0; } @@ -177,6 +183,18 @@ find_mntfs(am_ops *ops, am_opts *mo, char *mp, char *info, char *auto_opts, char } /* end of "if (STREQ(mf-> ..." */ } /* end of ITER */ + return 0; +} + + +/* find a matching mntfs in our list, create a new one if none is found */ +mntfs * +find_mntfs(am_ops *ops, am_opts *mo, char *mp, char *info, char *auto_opts, char *mopts, char *remopts) +{ + mntfs *mf = locate_mntfs(ops, mo, mp, info, auto_opts, mopts, remopts); + if (mf) + return mf; + return alloc_mntfs(ops, mo, mp, info, auto_opts, mopts, remopts); } @@ -189,7 +207,7 @@ new_mntfs(void) static void -uninit_mntfs(mntfs *mf, int rmd) +uninit_mntfs(mntfs *mf) { if (mf->mf_auto) XFREE(mf->mf_auto); @@ -202,12 +220,6 @@ uninit_mntfs(mntfs *mf, int rmd) if (mf->mf_private && mf->mf_prfree) (*mf->mf_prfree) (mf->mf_private); - /* - * Clean up any directories that were made - */ - if (rmd && (mf->mf_flags & MFF_MKMNT)) - rmdirs(mf->mf_mount); - /* free mf_mount _AFTER_ removing the directories */ if (mf->mf_mount) XFREE(mf->mf_mount); @@ -237,7 +249,7 @@ discard_mntfs(voidp v) /* * Free memory */ - uninit_mntfs(mf, TRUE); + uninit_mntfs(mf); XFREE(mf); --mntfs_allocated; @@ -260,17 +272,27 @@ flush_mntfs(void) void -free_mntfs(voidp v) +free_mntfs(opaque_t arg) { - mntfs *mf = v; + mntfs *mf = (mntfs *) arg; + + dlog("free_mntfs <%s> type %s mf_refc %d flags %x", + mf->mf_mount, mf->mf_ops->fs_type, mf->mf_refc, mf->mf_flags); /* * We shouldn't ever be called to free something that has * a non-positive refcount. Something is badly wrong if * we have been! Ignore the request for now... */ - if(mf->mf_refc <= 0) { - plog(XLOG_ERROR, "IGNORING free_mntfs for <%s>: refc %d, flags %x", + if (mf->mf_refc <= 0) { + plog(XLOG_ERROR, "IGNORING free_mntfs for <%s>: refc %d, flags %x (bug?)", + mf->mf_mount, mf->mf_refc, mf->mf_flags); + return; + } + + /* don't discard last reference of a restarted/kept mntfs */ + if (mf->mf_refc == 1 && mf->mf_flags & MFF_RSTKEEP) { + plog(XLOG_ERROR, "IGNORING free_mntfs for <%s>: refc %d, flags %x (restarted)", mf->mf_mount, mf->mf_refc, mf->mf_flags); return; } @@ -292,15 +314,12 @@ free_mntfs(voidp v) mf->mf_ops->fs_type, mf->mf_mount); } - if (mf->mf_ops->fs_flags & FS_DISCARD) { -#ifdef DEBUG + if (mf->mf_fsflags & FS_DISCARD) { dlog("Immediately discarding mntfs for %s", mf->mf_mount); -#endif /* DEBUG */ discard_mntfs(mf); } else { -#ifdef DEBUG if (mf->mf_flags & MFF_RESTART) { dlog("Discarding remount hook for %s", mf->mf_mount); } else { @@ -309,7 +328,6 @@ free_mntfs(voidp v) } if (mf->mf_flags & (MFF_MOUNTED | MFF_MOUNTING | MFF_UNMOUNTING)) dlog("mntfs reference for %s still active", mf->mf_mount); -#endif /* DEBUG */ mf->mf_cid = timeout(ALLOWED_MOUNT_TIME, discard_mntfs, (voidp) mf); } } @@ -322,7 +340,7 @@ realloc_mntfs(mntfs *mf, am_ops *ops, am_opts *mo, char *mp, char *info, char *a mntfs *mf2; if (mf->mf_refc == 1 && - mf->mf_ops == &amfs_inherit_ops && + mf->mf_flags & MFF_RESTART && STREQ(mf->mf_mount, mp)) { /* * If we are inheriting then just return @@ -344,23 +362,5 @@ realloc_mntfs(mntfs *mf, am_ops *ops, am_opts *mo, char *mp, char *info, char *a mf2 = find_mntfs(ops, mo, mp, info, auto_opts, mopts, remopts); free_mntfs(mf); -#if 0 - /* - * XXX: EZK IS THIS RIGHT??? - * The next "if" statement is what supposedly fixes bgmount() in - * that it will actually use the ops structure of the next mount - * entry, if the previous one failed. - */ - if (mf2 && - ops && - mf2->mf_ops != ops && - mf2->mf_ops != &amfs_inherit_ops && - mf2->mf_ops != &amfs_toplvl_ops && - mf2->mf_ops != &amfs_error_ops) { - plog(XLOG_WARNING, "realloc_mntfs: copy fallback ops \"%s\" over \"%s\"", - ops->fs_type, mf2->mf_ops->fs_type); - mf2->mf_ops = ops; - } -#endif return mf2; } diff --git a/contrib/amd/amd/nfs_prot_svc.c b/contrib/amd/amd/nfs_prot_svc.c index 39d1d4562eea..0dd6992cf9e7 100644 --- a/contrib/amd/amd/nfs_prot_svc.c +++ b/contrib/amd/amd/nfs_prot_svc.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: nfs_prot_svc.c,v 1.5.2.6 2004/01/21 04:04:58 ib42 Exp $ + * File: am-utils/amd/nfs_prot_svc.c * */ @@ -69,7 +68,7 @@ extern nfsreaddirres *nfsproc_readdir_2_svc(nfsreaddirargs *, struct svc_req *); extern nfsstatfsres *nfsproc_statfs_2_svc(am_nfs_fh *, struct svc_req *); /* global variables */ -SVCXPRT *nfs_program_2_transp; +SVCXPRT *current_transp; /* typedefs */ typedef char *(*nfssvcproc_t)(voidp, struct svc_req *); @@ -98,30 +97,60 @@ nfs_program_2(struct svc_req *rqstp, SVCXPRT *transp) char *result; xdrproc_t xdr_argument, xdr_result; nfssvcproc_t local; + +#ifdef HAVE_TRANSPORT_TYPE_TLI + /* + * On TLI systems we don't use an INET network type, but a "ticlts" (see + * /etc/netconfig and conf/transp_tli.c:create_nfs_service). This means + * that packets could only come from the loopback interface, and we don't + * need to check them and filter possibly spoofed packets. Therefore we + * only need to check if the UID caller is correct. + */ +# ifdef HAVE___RPC_GET_LOCAL_UID + uid_t u; + /* extern definition for an internal libnsl function */ + extern int __rpc_get_local_uid(SVCXPRT *transp, uid_t *uid); + if (__rpc_get_local_uid(transp, &u) >= 0 && u != 0) { + plog(XLOG_WARNING, "ignoring request from UID %ld, must be 0", (long) u); + return; + } +# else /* not HAVE___RPC_GET_LOCAL_UID */ + dlog("cannot verify local uid for rpc request"); +# endif /* HAVE___RPC_GET_LOCAL_UID */ +#else /* not HAVE_TRANPORT_TYPE_TLI */ struct sockaddr_in *sinp; char dq[20], dq2[28]; - sinp = amu_svc_getcaller(rqstp->rq_xprt); -#ifdef MNT2_NFS_OPT_RESVPORT +# ifdef MNT2_NFS_OPT_RESVPORT /* Verify that the request comes from a reserved port */ - if (ntohs(sinp->sin_port) >= IPPORT_RESERVED) && + if (sinp && + ntohs(sinp->sin_port) >= IPPORT_RESERVED && !(gopt.flags & CFM_NFS_INSECURE_PORT)) { plog(XLOG_WARNING, "ignoring request from %s:%u, port not reserved", - inet_dquad(dq, sinp->sin_addr.s_addr), + inet_dquad(dq, sizeof(dq), sinp->sin_addr.s_addr), ntohs(sinp->sin_port)); return; } -#endif /* MNT2_NFS_OPT_RESVPORT */ +# endif /* MNT2_NFS_OPT_RESVPORT */ /* if the address does not match, ignore the request */ - if (sinp->sin_addr.s_addr && sinp->sin_addr.s_addr != myipaddr.s_addr) { - plog(XLOG_WARNING, "ignoring request from %s:%u, expected %s", - inet_dquad(dq, sinp->sin_addr.s_addr), - ntohs(sinp->sin_port), - inet_dquad(dq2, myipaddr.s_addr)); - return; + if (sinp && (sinp->sin_addr.s_addr != myipaddr.s_addr)) { + if (gopt.flags & CFM_NFS_ANY_INTERFACE) { + if (!is_interface_local(sinp->sin_addr.s_addr)) { + plog(XLOG_WARNING, "ignoring request from %s:%u, not a local interface", + inet_dquad(dq, sizeof(dq), sinp->sin_addr.s_addr), + ntohs(sinp->sin_port)); + } + } else { + plog(XLOG_WARNING, "ignoring request from %s:%u, expected %s", + inet_dquad(dq, sizeof(dq), sinp->sin_addr.s_addr), + ntohs(sinp->sin_port), + inet_dquad(dq2, sizeof(dq2), myipaddr.s_addr)); + return; + } } +#endif /* not HAVE_TRANPORT_TYPE_TLI */ - nfs_program_2_transp = NULL; + current_transp = NULL; switch (rqstp->rq_proc) { @@ -158,7 +187,7 @@ nfs_program_2(struct svc_req *rqstp, SVCXPRT *transp) * be stored in the am_node structure and later used for * quick_reply(). */ - nfs_program_2_transp = transp; + current_transp = transp; break; case NFSPROC_READLINK: @@ -256,7 +285,7 @@ nfs_program_2(struct svc_req *rqstp, SVCXPRT *transp) } result = (*local) (&argument, rqstp); - nfs_program_2_transp = NULL; + current_transp = NULL; if (result != NULL && !svc_sendreply(transp, (XDRPROC_T_TYPE) xdr_result, diff --git a/contrib/amd/amd/nfs_start.c b/contrib/amd/amd/nfs_start.c index 1bf6df144e8a..f6aba94e2b6d 100644 --- a/contrib/amd/amd/nfs_start.c +++ b/contrib/amd/amd/nfs_start.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: nfs_start.c,v 1.5.2.7 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/nfs_start.c * */ @@ -52,8 +51,8 @@ # define SELECT_MAXWAIT 16 #endif /* not SELECT_MAXWAIT */ -SVCXPRT *nfsxprt; -u_short nfs_port; +SVCXPRT *nfsxprt = NULL; +u_short nfs_port = 0; #ifndef HAVE_SIGACTION # define MASKED_SIGS (sigmask(SIGINT)|sigmask(SIGTERM)|sigmask(SIGCHLD)|sigmask(SIGHUP)) @@ -92,7 +91,9 @@ checkup(void) } } -#endif /* DEBUG */ +#else /* not DEBUG */ +#define checkup() +#endif /* not DEBUG */ static int @@ -121,10 +122,6 @@ do_select(int smask, int fds, fd_set *fdp, struct timeval *tvp) } else { select_intr_valid = 1; /* - * Invalidate the current clock value - */ - clock_valid = 0; - /* * Allow interrupts. If a signal * occurs, then it will cause a longjmp * up above. @@ -151,9 +148,9 @@ do_select(int smask, int fds, fd_set *fdp, struct timeval *tvp) /* * Perhaps reload the cache? */ - if (do_mapc_reload < clocktime()) { + if (do_mapc_reload < clocktime(NULL)) { mapc_reload(); - do_mapc_reload = clocktime() + ONE_HOUR; + do_mapc_reload = clocktime(NULL) + gopt.map_reload_interval; } return nsel; } @@ -168,26 +165,17 @@ rpc_pending_now(void) { struct timeval tvv; int nsel; -#ifdef FD_SET fd_set readfds; FD_ZERO(&readfds); FD_SET(fwd_sock, &readfds); -#else /* not FD_SET */ - int readfds = (1 << fwd_sock); -#endif /* not FD_SET */ tvv.tv_sec = tvv.tv_usec = 0; nsel = select(FD_SETSIZE, &readfds, (fd_set *) 0, (fd_set *) 0, &tvv); if (nsel < 1) return (0); -#ifdef FD_SET if (FD_ISSET(fwd_sock, &readfds)) return (1); -#else /* not FD_SET */ - if (readfds & (1 << fwd_sock)) - return (1); -#endif /* not FD_SET */ return (0); } @@ -203,7 +191,7 @@ run_rpc(void) int smask = sigblock(MASKED_SIGS); #endif /* not HAVE_SIGACTION */ - next_softclock = clocktime(); + next_softclock = clocktime(NULL); amd_state = Run; @@ -216,31 +204,27 @@ run_rpc(void) struct timeval tvv; int nsel; time_t now; -#ifdef HAVE_SVC_GETREQSET fd_set readfds; +#ifdef HAVE_SVC_GETREQSET memmove(&readfds, &svc_fdset, sizeof(svc_fdset)); - FD_SET(fwd_sock, &readfds); #else /* not HAVE_SVC_GETREQSET */ -# ifdef FD_SET - fd_set readfds; FD_ZERO(&readfds); +# ifdef HAVE_FD_SET_FDS_BITS readfds.fds_bits[0] = svc_fds; - FD_SET(fwd_sock, &readfds); -# else /* not FD_SET */ - int readfds = svc_fds | (1 << fwd_sock); -# endif /* not FD_SET */ +# else /* not HAVE_FD_SET_FDS_BITS */ + readfds = svc_fds; +# endif /* not HAVE_FD_SET_FDS_BITS */ #endif /* not HAVE_SVC_GETREQSET */ + FD_SET(fwd_sock, &readfds); -#ifdef DEBUG checkup(); -#endif /* DEBUG */ /* * If the full timeout code is not called, * then recompute the time delta manually. */ - now = clocktime(); + now = clocktime(NULL); if (next_softclock <= now) { if (amd_state == Finishing) @@ -251,29 +235,30 @@ run_rpc(void) } tvv.tv_usec = 0; - if (amd_state == Finishing && last_used_map < 0) { + if (amd_state == Finishing && get_exported_ap(0) == NULL) { flush_mntfs(); amd_state = Quit; break; } + +#ifdef HAVE_FS_AUTOFS + autofs_add_fdset(&readfds); +#endif /* HAVE_FS_AUTOFS */ + if (tvv.tv_sec <= 0) tvv.tv_sec = SELECT_MAXWAIT; -#ifdef DEBUG if (tvv.tv_sec) { dlog("Select waits for %ds", (int) tvv.tv_sec); } else { dlog("Select waits for Godot"); } -#endif /* DEBUG */ nsel = do_select(smask, FD_SETSIZE, &readfds, &tvv); switch (nsel) { case -1: if (errno == EINTR) { -#ifdef DEBUG dlog("select interrupted"); -#endif /* DEBUG */ continue; } plog(XLOG_ERROR, "select: %m"); @@ -284,22 +269,22 @@ run_rpc(void) default: /* - * Read all pending NFS responses at once to avoid having responses. + * Read all pending NFS responses at once to avoid having responses * queue up as a consequence of retransmissions. */ -#ifdef FD_SET if (FD_ISSET(fwd_sock, &readfds)) { FD_CLR(fwd_sock, &readfds); -#else /* not FD_SET */ - if (readfds & (1 << fwd_sock)) { - readfds &= ~(1 << fwd_sock); -#endif /* not FD_SET */ --nsel; do { fwd_reply(); } while (rpc_pending_now() > 0); } +#ifdef HAVE_FS_AUTOFS + if (nsel) + nsel = autofs_handle_fdset(&readfds, nsel); +#endif /* HAVE_FS_AUTOFS */ + if (nsel) { /* * Anything left must be a normal @@ -308,11 +293,11 @@ run_rpc(void) #ifdef HAVE_SVC_GETREQSET svc_getreqset(&readfds); #else /* not HAVE_SVC_GETREQSET */ -# ifdef FD_SET +# ifdef HAVE_FD_SET_FDS_BITS svc_getreq(readfds.fds_bits[0]); -# else /* not FD_SET */ +# else /* not HAVE_FD_SET_FDS_BITS */ svc_getreq(readfds); -# endif /* not FD_SET */ +# endif /* not HAVE_FD_SET_FDS_BITS */ #endif /* not HAVE_SVC_GETREQSET */ } break; @@ -344,26 +329,16 @@ mount_automounter(int ppid) int nmount, ret; int soNFS; int udp_soAMQ, tcp_soAMQ; -#ifdef HAVE_TRANSPORT_TYPE_TLI struct netconfig *udp_amqncp, *tcp_amqncp; -#endif /* HAVE_TRANSPORT_TYPE_TLI */ /* - * Create the nfs service for amd + * This must be done first, because it attempts to bind + * to various UDP ports and we don't want anything else + * potentially taking over those ports before we get a chance + * to reserve them. */ -#ifdef HAVE_TRANSPORT_TYPE_TLI - ret = create_nfs_service(&soNFS, &nfs_port, &nfsxprt, nfs_program_2); - if (ret != 0) - return ret; - ret = create_amq_service(&udp_soAMQ, &udp_amqp, &udp_amqncp, &tcp_soAMQ, &tcp_amqp, &tcp_amqncp); -#else /* not HAVE_TRANSPORT_TYPE_TLI */ - ret = create_nfs_service(&soNFS, &nfs_port, &nfsxprt, nfs_program_2); - if (ret != 0) - return ret; - ret = create_amq_service(&udp_soAMQ, &udp_amqp, &tcp_soAMQ, &tcp_amqp); -#endif /* not HAVE_TRANSPORT_TYPE_TLI */ - if (ret != 0) - return ret; + if (gopt.flags & CFM_RESTART_EXISTING_MOUNTS) + restart_automounter_nodes(); /* * Start RPC forwarding @@ -385,6 +360,46 @@ mount_automounter(int ppid) restart(); /* + * Create the nfs service for amd + * If nfs_port is already initialized, it means we + * already created the service during restart_automounter_nodes(). + */ + if (nfs_port == 0) { + ret = create_nfs_service(&soNFS, &nfs_port, &nfsxprt, nfs_program_2); + if (ret != 0) + return ret; + } + xsnprintf(pid_fsname, sizeof(pid_fsname), "%s:(pid%ld,port%u)", + am_get_hostname(), (long) am_mypid, nfs_port); + + /* security: if user sets -D amq, don't even create listening socket */ + if (!amuDebug(D_AMQ)) { + ret = create_amq_service(&udp_soAMQ, + &udp_amqp, + &udp_amqncp, + &tcp_soAMQ, + &tcp_amqp, + &tcp_amqncp, + gopt.preferred_amq_port); + if (ret != 0) + return ret; + } + +#ifdef HAVE_FS_AUTOFS + if (amd_use_autofs) { + /* + * Create the autofs service for amd. + */ + ret = create_autofs_service(); + /* if autofs service fails it is OK if using a test amd */ + if (ret != 0) { + plog(XLOG_WARNING, "autofs service registration failed, turning off autofs support"); + amd_use_autofs = 0; + } + } +#endif /* HAVE_FS_AUTOFS */ + + /* * Mount the top-level auto-mountpoints */ nmount = mount_exported(); @@ -401,41 +416,26 @@ mount_automounter(int ppid) return 0; } -#ifdef DEBUG - amuDebug(D_AMQ) { -#endif /* DEBUG */ + if (!amuDebug(D_AMQ)) { /* * Complete registration of amq (first TCP service then UDP) */ unregister_amq(); -#ifdef HAVE_TRANSPORT_TYPE_TLI - ret = svc_reg(tcp_amqp, get_amd_program_number(), AMQ_VERSION, - amq_program_1, tcp_amqncp); -#else /* not HAVE_TRANSPORT_TYPE_TLI */ - ret = svc_register(tcp_amqp, get_amd_program_number(), AMQ_VERSION, - amq_program_1, IPPROTO_TCP); -#endif /* not HAVE_TRANSPORT_TYPE_TLI */ + ret = amu_svc_register(tcp_amqp, get_amd_program_number(), AMQ_VERSION, + amq_program_1, IPPROTO_TCP, tcp_amqncp); if (ret != 1) { plog(XLOG_FATAL, "unable to register (AMQ_PROGRAM=%d, AMQ_VERSION, tcp)", get_amd_program_number()); return 3; } -#ifdef HAVE_TRANSPORT_TYPE_TLI - ret = svc_reg(udp_amqp, get_amd_program_number(), AMQ_VERSION, - amq_program_1, udp_amqncp); -#else /* not HAVE_TRANSPORT_TYPE_TLI */ - ret = svc_register(udp_amqp, get_amd_program_number(), AMQ_VERSION, - amq_program_1, IPPROTO_UDP); -#endif /* not HAVE_TRANSPORT_TYPE_TLI */ + ret = amu_svc_register(udp_amqp, get_amd_program_number(), AMQ_VERSION, + amq_program_1, IPPROTO_UDP, udp_amqncp); if (ret != 1) { plog(XLOG_FATAL, "unable to register (AMQ_PROGRAM=%d, AMQ_VERSION, udp)", get_amd_program_number()); return 4; } - -#ifdef DEBUG } -#endif /* DEBUG */ /* * Start timeout_mp rolling diff --git a/contrib/amd/amd/nfs_subr.c b/contrib/amd/amd/nfs_subr.c index c216b3e524c2..80d3ca8e311c 100644 --- a/contrib/amd/amd/nfs_subr.c +++ b/contrib/amd/amd/nfs_subr.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: nfs_subr.c,v 1.6.2.6 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/nfs_subr.c * */ @@ -57,19 +56,45 @@ # define nfs_error(e) ((nfsstat)(e)) #endif /* nfs_error */ +/* + * File Handle structure + * + * This is interpreted by indexing the exported array + * by fhh_id (for old-style filehandles), or by retrieving + * the node name from fhh_path (for new-style filehandles). + * + * The whole structure is mapped onto a standard fhandle_t + * when transmitted. + */ +struct am_fh { + u_int fhh_gen; /* generation number */ + union { + struct { + int fhh_type; /* old or new am_fh */ + pid_t fhh_pid; /* process id */ + int fhh_id; /* map id */ + } s; + char fhh_path[NFS_FHSIZE-sizeof(u_int)]; /* path to am_node */ + } u; +}; + + /* forward declarations */ +/* converting am-filehandles to mount-points */ +static am_node *fh_to_mp3(am_nfs_fh *fhp, int *rp, int vop); +static am_node *fh_to_mp(am_nfs_fh *fhp); static void count_map_entries(const am_node *mp, u_int *out_blocks, u_int *out_bfree, u_int *out_bavail); static char * -do_readlink(am_node *mp, int *error_return, nfsattrstat **attrpp) +do_readlink(am_node *mp, int *error_return) { char *ln; /* - * If there is a readlink method, then use - * that, otherwise if a link exists use - * that, otherwise use the mount point. + * If there is a readlink method then use it, + * otherwise if a link exists use that, + * otherwise use the mount point. */ if (mp->am_mnt->mf_ops->readlink) { int retry = 0; @@ -86,8 +111,6 @@ do_readlink(am_node *mp, int *error_return, nfsattrstat **attrpp) } else { ln = mp->am_mnt->mf_mount; } - if (attrpp) - *attrpp = &mp->am_attr; return ln; } @@ -108,46 +131,38 @@ nfsproc_getattr_2_svc(am_nfs_fh *argp, struct svc_req *rqstp) static nfsattrstat res; am_node *mp; int retry; - time_t now = clocktime(); + time_t now = clocktime(NULL); -#ifdef DEBUG - amuDebug(D_TRACE) + if (amuDebug(D_TRACE)) plog(XLOG_DEBUG, "getattr:"); -#endif /* DEBUG */ - mp = fh_to_mp2(argp, &retry); + mp = fh_to_mp3(argp, &retry, VLOOK_CREATE); if (mp == 0) { - -#ifdef DEBUG - amuDebug(D_TRACE) + if (amuDebug(D_TRACE)) plog(XLOG_DEBUG, "\tretry=%d", retry); -#endif /* DEBUG */ if (retry < 0) { amd_stats.d_drops++; return 0; } res.ns_status = nfs_error(retry); - } else { - nfsattrstat *attrp = &mp->am_attr; - -#ifdef DEBUG - amuDebug(D_TRACE) - plog(XLOG_DEBUG, "\tstat(%s), size = %d, mtime=%ld", - mp->am_path, - (int) attrp->ns_u.ns_attr_u.na_size, - (long) attrp->ns_u.ns_attr_u.na_mtime.nt_seconds); -#endif /* DEBUG */ - - /* Delay unmount of what was looked up */ - if (mp->am_timeo_w < 4 * gopt.am_timeo_w) - mp->am_timeo_w += gopt.am_timeo_w; - mp->am_ttl = now + mp->am_timeo_w; - - mp->am_stats.s_getattr++; - return attrp; + return &res; } + res = mp->am_attr; + if (amuDebug(D_TRACE)) + plog(XLOG_DEBUG, "\tstat(%s), size = %d, mtime=%ld.%ld", + mp->am_path, + (int) res.ns_u.ns_attr_u.na_size, + (long) res.ns_u.ns_attr_u.na_mtime.nt_seconds, + (long) res.ns_u.ns_attr_u.na_mtime.nt_useconds); + + /* Delay unmount of what was looked up */ + if (mp->am_timeo_w < 4 * gopt.am_timeo_w) + mp->am_timeo_w += gopt.am_timeo_w; + mp->am_ttl = now + mp->am_timeo_w; + + mp->am_stats.s_getattr++; return &res; } @@ -184,18 +199,16 @@ nfsproc_lookup_2_svc(nfsdiropargs *argp, struct svc_req *rqstp) uid_t uid; gid_t gid; -#ifdef DEBUG - amuDebug(D_TRACE) + if (amuDebug(D_TRACE)) plog(XLOG_DEBUG, "lookup:"); -#endif /* DEBUG */ /* finally, find the effective uid/gid from RPC request */ if (getcreds(rqstp, &uid, &gid, nfsxprt) < 0) plog(XLOG_ERROR, "cannot get uid/gid from RPC credentials"); - sprintf(opt_uid, "%d", (int) uid); - sprintf(opt_gid, "%d", (int) gid); + xsnprintf(opt_uid, sizeof(uid_str), "%d", (int) uid); + xsnprintf(opt_gid, sizeof(gid_str), "%d", (int) gid); - mp = fh_to_mp2(&argp->da_fhandle, &retry); + mp = fh_to_mp3(&argp->da_fhandle, &retry, VLOOK_CREATE); if (mp == 0) { if (retry < 0) { amd_stats.d_drops++; @@ -205,11 +218,11 @@ nfsproc_lookup_2_svc(nfsdiropargs *argp, struct svc_req *rqstp) } else { int error; am_node *ap; -#ifdef DEBUG - amuDebug(D_TRACE) - plog(XLOG_DEBUG, "\tlookuppn(%s, %s)", mp->am_path, argp->da_name); -#endif /* DEBUG */ - ap = (*mp->am_mnt->mf_ops->lookuppn) (mp, argp->da_name, &error, VLOOK_CREATE); + if (amuDebug(D_TRACE)) + plog(XLOG_DEBUG, "\tlookup(%s, %s)", mp->am_path, argp->da_name); + ap = mp->am_mnt->mf_ops->lookup_child(mp, argp->da_name, &error, VLOOK_CREATE); + if (ap && error < 0) + ap = mp->am_mnt->mf_ops->mount_child(ap, &error); if (ap == 0) { if (error < 0) { amd_stats.d_drops++; @@ -237,7 +250,7 @@ nfsproc_lookup_2_svc(nfsdiropargs *argp, struct svc_req *rqstp) void -quick_reply(am_node *mp, int error) +nfs_quick_reply(am_node *mp, int error) { SVCXPRT *transp = mp->am_transp; nfsdiropres res; @@ -271,11 +284,8 @@ quick_reply(am_node *mp, int error) /* * Free up transp. It's only used for one reply. */ - XFREE(transp); - mp->am_transp = NULL; -#ifdef DEBUG + XFREE(mp->am_transp); dlog("Quick reply sent for %s", mp->am_mnt->mf_mount); -#endif /* DEBUG */ } } @@ -287,12 +297,10 @@ nfsproc_readlink_2_svc(am_nfs_fh *argp, struct svc_req *rqstp) am_node *mp; int retry; -#ifdef DEBUG - amuDebug(D_TRACE) + if (amuDebug(D_TRACE)) plog(XLOG_DEBUG, "readlink:"); -#endif /* DEBUG */ - mp = fh_to_mp2(argp, &retry); + mp = fh_to_mp3(argp, &retry, VLOOK_CREATE); if (mp == 0) { readlink_retry: if (retry < 0) { @@ -301,15 +309,12 @@ nfsproc_readlink_2_svc(am_nfs_fh *argp, struct svc_req *rqstp) } res.rlr_status = nfs_error(retry); } else { - char *ln = do_readlink(mp, &retry, (nfsattrstat **) 0); + char *ln = do_readlink(mp, &retry); if (ln == 0) goto readlink_retry; res.rlr_status = NFS_OK; -#ifdef DEBUG - amuDebug(D_TRACE) - if (ln) - plog(XLOG_DEBUG, "\treadlink(%s) = %s", mp->am_path, ln); -#endif /* DEBUG */ + if (amuDebug(D_TRACE) && ln) + plog(XLOG_DEBUG, "\treadlink(%s) = %s", mp->am_path, ln); res.rlr_u.rlr_data_u = ln; mp->am_stats.s_readlink++; } @@ -388,12 +393,10 @@ unlink_or_rmdir(nfsdiropargs *argp, struct svc_req *rqstp, int unlinkp) goto out; } -#ifdef DEBUG - amuDebug(D_TRACE) + if (amuDebug(D_TRACE)) plog(XLOG_DEBUG, "\tremove(%s, %s)", mp->am_path, argp->da_name); -#endif /* DEBUG */ - mp = (*mp->am_mnt->mf_ops->lookuppn) (mp, argp->da_name, &retry, VLOOK_DELETE); + mp = mp->am_mnt->mf_ops->lookup_child(mp, argp->da_name, &retry, VLOOK_DELETE); if (mp == 0) { /* * Ignore retries... @@ -503,12 +506,10 @@ nfsproc_readdir_2_svc(nfsreaddirargs *argp, struct svc_req *rqstp) am_node *mp; int retry; -#ifdef DEBUG - amuDebug(D_TRACE) + if (amuDebug(D_TRACE)) plog(XLOG_DEBUG, "readdir:"); -#endif /* DEBUG */ - mp = fh_to_mp2(&argp->rda_fhandle, &retry); + mp = fh_to_mp3(&argp->rda_fhandle, &retry, VLOOK_CREATE); if (mp == 0) { if (retry < 0) { amd_stats.d_drops++; @@ -516,10 +517,8 @@ nfsproc_readdir_2_svc(nfsreaddirargs *argp, struct svc_req *rqstp) } res.rdr_status = nfs_error(retry); } else { -#ifdef DEBUG - amuDebug(D_TRACE) + if (amuDebug(D_TRACE)) plog(XLOG_DEBUG, "\treaddir(%s)", mp->am_path); -#endif /* DEBUG */ res.rdr_status = nfs_error((*mp->am_mnt->mf_ops->readdir) (mp, argp->rda_cookie, &res.rdr_u.rdr_reply_u, e_res, argp->rda_count)); @@ -538,12 +537,10 @@ nfsproc_statfs_2_svc(am_nfs_fh *argp, struct svc_req *rqstp) int retry; mntent_t mnt; -#ifdef DEBUG - amuDebug(D_TRACE) + if (amuDebug(D_TRACE)) plog(XLOG_DEBUG, "statfs:"); -#endif /* DEBUG */ - mp = fh_to_mp2(argp, &retry); + mp = fh_to_mp3(argp, &retry, VLOOK_CREATE); if (mp == 0) { if (retry < 0) { amd_stats.d_drops++; @@ -552,10 +549,8 @@ nfsproc_statfs_2_svc(am_nfs_fh *argp, struct svc_req *rqstp) res.sfr_status = nfs_error(retry); } else { nfsstatfsokres *fp; -#ifdef DEBUG - amuDebug(D_TRACE) + if (amuDebug(D_TRACE)) plog(XLOG_DEBUG, "\tstat_fs(%s)", mp->am_path); -#endif /* DEBUG */ /* * just return faked up file system information @@ -569,7 +564,7 @@ nfsproc_statfs_2_svc(am_nfs_fh *argp, struct svc_req *rqstp) if ((gopt.flags & CFM_SHOW_STATFS_ENTRIES) && mp->am_mnt && mp->am_mnt->mf_mopts) { mnt.mnt_opts = mp->am_mnt->mf_mopts; - if (hasmntopt(&mnt, "browsable")) { + if (amu_hasmntopt(&mnt, "browsable")) { count_map_entries(mp, &fp->sfrok_blocks, &fp->sfrok_bfree, @@ -629,3 +624,205 @@ out: *out_bfree = bfree; *out_bavail = bavail; } + + +/* + * Convert from file handle to automount node. + */ +static am_node * +fh_to_mp3(am_nfs_fh *fhp, int *rp, int vop) +{ + struct am_fh *fp = (struct am_fh *) fhp; + am_node *ap = 0; + + if (fp->u.s.fhh_type != 0) { + /* New filehandle type */ + int len = sizeof(*fhp) - sizeof(fp->fhh_gen); + char *path = xmalloc(len+1); + /* + * Because fhp is treated as a filehandle we use memcpy + * instead of xstrlcpy. + */ + memcpy(path, (char *) fp->u.fhh_path, len); + path[len] = '\0'; + /* dlog("fh_to_mp3: new filehandle: %s", path); */ + + ap = path_to_exported_ap(path); + XFREE(path); + } else { + /* dlog("fh_to_mp3: old filehandle: %d", fp->u.s.fhh_id); */ + /* + * Check process id matches + * If it doesn't then it is probably + * from an old kernel-cached filehandle + * which is now out of date. + */ + if (fp->u.s.fhh_pid != get_server_pid()) { + dlog("fh_to_mp3: wrong pid %ld != my pid %ld", + (long) fp->u.s.fhh_pid, get_server_pid()); + goto drop; + } + + /* + * Get hold of the supposed mount node + */ + ap = get_exported_ap(fp->u.s.fhh_id); + } + + /* + * Check the generation number in the node + * matches the one from the kernel. If not + * then the old node has been timed out and + * a new one allocated. + */ + if (ap != NULL && ap->am_gen != fp->fhh_gen) + ap = 0; + + /* + * If it doesn't exists then drop the request + */ + if (!ap) + goto drop; + +#if 0 + /* + * If the node is hung then locate a new node + * for it. This implements the replicated filesystem + * retries. + */ + if (ap->am_mnt && FSRV_ISDOWN(ap->am_mnt->mf_server) && ap->am_parent) { + int error; + am_node *orig_ap = ap; + + dlog("fh_to_mp3: %s (%s) is hung: lookup alternative file server", + orig_ap->am_path, orig_ap->am_mnt->mf_info); + + /* + * Update modify time of parent node. + * With any luck the kernel will re-stat + * the child node and get new information. + */ + clocktime(&orig_ap->am_fattr.na_mtime); + + /* + * Call the parent's lookup routine for an object + * with the same name. This may return -1 in error + * if a mount is in progress. In any case, if no + * mount node is returned the error code is propagated + * to the caller. + */ + if (vop == VLOOK_CREATE) { + ap = orig_ap->am_parent->am_mnt->mf_ops->lookup_child(orig_ap->am_parent, orig_ap->am_name, &error, vop); + if (ap && error < 0) + ap = orig_ap->am_parent->am_mnt->mf_ops->mount_child(ap, &error); + } else { + ap = 0; + error = ESTALE; + } + if (ap == 0) { + if (error < 0 && amd_state == Finishing) + error = ENOENT; + *rp = error; + return 0; + } + + /* + * Update last access to original node. This + * avoids timing it out and so sending ESTALE + * back to the kernel. + * XXX - Not sure we need this anymore (jsp, 90/10/6). + */ + new_ttl(orig_ap); + + } +#endif + + /* + * Disallow references to objects being unmounted, unless + * they are automount points. + */ + if (ap->am_mnt && (ap->am_mnt->mf_flags & MFF_UNMOUNTING) && + !(ap->am_flags & AMF_ROOT)) { + if (amd_state == Finishing) + *rp = ENOENT; + else + *rp = -1; + return 0; + } + new_ttl(ap); + +drop: + if (!ap || !ap->am_mnt) { + /* + * If we are shutting down then it is likely + * that this node has disappeared because of + * a fast timeout. To avoid things thrashing + * just pretend it doesn't exist at all. If + * ESTALE is returned, some NFS clients just + * keep retrying (stupid or what - if it's + * stale now, what's it going to be in 5 minutes?) + */ + if (amd_state == Finishing) + *rp = ENOENT; + else + *rp = ESTALE; + amd_stats.d_stale++; + } + + return ap; +} + + +static am_node * +fh_to_mp(am_nfs_fh *fhp) +{ + int dummy; + + return fh_to_mp3(fhp, &dummy, VLOOK_CREATE); +} + + +/* + * Convert from automount node to file handle. + */ +void +mp_to_fh(am_node *mp, am_nfs_fh *fhp) +{ + u_int pathlen; + struct am_fh *fp = (struct am_fh *) fhp; + + memset((char *) fhp, 0, sizeof(am_nfs_fh)); + + /* Store the generation number */ + fp->fhh_gen = mp->am_gen; + + pathlen = strlen(mp->am_path); + if (pathlen <= sizeof(*fhp) - sizeof(fp->fhh_gen)) { + /* dlog("mp_to_fh: new filehandle: %s", mp->am_path); */ + + /* + * Because fhp is treated as a filehandle we use memcpy instead of + * xstrlcpy. + */ + memcpy(fp->u.fhh_path, mp->am_path, pathlen); /* making a filehandle */ + } else { + /* + * Take the process id + */ + fp->u.s.fhh_pid = get_server_pid(); + + /* + * ... the map number + */ + fp->u.s.fhh_id = mp->am_mapno; + + /* + * ... and the generation number (previously stored) + * to make a "unique" triple that will never + * be reallocated except across reboots (which doesn't matter) + * or if we are unlucky enough to be given the same + * pid as a previous amd (very unlikely). + */ + /* dlog("mp_to_fh: old filehandle: %d", fp->u.s.fhh_id); */ + } +} diff --git a/contrib/amd/amd/ops_TEMPLATE.c b/contrib/amd/amd/ops_TEMPLATE.c index dcec2808687a..3f7421984412 100644 --- a/contrib/amd/amd/ops_TEMPLATE.c +++ b/contrib/amd/amd/ops_TEMPLATE.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: ops_TEMPLATE.c,v 1.3.2.5 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/ops_TEMPLATE.c * */ @@ -62,16 +61,14 @@ /* forward declarations */ static char *foofs_match(am_opts *fo); static int foofs_init(mntfs *mf); -static int foofs_mount(am_node *mp); -static int foofs_fmount(mntfs *mf); -static int foofs_umount(am_node *mp); -static int foofs_fumount(mntfs *mf); +static int foofs_mount(am_node *mp, mntfs *mf); +static int foofs_umount(am_node *mp, mntfs *mf); static am_node *foofs_lookuppn(am_node *mp, char *fname, int *error_return, int op); -static int foofs_readdir(am_node *mp, nfscookie cookie, nfsdirlist *dp, nfsentry *ep, int count); +static int foofs_readdir(am_node *mp, nfscookie cookie, nfsdirlist *dp, nfsentry *ep, u_int count); static am_node *foofs_readlink(am_node *mp, int *error_return); -static void foofs_mounted(mntfs *mf); -static void foofs_umounted(am_node *mp); -fserver *foofs_ffserver(mntfs *mf); +static void foofs_mounted(am_node *am, mntfs *mf); +static void foofs_umounted(am_node *mp, mntfs *mf); +static fserver *foofs_ffserver(mntfs *mf); /* @@ -84,16 +81,19 @@ am_ops foofs_ops = foofs_match, /* match */ foofs_init, /* initialize */ foofs_mount, /* mount vnode */ - foofs_fmount, /* mount vfs */ foofs_umount, /* unmount vnode */ - foofs_fumount, /* unmount VFS */ - foofs_lookuppn, /* lookup path-name */ + foofs_lookup_child, /* lookup path-name */ + foofs_mount_child, /* mount path-name */ foofs_readdir, /* read directory */ foofs_readlink, /* read link */ foofs_mounted, /* after-mount extra actions */ foofs_umounted, /* after-umount extra actions */ foofs_ffserver, /* find a file server */ - FS_MKMNT | FS_BACKGROUND | FS_AMQINFO /* flags */ + foofs_get_wchan, /* return the waiting channel */ + FS_MKMNT | FS_BACKGROUND | FS_AMQINFO, /* nfs_fs_flags */ +#ifdef HAVE_FS_AUTOFS + AUTOFS_TEMPLATE_FS_FLAGS, +#endif /* HAVE_FS_AUTOFS */ }; @@ -220,7 +220,7 @@ foofs_lookuppn(am_node *mp, char *fname, int *error_return, int op) * If OK, fills in ep with chain of directory entries. */ static int -foofs_readdir(am_node *mp, nfscookie cookie, nfsdirlist *dp, nfsentry *ep, int count) +foofs_readdir(am_node *mp, nfscookie cookie, nfsdirlist *dp, nfsentry *ep, u_int count) { int error = 0; @@ -284,10 +284,22 @@ foofs_umounted(am_node *mp) * Find a file server. * Returns: fserver of found server, or NULL if not found. */ -fserver * +static fserver * foofs_ffserver(mntfs *mf) { plog(XLOG_INFO, "entering foofs_ffserver..."); return NULL; } + + +/* + * Normally just return mf. Only inherit needs to do special tricks. + */ +static wchan_t * +foofs_get_wchan(mntfs *mf) +{ + plog(XLOG_INFO, "entering foofs_get_wchan..."); + + return mf; +} diff --git a/contrib/amd/amd/ops_cachefs.c b/contrib/amd/amd/ops_cachefs.c index 08c48759664e..d3e303bc2bf9 100644 --- a/contrib/amd/amd/ops_cachefs.c +++ b/contrib/amd/amd/ops_cachefs.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: ops_cachefs.c,v 1.3.2.4 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/ops_cachefs.c * */ @@ -55,8 +54,8 @@ /* forward declarations */ static char *cachefs_match(am_opts *fo); static int cachefs_init(mntfs *mf); -static int cachefs_fmount(mntfs *mf); -static int cachefs_fumount(mntfs *mf); +static int cachefs_mount(am_node *am, mntfs *mf); +static int cachefs_umount(am_node *am, mntfs *mf); /* @@ -67,17 +66,20 @@ am_ops cachefs_ops = "cachefs", cachefs_match, cachefs_init, - amfs_auto_fmount, - cachefs_fmount, - amfs_auto_fumount, - cachefs_fumount, - amfs_error_lookuppn, + cachefs_mount, + cachefs_umount, + amfs_error_lookup_child, + amfs_error_mount_child, amfs_error_readdir, 0, /* cachefs_readlink */ - 0, /* post-mount actions */ - 0, /* post-umount actions */ - find_amfs_auto_srvr, - FS_MKMNT | FS_NOTIMEOUT | FS_UBACKGROUND | FS_AMQINFO + 0, /* cachefs_mounted */ + 0, /* cachefs_umounted */ + amfs_generic_find_srvr, + 0, /* cachefs_get_wchan */ + FS_MKMNT | FS_NOTIMEOUT | FS_UBACKGROUND | FS_AMQINFO, /* nfs_fs_flags */ +#ifdef HAVE_FS_AUTOFS + AUTOFS_CACHEFS_FS_FLAGS, +#endif /* HAVE_FS_AUTOFS */ }; @@ -94,9 +96,7 @@ cachefs_match(am_opts *fo) return NULL; } -#ifdef DEBUG dlog("CACHEFS: using cache directory \"%s\"", fo->opt_cachedir); -#endif /* DEBUG */ /* determine magic cookie to put in mtab */ return strdup(fo->opt_cachedir); @@ -113,7 +113,7 @@ cachefs_init(mntfs *mf) /* * Save cache directory name */ - if (mf->mf_refc == 1) { + if (!mf->mf_private) { mf->mf_private = (voidp) strdup(mf->mf_fo->opt_cachedir); mf->mf_prfree = (void (*)(voidp)) free; } @@ -128,7 +128,8 @@ cachefs_init(mntfs *mf) * cachedir is the cache directory ($cachedir) */ static int -mount_cachefs(char *mntpt, char *backdir, char *cachedir, char *opts) +mount_cachefs(char *mntdir, char *backdir, char *cachedir, + char *opts, int on_autofs) { cachefs_args_t ca; mntent_t mnt; @@ -142,12 +143,16 @@ mount_cachefs(char *mntpt, char *backdir, char *cachedir, char *opts) * Fill in the mount structure */ memset((voidp) &mnt, 0, sizeof(mnt)); - mnt.mnt_dir = mntpt; + mnt.mnt_dir = mntdir; mnt.mnt_fsname = backdir; mnt.mnt_type = MNTTAB_TYPE_CACHEFS; mnt.mnt_opts = opts; flags = compute_mount_flags(&mnt); +#ifdef HAVE_FS_AUTOFS + if (on_autofs) + flags |= autofs_compute_mount_flags(&mnt); +#endif /* HAVE_FS_AUTOFS */ /* Fill in cachefs mount arguments */ @@ -170,8 +175,13 @@ mount_cachefs(char *mntpt, char *backdir, char *cachedir, char *opts) /* CFS fscdir name */ memset(ca.cfs_cacheid, 0, sizeof(ca.cfs_cacheid)); - /* append cacheid and mountpoint */ - sprintf(ca.cfs_cacheid, "%s:%s", ca.cfs_fsid, mntpt); + /* + * Append cacheid and mountpoint. + * sizeof(cfs_cacheid) should be C_MAX_MOUNT_FSCDIRNAME as per + * <sys/fs/cachefs_fs.h> (checked on Solaris 8). + */ + xsnprintf(ca.cfs_cacheid, sizeof(ca.cfs_cacheid), + "%s:%s", ca.cfs_fsid, mntdir); /* convert '/' to '_' (Solaris does that...) */ cp = ca.cfs_cacheid; while ((cp = strpbrk(cp, "/")) != NULL) @@ -192,19 +202,21 @@ mount_cachefs(char *mntpt, char *backdir, char *cachedir, char *opts) /* * Call generic mount routine */ - return mount_fs(&mnt, flags, (caddr_t) &ca, 0, type, 0, NULL, mnttab_file_name); + return mount_fs(&mnt, flags, (caddr_t) &ca, 0, type, 0, NULL, mnttab_file_name, on_autofs); } static int -cachefs_fmount(mntfs *mf) +cachefs_mount(am_node *am, mntfs *mf) { + int on_autofs = mf->mf_flags & MFF_ON_AUTOFS; int error; error = mount_cachefs(mf->mf_mount, mf->mf_fo->opt_rfs, mf->mf_fo->opt_cachedir, - mf->mf_mopts); + mf->mf_mopts, + on_autofs); if (error) { errno = error; /* according to Solaris, if errno==ESRCH, "options to not match" */ @@ -220,11 +232,12 @@ cachefs_fmount(mntfs *mf) static int -cachefs_fumount(mntfs *mf) +cachefs_umount(am_node *am, mntfs *mf) { + int unmount_flags = (mf->mf_flags & MFF_ON_AUTOFS) ? AMU_UMOUNT_AUTOFS : 0; int error; - error = UMOUNT_FS(mf->mf_mount, mnttab_file_name); + error = UMOUNT_FS(mf->mf_mount, mnttab_file_name, unmount_flags); /* * In the case of cachefs, we must fsck the cache directory. Otherwise, @@ -239,7 +252,7 @@ cachefs_fumount(mntfs *mf) cachedir = (char *) mf->mf_private; plog(XLOG_INFO, "running fsck on cache directory \"%s\"", cachedir); - sprintf(cmd, "fsck -F cachefs %s", cachedir); + xsnprintf(cmd, sizeof(cmd), "fsck -F cachefs %s", cachedir); system(cmd); } diff --git a/contrib/amd/amd/ops_cdfs.c b/contrib/amd/amd/ops_cdfs.c index 6487e6d07903..40355ac5c078 100644 --- a/contrib/amd/amd/ops_cdfs.c +++ b/contrib/amd/amd/ops_cdfs.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: ops_cdfs.c,v 1.4.2.5 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/ops_cdfs.c * */ @@ -54,8 +53,8 @@ /* forward declarations */ static char *cdfs_match(am_opts *fo); -static int cdfs_fmount(mntfs *mf); -static int cdfs_fumount(mntfs *mf); +static int cdfs_mount(am_node *am, mntfs *mf); +static int cdfs_umount(am_node *am, mntfs *mf); /* * Ops structure @@ -65,17 +64,20 @@ am_ops cdfs_ops = "cdfs", cdfs_match, 0, /* cdfs_init */ - amfs_auto_fmount, - cdfs_fmount, - amfs_auto_fumount, - cdfs_fumount, - amfs_error_lookuppn, + cdfs_mount, + cdfs_umount, + amfs_error_lookup_child, + amfs_error_mount_child, amfs_error_readdir, 0, /* cdfs_readlink */ 0, /* cdfs_mounted */ 0, /* cdfs_umounted */ - find_amfs_auto_srvr, - FS_MKMNT | FS_UBACKGROUND | FS_AMQINFO + amfs_generic_find_srvr, + 0, /* cdfs_get_wchan */ + FS_MKMNT | FS_UBACKGROUND | FS_AMQINFO, /* nfs_fs_flags */ +#ifdef HAVE_FS_AUTOFS + AUTOFS_CDFS_FS_FLAGS, +#endif /* HAVE_FS_AUTOFS */ }; @@ -89,10 +91,8 @@ cdfs_match(am_opts *fo) plog(XLOG_USER, "cdfs: no source device specified"); return 0; } -#ifdef DEBUG dlog("CDFS: mounting device \"%s\" on \"%s\"", fo->opt_dev, fo->opt_fs); -#endif /* DEBUG */ /* * Determine magic cookie to put in mtab @@ -102,11 +102,11 @@ cdfs_match(am_opts *fo) static int -mount_cdfs(char *dir, char *fs_name, char *opts) +mount_cdfs(char *mntdir, char *fs_name, char *opts, int on_autofs) { cdfs_args_t cdfs_args; mntent_t mnt; - int genflags, cdfs_flags; + int genflags, cdfs_flags, retval; /* * Figure out the name of the file system type. @@ -120,13 +120,13 @@ mount_cdfs(char *dir, char *fs_name, char *opts) * Fill in the mount structure */ memset((voidp) &mnt, 0, sizeof(mnt)); - mnt.mnt_dir = dir; + mnt.mnt_dir = mntdir; mnt.mnt_fsname = fs_name; mnt.mnt_type = MNTTAB_TYPE_CDFS; mnt.mnt_opts = opts; #if defined(MNT2_CDFS_OPT_DEFPERM) && defined(MNTTAB_OPT_DEFPERM) - if (hasmntopt(&mnt, MNTTAB_OPT_DEFPERM)) + if (amu_hasmntopt(&mnt, MNTTAB_OPT_DEFPERM)) # ifdef MNT2_CDFS_OPT_DEFPERM cdfs_flags |= MNT2_CDFS_OPT_DEFPERM; # else /* not MNT2_CDFS_OPT_DEFPERM */ @@ -135,34 +135,38 @@ mount_cdfs(char *dir, char *fs_name, char *opts) #endif /* defined(MNT2_CDFS_OPT_DEFPERM) && defined(MNTTAB_OPT_DEFPERM) */ #if defined(MNT2_CDFS_OPT_NODEFPERM) && defined(MNTTAB_OPT_NODEFPERM) - if (hasmntopt(&mnt, MNTTAB_OPT_NODEFPERM)) + if (amu_hasmntopt(&mnt, MNTTAB_OPT_NODEFPERM)) cdfs_flags |= MNT2_CDFS_OPT_NODEFPERM; #endif /* MNTTAB_OPT_NODEFPERM */ #if defined(MNT2_CDFS_OPT_NOVERSION) && defined(MNTTAB_OPT_NOVERSION) - if (hasmntopt(&mnt, MNTTAB_OPT_NOVERSION)) + if (amu_hasmntopt(&mnt, MNTTAB_OPT_NOVERSION)) cdfs_flags |= MNT2_CDFS_OPT_NOVERSION; #endif /* defined(MNT2_CDFS_OPT_NOVERSION) && defined(MNTTAB_OPT_NOVERSION) */ #if defined(MNT2_CDFS_OPT_RRIP) && defined(MNTTAB_OPT_RRIP) - if (hasmntopt(&mnt, MNTTAB_OPT_RRIP)) + if (amu_hasmntopt(&mnt, MNTTAB_OPT_RRIP)) cdfs_flags |= MNT2_CDFS_OPT_RRIP; #endif /* defined(MNT2_CDFS_OPT_RRIP) && defined(MNTTAB_OPT_RRIP) */ #if defined(MNT2_CDFS_OPT_NORRIP) && defined(MNTTAB_OPT_NORRIP) - if (hasmntopt(&mnt, MNTTAB_OPT_NORRIP)) + if (amu_hasmntopt(&mnt, MNTTAB_OPT_NORRIP)) cdfs_flags |= MNT2_CDFS_OPT_NORRIP; #endif /* defined(MNT2_CDFS_OPT_NORRIP) && defined(MNTTAB_OPT_NORRIP) */ #if defined(MNT2_CDFS_OPT_GENS) && defined(MNTTAB_OPT_GENS) - if (hasmntopt(&mnt, MNTTAB_OPT_GENS)) + if (amu_hasmntopt(&mnt, MNTTAB_OPT_GENS)) cdfs_flags |= MNT2_CDFS_OPT_GENS; #endif /* defined(MNT2_CDFS_OPT_GENS) && defined(MNTTAB_OPT_GENS) */ #if defined(MNT2_CDFS_OPT_EXTATT) && defined(MNTTAB_OPT_EXTATT) - if (hasmntopt(&mnt, MNTTAB_OPT_EXTATT)) + if (amu_hasmntopt(&mnt, MNTTAB_OPT_EXTATT)) cdfs_flags |= MNT2_CDFS_OPT_EXTATT; #endif /* defined(MNT2_CDFS_OPT_EXTATT) && defined(MNTTAB_OPT_EXTATT) */ genflags = compute_mount_flags(&mnt); +#ifdef HAVE_FS_AUTOFS + if (on_autofs) + genflags |= autofs_compute_mount_flags(&mnt); +#endif /* HAVE_FS_AUTOFS */ #ifdef HAVE_CDFS_ARGS_T_FLAGS cdfs_args.flags = cdfs_flags; @@ -176,10 +180,6 @@ mount_cdfs(char *dir, char *fs_name, char *opts) cdfs_args.iso_pgthresh = hasmntval(&mnt, MNTTAB_OPT_PGTHRESH); #endif /* HAVE_CDFS_ARGS_T_ISO_PGTHRESH */ -#ifdef HAVE_CDFS_ARGS_T_FSPEC - cdfs_args.fspec = fs_name; -#endif /* HAVE_CDFS_ARGS_T_FSPEC */ - #ifdef HAVE_CDFS_ARGS_T_NORRIP /* XXX: need to provide norrip mount opt */ cdfs_args.norrip = 0; /* use Rock-Ridge Protocol extensions */ @@ -190,19 +190,26 @@ mount_cdfs(char *dir, char *fs_name, char *opts) cdfs_args.ssector = 0; /* use 1st session on disk */ #endif /* HAVE_CDFS_ARGS_T_SSECTOR */ +#ifdef HAVE_CDFS_ARGS_T_FSPEC + cdfs_args.fspec = fs_name; +#endif /* HAVE_CDFS_ARGS_T_FSPEC */ + /* * Call generic mount routine */ - return mount_fs(&mnt, genflags, (caddr_t) &cdfs_args, 0, type, 0, NULL, mnttab_file_name); + retval = mount_fs(&mnt, genflags, (caddr_t) &cdfs_args, 0, type, 0, NULL, mnttab_file_name, on_autofs); + + return retval; } static int -cdfs_fmount(mntfs *mf) +cdfs_mount(am_node *am, mntfs *mf) { + int on_autofs = mf->mf_flags & MFF_ON_AUTOFS; int error; - error = mount_cdfs(mf->mf_mount, mf->mf_info, mf->mf_mopts); + error = mount_cdfs(mf->mf_mount, mf->mf_info, mf->mf_mopts, on_autofs); if (error) { errno = error; plog(XLOG_ERROR, "mount_cdfs: %m"); @@ -213,7 +220,9 @@ cdfs_fmount(mntfs *mf) static int -cdfs_fumount(mntfs *mf) +cdfs_umount(am_node *am, mntfs *mf) { - return UMOUNT_FS(mf->mf_mount, mnttab_file_name); + int unmount_flags = (mf->mf_flags & MFF_ON_AUTOFS) ? AMU_UMOUNT_AUTOFS : 0; + + return UMOUNT_FS(mf->mf_mount, mnttab_file_name, unmount_flags); } diff --git a/contrib/amd/amd/ops_efs.c b/contrib/amd/amd/ops_efs.c index 36f47ed8d37f..047fe1e4690c 100644 --- a/contrib/amd/amd/ops_efs.c +++ b/contrib/amd/amd/ops_efs.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: ops_efs.c,v 1.3.2.5 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/ops_efs.c * */ @@ -54,8 +53,8 @@ /* forward declarations */ static char *efs_match(am_opts *fo); -static int efs_fmount(mntfs *mf); -static int efs_fumount(mntfs *mf); +static int efs_mount(am_node *am, mntfs *mf); +static int efs_umount(am_node *am, mntfs *mf); /* * Ops structure @@ -65,17 +64,20 @@ am_ops efs_ops = "efs", efs_match, 0, /* efs_init */ - amfs_auto_fmount, - efs_fmount, - amfs_auto_fumount, - efs_fumount, - amfs_error_lookuppn, + efs_mount, + efs_umount, + amfs_error_lookup_child, + amfs_error_mount_child, amfs_error_readdir, 0, /* efs_readlink */ 0, /* efs_mounted */ 0, /* efs_umounted */ - find_amfs_auto_srvr, - FS_MKMNT | FS_NOTIMEOUT | FS_UBACKGROUND | FS_AMQINFO + amfs_generic_find_srvr, + 0, /* efs_get_wchan */ + FS_MKMNT | FS_NOTIMEOUT | FS_UBACKGROUND | FS_AMQINFO, /* nfs_fs_flags */ +#ifdef HAVE_FS_AUTOFS + AUTOFS_EFS_FS_FLAGS, +#endif /* HAVE_FS_AUTOFS */ }; @@ -91,9 +93,7 @@ efs_match(am_opts *fo) return 0; } -#ifdef DEBUG dlog("EFS: mounting device \"%s\" on \"%s\"", fo->opt_dev, fo->opt_fs); -#endif /* DEBUG */ /* * Determine magic cookie to put in mtab @@ -103,7 +103,7 @@ efs_match(am_opts *fo) static int -mount_efs(char *dir, char *fs_name, char *opts) +mount_efs(char *mntdir, char *fs_name, char *opts, int on_autofs) { efs_args_t efs_args; mntent_t mnt; @@ -120,12 +120,16 @@ mount_efs(char *dir, char *fs_name, char *opts) * Fill in the mount structure */ memset((voidp) &mnt, 0, sizeof(mnt)); - mnt.mnt_dir = dir; + mnt.mnt_dir = mntdir; mnt.mnt_fsname = fs_name; mnt.mnt_type = MNTTAB_TYPE_EFS; mnt.mnt_opts = opts; flags = compute_mount_flags(&mnt); +#ifdef HAVE_FS_AUTOFS + if (on_autofs) + flags |= autofs_compute_mount_flags(&mnt); +#endif /* HAVE_FS_AUTOFS */ #ifdef HAVE_EFS_ARGS_T_FLAGS efs_args.flags = 0; /* XXX: fix this to correct flags */ @@ -137,16 +141,17 @@ mount_efs(char *dir, char *fs_name, char *opts) /* * Call generic mount routine */ - return mount_fs(&mnt, flags, (caddr_t) &efs_args, 0, type, 0, NULL, mnttab_file_name); + return mount_fs(&mnt, flags, (caddr_t) &efs_args, 0, type, 0, NULL, mnttab_file_name, on_autofs); } static int -efs_fmount(mntfs *mf) +efs_mount(am_node *am, mntfs *mf) { + int on_autofs = mf->mf_flags & MFF_ON_AUTOFS; int error; - error = mount_efs(mf->mf_mount, mf->mf_info, mf->mf_mopts); + error = mount_efs(mf->mf_mount, mf->mf_info, mf->mf_mopts, on_autofs); if (error) { errno = error; plog(XLOG_ERROR, "mount_efs: %m"); @@ -158,7 +163,10 @@ efs_fmount(mntfs *mf) static int -efs_fumount(mntfs *mf) +efs_umount(am_node *am, mntfs *mf) { - return UMOUNT_FS(mf->mf_mount, mnttab_file_name); + int unmount_flags = (mf->mf_flags & MFF_ON_AUTOFS) ? AMU_UMOUNT_AUTOFS : 0; + + return UMOUNT_FS(mf->mf_mount, mnttab_file_name, unmount_flags); } + diff --git a/contrib/amd/amd/ops_lofs.c b/contrib/amd/amd/ops_lofs.c index 6d27d2c4c974..26fdc9f9b626 100644 --- a/contrib/amd/amd/ops_lofs.c +++ b/contrib/amd/amd/ops_lofs.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: ops_lofs.c,v 1.3.2.5 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/ops_lofs.c * */ @@ -54,10 +53,8 @@ /* forward definitions */ static char *lofs_match(am_opts *fo); -static int lofs_fmount(mntfs *mf); -static int lofs_fumount(mntfs *mf); -static int mount_lofs(char *dir, char *fs_name, char *opts); - +static int lofs_mount(am_node *am, mntfs *mf); +static int lofs_umount(am_node *am, mntfs *mf); /* * Ops structure @@ -67,17 +64,20 @@ am_ops lofs_ops = "lofs", lofs_match, 0, /* lofs_init */ - amfs_auto_fmount, - lofs_fmount, - amfs_auto_fumount, - lofs_fumount, - amfs_error_lookuppn, + lofs_mount, + lofs_umount, + amfs_error_lookup_child, + amfs_error_mount_child, amfs_error_readdir, 0, /* lofs_readlink */ 0, /* lofs_mounted */ 0, /* lofs_umounted */ - find_amfs_auto_srvr, - FS_MKMNT | FS_NOTIMEOUT | FS_UBACKGROUND | FS_AMQINFO + amfs_generic_find_srvr, + 0, /* lofs_get_wchan */ + FS_MKMNT | FS_NOTIMEOUT | FS_UBACKGROUND | FS_AMQINFO, /* nfs_fs_flags */ +#ifdef HAVE_FS_AUTOFS + AUTOFS_LOFS_FS_FLAGS, +#endif /* HAVE_FS_AUTOFS */ }; @@ -91,10 +91,8 @@ lofs_match(am_opts *fo) plog(XLOG_USER, "lofs: no source filesystem specified"); return 0; } -#ifdef DEBUG dlog("LOFS: mounting fs \"%s\" on \"%s\"", fo->opt_rfs, fo->opt_fs); -#endif /* DEBUG */ /* * Determine magic cookie to put in mtab @@ -103,8 +101,8 @@ lofs_match(am_opts *fo) } -static int -mount_lofs(char *dir, char *fs_name, char *opts) +int +mount_lofs(char *mntdir, char *fs_name, char *opts, int on_autofs) { mntent_t mnt; int flags; @@ -118,26 +116,31 @@ mount_lofs(char *dir, char *fs_name, char *opts) * Fill in the mount structure */ memset((voidp) &mnt, 0, sizeof(mnt)); - mnt.mnt_dir = dir; + mnt.mnt_dir = mntdir; mnt.mnt_fsname = fs_name; mnt.mnt_type = MNTTAB_TYPE_LOFS; mnt.mnt_opts = opts; flags = compute_mount_flags(&mnt); +#ifdef HAVE_FS_AUTOFS + if (on_autofs) + flags |= autofs_compute_mount_flags(&mnt); +#endif /* HAVE_FS_AUTOFS */ /* * Call generic mount routine */ - return mount_fs(&mnt, flags, NULL, 0, type, 0, NULL, mnttab_file_name); + return mount_fs(&mnt, flags, NULL, 0, type, 0, NULL, mnttab_file_name, on_autofs); } static int -lofs_fmount(mntfs *mf) +lofs_mount(am_node *am, mntfs *mf) { + int on_autofs = mf->mf_flags & MFF_ON_AUTOFS; int error; - error = mount_lofs(mf->mf_mount, mf->mf_info, mf->mf_mopts); + error = mount_lofs(mf->mf_mount, mf->mf_info, mf->mf_mopts, on_autofs); if (error) { errno = error; plog(XLOG_ERROR, "mount_lofs: %m"); @@ -148,7 +151,9 @@ lofs_fmount(mntfs *mf) static int -lofs_fumount(mntfs *mf) +lofs_umount(am_node *am, mntfs *mf) { - return UMOUNT_FS(mf->mf_mount, mnttab_file_name); + int unmount_flags = (mf->mf_flags & MFF_ON_AUTOFS) ? AMU_UMOUNT_AUTOFS : 0; + + return UMOUNT_FS(mf->mf_mount, mnttab_file_name, unmount_flags); } diff --git a/contrib/amd/amd/ops_mfs.c b/contrib/amd/amd/ops_mfs.c index 67d6e98ef8f7..ccaa49c569cd 100644 --- a/contrib/amd/amd/ops_mfs.c +++ b/contrib/amd/amd/ops_mfs.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: ops_mfs.c,v 1.3.2.4 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/ops_mfs.c * */ diff --git a/contrib/amd/amd/ops_nfs.c b/contrib/amd/amd/ops_nfs.c index 5f6a47454a1e..a6a85858d484 100644 --- a/contrib/amd/amd/ops_nfs.c +++ b/contrib/amd/amd/ops_nfs.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: ops_nfs.c,v 1.6.2.6 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/ops_nfs.c * */ @@ -64,7 +63,7 @@ */ #define FH_TTL (5 * 60) /* five minutes */ #define FH_TTL_ERROR (30) /* 30 seconds */ -#define FHID_ALLOC(struct) (++fh_id) +#define FHID_ALLOC() (++fh_id) /* * The NFS layer maintains a cache of file handles. @@ -92,19 +91,26 @@ typedef struct fh_cache fh_cache; struct fh_cache { qelem fh_q; /* List header */ - voidp fh_wchan; /* Wait channel */ + wchan_t fh_wchan; /* Wait channel */ int fh_error; /* Valid data? */ int fh_id; /* Unique id */ int fh_cid; /* Callout id */ u_long fh_nfs_version; /* highest NFS version on host */ am_nfs_handle_t fh_nfs_handle; /* Handle on filesystem */ + int fh_status; /* Status of last rpc */ struct sockaddr_in fh_sin; /* Address of mountd */ fserver *fh_fs; /* Server holding filesystem */ char *fh_path; /* Filesystem on host */ }; /* forward definitions */ -static int call_mountd(fh_cache *fp, u_long proc, fwd_fun f, voidp wchan); +static int nfs_init(mntfs *mf); +static char *nfs_match(am_opts *fo); +static int nfs_mount(am_node *am, mntfs *mf); +static int nfs_umount(am_node *am, mntfs *mf); +static void nfs_umounted(mntfs *mf); +static int call_mountd(fh_cache *fp, u_long proc, fwd_fun f, wchan_t wchan); +static int webnfs_lookup(fh_cache *fp, fwd_fun f, wchan_t wchan); static int fh_id = 0; /* globals */ @@ -119,25 +125,28 @@ am_ops nfs_ops = "nfs", nfs_match, nfs_init, - amfs_auto_fmount, - nfs_fmount, - amfs_auto_fumount, - nfs_fumount, - amfs_error_lookuppn, + nfs_mount, + nfs_umount, + amfs_error_lookup_child, + amfs_error_mount_child, amfs_error_readdir, 0, /* nfs_readlink */ 0, /* nfs_mounted */ nfs_umounted, find_nfs_srvr, - FS_MKMNT | FS_BACKGROUND | FS_AMQINFO + 0, /* nfs_get_wchan */ + FS_MKMNT | FS_BACKGROUND | FS_AMQINFO, /* nfs_fs_flags */ +#ifdef HAVE_FS_AUTOFS + AUTOFS_NFS_FS_FLAGS, +#endif /* HAVE_FS_AUTOFS */ }; static fh_cache * -find_nfs_fhandle_cache(voidp idv, int done) +find_nfs_fhandle_cache(opaque_t arg, int done) { fh_cache *fp, *fp2 = 0; - int id = (long) idv; /* for 64-bit archs */ + int id = (long) arg; /* for 64-bit archs */ ITER(fp, fh_cache, &fh_head) { if (fp->fh_id == id) { @@ -146,13 +155,11 @@ find_nfs_fhandle_cache(voidp idv, int done) } } -#ifdef DEBUG if (fp2) { dlog("fh cache gives fp %#lx, fs %s", (unsigned long) fp2, fp2->fh_path); } else { dlog("fh cache search failed"); } -#endif /* DEBUG */ if (fp2 && !done) { fp2->fh_error = ETIMEDOUT; @@ -164,14 +171,18 @@ find_nfs_fhandle_cache(voidp idv, int done) /* - * Called when a filehandle appears + * Called when a filehandle appears via the mount protocol */ static void -got_nfs_fh(voidp pkt, int len, struct sockaddr_in *sa, struct sockaddr_in *ia, voidp idv, int done) +got_nfs_fh_mount(voidp pkt, int len, struct sockaddr_in *sa, struct sockaddr_in *ia, opaque_t arg, int done) { fh_cache *fp; + struct fhstatus res; +#ifdef HAVE_FS_NFS3 + struct am_mountres3 res3; +#endif /* HAVE_FS_NFS3 */ - fp = find_nfs_fhandle_cache(idv, done); + fp = find_nfs_fhandle_cache(arg, done); if (!fp) return; @@ -180,28 +191,109 @@ got_nfs_fh(voidp pkt, int len, struct sockaddr_in *sa, struct sockaddr_in *ia, v * NFS protocol version. */ #ifdef HAVE_FS_NFS3 - if (fp->fh_nfs_version == NFS_VERSION3) - fp->fh_error = pickup_rpc_reply(pkt, len, (voidp) &fp->fh_nfs_handle.v3, - (XDRPROC_T_TYPE) xdr_mountres3); - else + if (fp->fh_nfs_version == NFS_VERSION3) { + memset(&res3, 0, sizeof(res3)); + fp->fh_error = pickup_rpc_reply(pkt, len, (voidp) &res3, + (XDRPROC_T_TYPE) xdr_am_mountres3); + fp->fh_status = unx_error(res3.fhs_status); + memset(&fp->fh_nfs_handle.v3, 0, sizeof(am_nfs_fh3)); + fp->fh_nfs_handle.v3.am_fh3_length = res3.mountres3_u.mountinfo.fhandle.fhandle3_len; + memmove(fp->fh_nfs_handle.v3.am_fh3_data, + res3.mountres3_u.mountinfo.fhandle.fhandle3_val, + fp->fh_nfs_handle.v3.am_fh3_length); + } else { #endif /* HAVE_FS_NFS3 */ - fp->fh_error = pickup_rpc_reply(pkt, len, (voidp) &fp->fh_nfs_handle.v2, + memset(&res, 0, sizeof(res)); + fp->fh_error = pickup_rpc_reply(pkt, len, (voidp) &res, (XDRPROC_T_TYPE) xdr_fhstatus); + fp->fh_status = unx_error(res.fhs_status); + memmove(&fp->fh_nfs_handle.v2, &res.fhs_fh, NFS_FHSIZE); +#ifdef HAVE_FS_NFS3 + } +#endif /* HAVE_FS_NFS3 */ if (!fp->fh_error) { -#ifdef DEBUG dlog("got filehandle for %s:%s", fp->fh_fs->fs_host, fp->fh_path); -#endif /* DEBUG */ + } else { + plog(XLOG_USER, "filehandle denied for %s:%s", fp->fh_fs->fs_host, fp->fh_path); + /* + * Force the error to be EACCES. It's debatable whether it should be + * ENOENT instead, but the server really doesn't give us any clues, and + * EACCES is more in line with the "filehandle denied" message. + */ + fp->fh_error = EACCES; + } + + /* + * Wakeup anything sleeping on this filehandle + */ + if (fp->fh_wchan) { + dlog("Calling wakeup on %#lx", (unsigned long) fp->fh_wchan); + wakeup(fp->fh_wchan); + } +} + +/* + * Called when a filehandle appears via WebNFS + */ +static void +got_nfs_fh_webnfs(voidp pkt, int len, struct sockaddr_in *sa, struct sockaddr_in *ia, opaque_t arg, int done) +{ + fh_cache *fp; + nfsdiropres res; +#ifdef HAVE_FS_NFS3 + am_LOOKUP3res res3; +#endif /* HAVE_FS_NFS3 */ + + fp = find_nfs_fhandle_cache(arg, done); + if (!fp) + return; + + /* + * retrieve the correct RPC reply for the file handle, based on the + * NFS protocol version. + */ +#ifdef HAVE_FS_NFS3 + if (fp->fh_nfs_version == NFS_VERSION3) { + memset(&res3, 0, sizeof(res3)); + fp->fh_error = pickup_rpc_reply(pkt, len, (voidp) &res3, + (XDRPROC_T_TYPE) xdr_am_LOOKUP3res); + fp->fh_status = unx_error(res3.status); + memset(&fp->fh_nfs_handle.v3, 0, sizeof(am_nfs_fh3)); + fp->fh_nfs_handle.v3.am_fh3_length = res3.res_u.ok.object.am_fh3_length; + memmove(fp->fh_nfs_handle.v3.am_fh3_data, + res3.res_u.ok.object.am_fh3_data, + fp->fh_nfs_handle.v3.am_fh3_length); + } else { +#endif /* HAVE_FS_NFS3 */ + memset(&res, 0, sizeof(res)); + fp->fh_error = pickup_rpc_reply(pkt, len, (voidp) &res, + (XDRPROC_T_TYPE) xdr_diropres); + fp->fh_status = unx_error(res.dr_status); + memmove(&fp->fh_nfs_handle.v2, &res.dr_u.dr_drok_u.drok_fhandle, NFS_FHSIZE); +#ifdef HAVE_FS_NFS3 + } +#endif /* HAVE_FS_NFS3 */ + + if (!fp->fh_error) { + dlog("got filehandle for %s:%s", fp->fh_fs->fs_host, fp->fh_path); + } else { + plog(XLOG_USER, "filehandle denied for %s:%s", fp->fh_fs->fs_host, fp->fh_path); /* - * Wakeup anything sleeping on this filehandle + * Force the error to be EACCES. It's debatable whether it should be + * ENOENT instead, but the server really doesn't give us any clues, and + * EACCES is more in line with the "filehandle denied" message. */ - if (fp->fh_wchan) { -#ifdef DEBUG - dlog("Calling wakeup on %#lx", (unsigned long) fp->fh_wchan); -#endif /* DEBUG */ - wakeup(fp->fh_wchan); - } + fp->fh_error = EACCES; + } + + /* + * Wakeup anything sleeping on this filehandle + */ + if (fp->fh_wchan) { + dlog("Calling wakeup on %#lx", (unsigned long) fp->fh_wchan); + wakeup(fp->fh_wchan); } } @@ -212,8 +304,12 @@ flush_nfs_fhandle_cache(fserver *fs) fh_cache *fp; ITER(fp, fh_cache, &fh_head) { - if (fp->fh_fs == fs || fs == 0) { - fp->fh_sin.sin_port = (u_short) 0; + if (fp->fh_fs == fs || fs == NULL) { + /* + * Only invalidate port info for non-WebNFS servers + */ + if (!(fp->fh_fs->fs_flags & FSF_WEBNFS)) + fp->fh_sin.sin_port = (u_short) 0; fp->fh_error = -1; } } @@ -221,15 +317,13 @@ flush_nfs_fhandle_cache(fserver *fs) static void -discard_fh(voidp v) +discard_fh(opaque_t arg) { - fh_cache *fp = v; + fh_cache *fp = (fh_cache *) arg; rem_que(&fp->fh_q); if (fp->fh_fs) { -#ifdef DEBUG dlog("Discarding filehandle for %s:%s", fp->fh_fs->fs_host, fp->fh_path); -#endif /* DEBUG */ free_srvr(fp->fh_fs); } if (fp->fh_path) @@ -242,88 +336,92 @@ discard_fh(voidp v) * Determine the file handle for a node */ static int -prime_nfs_fhandle_cache(char *path, fserver *fs, am_nfs_handle_t *fhbuf, voidp wchan) +prime_nfs_fhandle_cache(char *path, fserver *fs, am_nfs_handle_t *fhbuf, mntfs *mf) { fh_cache *fp, *fp_save = 0; int error; int reuse_id = FALSE; -#ifdef DEBUG dlog("Searching cache for %s:%s", fs->fs_host, path); -#endif /* DEBUG */ /* * First search the cache */ ITER(fp, fh_cache, &fh_head) { - if (fs == fp->fh_fs && STREQ(path, fp->fh_path)) { - switch (fp->fh_error) { - case 0: - plog(XLOG_INFO, "prime_nfs_fhandle_cache: NFS version %d", (int) fp->fh_nfs_version); -#ifdef HAVE_FS_NFS3 - if (fp->fh_nfs_version == NFS_VERSION3) - error = fp->fh_error = unx_error(fp->fh_nfs_handle.v3.fhs_status); - else -#endif /* HAVE_FS_NFS3 */ - error = fp->fh_error = unx_error(fp->fh_nfs_handle.v2.fhs_status); - if (error == 0) { - if (fhbuf) { + if (fs != fp->fh_fs || !STREQ(path, fp->fh_path)) + continue; /* skip to next ITER item */ + /* else we got a match */ + switch (fp->fh_error) { + case 0: + plog(XLOG_INFO, "prime_nfs_fhandle_cache: NFS version %d", (int) fp->fh_nfs_version); + + error = fp->fh_error = fp->fh_status; + + if (error == 0) { + if (mf->mf_flags & MFF_NFS_SCALEDOWN) { + fp_save = fp; + /* XXX: why reuse the ID? */ + reuse_id = TRUE; + break; + } + + if (fhbuf) { #ifdef HAVE_FS_NFS3 - if (fp->fh_nfs_version == NFS_VERSION3) - memmove((voidp) &(fhbuf->v3), (voidp) &(fp->fh_nfs_handle.v3), - sizeof(fp->fh_nfs_handle.v3)); - else + if (fp->fh_nfs_version == NFS_VERSION3) { + memmove((voidp) &(fhbuf->v3), (voidp) &(fp->fh_nfs_handle.v3), + sizeof(fp->fh_nfs_handle.v3)); + } else #endif /* HAVE_FS_NFS3 */ + { memmove((voidp) &(fhbuf->v2), (voidp) &(fp->fh_nfs_handle.v2), sizeof(fp->fh_nfs_handle.v2)); - } - if (fp->fh_cid) - untimeout(fp->fh_cid); - fp->fh_cid = timeout(FH_TTL, discard_fh, (voidp) fp); - } else if (error == EACCES) { - /* - * Now decode the file handle return code. - */ - plog(XLOG_INFO, "Filehandle denied for \"%s:%s\"", - fs->fs_host, path); - } else { - errno = error; /* XXX */ - plog(XLOG_INFO, "Filehandle error for \"%s:%s\": %m", - fs->fs_host, path); + } } - + if (fp->fh_cid) + untimeout(fp->fh_cid); + fp->fh_cid = timeout(FH_TTL, discard_fh, (opaque_t) fp); + } else if (error == EACCES) { /* - * The error was returned from the remote mount daemon. - * Policy: this error will be cached for now... + * Now decode the file handle return code. */ - return error; + plog(XLOG_INFO, "Filehandle denied for \"%s:%s\"", + fs->fs_host, path); + } else { + errno = error; /* XXX */ + plog(XLOG_INFO, "Filehandle error for \"%s:%s\": %m", + fs->fs_host, path); + } - case -1: - /* - * Still thinking about it, but we can re-use. - */ - fp_save = fp; - reuse_id = TRUE; - break; + /* + * The error was returned from the remote mount daemon. + * Policy: this error will be cached for now... + */ + return error; - default: - /* - * Return the error. - * Policy: make sure we recompute if required again - * in case this was caused by a network failure. - * This can thrash mountd's though... If you find - * your mountd going slowly then: - * 1. Add a fork() loop to main. - * 2. Remove the call to innetgr() and don't use - * netgroups, especially if you don't use YP. - */ - error = fp->fh_error; - fp->fh_error = -1; - return error; - } + case -1: + /* + * Still thinking about it, but we can re-use. + */ + fp_save = fp; + reuse_id = TRUE; break; - } - } + + default: + /* + * Return the error. + * Policy: make sure we recompute if required again + * in case this was caused by a network failure. + * This can thrash mountd's though... If you find + * your mountd going slowly then: + * 1. Add a fork() loop to main. + * 2. Remove the call to innetgr() and don't use + * netgroups, especially if you don't use YP. + */ + error = fp->fh_error; + fp->fh_error = -1; + return error; + } /* end of switch statement */ + } /* end of ITER loop */ /* * Not in cache @@ -342,13 +440,13 @@ prime_nfs_fhandle_cache(char *path, fserver *fs, am_nfs_handle_t *fhbuf, voidp w ins_que(&fp->fh_q, &fh_head); } if (!reuse_id) - fp->fh_id = FHID_ALLOC(struct ); - fp->fh_wchan = wchan; + fp->fh_id = FHID_ALLOC(); + fp->fh_wchan = get_mntfs_wchan(mf); fp->fh_error = -1; - fp->fh_cid = timeout(FH_TTL, discard_fh, (voidp) fp); + fp->fh_cid = timeout(FH_TTL, discard_fh, (opaque_t) fp); /* - * if fs->fs_ip is null, remote server is probably down. + * If fs->fs_ip is null, remote server is probably down. */ if (!fs->fs_ip) { /* Mark the fileserver down and invalid again */ @@ -359,18 +457,25 @@ prime_nfs_fhandle_cache(char *path, fserver *fs, am_nfs_handle_t *fhbuf, voidp w } /* - * If the address has changed then don't try to re-use the - * port information + * Either fp has been freshly allocated or the address has changed. + * Initialize address and nfs version. Don't try to re-use the port + * information unless using WebNFS where the port is fixed either by + * the spec or the "port" mount option. */ if (fp->fh_sin.sin_addr.s_addr != fs->fs_ip->sin_addr.s_addr) { fp->fh_sin = *fs->fs_ip; - fp->fh_sin.sin_port = 0; + if (!(mf->mf_flags & MFF_WEBNFS)) + fp->fh_sin.sin_port = 0; fp->fh_nfs_version = fs->fs_version; } + fp->fh_fs = dup_srvr(fs); fp->fh_path = strdup(path); - error = call_mountd(fp, MOUNTPROC_MNT, got_nfs_fh, wchan); + if (mf->mf_flags & MFF_WEBNFS) + error = webnfs_lookup(fp, got_nfs_fh_webnfs, get_mntfs_wchan(mf)); + else + error = call_mountd(fp, MOUNTPROC_MNT, got_nfs_fh_mount, get_mntfs_wchan(mf)); if (error) { /* * Local error - cache for a short period @@ -378,7 +483,7 @@ prime_nfs_fhandle_cache(char *path, fserver *fs, am_nfs_handle_t *fhbuf, voidp w */ untimeout(fp->fh_cid); fp->fh_cid = timeout(error < 0 ? 2 * ALLOWED_MOUNT_TIME : FH_TTL_ERROR, - discard_fh, (voidp) fp); + discard_fh, (opaque_t) fp); fp->fh_error = error; } else { error = fp->fh_error; @@ -419,11 +524,11 @@ make_nfs_auth(void) static int -call_mountd(fh_cache *fp, u_long proc, fwd_fun f, voidp wchan) +call_mountd(fh_cache *fp, u_long proc, fwd_fun fun, wchan_t wchan) { struct rpc_msg mnt_msg; int len; - char iobuf[8192]; + char iobuf[UDPMSGSIZE]; int error; u_long mnt_version; @@ -434,17 +539,17 @@ call_mountd(fh_cache *fp, u_long proc, fwd_fun f, voidp wchan) } if (fp->fh_sin.sin_port == 0) { - u_short port; - error = nfs_srvr_port(fp->fh_fs, &port, wchan); + u_short mountd_port; + error = get_mountd_port(fp->fh_fs, &mountd_port, wchan); if (error) return error; - fp->fh_sin.sin_port = port; + fp->fh_sin.sin_port = mountd_port; } /* find the right version of the mount protocol */ #ifdef HAVE_FS_NFS3 if (fp->fh_nfs_version == NFS_VERSION3) - mnt_version = MOUNTVERS3; + mnt_version = AM_MOUNTVERS3; else #endif /* HAVE_FS_NFS3 */ mnt_version = MOUNTVERS; @@ -462,40 +567,128 @@ call_mountd(fh_cache *fp, u_long proc, fwd_fun f, voidp wchan) if (len > 0) { error = fwd_packet(MK_RPC_XID(RPC_XID_MOUNTD, fp->fh_id), - (voidp) iobuf, + iobuf, len, &fp->fh_sin, &fp->fh_sin, - (voidp) ((long) fp->fh_id), /* for 64-bit archs */ - f); + (opaque_t) ((long) fp->fh_id), /* cast to long needed for 64-bit archs */ + fun); } else { error = -len; } -/* - * It may be the case that we're sending to the wrong MOUNTD port. This - * occurs if mountd is restarted on the server after the port has been - * looked up and stored in the filehandle cache somewhere. The correct - * solution, if we're going to cache port numbers is to catch the ICMP - * port unreachable reply from the server and cause the portmap request - * to be redone. The quick solution here is to invalidate the MOUNTD - * port. - */ + /* + * It may be the case that we're sending to the wrong MOUNTD port. This + * occurs if mountd is restarted on the server after the port has been + * looked up and stored in the filehandle cache somewhere. The correct + * solution, if we're going to cache port numbers is to catch the ICMP + * port unreachable reply from the server and cause the portmap request + * to be redone. The quick solution here is to invalidate the MOUNTD + * port. + */ fp->fh_sin.sin_port = 0; return error; } +static int +webnfs_lookup(fh_cache *fp, fwd_fun fun, wchan_t wchan) +{ + struct rpc_msg wnfs_msg; + int len; + char iobuf[UDPMSGSIZE]; + int error; + u_long proc; + XDRPROC_T_TYPE xdr_fn; + voidp argp; + nfsdiropargs args; +#ifdef HAVE_FS_NFS3 + am_LOOKUP3args args3; +#endif + char *wnfs_path; + size_t l; + + if (!nfs_auth) { + error = make_nfs_auth(); + if (error) + return error; + } + + if (fp->fh_sin.sin_port == 0) { + /* FIXME: wrong, don't discard sin_port in the first place for WebNFS. */ + plog(XLOG_WARNING, "webnfs_lookup: port == 0 for nfs on %s, fixed", + fp->fh_fs->fs_host); + fp->fh_sin.sin_port = htons(NFS_PORT); + } + + /* + * Use native path like the rest of amd (cf. RFC 2054, 6.1). + */ + l = strlen(fp->fh_path) + 2; + wnfs_path = (char *) xmalloc(l); + wnfs_path[0] = 0x80; + xstrlcpy(wnfs_path + 1, fp->fh_path, l - 1); + + /* find the right program and lookup procedure */ +#ifdef HAVE_FS_NFS3 + if (fp->fh_nfs_version == NFS_VERSION3) { + proc = AM_NFSPROC3_LOOKUP; + xdr_fn = (XDRPROC_T_TYPE) xdr_am_LOOKUP3args; + argp = &args3; + /* WebNFS public file handle */ + args3.what.dir.am_fh3_length = 0; + args3.what.name = wnfs_path; + } else { +#endif /* HAVE_FS_NFS3 */ + proc = NFSPROC_LOOKUP; + xdr_fn = (XDRPROC_T_TYPE) xdr_diropargs; + argp = &args; + /* WebNFS public file handle */ + memset(&args.da_fhandle, 0, NFS_FHSIZE); + args.da_name = wnfs_path; +#ifdef HAVE_FS_NFS3 + } +#endif /* HAVE_FS_NFS3 */ + + plog(XLOG_INFO, "webnfs_lookup: NFS version %d", (int) fp->fh_nfs_version); + + rpc_msg_init(&wnfs_msg, NFS_PROGRAM, fp->fh_nfs_version, proc); + len = make_rpc_packet(iobuf, + sizeof(iobuf), + proc, + &wnfs_msg, + argp, + (XDRPROC_T_TYPE) xdr_fn, + nfs_auth); + + if (len > 0) { + error = fwd_packet(MK_RPC_XID(RPC_XID_WEBNFS, fp->fh_id), + iobuf, + len, + &fp->fh_sin, + &fp->fh_sin, + (opaque_t) ((long) fp->fh_id), /* cast to long needed for 64-bit archs */ + fun); + } else { + error = -len; + } + + XFREE(wnfs_path); + return error; +} + + /* * NFS needs the local filesystem, remote filesystem * remote hostname. * Local filesystem defaults to remote and vice-versa. */ -char * +static char * nfs_match(am_opts *fo) { char *xmtab; + size_t l; if (fo->opt_fs && !fo->opt_rfs) fo->opt_rfs = fo->opt_fs; @@ -511,12 +704,11 @@ nfs_match(am_opts *fo) /* * Determine magic cookie to put in mtab */ - xmtab = (char *) xmalloc(strlen(fo->opt_rhost) + strlen(fo->opt_rfs) + 2); - sprintf(xmtab, "%s:%s", fo->opt_rhost, fo->opt_rfs); -#ifdef DEBUG + l = strlen(fo->opt_rhost) + strlen(fo->opt_rfs) + 2; + xmtab = (char *) xmalloc(l); + xsnprintf(xmtab, l, "%s:%s", fo->opt_rhost, fo->opt_rfs); dlog("NFS: mounting remote server \"%s\", remote fs \"%s\" on \"%s\"", fo->opt_rhost, fo->opt_rfs, fo->opt_fs); -#endif /* DEBUG */ return xmtab; } @@ -525,24 +717,36 @@ nfs_match(am_opts *fo) /* * Initialize am structure for nfs */ -int +static int nfs_init(mntfs *mf) { int error; am_nfs_handle_t fhs; char *colon; - if (mf->mf_private) - return 0; + if (mf->mf_private) { + if (mf->mf_flags & MFF_NFS_SCALEDOWN) { + fserver *fs; + + /* tell remote mountd that we're done with this filehandle */ + mf->mf_ops->umounted(mf); + + mf->mf_prfree(mf->mf_private); + fs = mf->mf_ops->ffserver(mf); + free_srvr(mf->mf_server); + mf->mf_server = fs; + } else + return 0; + } colon = strchr(mf->mf_info, ':'); if (colon == 0) return ENOENT; - error = prime_nfs_fhandle_cache(colon + 1, mf->mf_server, &fhs, (voidp) mf); + error = prime_nfs_fhandle_cache(colon + 1, mf->mf_server, &fhs, mf); if (!error) { - mf->mf_private = (voidp) ALLOC(am_nfs_handle_t); - mf->mf_prfree = (void (*)(voidp)) free; + mf->mf_private = (opaque_t) ALLOC(am_nfs_handle_t); + mf->mf_prfree = (void (*)(opaque_t)) free; memmove(mf->mf_private, (voidp) &fhs, sizeof(fhs)); } return error; @@ -550,18 +754,20 @@ nfs_init(mntfs *mf) int -mount_nfs_fh(am_nfs_handle_t *fhp, char *dir, char *fs_name, char *opts, mntfs *mf) +mount_nfs_fh(am_nfs_handle_t *fhp, char *mntdir, char *fs_name, mntfs *mf) { MTYPE_TYPE type; char *colon; - char *xopts; + char *xopts=NULL, transp_timeo_opts[40], transp_retrans_opts[40]; char host[MAXHOSTNAMELEN + MAXPATHLEN + 2]; fserver *fs = mf->mf_server; u_long nfs_version = fs->fs_version; char *nfs_proto = fs->fs_proto; /* "tcp" or "udp" */ + int on_autofs = mf->mf_flags & MFF_ON_AUTOFS; int error; int genflags; int retry; + int proto = AMU_TYPE_NONE; mntent_t mnt; nfs_args_t nfs_args; @@ -575,26 +781,48 @@ mount_nfs_fh(am_nfs_handle_t *fhp, char *dir, char *fs_name, char *opts, mntfs * #ifdef MOUNT_TABLE_ON_FILE *colon = '\0'; #endif /* MOUNT_TABLE_ON_FILE */ - strncpy(host, fs_name, sizeof(host)); + xstrlcpy(host, fs_name, sizeof(host)); #ifdef MOUNT_TABLE_ON_FILE *colon = ':'; #endif /* MOUNT_TABLE_ON_FILE */ #ifdef MAXHOSTNAMELEN /* most kernels have a name length restriction */ if (strlen(host) >= MAXHOSTNAMELEN) - strcpy(host + MAXHOSTNAMELEN - 3, ".."); + xstrlcpy(host + MAXHOSTNAMELEN - 3, "..", + sizeof(host) - MAXHOSTNAMELEN + 3); #endif /* MAXHOSTNAMELEN */ + /* + * Create option=VAL for udp/tcp specific timeouts and retrans values, but + * only if these options were specified. + */ + + transp_timeo_opts[0] = transp_retrans_opts[0] = '\0'; /* initialize */ + if (STREQ(nfs_proto, "udp")) + proto = AMU_TYPE_UDP; + else if (STREQ(nfs_proto, "tcp")) + proto = AMU_TYPE_TCP; + if (proto != AMU_TYPE_NONE) { + if (gopt.amfs_auto_timeo[proto] > 0) + xsnprintf(transp_timeo_opts, sizeof(transp_timeo_opts), "%s=%d,", + MNTTAB_OPT_TIMEO, gopt.amfs_auto_timeo[proto]); + if (gopt.amfs_auto_retrans[proto] > 0) + xsnprintf(transp_retrans_opts, sizeof(transp_retrans_opts), "%s=%d,", + MNTTAB_OPT_RETRANS, gopt.amfs_auto_retrans[proto]); + } + if (mf->mf_remopts && *mf->mf_remopts && !islocalnet(fs->fs_ip->sin_addr.s_addr)) { plog(XLOG_INFO, "Using remopts=\"%s\"", mf->mf_remopts); - xopts = strdup(mf->mf_remopts); + /* use transp_opts first, so map-specific opts will override */ + xopts = str3cat(xopts, transp_timeo_opts, transp_retrans_opts, mf->mf_remopts); } else { - xopts = strdup(opts); + /* use transp_opts first, so map-specific opts will override */ + xopts = str3cat(xopts, transp_timeo_opts, transp_retrans_opts, mf->mf_mopts); } memset((voidp) &mnt, 0, sizeof(mnt)); - mnt.mnt_dir = dir; + mnt.mnt_dir = mntdir; mnt.mnt_fsname = fs_name; mnt.mnt_opts = xopts; @@ -626,18 +854,19 @@ mount_nfs_fh(am_nfs_handle_t *fhp, char *dir, char *fs_name, char *opts, mntfs * } #endif /* HAVE_FS_NFS3 */ plog(XLOG_INFO, "mount_nfs_fh: NFS version %d", (int) nfs_version); -#if defined(HAVE_FS_NFS3) || defined(HAVE_TRANSPORT_TYPE_TLI) plog(XLOG_INFO, "mount_nfs_fh: using NFS transport %s", nfs_proto); -#endif /* defined(HAVE_FS_NFS3) || defined(HAVE_TRANSPORT_TYPE_TLI) */ retry = hasmntval(&mnt, MNTTAB_OPT_RETRY); if (retry <= 0) retry = 1; /* XXX */ genflags = compute_mount_flags(&mnt); +#ifdef HAVE_FS_AUTOFS + if (on_autofs) + genflags |= autofs_compute_mount_flags(&mnt); +#endif /* HAVE_FS_AUTOFS */ /* setup the many fields and flags within nfs_args */ -#ifdef HAVE_TRANSPORT_TYPE_TLI compute_nfs_args(&nfs_args, &mnt, genflags, @@ -648,27 +877,14 @@ mount_nfs_fh(am_nfs_handle_t *fhp, char *dir, char *fs_name, char *opts, mntfs * fhp, host, fs_name); -#else /* not HAVE_TRANSPORT_TYPE_TLI */ - compute_nfs_args(&nfs_args, - &mnt, - genflags, - fs->fs_ip, - nfs_version, - nfs_proto, - fhp, - host, - fs_name); -#endif /* not HAVE_TRANSPORT_TYPE_TLI */ /* finally call the mounting function */ -#ifdef DEBUG - amuDebug(D_TRACE) { + if (amuDebug(D_TRACE)) { print_nfs_args(&nfs_args, nfs_version); plog(XLOG_DEBUG, "Generic mount flags 0x%x used for NFS mount", genflags); } -#endif /* DEBUG */ error = mount_fs(&mnt, genflags, (caddr_t) &nfs_args, retry, type, - nfs_version, nfs_proto, mnttab_file_name); + nfs_version, nfs_proto, mnttab_file_name, on_autofs); XFREE(xopts); #ifdef HAVE_TRANSPORT_TYPE_TLI @@ -682,39 +898,62 @@ mount_nfs_fh(am_nfs_handle_t *fhp, char *dir, char *fs_name, char *opts, mntfs * static int -mount_nfs(char *dir, char *fs_name, char *opts, mntfs *mf) +nfs_mount(am_node *am, mntfs *mf) { + int error = 0; + mntent_t mnt; + if (!mf->mf_private) { - plog(XLOG_ERROR, "Missing filehandle for %s", fs_name); + plog(XLOG_ERROR, "Missing filehandle for %s", mf->mf_info); return EINVAL; } - return mount_nfs_fh((am_nfs_handle_t *) mf->mf_private, dir, fs_name, opts, mf); -} + mnt.mnt_opts = mf->mf_mopts; + if (amu_hasmntopt(&mnt, "softlookup") || + (amu_hasmntopt(&mnt, "soft") && !amu_hasmntopt(&mnt, "nosoftlookup"))) + am->am_flags |= AMF_SOFTLOOKUP; + error = mount_nfs_fh((am_nfs_handle_t *) mf->mf_private, + mf->mf_mount, + mf->mf_info, + mf); -int -nfs_fmount(mntfs *mf) -{ - int error = 0; - - error = mount_nfs(mf->mf_mount, mf->mf_info, mf->mf_mopts, mf); - -#ifdef DEBUG if (error) { errno = error; dlog("mount_nfs: %m"); } -#endif /* DEBUG */ return error; } -int -nfs_fumount(mntfs *mf) +static int +nfs_umount(am_node *am, mntfs *mf) { - int error = UMOUNT_FS(mf->mf_mount, mnttab_file_name); + int unmount_flags, new_unmount_flags, error; + + unmount_flags = (mf->mf_flags & MFF_ON_AUTOFS) ? AMU_UMOUNT_AUTOFS : 0; + error = UMOUNT_FS(mf->mf_mount, mnttab_file_name, unmount_flags); + +#if defined(HAVE_UMOUNT2) && (defined(MNT2_GEN_OPT_FORCE) || defined(MNT2_GEN_OPT_DETACH)) + /* + * If the attempt to unmount failed with EBUSY, and this fserver was + * marked for forced unmounts, then use forced/lazy unmounts. + */ + if (error == EBUSY && + gopt.flags & CFM_FORCED_UNMOUNTS && + mf->mf_server->fs_flags & FSF_FORCE_UNMOUNT) { + plog(XLOG_INFO, "EZK: nfs_umount: trying forced/lazy unmounts"); + /* + * XXX: turning off the FSF_FORCE_UNMOUNT may not be perfectly + * incorrect. Multiple nodes may need to be timed out and restarted for + * a single hung fserver. + */ + mf->mf_server->fs_flags &= ~FSF_FORCE_UNMOUNT; + new_unmount_flags = unmount_flags | AMU_UMOUNT_FORCE | AMU_UMOUNT_DETACH; + error = UMOUNT_FS(mf->mf_mount, mnttab_file_name, new_unmount_flags); + } +#endif /* HAVE_UMOUNT2 && (MNT2_GEN_OPT_FORCE || MNT2_GEN_OPT_DETACH) */ /* * Here is some code to unmount 'restarted' file systems. @@ -743,12 +982,14 @@ nfs_fumount(mntfs *mf) if (NSTREQ(mf->mf_mount, new_mf->mf_mount, len) && new_mf->mf_mount[len] == '/') { - UMOUNT_FS(new_mf->mf_mount, mnttab_file_name); + new_unmount_flags = + (new_mf->mf_flags & MFF_ON_AUTOFS) ? AMU_UMOUNT_AUTOFS : 0; + UMOUNT_FS(new_mf->mf_mount, mnttab_file_name, new_unmount_flags); didsome = 1; } } if (didsome) - error = UMOUNT_FS(mf->mf_mount, mnttab_file_name); + error = UMOUNT_FS(mf->mf_mount, mnttab_file_name, unmount_flags); } if (error) return error; @@ -757,38 +998,35 @@ nfs_fumount(mntfs *mf) } -void -nfs_umounted(am_node *mp) +static void +nfs_umounted(mntfs *mf) { - /* - * Don't bother to inform remote mountd that we are finished. Until a - * full track of filehandles is maintained the mountd unmount callback - * cannot be done correctly anyway... - */ - mntfs *mf = mp->am_mnt; fserver *fs; char *colon, *path; if (mf->mf_error || mf->mf_refc > 1) return; - fs = mf->mf_server; + /* + * No need to inform mountd when WebNFS is in use. + */ + if (mf->mf_flags & MFF_WEBNFS) + return; /* * Call the mount daemon on the server to announce that we are not using * the fs any more. * - * This is *wrong*. The mountd should be called when the fhandle is + * XXX: This is *wrong*. The mountd should be called when the fhandle is * flushed from the cache, and a reference held to the cached entry while * the fs is mounted... */ + fs = mf->mf_server; colon = path = strchr(mf->mf_info, ':'); if (fs && colon) { fh_cache f; -#ifdef DEBUG dlog("calling mountd for %s", mf->mf_info); -#endif /* DEBUG */ *path++ = '\0'; f.fh_path = path; f.fh_sin = *fs->fs_ip; @@ -797,8 +1035,8 @@ nfs_umounted(am_node *mp) f.fh_fs = fs; f.fh_id = 0; f.fh_error = 0; - prime_nfs_fhandle_cache(colon + 1, mf->mf_server, (am_nfs_handle_t *) 0, (voidp) mf); - call_mountd(&f, MOUNTPROC_UMNT, (fwd_fun) 0, (voidp) 0); + prime_nfs_fhandle_cache(colon + 1, mf->mf_server, (am_nfs_handle_t *) 0, mf); + call_mountd(&f, MOUNTPROC_UMNT, (fwd_fun *) 0, (wchan_t) 0); *colon = ':'; } } diff --git a/contrib/amd/amd/ops_nfs3.c b/contrib/amd/amd/ops_nfs3.c index 8da2cb13cd35..db3c7f9d265d 100644 --- a/contrib/amd/amd/ops_nfs3.c +++ b/contrib/amd/amd/ops_nfs3.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: ops_nfs3.c,v 1.3.2.4 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/ops_nfs3.c * */ diff --git a/contrib/amd/amd/ops_nullfs.c b/contrib/amd/amd/ops_nullfs.c index 0ecb1a9a7073..cf621ec33ff5 100644 --- a/contrib/amd/amd/ops_nullfs.c +++ b/contrib/amd/amd/ops_nullfs.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: ops_nullfs.c,v 1.3.2.4 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/ops_nullfs.c * */ diff --git a/contrib/amd/amd/ops_pcfs.c b/contrib/amd/amd/ops_pcfs.c index f148e6d5e511..527dc926ca77 100644 --- a/contrib/amd/amd/ops_pcfs.c +++ b/contrib/amd/amd/ops_pcfs.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: ops_pcfs.c,v 1.3.2.5 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/ops_pcfs.c * */ @@ -54,8 +53,8 @@ /* forward definitions */ static char *pcfs_match(am_opts *fo); -static int pcfs_fmount(mntfs *mf); -static int pcfs_fumount(mntfs *mf); +static int pcfs_mount(am_node *am, mntfs *mf); +static int pcfs_umount(am_node *am, mntfs *mf); /* * Ops structure @@ -65,17 +64,20 @@ am_ops pcfs_ops = "pcfs", pcfs_match, 0, /* pcfs_init */ - amfs_auto_fmount, - pcfs_fmount, - amfs_auto_fumount, - pcfs_fumount, - amfs_error_lookuppn, + pcfs_mount, + pcfs_umount, + amfs_error_lookup_child, + amfs_error_mount_child, amfs_error_readdir, 0, /* pcfs_readlink */ 0, /* pcfs_mounted */ 0, /* pcfs_umounted */ - find_amfs_auto_srvr, - FS_MKMNT | FS_UBACKGROUND | FS_AMQINFO + amfs_generic_find_srvr, + 0, /* pcfs_get_wchan */ + FS_MKMNT | FS_UBACKGROUND | FS_AMQINFO, /* nfs_fs_flags */ +#ifdef HAVE_FS_AUTOFS + AUTOFS_PCFS_FS_FLAGS, +#endif /* HAVE_FS_AUTOFS */ }; @@ -90,9 +92,7 @@ pcfs_match(am_opts *fo) plog(XLOG_USER, "pcfs: no source device specified"); return 0; } -#ifdef DEBUG dlog("PCFS: mounting device \"%s\" on \"%s\"", fo->opt_dev, fo->opt_fs); -#endif /* DEBUG */ /* * Determine magic cookie to put in mtab @@ -102,11 +102,17 @@ pcfs_match(am_opts *fo) static int -mount_pcfs(char *dir, char *fs_name, char *opts) +mount_pcfs(char *mntdir, char *fs_name, char *opts, int on_autofs) { pcfs_args_t pcfs_args; mntent_t mnt; int flags; +#if defined(HAVE_PCFS_ARGS_T_MASK) || defined(HAVE_PCFS_ARGS_T_DIRMASK) + int mask; +#endif /* defined(HAVE_PCFS_ARGS_T_MASK) || defined(HAVE_PCFS_ARGS_T_DIRMASK) */ +#if defined(HAVE_PCFS_ARGS_T_UID) || defined(HAVE_PCFS_ARGS_T_UID) + char *str; +#endif /* defined(HAVE_PCFS_ARGS_T_UID) || defined(HAVE_PCFS_ARGS_T_UID) */ /* * Figure out the name of the file system type. @@ -119,12 +125,18 @@ mount_pcfs(char *dir, char *fs_name, char *opts) * Fill in the mount structure */ memset((voidp) &mnt, 0, sizeof(mnt)); - mnt.mnt_dir = dir; + mnt.mnt_dir = mntdir; mnt.mnt_fsname = fs_name; mnt.mnt_type = MNTTAB_TYPE_PCFS; mnt.mnt_opts = opts; flags = compute_mount_flags(&mnt); +#ifdef HAVE_FS_AUTOFS + if (on_autofs) + flags |= autofs_compute_mount_flags(&mnt); +#endif /* HAVE_FS_AUTOFS */ + if (amuDebug(D_TRACE)) + plog(XLOG_DEBUG, "mount_pcfs: flags=0x%x", (u_int) flags); #ifdef HAVE_PCFS_ARGS_T_FSPEC pcfs_args.fspec = fs_name; @@ -132,14 +144,46 @@ mount_pcfs(char *dir, char *fs_name, char *opts) #ifdef HAVE_PCFS_ARGS_T_MASK pcfs_args.mask = 0777; /* this may be the msdos file modes */ + if ((mask = hasmntval(&mnt, MNTTAB_OPT_MASK)) > 0) + pcfs_args.mask = mask; + if (amuDebug(D_TRACE)) + plog(XLOG_DEBUG, "mount_pcfs: mask=%o (octal)", (u_int) pcfs_args.mask); #endif /* HAVE_PCFS_ARGS_T_MASK */ +#ifdef HAVE_PCFS_ARGS_T_DIRMASK + pcfs_args.dirmask = 0777; /* this may be the msdos dir modes */ + if ((mask = hasmntval(&mnt, MNTTAB_OPT_DIRMASK)) > 0) + pcfs_args.dirmask = mask; + if (amuDebug(D_TRACE)) + plog(XLOG_DEBUG, "mount_pcfs: dirmask=%o (octal)", (u_int) pcfs_args.dirmask); +#endif /* HAVE_PCFS_ARGS_T_DIRMASK */ + #ifdef HAVE_PCFS_ARGS_T_UID - pcfs_args.uid = 0; /* root */ + pcfs_args.uid = 0; /* default to root */ + if ((str = hasmntstr(&mnt, MNTTAB_OPT_USER)) != NULL) { + struct passwd *pw; + if ((pw = getpwnam(str)) != NULL) + pcfs_args.uid = pw->pw_uid; + else /* maybe used passed a UID number, not user name */ + pcfs_args.uid = atoi(str); /* atoi returns '0' if it failed */ + XFREE(str); + } + if (amuDebug(D_TRACE)) + plog(XLOG_DEBUG, "mount_pcfs: uid=%d", (int) pcfs_args.uid); #endif /* HAVE_PCFS_ARGS_T_UID */ #ifdef HAVE_PCFS_ARGS_T_GID - pcfs_args.gid = 0; /* wheel */ + pcfs_args.gid = 0; /* default to wheel/root group */ + if ((str = hasmntstr(&mnt, MNTTAB_OPT_GROUP)) != NULL) { + struct group *gr; + if ((gr = getgrnam(str)) != NULL) + pcfs_args.gid = gr->gr_gid; + else /* maybe used passed a GID number, not group name */ + pcfs_args.gid = atoi(str); /* atoi returns '0' if it failed */ + XFREE(str); + } + if (amuDebug(D_TRACE)) + plog(XLOG_DEBUG, "mount_pcfs: gid=%d", (int) pcfs_args.gid); #endif /* HAVE_PCFS_ARGS_T_GID */ #ifdef HAVE_PCFS_ARGS_T_SECONDSWEST @@ -152,16 +196,17 @@ mount_pcfs(char *dir, char *fs_name, char *opts) /* * Call generic mount routine */ - return mount_fs(&mnt, flags, (caddr_t) & pcfs_args, 0, type, 0, NULL, mnttab_file_name); + return mount_fs(&mnt, flags, (caddr_t) & pcfs_args, 0, type, 0, NULL, mnttab_file_name, on_autofs); } static int -pcfs_fmount(mntfs *mf) +pcfs_mount(am_node *am, mntfs *mf) { + int on_autofs = mf->mf_flags & MFF_ON_AUTOFS; int error; - error = mount_pcfs(mf->mf_mount, mf->mf_info, mf->mf_mopts); + error = mount_pcfs(mf->mf_mount, mf->mf_info, mf->mf_mopts, on_autofs); if (error) { errno = error; plog(XLOG_ERROR, "mount_pcfs: %m"); @@ -173,7 +218,9 @@ pcfs_fmount(mntfs *mf) static int -pcfs_fumount(mntfs *mf) +pcfs_umount(am_node *am, mntfs *mf) { - return UMOUNT_FS(mf->mf_mount, mnttab_file_name); + int unmount_flags = (mf->mf_flags & MFF_ON_AUTOFS) ? AMU_UMOUNT_AUTOFS : 0; + + return UMOUNT_FS(mf->mf_mount, mnttab_file_name, unmount_flags); } diff --git a/contrib/amd/amd/ops_tfs.c b/contrib/amd/amd/ops_tfs.c index 911c01c4474f..142c32022937 100644 --- a/contrib/amd/amd/ops_tfs.c +++ b/contrib/amd/amd/ops_tfs.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: ops_tfs.c,v 1.3.2.4 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/ops_tfs.c * */ diff --git a/contrib/amd/amd/ops_tmpfs.c b/contrib/amd/amd/ops_tmpfs.c index ca2d515f0515..eddd75569e9e 100644 --- a/contrib/amd/amd/ops_tmpfs.c +++ b/contrib/amd/amd/ops_tmpfs.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: ops_tmpfs.c,v 1.3.2.4 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/ops_tmpfs.c * */ diff --git a/contrib/amd/amd/ops_ufs.c b/contrib/amd/amd/ops_ufs.c index 999a66918d4e..fd82a5cd2228 100644 --- a/contrib/amd/amd/ops_ufs.c +++ b/contrib/amd/amd/ops_ufs.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: ops_ufs.c,v 1.3.2.5 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/ops_ufs.c * */ @@ -54,8 +53,8 @@ /* forward declarations */ static char *ufs_match(am_opts *fo); -static int ufs_fmount(mntfs *mf); -static int ufs_fumount(mntfs *mf); +static int ufs_mount(am_node *am, mntfs *mf); +static int ufs_umount(am_node *am, mntfs *mf); /* * Ops structure @@ -65,17 +64,20 @@ am_ops ufs_ops = "ufs", ufs_match, 0, /* ufs_init */ - amfs_auto_fmount, - ufs_fmount, - amfs_auto_fumount, - ufs_fumount, - amfs_error_lookuppn, + ufs_mount, + ufs_umount, + amfs_error_lookup_child, + amfs_error_mount_child, amfs_error_readdir, 0, /* ufs_readlink */ 0, /* ufs_mounted */ 0, /* ufs_umounted */ - find_amfs_auto_srvr, - FS_MKMNT | FS_NOTIMEOUT | FS_UBACKGROUND | FS_AMQINFO + amfs_generic_find_srvr, + 0, /* ufs_get_wchan */ + FS_MKMNT | FS_NOTIMEOUT | FS_UBACKGROUND | FS_AMQINFO, /* nfs_fs_flags */ +#ifdef HAVE_FS_AUTOFS + AUTOFS_UFS_FS_FLAGS, +#endif /* HAVE_FS_AUTOFS */ }; @@ -91,9 +93,7 @@ ufs_match(am_opts *fo) return 0; } -#ifdef DEBUG dlog("UFS: mounting device \"%s\" on \"%s\"", fo->opt_dev, fo->opt_fs); -#endif /* DEBUG */ /* * Determine magic cookie to put in mtab @@ -103,7 +103,7 @@ ufs_match(am_opts *fo) static int -mount_ufs(char *dir, char *fs_name, char *opts) +mount_ufs(char *mntdir, char *fs_name, char *opts, int on_autofs) { ufs_args_t ufs_args; mntent_t mnt; @@ -120,12 +120,16 @@ mount_ufs(char *dir, char *fs_name, char *opts) * Fill in the mount structure */ memset((voidp) &mnt, 0, sizeof(mnt)); - mnt.mnt_dir = dir; + mnt.mnt_dir = mntdir; mnt.mnt_fsname = fs_name; mnt.mnt_type = MNTTAB_TYPE_UFS; mnt.mnt_opts = opts; genflags = compute_mount_flags(&mnt); +#ifdef HAVE_FS_AUTOFS + if (on_autofs) + genflags |= autofs_compute_mount_flags(&mnt); +#endif /* HAVE_FS_AUTOFS */ #ifdef HAVE_UFS_ARGS_T_FLAGS ufs_args.flags = genflags; /* XXX: is this correct? */ @@ -146,16 +150,17 @@ mount_ufs(char *dir, char *fs_name, char *opts) /* * Call generic mount routine */ - return mount_fs(&mnt, genflags, (caddr_t) &ufs_args, 0, type, 0, NULL, mnttab_file_name); + return mount_fs(&mnt, genflags, (caddr_t) &ufs_args, 0, type, 0, NULL, mnttab_file_name, on_autofs); } static int -ufs_fmount(mntfs *mf) +ufs_mount(am_node *am, mntfs *mf) { + int on_autofs = mf->mf_flags & MFF_ON_AUTOFS; int error; - error = mount_ufs(mf->mf_mount, mf->mf_info, mf->mf_mopts); + error = mount_ufs(mf->mf_mount, mf->mf_info, mf->mf_mopts, on_autofs); if (error) { errno = error; plog(XLOG_ERROR, "mount_ufs: %m"); @@ -167,7 +172,9 @@ ufs_fmount(mntfs *mf) static int -ufs_fumount(mntfs *mf) +ufs_umount(am_node *am, mntfs *mf) { - return UMOUNT_FS(mf->mf_mount, mnttab_file_name); + int unmount_flags = (mf->mf_flags & MFF_ON_AUTOFS) ? AMU_UMOUNT_AUTOFS : 0; + + return UMOUNT_FS(mf->mf_mount, mnttab_file_name, unmount_flags); } diff --git a/contrib/amd/amd/ops_umapfs.c b/contrib/amd/amd/ops_umapfs.c index 65e99cbf9583..5ba735e39c61 100644 --- a/contrib/amd/amd/ops_umapfs.c +++ b/contrib/amd/amd/ops_umapfs.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: ops_umapfs.c,v 1.3.2.4 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/ops_umapfs.c * */ diff --git a/contrib/amd/amd/ops_unionfs.c b/contrib/amd/amd/ops_unionfs.c index 52059a017472..73f8d6676203 100644 --- a/contrib/amd/amd/ops_unionfs.c +++ b/contrib/amd/amd/ops_unionfs.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: ops_unionfs.c,v 1.3.2.4 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/ops_unionfs.c * */ diff --git a/contrib/amd/amd/ops_xfs.c b/contrib/amd/amd/ops_xfs.c index 4c9010bab731..e0e740bc0a0e 100644 --- a/contrib/amd/amd/ops_xfs.c +++ b/contrib/amd/amd/ops_xfs.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: ops_xfs.c,v 1.3.2.6 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/ops_xfs.c * */ @@ -54,8 +53,8 @@ /* forward declarations */ static char *xfs_match(am_opts *fo); -static int xfs_fmount(mntfs *mf); -static int xfs_fumount(mntfs *mf); +static int xfs_mount(am_node *am, mntfs *mf); +static int xfs_umount(am_node *am, mntfs *mf); /* * Ops structure @@ -65,17 +64,20 @@ am_ops xfs_ops = "xfs", xfs_match, 0, /* xfs_init */ - amfs_auto_fmount, - xfs_fmount, - amfs_auto_fumount, - xfs_fumount, - amfs_error_lookuppn, + xfs_mount, + xfs_umount, + amfs_error_lookup_child, + amfs_error_mount_child, amfs_error_readdir, 0, /* xfs_readlink */ 0, /* xfs_mounted */ 0, /* xfs_umounted */ - find_amfs_auto_srvr, - FS_MKMNT | FS_NOTIMEOUT | FS_UBACKGROUND | FS_AMQINFO + amfs_generic_find_srvr, + 0, /* xfs_get_wchan */ + FS_MKMNT | FS_NOTIMEOUT | FS_UBACKGROUND | FS_AMQINFO, /* nfs_fs_flags */ +#ifdef HAVE_FS_AUTOFS + AUTOFS_XFS_FS_FLAGS, +#endif /* HAVE_FS_AUTOFS */ }; @@ -91,9 +93,7 @@ xfs_match(am_opts *fo) return 0; } -#ifdef DEBUG dlog("XFS: mounting device \"%s\" on \"%s\"", fo->opt_dev, fo->opt_fs); -#endif /* DEBUG */ /* * Determine magic cookie to put in mtab @@ -103,7 +103,7 @@ xfs_match(am_opts *fo) static int -mount_xfs(char *dir, char *fs_name, char *opts) +mount_xfs(char *mntdir, char *fs_name, char *opts, int on_autofs) { xfs_args_t xfs_args; mntent_t mnt; @@ -120,12 +120,16 @@ mount_xfs(char *dir, char *fs_name, char *opts) * Fill in the mount structure */ memset((voidp) &mnt, 0, sizeof(mnt)); - mnt.mnt_dir = dir; + mnt.mnt_dir = mntdir; mnt.mnt_fsname = fs_name; mnt.mnt_type = MNTTAB_TYPE_XFS; mnt.mnt_opts = opts; flags = compute_mount_flags(&mnt); +#ifdef HAVE_FS_AUTOFS + if (on_autofs) + flags |= autofs_compute_mount_flags(&mnt); +#endif /* HAVE_FS_AUTOFS */ #ifdef HAVE_XFS_ARGS_T_FLAGS xfs_args.flags = 0; /* XXX: fix this to correct flags */ @@ -137,16 +141,17 @@ mount_xfs(char *dir, char *fs_name, char *opts) /* * Call generic mount routine */ - return mount_fs(&mnt, flags, (caddr_t) &xfs_args, 0, type, 0, NULL, mnttab_file_name); + return mount_fs(&mnt, flags, (caddr_t) &xfs_args, 0, type, 0, NULL, mnttab_file_name, on_autofs); } static int -xfs_fmount(mntfs *mf) +xfs_mount(am_node *am, mntfs *mf) { + int on_autofs = mf->mf_flags & MFF_ON_AUTOFS; int error; - error = mount_xfs(mf->mf_mount, mf->mf_info, mf->mf_mopts); + error = mount_xfs(mf->mf_mount, mf->mf_info, mf->mf_mopts, on_autofs); if (error) { errno = error; plog(XLOG_ERROR, "mount_xfs: %m"); @@ -158,7 +163,9 @@ xfs_fmount(mntfs *mf) static int -xfs_fumount(mntfs *mf) +xfs_umount(am_node *am, mntfs *mf) { - return UMOUNT_FS(mf->mf_mount, mnttab_file_name); + int unmount_flags = (mf->mf_flags & MFF_ON_AUTOFS) ? AMU_UMOUNT_AUTOFS : 0; + + return UMOUNT_FS(mf->mf_mount, mnttab_file_name, unmount_flags); } diff --git a/contrib/amd/amd/opts.c b/contrib/amd/amd/opts.c index 92bceb21804d..a3d35343adc0 100644 --- a/contrib/amd/amd/opts.c +++ b/contrib/amd/amd/opts.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: opts.c,v 1.8.2.7 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/opts.c * */ @@ -94,11 +93,13 @@ struct functable { * FORWARD DEFINITION: */ static int f_in_network(char *); +static int f_xhost(char *); static int f_netgrp(char *); static int f_netgrpd(char *); static int f_exists(char *); static int f_false(char *); static int f_true(char *); +static inline char *expand_options(char *key); /* * STATICS: @@ -112,7 +113,7 @@ static char *opt_key = nullstr; static char *opt_keyd = nullstr; static char *opt_map = nullstr; static char *opt_path = nullstr; -static char uid_str[12], gid_str[12]; +char uid_str[SIZEOF_UID_STR], gid_str[SIZEOF_GID_STR]; char *opt_uid = uid_str; char *opt_gid = gid_str; static char *vars[8]; @@ -121,11 +122,11 @@ static char *literal_dollar = "$"; /* ${dollar}: a literal '$' in maps */ /* * GLOBALS */ -struct am_opts fs_static; /* copy of the options to play with */ +static struct am_opts fs_static; /* copy of the options to play with */ /* - * Options in something corresponding to frequency of use so that + * Options in some order corresponding to frequency of use so that * first-match algorithm is sped up. */ static struct opt opt_fields[] = { @@ -191,6 +192,8 @@ static struct opt opt_fields[] = { &fs_static.opt_mount, 0, 0, FALSE }, { S("unmount"), &fs_static.opt_unmount, 0, 0, FALSE }, + { S("umount"), + &fs_static.opt_umount, 0, 0, FALSE }, { S("cache"), &fs_static.opt_cache, 0, 0, FALSE }, { S("user"), @@ -201,7 +204,6 @@ static struct opt opt_fields[] = { 0, &opt_dkey, 0, FALSE }, { S("key."), 0, &opt_keyd, 0, FALSE }, - /* XXX: should maptype really be a variable? I think selector. -Erez */ { S("maptype"), &fs_static.opt_maptype, 0, 0, FALSE }, { S("cachedir"), @@ -212,6 +214,8 @@ static struct opt opt_fields[] = { 0, &opt_uid, 0, FALSE }, { S("gid"), 0, &opt_gid, 0, FALSE }, + { S("mount_type"), + &fs_static.opt_mount_type, 0, 0, FALSE }, { S("dollar"), &literal_dollar, 0, 0, FALSE }, { S("var0"), @@ -235,6 +239,7 @@ static struct opt opt_fields[] = { static struct functable functable[] = { { "in_network", f_in_network }, + { "xhost", f_xhost }, { "netgrp", f_netgrp }, { "netgrpd", f_netgrpd }, { "exists", f_exists }, @@ -265,6 +270,7 @@ static opt_apply expansions[] = {&fs_static.opt_remopts, "${opts}"}, {&fs_static.opt_mount, 0}, {&fs_static.opt_unmount, 0}, + {&fs_static.opt_umount, 0}, {&fs_static.opt_cachedir, 0}, {&fs_static.opt_addopts, 0}, {0, 0}, @@ -286,6 +292,7 @@ static opt_apply to_free[] = {&fs_static.opt_remopts, 0}, {&fs_static.opt_mount, 0}, {&fs_static.opt_unmount, 0}, + {&fs_static.opt_umount, 0}, {&fs_static.opt_cachedir, 0}, {&fs_static.opt_addopts, 0}, {&vars[0], 0}, @@ -302,6 +309,7 @@ static opt_apply to_free[] = /* * expand backslash escape sequences + * (escaped slash is handled separately in normalize_slash) */ static char backslash(char **p) @@ -457,33 +465,99 @@ functable_lookup(char *key) } +/* + * Fill in the global structure fs_static by + * cracking the string opts. opts may be + * scribbled on at will. Does NOT evaluate options. + * Returns 0 on error, 1 if no syntax errors were discovered. + */ static int -eval_opts(char *opts, char *mapkey) +split_opts(char *opts, char *mapkey) { + char *o = opts; + char *f; + /* - * Fill in the global structure fs_static by - * cracking the string opts. opts may be - * scribbled on at will. + * For each user-specified option */ - char *o = opts; + for (f = opt(&o); *f; f = opt(&o)) { + struct opt *op; + char *eq = strchr(f, '='); + char *opt = NULL; + + if (!eq) + continue; + + if (*(eq-1) == '!' || + eq[1] == '=' || + eq[1] == '!') { /* != or == or =! */ + continue; /* we don't care about selectors */ + } + + if (*(eq-1) == ':') { /* := */ + *(eq-1) = '\0'; + } else { + /* old style assignment */ + eq[0] = '\0'; + } + opt = eq + 1; + + /* + * For each recognized option + */ + for (op = opt_fields; op->name; op++) { + /* + * Check whether they match + */ + if (FSTREQ(op->name, f)) { + if (op->sel_p) { + plog(XLOG_USER, "key %s: Can't assign to a selector (%s)", + mapkey, op->name); + return 0; + } + *op->optp = opt; /* actual assignment into fs_static */ + break; /* break out of for loop */ + } /* end of "if (FSTREQ(op->name, f))" statement */ + } /* end of "for (op = opt_fields..." statement */ + + if (!op->name) + plog(XLOG_USER, "key %s: Unrecognized key/option \"%s\"", mapkey, f); + } + + return 1; +} + + +/* + * Just evaluate selectors, which were split by split_opts. + * Returns 0 on error or no match, 1 if matched. + */ +static int +eval_selectors(char *opts, char *mapkey) +{ + char *o, *old_o; char *f; + int ret = 0; + + o = old_o = strdup(opts); /* * For each user-specified option */ - while (*(f = opt(&o))) { + for (f = opt(&o); *f; f = opt(&o)) { struct opt *op; - enum vs_opt vs_opt = VarAss; + enum vs_opt vs_opt; char *eq = strchr(f, '='); char *fx; IntFuncPtr func; char *opt = NULL; + char *arg; - if (!eq || eq[1] == '\0' || eq == f) { + if (!eq) { /* * No value, is it a function call? */ - char *arg = strchr(f, '('); + arg = strchr(f, '('); if (!arg || arg[1] == '\0' || arg == f) { /* @@ -502,43 +576,54 @@ eval_opts(char *opts, char *mapkey) } *fx = '\0'; + if (f[0] == '!') { + vs_opt = SelNE; + f++; + } else { + vs_opt = SelEQ; + } /* * look up f in functable and pass it arg. * func must return 0 on failure, and 1 on success. */ if ((func = functable_lookup(f))) { - if (!(*func) (arg)) { - return (0); - } - continue; - } else if (NSTREQ(f, "!", 1) && (func = functable_lookup(&f[1]))) { - /* then this is a negated prefixed function such as "!exists" */ - plog(XLOG_INFO, "executing negated function %s", &f[1]); - if ((*func) (arg)) { - return (0); - } + int funok; + + /* this allocates memory, don't forget to free */ + arg = expand_options(arg); + funok = func(arg); + XFREE(arg); + + if (vs_opt == SelNE) + funok = !funok; + if (!funok) + goto out; + continue; } else { plog(XLOG_USER, "key %s: unknown function \"%s\"", mapkey, f); - return (0); + goto out; + } + } else { + if (eq[1] == '\0' || eq == f) { + /* misformed selector */ + plog(XLOG_USER, "key %s: Bad selector \"%s\"", mapkey, f); + continue; } - } /* * Check what type of operation is happening * !=, =! is SelNE * == is SelEQ - * := is VarAss + * =, := is VarAss */ - if (eq[-1] == '!') { /* != */ + if (*(eq-1) == '!') { /* != */ vs_opt = SelNE; - eq[-1] = '\0'; - opt = eq + 1; - } else if (eq[-1] == ':') { /* := */ - vs_opt = VarAss; - eq[-1] = '\0'; + *(eq-1) = '\0'; opt = eq + 1; + } else if (*(eq-1) == ':') { /* := */ + continue; } else if (eq[1] == '=') { /* == */ vs_opt = SelEQ; eq[0] = '\0'; @@ -547,6 +632,9 @@ eval_opts(char *opts, char *mapkey) vs_opt = SelNE; eq[0] = '\0'; opt = eq + 2; + } else { + /* old style assignment */ + continue; } /* @@ -557,48 +645,47 @@ eval_opts(char *opts, char *mapkey) * Check whether they match */ if (FSTREQ(op->name, f)) { - int selok; - switch (vs_opt) { - case SelEQ: - case SelNE: - if ((selok = (op->sel_p != NULL))) { - if (op->case_insensitive) { - selok = (STRCEQ(*op->sel_p, opt) == (vs_opt == SelNE)); - } else { - selok = (STREQ(*op->sel_p, opt) == (vs_opt == SelNE)); - } - } - if (selok) { + opt = expand_options(opt); + + if (op->sel_p != NULL) { + int selok; + if (op->case_insensitive) { + selok = STRCEQ(*op->sel_p, opt); + } else { + selok = STREQ(*op->sel_p, opt); + } + if (vs_opt == SelNE) + selok = !selok; + if (!selok) { plog(XLOG_MAP, "key %s: map selector %s (=%s) did not %smatch %s", mapkey, op->name, *op->sel_p, vs_opt == SelNE ? "mis" : "", opt); - return 0; + XFREE(opt); + goto out; } - /* check if to apply a function */ - if (op->fxn_p && - ((*op->fxn_p)(opt) == (vs_opt == SelNE))) { + XFREE(opt); + } + /* check if to apply a function */ + if (op->fxn_p) { + int funok; + + funok = op->fxn_p(opt); + if (vs_opt == SelNE) + funok = !funok; + if (!funok) { plog(XLOG_MAP, "key %s: map function %s did not %smatch %s", mapkey, op->name, vs_opt == SelNE ? "mis" : "", opt); - return 0; - } - break; - - case VarAss: - if (op->sel_p) { - plog(XLOG_USER, "key %s: Can't assign to a selector (%s)", - mapkey, op->name); - return 0; + XFREE(opt); + goto out; } - *op->optp = opt; - break; - - } /* end of "switch (vs_opt)" statement */ + XFREE(opt); + } break; /* break out of for loop */ } } @@ -607,7 +694,12 @@ eval_opts(char *opts, char *mapkey) plog(XLOG_USER, "key %s: Unrecognized key/option \"%s\"", mapkey, f); } - return 1; + /* all is ok */ + ret = 1; + + out: + free(old_o); + return ret; } @@ -695,9 +787,9 @@ strip_selectors(char *opts, char *mapkey) * == is SelEQ * := is VarAss */ - if (eq[-1] == '!') { /* != */ + if (*(eq-1) == '!') { /* != */ vs_opt = SelNE; - } else if (eq[-1] == ':') { /* := */ + } else if (*(eq-1) == ':') { /* := */ vs_opt = VarAss; } else if (eq[1] == '=') { /* == */ vs_opt = SelEQ; @@ -715,9 +807,7 @@ strip_selectors(char *opts, char *mapkey) case VarAss: /* found the first assignment, return the string starting with it */ -#ifdef DEBUG dlog("found first assignment past selectors \"%s\"", o); -#endif /* DEBUG */ return oo; } } @@ -738,27 +828,86 @@ f_in_network(char *arg) int status; if (!arg) - return FALSE; + return 0; status = is_network_member(arg); -#ifdef DEBUG - plog(XLOG_USER, "%s is %son a local network", - arg, (status ? "" : "not ")); -#endif /* DEBUG */ + dlog("%s is %son a local network", arg, (status ? "" : "not ")); return status; } +/* + * Test if arg is any of this host's names or aliases (CNAMES). + * Note: this function compares against the fully expanded host name (hostd). + * XXX: maybe we also need to compare against the stripped host name? + */ +static int +f_xhost(char *arg) +{ + struct hostent *hp; + char **cp; + + if (!arg) + return 0; + + /* simple test: does it match main host name? */ + if (STREQ(arg, opt_hostd)) + return 1; + + /* now find all of the names of "arg" and compare against opt_hostd */ + hp = gethostbyname(arg); + if (hp == NULL) { +#ifdef HAVE_HSTRERROR + plog(XLOG_ERROR, "gethostbyname xhost(%s): %s", arg, hstrerror(h_errno)); +#else /* not HAVE_HSTRERROR */ + plog(XLOG_ERROR, "gethostbyname xhost(%s): h_errno %d", arg, h_errno); +#endif /* not HAVE_HSTRERROR */ + return 0; + } + /* check primary name */ + if (hp->h_name) { + dlog("xhost: compare %s==%s", hp->h_name, opt_hostd); + if (STREQ(hp->h_name, opt_hostd)) { + plog(XLOG_INFO, "xhost(%s): matched h_name %s", arg, hp->h_name); + return 1; + } + } + /* check all aliases, if any */ + if (hp->h_aliases == NULL) { + dlog("gethostbyname(%s) has no aliases", arg); + return 0; + } + cp = hp->h_aliases; + while (*cp) { + dlog("xhost: compare alias %s==%s", *cp, opt_hostd); + if (STREQ(*cp, opt_hostd)) { + plog(XLOG_INFO, "xhost(%s): matched alias %s", arg, *cp); + return 1; + } + cp++; + } + /* nothing matched */ + return 0; +} + + /* test if this host (short hostname form) is in netgroup (arg) */ static int f_netgrp(char *arg) { int status; + char *ptr, *nhost; - status = innetgr(arg, opt_host, NULL, NULL); -#ifdef DEBUG - plog(XLOG_USER, "netgrp = %s status = %d host = %s", arg, status, opt_host); -#endif /* DEBUG */ + if ((ptr = strchr(arg, ',')) != NULL) { + *ptr = '\0'; + nhost = ptr + 1; + } else { + nhost = opt_host; + } + status = innetgr(arg, nhost, NULL, NULL); + dlog("netgrp = %s status = %d host = %s", arg, status, nhost); + if (ptr) + *ptr = ','; return status; } @@ -768,11 +917,18 @@ static int f_netgrpd(char *arg) { int status; + char *ptr, *nhost; - status = innetgr(arg, opt_hostd, NULL, NULL); -#ifdef DEBUG - plog(XLOG_USER, "netgrp = %s status = %d hostd = %s", arg, status, opt_hostd); -#endif /* DEBUG */ + if ((ptr = strchr(arg, ',')) != NULL) { + *ptr = '\0'; + nhost = ptr + 1; + } else { + nhost = opt_hostd; + } + status = innetgr(arg, nhost, NULL, NULL); + dlog("netgrp = %s status = %d hostd = %s", arg, status, nhost); + if (ptr) + *ptr = ','; return status; } @@ -814,7 +970,6 @@ free_op(opt_apply *p, int b) { if (*p->opt) { XFREE(*p->opt); - *p->opt = 0; } } @@ -825,9 +980,12 @@ free_op(opt_apply *p, int b) void normalize_slash(char *p) { - char *f = strchr(p, '/'); - char *f0 = f; + char *f, *f0; + if (!(gopt.flags & CFM_NORMALIZE_SLASHES)) + return; + + f0 = f = strchr(p, '/'); if (f) { char *t = f; do { @@ -849,6 +1007,9 @@ normalize_slash(char *p) /* assert(*f != '/'); */ /* keep copying up to next / */ while (*f && *f != '/') { + /* support escaped slashes '\/' */ + if (f[0] == '\\' && f[1] == '/') + f++; /* skip backslash */ *t++ = *f++; } @@ -863,22 +1024,20 @@ normalize_slash(char *p) /* * Macro-expand an option. Note that this does not * handle recursive expansions. They will go badly wrong. - * If sel is true then old expand selectors, otherwise + * If sel_p is true then old expand selectors, otherwise * don't expand selectors. */ -static void -expand_op(opt_apply *p, int sel_p) +static char * +expand_op(char *opt, int sel_p) { - static const char expand_error[] = "No space to expand \"%s\""; +#define EXPAND_ERROR "No space to expand \"%s\"" char expbuf[MAXPATHLEN + 1]; char nbuf[NLEN + 1]; char *ep = expbuf; - char *cp = *p->opt; + char *cp = opt; char *dp; struct opt *op; -#ifdef DEBUG - char *cp_orig = *p->opt; -#endif /* DEBUG */ + char *cp_orig = opt; while ((dp = strchr(cp, '$'))) { char ch; @@ -888,12 +1047,18 @@ expand_op(opt_apply *p, int sel_p) { int len = dp - cp; - if (BUFSPACE(ep, len)) { - strncpy(ep, cp, len); - ep += len; - } else { - plog(XLOG_ERROR, expand_error, *p->opt); - goto out; + if (len > 0) { + if (BUFSPACE(ep, len)) { + /* + * We use strncpy (not xstrlcpy) because 'ep' relies on its + * semantics. BUFSPACE guarantees that ep can hold len. + */ + strncpy(ep, cp, len); + ep += len; + } else { + plog(XLOG_ERROR, EXPAND_ERROR, opt); + goto out; + } } } @@ -903,7 +1068,7 @@ expand_op(opt_apply *p, int sel_p) if (BUFSPACE(ep, 1)) { *ep++ = '$'; } else { - plog(XLOG_ERROR, expand_error, *p->opt); + plog(XLOG_ERROR, EXPAND_ERROR, opt); goto out; } } else if (ch == '{') { @@ -924,7 +1089,7 @@ expand_op(opt_apply *p, int sel_p) /* * Just give up */ - plog(XLOG_USER, "No closing '}' in \"%s\"", *p->opt); + plog(XLOG_USER, "No closing '}' in \"%s\"", opt); goto out; } len = br_p - cp; @@ -939,7 +1104,7 @@ expand_op(opt_apply *p, int sel_p) todo = E_File; cp++; --len; - } else if (br_p[-1] == '/') { + } else if (*(br_p-1) == '/') { /* * Take all but the last component */ @@ -952,7 +1117,7 @@ expand_op(opt_apply *p, int sel_p) todo = E_Domain; cp++; --len; - } else if (br_p[-1] == '.') { + } else if (*(br_p-1) == '.') { /* * Take host name */ @@ -976,6 +1141,11 @@ expand_op(opt_apply *p, int sel_p) /* * Put the string into another buffer so * we can do comparisons. + * + * We use strncpy here (not xstrlcpy) because the dest is meant + * to be truncated and we don't want to log it as an error. The + * use of the BUFSPACE macro above guarantees the safe use of + * strncpy with nbuf. */ strncpy(nbuf, cp, len); nbuf[len] = '\0'; @@ -1003,12 +1173,12 @@ expand_op(opt_apply *p, int sel_p) /* * Copy the string across unexpanded */ - sprintf(xbuf, "${%s%s%s}", - todo == E_File ? "/" : - todo == E_Domain ? "." : "", - nbuf, - todo == E_Dir ? "/" : - todo == E_Host ? "." : ""); + xsnprintf(xbuf, sizeof(xbuf), "${%s%s%s}", + todo == E_File ? "/" : + todo == E_Domain ? "." : "", + nbuf, + todo == E_Dir ? "/" : + todo == E_Host ? "." : ""); val = xbuf; /* * Make sure expansion doesn't @@ -1067,11 +1237,11 @@ expand_op(opt_apply *p, int sel_p) break; } - if (BUFSPACE(ep, vlen)) { - strcpy(ep, vptr); + if (BUFSPACE(ep, vlen+1)) { + xstrlcpy(ep, vptr, vlen+1); ep += vlen; } else { - plog(XLOG_ERROR, expand_error, *p->opt); + plog(XLOG_ERROR, EXPAND_ERROR, opt); goto out; } } @@ -1096,17 +1266,15 @@ expand_op(opt_apply *p, int sel_p) if (env) { int vlen = strlen(env); - if (BUFSPACE(ep, vlen)) { - strcpy(ep, env); + if (BUFSPACE(ep, vlen+1)) { + xstrlcpy(ep, env, vlen+1); ep += vlen; } else { - plog(XLOG_ERROR, expand_error, *p->opt); + plog(XLOG_ERROR, EXPAND_ERROR, opt); goto out; } -#ifdef DEBUG - amuDebug(D_STR) + if (amuDebug(D_STR)) plog(XLOG_DEBUG, "Environment gave \"%s\" -> \"%s\"", nbuf, env); -#endif /* DEBUG */ } else { plog(XLOG_USER, "Unknown sequence \"${%s}\"", nbuf); } @@ -1115,7 +1283,7 @@ expand_op(opt_apply *p, int sel_p) /* * Error, error */ - plog(XLOG_USER, "Unknown $ sequence in \"%s\"", *p->opt); + plog(XLOG_USER, "Unknown $ sequence in \"%s\"", opt); } } @@ -1123,33 +1291,33 @@ out: /* * Handle common case - no expansion */ - if (cp == *p->opt) { - *p->opt = strdup(cp); + if (cp == opt) { + opt = strdup(cp); } else { /* * Finish off the expansion */ - if (BUFSPACE(ep, strlen(cp))) { - strcpy(ep, cp); - /* ep += strlen(ep); */ + int vlen = strlen(cp); + if (BUFSPACE(ep, vlen+1)) { + xstrlcpy(ep, cp, vlen+1); + /* ep += vlen; */ } else { - plog(XLOG_ERROR, expand_error, *p->opt); + plog(XLOG_ERROR, EXPAND_ERROR, opt); } /* * Save the expansion */ - *p->opt = strdup(expbuf); + opt = strdup(expbuf); } - normalize_slash(*p->opt); + normalize_slash(opt); -#ifdef DEBUG - amuDebug(D_STR) { + if (amuDebug(D_STR)) { plog(XLOG_DEBUG, "Expansion of \"%s\"...", cp_orig); - plog(XLOG_DEBUG, "... is \"%s\"", *p->opt); + plog(XLOG_DEBUG, "......... is \"%s\"", opt); } -#endif /* DEBUG */ + return opt; } @@ -1160,15 +1328,15 @@ static void expand_opts(opt_apply *p, int sel_p) { if (*p->opt) { - expand_op(p, sel_p); + *p->opt = expand_op(*p->opt, sel_p); } else if (p->val) { /* * Do double expansion, remembering * to free the string from the first * expansion... */ - char *s = *p->opt = expand_key(p->val); - expand_op(p, sel_p); + char *s = expand_op(p->val, TRUE); + *p->opt = expand_op(s, sel_p); XFREE(s); } } @@ -1206,18 +1374,22 @@ free_opts(am_opts *fo) /* - * Expand lookup key + * Expand selectors (variables that cannot be assigned to or overridden) */ char * -expand_key(char *key) +expand_selectors(char *key) { - opt_apply oa; + return expand_op(key, TRUE); +} - oa.opt = &key; - oa.val = 0; - expand_opts(&oa, TRUE); - return key; +/* + * Expand options (i.e. non-selectors, see above for definition) + */ +static inline char * +expand_options(char *key) +{ + return expand_op(key, FALSE); } @@ -1225,10 +1397,14 @@ expand_key(char *key) * Remove trailing /'s from a string * unless the string is a single / (Steven Glassman) * or unless it is two slashes // (Kevin D. Bond) + * or unless amd.conf says not to touch slashes. */ void deslashify(char *s) { + if (!(gopt.flags & CFM_NORMALIZE_SLASHES)) + return; + if (s && *s) { char *sl = s + strlen(s); @@ -1276,24 +1452,27 @@ eval_fs_opts(am_opts *fo, char *opts, char *g_opts, char *path, char *key, char /* * Expand global options */ - fs_static.fs_glob = expand_key(g_opts); + fs_static.fs_glob = expand_selectors(g_opts); /* * Expand local options */ - fs_static.fs_local = expand_key(opts); - - /* - * Expand default (global) options - */ - if (!eval_opts(fs_static.fs_glob, key)) - ok = FALSE; + fs_static.fs_local = expand_selectors(opts); - /* - * Expand local options - */ - if (ok && !eval_opts(fs_static.fs_local, key)) - ok = FALSE; + /* break global options into fs_static fields */ + if ((ok = split_opts(fs_static.fs_glob, key))) { + dlog("global split_opts ok"); + /* + * evaluate local selectors + */ + if ((ok = eval_selectors(fs_static.fs_local, key))) { + dlog("local eval_selectors ok"); + /* if the local selectors matched, then do the local overrides */ + ok = split_opts(fs_static.fs_local, key); + if (ok) + dlog("local split_opts ok"); + } + } /* * Normalize remote host name. diff --git a/contrib/amd/amd/readdir.c b/contrib/amd/amd/readdir.c new file mode 100644 index 000000000000..d025c9118c30 --- /dev/null +++ b/contrib/amd/amd/readdir.c @@ -0,0 +1,498 @@ +/* + * Copyright (c) 1997-2006 Erez Zadok + * Copyright (c) 1990 Jan-Simon Pendry + * Copyright (c) 1990 Imperial College of Science, Technology & Medicine + * Copyright (c) 1990 The Regents of the University of California. + * All rights reserved. + * + * This code is derived from software contributed to Berkeley by + * Jan-Simon Pendry at Imperial College, London. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * 3. All advertising materials mentioning features or use of this software + * must display the following acknowledgment: + * This product includes software developed by the University of + * California, Berkeley and its contributors. + * 4. Neither the name of the University nor the names of its contributors + * may be used to endorse or promote products derived from this software + * without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF + * SUCH DAMAGE. + * + * + * File: am-utils/amd/readdir.c + * + */ + + +#ifdef HAVE_CONFIG_H +# include <config.h> +#endif /* HAVE_CONFIG_H */ +#include <am_defs.h> +#include <amd.h> + + +/**************************************************************************** + *** MACROS *** + ****************************************************************************/ +#define DOT_DOT_COOKIE (u_int) 1 +#define MAX_CHAIN 2048 + + +/**************************************************************************** + *** FORWARD DEFINITIONS *** + ****************************************************************************/ +static int key_already_in_chain(char *keyname, const nfsentry *chain); +static nfsentry *make_entry_chain(am_node *mp, const nfsentry *current_chain, int fully_browsable); +static int amfs_readdir_browsable(am_node *mp, nfscookie cookie, nfsdirlist *dp, nfsentry *ep, u_int count, int fully_browsable); + + +/**************************************************************************** + *** FUNCTIONS *** + ****************************************************************************/ +/* + * Was: NEW_TOPLVL_READDIR + * Search a chain for an entry with some name. + * -Erez Zadok <ezk@cs.columbia.edu> + */ +static int +key_already_in_chain(char *keyname, const nfsentry *chain) +{ + const nfsentry *tmpchain = chain; + + while (tmpchain) { + if (keyname && tmpchain->ne_name && STREQ(keyname, tmpchain->ne_name)) + return 1; + tmpchain = tmpchain->ne_nextentry; + } + + return 0; +} + + +/* + * Create a chain of entries which are not linked. + * -Erez Zadok <ezk@cs.columbia.edu> + */ +static nfsentry * +make_entry_chain(am_node *mp, const nfsentry *current_chain, int fully_browsable) +{ + static u_int last_cookie = (u_int) 2; /* monotonically increasing */ + static nfsentry chain[MAX_CHAIN]; + static int max_entries = MAX_CHAIN; + char *key; + int num_entries = 0, i; + u_int preflen = 0; + nfsentry *retval = (nfsentry *) NULL; + mntfs *mf; + mnt_map *mmp; + + if (!mp) { + plog(XLOG_DEBUG, "make_entry_chain: mp is (NULL)"); + return retval; + } + mf = mp->am_mnt; + if (!mf) { + plog(XLOG_DEBUG, "make_entry_chain: mp->am_mnt is (NULL)"); + return retval; + } + mmp = (mnt_map *) mf->mf_private; + if (!mmp) { + plog(XLOG_DEBUG, "make_entry_chain: mp->am_mnt->mf_private is (NULL)"); + return retval; + } + + if (mp->am_pref) + preflen = strlen(mp->am_pref); + + /* iterate over keys */ + for (i = 0; i < NKVHASH; i++) { + kv *k; + for (k = mmp->kvhash[i]; k ; k = k->next) { + + /* + * Skip unwanted entries which are either not real entries or + * very difficult to interpret (wildcards...) This test needs + * lots of improvement. Any takers? + */ + key = k->key; + if (!key) + continue; + + /* Skip '/defaults' */ + if (STREQ(key, "/defaults")) + continue; + + /* Skip '*' */ + if (!fully_browsable && strchr(key, '*')) + continue; + + /* + * If the map has a prefix-string then check if the key starts with + * this string, and if it does, skip over this prefix. If it has a + * prefix and it doesn't match the start of the key, skip it. + */ + if (preflen) { + if (preflen > strlen(key)) + continue; + if (!NSTREQ(key, mp->am_pref, preflen)) + continue; + key += preflen; + } + + /* no more '/' are allowed, unless browsable_dirs=full was used */ + if (!fully_browsable && strchr(key, '/')) + continue; + + /* no duplicates allowed */ + if (key_already_in_chain(key, current_chain)) + continue; + + /* fill in a cell and link the entry */ + if (num_entries >= max_entries) { + /* out of space */ + plog(XLOG_DEBUG, "make_entry_chain: no more space in chain"); + if (num_entries > 0) { + chain[num_entries - 1].ne_nextentry = 0; + retval = &chain[0]; + } + return retval; + } + + /* we have space. put entry in next cell */ + ++last_cookie; + chain[num_entries].ne_fileid = (u_int) last_cookie; + *(u_int *) chain[num_entries].ne_cookie = (u_int) last_cookie; + chain[num_entries].ne_name = key; + if (num_entries < max_entries - 1) { /* link to next one */ + chain[num_entries].ne_nextentry = &chain[num_entries + 1]; + } + ++num_entries; + } /* end of "while (k)" */ + } /* end of "for (i ... NKVHASH ..." */ + + /* terminate chain */ + if (num_entries > 0) { + chain[num_entries - 1].ne_nextentry = 0; + retval = &chain[0]; + } + + return retval; +} + + + +/* This one is called only if map is browsable */ +static int +amfs_readdir_browsable(am_node *mp, nfscookie cookie, nfsdirlist *dp, nfsentry *ep, u_int count, int fully_browsable) +{ + u_int gen = *(u_int *) cookie; + int chain_length, i; + static nfsentry *te, *te_next; + static int j; + + dp->dl_eof = FALSE; /* assume readdir not done */ + + if (amuDebug(D_READDIR)) + plog(XLOG_DEBUG, "amfs_readdir_browsable gen=%u, count=%d", + gen, count); + + if (gen == 0) { + /* + * In the default instance (which is used to start a search) we return + * "." and "..". + * + * This assumes that the count is big enough to allow both "." and ".." + * to be returned in a single packet. If it isn't (which would be + * fairly unbelievable) then tough. + */ + dlog("amfs_readdir_browsable: default search"); + /* + * Check for enough room. This is extremely approximate but is more + * than enough space. Really need 2 times: + * 4byte fileid + * 4byte cookie + * 4byte name length + * 4byte name + * plus the dirlist structure */ + if (count < (2 * (2 * (sizeof(*ep) + sizeof("..") + 4) + sizeof(*dp)))) + return EINVAL; + + /* + * compute # of entries to send in this chain. + * heuristics: 128 bytes per entry. + * This is too much probably, but it seems to work better because + * of the re-entrant nature of nfs_readdir, and esp. on systems + * like OpenBSD 2.2. + */ + chain_length = count / 128; + + /* reset static state counters */ + te = te_next = NULL; + + dp->dl_entries = ep; + + /* construct "." */ + ep[0].ne_fileid = mp->am_gen; + ep[0].ne_name = "."; + ep[0].ne_nextentry = &ep[1]; + *(u_int *) ep[0].ne_cookie = 0; + + /* construct ".." */ + if (mp->am_parent) + ep[1].ne_fileid = mp->am_parent->am_gen; + else + ep[1].ne_fileid = mp->am_gen; + + ep[1].ne_name = ".."; + ep[1].ne_nextentry = 0; + *(u_int *) ep[1].ne_cookie = DOT_DOT_COOKIE; + + /* + * If map is browsable, call a function make_entry_chain() to construct + * a linked list of unmounted keys, and return it. Then link the chain + * to the regular list. Get the chain only once, but return + * chunks of it each time. + */ + te = make_entry_chain(mp, dp->dl_entries, fully_browsable); + if (!te) + return 0; + if (amuDebug(D_READDIR)) { + nfsentry *ne; + for (j = 0, ne = te; ne; ne = ne->ne_nextentry) + plog(XLOG_DEBUG, "gen1 key %4d \"%s\"", j++, ne->ne_name); + } + + /* return only "chain_length" entries */ + te_next = te; + for (i=1; i<chain_length; ++i) { + te_next = te_next->ne_nextentry; + if (!te_next) + break; + } + if (te_next) { + nfsentry *te_saved = te_next->ne_nextentry; + te_next->ne_nextentry = NULL; /* terminate "te" chain */ + te_next = te_saved; /* save rest of "te" for next iteration */ + dp->dl_eof = FALSE; /* tell readdir there's more */ + } else { + dp->dl_eof = TRUE; /* tell readdir that's it */ + } + ep[1].ne_nextentry = te; /* append this chunk of "te" chain */ + if (amuDebug(D_READDIR)) { + nfsentry *ne; + for (j = 0, ne = te; ne; ne = ne->ne_nextentry) + plog(XLOG_DEBUG, "gen2 key %4d \"%s\"", j++, ne->ne_name); + for (j = 0, ne = ep; ne; ne = ne->ne_nextentry) + plog(XLOG_DEBUG, "gen2+ key %4d \"%s\" fi=%d ck=%d", + j++, ne->ne_name, ne->ne_fileid, *(u_int *)ne->ne_cookie); + plog(XLOG_DEBUG, "EOF is %d", dp->dl_eof); + } + return 0; + } /* end of "if (gen == 0)" statement */ + + dlog("amfs_readdir_browsable: real child"); + + if (gen == DOT_DOT_COOKIE) { + dlog("amfs_readdir_browsable: End of readdir in %s", mp->am_path); + dp->dl_eof = TRUE; + dp->dl_entries = 0; + return 0; + } + + /* + * If browsable directories, then continue serving readdir() with another + * chunk of entries, starting from where we left off (when gen was equal + * to 0). Once again, assume last chunk served to readdir. + */ + dp->dl_eof = TRUE; + dp->dl_entries = ep; + + te = te_next; /* reset 'te' from last saved te_next */ + if (!te) { /* another indicator of end of readdir */ + dp->dl_entries = 0; + return 0; + } + /* + * compute # of entries to send in this chain. + * heuristics: 128 bytes per entry. + */ + chain_length = count / 128; + + /* return only "chain_length" entries */ + for (i = 1; i < chain_length; ++i) { + te_next = te_next->ne_nextentry; + if (!te_next) + break; + } + if (te_next) { + nfsentry *te_saved = te_next->ne_nextentry; + te_next->ne_nextentry = NULL; /* terminate "te" chain */ + te_next = te_saved; /* save rest of "te" for next iteration */ + dp->dl_eof = FALSE; /* tell readdir there's more */ + } + ep = te; /* send next chunk of "te" chain */ + dp->dl_entries = ep; + if (amuDebug(D_READDIR)) { + nfsentry *ne; + plog(XLOG_DEBUG, "dl_entries=%p, te_next=%p, dl_eof=%d", + dp->dl_entries, te_next, dp->dl_eof); + for (ne = te; ne; ne = ne->ne_nextentry) + plog(XLOG_DEBUG, "gen3 key %4d \"%s\"", j++, ne->ne_name); + } + return 0; +} + + +/* + * This readdir function which call a special version of it that allows + * browsing if browsable_dirs=yes was set on the map. + */ +int +amfs_generic_readdir(am_node *mp, nfscookie cookie, nfsdirlist *dp, nfsentry *ep, u_int count) +{ + u_int gen = *(u_int *) cookie; + am_node *xp; + mntent_t mnt; + + dp->dl_eof = FALSE; /* assume readdir not done */ + + /* check if map is browsable */ + if (mp->am_mnt && mp->am_mnt->mf_mopts) { + mnt.mnt_opts = mp->am_mnt->mf_mopts; + if (amu_hasmntopt(&mnt, "fullybrowsable")) + return amfs_readdir_browsable(mp, cookie, dp, ep, count, TRUE); + if (amu_hasmntopt(&mnt, "browsable")) + return amfs_readdir_browsable(mp, cookie, dp, ep, count, FALSE); + } + + /* when gen is 0, we start reading from the beginning of the directory */ + if (gen == 0) { + /* + * In the default instance (which is used to start a search) we return + * "." and "..". + * + * This assumes that the count is big enough to allow both "." and ".." + * to be returned in a single packet. If it isn't (which would be + * fairly unbelievable) then tough. + */ + dlog("amfs_generic_readdir: default search"); + /* + * Check for enough room. This is extremely approximate but is more + * than enough space. Really need 2 times: + * 4byte fileid + * 4byte cookie + * 4byte name length + * 4byte name + * plus the dirlist structure */ + if (count < (2 * (2 * (sizeof(*ep) + sizeof("..") + 4) + sizeof(*dp)))) + return EINVAL; + + xp = next_nonerror_node(mp->am_child); + dp->dl_entries = ep; + + /* construct "." */ + ep[0].ne_fileid = mp->am_gen; + ep[0].ne_name = "."; + ep[0].ne_nextentry = &ep[1]; + *(u_int *) ep[0].ne_cookie = 0; + + /* construct ".." */ + if (mp->am_parent) + ep[1].ne_fileid = mp->am_parent->am_gen; + else + ep[1].ne_fileid = mp->am_gen; + ep[1].ne_name = ".."; + ep[1].ne_nextentry = 0; + *(u_int *) ep[1].ne_cookie = (xp ? xp->am_gen : DOT_DOT_COOKIE); + + if (!xp) + dp->dl_eof = TRUE; /* by default assume readdir done */ + + if (amuDebug(D_READDIR)) { + nfsentry *ne; + int j; + for (j = 0, ne = ep; ne; ne = ne->ne_nextentry) + plog(XLOG_DEBUG, "gen1 key %4d \"%s\" fi=%d ck=%d", + j++, ne->ne_name, ne->ne_fileid, *(u_int *)ne->ne_cookie); + } + return 0; + } + dlog("amfs_generic_readdir: real child"); + + if (gen == DOT_DOT_COOKIE) { + dlog("amfs_generic_readdir: End of readdir in %s", mp->am_path); + dp->dl_eof = TRUE; + dp->dl_entries = 0; + if (amuDebug(D_READDIR)) + plog(XLOG_DEBUG, "end of readdir eof=TRUE, dl_entries=0\n"); + return 0; + } + + /* non-browsable directories code */ + xp = mp->am_child; + while (xp && xp->am_gen != gen) + xp = xp->am_osib; + + if (xp) { + int nbytes = count / 2; /* conservative */ + int todo = MAX_READDIR_ENTRIES; + + dp->dl_entries = ep; + do { + am_node *xp_next = next_nonerror_node(xp->am_osib); + + if (xp_next) { + *(u_int *) ep->ne_cookie = xp_next->am_gen; + } else { + *(u_int *) ep->ne_cookie = DOT_DOT_COOKIE; + dp->dl_eof = TRUE; + } + + ep->ne_fileid = xp->am_gen; + ep->ne_name = xp->am_name; + nbytes -= sizeof(*ep) + 1; + if (xp->am_name) + nbytes -= strlen(xp->am_name); + + xp = xp_next; + + if (nbytes > 0 && !dp->dl_eof && todo > 1) { + ep->ne_nextentry = ep + 1; + ep++; + --todo; + } else { + todo = 0; + } + } while (todo > 0); + + ep->ne_nextentry = 0; + + if (amuDebug(D_READDIR)) { + nfsentry *ne; + int j; + for (j=0,ne=ep; ne; ne=ne->ne_nextentry) + plog(XLOG_DEBUG, "gen2 key %4d \"%s\" fi=%d ck=%d", + j++, ne->ne_name, ne->ne_fileid, *(u_int *)ne->ne_cookie); + } + return 0; + } + return ESTALE; +} diff --git a/contrib/amd/amd/restart.c b/contrib/amd/amd/restart.c index 59902f6a59bc..4f71e381e25a 100644 --- a/contrib/amd/amd/restart.c +++ b/contrib/amd/amd/restart.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: restart.c,v 1.3.2.4 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/restart.c * */ @@ -49,14 +48,81 @@ #include <amd.h> +static void +restart_fake_mntfs(mntent_t *me, am_ops *fs_ops) +{ + mntfs *mf; + am_opts mo; + char *cp; + + /* + * Partially fake up an opts structure + */ + memset(&mo, 0, sizeof(mo)); + mo.opt_rhost = 0; + mo.opt_rfs = 0; + cp = strchr(me->mnt_fsname, ':'); + if (cp) { + *cp = '\0'; + mo.opt_rhost = strdup(me->mnt_fsname); + mo.opt_rfs = strdup(cp + 1); + *cp = ':'; + } else if (STREQ(me->mnt_type, MNTTAB_TYPE_NFS)) { + /* + * Hacky workaround for mnttab NFS entries that only list the server + */ + plog(XLOG_WARNING, "NFS server entry assumed to be %s:/", me->mnt_fsname); + mo.opt_rhost = strdup(me->mnt_fsname); + mo.opt_rfs = strdup("/"); + me->mnt_fsname = str3cat(me->mnt_fsname, mo.opt_rhost, ":", "/"); + } + mo.opt_fs = me->mnt_dir; + mo.opt_opts = me->mnt_opts; + + /* + * Make a new mounted filesystem + */ + mf = find_mntfs(fs_ops, &mo, me->mnt_dir, + me->mnt_fsname, "", me->mnt_opts, ""); + if (mf->mf_refc == 1) { + mf->mf_flags |= MFF_RESTART | MFF_MOUNTED; + mf->mf_error = 0; /* Already mounted correctly */ + mf->mf_fo = 0; + /* + * Only timeout non-NFS entries + */ + if (!STREQ(me->mnt_type, MNTTAB_TYPE_NFS)) + mf->mf_flags |= MFF_RSTKEEP; + if (fs_ops->fs_init) { + /* + * Don't care whether this worked since + * it is checked again when the fs is + * inherited. + */ + (void) (*fs_ops->fs_init) (mf); + } + plog(XLOG_INFO, "%s restarted fstype %s on %s, flags 0x%x", + me->mnt_fsname, fs_ops->fs_type, me->mnt_dir, mf->mf_flags); + } else { + /* Something strange happened - two mounts at the same place! */ + free_mntfs(mf); + } + /* + * Clean up mo + */ + if (mo.opt_rhost) + XFREE(mo.opt_rhost); + if (mo.opt_rfs) + XFREE(mo.opt_rfs); +} + + /* * Handle an amd restart. * * Scan through the mount list finding all "interesting" mount points. * Next hack up partial data structures and add the mounted file - * system to the list of known filesystems. This will leave a - * dangling reference to that filesystems, so when the filesystem is - * finally inherited, an extra "free" must be done on it. + * system to the list of known filesystems. * * This module relies on internal details of other components. If * you change something else make *sure* restart() still works. @@ -64,26 +130,19 @@ void restart(void) { - /* - * Read the existing mount table - */ mntlist *ml, *mlp; /* - * For each entry, find nfs, ufs or auto mounts - * and create a partial am_node to represent it. + * Read the existing mount table. For each entry, find nfs, ufs or auto + * mounts and create a partial am_node to represent it. */ for (mlp = ml = read_mtab("restart", mnttab_file_name); mlp; mlp = mlp->mnext) { mntent_t *me = mlp->mnt; am_ops *fs_ops = 0; - if (STREQ(me->mnt_type, MNTTAB_TYPE_UFS)) { - /* - * UFS entry - */ - fs_ops = &ufs_ops; - } else if (STREQ(me->mnt_type, MNTTAB_TYPE_NFS)) { + + if (STREQ(me->mnt_type, MNTTAB_TYPE_NFS)) { /* * NFS entry, or possibly an Amd entry... * The mnt_fsname for daemon mount points is @@ -92,117 +151,138 @@ restart(void) * host:daemon(pidXXX) */ char *colon = strchr(me->mnt_fsname, ':'); + if (colon && strstr(colon, "(pid")) + continue; + } - if (colon && strstr(colon, "(pid")) { - plog(XLOG_WARNING, "%s is an existing automount point", me->mnt_dir); - fs_ops = &amfs_link_ops; - } else { - fs_ops = &nfs_ops; - } -#ifdef MNTTAB_TYPE_NFS3 - } else if (STREQ(me->mnt_type, MNTTAB_TYPE_NFS3)) { - fs_ops = &nfs_ops; -#endif /* MNTTAB_TYPE_NFS3 */ -#ifdef MNTTAB_TYPE_LOFS - } else if (STREQ(me->mnt_type, MNTTAB_TYPE_LOFS)) { - fs_ops = &lofs_ops; -#endif /* MNTTAB_TYPE_LOFS */ -#ifdef MNTTAB_TYPE_CDFS - } else if (STREQ(me->mnt_type, MNTTAB_TYPE_CDFS)) { - fs_ops = &cdfs_ops; -#endif /* MNTTAB_TYPE_CDFS */ -#ifdef MNTTAB_TYPE_PCFS - } else if (STREQ(me->mnt_type, MNTTAB_TYPE_PCFS)) { - fs_ops = &pcfs_ops; -#endif /* MNTTAB_TYPE_PCFS */ -#ifdef MNTTAB_TYPE_MFS - } else if (STREQ(me->mnt_type, MNTTAB_TYPE_MFS)) { - /* - * MFS entry. Fake with a symlink. - */ - fs_ops = &amfs_link_ops; -#endif /* MNTTAB_TYPE_MFS */ - } else { - /* - * Catch everything else with symlinks to - * avoid recursive mounts. This is debatable... - */ + /* Search for the correct filesystem ops */ + fs_ops = ops_search(me->mnt_type); + + /* + * Catch everything else with symlinks to + * avoid recursive mounts. This is debatable... + */ + if (!fs_ops) fs_ops = &amfs_link_ops; + + restart_fake_mntfs(me, fs_ops); + } + + /* + * Free the mount list + */ + free_mntlist(ml); +} + + +/* + * Handle an amd restart for amd's own mount points. + * + * Scan through the mount list finding all daemon mount points + * (determined by the presence of a pid inside the mount info). + * Next hack up partial data structures and add the mounted file + * system to the list of known filesystems. + * + * This module relies on internal details of other components. If + * you change something else make *sure* restart() still works. + */ +void +restart_automounter_nodes(void) +{ + mntlist *ml, *mlp; + /* reasonably sized list of restarted nfs ports */ + u_short old_ports[256]; + + memset((voidp) &old_ports, 0, sizeof(u_short) * 256); + + /* + * Read the existing mount table. For each entry, find nfs, ufs or auto + * mounts and create a partial am_node to represent it. + */ + for (mlp = ml = read_mtab("restart", mnttab_file_name); + mlp; + mlp = mlp->mnext) { + mntent_t *me = mlp->mnt; + am_ops *fs_ops = 0; + char *colon; + long pid; + u_short port; + int err; + + if (!STREQ(me->mnt_type, MNTTAB_TYPE_NFS)) + continue; /* to next mlp */ + /* + * NFS entry, or possibly an Amd entry... + * The mnt_fsname for daemon mount points is + * host:(pidXXX) + * or (seen on Solaris) + * host:daemon(pidXXX) + */ + colon = strchr(me->mnt_fsname, ':'); + if (!colon || !strstr(colon, "(pid")) + continue; + /* if got here, then we matched an existing Amd mount point */ + err = 1; + + plog(XLOG_WARNING, "%s is an existing automount point", me->mnt_dir); + + /* Is the old automounter still alive? */ + if (sscanf(colon, "%*[^(](pid%ld%*[,)]", &pid) != 1) { + plog(XLOG_WARNING, "Can't parse pid in %s", me->mnt_fsname); + goto give_up; + } + if (kill(pid, 0) != -1 || errno != ESRCH) { + plog(XLOG_WARNING, "Automounter (pid: %ld) still alive", pid); + goto give_up; } /* - * If we found something to do + * Do we have a map for this mount point? Who cares, we'll restart + * anyway -- getting ESTALE is way better than hanging. */ - if (fs_ops) { - mntfs *mf; - am_opts mo; - char *cp; - cp = strchr(me->mnt_fsname, ':'); - /* - * Partially fake up an opts structure - */ - mo.opt_rhost = 0; - mo.opt_rfs = 0; - if (cp) { - *cp = '\0'; - mo.opt_rhost = strdup(me->mnt_fsname); - mo.opt_rfs = strdup(cp + 1); - *cp = ':'; - } else if (fs_ops->ffserver == find_nfs_srvr) { - /* - * Prototype 4.4 BSD used to end up here - - * might as well keep the workaround for now - */ - plog(XLOG_WARNING, "NFS server entry assumed to be %s:/", me->mnt_fsname); - mo.opt_rhost = strdup(me->mnt_fsname); - mo.opt_rfs = strdup("/"); - me->mnt_fsname = str3cat(me->mnt_fsname, mo.opt_rhost, ":", "/"); + /* Can we restart it? Only if it tells us what port it was using... */ + if (sscanf(colon, "%*[^,],port%hu)", &port) != 1) { + plog(XLOG_WARNING, "No port specified for %s", me->mnt_fsname); + goto give_up; + } + + /* Maybe we already own that port... */ + if (port != nfs_port) { + int i; + for (i = 0; i < 256; i++) { + if (old_ports[i] == port || + old_ports[i] == 0) + break; + } + if (i == 256) { + plog(XLOG_WARNING, "Too many open ports (256)"); + goto give_up; } - mo.opt_fs = me->mnt_dir; - mo.opt_opts = me->mnt_opts; - /* - * Make a new mounted filesystem - */ - mf = find_mntfs(fs_ops, &mo, me->mnt_dir, - me->mnt_fsname, "", me->mnt_opts, ""); - if (mf->mf_refc == 1) { - mf->mf_flags |= MFF_RESTART | MFF_MOUNTED; - mf->mf_error = 0; /* Already mounted correctly */ - mf->mf_fo = 0; - /* - * If the restarted type is a link then - * don't time out. - */ - if (fs_ops == &amfs_link_ops || fs_ops == &ufs_ops) - mf->mf_flags |= MFF_RSTKEEP; - if (fs_ops->fs_init) { - /* - * Don't care whether this worked since - * it is checked again when the fs is - * inherited. - */ - (void) (*fs_ops->fs_init) (mf); + if (old_ports[i] == 0) { + int soNFS; + SVCXPRT *nfsxprt; + if (create_nfs_service(&soNFS, &port, &nfsxprt, nfs_program_2) != 0) { + plog(XLOG_WARNING, "Can't bind to port %u", port); + goto give_up; } - plog(XLOG_INFO, "%s restarted fstype %s on %s", - me->mnt_fsname, fs_ops->fs_type, me->mnt_dir); - } else { - /* Something strange happened - two mounts at the same place! */ - free_mntfs(mf); + old_ports[i] = nfs_port = port; } - /* - * Clean up mo - */ - if (mo.opt_rhost) - XFREE(mo.opt_rhost); - if (mo.opt_rfs) - XFREE(mo.opt_rfs); } - } + err = 0; - /* - * Free the mount list - */ + give_up: + if (err) { + plog(XLOG_WARNING, "Can't restart %s, leaving it alone", me->mnt_dir); + fs_ops = &amfs_link_ops; + } else { + fs_ops = &amfs_toplvl_ops; + } + + restart_fake_mntfs(me, fs_ops); + } /* end of "for (mlp" */ + + /* free the mount list */ free_mntlist(ml); } diff --git a/contrib/amd/amd/rpc_fwd.c b/contrib/amd/amd/rpc_fwd.c index 5a5439c50fb2..b3c8be4fa3b7 100644 --- a/contrib/amd/amd/rpc_fwd.c +++ b/contrib/amd/amd/rpc_fwd.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: rpc_fwd.c,v 1.3.2.5 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/rpc_fwd.c * */ @@ -58,7 +57,7 @@ * is no need to convert to and from network byte ordering. */ -#define XID_ALLOC(struct ) (xid++) +#define XID_ALLOC() (xid++) #define MAX_PACKET_SIZE 8192 /* Maximum UDP packet size */ /* @@ -75,7 +74,7 @@ struct rpc_forward { time_t rf_ttl; /* Time to live */ u_int rf_xid; /* Packet id */ u_int rf_oldid; /* Original packet id */ - fwd_fun rf_fwd; /* Forwarding function */ + fwd_fun *rf_fwd; /* Forwarding function */ voidp rf_ptr; struct sockaddr_in rf_sin; }; @@ -94,7 +93,7 @@ static u_int xid; static rpc_forward * fwd_alloc(void) { - time_t now = clocktime(); + time_t now = clocktime(NULL); rpc_forward *p = 0, *p2; /* @@ -117,9 +116,7 @@ fwd_alloc(void) * Call forwarding function to say that * this message was junked. */ -#ifdef DEBUG dlog("Re-using packet forwarding slot - id %#x", p->rf_xid); -#endif /* DEBUG */ if (p->rf_fwd) (*p->rf_fwd) (0, 0, 0, &p->rf_sin, p->rf_ptr, FALSE); rem_que(&p->rf_q); @@ -228,7 +225,7 @@ fwd_locate(u_int id) * different address. */ int -fwd_packet(int type_id, voidp pkt, int len, struct sockaddr_in *fwdto, struct sockaddr_in *replyto, voidp i, fwd_fun cb) +fwd_packet(int type_id, char *pkt, int len, struct sockaddr_in *fwdto, struct sockaddr_in *replyto, opaque_t cb_arg, fwd_fun cb) { rpc_forward *p; u_int *pkt_int; @@ -247,36 +244,33 @@ fwd_packet(int type_id, voidp pkt, int len, struct sockaddr_in *fwdto, struct so * Otherwise make sure the type_id is * fully qualified by allocating an id here. */ -#ifdef DEBUG switch (type_id & RPC_XID_MASK) { case RPC_XID_PORTMAP: - dlog("Sending PORTMAP request"); + dlog("Sending PORTMAP request %#x", type_id); break; case RPC_XID_MOUNTD: dlog("Sending MOUNTD request %#x", type_id); break; case RPC_XID_NFSPING: - dlog("Sending NFS ping"); + dlog("Sending NFS ping %#x", type_id); + break; + case RPC_XID_WEBNFS: + dlog("Sending WebNFS lookup %#x", type_id); break; default: - dlog("UNKNOWN RPC XID"); + dlog("UNKNOWN RPC XID %#x", type_id); break; } -#endif /* DEBUG */ if (type_id & ~RPC_XID_MASK) { p = fwd_locate(type_id); if (p) { -#ifdef DEBUG dlog("Discarding earlier rpc fwd handle"); -#endif /* DEBUG */ fwd_free(p); } } else { -#ifdef DEBUG dlog("Allocating a new xid..."); -#endif /* DEBUG */ - type_id = MK_RPC_XID(type_id, XID_ALLOC(struct )); + type_id = MK_RPC_XID(type_id, XID_ALLOC()); } p = fwd_alloc(); @@ -290,12 +284,13 @@ fwd_packet(int type_id, voidp pkt, int len, struct sockaddr_in *fwdto, struct so /* * Get the original packet id */ - p->rf_oldid = *pkt_int; + p->rf_oldid = ntohl(*pkt_int); /* * Replace with newly allocated id */ - p->rf_xid = *pkt_int = type_id; + p->rf_xid = type_id; + *pkt_int = htonl(type_id); /* * The sendto may fail if, for example, the route @@ -307,9 +302,9 @@ fwd_packet(int type_id, voidp pkt, int len, struct sockaddr_in *fwdto, struct so { char dq[20]; if (p && fwdto) - dlog("Sending packet id %#x to %s.%d", + dlog("Sending packet id %#x to %s:%d", p->rf_xid, - inet_dquad(dq, fwdto->sin_addr.s_addr), + inet_dquad(dq, sizeof(dq), fwdto->sin_addr.s_addr), ntohs(fwdto->sin_port)); } #endif /* DEBUG */ @@ -349,7 +344,7 @@ out: p->rf_sin = *replyto; else memset((voidp) &p->rf_sin, 0, sizeof(p->rf_sin)); - p->rf_ptr = i; + p->rf_ptr = cb_arg; return error; } @@ -364,6 +359,7 @@ fwd_reply(void) int len; u_int pkt[MAX_PACKET_SIZE / sizeof(u_int) + 1]; u_int *pkt_int; + u_int pkt_xid; int rc; rpc_forward *p; struct sockaddr_in src_addr; @@ -396,6 +392,12 @@ again: rc = ud.udata.len; else { plog(XLOG_ERROR,"fwd_reply failed: t_errno=%d, errno=%d, flags=%d",t_errno,errno, flags); + /* + * Clear error indication, otherwise the error condition persists and + * amd gets into an infinite loop. + */ + if (t_errno == TLOOK) + t_rcvuderr(fwd_sock, NULL); } #else /* not HAVE_TRANSPORT_TYPE_TLI */ rc = recvfrom(fwd_sock, @@ -428,29 +430,29 @@ again: * Find packet reference */ pkt_int = (u_int *) pkt; + pkt_xid = ntohl(*pkt_int); -#ifdef DEBUG - switch (*pkt_int & RPC_XID_MASK) { + switch (pkt_xid & RPC_XID_MASK) { case RPC_XID_PORTMAP: - dlog("Receiving PORTMAP reply"); + dlog("Receiving PORTMAP reply %#x", pkt_xid); break; case RPC_XID_MOUNTD: - dlog("Receiving MOUNTD reply %#x", *pkt_int); + dlog("Receiving MOUNTD reply %#x", pkt_xid); break; case RPC_XID_NFSPING: - dlog("Receiving NFS ping %#x", *pkt_int); + dlog("Receiving NFS ping %#x", pkt_xid); + break; + case RPC_XID_WEBNFS: + dlog("Receiving WebNFS lookup %#x", pkt_xid); break; default: - dlog("UNKNOWN RPC XID"); + dlog("UNKNOWN RPC XID %#x", pkt_xid); break; } -#endif /* DEBUG */ - p = fwd_locate(*pkt_int); + p = fwd_locate(pkt_xid); if (!p) { -#ifdef DEBUG - dlog("Can't forward reply id %#x", *pkt_int); -#endif /* DEBUG */ + dlog("Can't forward reply id %#x", pkt_xid); goto out; } @@ -459,7 +461,7 @@ again: * Put the original message id back * into the packet. */ - *pkt_int = p->rf_oldid; + *pkt_int = htonl(p->rf_oldid); /* * Call forwarding function diff --git a/contrib/amd/amd/sched.c b/contrib/amd/amd/sched.c index c32ef0fe0c39..8efe57a3ab81 100644 --- a/contrib/amd/amd/sched.c +++ b/contrib/amd/amd/sched.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: sched.c,v 1.4.2.5 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/sched.c * */ @@ -56,12 +55,12 @@ typedef struct pjob pjob; struct pjob { - qelem hdr; /* Linked list */ - int pid; /* Process ID of job */ - cb_fun cb_fun; /* Callback function */ - voidp cb_closure; /* Closure for callback */ + qelem hdr; /* Linked list */ + int pid; /* Process ID of job */ + cb_fun *cb_fun; /* Callback function */ + opaque_t cb_arg; /* Argument for callback */ int w; /* everyone these days uses int, not a "union wait" */ - voidp wchan; /* Wait channel */ + wchan_t wchan; /* Wait channel */ }; /* globals */ @@ -94,12 +93,12 @@ rem_que(qelem *elem) static pjob * -sched_job(cb_fun cf, voidp ca) +sched_job(cb_fun *cf, opaque_t ca) { pjob *p = ALLOC(struct pjob); p->cb_fun = cf; - p->cb_closure = ca; + p->cb_arg = ca; /* * Now place on wait queue @@ -115,7 +114,7 @@ sched_job(cb_fun cf, voidp ca) * cf: Continuation function (ca is its arguments) */ void -run_task(task_fun tf, voidp ta, cb_fun cf, voidp ca) +run_task(task_fun *tf, opaque_t ta, cb_fun *cf, opaque_t ca) { pjob *p = sched_job(cf, ca); #ifdef HAVE_SIGACTION @@ -124,7 +123,7 @@ run_task(task_fun tf, voidp ta, cb_fun cf, voidp ca) int mask; #endif /* not HAVE_SIGACTION */ - p->wchan = (voidp) p; + p->wchan = (wchan_t) p; #ifdef HAVE_SIGACTION sigemptyset(&new); /* initialize signal set we wish to block */ @@ -143,7 +142,7 @@ run_task(task_fun tf, voidp ta, cb_fun cf, voidp ca) return; } - /* child code runs here, parent have returned to caller */ + /* child code runs here, parent has returned to caller */ exit((*tf) (ta)); /* firewall... */ @@ -155,19 +154,17 @@ run_task(task_fun tf, voidp ta, cb_fun cf, voidp ca) * Schedule a task to be run when woken up */ void -sched_task(cb_fun cf, voidp ca, voidp wchan) +sched_task(cb_fun *cf, opaque_t ca, wchan_t wchan) { /* * Allocate a new task */ pjob *p = sched_job(cf, ca); -#ifdef DEBUG - dlog("SLEEP on %#lx", (unsigned long) wchan); -#endif /* DEBUG */ + dlog("SLEEP on %p", wchan); p->wchan = wchan; p->pid = 0; - memset((voidp) &p->w, 0, sizeof(p->w)); + p->w = 0; /* was memset (when ->w was union) */ } @@ -181,7 +178,7 @@ wakeupjob(pjob *p) void -wakeup(voidp wchan) +wakeup(wchan_t wchan) { pjob *p, *p2; @@ -189,7 +186,7 @@ wakeup(voidp wchan) return; /* - * Can't user ITER() here because + * Can't use ITER() here because * wakeupjob() juggles the list. */ for (p = AM_FIRST(pjob, &proc_wait_list); @@ -203,9 +200,20 @@ wakeup(voidp wchan) void -wakeup_task(int rc, int term, voidp cl) +wakeup_task(int rc, int term, wchan_t wchan) { - wakeup(cl); + wakeup(wchan); +} + + +wchan_t +get_mntfs_wchan(mntfs *mf) +{ + if (mf && + mf->mf_ops && + mf->mf_ops->get_wchan) + return mf->mf_ops->get_wchan(mf); + return mf; } @@ -236,9 +244,9 @@ do_task_notify(void) */ if (p->cb_fun) { /* these two trigraphs will ensure compatibility with strict POSIX.1 */ - (*p->cb_fun) (WIFEXITED(p->w) ? WEXITSTATUS(p->w) : 0, - WIFSIGNALED(p->w) ? WTERMSIG(p->w) : 0, - p->cb_closure); + p->cb_fun(WIFEXITED(p->w) ? WEXITSTATUS(p->w) : 0, + WIFSIGNALED(p->w) ? WTERMSIG(p->w) : 0, + p->cb_arg); } XFREE(p); } @@ -261,11 +269,9 @@ sigchld(int sig) if (WIFSIGNALED(w)) plog(XLOG_ERROR, "Process %d exited with signal %d", pid, WTERMSIG(w)); -#ifdef DEBUG else dlog("Process %d exited with status %d", pid, WEXITSTATUS(w)); -#endif /* DEBUG */ for (p = AM_FIRST(pjob, &proc_wait_list); p2 = NEXT(pjob, p), p != HEAD(pjob, &proc_wait_list); @@ -277,18 +283,16 @@ sigchld(int sig) } } /* end of for loop */ -#ifdef DEBUG - if (!p) + if (p == HEAD(pjob, &proc_wait_list)) dlog("can't locate task block for pid %d", pid); -#endif /* DEBUG */ /* * Must count down children inside the while loop, otherwise we won't - * count them all, and NumChild (and later backoff) will be set + * count them all, and NumChildren (and later backoff) will be set * incorrectly. SH/RUNIT 940519. */ - if (--NumChild < 0) - NumChild = 0; + if (--NumChildren < 0) + NumChildren = 0; } /* end of "while wait..." loop */ #ifdef REINSTALL_SIGNAL_HANDLER diff --git a/contrib/amd/amd/srvr_amfs_auto.c b/contrib/amd/amd/srvr_amfs_auto.c index 70c93bf1f83e..4742cf6f750d 100644 --- a/contrib/amd/amd/srvr_amfs_auto.c +++ b/contrib/amd/amd/srvr_amfs_auto.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: srvr_amfs_auto.c,v 1.3.2.6 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/srvr_amfs_auto.c * */ @@ -53,9 +52,9 @@ #include <amd.h> /* globals */ -qelem amfs_auto_srvr_list = {&amfs_auto_srvr_list, &amfs_auto_srvr_list}; /* statics */ +static qelem amfs_auto_srvr_list = {&amfs_auto_srvr_list, &amfs_auto_srvr_list}; static fserver *localhost; @@ -63,7 +62,7 @@ static fserver *localhost; * Find an nfs server for the local host */ fserver * -find_amfs_auto_srvr(mntfs *mf) +amfs_generic_find_srvr(mntfs *mf) { fserver *fs = localhost; @@ -73,8 +72,8 @@ find_amfs_auto_srvr(mntfs *mf) fs->fs_host = strdup("localhost"); fs->fs_ip = 0; fs->fs_cid = 0; - fs->fs_pinger = 0; - fs->fs_flags = FSF_VALID; + fs->fs_pinger = AM_PINGER; + fs->fs_flags = FSF_VALID | FSF_PING_UNINIT; fs->fs_type = "local"; fs->fs_private = 0; fs->fs_prfree = 0; @@ -119,9 +118,7 @@ timeout_srvr(voidp v) * we are free to remove this node */ if (fs->fs_refc == 0) { -#ifdef DEBUG dlog("Deleting file server %s", fs->fs_host); -#endif /* DEBUG */ if (fs->fs_flags & FSF_WANT) wakeup_srvr(fs); @@ -167,11 +164,9 @@ free_srvr(fserver *fs) * removed in AM_TTL seconds if no * other mntfs is referencing it. */ - int ttl = (fs->fs_flags & (FSF_DOWN | FSF_ERROR)) ? 19 : AM_TTL; + int ttl = (FSRV_ERROR(fs) || FSRV_ISDOWN(fs)) ? 19 : AM_TTL; -#ifdef DEBUG dlog("Last hard reference to file server %s - will timeout in %ds", fs->fs_host, ttl); -#endif /* DEBUG */ if (fs->fs_cid) { untimeout(fs->fs_cid); /* diff --git a/contrib/amd/amd/srvr_nfs.c b/contrib/amd/amd/srvr_nfs.c index 48e0789abecf..0c74a658e5ee 100644 --- a/contrib/amd/amd/srvr_nfs.c +++ b/contrib/amd/amd/srvr_nfs.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: srvr_nfs.c,v 1.7.2.11 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amd/srvr_nfs.c * */ @@ -72,8 +71,6 @@ */ #endif /* (FAST_NFS_PING * MAX_ALLOWED_PINGS) >= ALLOWED_MOUNT_TIME */ -#define NPXID_ALLOC(struct ) (++np_xid) - /* structures and typedefs */ typedef struct nfs_private { u_short np_mountd; /* Mount daemon port number */ @@ -88,9 +85,16 @@ typedef struct nfs_private { qelem nfs_srvr_list = {&nfs_srvr_list, &nfs_srvr_list}; /* statics */ -static int np_xid; /* For NFS pings */ -static int ping_len; -static char ping_buf[sizeof(struct rpc_msg) + 32]; +static int global_xid; /* For NFS pings */ +#define XID_ALLOC() (++global_xid) + +#ifdef HAVE_FS_NFS3 +# define NUM_NFS_VERS 2 +#else /* not HAVE_FS_NFS3 */ +# define NUM_NFS_VERS 1 +#endif /* not HAVE_FS_NFS3 */ +static int ping_len[NUM_NFS_VERS]; +static char ping_buf[NUM_NFS_VERS][sizeof(struct rpc_msg) + 32]; #if defined(MNTTAB_OPT_PROTO) || defined(HAVE_FS_NFS3) /* @@ -99,6 +103,8 @@ static char ping_buf[sizeof(struct rpc_msg) + 32]; * Note that Solaris 8 and newer NetBSD systems are switching to UDP first, * so this order may have to be adjusted for Amd in the future once more * vendors make that change. -Erez 11/24/2000 + * + * Or we might simply make this is a platform-specific order. -Ion 09/13/2003 */ static char *protocols[] = { "tcp", "udp", NULL }; #endif /* defined(MNTTAB_OPT_PROTO) || defined(HAVE_FS_NFS3) */ @@ -107,20 +113,21 @@ static char *protocols[] = { "tcp", "udp", NULL }; static void nfs_keepalive(voidp); - /* - * Flush any cached data + * Flush cached data for an fserver (or for all, if fs==NULL) */ void -flush_srvr_nfs_cache(void) +flush_srvr_nfs_cache(fserver *fs) { - fserver *fs = 0; + fserver *fs2 = NULL; - ITER(fs, fserver, &nfs_srvr_list) { - nfs_private *np = (nfs_private *) fs->fs_private; - if (np) { - np->np_mountd_inval = TRUE; - np->np_error = -1; + ITER(fs2, fserver, &nfs_srvr_list) { + if (fs == NULL || fs == fs2) { + nfs_private *np = (nfs_private *) fs2->fs_private; + if (np) { + np->np_mountd_inval = TRUE; + np->np_error = -1; + } } } } @@ -130,7 +137,7 @@ flush_srvr_nfs_cache(void) * Startup the NFS ping for a particular version. */ static void -start_ping(u_long nfs_version) +create_ping_payload(u_long nfs_version) { XDR ping_xdr; struct rpc_msg ping_msg; @@ -140,16 +147,16 @@ start_ping(u_long nfs_version) */ if (nfs_version == 0) { nfs_version = NFS_VERSION; - plog(XLOG_WARNING, "start_ping: nfs_version = 0 fixed"); - } - plog(XLOG_INFO, "start_ping: nfs_version: %d", (int) nfs_version); + plog(XLOG_WARNING, "create_ping_payload: nfs_version = 0, changed to 2"); + } else + plog(XLOG_INFO, "create_ping_payload: nfs_version: %d", (int) nfs_version); rpc_msg_init(&ping_msg, NFS_PROGRAM, nfs_version, NFSPROC_NULL); /* * Create an XDR endpoint */ - xdrmem_create(&ping_xdr, ping_buf, sizeof(ping_buf), XDR_ENCODE); + xdrmem_create(&ping_xdr, ping_buf[nfs_version - NFS_VERSION], sizeof(ping_buf[0]), XDR_ENCODE); /* * Create the NFS ping message @@ -161,7 +168,7 @@ start_ping(u_long nfs_version) /* * Find out how long it is */ - ping_len = xdr_getpos(&ping_xdr); + ping_len[nfs_version - NFS_VERSION] = xdr_getpos(&ping_xdr); /* * Destroy the XDR endpoint - we don't need it anymore @@ -183,7 +190,7 @@ got_portmap(voidp pkt, int len, struct sockaddr_in *sa, struct sockaddr_in *ia, * Find which fileserver we are talking about */ ITER(fs, fserver, &nfs_srvr_list) - if (fs == fs2) + if (fs == fs2) break; if (fs == fs2) { @@ -192,9 +199,7 @@ got_portmap(voidp pkt, int len, struct sockaddr_in *sa, struct sockaddr_in *ia, nfs_private *np = (nfs_private *) fs->fs_private; if (!error && port) { -#ifdef DEBUG dlog("got port (%d) for mountd on %s", (int) port, fs->fs_host); -#endif /* DEBUG */ /* * Grab the port number. Portmap sends back * an u_long in native ordering, so it @@ -205,10 +210,8 @@ got_portmap(voidp pkt, int len, struct sockaddr_in *sa, struct sockaddr_in *ia, np->np_mountd_inval = FALSE; np->np_error = 0; } else { -#ifdef DEBUG dlog("Error fetching port for mountd on %s", fs->fs_host); dlog("\t error=%d, port=%d", error, (int) port); -#endif /* DEBUG */ /* * Almost certainly no mountd running on remote host */ @@ -218,13 +221,9 @@ got_portmap(voidp pkt, int len, struct sockaddr_in *sa, struct sockaddr_in *ia, if (fs->fs_flags & FSF_WANT) wakeup_srvr(fs); } else if (done) { -#ifdef DEBUG dlog("Got portmap for old port request"); -#endif /* DEBUG */ } else { -#ifdef DEBUG dlog("portmap request timed out"); -#endif /* DEBUG */ } } @@ -258,7 +257,7 @@ call_portmap(fserver *fs, AUTH *auth, u_long prog, u_long vers, u_long prot) memset((voidp) &sin, 0, sizeof(sin)); sin = *fs->fs_ip; sin.sin_port = htons(PMAPPORT); - error = fwd_packet(RPC_XID_PORTMAP, (voidp) iobuf, len, + error = fwd_packet(RPC_XID_PORTMAP, iobuf, len, &sin, &sin, (voidp) fs, got_portmap); } else { error = -len; @@ -274,6 +273,12 @@ recompute_portmap(fserver *fs) int error; u_long mnt_version; + /* + * No portmap calls for pure WebNFS servers. + */ + if (fs->fs_flags & FSF_WEBNFS) + return; + if (nfs_auth) error = 0; else @@ -288,10 +293,11 @@ recompute_portmap(fserver *fs) if (fs->fs_version == 0) plog(XLOG_WARNING, "recompute_portmap: nfs_version = 0 fixed"); - plog(XLOG_INFO, "recompute_portmap: NFS version %d", (int) fs->fs_version); + plog(XLOG_INFO, "recompute_portmap: NFS version %d on %s", + (int) fs->fs_version, fs->fs_host); #ifdef HAVE_FS_NFS3 if (fs->fs_version == NFS_VERSION3) - mnt_version = MOUNTVERS3; + mnt_version = AM_MOUNTVERS3; else #endif /* HAVE_FS_NFS3 */ mnt_version = MOUNTVERS; @@ -301,19 +307,61 @@ recompute_portmap(fserver *fs) } +int +get_mountd_port(fserver *fs, u_short *port, wchan_t wchan) +{ + int error = -1; + if (FSRV_ISDOWN(fs)) + return EWOULDBLOCK; + + if (FSRV_ISUP(fs)) { + nfs_private *np = (nfs_private *) fs->fs_private; + if (np->np_error == 0) { + *port = np->np_mountd; + error = 0; + } else { + error = np->np_error; + } + /* + * Now go get the port mapping again in case it changed. + * Note that it is used even if (np_mountd_inval) + * is True. The flag is used simply as an + * indication that the mountd may be invalid, not + * that it is known to be invalid. + */ + if (np->np_mountd_inval) + recompute_portmap(fs); + else + np->np_mountd_inval = TRUE; + } + if (error < 0 && wchan && !(fs->fs_flags & FSF_WANT)) { + /* + * If a wait channel is supplied, and no + * error has yet occurred, then arrange + * that a wakeup is done on the wait channel, + * whenever a wakeup is done on this fs node. + * Wakeup's are done on the fs node whenever + * it changes state - thus causing control to + * come back here and new, better things to happen. + */ + fs->fs_flags |= FSF_WANT; + sched_task(wakeup_task, wchan, (wchan_t) fs); + } + return error; +} + + /* * This is called when we get a reply to an RPC ping. * The value of id was taken from the nfs_private * structure when the ping was transmitted. */ static void -nfs_pinged(voidp pkt, int len, struct sockaddr_in *sp, struct sockaddr_in *tsp, voidp idv, int done) +nfs_keepalive_callback(voidp pkt, int len, struct sockaddr_in *sp, struct sockaddr_in *tsp, voidp idv, int done) { - int xid = (long) idv; /* for 64-bit archs */ + int xid = (long) idv; /* cast needed for 64-bit archs */ fserver *fs; -#ifdef DEBUG int found_map = 0; -#endif /* DEBUG */ if (!done) return; @@ -336,19 +384,15 @@ nfs_pinged(voidp pkt, int len, struct sockaddr_in *sp, struct sockaddr_in *tsp, } else { if (np->np_ping > 1) srvrlog(fs, "ok"); -#ifdef DEBUG else srvrlog(fs, "starts up"); -#endif /* DEBUG */ fs->fs_flags |= FSF_VALID; } map_flush_srvr(fs); } else { if (fs->fs_flags & FSF_VALID) { -#ifdef DEBUG dlog("file server %s type nfs is still up", fs->fs_host); -#endif /* DEBUG */ } else { if (np->np_ping > 1) srvrlog(fs, "ok"); @@ -365,13 +409,13 @@ nfs_pinged(voidp pkt, int len, struct sockaddr_in *sp, struct sockaddr_in *tsp, /* * Update ttl for this server */ - np->np_ttl = clocktime() + + np->np_ttl = clocktime(NULL) + (MAX_ALLOWED_PINGS - 1) * FAST_NFS_PING + fs->fs_pinger - 1; /* * New RPC xid... */ - np->np_xid = NPXID_ALLOC(struct ); + np->np_xid = XID_ALLOC(); /* * Failed pings is zero... @@ -384,17 +428,53 @@ nfs_pinged(voidp pkt, int len, struct sockaddr_in *sp, struct sockaddr_in *tsp, if (np->np_mountd_inval) recompute_portmap(fs); -#ifdef DEBUG found_map++; -#endif /* DEBUG */ break; } } -#ifdef DEBUG if (found_map == 0) dlog("Spurious ping packet"); -#endif /* DEBUG */ +} + + +static void +check_fs_addr_change(fserver *fs) +{ + struct hostent *hp = NULL; + struct in_addr ia; + char *old_ipaddr, *new_ipaddr; + + hp = gethostbyname(fs->fs_host); + if (!hp || + hp->h_addrtype != AF_INET || + !STREQ((char *) hp->h_name, fs->fs_host) || + memcmp((voidp) &fs->fs_ip->sin_addr, + (voidp) hp->h_addr, + sizeof(fs->fs_ip->sin_addr)) == 0) + return; + /* if got here: downed server changed IP address */ + old_ipaddr = strdup(inet_ntoa(fs->fs_ip->sin_addr)); + memmove((voidp) &ia, (voidp) hp->h_addr, sizeof(struct in_addr)); + new_ipaddr = inet_ntoa(ia); /* ntoa uses static buf */ + plog(XLOG_WARNING, "EZK: down fileserver %s changed ip: %s -> %s", + fs->fs_host, old_ipaddr, new_ipaddr); + XFREE(old_ipaddr); + /* copy new IP addr */ + memmove((voidp) &fs->fs_ip->sin_addr, + (voidp) hp->h_addr, + sizeof(fs->fs_ip->sin_addr)); + /* XXX: do we need to un/set these flags? */ + fs->fs_flags &= ~FSF_DOWN; + fs->fs_flags |= FSF_VALID | FSF_WANT; + map_flush_srvr(fs); /* XXX: a race with flush_srvr_nfs_cache? */ + flush_srvr_nfs_cache(fs); + fs->fs_flags |= FSF_FORCE_UNMOUNT; + +#if 0 + flush_nfs_fhandle_cache(fs); /* done in caller: nfs_keepalive_timeout */ + /* XXX: need to purge nfs_private so that somehow it will get re-initialized? */ +#endif } @@ -402,7 +482,7 @@ nfs_pinged(voidp pkt, int len, struct sockaddr_in *sp, struct sockaddr_in *tsp, * Called when no ping-reply received */ static void -nfs_timed_out(voidp v) +nfs_keepalive_timeout(voidp v) { fserver *fs = v; nfs_private *np = (nfs_private *) fs->fs_private; @@ -423,11 +503,9 @@ nfs_timed_out(voidp v) /* * If ttl has expired then guess that it is dead */ - if (np->np_ttl < clocktime()) { + if (np->np_ttl < clocktime(NULL)) { int oflags = fs->fs_flags; -#ifdef DEBUG dlog("ttl has expired"); -#endif /* DEBUG */ if ((fs->fs_flags & FSF_DOWN) == 0) { /* * Server was up, but is now down. @@ -441,14 +519,13 @@ nfs_timed_out(voidp v) */ flush_nfs_fhandle_cache(fs); np->np_error = -1; + check_fs_addr_change(fs); /* check if IP addr of fserver changed */ } else { /* * Known to be down */ -#ifdef DEBUG if ((fs->fs_flags & FSF_VALID) == 0) srvrlog(fs, "starts down"); -#endif /* DEBUG */ fs->fs_flags |= FSF_VALID; } if (oflags != fs->fs_flags && (fs->fs_flags & FSF_WANT)) @@ -458,17 +535,15 @@ nfs_timed_out(voidp v) */ np->np_ping = 0; } else { -#ifdef DEBUG if (np->np_ping > 1) dlog("%d pings to %s failed - at most %d allowed", np->np_ping, fs->fs_host, MAX_ALLOWED_PINGS); -#endif /* DEBUG */ } /* * New RPC xid, so any late responses to the previous ping * get ignored... */ - np->np_xid = NPXID_ALLOC(struct ); + np->np_xid = XID_ALLOC(); /* * Run keepalive again @@ -492,19 +567,19 @@ nfs_keepalive(voidp v) * Send an NFS ping to this node */ - if (ping_len == 0) - start_ping(fs->fs_version); + if (ping_len[fs->fs_version - NFS_VERSION] == 0) + create_ping_payload(fs->fs_version); /* * Queue the packet... */ error = fwd_packet(MK_RPC_XID(RPC_XID_NFSPING, np->np_xid), - (voidp) ping_buf, - ping_len, + ping_buf[fs->fs_version - NFS_VERSION], + ping_len[fs->fs_version - NFS_VERSION], fs->fs_ip, (struct sockaddr_in *) 0, - (voidp) ((long) np->np_xid), /* for 64-bit archs */ - nfs_pinged); + (voidp) ((long) np->np_xid), /* cast needed for 64-bit archs */ + nfs_keepalive_callback); /* * See if a hard error occurred @@ -517,7 +592,7 @@ nfs_keepalive(voidp v) np->np_ping = MAX_ALLOWED_PINGS; /* immediately down */ np->np_ttl = (time_t) 0; /* - * This causes an immediate call to nfs_timed_out + * This causes an immediate call to nfs_keepalive_timeout * whenever the server was thought to be up. * See +++ below. */ @@ -525,15 +600,13 @@ nfs_keepalive(voidp v) break; case 0: -#ifdef DEBUG dlog("Sent NFS ping to %s", fs->fs_host); -#endif /* DEBUG */ break; } /* * Back off the ping interval if we are not getting replies and - * the remote system is know to be down. + * the remote system is known to be down. */ switch (fs->fs_flags & (FSF_DOWN | FSF_VALID)) { case FSF_VALID: /* Up */ @@ -550,73 +623,41 @@ nfs_keepalive(voidp v) break; } -#ifdef DEBUG dlog("NFS timeout in %d seconds", fstimeo); -#endif /* DEBUG */ - fs->fs_cid = timeout(fstimeo, nfs_timed_out, (voidp) fs); -} - - -int -nfs_srvr_port(fserver *fs, u_short *port, voidp wchan) -{ - int error = -1; - if ((fs->fs_flags & FSF_VALID) == FSF_VALID) { - if ((fs->fs_flags & FSF_DOWN) == 0) { - nfs_private *np = (nfs_private *) fs->fs_private; - if (np->np_error == 0) { - *port = np->np_mountd; - error = 0; - } else { - error = np->np_error; - } - /* - * Now go get the port mapping again in case it changed. - * Note that it is used even if (np_mountd_inval) - * is True. The flag is used simply as an - * indication that the mountd may be invalid, not - * that it is known to be invalid. - */ - if (np->np_mountd_inval) - recompute_portmap(fs); - else - np->np_mountd_inval = TRUE; - } else { - error = EWOULDBLOCK; - } - } - if (error < 0 && wchan && !(fs->fs_flags & FSF_WANT)) { - /* - * If a wait channel is supplied, and no - * error has yet occurred, then arrange - * that a wakeup is done on the wait channel, - * whenever a wakeup is done on this fs node. - * Wakeup's are done on the fs node whenever - * it changes state - thus causing control to - * come back here and new, better things to happen. - */ - fs->fs_flags |= FSF_WANT; - sched_task(wakeup_task, wchan, (voidp) fs); - } - return error; + fs->fs_cid = timeout(fstimeo, nfs_keepalive_timeout, (voidp) fs); } static void start_nfs_pings(fserver *fs, int pingval) { - if (fs->fs_flags & FSF_PINGING) { -#ifdef DEBUG - dlog("Already running pings to %s", fs->fs_host); -#endif /* DEBUG */ + if (pingval == 0) /* could be because ping mnt option not found */ + pingval = AM_PINGER; + /* if pings haven't been initalized, then init them for first time */ + if (fs->fs_flags & FSF_PING_UNINIT) { + fs->fs_flags &= ~FSF_PING_UNINIT; + plog(XLOG_INFO, "initializing %s's pinger to %d sec", fs->fs_host, pingval); + goto do_pings; + } + + if ((fs->fs_flags & FSF_PINGING) && fs->fs_pinger == pingval) { + dlog("already running pings to %s", fs->fs_host); return; } + /* if got here, then we need to update the ping value */ + plog(XLOG_INFO, "changing %s's ping value from %d%s to %d%s", + fs->fs_host, + fs->fs_pinger, (fs->fs_pinger < 0 ? " (off)" : ""), + pingval, (pingval < 0 ? " (off)" : "")); + do_pings: + fs->fs_pinger = pingval; + if (fs->fs_cid) untimeout(fs->fs_cid); if (pingval < 0) { - srvrlog(fs, "wired up"); + srvrlog(fs, "wired up (pings disabled)"); fs->fs_flags |= FSF_VALID; fs->fs_flags &= ~FSF_DOWN; } else { @@ -633,17 +674,18 @@ fserver * find_nfs_srvr(mntfs *mf) { char *host = mf->mf_fo->opt_rhost; - char *nfs_proto = NULL; fserver *fs; int pingval; mntent_t mnt; nfs_private *np; - struct hostent *hp = 0; - struct sockaddr_in *ip; + struct hostent *hp = NULL; + struct sockaddr_in *ip = NULL; u_long nfs_version = 0; /* default is no version specified */ -#ifdef MNTTAB_OPT_PROTO - char *rfsname = mf->mf_fo->opt_rfs; -#endif /* MNTTAB_OPT_PROTO */ + u_long best_nfs_version = 0; + char *nfs_proto = NULL; /* no IP protocol either */ + int nfs_port = 0; + int nfs_port_opt = 0; + int fserver_is_down = 0; /* * Get ping interval from mount options. @@ -653,49 +695,60 @@ find_nfs_srvr(mntfs *mf) mnt.mnt_opts = mf->mf_mopts; pingval = hasmntval(&mnt, "ping"); - /* - * Get the NFS version from the mount options. This is used - * to decide the highest NFS version to try. - */ + if (mf->mf_flags & MFF_NFS_SCALEDOWN) { + /* + * the server granted us a filehandle, but we were unable to mount it. + * therefore, scale down to NFSv2/UDP and try again. + */ + nfs_version = NFS_VERSION; + nfs_proto = "udp"; + plog(XLOG_WARNING, "find_nfs_srvr: NFS mount failed, trying again with NFSv2/UDP"); + mf->mf_flags &= ~MFF_NFS_SCALEDOWN; + } else { + /* + * Get the NFS version from the mount options. This is used + * to decide the highest NFS version to try. + */ #ifdef MNTTAB_OPT_VERS - nfs_version = hasmntval(&mnt, MNTTAB_OPT_VERS); + nfs_version = hasmntval(&mnt, MNTTAB_OPT_VERS); #endif /* MNTTAB_OPT_VERS */ #ifdef MNTTAB_OPT_PROTO - { - char *proto_opt = hasmnteq(&mnt, MNTTAB_OPT_PROTO); - if (proto_opt) { - char **p; - for (p = protocols; *p; p ++) - if (NSTREQ(proto_opt, *p, strlen(*p))) { - nfs_proto = *p; - break; - } - if (*p == NULL) - plog(XLOG_WARNING, "ignoring unknown protocol option for %s:%s", - host, rfsname); + { + char *proto_opt = hasmnteq(&mnt, MNTTAB_OPT_PROTO); + if (proto_opt) { + char **p; + for (p = protocols; *p; p++) + if (NSTREQ(proto_opt, *p, strlen(*p))) { + nfs_proto = *p; + break; + } + if (*p == NULL) + plog(XLOG_WARNING, "ignoring unknown protocol option for %s:%s", + host, mf->mf_fo->opt_rfs); + } } - } #endif /* MNTTAB_OPT_PROTO */ #ifdef HAVE_NFS_NFSV2_H - /* allow overriding if nfsv2 option is specified in mount options */ - if (hasmntopt(&mnt, "nfsv2")) { - nfs_version = (u_long) 2; /* nullify any ``vers=X'' statements */ - nfs_proto = "udp"; /* nullify any ``proto=tcp'' statements */ - plog(XLOG_WARNING, "found compatiblity option \"nfsv2\": set options vers=2,proto=udp for host %s", host); - } + /* allow overriding if nfsv2 option is specified in mount options */ + if (amu_hasmntopt(&mnt, "nfsv2")) { + nfs_version = NFS_VERSION;/* nullify any ``vers=X'' statements */ + nfs_proto = "udp"; /* nullify any ``proto=tcp'' statements */ + plog(XLOG_WARNING, "found compatibility option \"nfsv2\": set options vers=2,proto=udp for host %s", host); + } #endif /* HAVE_NFS_NFSV2_H */ - /* check if we globally overridden the NFS version/protocol */ - if (gopt.nfs_vers) { - nfs_version = gopt.nfs_vers; - plog(XLOG_INFO, "find_nfs_srvr: force NFS version to %d", - (int) nfs_version); - } - if (gopt.nfs_proto) { - nfs_proto = gopt.nfs_proto; - plog(XLOG_INFO, "find_nfs_srvr: force NFS protocol transport to %s", nfs_proto); + /* check if we've globally overridden the NFS version/protocol */ + if (gopt.nfs_vers) { + nfs_version = gopt.nfs_vers; + plog(XLOG_INFO, "find_nfs_srvr: force NFS version to %d", + (int) nfs_version); + } + if (gopt.nfs_proto) { + nfs_proto = gopt.nfs_proto; + plog(XLOG_INFO, "find_nfs_srvr: force NFS protocol transport to %s", nfs_proto); + } } /* @@ -718,72 +771,148 @@ find_nfs_srvr(mntfs *mf) case AF_INET: ip = ALLOC(struct sockaddr_in); memset((voidp) ip, 0, sizeof(*ip)); + /* as per POSIX, sin_len need not be set (used internally by kernel) */ ip->sin_family = AF_INET; memmove((voidp) &ip->sin_addr, (voidp) hp->h_addr, sizeof(ip->sin_addr)); - - ip->sin_port = htons(NFS_PORT); break; default: - ip = 0; - break; + plog(XLOG_USER, "No IP address for host %s", host); + goto no_dns; } } else { plog(XLOG_USER, "Unknown host: %s", host); - ip = 0; + goto no_dns; } /* - * Get the NFS Version, and verify server is up. Probably no - * longer need to start server down below. + * This may not be the best way to do things, but it really doesn't make + * sense to query a file server which is marked as 'down' for any + * version/proto combination. */ - if (ip) { + ITER(fs, fserver, &nfs_srvr_list) { + if (FSRV_ISDOWN(fs) && + STREQ(host, fs->fs_host)) { + plog(XLOG_WARNING, "fileserver %s is already hung - not running NFS proto/version discovery", host); + fs->fs_refc++; + if (ip) + XFREE(ip); + return fs; + } + } + + /* + * Get the NFS Version, and verify server is up. + * If the client only supports NFSv2, hardcode it but still try to + * contact the remote portmapper to see if the service is running. + */ +#ifndef HAVE_FS_NFS3 + nfs_version = NFS_VERSION; + nfs_proto = "udp"; + plog(XLOG_INFO, "The client supports only NFS(2,udp)"); +#endif /* not HAVE_FS_NFS3 */ + + + if (amu_hasmntopt(&mnt, MNTTAB_OPT_PUBLIC)) { + /* + * Use WebNFS to obtain file handles. + */ + mf->mf_flags |= MFF_WEBNFS; + plog(XLOG_INFO, "%s option used, NOT contacting the portmapper on %s", + MNTTAB_OPT_PUBLIC, host); + /* + * Prefer NFSv3/tcp if the client supports it (cf. RFC 2054, 7). + */ + if (!nfs_version) { #ifdef HAVE_FS_NFS3 + nfs_version = NFS_VERSION3; +#else /* not HAVE_FS_NFS3 */ + nfs_version = NFS_VERSION; +#endif /* not HAVE_FS_NFS3 */ + plog(XLOG_INFO, "No NFS version specified, will use NFSv%d", + (int) nfs_version); + } + if (!nfs_proto) { +#if defined(MNTTAB_OPT_PROTO) || defined(HAVE_FS_NFS3) + nfs_proto = "tcp"; +#else /* not defined(MNTTAB_OPT_PROTO) || defined(HAVE_FS_NFS3) */ + nfs_proto = "udp"; +#endif /* not defined(MNTTAB_OPT_PROTO) || defined(HAVE_FS_NFS3) */ + plog(XLOG_INFO, "No NFS protocol transport specified, will use %s", + nfs_proto); + } + } else { /* * Find the best combination of NFS version and protocol. * When given a choice, use the highest available version, * and use TCP over UDP if available. */ - if (nfs_proto) - nfs_version = get_nfs_version(host, ip, nfs_version, nfs_proto); - else { - int best_nfs_version = 0; - int proto_nfs_version; - char **p; - - for (p = protocols; *p; p++) { - proto_nfs_version = get_nfs_version(host, ip, nfs_version, *p); - - if (proto_nfs_version > best_nfs_version) { - best_nfs_version = proto_nfs_version; - nfs_proto = *p; + if (check_pmap_up(host, ip)) { + if (nfs_proto) { + best_nfs_version = get_nfs_version(host, ip, nfs_version, nfs_proto); + nfs_port = ip->sin_port; + } +#ifdef MNTTAB_OPT_PROTO + else { + u_int proto_nfs_version; + char **p; + + for (p = protocols; *p; p++) { + proto_nfs_version = get_nfs_version(host, ip, nfs_version, *p); + + if (proto_nfs_version > best_nfs_version) { + best_nfs_version = proto_nfs_version; + nfs_proto = *p; + nfs_port = ip->sin_port; + } } } - nfs_version = best_nfs_version; +#endif /* MNTTAB_OPT_PROTO */ + } else { + plog(XLOG_INFO, "portmapper service not running on %s", host); } - if (!nfs_version) { + /* use the portmapper results only nfs_version is not set yet */ + if (!best_nfs_version) { /* * If the NFS server is down or does not support the portmapper call * (such as certain Novell NFS servers) we mark it as version 2 and we - * let the nfs code deal with the case that is down. If when the - * server comes back up, it can support NFS V.3 and/or TCP, it will + * let the nfs code deal with the case when it is down. If/when the + * server comes back up and it can support NFSv3 and/or TCP, it will * use those. */ - nfs_version = NFS_VERSION; - nfs_proto = "udp"; + if (nfs_version == 0) { + nfs_version = NFS_VERSION; + nfs_proto = "udp"; + } + plog(XLOG_INFO, "NFS service not running on %s", host); + fserver_is_down = 1; + } else { + if (nfs_version == 0) + nfs_version = best_nfs_version; + plog(XLOG_INFO, "Using NFS version %d, protocol %s on host %s", + (int) nfs_version, nfs_proto, host); } -#else /* not HAVE_FS_NFS3 */ - nfs_version = NFS_VERSION; -#endif /* not HAVE_FS_NFS3 */ } - if (!nfs_proto) - nfs_proto = "udp"; + /* + * Determine the NFS port. + * + * A valid "port" mount option overrides anything else. + * If the port has been determined from the portmapper, use that. + * Default to NFS_PORT otherwise (cf. RFC 2054, 3). + */ + nfs_port_opt = hasmntval(&mnt, MNTTAB_OPT_PORT); + if (nfs_port_opt > 0) + nfs_port = htons(nfs_port_opt); + if (!nfs_port) + nfs_port = htons(NFS_PORT); - plog(XLOG_INFO, "Using NFS version %d, protocol %s on host %s", - (int) nfs_version, nfs_proto, host); + dlog("find_nfs_srvr: using port %d for nfs on %s", + (int) ntohs(nfs_port), host); + ip->sin_port = nfs_port; +no_dns: /* * Try to find an existing fs server structure for this host. * Note that differing versions or protocols have their own structures. @@ -795,16 +924,46 @@ find_nfs_srvr(mntfs *mf) nfs_version == fs->fs_version && STREQ(nfs_proto, fs->fs_proto)) { /* - * following if statement from Mike Mitchell - * <mcm@unx.sas.com> - * Initialize the ping data if we aren't pinging - * now. The np_ttl and np_ping fields are - * especially important. + * fill in the IP address -- this is only needed + * if there is a chance an IP address will change + * between mounts. + * Mike Mitchell, mcm@unx.sas.com, 09/08/93 + */ + if (hp && fs->fs_ip && + memcmp((voidp) &fs->fs_ip->sin_addr, + (voidp) hp->h_addr, + sizeof(fs->fs_ip->sin_addr)) != 0) { + struct in_addr ia; + char *old_ipaddr, *new_ipaddr; + old_ipaddr = strdup(inet_ntoa(fs->fs_ip->sin_addr)); + memmove((voidp) &ia, (voidp) hp->h_addr, sizeof(struct in_addr)); + new_ipaddr = inet_ntoa(ia); /* ntoa uses static buf */ + plog(XLOG_WARNING, "fileserver %s changed ip: %s -> %s", + fs->fs_host, old_ipaddr, new_ipaddr); + XFREE(old_ipaddr); + flush_nfs_fhandle_cache(fs); + memmove((voidp) &fs->fs_ip->sin_addr, (voidp) hp->h_addr, sizeof(fs->fs_ip->sin_addr)); + } + + /* + * If the new file systems doesn't use WebNFS, the nfs pings may + * try to contact the portmapper. + */ + if (!(mf->mf_flags & MFF_WEBNFS)) + fs->fs_flags &= ~FSF_WEBNFS; + + /* check if pingval needs to be updated/set/reset */ + start_nfs_pings(fs, pingval); + + /* + * Following if statement from Mike Mitchell <mcm@unx.sas.com> + * Initialize the ping data if we aren't pinging now. The np_ttl and + * np_ping fields are especially important. */ if (!(fs->fs_flags & FSF_PINGING)) { np = (nfs_private *) fs->fs_private; np->np_mountd_inval = TRUE; - np->np_xid = NPXID_ALLOC(struct ); + np->np_xid = XID_ALLOC(); np->np_error = -1; np->np_ping = 0; /* @@ -812,18 +971,12 @@ find_nfs_srvr(mntfs *mf) * after MAX_ALLOWED_PINGS of the fast variety * have failed. */ - np->np_ttl = MAX_ALLOWED_PINGS * FAST_NFS_PING + clocktime() - 1; + np->np_ttl = MAX_ALLOWED_PINGS * FAST_NFS_PING + clocktime(NULL) - 1; + start_nfs_pings(fs, pingval); + if (fserver_is_down) + fs->fs_flags |= FSF_VALID | FSF_DOWN; } - /* - * fill in the IP address -- this is only needed - * if there is a chance an IP address will change - * between mounts. - * Mike Mitchell, mcm@unx.sas.com, 09/08/93 - */ - if (hp && fs->fs_ip) - memmove((voidp) &fs->fs_ip->sin_addr, (voidp) hp->h_addr, sizeof(fs->fs_ip->sin_addr)); - start_nfs_pings(fs, pingval); fs->fs_refc++; if (ip) XFREE(ip); @@ -852,29 +1005,32 @@ find_nfs_srvr(mntfs *mf) mf->mf_flags |= MFF_ERROR; mf->mf_error = ENOENT; } + if (mf->mf_flags & MFF_WEBNFS) + fs->fs_flags |= FSF_WEBNFS; fs->fs_version = nfs_version; fs->fs_proto = nfs_proto; fs->fs_type = MNTTAB_TYPE_NFS; fs->fs_pinger = AM_PINGER; + fs->fs_flags |= FSF_PING_UNINIT; /* pinger hasn't been initialized */ np = ALLOC(struct nfs_private); memset((voidp) np, 0, sizeof(*np)); np->np_mountd_inval = TRUE; - np->np_xid = NPXID_ALLOC(struct ); + np->np_xid = XID_ALLOC(); np->np_error = -1; /* * Initially the server will be deemed dead after * MAX_ALLOWED_PINGS of the fast variety have failed. */ - np->np_ttl = clocktime() + MAX_ALLOWED_PINGS * FAST_NFS_PING - 1; + np->np_ttl = clocktime(NULL) + MAX_ALLOWED_PINGS * FAST_NFS_PING - 1; fs->fs_private = (voidp) np; fs->fs_prfree = (void (*)(voidp)) free; - if (!(fs->fs_flags & FSF_ERROR)) { - /* - * Start of keepalive timer - */ + if (!FSRV_ERROR(fs)) { + /* start of keepalive timer, first updating pingval */ start_nfs_pings(fs, pingval); + if (fserver_is_down) + fs->fs_flags |= FSF_VALID | FSF_DOWN; } /* diff --git a/contrib/amd/amq/amq.8 b/contrib/amd/amq/amq.8 index 7ccfd7c0735c..203a52938014 100644 --- a/contrib/amd/amq/amq.8 +++ b/contrib/amd/amq/amq.8 @@ -1,5 +1,5 @@ .\" -.\" Copyright (c) 1997-2004 Erez Zadok +.\" Copyright (c) 1997-2006 Erez Zadok .\" Copyright (c) 1990 Jan-Simon Pendry .\" Copyright (c) 1990 Imperial College of Science, Technology & Medicine .\" Copyright (c) 1990 The Regents of the University of California. @@ -38,7 +38,7 @@ .\" .\" %W% (Berkeley) %G% .\" -.\" $Id: amq.8,v 1.3.2.8 2004/01/06 03:15:16 ezk Exp $ +.\" $Id: amq.8,v 1.15.2.1 2006/01/02 18:48:24 ezk Exp $ .\" .TH AMQ 8 "25 April 1989" .SH NAME @@ -192,26 +192,70 @@ using UDP (connectionless) transport only. Normally will try TCP, and if that failed, will try UDP. .SH FILES -.PD 0 .TP 20 .B amq.x .SM RPC protocol description. + .SH CAVEATS .B Amq uses a Sun registered .SM RPC program number (300019 decimal) which may not be in the /etc/rpc database. +.PP +If the TCP wrappers library is available, and the +.B use_tcpwrappers +global +.B amd.conf +option is set to ``yes'', then +.B amd +will verify that the host running +.B amq +is authorized to connect. The +.I amd +service name must used in the +.B /etc/hosts.allow +and +.B /etc/hosts.deny +files. For example, to allow only localhost to connect to +.B amd, +add this line to +.B /etc/hosts.allow: +.PP +.RS +amd: localhost +.RE +.PP +and this line to +.B /etc/hosts.deny: +.PP +.RS +amd: ALL +.RE + .SH "SEE ALSO" .BR amd (8), .BR ctl-amd (8), -.BR amd.conf (5). +.BR amd.conf (5), +.BR hosts_access (5). +.LP +``am-utils'' +.BR info (1) +entry. +.LP +.I "Linux NFS and Automounter Administration" +by Erez Zadok, ISBN 0-7821-2739-8, (Sybex, 2001). +.LP +.I http://www.am-utils.org +.LP +.I "Amd \- The 4.4 BSD Automounter" + .SH AUTHORS Jan-Simon Pendry <jsp@doc.ic.ac.uk>, Department of Computing, Imperial College, London, UK. .P -Erez Zadok <ezk@cs.columbia.edu>, Department of Computer Science, Columbia -University, New York, USA. +Erez Zadok <ezk@cs.sunysb.edu>, Computer Science Department, Stony Brook +University, Stony Brook, New York, USA. .P Other authors and contributors to am-utils are listed in the .B AUTHORS diff --git a/contrib/amd/amq/amq.c b/contrib/amd/amq/amq.c index 06574bf2fca4..2379b6214766 100644 --- a/contrib/amd/amq/amq.c +++ b/contrib/amd/amq/amq.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: amq.c,v 1.7.2.9 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amq/amq.c * */ @@ -46,19 +45,6 @@ * Automounter query tool */ -#ifndef lint -char copyright[] = "\ -@(#)Copyright (c) 1997-2004 Erez Zadok\n\ -@(#)Copyright (c) 1990 Jan-Simon Pendry\n\ -@(#)Copyright (c) 1990 Imperial College of Science, Technology & Medicine\n\ -@(#)Copyright (c) 1990 The Regents of the University of California.\n\ -@(#)All rights reserved.\n"; -#if __GNUC__ < 2 -static char rcsid[] = "$Id: amq.c,v 1.7.2.9 2004/01/06 03:15:16 ezk Exp $"; -static char sccsid[] = "%W% (Berkeley) %G%"; -#endif /* __GNUC__ < 2 */ -#endif /* not lint */ - #ifdef HAVE_CONFIG_H # include <config.h> #endif /* HAVE_CONFIG_H */ @@ -115,8 +101,8 @@ show_mti(amq_mount_tree *mt, enum show_opt e, int *mwid, int *dwid, int *twid) case Full: { - struct tm *tp = localtime((time_t *) &mt->mt_mounttime); - printf("%-*.*s %-*.*s %-*.*s %s\n\t%-5d %-7d %-6d %-7d %-7d %-6d %02d/%02d/%02d %02d:%02d:%02d\n", + struct tm *tp = localtime((time_t *) ((voidp) &mt->mt_mounttime)); + printf("%-*.*s %-*.*s %-*.*s %s\n\t%-5d %-7d %-6d %-7d %-7d %-6d %02d/%02d/%04d %02d:%02d:%02d\n", *dwid, *dwid, *mt->mt_directory ? mt->mt_directory : "/", /* XXX */ *twid, *twid, @@ -132,16 +118,16 @@ show_mti(amq_mount_tree *mt, enum show_opt e, int *mwid, int *dwid, int *twid) mt->mt_readlink, mt->mt_statfs, - tp->tm_year > 99 ? tp->tm_year - 100 : tp->tm_year, tp->tm_mon + 1, tp->tm_mday, + tp->tm_year < 1900 ? tp->tm_year + 1900 : tp->tm_year, tp->tm_hour, tp->tm_min, tp->tm_sec); } break; case Stats: { - struct tm *tp = localtime((time_t *) &mt->mt_mounttime); - printf("%-*.*s %-5d %-7d %-6d %-7d %-7d %-6d %02d/%02d/%02d %02d:%02d:%02d\n", + struct tm *tp = localtime((time_t *) ((voidp) &mt->mt_mounttime)); + printf("%-*.*s %-5d %-7d %-6d %-7d %-7d %-6d %02d/%02d/%02d %02d:%02d:%04d\n", *dwid, *dwid, *mt->mt_directory ? mt->mt_directory : "/", /* XXX */ @@ -152,8 +138,8 @@ show_mti(amq_mount_tree *mt, enum show_opt e, int *mwid, int *dwid, int *twid) mt->mt_readlink, mt->mt_statfs, - tp->tm_year > 99 ? tp->tm_year - 100 : tp->tm_year, tp->tm_mon + 1, tp->tm_mday, + tp->tm_year < 1900 ? tp->tm_year + 1900 : tp->tm_year, tp->tm_hour, tp->tm_min, tp->tm_sec); } break; @@ -181,7 +167,7 @@ show_mti(amq_mount_tree *mt, enum show_opt e, int *mwid, int *dwid, int *twid) * Display a pwd data */ static void -show_pwd(amq_mount_tree *mt, char *path, int *flag) +show_pwd(amq_mount_tree *mt, char *path, size_t l, int *flag) { int len; @@ -189,13 +175,13 @@ show_pwd(amq_mount_tree *mt, char *path, int *flag) len = strlen(mt->mt_mountpoint); if (NSTREQ(path, mt->mt_mountpoint, len) && !STREQ(mt->mt_directory, mt->mt_mountpoint)) { - char buf[MAXPATHLEN+1]; - strcpy(buf, mt->mt_directory); - strcat(buf, &path[len]); - strcpy(path, buf); + char buf[MAXPATHLEN+1]; /* must be same size as 'path' */ + xstrlcpy(buf, mt->mt_directory, sizeof(buf)); + xstrlcat(buf, &path[len], sizeof(buf)); + xstrlcpy(path, buf, l); *flag = 1; } - show_pwd(mt->mt_next, path, flag); + show_pwd(mt->mt_next, path, l, flag); mt = mt->mt_child; } } @@ -218,7 +204,7 @@ show_mt(amq_mount_tree *mt, enum show_opt e, int *mwid, int *dwid, int *pwid) static void show_mi(amq_mount_info_list *ml, enum show_opt e, int *mwid, int *dwid, int *twid) { - int i; + u_int i; switch (e) { @@ -448,7 +434,8 @@ Usage: %s [-fmpsvwHTU] [-h hostname] [-l log_file|\"syslog\"]\n\ am_get_progname(), server); exit(1); } - memset(&server_addr, 0, sizeof server_addr); + memset(&server_addr, 0, sizeof(server_addr)); + /* as per POSIX, sin_len need not be set (used internally by kernel) */ server_addr.sin_family = AF_INET; if (hp) { memmove((voidp) &server_addr.sin_addr, (voidp) hp->h_addr, @@ -554,7 +541,8 @@ Usage: %s [-fmpsvwHTU] [-h hostname] [-l log_file|\"syslog\"]\n\ char *wd = getcwd(path, MAXPATHLEN+1); amq_mount_tree_list *mlp = amqproc_export_1((voidp) 0, clnt); amq_mount_tree_p mt; - int i, flag; + u_int i; + int flag; if (!wd) { perror("getcwd"); @@ -564,7 +552,7 @@ Usage: %s [-fmpsvwHTU] [-h hostname] [-l log_file|\"syslog\"]\n\ mt = mlp->amq_mount_tree_list_val[i]; while (1) { flag = 0; - show_pwd(mt, path, &flag); + show_pwd(mt, path, sizeof(path), &flag); if (!flag) { printf("%s\n", path); break; @@ -678,8 +666,9 @@ Usage: %s [-fmpsvwHTU] [-h hostname] [-l log_file|\"syslog\"]\n\ if (mlp) { enum show_opt e = Calc; int mwid = 0, dwid = 0, pwid = 0; + while (e != ShowDone) { - int i; + u_int i; for (i = 0; i < mlp->amq_mount_tree_list_len; i++) { show_mt(mlp->amq_mount_tree_list_val[i], e, &mwid, &dwid, &pwid); diff --git a/contrib/amd/amq/amq.h b/contrib/amd/amq/amq.h index 4e2d78566b68..2f36b8194456 100644 --- a/contrib/amd/amq/amq.h +++ b/contrib/amd/amq/amq.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: amq.h,v 1.14.2.4 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amq/amq.h * */ @@ -59,5 +58,6 @@ extern amq_mount_info_list *amqproc_getmntfs_1(voidp argp, CLIENT *rqstp); extern int *amqproc_mount_1(voidp argp, CLIENT *rqstp); extern amq_string *amqproc_getvers_1(voidp argp, CLIENT *rqstp); extern int *amqproc_getpid_1(voidp argp, CLIENT *rqstp); +extern amq_string *amqproc_pawd_1(amq_string *argp, CLIENT *rqstp); #endif /* not _AMQ_H */ diff --git a/contrib/amd/amq/amq_clnt.c b/contrib/amd/amq/amq_clnt.c index 37de00add895..ddfeb675c99b 100644 --- a/contrib/amd/amq/amq_clnt.c +++ b/contrib/amd/amq/amq_clnt.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: amq_clnt.c,v 1.3.2.4 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amq/amq_clnt.c * */ @@ -76,7 +75,7 @@ amqproc_mnttree_1(amq_string *argp, CLIENT *clnt) memset((char *) &res, 0, sizeof(res)); if (clnt_call(clnt, AMQPROC_MNTTREE, (XDRPROC_T_TYPE) xdr_amq_string, (SVC_IN_ARG_TYPE) argp, - (XDRPROC_T_TYPE) xdr_amq_mount_tree_p, (SVC_IN_ARG_TYPE) & res, + (XDRPROC_T_TYPE) xdr_amq_mount_tree_p, (SVC_IN_ARG_TYPE) &res, TIMEOUT) != RPC_SUCCESS) { return (NULL); } @@ -109,7 +108,7 @@ amqproc_stats_1(voidp argp, CLIENT *clnt) if (clnt_call(clnt, AMQPROC_STATS, (XDRPROC_T_TYPE) xdr_void, argp, (XDRPROC_T_TYPE) xdr_amq_mount_stats, - (SVC_IN_ARG_TYPE) & res, + (SVC_IN_ARG_TYPE) &res, TIMEOUT) != RPC_SUCCESS) { return (NULL); } @@ -126,7 +125,7 @@ amqproc_export_1(voidp argp, CLIENT *clnt) if (clnt_call(clnt, AMQPROC_EXPORT, (XDRPROC_T_TYPE) xdr_void, argp, (XDRPROC_T_TYPE) xdr_amq_mount_tree_list, - (SVC_IN_ARG_TYPE) & res, TIMEOUT) != RPC_SUCCESS) { + (SVC_IN_ARG_TYPE) &res, TIMEOUT) != RPC_SUCCESS) { return (NULL); } return (&res); @@ -141,7 +140,7 @@ amqproc_setopt_1(amq_setopt *argp, CLIENT *clnt) memset((char *) &res, 0, sizeof(res)); if (clnt_call(clnt, AMQPROC_SETOPT, (XDRPROC_T_TYPE) xdr_amq_setopt, (SVC_IN_ARG_TYPE) argp, (XDRPROC_T_TYPE) xdr_int, - (SVC_IN_ARG_TYPE) & res, TIMEOUT) != RPC_SUCCESS) { + (SVC_IN_ARG_TYPE) &res, TIMEOUT) != RPC_SUCCESS) { return (NULL); } return (&res); @@ -156,7 +155,7 @@ amqproc_getmntfs_1(voidp argp, CLIENT *clnt) memset((char *) &res, 0, sizeof(res)); if (clnt_call(clnt, AMQPROC_GETMNTFS, (XDRPROC_T_TYPE) xdr_void, argp, (XDRPROC_T_TYPE) xdr_amq_mount_info_list, - (SVC_IN_ARG_TYPE) & res, TIMEOUT) != RPC_SUCCESS) { + (SVC_IN_ARG_TYPE) &res, TIMEOUT) != RPC_SUCCESS) { return (NULL); } return (&res); @@ -170,7 +169,7 @@ amqproc_mount_1(voidp argp, CLIENT *clnt) memset((char *) &res, 0, sizeof(res)); if (clnt_call(clnt, AMQPROC_MOUNT, (XDRPROC_T_TYPE) xdr_amq_string, argp, - (XDRPROC_T_TYPE) xdr_int, (SVC_IN_ARG_TYPE) & res, + (XDRPROC_T_TYPE) xdr_int, (SVC_IN_ARG_TYPE) &res, TIMEOUT) != RPC_SUCCESS) { return (NULL); } @@ -185,7 +184,7 @@ amqproc_getvers_1(voidp argp, CLIENT *clnt) memset((char *) &res, 0, sizeof(res)); if (clnt_call(clnt, AMQPROC_GETVERS, (XDRPROC_T_TYPE) xdr_void, argp, - (XDRPROC_T_TYPE) xdr_amq_string, (SVC_IN_ARG_TYPE) & res, + (XDRPROC_T_TYPE) xdr_amq_string, (SVC_IN_ARG_TYPE) &res, TIMEOUT) != RPC_SUCCESS) { return (NULL); } @@ -200,7 +199,23 @@ amqproc_getpid_1(voidp argp, CLIENT *clnt) memset((char *) &res, 0, sizeof(res)); if (clnt_call(clnt, AMQPROC_GETPID, (XDRPROC_T_TYPE) xdr_void, argp, - (XDRPROC_T_TYPE) xdr_int, (SVC_IN_ARG_TYPE) & res, + (XDRPROC_T_TYPE) xdr_int, (SVC_IN_ARG_TYPE) &res, + TIMEOUT) != RPC_SUCCESS) { + return (NULL); + } + return (&res); +} + + +amq_string * +amqproc_pawd_1(amq_string *argp, CLIENT *clnt) +{ + static amq_string res; + + memset((char *) &res, 0, sizeof(res)); + if (clnt_call(clnt, AMQPROC_PAWD, + (XDRPROC_T_TYPE) xdr_amq_string, (SVC_IN_ARG_TYPE) argp, + (XDRPROC_T_TYPE) xdr_amq_string, (SVC_IN_ARG_TYPE) &res, TIMEOUT) != RPC_SUCCESS) { return (NULL); } diff --git a/contrib/amd/amq/amq_xdr.c b/contrib/amd/amq/amq_xdr.c index 835b98d9ba88..692a0a408607 100644 --- a/contrib/amd/amq/amq_xdr.c +++ b/contrib/amd/amq/amq_xdr.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: amq_xdr.c,v 1.3.2.4 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amq/amq_xdr.c * */ @@ -107,11 +106,17 @@ xdr_amq_mount_tree(XDR *xdrs, amq_mount_tree *objp) return (FALSE); } - if (!xdr_pointer(xdrs, (char **) &objp->mt_next, sizeof(amq_mount_tree), (XDRPROC_T_TYPE) xdr_amq_mount_tree)) { + if (!xdr_pointer(xdrs, + (char **) ((voidp) &objp->mt_next), + sizeof(amq_mount_tree), + (XDRPROC_T_TYPE) xdr_amq_mount_tree)) { return (FALSE); } - if (!xdr_pointer(xdrs, (char **) &objp->mt_child, sizeof(amq_mount_tree), (XDRPROC_T_TYPE) xdr_amq_mount_tree)) { + if (!xdr_pointer(xdrs, + (char **) ((voidp) &objp->mt_child), + sizeof(amq_mount_tree), + (XDRPROC_T_TYPE) xdr_amq_mount_tree)) { return (FALSE); } @@ -122,7 +127,10 @@ xdr_amq_mount_tree(XDR *xdrs, amq_mount_tree *objp) bool_t xdr_amq_mount_tree_p(XDR *xdrs, amq_mount_tree_p *objp) { - if (!xdr_pointer(xdrs, (char **) objp, sizeof(amq_mount_tree), (XDRPROC_T_TYPE) xdr_amq_mount_tree)) { + if (!xdr_pointer(xdrs, + (char **) objp, + sizeof(amq_mount_tree), + (XDRPROC_T_TYPE) xdr_amq_mount_tree)) { return (FALSE); } return (TRUE); @@ -169,7 +177,7 @@ bool_t xdr_amq_mount_info_list(XDR *xdrs, amq_mount_info_list *objp) { if (!xdr_array(xdrs, - (char **) &objp->amq_mount_info_list_val, + (char **) ((voidp) &objp->amq_mount_info_list_val), (u_int *) &objp->amq_mount_info_list_len, ~0, sizeof(amq_mount_info), @@ -184,7 +192,7 @@ bool_t xdr_amq_mount_tree_list(XDR *xdrs, amq_mount_tree_list *objp) { if (!xdr_array(xdrs, - (char **) &objp->amq_mount_tree_list_val, + (char **) ((voidp) &objp->amq_mount_tree_list_val), (u_int *) &objp->amq_mount_tree_list_len, ~0, sizeof(amq_mount_tree_p), diff --git a/contrib/amd/amq/pawd.1 b/contrib/amd/amq/pawd.1 index d7ddebd1fc9f..73a16b59b555 100644 --- a/contrib/amd/amq/pawd.1 +++ b/contrib/amd/amq/pawd.1 @@ -1,5 +1,5 @@ .\" -.\" Copyright (c) 1997-2004 Erez Zadok +.\" Copyright (c) 1997-2006 Erez Zadok .\" Copyright (c) 1990 Jan-Simon Pendry .\" Copyright (c) 1990 Imperial College of Science, Technology & Medicine .\" Copyright (c) 1990 The Regents of the University of California. @@ -38,7 +38,7 @@ .\" .\" %W% (Berkeley) %G% .\" -.\" $Id: pawd.1,v 1.3.2.4 2004/01/06 03:15:16 ezk Exp $ +.\" $Id: pawd.1,v 1.9.2.1 2006/01/02 18:48:24 ezk Exp $ .\" .TH PAWD 1 "6 Jan 1998" .SH NAME @@ -70,3 +70,21 @@ arguments. .BR amd (8), .BR amq (8), .BR pwd (1). +.LP +``am-utils'' +.BR info (1) +entry. +.LP +.I "Linux NFS and Automounter Administration" +by Erez Zadok, ISBN 0-7821-2739-8, (Sybex, 2001). +.LP +.I http://www.am-utils.org +.LP +.I "Amd \- The 4.4 BSD Automounter" +.SH AUTHORS +Erez Zadok <ezk@cs.sunysb.edu>, Computer Science Department, Stony Brook +University, Stony Brook, New York, USA. +.P +Other authors and contributors to am-utils are listed in the +.B AUTHORS +file distributed with am-utils. diff --git a/contrib/amd/amq/pawd.c b/contrib/amd/amq/pawd.c index 2d655d05cda4..c9a32b16189b 100644 --- a/contrib/amd/amq/pawd.c +++ b/contrib/amd/amq/pawd.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: pawd.c,v 1.6.2.4 2004/01/06 03:15:16 ezk Exp $ + * File: am-utils/amq/pawd.c * */ @@ -58,48 +57,11 @@ #include <am_defs.h> #include <amq.h> + /* statics */ -static char *localhost="localhost"; -static char newdir[MAXPATHLEN]; +static char *localhost = "localhost"; static char transform[MAXPATHLEN]; -static int -find_mt(amq_mount_tree *mt, char *dir) -{ - while (mt) { - if (STREQ(mt->mt_type, "link") || - STREQ(mt->mt_type, "nfs") || - STREQ(mt->mt_type, "nfsl")) { - int len = strlen(mt->mt_mountpoint); - if (NSTREQ(mt->mt_mountpoint, dir, len) && - ((dir[len] == '\0') || (dir[len] == '/'))) { - char tmp_buf[MAXPATHLEN]; - strcpy(tmp_buf, mt->mt_directory); - strcat(tmp_buf, &dir[len]); - strcpy(newdir, tmp_buf); - return 1; - } - } - if (find_mt(mt->mt_next,dir)) - return 1; - mt = mt->mt_child; - } - return 0; -} - - -static int -find_mlp(amq_mount_tree_list *mlp, char *dir) -{ - int i; - - for (i = 0; i < mlp->amq_mount_tree_list_len; i++) { - if (find_mt(mlp->amq_mount_tree_list_val[i], dir)) - return 1; - } - return 0; -} - #ifdef HAVE_CNODEID static char * @@ -160,7 +122,8 @@ hack_name(char *dir) fprintf(stderr, "partition %s, username %s\n", partition, username); #endif /* DEBUG */ - sprintf(hesiod_lookup, "%s.homes-remote", username); + xsnprintf(hesiod_lookup, sizeof(hesiod_lookup), + "%s.homes-remote", username); hes = hes_resolve(hesiod_lookup, "amd"); if (!hes) return NULL; @@ -184,9 +147,10 @@ hack_name(char *dir) #ifdef DEBUG fprintf(stderr, "A match, munging....\n"); #endif /* DEBUG */ - strcpy(transform, "/home/"); - strcat(transform, username); - if (*ch) strcat(transform, ch); + xstrlcpy(transform, "/home/", sizeof(transform)); + xstrlcat(transform, username, sizeof(transform)); + if (*ch) + xstrlcat(transform, ch, sizeof(transform)); #ifdef DEBUG fprintf(stderr, "Munged to <%s>\n", transform); #endif /* DEBUG */ @@ -216,8 +180,9 @@ transform_dir(char *dir) int s = RPC_ANYSOCK; CLIENT *clnt; struct hostent *hp; - amq_mount_tree_list *mlp; struct timeval tmo = {10, 0}; + char *dummystr; + amq_string *spp; #ifdef DISK_HOME_HACK if (ch = hack_name(dir)) @@ -230,31 +195,37 @@ transform_dir(char *dir) server = localhost; #endif /* not HAVE_CNODEID */ - if ((hp = gethostbyname(server)) == 0) + if ((hp = gethostbyname(server)) == NULL) return dir; memset(&server_addr, 0, sizeof(server_addr)); + /* as per POSIX, sin_len need not be set (used internally by kernel) */ server_addr.sin_family = AF_INET; server_addr.sin_addr = *(struct in_addr *) hp->h_addr; clnt = clntudp_create(&server_addr, AMQ_PROGRAM, AMQ_VERSION, tmo, &s); - if (clnt == 0) + if (clnt == NULL) + clnt = clnttcp_create(&server_addr, AMQ_PROGRAM, AMQ_VERSION, &s, 0, 0); + if (clnt == NULL) return dir; - strcpy(transform,dir); - while ( (mlp = amqproc_export_1((voidp)0, clnt)) && - find_mlp(mlp,transform) ) { - strcpy(transform,newdir); + xstrlcpy(transform, dir, sizeof(transform)); + dummystr = transform; + spp = amqproc_pawd_1((amq_string *) &dummystr, clnt); + if (spp && *spp && **spp) { + xstrlcpy(transform, *spp, sizeof(transform)); + XFREE(*spp); } + clnt_destroy(clnt); return transform; } /* getawd() is a substitute for getwd() which transforms the path */ static char * -getawd(char *path) +getawd(char *path, size_t l) { #ifdef HAVE_GETCWD - char *wd = getcwd(path, MAXPATHLEN+1); + char *wd = getcwd(path, MAXPATHLEN); #else /* not HAVE_GETCWD */ char *wd = getwd(path); #endif /* not HAVE_GETCWD */ @@ -262,7 +233,7 @@ getawd(char *path) if (wd == NULL) { return NULL; } - strcpy(path, transform_dir(wd)); + xstrlcpy(path, transform_dir(wd), l); return path; } @@ -273,7 +244,7 @@ main(int argc, char *argv[]) char tmp_buf[MAXPATHLEN], *wd; if (argc == 1) { - wd = getawd(tmp_buf); + wd = getawd(tmp_buf, sizeof(tmp_buf)); if (wd == NULL) { fprintf(stderr, "pawd: %s\n", tmp_buf); exit(1); diff --git a/contrib/amd/aux_conf.h.in b/contrib/amd/aux_conf.h.in index dbae5bd22071..8c38bbfac5f1 100644 --- a/contrib/amd/aux_conf.h.in +++ b/contrib/amd/aux_conf.h.in @@ -25,6 +25,8 @@ */ #define UNMOUNT_TRAP(mnt) @am_utils_unmount_call@(@am_utils_unmount_args@) /* End of replaced UNMOUNT_TRAP macro definition */ +/* umount(8) executable path, for type:=program */ +#define UNMOUNT_PROGRAM "@UNMOUNT_PROGRAM@" /* * The next line is a literal inclusion of a file which includes a diff --git a/contrib/amd/bootstrap b/contrib/amd/bootstrap index f28953662a64..6c351382caa5 100755 --- a/contrib/amd/bootstrap +++ b/contrib/amd/bootstrap @@ -23,7 +23,7 @@ if [ ! -f m4/macros/HEADER ]; then fi # remove any remaining autom4te.cache directory -rm -fr autom4te.cache +rm -fr autom4te.cache autom4te-*.cache # generate acinclude.m4 file echo "AMU: prepare acinclude.m4..." diff --git a/contrib/amd/conf/checkmount/checkmount_bsd44.c b/contrib/amd/conf/checkmount/checkmount_bsd44.c index abe8831d0b31..a6ec2438da88 100644 --- a/contrib/amd/conf/checkmount/checkmount_bsd44.c +++ b/contrib/amd/conf/checkmount/checkmount_bsd44.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: checkmount_bsd44.c,v 1.3.2.4 2004/01/06 03:15:19 ezk Exp $ + * File: am-utils/conf/checkmount/checkmount_bsd44.c * */ diff --git a/contrib/amd/conf/mtab/mtab_bsd.c b/contrib/amd/conf/mtab/mtab_bsd.c index efe817a48e76..fe3991aa575d 100644 --- a/contrib/amd/conf/mtab/mtab_bsd.c +++ b/contrib/amd/conf/mtab/mtab_bsd.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: mtab_bsd.c,v 1.3.2.5 2004/01/06 03:15:19 ezk Exp $ + * File: am-utils/conf/mtab/mtab_bsd.c * */ diff --git a/contrib/amd/conf/nfs_prot/nfs_prot_freebsd2.h b/contrib/amd/conf/nfs_prot/nfs_prot_freebsd2.h index e59602bb8cf9..cf7ba33ee47b 100644 --- a/contrib/amd/conf/nfs_prot/nfs_prot_freebsd2.h +++ b/contrib/amd/conf/nfs_prot/nfs_prot_freebsd2.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: nfs_prot_freebsd2.h,v 1.3.2.4 2004/01/06 03:15:19 ezk Exp $ + * File: am-utils/conf/nfs_prot/nfs_prot_freebsd2.h * */ diff --git a/contrib/amd/conf/nfs_prot/nfs_prot_freebsd3.h b/contrib/amd/conf/nfs_prot/nfs_prot_freebsd3.h index 4260080fa808..edcc57540fee 100644 --- a/contrib/amd/conf/nfs_prot/nfs_prot_freebsd3.h +++ b/contrib/amd/conf/nfs_prot/nfs_prot_freebsd3.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: nfs_prot_freebsd3.h,v 1.5.2.7 2004/01/06 03:15:19 ezk Exp $ + * File: am-utils/conf/nfs_prot/nfs_prot_freebsd3.h * */ @@ -55,6 +54,13 @@ # include <nfs/nfs.h> #endif /* HAVE_NFS_NFS_H */ #ifdef HAVE_UFS_UFS_UFSMOUNT_H +# ifdef HAVE_UFS_UFS_EXTATTR_H +/* + * Define a dummy struct ufs_extattr_per_mount, which is used in struct + * ufsmount in <ufs/ufs/ufsmount.h>. + */ +struct ufs_extattr_per_mount; +# endif /* HAVE_UFS_UFS_EXTATTR_H */ # include <ufs/ufs/ufsmount.h> #endif /* HAVE_UFS_UFS_UFSMOUNT_H */ @@ -166,22 +172,16 @@ typedef writeargs nfswriteargs; # define MOUNT_NFS3 "nfs" /* is this right? */ # define MNTOPT_NFS3 "nfs" +# ifndef HAVE_XDR_LOOKUP3RES /* - * as of 3.0-RELEASE the nfs_fh3 that is defined in the system headers - * (or the one generated by rpcgen) lacks the proper full definition, - * listed below. A special macro (m4/macros/struct_nfs_fh3.m4) searches - * for this special name before other names. + * FreeBSD uses different field names than are defined on most other + * systems. */ -struct nfs_fh3_freebsd3 { - u_int fh3_length; - union nfs_fh3_u { - struct nfs_fh3_i { - fhandle_t fh3_i; - } nfs_fh3_i; - char data[NFS3_FHSIZE]; - } fh3_u; -}; -typedef struct nfs_fh3_freebsd3 nfs_fh3_freebsd3; +# define AMU_LOOKUP3RES_OK(x) ((x)->LOOKUP3res_u.resok) +# define AMU_LOOKUP3RES_FAIL(x) ((x)->LOOKUP3res_u.resfail) +# define AMU_LOOKUP3RES_FH_LEN(x) (AMU_LOOKUP3RES_OK(x).object.data.data_len) +# define AMU_LOOKUP3RES_FH_DATA(x) (AMU_LOOKUP3RES_OK(x).object.data.data_val) +# endif /* not HAVE_XDR_LOOKUP3RES */ #endif /* NFSMNT_NFSV3 */ diff --git a/contrib/amd/conf/sa_dref/sa_dref_bsd44.h b/contrib/amd/conf/sa_dref/sa_dref_bsd44.h index e76c16b7b8b5..a8075401477e 100644 --- a/contrib/amd/conf/sa_dref/sa_dref_bsd44.h +++ b/contrib/amd/conf/sa_dref/sa_dref_bsd44.h @@ -3,3 +3,4 @@ (dst)->addr = (struct sockaddr *) (src); \ (dst)->addrlen = sizeof(*src); \ } +#define NFS_ARGS_T_ADDR_IS_POINTER 1 diff --git a/contrib/amd/conf/transp/transp_sockets.c b/contrib/amd/conf/transp/transp_sockets.c index 23ed3f7f11da..025e1f3e3cf2 100644 --- a/contrib/amd/conf/transp/transp_sockets.c +++ b/contrib/amd/conf/transp/transp_sockets.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: transp_sockets.c,v 1.6.2.11 2004/01/06 03:15:20 ezk Exp $ + * File: am-utils/conf/transp/transp_sockets.c * * Socket specific utilities. * -Erez Zadok <ezk@cs.columbia.edu> @@ -55,18 +54,67 @@ * find the IP address that can be used to connect to the local host */ void -amu_get_myaddress(struct in_addr *iap) +amu_get_myaddress(struct in_addr *iap, const char *preferred_localhost) { + struct hostent *hp; + char dq[20]; + +#ifdef DEBUG_off +#error this code is old and probably not useful any longer. +#error Erez, Jan 21, 2004. struct sockaddr_in sin; + /* + * Most modern systems should use 127.0.0.1 as the localhost address over + * which you can do NFS mounts. In the past we found that some NFS + * clients may not allow mounts from localhost. So we used + * get_myaddress() and that seemed to work. Alas, on some other systems, + * get_myaddress() may return one of the interface addresses at random, + * and thus use a less efficient IP address than 127.0.0.1. The solution + * is to hard-code 127.0.0.1, but still check if get_myaddress() returns a + * different value and warn about it. + */ memset((char *) &sin, 0, sizeof(sin)); get_myaddress(&sin); - iap->s_addr = sin.sin_addr.s_addr; + if (sin.sin_addr.s_addr != htonl(INADDR_LOOPBACK)) + dlog("amu_get_myaddress: myaddress conflict (0x%x vs. 0x%lx)", + sin.sin_addr.s_addr, (u_long) htonl(INADDR_LOOPBACK)); +#endif /* DEBUG_off */ + + if (preferred_localhost == NULL) + goto out; + + /* if specified preferred locahost, then try to use it */ + hp = gethostbyname(preferred_localhost); + if (hp == NULL) { + /* XXX: if hstrerror()/h_errno aren't portable, then need to port the next statement */ + plog(XLOG_ERROR, "Unable to resolve localhost_address \"%s\" (%s): using default", + preferred_localhost, hstrerror(h_errno)); + goto out; + } + if (hp->h_addr_list == NULL) { + plog(XLOG_ERROR, "localhost_address \"%s\" has no IP addresses: using default", + preferred_localhost); + goto out; + } + if (hp->h_addr_list[1] != NULL) { + plog(XLOG_ERROR, "localhost_address \"%s\" has more than one IP addresses: using first", + preferred_localhost); + goto out; + } + memmove((voidp) &iap->s_addr, (voidp) hp->h_addr_list[0], sizeof(iap->s_addr)); + plog(XLOG_INFO, "localhost_address \"%s\" requested, using %s", + preferred_localhost, inet_dquad(dq, sizeof(dq), iap->s_addr)); + return; + + out: + iap->s_addr = htonl(INADDR_LOOPBACK); } /* * How to bind to reserved ports. + * Note: if *pp is non-null and is greater than 0, then *pp will not be modified. */ int bind_resv_port(int so, u_short *pp) @@ -78,16 +126,21 @@ bind_resv_port(int so, u_short *pp) memset((voidp) &sin, 0, sizeof(sin)); sin.sin_family = AF_INET; - port = IPPORT_RESERVED; - - do { - --port; - sin.sin_port = htons(port); + if (pp && *pp > 0) { + sin.sin_port = htons(*pp); rc = bind(so, (struct sockaddr *) &sin, sizeof(sin)); - } while (rc < 0 && (int) port > IPPORT_RESERVED / 2); + } else { + port = IPPORT_RESERVED; - if (pp && rc == 0) - *pp = port; + do { + --port; + sin.sin_port = htons(port); + rc = bind(so, (struct sockaddr *) &sin, sizeof(sin)); + } while (rc < 0 && (int) port > IPPORT_RESERVED / 2); + + if (pp && rc == 0) + *pp = port; + } return rc; } @@ -161,9 +214,7 @@ get_mount_client(char *unused_host, struct sockaddr_in *sin, struct timeval *tv, *sock = RPC_ANYSOCK; return NULL; } -#ifdef DEBUG dlog("get_mount_client: Using udp, port %d", sin->sin_port); -#endif /* DEBUG */ return client; } @@ -175,7 +226,19 @@ struct sockaddr_in * amu_svc_getcaller(SVCXPRT *xprt) { /* glibc 2.2 returns a sockaddr_storage ??? */ - return (struct sockaddr_in *)svc_getcaller(xprt); + return (struct sockaddr_in *) svc_getcaller(xprt); +} + + +/* + * register an RPC server + */ +int +amu_svc_register(SVCXPRT *xprt, u_long prognum, u_long versnum, + void (*dispatch)(struct svc_req *rqstp, SVCXPRT *transp), + u_long protocol, struct netconfig *dummy) +{ + return svc_register(xprt, prognum, versnum, dispatch, protocol); } @@ -188,21 +251,28 @@ create_nfs_service(int *soNFSp, u_short *nfs_portp, SVCXPRT **nfs_xprtp, void (* *soNFSp = socket(AF_INET, SOCK_DGRAM, 0); - if (*soNFSp < 0 || bind_resv_port(*soNFSp, NULL) < 0) { + if (*soNFSp < 0 || bind_resv_port(*soNFSp, nfs_portp) < 0) { plog(XLOG_FATAL, "Can't create privileged nfs port (socket)"); + if (*soNFSp >= 0) + close(*soNFSp); return 1; } if ((*nfs_xprtp = svcudp_create(*soNFSp)) == NULL) { plog(XLOG_FATAL, "cannot create rpc/udp service"); + close(*soNFSp); return 2; } if ((*nfs_portp = (*nfs_xprtp)->xp_port) >= IPPORT_RESERVED) { plog(XLOG_FATAL, "Can't create privileged nfs port"); + svc_destroy(*nfs_xprtp); + close(*soNFSp); return 1; } if (!svc_register(*nfs_xprtp, NFS_PROGRAM, NFS_VERSION, dispatch_fxn, 0)) { plog(XLOG_FATAL, "unable to register (%ld, %ld, 0)", (u_long) NFS_PROGRAM, (u_long) NFS_VERSION); + svc_destroy(*nfs_xprtp); + close(*soNFSp); return 3; } @@ -214,7 +284,13 @@ create_nfs_service(int *soNFSp, u_short *nfs_portp, SVCXPRT **nfs_xprtp, void (* * Create the amq service for amd (both TCP and UDP) */ int -create_amq_service(int *udp_soAMQp, SVCXPRT **udp_amqpp, int *tcp_soAMQp, SVCXPRT **tcp_amqpp) +create_amq_service(int *udp_soAMQp, + SVCXPRT **udp_amqpp, + struct netconfig **dummy1, + int *tcp_soAMQp, + SVCXPRT **tcp_amqpp, + struct netconfig **dummy2, + u_short preferred_amq_port) { /* first create TCP service */ if (tcp_soAMQp) { @@ -224,11 +300,25 @@ create_amq_service(int *udp_soAMQp, SVCXPRT **udp_amqpp, int *tcp_soAMQp, SVCXPR return 1; } + /* next, bind to a specific (TCP) port if asked for */ + if (preferred_amq_port > 0) { + /* + * Note: if &preferred_amq_port is non-null and is greater than 0, + * then the pointer will not be modified. We don't want it to be + * modified because it was passed down to create_amq_service as a + * non-pointer (a variable on the stack, not to be modified!) + */ + if (bind_resv_port(*tcp_soAMQp, &preferred_amq_port) < 0) { + plog(XLOG_FATAL, "can't bind amq service to requested TCP port %d: %m)", preferred_amq_port); + return 1; + } + } + /* now create RPC service handle for amq */ if (tcp_amqpp && (*tcp_amqpp = svctcp_create(*tcp_soAMQp, AMQ_SIZE, AMQ_SIZE)) == NULL) { plog(XLOG_FATAL, "cannot create tcp service for amq: soAMQp=%d", *tcp_soAMQp); - return 2; + return 1; } #ifdef SVCSET_CONNMAXREC @@ -240,7 +330,7 @@ create_amq_service(int *udp_soAMQp, SVCXPRT **udp_amqpp, int *tcp_soAMQp, SVCXPR # ifndef RPC_MAXDATASIZE # define RPC_MAXDATASIZE 9000 # endif /* not RPC_MAXDATASIZE */ - { + if (tcp_amqpp) { int maxrec = RPC_MAXDATASIZE; SVC_CONTROL(*tcp_amqpp, SVCSET_CONNMAXREC, &maxrec); } @@ -252,14 +342,26 @@ create_amq_service(int *udp_soAMQp, SVCXPRT **udp_amqpp, int *tcp_soAMQp, SVCXPR *udp_soAMQp = socket(AF_INET, SOCK_DGRAM, 0); if (*udp_soAMQp < 0) { plog(XLOG_FATAL, "cannot create udp socket for amq service: %m"); - return 3; + return 1; + } + + /* next, bind to a specific (UDP) port if asked for */ + if (preferred_amq_port > 0) { + /* + * Note: see comment about using &preferred_amq_port above in this + * function. + */ + if (bind_resv_port(*udp_soAMQp, &preferred_amq_port) < 0) { + plog(XLOG_FATAL, "can't bind amq service to requested UDP port %d: %m)", preferred_amq_port); + return 1; + } } /* now create RPC service handle for amq */ if (udp_amqpp && (*udp_amqpp = svcudp_bufcreate(*udp_soAMQp, AMQ_SIZE, AMQ_SIZE)) == NULL) { plog(XLOG_FATAL, "cannot create udp service for amq: soAMQp=%d", *udp_soAMQp); - return 4; + return 1; } } @@ -268,34 +370,47 @@ create_amq_service(int *udp_soAMQp, SVCXPRT **udp_amqpp, int *tcp_soAMQp, SVCXPR /* - * Ping the portmapper on a remote system by calling the nullproc + * Check if the portmapper is running and reachable: 0==down, 1==up */ -enum clnt_stat -pmap_ping(struct sockaddr_in *address) +int check_pmap_up(char *host, struct sockaddr_in* sin) { CLIENT *client; enum clnt_stat clnt_stat = RPC_TIMEDOUT; /* assume failure */ int socket = RPC_ANYSOCK; struct timeval timeout; - timeout.tv_sec = 3; + timeout.tv_sec = 2; timeout.tv_usec = 0; - address->sin_port = htons(PMAPPORT); - client = clntudp_create(address, PMAPPROG, PMAPVERS, timeout, &socket); - if (client != (CLIENT *) NULL) { - clnt_stat = clnt_call(client, - PMAPPROC_NULL, - (XDRPROC_T_TYPE) xdr_void, - NULL, - (XDRPROC_T_TYPE) xdr_void, - NULL, - timeout); - clnt_destroy(client); + sin->sin_port = htons(PMAPPORT); + client = clntudp_create(sin, PMAPPROG, PMAPVERS, timeout, &socket); + + if (client == (CLIENT *) NULL) { + plog(XLOG_ERROR, + "check_pmap_up: cannot create connection to contact portmapper on host \"%s\"%s", + host, clnt_spcreateerror("")); + return 0; } + + timeout.tv_sec = 6; + /* Ping the portmapper on a remote system by calling the nullproc */ + clnt_stat = clnt_call(client, + PMAPPROC_NULL, + (XDRPROC_T_TYPE) xdr_void, + NULL, + (XDRPROC_T_TYPE) xdr_void, + NULL, + timeout); + clnt_destroy(client); close(socket); - address->sin_port = 0; + sin->sin_port = 0; - return clnt_stat; + if (clnt_stat == RPC_TIMEDOUT) { + plog(XLOG_ERROR, + "check_pmap_up: failed to contact portmapper on host \"%s\": %s", + host, clnt_sperrno(clnt_stat)); + return 0; + } + return 1; } @@ -310,6 +425,7 @@ get_nfs_version(char *host, struct sockaddr_in *sin, u_long nfs_version, const c enum clnt_stat clnt_stat; struct timeval tv; int sock; + char *errstr; /* * If not set or set wrong, then try from NFS_VERS_MAX on down. If @@ -319,23 +435,15 @@ get_nfs_version(char *host, struct sockaddr_in *sin, u_long nfs_version, const c nfs_version = NFS_VERS_MAX; again = 1; } - tv.tv_sec = 3; /* retry every 3 seconds, but also timeout */ + tv.tv_sec = 2; /* retry every 2 seconds, but also timeout */ tv.tv_usec = 0; - /* - * First check if remote portmapper is up (verify if remote host is up). - */ - clnt_stat = pmap_ping(sin); - if (clnt_stat == RPC_TIMEDOUT) { - plog(XLOG_ERROR, "get_nfs_version: failed to contact portmapper on host \"%s\": %s", host, clnt_sperrno(clnt_stat)); - return 0; - } - #ifdef HAVE_FS_NFS3 try_again: #endif /* HAVE_FS_NFS3 */ sock = RPC_ANYSOCK; + errstr = NULL; if (STREQ(proto, "tcp")) clnt = clnttcp_create(sin, NFS_PROGRAM, nfs_version, &sock, 0, 0); else if (STREQ(proto, "udp")) @@ -343,45 +451,90 @@ try_again: else clnt = NULL; - if (clnt == NULL) { + if (clnt != NULL) { + /* Try three times (6/2=3) to verify the CLIENT handle. */ + tv.tv_sec = 6; + clnt_stat = clnt_call(clnt, + NFSPROC_NULL, + (XDRPROC_T_TYPE) xdr_void, + 0, + (XDRPROC_T_TYPE) xdr_void, + 0, + tv); + + if (clnt_stat != RPC_SUCCESS) + errstr = clnt_sperrno(clnt_stat); + + close(sock); + clnt_destroy(clnt); + } else { #ifdef HAVE_CLNT_SPCREATEERROR - plog(XLOG_INFO, "get_nfs_version NFS(%d,%s) failed for %s: %s", - (int) nfs_version, proto, host, clnt_spcreateerror("")); + errstr = clnt_spcreateerror(""); #else /* not HAVE_CLNT_SPCREATEERROR */ - plog(XLOG_INFO, "get_nfs_version NFS(%d,%s) failed for %s", - (int) nfs_version, proto, host); + errstr = ""; #endif /* not HAVE_CLNT_SPCREATEERROR */ - return 0; } - /* Try a couple times to verify the CLIENT handle. */ - tv.tv_sec = 6; - clnt_stat = clnt_call(clnt, - NFSPROC_NULL, - (XDRPROC_T_TYPE) xdr_void, - 0, - (XDRPROC_T_TYPE) xdr_void, - 0, - tv); - close(sock); - clnt_destroy(clnt); - if (clnt_stat != RPC_SUCCESS) { + if (errstr) { + plog(XLOG_INFO, "get_nfs_version NFS(%d,%s) failed for %s%s", + (int) nfs_version, proto, host, errstr); if (again) { #ifdef HAVE_FS_NFS3 if (nfs_version == NFS_VERSION3) { - plog(XLOG_INFO, "get_nfs_version trying a lower version"); nfs_version = NFS_VERSION; again = 0; + plog(XLOG_INFO, "get_nfs_version trying a lower version: NFS(%d,%s)", (int) nfs_version, proto); } goto try_again; #endif /* HAVE_FS_NFS3 */ } - plog(XLOG_INFO, "get_nfs_version NFS(%d,%s) failed for %s", - (int) nfs_version, proto, host); return 0; } - plog(XLOG_INFO, "get_nfs_version: returning (%d,%s) on host %s", + plog(XLOG_INFO, "get_nfs_version: returning NFS(%d,%s) on host %s", (int) nfs_version, proto, host); return nfs_version; } + + +#if defined(HAVE_FS_AUTOFS) && defined(AUTOFS_PROG) +/* + * Register the autofs service for amd + */ +int +register_autofs_service(char *autofs_conftype, void (*autofs_dispatch)(struct svc_req *rqstp, SVCXPRT *transp)) +{ + int autofs_socket; + SVCXPRT *autofs_xprt = NULL; + + autofs_socket = socket(AF_INET, SOCK_DGRAM, 0); + + if (autofs_socket < 0 || bind_resv_port(autofs_socket, NULL) < 0) { + plog(XLOG_FATAL, "Can't create privileged autofs port (socket)"); + return 1; + } + if ((autofs_xprt = svcudp_create(autofs_socket)) == NULL) { + plog(XLOG_FATAL, "Can't create autofs rpc/udp service"); + return 2; + } + if (autofs_xprt->xp_port >= IPPORT_RESERVED) { + plog(XLOG_FATAL, "Can't create privileged autofs port"); + return 1; + } + if (!svc_register(autofs_xprt, AUTOFS_PROG, AUTOFS_VERS, autofs_dispatch, 0)) { + plog(XLOG_FATAL, "unable to register (%ld, %ld, 0)", + (u_long) AUTOFS_PROG, (u_long) AUTOFS_VERS); + return 3; + } + + return 0; /* all is well */ +} + + +int +unregister_autofs_service(char *autofs_conftype) +{ + svc_unregister(AUTOFS_PROG, AUTOFS_VERS); + return 0; +} +#endif /* HAVE_FS_AUTOFS && AUTOFS_PROG */ diff --git a/contrib/amd/conf/umount/umount_bsd44.c b/contrib/amd/conf/umount/umount_bsd44.c index 6ac4c0396259..d05944d8f788 100644 --- a/contrib/amd/conf/umount/umount_bsd44.c +++ b/contrib/amd/conf/umount/umount_bsd44.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: umount_bsd44.c,v 1.3.2.4 2004/01/06 03:15:20 ezk Exp $ + * File: am-utils/conf/umount/umount_bsd44.c * */ @@ -54,12 +53,12 @@ int -umount_fs(char *fs_name, const char *mnttabname) +umount_fs(char *mntdir, const char *mnttabname, u_int unmount_flags) { int error; eintr: - error = unmount(fs_name, 0); + error = unmount(mntdir, 0); if (error < 0) error = errno; @@ -67,23 +66,55 @@ eintr: case EINVAL: case ENOTBLK: case ENOENT: - plog(XLOG_WARNING, "unmount: %s is not mounted", fs_name); + plog(XLOG_WARNING, "unmount: %s is not mounted", mntdir); error = 0; /* Not really an error */ break; case EINTR: -#ifdef DEBUG /* not sure why this happens, but it does. ask kirk one day... */ - dlog("%s: unmount: %m", fs_name); -#endif /* DEBUG */ + dlog("%s: unmount: %m", mntdir); goto eintr; -#ifdef DEBUG +#ifdef MNT2_GEN_OPT_FORCE + case EBUSY: + case EIO: + case ESTALE: + /* caller determines if forced unmounts should be used */ + if (unmount_flags & AMU_UMOUNT_FORCE) { + error = umount2_fs(mntdir, unmount_flags); + if (error < 0) + error = errno; + else + return error; + } + /* fallthrough */ +#endif /* MNT2_GEN_OPT_FORCE */ + default: - dlog("%s: unmount: %m", fs_name); + dlog("%s: unmount: %m", mntdir); break; -#endif /* DEBUG */ } return error; } + + +#ifdef MNT2_GEN_OPT_FORCE +/* force unmount, no questions asked, without touching mnttab file */ +int +umount2_fs(const char *mntdir, u_int unmount_flags) +{ + int error = 0; + if (unmount_flags & AMU_UMOUNT_FORCE) { + plog(XLOG_INFO, "umount2_fs: trying unmount/forced on %s", mntdir); + error = unmount(mntdir, MNT2_GEN_OPT_FORCE); + if (error < 0 && (errno == EINVAL || errno == ENOENT)) + error = 0; /* ignore EINVAL/ENOENT */ + if (error < 0) + plog(XLOG_WARNING, "%s: unmount/force: %m", mntdir); + else + dlog("%s: unmount/force: OK", mntdir); + } + return error; +} +#endif /* MNT2_GEN_OPT_FORCE */ diff --git a/contrib/amd/doc/am-utils.texi b/contrib/amd/doc/am-utils.texi index 65d1af30cc02..1cc46b608bae 100644 --- a/contrib/amd/doc/am-utils.texi +++ b/contrib/amd/doc/am-utils.texi @@ -1,6 +1,6 @@ \input texinfo @c -*-texinfo-*- @c -@c Copyright (c) 1997-2004 Erez Zadok +@c Copyright (c) 1997-2006 Erez Zadok @c Copyright (c) 1989 Jan-Simon Pendry @c Copyright (c) 1989 Imperial College of Science, Technology & Medicine @c Copyright (c) 1989 The Regents of the University of California. @@ -36,15 +36,15 @@ @c LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY @c OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF @c -@c %W% (Berkeley) %G% @c -@c $Id: am-utils.texi,v 1.21.2.32 2004/01/21 04:04:58 ib42 Exp $ +@c File: am-utils/doc/am-utils.texi @c @setfilename am-utils.info @include version.texi @c info directory entry +@dircategory Administration @direntry * Am-utils: (am-utils). The Amd automounter suite of utilities @end direntry @@ -60,7 +60,7 @@ (Originally by Jan-Simon Pendry and Nick Williams) @page -Copyright @copyright{} 1997-2004 Erez Zadok +Copyright @copyright{} 1997-2006 Erez Zadok @* Copyright @copyright{} 1989 Jan-Simon Pendry @* @@ -93,7 +93,7 @@ For version @value{VERSION}, @value{UPDATED} @* (Originally by Jan-Simon Pendry and Nick Williams) -Copyright @copyright{} 1997-2004 Erez Zadok +Copyright @copyright{} 1997-2006 Erez Zadok @* Copyright @copyright{} 1989 Jan-Simon Pendry @* @@ -117,12 +117,13 @@ tools within Am-utils. * License:: Explains the terms and conditions for using and distributing Am-utils. * Distrib:: How to get the latest Am-utils distribution. +* AddInfo:: How to get additional information. * Intro:: An introduction to Automounting concepts. * History:: History of am-utils' development. * Overview:: An overview of Amd. * Supported Platforms:: Machines and Systems supported by Amd. -* Mount Maps:: Details of mount maps -* Amd Command Line Options:: All the Amd command line options explained. +* Mount Maps:: Details of mount maps. +* Amd Command Line Options:: All the Amd command line options explained. * Filesystem Types:: The different mount types supported by Amd. * Amd Configuration File:: The amd.conf file syntax and meaning. * Run-time Administration:: How to start, stop and control Amd. @@ -131,7 +132,7 @@ tools within Am-utils. * Assorted Tools:: Other tools which come with am-utils. * Examples:: Some examples showing how Amd might be used. * Internals:: Implementation details. -* Acknowledgments & Trademarks:: Legal Notes +* Acknowledgments & Trademarks:: Legal Notes. Indexes * Index:: An item for each concept. @@ -207,7 +208,7 @@ ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. @c ################################################################ -@node Distrib, Intro, License, Top +@node Distrib, AddInfo, License, Top @unnumbered Source Distribution @cindex Source code distribution @cindex Obtaining the source code @@ -236,29 +237,40 @@ Revision 6.0 was made independently by @email{ezk@@cs.columbia.edu,Erez Zadok} at the Computer Science Department of @uref{http://www.cs.columbia.edu/,Columbia University}, as part of his -@uref{http://www.cs.columbia.edu/~ezk/research/tp/thesis_proposal.html,PhD +@uref{http://www.fsl.cs.sunysb.edu/docs/zadok-thesis-proposal/,PhD thesis work}. Am-utils (especially version 6.1) continues to be developed and maintained at the @uref{http://www.cs.sunysb.edu/,Computer Science Department} of @uref{http://www.stonybrook.edu/,Stony Brook University}, as a service to the user community. + @xref{History}, for more details. +@c ################################################################ +@node AddInfo, Intro, Distrib, Top +@unnumbered Getting Additional Information +@cindex Getting Additional Information + @unnumberedsec Bug Reports @cindex Bug reports Before reporting a bug, see if it is a known one in the -@uref{http://www.am-utils.org/BUGS.txt,bugs} file. -Send all bug reports to @email{am-utils@@am-utils.org} -quoting the details of the release and your configuration. These can be -obtained by running the command @samp{amd -v}. It would greatly help if -you could provide a reproducible procedure for detecting the bug you are +@uref{http://www.am-utils.org/docs/am-utils/BUGS.txt,bugs} file. + +If you find a problem and hopefully you can reproduce it, please +describe it in detail and +@uref{https://bugzilla.filesystems.org/,submit a bug report} via +@uref{http://www.bugzilla.org/,Bugzilla}. Alternatively, you can send +your bug report to @email{am-utils@@am-utils.org} quoting the details +of the release and your configuration. These details can be obtained +by running the command @samp{amd -v}. It would greatly help if you +could provide a reproducible procedure for detecting the bug you are reporting. Providing working patches is highly encouraged. Every patch incorporated, however small, will get its author an honorable mention in -the @uref{http://www.am-utils.org/AUTHORS.txt,authors +the @uref{http://www.am-utils.org/docs/am-utils/AUTHORS.txt,authors file}. @unnumberedsec Mailing Lists @@ -343,7 +355,7 @@ geared toward Linux users, it is general enough for any Unix administrator and contains specific sections for non-Linux systems. @c ################################################################ -@node Intro, History, Distrib, Top +@node Intro, History, AddInfo, Top @unnumbered Introduction @cindex Introduction @@ -377,7 +389,7 @@ numerous flavors of Unix. The @i{Amd} package has been without an official maintainer since 1992. Several people have stepped in to maintain it unofficially. Most notable were the `upl' (Unofficial Patch Level) releases of @i{Amd}, -created by me (@email{ezk@@cs.columbia.edu,Erez Zadok}), and available from +created by me (@email{ezk@@cs.sunysb.edu,Erez Zadok}), and available from @url{ftp://ftp.am-utils.org/pub/amd/}. The last such unofficial release was `upl102'. @@ -409,6 +421,15 @@ necessary to remove old or unused features, change various syntax files, etc. However, great care was taken to ensure the maximum possible backwards compatibility. +Am-utils version 6.1 has autofs support for Linux and Solaris 2.5+ as +@i{the} major new feature, in addition to several other minor new +features. The autofs support is completely transparent to the +end-user, aside from the fact that @code{/bin/pwd} now always returns +the correct amd-ified path. The administrator can easily switch +between NFS and autofs mounts by changing one parameter in +@code{amd.conf}. Autofs support and maintenance was developed in +conjunction with @email{ionut@@badula.org,Ion Badulescu}. + @c ################################################################ @node Overview, Supported Platforms, History, Top @chapter Overview @@ -426,12 +447,12 @@ is loaded with additional features which have little practical use. At some point the infrequently used components may be removed to streamline the production system. -@c @i{Amd} supports the notion of @dfn{replicated} filesystems by evaluating -@c each member of a list of possible filesystem locations in parallel. -@c @i{Amd} checks that each cached mapping remains valid. Should a mapping be -@c lost -- such as happens when a fileserver goes down -- @i{Amd} automatically -@c selects a replacement should one be available. -@c +@i{Amd} supports the notion of @dfn{replicated} filesystems by evaluating +each member of a list of possible filesystem locations one by one. +@i{Amd} checks that each cached mapping remains valid. Should a mapping be +lost -- such as happens when a fileserver goes down -- @i{Amd} automatically +selects a replacement should one be available. + @menu * Fundamentals:: * Filesystems and Volumes:: @@ -635,7 +656,11 @@ Option, -w}) or the @i{amd.conf} parameter @samp{dismount_interval} value on a per-mount basis (@pxref{opts Option, opts, opts}). Filesystems can be forcefully timed out using the @i{Amq} command. -@xref{Run-time Administration}. +@xref{Run-time Administration}. Note that on new enough systems that +support forced unmounts, such as Linux, @i{Amd} can try to use the +@b{umount2}(2) system call to force the unmount, if the regular +@b{umount}(2) system call failed in a way that indicates that the +mount point is hung or stale. @xref{forced_unmounts Parameter}. @node Keep-alives, Non-blocking Operation, Automatic Unmounting, Overview @comment node-name, next, previous, up @@ -667,7 +692,8 @@ While the server state is uncertain the requests are re-transmitted at three second intervals and if no reply is received after four attempts the server is marked down. If a reply is received the fileserver is marked up and stays in that state for 30 seconds at which time another -NFS ping is sent. +NFS ping is sent. This interval is configurable and can even be +turned off using the @i{ping} option. @xref{opts Option}. Once a fileserver is marked down, requests continue to be sent every 30 seconds in order to determine when the fileserver comes back up. During @@ -738,457 +764,6 @@ machines, as well as 32 bit and 64 bit architectures. Furthermore, when readily portable to the same Operating System on all platforms on which it is available. -The table below lists those platforms supported by the latest release. -The listing is based on the standard output from GNU's -@code{config.guess} script. Since significant changes have been made to -am-utils, not all systems listed here have been verified working for all -features. - -@multitable {Auto-Configured System Name} {Config} {Compile} {Amd} {NFS3} {Shlib} {Hlfsd} -@c @multitable @columnfractions .5 .1 .1 .1 .1 .1 - -@item @b{Auto-Configured System Name} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab @b{Config} @tab @b{Compile} @tab @b{Amd} @tab @b{NFS3} @tab @b{Shlib} @tab @b{Hlfsd} - -@item @b{alpha-dec-osf2.1} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab ? @tab no @tab ? - -@item @b{alpha-dec-osf4.0} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{alpha-dec-osf4.0f} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{alpha-dec-osf5.1} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{alphaev5-unknown-linux-gnu} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{alphaev5-unknown-linux-gnu-rh5.2} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{alphaev6-dec-osf5.0} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{hppa1.0-hp-hpux11.00} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab no @tab yes @tab yes - -@item @b{hppa1.1-hp-hpux10.10} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab no @tab ? - -@item @b{hppa1.1-hp-hpux10.20} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab no @tab no @tab ? - -@item @b{hppa1.1-hp-hpux11.00} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab UDP @tab yes @tab yes - -@item @b{hppa1.1-hp-hpux9.01} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{hppa1.1-hp-hpux9.05} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{hppa1.1-hp-hpux9.07} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{hppa2.0w-hp-hpux11.00} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{i386-pc-bsdi2.1} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab no @tab ? - -@item @b{i386-pc-bsdi3.0} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab no @tab ? - -@item @b{i386-pc-bsdi3.1} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab no @tab ? - -@item @b{i386-pc-bsdi4.0} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{i386-pc-bsdi4.0.1} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{i386-pc-bsdi4.1} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{i386-pc-linux-rh7.2} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab yes - -@item @b{i386-pc-solaris2.5.1} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab yes - -@item @b{i386-pc-solaris2.6} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab yes - -@item @b{i386-pc-solaris2.7} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab yes - -@item @b{i386-unknown-freebsd2.1.0} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab ? @tab ? - -@item @b{i386-unknown-freebsd2.2.1} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{i386-unknown-freebsd2.2.6} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{i386-unknown-freebsd2.2.7} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{i386-unknown-freebsd2.2.8} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{i386-unknown-freebsd3.0} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{i386-unknown-freebsd4.2} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{i386-unknown-freebsd4.4} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{i386-unknown-freebsd5.0} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{i386-unknown-freebsdelf3.0} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{i386-unknown-freebsdelf3.1} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{i386-unknown-freebsdelf3.2} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{i386-unknown-freebsdelf3.3} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{i386-unknown-freebsdelf3.4} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{i386-unknown-freebsdelf4.0} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{i386-unknown-netbsd1.2.1} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{i386-unknown-netbsd1.3} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{i386-unknown-netbsd1.3.1} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{i386-unknown-netbsd1.3.2} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{i386-unknown-netbsd1.3.3} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{i386-unknown-netbsd1.4} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{i386-unknown-netbsd1.4.1} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{i386-unknown-openbsd2.1} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{i386-unknown-openbsd2.2} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{i386-unknown-openbsd2.3} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{i386-unknown-openbsd2.4} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{i386-unknown-openbsd2.5} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{i486-ncr-sysv4.3.03} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab ? @tab yes @tab yes @tab ? - -@item @b{i486-pc-linux-gnu-rh6.0} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{i486-pc-linux-gnulibc1} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{i486-pc-linux-gnulibc1-rh4.2} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{i486-pc-linux-gnuoldld} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{i586-pc-linux-gnu} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{i586-pc-linux-gnu-rh5.2} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{i586-pc-linux-gnu-rh6.0} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{i586-pc-linux-gnu-rh6.1} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{i586-pc-linux-gnu-rh6.2} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{i586-pc-linux-gnulibc1} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{i586-pc-linux-gnulibc1-rh4.2} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{i686-pc-linux-gnu} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{i686-pc-linux-gnu-rh5.2} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{i686-pc-linux-gnu-rh6.0} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{i686-pc-linux-gnu-rh6.2} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab yes - -@item @b{i686-pc-linux-gnulibc} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{i686-pc-linux-gnulibc1} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{ia64-hp-hpux11.20} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{ia64-unknown-linux-rh2.1AS} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab yes - -@item @b{ia64-unknown-linux-rh2.1AW} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab yes - -@item @b{ia64-unknown-linux-rh7.1} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab yes - -@item @b{ia64-unknown-linux-rh7.2} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab yes - -@item @b{m68k-hp-hpux9.00} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab ? @tab ? - -@item @b{m68k-sun-sunos4.1.1} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab no @tab ? - -@item @b{m68k-next-nextstep3} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab no @tab ? - -@item @b{mips-dec-ultrix4.3} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab ? @tab ? - -@item @b{mips-sgi-irix5.2} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab ? @tab ? @tab ? @tab ? @tab ? @tab ? - -@item @b{mips-sgi-irix5.3} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{mips-sgi-irix6.2} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{mips-sgi-irix6.4} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{mips-sgi-irix6.5} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{powerpc-ibm-aix4.1.5.0} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab no/broken @tab ? - -@item @b{powerpc-ibm-aix4.2.1.0} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab no/broken @tab ? - -@item @b{powerpc-ibm-aix4.3.1.0} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab ? @tab yes @tab ? @tab ? - -@item @b{powerpc-unknown-linux-gnu} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{rs6000-ibm-aix3.2} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab ? @tab ? - -@item @b{rs6000-ibm-aix3.2.5} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab ? @tab ? - -@item @b{rs6000-ibm-aix4.1.4.0} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab no/broken @tab ? - -@item @b{rs6000-ibm-aix4.1.5.0} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab no/broken @tab ? - -@item @b{sparc-sun-solaris2.3} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{sparc-sun-solaris2.4} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{sparc-sun-solaris2.5} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@item @b{sparc-sun-solaris2.5.1} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab yes - -@item @b{sparc-sun-solaris2.6} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab yes - -@item @b{sparc-sun-solaris2.7} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab yes - -@item @b{sparc-sun-solaris2.8} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab yes - -@item @b{sparc-sun-sunos4.1.1} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{sparc-sun-sunos4.1.3} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{sparc-sun-sunos4.1.3C} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{sparc-sun-sunos4.1.3_U1} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{sparc-sun-sunos4.1.4} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{sparc-unknown-linux-gnulibc1} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{sparc-unknown-netbsd1.2E} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab ? @tab ? @tab ? - -@item @b{sparc-unknown-netbsd1.2G} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab ? @tab ? @tab ? - -@item @b{sparc64-unknown-linux-gnu} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab n/a @tab yes @tab ? - -@item @b{sparc64-unknown-linux-suse7.3} -@c {Config} {Compile} {Amd} {NFS V.3} {Shlib} {Hlfsd} -@tab yes @tab yes @tab yes @tab yes @tab yes @tab ? - -@end multitable - See the @file{INSTALL} in the distribution for more specific details on building and/or configuring for some systems. @@ -1265,8 +840,10 @@ list of map types configured on your machine. * Password maps:: * Union maps:: * LDAP maps:: +* Executable maps:: @end menu +@c ---------------------------------------------------------------- @node File maps, ndbm maps, Map Types, Map Types @comment node-name, next, previous, up @subsection File maps @@ -1321,6 +898,7 @@ file maps, or ndbm maps built with the @code{mk-amd-map} program. When caching is enabled, file maps have a default cache mode of @code{all} (@pxref{Automount Filesystem}). +@c ---------------------------------------------------------------- @node ndbm maps, NIS maps, File maps, Map Types @comment node-name, next, previous, up @subsection ndbm maps @@ -1334,8 +912,10 @@ be sharable across machine architectures. The notion of speed generally only applies to large maps; a small map, less than a single disk block, is almost certainly better implemented as a file map. -ndbm maps have a default cache mode of @samp{all} (@pxref{Automount Filesystem}). +ndbm maps have a default cache mode of @samp{all} +(@pxref{Automount Filesystem}). +@c ---------------------------------------------------------------- @node NIS maps, NIS+ maps, ndbm maps, Map Types @comment node-name, next, previous, up @subsection NIS maps @@ -1376,9 +956,10 @@ $(YPTSDIR)/amd.home.time: $(ETCDIR)/amd.home fi @end example -Here @code{$(YPTSDIR)} contains the time stamp files, and @code{$(YPDBDIR)} contains -the dbm format NIS files. +Here @code{$(YPTSDIR)} contains the time stamp files, and +@code{$(YPDBDIR)} contains the dbm format NIS files. +@c ---------------------------------------------------------------- @node NIS+ maps, Hesiod maps, NIS maps, Map Types @comment node-name, next, previous, up @subsection NIS+ maps @@ -1389,6 +970,7 @@ enabled, have a default cache mode of @samp{inc}. XXX: FILL IN WITH AN EXAMPLE. +@c ---------------------------------------------------------------- @node Hesiod maps, Password maps, NIS+ maps, Map Types @comment node-name, next, previous, up @subsection Hesiod maps @@ -1414,6 +996,7 @@ jsp.homes.automount HS TXT "rfs:=/home/charm;rhost:=charm;sublink:=jsp" njw.homes.automount HS TXT "rfs:=/home/dylan/dk2;rhost:=dylan;sublink:=njw" @end example +@c ---------------------------------------------------------------- @node Password maps, Union maps, Hesiod maps, Map Types @comment node-name, next, previous, up @subsection Password maps @@ -1454,13 +1037,14 @@ Similarly, if the password file entry was /home/cc/sugar/mjh @end example -the map entry used by @i{Amd} would be +the map entry used by @i{Amd} would be @example rfs:=/home/sugar;rhost:=sugar.cc;sublink:=jsp @end example -@node Union maps, LDAP maps , Password maps, Map Types +@c ---------------------------------------------------------------- +@node Union maps, LDAP maps, Password maps, Map Types @comment node-name, next, previous, up @subsection Union maps @cindex Union file maps @@ -1475,7 +1059,8 @@ directories take precedence over earlier ones. The union filesystem type then uses the map cache to determine the union of the names in all the directories. -@node LDAP maps, , Union maps, Map Types +@c ---------------------------------------------------------------- +@node LDAP maps, Executable maps, Union maps, Map Types @comment node-name, next, previous, up @subsection LDAP maps @cindex LDAP maps @@ -1515,8 +1100,8 @@ dn: cn=amdmap amd.home[], CUCS cn : amdmap amd.home[] objectClass : amdmap amdmapName : amd.home -amdmapKey : -amdmapValue : +amdmapKey : +amdmapValue : dn: cn=amdmap amd.home[zing], CUCS cn : amdmap amd.home[zing] @@ -1526,8 +1111,42 @@ amdmapKey : zing amdmapValue : -rhost:=shekel host==shekel host!=shekel;type:=nfs @end example -@c subsection Gdbm +@c ---------------------------------------------------------------- +@node Executable maps, , LDAP maps, Map Types +@comment node-name, next, previous, up +@subsection Executable maps +@cindex Executable maps +An executable map is a dynamic map in which the keys and values for +the maps are generated on the fly by a program or script. The program +is expected to take a single parameter argument which is the key to +lookup. If the key is found, the program should print on stdout the +key-value pair that were found; if the key was not found, nothing +should be printed out. Below is an sample of such a map script: + +@example +#!/bin/sh +# executable map example +case "$1" in + "/defaults" ) + echo "/defaults type:=nfs;rfs:=filer" + ;; + "a" ) + echo "a type:=nfs;fs:=/tmp" + ;; + "b" ) + echo "b type:=link;fs:=/usr/local" + ;; + * ) # no match, echo nothing + ;; +esac +@end example + +@xref{exec_map_timeout Parameter}. + +@c ---------------------------------------------------------------- +@c subsection Gdbm +@c ---------------------------------------------------------------- @node Key Lookup, Location Format, Map Types, Mount Maps @comment node-name, next, previous, up @section How keys are looked up @@ -1611,10 +1230,17 @@ White space is only allowed, and is mandatory, where shown with non-terminal @i{white-space}. A @dfn{location-selection} is a list of possible volumes with which to -satisfy the request. @dfn{location-selection}s are separated by the -@samp{||} operator. The effect of this operator is to prevent use of +satisfy the request. Each @dfn{location-selection} is tried +sequentially, until either one succeeds or all fail. This, by the +way, is different from the historically documented behavior, which +claimed (falsely, at least for last 3 years) that @i{Amd} would +attempt to mount all @dfn{location-selection}s in parallel and the +first one to succeed would be used. + +@dfn{location-selection}s are optionally separated by the @samp{||} +operator. The effect of this operator is to prevent use of location-selections to its right if any of the location-selections on -its left were selected whether or not any of them were successfully +its left were selected, whether or not any of them were successfully mounted (@pxref{Selectors}).@refill The location-selection, and singleton @dfn{location-list}, @@ -1798,6 +1424,7 @@ The following selectors are currently implemented. * netgrpd Selector Function:: * in_network Selector Function:: * true Selector Function:: +* xhost Selector Function:: @end menu @c ---------------------------------------------------------------- @@ -1811,7 +1438,8 @@ The following selectors are currently implemented. The machine architecture which was automatically determined at compile time. The architecture type can be displayed by running the command -@samp{amd -v}. @xref{Supported Platforms}.@refill +@samp{amd -v}. You can override this value also using the @code{-A} +command line option. @xref{Supported Platforms}.@refill @c ---------------------------------------------------------------- @node autodir Selector Variable, byte Selector Variable, arch Selector Variable, Selectors @@ -2164,20 +1792,43 @@ Always evaluates to false. @i{ARG} is ignored. @cindex Mount selector; netgrp @cindex Selector; netgrp -If the current host as determined by the value of @code{$@{host@}} -(e.g., short host name) is a member of the netgroup @i{ARG}, this -selector evaluates to true. Otherwise it evaluates to false. +The argument @i{ARG} of this selector is a netgroup name followed +optionally by a comma and a host name. If the host name is not +specified, it defaults to @code{$@{host@}}. If the host name (short +name) is a member of the netgroup, this selector evaluates to +true. Otherwise it evaluates to false. For example, suppose you have a netgroup @samp{ppp-hosts}, and for -reasons of performance, these have a local @file{/home} partition, while -all other clients on the faster network can access a shared home -directory. A common map to use for both might look like the following: +reasons of performance, these have a local @file{/home} partition, +while all other clients on the faster network can access a shared home +directory. A common map to use for both might look like the +following: @example home/* netgrp(ppp-hosts);type:=link;fs:=/local/$@{key@} \ !netgrp(ppp-hosts);type:=nfs;rhost:=serv1;rfs:=/remote/$@{key@} @end example +A more complex example that takes advantage of the two argument netgrp +mount selector is given in the following scenario. Suppose one wants +to mount the local scratch space from a each host under +@file{scratch/<hostname>} and some hosts have their scratch space in a +different path than others. Hosts in the netgroup @samp{apple-hosts} +have their scratch space in the @file{/apple} path, where hosts in the +netgroup @samp{cherry-hosts} have their scratch space in the +@file{/cherry} path. For hosts that are neither in the +@samp{apple-hosts} or @samp{cherry-hosts} netgroups we want to make a +symlink pointing to nowhere but provide a descriptive error message in +the link destination: + +@example +scratch/* netgrp(apple-hosts,$@{/key@});type:=nfs;rhost:=$@{/key@};\ + rfs:="/apple" \ + netgrp(cherry-hosts,$@{/key@});type:=nfs;rhost:=$@{/key@};\ + rfs:="/cherry" \ + type:=link;rfs:="no local partition for $@{/key@}" +@end example + @c ---------------------------------------------------------------- @node netgrpd Selector Function, in_network Selector Function, netgrp Selector Function, Selectors @comment node-name, next, previous, up @@ -2188,14 +1839,15 @@ home/* netgrp(ppp-hosts);type:=link;fs:=/local/$@{key@} \ @cindex Mount selector; netgrpd @cindex Selector; netgrpd -If the current host as determined by the value of @code{$@{hostd@}} is a -member of the netgroup @i{ARG}, this selector evaluates to true. -Otherwise it evaluates to false. +The argument @i{ARG} of this selector is a netgroup name followed +optionally by a comma and a host name. If the host name is not +specified, it defaults to @code{$@{hostd@}}. If the host name +(fully-qualified name) is a member of the netgroup, this selector +evaluates to true. Otherwise it evaluates to false. -The @samp{netgrpd} function uses fully-qualified host names -(@code{$@{hostd@}}) to match netgroup names, while the @samp{netgrp} -function (@pxref{netgrp Selector Function}) uses short host names -(@code{$@{host@}}). +The @samp{netgrpd} function uses fully-qualified host names to match +netgroup names, while the @samp{netgrp} function (@pxref{netgrp +Selector Function}) uses short host names. @c ---------------------------------------------------------------- @node in_network Selector Function, true Selector Function, netgrpd Selector Function, Selectors @@ -2210,7 +1862,7 @@ function (@pxref{netgrp Selector Function}) uses short host names This selector matches against any network name or number with an optional netmask. First, if the current host has any network interface that is locally attached to the network specified in @i{ARG} (either via name or -number), this selector evaluates to true. +number), this selector evaluates to true. Second, @samp{in_network} supports a network/netmask syntax such as @samp{128.59.16.0/255.255.255.0}, @samp{128.59.16.0/24}, @@ -2233,7 +1885,7 @@ opt in_network(foo-net.site.com);rhost:=serv1;rfs:=/opt \ @end example @c ---------------------------------------------------------------- -@node true Selector Function, , in_network Selector Function, Selectors +@node true Selector Function, xhost Selector Function, in_network Selector Function, Selectors @comment node-name, next, previous, up @subsubsection true Selector Function @cindex true Selector Function @@ -2244,6 +1896,22 @@ opt in_network(foo-net.site.com);rhost:=serv1;rfs:=/opt \ Always evaluates to true. @i{ARG} is ignored. +@c ---------------------------------------------------------------- +@node xhost Selector Function, , true Selector Function, Selectors +@comment node-name, next, previous, up +@subsubsection xhost Selector Function +@cindex xhost Selector Function +@cindex xhost, boolean mount selector +@cindex !xhost, boolean mount selector +@cindex Mount selector; xhost +@cindex Selector; xhost +@cindex CNAMEs + +This function compares @i{ARG} against the current hostname, similarly +to the @ref{host Selector Variable}. However, this function will +also match if @i{ARG} is a CNAME (DNS Canonical Name, or alias) for +the current host's name. + @c ================================================================ @node Map Options, , Selectors, Location Format @comment node-name, next, previous, up @@ -2443,6 +2111,13 @@ UID 0, and GID 0. Useful for CD-ROMs formatted as ISO-9660. @cindex Mount flags; dev Allow local special devices on this filesystem. +@item dirmask=@var{n} +@cindex Mount flags; dirmask +For PCFS mounts, specify the maximum file permissions for directories +in the file system. See the @samp{mask} option's description for more +details. The mask value of @var{n} can be specified in decimal, +octal, or hexadecimal. + @item dumbtimr @cindex Mount flags; dumbtimr Turn off the dynamic retransmit timeout estimator. This may be useful @@ -2462,6 +2137,13 @@ Set ID of filesystem. Enable generations in ISO-9660 file systems. Generations allow you to see all versions of a given file. +@item group=@var{n} +@cindex Mount flags; group +For PCFS mounts, set the group of the files in the file system to +@var{n} (which can either be a group name or a GID number). The +default group is the group of the directory on which the file system +is being mounted. + @item grpid @cindex Mount flags; grpid Use BSD directory group-id semantics. @@ -2476,6 +2158,20 @@ Allow keyboard interrupts on hard mounts. @cindex Mount flags; lock Use the NFS locking protocol (default) +@item longname +@cindex Mount Flags; longname +For PCFS mounts, force Win95 long names. + +@item mask=@var{n} +@cindex Mount flags; mask +For PCFS mounts, specify the maximum file permissions for files in the +file system. For example, a mask of 755 specifies that, by default, +the owner should have read, write, and execute permissions for files, +but others should only have read and execute permissions. Only the +nine low-order bits of mask are used. The default mask is taken from +the directory on which the file system is being mounted. The mask +value of @var{n} can be specified in decimal, octal, or hexadecimal. + @item multi @cindex Mount flags; multi Perform multi-component lookup on files. @@ -2557,6 +2253,10 @@ Don't allow set-uid or set-gid executables on this filesystem. Strip the extension @samp{;#} from the version string of files recorded on an ISO-9660 CD-ROM. +@item nowin95 +@cindex Mount Flags; nowin95 +For PCFS mounts, completely ignore Win95 entries. + @item optionstr @cindex Mount flags; optionstr Under Solaris 8, provide the kernel a string of options to parse and @@ -2578,9 +2278,14 @@ Set the NFS port to @var{n}. @cindex Mount flags; posix Turn on POSIX static pathconf for mounts. +@item private +@cindex Mount flags; private +Use local locking instead of the NLM protocol, useful for IRIX 6 only. + @item proplist @cindex Mount flags; proplist -Support property lists (ACLs) for this mount, useful primarily for DU-4.0. +Support property lists (ACLs) for this mount, useful primarily for Tru64 +UNIX. @item proto=@var{s} @cindex Mount flags; proto @@ -2628,6 +2333,10 @@ NFS/UDP through a gateway or a slow link. @cindex Mount flags; rw Allow reads and writes on this filesystem. +@item shortname +@cindex Mount Flags; longname +For PCFS mounts, force old DOS short names only. + @item soft @cindex Mount flags; soft Give up after @dfn{retrans} retransmissions. @@ -2657,9 +2366,16 @@ support TCP/IP mounts. @cindex Mount flags; timeo The NFS timeout, in tenth-seconds, before a request is retransmitted. +@item user=@var{n} +@cindex Mount flags; user +For PCFS mounts, set the owner of the files in the file system to +@var{n} (which can either be a user name or a UID number). The +default owner is the owner of the directory on which the file system +is being mounted. + @item vers=@var{n} @cindex Mount flags; vers - Use NFS protocol version number @var{n} (can be 2 or 3). +Use NFS protocol version number @var{n} (can be 2 or 3). @item wsize=@var{n} @cindex Mount flags; wsize @@ -2686,14 +2402,50 @@ mounting local disks, floppies, and CD-ROMs). See also the related @cindex Mount flags; ping The interval, in seconds, between keep-alive pings. When four consecutive pings have failed the mount point is marked as hung. This -interval defaults to 30 seconds. If the ping interval is less than zero, -no pings are sent and the host is assumed to be always -up. By default, pings are not sent for an NFS/TCP mount. +interval defaults to 30 seconds; if the ping interval is set to zero, +@i{Amd} will use the default 30-second interval. If the interval is +set to -1 (or any other negative value), no pings are sent and the +host is assumed to be always up, which can cause unmounts to hang See +the @i{softlookup} option for a better alternative. Turning pings off +can be useful in NFS-HA (High-Availability) sites where the NFS +service rarely goes down. Setting the ping value to a large value can +reduce the amount of NFS_NULL chatter on your network considerably, +especially in large sites. + +Note that if you have multiple @i{Amd} entries using the same file +server, and each entry sets a different value of N, then each time Amd +mounts a new entry, the ping value will be re-evaluated (and updated, +turned off, or turned back on as needed). Finally, note that NFS_NULL +pings are sent for both UDP and TCP mounts, because even a hung TCP +mount can cause user processes to hang. + +@item public +@cindex Mount flags; public +Use WebNFS multi-component lookup on the public file handle instead of +the mount protocol to obtain NFS file handles, as documented in the +WebNFS Client Specification, RFC 2054. This means that @i{Amd} will not +attempt to contact the remote portmapper or remote mountd daemon, and +will only connect to the well-known NFS port 2049 or the port specified +with the @i{port} mount option, thus making it easier to use NFS through +a firewall. @item retry=@var{n} @cindex Mount flags; retry=@var{n} The number of times to retry the mount system call. +@item softlookup +@cindex Mount flags; softlookup +Configures @i{Amd}'s behavior with respect to already-mounted shares from +NFS fileservers that are unreachable. If softlookup is specified, +trying to access such a share will result in an error (EIO, which is +changed from the ENOENT 6.0 used to return). If it is not specified, a +regular symlink is provided and the access will probably hang +in the NFS filesystem. + +The default behavior depends on whether the mount is 'soft' or 'hard'; +softlookup can be used to change this default. This is changed from 6.0 +which always behaved as if softlookup was specified. + @item unmount @cindex Mount flags; unmount Configures the mount so that its time-to-live will indeed expire (and @@ -2706,11 +2458,18 @@ option. @item utimeout=@var{n} @cindex Mount flags; utimeout=@var{n} -The interval, in seconds, by which the mount's -time-to-live is extended after an unmount attempt -has failed. In fact the interval is extended before the unmount is -attempted to avoid thrashing. The default value is 120 seconds (two -minutes) or as set by the @code{-w} command line option. +The interval, in seconds, that looked up and mounted map entries are +cached. After that period of time, @i{Amd} will attempt to unmount +the entries. If, however, the unmount fails (with EBUSY), then +@i{Amd} will extend the mount's time-to-live by the @i{utimeout} value +before the next unmount attempt is made. In fact the interval is +extended before the unmount is attempted, to avoid thrashing. The +default value is 120 seconds (two minutes) or as set by the @code{-w} +command line option. + +@item xlatecookie +@cindex Mount flags; xlatecookie +Translate directory cookies between 32-long and 64-long lengths. @end table @@ -2797,7 +2556,7 @@ forks into the background. Note: Even if @i{Amd} has been built with @samp{-DDEBUG} (via @code{configure --enable-debug}), it will still background itself and disassociate itself from the controlling terminal. To use a debugger it -is necessary to specify @samp{-D nodaemon} on the command line. +is necessary to specify @samp{-D daemon} on the command line. However, even with all of this, mounts and unmounts are performed in the background, and @i{Amd} will always fork before doing them. Therefore, debugging what happens closely during un/mounts is more challenging. @@ -2823,13 +2582,14 @@ exists. * -w Option:: Wait interval after failed unmount. * -x Option:: Log options. * -y Option:: NIS domain. -* -C-Option:: Cluster name. -* -D-Option:: Debug flags. +* -A Option:: Operating system Architecture. +* -C Option:: Cluster name. +* -D Option:: Debug flags. * -F Option:: Amd configuration file. * -H Option:: Show brief help. -* -O-Option:: Operating system name. +* -O Option:: Operating system name. * -S Option:: Lock executable pages in memory. -* -T-Option:: Set tag for configuration file. +* -T Option:: Set tag for configuration file. @end menu @c ---------------------------------------------------------------- @@ -3017,7 +2777,7 @@ amd -p > /var/run/amd.pid ... @end example This option only has an affect if @i{Amd} is running in daemon mode. -If @i{Amd} is started with the @code{-D nodaemon} debug flag, this +If @i{Amd} is started with the @code{-D daemon} debug flag, this option is ignored. @c ---------------------------------------------------------------- @@ -3068,9 +2828,9 @@ Built by ezk@@cs.columbia.edu on date Wed Oct 22 15:21:03 EDT 1997. cpu=sparc (big-endian), arch=sun4, karch=sun4u. full_os=solaris2.5.1, os=sos5, osver=5.5.1, vendor=sun. Map support for: root, passwd, union, nisplus, nis, ndbm, file, error. -AMFS: nfs, link, nfsx, nfsl, host, linkx, program, union, inherit, +AMFS: nfs, link, nfsx, nfsl, host, linkx, program, union, inherit, ufs, lofs, hsfs, pcfs, auto, direct, toplvl, error. -FS: cachefs, cdfs, lofs, nfs, nfs3, pcfs, tfs, tmpfs, ufs. +FS: autofs, cachefs, cdfs, lofs, nfs, nfs3, pcfs, tfs, tmpfs, ufs. Network 1: wire="mcl-lab-net.cs.columbia.edu" (netnumber=128.59.13). Network 2: wire="14-net.cs.columbia.edu" (netnumber=128.59.14). Network 3: wire="old-net.cs.columbia.edu" (netnumber=128.59.16). @@ -3181,7 +2941,7 @@ If @i{Amd} was built with debugging enabled the @code{debug} option is automatically enabled regardless of the command line options. @c ---------------------------------------------------------------- -@node -y Option, -C-Option, -x Option, Amd Command Line Options +@node -y Option, -A Option, -x Option, Amd Command Line Options @comment node-name, next, previous, up @section @code{-y} @var{NIS-domain} @cindex NIS (YP) domain name @@ -3196,7 +2956,22 @@ immediately attempts to bind to a server for this domain. @c is specified, and whenever required in a mount map. @c ---------------------------------------------------------------- -@node -C-Option, -D-Option, -y Option, Amd Command Line Options +@node -A Option, -C Option, -y Option, Amd Command Line Options +@comment node-name, next, previous, up +@section @code{-A} @var{architecture} +@cindex Setting the operating system architecture + +Specifies the OS architecture of the system. +The only effect of this option is to set the variable @code{$@{arch@}}. + +This option would be used as follows: + +@example +amd -A i386 ... +@end example + +@c ---------------------------------------------------------------- +@node -C Option, -D Option, -A Option, Amd Command Line Options @comment node-name, next, previous, up @section @code{-C} @var{cluster-name} @cindex Cluster names @@ -3216,7 +2991,7 @@ amd -C `clustername` ... @end example @c ---------------------------------------------------------------- -@node -D-Option, -F Option, -C-Option, Amd Command Line Options +@node -D Option, -F Option, -C Option, Amd Command Line Options @comment node-name, next, previous, up @section @code{-D} @var{opts} @cindex Debug options @@ -3236,13 +3011,13 @@ can be prefixed with @samp{no} to turn it off. @table @code @item all -all options +all ``reasonable'' options (currently trace|str|full|mem|info|readdir) @item amq -register for amq +do not register for amq @item daemon -enter daemon mode +do not enter daemon mode @item fork -fork server +do not fork child worker (hlfsd only) @item full program trace @item hrtime @@ -3253,7 +3028,8 @@ print high resolution time stamps (only if @b{syslog}(3) is not used) info service specific debugging (hesiod, nis, etc.) In the case of hesiod maps, turns on the hesiod RES_DEBUG internal debugging option. @item mem -trace memory allocations +trace memory allocations. Needs to be explicitly enabled at compile +time with --enable-debug=mem. @item mtab use local @file{./mtab} file @item readdir @@ -3272,7 +3048,7 @@ You may also refer to the program source for a more detailed explanation of the available options. @c ---------------------------------------------------------------- -@node -F Option, -H Option, -D-Option, Amd Command Line Options +@node -F Option, -H Option, -D Option, Amd Command Line Options @comment node-name, next, previous, up @section @code{-F} @var{conf-file} @cindex Amd configuration file; specifying name @@ -3290,7 +3066,7 @@ options had been processed, regardless of the actual location of this option on the command line. @c ---------------------------------------------------------------- -@node -H Option, -O-Option, -F Option, Amd Command Line Options +@node -H Option, -O Option, -F Option, Amd Command Line Options @comment node-name, next, previous, up @section @code{-H} @cindex Displaying brief help @@ -3299,7 +3075,7 @@ option on the command line. Print a brief help and usage string. @c ---------------------------------------------------------------- -@node -O-Option, -S Option, -H Option, Amd Command Line Options +@node -O Option, -S Option, -H Option, Amd Command Line Options @comment node-name, next, previous, up @section @code{-O} @var{op-sys-name} @cindex Operating System name @@ -3312,14 +3088,16 @@ backward compatibility reasons. For example, if the build in name is older maps which were written with the latter in mind. @c ---------------------------------------------------------------- -@node -S Option, -T-Option, -O-Option, Amd Command Line Options +@node -S Option, -T Option, -O Option, Amd Command Line Options @comment node-name, next, previous, up @section @code{-S} @cindex plock; using +@cindex mlockall; using @cindex locking executable pages in memory Do @emph{not} lock the running executable pages of @i{Amd} into memory. To improve @i{Amd}'s performance, systems that support the @b{plock}(3) +or @b{mlockall}(2) call lock the @i{Amd} process into memory. This way there is less chance the operating system will schedule, page out, and swap the @i{Amd} process as needed. This tends to improve @i{Amd}'s performance, @@ -3328,12 +3106,12 @@ it unavailable for other processes). If this behavior is not desired, use the @code{-S} option. @c ---------------------------------------------------------------- -@node -T-Option, , -S Option, Amd Command Line Options +@node -T Option, , -S Option, Amd Command Line Options @comment node-name, next, previous, up @section @code{-T} @var{tag} @cindex Tags for Amd configuration file @cindex Configuration file; tags - + Specify a tag to use with @file{amd.conf}. All map entries tagged with @var{tag} will be processed. Map entries that are not tagged are always processed. Map entries that are tagged with a tag other than @var{tag} @@ -3431,16 +3209,24 @@ of file handles for remote file systems. The cache entries have a lifetime of a few minutes. If a required file handle is not in the cache, @i{Amd} sends a request -to the remote server to obtain it. @i{Amd} @dfn{does not} wait for -a response; it notes that one of the locations needs retrying, but -continues with any remaining locations. When the file handle becomes -available, and assuming none of the other locations was successfully -mounted, @i{Amd} will retry the mount. This mechanism allows several -NFS filesystems to be mounted in parallel. +to the remote server to obtain it. +@c @i{Amd} @dfn{does not} wait for +@c a response; it notes that one of the locations needs retrying, but +@c continues with any remaining locations. When the file handle becomes +@c available, and assuming none of the other locations was successfully +@c mounted, @i{Amd} will retry the mount. This mechanism allows several +@c NFS filesystems to be mounted in parallel. @c @footnote{The mechanism @c is general, however NFS is the only filesystem @c for which the required hooks have been written.} -The first one which responds with a valid file handle will be used. +@c The first one which responds with a valid file handle will be used. + +Historically, this documentation has maintained that @i{Amd} will try +all the locations in parallel and use the first one which responds +with a valid file handle. This has not been the case for quite some +time, however. Instead, @i{Amd} will go through each location, one by +one, and will only skip to the next one if the previous one either +fails or times out. @noindent An NFS entry might be: @@ -3536,8 +3322,12 @@ The @dfn{nfsx} (@samp{type:=nfsx}) filesystem allows a group of filesystems to b from a single NFS server. The implementation is layered above the @samp{nfs} implementation so keep-alives work in the same way. +@emph{WARNING}: @samp{nfsx} is meant to be a ``last resort'' kind of +solution. It is racy and poorly supported. The authors @emph{highly} +recommend that other solutions be considered before relying on it. + The options are the same as for the @samp{nfs} filesystem with one -difference. +difference for @samp{rfs}, as explained below. @noindent The following options should be specified: @@ -3563,7 +3353,7 @@ pub type:=nfsx;rhost:=gould;\ The first string defines the root of the tree, and is applied as a prefix to the remaining members of the list which define the individual filesystems. The first string is @emph{not} used as a filesystem name. -A parallel operation is used to determine the local mount points to +A serial operation is used to determine the local mount points to ensure a consistent layout of a tree of mounts. Here, the @emph{three} filesystems, @samp{/public}, @@ -3623,6 +3413,11 @@ ez1 type:=efs;dev:=/dev/xd0a ez2 type:=xfs;dev:=/dev/sd3c @end example +The UFS/XFS/EFS filesystems are never timed out by default, i.e. they +will never be unmounted by @i{Amd}. If automatic unmounting is +desired, the ``unmount'' option should be added to the mount options +for the entry. + @c ---------------------------------------------------------------- @node Caching Filesystem, CD-ROM Filesystem, Unix Filesystem, Filesystem Types @comment node-name, next, previous, up @@ -3662,6 +3457,10 @@ Access to the pathname @file{/import/copt} will follow a symbolic link to @file{/n/import/copt}. The latter is the mount point for a caching file system, that caches from @file{/import/opt} to @file{/cache}. +The cachefs filesystem is never timed out by default, i.e. it will +never be unmounted by @i{Amd}. If automatic unmounting is desired, the +``unmount'' option should be added to the mount options for the entry. + @b{Caveats}: @enumerate @item This file system is currently only implemented for Solaris 2.x! @@ -3851,7 +3650,7 @@ Remote Virtual Disk (RVD) which has a programmatic interface via the commands @samp{rvdmount} and @samp{rvdunmount}. @noindent -The following options must be specified: +Both of the following options must be specified: @table @code @cindex mount, mount option @@ -3860,29 +3659,47 @@ The following options must be specified: the program which will perform the mount. @cindex unmount, mount option +@cindex umount, mount option @cindex Mount option; unmount +@cindex Mount option; umount @item unmount -the program which will perform the unmount. +@item umount +the program which will perform the unmount. For convenience, you may +use either @samp{unmount} or @samp{umount} but not both. If neither +is defined, @i{Amd} will default to @samp{umount $@{fs@}} (the actual +unmount program pathname will be automatically determined at the time +GNU @code{configure} runs.) @end table The exit code from these two programs is interpreted as a Unix error code. As usual, exit code zero indicates success. To execute the -program @i{Amd} splits the string on whitespace to create an array of +program, @i{Amd} splits the string on whitespace to create an array of substrings. Single quotes @samp{'} can be used to quote whitespace if that is required in an argument. There is no way to escape or change -the quote character. +the single quote character. -To run the program @samp{rvdmount} with a host name and filesystem as -arguments would be specified by -@samp{fs:=$@{autodir@}$@{path@};mount:="/etc/rvdmount rvdmount fserver -$@{fs@}"}. +To run e.g. the program @samp{rvdmount} with a host name and filesystem as +arguments, it would be specified by +@samp{fs:=$@{autodir@}$@{path@};type:=program;mount:="/etc/rvdmount +rvdmount fserver $@{fs@}";unmount:="/etc/rdvumount rvdumount $@{fs@}"}. The first element in the array is taken as the pathname of the program -to execute. The other members of the array form the argument vector to -be passed to the program, @dfn{including argument zero}. This means -that the split string must have at least two elements. The program is -directly executed by @i{Amd}, not via a shell. This means that scripts -must begin with a @code{#!} interpreter specification. +to execute. The other members of the array form the argument vector +to be passed to the program, @dfn{including argument zero}. The array +is exactly the same as the array passed to the execv() system call +(man execv for details). The split string must have at least two +elements. The programs are directly executed by @i{Amd}, not via a +shell. Therefore, if a script is to be used as a mount/umount +program, it @dfn{must} begin with a @code{#!} interpreter specification. + +Often, this program mount type is used for Samba mounts, where you +need a double slash in pathnames. However, @i{Amd} normalizes +sequences of slashes into one slash. Therefore, you must use an +escaped slash, preceded by an escaped backslash. So to get a double +slash in the mount command, you need the eight character sequence +@samp{\\\/\\\/} in your map. For example: + +@samp{mount="/sbin/mount mount -r -t smbfs -o-N,-Ihostname \\\/\\\/guest@@venus/mp3"} If a filesystem type is to be heavily used, it may be worthwhile adding a new filesystem type into @i{Amd}, but for most uses the program @@ -3893,6 +3710,10 @@ from the current values used by @i{Amd}. Standard output is a duplicate of standard error. The value specified with the @code{-l} command line option has no effect on standard error. +@i{Amd} guarantees that the mountpoint will be created before calling +the mount program, and that it will be removed after the umount +program returns success. + @c ---------------------------------------------------------------- @node Symbolic Link Filesystem, Symbolic Link Filesystem II, Program Filesystem, Filesystem Types @comment node-name, next, previous, up @@ -3970,7 +3791,7 @@ entries. In this case, a list of possible targets can be given and The @dfn{nfsl} (@samp{type:=nfsl}) filesystem type is a combination of two others: @samp{link} and @samp{nfs}. If the local host name is equal to the -value of @code{$@{rhost@}}, or if the target pathname listed in +value of @code{$@{rhost@}} @emph{and} the target pathname listed in @code{$@{fs@}} exists, @samp{nfsl} will behave exactly as @samp{type:=link}, and refer to the target as a symbolic link. If the local host name is not equal to the value of @code{$@{rhost@}}, or if @@ -4103,13 +3924,17 @@ we are now stuck with it due to historical accident. @item pref alters the name that is looked up in the mount map. If -@code{$@{pref@}}, the @dfn{prefix}, is non-null then it is prepended to -the name requested by the kernel @dfn{before} the map is searched. +@code{$@{pref@}}, the @dfn{prefix}, is non-null then it is prepended +to the name requested by the kernel @dfn{before} the map is +searched. The default prefix is the prefix of the parent map (if any) +with name of the auto node appended to it. That means if you want no +prefix you must say so in the map: @samp{pref:=null}. @item opts Normally, @samp{auto} style maps are not browsable even if you turn on directory browsability (@pxref{browsable_dirs Parameter}). To enable -browsing entries in @samp{auto} maps, specify @samp{opts:=browsable} in +browsing entries in @samp{auto} maps, specify @samp{opts:=browsable} +or @samp{opts:=fullybrowsable} in the description of this map. @end table @@ -4160,6 +3985,18 @@ servers which export copies of the manual pages. Note that the key which is looked up is the name of the automount point without the leading @samp{/}. +Note that the implementation of the traditional @dfn{direct} filesystem is +essentially a hack (pretending that the root of an NFS filesystem is a +symlink) and many modern operating systems get very unhappy about +it. For example, Linux kernel 2.4+ completely disallows it, and Solaris +2.8 fails to unmount it when @i{Amd} shuts down. Therefore, the use of +the traditional @dfn{direct} filesystem is strongly discouraged; it is +only semi-supported, at best. + +The autofs implementations that permit direct mounts are fully +supported, however. That currently includes all versions of +Solaris. Linux autofs does NOT support direct mounts at all. + @c ---------------------------------------------------------------- @node Union Filesystem, Error Filesystem, Direct Automount Filesystem, Filesystem Types @comment node-name, next, previous, up @@ -4358,15 +4195,43 @@ specified only in the global section, it is applicable to all regular map sections that follow. @menu +* autofs_use_lofs Parameter:: * browsable_dirs Parameter:: +* map_defaults Parameter:: * map_options Parameter:: * map_type Parameter:: * mount_type Parameter:: * search_path Parameter:: +* selectors_in_defaults Parameter:: @end menu @c ---------------------------------------------------------------- -@node browsable_dirs Parameter, map_options Parameter, Common Parameters, Common Parameters +@node autofs_use_lofs Parameter, browsable_dirs Parameter, Common Parameters, Common Parameters +@comment node-name, next, previous, up +@subsection @t{autofs_use_lofs} Parameter +@cindex autofs_use_lofs Parameter + +(type=string, default=@samp{yes}). +When set to @samp{yes}, @i{Amd}'s autofs code will use lofs-type +(loopback) mounts for @code{type:=link} mounts, as well as several +other cases that require local references. This has the advantage +that @i{Amd} does not use a secondary mount point and users do not see +external pathnames (the infamous @code{/bin/pwd} problem, where it +reports a different path than the user chdir'ed into). One of the +disadvantages of using this option is that the autofs code is +relatively new and the in-place mounts have not been throughly tested. + +If this option is set to @samp{no}, then @i{Amd}'s autofs code will +use symlinks instead of lofs-type mounts for local references. This +has the advantage of using simpler (more stable) code, but at the +expense of negating one of autofs's big advantages: the hiding of +@i{Amd}'s internal paths. Note that symlinks are not supported in all +autofs implementations, especially those derived from Solaris Autofs +v1. Also, on Solaris 2.6 and newer, autofs symlinks are not cached, +resulting in repeated up-call requests to @i{Amd}. + +@c ---------------------------------------------------------------- +@node browsable_dirs Parameter, map_defaults Parameter, autofs_use_lofs Parameter, Common Parameters @comment node-name, next, previous, up @subsection @t{browsable_dirs} Parameter @cindex browsable_dirs Parameter @@ -4382,8 +4247,23 @@ a command which will attempt to @b{stat}(2) the entries, such as often done by @samp{ls -l} or @samp{ls -F}, @i{Amd} will attempt to mount @i{every} entry in that map. This is often called a ``mount storm''. +Note that mount storms are mostly avoided by using autofs mounts +(@samp{mount_type = autofs}). + +@c ---------------------------------------------------------------- +@node map_defaults Parameter, map_options Parameter, browsable_dirs Parameter, Common Parameters +@comment node-name, next, previous, up +@subsection @t{map_defaults} Parameter +@cindex map_defaults Parameter + +(type=string, default to empty). This option sets a string to be used +as the map's @code{/defaults} entry, overriding any @code{/defaults} +specified in the map. This allows local users to override a given +map's defaults without modifying maps globally (which is impossible in +sites where the maps are managed by a different administrative group). + @c ---------------------------------------------------------------- -@node map_options Parameter, map_type Parameter, browsable_dirs Parameter, Common Parameters +@node map_options Parameter, map_type Parameter, map_defaults Parameter, Common Parameters @comment node-name, next, previous, up @subsection @t{map_options} Parameter @cindex map_options Parameter @@ -4429,13 +4309,13 @@ union maps @subsection @t{mount_type} Parameter @cindex mount_type Parameter -(type=string, default=@samp{nfs}). All @i{Amd} mount types must be NFS. +(type=string, default=@samp{nfs}). All @i{Amd} mount types default to NFS. That is, @i{Amd} is an NFS server on the map mount points, for the local -host it is running on. If @samp{autofs} is specified, @i{Amd} will log -an error message and forcibly convert it to NFS. +host it is running on. If @samp{autofs} is specified, @i{Amd} will be +an autofs server for those mount points. @c ---------------------------------------------------------------- -@node search_path Parameter, , mount_type Parameter, Common Parameters +@node search_path Parameter, selectors_in_defaults Parameter, mount_type Parameter, Common Parameters @comment node-name, next, previous, up @subsection @t{search_path} Parameter @cindex search_path Parameter @@ -4445,6 +4325,28 @@ an error message and forcibly convert it to NFS. sites can allow for local map customizations and overrides, and can distributed maps in several locations as needed. +@c ---------------------------------------------------------------- +@node selectors_in_defaults Parameter, , search_path Parameter, Common Parameters +@comment node-name, next, previous, up +@subsection @t{selectors_in_defaults} Parameter +@cindex selectors_in_defaults Parameter + +(type=boolean, default=@samp{no}). If @samp{yes}, then the +@samp{/defaults} entry of maps will search for and process any +selectors before setting defaults for all other keys in that map. +Useful when you want to set different options for a complete map based +on some parameters. For example, you may want to better the NFS +performance over slow slip-based networks as follows: + +@example +/defaults \ + wire==slip-net;opts:=intr,rsize=1024,wsize=1024 \ + wire!=slip-net;opts:=intr,rsize=8192,wsize=8192 +@end example + +Deprecated form: selectors_on_default. + + @c ================================================================ @node Global Parameters, Regular Map Parameters, Common Parameters, Amd Configuration File @comment node-name, next, previous, up @@ -4454,55 +4356,150 @@ distributed maps in several locations as needed. The following parameters are applicable to the @samp{[global]} section only. @menu -* arch Parameter:: +* arch Parameter:: +* auto_attrcache Parameter:: * auto_dir Parameter:: * cache_duration Parameter:: -* cluster Parameter:: +* cluster Parameter:: +* debug_mtab_file Parameter:: * debug_options Parameter:: * dismount_interval Parameter:: +* domain_strip Parameter:: +* exec_map_timeout Parameter:: +* forced_unmounts Parameter:: * full_os Parameter:: * fully_qualified_hosts Parameter:: -* hesiod_base Parameter:: -* karch Parameter:: +* hesiod_base Parameter:: +* karch Parameter:: * ldap_base Parameter:: * ldap_cache_maxmem Parameter:: * ldap_cache_seconds Parameter:: * ldap_hostports Parameter:: +* ldap_proto_version Parameter:: * local_domain Parameter:: +* localhost_address Parameter:: * log_file Parameter:: * log_options Parameter:: +* map_reload_interval Parameter:: +* nfs_allow_any_interface Parameter:: * nfs_allow_insecure_port Parameter:: * nfs_proto Parameter:: * nfs_retransmit_counter Parameter:: +* nfs_retransmit_counter_udp Parameter:: +* nfs_retransmit_counter_tcp Parameter:: +* nfs_retransmit_counter_toplvl Parameter:: * nfs_retry_interval Parameter:: +* nfs_retry_interval_udp Parameter:: +* nfs_retry_interval_tcp Parameter:: +* nfs_retry_interval_toplvl Parameter:: * nfs_vers Parameter:: * nis_domain Parameter:: * normalize_hostnames Parameter:: -* os Parameter:: -* osver Parameter:: +* normalize_slashes Parameter:: +* os Parameter:: +* osver Parameter:: * pid_file Parameter:: -* plock Parameter:: +* plock Parameter:: * portmap_program Parameter:: +* preferred_amq_port Parameter:: * print_pid Parameter:: * print_version Parameter:: * restart_mounts Parameter:: -* selectors_in_defaults Parameter:: * show_statfs_entries Parameter:: +* truncate_log Parameter:: * unmount_on_exit Parameter:: +* use_tcpwrappers Parameter:: * vendor Parameter:: @end menu @c ---------------------------------------------------------------- -@node arch Parameter, auto_dir Parameter, Global Parameters, Global Parameters +@node arch Parameter, auto_attrcache Parameter, Global Parameters, Global Parameters @comment node-name, next, previous, up @subsection @t{arch} Parameter @cindex arch Parameter -(type=string, default to compiled in value). Allows you to override the -value of the @i{arch} @i{Amd} variable. +(type=string, default to compiled in value). Same as the @code{-A} +option to @i{Amd}. Allows you to override the value of the @i{arch} +@i{Amd} variable. + +@c ---------------------------------------------------------------- +@node auto_attrcache Parameter, auto_dir Parameter, arch Parameter, Global Parameters +@comment node-name, next, previous, up +@subsection @t{auto_attrcache} Parameter +@cindex auto_attrcache Parameter + +(type=numeric, default=0). Specify in seconds (or units of 0.1 +seconds, depending on the OS), what is the (kernel-side) NFS attribute +cache timeout for @i{Amd}'s own automount points. A value of 0 is +supposed to turn off attribute caching, meaning that @i{Amd} will be +consulted via a kernel-RPC each time someone stat()'s the mount point +(which could be abused as a denial-of-service attack). + +@emph{WARNING}: @i{Amd} depends on being able to turn off the NFS +attribute cache of the client OS. If it cannot be turned off, then +users may get ESTALE errors or symlinks that point to the wrong +places. This is more likely under heavy use of @i{Amd}, for example +if your system is experiencing frequent map changes or frequent +mounts/unmounts. Therefore, under normal circumstances, this +parameter should remain set to 0, to ensure that the attribute cache +is indeed off. + +Unfortunately, some kernels (e.g., certain BSDs) don't have a way to +turn off the NFS attribute cache. Setting this parameter to 0 is +supposed to turn off attribute caching entirely, but unfortunately it +does not; instead, the attribute cache is set to some internal +hard-coded default (usually anywhere from 5-30 seconds). If you +suspect that your OS doesn't have a reliable way of turning off the +attribute cache, then it is better to set this parameter to the +smallest possible non-zero value (set @samp{auto_attrcache=1} in your +@code{amd.conf}). This will not eliminate the problem, but reduce the +risk window somewhat. The best solutions are (1) to use @i{Amd} in +Autofs mode, if it's supported in your OS, and (2) talk to your OS +vendor to support a true @samp{noac} flag. See the +@uref{http://www.am-utils.org/docs/am-utils/attrcache.txt,README.attrcache} +document for more details. + +If you are able to turn off the attribute cache on your OS, alas, +@i{Amd}'s performance may degrade (when not using Autofs) because +every traversal of an automounter-controlled pathname will result in a +lookup request from the kernel to @i{Amd}. Under heavy loads, for +example when using recursive tools like @samp{find}, @samp{rdist}, or +@samp{rsync}, this performance degradation can be noticeable. There +are two possible solutions that some administrators have chosen to +improve performance: + +@enumerate + +@item +First, you can turn off unmounting using the @samp{nounmount} mount +option. This will ensure that no @i{Amd} symlink could ever change, +thereby the kernel's attribute cache and @i{Amd} will always be in +sync. However, this method will cause the number of mounts to keep +growing, even if some are no longer in use; this has the disadvantage +that your system could be more susceptible to hangs if even one of +those accumulating mounts hangs due to a downed server. + +@item +Second, you can turn on attribute caching carefully by setting a small +automounter attribute cache value (say, one second), and a relatively +large dismount interval (say, one hour). (@xref{dismount_interval +Parameter}.) For example, you can set this in your @code{amd.conf}: + +@example +[global] +auto_attrcache = 1 +dismount_interval = 3600 +@end example + +This has the benefit of using the kernel's attribute cache and thus +improving performance. The disadvantage with this option is that the +window of vulnerability is not eliminated entirely: it is only made +smaller. + +@end enumerate @c ---------------------------------------------------------------- -@node auto_dir Parameter, cache_duration Parameter, arch Parameter, Global Parameters +@node auto_dir Parameter, cache_duration Parameter, auto_attrcache Parameter, Global Parameters @comment node-name, next, previous, up @subsection @t{auto_dir} Parameter @cindex auto_dir Parameter @@ -4517,12 +4514,12 @@ sub-directories for its real mount points. @subsection @t{cache_duration} Parameter @cindex cache_duration Parameter -(type=numeric, default=300). Same as the @code{-c} option to -@i{Amd}. Sets the duration in seconds that looked up map entries remain -in the cache. +(type=numeric, default=300). Same as the @code{-c} option to @i{Amd}. +Sets the duration in seconds that looked-up or mounted map entries +remain in the cache. @c ---------------------------------------------------------------- -@node cluster Parameter, debug_options Parameter, cache_duration Parameter, Global Parameters +@node cluster Parameter, debug_mtab_file Parameter, cache_duration Parameter, Global Parameters @comment node-name, next, previous, up @subsection @t{cluster} Parameter @cindex cluster Parameter @@ -4530,8 +4527,18 @@ in the cache. (type=string, default no cluster). Same as the @code{-C} option to @i{Amd}. Specifies the alternate HP-UX cluster to use. +@c ---------------------------------------------------------------- +@node debug_mtab_file Parameter, debug_options Parameter, cluster Parameter, Global Parameters +@comment node-name, next, previous, up +@subsection @t{debug_mtab_file} Parameter +@cindex debug_mtab_file Parameter + +(type=string, default="/tmp/mnttab"). Path to mtab file that is used +by @i{Amd} to store a list of mounted file systems during debug-mtab mode. +This option only applies to systems that store mtab information on disk. + @c ---------------------------------------------------------------- -@node debug_options Parameter, dismount_interval Parameter, cluster Parameter, Global Parameters +@node debug_options Parameter, dismount_interval Parameter, debug_mtab_file Parameter, Global Parameters @comment node-name, next, previous, up @subsection @t{debug_options} Parameter @cindex debug_options Parameter @@ -4539,38 +4546,15 @@ in the cache. (type=string, default no debug options). Same as the @code{-D} option to @i{Amd}. Specify any debugging options for @i{Amd}. Works only if am-utils was configured for debugging using the @code{--enable-debug} -option. The @samp{mem} option, as well as all other options, can be -turned on via @code{--enable-debug=mem}. Otherwise debugging options -are ignored. Options are comma delimited, and can be preceded by the -string @samp{no} to negate their meaning. You can get the list of -supported debugging and logging options by running @code{amd -H}. -Possible values are: - -@table @samp -@item all -all options -@item amq -register for amq -@item daemon -enter daemon mode -@item fork -fork server -@item full -program trace -@item mem -trace memory allocations -@item mtab -use local @file{./mtab} file -@item str -debug string munging -@item test -full debug but no daemon -@item trace -trace RPC protocol and NFS mount arguments -@end table +option. The additional @samp{mem} option can be turned on via +@code{--enable-debug=mem}. Otherwise debugging options are ignored. +Options are comma delimited, and can be preceded by the string +@samp{no} to negate their meaning. You can get the list of supported +debugging and logging options by running @code{amd -H}. Possible +values those listed for the -D option. @xref{-D Option}. @c ---------------------------------------------------------------- -@node dismount_interval Parameter, full_os Parameter, debug_options Parameter, Global Parameters +@node dismount_interval Parameter, domain_strip Parameter, debug_options Parameter, Global Parameters @comment node-name, next, previous, up @subsection @t{dismount_interval} Parameter @cindex dismount_interval Parameter @@ -4580,7 +4564,70 @@ trace RPC protocol and NFS mount arguments systems that have exceeded their cached times. @c ---------------------------------------------------------------- -@node full_os Parameter, fully_qualified_hosts Parameter, dismount_interval Parameter, Global Parameters +@node domain_strip Parameter, exec_map_timeout Parameter, dismount_interval Parameter, Global Parameters +@comment node-name, next, previous, up +@subsection @t{domain_strip} Parameter +@cindex domain_strip Parameter + +(type=boolean, default=@samp{yes}). If @samp{yes}, then the domain +name part referred to by @code{$@{rhost@}} is stripped off. This is +useful to keep logs and smaller. If @samp{no}, then the domain name +part is left changed. This is useful when using multiple domains with +the same maps (as you may have hosts whose domain-stripped name is +identical). + +@c ---------------------------------------------------------------- +@node exec_map_timeout Parameter, forced_unmounts Parameter, domain_strip Parameter, Global Parameters +@comment node-name, next, previous, up +@subsection @t{exec_map_timeout} Parameter +@cindex exec_map_timeout Parameter + +(type=numeric, default=10). The timeout in seconds that @i{Amd} will +wait for an executable map program before an answer is returned from +that program (or script). This value should be set to as small as +possible while still allowing normal replies to be returned before the +timer expires, because during the time that the executable map program +is queried, @i{Amd} is essentially waiting and is thus not responding +to any other queries. @xref{Executable maps}. + +@c ---------------------------------------------------------------- +@node forced_unmounts Parameter, full_os Parameter, exec_map_timeout Parameter, Global Parameters +@comment node-name, next, previous, up +@subsection @t{forced_unmounts} Parameter +@cindex forced_unmounts Parameter + +(type=boolean, default=@samp{no}). +Sometimes, mount points are hung due to unrecoverable conditions, such +as when NFS servers migrate, change their IP address, are down +permanently, or due to hardware failures, and more. In this case, +attempting to unmount an existing mount point, or even just to +@b{stat}(2) it, results in one of three fatal errors: EIO, ESTALE, or +EBUSY. At that point, @i{Amd} can do little to recover that hung +point (in fact, the OS cannot automatically recover either). For that +reason, some OSs support special kinds of forced unmounts, which must +be used very carefully: they will force an unmount immediately (or +lazily on Linux), which could result in application data loss. +However, that may be the only way to recover the entire host (without +rebooting). Once a hung mount point is forced out, @i{Amd} can then +re-mount a replacement one (if available), bringing a mostly-hung +system back to operation and avoiding a potentially costly reboot. + +If the @samp{forced_unmounts} option is set to @samp{yes}, and the +client OS supports forced or lazy unmounts, then @i{Amd} will attempt +to use them if it gets any of the three serious error conditions +listed above. Note that @i{Amd} will force the unmount of mount +points that returned EBUSY only for @samp{type:=toplvl} mounts +(@pxref{Top-level Filesystem}): that is, @i{Amd}'s own mount points. +This is useful to recover from a previously hung @i{Amd}, and to +ensure that an existing @i{Amd} can shutdown cleanly even if some +processes are keeping its mount points busy (i.e., when a user's shell +process uses @code{cd} to set its CWD to @i{Amd}'s own mount point). + +If this option is set to @samp{no} (the default), then @i{Amd} will +not attempt this special recovery procedure. + +@c ---------------------------------------------------------------- +@node full_os Parameter, fully_qualified_hosts Parameter, forced_unmounts Parameter, Global Parameters @comment node-name, next, previous, up @subsection @t{full_os} Parameter @cindex full_os Parameter @@ -4656,7 +4703,7 @@ should use to cache LDAP entries. entries in the cache. @c ---------------------------------------------------------------- -@node ldap_hostports Parameter, local_domain Parameter, ldap_cache_seconds Parameter, Global Parameters +@node ldap_hostports Parameter, ldap_proto_version Parameter, ldap_cache_seconds Parameter, Global Parameters @comment node-name, next, previous, up @subsection @t{ldap_hostports} Parameter @cindex ldap_hostports Parameter @@ -4665,7 +4712,16 @@ entries in the cache. Specify the LDAP host and port values. @c ---------------------------------------------------------------- -@node local_domain Parameter, log_file Parameter, ldap_hostports Parameter, Global Parameters +@node ldap_proto_version Parameter, local_domain Parameter, ldap_hostports Parameter, Global Parameters +@comment node-name, next, previous, up +@subsection @t{ldap_proto_version} Parameter +@cindex ldap_proto_version Parameter + +(type=numeric, default=2). Specify the LDAP protocol version to use. +With a value of 3 will use LDAPv3 protocol. + +@c ---------------------------------------------------------------- +@node local_domain Parameter, localhost_address Parameter, ldap_proto_version Parameter, Global Parameters @comment node-name, next, previous, up @subsection @t{local_domain} Parameter @cindex local_domain Parameter @@ -4676,7 +4732,20 @@ the domain name is determined from the hostname, by removing the first component of the fully-qualified host name. @c ---------------------------------------------------------------- -@node log_file Parameter, log_options Parameter, local_domain Parameter, Global Parameters +@node localhost_address Parameter, log_file Parameter, local_domain Parameter, Global Parameters +@comment node-name, next, previous, up +@subsection @t{localhost_address} Parameter +@cindex localhost_address Parameter + +(type=string, default to localhost or 127.0.0.1). Specify the name or +IP address for @i{Amd} to use when connecting the sockets for the +local NFS server and the RPC server. This defaults to 127.0.0.1 or +whatever the host reports as its local address. This parameter is +useful on hosts with multiple addresses where you want to force +@i{Amd} to connect to a specific address. + +@c ---------------------------------------------------------------- +@node log_file Parameter, log_options Parameter, localhost_address Parameter, Global Parameters @comment node-name, next, previous, up @subsection @t{log_file} Parameter @cindex log_file Parameter @@ -4700,7 +4769,7 @@ is generally a bad idea to use those reserved for other services such as @samp{kern}, @samp{lpr}, @samp{cron}, etc. @c ---------------------------------------------------------------- -@node log_options Parameter, nfs_allow_insecure_port Parameter, log_file Parameter, Global Parameters +@node log_options Parameter, map_reload_interval Parameter, log_file Parameter, Global Parameters @comment node-name, next, previous, up @subsection @t{log_options} Parameter @cindex log_options Parameter @@ -4737,21 +4806,45 @@ warnings @end table @c ---------------------------------------------------------------- -@node nfs_allow_insecure_port Parameter, nfs_proto Parameter, log_options Parameter, Global Parameters +@node map_reload_interval Parameter, nfs_allow_any_interface Parameter, log_options Parameter, Global Parameters +@comment node-name, next, previous, up +@subsection @t{map_reload_interval} Parameter +@cindex map_reload_interval Parameter + +(type=numeric, default=3600). The number of seconds that @i{Amd} will +wait before it checks to see if any maps have changed at their source +(NIS servers, LDAP servers, files, etc.). @i{Amd} will reload only +those maps that have changed. + +@c ---------------------------------------------------------------- +@node nfs_allow_any_interface Parameter, nfs_allow_insecure_port Parameter, map_reload_interval Parameter, Global Parameters +@comment node-name, next, previous, up +@subsection @t{nfs_allow_any_interface} Parameter +@cindex nfs_allow_any_interface Parameter + +(type=string, default=@samp{no}). Normally @i{Amd} accepts local NFS +packets only from 127.0.0.1. If this parameter is set to @samp{yes}, +then @i{amd} will accept local NFS packets from any local interface; +this is useful on hosts that may have multiple interfaces where the +system is forced to send all outgoing packets (even those bound to the +same host) via an address other than 127.0.0.1. + +@c ---------------------------------------------------------------- +@node nfs_allow_insecure_port Parameter, nfs_proto Parameter, nfs_allow_any_interface Parameter, Global Parameters @comment node-name, next, previous, up @subsection @t{nfs_allow_insecure_port} Parameter @cindex nfs_allow_insecure_port Parameter -(type=string, default=@samp{no}). Normally amd will refuse requests -coming from unprivileged ports (i.e. ports >= 1024 on Unix systems), +(type=string, default=@samp{no}). Normally @i{Amd} will refuse requests +coming from unprivileged ports (i.e., ports >= 1024 on Unix systems), so that only privileged users and the kernel can send NFS requests to -it. However, some kernels (certain versions of Darwin, MacOS X, and +it. However, some kernels (certain versions of Darwin, MacOS X, and Linux) have bugs that cause them to use unprivileged ports in certain -situations, which causes amd to stop dead in its tracks. This -parameter allows amd to operate normally even on such systems, at the -expense of a slight decrease in the security of its operations. If you -see messages like ``ignoring request from foo:1234, port not -reserved'' in your amd log, try enabling this parameter and give it +situations, which causes @i{Amd} to stop dead in its tracks. This +parameter allows @i{Amd} to operate normally even on such systems, at the +expense of a slight decrease in the security of its operations. If +you see messages like ``ignoring request from foo:1234, port not +reserved'' in your @i{Amd} log, try enabling this parameter and give it another go. @c ---------------------------------------------------------------- @@ -4763,13 +4856,14 @@ another go. (type=string, default to trying version tcp then udp). By default, @i{Amd} tries @code{tcp} and then @code{udp}. This option forces the overall NFS protocol used to TCP or UDP. It overrides what is in the -@i{Amd} maps, and is useful when @i{Amd} is compiled with NFSv3 support -that may not be stable. With this option you can turn off the complete -usage of NFSv3 dynamically (without having to recompile @i{Amd}) until -such time as NFSv3 support is desired again. +@i{Amd} maps, and is useful when @i{Amd} is compiled with TCP support +in NFSv2/NFSv3 that may not be stable. With this option you can turn +off the complete usage of TCP for NFS dynamically (without having to +recompile @i{Amd}), and use UDP only, until such time as TCP support +is desired again. @c ---------------------------------------------------------------- -@node nfs_retransmit_counter Parameter, nfs_retry_interval Parameter, nfs_proto Parameter, Global Parameters +@node nfs_retransmit_counter Parameter, nfs_retransmit_counter_udp Parameter, nfs_proto Parameter, Global Parameters @comment node-name, next, previous, up @subsection @t{nfs_retransmit_counter} Parameter @cindex nfs_retransmit_counter Parameter @@ -4777,10 +4871,48 @@ such time as NFSv3 support is desired again. (type=numeric, default=11). Same as the @i{retransmit} part of the @code{-t} @i{timeout.retransmit} option to @i{Amd}. Specifies the number of NFS retransmissions that the kernel will use to communicate -with @i{Amd}. @xref{-t Option}. +with @i{Amd} using either UDP or TCP mounts. @xref{-t Option}. + +@c ---------------------------------------------------------------- +@node nfs_retransmit_counter_udp Parameter, nfs_retransmit_counter_tcp Parameter, nfs_retransmit_counter Parameter, Global Parameters +@comment node-name, next, previous, up +@subsection @t{nfs_retransmit_counter_udp} Parameter +@cindex nfs_retransmit_counter_udp Parameter +@cindex nfs_retransmit_counter Parameter +@cindex UDP + +(type=numeric, default=11). Same as the @i{nfs_retransmit_counter} +parameter, but applied globally only to UDP mounts. +@xref{nfs_retransmit_counter Parameter}. + +@c ---------------------------------------------------------------- +@node nfs_retransmit_counter_tcp Parameter, nfs_retransmit_counter_toplvl Parameter, nfs_retransmit_counter_udp Parameter, Global Parameters +@comment node-name, next, previous, up +@subsection @t{nfs_retransmit_counter_tcp} Parameter +@cindex nfs_retransmit_counter_tcp Parameter +@cindex nfs_retransmit_counter Parameter +@cindex TCP + +(type=numeric, default=11). Same as the @i{nfs_retransmit_counter} +parameter, but applied globally only to TCP mounts. +@xref{nfs_retransmit_counter Parameter}. + +@c ---------------------------------------------------------------- +@node nfs_retransmit_counter_toplvl Parameter, nfs_retry_interval Parameter, nfs_retransmit_counter_tcp Parameter, Global Parameters +@comment node-name, next, previous, up +@subsection @t{nfs_retransmit_counter_toplvl} Parameter +@cindex nfs_retransmit_counter_toplvl Parameter +@cindex nfs_retransmit_counter Parameter +@cindex UDP + +(type=numeric, default=11). Same as the @i{nfs_retransmit_counter} +parameter, applied only for @i{Amd}'s top-level UDP mounts. On some +systems it is useful to set this differently than the OS default, so +as to better tune @i{Amd}'s responsiveness under heavy scheduler +loads. @xref{nfs_retransmit_counter Parameter}. @c ---------------------------------------------------------------- -@node nfs_retry_interval Parameter, nfs_vers Parameter, nfs_retransmit_counter Parameter, Global Parameters +@node nfs_retry_interval Parameter, nfs_retry_interval_udp Parameter, nfs_retransmit_counter_toplvl Parameter, Global Parameters @comment node-name, next, previous, up @subsection @t{nfs_retry_interval} Parameter @cindex nfs_retry_interval Parameter @@ -4788,7 +4920,7 @@ with @i{Amd}. @xref{-t Option}. (type=numeric, default=8). Same as the @i{timeout} part of the @code{-t} @i{timeout.retransmit} option to @i{Amd}. Specifies the NFS timeout interval, in @emph{tenths} of seconds, between NFS/RPC retries -(for UDP only). This is the value that the kernel will use to +(for UDP or TCP). This is the value that the kernel will use to communicate with @i{Amd}. @xref{-t Option}. @i{Amd} relies on the kernel RPC retransmit mechanism to trigger mount @@ -4798,18 +4930,57 @@ Too long an interval gives poor interactive response; too short an interval causes excessive retries. @c ---------------------------------------------------------------- -@node nfs_vers Parameter, nis_domain Parameter, nfs_retry_interval Parameter, Global Parameters +@node nfs_retry_interval_udp Parameter, nfs_retry_interval_tcp Parameter, nfs_retry_interval Parameter, Global Parameters +@comment node-name, next, previous, up +@subsection @t{nfs_retry_interval_udp} Parameter +@cindex nfs_retry_interval_udp Parameter +@cindex nfs_retry_interval Parameter +@cindex UDP + +(type=numeric, default=8). Same as the @i{nfs_retry_interval} +parameter, but applied globally only to UDP mounts. +@xref{nfs_retry_interval Parameter}. + +@c ---------------------------------------------------------------- +@node nfs_retry_interval_tcp Parameter, nfs_retry_interval_toplvl Parameter, nfs_retry_interval_udp Parameter, Global Parameters +@comment node-name, next, previous, up +@subsection @t{nfs_retry_interval_tcp} Parameter +@cindex nfs_retry_interval_tcp Parameter +@cindex nfs_retry_interval Parameter +@cindex TCP + +(type=numeric, default=8). Same as the @i{nfs_retry_interval} +parameter, but applied globally only to TCP mounts. +@xref{nfs_retry_interval Parameter}. + +@c ---------------------------------------------------------------- +@node nfs_retry_interval_toplvl Parameter, nfs_vers Parameter, nfs_retry_interval_tcp Parameter, Global Parameters +@comment node-name, next, previous, up +@subsection @t{nfs_retry_interval_toplvl} Parameter +@cindex nfs_retry_interval_toplvl Parameter +@cindex nfs_retry_interval Parameter +@cindex UDP + +(type=numeric, default=8). Same as the @i{nfs_retry_interval} +parameter, applied only for @i{Amd}'s top-level UDP mounts. On some +systems it is useful to set this differently than the OS default, so +as to better tune @i{Amd}'s responsiveness under heavy scheduler +loads. @xref{nfs_retry_interval Parameter}. + +@c ---------------------------------------------------------------- +@node nfs_vers Parameter, nis_domain Parameter, nfs_retry_interval_toplvl Parameter, Global Parameters @comment node-name, next, previous, up @subsection @t{nfs_vers} Parameter @cindex nfs_vers Parameter -(type=numeric, default to trying version 3 then 2). By default, @i{Amd} -tries version 3 and then version 2. This option forces the overall NFS -protocol used to version 3 or 2. It overrides what is in the @i{Amd} -maps, and is useful when @i{Amd} is compiled with NFSv3 support that may not -be stable. With this option you can turn off the complete usage of -NFSv3 dynamically (without having to recompile @i{Amd}) until such time as -NFSv3 support is desired again. +(type=numeric, default to trying version 3 then 2). By default, +@i{Amd} tries version 3 and then version 2. This option forces the +overall NFS protocol used to version 3 or 2. It overrides what is in +the @i{Amd} maps, and is useful when @i{Amd} is compiled with NFSv3 +support that may not be stable. With this option you can turn off the +complete usage of NFSv3 dynamically (without having to recompile +@i{Amd}), and use NFSv2 only, until such time as NFSv3 support is +desired again. @c ---------------------------------------------------------------- @node nis_domain Parameter, normalize_hostnames Parameter, nfs_vers Parameter, Global Parameters @@ -4823,7 +4994,7 @@ which to fetch the NIS maps. The default is the system domain name. This option is ignored if NIS support is not available. @c ---------------------------------------------------------------- -@node normalize_hostnames Parameter, os Parameter, nis_domain Parameter, Global Parameters +@node normalize_hostnames Parameter, normalize_slashes Parameter, nis_domain Parameter, Global Parameters @comment node-name, next, previous, up @subsection @t{normalize_hostnames} Parameter @cindex normalize_hostnames Parameter @@ -4834,7 +5005,20 @@ relative to the host database before being used. The effect is to translate aliases into ``official'' names. @c ---------------------------------------------------------------- -@node os Parameter, osver Parameter, normalize_hostnames Parameter, Global Parameters +@node normalize_slashes Parameter, os Parameter, normalize_hostnames Parameter, Global Parameters +@comment node-name, next, previous, up +@subsection @t{normalize_slashes} Parameter +@cindex normalize_slashes Parameter + +(type=boolean, default=@samp{yes}). If @samp{yes} then amd will +condense all multiple @code{/} (slash) characters into one and remove +all trailing slashes. If @samp{no}, then amd will not touch strings +that may contain repeated or trailing slashes. The latter is +sometimes useful with SMB mounts, which often require multiple slash +characters in pathnames. + +@c ---------------------------------------------------------------- +@node os Parameter, osver Parameter, normalize_slashes Parameter, Global Parameters @comment node-name, next, previous, up @subsection @t{os} Parameter @cindex os Parameter @@ -4884,6 +5068,7 @@ This file is used only if the @samp{print_pid} option is on (type=boolean, default=@samp{yes}). Same as the @code{-S} option to @i{Amd}. If @samp{yes}, lock the running executable pages of @i{Amd} into memory. To improve @i{Amd}'s performance, systems that support the @b{plock}(3) +or @b{mlockall}(2) call can lock the @i{Amd} process into memory. This way there is less chance the operating system will schedule, page out, and swap the @i{Amd} process as needed. This improves @i{Amd}'s performance, at the @@ -4891,7 +5076,7 @@ cost of reserving the memory used by the @i{Amd} process (making it unavailable for other processes). @c ---------------------------------------------------------------- -@node portmap_program Parameter, print_pid Parameter, plock Parameter, Global Parameters +@node portmap_program Parameter, preferred_amq_port Parameter, plock Parameter, Global Parameters @comment node-name, next, previous, up @subsection @t{portmap_program} Parameter @cindex portmap_program Parameter @@ -4907,7 +5092,21 @@ number of an @i{Amd} to contact. In this way, amq can fully control any number of @i{Amd} processes running on the same host. @c ---------------------------------------------------------------- -@node print_pid Parameter, print_version Parameter, portmap_program Parameter, Global Parameters +@node preferred_amq_port Parameter, print_pid Parameter, portmap_program Parameter, Global Parameters +@comment node-name, next, previous, up +@subsection @t{preferred_amq_port} Parameter +@cindex preferred_amq_port Parameter + +(type=numeric, default=0). Specify an alternate Port-mapper RPC port +number for @i{Amd}'s @i{Amq} service. This is used for both UDP and +TCP. Setting this value to 0 (or not defining it) will cause @i{Amd} +to select an arbitrary port number. Setting the @i{Amq} RPC service +port to a specific number is useful in firewalled or NAT'ed +environments, where you need to know which port @i{Amd} will listen +on. + +@c ---------------------------------------------------------------- +@node print_pid Parameter, print_version Parameter, preferred_amq_port Parameter, Global Parameters @comment node-name, next, previous, up @subsection @t{print_pid} Parameter @cindex print_pid Parameter @@ -4927,7 +5126,7 @@ will print its version information string, which includes some configuration and compilation values. @c ---------------------------------------------------------------- -@node restart_mounts Parameter, selectors_in_defaults Parameter, print_version Parameter, Global Parameters +@node restart_mounts Parameter, show_statfs_entries Parameter, print_version Parameter, Global Parameters @comment node-name, next, previous, up @subsection @t{restart_mounts} Parameter @cindex restart_mounts Parameter @@ -4938,28 +5137,7 @@ systems are currently mounted. Whenever one of these would have been auto-mounted, @i{Amd} inherits it. @c ---------------------------------------------------------------- -@node selectors_in_defaults Parameter, show_statfs_entries Parameter, restart_mounts Parameter, Global Parameters -@comment node-name, next, previous, up -@subsection @t{selectors_in_defaults} Parameter -@cindex selectors_in_defaults Parameter - -(type=boolean, default=@samp{no}). If @samp{yes}, then the @samp{/defaults} entry of -maps will search for and process any selectors before setting defaults -for all other keys in that map. Useful when you want to set different -options for a complete map based on some parameters. For example, you -may want to better the NFS performance over slow slip-based networks as -follows: - -@example -/defaults \ - wire==slip-net;opts:=intr,rsize=1024,wsize=1024 \ - wire!=slip-net;opts:=intr,rsize=8192,wsize=8192 -@end example - -Deprecated form: selectors_on_default. - -@c ---------------------------------------------------------------- -@node show_statfs_entries Parameter, unmount_on_exit Parameter, selectors_in_defaults Parameter, Global Parameters +@node show_statfs_entries Parameter, truncate_log Parameter, restart_mounts Parameter, Global Parameters @comment node-name, next, previous, up @subsection @t{show_statfs_entries} Parameter @cindex show_statfs_entries Parameter @@ -4970,19 +5148,65 @@ browsable will also show the number of entries (keys) they have when the @b{statfs}(2) system call). @c ---------------------------------------------------------------- -@node unmount_on_exit Parameter, vendor Parameter, show_statfs_entries Parameter, Global Parameters +@node truncate_log Parameter, unmount_on_exit Parameter, show_statfs_entries Parameter, Global Parameters +@comment node-name, next, previous, up +@subsection @t{truncate_log} Parameter +@cindex truncate_log Parameter + +(type=boolean), default=@samp{no}). If @samp{yes}, then @i{Amd} will +truncate the log file (if it's a regular file) on startup. This could +be useful when conducting extensive testing on @i{Amd} maps (or +@i{Amd} itself) and you don't want to see log data from a previous run +in the same file. + +@c ---------------------------------------------------------------- +@node unmount_on_exit Parameter, use_tcpwrappers Parameter, truncate_log Parameter, Global Parameters @comment node-name, next, previous, up @subsection @t{unmount_on_exit} Parameter @cindex unmount_on_exit Parameter -(type=boolean), default=@samp{no}). If @samp{yes}, then @i{Amd} will attempt +(type=boolean, default=@samp{no}). If @samp{yes}, then @i{Amd} will attempt to unmount all file systems which it knows about. Normally it leaves all (esp. NFS) mounted file systems intact. Note that @i{Amd} does not know about file systems mounted before it starts up, unless the @samp{restart_mounts} option is used (@pxref{restart_mounts Parameter}). @c ---------------------------------------------------------------- -@node vendor Parameter, , unmount_on_exit Parameter, Global Parameters +@node use_tcpwrappers Parameter, vendor Parameter, unmount_on_exit Parameter, Global Parameters +@comment node-name, next, previous, up +@subsection @t{use_tcpwrappers} Parameter +@cindex use_tcpwrappers Parameter + +(type=boolean), default=@samp{yes}). If @samp{yes}, then amd will use +the tcpwrappers (tcpd/librwap) library (if available) to control +access to @i{Amd} via the @code{/etc/hosts.allow} and +@code{/etc/hosts.deny} files. @i{Amd} will verify that the host +running @i{Amq} is authorized to connect. The @code{amd} service name +must used in the @code{/etc/hosts.allow} and @code{/etc/hosts.deny} +files. For example, to allow only localhost to connect to @i{Amd}, +add this line to @code{/etc/hosts.allow}: + +@example +amd: localhost +@end example + +and this line to @code{/etc/hosts.deny}: + +@example +amd: ALL +@end example + +Consult the man pages for @b{hosts_access}(5) for more information on using +the tcpwrappers access-control library. + +Note that in particular, you should not configure your @code{hosts.allow} +file to spawn a command for @i{Amd}: that will cause @i{Amd} to not be able +to @code{waitpid} on the child process ID of any background un/mount that +@i{Amd} issued, resulting in a confused @i{Amd} that does not know what +happened to those background un/mount requests. + +@c ---------------------------------------------------------------- +@node vendor Parameter, , use_tcpwrappers Parameter, Global Parameters @comment node-name, next, previous, up @subsection @t{vendor} Parameter @cindex vendor Parameter @@ -5003,7 +5227,7 @@ The following parameters are applicable only to regular map sections. @menu * map_name Parameter:: -* tag Parameter:: +* tag Parameter:: @end menu @c ---------------------------------------------------------------- @@ -5033,7 +5257,7 @@ command-line option matches that in the map section. @section amd.conf Examples @cindex amd.conf examples -The following is the actual @code{amd.conf} file I use at the +The following is the actual @code{amd.conf} file I used at the Computer Science Department of Columbia University. @example @@ -5062,20 +5286,20 @@ fully_qualified_hosts = no # DEFINE AN AMD MOUNT POINT [ /u ] map_name = amd.u - -[ /proj ] + +[ /proj ] map_name = amd.proj - -[ /src ] + +[ /src ] map_name = amd.src - -[ /misc ] + +[ /misc ] map_name = amd.misc - -[ /import ] + +[ /import ] map_name = amd.import - -[ /tftpboot/.amd ] + +[ /tftpboot/.amd ] tag = tftpboot map_name = amd.tftpboot @end example @@ -5207,14 +5431,14 @@ mount point. * Amq default:: Default command behavior. * Amq -f option:: Flushing the map cache. * Amq -h option:: Controlling a non-local host. -* Amq -H-option:: Print help message. +* Amq -H option:: Print help message. * Amq -l option:: Controlling the log file. * Amq -m option:: Obtaining mount statistics. * Amq -p option:: Getting Amd's process ID. -* Amq -P-option:: Contacting alternate Amd processes. +* Amq -P option:: Contacting alternate Amd processes. * Amq -s option:: Obtaining global statistics. * Amq -T option:: Use TCP transport. -* Amq -U-option:: Use UDP transport. +* Amq -U option:: Use UDP transport. * Amq -u option:: Forcing volumes to time out. * Amq -v option:: Version information. * Amq -w option:: Print Amd current working directory. @@ -5310,7 +5534,7 @@ also be synchronized with the map source by using the @samp{sync} option (@pxref{Automount Filesystem}).@refill @c ---------------------------------------------------------------- -@node Amq -h option, Amq -H-option, Amq -f option, Controlling Amd +@node Amq -h option, Amq -H option, Amq -f option, Controlling Amd @comment node-name, next, previous, up @subsection @i{Amq} @code{-h} option @cindex Querying an alternate host @@ -5321,7 +5545,7 @@ be running. To query @i{Amd} on another host the @code{-h} option should be used. @c ---------------------------------------------------------------- -@node Amq -H-option, Amq -l option, Amq -h option, Controlling Amd +@node Amq -H option, Amq -l option, Amq -h option, Controlling Amd @comment node-name, next, previous, up @subsection @i{Amq} @code{-H} option @cindex Displaying brief help @@ -5330,7 +5554,7 @@ be used. Print a brief help and usage string. @c ---------------------------------------------------------------- -@node Amq -l option, Amq -m option, Amq -H-option, Controlling Amd +@node Amq -l option, Amq -m option, Amq -H option, Controlling Amd @comment node-name, next, previous, up @subsection @i{Amq} @code{-l} option @cindex Resetting the Amd log file @@ -5403,7 +5627,7 @@ filesystem mount list. @end ignore @c ---------------------------------------------------------------- -@node Amq -p option, Amq -P-option, Amq -m option, Controlling Amd +@node Amq -p option, Amq -P option, Amq -m option, Controlling Amd @comment node-name, next, previous, up @subsection @i{Amq} @code{-p} option @cindex Process ID; Amd @@ -5417,7 +5641,7 @@ rather not have to search through the process table. This option is used in the @file{ctl-amd} script. @c ---------------------------------------------------------------- -@node Amq -P-option, Amq -s option, Amq -p option, Controlling Amd +@node Amq -P option, Amq -s option, Amq -p option, Controlling Amd @comment node-name, next, previous, up @subsection @i{Amq} @code{-P} option @cindex Multiple Amd processes @@ -5440,7 +5664,7 @@ kill `amq -p -P 300020` @end example @c ---------------------------------------------------------------- -@node Amq -s option, Amq -T option, Amq -P-option, Controlling Amd +@node Amq -s option, Amq -T option, Amq -P option, Controlling Amd @comment node-name, next, previous, up @subsection @i{Amq} @code{-s} option @cindex Global statistics @@ -5477,7 +5701,7 @@ should be increased. @end table @c ---------------------------------------------------------------- -@node Amq -T option, Amq -U-option, Amq -s option, Controlling Amd +@node Amq -T option, Amq -U option, Amq -s option, Controlling Amd @comment node-name, next, previous, up @subsection @i{Amq} @code{-T} option @cindex Forcing Amq to use a TCP transport @@ -5488,7 +5712,7 @@ transport only (connection oriented). Normally, @i{Amq} will use TCP first, and if that failed, will try UDP. @c ---------------------------------------------------------------- -@node Amq -U-option, Amq -u option, Amq -T option, Controlling Amd +@node Amq -U option, Amq -u option, Amq -T option, Controlling Amd @comment node-name, next, previous, up @subsection @i{Amq} @code{-U} option @cindex Forcing Amq to use a UDP transport @@ -5499,7 +5723,7 @@ transport only (connectionless). Normally, @i{Amq} will use TCP first, and if that failed, will try UDP. @c ---------------------------------------------------------------- -@node Amq -u option, Amq -v option, Amq -U-option, Controlling Amd +@node Amq -u option, Amq -v option, Amq -U option, Controlling Amd @comment node-name, next, previous, up @subsection @i{Amq} @code{-u} option @cindex Forcing filesystem to time out @@ -5566,7 +5790,7 @@ fsinfo. * Using FSinfo:: Basic concepts. * FSinfo Grammar:: Language syntax, semantics and examples. * FSinfo host definitions:: Defining a new host. -* FSinfo host attributes:: Definable host attributes. +* FSinfo host attributes:: Definable host attributes. * FSinfo filesystems:: Defining locally attached filesystems. * FSinfo static mounts:: Defining additional static mounts. * FSinfo automount definitions:: @@ -5587,7 +5811,7 @@ The purpose of @i{FSinfo} is to generate all the important standard filesystem data files from a single set of input data. Starting with a single data source guarantees that all the generated files are self-consistent. One of the possible output data formats is a set of -@i{Amd} maps which can be used amongst the set of hosts described in the +@i{Amd} maps which can be used among the set of hosts described in the input data. @i{FSinfo} implements a declarative language. This language is @@ -5768,14 +5992,14 @@ host @{ The options that can be given as host attributes are shown below. @menu -* netif Option: FSinfo host netif: -* config Option: FSinfo host config: -* arch Option: FSinfo host arch: -* os Option: FSinfo host os: -* cluster Option: FSinfo host cluster: +* FSinfo netif Option:: FSinfo host netif. +* FSinfo config Option:: FSinfo host config. +* FSinfo arch Option:: FSinfo host arch. +* FSinfo os Option:: FSinfo host os. +* FSinfo cluster Option:: FSinfo host cluster. @end menu -@node FSinfo host netif, FSinfo host config, , FSinfo host attributes +@node FSinfo netif Option, FSinfo config Option, , FSinfo host attributes @comment node-name, next, previous, up @subsection netif Option @@ -5806,7 +6030,7 @@ netif ie0 @{ netif ec0 @{ @} @end example -@node FSinfo host config, FSinfo host arch, FSinfo host netif, FSinfo host attributes +@node FSinfo config Option, FSinfo arch Option, FSinfo netif Option, FSinfo host attributes @comment node-name, next, previous, up @subsection config Option @cindex FSinfo config host attribute @@ -5825,7 +6049,7 @@ config "ZEPHYR=true" This option is currently unsupported. -@node FSinfo host arch, FSinfo host os, FSinfo host config, FSinfo host attributes +@node FSinfo arch Option, FSinfo os Option, FSinfo config Option, FSinfo host attributes @comment node-name, next, previous, up @subsection arch Option @cindex FSinfo arch host attribute @@ -5840,7 +6064,7 @@ arch = hp300 This is intended to be of use when building architecture specific mountmaps, however, the option is currently unsupported. -@node FSinfo host os, FSinfo host cluster, FSinfo host arch, FSinfo host attributes +@node FSinfo os Option, FSinfo cluster Option, FSinfo arch Option, FSinfo host attributes @comment node-name, next, previous, up @subsection os Option @cindex FSinfo os host attribute @@ -5856,7 +6080,7 @@ This information is used when creating the @file{fstab} files, for example in choosing which format to use for the @file{fstab} entries within the file. -@node FSinfo host cluster, , FSinfo host os, FSinfo host attributes +@node FSinfo cluster Option, , FSinfo os Option, FSinfo host attributes @comment node-name, next, previous, up @subsection cluster Option @cindex FSinfo cluster host attribute @@ -5967,16 +6191,16 @@ fs /dev/dsk/5s0 @{ @end example @menu -* fstype Option: FSinfo filesystems fstype: -* opts Option: FSinfo filesystems opts: -* passno Option: FSinfo filesystems passno: -* freq Option: FSinfo filesystems freq: -* mount Option: FSinfo filesystems mount: -* dumpset Option: FSinfo filesystems dumpset: -* log Option: FSinfo filesystems log: +* FSinfo fstype Option:: FSinfo filesystems fstype. +* FSinfo opts Option:: FSinfo filesystems opts. +* FSinfo passno Option:: FSinfo filesystems passno. +* FSinfo freq Option:: FSinfo filesystems freq. +* FSinfo mount Option:: FSinfo filesystems mount. +* FSinfo dumpset Option:: FSinfo filesystems dumpset. +* FSinfo log Option:: FSinfo filesystems log. @end menu -@node FSinfo filesystems fstype, FSinfo filesystems opts, , FSinfo filesystems +@node FSinfo fstype Option, FSinfo opts Option, , FSinfo filesystems @comment node-name, next, previous, up @subsection fstype Option @cindex FSinfo fstype filesystems option @@ -6001,7 +6225,7 @@ Example: fstype = swap @end example -@node FSinfo filesystems opts, FSinfo filesystems passno, FSinfo filesystems fstype, FSinfo filesystems +@node FSinfo opts Option, FSinfo passno Option, FSinfo fstype Option, FSinfo filesystems @comment node-name, next, previous, up @subsection opts Option @cindex FSinfo opts filesystems option @@ -6014,7 +6238,7 @@ This defines any options that should be given to @b{mount}(8) in the opts = rw,nosuid,grpid @end example -@node FSinfo filesystems passno, FSinfo filesystems freq, FSinfo filesystems opts, FSinfo filesystems +@node FSinfo passno Option, FSinfo freq Option, FSinfo opts Option, FSinfo filesystems @comment node-name, next, previous, up @subsection passno Option @cindex FSinfo passno filesystems option @@ -6029,7 +6253,7 @@ Example: passno = 1 @end example -@node FSinfo filesystems freq, FSinfo filesystems mount, FSinfo filesystems passno, FSinfo filesystems +@node FSinfo freq Option, FSinfo mount Option, FSinfo passno Option, FSinfo filesystems @comment node-name, next, previous, up @subsection freq Option @cindex FSinfo freq filesystems option @@ -6044,7 +6268,7 @@ Example: freq = 3 @end example -@node FSinfo filesystems mount, FSinfo filesystems dumpset, FSinfo filesystems freq, FSinfo filesystems +@node FSinfo mount Option, FSinfo dumpset Option, FSinfo freq Option, FSinfo filesystems @comment node-name, next, previous, up @subsection mount Option @cindex FSinfo mount filesystems option @@ -6114,7 +6338,7 @@ filesystem.@refill @end table -@node FSinfo filesystems dumpset, FSinfo filesystems log, FSinfo filesystems mount, FSinfo filesystems +@node FSinfo dumpset Option, FSinfo log Option, FSinfo mount Option, FSinfo filesystems @comment node-name, next, previous, up @subsection dumpset Option @cindex FSinfo dumpset filesystems option @@ -6123,7 +6347,7 @@ filesystem.@refill This provides support for Imperial College's local file backup tools and is not documented further here. -@node FSinfo filesystems log, , FSinfo filesystems dumpset, FSinfo filesystems +@node FSinfo log Option, , FSinfo dumpset Option, FSinfo filesystems @comment node-name, next, previous, up @subsection log Option @cindex FSinfo log filesystems option @@ -6619,8 +6843,8 @@ each level. @item pass number for @var{host}:@var{device} is non-zero Occurs if @var{device} has its @samp{fstype} declared to be @samp{swap} -or @samp{export} and the @b{fsck}(8) pass number is set. Swap devices should not be -fsck'd. @xref{FSinfo filesystems fstype}. +or @samp{export} and the @b{fsck}(8) pass number is set. Swap devices +should not be fsck'd. @xref{FSinfo fstype Option}. @item sub-directory @var{directory} of @var{directory-tree} starts with '/' Within the filesystem specification for a host, if an element @@ -6684,7 +6908,7 @@ from anywhere. It was designed and implemented by @email{dupuy@@cs.columbia.edu,Alexander Dupuy}, at the @uref{http://www.cs.columbia.edu/,Computer Science Department} of @uref{http://www.columbia.edu/,Columbia University}. A -@uref{http://www.cs.columbia.edu/~ezk/research/hlfsd/hlfsd.html,paper} +@uref{http://www.fsl.cs.sunysb.edu/docs/hlfsd/hlfsd.html,paper} on @i{Hlfsd} was presented at the Usenix LISA VII conference in 1993. @i{Hlfsd} operates by mounting itself as an NFS server for the directory @@ -6705,8 +6929,8 @@ dump its internal table of user IDs and home directories to the file @menu * Introduction to Hlfsd:: -* Background to Mail Delivery:: -* Using Hlfsd:: +* Background to Mail Delivery:: +* Using Hlfsd:: @end menu @c ================================================================ @@ -7068,9 +7292,9 @@ discussed. @cindex Hlfsd; using @menu -* Controlling Hlfsd:: -* Hlfsd Options:: -* Hlfsd Files:: +* Controlling Hlfsd:: +* Hlfsd Options:: +* Hlfsd Files:: @end menu @c ---------------------------------------------------------------- @@ -7128,6 +7352,16 @@ mv /var/mail /var/alt_mail ln -s /mail/home /var/mail @end example +@i{Hlfsd} also responds to the following signals: + +A @samp{SIGHUP} signal sent to @i{Hlfsd} will force it to reload the +password map immediately. + +A @samp{SIGUSR1} signal sent to @i{Hlfsd} will cause it to dump its +internal password map to the file @file{/usr/tmp/hlfsd.dump.XXXXXX}, +where @samp{XXXXXX} will be replaced by a random string generated by +@b{mktemp}(3) or (the more secure) @b{mkstemp}(3). + @c ---------------------------------------------------------------- @node Hlfsd Options, Hlfsd Files, Controlling Hlfsd, Using Hlfsd @comment node-name, next, previous, up @@ -7221,11 +7455,7 @@ Select from a variety of debugging options. Prefixing an option with the string @samp{no} reverses the effect of that option. Options are cumulative. The most useful option is @samp{all}. Since this option is only used for debugging other options are not documented here. A fuller -description is available in the program source. A @samp{SIGUSR1} sent -to @i{Hlfsd} will cause it to dump its internal password map to the file -@file{/usr/tmp/hlfsd.dump.XXXXXX}, where @samp{XXXXXX} will be replaced -by a random string generated by @b{mktemp}(3) or (the more secure) -@b{mkstemp}(3). +description is available in the program source. @item -P @var{password-file} Read the user-name, user-id, and home directory information from the @@ -7264,6 +7494,12 @@ directory to which @file{home} symbolic link returned by @i{Hlfsd} points if it is unable to verify the that user's home directory is accessible. +@item /usr/tmp/hlfsd.dump.XXXXXX +file to which @i{Hlfsd} will dump its internal password map when it +receives the @samp{SIGUSR1} signal. @samp{XXXXXX} will be replaced by +a random string generated by @b{mktemp}(3) or (the more secure) +@b{mkstemp}(3). + @end table For discussion on other files used by @i{Hlfsd}, see @xref{lostaltmail}, and @@ -7279,25 +7515,25 @@ The following are additional utilities and scripts included with am-utils, and get installed. @menu -* am-eject:: -* amd.conf-sample:: -* amd2ldif:: -* amd2sun:: -* automount2amd:: -* ctl-amd:: -* ctl-hlfsd:: -* expn:: -* fix-amd-map:: -* fixmount:: -* fixrmtab:: -* lostaltmail:: +* am-eject:: +* amd.conf-sample:: +* amd2ldif:: +* amd2sun:: +* automount2amd:: +* ctl-amd:: +* ctl-hlfsd:: +* expn:: +* fix-amd-map:: +* fixmount:: +* fixrmtab:: +* lostaltmail:: * lostaltmail.conf-sample:: -* mk-amd-map:: -* pawd:: -* redhat-ctl-amd:: -* wait4amd:: -* wait4amd2die:: -* wire-test:: +* mk-amd-map:: +* pawd:: +* redhat-ctl-amd:: +* wait4amd:: +* wait4amd2die:: +* wire-test:: @end menu @c ---------------------------------------------------------------- @@ -7315,7 +7551,7 @@ then attempts to eject the removable device. @section amd.conf-sample @pindex amd.conf-sample -A sample @i{Amd} configuration file. @xref{Amd Configuration File}. +A sample @i{Amd} configuration file. @xref{Amd Configuration File}. @c ---------------------------------------------------------------- @node amd2ldif, amd2sun, amd.conf-sample, Assorted Tools @@ -7514,7 +7750,7 @@ an alternate directory. This is useful to continue delivering mail, even if the user's file system was unavailable, full, or over quota. But, the mail which gets delivered to the alternate directory needs to be resent to its respective users. This is what the @samp{lostaltmail} -script does. +script does. Use it as follows: @@ -8295,7 +8531,7 @@ The mount daemon refused to return a file handle for the requested filesystem. The mount daemon gave some other error for the requested filesystem. @item Finishing with status @i{exit-status} -@i{Amd} is about to exit with the given exit status. +@i{Amd} is about to exit with the given exit status. @item Re-synchronizing cache for map @t{$@{@i{map}@}} The named map has been modified and the internal cache is being re-synchronized. @@ -8349,7 +8585,7 @@ Many thanks to the @email{am-utils@@am-utils.org,Am-Utils Users} mailing list through the months developing am-utils. These members have contributed to the discussions, ideas, code and documentation, and subjected their systems to alpha quality code. Special thanks go -to those @uref{http://www.am-utils.org/AUTHORS.txt,authors} who have +to those @uref{http://www.am-utils.org/docs/am-utils/AUTHORS.txt,authors} who have submitted patches, and especially to the maintainers: @itemize @bullet @@ -8444,3 +8680,7 @@ All other registered trademarks are owned by their respective owners. @c LocalWords: freebsdelf gnuoldld ifhtml defperm nodefperm norrip RRIP rrip @c LocalWords: noversion attr XXXXXX netgrpd rh mkstemp uid gid noexec mntfs @c LocalWords: nomnttab optionstr hrtime xdrtrace getpwd proplist redhat ctl +@c LocalWords: texinfo texi ib sp cartouche ified xlatecookie dircategory sc +@c LocalWords: AddInfo suse Novell softlookup ENOENT USB fullybrowsable LDAPv +@c LocalWords: amy ie xfffffe zebedee andrew diskfull hdmail searchable si +@c LocalWords: Orth ESTALE diff --git a/contrib/amd/doc/stamp-vti b/contrib/amd/doc/stamp-vti index 3705a9f6c595..41b19a30d5c6 100644 --- a/contrib/amd/doc/stamp-vti +++ b/contrib/amd/doc/stamp-vti @@ -1,3 +1,4 @@ -@set UPDATED 3 July 2001 -@set EDITION 6.0.7 -@set VERSION 6.0.7 +@set UPDATED 20 April 2006 +@set UPDATED-MONTH April 2006 +@set EDITION 6.1.5 +@set VERSION 6.1.5 diff --git a/contrib/amd/doc/texinfo.tex b/contrib/amd/doc/texinfo.tex index b0a1cfc3e72c..e758cedae7e6 100644 --- a/contrib/amd/doc/texinfo.tex +++ b/contrib/amd/doc/texinfo.tex @@ -3,10 +3,11 @@ % Load plain if necessary, i.e., if running under initex. \expandafter\ifx\csname fmtname\endcsname\relax\input plain\fi % -\def\texinfoversion{2002-06-04.06} +\def\texinfoversion{2004-09-06.16} % -% Copyright (C) 1985, 86, 88, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, -% 2000, 01, 02 Free Software Foundation, Inc. +% Copyright (C) 1985, 1986, 1988, 1990, 1991, 1992, 1993, 1994, 1995, +% 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004 Free Software +% Foundation, Inc. % % This texinfo.tex file is free software; you can redistribute it and/or % modify it under the terms of the GNU General Public License as @@ -23,24 +24,17 @@ % to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, % Boston, MA 02111-1307, USA. % -% In other words, you are welcome to use, share and improve this program. -% You are forbidden to forbid anyone else to use, share and improve -% what you give them. Help stamp out software-hoarding! +% As a special exception, when this file is read by TeX when processing +% a Texinfo source document, you may use the result without +% restriction. (This has been our intent since Texinfo was invented.) % % Please try the latest version of texinfo.tex before submitting bug % reports; you can get the latest version from: -% ftp://ftp.gnu.org/gnu/texinfo.tex -% (and all GNU mirrors, see http://www.gnu.org/order/ftp.html) -% ftp://texinfo.org/texinfo/texinfo.tex +% http://www.gnu.org/software/texinfo/ (the Texinfo home page), or % ftp://tug.org/tex/texinfo.tex -% (and all CTAN mirrors, see http://www.ctan.org), -% and /home/gd/gnu/doc/texinfo.tex on the GNU machines. -% -% The texinfo.tex in any given Texinfo distribution could well be out +% (and all CTAN mirrors, see http://www.ctan.org). +% The texinfo.tex in any given distribution could well be out % of date, so if that's what you're using, please check. -% -% Texinfo has a small home page at http://texinfo.org/ and also -% http://www.gnu.org/software/texinfo. % % Send bug reports to bug-texinfo@gnu.org. Please include including a % complete document in each bug report with which we can reproduce the @@ -58,8 +52,12 @@ % Sometimes one run after texindex suffices, and sometimes you need more % than two; texi2dvi does it as many times as necessary. % -% It is possible to adapt texinfo.tex for other languages. You can get -% the existing language-specific files from the full Texinfo distribution. +% It is possible to adapt texinfo.tex for other languages, to some +% extent. You can get the existing language-specific files from the +% full Texinfo distribution. +% +% The GNU Texinfo home page is http://www.gnu.org/software/texinfo. + \message{Loading texinfo [version \texinfoversion]:} @@ -69,7 +67,14 @@ \everyjob{\message{[Texinfo version \texinfoversion]}% \catcode`+=\active \catcode`\_=\active} -% Save some parts of plain tex whose names we will redefine. +\message{Basics,} +\chardef\other=12 + +% We never want plain's \outer definition of \+ in Texinfo. +% For @tex, we can use \tabalign. +\let\+ = \relax + +% Save some plain tex macros whose names we will redefine. \let\ptexb=\b \let\ptexbullet=\bullet \let\ptexc=\c @@ -79,23 +84,34 @@ \let\ptexend=\end \let\ptexequiv=\equiv \let\ptexexclam=\! +\let\ptexfootnote=\footnote +\let\ptexgtr=> +\let\ptexhat=^ \let\ptexi=\i +\let\ptexindent=\indent +\let\ptexnoindent=\noindent +\let\ptexinsert=\insert \let\ptexlbrace=\{ +\let\ptexless=< +\let\ptexplus=+ \let\ptexrbrace=\} +\let\ptexslash=\/ \let\ptexstar=\* \let\ptext=\t -% We never want plain's outer \+ definition in Texinfo. -% For @tex, we can use \tabalign. -\let\+ = \relax - -\message{Basics,} -\chardef\other=12 - % If this character appears in an error message or help string, it % starts a new line in the output. \newlinechar = `^^J +% Use TeX 3.0's \inputlineno to get the line number, for better error +% messages, but if we're using an old version of TeX, don't do anything. +% +\ifx\inputlineno\thisisundefined + \let\linenumber = \empty % Pre-3.0. +\else + \def\linenumber{l.\the\inputlineno:\space} +\fi + % Set up fixed words for English if not already set. \ifx\putwordAppendix\undefined \gdef\putwordAppendix{Appendix}\fi \ifx\putwordChapter\undefined \gdef\putwordChapter{Chapter}\fi @@ -134,48 +150,111 @@ \ifx\putwordDefspec\undefined \gdef\putwordDefspec{Special Form}\fi \ifx\putwordDefvar\undefined \gdef\putwordDefvar{Variable}\fi \ifx\putwordDefopt\undefined \gdef\putwordDefopt{User Option}\fi -\ifx\putwordDeftypevar\undefined\gdef\putwordDeftypevar{Variable}\fi \ifx\putwordDeffunc\undefined \gdef\putwordDeffunc{Function}\fi -\ifx\putwordDeftypefun\undefined\gdef\putwordDeftypefun{Function}\fi + +% In some macros, we cannot use the `\? notation---the left quote is +% in some cases the escape char. +\chardef\colonChar = `\: +\chardef\commaChar = `\, +\chardef\dotChar = `\. +\chardef\exclamChar= `\! +\chardef\questChar = `\? +\chardef\semiChar = `\; +\chardef\underChar = `\_ + +\chardef\spaceChar = `\ % +\chardef\spacecat = 10 +\def\spaceisspace{\catcode\spaceChar=\spacecat} % Ignore a token. % \def\gobble#1{} -\hyphenation{ap-pen-dix} -\hyphenation{mini-buf-fer mini-buf-fers} -\hyphenation{eshell} -\hyphenation{white-space} +% The following is used inside several \edef's. +\def\makecsname#1{\expandafter\noexpand\csname#1\endcsname} + +% Hyphenation fixes. +\hyphenation{ + Flor-i-da Ghost-script Ghost-view Mac-OS Post-Script + ap-pen-dix bit-map bit-maps + data-base data-bases eshell fall-ing half-way long-est man-u-script + man-u-scripts mini-buf-fer mini-buf-fers over-view par-a-digm + par-a-digms rath-er rec-tan-gu-lar ro-bot-ics se-vere-ly set-up spa-ces + spell-ing spell-ings + stand-alone strong-est time-stamp time-stamps which-ever white-space + wide-spread wrap-around +} % Margin to add to right of even pages, to left of odd pages. -\newdimen \bindingoffset -\newdimen \normaloffset +\newdimen\bindingoffset +\newdimen\normaloffset \newdimen\pagewidth \newdimen\pageheight +% For a final copy, take out the rectangles +% that mark overfull boxes (in case you have decided +% that the text looks ok even though it passes the margin). +% +\def\finalout{\overfullrule=0pt} + +% @| inserts a changebar to the left of the current line. It should +% surround any changed text. This approach does *not* work if the +% change spans more than two lines of output. To handle that, we would +% have adopt a much more difficult approach (putting marks into the main +% vertical list for the beginning and end of each change). +% +\def\|{% + % \vadjust can only be used in horizontal mode. + \leavevmode + % + % Append this vertical mode material after the current line in the output. + \vadjust{% + % We want to insert a rule with the height and depth of the current + % leading; that is exactly what \strutbox is supposed to record. + \vskip-\baselineskip + % + % \vadjust-items are inserted at the left edge of the type. So + % the \llap here moves out into the left-hand margin. + \llap{% + % + % For a thicker or thinner bar, change the `1pt'. + \vrule height\baselineskip width1pt + % + % This is the space between the bar and the text. + \hskip 12pt + }% + }% +} + % Sometimes it is convenient to have everything in the transcript file % and nothing on the terminal. We don't just call \tracingall here, -% since that produces some useless output on the terminal. +% since that produces some useless output on the terminal. We also make +% some effort to order the tracing commands to reduce output in the log +% file; cf. trace.sty in LaTeX. % \def\gloggingall{\begingroup \globaldefs = 1 \loggingall \endgroup}% -\ifx\eTeXversion\undefined -\def\loggingall{\tracingcommands2 \tracingstats2 - \tracingpages1 \tracingoutput1 \tracinglostchars1 - \tracingmacros2 \tracingparagraphs1 \tracingrestores1 - \showboxbreadth\maxdimen\showboxdepth\maxdimen -}% -\else -\def\loggingall{\tracingcommands3 \tracingstats2 - \tracingpages1 \tracingoutput1 \tracinglostchars1 - \tracingmacros2 \tracingparagraphs1 \tracingrestores1 - \tracingscantokens1 \tracingassigns1 \tracingifs1 - \tracinggroups1 \tracingnesting2 - \showboxbreadth\maxdimen\showboxdepth\maxdimen +\def\loggingall{% + \tracingstats2 + \tracingpages1 + \tracinglostchars2 % 2 gives us more in etex + \tracingparagraphs1 + \tracingoutput1 + \tracingmacros2 + \tracingrestores1 + \showboxbreadth\maxdimen \showboxdepth\maxdimen + \ifx\eTeXversion\undefined\else % etex gives us more logging + \tracingscantokens1 + \tracingifs1 + \tracinggroups1 + \tracingnesting2 + \tracingassigns1 + \fi + \tracingcommands3 % 3 gives us more in etex + \errorcontextlines16 }% -\fi % add check for \lastpenalty to plain's definitions. If the last thing % we did was a \nobreak, we don't want to insert more space. -% +% \def\smallbreak{\ifnum\lastpenalty<10000\par\ifdim\lastskip<\smallskipamount \removelastskip\penalty-50\smallskip\fi\fi} \def\medbreak{\ifnum\lastpenalty<10000\par\ifdim\lastskip<\medskipamount @@ -228,7 +307,7 @@ % the page break happens to be in the middle of an example. \shipout\vbox{% % Do this early so pdf references go to the beginning of the page. - \ifpdfmakepagedest \pdfmkdest{\the\pageno} \fi + \ifpdfmakepagedest \pdfdest name{\the\pageno} xyz\fi % \ifcropmarks \vbox to \outervsize\bgroup \hsize = \outerhsize @@ -276,7 +355,7 @@ \egroup % \vbox from first cropmarks clause \fi }% end of \shipout\vbox - }% end of group with \turnoffactive + }% end of group with \normalturnoffactive \advancepageno \ifnum\outputpenalty>-20000 \else\dosupereject\fi } @@ -309,143 +388,162 @@ % the input line (except we remove a trailing comment). #1 should be a % macro which expects an ordinary undelimited TeX argument. % -\def\parsearg#1{% - \let\next = #1% +\def\parsearg{\parseargusing{}} +\def\parseargusing#1#2{% + \def\next{#2}% \begingroup \obeylines - \futurelet\temp\parseargx -} - -% If the next token is an obeyed space (from an @example environment or -% the like), remove it and recurse. Otherwise, we're done. -\def\parseargx{% - % \obeyedspace is defined far below, after the definition of \sepspaces. - \ifx\obeyedspace\temp - \expandafter\parseargdiscardspace - \else - \expandafter\parseargline - \fi + \spaceisspace + #1% + \parseargline\empty% Insert the \empty token, see \finishparsearg below. } -% Remove a single space (as the delimiter token to the macro call). -{\obeyspaces % - \gdef\parseargdiscardspace {\futurelet\temp\parseargx}} - {\obeylines % \gdef\parseargline#1^^M{% \endgroup % End of the group started in \parsearg. - % - % First remove any @c comment, then any @comment. - % Result of each macro is put in \toks0. - \argremovec #1\c\relax % - \expandafter\argremovecomment \the\toks0 \comment\relax % - % - % Call the caller's macro, saved as \next in \parsearg. - \expandafter\next\expandafter{\the\toks0}% + \argremovecomment #1\comment\ArgTerm% }% } -% Since all \c{,omment} does is throw away the argument, we can let TeX -% do that for us. The \relax here is matched by the \relax in the call -% in \parseargline; it could be more or less anything, its purpose is -% just to delimit the argument to the \c. -\def\argremovec#1\c#2\relax{\toks0 = {#1}} -\def\argremovecomment#1\comment#2\relax{\toks0 = {#1}} +% First remove any @comment, then any @c comment. +\def\argremovecomment#1\comment#2\ArgTerm{\argremovec #1\c\ArgTerm} +\def\argremovec#1\c#2\ArgTerm{\argcheckspaces#1\^^M\ArgTerm} -% \argremovec{,omment} might leave us with trailing spaces, though; e.g., +% Each occurence of `\^^M' or `<space>\^^M' is replaced by a single space. +% +% \argremovec might leave us with trailing space, e.g., % @end itemize @c foo -% will have two active spaces as part of the argument with the -% `itemize'. Here we remove all active spaces from #1, and assign the -% result to \toks0. -% -% This loses if there are any *other* active characters besides spaces -% in the argument -- _ ^ +, for example -- since they get expanded. -% Fortunately, Texinfo does not define any such commands. (If it ever -% does, the catcode of the characters in questionwill have to be changed -% here.) But this means we cannot call \removeactivespaces as part of -% \argremovec{,omment}, since @c uses \parsearg, and thus the argument -% that \parsearg gets might well have any character at all in it. -% -\def\removeactivespaces#1{% - \begingroup - \ignoreactivespaces - \edef\temp{#1}% - \global\toks0 = \expandafter{\temp}% - \endgroup +% This space token undergoes the same procedure and is eventually removed +% by \finishparsearg. +% +\def\argcheckspaces#1\^^M{\argcheckspacesX#1\^^M \^^M} +\def\argcheckspacesX#1 \^^M{\argcheckspacesY#1\^^M} +\def\argcheckspacesY#1\^^M#2\^^M#3\ArgTerm{% + \def\temp{#3}% + \ifx\temp\empty + % We cannot use \next here, as it holds the macro to run; + % thus we reuse \temp. + \let\temp\finishparsearg + \else + \let\temp\argcheckspaces + \fi + % Put the space token in: + \temp#1 #3\ArgTerm } -% Change the active space to expand to nothing. +% If a _delimited_ argument is enclosed in braces, they get stripped; so +% to get _exactly_ the rest of the line, we had to prevent such situation. +% We prepended an \empty token at the very beginning and we expand it now, +% just before passing the control to \next. +% (Similarily, we have to think about #3 of \argcheckspacesY above: it is +% either the null string, or it ends with \^^M---thus there is no danger +% that a pair of braces would be stripped. % -\begingroup +% But first, we have to remove the trailing space token. +% +\def\finishparsearg#1 \ArgTerm{\expandafter\next\expandafter{#1}} + +% \parseargdef\foo{...} +% is roughly equivalent to +% \def\foo{\parsearg\Xfoo} +% \def\Xfoo#1{...} +% +% Actually, I use \csname\string\foo\endcsname, ie. \\foo, as it is my +% favourite TeX trick. --kasal, 16nov03 + +\def\parseargdef#1{% + \expandafter \doparseargdef \csname\string#1\endcsname #1% +} +\def\doparseargdef#1#2{% + \def#2{\parsearg#1}% + \def#1##1% +} + +% Several utility definitions with active space: +{ \obeyspaces - \gdef\ignoreactivespaces{\obeyspaces\let =\empty} -\endgroup + \gdef\obeyedspace{ } + + % Make each space character in the input produce a normal interword + % space in the output. Don't allow a line break at this space, as this + % is used only in environments like @example, where each line of input + % should produce a line of output anyway. + % + \gdef\sepspaces{\obeyspaces\let =\tie} + + % If an index command is used in an @example environment, any spaces + % therein should become regular spaces in the raw index file, not the + % expansion of \tie (\leavevmode \penalty \@M \ ). + \gdef\unsepspaces{\let =\space} +} \def\flushcr{\ifx\par\lisppar \def\next##1{}\else \let\next=\relax \fi \next} -%% These are used to keep @begin/@end levels from running away -%% Call \inENV within environments (after a \begingroup) -\newif\ifENV \ENVfalse \def\inENV{\ifENV\relax\else\ENVtrue\fi} -\def\ENVcheck{% -\ifENV\errmessage{Still within an environment; press RETURN to continue} -\endgroup\fi} % This is not perfect, but it should reduce lossage +% Define the framework for environments in texinfo.tex. It's used like this: +% +% \envdef\foo{...} +% \def\Efoo{...} +% +% It's the responsibility of \envdef to insert \begingroup before the +% actual body; @end closes the group after calling \Efoo. \envdef also +% defines \thisenv, so the current environment is known; @end checks +% whether the environment name matches. The \checkenv macro can also be +% used to check whether the current environment is the one expected. +% +% Non-false conditionals (@iftex, @ifset) don't fit into this, so they +% are not treated as enviroments; they don't open a group. (The +% implementation of @end takes care not to call \endgroup in this +% special case.) -% @begin foo is the same as @foo, for now. -\newhelp\EMsimple{Press RETURN to continue.} -\outer\def\begin{\parsearg\beginxxx} +% At runtime, environments start with this: +\def\startenvironment#1{\begingroup\def\thisenv{#1}} +% initialize +\let\thisenv\empty -\def\beginxxx #1{% -\expandafter\ifx\csname #1\endcsname\relax -{\errhelp=\EMsimple \errmessage{Undefined command @begin #1}}\else -\csname #1\endcsname\fi} +% ... but they get defined via ``\envdef\foo{...}'': +\long\def\envdef#1#2{\def#1{\startenvironment#1#2}} +\def\envparseargdef#1#2{\parseargdef#1{\startenvironment#1#2}} -% @end foo executes the definition of \Efoo. -% -\def\end{\parsearg\endxxx} -\def\endxxx #1{% - \removeactivespaces{#1}% - \edef\endthing{\the\toks0}% - % - \expandafter\ifx\csname E\endthing\endcsname\relax - \expandafter\ifx\csname \endthing\endcsname\relax - % There's no \foo, i.e., no ``environment'' foo. - \errhelp = \EMsimple - \errmessage{Undefined command `@end \endthing'}% - \else - \unmatchedenderror\endthing - \fi +% Check whether we're in the right environment: +\def\checkenv#1{% + \def\temp{#1}% + \ifx\thisenv\temp \else - % Everything's ok; the right environment has been started. - \csname E\endthing\endcsname + \badenverr \fi } -% There is an environment #1, but it hasn't been started. Give an error. -% -\def\unmatchedenderror#1{% +% Evironment mismatch, #1 expected: +\def\badenverr{% \errhelp = \EMsimple - \errmessage{This `@end #1' doesn't have a matching `@#1'}% + \errmessage{This command can appear only \inenvironment\temp, + not \inenvironment\thisenv}% +} +\def\inenvironment#1{% + \ifx#1\empty + out of any environment% + \else + in environment \expandafter\string#1% + \fi } -% Define the control sequence \E#1 to give an unmatched @end error. +% @end foo executes the definition of \Efoo. +% But first, it executes a specialized version of \checkenv % -\def\defineunmatchedend#1{% - \expandafter\def\csname E#1\endcsname{\unmatchedenderror{#1}}% +\parseargdef\end{% + \if 1\csname iscond.#1\endcsname + \else + % The general wording of \badenverr may not be ideal, but... --kasal, 06nov03 + \expandafter\checkenv\csname#1\endcsname + \csname E#1\endcsname + \endgroup + \fi } +\newhelp\EMsimple{Press RETURN to continue.} -% Single-spacing is done by various environments (specifically, in -% \nonfillstart and \quotations). -\newskip\singlespaceskip \singlespaceskip = 12.5pt -\def\singlespace{% - % Why was this kern here? It messes up equalizing space above and below - % environments. --karl, 6may93 - %{\advance \baselineskip by -\singlespaceskip - %\kern \baselineskip}% - \setleading\singlespaceskip -} %% Simple single-character @ commands @@ -466,16 +564,22 @@ \let\{=\mylbrace \let\}=\myrbrace \begingroup - % Definitions to produce actual \{ & \} command in an index. - \catcode`\{ = 12 \catcode`\} = 12 + % Definitions to produce \{ and \} commands for indices, + % and @{ and @} for the aux file. + \catcode`\{ = \other \catcode`\} = \other \catcode`\[ = 1 \catcode`\] = 2 - \catcode`\@ = 0 \catcode`\\ = 12 - @gdef@lbracecmd[\{]% - @gdef@rbracecmd[\}]% -@endgroup + \catcode`\! = 0 \catcode`\\ = \other + !gdef!lbracecmd[\{]% + !gdef!rbracecmd[\}]% + !gdef!lbraceatcmd[@{]% + !gdef!rbraceatcmd[@}]% +!endgroup + +% @comma{} to avoid , parsing problems. +\let\comma = , % Accents: @, @dotaccent @ringaccent @ubaraccent @udotaccent -% Others are defined by plain TeX: @` @' @" @^ @~ @= @v @H. +% Others are defined by plain TeX: @` @' @" @^ @~ @= @u @v @H. \let\, = \c \let\dotaccent = \. \def\ringaccent#1{{\accent23 #1}} @@ -483,10 +587,12 @@ \let\ubaraccent = \b \let\udotaccent = \d -% Other special characters: @questiondown @exclamdown -% Plain TeX defines: @AA @AE @O @OE @L (and lowercase versions) @ss. +% Other special characters: @questiondown @exclamdown @ordf @ordm +% Plain TeX defines: @AA @AE @O @OE @L (plus lowercase versions) @ss. \def\questiondown{?`} \def\exclamdown{!`} +\def\ordf{\leavevmode\raise1ex\hbox{\selectfonts\lllsize \underbar{a}}} +\def\ordm{\leavevmode\raise1ex\hbox{\selectfonts\lllsize \underbar{o}}} % Dotless i and dotless j, used for accents. \def\imacro{i} @@ -499,6 +605,25 @@ \fi\fi } +% The \TeX{} logo, as in plain, but resetting the spacing so that a +% period following counts as ending a sentence. (Idea found in latex.) +% +\edef\TeX{\TeX \spacefactor=1000 } + +% @LaTeX{} logo. Not quite the same results as the definition in +% latex.ltx, since we use a different font for the raised A; it's most +% convenient for us to use an explicitly smaller font, rather than using +% the \scriptstyle font (since we don't reset \scriptstyle and +% \scriptscriptstyle). +% +\def\LaTeX{% + L\kern-.36em + {\setbox0=\hbox{T}% + \vbox to \ht0{\hbox{\selectfonts\lllsize A}\vss}}% + \kern-.15em + \TeX +} + % Be sure we're in horizontal mode when doing a tie, since we make space % equivalent to this in @example-like environments. Otherwise, a space % at the beginning of a line will start with \penalty -- and @@ -517,6 +642,9 @@ % @* forces a line break. \def\*{\hfil\break\hbox{}\ignorespaces} +% @/ allows a line break. +\let\/=\allowbreak + % @. is an end-of-sentence period. \def\.{.\spacefactor=3000 } @@ -539,47 +667,24 @@ % therefore, no glue is inserted, and the space between the headline and % the text is small, which looks bad. % -\def\group{\begingroup - \ifnum\catcode13=\active \else +% Another complication is that the group might be very large. This can +% cause the glue on the previous page to be unduly stretched, because it +% does not have much material. In this case, it's better to add an +% explicit \vfill so that the extra space is at the bottom. The +% threshold for doing this is if the group is more than \vfilllimit +% percent of a page (\vfilllimit can be changed inside of @tex). +% +\newbox\groupbox +\def\vfilllimit{0.7} +% +\envdef\group{% + \ifnum\catcode`\^^M=\active \else \errhelp = \groupinvalidhelp \errmessage{@group invalid in context where filling is enabled}% \fi + \startsavinginserts % - % The \vtop we start below produces a box with normal height and large - % depth; thus, TeX puts \baselineskip glue before it, and (when the - % next line of text is done) \lineskip glue after it. (See p.82 of - % the TeXbook.) Thus, space below is not quite equal to space - % above. But it's pretty close. - \def\Egroup{% - \egroup % End the \vtop. - \endgroup % End the \group. - }% - % - \vtop\bgroup - % We have to put a strut on the last line in case the @group is in - % the midst of an example, rather than completely enclosing it. - % Otherwise, the interline space between the last line of the group - % and the first line afterwards is too small. But we can't put the - % strut in \Egroup, since there it would be on a line by itself. - % Hence this just inserts a strut at the beginning of each line. - \everypar = {\strut}% - % - % Since we have a strut on every line, we don't need any of TeX's - % normal interline spacing. - \offinterlineskip - % - % OK, but now we have to do something about blank - % lines in the input in @example-like environments, which normally - % just turn into \lisppar, which will insert no space now that we've - % turned off the interline space. Simplest is to make them be an - % empty paragraph. - \ifx\par\lisppar - \edef\par{\leavevmode \par}% - % - % Reset ^^M's definition to new definition of \par. - \obeylines - \fi - % + \setbox\groupbox = \vtop\bgroup % Do @comment since we are called inside an environment such as % @example, where each end-of-line in the input causes an % end-of-line in the output. We don't want the end-of-line after @@ -589,6 +694,32 @@ \comment } % +% The \vtop produces a box with normal height and large depth; thus, TeX puts +% \baselineskip glue before it, and (when the next line of text is done) +% \lineskip glue after it. Thus, space below is not quite equal to space +% above. But it's pretty close. +\def\Egroup{% + % To get correct interline space between the last line of the group + % and the first line afterwards, we have to propagate \prevdepth. + \endgraf % Not \par, as it may have been set to \lisppar. + \global\dimen1 = \prevdepth + \egroup % End the \vtop. + % \dimen0 is the vertical size of the group's box. + \dimen0 = \ht\groupbox \advance\dimen0 by \dp\groupbox + % \dimen2 is how much space is left on the page (more or less). + \dimen2 = \pageheight \advance\dimen2 by -\pagetotal + % if the group doesn't fit on the current page, and it's a big big + % group, force a page break. + \ifdim \dimen0 > \dimen2 + \ifdim \pagetotal < \vfilllimit\pageheight + \page + \fi + \fi + \box\groupbox + \prevdepth = \dimen1 + \checkinserts +} +% % TeX puts in an \escapechar (i.e., `@') at the beginning of the help % message, so this ends up printing `@group can only ...'. % @@ -601,10 +732,8 @@ where each line of input produces a line of output.} \newdimen\mil \mil=0.001in -\def\need{\parsearg\needx} - % Old definition--didn't work. -%\def\needx #1{\par % +%\parseargdef\need{\par % %% This method tries to make TeX break the page naturally %% if the depth of the box does not fit. %{\baselineskip=0pt% @@ -612,7 +741,7 @@ where each line of input produces a line of output.} %\prevdepth=-1000pt %}} -\def\needx#1{% +\parseargdef\need{% % Ensure vertical mode, so we don't make a big box in the middle of a % paragraph. \par @@ -651,37 +780,11 @@ where each line of input produces a line of output.} \fi } -% @br forces paragraph break +% @br forces paragraph break (and is undocumented). \let\br = \par -% @dots{} output an ellipsis using the current font. -% We do .5em per period so that it has the same spacing in a typewriter -% font as three actual period characters. -% -\def\dots{% - \leavevmode - \hbox to 1.5em{% - \hskip 0pt plus 0.25fil minus 0.25fil - .\hss.\hss.% - \hskip 0pt plus 0.5fil minus 0.5fil - }% -} - -% @enddots{} is an end-of-sentence ellipsis. -% -\def\enddots{% - \leavevmode - \hbox to 2em{% - \hskip 0pt plus 0.25fil minus 0.25fil - .\hss.\hss.\hss.% - \hskip 0pt plus 0.5fil minus 0.5fil - }% - \spacefactor=3000 -} - - -% @page forces the start of a new page +% @page forces the start of a new page. % \def\page{\par\vfill\supereject} @@ -693,13 +796,11 @@ where each line of input produces a line of output.} \newskip\exdentamount % This defn is used inside fill environments such as @defun. -\def\exdent{\parsearg\exdentyyy} -\def\exdentyyy #1{{\hfil\break\hbox{\kern -\exdentamount{\rm#1}}\hfil\break}} +\parseargdef\exdent{\hfil\break\hbox{\kern -\exdentamount{\rm#1}}\hfil\break} % This defn is used inside nofill environments such as @example. -\def\nofillexdent{\parsearg\nofillexdentyyy} -\def\nofillexdentyyy #1{{\advance \leftskip by -\exdentamount -\leftline{\hskip\leftskip{\rm#1}}}} +\parseargdef\nofillexdent{{\advance \leftskip by -\exdentamount + \leftline{\hskip\leftskip{\rm#1}}}} % @inmargin{WHICH}{TEXT} puts TEXT in the WHICH margin next to the current % paragraph. For more general purposes, use the \margin insertion @@ -730,10 +831,10 @@ where each line of input produces a line of output.} % @inmargin{TEXT [, RIGHT-TEXT]} % (if RIGHT-TEXT is given, use TEXT for left page, RIGHT-TEXT for right; % else use TEXT for both). -% +% \def\inmargin#1{\parseinmargin #1,,\finish} \def\parseinmargin#1,#2,#3\finish{% not perfect, but better than nothing. - \setbox0 = \hbox{\ignorespaces #2}% + \setbox0 = \hbox{\ignorespaces #2}% \ifdim\wd0 > 0pt \def\lefttext{#1}% have both texts \def\righttext{#2}% @@ -751,37 +852,71 @@ where each line of input produces a line of output.} } % @include file insert text of that file as input. -% Allow normal characters that we make active in the argument (a file name). -\def\include{\begingroup - \catcode`\\=12 - \catcode`~=12 - \catcode`^=12 - \catcode`_=12 - \catcode`|=12 - \catcode`<=12 - \catcode`>=12 - \catcode`+=12 - \parsearg\includezzz} -% Restore active chars for included file. -\def\includezzz#1{\endgroup\begingroup - % Read the included file in a group so nested @include's work. +% +\def\include{\parseargusing\filenamecatcodes\includezzz} +\def\includezzz#1{% + \pushthisfilestack \def\thisfile{#1}% - \input\thisfile -\endgroup} + {% + \makevalueexpandable + \def\temp{\input #1 }% + \expandafter + }\temp + \popthisfilestack +} +\def\filenamecatcodes{% + \catcode`\\=\other + \catcode`~=\other + \catcode`^=\other + \catcode`_=\other + \catcode`|=\other + \catcode`<=\other + \catcode`>=\other + \catcode`+=\other + \catcode`-=\other +} -\def\thisfile{} +\def\pushthisfilestack{% + \expandafter\pushthisfilestackX\popthisfilestack\StackTerm +} +\def\pushthisfilestackX{% + \expandafter\pushthisfilestackY\thisfile\StackTerm +} +\def\pushthisfilestackY #1\StackTerm #2\StackTerm {% + \gdef\popthisfilestack{\gdef\thisfile{#1}\gdef\popthisfilestack{#2}}% +} -% @center line outputs that line, centered +\def\popthisfilestack{\errthisfilestackempty} +\def\errthisfilestackempty{\errmessage{Internal error: + the stack of filenames is empty.}} -\def\center{\parsearg\centerzzz} -\def\centerzzz #1{{\advance\hsize by -\leftskip -\advance\hsize by -\rightskip -\centerline{#1}}} +\def\thisfile{} + +% @center line +% outputs that line, centered. +% +\parseargdef\center{% + \ifhmode + \let\next\centerH + \else + \let\next\centerV + \fi + \next{\hfil \ignorespaces#1\unskip \hfil}% +} +\def\centerH#1{% + {% + \hfil\break + \advance\hsize by -\leftskip + \advance\hsize by -\rightskip + \line{#1}% + \break + }% +} +\def\centerV#1{\line{\kern\leftskip #1\kern\rightskip}} % @sp n outputs n lines of vertical space -\def\sp{\parsearg\spxxx} -\def\spxxx #1{\vskip #1\baselineskip} +\parseargdef\sp{\vskip #1\baselineskip} % @comment ...line which is ignored... % @c is the same as @comment @@ -796,13 +931,13 @@ where each line of input produces a line of output.} % @paragraphindent NCHARS % We'll use ems for NCHARS, close enough. -% We cannot implement @paragraphindent asis, though. -% +% NCHARS can also be the word `asis' or `none'. +% We cannot feasibly implement @paragraphindent asis, though. +% \def\asisword{asis} % no translation, these are keywords \def\noneword{none} % -\def\paragraphindent{\parsearg\doparagraphindent} -\def\doparagraphindent#1{% +\parseargdef\paragraphindent{% \def\temp{#1}% \ifx\temp\asisword \else @@ -819,8 +954,7 @@ where each line of input produces a line of output.} % We'll use ems for NCHARS like @paragraphindent. % It seems @exampleindent asis isn't necessary, but % I preserve it to make it similar to @paragraphindent. -\def\exampleindent{\parsearg\doexampleindent} -\def\doexampleindent#1{% +\parseargdef\exampleindent{% \def\temp{#1}% \ifx\temp\asisword \else @@ -832,51 +966,138 @@ where each line of input produces a line of output.} \fi } +% @firstparagraphindent WORD +% If WORD is `none', then suppress indentation of the first paragraph +% after a section heading. If WORD is `insert', then do indent at such +% paragraphs. +% +% The paragraph indentation is suppressed or not by calling +% \suppressfirstparagraphindent, which the sectioning commands do. +% We switch the definition of this back and forth according to WORD. +% By default, we suppress indentation. +% +\def\suppressfirstparagraphindent{\dosuppressfirstparagraphindent} +\def\insertword{insert} +% +\parseargdef\firstparagraphindent{% + \def\temp{#1}% + \ifx\temp\noneword + \let\suppressfirstparagraphindent = \dosuppressfirstparagraphindent + \else\ifx\temp\insertword + \let\suppressfirstparagraphindent = \relax + \else + \errhelp = \EMsimple + \errmessage{Unknown @firstparagraphindent option `\temp'}% + \fi\fi +} + +% Here is how we actually suppress indentation. Redefine \everypar to +% \kern backwards by \parindent, and then reset itself to empty. +% +% We also make \indent itself not actually do anything until the next +% paragraph. +% +\gdef\dosuppressfirstparagraphindent{% + \gdef\indent{% + \restorefirstparagraphindent + \indent + }% + \gdef\noindent{% + \restorefirstparagraphindent + \noindent + }% + \global\everypar = {% + \kern -\parindent + \restorefirstparagraphindent + }% +} + +\gdef\restorefirstparagraphindent{% + \global \let \indent = \ptexindent + \global \let \noindent = \ptexnoindent + \global \everypar = {}% +} + + % @asis just yields its argument. Used with @table, for example. % \def\asis#1{#1} % @math outputs its argument in math mode. -% We don't use $'s directly in the definition of \math because we need -% to set catcodes according to plain TeX first, to allow for subscripts, -% superscripts, special math chars, etc. -% -% @math does not do math typesetting in section titles, index -% entries, and other such contexts where the catcodes are set before -% @math gets a chance to work. This could perhaps be fixed, but for now -% at least we can have real math in the main text, where it's needed most. -% -\let\implicitmath = $%$ font-lock fix % % One complication: _ usually means subscripts, but it could also mean % an actual _ character, as in @math{@var{some_variable} + 1}. So make -% _ within @math be active (mathcode "8000), and distinguish by seeing -% if the current family is \slfam, which is what @var uses. -% -{\catcode95 = \active % 95 = _ -\gdef\mathunderscore{% - \catcode95=\active - \def_{\ifnum\fam=\slfam \_\else\sb\fi}% -}} -% +% _ active, and distinguish by seeing if the current family is \slfam, +% which is what @var uses. +{ + \catcode\underChar = \active + \gdef\mathunderscore{% + \catcode\underChar=\active + \def_{\ifnum\fam=\slfam \_\else\sb\fi}% + } +} % Another complication: we want \\ (and @\) to output a \ character. % FYI, plain.tex uses \\ as a temporary control sequence (why?), but % this is not advertised and we don't care. Texinfo does not % otherwise define @\. -% +% % The \mathchar is class=0=ordinary, family=7=ttfam, position=5C=\. \def\mathbackslash{\ifnum\fam=\ttfam \mathchar"075C \else\backslash \fi} % \def\math{% \tex - \mathcode`\_="8000 \mathunderscore + \mathunderscore \let\\ = \mathbackslash - \implicitmath\finishmath} -\def\finishmath#1{#1\implicitmath\Etex} + \mathactive + $\finishmath +} +\def\finishmath#1{#1$\endgroup} % Close the group opened by \tex. + +% Some active characters (such as <) are spaced differently in math. +% We have to reset their definitions in case the @math was an argument +% to a command which sets the catcodes (such as @item or @section). +% +{ + \catcode`^ = \active + \catcode`< = \active + \catcode`> = \active + \catcode`+ = \active + \gdef\mathactive{% + \let^ = \ptexhat + \let< = \ptexless + \let> = \ptexgtr + \let+ = \ptexplus + } +} % @bullet and @minus need the same treatment as @math, just above. -\def\bullet{\implicitmath\ptexbullet\implicitmath} -\def\minus{\implicitmath-\implicitmath} +\def\bullet{$\ptexbullet$} +\def\minus{$-$} + +% @dots{} outputs an ellipsis using the current font. +% We do .5em per period so that it has the same spacing in a typewriter +% font as three actual period characters. +% +\def\dots{% + \leavevmode + \hbox to 1.5em{% + \hskip 0pt plus 0.25fil + .\hfil.\hfil.% + \hskip 0pt plus 0.5fil + }% +} + +% @enddots{} is an end-of-sentence ellipsis. +% +\def\enddots{% + \dots + \spacefactor=3000 +} + +% @comma{} is so commas can be inserted into text without messing up +% Texinfo's parsing. +% +\let\comma = , % @refill is a no-op. \let\refill=\relax @@ -892,20 +1113,20 @@ where each line of input produces a line of output.} % So open here the files we need to have open while reading the input. % This makes it possible to make a .fmt file for texinfo. \def\setfilename{% + \fixbackslash % Turn off hack to swallow `\input texinfo'. \iflinks - \readauxfile + \tryauxfile + % Open the new aux file. TeX will close it automatically at exit. + \immediate\openout\auxfile=\jobname.aux \fi % \openindices needs to do some work in any case. \openindices - \fixbackslash % Turn off hack to swallow `\input texinfo'. - \global\let\setfilename=\comment % Ignore extra @setfilename cmds. + \let\setfilename=\comment % Ignore extra @setfilename cmds. % % If texinfo.cnf is present on the system, read it. % Useful for site-wide @afourpaper, etc. - % Just to be on the safe side, close the input stream before the \input. \openin 1 texinfo.cnf - \ifeof1 \let\temp=\relax \else \def\temp{\input texinfo.cnf }\fi - \closein1 - \temp + \ifeof 1 \else \input texinfo.cnf \fi + \closein 1 % \comment % Ignore the actual filename. } @@ -941,17 +1162,23 @@ where each line of input produces a line of output.} \newif\ifpdf \newif\ifpdfmakepagedest +% when pdftex is run in dvi mode, \pdfoutput is defined (so \pdfoutput=1 +% can be set). So we test for \relax and 0 as well as \undefined, +% borrowed from ifpdf.sty. \ifx\pdfoutput\undefined - \pdffalse - \let\pdfmkdest = \gobble - \let\pdfurl = \gobble - \let\endlink = \relax - \let\linkcolor = \relax - \let\pdfmakeoutlines = \relax \else - \pdftrue - \pdfoutput = 1 + \ifx\pdfoutput\relax + \else + \ifcase\pdfoutput + \else + \pdftrue + \fi + \fi +\fi +% +\ifpdf \input pdfcolor + \pdfcatalog{/PageMode /UseOutlines}% \def\dopdfimage#1#2#3{% \def\imagewidth{#2}% \def\imageheight{#3}% @@ -965,14 +1192,20 @@ where each line of input produces a line of output.} \ifx\empty\imagewidth\else width \imagewidth \fi \ifx\empty\imageheight\else height \imageheight \fi \ifnum\pdftexversion<13 - #1.pdf% + #1.pdf% \else {#1.pdf}% \fi \ifnum\pdftexversion < 14 \else \pdfrefximage \pdflastximage \fi} - \def\pdfmkdest#1{{\normalturnoffactive \pdfdest name{#1} xyz}} + \def\pdfmkdest#1{{% + % We have to set dummies so commands such as @code in a section title + % aren't expanded. + \atdummies + \normalturnoffactive + \pdfdest name{#1} xyz% + }} \def\pdfmkpgn#1{#1} \let\linkcolor = \Blue % was Cyan, but that seems light? \def\endlink{\Black\pdfendlink} @@ -981,49 +1214,94 @@ where each line of input produces a line of output.} \def\expnumber#1{\expandafter\ifx\csname#1\endcsname\relax 0% \else \csname#1\endcsname \fi} \def\advancenumber#1{\tempnum=\expnumber{#1}\relax - \advance\tempnum by1 + \advance\tempnum by 1 \expandafter\xdef\csname#1\endcsname{\the\tempnum}} - \def\pdfmakeoutlines{{% - \openin 1 \jobname.toc - \ifeof 1\else\begingroup - \closein 1 - \indexnofonts - \def\tt{} - \let\_ = \normalunderscore - % Thanh's hack / proper braces in bookmarks + % + % #1 is the section text. #2 is the pdf expression for the number + % of subentries (or empty, for subsubsections). #3 is the node + % text, which might be empty if this toc entry had no + % corresponding node. #4 is the page number. + % + \def\dopdfoutline#1#2#3#4{% + % Generate a link to the node text if that exists; else, use the + % page number. We could generate a destination for the section + % text in the case where a section has no node, but it doesn't + % seem worthwhile, since most documents are normally structured. + \def\pdfoutlinedest{#3}% + \ifx\pdfoutlinedest\empty \def\pdfoutlinedest{#4}\fi + % + \pdfoutline goto name{\pdfmkpgn{\pdfoutlinedest}}#2{#1}% + } + % + \def\pdfmakeoutlines{% + \begingroup + % Thanh's hack / proper braces in bookmarks \edef\mylbrace{\iftrue \string{\else}\fi}\let\{=\mylbrace \edef\myrbrace{\iffalse{\else\string}\fi}\let\}=\myrbrace % - \def\chapentry ##1##2##3{} - \let\appendixentry = \chapentry - \def\unnumbchapentry ##1##2{} - \def\secentry ##1##2##3##4{\advancenumber{chap##2}} - \def\unnumbsecentry ##1##2##3{\advancenumber{chap##2}} - \def\subsecentry ##1##2##3##4##5{\advancenumber{sec##2.##3}} - \def\unnumbsubsecentry ##1##2##3##4{\advancenumber{sec##2.##3}} - \def\subsubsecentry ##1##2##3##4##5##6{\advancenumber{subsec##2.##3.##4}} - \def\unnumbsubsubsecentry ##1##2##3##4##5{\advancenumber{subsec##2.##3.##4}} + % Read toc silently, to get counts of subentries for \pdfoutline. + \def\numchapentry##1##2##3##4{% + \def\thischapnum{##2}% + \let\thissecnum\empty + \let\thissubsecnum\empty + }% + \def\numsecentry##1##2##3##4{% + \advancenumber{chap\thischapnum}% + \def\thissecnum{##2}% + \let\thissubsecnum\empty + }% + \def\numsubsecentry##1##2##3##4{% + \advancenumber{sec\thissecnum}% + \def\thissubsecnum{##2}% + }% + \def\numsubsubsecentry##1##2##3##4{% + \advancenumber{subsec\thissubsecnum}% + }% + \let\thischapnum\empty + \let\thissecnum\empty + \let\thissubsecnum\empty + % + % use \def rather than \let here because we redefine \chapentry et + % al. a second time, below. + \def\appentry{\numchapentry}% + \def\appsecentry{\numsecentry}% + \def\appsubsecentry{\numsubsecentry}% + \def\appsubsubsecentry{\numsubsubsecentry}% + \def\unnchapentry{\numchapentry}% + \def\unnsecentry{\numsecentry}% + \def\unnsubsecentry{\numsubsecentry}% + \def\unnsubsubsecentry{\numsubsubsecentry}% \input \jobname.toc - \def\chapentry ##1##2##3{% - \pdfoutline goto name{\pdfmkpgn{##3}}count-\expnumber{chap##2}{##1}} - \let\appendixentry = \chapentry - \def\unnumbchapentry ##1##2{% - \pdfoutline goto name{\pdfmkpgn{##2}}{##1}} - \def\secentry ##1##2##3##4{% - \pdfoutline goto name{\pdfmkpgn{##4}}count-\expnumber{sec##2.##3}{##1}} - \def\unnumbsecentry ##1##2##3{% - \pdfoutline goto name{\pdfmkpgn{##3}}{##1}} - \def\subsecentry ##1##2##3##4##5{% - \pdfoutline goto name{\pdfmkpgn{##5}}count-\expnumber{subsec##2.##3.##4}{##1}} - \def\unnumbsubsecentry ##1##2##3##4{% - \pdfoutline goto name{\pdfmkpgn{##4}}{##1}} - \def\subsubsecentry ##1##2##3##4##5##6{% - \pdfoutline goto name{\pdfmkpgn{##6}}{##1}} - \def\unnumbsubsubsecentry ##1##2##3##4##5{% - \pdfoutline goto name{\pdfmkpgn{##5}}{##1}} + % + % Read toc second time, this time actually producing the outlines. + % The `-' means take the \expnumber as the absolute number of + % subentries, which we calculated on our first read of the .toc above. + % + % We use the node names as the destinations. + \def\numchapentry##1##2##3##4{% + \dopdfoutline{##1}{count-\expnumber{chap##2}}{##3}{##4}}% + \def\numsecentry##1##2##3##4{% + \dopdfoutline{##1}{count-\expnumber{sec##2}}{##3}{##4}}% + \def\numsubsecentry##1##2##3##4{% + \dopdfoutline{##1}{count-\expnumber{subsec##2}}{##3}{##4}}% + \def\numsubsubsecentry##1##2##3##4{% count is always zero + \dopdfoutline{##1}{}{##3}{##4}}% + % + % PDF outlines are displayed using system fonts, instead of + % document fonts. Therefore we cannot use special characters, + % since the encoding is unknown. For example, the eogonek from + % Latin 2 (0xea) gets translated to a | character. Info from + % Staszek Wawrykiewicz, 19 Jan 2004 04:09:24 +0100. + % + % xx to do this right, we have to translate 8-bit characters to + % their "best" equivalent, based on the @documentencoding. Right + % now, I guess we'll just let the pdf reader have its way. + \indexnofonts + \turnoffactive \input \jobname.toc - \endgroup\fi - }} + \endgroup + } + % \def\makelinks #1,{% \def\params{#1}\def\E{END}% \ifx\params\E @@ -1032,7 +1310,7 @@ where each line of input produces a line of output.} \let\nextmakelinks=\makelinks \ifnum\lnkcount>0,\fi \picknum{#1}% - \startlink attr{/Border [0 0 0]} + \startlink attr{/Border [0 0 0]} goto name{\pdfmkpgn{\the\pgn}}% \linkcolor #1% \advance\lnkcount by 1% @@ -1054,7 +1332,6 @@ where each line of input produces a line of output.} \def\ppn#1{\pgn=#1\gobble} \def\ppnn{\pgn=\first} \def\pdfmklnk#1{\lnkcount=0\makelinks #1,END,} - \def\addtokens#1#2{\edef\addtoks{\noexpand#1={\the#1#2}}\addtoks} \def\skipspaces#1{\def\PP{#1}\def\D{|}% \ifx\PP\D\let\nextsp\relax \else\let\nextsp\skipspaces @@ -1072,22 +1349,21 @@ where each line of input produces a line of output.} \def\pdfurl#1{% \begingroup \normalturnoffactive\def\@{@}% - \let\value=\expandablevalue + \makevalueexpandable \leavevmode\Red \startlink attr{/Border [0 0 0]}% user{/Subtype /Link /A << /S /URI /URI (#1) >>}% - % #1 \endgroup} \def\pdfgettoks#1.{\setbox\boxA=\hbox{\toksA={#1.}\toksB={}\maketoks}} \def\addtokens#1#2{\edef\addtoks{\noexpand#1={\the#1#2}}\addtoks} \def\adn#1{\addtokens{\toksC}{#1}\global\countA=1\let\next=\maketoks} \def\poptoks#1#2|ENDTOKS|{\let\first=#1\toksD={#1}\toksA={#2}} \def\maketoks{% - \expandafter\poptoks\the\toksA|ENDTOKS| + \expandafter\poptoks\the\toksA|ENDTOKS|\relax \ifx\first0\adn0 \else\ifx\first1\adn1 \else\ifx\first2\adn2 \else\ifx\first3\adn3 \else\ifx\first4\adn4 \else\ifx\first5\adn5 \else\ifx\first6\adn6 - \else\ifx\first7\adn7 \else\ifx\first8\adn8 \else\ifx\first9\adn9 + \else\ifx\first7\adn7 \else\ifx\first8\adn8 \else\ifx\first9\adn9 \else \ifnum0=\countA\else\makelink\fi \ifx\first.\let\next=\done\else @@ -1103,20 +1379,44 @@ where each line of input produces a line of output.} \startlink attr{/Border [0 0 0]} goto name{\pdfmkpgn{#1}} \linkcolor #1\endlink} \def\done{\edef\st{\global\noexpand\toksA={\the\toksB}}\st} -\fi % \ifx\pdfoutput +\else + \let\pdfmkdest = \gobble + \let\pdfurl = \gobble + \let\endlink = \relax + \let\linkcolor = \relax + \let\pdfmakeoutlines = \relax +\fi % \ifx\pdfoutput \message{fonts,} -% Font-change commands. + +% Change the current font style to #1, remembering it in \curfontstyle. +% For now, we do not accumulate font styles: @b{@i{foo}} prints foo in +% italics, not bold italics. +% +\def\setfontstyle#1{% + \def\curfontstyle{#1}% not as a control sequence, because we are \edef'd. + \csname ten#1\endcsname % change the current font +} + +% Select #1 fonts with the current style. +% +\def\selectfonts#1{\csname #1fonts\endcsname \csname\curfontstyle\endcsname} + +\def\rm{\fam=0 \setfontstyle{rm}} +\def\it{\fam=\itfam \setfontstyle{it}} +\def\sl{\fam=\slfam \setfontstyle{sl}} +\def\bf{\fam=\bffam \setfontstyle{bf}} +\def\tt{\fam=\ttfam \setfontstyle{tt}} % Texinfo sort of supports the sans serif font style, which plain TeX does not. -% So we set up a \sf analogous to plain's \rm, etc. +% So we set up a \sf. \newfam\sffam -\def\sf{\fam=\sffam \tensf} +\def\sf{\fam=\sffam \setfontstyle{sf}} \let\li = \sf % Sometimes we call it \li, not \sf. -% We don't need math for this one. -\def\ttsl{\tenttsl} +% We don't need math for this font style. +\def\ttsl{\setfontstyle{ttsl}} % Default leading. \newdimen\textleading \textleading = 13.2pt @@ -1167,10 +1467,11 @@ where each line of input produces a line of output.} \def\scshape{csc} \def\scbshape{csc} +% Text fonts (11.2pt, magstep1). \newcount\mainmagstep \ifx\bigger\relax % not really supported. - \let\mainmagstep=\magstep1 + \mainmagstep=\magstep1 \setfont\textrm\rmshape{12}{1000} \setfont\texttt\ttshape{12}{1000} \else @@ -1178,9 +1479,6 @@ where each line of input produces a line of output.} \setfont\textrm\rmshape{10}{\mainmagstep} \setfont\texttt\ttshape{10}{\mainmagstep} \fi -% Instead of cmb10, you many want to use cmbx10. -% cmbx10 is a prettier font on its own, but cmb10 -% looks better when embedded in a line with cmr10. \setfont\textbf\bfshape{10}{\mainmagstep} \setfont\textit\itshape{10}{\mainmagstep} \setfont\textsl\slshape{10}{\mainmagstep} @@ -1190,10 +1488,11 @@ where each line of input produces a line of output.} \font\texti=cmmi10 scaled \mainmagstep \font\textsy=cmsy10 scaled \mainmagstep -% A few fonts for @defun, etc. -\setfont\defbf\bxshape{10}{\magstep1} %was 1314 +% A few fonts for @defun names and args. +\setfont\defbf\bfshape{10}{\magstep1} \setfont\deftt\ttshape{10}{\magstep1} -\def\df{\let\tentt=\deftt \let\tenbf = \defbf \bf} +\setfont\defttsl\ttslshape{10}{\magstep1} +\def\df{\let\tentt=\deftt \let\tenbf = \defbf \let\tenttsl=\defttsl \bf} % Fonts for indices, footnotes, small examples (9pt). \setfont\smallrm\rmshape{9}{1000} @@ -1219,7 +1518,7 @@ where each line of input produces a line of output.} \font\smalleri=cmmi8 \font\smallersy=cmsy8 -% Fonts for title page: +% Fonts for title page (20.4pt): \setfont\titlerm\rmbshape{12}{\magstep3} \setfont\titleit\itbshape{10}{\magstep4} \setfont\titlesl\slbshape{10}{\magstep4} @@ -1231,6 +1530,7 @@ where each line of input produces a line of output.} \font\titlei=cmmi12 scaled \magstep3 \font\titlesy=cmsy10 scaled \magstep4 \def\authorrm{\secrm} +\def\authortt{\sectt} % Chapter (and unnumbered) fonts (17.28pt). \setfont\chaprm\rmbshape{12}{\magstep2} @@ -1264,11 +1564,21 @@ where each line of input produces a line of output.} \setfont\ssecttsl\ttslshape{10}{1315} \setfont\ssecsf\sfbshape{12}{\magstephalf} \let\ssecbf\ssecrm -\setfont\ssecsc\scbshape{10}{\magstep1} +\setfont\ssecsc\scbshape{10}{1315} \font\sseci=cmmi12 scaled \magstephalf \font\ssecsy=cmsy10 scaled 1315 -% The smallcaps and symbol fonts should actually be scaled \magstep1.5, -% but that is not a standard magnification. + +% Reduced fonts for @acro in text (10pt). +\setfont\reducedrm\rmshape{10}{1000} +\setfont\reducedtt\ttshape{10}{1000} +\setfont\reducedbf\bfshape{10}{1000} +\setfont\reducedit\itshape{10}{1000} +\setfont\reducedsl\slshape{10}{1000} +\setfont\reducedsf\sfshape{10}{1000} +\setfont\reducedsc\scshape{10}{1000} +\setfont\reducedttsl\ttslshape{10}{1000} +\font\reducedi=cmmi10 +\font\reducedsy=cmsy10 % In order for the font changes to affect most math symbols and letters, % we have to define the \textfont of the standard families. Since @@ -1283,56 +1593,95 @@ where each line of input produces a line of output.} } % The font-changing commands redefine the meanings of \tenSTYLE, instead -% of just \STYLE. We do this so that font changes will continue to work -% in math mode, where it is the current \fam that is relevant in most -% cases, not the current font. Plain TeX does \def\bf{\fam=\bffam -% \tenbf}, for example. By redefining \tenbf, we obviate the need to -% redefine \bf itself. +% of just \STYLE. We do this because \STYLE needs to also set the +% current \fam for math mode. Our \STYLE (e.g., \rm) commands hardwire +% \tenSTYLE to set the current font. +% +% Each font-changing command also sets the names \lsize (one size lower) +% and \lllsize (three sizes lower). These relative commands are used in +% the LaTeX logo and acronyms. +% +% This all needs generalizing, badly. +% \def\textfonts{% \let\tenrm=\textrm \let\tenit=\textit \let\tensl=\textsl \let\tenbf=\textbf \let\tentt=\texttt \let\smallcaps=\textsc - \let\tensf=\textsf \let\teni=\texti \let\tensy=\textsy \let\tenttsl=\textttsl + \let\tensf=\textsf \let\teni=\texti \let\tensy=\textsy + \let\tenttsl=\textttsl + \def\lsize{reduced}\def\lllsize{smaller}% \resetmathfonts \setleading{\textleading}} \def\titlefonts{% \let\tenrm=\titlerm \let\tenit=\titleit \let\tensl=\titlesl \let\tenbf=\titlebf \let\tentt=\titlett \let\smallcaps=\titlesc \let\tensf=\titlesf \let\teni=\titlei \let\tensy=\titlesy \let\tenttsl=\titlettsl + \def\lsize{chap}\def\lllsize{subsec}% \resetmathfonts \setleading{25pt}} \def\titlefont#1{{\titlefonts\rm #1}} \def\chapfonts{% \let\tenrm=\chaprm \let\tenit=\chapit \let\tensl=\chapsl \let\tenbf=\chapbf \let\tentt=\chaptt \let\smallcaps=\chapsc \let\tensf=\chapsf \let\teni=\chapi \let\tensy=\chapsy \let\tenttsl=\chapttsl + \def\lsize{sec}\def\lllsize{text}% \resetmathfonts \setleading{19pt}} \def\secfonts{% \let\tenrm=\secrm \let\tenit=\secit \let\tensl=\secsl \let\tenbf=\secbf \let\tentt=\sectt \let\smallcaps=\secsc - \let\tensf=\secsf \let\teni=\seci \let\tensy=\secsy \let\tenttsl=\secttsl + \let\tensf=\secsf \let\teni=\seci \let\tensy=\secsy + \let\tenttsl=\secttsl + \def\lsize{subsec}\def\lllsize{reduced}% \resetmathfonts \setleading{16pt}} \def\subsecfonts{% \let\tenrm=\ssecrm \let\tenit=\ssecit \let\tensl=\ssecsl \let\tenbf=\ssecbf \let\tentt=\ssectt \let\smallcaps=\ssecsc - \let\tensf=\ssecsf \let\teni=\sseci \let\tensy=\ssecsy \let\tenttsl=\ssecttsl + \let\tensf=\ssecsf \let\teni=\sseci \let\tensy=\ssecsy + \let\tenttsl=\ssecttsl + \def\lsize{text}\def\lllsize{small}% \resetmathfonts \setleading{15pt}} -\let\subsubsecfonts = \subsecfonts % Maybe make sssec fonts scaled magstephalf? +\let\subsubsecfonts = \subsecfonts +\def\reducedfonts{% + \let\tenrm=\reducedrm \let\tenit=\reducedit \let\tensl=\reducedsl + \let\tenbf=\reducedbf \let\tentt=\reducedtt \let\reducedcaps=\reducedsc + \let\tensf=\reducedsf \let\teni=\reducedi \let\tensy=\reducedsy + \let\tenttsl=\reducedttsl + \def\lsize{small}\def\lllsize{smaller}% + \resetmathfonts \setleading{10.5pt}} \def\smallfonts{% \let\tenrm=\smallrm \let\tenit=\smallit \let\tensl=\smallsl \let\tenbf=\smallbf \let\tentt=\smalltt \let\smallcaps=\smallsc \let\tensf=\smallsf \let\teni=\smalli \let\tensy=\smallsy \let\tenttsl=\smallttsl + \def\lsize{smaller}\def\lllsize{smaller}% \resetmathfonts \setleading{10.5pt}} \def\smallerfonts{% \let\tenrm=\smallerrm \let\tenit=\smallerit \let\tensl=\smallersl \let\tenbf=\smallerbf \let\tentt=\smallertt \let\smallcaps=\smallersc \let\tensf=\smallersf \let\teni=\smalleri \let\tensy=\smallersy \let\tenttsl=\smallerttsl + \def\lsize{smaller}\def\lllsize{smaller}% \resetmathfonts \setleading{9.5pt}} -\let\smallexamplefonts = \smallerfonts + +% Set the fonts to use with the @small... environments. +\let\smallexamplefonts = \smallfonts + +% About \smallexamplefonts. If we use \smallfonts (9pt), @smallexample +% can fit this many characters: +% 8.5x11=86 smallbook=72 a4=90 a5=69 +% If we use \scriptfonts (8pt), then we can fit this many characters: +% 8.5x11=90+ smallbook=80 a4=90+ a5=77 +% For me, subjectively, the few extra characters that fit aren't worth +% the additional smallness of 8pt. So I'm making the default 9pt. +% +% By the way, for comparison, here's what fits with @example (10pt): +% 8.5x11=71 smallbook=60 a4=75 a5=58 +% +% I wish the USA used A4 paper. +% --karl, 24jan03. + % Set up the default fonts, so we can use them for creating boxes. % -\textfonts +\textfonts \rm % Define these so they can be easily changed for other fonts. \def\angleleft{$\langle$} @@ -1343,23 +1692,33 @@ where each line of input produces a line of output.} % Fonts for short table of contents. \setfont\shortcontrm\rmshape{12}{1000} -\setfont\shortcontbf\bxshape{12}{1000} +\setfont\shortcontbf\bfshape{10}{\magstep1} % no cmb12 \setfont\shortcontsl\slshape{12}{1000} +\setfont\shortconttt\ttshape{12}{1000} %% Add scribe-like font environments, plus @l for inline lisp (usually sans %% serif) and @ii for TeX italic % \smartitalic{ARG} outputs arg in italics, followed by an italic correction % unless the following character is such as not to need one. -\def\smartitalicx{\ifx\next,\else\ifx\next-\else\ifx\next.\else\/\fi\fi\fi} -\def\smartslanted#1{{\sl #1}\futurelet\next\smartitalicx} -\def\smartitalic#1{{\it #1}\futurelet\next\smartitalicx} +\def\smartitalicx{\ifx\next,\else\ifx\next-\else\ifx\next.\else + \ptexslash\fi\fi\fi} +\def\smartslanted#1{{\ifusingtt\ttsl\sl #1}\futurelet\next\smartitalicx} +\def\smartitalic#1{{\ifusingtt\ttsl\it #1}\futurelet\next\smartitalicx} + +% like \smartslanted except unconditionally uses \ttsl. +% @var is set to this for defun arguments. +\def\ttslanted#1{{\ttsl #1}\futurelet\next\smartitalicx} + +% like \smartslanted except unconditionally use \sl. We never want +% ttsl for book titles, do we? +\def\cite#1{{\sl #1}\futurelet\next\smartitalicx} \let\i=\smartitalic +\let\slanted=\smartslanted \let\var=\smartslanted \let\dfn=\smartslanted \let\emph=\smartitalic -\let\cite=\smartslanted \def\b#1{{\bf #1}} \let\strong=\b @@ -1371,11 +1730,21 @@ where each line of input produces a line of output.} \def\nohyphenation{\hyphenchar\font = -1 \aftergroup\restorehyphenation} \def\restorehyphenation{\hyphenchar\font = `- } +% Set sfcode to normal for the chars that usually have another value. +% Can't use plain's \frenchspacing because it uses the `\x notation, and +% sometimes \x has an active definition that messes things up. +% +\catcode`@=11 + \def\frenchspacing{% + \sfcode\dotChar =\@m \sfcode\questChar=\@m \sfcode\exclamChar=\@m + \sfcode\colonChar=\@m \sfcode\semiChar =\@m \sfcode\commaChar =\@m + } +\catcode`@=\other + \def\t#1{% {\tt \rawbackslash \frenchspacing #1}% \null } -\let\ttfont=\t \def\samp#1{`\tclose{#1}'\null} \setfont\keyrm\rmshape{8}{1000} \font\keysy=cmsy9 @@ -1416,7 +1785,7 @@ where each line of input produces a line of output.} \null } -% We *must* turn on hyphenation at `-' and `_' in \code. +% We *must* turn on hyphenation at `-' and `_' in @code. % Otherwise, it is too hard to avoid overfull hboxes % in the Emacs manual, the Library manual, etc. @@ -1434,10 +1803,6 @@ where each line of input produces a line of output.} \catcode`\_=\active \let_\codeunder \codex } - % - % If we end up with any active - characters when handling the index, - % just treat them as a normal -. - \global\def\indexbreaks{\catcode`\-=\active \let-\realdash} } \def\realdash{-} @@ -1461,8 +1826,7 @@ where each line of input produces a line of output.} % @kbdinputstyle -- arg is `distinct' (@kbd uses slanted tty font always), % `example' (@kbd uses ttsl only inside of @example and friends), % or `code' (@kbd uses normal tty font always). -\def\kbdinputstyle{\parsearg\kbdinputstylexxx} -\def\kbdinputstylexxx#1{% +\parseargdef\kbdinputstyle{% \def\arg{#1}% \ifx\arg\worddistinct \gdef\kbdexamplefont{\ttsl}\gdef\kbdfont{\ttsl}% @@ -1470,15 +1834,17 @@ where each line of input produces a line of output.} \gdef\kbdexamplefont{\ttsl}\gdef\kbdfont{\tt}% \else\ifx\arg\wordcode \gdef\kbdexamplefont{\tt}\gdef\kbdfont{\tt}% + \else + \errhelp = \EMsimple + \errmessage{Unknown @kbdinputstyle option `\arg'}% \fi\fi\fi } \def\worddistinct{distinct} \def\wordexample{example} \def\wordcode{code} -% Default is kbdinputdistinct. (Too much of a hassle to call the macro, -% the catcodes are wrong for parsearg to work.) -\gdef\kbdexamplefont{\ttsl}\gdef\kbdfont{\ttsl} +% Default is `distinct.' +\kbdinputstyle distinct \def\xkey{\key} \def\kbdfoo#1#2#3\par{\def\one{#1}\def\three{#3}\def\threex{??}% @@ -1486,8 +1852,8 @@ where each line of input produces a line of output.} \else{\tclose{\kbdfont\look}}\fi \else{\tclose{\kbdfont\look}}\fi} -% For @url, @env, @command quotes seem unnecessary, so use \code. -\let\url=\code +% For @indicateurl, @env, @command quotes seem unnecessary, so use \code. +\let\indicateurl=\code \let\env=\code \let\command=\code @@ -1519,9 +1885,13 @@ where each line of input produces a line of output.} \endlink \endgroup} +% @url synonym for @uref, since that's how everyone uses it. +% +\let\url=\uref + % rms does not like angle brackets --karl, 17may97. % So now @email is just like @uref, unless we are pdf. -% +% %\def\email#1{\angleleft{\tt #1}\angleright} \ifpdf \def\email#1{\doemail#1,,\finish} @@ -1560,12 +1930,53 @@ where each line of input produces a line of output.} \def\sc#1{{\smallcaps#1}} % smallcaps font \def\ii#1{{\it #1}} % italic font -% @acronym downcases the argument and prints in smallcaps. -\def\acronym#1{{\smallcaps \lowercase{#1}}} +% @acronym for "FBI", "NATO", and the like. +% We print this one point size smaller, since it's intended for +% all-uppercase. +% +\def\acronym#1{\doacronym #1,,\finish} +\def\doacronym#1,#2,#3\finish{% + {\selectfonts\lsize #1}% + \def\temp{#2}% + \ifx\temp\empty \else + \space ({\unsepspaces \ignorespaces \temp \unskip})% + \fi +} + +% @abbr for "Comput. J." and the like. +% No font change, but don't do end-of-sentence spacing. +% +\def\abbr#1{\doabbr #1,,\finish} +\def\doabbr#1,#2,#3\finish{% + {\frenchspacing #1}% + \def\temp{#2}% + \ifx\temp\empty \else + \space ({\unsepspaces \ignorespaces \temp \unskip})% + \fi +} -% @pounds{} is a sterling sign. +% @pounds{} is a sterling sign, which Knuth put in the CM italic font. +% \def\pounds{{\it\$}} +% @registeredsymbol - R in a circle. The font for the R should really +% be smaller yet, but lllsize is the best we can do for now. +% Adapted from the plain.tex definition of \copyright. +% +\def\registeredsymbol{% + $^{{\ooalign{\hfil\raise.07ex\hbox{\selectfonts\lllsize R}% + \hfil\crcr\Orb}}% + }$% +} + +% Laurent Siebenmann reports \Orb undefined with: +% Textures 1.7.7 (preloaded format=plain 93.10.14) (68K) 16 APR 2004 02:38 +% so we'll define it if necessary. +% +\ifx\Orb\undefined +\def\Orb{\mathhexbox20D} +\fi + \message{page headings,} @@ -1584,86 +1995,103 @@ where each line of input produces a line of output.} \newif\ifsetshortcontentsaftertitlepage \let\setshortcontentsaftertitlepage = \setshortcontentsaftertitlepagetrue -\def\shorttitlepage{\parsearg\shorttitlepagezzz} -\def\shorttitlepagezzz #1{\begingroup\hbox{}\vskip 1.5in \chaprm \centerline{#1}% +\parseargdef\shorttitlepage{\begingroup\hbox{}\vskip 1.5in \chaprm \centerline{#1}% \endgroup\page\hbox{}\page} -\def\titlepage{\begingroup \parindent=0pt \textfonts - \let\subtitlerm=\tenrm - \def\subtitlefont{\subtitlerm \normalbaselineskip = 13pt \normalbaselines}% - % - \def\authorfont{\authorrm \normalbaselineskip = 16pt \normalbaselines}% - % - % Leave some space at the very top of the page. - \vglue\titlepagetopglue - % - % Now you can print the title using @title. - \def\title{\parsearg\titlezzz}% - \def\titlezzz##1{\leftline{\titlefonts\rm ##1} - % print a rule at the page bottom also. - \finishedtitlepagefalse - \vskip4pt \hrule height 4pt width \hsize \vskip4pt}% - % No rule at page bottom unless we print one at the top with @title. - \finishedtitlepagetrue - % - % Now you can put text using @subtitle. - \def\subtitle{\parsearg\subtitlezzz}% - \def\subtitlezzz##1{{\subtitlefont \rightline{##1}}}% - % - % @author should come last, but may come many times. - \def\author{\parsearg\authorzzz}% - \def\authorzzz##1{\ifseenauthor\else\vskip 0pt plus 1filll\seenauthortrue\fi - {\authorfont \leftline{##1}}}% - % - % Most title ``pages'' are actually two pages long, with space - % at the top of the second. We don't want the ragged left on the second. - \let\oldpage = \page - \def\page{% +\envdef\titlepage{% + % Open one extra group, as we want to close it in the middle of \Etitlepage. + \begingroup + \parindent=0pt \textfonts + % Leave some space at the very top of the page. + \vglue\titlepagetopglue + % No rule at page bottom unless we print one at the top with @title. + \finishedtitlepagetrue + % + % Most title ``pages'' are actually two pages long, with space + % at the top of the second. We don't want the ragged left on the second. + \let\oldpage = \page + \def\page{% \iffinishedtitlepage\else - \finishtitlepage + \finishtitlepage \fi - \oldpage \let\page = \oldpage - \hbox{}}% -% \def\page{\oldpage \hbox{}} + \page + \null + }% } \def\Etitlepage{% - \iffinishedtitlepage\else - \finishtitlepage - \fi - % It is important to do the page break before ending the group, - % because the headline and footline are only empty inside the group. - % If we use the new definition of \page, we always get a blank page - % after the title page, which we certainly don't want. - \oldpage - \endgroup - % - % Need this before the \...aftertitlepage checks so that if they are - % in effect the toc pages will come out with page numbers. - \HEADINGSon - % - % If they want short, they certainly want long too. - \ifsetshortcontentsaftertitlepage - \shortcontents - \contents - \global\let\shortcontents = \relax - \global\let\contents = \relax - \fi - % - \ifsetcontentsaftertitlepage - \contents - \global\let\contents = \relax - \global\let\shortcontents = \relax - \fi + \iffinishedtitlepage\else + \finishtitlepage + \fi + % It is important to do the page break before ending the group, + % because the headline and footline are only empty inside the group. + % If we use the new definition of \page, we always get a blank page + % after the title page, which we certainly don't want. + \oldpage + \endgroup + % + % Need this before the \...aftertitlepage checks so that if they are + % in effect the toc pages will come out with page numbers. + \HEADINGSon + % + % If they want short, they certainly want long too. + \ifsetshortcontentsaftertitlepage + \shortcontents + \contents + \global\let\shortcontents = \relax + \global\let\contents = \relax + \fi + % + \ifsetcontentsaftertitlepage + \contents + \global\let\contents = \relax + \global\let\shortcontents = \relax + \fi } \def\finishtitlepage{% - \vskip4pt \hrule height 2pt width \hsize - \vskip\titlepagebottomglue - \finishedtitlepagetrue + \vskip4pt \hrule height 2pt width \hsize + \vskip\titlepagebottomglue + \finishedtitlepagetrue } +%%% Macros to be used within @titlepage: + +\let\subtitlerm=\tenrm +\def\subtitlefont{\subtitlerm \normalbaselineskip = 13pt \normalbaselines} + +\def\authorfont{\authorrm \normalbaselineskip = 16pt \normalbaselines + \let\tt=\authortt} + +\parseargdef\title{% + \checkenv\titlepage + \leftline{\titlefonts\rm #1} + % print a rule at the page bottom also. + \finishedtitlepagefalse + \vskip4pt \hrule height 4pt width \hsize \vskip4pt +} + +\parseargdef\subtitle{% + \checkenv\titlepage + {\subtitlefont \rightline{#1}}% +} + +% @author should come last, but may come many times. +% It can also be used inside @quotation. +% +\parseargdef\author{% + \def\temp{\quotation}% + \ifx\thisenv\temp + \def\quotationauthor{#1}% printed in \Equotation. + \else + \checkenv\titlepage + \ifseenauthor\else \vskip 0pt plus 1filll \seenauthortrue \fi + {\authorfont \leftline{#1}}% + \fi +} + + %%% Set up page headings and footings. \let\thispage=\folio @@ -1673,7 +2101,7 @@ where each line of input produces a line of output.} \newtoks\evenfootline % footline on even pages \newtoks\oddfootline % footline on odd pages -% Now make Tex use those variables +% Now make TeX use those variables \headline={{\textfonts\rm \ifodd\pageno \the\oddheadline \else \the\evenheadline \fi}} \footline={{\textfonts\rm \ifodd\pageno \the\oddfootline @@ -1687,32 +2115,27 @@ where each line of input produces a line of output.} % @evenfooting @thisfile|| % @oddfooting ||@thisfile -\def\evenheading{\parsearg\evenheadingxxx} -\def\oddheading{\parsearg\oddheadingxxx} -\def\everyheading{\parsearg\everyheadingxxx} - -\def\evenfooting{\parsearg\evenfootingxxx} -\def\oddfooting{\parsearg\oddfootingxxx} -\def\everyfooting{\parsearg\everyfootingxxx} - -{\catcode`\@=0 % -\gdef\evenheadingxxx #1{\evenheadingyyy #1@|@|@|@|\finish} -\gdef\evenheadingyyy #1@|#2@|#3@|#4\finish{% +\def\evenheading{\parsearg\evenheadingxxx} +\def\evenheadingxxx #1{\evenheadingyyy #1\|\|\|\|\finish} +\def\evenheadingyyy #1\|#2\|#3\|#4\finish{% \global\evenheadline={\rlap{\centerline{#2}}\line{#1\hfil#3}}} -\gdef\oddheadingxxx #1{\oddheadingyyy #1@|@|@|@|\finish} -\gdef\oddheadingyyy #1@|#2@|#3@|#4\finish{% +\def\oddheading{\parsearg\oddheadingxxx} +\def\oddheadingxxx #1{\oddheadingyyy #1\|\|\|\|\finish} +\def\oddheadingyyy #1\|#2\|#3\|#4\finish{% \global\oddheadline={\rlap{\centerline{#2}}\line{#1\hfil#3}}} -\gdef\everyheadingxxx#1{\oddheadingxxx{#1}\evenheadingxxx{#1}}% +\parseargdef\everyheading{\oddheadingxxx{#1}\evenheadingxxx{#1}}% -\gdef\evenfootingxxx #1{\evenfootingyyy #1@|@|@|@|\finish} -\gdef\evenfootingyyy #1@|#2@|#3@|#4\finish{% +\def\evenfooting{\parsearg\evenfootingxxx} +\def\evenfootingxxx #1{\evenfootingyyy #1\|\|\|\|\finish} +\def\evenfootingyyy #1\|#2\|#3\|#4\finish{% \global\evenfootline={\rlap{\centerline{#2}}\line{#1\hfil#3}}} -\gdef\oddfootingxxx #1{\oddfootingyyy #1@|@|@|@|\finish} -\gdef\oddfootingyyy #1@|#2@|#3@|#4\finish{% +\def\oddfooting{\parsearg\oddfootingxxx} +\def\oddfootingxxx #1{\oddfootingyyy #1\|\|\|\|\finish} +\def\oddfootingyyy #1\|#2\|#3\|#4\finish{% \global\oddfootline = {\rlap{\centerline{#2}}\line{#1\hfil#3}}% % % Leave some space for the footline. Hopefully ok to assume @@ -1721,9 +2144,8 @@ where each line of input produces a line of output.} \global\advance\vsize by -\baselineskip } -\gdef\everyfootingxxx#1{\oddfootingxxx{#1}\evenfootingxxx{#1}} -% -}% unbind the catcode of @. +\parseargdef\everyfooting{\oddfootingxxx{#1}\evenfootingxxx{#1}} + % @headings double turns headings on for double-sided printing. % @headings single turns headings on for single-sided printing. @@ -1737,7 +2159,7 @@ where each line of input produces a line of output.} \def\headings #1 {\csname HEADINGS#1\endcsname} -\def\HEADINGSoff{ +\def\HEADINGSoff{% \global\evenheadline={\hfil} \global\evenfootline={\hfil} \global\oddheadline={\hfil} \global\oddfootline={\hfil}} \HEADINGSoff @@ -1746,7 +2168,7 @@ where each line of input produces a line of output.} % chapter name on inside top of right hand pages, document % title on inside top of left hand pages, and page numbers on outside top % edge of all pages. -\def\HEADINGSdouble{ +\def\HEADINGSdouble{% \global\pageno=1 \global\evenfootline={\hfil} \global\oddfootline={\hfil} @@ -1758,7 +2180,7 @@ where each line of input produces a line of output.} % For single-sided printing, chapter title goes across top left of page, % page number on top right. -\def\HEADINGSsingle{ +\def\HEADINGSsingle{% \global\pageno=1 \global\evenfootline={\hfil} \global\oddfootline={\hfil} @@ -1805,12 +2227,11 @@ where each line of input produces a line of output.} % @settitle line... specifies the title of the document, for headings. % It generates no output of its own. \def\thistitle{\putwordNoTitle} -\def\settitle{\parsearg\settitlezzz} -\def\settitlezzz #1{\gdef\thistitle{#1}} +\def\settitle{\parsearg{\gdef\thistitle}} \message{tables,} -% Tables -- @table, @ftable, @vtable, @item(x), @kitem(x), @xitem(x). +% Tables -- @table, @ftable, @vtable, @item(x). % default indentation of table text \newdimen\tableindent \tableindent=.8in @@ -1822,7 +2243,7 @@ where each line of input produces a line of output.} % used internally for \itemindent minus \itemmargin \newdimen\itemmax -% Note @table, @vtable, and @vtable define @item, @itemx, etc., with +% Note @table, @ftable, and @vtable define @item, @itemx, etc., with % these defs. % They also define \itemindex % to index the item name in whatever manner is desired (perhaps none). @@ -1834,22 +2255,10 @@ where each line of input produces a line of output.} \def\internalBitem{\smallbreak \parsearg\itemzzz} \def\internalBitemx{\itemxpar \parsearg\itemzzz} -\def\internalBxitem "#1"{\def\xitemsubtopix{#1} \smallbreak \parsearg\xitemzzz} -\def\internalBxitemx "#1"{\def\xitemsubtopix{#1} \itemxpar \parsearg\xitemzzz} - -\def\internalBkitem{\smallbreak \parsearg\kitemzzz} -\def\internalBkitemx{\itemxpar \parsearg\kitemzzz} - -\def\kitemzzz #1{\dosubind {kw}{\code{#1}}{for {\bf \lastfunction}}% - \itemzzz {#1}} - -\def\xitemzzz #1{\dosubind {kw}{\code{#1}}{for {\bf \xitemsubtopic}}% - \itemzzz {#1}} - \def\itemzzz #1{\begingroup % \advance\hsize by -\rightskip \advance\hsize by -\tableindent - \setbox0=\hbox{\itemfont{#1}}% + \setbox0=\hbox{\itemindicate{#1}}% \itemindex{#1}% \nobreak % This prevents a break before @itemx. % @@ -1873,10 +2282,14 @@ where each line of input produces a line of output.} % \parskip glue -- logically it's part of the @item we just started. \nobreak \vskip-\parskip % - % Stop a page break at the \parskip glue coming up. Unfortunately - % we can't prevent a possible page break at the following - % \baselineskip glue. - \nobreak + % Stop a page break at the \parskip glue coming up. However, if + % what follows is an environment such as @example, there will be no + % \parskip glue; then the negative vskip we just inserted would + % cause the example and the item to crash together. So we use this + % bizarre value of 10001 as a signal to \aboveenvbreak to insert + % \parskip glue after all. Section titles are handled this way also. + % + \penalty 10001 \endgroup \itemxneedsnegativevskipfalse \else @@ -1895,97 +2308,95 @@ where each line of input produces a line of output.} \fi } -\def\item{\errmessage{@item while not in a table}} -\def\itemx{\errmessage{@itemx while not in a table}} -\def\kitem{\errmessage{@kitem while not in a table}} -\def\kitemx{\errmessage{@kitemx while not in a table}} -\def\xitem{\errmessage{@xitem while not in a table}} -\def\xitemx{\errmessage{@xitemx while not in a table}} - -% Contains a kludge to get @end[description] to work. -\def\description{\tablez{\dontindex}{1}{}{}{}{}} +\def\item{\errmessage{@item while not in a list environment}} +\def\itemx{\errmessage{@itemx while not in a list environment}} % @table, @ftable, @vtable. -\def\table{\begingroup\inENV\obeylines\obeyspaces\tablex} -{\obeylines\obeyspaces% -\gdef\tablex #1^^M{% -\tabley\dontindex#1 \endtabley}} - -\def\ftable{\begingroup\inENV\obeylines\obeyspaces\ftablex} -{\obeylines\obeyspaces% -\gdef\ftablex #1^^M{% -\tabley\fnitemindex#1 \endtabley -\def\Eftable{\endgraf\afterenvbreak\endgroup}% -\let\Etable=\relax}} - -\def\vtable{\begingroup\inENV\obeylines\obeyspaces\vtablex} -{\obeylines\obeyspaces% -\gdef\vtablex #1^^M{% -\tabley\vritemindex#1 \endtabley -\def\Evtable{\endgraf\afterenvbreak\endgroup}% -\let\Etable=\relax}} - -\def\dontindex #1{} -\def\fnitemindex #1{\doind {fn}{\code{#1}}}% -\def\vritemindex #1{\doind {vr}{\code{#1}}}% - -{\obeyspaces % -\gdef\tabley#1#2 #3 #4 #5 #6 #7\endtabley{\endgroup% -\tablez{#1}{#2}{#3}{#4}{#5}{#6}}} - -\def\tablez #1#2#3#4#5#6{% -\aboveenvbreak % -\begingroup % -\def\Edescription{\Etable}% Necessary kludge. -\let\itemindex=#1% -\ifnum 0#3>0 \advance \leftskip by #3\mil \fi % -\ifnum 0#4>0 \tableindent=#4\mil \fi % -\ifnum 0#5>0 \advance \rightskip by #5\mil \fi % -\def\itemfont{#2}% -\itemmax=\tableindent % -\advance \itemmax by -\itemmargin % -\advance \leftskip by \tableindent % -\exdentamount=\tableindent -\parindent = 0pt -\parskip = \smallskipamount -\ifdim \parskip=0pt \parskip=2pt \fi% -\def\Etable{\endgraf\afterenvbreak\endgroup}% -\let\item = \internalBitem % -\let\itemx = \internalBitemx % -\let\kitem = \internalBkitem % -\let\kitemx = \internalBkitemx % -\let\xitem = \internalBxitem % -\let\xitemx = \internalBxitemx % +\envdef\table{% + \let\itemindex\gobble + \tablex +} +\envdef\ftable{% + \def\itemindex ##1{\doind {fn}{\code{##1}}}% + \tablex +} +\envdef\vtable{% + \def\itemindex ##1{\doind {vr}{\code{##1}}}% + \tablex +} +\def\tablex#1{% + \def\itemindicate{#1}% + \parsearg\tabley } +\def\tabley#1{% + {% + \makevalueexpandable + \edef\temp{\noexpand\tablez #1\space\space\space}% + \expandafter + }\temp \endtablez +} +\def\tablez #1 #2 #3 #4\endtablez{% + \aboveenvbreak + \ifnum 0#1>0 \advance \leftskip by #1\mil \fi + \ifnum 0#2>0 \tableindent=#2\mil \fi + \ifnum 0#3>0 \advance \rightskip by #3\mil \fi + \itemmax=\tableindent + \advance \itemmax by -\itemmargin + \advance \leftskip by \tableindent + \exdentamount=\tableindent + \parindent = 0pt + \parskip = \smallskipamount + \ifdim \parskip=0pt \parskip=2pt \fi + \let\item = \internalBitem + \let\itemx = \internalBitemx +} +\def\Etable{\endgraf\afterenvbreak} +\let\Eftable\Etable +\let\Evtable\Etable +\let\Eitemize\Etable +\let\Eenumerate\Etable % This is the counter used by @enumerate, which is really @itemize \newcount \itemno -\def\itemize{\parsearg\itemizezzz} +\envdef\itemize{\parsearg\doitemize} -\def\itemizezzz #1{% - \begingroup % ended by the @end itemize - \itemizey {#1}{\Eitemize} +\def\doitemize#1{% + \aboveenvbreak + \itemmax=\itemindent + \advance\itemmax by -\itemmargin + \advance\leftskip by \itemindent + \exdentamount=\itemindent + \parindent=0pt + \parskip=\smallskipamount + \ifdim\parskip=0pt \parskip=2pt \fi + \def\itemcontents{#1}% + % @itemize with no arg is equivalent to @itemize @bullet. + \ifx\itemcontents\empty\def\itemcontents{\bullet}\fi + \let\item=\itemizeitem } -\def\itemizey #1#2{% -\aboveenvbreak % -\itemmax=\itemindent % -\advance \itemmax by -\itemmargin % -\advance \leftskip by \itemindent % -\exdentamount=\itemindent -\parindent = 0pt % -\parskip = \smallskipamount % -\ifdim \parskip=0pt \parskip=2pt \fi% -\def#2{\endgraf\afterenvbreak\endgroup}% -\def\itemcontents{#1}% -\let\item=\itemizeitem} - -% Set sfcode to normal for the chars that usually have another value. -% These are `.?!:;,' -\def\frenchspacing{\sfcode46=1000 \sfcode63=1000 \sfcode33=1000 - \sfcode58=1000 \sfcode59=1000 \sfcode44=1000 } +% Definition of @item while inside @itemize and @enumerate. +% +\def\itemizeitem{% + \advance\itemno by 1 % for enumerations + {\let\par=\endgraf \smallbreak}% reasonable place to break + {% + % If the document has an @itemize directly after a section title, a + % \nobreak will be last on the list, and \sectionheading will have + % done a \vskip-\parskip. In that case, we don't want to zero + % parskip, or the item text will crash with the heading. On the + % other hand, when there is normal text preceding the item (as there + % usually is), we do want to zero parskip, or there would be too much + % space. In that case, we won't have a \nobreak before. At least + % that's the theory. + \ifnum\lastpenalty<10000 \parskip=0in \fi + \noindent + \hbox to 0pt{\hss \itemcontents \kern\itemmargin}% + \vadjust{\penalty 1200}}% not good to break after first line of item. + \flushcr +} % \splitoff TOKENS\endmark defines \first to be the first token in % TOKENS, and \rest to be the remainder. @@ -1996,11 +2407,8 @@ where each line of input produces a line of output.} % or number, to specify the first label in the enumerated list. No % argument is the same as `1'. % -\def\enumerate{\parsearg\enumeratezzz} -\def\enumeratezzz #1{\enumeratey #1 \endenumeratey} +\envparseargdef\enumerate{\enumeratey #1 \endenumeratey} \def\enumeratey #1 #2\endenumeratey{% - \begingroup % ended by the @end enumerate - % % If we were given no argument, pretend we were given `1'. \def\thearg{#1}% \ifx\thearg\empty \def\thearg{1}\fi @@ -2071,13 +2479,13 @@ where each line of input produces a line of output.} }% } -% Call itemizey, adding a period to the first argument and supplying the +% Call \doitemize, adding a period to the first argument and supplying the % common last two arguments. Also subtract one from the initial value in % \itemno, since @item increments \itemno. % \def\startenumeration#1{% \advance\itemno by -1 - \itemizey{#1.}\Eenumerate\flushcr + \doitemize{#1.}\flushcr } % @alphaenumerate and @capsenumerate are abbreviations for giving an arg @@ -2088,16 +2496,6 @@ where each line of input produces a line of output.} \def\Ealphaenumerate{\Eenumerate} \def\Ecapsenumerate{\Eenumerate} -% Definition of @item while inside @itemize. - -\def\itemizeitem{% -\advance\itemno by 1 -{\let\par=\endgraf \smallbreak}% -\ifhmode \errmessage{In hmode at itemizeitem}\fi -{\parskip=0in \hskip 0pt -\hbox to 0pt{\hss \itemcontents\hskip \itemmargin}% -\vadjust{\penalty 1200}}% -\flushcr} % @multitable macros % Amy Hendrickson, 8/18/94, 3/6/96 @@ -2124,24 +2522,14 @@ where each line of input produces a line of output.} % @multitable {Column 1 template} {Column 2 template} {Column 3 template} % @item ... % using the widest term desired in each column. -% -% For those who want to use more than one line's worth of words in -% the preamble, break the line within one argument and it -% will parse correctly, i.e., -% -% @multitable {Column 1 template} {Column 2 template} {Column 3 -% template} -% Not: -% @multitable {Column 1 template} {Column 2 template} -% {Column 3 template} % Each new table line starts with @item, each subsequent new column % starts with @tab. Empty columns may be produced by supplying @tab's % with nothing between them for as many times as empty columns are needed, % ie, @tab@tab@tab will produce two empty columns. -% @item, @tab, @multitable or @end multitable do not need to be on their -% own lines, but it will not hurt if they are. +% @item, @tab do not need to be on their own lines, but it will not hurt +% if they are. % Sample multitable: @@ -2185,13 +2573,12 @@ where each line of input produces a line of output.} \def\xcolumnfractions{\columnfractions} \newif\ifsetpercent -% #1 is the part of the @columnfraction before the decimal point, which -% is presumably either 0 or the empty string (but we don't check, we -% just throw it away). #2 is the decimal part, which we use as the -% percent of \hsize for this column. -\def\pickupwholefraction#1.#2 {% +% #1 is the @columnfraction, usually a decimal number like .5, but might +% be just 1. We just use it, whatever it is. +% +\def\pickupwholefraction#1 {% \global\advance\colcount by 1 - \expandafter\xdef\csname col\the\colcount\endcsname{.#2\hsize}% + \expandafter\xdef\csname col\the\colcount\endcsname{#1\hsize}% \setuptable } @@ -2208,8 +2595,8 @@ where each line of input produces a line of output.} \let\go\pickupwholefraction \else \global\advance\colcount by 1 - \setbox0=\hbox{#1\unskip }% Add a normal word space as a separator; - % typically that is always in the input, anyway. + \setbox0=\hbox{#1\unskip\space}% Add a normal word space as a + % separator; typically that is always in the input, anyway. \expandafter\xdef\csname col\the\colcount\endcsname{\the\wd0}% \fi \fi @@ -2224,18 +2611,33 @@ where each line of input produces a line of output.} \go } -% This used to have \hskip1sp. But then the space in a template line is -% not enough. That is bad. So let's go back to just & until we -% encounter the problem it was intended to solve again. -% --karl, nathan@acm.org, 20apr99. -\def\tab{&} +% multitable-only commands. +% +% @headitem starts a heading row, which we typeset in bold. +% Assignments have to be global since we are inside the implicit group +% of an alignment entry. Note that \everycr resets \everytab. +\def\headitem{\checkenv\multitable \crcr \global\everytab={\bf}\the\everytab}% +% +% A \tab used to include \hskip1sp. But then the space in a template +% line is not enough. That is bad. So let's go back to just `&' until +% we encounter the problem it was intended to solve again. +% --karl, nathan@acm.org, 20apr99. +\def\tab{\checkenv\multitable &\the\everytab}% % @multitable ... @end multitable definitions: % -\def\multitable{\parsearg\dotable} -\def\dotable#1{\bgroup +\newtoks\everytab % insert after every tab. +% +\envdef\multitable{% \vskip\parskip - \let\item\crcr + \startsavinginserts + % + % @item within a multitable starts a normal row. + % We use \def instead of \let so that if one of the multitable entries + % contains an @itemize, we don't choke on the \item (seen as \crcr aka + % \endtemplate) expanding \doitemize. + \def\item{\crcr}% + % \tolerance=9500 \hbadness=9500 \setmultitablespacing @@ -2243,66 +2645,80 @@ where each line of input produces a line of output.} \parindent=\multitableparindent \overfullrule=0pt \global\colcount=0 - \def\Emultitable{\global\setpercentfalse\cr\egroup\egroup}% % + \everycr = {% + \noalign{% + \global\everytab={}% + \global\colcount=0 % Reset the column counter. + % Check for saved footnotes, etc. + \checkinserts + % Keeps underfull box messages off when table breaks over pages. + %\filbreak + % Maybe so, but it also creates really weird page breaks when the + % table breaks over pages. Wouldn't \vfil be better? Wait until the + % problem manifests itself, so it can be fixed for real --karl. + }% + }% + % + \parsearg\domultitable +} +\def\domultitable#1{% % To parse everything between @multitable and @item: \setuptable#1 \endsetuptable % - % \everycr will reset column counter, \colcount, at the end of - % each line. Every column entry will cause \colcount to advance by one. - % The table preamble - % looks at the current \colcount to find the correct column width. - \everycr{\noalign{% - % - % \filbreak%% keeps underfull box messages off when table breaks over pages. - % Maybe so, but it also creates really weird page breaks when the table - % breaks over pages. Wouldn't \vfil be better? Wait until the problem - % manifests itself, so it can be fixed for real --karl. - \global\colcount=0\relax}}% - % % This preamble sets up a generic column definition, which will % be used as many times as user calls for columns. % \vtop will set a single line and will also let text wrap and % continue for many paragraphs if desired. - \halign\bgroup&\global\advance\colcount by 1\relax - \multistrut\vtop{\hsize=\expandafter\csname col\the\colcount\endcsname - % - % In order to keep entries from bumping into each other - % we will add a \leftskip of \multitablecolspace to all columns after - % the first one. - % - % If a template has been used, we will add \multitablecolspace - % to the width of each template entry. - % - % If the user has set preamble in terms of percent of \hsize we will - % use that dimension as the width of the column, and the \leftskip - % will keep entries from bumping into each other. Table will start at - % left margin and final column will justify at right margin. - % - % Make sure we don't inherit \rightskip from the outer environment. - \rightskip=0pt - \ifnum\colcount=1 - % The first column will be indented with the surrounding text. - \advance\hsize by\leftskip - \else - \ifsetpercent \else - % If user has not set preamble in terms of percent of \hsize - % we will advance \hsize by \multitablecolspace. - \advance\hsize by \multitablecolspace - \fi - % In either case we will make \leftskip=\multitablecolspace: - \leftskip=\multitablecolspace - \fi - % Ignoring space at the beginning and end avoids an occasional spurious - % blank line, when TeX decides to break the line at the space before the - % box from the multistrut, so the strut ends up on a line by itself. - % For example: - % @multitable @columnfractions .11 .89 - % @item @code{#} - % @tab Legal holiday which is valid in major parts of the whole country. - % Is automatically provided with highlighting sequences respectively marking - % characters. - \noindent\ignorespaces##\unskip\multistrut}\cr + \halign\bgroup &% + \global\advance\colcount by 1 + \multistrut + \vtop{% + % Use the current \colcount to find the correct column width: + \hsize=\expandafter\csname col\the\colcount\endcsname + % + % In order to keep entries from bumping into each other + % we will add a \leftskip of \multitablecolspace to all columns after + % the first one. + % + % If a template has been used, we will add \multitablecolspace + % to the width of each template entry. + % + % If the user has set preamble in terms of percent of \hsize we will + % use that dimension as the width of the column, and the \leftskip + % will keep entries from bumping into each other. Table will start at + % left margin and final column will justify at right margin. + % + % Make sure we don't inherit \rightskip from the outer environment. + \rightskip=0pt + \ifnum\colcount=1 + % The first column will be indented with the surrounding text. + \advance\hsize by\leftskip + \else + \ifsetpercent \else + % If user has not set preamble in terms of percent of \hsize + % we will advance \hsize by \multitablecolspace. + \advance\hsize by \multitablecolspace + \fi + % In either case we will make \leftskip=\multitablecolspace: + \leftskip=\multitablecolspace + \fi + % Ignoring space at the beginning and end avoids an occasional spurious + % blank line, when TeX decides to break the line at the space before the + % box from the multistrut, so the strut ends up on a line by itself. + % For example: + % @multitable @columnfractions .11 .89 + % @item @code{#} + % @tab Legal holiday which is valid in major parts of the whole country. + % Is automatically provided with highlighting sequences respectively + % marking characters. + \noindent\ignorespaces##\unskip\multistrut + }\cr +} +\def\Emultitable{% + \crcr + \egroup % end the \halign + \global\setpercentfalse } \def\setmultitablespacing{% test to see if user has set \multitablelinespace. @@ -2334,294 +2750,172 @@ width0pt\relax} \fi \message{conditionals,} -% Prevent errors for section commands. -% Used in @ignore and in failing conditionals. -\def\ignoresections{% - \let\chapter=\relax - \let\unnumbered=\relax - \let\top=\relax - \let\unnumberedsec=\relax - \let\unnumberedsection=\relax - \let\unnumberedsubsec=\relax - \let\unnumberedsubsection=\relax - \let\unnumberedsubsubsec=\relax - \let\unnumberedsubsubsection=\relax - \let\section=\relax - \let\subsec=\relax - \let\subsubsec=\relax - \let\subsection=\relax - \let\subsubsection=\relax - \let\appendix=\relax - \let\appendixsec=\relax - \let\appendixsection=\relax - \let\appendixsubsec=\relax - \let\appendixsubsection=\relax - \let\appendixsubsubsec=\relax - \let\appendixsubsubsection=\relax - \let\contents=\relax - \let\smallbook=\relax - \let\titlepage=\relax -} - -% Used in nested conditionals, where we have to parse the Texinfo source -% and so want to turn off most commands, in case they are used -% incorrectly. -% -\def\ignoremorecommands{% - \let\defcodeindex = \relax - \let\defcv = \relax - \let\deffn = \relax - \let\deffnx = \relax - \let\defindex = \relax - \let\defivar = \relax - \let\defmac = \relax - \let\defmethod = \relax - \let\defop = \relax - \let\defopt = \relax - \let\defspec = \relax - \let\deftp = \relax - \let\deftypefn = \relax - \let\deftypefun = \relax - \let\deftypeivar = \relax - \let\deftypeop = \relax - \let\deftypevar = \relax - \let\deftypevr = \relax - \let\defun = \relax - \let\defvar = \relax - \let\defvr = \relax - \let\ref = \relax - \let\xref = \relax - \let\printindex = \relax - \let\pxref = \relax - \let\settitle = \relax - \let\setchapternewpage = \relax - \let\setchapterstyle = \relax - \let\everyheading = \relax - \let\evenheading = \relax - \let\oddheading = \relax - \let\everyfooting = \relax - \let\evenfooting = \relax - \let\oddfooting = \relax - \let\headings = \relax - \let\include = \relax - \let\lowersections = \relax - \let\down = \relax - \let\raisesections = \relax - \let\up = \relax - \let\set = \relax - \let\clear = \relax - \let\item = \relax -} - -% Ignore @ignore, @ifhtml, @ifinfo, @ifplaintext, @ifnottex, @html, @menu, -% @direntry, and @documentdescription. + +% @iftex, @ifnotdocbook, @ifnothtml, @ifnotinfo, @ifnotplaintext, +% @ifnotxml always succeed. They currently do nothing; we don't +% attempt to check whether the conditionals are properly nested. But we +% have to remember that they are conditionals, so that @end doesn't +% attempt to close an environment group. % -\def\ignore{\doignore{ignore}} +\def\makecond#1{% + \expandafter\let\csname #1\endcsname = \relax + \expandafter\let\csname iscond.#1\endcsname = 1 +} +\makecond{iftex} +\makecond{ifnotdocbook} +\makecond{ifnothtml} +\makecond{ifnotinfo} +\makecond{ifnotplaintext} +\makecond{ifnotxml} + +% Ignore @ignore, @ifhtml, @ifinfo, and the like. +% +\def\direntry{\doignore{direntry}} +\def\documentdescription{\doignore{documentdescription}} +\def\docbook{\doignore{docbook}} +\def\html{\doignore{html}} +\def\ifdocbook{\doignore{ifdocbook}} \def\ifhtml{\doignore{ifhtml}} \def\ifinfo{\doignore{ifinfo}} -\def\ifplaintext{\doignore{ifplaintext}} \def\ifnottex{\doignore{ifnottex}} -\def\html{\doignore{html}} +\def\ifplaintext{\doignore{ifplaintext}} +\def\ifxml{\doignore{ifxml}} +\def\ignore{\doignore{ignore}} \def\menu{\doignore{menu}} -\def\direntry{\doignore{direntry}} -\def\documentdescription{\doignore{documentdescription}} -\def\documentdescriptionword{documentdescription} - -% @dircategory CATEGORY -- specify a category of the dir file -% which this file should belong to. Ignore this in TeX. -\let\dircategory = \comment +\def\xml{\doignore{xml}} -% Ignore text until a line `@end #1'. +% Ignore text until a line `@end #1', keeping track of nested conditionals. % +% A count to remember the depth of nesting. +\newcount\doignorecount + \def\doignore#1{\begingroup - % Don't complain about control sequences we have declared \outer. - \ignoresections - % - % Define a command to swallow text until we reach `@end #1'. - % This @ is a catcode 12 token (that is the normal catcode of @ in - % this texinfo.tex file). We change the catcode of @ below to match. - \long\def\doignoretext##1@end #1{\enddoignore}% + % Scan in ``verbatim'' mode: + \catcode`\@ = \other + \catcode`\{ = \other + \catcode`\} = \other % % Make sure that spaces turn into tokens that match what \doignoretext wants. - \catcode32 = 10 - % - % Ignore braces, too, so mismatched braces don't cause trouble. - \catcode`\{ = 9 - \catcode`\} = 9 + \spaceisspace % - % We must not have @c interpreted as a control sequence. - \catcode`\@ = 12 - % - \def\ignoreword{#1}% - \ifx\ignoreword\documentdescriptionword - % The c kludge breaks documentdescription, since - % `documentdescription' contains a `c'. Means not everything will - % be ignored inside @documentdescription, but oh well... - \else - % Make the letter c a comment character so that the rest of the line - % will be ignored. This way, the document can have (for example) - % @c @end ifinfo - % and the @end ifinfo will be properly ignored. - % (We've just changed @ to catcode 12.) - \catcode`\c = 14 - \fi + % Count number of #1's that we've seen. + \doignorecount = 0 % - % And now expand the command defined above. - \doignoretext -} - -% What we do to finish off ignored text. -% -\def\enddoignore{\endgroup\ignorespaces}% - -\newif\ifwarnedobs\warnedobsfalse -\def\obstexwarn{% - \ifwarnedobs\relax\else - % We need to warn folks that they may have trouble with TeX 3.0. - % This uses \immediate\write16 rather than \message to get newlines. - \immediate\write16{} - \immediate\write16{WARNING: for users of Unix TeX 3.0!} - \immediate\write16{This manual trips a bug in TeX version 3.0 (tex hangs).} - \immediate\write16{If you are running another version of TeX, relax.} - \immediate\write16{If you are running Unix TeX 3.0, kill this TeX process.} - \immediate\write16{ Then upgrade your TeX installation if you can.} - \immediate\write16{ (See ftp://ftp.gnu.org/pub/gnu/TeX.README.)} - \immediate\write16{If you are stuck with version 3.0, run the} - \immediate\write16{ script ``tex3patch'' from the Texinfo distribution} - \immediate\write16{ to use a workaround.} - \immediate\write16{} - \global\warnedobstrue - \fi + % Swallow text until we reach the matching `@end #1'. + \dodoignore{#1}% } -% **In TeX 3.0, setting text in \nullfont hangs tex. For a -% workaround (which requires the file ``dummy.tfm'' to be installed), -% uncomment the following line: -%%%%%\font\nullfont=dummy\let\obstexwarn=\relax - -% Ignore text, except that we keep track of conditional commands for -% purposes of nesting, up to an `@end #1' command. -% -\def\nestedignore#1{% - \obstexwarn - % We must actually expand the ignored text to look for the @end - % command, so that nested ignore constructs work. Thus, we put the - % text into a \vbox and then do nothing with the result. To minimize - % the change of memory overflow, we follow the approach outlined on - % page 401 of the TeXbook: make the current font be a dummy font. +{ \catcode`_=11 % We want to use \_STOP_ which cannot appear in texinfo source. + \obeylines % % - \setbox0 = \vbox\bgroup - % Don't complain about control sequences we have declared \outer. - \ignoresections - % - % Define `@end #1' to end the box, which will in turn undefine the - % @end command again. - \expandafter\def\csname E#1\endcsname{\egroup\ignorespaces}% + \gdef\dodoignore#1{% + % #1 contains the command name as a string, e.g., `ifinfo'. % - % We are going to be parsing Texinfo commands. Most cause no - % trouble when they are used incorrectly, but some commands do - % complicated argument parsing or otherwise get confused, so we - % undefine them. + % Define a command to find the next `@end #1', which must be on a line + % by itself. + \long\def\doignoretext##1^^M@end #1{\doignoretextyyy##1^^M@#1\_STOP_}% + % And this command to find another #1 command, at the beginning of a + % line. (Otherwise, we would consider a line `@c @ifset', for + % example, to count as an @ifset for nesting.) + \long\def\doignoretextyyy##1^^M@#1##2\_STOP_{\doignoreyyy{##2}\_STOP_}% % - % We can't do anything about stray @-signs, unfortunately; - % they'll produce `undefined control sequence' errors. - \ignoremorecommands - % - % Set the current font to be \nullfont, a TeX primitive, and define - % all the font commands to also use \nullfont. We don't use - % dummy.tfm, as suggested in the TeXbook, because not all sites - % might have that installed. Therefore, math mode will still - % produce output, but that should be an extremely small amount of - % stuff compared to the main input. - % - \nullfont - \let\tenrm=\nullfont \let\tenit=\nullfont \let\tensl=\nullfont - \let\tenbf=\nullfont \let\tentt=\nullfont \let\smallcaps=\nullfont - \let\tensf=\nullfont - % Similarly for index fonts. - \let\smallrm=\nullfont \let\smallit=\nullfont \let\smallsl=\nullfont - \let\smallbf=\nullfont \let\smalltt=\nullfont \let\smallsc=\nullfont - \let\smallsf=\nullfont - % Similarly for smallexample fonts. - \let\smallerrm=\nullfont \let\smallerit=\nullfont \let\smallersl=\nullfont - \let\smallerbf=\nullfont \let\smallertt=\nullfont \let\smallersc=\nullfont - \let\smallersf=\nullfont - % - % Don't complain when characters are missing from the fonts. - \tracinglostchars = 0 - % - % Don't bother to do space factor calculations. - \frenchspacing - % - % Don't report underfull hboxes. - \hbadness = 10000 - % - % Do minimal line-breaking. - \pretolerance = 10000 - % - % Do not execute instructions in @tex - \def\tex{\doignore{tex}}% - % Do not execute macro definitions. - % `c' is a comment character, so the word `macro' will get cut off. - \def\macro{\doignore{ma}}% + % And now expand that command. + \obeylines % + \doignoretext ^^M% + }% +} + +\def\doignoreyyy#1{% + \def\temp{#1}% + \ifx\temp\empty % Nothing found. + \let\next\doignoretextzzz + \else % Found a nested condition, ... + \advance\doignorecount by 1 + \let\next\doignoretextyyy % ..., look for another. + % If we're here, #1 ends with ^^M\ifinfo (for example). + \fi + \next #1% the token \_STOP_ is present just after this macro. +} + +% We have to swallow the remaining "\_STOP_". +% +\def\doignoretextzzz#1{% + \ifnum\doignorecount = 0 % We have just found the outermost @end. + \let\next\enddoignore + \else % Still inside a nested condition. + \advance\doignorecount by -1 + \let\next\doignoretext % Look for the next @end. + \fi + \next } +% Finish off ignored text. +\def\enddoignore{\endgroup\ignorespaces} + + % @set VAR sets the variable VAR to an empty value. % @set VAR REST-OF-LINE sets VAR to the value REST-OF-LINE. % % Since we want to separate VAR from REST-OF-LINE (which might be % empty), we can't just use \parsearg; we have to insert a space of our % own to delimit the rest of the line, and then take it out again if we -% didn't need it. Make sure the catcode of space is correct to avoid -% losing inside @example, for instance. +% didn't need it. +% We rely on the fact that \parsearg sets \catcode`\ =10. % -\def\set{\begingroup\catcode` =10 - \catcode`\-=12 \catcode`\_=12 % Allow - and _ in VAR. - \parsearg\setxxx} -\def\setxxx#1{\setyyy#1 \endsetyyy} +\parseargdef\set{\setyyy#1 \endsetyyy} \def\setyyy#1 #2\endsetyyy{% - \def\temp{#2}% - \ifx\temp\empty \global\expandafter\let\csname SET#1\endcsname = \empty - \else \setzzz{#1}#2\endsetzzz % Remove the trailing space \setxxx inserted. - \fi - \endgroup + {% + \makevalueexpandable + \def\temp{#2}% + \edef\next{\gdef\makecsname{SET#1}}% + \ifx\temp\empty + \next{}% + \else + \setzzz#2\endsetzzz + \fi + }% } -% Can't use \xdef to pre-expand #2 and save some time, since \temp or -% \next or other control sequences that we've defined might get us into -% an infinite loop. Consider `@set foo @cite{bar}'. -\def\setzzz#1#2 \endsetzzz{\expandafter\gdef\csname SET#1\endcsname{#2}} +% Remove the trailing space \setxxx inserted. +\def\setzzz#1 \endsetzzz{\next{#1}} % @clear VAR clears (i.e., unsets) the variable VAR. % -\def\clear{\parsearg\clearxxx} -\def\clearxxx#1{\global\expandafter\let\csname SET#1\endcsname=\relax} +\parseargdef\clear{% + {% + \makevalueexpandable + \global\expandafter\let\csname SET#1\endcsname=\relax + }% +} % @value{foo} gets the text saved in variable foo. +\def\value{\begingroup\makevalueexpandable\valuexxx} +\def\valuexxx#1{\expandablevalue{#1}\endgroup} { - \catcode`\_ = \active + \catcode`\- = \active \catcode`\_ = \active % - % We might end up with active _ or - characters in the argument if - % we're called from @code, as @code{@value{foo-bar_}}. So \let any - % such active characters to their normal equivalents. - \gdef\value{\begingroup - \catcode`\-=12 \catcode`\_=12 - \indexbreaks \let_\normalunderscore - \valuexxx} + \gdef\makevalueexpandable{% + \let\value = \expandablevalue + % We don't want these characters active, ... + \catcode`\-=\other \catcode`\_=\other + % ..., but we might end up with active ones in the argument if + % we're called from @code, as @code{@value{foo-bar_}}, though. + % So \let them to their normal equivalents. + \let-\realdash \let_\normalunderscore + } } -\def\valuexxx#1{\expandablevalue{#1}\endgroup} % We have this subroutine so that we can handle at least some @value's -% properly in indexes (we \let\value to this in \indexdummies). Ones -% whose names contain - or _ still won't work, but we can't do anything -% about that. The command has to be fully expandable, since the result -% winds up in the index file. This means that if the variable's value -% contains other Texinfo commands, it's almost certain it will fail -% (although perhaps we could fix that with sufficient work to do a -% one-level expansion on the result, instead of complete). +% properly in indexes (we call \makevalueexpandable in \indexdummies). +% The command has to be fully expandable (if the variable is set), since +% the result winds up in the index file. This means that if the +% variable's value contains other Texinfo commands, it's almost certain +% it will fail (although perhaps we could fix that with sufficient work +% to do a one-level expansion on the result, instead of complete). % \def\expandablevalue#1{% \expandafter\ifx\csname SET#1\endcsname\relax {[No value for ``#1'']}% + \message{Variable `#1', used in @value, is not set.}% \else \csname SET#1\endcsname \fi @@ -2630,68 +2924,36 @@ width0pt\relax} \fi % @ifset VAR ... @end ifset reads the `...' iff VAR has been defined % with @set. % -\def\ifset{\parsearg\ifsetxxx} -\def\ifsetxxx #1{% - \expandafter\ifx\csname SET#1\endcsname\relax - \expandafter\ifsetfail - \else - \expandafter\ifsetsucceed - \fi +% To get special treatment of `@end ifset,' call \makeond and the redefine. +% +\makecond{ifset} +\def\ifset{\parsearg{\doifset{\let\next=\ifsetfail}}} +\def\doifset#1#2{% + {% + \makevalueexpandable + \let\next=\empty + \expandafter\ifx\csname SET#2\endcsname\relax + #1% If not set, redefine \next. + \fi + \expandafter + }\next } -\def\ifsetsucceed{\conditionalsucceed{ifset}} -\def\ifsetfail{\nestedignore{ifset}} -\defineunmatchedend{ifset} +\def\ifsetfail{\doignore{ifset}} % @ifclear VAR ... @end ifclear reads the `...' iff VAR has never been % defined with @set, or has been undefined with @clear. % -\def\ifclear{\parsearg\ifclearxxx} -\def\ifclearxxx #1{% - \expandafter\ifx\csname SET#1\endcsname\relax - \expandafter\ifclearsucceed - \else - \expandafter\ifclearfail - \fi -} -\def\ifclearsucceed{\conditionalsucceed{ifclear}} -\def\ifclearfail{\nestedignore{ifclear}} -\defineunmatchedend{ifclear} - -% @iftex, @ifnothtml, @ifnotinfo, @ifnotplaintext always succeed; we -% read the text following, through the first @end iftex (etc.). Make -% `@end iftex' (etc.) valid only after an @iftex. -% -\def\iftex{\conditionalsucceed{iftex}} -\def\ifnothtml{\conditionalsucceed{ifnothtml}} -\def\ifnotinfo{\conditionalsucceed{ifnotinfo}} -\def\ifnotplaintext{\conditionalsucceed{ifnotplaintext}} -\defineunmatchedend{iftex} -\defineunmatchedend{ifnothtml} -\defineunmatchedend{ifnotinfo} -\defineunmatchedend{ifnotplaintext} - -% We can't just want to start a group at @iftex (etc.) and end it at -% @end iftex, since then @set commands inside the conditional have no -% effect (they'd get reverted at the end of the group). So we must -% define \Eiftex to redefine itself to be its previous value. (We can't -% just define it to fail again with an ``unmatched end'' error, since -% the @ifset might be nested.) -% -\def\conditionalsucceed#1{% - \edef\temp{% - % Remember the current value of \E#1. - \let\nece{prevE#1} = \nece{E#1}% - % - % At the `@end #1', redefine \E#1 to be its previous value. - \def\nece{E#1}{\let\nece{E#1} = \nece{prevE#1}}% - }% - \temp -} - -% We need to expand lots of \csname's, but we don't want to expand the -% control sequences after we've constructed them. +% The `\else' inside the `\doifset' parameter is a trick to reuse the +% above code: if the variable is not set, do nothing, if it is set, +% then redefine \next to \ifclearfail. % -\def\nece#1{\expandafter\noexpand\csname#1\endcsname} +\makecond{ifclear} +\def\ifclear{\parsearg{\doifset{\else \let\next=\ifclearfail}}} +\def\ifclearfail{\doignore{ifclear}} + +% @dircategory CATEGORY -- specify a category of the dir file +% which this file should belong to. Ignore this in TeX. +\let\dircategory=\comment % @defininfoenclose. \let\definfoenclose=\comment @@ -2742,10 +3004,10 @@ width0pt\relax} \fi % @synindex foo bar makes index foo feed into index bar. % Do this instead of @defindex foo if you don't want it as a separate index. -% +% % @syncodeindex foo bar similar, but put all entries made for index foo % inside @code. -% +% \def\synindex#1 #2 {\dosynindex\doindex{#1}{#2}} \def\syncodeindex#1 #2 {\dosynindex\docodeindex{#1}{#2}} @@ -2784,284 +3046,402 @@ width0pt\relax} \fi \def\docodeindex#1{\edef\indexname{#1}\parsearg\singlecodeindexer} \def\singlecodeindexer #1{\doind{\indexname}{\code{#1}}} -% Take care of texinfo commands likely to appear in an index entry. -% (Must be a way to avoid doing expansion at all, and thus not have to -% laboriously list every single command here.) -% +% Take care of Texinfo commands that can appear in an index entry. +% Since there are some commands we want to expand, and others we don't, +% we have to laboriously prevent expansion for those that we don't. +% \def\indexdummies{% -\def\ { }% -\def\@{@}% change to @@ when we switch to @ as escape char in aux files. -% Need these in case \tex is in effect and \{ is a \delimiter again. -% But can't use \lbracecmd and \rbracecmd because texindex assumes -% braces and backslashes are used only as delimiters. -\let\{ = \mylbrace -\let\} = \myrbrace -\def\_{{\realbackslash _}}% -\normalturnoffactive -% -% Take care of the plain tex accent commands. -\def\,##1{\realbackslash ,{##1}}% -\def\"{\realbackslash "}% -\def\`{\realbackslash `}% -\def\'{\realbackslash '}% -\def\^{\realbackslash ^}% -\def\~{\realbackslash ~}% -\def\={\realbackslash =}% -\def\b{\realbackslash b}% -\def\c{\realbackslash c}% -\def\d{\realbackslash d}% -\def\u{\realbackslash u}% -\def\v{\realbackslash v}% -\def\H{\realbackslash H}% -\def\dotless##1{\realbackslash dotless {##1}}% -% Take care of the plain tex special European modified letters. -\def\AA{\realbackslash AA}% -\def\AE{\realbackslash AE}% -\def\L{\realbackslash L}% -\def\OE{\realbackslash OE}% -\def\O{\realbackslash O}% -\def\aa{\realbackslash aa}% -\def\ae{\realbackslash ae}% -\def\l{\realbackslash l}% -\def\oe{\realbackslash oe}% -\def\o{\realbackslash o}% -\def\ss{\realbackslash ss}% -% -% Although these internals commands shouldn't show up, sometimes they do. -\def\bf{\realbackslash bf }% -\def\gtr{\realbackslash gtr}% -\def\hat{\realbackslash hat}% -\def\less{\realbackslash less}% -%\def\rm{\realbackslash rm }% -\def\sf{\realbackslash sf}% -\def\sl{\realbackslash sl }% -\def\tclose##1{\realbackslash tclose {##1}}% -\def\tt{\realbackslash tt}% -% -\def\b##1{\realbackslash b {##1}}% -\def\i##1{\realbackslash i {##1}}% -\def\sc##1{\realbackslash sc {##1}}% -\def\t##1{\realbackslash t {##1}}% -\def\r##1{\realbackslash r {##1}}% -% -\def\TeX{\realbackslash TeX}% -\def\acronym##1{\realbackslash acronym {##1}}% -\def\cite##1{\realbackslash cite {##1}}% -\def\code##1{\realbackslash code {##1}}% -\def\command##1{\realbackslash command {##1}}% -\def\dfn##1{\realbackslash dfn {##1}}% -\def\dots{\realbackslash dots }% -\def\emph##1{\realbackslash emph {##1}}% -\def\env##1{\realbackslash env {##1}}% -\def\file##1{\realbackslash file {##1}}% -\def\kbd##1{\realbackslash kbd {##1}}% -\def\key##1{\realbackslash key {##1}}% -\def\math##1{\realbackslash math {##1}}% -\def\option##1{\realbackslash option {##1}}% -\def\samp##1{\realbackslash samp {##1}}% -\def\strong##1{\realbackslash strong {##1}}% -\def\uref##1{\realbackslash uref {##1}}% -\def\url##1{\realbackslash url {##1}}% -\def\var##1{\realbackslash var {##1}}% -\def\w{\realbackslash w }% -% -% These math commands don't seem likely to be used in index entries. -\def\copyright{\realbackslash copyright}% -\def\equiv{\realbackslash equiv}% -\def\error{\realbackslash error}% -\def\expansion{\realbackslash expansion}% -\def\point{\realbackslash point}% -\def\print{\realbackslash print}% -\def\result{\realbackslash result}% -% -% Handle some cases of @value -- where the variable name does not -% contain - or _, and the value does not contain any -% (non-fully-expandable) commands. -\let\value = \expandablevalue -% -\unsepspaces -% Turn off macro expansion -\turnoffmacros -} - -% If an index command is used in an @example environment, any spaces -% therein should become regular spaces in the raw index file, not the -% expansion of \tie (\leavevmode \penalty \@M \ ). -{\obeyspaces - \gdef\unsepspaces{\obeyspaces\let =\space}} - -% \indexnofonts no-ops all font-change commands. -% This is used when outputting the strings to sort the index by. -\def\indexdummyfont#1{#1} -\def\indexdummytex{TeX} -\def\indexdummydots{...} + \def\@{@}% change to @@ when we switch to @ as escape char in index files. + \def\ {\realbackslash\space }% + % Need these in case \tex is in effect and \{ is a \delimiter again. + % But can't use \lbracecmd and \rbracecmd because texindex assumes + % braces and backslashes are used only as delimiters. + \let\{ = \mylbrace + \let\} = \myrbrace + % + % \definedummyword defines \#1 as \realbackslash #1\space, thus + % effectively preventing its expansion. This is used only for control + % words, not control letters, because the \space would be incorrect + % for control characters, but is needed to separate the control word + % from whatever follows. + % + % For control letters, we have \definedummyletter, which omits the + % space. + % + % These can be used both for control words that take an argument and + % those that do not. If it is followed by {arg} in the input, then + % that will dutifully get written to the index (or wherever). + % + \def\definedummyword##1{% + \expandafter\def\csname ##1\endcsname{\realbackslash ##1\space}% + }% + \def\definedummyletter##1{% + \expandafter\def\csname ##1\endcsname{\realbackslash ##1}% + }% + \let\definedummyaccent\definedummyletter + % + % Do the redefinitions. + \commondummies +} + +% For the aux file, @ is the escape character. So we want to redefine +% everything using @ instead of \realbackslash. When everything uses +% @, this will be simpler. +% +\def\atdummies{% + \def\@{@@}% + \def\ {@ }% + \let\{ = \lbraceatcmd + \let\} = \rbraceatcmd + % + % (See comments in \indexdummies.) + \def\definedummyword##1{% + \expandafter\def\csname ##1\endcsname{@##1\space}% + }% + \def\definedummyletter##1{% + \expandafter\def\csname ##1\endcsname{@##1}% + }% + \let\definedummyaccent\definedummyletter + % + % Do the redefinitions. + \commondummies +} + +% Called from \indexdummies and \atdummies. \definedummyword and +% \definedummyletter must be defined first. +% +\def\commondummies{% + % + \normalturnoffactive + % + \commondummiesnofonts + % + \definedummyletter{_}% + % + % Non-English letters. + \definedummyword{AA}% + \definedummyword{AE}% + \definedummyword{L}% + \definedummyword{OE}% + \definedummyword{O}% + \definedummyword{aa}% + \definedummyword{ae}% + \definedummyword{l}% + \definedummyword{oe}% + \definedummyword{o}% + \definedummyword{ss}% + \definedummyword{exclamdown}% + \definedummyword{questiondown}% + \definedummyword{ordf}% + \definedummyword{ordm}% + % + % Although these internal commands shouldn't show up, sometimes they do. + \definedummyword{bf}% + \definedummyword{gtr}% + \definedummyword{hat}% + \definedummyword{less}% + \definedummyword{sf}% + \definedummyword{sl}% + \definedummyword{tclose}% + \definedummyword{tt}% + % + \definedummyword{LaTeX}% + \definedummyword{TeX}% + % + % Assorted special characters. + \definedummyword{bullet}% + \definedummyword{comma}% + \definedummyword{copyright}% + \definedummyword{registeredsymbol}% + \definedummyword{dots}% + \definedummyword{enddots}% + \definedummyword{equiv}% + \definedummyword{error}% + \definedummyword{expansion}% + \definedummyword{minus}% + \definedummyword{pounds}% + \definedummyword{point}% + \definedummyword{print}% + \definedummyword{result}% + % + % Handle some cases of @value -- where it does not contain any + % (non-fully-expandable) commands. + \makevalueexpandable + % + % Normal spaces, not active ones. + \unsepspaces + % + % No macro expansion. + \turnoffmacros +} +% \commondummiesnofonts: common to \commondummies and \indexnofonts. +% +% Better have this without active chars. +{ + \catcode`\~=\other + \gdef\commondummiesnofonts{% + % Control letters and accents. + \definedummyletter{!}% + \definedummyaccent{"}% + \definedummyaccent{'}% + \definedummyletter{*}% + \definedummyaccent{,}% + \definedummyletter{.}% + \definedummyletter{/}% + \definedummyletter{:}% + \definedummyaccent{=}% + \definedummyletter{?}% + \definedummyaccent{^}% + \definedummyaccent{`}% + \definedummyaccent{~}% + \definedummyword{u}% + \definedummyword{v}% + \definedummyword{H}% + \definedummyword{dotaccent}% + \definedummyword{ringaccent}% + \definedummyword{tieaccent}% + \definedummyword{ubaraccent}% + \definedummyword{udotaccent}% + \definedummyword{dotless}% + % + % Texinfo font commands. + \definedummyword{b}% + \definedummyword{i}% + \definedummyword{r}% + \definedummyword{sc}% + \definedummyword{t}% + % + % Commands that take arguments. + \definedummyword{acronym}% + \definedummyword{cite}% + \definedummyword{code}% + \definedummyword{command}% + \definedummyword{dfn}% + \definedummyword{emph}% + \definedummyword{env}% + \definedummyword{file}% + \definedummyword{kbd}% + \definedummyword{key}% + \definedummyword{math}% + \definedummyword{option}% + \definedummyword{samp}% + \definedummyword{strong}% + \definedummyword{tie}% + \definedummyword{uref}% + \definedummyword{url}% + \definedummyword{var}% + \definedummyword{verb}% + \definedummyword{w}% + } +} + +% \indexnofonts is used when outputting the strings to sort the index +% by, and when constructing control sequence names. It eliminates all +% control sequences and just writes whatever the best ASCII sort string +% would be for a given command (usually its argument). +% \def\indexnofonts{% -\def\@{@}% -% how to handle braces? -\def\_{\normalunderscore}% -% -\let\,=\indexdummyfont -\let\"=\indexdummyfont -\let\`=\indexdummyfont -\let\'=\indexdummyfont -\let\^=\indexdummyfont -\let\~=\indexdummyfont -\let\==\indexdummyfont -\let\b=\indexdummyfont -\let\c=\indexdummyfont -\let\d=\indexdummyfont -\let\u=\indexdummyfont -\let\v=\indexdummyfont -\let\H=\indexdummyfont -\let\dotless=\indexdummyfont -% Take care of the plain tex special European modified letters. -\def\AA{AA}% -\def\AE{AE}% -\def\L{L}% -\def\OE{OE}% -\def\O{O}% -\def\aa{aa}% -\def\ae{ae}% -\def\l{l}% -\def\oe{oe}% -\def\o{o}% -\def\ss{ss}% -% -% Don't no-op \tt, since it isn't a user-level command -% and is used in the definitions of the active chars like <, >, |, etc. -% Likewise with the other plain tex font commands. -%\let\tt=\indexdummyfont -% -\let\b=\indexdummyfont -\let\i=\indexdummyfont -\let\r=\indexdummyfont -\let\sc=\indexdummyfont -\let\t=\indexdummyfont -% -\let\TeX=\indexdummytex -\let\acronym=\indexdummyfont -\let\cite=\indexdummyfont -\let\code=\indexdummyfont -\let\command=\indexdummyfont -\let\dfn=\indexdummyfont -\let\dots=\indexdummydots -\let\emph=\indexdummyfont -\let\env=\indexdummyfont -\let\file=\indexdummyfont -\let\kbd=\indexdummyfont -\let\key=\indexdummyfont -\let\math=\indexdummyfont -\let\option=\indexdummyfont -\let\samp=\indexdummyfont -\let\strong=\indexdummyfont -\let\uref=\indexdummyfont -\let\url=\indexdummyfont -\let\var=\indexdummyfont -\let\w=\indexdummyfont -} - -% To define \realbackslash, we must make \ not be an escape. -% We must first make another character (@) an escape -% so we do not become unable to do a definition. - -{\catcode`\@=0 \catcode`\\=\other - @gdef@realbackslash{\}} + % Accent commands should become @asis. + \def\definedummyaccent##1{% + \expandafter\let\csname ##1\endcsname\asis + }% + % We can just ignore other control letters. + \def\definedummyletter##1{% + \expandafter\def\csname ##1\endcsname{}% + }% + % Hopefully, all control words can become @asis. + \let\definedummyword\definedummyaccent + % + \commondummiesnofonts + % + % Don't no-op \tt, since it isn't a user-level command + % and is used in the definitions of the active chars like <, >, |, etc. + % Likewise with the other plain tex font commands. + %\let\tt=\asis + % + \def\ { }% + \def\@{@}% + % how to handle braces? + \def\_{\normalunderscore}% + % + % Non-English letters. + \def\AA{AA}% + \def\AE{AE}% + \def\L{L}% + \def\OE{OE}% + \def\O{O}% + \def\aa{aa}% + \def\ae{ae}% + \def\l{l}% + \def\oe{oe}% + \def\o{o}% + \def\ss{ss}% + \def\exclamdown{!}% + \def\questiondown{?}% + \def\ordf{a}% + \def\ordm{o}% + % + \def\LaTeX{LaTeX}% + \def\TeX{TeX}% + % + % Assorted special characters. + % (The following {} will end up in the sort string, but that's ok.) + \def\bullet{bullet}% + \def\comma{,}% + \def\copyright{copyright}% + \def\registeredsymbol{R}% + \def\dots{...}% + \def\enddots{...}% + \def\equiv{==}% + \def\error{error}% + \def\expansion{==>}% + \def\minus{-}% + \def\pounds{pounds}% + \def\point{.}% + \def\print{-|}% + \def\result{=>}% + % + % Don't write macro names. + \emptyusermacros +} \let\indexbackslash=0 %overridden during \printindex. \let\SETmarginindex=\relax % put index entries in margin (undocumented)? -% For \ifx comparisons. -\def\emptymacro{\empty} - % Most index entries go through here, but \dosubind is the general case. -% -\def\doind#1#2{\dosubind{#1}{#2}\empty} +% #1 is the index name, #2 is the entry text. +\def\doind#1#2{\dosubind{#1}{#2}{}} % Workhorse for all \fooindexes. % #1 is name of index, #2 is stuff to put there, #3 is subentry -- -% \empty if called from \doind, as we usually are. The main exception -% is with defuns, which call us directly. +% empty if called from \doind, as we usually are (the main exception +% is with most defuns, which call us directly). % \def\dosubind#1#2#3{% + \iflinks + {% + % Store the main index entry text (including the third arg). + \toks0 = {#2}% + % If third arg is present, precede it with a space. + \def\thirdarg{#3}% + \ifx\thirdarg\empty \else + \toks0 = \expandafter{\the\toks0 \space #3}% + \fi + % + \edef\writeto{\csname#1indfile\endcsname}% + % + \ifvmode + \dosubindsanitize + \else + \dosubindwrite + \fi + }% + \fi +} + +% Write the entry in \toks0 to the index file: +% +\def\dosubindwrite{% % Put the index entry in the margin if desired. \ifx\SETmarginindex\relax\else - \insert\margin{\hbox{\vrule height8pt depth3pt width0pt #2}}% + \insert\margin{\hbox{\vrule height8pt depth3pt width0pt \the\toks0}}% \fi - {% - \count255=\lastpenalty - {% - \indexdummies % Must do this here, since \bf, etc expand at this stage - \escapechar=`\\ - {% - \let\folio = 0% We will expand all macros now EXCEPT \folio. - \def\rawbackslashxx{\indexbackslash}% \indexbackslash isn't defined now - % so it will be output as is; and it will print as backslash. - % - \def\thirdarg{#3}% - % - % If third arg is present, precede it with space in sort key. - \ifx\thirdarg\emptymacro - \let\subentry = \empty - \else - \def\subentry{ #3}% - \fi - % - % First process the index entry with all font commands turned - % off to get the string to sort by. - {\indexnofonts \xdef\indexsorttmp{#2\subentry}}% - % - % Now the real index entry with the fonts. - \toks0 = {#2}% - % - % If the third (subentry) arg is present, add it to the index - % line to write. - \ifx\thirdarg\emptymacro \else - \toks0 = \expandafter{\the\toks0{#3}}% - \fi - % - % Set up the complete index entry, with both the sort key and - % the original text, including any font commands. We write - % three arguments to \entry to the .?? file (four in the - % subentry case), texindex reduces to two when writing the .??s - % sorted result. - \edef\temp{% - \write\csname#1indfile\endcsname{% - \realbackslash entry{\indexsorttmp}{\folio}{\the\toks0}}% - }% - % - % If a skip is the last thing on the list now, preserve it - % by backing up by \lastskip, doing the \write, then inserting - % the skip again. Otherwise, the whatsit generated by the - % \write will make \lastskip zero. The result is that sequences - % like this: - % @end defun - % @tindex whatever - % @defun ... - % will have extra space inserted, because the \medbreak in the - % start of the @defun won't see the skip inserted by the @end of - % the previous defun. - % - % But don't do any of this if we're not in vertical mode. We - % don't want to do a \vskip and prematurely end a paragraph. - % - % Avoid page breaks due to these extra skips, too. - % - \iflinks - \ifvmode - \skip0 = \lastskip - \ifdim\lastskip = 0pt \else \nobreak\vskip-\lastskip \fi - \fi - % - \temp % do the write - % - % - \ifvmode \ifdim\skip0 = 0pt \else \nobreak\vskip\skip0 \fi \fi - \fi - }% - }% - \penalty\count255 + % + % Remember, we are within a group. + \indexdummies % Must do this here, since \bf, etc expand at this stage + \escapechar=`\\ + \def\backslashcurfont{\indexbackslash}% \indexbackslash isn't defined now + % so it will be output as is; and it will print as backslash. + % + % Process the index entry with all font commands turned off, to + % get the string to sort by. + {\indexnofonts + \edef\temp{\the\toks0}% need full expansion + \xdef\indexsorttmp{\temp}% }% + % + % Set up the complete index entry, with both the sort key and + % the original text, including any font commands. We write + % three arguments to \entry to the .?? file (four in the + % subentry case), texindex reduces to two when writing the .??s + % sorted result. + \edef\temp{% + \write\writeto{% + \string\entry{\indexsorttmp}{\noexpand\folio}{\the\toks0}}% + }% + \temp +} + +% Take care of unwanted page breaks: +% +% If a skip is the last thing on the list now, preserve it +% by backing up by \lastskip, doing the \write, then inserting +% the skip again. Otherwise, the whatsit generated by the +% \write will make \lastskip zero. The result is that sequences +% like this: +% @end defun +% @tindex whatever +% @defun ... +% will have extra space inserted, because the \medbreak in the +% start of the @defun won't see the skip inserted by the @end of +% the previous defun. +% +% But don't do any of this if we're not in vertical mode. We +% don't want to do a \vskip and prematurely end a paragraph. +% +% Avoid page breaks due to these extra skips, too. +% +% But wait, there is a catch there: +% We'll have to check whether \lastskip is zero skip. \ifdim is not +% sufficient for this purpose, as it ignores stretch and shrink parts +% of the skip. The only way seems to be to check the textual +% representation of the skip. +% +% The following is almost like \def\zeroskipmacro{0.0pt} except that +% the ``p'' and ``t'' characters have catcode \other, not 11 (letter). +% +\edef\zeroskipmacro{\expandafter\the\csname z@skip\endcsname} +% +% ..., ready, GO: +% +\def\dosubindsanitize{% + % \lastskip and \lastpenalty cannot both be nonzero simultaneously. + \skip0 = \lastskip + \edef\lastskipmacro{\the\lastskip}% + \count255 = \lastpenalty + % + % If \lastskip is nonzero, that means the last item was a + % skip. And since a skip is discardable, that means this + % -\skip0 glue we're inserting is preceded by a + % non-discardable item, therefore it is not a potential + % breakpoint, therefore no \nobreak needed. + \ifx\lastskipmacro\zeroskipmacro + \else + \vskip-\skip0 + \fi + % + \dosubindwrite + % + \ifx\lastskipmacro\zeroskipmacro + % If \lastskip was zero, perhaps the last item was a penalty, and + % perhaps it was >=10000, e.g., a \nobreak. In that case, we want + % to re-insert the same penalty (values >10000 are used for various + % signals); since we just inserted a non-discardable item, any + % following glue (such as a \parskip) would be a breakpoint. For example: + % + % @deffn deffn-whatever + % @vindex index-whatever + % Description. + % would allow a break between the index-whatever whatsit + % and the "Description." paragraph. + \ifnum\count255>9999 \penalty\count255 \fi + \else + % On the other hand, if we had a nonzero \lastskip, + % this make-up glue would be preceded by a non-discardable item + % (the whatsit from the \write), so we must insert a \nobreak. + \nobreak\vskip\skip0 + \fi } % The index entry written in the file actually looks like @@ -3099,13 +3479,12 @@ width0pt\relax} \fi % @printindex causes a particular index (the ??s file) to get printed. % It does not print any chapter heading (usually an @unnumbered). % -\def\printindex{\parsearg\doprintindex} -\def\doprintindex#1{\begingroup +\parseargdef\printindex{\begingroup \dobreak \chapheadingskip{10000}% % \smallfonts \rm \tolerance = 9500 - \indexbreaks + \everypar = {}% don't want the \kern\-parindent from indentation suppression. % % See if the index file exists and is nonempty. % Change catcode of @ here so that if the index file contains @@ -3132,7 +3511,7 @@ width0pt\relax} \fi % Index files are almost Texinfo source, but we use \ as the escape % character. It would be better to use @, but that's too big a change % to make right now. - \def\indexbackslash{\rawbackslashxx}% + \def\indexbackslash{\backslashcurfont}% \catcode`\\ = 0 \escapechar = `\\ \begindoublecolumns @@ -3154,7 +3533,10 @@ width0pt\relax} \fi \removelastskip % % We like breaks before the index initials, so insert a bonus. - \penalty -300 + \nobreak + \vskip 0pt plus 3\baselineskip + \penalty 0 + \vskip 0pt plus -3\baselineskip % % Typeset the initial. Making this add up to a whole number of % baselineskips increases the chance of the dots lining up from column @@ -3164,80 +3546,100 @@ width0pt\relax} \fi % No shrink because it confuses \balancecolumns. \vskip 1.67\baselineskip plus .5\baselineskip \leftline{\secbf #1}% - \vskip .33\baselineskip plus .1\baselineskip - % % Do our best not to break after the initial. \nobreak + \vskip .33\baselineskip plus .1\baselineskip }} -% This typesets a paragraph consisting of #1, dot leaders, and then #2 -% flush to the right margin. It is used for index and table of contents -% entries. The paragraph is indented by \leftskip. +% \entry typesets a paragraph consisting of the text (#1), dot leaders, and +% then page number (#2) flushed to the right margin. It is used for index +% and table of contents entries. The paragraph is indented by \leftskip. % -\def\entry#1#2{\begingroup - % - % Start a new paragraph if necessary, so our assignments below can't - % affect previous text. - \par - % - % Do not fill out the last line with white space. - \parfillskip = 0in - % - % No extra space above this paragraph. - \parskip = 0in - % - % Do not prefer a separate line ending with a hyphen to fewer lines. - \finalhyphendemerits = 0 - % - % \hangindent is only relevant when the entry text and page number - % don't both fit on one line. In that case, bob suggests starting the - % dots pretty far over on the line. Unfortunately, a large - % indentation looks wrong when the entry text itself is broken across - % lines. So we use a small indentation and put up with long leaders. - % - % \hangafter is reset to 1 (which is the value we want) at the start - % of each paragraph, so we need not do anything with that. - \hangindent = 2em - % - % When the entry text needs to be broken, just fill out the first line - % with blank space. - \rightskip = 0pt plus1fil - % - % A bit of stretch before each entry for the benefit of balancing columns. - \vskip 0pt plus1pt - % - % Start a ``paragraph'' for the index entry so the line breaking - % parameters we've set above will have an effect. - \noindent - % - % Insert the text of the index entry. TeX will do line-breaking on it. - #1% - % The following is kludged to not output a line of dots in the index if - % there are no page numbers. The next person who breaks this will be - % cursed by a Unix daemon. - \def\tempa{{\rm }}% - \def\tempb{#2}% - \edef\tempc{\tempa}% - \edef\tempd{\tempb}% - \ifx\tempc\tempd\ \else% +% A straightforward implementation would start like this: +% \def\entry#1#2{... +% But this frozes the catcodes in the argument, and can cause problems to +% @code, which sets - active. This problem was fixed by a kludge--- +% ``-'' was active throughout whole index, but this isn't really right. +% +% The right solution is to prevent \entry from swallowing the whole text. +% --kasal, 21nov03 +\def\entry{% + \begingroup + % + % Start a new paragraph if necessary, so our assignments below can't + % affect previous text. + \par + % + % Do not fill out the last line with white space. + \parfillskip = 0in + % + % No extra space above this paragraph. + \parskip = 0in + % + % Do not prefer a separate line ending with a hyphen to fewer lines. + \finalhyphendemerits = 0 % - % If we must, put the page number on a line of its own, and fill out - % this line with blank space. (The \hfil is overwhelmed with the - % fill leaders glue in \indexdotfill if the page number does fit.) - \hfil\penalty50 - \null\nobreak\indexdotfill % Have leaders before the page number. + % \hangindent is only relevant when the entry text and page number + % don't both fit on one line. In that case, bob suggests starting the + % dots pretty far over on the line. Unfortunately, a large + % indentation looks wrong when the entry text itself is broken across + % lines. So we use a small indentation and put up with long leaders. % - % The `\ ' here is removed by the implicit \unskip that TeX does as - % part of (the primitive) \par. Without it, a spurious underfull - % \hbox ensues. - \ifpdf - \pdfgettoks#2.\ \the\toksA % The page number ends the paragraph. + % \hangafter is reset to 1 (which is the value we want) at the start + % of each paragraph, so we need not do anything with that. + \hangindent = 2em + % + % When the entry text needs to be broken, just fill out the first line + % with blank space. + \rightskip = 0pt plus1fil + % + % A bit of stretch before each entry for the benefit of balancing + % columns. + \vskip 0pt plus1pt + % + % Swallow the left brace of the text (first parameter): + \afterassignment\doentry + \let\temp = +} +\def\doentry{% + \bgroup % Instead of the swallowed brace. + \noindent + \aftergroup\finishentry + % And now comes the text of the entry. +} +\def\finishentry#1{% + % #1 is the page number. + % + % The following is kludged to not output a line of dots in the index if + % there are no page numbers. The next person who breaks this will be + % cursed by a Unix daemon. + \def\tempa{{\rm }}% + \def\tempb{#1}% + \edef\tempc{\tempa}% + \edef\tempd{\tempb}% + \ifx\tempc\tempd + \ % \else - \ #2% The page number ends the paragraph. + % + % If we must, put the page number on a line of its own, and fill out + % this line with blank space. (The \hfil is overwhelmed with the + % fill leaders glue in \indexdotfill if the page number does fit.) + \hfil\penalty50 + \null\nobreak\indexdotfill % Have leaders before the page number. + % + % The `\ ' here is removed by the implicit \unskip that TeX does as + % part of (the primitive) \par. Without it, a spurious underfull + % \hbox ensues. + \ifpdf + \pdfgettoks#1.% + \ \the\toksA + \else + \ #1% + \fi \fi - \fi% - \par -\endgroup} + \par + \endgroup +} % Like \dotfill except takes at least 1 em. \def\indexdotfill{\cleaders @@ -3348,7 +3750,7 @@ width0pt\relax} \fi \wd0=\hsize \wd2=\hsize \hbox to\pagewidth{\box0\hfil\box2}% } -% +% % All done with double columns. \def\enddoublecolumns{% \output = {% @@ -3406,6 +3808,12 @@ width0pt\relax} \fi \message{sectioning,} % Chapters, sections, etc. +% \unnumberedno is an oxymoron, of course. But we count the unnumbered +% sections so that we can refer to them unambiguously in the pdf +% outlines by their "section number". We avoid collisions with chapter +% numbers by starting them at 10000. (If a document ever has 10000 +% chapters, we're in trouble anyway, I'm sure.) +\newcount\unnumberedno \unnumberedno = 10000 \newcount\chapno \newcount\secno \secno=0 \newcount\subsecno \subsecno=0 @@ -3413,9 +3821,12 @@ width0pt\relax} \fi % This counter is funny since it counts through charcodes of letters A, B, ... \newcount\appendixno \appendixno = `\@ +% % \def\appendixletter{\char\the\appendixno} -% We do the following for the sake of pdftex, which needs the actual +% We do the following ugly conditional instead of the above simple +% construct for the sake of pdftex, which needs the actual % letter in the expansion, not just typeset. +% \def\appendixletter{% \ifnum\appendixno=`A A% \else\ifnum\appendixno=`B B% @@ -3453,11 +3864,12 @@ width0pt\relax} \fi % Each @chapter defines this as the name of the chapter. % page headings and footings can use it. @section does likewise. +% However, they are not reliable, because we don't use marks. \def\thischapter{} \def\thissection{} \newcount\absseclevel % used to calculate proper heading level -\newcount\secbase\secbase=0 % @raise/lowersections modify this count +\newcount\secbase\secbase=0 % @raisesections/@lowersections modify this count % @raisesections: treat @section as chapter, @subsection as section, etc. \def\raisesections{\global\advance\secbase by -1} @@ -3467,288 +3879,246 @@ width0pt\relax} \fi \def\lowersections{\global\advance\secbase by 1} \let\down=\lowersections % original BFox name -% Choose a numbered-heading macro -% #1 is heading level if unmodified by @raisesections or @lowersections -% #2 is text for heading -\def\numhead#1#2{\absseclevel=\secbase\advance\absseclevel by #1 -\ifcase\absseclevel - \chapterzzz{#2} -\or - \seczzz{#2} -\or - \numberedsubseczzz{#2} -\or - \numberedsubsubseczzz{#2} -\else - \ifnum \absseclevel<0 - \chapterzzz{#2} +% we only have subsub. +\chardef\maxseclevel = 3 +% +% A numbered section within an unnumbered changes to unnumbered too. +% To achive this, remember the "biggest" unnum. sec. we are currently in: +\chardef\unmlevel = \maxseclevel +% +% Trace whether the current chapter is an appendix or not: +% \chapheadtype is "N" or "A", unnumbered chapters are ignored. +\def\chapheadtype{N} + +% Choose a heading macro +% #1 is heading type +% #2 is heading level +% #3 is text for heading +\def\genhead#1#2#3{% + % Compute the abs. sec. level: + \absseclevel=#2 + \advance\absseclevel by \secbase + % Make sure \absseclevel doesn't fall outside the range: + \ifnum \absseclevel < 0 + \absseclevel = 0 \else - \numberedsubsubseczzz{#2} + \ifnum \absseclevel > 3 + \absseclevel = 3 + \fi \fi -\fi -} - -% like \numhead, but chooses appendix heading levels -\def\apphead#1#2{\absseclevel=\secbase\advance\absseclevel by #1 -\ifcase\absseclevel - \appendixzzz{#2} -\or - \appendixsectionzzz{#2} -\or - \appendixsubseczzz{#2} -\or - \appendixsubsubseczzz{#2} -\else - \ifnum \absseclevel<0 - \appendixzzz{#2} + % The heading type: + \def\headtype{#1}% + \if \headtype U% + \ifnum \absseclevel < \unmlevel + \chardef\unmlevel = \absseclevel + \fi \else - \appendixsubsubseczzz{#2} + % Check for appendix sections: + \ifnum \absseclevel = 0 + \edef\chapheadtype{\headtype}% + \else + \if \headtype A\if \chapheadtype N% + \errmessage{@appendix... within a non-appendix chapter}% + \fi\fi + \fi + % Check for numbered within unnumbered: + \ifnum \absseclevel > \unmlevel + \def\headtype{U}% + \else + \chardef\unmlevel = 3 + \fi \fi -\fi -} - -% like \numhead, but chooses numberless heading levels -\def\unnmhead#1#2{\absseclevel=\secbase\advance\absseclevel by #1 -\ifcase\absseclevel - \unnumberedzzz{#2} -\or - \unnumberedseczzz{#2} -\or - \unnumberedsubseczzz{#2} -\or - \unnumberedsubsubseczzz{#2} -\else - \ifnum \absseclevel<0 - \unnumberedzzz{#2} + % Now print the heading: + \if \headtype U% + \ifcase\absseclevel + \unnumberedzzz{#3}% + \or \unnumberedseczzz{#3}% + \or \unnumberedsubseczzz{#3}% + \or \unnumberedsubsubseczzz{#3}% + \fi \else - \unnumberedsubsubseczzz{#2} + \if \headtype A% + \ifcase\absseclevel + \appendixzzz{#3}% + \or \appendixsectionzzz{#3}% + \or \appendixsubseczzz{#3}% + \or \appendixsubsubseczzz{#3}% + \fi + \else + \ifcase\absseclevel + \chapterzzz{#3}% + \or \seczzz{#3}% + \or \numberedsubseczzz{#3}% + \or \numberedsubsubseczzz{#3}% + \fi + \fi \fi -\fi + \suppressfirstparagraphindent } -% @chapter, @appendix, @unnumbered. -\def\thischaptername{No Chapter Title} -\outer\def\chapter{\parsearg\chapteryyy} -\def\chapteryyy #1{\numhead0{#1}} % normally numhead0 calls chapterzzz -\def\chapterzzz #1{% -\secno=0 \subsecno=0 \subsubsecno=0 -\global\advance \chapno by 1 \message{\putwordChapter\space \the\chapno}% -\chapmacro {#1}{\the\chapno}% -\gdef\thissection{#1}% -\gdef\thischaptername{#1}% -% We don't substitute the actual chapter name into \thischapter -% because we don't want its macros evaluated now. -\xdef\thischapter{\putwordChapter{} \the\chapno: \noexpand\thischaptername}% -\toks0 = {#1}% -\edef\temp{\noexpand\writetocentry{\realbackslash chapentry{\the\toks0}% - {\the\chapno}}}% -\temp -\donoderef -\global\let\section = \numberedsec -\global\let\subsection = \numberedsubsec -\global\let\subsubsection = \numberedsubsubsec -} - -\outer\def\appendix{\parsearg\appendixyyy} -\def\appendixyyy #1{\apphead0{#1}} % normally apphead0 calls appendixzzz -\def\appendixzzz #1{% -\secno=0 \subsecno=0 \subsubsecno=0 -\global\advance \appendixno by 1 -\message{\putwordAppendix\space \appendixletter}% -\chapmacro {#1}{\putwordAppendix{} \appendixletter}% -\gdef\thissection{#1}% -\gdef\thischaptername{#1}% -\xdef\thischapter{\putwordAppendix{} \appendixletter: \noexpand\thischaptername}% -\toks0 = {#1}% -\edef\temp{\noexpand\writetocentry{\realbackslash appendixentry{\the\toks0}% - {\appendixletter}}}% -\temp -\appendixnoderef -\global\let\section = \appendixsec -\global\let\subsection = \appendixsubsec -\global\let\subsubsection = \appendixsubsubsec +% an interface: +\def\numhead{\genhead N} +\def\apphead{\genhead A} +\def\unnmhead{\genhead U} + +% @chapter, @appendix, @unnumbered. Increment top-level counter, reset +% all lower-level sectioning counters to zero. +% +% Also set \chaplevelprefix, which we prepend to @float sequence numbers +% (e.g., figures), q.v. By default (before any chapter), that is empty. +\let\chaplevelprefix = \empty +% +\outer\parseargdef\chapter{\numhead0{#1}} % normally numhead0 calls chapterzzz +\def\chapterzzz#1{% + % section resetting is \global in case the chapter is in a group, such + % as an @include file. + \global\secno=0 \global\subsecno=0 \global\subsubsecno=0 + \global\advance\chapno by 1 + % + % Used for \float. + \gdef\chaplevelprefix{\the\chapno.}% + \resetallfloatnos + % + \message{\putwordChapter\space \the\chapno}% + % + % Write the actual heading. + \chapmacro{#1}{Ynumbered}{\the\chapno}% + % + % So @section and the like are numbered underneath this chapter. + \global\let\section = \numberedsec + \global\let\subsection = \numberedsubsec + \global\let\subsubsection = \numberedsubsubsec +} + +\outer\parseargdef\appendix{\apphead0{#1}} % normally apphead0 calls appendixzzz +\def\appendixzzz#1{% + \global\secno=0 \global\subsecno=0 \global\subsubsecno=0 + \global\advance\appendixno by 1 + \gdef\chaplevelprefix{\appendixletter.}% + \resetallfloatnos + % + \def\appendixnum{\putwordAppendix\space \appendixletter}% + \message{\appendixnum}% + % + \chapmacro{#1}{Yappendix}{\appendixletter}% + % + \global\let\section = \appendixsec + \global\let\subsection = \appendixsubsec + \global\let\subsubsection = \appendixsubsubsec +} + +\outer\parseargdef\unnumbered{\unnmhead0{#1}} % normally unnmhead0 calls unnumberedzzz +\def\unnumberedzzz#1{% + \global\secno=0 \global\subsecno=0 \global\subsubsecno=0 + \global\advance\unnumberedno by 1 + % + % Since an unnumbered has no number, no prefix for figures. + \global\let\chaplevelprefix = \empty + \resetallfloatnos + % + % This used to be simply \message{#1}, but TeX fully expands the + % argument to \message. Therefore, if #1 contained @-commands, TeX + % expanded them. For example, in `@unnumbered The @cite{Book}', TeX + % expanded @cite (which turns out to cause errors because \cite is meant + % to be executed, not expanded). + % + % Anyway, we don't want the fully-expanded definition of @cite to appear + % as a result of the \message, we just want `@cite' itself. We use + % \the<toks register> to achieve this: TeX expands \the<toks> only once, + % simply yielding the contents of <toks register>. (We also do this for + % the toc entries.) + \toks0 = {#1}% + \message{(\the\toks0)}% + % + \chapmacro{#1}{Ynothing}{\the\unnumberedno}% + % + \global\let\section = \unnumberedsec + \global\let\subsection = \unnumberedsubsec + \global\let\subsubsection = \unnumberedsubsubsec } % @centerchap is like @unnumbered, but the heading is centered. -\outer\def\centerchap{\parsearg\centerchapyyy} -\def\centerchapyyy #1{{\let\unnumbchapmacro=\centerchapmacro \unnumberedyyy{#1}}} +\outer\parseargdef\centerchap{% + % Well, we could do the following in a group, but that would break + % an assumption that \chapmacro is called at the outermost level. + % Thus we are safer this way: --kasal, 24feb04 + \let\centerparametersmaybe = \centerparameters + \unnmhead0{#1}% + \let\centerparametersmaybe = \relax +} % @top is like @unnumbered. -\outer\def\top{\parsearg\unnumberedyyy} - -\outer\def\unnumbered{\parsearg\unnumberedyyy} -\def\unnumberedyyy #1{\unnmhead0{#1}} % normally unnmhead0 calls unnumberedzzz -\def\unnumberedzzz #1{% -\secno=0 \subsecno=0 \subsubsecno=0 -% -% This used to be simply \message{#1}, but TeX fully expands the -% argument to \message. Therefore, if #1 contained @-commands, TeX -% expanded them. For example, in `@unnumbered The @cite{Book}', TeX -% expanded @cite (which turns out to cause errors because \cite is meant -% to be executed, not expanded). -% -% Anyway, we don't want the fully-expanded definition of @cite to appear -% as a result of the \message, we just want `@cite' itself. We use -% \the<toks register> to achieve this: TeX expands \the<toks> only once, -% simply yielding the contents of <toks register>. (We also do this for -% the toc entries.) -\toks0 = {#1}\message{(\the\toks0)}% -% -\unnumbchapmacro {#1}% -\gdef\thischapter{#1}\gdef\thissection{#1}% -\toks0 = {#1}% -\edef\temp{\noexpand\writetocentry{\realbackslash unnumbchapentry{\the\toks0}}}% -\temp -\unnumbnoderef -\global\let\section = \unnumberedsec -\global\let\subsection = \unnumberedsubsec -\global\let\subsubsection = \unnumberedsubsubsec -} +\let\top\unnumbered % Sections. -\outer\def\numberedsec{\parsearg\secyyy} -\def\secyyy #1{\numhead1{#1}} % normally calls seczzz -\def\seczzz #1{% -\subsecno=0 \subsubsecno=0 \global\advance \secno by 1 % -\gdef\thissection{#1}\secheading {#1}{\the\chapno}{\the\secno}% -\toks0 = {#1}% -\edef\temp{\noexpand\writetocentry{\realbackslash secentry{\the\toks0}% - {\the\chapno}{\the\secno}}}% -\temp -\donoderef -\nobreak -} - -\outer\def\appendixsection{\parsearg\appendixsecyyy} -\outer\def\appendixsec{\parsearg\appendixsecyyy} -\def\appendixsecyyy #1{\apphead1{#1}} % normally calls appendixsectionzzz -\def\appendixsectionzzz #1{% -\subsecno=0 \subsubsecno=0 \global\advance \secno by 1 % -\gdef\thissection{#1}\secheading {#1}{\appendixletter}{\the\secno}% -\toks0 = {#1}% -\edef\temp{\noexpand\writetocentry{\realbackslash secentry{\the\toks0}% - {\appendixletter}{\the\secno}}}% -\temp -\appendixnoderef -\nobreak -} - -\outer\def\unnumberedsec{\parsearg\unnumberedsecyyy} -\def\unnumberedsecyyy #1{\unnmhead1{#1}} % normally calls unnumberedseczzz -\def\unnumberedseczzz #1{% -\plainsecheading {#1}\gdef\thissection{#1}% -\toks0 = {#1}% -\edef\temp{\noexpand\writetocentry{\realbackslash unnumbsecentry% - {\the\toks0}{\the\chapno}}}% -\temp -\unnumbnoderef -\nobreak +\outer\parseargdef\numberedsec{\numhead1{#1}} % normally calls seczzz +\def\seczzz#1{% + \global\subsecno=0 \global\subsubsecno=0 \global\advance\secno by 1 + \sectionheading{#1}{sec}{Ynumbered}{\the\chapno.\the\secno}% +} + +\outer\parseargdef\appendixsection{\apphead1{#1}} % normally calls appendixsectionzzz +\def\appendixsectionzzz#1{% + \global\subsecno=0 \global\subsubsecno=0 \global\advance\secno by 1 + \sectionheading{#1}{sec}{Yappendix}{\appendixletter.\the\secno}% +} +\let\appendixsec\appendixsection + +\outer\parseargdef\unnumberedsec{\unnmhead1{#1}} % normally calls unnumberedseczzz +\def\unnumberedseczzz#1{% + \global\subsecno=0 \global\subsubsecno=0 \global\advance\secno by 1 + \sectionheading{#1}{sec}{Ynothing}{\the\unnumberedno.\the\secno}% } % Subsections. -\outer\def\numberedsubsec{\parsearg\numberedsubsecyyy} -\def\numberedsubsecyyy #1{\numhead2{#1}} % normally calls numberedsubseczzz -\def\numberedsubseczzz #1{% -\gdef\thissection{#1}\subsubsecno=0 \global\advance \subsecno by 1 % -\subsecheading {#1}{\the\chapno}{\the\secno}{\the\subsecno}% -\toks0 = {#1}% -\edef\temp{\noexpand\writetocentry{\realbackslash subsecentry{\the\toks0}% - {\the\chapno}{\the\secno}{\the\subsecno}}}% -\temp -\donoderef -\nobreak -} - -\outer\def\appendixsubsec{\parsearg\appendixsubsecyyy} -\def\appendixsubsecyyy #1{\apphead2{#1}} % normally calls appendixsubseczzz -\def\appendixsubseczzz #1{% -\gdef\thissection{#1}\subsubsecno=0 \global\advance \subsecno by 1 % -\subsecheading {#1}{\appendixletter}{\the\secno}{\the\subsecno}% -\toks0 = {#1}% -\edef\temp{\noexpand\writetocentry{\realbackslash subsecentry{\the\toks0}% - {\appendixletter}{\the\secno}{\the\subsecno}}}% -\temp -\appendixnoderef -\nobreak -} - -\outer\def\unnumberedsubsec{\parsearg\unnumberedsubsecyyy} -\def\unnumberedsubsecyyy #1{\unnmhead2{#1}} %normally calls unnumberedsubseczzz -\def\unnumberedsubseczzz #1{% -\plainsubsecheading {#1}\gdef\thissection{#1}% -\toks0 = {#1}% -\edef\temp{\noexpand\writetocentry{\realbackslash unnumbsubsecentry% - {\the\toks0}{\the\chapno}{\the\secno}}}% -\temp -\unnumbnoderef -\nobreak +\outer\parseargdef\numberedsubsec{\numhead2{#1}} % normally calls numberedsubseczzz +\def\numberedsubseczzz#1{% + \global\subsubsecno=0 \global\advance\subsecno by 1 + \sectionheading{#1}{subsec}{Ynumbered}{\the\chapno.\the\secno.\the\subsecno}% +} + +\outer\parseargdef\appendixsubsec{\apphead2{#1}} % normally calls appendixsubseczzz +\def\appendixsubseczzz#1{% + \global\subsubsecno=0 \global\advance\subsecno by 1 + \sectionheading{#1}{subsec}{Yappendix}% + {\appendixletter.\the\secno.\the\subsecno}% +} + +\outer\parseargdef\unnumberedsubsec{\unnmhead2{#1}} %normally calls unnumberedsubseczzz +\def\unnumberedsubseczzz#1{% + \global\subsubsecno=0 \global\advance\subsecno by 1 + \sectionheading{#1}{subsec}{Ynothing}% + {\the\unnumberedno.\the\secno.\the\subsecno}% } % Subsubsections. -\outer\def\numberedsubsubsec{\parsearg\numberedsubsubsecyyy} -\def\numberedsubsubsecyyy #1{\numhead3{#1}} % normally numberedsubsubseczzz -\def\numberedsubsubseczzz #1{% -\gdef\thissection{#1}\global\advance \subsubsecno by 1 % -\subsubsecheading {#1} - {\the\chapno}{\the\secno}{\the\subsecno}{\the\subsubsecno}% -\toks0 = {#1}% -\edef\temp{\noexpand\writetocentry{\realbackslash subsubsecentry{\the\toks0}% - {\the\chapno}{\the\secno}{\the\subsecno}{\the\subsubsecno}}}% -\temp -\donoderef -\nobreak -} - -\outer\def\appendixsubsubsec{\parsearg\appendixsubsubsecyyy} -\def\appendixsubsubsecyyy #1{\apphead3{#1}} % normally appendixsubsubseczzz -\def\appendixsubsubseczzz #1{% -\gdef\thissection{#1}\global\advance \subsubsecno by 1 % -\subsubsecheading {#1} - {\appendixletter}{\the\secno}{\the\subsecno}{\the\subsubsecno}% -\toks0 = {#1}% -\edef\temp{\noexpand\writetocentry{\realbackslash subsubsecentry{\the\toks0}% - {\appendixletter}{\the\secno}{\the\subsecno}{\the\subsubsecno}}}% -\temp -\appendixnoderef -\nobreak -} - -\outer\def\unnumberedsubsubsec{\parsearg\unnumberedsubsubsecyyy} -\def\unnumberedsubsubsecyyy #1{\unnmhead3{#1}} %normally unnumberedsubsubseczzz -\def\unnumberedsubsubseczzz #1{% -\plainsubsubsecheading {#1}\gdef\thissection{#1}% -\toks0 = {#1}% -\edef\temp{\noexpand\writetocentry{\realbackslash unnumbsubsubsecentry% - {\the\toks0}{\the\chapno}{\the\secno}{\the\subsecno}}}% -\temp -\unnumbnoderef -\nobreak -} - -% These are variants which are not "outer", so they can appear in @ifinfo. -% Actually, they should now be obsolete; ordinary section commands should work. -\def\infotop{\parsearg\unnumberedzzz} -\def\infounnumbered{\parsearg\unnumberedzzz} -\def\infounnumberedsec{\parsearg\unnumberedseczzz} -\def\infounnumberedsubsec{\parsearg\unnumberedsubseczzz} -\def\infounnumberedsubsubsec{\parsearg\unnumberedsubsubseczzz} - -\def\infoappendix{\parsearg\appendixzzz} -\def\infoappendixsec{\parsearg\appendixseczzz} -\def\infoappendixsubsec{\parsearg\appendixsubseczzz} -\def\infoappendixsubsubsec{\parsearg\appendixsubsubseczzz} - -\def\infochapter{\parsearg\chapterzzz} -\def\infosection{\parsearg\sectionzzz} -\def\infosubsection{\parsearg\subsectionzzz} -\def\infosubsubsection{\parsearg\subsubsectionzzz} +\outer\parseargdef\numberedsubsubsec{\numhead3{#1}} % normally numberedsubsubseczzz +\def\numberedsubsubseczzz#1{% + \global\advance\subsubsecno by 1 + \sectionheading{#1}{subsubsec}{Ynumbered}% + {\the\chapno.\the\secno.\the\subsecno.\the\subsubsecno}% +} + +\outer\parseargdef\appendixsubsubsec{\apphead3{#1}} % normally appendixsubsubseczzz +\def\appendixsubsubseczzz#1{% + \global\advance\subsubsecno by 1 + \sectionheading{#1}{subsubsec}{Yappendix}% + {\appendixletter.\the\secno.\the\subsecno.\the\subsubsecno}% +} + +\outer\parseargdef\unnumberedsubsubsec{\unnmhead3{#1}} %normally unnumberedsubsubseczzz +\def\unnumberedsubsubseczzz#1{% + \global\advance\subsubsecno by 1 + \sectionheading{#1}{subsubsec}{Ynothing}% + {\the\unnumberedno.\the\secno.\the\subsecno.\the\subsubsecno}% +} % These macros control what the section commands do, according % to what kind of chapter we are in (ordinary, appendix, or unnumbered). % Define them by default for a numbered chapter. -\global\let\section = \numberedsec -\global\let\subsection = \numberedsubsec -\global\let\subsubsection = \numberedsubsubsec +\let\section = \numberedsec +\let\subsection = \numberedsubsec +\let\subsubsection = \numberedsubsubsec % Define @majorheading, @heading and @subheading @@ -3761,23 +4131,27 @@ width0pt\relax} \fi % if justification is not attempted. Hence \raggedright. -\def\majorheading{\parsearg\majorheadingzzz} -\def\majorheadingzzz #1{% -{\advance\chapheadingskip by 10pt \chapbreak }% -{\chapfonts \vbox{\hyphenpenalty=10000\tolerance=5000 - \parindent=0pt\raggedright - \rm #1\hfill}}\bigskip \par\penalty 200} +\def\majorheading{% + {\advance\chapheadingskip by 10pt \chapbreak }% + \parsearg\chapheadingzzz +} -\def\chapheading{\parsearg\chapheadingzzz} -\def\chapheadingzzz #1{\chapbreak % -{\chapfonts \vbox{\hyphenpenalty=10000\tolerance=5000 - \parindent=0pt\raggedright - \rm #1\hfill}}\bigskip \par\penalty 200} +\def\chapheading{\chapbreak \parsearg\chapheadingzzz} +\def\chapheadingzzz#1{% + {\chapfonts \vbox{\hyphenpenalty=10000\tolerance=5000 + \parindent=0pt\raggedright + \rm #1\hfill}}% + \bigskip \par\penalty 200\relax + \suppressfirstparagraphindent +} % @heading, @subheading, @subsubheading. -\def\heading{\parsearg\plainsecheading} -\def\subheading{\parsearg\plainsubsecheading} -\def\subsubheading{\parsearg\plainsubsubsecheading} +\parseargdef\heading{\sectionheading{#1}{sec}{Yomitfromtoc}{} + \suppressfirstparagraphindent} +\parseargdef\subheading{\sectionheading{#1}{subsec}{Yomitfromtoc}{} + \suppressfirstparagraphindent} +\parseargdef\subsubheading{\sectionheading{#1}{subsubsec}{Yomitfromtoc}{} + \suppressfirstparagraphindent} % These macros generate a chapter, section, etc. heading only % (including whitespace, linebreaking, etc. around it), @@ -3786,8 +4160,6 @@ width0pt\relax} \fi %%% Args are the skip and penalty (usually negative) \def\dobreak#1#2{\par\ifdim\lastskip<#1\removelastskip\penalty#2\vskip#1\fi} -\def\setchapterstyle #1 {\csname CHAPF#1\endcsname} - %%% Define plain chapter starts, and page on/off switching for it % Parameter controlling skip before chapter headings (if needed) @@ -3810,7 +4182,7 @@ width0pt\relax} \fi \global\let\pagealignmacro=\chappager \global\def\HEADINGSon{\HEADINGSsingle}} -\def\CHAPPAGodd{ +\def\CHAPPAGodd{% \global\let\contentsalignmacro = \chapoddpage \global\let\pchapsepmacro=\chapoddpage \global\let\pagealignmacro=\chapoddpage @@ -3818,107 +4190,193 @@ width0pt\relax} \fi \CHAPPAGon -\def\CHAPFplain{ -\global\let\chapmacro=\chfplain -\global\let\unnumbchapmacro=\unnchfplain -\global\let\centerchapmacro=\centerchfplain} - -% Plain chapter opening. -% #1 is the text, #2 the chapter number or empty if unnumbered. -\def\chfplain#1#2{% +% Chapter opening. +% +% #1 is the text, #2 is the section type (Ynumbered, Ynothing, +% Yappendix, Yomitfromtoc), #3 the chapter number. +% +% To test against our argument. +\def\Ynothingkeyword{Ynothing} +\def\Yomitfromtockeyword{Yomitfromtoc} +\def\Yappendixkeyword{Yappendix} +% +\def\chapmacro#1#2#3{% \pchapsepmacro {% \chapfonts \rm - \def\chapnum{#2}% - \setbox0 = \hbox{#2\ifx\chapnum\empty\else\enspace\fi}% + % + % Have to define \thissection before calling \donoderef, because the + % xref code eventually uses it. On the other hand, it has to be called + % after \pchapsepmacro, or the headline will change too soon. + \gdef\thissection{#1}% + \gdef\thischaptername{#1}% + % + % Only insert the separating space if we have a chapter/appendix + % number, and don't print the unnumbered ``number''. + \def\temptype{#2}% + \ifx\temptype\Ynothingkeyword + \setbox0 = \hbox{}% + \def\toctype{unnchap}% + \def\thischapter{#1}% + \else\ifx\temptype\Yomitfromtockeyword + \setbox0 = \hbox{}% contents like unnumbered, but no toc entry + \def\toctype{omit}% + \xdef\thischapter{}% + \else\ifx\temptype\Yappendixkeyword + \setbox0 = \hbox{\putwordAppendix{} #3\enspace}% + \def\toctype{app}% + % We don't substitute the actual chapter name into \thischapter + % because we don't want its macros evaluated now. And we don't + % use \thissection because that changes with each section. + % + \xdef\thischapter{\putwordAppendix{} \appendixletter: + \noexpand\thischaptername}% + \else + \setbox0 = \hbox{#3\enspace}% + \def\toctype{numchap}% + \xdef\thischapter{\putwordChapter{} \the\chapno: + \noexpand\thischaptername}% + \fi\fi\fi + % + % Write the toc entry for this chapter. Must come before the + % \donoderef, because we include the current node name in the toc + % entry, and \donoderef resets it to empty. + \writetocentry{\toctype}{#1}{#3}% + % + % For pdftex, we have to write out the node definition (aka, make + % the pdfdest) after any page break, but before the actual text has + % been typeset. If the destination for the pdf outline is after the + % text, then jumping from the outline may wind up with the text not + % being visible, for instance under high magnification. + \donoderef{#2}% + % + % Typeset the actual heading. \vbox{\hyphenpenalty=10000 \tolerance=5000 \parindent=0pt \raggedright - \hangindent = \wd0 \centerparametersmaybe + \hangindent=\wd0 \centerparametersmaybe \unhbox0 #1\par}% }% \nobreak\bigskip % no page break after a chapter title \nobreak } -% Plain opening for unnumbered. -\def\unnchfplain#1{\chfplain{#1}{}} - % @centerchap -- centered and unnumbered. \let\centerparametersmaybe = \relax -\def\centerchfplain#1{{% - \def\centerparametersmaybe{% - \advance\rightskip by 3\rightskip - \leftskip = \rightskip - \parfillskip = 0pt - }% - \chfplain{#1}{}% -}} +\def\centerparameters{% + \advance\rightskip by 3\rightskip + \leftskip = \rightskip + \parfillskip = 0pt +} -\CHAPFplain % The default +% I don't think this chapter style is supported any more, so I'm not +% updating it with the new noderef stuff. We'll see. --karl, 11aug03. +% +\def\setchapterstyle #1 {\csname CHAPF#1\endcsname} +% \def\unnchfopen #1{% \chapoddpage {\chapfonts \vbox{\hyphenpenalty=10000\tolerance=5000 \parindent=0pt\raggedright \rm #1\hfill}}\bigskip \par\nobreak } - \def\chfopen #1#2{\chapoddpage {\chapfonts \vbox to 3in{\vfil \hbox to\hsize{\hfil #2} \hbox to\hsize{\hfil #1} \vfil}}% \par\penalty 5000 % } - \def\centerchfopen #1{% \chapoddpage {\chapfonts \vbox{\hyphenpenalty=10000\tolerance=5000 \parindent=0pt \hfill {\rm #1}\hfill}}\bigskip \par\nobreak } +\def\CHAPFopen{% + \global\let\chapmacro=\chfopen + \global\let\centerchapmacro=\centerchfopen} -\def\CHAPFopen{ -\global\let\chapmacro=\chfopen -\global\let\unnumbchapmacro=\unnchfopen -\global\let\centerchapmacro=\centerchfopen} - -% Section titles. +% Section titles. These macros combine the section number parts and +% call the generic \sectionheading to do the printing. +% \newskip\secheadingskip -\def\secheadingbreak{\dobreak \secheadingskip {-1000}} -\def\secheading#1#2#3{\sectionheading{sec}{#2.#3}{#1}} -\def\plainsecheading#1{\sectionheading{sec}{}{#1}} +\def\secheadingbreak{\dobreak \secheadingskip{-1000}} % Subsection titles. -\newskip \subsecheadingskip -\def\subsecheadingbreak{\dobreak \subsecheadingskip {-500}} -\def\subsecheading#1#2#3#4{\sectionheading{subsec}{#2.#3.#4}{#1}} -\def\plainsubsecheading#1{\sectionheading{subsec}{}{#1}} +\newskip\subsecheadingskip +\def\subsecheadingbreak{\dobreak \subsecheadingskip{-500}} % Subsubsection titles. -\let\subsubsecheadingskip = \subsecheadingskip -\let\subsubsecheadingbreak = \subsecheadingbreak -\def\subsubsecheading#1#2#3#4#5{\sectionheading{subsubsec}{#2.#3.#4.#5}{#1}} -\def\plainsubsubsecheading#1{\sectionheading{subsubsec}{}{#1}} +\def\subsubsecheadingskip{\subsecheadingskip} +\def\subsubsecheadingbreak{\subsecheadingbreak} -% Print any size section title. +% Print any size, any type, section title. % -% #1 is the section type (sec/subsec/subsubsec), #2 is the section -% number (maybe empty), #3 the text. -\def\sectionheading#1#2#3{% - {% - \expandafter\advance\csname #1headingskip\endcsname by \parskip - \csname #1headingbreak\endcsname - }% +% #1 is the text, #2 is the section level (sec/subsec/subsubsec), #3 is +% the section type for xrefs (Ynumbered, Ynothing, Yappendix), #4 is the +% section number. +% +\def\sectionheading#1#2#3#4{% {% % Switch to the right set of fonts. - \csname #1fonts\endcsname \rm + \csname #2fonts\endcsname \rm + % + % Insert space above the heading. + \csname #2headingbreak\endcsname + % + % Only insert the space after the number if we have a section number. + \def\sectionlevel{#2}% + \def\temptype{#3}% % - % Only insert the separating space if we have a section number. - \def\secnum{#2}% - \setbox0 = \hbox{#2\ifx\secnum\empty\else\enspace\fi}% + \ifx\temptype\Ynothingkeyword + \setbox0 = \hbox{}% + \def\toctype{unn}% + \gdef\thissection{#1}% + \else\ifx\temptype\Yomitfromtockeyword + % for @headings -- no section number, don't include in toc, + % and don't redefine \thissection. + \setbox0 = \hbox{}% + \def\toctype{omit}% + \let\sectionlevel=\empty + \else\ifx\temptype\Yappendixkeyword + \setbox0 = \hbox{#4\enspace}% + \def\toctype{app}% + \gdef\thissection{#1}% + \else + \setbox0 = \hbox{#4\enspace}% + \def\toctype{num}% + \gdef\thissection{#1}% + \fi\fi\fi + % + % Write the toc entry (before \donoderef). See comments in \chfplain. + \writetocentry{\toctype\sectionlevel}{#1}{#4}% + % + % Write the node reference (= pdf destination for pdftex). + % Again, see comments in \chfplain. + \donoderef{#3}% % + % Output the actual section heading. \vbox{\hyphenpenalty=10000 \tolerance=5000 \parindent=0pt \raggedright - \hangindent = \wd0 % zero if no section number - \unhbox0 #3}% + \hangindent=\wd0 % zero if no section number + \unhbox0 #1}% }% - \ifdim\parskip<10pt \nobreak\kern10pt\nobreak\kern-\parskip\fi \nobreak + % Add extra space after the heading -- half of whatever came above it. + % Don't allow stretch, though. + \kern .5 \csname #2headingskip\endcsname + % + % Do not let the kern be a potential breakpoint, as it would be if it + % was followed by glue. + \nobreak + % + % We'll almost certainly start a paragraph next, so don't let that + % glue accumulate. (Not a breakpoint because it's preceded by a + % discardable item.) + \vskip-\parskip + % + % This is purely so the last item on the list is a known \penalty > + % 10000. This is so \startdefun can avoid allowing breakpoints after + % section headings. Otherwise, it would insert a valid breakpoint between: + % + % @section sec-whatever + % @deffn def-whatever + \penalty 10001 } @@ -3927,112 +4385,152 @@ width0pt\relax} \fi \newwrite\tocfile % Write an entry to the toc file, opening it if necessary. -% Called from @chapter, etc. We supply {\folio} at the end of the -% argument, which will end up as the last argument to the \...entry macro. +% Called from @chapter, etc. % -% We open the .toc file here instead of at @setfilename or any other -% fixed time so that @contents can be put in the document anywhere. +% Example usage: \writetocentry{sec}{Section Name}{\the\chapno.\the\secno} +% We append the current node name (if any) and page number as additional +% arguments for the \{chap,sec,...}entry macros which will eventually +% read this. The node name is used in the pdf outlines as the +% destination to jump to. +% +% We open the .toc file for writing here instead of at @setfilename (or +% any other fixed time) so that @contents can be anywhere in the document. +% But if #1 is `omit', then we don't do anything. This is used for the +% table of contents chapter openings themselves. % \newif\iftocfileopened -\def\writetocentry#1{% - \iftocfileopened\else - \immediate\openout\tocfile = \jobname.toc - \global\tocfileopenedtrue +\def\omitkeyword{omit}% +% +\def\writetocentry#1#2#3{% + \edef\writetoctype{#1}% + \ifx\writetoctype\omitkeyword \else + \iftocfileopened\else + \immediate\openout\tocfile = \jobname.toc + \global\tocfileopenedtrue + \fi + % + \iflinks + \toks0 = {#2}% + \toks2 = \expandafter{\lastnode}% + \edef\temp{\write\tocfile{\realbackslash #1entry{\the\toks0}{#3}% + {\the\toks2}{\noexpand\folio}}}% + \temp + \fi \fi - \iflinks \write\tocfile{#1{\folio}}\fi % - % Tell \shipout to create a page destination if we're doing pdf, which - % will be the target of the links in the table of contents. We can't - % just do it on every page because the title pages are numbered 1 and - % 2 (the page numbers aren't printed), and so are the first two pages - % of the document. Thus, we'd have two destinations named `1', and - % two named `2'. - \ifpdf \pdfmakepagedesttrue \fi + % Tell \shipout to create a pdf destination on each page, if we're + % writing pdf. These are used in the table of contents. We can't + % just write one on every page because the title pages are numbered + % 1 and 2 (the page numbers aren't printed), and so are the first + % two pages of the document. Thus, we'd have two destinations named + % `1', and two named `2'. + \ifpdf \global\pdfmakepagedesttrue \fi } \newskip\contentsrightmargin \contentsrightmargin=1in \newcount\savepageno \newcount\lastnegativepageno \lastnegativepageno = -1 -% Finish up the main text and prepare to read what we've written -% to \tocfile. +% Prepare to read what we've written to \tocfile. % \def\startcontents#1{% - % If @setchapternewpage on, and @headings double, the contents should - % start on an odd page, unlike chapters. Thus, we maintain - % \contentsalignmacro in parallel with \pagealignmacro. - % From: Torbjorn Granlund <tege@matematik.su.se> - \contentsalignmacro - \immediate\closeout\tocfile - % - % Don't need to put `Contents' or `Short Contents' in the headline. - % It is abundantly clear what they are. - \unnumbchapmacro{#1}\def\thischapter{}% - \savepageno = \pageno - \begingroup % Set up to handle contents files properly. - \catcode`\\=0 \catcode`\{=1 \catcode`\}=2 \catcode`\@=11 - % We can't do this, because then an actual ^ in a section - % title fails, e.g., @chapter ^ -- exponentiation. --karl, 9jul97. - %\catcode`\^=7 % to see ^^e4 as \"a etc. juha@piuha.ydi.vtt.fi - \raggedbottom % Worry more about breakpoints than the bottom. - \advance\hsize by -\contentsrightmargin % Don't use the full line length. - % - % Roman numerals for page numbers. - \ifnum \pageno>0 \pageno = \lastnegativepageno \fi + % If @setchapternewpage on, and @headings double, the contents should + % start on an odd page, unlike chapters. Thus, we maintain + % \contentsalignmacro in parallel with \pagealignmacro. + % From: Torbjorn Granlund <tege@matematik.su.se> + \contentsalignmacro + \immediate\closeout\tocfile + % + % Don't need to put `Contents' or `Short Contents' in the headline. + % It is abundantly clear what they are. + \def\thischapter{}% + \chapmacro{#1}{Yomitfromtoc}{}% + % + \savepageno = \pageno + \begingroup % Set up to handle contents files properly. + \catcode`\\=0 \catcode`\{=1 \catcode`\}=2 \catcode`\@=11 + % We can't do this, because then an actual ^ in a section + % title fails, e.g., @chapter ^ -- exponentiation. --karl, 9jul97. + %\catcode`\^=7 % to see ^^e4 as \"a etc. juha@piuha.ydi.vtt.fi + \raggedbottom % Worry more about breakpoints than the bottom. + \advance\hsize by -\contentsrightmargin % Don't use the full line length. + % + % Roman numerals for page numbers. + \ifnum \pageno>0 \global\pageno = \lastnegativepageno \fi } % Normal (long) toc. \def\contents{% - \startcontents{\putwordTOC}% - \openin 1 \jobname.toc - \ifeof 1 \else - \closein 1 - \input \jobname.toc - \fi - \vfill \eject - \contentsalignmacro % in case @setchapternewpage odd is in effect - \pdfmakeoutlines - \endgroup - \lastnegativepageno = \pageno - \pageno = \savepageno + \startcontents{\putwordTOC}% + \openin 1 \jobname.toc + \ifeof 1 \else + \input \jobname.toc + \fi + \vfill \eject + \contentsalignmacro % in case @setchapternewpage odd is in effect + \ifeof 1 \else + \pdfmakeoutlines + \fi + \closein 1 + \endgroup + \lastnegativepageno = \pageno + \global\pageno = \savepageno } % And just the chapters. \def\summarycontents{% - \startcontents{\putwordShortTOC}% - % - \let\chapentry = \shortchapentry - \let\appendixentry = \shortappendixentry - \let\unnumbchapentry = \shortunnumberedentry - % We want a true roman here for the page numbers. - \secfonts - \let\rm=\shortcontrm \let\bf=\shortcontbf \let\sl=\shortcontsl - \rm - \hyphenpenalty = 10000 - \advance\baselineskip by 1pt % Open it up a little. - \def\secentry ##1##2##3##4{} - \def\unnumbsecentry ##1##2##3{} - \def\subsecentry ##1##2##3##4##5{} - \def\unnumbsubsecentry ##1##2##3##4{} - \def\subsubsecentry ##1##2##3##4##5##6{} - \def\unnumbsubsubsecentry ##1##2##3##4##5{} - \openin 1 \jobname.toc - \ifeof 1 \else - \closein 1 - \input \jobname.toc - \fi - \vfill \eject - \contentsalignmacro % in case @setchapternewpage odd is in effect - \endgroup - \lastnegativepageno = \pageno - \pageno = \savepageno + \startcontents{\putwordShortTOC}% + % + \let\numchapentry = \shortchapentry + \let\appentry = \shortchapentry + \let\unnchapentry = \shortunnchapentry + % We want a true roman here for the page numbers. + \secfonts + \let\rm=\shortcontrm \let\bf=\shortcontbf + \let\sl=\shortcontsl \let\tt=\shortconttt + \rm + \hyphenpenalty = 10000 + \advance\baselineskip by 1pt % Open it up a little. + \def\numsecentry##1##2##3##4{} + \let\appsecentry = \numsecentry + \let\unnsecentry = \numsecentry + \let\numsubsecentry = \numsecentry + \let\appsubsecentry = \numsecentry + \let\unnsubsecentry = \numsecentry + \let\numsubsubsecentry = \numsecentry + \let\appsubsubsecentry = \numsecentry + \let\unnsubsubsecentry = \numsecentry + \openin 1 \jobname.toc + \ifeof 1 \else + \input \jobname.toc + \fi + \closein 1 + \vfill \eject + \contentsalignmacro % in case @setchapternewpage odd is in effect + \endgroup + \lastnegativepageno = \pageno + \global\pageno = \savepageno } \let\shortcontents = \summarycontents -\ifpdf - \pdfcatalog{/PageMode /UseOutlines}% -\fi +% Typeset the label for a chapter or appendix for the short contents. +% The arg is, e.g., `A' for an appendix, or `3' for a chapter. +% +\def\shortchaplabel#1{% + % This space should be enough, since a single number is .5em, and the + % widest letter (M) is 1em, at least in the Computer Modern fonts. + % But use \hss just in case. + % (This space doesn't include the extra space that gets added after + % the label; that gets put in by \shortchapentry above.) + % + % We'd like to right-justify chapter numbers, but that looks strange + % with appendix letters. And right-justifying numbers and + % left-justifying letters looks strange when there is less than 10 + % chapters. Have to read the whole toc once to know how many chapters + % there are before deciding ... + \hbox to 1em{#1\hss}% +} % These macros generate individual entries in the table of contents. % The first argument is the chapter or section name. @@ -4040,57 +4538,46 @@ width0pt\relax} \fi % The arguments in between are the chapter number, section number, ... % Chapters, in the main contents. -\def\chapentry#1#2#3{\dochapentry{#2\labelspace#1}{#3}} +\def\numchapentry#1#2#3#4{\dochapentry{#2\labelspace#1}{#4}} % % Chapters, in the short toc. % See comments in \dochapentry re vbox and related settings. -\def\shortchapentry#1#2#3{% - \tocentry{\shortchaplabel{#2}\labelspace #1}{\doshortpageno\bgroup#3\egroup}% +\def\shortchapentry#1#2#3#4{% + \tocentry{\shortchaplabel{#2}\labelspace #1}{\doshortpageno\bgroup#4\egroup}% } % Appendices, in the main contents. -\def\appendixentry#1#2#3{\dochapentry{\putwordAppendix{} #2\labelspace#1}{#3}} +% Need the word Appendix, and a fixed-size box. % -% Appendices, in the short toc. -\let\shortappendixentry = \shortchapentry - -% Typeset the label for a chapter or appendix for the short contents. -% The arg is, e.g., `Appendix A' for an appendix, or `3' for a chapter. -% We could simplify the code here by writing out an \appendixentry -% command in the toc file for appendices, instead of using \chapentry -% for both, but it doesn't seem worth it. -% -\newdimen\shortappendixwidth +\def\appendixbox#1{% + % We use M since it's probably the widest letter. + \setbox0 = \hbox{\putwordAppendix{} M}% + \hbox to \wd0{\putwordAppendix{} #1\hss}} % -\def\shortchaplabel#1{% - % This space should be enough, since a single number is .5em, and the - % widest letter (M) is 1em, at least in the Computer Modern fonts. - % But use \hss just in case. - % (This space doesn't include the extra space that gets added after - % the label; that gets put in by \shortchapentry above.) - \dimen0 = 1em - \hbox to \dimen0{#1\hss}% -} +\def\appentry#1#2#3#4{\dochapentry{\appendixbox{#2}\labelspace#1}{#4}} % Unnumbered chapters. -\def\unnumbchapentry#1#2{\dochapentry{#1}{#2}} -\def\shortunnumberedentry#1#2{\tocentry{#1}{\doshortpageno\bgroup#2\egroup}} +\def\unnchapentry#1#2#3#4{\dochapentry{#1}{#4}} +\def\shortunnchapentry#1#2#3#4{\tocentry{#1}{\doshortpageno\bgroup#4\egroup}} % Sections. -\def\secentry#1#2#3#4{\dosecentry{#2.#3\labelspace#1}{#4}} -\def\unnumbsecentry#1#2#3{\dosecentry{#1}{#3}} +\def\numsecentry#1#2#3#4{\dosecentry{#2\labelspace#1}{#4}} +\let\appsecentry=\numsecentry +\def\unnsecentry#1#2#3#4{\dosecentry{#1}{#4}} % Subsections. -\def\subsecentry#1#2#3#4#5{\dosubsecentry{#2.#3.#4\labelspace#1}{#5}} -\def\unnumbsubsecentry#1#2#3#4{\dosubsecentry{#1}{#4}} +\def\numsubsecentry#1#2#3#4{\dosubsecentry{#2\labelspace#1}{#4}} +\let\appsubsecentry=\numsubsecentry +\def\unnsubsecentry#1#2#3#4{\dosubsecentry{#1}{#4}} % And subsubsections. -\def\subsubsecentry#1#2#3#4#5#6{% - \dosubsubsecentry{#2.#3.#4.#5\labelspace#1}{#6}} -\def\unnumbsubsubsecentry#1#2#3#4#5{\dosubsubsecentry{#1}{#5}} +\def\numsubsubsecentry#1#2#3#4{\dosubsubsecentry{#2\labelspace#1}{#4}} +\let\appsubsubsecentry=\numsubsubsecentry +\def\unnsubsubsecentry#1#2#3#4{\dosubsubsecentry{#1}{#4}} % This parameter controls the indentation of the various levels. -\newdimen\tocindent \tocindent = 3pc +% Same as \defaultparindent. +\newdimen\tocindent \tocindent = 15pt % Now for the actual typesetting. In all these, #1 is the text and #2 is the % page number. @@ -4121,17 +4608,8 @@ width0pt\relax} \fi \tocentry{#1}{\dopageno\bgroup#2\egroup}% \endgroup} -% Final typesetting of a toc entry; we use the same \entry macro as for -% the index entries, but we want to suppress hyphenation here. (We -% can't do that in the \entry macro, since index entries might consist -% of hyphenated-identifiers-that-do-not-fit-on-a-line-and-nothing-else.) -\def\tocentry#1#2{\begingroup - \vskip 0pt plus1pt % allow a little stretch for the sake of nice page breaks - % Do not use \turnoffactive in these arguments. Since the toc is - % typeset in cmr, characters such as _ would come out wrong; we - % have to do the usual translation tricks. - \entry{#1}{#2}% -\endgroup} +% We use the same \entry macro as for the index entries. +\let\tocentry = \entry % Space between chapter (or whatever) number and the title. \def\labelspace{\hskip1em \relax} @@ -4141,15 +4619,15 @@ width0pt\relax} \fi \def\chapentryfonts{\secfonts \rm} \def\secentryfonts{\textfonts} -\let\subsecentryfonts = \textfonts -\let\subsubsecentryfonts = \textfonts +\def\subsecentryfonts{\textfonts} +\def\subsubsecentryfonts{\textfonts} \message{environments,} % @foo ... @end foo. % @point{}, @result{}, @expansion{}, @print{}, @equiv{}. -% +% % Since these characters are used in examples, it should be an even number of % \tt widths. Each \tt character is 1en, so two makes it 1em. % @@ -4161,7 +4639,7 @@ width0pt\relax} \fi % The @error{} command. % Adapted from the TeXbook's \boxit. -% +% \newbox\errorbox % {\tentt \global\dimen0 = 3em}% Width of the box. @@ -4169,10 +4647,10 @@ width0pt\relax} \fi % The text. (`r' is open on the right, `e' somewhat less so on the left.) \setbox0 = \hbox{\kern-.75pt \tensf error\kern-1.5pt} % -\global\setbox\errorbox=\hbox to \dimen0{\hfil +\setbox\errorbox=\hbox to \dimen0{\hfil \hsize = \dimen0 \advance\hsize by -5.8pt % Space to left+right. \advance\hsize by -2\dimen2 % Rules. - \vbox{ + \vbox{% \hrule height\dimen2 \hbox{\vrule width\dimen2 \kern3pt % Space to left of text. \vtop{\kern2.4pt \box0 \kern2.4pt}% Space above/below. @@ -4186,17 +4664,16 @@ width0pt\relax} \fi % One exception: @ is still an escape character, so that @end tex works. % But \@ or @@ will get a plain tex @ character. -\def\tex{\begingroup +\envdef\tex{% \catcode `\\=0 \catcode `\{=1 \catcode `\}=2 \catcode `\$=3 \catcode `\&=4 \catcode `\#=6 - \catcode `\^=7 \catcode `\_=8 \catcode `\~=13 \let~=\tie + \catcode `\^=7 \catcode `\_=8 \catcode `\~=\active \let~=\tie \catcode `\%=14 - \catcode 43=12 % plus - \catcode`\"=12 - \catcode`\==12 - \catcode`\|=12 - \catcode`\<=12 - \catcode`\>=12 + \catcode `\+=\other + \catcode `\"=\other + \catcode `\|=\other + \catcode `\<=\other + \catcode `\>=\other \escapechar=`\\ % \let\b=\ptexb @@ -4208,19 +4685,23 @@ width0pt\relax} \fi \let\equiv=\ptexequiv \let\!=\ptexexclam \let\i=\ptexi + \let\indent=\ptexindent + \let\noindent=\ptexnoindent \let\{=\ptexlbrace \let\+=\tabalign \let\}=\ptexrbrace + \let\/=\ptexslash \let\*=\ptexstar \let\t=\ptext % \def\endldots{\mathinner{\ldots\ldots\ldots\ldots}}% \def\enddots{\relax\ifmmode\endldots\else$\mathsurround=0pt \endldots\,$\fi}% \def\@{@}% -\let\Etex=\endgroup} +} +% There is no need to define \Etex. % Define @lisp ... @end lisp. -% @lisp does a \begingroup so it can rebind things, +% @lisp environment forms a group so it can rebind things, % including the definition of @end lisp (which normally is erroneous). % Amount to narrow the margins by for @lisp. @@ -4231,34 +4712,25 @@ width0pt\relax} \fi % have any width. \def\lisppar{\null\endgraf} -% Make each space character in the input produce a normal interword -% space in the output. Don't allow a line break at this space, as this -% is used only in environments like @example, where each line of input -% should produce a line of output anyway. -% -{\obeyspaces % -\gdef\sepspaces{\obeyspaces\let =\tie}} - -% Define \obeyedspace to be our active space, whatever it is. This is -% for use in \parsearg. -{\sepspaces% -\global\let\obeyedspace= } - % This space is always present above and below environments. \newskip\envskipamount \envskipamount = 0pt % Make spacing and below environment symmetrical. We use \parskip here % to help in doing that, since in @example-like environments \parskip % is reset to zero; thus the \afterenvbreak inserts no space -- but the -% start of the next paragraph will insert \parskip +% start of the next paragraph will insert \parskip. % \def\aboveenvbreak{{% - \ifnum\lastpenalty < 10000 + % =10000 instead of <10000 because of a special case in \itemzzz and + % \sectionheading, q.v. + \ifnum \lastpenalty=10000 \else \advance\envskipamount by \parskip \endgraf \ifdim\lastskip<\envskipamount \removelastskip - \penalty-50 + % it's not a good place to break if the last penalty was \nobreak + % or better ... + \ifnum\lastpenalty<10000 \penalty-50 \fi \vskip\envskipamount \fi \fi @@ -4290,54 +4762,54 @@ width0pt\relax} \fi % \newskip\lskip\newskip\rskip -\long\def\cartouche{% -\begingroup - \lskip=\leftskip \rskip=\rightskip - \leftskip=0pt\rightskip=0pt %we want these *outside*. - \cartinner=\hsize \advance\cartinner by-\lskip - \advance\cartinner by-\rskip - \cartouter=\hsize - \advance\cartouter by 18.4pt % allow for 3pt kerns on either -% side, and for 6pt waste from -% each corner char, and rule thickness - \normbskip=\baselineskip \normpskip=\parskip \normlskip=\lineskip - % Flag to tell @lisp, etc., not to narrow margin. - \let\nonarrowing=\comment - \vbox\bgroup - \baselineskip=0pt\parskip=0pt\lineskip=0pt - \carttop - \hbox\bgroup - \hskip\lskip - \vrule\kern3pt - \vbox\bgroup - \hsize=\cartinner - \kern3pt - \begingroup - \baselineskip=\normbskip - \lineskip=\normlskip - \parskip=\normpskip - \vskip -\parskip +\envdef\cartouche{% + \ifhmode\par\fi % can't be in the midst of a paragraph. + \startsavinginserts + \lskip=\leftskip \rskip=\rightskip + \leftskip=0pt\rightskip=0pt % we want these *outside*. + \cartinner=\hsize \advance\cartinner by-\lskip + \advance\cartinner by-\rskip + \cartouter=\hsize + \advance\cartouter by 18.4pt % allow for 3pt kerns on either + % side, and for 6pt waste from + % each corner char, and rule thickness + \normbskip=\baselineskip \normpskip=\parskip \normlskip=\lineskip + % Flag to tell @lisp, etc., not to narrow margin. + \let\nonarrowing=\comment + \vbox\bgroup + \baselineskip=0pt\parskip=0pt\lineskip=0pt + \carttop + \hbox\bgroup + \hskip\lskip + \vrule\kern3pt + \vbox\bgroup + \kern3pt + \hsize=\cartinner + \baselineskip=\normbskip + \lineskip=\normlskip + \parskip=\normpskip + \vskip -\parskip + \comment % For explanation, see the end of \def\group. +} \def\Ecartouche{% - \endgroup - \kern3pt - \egroup - \kern3pt\vrule - \hskip\rskip - \egroup - \cartbot - \egroup -\endgroup -}} + \ifhmode\par\fi + \kern3pt + \egroup + \kern3pt\vrule + \hskip\rskip + \egroup + \cartbot + \egroup + \checkinserts +} % This macro is called at the beginning of all the @example variants, % inside a group. \def\nonfillstart{% \aboveenvbreak - \inENV % This group ends at the end of the body \hfuzz = 12pt % Don't be fussy \sepspaces % Make spaces be word-separators rather than space tokens. - \singlespace \let\par = \lisppar % don't ignore blank lines \obeylines % each line of input is a line of output \parskip = 0pt @@ -4348,115 +4820,99 @@ width0pt\relax} \fi \ifx\nonarrowing\relax \advance \leftskip by \lispnarrowing \exdentamount=\lispnarrowing - \let\exdent=\nofillexdent - \let\nonarrowing=\relax \fi + \let\exdent=\nofillexdent } -% Define the \E... control sequence only if we are inside the particular -% environment, so the error checking in \end will work. +% If you want all examples etc. small: @set dispenvsize small. +% If you want even small examples the full size: @set dispenvsize nosmall. +% This affects the following displayed environments: +% @example, @display, @format, @lisp % -% To end an @example-like environment, we first end the paragraph (via -% \afterenvbreak's vertical glue), and then the group. That way we keep -% the zero \parskip that the environments set -- \parskip glue will be -% inserted at the beginning of the next paragraph in the document, after -% the environment. -% -\def\nonfillfinish{\afterenvbreak\endgroup} +\def\smallword{small} +\def\nosmallword{nosmall} +\let\SETdispenvsize\relax +\def\setnormaldispenv{% + \ifx\SETdispenvsize\smallword + \smallexamplefonts \rm + \fi +} +\def\setsmalldispenv{% + \ifx\SETdispenvsize\nosmallword + \else + \smallexamplefonts \rm + \fi +} -% @lisp: indented, narrowed, typewriter font. -\def\lisp{\begingroup - \nonfillstart - \let\Elisp = \nonfillfinish - \tt - \let\kbdfont = \kbdexamplefont % Allow @kbd to do something special. - \gobble % eat return +% We often define two environments, @foo and @smallfoo. +% Let's do it by one command: +\def\makedispenv #1#2{ + \expandafter\envdef\csname#1\endcsname {\setnormaldispenv #2} + \expandafter\envdef\csname small#1\endcsname {\setsmalldispenv #2} + \expandafter\let\csname E#1\endcsname \afterenvbreak + \expandafter\let\csname Esmall#1\endcsname \afterenvbreak } -% @example: Same as @lisp. -\def\example{\begingroup \def\Eexample{\nonfillfinish\endgroup}\lisp} +% Define two synonyms: +\def\maketwodispenvs #1#2#3{ + \makedispenv{#1}{#3} + \makedispenv{#2}{#3} +} -% @small... is usually equivalent to the non-small (@smallbook -% redefines). We must call \example (or whatever) last in the -% definition, since it reads the return following the @example (or -% whatever) command. -% -% This actually allows (for example) @end display inside an -% @smalldisplay. Too bad, but makeinfo will catch the error anyway. +% @lisp: indented, narrowed, typewriter font; @example: same as @lisp. % -\def\smalldisplay{\begingroup\def\Esmalldisplay{\nonfillfinish\endgroup}\display} -\def\smallexample{\begingroup\def\Esmallexample{\nonfillfinish\endgroup}\lisp} -\def\smallformat{\begingroup\def\Esmallformat{\nonfillfinish\endgroup}\format} -\def\smalllisp{\begingroup\def\Esmalllisp{\nonfillfinish\endgroup}\lisp} - -% Real @smallexample and @smalllisp (when @smallbook): use smaller fonts. +% @smallexample and @smalllisp: use smaller fonts. % Originally contributed by Pavel@xerox. -\def\smalllispx{\begingroup - \def\Esmalllisp{\nonfillfinish\endgroup}% - \def\Esmallexample{\nonfillfinish\endgroup}% - \smallexamplefonts - \lisp +% +\maketwodispenvs {lisp}{example}{% + \nonfillstart + \tt + \let\kbdfont = \kbdexamplefont % Allow @kbd to do something special. + \gobble % eat return } -% @display: same as @lisp except keep current font. +% @display/@smalldisplay: same as @lisp except keep current font. % -\def\display{\begingroup +\makedispenv {display}{% \nonfillstart - \let\Edisplay = \nonfillfinish \gobble } -% -% @smalldisplay (when @smallbook): @display plus smaller fonts. -% -\def\smalldisplayx{\begingroup - \def\Esmalldisplay{\nonfillfinish\endgroup}% - \smallexamplefonts \rm - \display -} -% @format: same as @display except don't narrow margins. +% @format/@smallformat: same as @display except don't narrow margins. % -\def\format{\begingroup - \let\nonarrowing = t +\makedispenv{format}{% + \let\nonarrowing = t% \nonfillstart - \let\Eformat = \nonfillfinish \gobble } -% -% @smallformat (when @smallbook): @format plus smaller fonts. -% -\def\smallformatx{\begingroup - \def\Esmallformat{\nonfillfinish\endgroup}% - \smallexamplefonts \rm - \format -} -% @flushleft (same as @format). -% -\def\flushleft{\begingroup \def\Eflushleft{\nonfillfinish\endgroup}\format} +% @flushleft: same as @format, but doesn't obey \SETdispenvsize. +\envdef\flushleft{% + \let\nonarrowing = t% + \nonfillstart + \gobble +} +\let\Eflushleft = \afterenvbreak % @flushright. % -\def\flushright{\begingroup - \let\nonarrowing = t +\envdef\flushright{% + \let\nonarrowing = t% \nonfillstart - \let\Eflushright = \nonfillfinish \advance\leftskip by 0pt plus 1fill \gobble } +\let\Eflushright = \afterenvbreak % @quotation does normal linebreaking (hence we can't use \nonfillstart) -% and narrows the margins. +% and narrows the margins. We keep \parskip nonzero in general, since +% we're doing normal filling. So, when using \aboveenvbreak and +% \afterenvbreak, temporarily make \parskip 0. % -\def\quotation{% - \begingroup\inENV %This group ends at the end of the @quotation body +\envdef\quotation{% {\parskip=0pt \aboveenvbreak}% because \aboveenvbreak inserts \parskip - \singlespace \parindent=0pt - % We have retained a nonzero parskip for the environment, since we're - % doing normal filling. So to avoid extra space below the environment... - \def\Equotation{\parskip = 0pt \nonfillfinish}% % % @cartouche defines \nonarrowing to inhibit narrowing at next level down. \ifx\nonarrowing\relax @@ -4465,24 +4921,49 @@ width0pt\relax} \fi \exdentamount = \lispnarrowing \let\nonarrowing = \relax \fi + \parsearg\quotationlabel +} + +% We have retained a nonzero parskip for the environment, since we're +% doing normal filling. +% +\def\Equotation{% + \par + \ifx\quotationauthor\undefined\else + % indent a bit. + \leftline{\kern 2\leftskip \sl ---\quotationauthor}% + \fi + {\parskip=0pt \afterenvbreak}% +} + +% If we're given an argument, typeset it in bold with a colon after. +\def\quotationlabel#1{% + \def\temp{#1}% + \ifx\temp\empty \else + {\bf #1: }% + \fi } % LaTeX-like @verbatim...@end verbatim and @verb{<char>...<char>} -% If we want to allow any <char> as delimiter, +% If we want to allow any <char> as delimiter, % we need the curly braces so that makeinfo sees the @verb command, eg: % `@verbx...x' would look like the '@verbx' command. --janneke@gnu.org % % [Knuth]: Donald Ervin Knuth, 1996. The TeXbook. % -% [Knuth] p. 344; only we need to do '@' too +% [Knuth] p.344; only we need to do the other characters Texinfo sets +% active too. Otherwise, they get lost as the first character on a +% verbatim line. \def\dospecials{% - \do\ \do\\\do\@\do\{\do\}\do\$\do\&% - \do\#\do\^\do\^^K\do\_\do\^^A\do\%\do\~} + \do\ \do\\\do\{\do\}\do\$\do\&% + \do\#\do\^\do\^^K\do\_\do\^^A\do\%\do\~% + \do\<\do\>\do\|\do\@\do+\do\"% +} % % [Knuth] p. 380 \def\uncatcodespecials{% - \def\do##1{\catcode`##1=12}\dospecials} + \def\do##1{\catcode`##1=\other}\dospecials} % % [Knuth] pp. 380,381,391 % Disable Spanish ligatures ?` and !` of \tt font @@ -4530,6 +5011,8 @@ width0pt\relax} \fi } \endgroup \def\setupverbatim{% + \nonfillstart + \advance\leftskip by -\defbodyindent % Easiest (and conventionally used) font for verbatim \tt \def\par{\leavevmode\egroup\box0\endgraf}% @@ -4543,15 +5026,15 @@ width0pt\relax} \fi \everypar{\starttabbox}% } -% Do the @verb magic: verbatim text is quoted by unique -% delimiter characters. Before first delimiter expect a +% Do the @verb magic: verbatim text is quoted by unique +% delimiter characters. Before first delimiter expect a % right brace, after last delimiter expect closing brace: % % \def\doverb'{'<char>#1<char>'}'{#1} % % [Knuth] p. 382; only eat outer {} \begingroup - \catcode`[=1\catcode`]=2\catcode`\{=12\catcode`\}=12 + \catcode`[=1\catcode`]=2\catcode`\{=\other\catcode`\}=\other \gdef\doverb{#1[\def\next##1#1}[##1\endgroup]\next] \endgroup % @@ -4563,611 +5046,395 @@ width0pt\relax} \fi % % \def\doverbatim#1@end verbatim{#1} % -% For Texinfo it's a lot easier than for LaTeX, +% For Texinfo it's a lot easier than for LaTeX, % because texinfo's \verbatim doesn't stop at '\end{verbatim}': -% we need not redefine '\', '{' and '}' +% we need not redefine '\', '{' and '}'. % % Inspired by LaTeX's verbatim command set [latex.ltx] -%% Include LaTeX hack for completeness -- never know -%% \begingroup -%% \catcode`|=0 \catcode`[=1 -%% \catcode`]=2\catcode`\{=12\catcode`\}=12\catcode`\ =\active -%% \catcode`\\=12|gdef|doverbatim#1@end verbatim[ -%% #1|endgroup|def|Everbatim[]|end[verbatim]] -%% |endgroup +% \begingroup \catcode`\ =\active - \gdef\doverbatim#1@end verbatim{#1\end{verbatim}} + \obeylines % + % ignore everything up to the first ^^M, that's the newline at the end + % of the @verbatim input line itself. Otherwise we get an extra blank + % line in the output. + \xdef\doverbatim#1^^M#2@end verbatim{#2\noexpand\end\gobble verbatim}% + % We really want {...\end verbatim} in the body of the macro, but + % without the active space; thus we have to use \xdef and \gobble. \endgroup % -\def\verbatim{% - \def\Everbatim{\nonfillfinish\endgroup}% - \begingroup - \nonfillstart - \advance\leftskip by -\defbodyindent - \begingroup\setupverbatim\doverbatim +\envdef\verbatim{% + \setupverbatim\doverbatim } +\let\Everbatim = \afterenvbreak + % @verbatiminclude FILE - insert text of file in verbatim environment. % -% Allow normal characters that we make active in the argument (a file name). -\def\verbatiminclude{% - \begingroup - \catcode`\\=12 - \catcode`~=12 - \catcode`^=12 - \catcode`_=12 - \catcode`|=12 - \catcode`<=12 - \catcode`>=12 - \catcode`+=12 - \parsearg\doverbatiminclude -} -\def\setupverbatiminclude{% - \begingroup - \nonfillstart - \advance\leftskip by -\defbodyindent - \begingroup\setupverbatim -} +\def\verbatiminclude{\parseargusing\filenamecatcodes\doverbatiminclude} % \def\doverbatiminclude#1{% - % Restore active chars for included file. - \endgroup - \begingroup - \def\thisfile{#1}% - \expandafter\expandafter\setupverbatiminclude\input\thisfile - \endgroup\nonfillfinish\endgroup + {% + \makevalueexpandable + \setupverbatim + \input #1 + \afterenvbreak + }% } % @copying ... @end copying. % Save the text away for @insertcopying later. -% -\newbox\copyingbox % -\def\copying{\begingroup - \parindent = 0pt % looks wrong on title page - \def\Ecopying{\egroup\endgroup}% - \global\setbox\copyingbox = \vbox\bgroup +% We save the uninterpreted tokens, rather than creating a box. +% Saving the text in a box would be much easier, but then all the +% typesetting commands (@smallbook, font changes, etc.) have to be done +% beforehand -- and a) we want @copying to be done first in the source +% file; b) letting users define the frontmatter in as flexible order as +% possible is very desirable. +% +\def\copying{\checkenv{}\begingroup\scanargctxt\docopying} +\def\docopying#1@end copying{\endgroup\def\copyingtext{#1}} +% +\def\insertcopying{% + \begingroup + \parindent = 0pt % paragraph indentation looks wrong on title page + \scanexp\copyingtext + \endgroup } -% @insertcopying. -% -\def\insertcopying{\unvcopy\copyingbox} - - \message{defuns,} % @defun etc. -% Allow user to change definition object font (\df) internally -\def\setdeffont #1 {\csname DEF#1\endcsname} - \newskip\defbodyindent \defbodyindent=.4in \newskip\defargsindent \defargsindent=50pt -\newskip\deftypemargin \deftypemargin=12pt \newskip\deflastargmargin \deflastargmargin=18pt -\newcount\parencount -% define \functionparens, which makes ( and ) and & do special things. -% \functionparens affects the group it is contained in. -\def\activeparens{% -\catcode`\(=\active \catcode`\)=\active \catcode`\&=\active -\catcode`\[=\active \catcode`\]=\active} - -% Make control sequences which act like normal parenthesis chars. -\let\lparen = ( \let\rparen = ) - -{\activeparens % Now, smart parens don't turn on until &foo (see \amprm) - -% Be sure that we always have a definition for `(', etc. For example, -% if the fn name has parens in it, \boldbrax will not be in effect yet, -% so TeX would otherwise complain about undefined control sequence. -\global\let(=\lparen \global\let)=\rparen -\global\let[=\lbrack \global\let]=\rbrack - -\gdef\functionparens{\boldbrax\let&=\amprm\parencount=0 } -\gdef\boldbrax{\let(=\opnr\let)=\clnr\let[=\lbrb\let]=\rbrb} -% This is used to turn on special parens -% but make & act ordinary (given that it's active). -\gdef\boldbraxnoamp{\let(=\opnr\let)=\clnr\let[=\lbrb\let]=\rbrb\let&=\ampnr} - -% Definitions of (, ) and & used in args for functions. -% This is the definition of ( outside of all parentheses. -\gdef\oprm#1 {{\rm\char`\(}#1 \bf \let(=\opnested - \global\advance\parencount by 1 -} -% -% This is the definition of ( when already inside a level of parens. -\gdef\opnested{\char`\(\global\advance\parencount by 1 } -% -\gdef\clrm{% Print a paren in roman if it is taking us back to depth of 0. - % also in that case restore the outer-level definition of (. - \ifnum \parencount=1 {\rm \char `\)}\sl \let(=\oprm \else \char `\) \fi - \global\advance \parencount by -1 } -% If we encounter &foo, then turn on ()-hacking afterwards -\gdef\amprm#1 {{\rm\}\let(=\oprm \let)=\clrm\ } -% -\gdef\normalparens{\boldbrax\let&=\ampnr} -} % End of definition inside \activeparens -%% These parens (in \boldbrax) actually are a little bolder than the -%% contained text. This is especially needed for [ and ] -\def\opnr{{\sf\char`\(}\global\advance\parencount by 1 } -\def\clnr{{\sf\char`\)}\global\advance\parencount by -1 } -\let\ampnr = \& -\def\lbrb{{\bf\char`\[}} -\def\rbrb{{\bf\char`\]}} - -% Active &'s sneak into the index arguments, so make sure it's defined. -{ - \catcode`& = 13 - \global\let& = \ampnr -} - -% First, defname, which formats the header line itself. -% #1 should be the function name. -% #2 should be the type of definition, such as "Function". - -\def\defname #1#2{% -% Get the values of \leftskip and \rightskip as they were -% outside the @def... -\dimen2=\leftskip -\advance\dimen2 by -\defbodyindent -\noindent -\setbox0=\hbox{\hskip \deflastargmargin{\rm #2}\hskip \deftypemargin}% -\dimen0=\hsize \advance \dimen0 by -\wd0 % compute size for first line -\dimen1=\hsize \advance \dimen1 by -\defargsindent %size for continuations -\parshape 2 0in \dimen0 \defargsindent \dimen1 -% Now output arg 2 ("Function" or some such) -% ending at \deftypemargin from the right margin, -% but stuck inside a box of width 0 so it does not interfere with linebreaking -{% Adjust \hsize to exclude the ambient margins, -% so that \rightline will obey them. -\advance \hsize by -\dimen2 -\rlap{\rightline{{\rm #2}\hskip -1.25pc }}}% -% Make all lines underfull and no complaints: -\tolerance=10000 \hbadness=10000 -\advance\leftskip by -\defbodyindent -\exdentamount=\defbodyindent -{\df #1}\enskip % Generate function name -} - -% Common pieces to start any @def... -% #1 is the \E... control sequence to end the definition (which we define). -% #2 is the \...x control sequence (which our caller defines). -% #3 is the control sequence to process the header, such as \defunheader. -% -\def\parsebodycommon#1#2#3{% - \begingroup\inENV - % If there are two @def commands in a row, we'll have a \nobreak, - % which is there to keep the function description together with its - % header. But if there's nothing but headers, we want to allow a - % break after all. - \ifnum\lastpenalty = 10000 \penalty0 \fi - \medbreak - % - % Define the \E... end token that this defining construct specifies - % so that it will exit this group. - \def#1{\endgraf\endgroup\medbreak}% +% Start the processing of @deffn: +\def\startdefun{% + \ifnum\lastpenalty<10000 + \medbreak + \else + % If there are two @def commands in a row, we'll have a \nobreak, + % which is there to keep the function description together with its + % header. But if there's nothing but headers, we need to allow a + % break somewhere. Check specifically for penalty 10002, inserted + % by \defargscommonending, instead of 10000, since the sectioning + % commands also insert a nobreak penalty, and we don't want to allow + % a break between a section heading and a defun. + % + \ifnum\lastpenalty=10002 \penalty2000 \fi + % + % Similarly, after a section heading, do not allow a break. + % But do insert the glue. + \medskip % preceded by discardable penalty, so not a breakpoint + \fi % \parindent=0in \advance\leftskip by \defbodyindent \exdentamount=\defbodyindent } -% Process body of @defun, @deffn, @defmac, etc. -% -\def\defparsebody#1#2#3{% - \parsebodycommon{#1}{#2}{#3}% - \def#2{\begingroup\obeylines\activeparens\spacesplit#3}% - \catcode61=\active % 61 is `=' - \begingroup\obeylines\activeparens - \spacesplit#3% -} - -% #1, #2, #3 are the common arguments (see \defparsebody). -% #4, delimited by the space, is the class name. -% -\def\defmethparsebody#1#2#3#4 {% - \parsebodycommon{#1}{#2}{#3}% - \def#2##1 {\begingroup\obeylines\activeparens\spacesplit{#3{##1}}}% - \begingroup\obeylines\activeparens - \spacesplit{#3{#4}}% +\def\dodefunx#1{% + % First, check whether we are in the right environment: + \checkenv#1% + % + % As above, allow line break if we have multiple x headers in a row. + % It's not a great place, though. + \ifnum\lastpenalty=10002 \penalty3000 \fi + % + % And now, it's time to reuse the body of the original defun: + \expandafter\gobbledefun#1% } +\def\gobbledefun#1\startdefun{} -% Used for @deftypemethod and @deftypeivar. -% #1, #2, #3 are the common arguments (see \defparsebody). -% #4, delimited by a space, is the class name. -% #5 is the method's return type. +% \printdefunline \deffnheader{text} % -\def\deftypemethparsebody#1#2#3#4 #5 {% - \parsebodycommon{#1}{#2}{#3}% - \def#2##1 ##2 {\begingroup\obeylines\activeparens\spacesplit{#3{##1}{##2}}}% - \begingroup\obeylines\activeparens - \spacesplit{#3{#4}{#5}}% -} - -% Used for @deftypeop. The change from \deftypemethparsebody is an -% extra argument at the beginning which is the `category', instead of it -% being the hardwired string `Method' or `Instance Variable'. We have -% to account for this both in the \...x definition and in parsing the -% input at hand. Thus also need a control sequence (passed as #5) for -% the \E... definition to assign the category name to. -% -\def\deftypeopparsebody#1#2#3#4#5 #6 {% - \parsebodycommon{#1}{#2}{#3}% - \def#2##1 ##2 ##3 {% - \def#4{##1}% - \begingroup\obeylines\activeparens\spacesplit{#3{##2}{##3}}}% - \begingroup\obeylines\activeparens - \spacesplit{#3{#5}{#6}}% +\def\printdefunline#1#2{% + \begingroup + % call \deffnheader: + #1#2 \endheader + % common ending: + \interlinepenalty = 10000 + \advance\rightskip by 0pt plus 1fil + \endgraf + \nobreak\vskip -\parskip + \penalty 10002 % signal to \startdefun and \dodefunx + % Some of the @defun-type tags do not enable magic parentheses, + % rendering the following check redundant. But we don't optimize. + \checkparencounts + \endgroup } -% For @defop. -\def\defopparsebody #1#2#3#4#5 {% - \parsebodycommon{#1}{#2}{#3}% - \def#2##1 ##2 {\def#4{##1}% - \begingroup\obeylines\activeparens\spacesplit{#3{##2}}}% - \begingroup\obeylines\activeparens - \spacesplit{#3{#5}}% -} +\def\Edefun{\endgraf\medbreak} -% These parsing functions are similar to the preceding ones -% except that they do not make parens into active characters. -% These are used for "variables" since they have no arguments. +% \makedefun{deffn} creates \deffn, \deffnx and \Edeffn; +% the only thing remainnig is to define \deffnheader. % -\def\defvarparsebody #1#2#3{% - \parsebodycommon{#1}{#2}{#3}% - \def#2{\begingroup\obeylines\spacesplit#3}% - \catcode61=\active % - \begingroup\obeylines - \spacesplit#3% -} - -% @defopvar. -\def\defopvarparsebody #1#2#3#4#5 {% - \parsebodycommon{#1}{#2}{#3}% - \def#2##1 ##2 {\def#4{##1}% - \begingroup\obeylines\spacesplit{#3{##2}}}% - \begingroup\obeylines - \spacesplit{#3{#5}}% -} - -\def\defvrparsebody#1#2#3#4 {% - \parsebodycommon{#1}{#2}{#3}% - \def#2##1 {\begingroup\obeylines\spacesplit{#3{##1}}}% - \begingroup\obeylines - \spacesplit{#3{#4}}% +\def\makedefun#1{% + \expandafter\let\csname E#1\endcsname = \Edefun + \edef\temp{\noexpand\domakedefun + \makecsname{#1}\makecsname{#1x}\makecsname{#1header}}% + \temp } -% This loses on `@deftp {Data Type} {struct termios}' -- it thinks the -% type is just `struct', because we lose the braces in `{struct -% termios}' when \spacesplit reads its undelimited argument. Sigh. -% \let\deftpparsebody=\defvrparsebody +% \domakedefun \deffn \deffnx \deffnheader % -% So, to get around this, we put \empty in with the type name. That -% way, TeX won't find exactly `{...}' as an undelimited argument, and -% won't strip off the braces. +% Define \deffn and \deffnx, without parameters. +% \deffnheader has to be defined explicitly. % -\def\deftpparsebody #1#2#3#4 {% - \parsebodycommon{#1}{#2}{#3}% - \def#2##1 {\begingroup\obeylines\spacesplit{#3{##1}}}% - \begingroup\obeylines - \spacesplit{\parsetpheaderline{#3{#4}}}\empty +\def\domakedefun#1#2#3{% + \envdef#1{% + \startdefun + \parseargusing\activeparens{\printdefunline#3}% + }% + \def#2{\dodefunx#1}% + \def#3% } -% Fine, but then we have to eventually remove the \empty *and* the -% braces (if any). That's what this does. -% -\def\removeemptybraces\empty#1\relax{#1} +%%% Untyped functions: -% After \spacesplit has done its work, this is called -- #1 is the final -% thing to call, #2 the type name (which starts with \empty), and #3 -% (which might be empty) the arguments. -% -\def\parsetpheaderline#1#2#3{% - #1{\removeemptybraces#2\relax}{#3}% -}% +% @deffn category name args +\makedefun{deffn}{\deffngeneral{}} -% Split up #2 at the first space token. -% call #1 with two arguments: -% the first is all of #2 before the space token, -% the second is all of #2 after that space token. -% If #2 contains no space token, all of it is passed as the first arg -% and the second is passed as empty. -% -{\obeylines -\gdef\spacesplit#1#2^^M{\endgroup\spacesplitfoo{#1}#2 \relax\spacesplitfoo}% -\long\gdef\spacesplitfoo#1#2 #3#4\spacesplitfoo{% -\ifx\relax #3% -#1{#2}{}\else #1{#2}{#3#4}\fi}} +% @deffn category class name args +\makedefun{defop}#1 {\defopon{#1\ \putwordon}} -% Define @defun. +% \defopon {category on}class name args +\def\defopon#1#2 {\deffngeneral{\putwordon\ \code{#2}}{#1\ \code{#2}} } -% First, define the processing that is wanted for arguments of \defun -% Use this to expand the args and terminate the paragraph they make up - -\def\defunargs#1{\functionparens \sl -% Expand, preventing hyphenation at `-' chars. -% Note that groups don't affect changes in \hyphenchar. -% Set the font temporarily and use \font in case \setfont made \tensl a macro. -{\tensl\hyphenchar\font=0}% -#1% -{\tensl\hyphenchar\font=45}% -\ifnum\parencount=0 \else \errmessage{Unbalanced parentheses in @def}\fi% -\interlinepenalty=10000 -\advance\rightskip by 0pt plus 1fil -\endgraf\nobreak\vskip -\parskip\nobreak +% \deffngeneral {subind}category name args +% +\def\deffngeneral#1#2 #3 #4\endheader{% + % Remember that \dosubind{fn}{foo}{} is equivalent to \doind{fn}{foo}. + \dosubind{fn}{\code{#3}}{#1}% + \defname{#2}{}{#3}\magicamp\defunargs{#4\unskip}% } -\def\deftypefunargs #1{% -% Expand, preventing hyphenation at `-' chars. -% Note that groups don't affect changes in \hyphenchar. -% Use \boldbraxnoamp, not \functionparens, so that & is not special. -\boldbraxnoamp -\tclose{#1}% avoid \code because of side effects on active chars -\interlinepenalty=10000 -\advance\rightskip by 0pt plus 1fil -\endgraf\nobreak\vskip -\parskip\nobreak -} +%%% Typed functions: -% Do complete processing of one @defun or @defunx line already parsed. +% @deftypefn category type name args +\makedefun{deftypefn}{\deftypefngeneral{}} -% @deffn Command forward-char nchars +% @deftypeop category class type name args +\makedefun{deftypeop}#1 {\deftypeopon{#1\ \putwordon}} -\def\deffn{\defmethparsebody\Edeffn\deffnx\deffnheader} +% \deftypeopon {category on}class type name args +\def\deftypeopon#1#2 {\deftypefngeneral{\putwordon\ \code{#2}}{#1\ \code{#2}} } -\def\deffnheader #1#2#3{\doind {fn}{\code{#2}}% -\begingroup\defname {#2}{#1}\defunargs{#3}\endgroup % -\catcode 61=\other % Turn off change made in \defparsebody +% \deftypefngeneral {subind}category type name args +% +\def\deftypefngeneral#1#2 #3 #4 #5\endheader{% + \dosubind{fn}{\code{#4}}{#1}% + \defname{#2}{#3}{#4}\defunargs{#5\unskip}% } -% @defun == @deffn Function - -\def\defun{\defparsebody\Edefun\defunx\defunheader} +%%% Typed variables: -\def\defunheader #1#2{\doind {fn}{\code{#1}}% Make entry in function index -\begingroup\defname {#1}{\putwordDeffunc}% -\defunargs {#2}\endgroup % -\catcode 61=\other % Turn off change made in \defparsebody -} +% @deftypevr category type var args +\makedefun{deftypevr}{\deftypecvgeneral{}} -% @deftypefun int foobar (int @var{foo}, float @var{bar}) +% @deftypecv category class type var args +\makedefun{deftypecv}#1 {\deftypecvof{#1\ \putwordof}} -\def\deftypefun{\defparsebody\Edeftypefun\deftypefunx\deftypefunheader} +% \deftypecvof {category of}class type var args +\def\deftypecvof#1#2 {\deftypecvgeneral{\putwordof\ \code{#2}}{#1\ \code{#2}} } -% #1 is the data type. #2 is the name and args. -\def\deftypefunheader #1#2{\deftypefunheaderx{#1}#2 \relax} -% #1 is the data type, #2 the name, #3 the args. -\def\deftypefunheaderx #1#2 #3\relax{% -\doind {fn}{\code{#2}}% Make entry in function index -\begingroup\defname {\defheaderxcond#1\relax$.$#2}{\putwordDeftypefun}% -\deftypefunargs {#3}\endgroup % -\catcode 61=\other % Turn off change made in \defparsebody +% \deftypecvgeneral {subind}category type var args +% +\def\deftypecvgeneral#1#2 #3 #4 #5\endheader{% + \dosubind{vr}{\code{#4}}{#1}% + \defname{#2}{#3}{#4}\defunargs{#5\unskip}% } -% @deftypefn {Library Function} int foobar (int @var{foo}, float @var{bar}) - -\def\deftypefn{\defmethparsebody\Edeftypefn\deftypefnx\deftypefnheader} +%%% Untyped variables: -% \defheaderxcond#1\relax$.$ -% puts #1 in @code, followed by a space, but does nothing if #1 is null. -\def\defheaderxcond#1#2$.${\ifx#1\relax\else\code{#1#2} \fi} +% @defvr category var args +\makedefun{defvr}#1 {\deftypevrheader{#1} {} } -% #1 is the classification. #2 is the data type. #3 is the name and args. -\def\deftypefnheader #1#2#3{\deftypefnheaderx{#1}{#2}#3 \relax} -% #1 is the classification, #2 the data type, #3 the name, #4 the args. -\def\deftypefnheaderx #1#2#3 #4\relax{% -\doind {fn}{\code{#3}}% Make entry in function index -\begingroup -\normalparens % notably, turn off `&' magic, which prevents -% at least some C++ text from working -\defname {\defheaderxcond#2\relax$.$#3}{#1}% -\deftypefunargs {#4}\endgroup % -\catcode 61=\other % Turn off change made in \defparsebody -} +% @defcv category class var args +\makedefun{defcv}#1 {\defcvof{#1\ \putwordof}} -% @defmac == @deffn Macro +% \defcvof {category of}class var args +\def\defcvof#1#2 {\deftypecvof{#1}#2 {} } -\def\defmac{\defparsebody\Edefmac\defmacx\defmacheader} - -\def\defmacheader #1#2{\doind {fn}{\code{#1}}% Make entry in function index -\begingroup\defname {#1}{\putwordDefmac}% -\defunargs {#2}\endgroup % -\catcode 61=\other % Turn off change made in \defparsebody +%%% Type: +% @deftp category name args +\makedefun{deftp}#1 #2 #3\endheader{% + \doind{tp}{\code{#2}}% + \defname{#1}{}{#2}\defunargs{#3\unskip}% } -% @defspec == @deffn Special Form - -\def\defspec{\defparsebody\Edefspec\defspecx\defspecheader} +% Remaining @defun-like shortcuts: +\makedefun{defun}{\deffnheader{\putwordDeffunc} } +\makedefun{defmac}{\deffnheader{\putwordDefmac} } +\makedefun{defspec}{\deffnheader{\putwordDefspec} } +\makedefun{deftypefun}{\deftypefnheader{\putwordDeffunc} } +\makedefun{defvar}{\defvrheader{\putwordDefvar} } +\makedefun{defopt}{\defvrheader{\putwordDefopt} } +\makedefun{deftypevar}{\deftypevrheader{\putwordDefvar} } +\makedefun{defmethod}{\defopon\putwordMethodon} +\makedefun{deftypemethod}{\deftypeopon\putwordMethodon} +\makedefun{defivar}{\defcvof\putwordInstanceVariableof} +\makedefun{deftypeivar}{\deftypecvof\putwordInstanceVariableof} -\def\defspecheader #1#2{\doind {fn}{\code{#1}}% Make entry in function index -\begingroup\defname {#1}{\putwordDefspec}% -\defunargs {#2}\endgroup % -\catcode 61=\other % Turn off change made in \defparsebody -} - -% @defop CATEGORY CLASS OPERATION ARG... +% \defname, which formats the name of the @def (not the args). +% #1 is the category, such as "Function". +% #2 is the return type, if any. +% #3 is the function name. % -\def\defop #1 {\def\defoptype{#1}% -\defopparsebody\Edefop\defopx\defopheader\defoptype} +% We are followed by (but not passed) the arguments, if any. % -\def\defopheader#1#2#3{% -\dosubind {fn}{\code{#2}}{\putwordon\ #1}% Make entry in function index -\begingroup\defname {#2}{\defoptype\ \putwordon\ #1}% -\defunargs {#3}\endgroup % +\def\defname#1#2#3{% + % Get the values of \leftskip and \rightskip as they were outside the @def... + \advance\leftskip by -\defbodyindent + % + % How we'll format the type name. Putting it in brackets helps + % distinguish it from the body text that may end up on the next line + % just below it. + \def\temp{#1}% + \setbox0=\hbox{\kern\deflastargmargin \ifx\temp\empty\else [\rm\temp]\fi} + % + % Figure out line sizes for the paragraph shape. + % The first line needs space for \box0; but if \rightskip is nonzero, + % we need only space for the part of \box0 which exceeds it: + \dimen0=\hsize \advance\dimen0 by -\wd0 \advance\dimen0 by \rightskip + % The continuations: + \dimen2=\hsize \advance\dimen2 by -\defargsindent + % (plain.tex says that \dimen1 should be used only as global.) + \parshape 2 0in \dimen0 \defargsindent \dimen2 + % + % Put the type name to the right margin. + \noindent + \hbox to 0pt{% + \hfil\box0 \kern-\hsize + % \hsize has to be shortened this way: + \kern\leftskip + % Intentionally do not respect \rightskip, since we need the space. + }% + % + % Allow all lines to be underfull without complaint: + \tolerance=10000 \hbadness=10000 + \exdentamount=\defbodyindent + {% + % defun fonts. We use typewriter by default (used to be bold) because: + % . we're printing identifiers, they should be in tt in principle. + % . in languages with many accents, such as Czech or French, it's + % common to leave accents off identifiers. The result looks ok in + % tt, but exceedingly strange in rm. + % . we don't want -- and --- to be treated as ligatures. + % . this still does not fix the ?` and !` ligatures, but so far no + % one has made identifiers using them :). + \df \tt + \def\temp{#2}% return value type + \ifx\temp\empty\else \tclose{\temp} \fi + #3% output function name + }% + {\rm\enskip}% hskip 0.5 em of \tenrm + % + \boldbrax + % arguments will be output next, if any. } -% @deftypeop CATEGORY CLASS TYPE OPERATION ARG... +% Print arguments in slanted roman (not ttsl), inconsistently with using +% tt for the name. This is because literal text is sometimes needed in +% the argument list (groff manual), and ttsl and tt are not very +% distinguishable. Prevent hyphenation at `-' chars. % -\def\deftypeop #1 {\def\deftypeopcategory{#1}% - \deftypeopparsebody\Edeftypeop\deftypeopx\deftypeopheader - \deftypeopcategory} -% -% #1 is the class name, #2 the data type, #3 the operation name, #4 the args. -\def\deftypeopheader#1#2#3#4{% - \dosubind{fn}{\code{#3}}{\putwordon\ \code{#1}}% entry in function index - \begingroup - \defname{\defheaderxcond#2\relax$.$#3} - {\deftypeopcategory\ \putwordon\ \code{#1}}% - \deftypefunargs{#4}% - \endgroup +\def\defunargs#1{% + % use sl by default (not ttsl), + % tt for the names. + \df \sl \hyphenchar\font=0 + % + % On the other hand, if an argument has two dashes (for instance), we + % want a way to get ttsl. Let's try @var for that. + \let\var=\ttslanted + #1% + \sl\hyphenchar\font=45 } -% @deftypemethod CLASS TYPE METHOD ARG... +% We want ()&[] to print specially on the defun line. % -\def\deftypemethod{% - \deftypemethparsebody\Edeftypemethod\deftypemethodx\deftypemethodheader} -% -% #1 is the class name, #2 the data type, #3 the method name, #4 the args. -\def\deftypemethodheader#1#2#3#4{% - \dosubind{fn}{\code{#3}}{\putwordon\ \code{#1}}% entry in function index - \begingroup - \defname{\defheaderxcond#2\relax$.$#3}{\putwordMethodon\ \code{#1}}% - \deftypefunargs{#4}% - \endgroup +\def\activeparens{% + \catcode`\(=\active \catcode`\)=\active + \catcode`\[=\active \catcode`\]=\active + \catcode`\&=\active } -% @deftypeivar CLASS TYPE VARNAME -% -\def\deftypeivar{% - \deftypemethparsebody\Edeftypeivar\deftypeivarx\deftypeivarheader} -% -% #1 is the class name, #2 the data type, #3 the variable name. -\def\deftypeivarheader#1#2#3{% - \dosubind{vr}{\code{#3}}{\putwordof\ \code{#1}}% entry in variable index - \begingroup - \defname{\defheaderxcond#2\relax$.$#3} - {\putwordInstanceVariableof\ \code{#1}}% - \defvarargs{#3}% - \endgroup -} +% Make control sequences which act like normal parenthesis chars. +\let\lparen = ( \let\rparen = ) -% @defmethod == @defop Method -% -\def\defmethod{\defmethparsebody\Edefmethod\defmethodx\defmethodheader} -% -% #1 is the class name, #2 the method name, #3 the args. -\def\defmethodheader#1#2#3{% - \dosubind{fn}{\code{#2}}{\putwordon\ \code{#1}}% entry in function index - \begingroup - \defname{#2}{\putwordMethodon\ \code{#1}}% - \defunargs{#3}% - \endgroup -} +% Be sure that we always have a definition for `(', etc. For example, +% if the fn name has parens in it, \boldbrax will not be in effect yet, +% so TeX would otherwise complain about undefined control sequence. +{ + \activeparens + \global\let(=\lparen \global\let)=\rparen + \global\let[=\lbrack \global\let]=\rbrack + \global\let& = \& -% @defcv {Class Option} foo-class foo-flag + \gdef\boldbrax{\let(=\opnr\let)=\clnr\let[=\lbrb\let]=\rbrb} + \gdef\magicamp{\let&=\amprm} +} -\def\defcv #1 {\def\defcvtype{#1}% -\defopvarparsebody\Edefcv\defcvx\defcvarheader\defcvtype} +\newcount\parencount -\def\defcvarheader #1#2#3{% -\dosubind {vr}{\code{#2}}{\putwordof\ #1}% Make entry in var index -\begingroup\defname {#2}{\defcvtype\ \putwordof\ #1}% -\defvarargs {#3}\endgroup % +% If we encounter &foo, then turn on ()-hacking afterwards +\newif\ifampseen +\def\amprm#1 {\ampseentrue{\bf\ }} + +\def\parenfont{% + \ifampseen + % At the first level, print parens in roman, + % otherwise use the default font. + \ifnum \parencount=1 \rm \fi + \else + % The \sf parens (in \boldbrax) actually are a little bolder than + % the contained text. This is especially needed for [ and ] . + \sf + \fi } - -% @defivar CLASS VARNAME == @defcv {Instance Variable} CLASS VARNAME -% -\def\defivar{\defvrparsebody\Edefivar\defivarx\defivarheader} -% -\def\defivarheader#1#2#3{% - \dosubind {vr}{\code{#2}}{\putwordof\ #1}% entry in var index - \begingroup - \defname{#2}{\putwordInstanceVariableof\ #1}% - \defvarargs{#3}% - \endgroup +\def\infirstlevel#1{% + \ifampseen + \ifnum\parencount=1 + #1% + \fi + \fi } +\def\bfafterword#1 {#1 \bf} -% @defvar -% First, define the processing that is wanted for arguments of @defvar. -% This is actually simple: just print them in roman. -% This must expand the args and terminate the paragraph they make up -\def\defvarargs #1{\normalparens #1% -\interlinepenalty=10000 -\endgraf\nobreak\vskip -\parskip\nobreak} - -% @defvr Counter foo-count - -\def\defvr{\defvrparsebody\Edefvr\defvrx\defvrheader} - -\def\defvrheader #1#2#3{\doind {vr}{\code{#2}}% -\begingroup\defname {#2}{#1}\defvarargs{#3}\endgroup} - -% @defvar == @defvr Variable - -\def\defvar{\defvarparsebody\Edefvar\defvarx\defvarheader} - -\def\defvarheader #1#2{\doind {vr}{\code{#1}}% Make entry in var index -\begingroup\defname {#1}{\putwordDefvar}% -\defvarargs {#2}\endgroup % +\def\opnr{% + \global\advance\parencount by 1 + {\parenfont(}% + \infirstlevel \bfafterword } - -% @defopt == @defvr {User Option} - -\def\defopt{\defvarparsebody\Edefopt\defoptx\defoptheader} - -\def\defoptheader #1#2{\doind {vr}{\code{#1}}% Make entry in var index -\begingroup\defname {#1}{\putwordDefopt}% -\defvarargs {#2}\endgroup % +\def\clnr{% + {\parenfont)}% + \infirstlevel \sl + \global\advance\parencount by -1 } -% @deftypevar int foobar - -\def\deftypevar{\defvarparsebody\Edeftypevar\deftypevarx\deftypevarheader} - -% #1 is the data type. #2 is the name, perhaps followed by text that -% is actually part of the data type, which should not be put into the index. -\def\deftypevarheader #1#2{% -\dovarind#2 \relax% Make entry in variables index -\begingroup\defname {\defheaderxcond#1\relax$.$#2}{\putwordDeftypevar}% -\interlinepenalty=10000 -\endgraf\nobreak\vskip -\parskip\nobreak -\endgroup} -\def\dovarind#1 #2\relax{\doind{vr}{\code{#1}}} - -% @deftypevr {Global Flag} int enable - -\def\deftypevr{\defvrparsebody\Edeftypevr\deftypevrx\deftypevrheader} - -\def\deftypevrheader #1#2#3{\dovarind#3 \relax% -\begingroup\defname {\defheaderxcond#2\relax$.$#3}{#1} -\interlinepenalty=10000 -\endgraf\nobreak\vskip -\parskip\nobreak -\endgroup} - -% Now define @deftp -% Args are printed in bold, a slight difference from @defvar. - -\def\deftpargs #1{\bf \defvarargs{#1}} - -% @deftp Class window height width ... - -\def\deftp{\deftpparsebody\Edeftp\deftpx\deftpheader} - -\def\deftpheader #1#2#3{\doind {tp}{\code{#2}}% -\begingroup\defname {#2}{#1}\deftpargs{#3}\endgroup} +\newcount\brackcount +\def\lbrb{% + \global\advance\brackcount by 1 + {\bf[}% +} +\def\rbrb{% + {\bf]}% + \global\advance\brackcount by -1 +} -% These definitions are used if you use @defunx (etc.) -% anywhere other than immediately after a @defun or @defunx. -% -\def\defcvx#1 {\errmessage{@defcvx in invalid context}} -\def\deffnx#1 {\errmessage{@deffnx in invalid context}} -\def\defivarx#1 {\errmessage{@defivarx in invalid context}} -\def\defmacx#1 {\errmessage{@defmacx in invalid context}} -\def\defmethodx#1 {\errmessage{@defmethodx in invalid context}} -\def\defoptx #1 {\errmessage{@defoptx in invalid context}} -\def\defopx#1 {\errmessage{@defopx in invalid context}} -\def\defspecx#1 {\errmessage{@defspecx in invalid context}} -\def\deftpx#1 {\errmessage{@deftpx in invalid context}} -\def\deftypefnx#1 {\errmessage{@deftypefnx in invalid context}} -\def\deftypefunx#1 {\errmessage{@deftypefunx in invalid context}} -\def\deftypeivarx#1 {\errmessage{@deftypeivarx in invalid context}} -\def\deftypemethodx#1 {\errmessage{@deftypemethodx in invalid context}} -\def\deftypeopx#1 {\errmessage{@deftypeopx in invalid context}} -\def\deftypevarx#1 {\errmessage{@deftypevarx in invalid context}} -\def\deftypevrx#1 {\errmessage{@deftypevrx in invalid context}} -\def\defunx#1 {\errmessage{@defunx in invalid context}} -\def\defvarx#1 {\errmessage{@defvarx in invalid context}} -\def\defvrx#1 {\errmessage{@defvrx in invalid context}} +\def\checkparencounts{% + \ifnum\parencount=0 \else \badparencount \fi + \ifnum\brackcount=0 \else \badbrackcount \fi +} +\def\badparencount{% + \errmessage{Unbalanced parentheses in @def}% + \global\parencount=0 +} +\def\badbrackcount{% + \errmessage{Unbalanced square braces in @def}% + \global\brackcount=0 +} \message{macros,} @@ -5176,28 +5443,42 @@ width0pt\relax} \fi % To do this right we need a feature of e-TeX, \scantokens, % which we arrange to emulate with a temporary file in ordinary TeX. \ifx\eTeXversion\undefined - \newwrite\macscribble - \def\scanmacro#1{% - \begingroup \newlinechar`\^^M - % Undo catcode changes of \startcontents and \doprintindex - \catcode`\@=0 \catcode`\\=12 \escapechar=`\@ - % Append \endinput to make sure that TeX does not see the ending newline. - \toks0={#1\endinput}% - \immediate\openout\macscribble=\jobname.tmp - \immediate\write\macscribble{\the\toks0}% - \immediate\closeout\macscribble - \let\xeatspaces\eatspaces - \input \jobname.tmp - \endgroup -} -\else -\def\scanmacro#1{% -\begingroup \newlinechar`\^^M -% Undo catcode changes of \startcontents and \doprintindex -\catcode`\@=0 \catcode`\\=12 \escapechar=`\@ -\let\xeatspaces\eatspaces\scantokens{#1\endinput}\endgroup} + \newwrite\macscribble + \def\scantokens#1{% + \toks0={#1}% + \immediate\openout\macscribble=\jobname.tmp + \immediate\write\macscribble{\the\toks0}% + \immediate\closeout\macscribble + \input \jobname.tmp + } \fi +\def\scanmacro#1{% + \begingroup + \newlinechar`\^^M + \let\xeatspaces\eatspaces + % Undo catcode changes of \startcontents and \doprintindex + % When called from @insertcopying or (short)caption, we need active + % backslash to get it printed correctly. Previously, we had + % \catcode`\\=\other instead. We'll see whether a problem appears + % with macro expansion. --kasal, 19aug04 + \catcode`\@=0 \catcode`\\=\active \escapechar=`\@ + % ... and \example + \spaceisspace + % + % Append \endinput to make sure that TeX does not see the ending newline. + % + % I've verified that it is necessary both for e-TeX and for ordinary TeX + % --kasal, 29nov03 + \scantokens{#1\endinput}% + \endgroup +} + +\def\scanexp#1{% + \edef\temp{\noexpand\scanmacro{#1}}% + \temp +} + \newcount\paramno % Count of parameters \newtoks\macname % Macro name \newif\ifrecursive % Is it recursive? @@ -5205,13 +5486,15 @@ width0pt\relax} \fi % \do\macro1\do\macro2... % Utility routines. -% Thisdoes \let #1 = #2, except with \csnames. +% This does \let #1 = #2, with \csnames; that is, +% \let \csname#1\endcsname = \csname#2\endcsname +% (except of course we have to play expansion games). +% \def\cslet#1#2{% -\expandafter\expandafter -\expandafter\let -\expandafter\expandafter -\csname#1\endcsname -\csname#2\endcsname} + \expandafter\let + \csname#1\expandafter\endcsname + \csname#2\endcsname +} % Trim leading and trailing spaces off a string. % Concepts from aro-bend problem 15 (see CTAN). @@ -5224,7 +5507,7 @@ width0pt\relax} \fi } % Trim a single trailing ^^M off a string. -{\catcode`\^^M=12\catcode`\Q=3% +{\catcode`\^^M=\other \catcode`\Q=3% \gdef\eatcr #1{\eatcra #1Q^^MQ}% \gdef\eatcra#1^^MQ{\eatcrb#1Q}% \gdef\eatcrb#1Q#2Q{#1}% @@ -5238,30 +5521,36 @@ width0pt\relax} \fi % done by making ^^M (\endlinechar) catcode 12 when reading the macro % body, and then making it the \newlinechar in \scanmacro. +\def\scanctxt{% + \catcode`\"=\other + \catcode`\+=\other + \catcode`\<=\other + \catcode`\>=\other + \catcode`\@=\other + \catcode`\^=\other + \catcode`\_=\other + \catcode`\|=\other + \catcode`\~=\other +} + +\def\scanargctxt{% + \scanctxt + \catcode`\\=\other + \catcode`\^^M=\other +} + \def\macrobodyctxt{% - \catcode`\~=12 - \catcode`\^=12 - \catcode`\_=12 - \catcode`\|=12 - \catcode`\<=12 - \catcode`\>=12 - \catcode`\+=12 - \catcode`\{=12 - \catcode`\}=12 - \catcode`\@=12 - \catcode`\^^M=12 - \usembodybackslash} + \scanctxt + \catcode`\{=\other + \catcode`\}=\other + \catcode`\^^M=\other + \usembodybackslash +} \def\macroargctxt{% - \catcode`\~=12 - \catcode`\^=12 - \catcode`\_=12 - \catcode`\|=12 - \catcode`\<=12 - \catcode`\>=12 - \catcode`\+=12 - \catcode`\@=12 - \catcode`\\=12} + \scanctxt + \catcode`\\=\other +} % \mbodybackslash is the definition of \ in @macro bodies. % It maps \foo\ => \csname macarg.foo\endcsname => #N @@ -5302,32 +5591,32 @@ width0pt\relax} \fi \else \expandafter\parsemacbody \fi} -\def\unmacro{\parsearg\unmacroxxx} -\def\unmacroxxx#1{% +\parseargdef\unmacro{% \if1\csname ismacro.#1\endcsname \global\cslet{#1}{macsave.#1}% \global\expandafter\let \csname ismacro.#1\endcsname=0% - % Remove the macro name from \macrolist + % Remove the macro name from \macrolist: \begingroup - \edef\tempa{\expandafter\noexpand\csname#1\endcsname}% - \def\do##1{% - \def\tempb{##1}% - \ifx\tempa\tempb - % remove this - \else - \toks0 = \expandafter{\newmacrolist\do}% - \edef\newmacrolist{\the\toks0\expandafter\noexpand\tempa}% - \fi}% - \def\newmacrolist{}% - % Execute macro list to define \newmacrolist - \macrolist - \global\let\macrolist\newmacrolist + \expandafter\let\csname#1\endcsname \relax + \let\do\unmacrodo + \xdef\macrolist{\macrolist}% \endgroup \else \errmessage{Macro #1 not defined}% \fi } +% Called by \do from \dounmacro on each macro. The idea is to omit any +% macro definitions that have been changed to \relax. +% +\def\unmacrodo#1{% + \ifx#1\relax + % remove this + \else + \noexpand\do \noexpand #1% + \fi +} + % This makes use of the obscure feature that if the last token of a % <parameter list> is #, then the preceding argument is delimited by % an opening brace, and that opening brace is not consumed. @@ -5443,25 +5732,41 @@ width0pt\relax} \fi \expandafter\parsearg \fi \next} -% We mant to disable all macros during \shipout so that they are not +% We want to disable all macros during \shipout so that they are not % expanded by \write. \def\turnoffmacros{\begingroup \def\do##1{\let\noexpand##1=\relax}% \edef\next{\macrolist}\expandafter\endgroup\next} +% For \indexnofonts, we need to get rid of all macros, leaving only the +% arguments (if present). Of course this is not nearly correct, but it +% is the best we can do for now. makeinfo does not expand macros in the +% argument to @deffn, which ends up writing an index entry, and texindex +% isn't prepared for an index sort entry that starts with \. +% +% Since macro invocations are followed by braces, we can just redefine them +% to take a single TeX argument. The case of a macro invocation that +% goes to end-of-line is not handled. +% +\def\emptyusermacros{\begingroup + \def\do##1{\let\noexpand##1=\noexpand\asis}% + \edef\next{\macrolist}\expandafter\endgroup\next} + % @alias. % We need some trickery to remove the optional spaces around the equal % sign. Just make them active and then expand them all to nothing. -\def\alias{\begingroup\obeyspaces\parsearg\aliasxxx} +\def\alias{\parseargusing\obeyspaces\aliasxxx} \def\aliasxxx #1{\aliasyyy#1\relax} -\def\aliasyyy #1=#2\relax{\ignoreactivespaces -\edef\next{\global\let\expandafter\noexpand\csname#1\endcsname=% - \expandafter\noexpand\csname#2\endcsname}% -\expandafter\endgroup\next} +\def\aliasyyy #1=#2\relax{% + {% + \expandafter\let\obeyedspace=\empty + \xdef\next{\global\let\makecsname{#1}=\makecsname{#2}}% + }% + \next +} \message{cross references,} -% @xref etc. \newwrite\auxfile @@ -5473,56 +5778,70 @@ width0pt\relax} \fi \def\inforefzzz #1,#2,#3,#4**{\putwordSee{} \putwordInfo{} \putwordfile{} \file{\ignorespaces #3{}}, node \samp{\ignorespaces#1{}}} -% @node's job is to define \lastnode. -\def\node{\ENVcheck\parsearg\nodezzz} -\def\nodezzz#1{\nodexxx [#1,]} -\def\nodexxx[#1,#2]{\gdef\lastnode{#1}} +% @node's only job in TeX is to define \lastnode, which is used in +% cross-references. The @node line might or might not have commas, and +% might or might not have spaces before the first comma, like: +% @node foo , bar , ... +% We don't want such trailing spaces in the node name. +% +\parseargdef\node{\checkenv{}\donode #1 ,\finishnodeparse} +% +% also remove a trailing comma, in case of something like this: +% @node Help-Cross, , , Cross-refs +\def\donode#1 ,#2\finishnodeparse{\dodonode #1,\finishnodeparse} +\def\dodonode#1,#2\finishnodeparse{\gdef\lastnode{#1}} + \let\nwnode=\node -\let\lastnode=\relax - -% The sectioning commands (@chapter, etc.) call these. -\def\donoderef{% - \ifx\lastnode\relax\else - \expandafter\expandafter\expandafter\setref{\lastnode}% - {Ysectionnumberandtype}% - \global\let\lastnode=\relax - \fi -} -\def\unnumbnoderef{% - \ifx\lastnode\relax\else - \expandafter\expandafter\expandafter\setref{\lastnode}{Ynothing}% - \global\let\lastnode=\relax - \fi -} -\def\appendixnoderef{% - \ifx\lastnode\relax\else - \expandafter\expandafter\expandafter\setref{\lastnode}% - {Yappendixletterandtype}% - \global\let\lastnode=\relax +\let\lastnode=\empty + +% Write a cross-reference definition for the current node. #1 is the +% type (Ynumbered, Yappendix, Ynothing). +% +\def\donoderef#1{% + \ifx\lastnode\empty\else + \setref{\lastnode}{#1}% + \global\let\lastnode=\empty \fi } - % @anchor{NAME} -- define xref target at arbitrary point. % \newcount\savesfregister -\gdef\savesf{\relax \ifhmode \savesfregister=\spacefactor \fi} -\gdef\restoresf{\relax \ifhmode \spacefactor=\savesfregister \fi} -\gdef\anchor#1{\savesf \setref{#1}{Ynothing}\restoresf \ignorespaces} - -% \setref{NAME}{SNT} defines a cross-reference point NAME, namely -% NAME-title, NAME-pg, and NAME-SNT. Called from \foonoderef. We have -% to set \indexdummies so commands such as @code in a section title -% aren't expanded. It would be nicer not to expand the titles in the -% first place, but there's so many layers that that is hard to do. -% -\def\setref#1#2{{% - \indexdummies +% +\def\savesf{\relax \ifhmode \savesfregister=\spacefactor \fi} +\def\restoresf{\relax \ifhmode \spacefactor=\savesfregister \fi} +\def\anchor#1{\savesf \setref{#1}{Ynothing}\restoresf \ignorespaces} + +% \setref{NAME}{SNT} defines a cross-reference point NAME (a node or an +% anchor), which consists of three parts: +% 1) NAME-title - the current sectioning name taken from \thissection, +% or the anchor name. +% 2) NAME-snt - section number and type, passed as the SNT arg, or +% empty for anchors. +% 3) NAME-pg - the page number. +% +% This is called from \donoderef, \anchor, and \dofloat. In the case of +% floats, there is an additional part, which is not written here: +% 4) NAME-lof - the text as it should appear in a @listoffloats. +% +\def\setref#1#2{% \pdfmkdest{#1}% - \dosetq{#1-title}{Ytitle}% - \dosetq{#1-pg}{Ypagenumber}% - \dosetq{#1-snt}{#2}% -}} + \iflinks + {% + \atdummies % preserve commands, but don't expand them + \turnoffactive + \otherbackslash + \edef\writexrdef##1##2{% + \write\auxfile{@xrdef{#1-% #1 of \setref, expanded by the \edef + ##1}{##2}}% these are parameters of \writexrdef + }% + \toks0 = \expandafter{\thissection}% + \immediate \writexrdef{title}{\the\toks0 }% + \immediate \writexrdef{snt}{\csname #2\endcsname}% \Ynumbered etc. + \writexrdef{pg}{\folio}% will be written later, during \shipout + }% + \fi +} % @xref, @pxref, and @ref generate cross-references. For \xrefX, #1 is % the node name, #2 the name of the Info cross-reference, #3 the printed @@ -5535,137 +5854,156 @@ width0pt\relax} \fi \def\xrefX[#1,#2,#3,#4,#5,#6]{\begingroup \unsepspaces \def\printedmanual{\ignorespaces #5}% - \def\printednodename{\ignorespaces #3}% - \setbox1=\hbox{\printedmanual}% - \setbox0=\hbox{\printednodename}% + \def\printedrefname{\ignorespaces #3}% + \setbox1=\hbox{\printedmanual\unskip}% + \setbox0=\hbox{\printedrefname\unskip}% \ifdim \wd0 = 0pt % No printed node name was explicitly given. \expandafter\ifx\csname SETxref-automatic-section-title\endcsname\relax % Use the node name inside the square brackets. - \def\printednodename{\ignorespaces #1}% + \def\printedrefname{\ignorespaces #1}% \else % Use the actual chapter/section title appear inside % the square brackets. Use the real section title if we have it. \ifdim \wd1 > 0pt % It is in another manual, so we don't have it. - \def\printednodename{\ignorespaces #1}% + \def\printedrefname{\ignorespaces #1}% \else \ifhavexrefs % We know the real title if we have the xref values. - \def\printednodename{\refx{#1-title}{}}% + \def\printedrefname{\refx{#1-title}{}}% \else % Otherwise just copy the Info node name. - \def\printednodename{\ignorespaces #1}% + \def\printedrefname{\ignorespaces #1}% \fi% \fi \fi \fi % - % If we use \unhbox0 and \unhbox1 to print the node names, TeX does not - % insert empty discretionaries after hyphens, which means that it will - % not find a line break at a hyphen in a node names. Since some manuals - % are best written with fairly long node names, containing hyphens, this - % is a loss. Therefore, we give the text of the node name again, so it - % is as if TeX is seeing it for the first time. + % Make link in pdf output. \ifpdf \leavevmode \getfilename{#4}% - {\normalturnoffactive + {\turnoffactive \otherbackslash \ifnum\filenamelength>0 \startlink attr{/Border [0 0 0]}% goto file{\the\filename.pdf} name{#1}% \else \startlink attr{/Border [0 0 0]}% - goto name{#1}% + goto name{\pdfmkpgn{#1}}% \fi }% \linkcolor \fi % - \ifdim \wd1 > 0pt - \putwordsection{} ``\printednodename'' \putwordin{} \cite{\printedmanual}% + % Float references are printed completely differently: "Figure 1.2" + % instead of "[somenode], p.3". We distinguish them by the + % LABEL-title being set to a magic string. + {% + % Have to otherify everything special to allow the \csname to + % include an _ in the xref name, etc. + \indexnofonts + \turnoffactive + \otherbackslash + \expandafter\global\expandafter\let\expandafter\Xthisreftitle + \csname XR#1-title\endcsname + }% + \iffloat\Xthisreftitle + % If the user specified the print name (third arg) to the ref, + % print it instead of our usual "Figure 1.2". + \ifdim\wd0 = 0pt + \refx{#1-snt}% + \else + \printedrefname + \fi + % + % if the user also gave the printed manual name (fifth arg), append + % "in MANUALNAME". + \ifdim \wd1 > 0pt + \space \putwordin{} \cite{\printedmanual}% + \fi \else - % _ (for example) has to be the character _ for the purposes of the - % control sequence corresponding to the node, but it has to expand - % into the usual \leavevmode...\vrule stuff for purposes of - % printing. So we \turnoffactive for the \refx-snt, back on for the - % printing, back off for the \refx-pg. - {\normalturnoffactive - % Only output a following space if the -snt ref is nonempty; for - % @unnumbered and @anchor, it won't be. - \setbox2 = \hbox{\ignorespaces \refx{#1-snt}{}}% - \ifdim \wd2 > 0pt \refx{#1-snt}\space\fi - }% - % [mynode], - [\printednodename],\space - % page 3 - \turnoffactive \putwordpage\tie\refx{#1-pg}{}% + % node/anchor (non-float) references. + % + % If we use \unhbox0 and \unhbox1 to print the node names, TeX does not + % insert empty discretionaries after hyphens, which means that it will + % not find a line break at a hyphen in a node names. Since some manuals + % are best written with fairly long node names, containing hyphens, this + % is a loss. Therefore, we give the text of the node name again, so it + % is as if TeX is seeing it for the first time. + \ifdim \wd1 > 0pt + \putwordsection{} ``\printedrefname'' \putwordin{} \cite{\printedmanual}% + \else + % _ (for example) has to be the character _ for the purposes of the + % control sequence corresponding to the node, but it has to expand + % into the usual \leavevmode...\vrule stuff for purposes of + % printing. So we \turnoffactive for the \refx-snt, back on for the + % printing, back off for the \refx-pg. + {\turnoffactive \otherbackslash + % Only output a following space if the -snt ref is nonempty; for + % @unnumbered and @anchor, it won't be. + \setbox2 = \hbox{\ignorespaces \refx{#1-snt}{}}% + \ifdim \wd2 > 0pt \refx{#1-snt}\space\fi + }% + % output the `[mynode]' via a macro so it can be overridden. + \xrefprintnodename\printedrefname + % + % But we always want a comma and a space: + ,\space + % + % output the `page 3'. + \turnoffactive \otherbackslash \putwordpage\tie\refx{#1-pg}{}% + \fi \fi \endlink \endgroup} -% \dosetq is the interface for calls from other macros - -% Use \normalturnoffactive so that punctuation chars such as underscore -% and backslash work in node names. (\turnoffactive doesn't do \.) -\def\dosetq#1#2{% - {\let\folio=0% - \normalturnoffactive - \edef\next{\write\auxfile{\internalsetq{#1}{#2}}}% - \iflinks - \next - \fi - }% -} - -% \internalsetq {foo}{page} expands into -% CHARACTERS 'xrdef {foo}{...expansion of \Ypage...} -% When the aux file is read, ' is the escape character - -\def\internalsetq #1#2{'xrdef {#1}{\csname #2\endcsname}} - -% Things to be expanded by \internalsetq - -\def\Ypagenumber{\folio} - -\def\Ytitle{\thissection} - -\def\Ynothing{} - -\def\Ysectionnumberandtype{% -\ifnum\secno=0 \putwordChapter\xreftie\the\chapno % -\else \ifnum \subsecno=0 \putwordSection\xreftie\the\chapno.\the\secno % -\else \ifnum \subsubsecno=0 % -\putwordSection\xreftie\the\chapno.\the\secno.\the\subsecno % -\else % -\putwordSection\xreftie\the\chapno.\the\secno.\the\subsecno.\the\subsubsecno % -\fi \fi \fi } - -\def\Yappendixletterandtype{% -\ifnum\secno=0 \putwordAppendix\xreftie'char\the\appendixno{}% -\else \ifnum \subsecno=0 \putwordSection\xreftie'char\the\appendixno.\the\secno % -\else \ifnum \subsubsecno=0 % -\putwordSection\xreftie'char\the\appendixno.\the\secno.\the\subsecno % -\else % -\putwordSection\xreftie'char\the\appendixno.\the\secno.\the\subsecno.\the\subsubsecno % -\fi \fi \fi } - -\gdef\xreftie{'tie} +% This macro is called from \xrefX for the `[nodename]' part of xref +% output. It's a separate macro only so it can be changed more easily, +% since square brackets don't work well in some documents. Particularly +% one that Bob is working on :). +% +\def\xrefprintnodename#1{[#1]} -% Use TeX 3.0's \inputlineno to get the line number, for better error -% messages, but if we're using an old version of TeX, don't do anything. +% Things referred to by \setref. % -\ifx\inputlineno\thisisundefined - \let\linenumber = \empty % Non-3.0. -\else - \def\linenumber{\the\inputlineno:\space} -\fi +\def\Ynothing{} +\def\Yomitfromtoc{} +\def\Ynumbered{% + \ifnum\secno=0 + \putwordChapter@tie \the\chapno + \else \ifnum\subsecno=0 + \putwordSection@tie \the\chapno.\the\secno + \else \ifnum\subsubsecno=0 + \putwordSection@tie \the\chapno.\the\secno.\the\subsecno + \else + \putwordSection@tie \the\chapno.\the\secno.\the\subsecno.\the\subsubsecno + \fi\fi\fi +} +\def\Yappendix{% + \ifnum\secno=0 + \putwordAppendix@tie @char\the\appendixno{}% + \else \ifnum\subsecno=0 + \putwordSection@tie @char\the\appendixno.\the\secno + \else \ifnum\subsubsecno=0 + \putwordSection@tie @char\the\appendixno.\the\secno.\the\subsecno + \else + \putwordSection@tie + @char\the\appendixno.\the\secno.\the\subsecno.\the\subsubsecno + \fi\fi\fi +} % Define \refx{NAME}{SUFFIX} to reference a cross-reference string named NAME. % If its value is nonempty, SUFFIX is output afterward. - +% \def\refx#1#2{% - \expandafter\ifx\csname X#1\endcsname\relax + {% + \indexnofonts + \otherbackslash + \expandafter\global\expandafter\let\expandafter\thisrefX + \csname XR#1\endcsname + }% + \ifx\thisrefX\relax % If not defined, say something at least. \angleleft un\-de\-fined\angleright \iflinks @@ -5680,21 +6018,49 @@ width0pt\relax} \fi \fi \else % It's defined, so just use it. - \csname X#1\endcsname + \thisrefX \fi #2% Output the suffix in any case. } -% This is the macro invoked by entries in the aux file. +% This is the macro invoked by entries in the aux file. Usually it's +% just a \def (we prepend XR to the control sequence name to avoid +% collisions). But if this is a float type, we have more work to do. % -\def\xrdef#1{\begingroup - % Reenable \ as an escape while reading the second argument. - \catcode`\\ = 0 - \afterassignment\endgroup - \expandafter\gdef\csname X#1\endcsname +\def\xrdef#1#2{% + \expandafter\gdef\csname XR#1\endcsname{#2}% remember this xref value. + % + % Was that xref control sequence that we just defined for a float? + \expandafter\iffloat\csname XR#1\endcsname + % it was a float, and we have the (safe) float type in \iffloattype. + \expandafter\let\expandafter\floatlist + \csname floatlist\iffloattype\endcsname + % + % Is this the first time we've seen this float type? + \expandafter\ifx\floatlist\relax + \toks0 = {\do}% yes, so just \do + \else + % had it before, so preserve previous elements in list. + \toks0 = \expandafter{\floatlist\do}% + \fi + % + % Remember this xref in the control sequence \floatlistFLOATTYPE, + % for later use in \listoffloats. + \expandafter\xdef\csname floatlist\iffloattype\endcsname{\the\toks0{#1}}% + \fi } % Read the last existing aux file, if any. No error if none exists. +% +\def\tryauxfile{% + \openin 1 \jobname.aux + \ifeof 1 \else + \readauxfile + \global\havexrefstrue + \fi + \closein 1 +} + \def\readauxfile{\begingroup \catcode`\^^@=\other \catcode`\^^A=\other @@ -5723,9 +6089,7 @@ width0pt\relax} \fi \catcode`\^^]=\other \catcode`\^^^=\other \catcode`\^^_=\other - \catcode`\@=\other - \catcode`\^=\other - % It was suggested to define this as 7, which would allow ^^e4 etc. + % It was suggested to set the catcode of ^ to 7, which would allow ^^e4 etc. % in xref tags, i.e., node names. But since ^^e4 notation isn't % supported in the main text, it doesn't seem desirable. Furthermore, % that is not enough: for node names that actually contain a ^ @@ -5738,6 +6102,9 @@ width0pt\relax} \fi % \def\auxhat{\def^{'hat }}% extra space so ok if followed by letter % and then to call \auxhat in \setq. % + \catcode`\^=\other + % + % Special characters. Should be turned off anyway, but... \catcode`\~=\other \catcode`\[=\other \catcode`\]=\other @@ -5749,8 +6116,19 @@ width0pt\relax} \fi \catcode`\$=\other \catcode`\#=\other \catcode`\&=\other + \catcode`\%=\other \catcode`+=\other % avoid \+ for paranoia even though we've turned it off - % Make the characters 128-255 be printing characters + % + % This is to support \ in node names and titles, since the \ + % characters end up in a \csname. It's easier than + % leaving it active and making its active definition an actual \ + % character. What I don't understand is why it works in the *value* + % of the xrdef. Seems like it should be a catcode12 \, and that + % should not typeset properly. But it works, so I'm moving on for + % now. --karl, 15jan04. + \catcode`\\=\other + % + % Make the characters 128-255 be printing characters. {% \count 1=128 \def\loop{% @@ -5759,31 +6137,18 @@ width0pt\relax} \fi \ifnum \count 1<256 \loop \fi }% }% - % The aux file uses ' as the escape (for now). - % Turn off \ as an escape so we do not lose on - % entries which were dumped with control sequences in their names. - % For example, 'xrdef {$\leq $-fun}{page ...} made by @defun ^^ - % Reference to such entries still does not work the way one would wish, - % but at least they do not bomb out when the aux file is read in. + % + % @ is our escape character in .aux files, and we need braces. \catcode`\{=1 \catcode`\}=2 - \catcode`\%=\other - \catcode`\'=0 - \catcode`\\=\other + \catcode`\@=0 % - \openin 1 \jobname.aux - \ifeof 1 \else - \closein 1 - \input \jobname.aux - \global\havexrefstrue - \global\warnedobstrue - \fi - % Open the new aux file. TeX will close it automatically at exit. - \openout\auxfile=\jobname.aux + \input \jobname.aux \endgroup} -% Footnotes. +\message{insertions,} +% including footnotes. \newcount \footnoteno @@ -5797,37 +6162,39 @@ width0pt\relax} \fi % @footnotestyle is meaningful for info output only. \let\footnotestyle=\comment -\let\ptexfootnote=\footnote - {\catcode `\@=11 % % Auto-number footnotes. Otherwise like plain. \gdef\footnote{% + \let\indent=\ptexindent + \let\noindent=\ptexnoindent \global\advance\footnoteno by \@ne \edef\thisfootno{$^{\the\footnoteno}$}% % % In case the footnote comes at the end of a sentence, preserve the % extra spacing after we do the footnote number. \let\@sf\empty - \ifhmode\edef\@sf{\spacefactor\the\spacefactor}\/\fi + \ifhmode\edef\@sf{\spacefactor\the\spacefactor}\ptexslash\fi % % Remove inadvertent blank space before typesetting the footnote number. \unskip \thisfootno\@sf - \footnotezzz + \dofootnote }% % Don't bother with the trickery in plain.tex to not require the % footnote text as a parameter. Our footnotes don't need to be so general. % -% Oh yes, they do; otherwise, @ifset and anything else that uses -% \parseargline fail inside footnotes because the tokens are fixed when +% Oh yes, they do; otherwise, @ifset (and anything else that uses +% \parseargline) fails inside footnotes because the tokens are fixed when % the footnote is read. --karl, 16nov96. % -\long\gdef\footnotezzz{\insert\footins\bgroup +\gdef\dofootnote{% + \insert\footins\bgroup % We want to typeset this text as a normal paragraph, even if the % footnote reference occurs in (for example) a display environment. % So reset some parameters. + \hsize=\pagewidth \interlinepenalty\interfootnotelinepenalty \splittopskip\ht\strutbox % top baseline for broken footnotes \splitmaxdepth\dp\strutbox @@ -5857,48 +6224,68 @@ width0pt\relax} \fi \footstrut \futurelet\next\fo@t } -\def\fo@t{\ifcat\bgroup\noexpand\next \let\next\f@@t - \else\let\next\f@t\fi \next} -\def\f@@t{\bgroup\aftergroup\@foot\let\next} -\def\f@t#1{#1\@foot} -\def\@foot{\strut\par\egroup} - }%end \catcode `\@=11 -% @| inserts a changebar to the left of the current line. It should -% surround any changed text. This approach does *not* work if the -% change spans more than two lines of output. To handle that, we would -% have adopt a much more difficult approach (putting marks into the main -% vertical list for the beginning and end of each change). +% In case a @footnote appears in a vbox, save the footnote text and create +% the real \insert just after the vbox finished. Otherwise, the insertion +% would be lost. +% Similarily, if a @footnote appears inside an alignment, save the footnote +% text to a box and make the \insert when a row of the table is finished. +% And the same can be done for other insert classes. --kasal, 16nov03. + +% Replace the \insert primitive by a cheating macro. +% Deeper inside, just make sure that the saved insertions are not spilled +% out prematurely. % -\def\|{% - % \vadjust can only be used in horizontal mode. - \leavevmode - % - % Append this vertical mode material after the current line in the output. - \vadjust{% - % We want to insert a rule with the height and depth of the current - % leading; that is exactly what \strutbox is supposed to record. - \vskip-\baselineskip - % - % \vadjust-items are inserted at the left edge of the type. So - % the \llap here moves out into the left-hand margin. - \llap{% - % - % For a thicker or thinner bar, change the `1pt'. - \vrule height\baselineskip width1pt - % - % This is the space between the bar and the text. - \hskip 12pt - }% - }% +\def\startsavinginserts{% + \ifx \insert\ptexinsert + \let\insert\saveinsert + \else + \let\checkinserts\relax + \fi } -% For a final copy, take out the rectangles -% that mark overfull boxes (in case you have decided -% that the text looks ok even though it passes the margin). +% This \insert replacement works for both \insert\footins{foo} and +% \insert\footins\bgroup foo\egroup, but it doesn't work for \insert27{foo}. % -\def\finalout{\overfullrule=0pt} +\def\saveinsert#1{% + \edef\next{\noexpand\savetobox \makeSAVEname#1}% + \afterassignment\next + % swallow the left brace + \let\temp = +} +\def\makeSAVEname#1{\makecsname{SAVE\expandafter\gobble\string#1}} +\def\savetobox#1{\global\setbox#1 = \vbox\bgroup \unvbox#1} + +\def\checksaveins#1{\ifvoid#1\else \placesaveins#1\fi} + +\def\placesaveins#1{% + \ptexinsert \csname\expandafter\gobblesave\string#1\endcsname + {\box#1}% +} + +% eat @SAVE -- beware, all of them have catcode \other: +{ + \def\dospecials{\do S\do A\do V\do E} \uncatcodespecials % ;-) + \gdef\gobblesave @SAVE{} +} + +% initialization: +\def\newsaveins #1{% + \edef\next{\noexpand\newsaveinsX \makeSAVEname#1}% + \next +} +\def\newsaveinsX #1{% + \csname newbox\endcsname #1% + \expandafter\def\expandafter\checkinserts\expandafter{\checkinserts + \checksaveins #1}% +} + +% initialize: +\let\checkinserts\empty +\newsaveins\footins +\newsaveins\margin + % @image. We use the macros from epsf.tex to support this. % If epsf.tex is not installed and @image is used, we complain. @@ -5908,12 +6295,12 @@ width0pt\relax} \fi % undone and the next image would fail. \openin 1 = epsf.tex \ifeof 1 \else - \closein 1 - % Do not bother showing banner with post-v2.7 epsf.tex (available in - % doc/epsf.tex until it shows up on ctan). + % Do not bother showing banner with epsf.tex v2.7k (available in + % doc/epsf.tex and on ctan). \def\epsfannounce{\toks0 = }% \input epsf.tex \fi +\closein 1 % % We will only complain once about lack of epsf.tex. \newif\ifwarnednoepsf @@ -5949,7 +6336,7 @@ width0pt\relax} \fi \nobreak\bigskip % Usually we'll have text after the image which will insert % \parskip glue, so insert it here too to equalize the space - % above and below. + % above and below. \nobreak\vskip\parskip \nobreak \line\bgroup\hss @@ -5969,6 +6356,269 @@ width0pt\relax} \fi \endgroup} +% @float FLOATTYPE,LABEL,LOC ... @end float for displayed figures, tables, +% etc. We don't actually implement floating yet, we always include the +% float "here". But it seemed the best name for the future. +% +\envparseargdef\float{\eatcommaspace\eatcommaspace\dofloat#1, , ,\finish} + +% There may be a space before second and/or third parameter; delete it. +\def\eatcommaspace#1, {#1,} + +% #1 is the optional FLOATTYPE, the text label for this float, typically +% "Figure", "Table", "Example", etc. Can't contain commas. If omitted, +% this float will not be numbered and cannot be referred to. +% +% #2 is the optional xref label. Also must be present for the float to +% be referable. +% +% #3 is the optional positioning argument; for now, it is ignored. It +% will somehow specify the positions allowed to float to (here, top, bottom). +% +% We keep a separate counter for each FLOATTYPE, which we reset at each +% chapter-level command. +\let\resetallfloatnos=\empty +% +\def\dofloat#1,#2,#3,#4\finish{% + \let\thiscaption=\empty + \let\thisshortcaption=\empty + % + % don't lose footnotes inside @float. + % + % BEWARE: when the floats start float, we have to issue warning whenever an + % insert appears inside a float which could possibly float. --kasal, 26may04 + % + \startsavinginserts + % + % We can't be used inside a paragraph. + \par + % + \vtop\bgroup + \def\floattype{#1}% + \def\floatlabel{#2}% + \def\floatloc{#3}% we do nothing with this yet. + % + \ifx\floattype\empty + \let\safefloattype=\empty + \else + {% + % the floattype might have accents or other special characters, + % but we need to use it in a control sequence name. + \indexnofonts + \turnoffactive + \xdef\safefloattype{\floattype}% + }% + \fi + % + % If label is given but no type, we handle that as the empty type. + \ifx\floatlabel\empty \else + % We want each FLOATTYPE to be numbered separately (Figure 1, + % Table 1, Figure 2, ...). (And if no label, no number.) + % + \expandafter\getfloatno\csname\safefloattype floatno\endcsname + \global\advance\floatno by 1 + % + {% + % This magic value for \thissection is output by \setref as the + % XREFLABEL-title value. \xrefX uses it to distinguish float + % labels (which have a completely different output format) from + % node and anchor labels. And \xrdef uses it to construct the + % lists of floats. + % + \edef\thissection{\floatmagic=\safefloattype}% + \setref{\floatlabel}{Yfloat}% + }% + \fi + % + % start with \parskip glue, I guess. + \vskip\parskip + % + % Don't suppress indentation if a float happens to start a section. + \restorefirstparagraphindent +} + +% we have these possibilities: +% @float Foo,lbl & @caption{Cap}: Foo 1.1: Cap +% @float Foo,lbl & no caption: Foo 1.1 +% @float Foo & @caption{Cap}: Foo: Cap +% @float Foo & no caption: Foo +% @float ,lbl & Caption{Cap}: 1.1: Cap +% @float ,lbl & no caption: 1.1 +% @float & @caption{Cap}: Cap +% @float & no caption: +% +\def\Efloat{% + \let\floatident = \empty + % + % In all cases, if we have a float type, it comes first. + \ifx\floattype\empty \else \def\floatident{\floattype}\fi + % + % If we have an xref label, the number comes next. + \ifx\floatlabel\empty \else + \ifx\floattype\empty \else % if also had float type, need tie first. + \appendtomacro\floatident{\tie}% + \fi + % the number. + \appendtomacro\floatident{\chaplevelprefix\the\floatno}% + \fi + % + % Start the printed caption with what we've constructed in + % \floatident, but keep it separate; we need \floatident again. + \let\captionline = \floatident + % + \ifx\thiscaption\empty \else + \ifx\floatident\empty \else + \appendtomacro\captionline{: }% had ident, so need a colon between + \fi + % + % caption text. + \appendtomacro\captionline{\scanexp\thiscaption}% + \fi + % + % If we have anything to print, print it, with space before. + % Eventually this needs to become an \insert. + \ifx\captionline\empty \else + \vskip.5\parskip + \captionline + % + % Space below caption. + \vskip\parskip + \fi + % + % If have an xref label, write the list of floats info. Do this + % after the caption, to avoid chance of it being a breakpoint. + \ifx\floatlabel\empty \else + % Write the text that goes in the lof to the aux file as + % \floatlabel-lof. Besides \floatident, we include the short + % caption if specified, else the full caption if specified, else nothing. + {% + \atdummies \turnoffactive \otherbackslash + % since we read the caption text in the macro world, where ^^M + % is turned into a normal character, we have to scan it back, so + % we don't write the literal three characters "^^M" into the aux file. + \scanexp{% + \xdef\noexpand\gtemp{% + \ifx\thisshortcaption\empty + \thiscaption + \else + \thisshortcaption + \fi + }% + }% + \immediate\write\auxfile{@xrdef{\floatlabel-lof}{\floatident + \ifx\gtemp\empty \else : \gtemp \fi}}% + }% + \fi + \egroup % end of \vtop + % + % place the captured inserts + % + % BEWARE: when the floats start float, we have to issue warning whenever an + % insert appears inside a float which could possibly float. --kasal, 26may04 + % + \checkinserts +} + +% Append the tokens #2 to the definition of macro #1, not expanding either. +% +\def\appendtomacro#1#2{% + \expandafter\def\expandafter#1\expandafter{#1#2}% +} + +% @caption, @shortcaption +% +\def\caption{\docaption\thiscaption} +\def\shortcaption{\docaption\thisshortcaption} +\def\docaption{\checkenv\float \bgroup\scanargctxt\defcaption} +\def\defcaption#1#2{\egroup \def#1{#2}} + +% The parameter is the control sequence identifying the counter we are +% going to use. Create it if it doesn't exist and assign it to \floatno. +\def\getfloatno#1{% + \ifx#1\relax + % Haven't seen this figure type before. + \csname newcount\endcsname #1% + % + % Remember to reset this floatno at the next chap. + \expandafter\gdef\expandafter\resetallfloatnos + \expandafter{\resetallfloatnos #1=0 }% + \fi + \let\floatno#1% +} + +% \setref calls this to get the XREFLABEL-snt value. We want an @xref +% to the FLOATLABEL to expand to "Figure 3.1". We call \setref when we +% first read the @float command. +% +\def\Yfloat{\floattype@tie \chaplevelprefix\the\floatno}% + +% Magic string used for the XREFLABEL-title value, so \xrefX can +% distinguish floats from other xref types. +\def\floatmagic{!!float!!} + +% #1 is the control sequence we are passed; we expand into a conditional +% which is true if #1 represents a float ref. That is, the magic +% \thissection value which we \setref above. +% +\def\iffloat#1{\expandafter\doiffloat#1==\finish} +% +% #1 is (maybe) the \floatmagic string. If so, #2 will be the +% (safe) float type for this float. We set \iffloattype to #2. +% +\def\doiffloat#1=#2=#3\finish{% + \def\temp{#1}% + \def\iffloattype{#2}% + \ifx\temp\floatmagic +} + +% @listoffloats FLOATTYPE - print a list of floats like a table of contents. +% +\parseargdef\listoffloats{% + \def\floattype{#1}% floattype + {% + % the floattype might have accents or other special characters, + % but we need to use it in a control sequence name. + \indexnofonts + \turnoffactive + \xdef\safefloattype{\floattype}% + }% + % + % \xrdef saves the floats as a \do-list in \floatlistSAFEFLOATTYPE. + \expandafter\ifx\csname floatlist\safefloattype\endcsname \relax + \ifhavexrefs + % if the user said @listoffloats foo but never @float foo. + \message{\linenumber No `\safefloattype' floats to list.}% + \fi + \else + \begingroup + \leftskip=\tocindent % indent these entries like a toc + \let\do=\listoffloatsdo + \csname floatlist\safefloattype\endcsname + \endgroup + \fi +} + +% This is called on each entry in a list of floats. We're passed the +% xref label, in the form LABEL-title, which is how we save it in the +% aux file. We strip off the -title and look up \XRLABEL-lof, which +% has the text we're supposed to typeset here. +% +% Figures without xref labels will not be included in the list (since +% they won't appear in the aux file). +% +\def\listoffloatsdo#1{\listoffloatsdoentry#1\finish} +\def\listoffloatsdoentry#1-title\finish{{% + % Can't fully expand XR#1-lof because it can contain anything. Just + % pass the control sequence. On the other hand, XR#1-pg is just the + % page number, and we want to fully expand that so we can get a link + % in pdf output. + \toksA = \expandafter{\csname XR#1-lof\endcsname}% + % + % use the same \entry macro we use to generate the TOC and index. + \edef\writeentry{\noexpand\entry{\the\toksA}{\csname XR#1-pg\endcsname}}% + \writeentry +}} + \message{localization,} % and i18n. @@ -5977,19 +6627,17 @@ width0pt\relax} \fi % properly. Single argument is the language abbreviation. % It would be nice if we could set up a hyphenation file here. % -\def\documentlanguage{\parsearg\dodocumentlanguage} -\def\dodocumentlanguage#1{% +\parseargdef\documentlanguage{% \tex % read txi-??.tex file in plain TeX. - % Read the file if it exists. - \openin 1 txi-#1.tex - \ifeof1 - \errhelp = \nolanghelp - \errmessage{Cannot read language file txi-#1.tex}% - \let\temp = \relax - \else - \def\temp{\input txi-#1.tex }% - \fi - \temp + % Read the file if it exists. + \openin 1 txi-#1.tex + \ifeof 1 + \errhelp = \nolanghelp + \errmessage{Cannot read language file txi-#1.tex}% + \else + \input txi-#1.tex + \fi + \closein 1 \endgroup } \newhelp\nolanghelp{The given language definition file cannot be found or @@ -6035,11 +6683,13 @@ should work if nowhere else does.} } % Parameters in order: 1) textheight; 2) textwidth; 3) voffset; -% 4) hoffset; 5) binding offset; 6) topskip. We also call -% \setleading{\textleading}, so the caller should define \textleading. -% The caller should also set \parskip. +% 4) hoffset; 5) binding offset; 6) topskip; 7) physical page height; 8) +% physical page width. +% +% We also call \setleading{\textleading}, so the caller should define +% \textleading. The caller should also set \parskip. % -\def\internalpagesizes#1#2#3#4#5#6{% +\def\internalpagesizes#1#2#3#4#5#6#7#8{% \voffset = #3\relax \topskip = #6\relax \splittopskip = \topskip @@ -6058,28 +6708,27 @@ should work if nowhere else does.} \normaloffset = #4\relax \bindingoffset = #5\relax % + \ifpdf + \pdfpageheight #7\relax + \pdfpagewidth #8\relax + \fi + % \setleading{\textleading} % \parindent = \defaultparindent \setemergencystretch } -% Use `small' versions. -% -\def\smallenvironments{% - \let\smalldisplay = \smalldisplayx - \let\smallexample = \smalllispx - \let\smallformat = \smallformatx - \let\smalllisp = \smalllispx -} - % @letterpaper (the default). \def\letterpaper{{\globaldefs = 1 \parskip = 3pt plus 2pt minus 1pt \textleading = 13.2pt % % If page is nothing but text, make it come out even. - \internalpagesizes{46\baselineskip}{6in}{\voffset}{.25in}{\bindingoffset}{36pt}% + \internalpagesizes{46\baselineskip}{6in}% + {\voffset}{.25in}% + {\bindingoffset}{36pt}% + {11in}{8.5in}% }} % Use @smallbook to reset parameters for 7x9.5 (or so) format. @@ -6087,26 +6736,42 @@ should work if nowhere else does.} \parskip = 2pt plus 1pt \textleading = 12pt % - \internalpagesizes{7.5in}{5.in}{\voffset}{.25in}{\bindingoffset}{16pt}% + \internalpagesizes{7.5in}{5in}% + {\voffset}{.25in}% + {\bindingoffset}{16pt}% + {9.25in}{7in}% % \lispnarrowing = 0.3in \tolerance = 700 \hfuzz = 1pt \contentsrightmargin = 0pt - \deftypemargin = 0pt \defbodyindent = .5cm - \smallenvironments }} % Use @afourpaper to print on European A4 paper. \def\afourpaper{{\globaldefs = 1 \parskip = 3pt plus 2pt minus 1pt - \textleading = 12pt + \textleading = 13.2pt % - \internalpagesizes{53\baselineskip}{160mm}{\voffset}{4mm}{\bindingoffset}{44pt}% + % Double-side printing via postscript on Laserjet 4050 + % prints double-sided nicely when \bindingoffset=10mm and \hoffset=-6mm. + % To change the settings for a different printer or situation, adjust + % \normaloffset until the front-side and back-side texts align. Then + % do the same for \bindingoffset. You can set these for testing in + % your texinfo source file like this: + % @tex + % \global\normaloffset = -6mm + % \global\bindingoffset = 10mm + % @end tex + \internalpagesizes{51\baselineskip}{160mm} + {\voffset}{\hoffset}% + {\bindingoffset}{44pt}% + {297mm}{210mm}% % \tolerance = 700 \hfuzz = 1pt + \contentsrightmargin = 0pt + \defbodyindent = 5mm }} % Use @afivepaper to print on European A5 paper. @@ -6116,44 +6781,46 @@ should work if nowhere else does.} \parskip = 2pt plus 1pt minus 0.1pt \textleading = 12.5pt % - \internalpagesizes{166mm}{120mm}{\voffset}{-8mm}{\bindingoffset}{8pt}% + \internalpagesizes{160mm}{120mm}% + {\voffset}{\hoffset}% + {\bindingoffset}{8pt}% + {210mm}{148mm}% % \lispnarrowing = 0.2in \tolerance = 800 \hfuzz = 1.2pt - \contentsrightmargin = 0mm - \deftypemargin = 0pt + \contentsrightmargin = 0pt \defbodyindent = 2mm \tableindent = 12mm - % - \smallenvironments }} -% A specific text layout, 24x15cm overall, intended for A4 paper. Top margin -% 29mm, hence bottom margin 28mm, nominal side margin 3cm. +% A specific text layout, 24x15cm overall, intended for A4 paper. \def\afourlatex{{\globaldefs = 1 - \textleading = 13.6pt - % \afourpaper - \internalpagesizes{237mm}{150mm}{3.6mm}{3.6mm}{3mm}{7mm}% + \internalpagesizes{237mm}{150mm}% + {\voffset}{4.6mm}% + {\bindingoffset}{7mm}% + {297mm}{210mm}% % - % Must explicitly reset to 0 because we call \afourpaper, apparently, - % although this does not entirely make sense. + % Must explicitly reset to 0 because we call \afourpaper. \globaldefs = 0 }} -% Use @afourwide to print on European A4 paper in wide format. -\def\afourwide{% +% Use @afourwide to print on A4 paper in landscape format. +\def\afourwide{{\globaldefs = 1 \afourpaper - \internalpagesizes{6.5in}{9.5in}{\hoffset}{\normaloffset}{\bindingoffset}{7mm}% -} + \internalpagesizes{241mm}{165mm}% + {\voffset}{-2.95mm}% + {\bindingoffset}{7mm}% + {297mm}{210mm}% + \globaldefs = 0 +}} % @pagesizes TEXTHEIGHT[,TEXTWIDTH] % Perhaps we should allow setting the margins, \topskip, \parskip, % and/or leading, also. Or perhaps we should compute them somehow. % -\def\pagesizes{\parsearg\pagesizesxxx} -\def\pagesizesxxx#1{\pagesizesyyy #1,,\finish} +\parseargdef\pagesizes{\pagesizesyyy #1,,\finish} \def\pagesizesyyy#1,#2,#3\finish{{% \setbox0 = \hbox{\ignorespaces #2}\ifdim\wd0 > 0pt \hsize=#2\relax \fi \globaldefs = 1 @@ -6161,7 +6828,16 @@ should work if nowhere else does.} \parskip = 3pt plus 2pt minus 1pt \setleading{\textleading}% % - \internalpagesizes{#1}{\hsize}{\voffset}{\normaloffset}{\bindingoffset}{44pt}% + \dimen0 = #1 + \advance\dimen0 by \voffset + % + \dimen2 = \hsize + \advance\dimen2 by \normaloffset + % + \internalpagesizes{#1}{\hsize}% + {\voffset}{\normaloffset}% + {\bindingoffset}{44pt}% + {\dimen0}{\dimen2}% }} % Set default to letter. @@ -6191,8 +6867,8 @@ should work if nowhere else does.} \def\normalplus{+} \def\normaldollar{$}%$ font-lock fix -% This macro is used to make a character print one way in ttfont -% where it can probably just be output, and another way in other fonts, +% This macro is used to make a character print one way in \tt +% (where it can probably be output as-is), and another way in other fonts, % where something hairier probably needs to be done. % % #1 is what to print if we are indeed using \tt; #2 is what to print @@ -6225,7 +6901,7 @@ should work if nowhere else does.} \catcode`\_=\active \def_{\ifusingtt\normalunderscore\_} % Subroutine for the previous macro. -\def\_{\leavevmode \kern.06em \vbox{\hrule width.3em height.1ex}} +\def\_{\leavevmode \kern.07em \vbox{\hrule width.3em height.1ex}\kern .07em } \catcode`\|=\active \def|{{\tt\char124}} @@ -6239,15 +6915,6 @@ should work if nowhere else does.} \def+{{\tt \char 43}} \catcode`\$=\active \def${\ifusingit{{\sl\$}}\normaldollar}%$ font-lock fix -%\catcode 27=\active -%\def^^[{$\diamondsuit$} - -% Set up an active definition for =, but don't enable it most of the time. -{\catcode`\==\active -\global\def={{\tt \char 61}}} - -\catcode`+=\active -\catcode`\_=\active % If a .fmt file is being used, characters that might appear in a file % name cannot be active until we have parsed the command line. @@ -6257,44 +6924,48 @@ should work if nowhere else does.} \catcode`\@=0 -% \rawbackslashxx output one backslash character in current font -\global\chardef\rawbackslashxx=`\\ -%{\catcode`\\=\other -%@gdef@rawbackslashxx{\}} +% \backslashcurfont outputs one backslash character in current font, +% as in \char`\\. +\global\chardef\backslashcurfont=`\\ +\global\let\rawbackslashxx=\backslashcurfont % let existing .??s files work -% \rawbackslash redefines \ as input to do \rawbackslashxx. +% \rawbackslash defines an active \ to do \backslashcurfont. +% \otherbackslash defines an active \ to be a literal `\' character with +% catcode other. {\catcode`\\=\active -@gdef@rawbackslash{@let\=@rawbackslashxx }} + @gdef@rawbackslash{@let\=@backslashcurfont} + @gdef@otherbackslash{@let\=@realbackslash} +} + +% \realbackslash is an actual character `\' with catcode other. +{\catcode`\\=\other @gdef@realbackslash{\}} % \normalbackslash outputs one backslash in fixed width font. -\def\normalbackslash{{\tt\rawbackslashxx}} +\def\normalbackslash{{\tt\backslashcurfont}} -% \catcode 17=0 % Define control-q \catcode`\\=\active % Used sometimes to turn off (effectively) the active characters % even after parsing them. -@def@turnoffactive{@let"=@normaldoublequote -@let\=@realbackslash -@let~=@normaltilde -@let^=@normalcaret -@let_=@normalunderscore -@let|=@normalverticalbar -@let<=@normalless -@let>=@normalgreater -@let+=@normalplus -@let$=@normaldollar}%$ font-lock fix - -@def@normalturnoffactive{@let"=@normaldoublequote -@let\=@normalbackslash -@let~=@normaltilde -@let^=@normalcaret -@let_=@normalunderscore -@let|=@normalverticalbar -@let<=@normalless -@let>=@normalgreater -@let+=@normalplus -@let$=@normaldollar}%$ font-lock fix +@def@turnoffactive{% + @let"=@normaldoublequote + @let\=@realbackslash + @let~=@normaltilde + @let^=@normalcaret + @let_=@normalunderscore + @let|=@normalverticalbar + @let<=@normalless + @let>=@normalgreater + @let+=@normalplus + @let$=@normaldollar %$ font-lock fix + @unsepspaces +} + +% Same as @turnoffactive except outputs \ as {\tt\char`\\} instead of +% the literal character `\'. (Thus, \ is not expandable when this is in +% effect.) +% +@def@normalturnoffactive{@turnoffactive @let\=@normalbackslash} % Make _ and + \other characters, temporarily. % This is canceled by @fixbackslash. @@ -6322,15 +6993,11 @@ should work if nowhere else does.} % Say @foo, not \foo, in error messages. @escapechar = `@@ -% These look ok in all fonts, so just make them not special. +% These look ok in all fonts, so just make them not special. @catcode`@& = @other @catcode`@# = @other @catcode`@% = @other -@c Set initial fonts. -@textfonts -@rm - @c Local variables: @c eval: (add-hook 'write-file-hooks 'time-stamp) @@ -6339,3 +7006,9 @@ should work if nowhere else does.} @c time-stamp-format: "%:y-%02m-%02d.%02H" @c time-stamp-end: "}" @c End: + +@c vim:sw=2: + +@ignore + arch-tag: e1b36e32-c96e-4135-a41a-0b2efa2ea115 +@end ignore diff --git a/contrib/amd/doc/version.texi b/contrib/amd/doc/version.texi index afd06b1c1da2..41b19a30d5c6 100644 --- a/contrib/amd/doc/version.texi +++ b/contrib/amd/doc/version.texi @@ -1,3 +1,4 @@ -@set UPDATED 28 August 2003 -@set EDITION 6.0.9 -@set VERSION 6.0.9 +@set UPDATED 20 April 2006 +@set UPDATED-MONTH April 2006 +@set EDITION 6.1.5 +@set VERSION 6.1.5 diff --git a/contrib/amd/fixmount/fixmount.8 b/contrib/amd/fixmount/fixmount.8 index 4fa41d56a32a..e4b700b9eebf 100644 --- a/contrib/amd/fixmount/fixmount.8 +++ b/contrib/amd/fixmount/fixmount.8 @@ -1,5 +1,5 @@ .\" -.\" Copyright (c) 1997-2004 Erez Zadok +.\" Copyright (c) 1997-2006 Erez Zadok .\" Copyright (c) 1990 Jan-Simon Pendry .\" Copyright (c) 1990 Imperial College of Science, Technology & Medicine .\" Copyright (c) 1990 The Regents of the University of California. @@ -38,7 +38,7 @@ .\" .\" %W% (Berkeley) %G% .\" -.\" $Id: fixmount.8,v 1.3.2.6 2004/01/06 03:15:23 ezk Exp $ +.\" $Id: fixmount.8,v 1.12.2.1 2006/01/02 18:48:25 ezk Exp $ .\" .TH FIXMOUNT 8 "26 Feb 1993" .SH NAME @@ -111,19 +111,28 @@ only. This option also saves time as comparisons of remotely recorded and local hostnames by address are avoided. .SH FILES -.PD 0 .TP 20 .B /etc/mtab List of current mounts. .TP .B /etc/rmtab Backup file for remote mount entries on NFS server. -.PD .SH "SEE ALSO" .BR showmount (8), .BR mtab (5), .BR rmtab (5), .BR mountd (8C). +.LP +``am-utils'' +.BR info (1) +entry. +.LP +.I "Linux NFS and Automounter Administration" +by Erez Zadok, ISBN 0-7821-2739-8, (Sybex, 2001). +.LP +.I http://www.am-utils.org +.LP +.I "Amd \- The 4.4 BSD Automounter" .SH BUGS No attempt is made to verify the information in .B /etc/mtab @@ -157,3 +166,12 @@ the remote /etc/rmtab file has to be edited and mountd restarted. The RPC timeouts for mountd calls can only be changed by recompiling. The defaults are 2 seconds for client handle creation and 5 seconds for RPC calls. +.SH AUTHORS +Andreas Stolcke <stolcke@icsi.berkeley.edu>. +.P +Erez Zadok <ezk@cs.sunysb.edu>, Computer Science Department, Stony Brook +University, Stony Brook, New York, USA. +.P +Other authors and contributors to am-utils are listed in the +.B AUTHORS +file distributed with am-utils. diff --git a/contrib/amd/fixmount/fixmount.c b/contrib/amd/fixmount/fixmount.c index 058c30f5003c..c7c69102a55b 100644 --- a/contrib/amd/fixmount/fixmount.c +++ b/contrib/amd/fixmount/fixmount.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: fixmount.c,v 1.5.2.4 2004/01/06 03:15:23 ezk Exp $ + * File: am-utils/fixmount/fixmount.c * */ @@ -50,10 +49,6 @@ #define CREATE_TIMEOUT 2 /* seconds */ #define CALL_TIMEOUT 5 /* seconds */ -#ifndef INADDR_NONE -# define INADDR_NONE 0xffffffff -#endif /* not INADDR_NONE */ - /* Constant defs */ #define ALL 1 #define DIRS 2 @@ -120,7 +115,7 @@ is_same_host(char *name1, char *name2, struct in_addr addr2) } else if (!(he = gethostbyname(name1))) { return 0; } else { - strncpy(lasthost, name1, sizeof(lasthost) - 1); + xstrlcpy(lasthost, name1, MAXHOSTNAMELEN); memcpy(&addr1, he->h_addr, sizeof(addr1)); return (addr1.s_addr == addr2.s_addr); } @@ -164,7 +159,7 @@ remove_mount(CLIENT *client, char *host, mountlist ml, int fixit) struct timeval tv; char *pathp = dir_path; - strncpy(dir_path, ml->ml_directory, sizeof(dir_path)); + xstrlcpy(dir_path, ml->ml_directory, sizeof(dir_path)); if (!fixit) { printf("%s: bogus mount %s:%s\n", host, ml->ml_hostname, ml->ml_directory); @@ -326,8 +321,7 @@ main(int argc, char *argv[]) break; case 'h': - strncpy(thishost, optarg, sizeof(thishost)); - thishost[sizeof(thishost) - 1] = '\0'; + xstrlcpy(thishost, optarg, sizeof(thishost)); break; case '?': @@ -367,8 +361,7 @@ main(int argc, char *argv[]) inet_ntoa(thisaddr)); exit(1); } - strncpy(thishost, he->h_name, sizeof(thishost)); - thishost[sizeof(thishost) - 1] = '\0'; + xstrlcpy(thishost, he->h_name, sizeof(thishost)); } else { thisaddr.s_addr = INADDR_NONE; } @@ -497,8 +490,10 @@ inetresport(int ty) struct sockaddr_in addr; int fd; - /* Use internet address family */ - addr.sin_family = AF_INET; + memset(&addr, 0, sizeof(addr)); + /* as per POSIX, sin_len need not be set (used internally by kernel) */ + + addr.sin_family = AF_INET; /* use internet address family */ addr.sin_addr.s_addr = INADDR_ANY; if ((fd = socket(AF_INET, ty, 0)) < 0) return -1; @@ -568,7 +563,8 @@ clnt_create_timeout(char *host, struct timeval *tvp) fprintf(stderr, "can't get address of %s\n", host); return NULL; } - memset(&host_addr, 0, sizeof host_addr); + memset(&host_addr, 0, sizeof(host_addr)); + /* as per POSIX, sin_len need not be set (used internally by kernel) */ host_addr.sin_family = AF_INET; if (hp) { memmove((voidp) &host_addr.sin_addr, (voidp) hp->h_addr, diff --git a/contrib/amd/fsinfo/fsi_analyze.c b/contrib/amd/fsinfo/fsi_analyze.c index 6a513337a7e9..9da40978e621 100644 --- a/contrib/amd/fsinfo/fsi_analyze.c +++ b/contrib/amd/fsinfo/fsi_analyze.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: fsi_analyze.c,v 1.3.2.5 2004/01/06 03:15:23 ezk Exp $ + * File: am-utils/fsinfo/fsi_analyze.c * */ @@ -112,10 +111,11 @@ domain_strip(char *otherdom, char *localdom) static char * compute_hostpath(char *hn) { - char *p = strdup(hn); + char *p = xmalloc(MAXPATHLEN); char *d; char path[MAXPATHLEN]; + xstrlcpy(p, hn, MAXPATHLEN); domain_strip(p, hostname); path[0] = '\0'; @@ -123,16 +123,16 @@ compute_hostpath(char *hn) d = strrchr(p, '.'); if (d) { *d = 0; - strcat(path, d + 1); - strcat(path, "/"); + xstrlcat(path, d + 1, sizeof(path)); + xstrlcat(path, "/", sizeof(path)); } else { - strcat(path, p); + xstrlcat(path, p, sizeof(path)); } } while (d); fsi_log("hostpath of '%s' is '%s'", hn, path); - strcpy(p, path); + xstrlcpy(p, path, MAXPATHLEN); return p; } @@ -221,7 +221,7 @@ analyze_dkmount_tree(qelem *q, fsi_mount *parent, disk_fs *dk) fsi_log("Mount %s:", mp->m_name); if (parent) { char n[MAXPATHLEN]; - sprintf(n, "%s/%s", parent->m_name, mp->m_name); + xsnprintf(n, sizeof(n), "%s/%s", parent->m_name, mp->m_name); if (*mp->m_name == '/') lerror(mp->m_ioloc, "sub-directory %s of %s starts with '/'", mp->m_name, parent->m_name); else if (STREQ(mp->m_name, "default")) @@ -281,10 +281,10 @@ analyze_dkmounts(disk_fs *dk, qelem *q) /* * Now see if a default mount point is required */ - if (STREQ(mp2->m_name, "default")) { + if (mp2 && STREQ(mp2->m_name, "default")) { if (ISSET(mp2->m_mask, DM_VOLNAME)) { char nbuf[1024]; - compute_automount_point(nbuf, dk->d_host, mp2->m_volname); + compute_automount_point(nbuf, sizeof(nbuf), dk->d_host, mp2->m_volname); XFREE(mp2->m_name); mp2->m_name = strdup(nbuf); fsi_log("%s:%s has default mount on %s", dk->d_host->h_hostname, dk->d_dev, mp2->m_name); @@ -516,7 +516,8 @@ analyze_mounts(host *hp) ITER(dd, dict_data, &de->de_q) { fsi_mount *mp = (fsi_mount *) dd->dd_data; - if (STREQ(mp->m_dk->d_host->h_hostname, fp->f_from)) { + if (fp->f_from && + STREQ(mp->m_dk->d_host->h_hostname, fp->f_from)) { mp2 = mp; break; } @@ -542,7 +543,8 @@ analyze_mounts(host *hp) lerror(fp->f_ioloc, "volname %s unknown", fp->f_volname); } else if (matched) { - fixup_required_mount_info(fp, de); + if (de) + fixup_required_mount_info(fp, de); req = ~fp->f_mask & FM_REQUIRED; if (req) { show_required(fp->f_ioloc, req, fp->f_volname, hp->h_hostname, @@ -631,7 +633,7 @@ analyze_automount_tree(qelem *q, char *pref, int lvl) if (lvl > 0 || ap->a_mount) if (ap->a_name[1] && strchr(ap->a_name + 1, '/')) lerror(ap->a_ioloc, "not allowed '/' in a directory name"); - sprintf(nname, "%s/%s", pref, ap->a_name); + xsnprintf(nname, sizeof(nname), "%s/%s", pref, ap->a_name); XFREE(ap->a_name); ap->a_name = strdup(nname[1] == '/' ? nname + 1 : nname); fsi_log("automount point %s:", ap->a_name); diff --git a/contrib/amd/fsinfo/fsi_data.h b/contrib/amd/fsinfo/fsi_data.h index ac4fd01baec8..8276caf36cba 100644 --- a/contrib/amd/fsinfo/fsi_data.h +++ b/contrib/amd/fsinfo/fsi_data.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,12 +36,14 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: fsi_data.h,v 1.3.2.4 2004/01/06 03:15:23 ezk Exp $ + * File: am-utils/fsinfo/fsi_data.h * */ +#ifndef _FSI_DATA_H +#define _FSI_DATA_H + typedef struct auto_tree auto_tree; typedef struct automount automount; typedef struct dict dict; @@ -233,3 +235,4 @@ struct ioloc { int i_line; char *i_file; }; +#endif /* not _FSI_DATA_H */ diff --git a/contrib/amd/fsinfo/fsi_dict.c b/contrib/amd/fsinfo/fsi_dict.c index 0f11a42febac..29cd1a3ed08a 100644 --- a/contrib/amd/fsinfo/fsi_dict.c +++ b/contrib/amd/fsinfo/fsi_dict.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: fsi_dict.c,v 1.3.2.4 2004/01/06 03:15:23 ezk Exp $ + * File: am-utils/fsinfo/fsi_dict.c * */ diff --git a/contrib/amd/fsinfo/fsi_gram.y b/contrib/amd/fsinfo/fsi_gram.y index 969f4bf13549..961a89f1af45 100644 --- a/contrib/amd/fsinfo/fsi_gram.y +++ b/contrib/amd/fsinfo/fsi_gram.y @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: fsi_gram.y,v 1.4.2.4 2004/01/06 03:15:23 ezk Exp $ + * File: am-utils/fsinfo/fsi_gram.y * */ @@ -50,22 +49,6 @@ #include <fsi_data.h> #include <fsinfo.h> -/* AIX requires this to be the first thing in the file. */ -#ifndef __GNUC__ -# if HAVE_ALLOCA_H -# include <alloca.h> -# else /* not HAVE_ALLOCA_H */ -# ifdef _AIX -#pragma alloca -# else /* not _AIX */ -# ifndef alloca - /* predefined by HP cc +Olibcalls */ -voidp alloca(); -# endif /* not alloca */ -# endif /* not _AIX */ -# endif /* not HAVE_ALLOCA_H */ -#endif /* not __GNUC__ */ - extern qelem *list_of_hosts, *list_of_automounts; %} diff --git a/contrib/amd/fsinfo/fsi_lex.l b/contrib/amd/fsinfo/fsi_lex.l index 8de8a139b8d1..6bca59b4deeb 100644 --- a/contrib/amd/fsinfo/fsi_lex.l +++ b/contrib/amd/fsinfo/fsi_lex.l @@ -1,6 +1,6 @@ %{ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -38,7 +38,7 @@ * SUCH DAMAGE. * * - * $Id: fsi_lex.l,v 1.4.2.6 2004/05/12 15:54:31 ezk Exp $ + * File: am-utils/fsinfo/fsi_lex.l * */ diff --git a/contrib/amd/fsinfo/fsi_util.c b/contrib/amd/fsinfo/fsi_util.c index 8d8ac61f8b5f..5e7571fd4db2 100644 --- a/contrib/amd/fsinfo/fsi_util.c +++ b/contrib/amd/fsinfo/fsi_util.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -33,9 +33,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: fsi_util.c,v 1.3.2.6 2004/01/06 03:15:23 ezk Exp $ + * File: am-utils/fsinfo/fsi_util.c * */ @@ -77,7 +76,7 @@ show_total(void) if (total_mmm < 0) fputc('*', stdout); - sprintf(n, "%d", total_shown); + xsnprintf(n, sizeof(n), "%d", total_shown); len = strlen(n); if (col_output(len)) fputc(' ', stdout); @@ -276,7 +275,7 @@ pref_open(char *pref, char *hn, void (*hdr) (FILE *, char *), char *arg) char p[MAXPATHLEN]; FILE *ef; - sprintf(p, "%s%s", pref, hn); + xsnprintf(p, sizeof(p), "%s%s", pref, hn); fsi_log("Writing %s info for %s to %s", pref, hn, p); ef = fopen(p, "w"); if (ef) { @@ -301,20 +300,9 @@ pref_close(FILE *fp) * Determine where Amd would automount the host/volname pair */ void -compute_automount_point(char *buf, host *hp, char *vn) +compute_automount_point(char *buf, size_t l, host *hp, char *vn) { - sprintf(buf, "%s/%s%s", autodir, hp->h_lochost, vn); -} - - -char * -xcalloc(int i, int s) -{ - char *p = (char *) calloc(i, (unsigned) s); - - if (!p) - fatal("Out of memory"); - return p; + xsnprintf(buf, l, "%s/%s%s", autodir, hp->h_lochost, vn); } @@ -463,7 +451,7 @@ set_ether_if(ether_if *ep, int k, char *v) case EF_INADDR:{ ep->e_inaddr.s_addr = inet_addr(v); - if (ep->e_inaddr.s_addr == (u_long) - 1) + if ((int) ep->e_inaddr.s_addr == (int) INADDR_NONE) yyerror("malformed IP dotted quad: %s", v); XFREE(v); } diff --git a/contrib/amd/fsinfo/fsinfo.8 b/contrib/amd/fsinfo/fsinfo.8 index c9755ab423fc..f893eb24bd8d 100644 --- a/contrib/amd/fsinfo/fsinfo.8 +++ b/contrib/amd/fsinfo/fsinfo.8 @@ -1,5 +1,5 @@ .\" -.\" Copyright (c) 1997-2004 Erez Zadok +.\" Copyright (c) 1997-2006 Erez Zadok .\" Copyright (c) 1993 Jan-Simon Pendry. .\" Copyright (c) 1993 .\" The Regents of the University of California. All rights reserved. @@ -33,7 +33,7 @@ .\" SUCH DAMAGE. .\" .\" from: @(#)fsinfo.8 8.1 (Berkeley) 6/28/93 -.\" $Id: fsinfo.8,v 1.3.2.5 2004/01/06 03:15:23 ezk Exp $ +.\" $Id: fsinfo.8,v 1.13.2.1 2006/01/02 18:48:25 ezk Exp $ .\" .TH FSINFO 8 "June 28, 1993" .SH NAME @@ -68,10 +68,10 @@ fsinfo \- coordinate site-wide filesystem information .I dir ] [ .B \-D -.I string[=string]] +.I string[=string] ] [ .B \-U -.I string[=string]] +.I string[=string] ] .I config .I ... @@ -95,7 +95,27 @@ command is fully described in the document .BR amd (8), .BR mount (8), .BR mountd (8). +.LP +``am-utils'' +.BR info (1) +entry. +.LP +.I "Linux NFS and Automounter Administration" +by Erez Zadok, ISBN 0-7821-2739-8, (Sybex, 2001). +.LP +.I http://www.am-utils.org +.LP +.I "Amd \- The 4.4 BSD Automounter" .SH HISTORY The .B fsinfo command first appeared in 4.4BSD. +.SH AUTHORS +Jan-Simon Pendry <jsp@doc.ic.ac.uk>, Department of Computing, Imperial College, London, UK. +.P +Erez Zadok <ezk@cs.sunysb.edu>, Computer Science Department, Stony Brook +University, Stony Brook, New York, USA. +.P +Other authors and contributors to am-utils are listed in the +.B AUTHORS +file distributed with am-utils. diff --git a/contrib/amd/fsinfo/fsinfo.c b/contrib/amd/fsinfo/fsinfo.c index 0c870e137e70..e441a47fab4b 100644 --- a/contrib/amd/fsinfo/fsinfo.c +++ b/contrib/amd/fsinfo/fsinfo.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -37,7 +37,7 @@ * SUCH DAMAGE. * * - * $Id: fsinfo.c,v 1.5.2.7 2004/05/12 15:54:31 ezk Exp $ + * File: am-utils/fsinfo/fsinfo.c * */ @@ -124,7 +124,7 @@ fsi_get_args(int c, char *v[]) break; case 'h': - strncpy(hostname, optarg, sizeof(hostname) - 1); + xstrlcpy(hostname, optarg, sizeof(hostname)); break; case 'e': @@ -156,7 +156,8 @@ fsi_get_args(int c, char *v[]) case 'I': case 'D': case 'U': - sprintf(iptr, "-%c%s ", ch, optarg); + /* sizeof(iptr) is actually that of idvbuf. See declaration above */ + xsnprintf(iptr, sizeof(idvbuf), "-%c%s ", ch, optarg); iptr += strlen(iptr); break; diff --git a/contrib/amd/fsinfo/fsinfo.h b/contrib/amd/fsinfo/fsinfo.h index 911ecbb08a3e..99b407b04bf0 100644 --- a/contrib/amd/fsinfo/fsinfo.h +++ b/contrib/amd/fsinfo/fsinfo.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -37,7 +37,7 @@ * SUCH DAMAGE. * * - * $Id: fsinfo.h,v 1.4.2.7 2004/05/12 15:54:31 ezk Exp $ + * File: am-utils/fsinfo/fsinfo.h * */ @@ -80,7 +80,7 @@ extern fsi_mount *new_mount(void); extern qelem *new_que(void); extern void analyze_automounts(qelem *); extern void analyze_hosts(qelem *); -extern void compute_automount_point(char *, host *, char *); +extern void compute_automount_point(char *, size_t, host *, char *); extern void dict_add(dict *, char *, char *); extern void error(char *fmt, ...) __attribute__((__format__(__printf__, 1, 2))); diff --git a/contrib/amd/fsinfo/wr_atab.c b/contrib/amd/fsinfo/wr_atab.c index 6db5eea2b22f..e02db07f05f5 100644 --- a/contrib/amd/fsinfo/wr_atab.c +++ b/contrib/amd/fsinfo/wr_atab.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: wr_atab.c,v 1.3.2.4 2004/01/06 03:15:23 ezk Exp $ + * File: am-utils/fsinfo/wr_atab.c * */ @@ -54,7 +53,7 @@ * Write a sequence of automount mount map entries */ static int -write_amount_info(FILE *af, automount *ap, int sk) +write_amount_info(FILE *af, automount *ap, u_int sk) { int errors = 0; @@ -135,7 +134,8 @@ write_amount_info(FILE *af, automount *ap, int sk) */ if (mp->m_dk->d_host->h_lochost) { char amountpt[1024]; - compute_automount_point(amountpt, mp->m_dk->d_host, mp->m_exported->m_volname); + compute_automount_point(amountpt, sizeof(amountpt), + mp->m_dk->d_host, mp->m_exported->m_volname); if (!STREQ(mp->m_dk->d_mountpt, amountpt)) { /* * ap->a_volname is the name of the aliased volume @@ -221,12 +221,12 @@ write_amount_info(FILE *af, automount *ap, int sk) char sublink[1024]; sublink[0] = '\0'; if (exp_namelen < namelen) { - strcat(sublink, mp->m_name + exp_namelen + 1); + xstrlcat(sublink, mp->m_name + exp_namelen + 1, sizeof(sublink)); if (mvolnlen < volnlen) - strcat(sublink, "/"); + xstrlcat(sublink, "/", sizeof(sublink)); } if (mvolnlen < volnlen) - strcat(sublink, ap->a_volname + mvolnlen + 1); + xstrlcat(sublink, ap->a_volname + mvolnlen + 1, sizeof(sublink)); fprintf(af, ";sublink:=%s", sublink); } diff --git a/contrib/amd/fsinfo/wr_bparam.c b/contrib/amd/fsinfo/wr_bparam.c index c1ca06848eca..9220762f2b10 100644 --- a/contrib/amd/fsinfo/wr_bparam.c +++ b/contrib/amd/fsinfo/wr_bparam.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: wr_bparam.c,v 1.3.2.4 2004/01/06 03:15:23 ezk Exp $ + * File: am-utils/fsinfo/wr_bparam.c * */ diff --git a/contrib/amd/fsinfo/wr_dumpset.c b/contrib/amd/fsinfo/wr_dumpset.c index 029ec305f128..69c1257e2659 100644 --- a/contrib/amd/fsinfo/wr_dumpset.c +++ b/contrib/amd/fsinfo/wr_dumpset.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: wr_dumpset.c,v 1.3.2.4 2004/01/06 03:15:23 ezk Exp $ + * File: am-utils/fsinfo/wr_dumpset.c * */ diff --git a/contrib/amd/fsinfo/wr_exportfs.c b/contrib/amd/fsinfo/wr_exportfs.c index f6354c29dc52..818d893687cd 100644 --- a/contrib/amd/fsinfo/wr_exportfs.c +++ b/contrib/amd/fsinfo/wr_exportfs.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: wr_exportfs.c,v 1.3.2.4 2004/01/06 03:15:23 ezk Exp $ + * File: am-utils/fsinfo/wr_exportfs.c * */ diff --git a/contrib/amd/fsinfo/wr_fstab.c b/contrib/amd/fsinfo/wr_fstab.c index 7391601efe25..52cebbf27e11 100644 --- a/contrib/amd/fsinfo/wr_fstab.c +++ b/contrib/amd/fsinfo/wr_fstab.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: wr_fstab.c,v 1.3.2.5 2004/01/06 03:15:23 ezk Exp $ + * File: am-utils/fsinfo/wr_fstab.c * */ diff --git a/contrib/amd/hlfsd/hlfsd.8 b/contrib/amd/hlfsd/hlfsd.8 index bed4480a534c..8c6fb49a9893 100644 --- a/contrib/amd/hlfsd/hlfsd.8 +++ b/contrib/amd/hlfsd/hlfsd.8 @@ -1,5 +1,5 @@ .\" -.\" Copyright (c) 1997-2004 Erez Zadok +.\" Copyright (c) 1997-2006 Erez Zadok .\" Copyright (c) 1989 Jan-Simon Pendry .\" Copyright (c) 1989 Imperial College of Science, Technology & Medicine .\" Copyright (c) 1989 The Regents of the University of California. @@ -36,7 +36,7 @@ .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" SUCH DAMAGE. .\" -.\" $Id: hlfsd.8,v 1.3.2.5 2004/01/06 03:15:23 ezk Exp $ +.\" $Id: hlfsd.8,v 1.11.2.1 2006/01/02 18:48:25 ezk Exp $ .\" .\" HLFSD was written at Columbia University Computer Science Department, by .\" Erez Zadok <ezk@cs.columbia.edu> and Alexander Dupuy <dupuy@smarts.com> @@ -263,7 +263,6 @@ are read and checked. All other fields are ignored. The file must otherwise be compliant with Unix System 7 colon-delimited format .IR passwd (4). .SH FILES -.PD 0 .TP 5 .B /hlfs directory under which @@ -303,8 +302,22 @@ user's home directory is accessible. in .IR "Proc. LISA-VII, The 7th Usenix System Administration Conference" , November 1993. +.LP +``am-utils'' +.BR info (1) +entry. +.LP +.I "Linux NFS and Automounter Administration" +by Erez Zadok, ISBN 0-7821-2739-8, (Sybex, 2001). +.LP +.I http://www.am-utils.org .SH AUTHORS -Erez Zadok <ezk@cs.columbia.edu>, Computer Science Department, -Columbia University, New York City, New York, USA, and +Erez Zadok <ezk@cs.sunysb.edu>, Computer Science Department, Stony Brook +University, Stony Brook, New York, USA. +and Alexander Dupuy <dupuy@smarts.com>, System Management ARTS, White Plains, New York, USA. +.P +Other authors and contributors to am-utils are listed in the +.B AUTHORS +file distributed with am-utils. diff --git a/contrib/amd/hlfsd/hlfsd.c b/contrib/amd/hlfsd/hlfsd.c index 355509d37637..8703f5982c5e 100644 --- a/contrib/amd/hlfsd/hlfsd.c +++ b/contrib/amd/hlfsd/hlfsd.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: hlfsd.c,v 1.7.2.9 2004/01/19 00:25:55 ezk Exp $ + * File: am-utils/hlfsd/hlfsd.c * * HLFSD was written at Columbia University Computer Science Department, by * Erez Zadok <ezk@cs.columbia.edu> and Alexander Dupuy <dupuy@cs.columbia.edu> @@ -85,7 +84,7 @@ char *logfile = DEFAULT_LOGFILE; char *passwdfile = NULL; /* alternate passwd file to use */ char *slinkname = 0; char hostname[MAXHOSTNAMELEN + 1] = "localhost"; -int cache_interval = DEFAULT_CACHE_INTERVAL; +u_int cache_interval = DEFAULT_CACHE_INTERVAL; gid_t hlfs_gid = (gid_t) INVALIDID; int masterpid = 0; int noverify = 0; @@ -121,6 +120,17 @@ usage(void) } +void +fatalerror(char *str) +{ +#define ERRM ": %m" + size_t l = strlen(str) + sizeof(ERRM) - 1; + char *tmp = strnsave(str, l); + xstrlcat(tmp, ERRM, l); + fatal(tmp); +} + + int main(int argc, char *argv[]) { @@ -308,12 +318,12 @@ main(int argc, char *argv[]) *dot = '\0'; orig_umask = umask(0); if (logfile) - switch_to_logfile(logfile, orig_umask); + switch_to_logfile(logfile, orig_umask, 0); -#if defined(DEBUG) && !defined(MOUNT_TABLE_ON_FILE) - if (debug_flags & D_MTAB) +#ifndef MOUNT_TABLE_ON_FILE + if (amuDebug(D_MTAB)) dlog("-D mtab option ignored"); -#endif /* defined(DEBUG) && !defined(MOUNT_TABLE_ON_FILE) */ +#endif /* not MOUNT_TABLE_ON_FILE */ /* avoid hanging on other NFS servers if started elsewhere */ if (chdir("/") < 0) @@ -337,8 +347,6 @@ main(int argc, char *argv[]) exit(3); } - clock_valid = 0; /* invalidate logging clock */ - if (!forcefast) { /* make sure mount point exists and is at least mode 555 */ if (stat(dir_name, &stmodes) < 0) @@ -383,7 +391,7 @@ main(int argc, char *argv[]) chmod(alt_spooldir, OPEN_SPOOLMODE); /* create failsafe link to alternate spool directory */ - slinkname[-1] = '/'; /* unsplit dir_name to include link */ + *(slinkname-1) = '/'; /* unsplit dir_name to include link */ if (lstat(dir_name, &stmodes) == 0 && (stmodes.st_mode & S_IFMT) != S_IFLNK) { fprintf(stderr, "%s: failsafe %s not a symlink\n", @@ -404,7 +412,7 @@ main(int argc, char *argv[]) } } - slinkname[-1] = '\0'; /* resplit dir_name */ + *(slinkname-1) = '\0'; /* resplit dir_name */ } /* end of "if (!forcefast) {" */ /* @@ -420,7 +428,7 @@ main(int argc, char *argv[]) #ifdef HAVE_SIGACTION sa.sa_handler = proceed; - sa.sa_flags = SA_RESTART; + sa.sa_flags = 0; sigemptyset(&(sa.sa_mask)); sigaddset(&(sa.sa_mask), SIGUSR2); sigaction(SIGUSR2, &sa, NULL); @@ -433,7 +441,7 @@ main(int argc, char *argv[]) #ifdef HAVE_SIGACTION sa.sa_handler = reaper; - sa.sa_flags = SA_RESTART; + sa.sa_flags = 0; sigemptyset(&(sa.sa_mask)); sigaddset(&(sa.sa_mask), SIGCHLD); sigaction(SIGCHLD, &sa, NULL); @@ -441,53 +449,57 @@ main(int argc, char *argv[]) signal(SIGCHLD, reaper); #endif /* not HAVE_SIGACTION */ -#ifdef DEBUG /* - * In the parent, if -D nodaemon (or -D daemon) , we don't need to + * In the parent, if -D daemon, we don't need to * set this signal handler. */ - amuDebug(D_DAEMON) { -#endif /* DEBUG */ - /* XXX: port to use pure svr4 signals */ + if (!amuDebug(D_DAEMON)) { s = -99; while (stoplight != SIGUSR2) { plog(XLOG_INFO, "parent waits for child to setup (stoplight=%d)", stoplight); +#ifdef HAVE_SIGSUSPEND + { + sigset_t mask; + sigemptyset(&mask); + s = sigsuspend(&mask); /* wait for child to set up */ + } +#else /* not HAVE_SIGSUSPEND */ s = sigpause(0); /* wait for child to set up */ +#endif /* not HAVE_SIGSUSPEND */ sleep(1); } -#ifdef DEBUG } -#endif /* DEBUG */ /* * setup options to mount table (/etc/{mtab,mnttab}) entry */ - sprintf(hostpid_fs, "%s:(pid%d)", hostname, masterpid); + xsnprintf(hostpid_fs, sizeof(hostpid_fs), + "%s:(pid%d)", hostname, masterpid); memset((char *) &mnt, 0, sizeof(mnt)); mnt.mnt_dir = dir_name; /* i.e., "/mail" */ mnt.mnt_fsname = hostpid_fs; if (mntopts) { mnt.mnt_opts = mntopts; } else { - strcpy(preopts, default_mntopts); + xstrlcpy(preopts, default_mntopts, sizeof(preopts)); /* * Turn off all kinds of attribute and symlink caches as * much as possible. Also make sure that mount does not * show up to df. */ #ifdef MNTTAB_OPT_INTR - strcat(preopts, ","); - strcat(preopts, MNTTAB_OPT_INTR); + xstrlcat(preopts, ",", sizeof(preopts)); + xstrlcat(preopts, MNTTAB_OPT_INTR, sizeof(preopts)); #endif /* MNTTAB_OPT_INTR */ #ifdef MNTTAB_OPT_IGNORE - strcat(preopts, ","); - strcat(preopts, MNTTAB_OPT_IGNORE); + xstrlcat(preopts, ",", sizeof(preopts)); + xstrlcat(preopts, MNTTAB_OPT_IGNORE, sizeof(preopts)); #endif /* MNTTAB_OPT_IGNORE */ #ifdef MNT2_GEN_OPT_CACHE - strcat(preopts, ",nocache"); + xstrlcat(preopts, ",nocache", sizeof(preopts)); #endif /* MNT2_GEN_OPT_CACHE */ #ifdef MNT2_NFS_OPT_SYMTTL - strcat(preopts, ",symttl=0"); + xstrlcat(preopts, ",symttl=0", sizeof(preopts)); #endif /* MNT2_NFS_OPT_SYMTTL */ mnt.mnt_opts = preopts; } @@ -498,11 +510,15 @@ main(int argc, char *argv[]) * If they don't appear to support the either the "ignore" mnttab * option entry, or the "auto" one, set the mount type to "nfs". */ +#ifdef HIDE_MOUNT_TYPE mnt.mnt_type = HIDE_MOUNT_TYPE; +#else /* not HIDE_MOUNT_TYPE */ + mnt.mnt_type = "nfs"; +#endif /* not HIDE_MOUNT_TYPE */ /* some systems don't have a mount type, but a mount flag */ #ifndef HAVE_TRANSPORT_TYPE_TLI - amu_get_myaddress(&localsocket.sin_addr); + amu_get_myaddress(&localsocket.sin_addr, NULL); localsocket.sin_family = AF_INET; localsocket.sin_port = htons(nfsxprt->xp_port); #endif /* not HAVE_TRANSPORT_TYPE_TLI */ @@ -511,11 +527,13 @@ main(int argc, char *argv[]) * Update hostname field. * Make some name prog:pid (i.e., hlfsd:174) for hostname */ - sprintf(progpid_fs, "%s:%d", am_get_progname(), masterpid); + xsnprintf(progpid_fs, sizeof(progpid_fs), + "%s:%d", am_get_progname(), masterpid); /* Most kernels have a name length restriction. */ if ((int) strlen(progpid_fs) >= (int) MAXHOSTNAMELEN) - strcpy(progpid_fs + MAXHOSTNAMELEN - 3, ".."); + xstrlcpy(progpid_fs + MAXHOSTNAMELEN - 3, "..", + sizeof(progpid_fs) - MAXHOSTNAMELEN + 3); genflags = compute_mount_flags(&mnt); @@ -523,7 +541,7 @@ main(int argc, char *argv[]) if (retry <= 0) retry = 1; /* XXX */ - memmove(&anh.v2.fhs_fh, root_fhp, sizeof(*root_fhp)); + memmove(&anh.v2, root_fhp, sizeof(*root_fhp)); #ifdef HAVE_TRANSPORT_TYPE_TLI compute_nfs_args(&nfs_args, &mnt, @@ -549,6 +567,7 @@ main(int argc, char *argv[]) compute_nfs_args(&nfs_args, &mnt, genflags, + NULL, &localsocket, NFS_VERSION, /* version 2 */ "udp", /* XXX: shouldn't this be "udp"? */ @@ -564,33 +583,26 @@ main(int argc, char *argv[]) *************************************************************************/ compute_automounter_nfs_args(&nfs_args, &mnt); - clock_valid = 0; /* invalidate logging clock */ - -/* - * The following code could be cleverly ifdef-ed, but I duplicated the - * mount_fs call three times for simplicity and readability. - */ -#ifdef DEBUG /* * For some reason, this mount may have to be done in the background, if I am - * using -D nodebug. I suspect that the actual act of mounting requires + * using -D daemon. I suspect that the actual act of mounting requires * calling to hlfsd itself to invoke one or more of its nfs calls, to stat - * /mail. That means that even if you say -D nodaemon, at least the mount + * /mail. That means that even if you say -D daemon, at least the mount * of hlfsd itself on top of /mail will be done in the background. * The other alternative I have is to run svc_run, but set a special * signal handler to perform the mount in N seconds via some alarm. * -Erez Zadok. */ - if (debug_flags & D_DAEMON) { /* asked for -D daemon */ - plog(XLOG_INFO, "parent NFS mounting hlfsd service points"); - if (mount_fs(&mnt, genflags, (caddr_t) &nfs_args, retry, type, 0, NULL, mnttab_file_name) < 0) + if (!amuDebug(D_DAEMON)) { /* Normal case */ + plog(XLOG_INFO, "normal NFS mounting hlfsd service points"); + if (mount_fs(&mnt, genflags, (caddr_t) &nfs_args, retry, type, 0, NULL, mnttab_file_name, 0) < 0) fatal("nfsmount: %m"); - } else { /* asked for -D nodaemon */ + } else { /* asked for -D daemon */ if (fork() == 0) { /* child runs mount */ am_set_mypid(); foreground = 0; plog(XLOG_INFO, "child NFS mounting hlfsd service points"); - if (mount_fs(&mnt, genflags, (caddr_t) &nfs_args, retry, type, 0, NULL, mnttab_file_name) < 0) { + if (mount_fs(&mnt, genflags, (caddr_t) &nfs_args, retry, type, 0, NULL, mnttab_file_name, 0) < 0) { fatal("nfsmount: %m"); } exit(0); /* all went well */ @@ -598,11 +610,6 @@ main(int argc, char *argv[]) plog(XLOG_INFO, "parent waiting 1sec for mount..."); } } -#else /* not DEBUG */ - plog(XLOG_INFO, "normal NFS mounting hlfsd service points"); - if (mount_fs(&mnt, genflags, (caddr_t) &nfs_args, retry, type, 2, "udp", mnttab_file_name) < 0) - fatal("nfsmount: %m"); -#endif /* not DEBUG */ #ifdef HAVE_TRANSPORT_TYPE_TLI /* @@ -620,15 +627,14 @@ main(int argc, char *argv[]) printf("%d\n", masterpid); plog(XLOG_INFO, "hlfsd ready to serve"); -#ifdef DEBUG /* - * If asked not to fork a daemon (-D nodaemon), then hlfsd_init() + * If asked not to fork a daemon (-D daemon), then hlfsd_init() * will not run svc_run. We must start svc_run here. */ - dlog("starting no-daemon debugging svc_run"); - amuDebugNo(D_DAEMON) + if (amuDebug(D_DAEMON)) { + plog(XLOG_DEBUG, "starting no-daemon debugging svc_run"); svc_run(); -#endif /* DEBUG */ + } cleanup(0); /* should never happen here */ return (0); /* everything went fine? */ @@ -643,20 +649,16 @@ hlfsd_init(void) struct sigaction sa; #endif /* HAVE_SIGACTION */ - clock_valid = 0; /* invalidate logging clock */ - /* * Initialize file handles. */ plog(XLOG_INFO, "initializing hlfsd file handles"); hlfsd_init_filehandles(); -#ifdef DEBUG /* - * If -D daemon then we must fork. + * If not -D daemon then we must fork. */ - amuDebug(D_DAEMON) -#endif /* DEBUG */ + if (!amuDebug(D_DAEMON)) child = fork(); if (child < 0) @@ -685,7 +687,7 @@ hlfsd_init(void) */ #ifdef HAVE_SIGACTION sa.sa_handler = reload; - sa.sa_flags = SA_RESTART; + sa.sa_flags = 0; sigemptyset(&(sa.sa_mask)); sigaddset(&(sa.sa_mask), SIGALRM); sigaddset(&(sa.sa_mask), SIGHUP); @@ -701,7 +703,7 @@ hlfsd_init(void) */ #ifdef HAVE_SIGACTION sa.sa_handler = cleanup; - sa.sa_flags = SA_RESTART; + sa.sa_flags = 0; sigemptyset(&(sa.sa_mask)); sigaddset(&(sa.sa_mask), SIGTERM); sigaction(SIGTERM, &sa, NULL); @@ -714,7 +716,7 @@ hlfsd_init(void) */ #ifdef HAVE_SIGACTION sa.sa_handler = interlock; - sa.sa_flags = SA_RESTART; + sa.sa_flags = 0; sigemptyset(&(sa.sa_mask)); sigaddset(&(sa.sa_mask), SIGCHLD); sigaction(SIGCHLD, &sa, NULL); @@ -731,7 +733,7 @@ hlfsd_init(void) # else /* not defined(DEBUG) || defined(DEBUG_PRINT) */ sa.sa_handler = SIG_IGN; # endif /* not defined(DEBUG) || defined(DEBUG_PRINT) */ - sa.sa_flags = SA_RESTART; + sa.sa_flags = 0; sigemptyset(&(sa.sa_mask)); sigaddset(&(sa.sa_mask), SIGUSR1); sigaction(SIGUSR1, &sa, NULL); @@ -746,17 +748,14 @@ hlfsd_init(void) if (setitimer(ITIMER_REAL, &reloadinterval, (struct itimerval *) 0) < 0) fatal("setitimer: %m"); - gettimeofday((struct timeval *) ((void *)&startup), (struct timezone *) 0); + clocktime(&startup); -#ifdef DEBUG /* - * If -D daemon, then start serving here in the child, - * and the parent will exit. But if -D nodaemon, then + * If not -D daemon, then start serving here in the child, + * and the parent will exit. But if -D daemon, then * skip this code and make sure svc_run is entered elsewhere. */ - amuDebug(D_DAEMON) { -#endif /* DEBUG */ - + if (!amuDebug(D_DAEMON)) { /* * Dissociate from the controlling terminal */ @@ -771,9 +770,7 @@ hlfsd_init(void) plog(XLOG_INFO, "starting svc_run"); svc_run(); cleanup(0); /* should never happen, just in case */ -#ifdef DEBUG - } /* end of code that runs iff hlfsd daemonizes */ -#endif /* DEBUG */ + } } @@ -791,8 +788,6 @@ reload(int signum) int child; int status; - clock_valid = 0; /* invalidate logging clock */ - if (getpid() != masterpid) return; @@ -801,7 +796,7 @@ reload(int signum) * can be rotated) */ if (signum == SIGHUP && logfile) - switch_to_logfile(logfile, orig_umask); + switch_to_logfile(logfile, orig_umask, 0); /* * parent performs the reload, while the child continues to serve @@ -844,29 +839,21 @@ cleanup(int signum) struct stat stbuf; int umount_result; - clock_valid = 0; /* invalidate logging clock */ - -#ifdef DEBUG - amuDebug(D_DAEMON) -#endif /* DEBUG */ + if (!amuDebug(D_DAEMON)) { if (getpid() != masterpid) return; -#ifdef DEBUG - amuDebug(D_DAEMON) -#endif /* DEBUG */ if (fork() != 0) { masterpid = 0; am_set_mypid(); return; } + } am_set_mypid(); for (;;) { - while ((umount_result = UMOUNT_FS(dir_name, mnttab_file_name)) == EBUSY) { -#ifdef DEBUG + while ((umount_result = UMOUNT_FS(dir_name, mnttab_file_name, 0)) == EBUSY) { dlog("cleanup(): umount delaying for 10 seconds"); -#endif /* DEBUG */ sleep(10); } if (stat(dir_name, &stbuf) == 0 && stbuf.st_ino == ROOTID) { @@ -878,19 +865,14 @@ cleanup(int signum) break; } -#ifdef DEBUG - dlog("cleanup(): killing processes and terminating"); - amuDebug(D_DAEMON) -#endif /* DEBUG */ + if (!amuDebug(D_DAEMON)) { + plog(XLOG_INFO, "cleanup(): killing processes and terminating"); kill(masterpid, SIGKILL); - -#ifdef DEBUG - amuDebug(D_DAEMON) -#endif /* DEBUG */ kill(serverpid, SIGKILL); + } plog(XLOG_INFO, "hlfsd terminating with status 0\n"); - exit(0); + _exit(0); } @@ -900,7 +882,7 @@ reaper(int signum) int result; if (wait(&result) == masterpid) { - exit(4); + _exit(4); } } @@ -931,7 +913,7 @@ fatal(char *mess) if (!STREQ(&mess[messlen + 1 - sizeof(ERRM)], ERRM)) fprintf(stderr, "%s: %s\n", am_get_progname(), mess); else { - strcpy(lessmess, mess); + xstrlcpy(lessmess, mess, sizeof(lessmess)); lessmess[messlen - 4] = '\0'; fprintf(stderr, "%s: %s: %s\n", diff --git a/contrib/amd/hlfsd/hlfsd.h b/contrib/amd/hlfsd/hlfsd.h index 645c2f87f4b7..ed136b6f2306 100644 --- a/contrib/amd/hlfsd/hlfsd.h +++ b/contrib/amd/hlfsd/hlfsd.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: hlfsd.h,v 1.4.2.7 2004/01/06 03:15:23 ezk Exp $ + * File: am-utils/hlfsd/hlfsd.h * * HLFSD was written at Columbia University Computer Science Department, by * Erez Zadok <ezk@cs.columbia.edu> and Alexander Dupuy <dupuy@cs.columbia.edu> @@ -100,9 +99,6 @@ # define DEFAULT_LOGFILE 0 #endif /* not HAVE)_SYSLOG */ -#define ERRM ": %m" -#define fatalerror(str) \ - (fatal (strcat (strnsave ((str), strlen ((str)) + sizeof (ERRM) - 1), ERRM))) /* * TYPEDEFS: @@ -142,16 +138,15 @@ extern char *homedir(int, int); extern char *mailbox(int, char *); extern char *passwdfile; extern char *slinkname; -extern char mboxfile[]; extern gid_t hlfs_gid; -extern int cache_interval; +extern u_int cache_interval; extern int noverify; extern int serverpid; extern int untab_index(char *username); extern am_nfs_fh *root_fhp; extern am_nfs_fh root; extern nfstime startup; -extern uid2home_t *plt_search(int); +extern uid2home_t *plt_search(u_int); extern username2uid_t *untab; /* user name table */ extern void fatal(char *); extern void plt_init(void); diff --git a/contrib/amd/hlfsd/homedir.c b/contrib/amd/hlfsd/homedir.c index 533b7f4d6b85..2ade32ffb344 100644 --- a/contrib/amd/hlfsd/homedir.c +++ b/contrib/amd/hlfsd/homedir.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: homedir.c,v 1.5.2.11 2004/01/06 03:15:23 ezk Exp $ + * File: am-utils/hlfsd/homedir.c * * HLFSD was written at Columbia University Computer Science Department, by * Erez Zadok <ezk@cs.columbia.edu> and Alexander Dupuy <dupuy@cs.columbia.edu> @@ -66,7 +65,7 @@ static struct passwd passwd_ent; static uid2home_t *lastchild; static uid2home_t *pwtab; static void delay(uid2home_t *, int); -static void table_add(int, const char *, const char *); +static void table_add(u_int, const char *, const char *); static char mboxfile[MAXPATHLEN]; static char *root_home; /* root's home directory */ @@ -90,8 +89,6 @@ homedir(int userid, int groupid) struct stat homestat; int old_groupid, old_userid; - clock_valid = 0; /* invalidate logging clock */ - if ((found = plt_search(userid)) == (uid2home_t *) NULL) { return alt_spooldir; /* use alt spool for unknown uid */ } @@ -102,9 +99,9 @@ homedir(int userid, int groupid) return alt_spooldir; /* use alt spool for / or rel. home */ } if ((int) userid == 0) /* force all uid 0 to use root's home */ - sprintf(linkval, "%s/%s", root_home, home_subdir); + xsnprintf(linkval, sizeof(linkval), "%s/%s", root_home, home_subdir); else - sprintf(linkval, "%s/%s", homename, home_subdir); + xsnprintf(linkval, sizeof(linkval), "%s/%s", homename, home_subdir); if (noverify) { found->last_status = 0; @@ -135,41 +132,18 @@ homedir(int userid, int groupid) } } -#ifdef DEBUG /* - * only run this forking code if asked for -D fork - * or if did not ask for -D nofork + * only run this forking code if did not ask for -D fork */ - amuDebug(D_FORK) { -#endif /* DEBUG */ + if (!amuDebug(D_FORK)) { /* fork child to process request if none in progress */ - if (found->child && kill(found->child, 0) < 0) + if (found->child && kill(found->child, 0)) found->child = 0; if (found->child) delay(found, 5); /* wait a bit if in progress */ - -#if defined(DEBUG) && defined(HAVE_WAITPID) - if (found->child) { - /* perhaps it's a child we lost count of? let's wait on it */ - int status, child; - if ((child = waitpid((pid_t) found->child, &status, WNOHANG)) > 0) { - plog(XLOG_ERROR, "found lost child %d", child); - found->child = 0; - if (WIFEXITED(status)) - found->last_status = WEXITSTATUS(status); - else if (WIFSIGNALED(status)) - found->last_status = -WTERMSIG(status); - else { - plog(XLOG_ERROR, "unknown child exit status (%d) ???", status); - found->last_status = 255; - } - } - } -#endif /* DEBUG && HAVE_WAITPID */ - - if (found->child) { - found->last_status = 1; /* better safe than sorry - maybe */ + if (found->child) { /* better safe than sorry - maybe */ + found->last_status = 1; return alt_spooldir; } if ((found->child = fork()) < 0) { @@ -177,21 +151,17 @@ homedir(int userid, int groupid) return alt_spooldir; } if (found->child) { /* PARENT */ -#ifdef DEBUG if (lastchild) - plog(XLOG_INFO, "cache spill uid = %ld, pid = %ld, home = %s", + dlog("cache spill uid = %ld, pid = %ld, home = %s", (long) lastchild->uid, (long) lastchild->child, lastchild->home); -#endif /* DEBUG */ lastchild = found; return (char *) NULL; /* return NULL to parent, so it can continue */ } -#ifdef DEBUG - } /* end of Debug(D_FORK) */ -#endif /* DEBUG */ + } /* - * CHILD: (or parent if -D nofork) + * CHILD: (or parent if -D fork) * * Check and create dir if needed. * Check disk space and/or quotas too. @@ -257,9 +227,7 @@ hlfsd_diskspace(char *path) char buf[MAXPATHLEN]; int fd, len; - clock_valid = 0; /* invalidate logging clock */ - - sprintf(buf, "%s/._hlfstmp_%lu", path, (long) getpid()); + xsnprintf(buf, sizeof(buf), "%s/._hlfstmp_%lu", path, (long) getpid()); if ((fd = open(buf, O_RDWR | O_CREAT, 0600)) < 0) { plog(XLOG_ERROR, "cannot open %s: %m", buf); return -1; @@ -297,10 +265,7 @@ delay(uid2home_t *found, int secs) { struct timeval tv; -#ifdef DEBUG - if (found) - dlog("delaying on child %ld for %d seconds", (long) found->child, secs); -#endif /* DEBUG */ + dlog("delaying on child %ld for %d seconds", (long) found->child, secs); tv.tv_usec = 0; @@ -323,55 +288,30 @@ interlock(int signum) int child; uid2home_t *lostchild; int status; - int max_errors = 10; /* avoid infinite loops */ #ifdef HAVE_WAITPID - while ((child = waitpid((pid_t) -1, &status, WNOHANG)) != 0) { + while ((child = waitpid((pid_t) -1, &status, WNOHANG)) > 0) { #else /* not HAVE_WAITPID */ - while ((child = wait3(&status, WNOHANG, (struct rusage *) 0)) != 0) { + while ((child = wait3(&status, WNOHANG, (struct rusage *) 0)) > 0) { #endif /* not HAVE_WAITPID */ - if (child < 0) { - plog(XLOG_WARNING, "waitpid/wait3: %m"); - if (--max_errors > 0) - continue; - else - break; - } - /* high chances this was the last child forked */ if (lastchild && lastchild->child == child) { lastchild->child = 0; if (WIFEXITED(status)) lastchild->last_status = WEXITSTATUS(status); - else if (WIFSIGNALED(status)) - lastchild->last_status = -WTERMSIG(status); - else { - plog(XLOG_ERROR, "unknown child exit status (%d) ???", status); - lastchild->last_status = 255; - } lastchild = (uid2home_t *) NULL; } else { /* and if not, we have to search for it... */ - int found = 0; for (lostchild = pwtab; lostchild < &pwtab[cur_pwtab_num]; lostchild++) { if (lostchild->child == child) { - lostchild->child = 0; if (WIFEXITED(status)) lostchild->last_status = WEXITSTATUS(status); - else if (WIFSIGNALED(status)) - lostchild->last_status = -WTERMSIG(status); - else { - plog(XLOG_ERROR, "unknown child exit status (%d) ???", status); - lostchild->last_status = 255; - } - found = 1; + lostchild->child = 0; break; } } - if (!found) - plog(XLOG_ERROR, "no record of child %d found???", child); } } } @@ -455,15 +395,18 @@ mailbox(int uid, char *username) if ((home = homeof(username)) == (char *) NULL) return (char *) NULL; if (STREQ(home, "/")) - sprintf(mboxfile, "/%s/%s", home_subdir, username); + xsnprintf(mboxfile, sizeof(mboxfile), + "/%s/%s", home_subdir, username); else - sprintf(mboxfile, "%s/%s/%s", home, home_subdir, username); + xsnprintf(mboxfile, sizeof(mboxfile), + "%s/%s/%s", home, home_subdir, username); return mboxfile; } static int plt_compare_fxn(const voidp x, const voidp y) + { uid2home_t *i = (uid2home_t *) x; uid2home_t *j = (uid2home_t *) y; @@ -538,8 +481,6 @@ hlfsd_getpwent(void) return getpwent(); } - clock_valid = 0; /* invalidate logging clock */ - /* return here to read another entry */ readent: @@ -562,7 +503,8 @@ readent: plog(XLOG_ERROR, "no user name on line %d of %s", passwd_line, passwdfile); goto readent; } - strcpy(pw_name, cp); /* will show up in passwd_ent.pw_name */ + /* pw_name will show up in passwd_ent.pw_name */ + xstrlcpy(pw_name, cp, sizeof(pw_name)); /* skip passwd */ strtok(NULL, ":"); @@ -585,7 +527,8 @@ readent: plog(XLOG_ERROR, "no home dir on line %d of %s", passwd_line, passwdfile); goto readent; } - strcpy(pw_dir, cp); /* will show up in passwd_ent.pw_dir */ + /* pw_dir will show up in passwd_ent.pw_dir */ + xstrlcpy(pw_dir, cp, sizeof(pw_dir)); /* the rest of the fields are unimportant and not being considered */ @@ -648,8 +591,6 @@ plt_reset(void) { int i; - clock_valid = 0; /* invalidate logging clock */ - hlfsd_setpwent(); if (hlfsd_getpwent() == (struct passwd *) NULL) { hlfsd_endpwent(); @@ -690,12 +631,10 @@ plt_reset(void) * n: user ID name */ static void -table_add(int u, const char *h, const char *n) +table_add(u_int u, const char *h, const char *n) { int i; - clock_valid = 0; /* invalidate logging clock */ - if (max_pwtab_num <= 0) { /* was never initialized */ max_pwtab_num = 1; pwtab = (uid2home_t *) xmalloc(max_pwtab_num * @@ -726,10 +665,8 @@ table_add(int u, const char *h, const char *n) /* do NOT add duplicate entries (this is an O(N^2) algorithm... */ for (i=0; i<cur_pwtab_num; ++i) if (u == pwtab[i].uid && u != 0 ) { -#ifdef DEBUG dlog("ignoring duplicate home %s for uid %d (already %s)", h, u, pwtab[i].home); -#endif /* DEBUG */ return; } @@ -757,7 +694,7 @@ table_add(int u, const char *h, const char *n) * return entry in lookup table */ uid2home_t * -plt_search(int u) +plt_search(u_int u) { int max, min, mid; diff --git a/contrib/amd/hlfsd/nfs_prot_svc.c b/contrib/amd/hlfsd/nfs_prot_svc.c index b9150e3d8831..8cea0dca700d 100644 --- a/contrib/amd/hlfsd/nfs_prot_svc.c +++ b/contrib/amd/hlfsd/nfs_prot_svc.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: nfs_prot_svc.c,v 1.4.2.5 2004/01/06 03:15:23 ezk Exp $ + * File: am-utils/hlfsd/nfs_prot_svc.c * */ diff --git a/contrib/amd/hlfsd/stubs.c b/contrib/amd/hlfsd/stubs.c index 4038c05006f7..becf402c1ecb 100644 --- a/contrib/amd/hlfsd/stubs.c +++ b/contrib/amd/hlfsd/stubs.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: stubs.c,v 1.5.2.7 2004/01/06 03:15:23 ezk Exp $ + * File: am-utils/hlfsd/stubs.c * * HLFSD was written at Columbia University Computer Science Department, by * Erez Zadok <ezk@cs.columbia.edu> and Alexander Dupuy <dupuy@cs.columbia.edu> @@ -127,8 +126,18 @@ nfsproc_getattr_2_svc(am_nfs_fh *argp, struct svc_req *rqstp) res.ns_status = NFSERR_STALE; return &res; } - if (eq_fh(argp, &root)) { +#if 0 + /* + * XXX: increment mtime of parent directory, causes NFS clients to + * invalidate their cache for that directory. + * Some NFS clients may need this code. + */ + if (uid != rootfattr.na_uid) { + clocktime(&rootfattr.na_mtime); + rootfattr.na_uid = uid; + } +#endif res.ns_status = NFS_OK; res.ns_u.ns_attr_u = rootfattr; } else if (eq_fh(argp, &slink)) { @@ -144,7 +153,7 @@ nfsproc_getattr_2_svc(am_nfs_fh *argp, struct svc_req *rqstp) * so we must update the nt_seconds field every time. */ if (uid != slinkfattr.na_uid) { - slinkfattr.na_mtime.nt_seconds++; + clocktime(&slinkfattr.na_mtime); slinkfattr.na_uid = uid; } #endif /* not MNT2_NFS_OPT_SYMTTL */ @@ -161,10 +170,8 @@ nfsproc_getattr_2_svc(am_nfs_fh *argp, struct svc_req *rqstp) res.ns_status = NFS_OK; un_fattr.na_fileid = uid; res.ns_u.ns_attr_u = un_fattr; -#ifdef DEBUG dlog("nfs_getattr: successful search for uid=%ld, gid=%ld", (long) uid, (long) gid); -#endif /* DEBUG */ } else { /* not found */ res.ns_status = NFSERR_STALE; } @@ -219,12 +226,22 @@ nfsproc_lookup_2_svc(nfsdiropargs *argp, struct svc_req *rqstp) res.dr_status = NFSERR_NOENT; return &res; } - if (eq_fh(&argp->da_fhandle, &root)) { if (argp->da_name[0] == '.' && (argp->da_name[1] == '\0' || (argp->da_name[1] == '.' && argp->da_name[2] == '\0'))) { +#if 0 + /* + * XXX: increment mtime of parent directory, causes NFS clients to + * invalidate their cache for that directory. + * Some NFS clients may need this code. + */ + if (uid != rootfattr.na_uid) { + clocktime(&rootfattr.na_mtime); + rootfattr.na_uid = uid; + } +#endif res.dr_u.dr_drok_u.drok_fhandle = root; res.dr_u.dr_drok_u.drok_attributes = rootfattr; res.dr_status = NFS_OK; @@ -243,7 +260,7 @@ nfsproc_lookup_2_svc(nfsdiropargs *argp, struct svc_req *rqstp) * so we must update the nt_seconds field every time. */ if (uid != slinkfattr.na_uid) { - slinkfattr.na_mtime.nt_seconds++; + clocktime(&slinkfattr.na_mtime); slinkfattr.na_uid = uid; } #endif /* not MNT2_NFS_OPT_SYMTTL */ @@ -267,15 +284,13 @@ nfsproc_lookup_2_svc(nfsdiropargs *argp, struct svc_req *rqstp) res.dr_u.dr_drok_u.drok_attributes = un_fattr; memset((char *) &un_fhandle, 0, sizeof(am_nfs_fh)); *(u_int *) un_fhandle.fh_data = (u_int) untab[idx].uid; - strncpy((char *) &un_fhandle.fh_data[sizeof(int)], - untab[idx].username, - sizeof(am_nfs_fh) - sizeof(int)); + xstrlcpy((char *) &un_fhandle.fh_data[sizeof(int)], + untab[idx].username, + sizeof(am_nfs_fh) - sizeof(int)); res.dr_u.dr_drok_u.drok_fhandle = un_fhandle; res.dr_status = NFS_OK; -#ifdef DEBUG dlog("nfs_lookup: successful lookup for uid=%ld, gid=%ld: username=%s", (long) uid, (long) gid, untab[idx].username); -#endif /* DEBUG */ return &res; } } /* end of "if (eq_fh(argp->dir.data, root.data)) {" */ @@ -302,7 +317,7 @@ nfsproc_readlink_2_svc(am_nfs_fh *argp, struct svc_req *rqstp) if (getcreds(rqstp, &userid, &groupid, nfsxprt) < 0) return (nfsreadlinkres *) NULL; - gettimeofday((struct timeval *) &slinkfattr.na_atime, (struct timezone *) 0); + clocktime(&slinkfattr.na_atime); res.rlr_status = NFS_OK; if (groupid == hlfs_gid) { @@ -340,7 +355,7 @@ nfsproc_readlink_2_svc(am_nfs_fh *argp, struct svc_req *rqstp) last_uid = userid; } - /* I don't think will pass this if -D nofork */ + /* I don't think it will pass this if -D fork */ if (serverpid == getpid()) return &res; @@ -359,15 +374,13 @@ nfsproc_readlink_2_svc(am_nfs_fh *argp, struct svc_req *rqstp) else retval = 0; -#ifdef DEBUG /* - * If asked for -D nofork, then must return the value, + * If asked for -D fork, then must return the value, * NOT exit, or else the main hlfsd server exits. - * Bug where is that status information being collected? + * Bug: where is that status information being collected? */ - amuDebugNo(D_FORK) + if (amuDebug(D_FORK)) return &res; -#endif /* DEBUG */ exit(retval); } @@ -476,7 +489,7 @@ nfsproc_readdir_2_svc(nfsreaddirargs *argp, struct svc_req *rqstp) if (eq_fh(&argp->rda_fhandle, &slink)) { res.rdr_status = NFSERR_NOTDIR; } else if (eq_fh(&argp->rda_fhandle, &root)) { - gettimeofday((struct timeval *) &rootfattr.na_atime, (struct timezone *) 0); + clocktime(&rootfattr.na_atime); res.rdr_status = NFS_OK; switch (argp->rda_cookie[0]) { diff --git a/contrib/amd/include/am_compat.h b/contrib/amd/include/am_compat.h index c5bc3214e1f0..dc3b71d74468 100644 --- a/contrib/amd/include/am_compat.h +++ b/contrib/amd/include/am_compat.h @@ -1,5 +1,47 @@ /* - * am_compat.h: + * Copyright (c) 1997-2006 Erez Zadok + * Copyright (c) 1990 Jan-Simon Pendry + * Copyright (c) 1990 Imperial College of Science, Technology & Medicine + * Copyright (c) 1990 The Regents of the University of California. + * All rights reserved. + * + * This code is derived from software contributed to Berkeley by + * Jan-Simon Pendry at Imperial College, London. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * 3. All advertising materials mentioning features or use of this software + * must display the following acknowledgment: + * This product includes software developed by the University of + * California, Berkeley and its contributors. + * 4. Neither the name of the University nor the names of its contributors + * may be used to endorse or promote products derived from this software + * without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF + * SUCH DAMAGE. + * + * + * File: am-utils/include/am_compat.h + * + */ + +/* * * This file contains compatibility functions and macros, all of which * should be auto-discovered, but for one reason or another (mostly @@ -59,6 +101,10 @@ # define MNTTAB_OPT_PGTHRESH "pgthresh" #endif /* defined(MNT2_NFS_OPT_PGTHRESH) && !defined(MNTTAB_OPT_PGTHRESH) */ +#if defined(MNT2_NFS_OPT_PRIVATE) && !defined(MNTTAB_OPT_PRIVATE) +# define MNTTAB_OPT_PRIVATE "private" +#endif /* defined(MNT2_NFS_OPT_PRIVATE) && !defined(MNTTAB_OPT_PRIVATE) */ + #if defined(MNT2_NFS_OPT_RETRANS) && !defined(MNTTAB_OPT_RETRANS) # define MNTTAB_OPT_RETRANS "retrans" #endif /* defined(MNT2_NFS_OPT_RETRANS) && !defined(MNTTAB_OPT_RETRANS) */ @@ -94,6 +140,10 @@ # define MNTTAB_OPT_NOLOCK "nolock" #endif /* defined(MNT2_NFS_OPT_NONLM) && !defined(MNTTAB_OPT_NOLOCK) */ +#if defined(MNT2_NFS_OPT_XLATECOOKIE) && !defined(MNTTAB_OPT_XLATECOOKIE) +# define MNTTAB_OPT_XLATECOOKIE "xlatecookie" +#endif /* defined(MNT2_NFS_OPT_XLATECOOKIE) && !defined(MNTTAB_OPT_XLATECOOKIE) */ + /* * Complete MNTTAB_OPT_* options based on MNT2_CDFS_OPT_* mount options. */ @@ -131,6 +181,19 @@ #endif /* defined(MNT2_CDFS_OPT_EXTATT) && !defined(MNTTAB_OPT_EXTATT) */ /* + * Complete MNTTAB_OPT_* options based on MNT2_PCFS_OPT_* mount options. + */ +#if defined(MNT2_PCFS_OPT_LONGNAME) && !defined(MNTTAB_OPT_LONGNAME) +# define MNTTAB_OPT_LONGNAME "longnames" +#endif /* defined(MNT2_PCFS_OPT_LONGNAME) && !defined(MNTTAB_OPT_LONGNAME) */ +#if defined(MNT2_PCFS_OPT_NOWIN95) && !defined(MNTTAB_OPT_NOWIN95) +# define MNTTAB_OPT_NOWIN95 "nowin95" +#endif /* defined(MNT2_PCFS_OPT_NOWIN95) && !defined(MNTTAB_OPT_NOWIN95) */ +#if defined(MNT2_PCFS_OPT_SHORTNAME) && !defined(MNTTAB_OPT_SHORTNAME) +# define MNTTAB_OPT_SHORTNAME "shortnames" +#endif /* defined(MNT2_PCFS_OPT_SHORTNAME) && !defined(MNTTAB_OPT_SHORTNAME) */ + +/* * Complete MNTTAB_OPT_* options based on MNT2_GEN_OPT_* mount options. */ #if defined(MNT2_GEN_OPT_GRPID) && !defined(MNTTAB_OPT_GRPID) @@ -189,6 +252,10 @@ # define MNTTAB_OPT_PORT "port" #endif /* not MNTTAB_OPT_PORT */ +#ifndef MNTTAB_OPT_PUBLIC +# define MNTTAB_OPT_PUBLIC "public" +#endif /* not MNTTAB_OPT_PUBLIC */ + #ifndef MNTTAB_OPT_RETRANS # define MNTTAB_OPT_RETRANS "retrans" #endif /* not MNTTAB_OPT_RETRANS */ @@ -217,6 +284,19 @@ # define MNTTAB_OPT_WSIZE "wsize" #endif /* not MNTTAB_OPT_WSIZE */ +/* next four are useful for pcfs mounts */ +#ifndef MNTTAB_OPT_USER +# define MNTTAB_OPT_USER "user" +#endif /* not MNTTAB_OPT_USER */ +#ifndef MNTTAB_OPT_GROUP +# define MNTTAB_OPT_GROUP "group" +#endif /* not MNTTAB_OPT_GROUP */ +#ifndef MNTTAB_OPT_MASK +# define MNTTAB_OPT_MASK "mask" +#endif /* not MNTTAB_OPT_MASK */ +#ifndef MNTTAB_OPT_DIRMASK +# define MNTTAB_OPT_DIRMASK "dirmask" +#endif /* not MNTTAB_OPT_DIRMASK */ /* * Incomplete filesystem definitions (sunos4, irix6, solaris2) @@ -268,6 +348,10 @@ struct hsfs_args { # define xfs_args_t u_int #endif /* defined(HAVE_FS_XFS) && !defined(xfs_args_t) */ +#if defined(HAVE_FS_AUTOFS) && defined(MOUNT_TYPE_AUTOFS) && !defined(MNTTYPE_AUTOFS) +# define MNTTYPE_AUTOFS "autofs" +#endif /* defined(HAVE_FS_AUTOFS) && defined(MOUNT_TYPE_AUTOFS) && !defined(MNTTYPE_AUTOFS) */ + /* * If NFS3, then make sure that "proto" and "vers" mnttab options * are available. @@ -281,4 +365,29 @@ struct hsfs_args { # endif /* not MNTTAB_OPT_PROTO */ #endif /* not HAVE_FS_NFS3 */ +/* + * If loop device (header file) exists, define mount table option + */ +#if defined(HAVE_LOOP_DEVICE) && !defined(MNTTAB_OPT_LOOP) +# define MNTTAB_OPT_LOOP "loop" +#endif /* defined(HAVE_LOOP_DEVICE) && !defined(MNTTAB_OPT_LOOP) */ + +/* + * Define a dummy struct netconfig for non-TLI systems + */ +#if !defined(HAVE_NETCONFIG_H) && !defined(HAVE_SYS_NETCONFIG_H) +struct netconfig { + int dummy; +}; +#endif /* not HAVE_NETCONFIG_H and not HAVE_SYS_NETCONFIG_H */ + +/* some OSs don't define INADDR_NONE and assume it's unsigned -1 */ +#ifndef INADDR_NONE +# define INADDR_NONE 0xffffffffU +#endif /* INADDR_NONE */ +/* some OSs don't define INADDR_LOOPBACK */ +#ifndef INADDR_LOOPBACK +# define INADDR_LOOPBACK 0x7f000001 +#endif /* not INADDR_LOOPBACK */ + #endif /* not _AM_COMPAT_H */ diff --git a/contrib/amd/include/am_defs.h b/contrib/amd/include/am_defs.h index 35a9d0334b14..c2185dbfd3e6 100644 --- a/contrib/amd/include/am_defs.h +++ b/contrib/amd/include/am_defs.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: am_defs.h,v 1.15.2.16 2004/05/12 15:54:31 ezk Exp $ + * File: am-utils/include/am_defs.h * */ @@ -69,26 +68,6 @@ char *strchr(), *strrchr(), *strdup(); #endif /* not STDC_HEADERS */ -/* AIX requires this to be the first thing in the file. */ -#ifndef __GNUC__ -# if HAVE_ALLOCA_H -# include <alloca.h> -# else /* not HAVE_ALLOCA_H */ -# ifdef _AIX -/* - * This pragma directive is indented so that pre-ANSI C compilers will - * ignore it, rather than choke on it. - */ - #pragma alloca -# else /* not _AIX */ -# ifndef alloca -/* predefined by HP cc +Olibcalls */ -voidp alloca(); -# endif /* not alloca */ -# endif /* not _AIX */ -# endif /* not HAVE_ALLOCA_H */ -#endif /* not __GNUC__ */ - /* * Handle gcc __attribute__ if available. */ @@ -125,6 +104,15 @@ voidp alloca(); */ #if TIME_WITH_SYS_TIME # include <sys/time.h> +# ifdef _ALL_SOURCE +/* + * AIX 5.2 needs struct sigevent from signal.h to be defined, but I + * don't want to move the inclusion of signal.h this early into this + * file. Luckily, amd doesn't need the size of this structure in any + * other structure that it uses. So we sidestep it for now. + */ +struct sigevent; +# endif /* _ALL_SOURCE */ # include <time.h> #else /* not TIME_WITH_SYS_TIME */ # if HAVE_SYS_TIME_H @@ -158,6 +146,13 @@ voidp alloca(); #endif /* HAVE_SYS_TYPES_H */ /* + * Actions to take if HAVE_LIMITS_H is defined. + */ +#if HAVE_LIMITS_H_H +# include <limits.h> +#endif /* HAVE_LIMITS_H */ + +/* * Actions to take if HAVE_UNISTD_H is defined. */ #if HAVE_UNISTD_H @@ -212,6 +207,12 @@ voidp alloca(); * Actions to take if HAVE_FCNTL_H is defined. */ #if HAVE_FCNTL_H +# ifdef HAVE_LINUX_LOOP_H +/* so I can mount large files as loop devices */ +/* XXX: need to move these two LARGEFILE defines to a better place */ +# define _LARGEFILE64_SOURCE +# define __USE_LARGEFILE64 +# endif /* HAVE_LINUX_LOOP_H */ # include <fcntl.h> #endif /* HAVE_FCNTL_H */ @@ -364,6 +365,13 @@ extern int errno; #endif /* HAVE_NET_ERRNO_H */ /* + * Actions to take if <net/if.h> exists. + */ +#ifdef HAVE_NET_IF_H +# include <net/if.h> +#endif /* HAVE_NET_IF_H */ + +/* * Actions to take if <net/route.h> exists. */ #ifdef HAVE_NET_ROUTE_H @@ -397,11 +405,11 @@ extern int errno; #endif /* HAVE_SYS_MBUF_H */ /* - * Actions to take if <net/if.h> exists. + * Actions to take if <sys/mman.h> exists. */ -#ifdef HAVE_NET_IF_H -# include <net/if.h> -#endif /* HAVE_NET_IF_H */ +#ifdef HAVE_SYS_MMAN_H +# include <sys/mman.h> +#endif /* HAVE_SYS_MMAN_H */ /* * Actions to take if <netdb.h> exists. @@ -599,15 +607,77 @@ struct ypall_callback; #endif /* HAVE_CDFS_CDFSMOUNT_H */ /* - * Actions to take if <linux/auto_fs.h> exists. + * Actions to take if <linux/loop.h> exists. + */ +#ifdef HAVE_LINUX_LOOP_H +# ifdef HAVE_LINUX_POSIX_TYPES_H +# include <linux/posix_types.h> +# endif /* HAVE_LINUX_POSIX_TYPES_H */ +/* next dev_t lines needed due to changes in kernel code */ +# undef dev_t +# define dev_t unsigned short /* compatible with Red Hat and SuSE */ +# include <linux/loop.h> +#endif /* HAVE_LINUX_LOOP_H */ + +/* + * AUTOFS PROTOCOL HEADER FILES: + */ + +/* + * Actions to take if <linux/auto_fs[4].h> exists. * We really don't want <linux/fs.h> pulled in here */ #ifndef _LINUX_FS_H #define _LINUX_FS_H #endif /* _LINUX_FS_H */ -#ifdef HAVE_LINUX_AUTO_FS_H -# include <linux/auto_fs.h> -#endif /* HAVE_LINUX_AUTO_FS_H */ +#ifdef HAVE_LINUX_AUTO_FS4_H +# include <linux/auto_fs4.h> +#else /* not HAVE_LINUX_AUTO_FS4_H */ +# ifdef HAVE_LINUX_AUTO_FS_H +# include <linux/auto_fs.h> +# endif /* HAVE_LINUX_AUTO_FS_H */ +#endif /* not HAVE_LINUX_AUTO_FS4_H */ + +/* + * Actions to take if <sys/fs/autofs.h> exists. + */ +#ifdef HAVE_SYS_FS_AUTOFS_H +# include <sys/fs/autofs.h> +#endif /* HAVE_SYS_FS_AUTOFS_H */ + +/* + * Actions to take if <rpcsvc/autofs_prot.h> or <sys/fs/autofs_prot.h> exist. + */ +#ifdef HAVE_RPCSVC_AUTOFS_PROT_H +# include <rpcsvc/autofs_prot.h> +#else /* not HAVE_RPCSVC_AUTOFS_PROT_H */ +# ifdef HAVE_SYS_FS_AUTOFS_PROT_H +# include <sys/fs/autofs_prot.h> +# endif /* HAVE_SYS_FS_AUTOFS_PROT_H */ +#endif /* not HAVE_RPCSVC_AUTOFS_PROT_H */ + +/* + * Actions to take if <lber.h> exists. + * This header file is required before <ldap.h> can be included. + */ +#ifdef HAVE_LBER_H +# include <lber.h> +#endif /* HAVE_LBER_H */ + +/* + * Actions to take if <ldap.h> exists. + */ +#ifdef HAVE_LDAP_H +# include <ldap.h> +#endif /* HAVE_LDAP_H */ + +/**************************************************************************** + ** IMPORTANT!!! ** + ** We always include am-utils' amu_autofs_prot.h. ** + ** That is actually defined in "conf/autofs/autofs_${autofs_style}.h" ** + ****************************************************************************/ +#include <amu_autofs_prot.h> + /* * NFS PROTOCOL HEADER FILES: @@ -622,7 +692,7 @@ struct ypall_callback; /**************************************************************************** ** IMPORTANT!!! ** - ** We always include am-util's amu_nfs_prot.h. ** + ** We always include am-utils' amu_nfs_prot.h. ** ** That is actually defined in "conf/nfs_prot/nfs_prot_${host_os_name}.h" ** ****************************************************************************/ #include <amu_nfs_prot.h> @@ -665,13 +735,29 @@ struct ypall_callback; #ifdef HAVE_SYS_FS_NFS_CLNT_H # include <sys/fs/nfs_clnt.h> #endif /* HAVE_SYS_FS_NFS_CLNT_H */ + +/* complex rules for linux/nfs_mount.h: broken on so many systems */ #ifdef HAVE_LINUX_NFS_MOUNT_H -# define _LINUX_NFS_H -# define _LINUX_NFS2_H -# define _LINUX_NFS3_H -# define _LINUX_NFS_FS_H -# define _LINUX_IN_H +# ifndef _LINUX_NFS_H +# define _LINUX_NFS_H +# endif /* not _LINUX_NFS_H */ +# ifndef _LINUX_NFS2_H +# define _LINUX_NFS2_H +# endif /* not _LINUX_NFS2_H */ +# ifndef _LINUX_NFS3_H +# define _LINUX_NFS3_H +# endif /* not _LINUX_NFS3_H */ +# ifndef _LINUX_NFS_FS_H +# define _LINUX_NFS_FS_H +# endif /* not _LINUX_NFS_FS_H */ +# ifndef _LINUX_IN_H +# define _LINUX_IN_H +# endif /* not _LINUX_IN_H */ +# ifndef __KERNEL__ +# define __KERNEL__ +# endif /* __KERNEL__ */ # include <linux/nfs_mount.h> +# undef __KERNEL__ #endif /* HAVE_LINUX_NFS_MOUNT_H */ /* @@ -689,21 +775,6 @@ struct ypall_callback; #endif /* HAVE_HESIOD_H */ /* - * Actions to take if <lber.h> exists. - * This header file is required before <ldap.h> can be included. - */ -#ifdef HAVE_LBER_H -# include <lber.h> -#endif /* HAVE_LBER_H */ - -/* - * Actions to take if <ldap.h> exists. - */ -#ifdef HAVE_LDAP_H -# include <ldap.h> -#endif /* HAVE_LDAP_H */ - -/* * Actions to take if <arpa/nameser.h> exists. * Should be included before <resolv.h>. */ @@ -736,6 +807,14 @@ struct sockaddr_dl; * Actions to take if <resolv.h> exists. */ #ifdef HAVE_RESOLV_H +/* + * On AIX 5.2, both <resolv.h> and <arpa/nameser_compat.h> define MAXDNAME, + * if compiling with gcc -D_USE_IRS (so that we get extern definitions for + * hstrerror() and others). + */ +# if defined(_AIX) && defined(MAXDNAME) && defined(_USE_IRS) +# undef MAXDNAME +# endif /* defined(_AIX) && defined(MAXDNAME) && defined(_USE_IRS) */ # include <resolv.h> #endif /* HAVE_RESOLV_H */ @@ -768,6 +847,13 @@ struct sockaddr_dl; #endif /* HAVE_MSDOSFS_MSDOSFSMOUNT_H */ /* + * Actions to take if <fs/msdosfs/msdosfsmount.h> exists. + */ +#ifdef HAVE_FS_MSDOSFS_MSDOSFSMOUNT_H +# include <fs/msdosfs/msdosfsmount.h> +#endif /* HAVE_FS_MSDOSFS_MSDOSFSMOUNT_H */ + +/* * Actions to take if <sys/fs/tmp.h> exists. */ #ifdef HAVE_SYS_FS_TMP_H @@ -785,7 +871,7 @@ struct sockaddr_dl; # error causes errors with other header files. Instead, add it to the # error specific conf/nfs_prot_*.h file. # include <ufs/ufs/ufsmount.h> -#endif /* HAVE_UFS_UFS_UFSMOUNT_H */ +#endif /* HAVE_UFS_UFS_UFSMOUNT_H_off */ /* * Actions to take if <sys/fs/efs_clnt.h> exists. @@ -915,6 +1001,22 @@ struct sockaddr_dl; * Actions to take if <rpcsvc/nis.h> exists. */ #ifdef HAVE_RPCSVC_NIS_H +/* + * Solaris 10 (build 72) defines GROUP_OBJ in <sys/acl.h>, which is included + * in many other header files. <rpcsvc/nis.h> uses GROUP_OBJ inside enum + * zotypes. So if you're unlucky enough to include both headers, you get a + * compile error because the two symbols conflict. + * A similar conflict arises with Sun cc and the definition of "GROUP". + * + * Temp hack: undefine acl.h's GROUP_OBJ and GROUP because they're not needed + * for am-utils. + */ +# ifdef GROUP_OBJ +# undef GROUP_OBJ +# endif /* GROUP_OBJ */ +# ifdef GROUP +# undef GROUP +# endif /* GROUP */ # include <rpcsvc/nis.h> #endif /* HAVE_RPCSVC_NIS_H */ @@ -1119,6 +1221,13 @@ extern char *nc_sperror(void); #endif /* HAVE_SYS_STATFS_H */ /* + * Actions to take if <sys/statvfs.h> exists. + */ +#ifdef HAVE_SYS_STATVFS_H +# include <sys/statvfs.h> +#endif /* HAVE_SYS_STATVFS_H */ + +/* * Actions to take if <sys/vfs.h> exists. */ #ifdef HAVE_SYS_VFS_H @@ -1211,6 +1320,13 @@ extern char *nc_sperror(void); # include <regex.h> #endif /* HAVE_REGEX_H */ +/* + * Actions to take if <tcpd.h> exists. + */ +#if defined(HAVE_TCPD_H) && defined(HAVE_LIBWRAP) +# include <tcpd.h> +#endif /* defined(HAVE_TCPD_H) && defined(HAVE_LIBWRAP) */ + /****************************************************************************/ /* @@ -1292,6 +1408,16 @@ typedef struct _am_mntent { # endif /* not HAVE_STRUCT_MNTTAB */ #endif /* not HAVE_STRUCT_MNTENT */ +/* + * Provide FD_* macros for systems that lack them. + */ +#ifndef FD_SET +# define FD_SET(fd, set) (*(set) |= (1 << (fd))) +# define FD_ISSET(fd, set) (*(set) & (1 << (fd))) +# define FD_CLR(fd, set) (*(set) &= ~(1 << (fd))) +# define FD_ZERO(set) (*(set) = 0) +#endif /* not FD_SET */ + /* * Complete external definitions missing from some systems. @@ -1348,6 +1474,10 @@ extern int getpagesize(void); extern char *getwd(char *s); #endif /* not HAVE_EXTERN_GETWD */ +#if defined(HAVE_TCPD_H) && defined(HAVE_LIBWRAP) && !defined(HAVE_EXTERN_HOSTS_CTL) +extern int hosts_ctl(char *daemon, char *client_name, char *client_addr, char *client_user); +#endif /* defined(HAVE_TCPD_H) && defined(HAVE_LIBWRAP) && !defined(HAVE_EXTERN_HOSTS_CTL) */ + #ifndef HAVE_EXTERN_INNETGR extern int innetgr(char *, char *, char *, char *); #endif /* not HAVE_EXTERN_INNETGR */ @@ -1368,6 +1498,10 @@ extern int seteuid(uid_t euid); extern int setitimer(int, struct itimerval *, struct itimerval *); #endif /* defined(HAVE_SETITIMER) && !defined(HAVE_EXTERN_SETITIMER) */ +#ifndef HAVE_EXTERN_SLEEP +extern unsigned int sleep(unsigned int seconds); +#endif /* not HAVE_EXTERN_SETITIMER */ + #ifndef HAVE_EXTERN_STRCASECMP /* * define this extern even if function does not exist, for it will @@ -1384,6 +1518,22 @@ extern int strcasecmp(const char *s1, const char *s2); extern char *strdup(const char *s); #endif /* not HAVE_EXTERN_STRDUP */ +#ifndef HAVE_EXTERN_STRLCAT +/* + * define this extern even if function does not exist, for it will + * be filled in by libamu/strlcat.c + */ +extern size_t strlcat(char *dst, const char *src, size_t siz); +#endif /* not HAVE_EXTERN_STRLCAT */ + +#ifndef HAVE_EXTERN_STRLCPY +/* + * define this extern even if function does not exist, for it will + * be filled in by libamu/strlcpy.c + */ +extern size_t strlcpy(char *dst, const char *src, size_t siz); +#endif /* not HAVE_EXTERN_STRLCPY */ + #if defined(HAVE_STRSTR) && !defined(HAVE_EXTERN_STRSTR) extern char *strstr(const char *s1, const char *s2); #endif /* defined(HAVE_STRSTR) && !defined(HAVE_EXTERN_STRSTR) */ @@ -1419,11 +1569,11 @@ extern bool_t xdr_opaque_auth(XDR *xdrs, struct opaque_auth *auth); #ifdef THIS_HEADER_FILE_IS_INCLUDED_ABOVE # include <amu_nfs_prot.h> #endif /* THIS_HEADER_FILE_IS_INCLUDED_ABOVE */ +#include <am_compat.h> +#include <am_xdr_func.h> #include <am_utils.h> #include <amq_defs.h> #include <aux_conf.h> -/* compatibility with old amd, while autoconfiscating it */ -#include <am_compat.h> /****************************************************************************/ @@ -1432,14 +1582,14 @@ extern bool_t xdr_opaque_auth(XDR *xdrs, struct opaque_auth *auth); * and those are probably declared in any of the above headers. */ -#ifndef HAVE_HASMNTOPT -extern char *hasmntopt(mntent_t *mnt, char *opt); +#ifdef HAVE_HASMNTOPT +# ifdef HAVE_BAD_HASMNTOPT +extern char *amu_hasmntopt(mntent_t *mnt, char *opt); +# else /* not HAVE_BAD_HASMNTOPT */ +# define amu_hasmntopt hasmntopt +# endif /* not HAVE_BAD_HASMNTOPT */ +#else /* not HAVE_HASMNTOPT */ +extern char *amu_hasmntopt(mntent_t *mnt, char *opt); #endif /* not HAVE_HASMNTOPT */ -/* - * include definitions of all possible xdr functions that are otherwise - * not defined elsewhere. - */ -#include <am_xdr_func.h> - #endif /* not _AM_DEFS_H */ diff --git a/contrib/amd/include/am_utils.h b/contrib/amd/include/am_utils.h index 0549186a7185..b7e55ce33e2c 100644 --- a/contrib/amd/include/am_utils.h +++ b/contrib/amd/include/am_utils.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: am_utils.h,v 1.11.2.13 2004/01/06 03:15:24 ezk Exp $ + * File: am-utils/include/am_utils.h * */ @@ -50,6 +49,8 @@ #define _AM_UTILS_H +#include "aux_conf.h" + /**************************************************************************/ /*** MACROS ***/ /**************************************************************************/ @@ -111,16 +112,9 @@ #define XLOG_DEFSTR "all,nomap,nostats" /* Default log options */ #define XLOG_ALL (XLOG_FATAL|XLOG_ERROR|XLOG_USER|XLOG_WARNING|XLOG_INFO|XLOG_MAP|XLOG_STATS) -#define clocktime() (clock_valid ? clock_valid : time(&clock_valid)) - -#ifndef ROOT_MAP -# define ROOT_MAP "\"root\"" -#endif /* not ROOT_MAP */ - -#define NO_SUBNET "notknown" /* default subnet name for no subnet */ -#define NEXP_AP (1022) /* gdmr: was 254 */ -#define NEXP_AP_MARGIN (128) -#define MAX_READDIR_ENTRIES 16 +#define NO_SUBNET "notknown" /* default subnet name for no subnet */ +#define NEXP_AP (1022) /* gdmr: was 254 */ +#define NEXP_AP_MARGIN (128) /* ???? not used */ /* * Linked list macros @@ -135,82 +129,30 @@ /* allocate anything of type ty */ #define ALLOC(ty) ((ty *) xmalloc(sizeof(ty))) -#define CALLOC(ty) ((ty *) xcalloc(1, sizeof(ty))) +#define CALLOC(ty) ((ty *) xzalloc(sizeof(ty))) /* simply allocate b bytes */ #define SALLOC(b) xmalloc((b)) -/* converting am-filehandles to mount-points */ -#define fh_to_mp2(fhp, rp) fh_to_mp3(fhp, rp, VLOOK_CREATE) - /* * Systems which have the mount table in a file need to read it before * they can perform an unmount() system call. */ -#define UMOUNT_FS(dir, mtb_name) umount_fs(dir, mtb_name) -/* imported via $srcdir/conf/umount/umount_*.c */ -extern int umount_fs(char *fs_name, const char *mnttabname); - -/* - * macros for automounter vfs/vnode operations. - */ -#define VLOOK_CREATE 0x1 -#define VLOOK_DELETE 0x2 -#define FS_DIRECTORY 0x0001 /* This looks like a dir, not a link */ -#define FS_MBACKGROUND 0x0002 /* Should background this mount */ -#define FS_NOTIMEOUT 0x0004 /* Don't bother with timeouts */ -#define FS_MKMNT 0x0008 /* Need to make the mount point */ -#define FS_UBACKGROUND 0x0010 /* Unmount in background */ -#define FS_BACKGROUND (FS_MBACKGROUND|FS_UBACKGROUND) -#define FS_DISCARD 0x0020 /* Discard immediately on last reference */ -#define FS_AMQINFO 0x0040 /* Amq is interested in this fs type */ +#define UMOUNT_FS(dir, mtb_name, unmount_flags) umount_fs(dir, mtb_name, unmount_flags) +/* next two are imported via $srcdir/conf/umount/umount_*.c */ +extern int umount_fs(char *mntdir, const char *mnttabname, u_int unmount_flags); +#ifdef MNT2_GEN_OPT_FORCE +extern int umount2_fs(const char *mntdir, u_int unmount_flags); +#endif /* MNT2_GEN_OPT_FORCE */ -/* - * macros for struct fserver. - */ -#define FSF_VALID 0x0001 /* Valid information available */ -#define FSF_DOWN 0x0002 /* This fileserver is thought to be down */ -#define FSF_ERROR 0x0004 /* Permanent error has occurred */ -#define FSF_WANT 0x0008 /* Want a wakeup call */ -#define FSF_PINGING 0x0010 /* Already doing pings */ -#define FSRV_ISDOWN(fs) (((fs)->fs_flags & (FSF_DOWN|FSF_VALID)) == (FSF_DOWN|FSF_VALID)) -#define FSRV_ISUP(fs) (((fs)->fs_flags & (FSF_DOWN|FSF_VALID)) == (FSF_VALID)) - -/* - * macros for struct mntfs (list of mounted filesystems) - */ -#define MFF_MOUNTED 0x0001 /* Node is mounted */ -#define MFF_MOUNTING 0x0002 /* Mount is in progress */ -#define MFF_UNMOUNTING 0x0004 /* Unmount is in progress */ -#define MFF_RESTART 0x0008 /* Restarted node */ -#define MFF_MKMNT 0x0010 /* Delete this node's am_mount */ -#define MFF_ERROR 0x0020 /* This node failed to mount */ -#define MFF_LOGDOWN 0x0040 /* Logged that this mount is down */ -#define MFF_RSTKEEP 0x0080 /* Don't timeout this filesystem - restarted */ -#define MFF_WANTTIMO 0x0100 /* Need a timeout call when not busy */ -#ifdef HAVE_AMU_FS_NFSL -# define MFF_NFSLINK 0x0200 /* nfsl type, and deemed a link */ -#endif /* HAVE_AMU_FS_NFSL */ - -/* - * macros for struct am_node (map of auto-mount points). - */ -#define AMF_NOTIMEOUT 0x0001 /* This node never times out */ -#define AMF_ROOT 0x0002 /* This is a root node */ -#define AMF_AUTOFS 0x0004 /* This node is of type autofs -- not yet supported */ +/* unmount-related flags (special handling of autofs, forced/lazy, etc.) */ +#define AMU_UMOUNT_FORCE 0x1 +#define AMU_UMOUNT_DETACH 0x2 +#define AMU_UMOUNT_AUTOFS 0x4 /* * The following values can be tuned... */ #define ALLOWED_MOUNT_TIME 40 /* 40s for a mount */ -#define AM_TTL (5 * 60) /* Default cache period */ -#define AM_TTL_W (2 * 60) /* Default unmount interval */ -#define AM_PINGER 30 /* NFS ping interval for live systems */ -#define AMFS_AUTO_TIMEO 8 /* Default amfs_auto timeout - .8s */ - -/* - * default amfs_auto retrans - 1/10th seconds - */ -#define AMFS_AUTO_RETRANS ((ALLOWED_MOUNT_TIME*10+5*gopt.amfs_auto_timeo)/gopt.amfs_auto_timeo * 2) /* * RPC-related macros. @@ -218,6 +160,7 @@ extern int umount_fs(char *fs_name, const char *mnttabname); #define RPC_XID_PORTMAP 0 #define RPC_XID_MOUNTD 1 #define RPC_XID_NFSPING 2 +#define RPC_XID_WEBNFS 3 #define RPC_XID_MASK (0x0f) /* 16 id's for now */ #define MK_RPC_XID(type_id, uniq) ((type_id) | ((uniq) << 4)) @@ -228,20 +171,6 @@ extern int umount_fs(char *fs_name, const char *mnttabname); */ #define AMD_COMPAT 5000000 /* 5.0 */ -/* - * Error to return if remote host is not available. - * Try, in order, "host down", "host unreachable", "invalid argument". - */ -#ifdef EHOSTDOWN -# define AM_ERRNO_HOST_DOWN EHOSTDOWN -# else /* not EHOSTDOWN */ -# ifdef EHOSTUNREACH -# define AM_ERRNO_HOST_DOWN EHOSTUNREACH -# else /* not EHOSTUNREACH */ -# define AM_ERRNO_HOST_DOWN EINVAL -# endif /* not EHOSTUNREACH */ -#endif /* not EHOSTDOWN */ - /**************************************************************************/ /*** STRUCTURES AND TYPEDEFS ***/ @@ -249,13 +178,8 @@ extern int umount_fs(char *fs_name, const char *mnttabname); /* some typedefs must come first */ typedef char *amq_string; -typedef struct mntfs mntfs; -typedef struct am_opts am_opts; -typedef struct am_ops am_ops; -typedef struct am_node am_node; typedef struct _qelem qelem; typedef struct mntlist mntlist; -typedef struct fserver fserver; /* * Linked list @@ -285,120 +209,6 @@ typedef enum { Done } serv_state; -/* - * Options - */ -struct am_opts { - char *fs_glob; /* Smashed copy of global options */ - char *fs_local; /* Expanded copy of local options */ - char *fs_mtab; /* Mount table entry */ - /* Other options ... */ - char *opt_dev; - char *opt_delay; - char *opt_dir; - char *opt_fs; - char *opt_group; - char *opt_mount; - char *opt_opts; - char *opt_remopts; - char *opt_pref; - char *opt_cache; - char *opt_rfs; - char *opt_rhost; - char *opt_sublink; - char *opt_type; - char *opt_unmount; - char *opt_user; - char *opt_maptype; /* map type: file, nis, hesiod, etc. */ - char *opt_cachedir; /* cache directory */ - char *opt_addopts; /* options to add to opt_opts */ -}; - -/* - * List of mounted filesystems - */ -struct mntfs { - qelem mf_q; /* List of mounted filesystems */ - am_ops *mf_ops; /* Operations on this mountpoint */ - am_opts *mf_fo; /* File opts */ - char *mf_mount; /* "/a/kiska/home/kiska" */ - char *mf_info; /* Mount info */ - char *mf_auto; /* Automount opts */ - char *mf_mopts; /* FS mount opts */ - char *mf_remopts; /* Remote FS mount opts */ - fserver *mf_server; /* File server */ - int mf_flags; /* Flags MFF_* */ - int mf_error; /* Error code from background mount */ - int mf_refc; /* Number of references to this node */ - int mf_cid; /* Callout id */ - void (*mf_prfree) (voidp); /* Free private space */ - voidp mf_private; /* Private - per-fs data */ -}; - -/* - * File Handle - * - * This is interpreted by indexing the exported array - * by fhh_id. - * - * The whole structure is mapped onto a standard fhandle_t - * when transmitted. - */ -struct am_fh { - int fhh_pid; /* process id */ - int fhh_id; /* map id */ - int fhh_gen; /* generation number */ -}; - -/* - * Multi-protocol NFS file handle - */ -union am_nfs_handle { - /* placeholder for V4 file handle */ -#ifdef HAVE_FS_NFS3 - struct mountres3 v3; /* NFS version 3 handle */ -#endif /* HAVE_FS_NFS3 */ - struct fhstatus v2; /* NFS version 2 handle */ -}; -typedef union am_nfs_handle am_nfs_handle_t; - -/* - * automounter vfs/vnode operations. - */ -typedef char *(*vfs_match) (am_opts *); -typedef int (*vfs_init) (mntfs *); -typedef int (*vmount_fs) (am_node *); -typedef int (*vfmount_fs) (mntfs *); -typedef int (*vumount_fs) (am_node *); -typedef int (*vfumount_fs) (mntfs *); -typedef am_node *(*vlookuppn) (am_node *, char *, int *, int); -typedef int (*vreaddir) (am_node *, nfscookie, nfsdirlist *, nfsentry *, int); -typedef am_node *(*vreadlink) (am_node *, int *); -typedef void (*vmounted) (mntfs *); -typedef void (*vumounted) (am_node *); -typedef fserver *(*vffserver) (mntfs *); - -struct am_ops { - char *fs_type; /* type of filesystems "nfsx" */ - vfs_match fs_match; /* fxn: match */ - vfs_init fs_init; /* fxn: initialization */ - vmount_fs mount_fs; /* fxn: mount vnode */ - vfmount_fs fmount_fs; /* fxn: mount VFS */ - vumount_fs umount_fs; /* fxn: unmount vnode */ - vfumount_fs fumount_fs; /* fxn: unmount VFS */ - vlookuppn lookuppn; /* fxn: lookup path-name */ - vreaddir readdir; /* fxn: read directory */ - vreadlink readlink; /* fxn: read link */ - vmounted mounted; /* fxn: after-mount extra actions */ - vumounted umounted; /* fxn: after-umount extra actions */ - vffserver ffserver; /* fxn: find a file server */ - int fs_flags; /* filesystem flags FS_* */ -}; - -typedef int (*task_fun) (voidp); -typedef void (*cb_fun) (int, int, voidp); -typedef void (*fwd_fun) P((voidp, int, struct sockaddr_in *, - struct sockaddr_in *, voidp, int)); /* * List of mount table entries @@ -413,76 +223,6 @@ struct mntlist { */ typedef struct mnt_map mnt_map; -/* - * Per-mountpoint statistics - */ -struct am_stats { - time_t s_mtime; /* Mount time */ - u_short s_uid; /* Uid of mounter */ - int s_getattr; /* Count of getattrs */ - int s_lookup; /* Count of lookups */ - int s_readdir; /* Count of readdirs */ - int s_readlink; /* Count of readlinks */ - int s_statfs; /* Count of statfs */ -}; -typedef struct am_stats am_stats; - -/* - * System statistics - */ -struct amd_stats { - int d_drops; /* Dropped requests */ - int d_stale; /* Stale NFS handles */ - int d_mok; /* Successful mounts */ - int d_merr; /* Failed mounts */ - int d_uerr; /* Failed unmounts */ -}; -extern struct amd_stats amd_stats; - -/* - * List of fileservers - */ -struct fserver { - qelem fs_q; /* List of fileservers */ - int fs_refc; /* Number of references to this node */ - char *fs_host; /* Normalized hostname of server */ - struct sockaddr_in *fs_ip; /* Network address of server */ - int fs_cid; /* Callout id */ - int fs_pinger; /* Ping (keepalive) interval */ - int fs_flags; /* Flags */ - char *fs_type; /* File server type */ - u_long fs_version; /* NFS version of server (2, 3, etc.)*/ - char *fs_proto; /* NFS protocol of server (tcp, udp, etc.) */ - voidp fs_private; /* Private data */ - void (*fs_prfree) (voidp); /* Free private data */ -}; - -/* - * Map of auto-mount points. - */ -struct am_node { - int am_mapno; /* Map number */ - mntfs *am_mnt; /* Mounted filesystem */ - char *am_name; /* "kiska": name of this node */ - char *am_path; /* "/home/kiska": path of this node's mount point */ - char *am_link; /* "/a/kiska/home/kiska/this/that": link to sub-dir */ - am_node *am_parent; /* Parent of this node */ - am_node *am_ysib; /* Younger sibling of this node */ - am_node *am_osib; /* Older sibling of this node */ - am_node *am_child; /* First child of this node */ - nfsattrstat am_attr; /* File attributes */ -#define am_fattr am_attr.ns_u.ns_attr_u - int am_flags; /* Boolean flags AMF_* */ - int am_error; /* Specific mount error */ - time_t am_ttl; /* Time to live */ - int am_timeo_w; /* Wait interval */ - int am_timeo; /* Timeout interval */ - u_int am_gen; /* Generation number */ - char *am_pref; /* Mount info prefix */ - am_stats am_stats; /* Statistics gathering */ - SVCXPRT *am_transp; /* Info for quick reply */ -}; - /**************************************************************************/ /*** EXTERNALS ***/ @@ -496,8 +236,6 @@ extern char *cpu; /* "CPU type" */ extern char *endian; /* "big" */ extern char *hostdomain; /* "southseas.nz" */ extern char copyright[]; /* Copyright info */ -extern char hostd[]; /* "kiska.southseas.nz" */ -extern char pid_fsname[]; /* kiska.southseas.nz:(pid%d) */ extern char version[]; /* Version info */ /* @@ -506,8 +244,6 @@ extern char version[]; /* Version info */ extern AUTH *nfs_auth; /* Dummy authorization for remote servers */ extern FILE *logfp; /* Log file */ extern SVCXPRT *nfsxprt; -extern am_node **exported_ap; /* List of nodes */ -extern am_node *root_node; /* Node for "root" */ extern char *PrimNetName; /* Name of primary connected network */ extern char *PrimNetNum; /* Name of primary connected network */ extern char *SubsNetName; /* Name of subsidiary connected network */ @@ -520,20 +256,13 @@ extern const char *am_get_hostname(void); extern pid_t am_set_mypid(void); extern pid_t am_mypid; -extern int first_free_map; /* First free node */ extern int foreground; /* Foreground process */ -extern int immediate_abort; /* Should close-down unmounts be retried */ -extern int last_used_map; /* Last map being used for mounts */ extern int orig_umask; /* umask() on startup */ -extern int task_notify_todo; /* Task notifier needs running */ extern int xlog_level; /* Logging level */ extern int xlog_level_init; extern serv_state amd_state; /* Should we go now */ extern struct in_addr myipaddr; /* (An) IP address of this host */ extern struct opt_tab xlog_opt[]; -extern time_t clock_valid; /* Clock needs recalculating */ -extern time_t do_mapc_reload; /* Flush & reload mount map cache */ -extern time_t next_softclock; /* Time to call softclock() */ extern u_short nfs_port; /* Our NFS service port */ /* @@ -541,134 +270,92 @@ extern u_short nfs_port; /* Our NFS service port */ */ extern CLIENT *get_mount_client(char *unused_host, struct sockaddr_in *sin, struct timeval *tv, int *sock, u_long mnt_version); extern RETSIGTYPE sigchld(int); -extern am_node *efs_lookuppn(am_node *, char *, int *, int); -extern am_node *exported_ap_alloc(void); -extern am_node *fh_to_mp(am_nfs_fh *); -extern am_node *fh_to_mp3(am_nfs_fh *, int *, int); -extern am_node *find_mf(mntfs *); -extern am_node *next_map(int *); -extern am_node *root_ap(char *, int); -extern am_ops *ops_match(am_opts *, char *, char *, char *, char *, char *); extern bool_t xdr_amq_string(XDR *xdrs, amq_string *objp); extern bool_t xdr_dirpath(XDR *xdrs, dirpath *objp); extern char **strsplit(char *, int, int); -extern char *expand_key(char *); +extern char *expand_selectors(char *); extern char *get_version_string(void); -extern char *inet_dquad(char *, u_long); +extern char *inet_dquad(char *, size_t, u_long); extern char *print_wires(void); extern char *str3cat(char *, char *, char *, char *); extern char *strealloc(char *, char *); extern char *strip_selectors(char *, char *); extern char *strnsave(const char *, int); -extern fserver *dup_srvr(fserver *); extern int amu_close(int fd); -extern int background(void); extern int bind_resv_port(int, u_short *); extern int cmdoption(char *, struct opt_tab *, int *); extern int compute_automounter_mount_flags(mntent_t *); extern int compute_mount_flags(mntent_t *); -extern int efs_readdir(am_node *, nfscookie, nfsdirlist *, nfsentry *, int); -extern int eval_fs_opts(am_opts *, char *, char *, char *, char *, char *); -extern int fwd_init(void); -extern int fwd_packet(int, voidp, int, struct sockaddr_in *, struct sockaddr_in *, voidp, fwd_fun); extern int get_amd_program_number(void); extern int getcreds(struct svc_req *, uid_t *, gid_t *, SVCXPRT *); extern int hasmntval(mntent_t *, char *); +extern unsigned int hasmntvalerr(mntent_t *, char *, int *); +extern char *hasmntstr(mntent_t *, char *); extern char *hasmnteq(mntent_t *, char *); extern char *haseq(char *); extern int is_network_member(const char *net); +extern int is_interface_local(u_long); extern int islocalnet(u_long); -extern int make_nfs_auth(void); extern int make_rpc_packet(char *, int, u_long, struct rpc_msg *, voidp, XDRPROC_T_TYPE, AUTH *); -extern int mapc_keyiter(mnt_map *, void(*)(char *, voidp), voidp); -extern int mapc_search(mnt_map *, char *, char **); -extern int mapc_type_exists(const char *type); extern int mkdirs(char *, int); -extern int mount_auto_node(char *, voidp); -extern int mount_automounter(int); -extern int mount_exported(void); -extern int mount_fs(mntent_t *, int, caddr_t, int, MTYPE_TYPE, u_long, const char *, const char *); -extern int mount_node(am_node *); -extern int nfs_srvr_port(fserver *, u_short *, voidp); +extern int mount_fs(mntent_t *, int, caddr_t, int, MTYPE_TYPE, u_long, const char *, const char *, int); +extern void nfs_program_2(struct svc_req *rqstp, SVCXPRT *transp); extern int pickup_rpc_reply(voidp, int, voidp, XDRPROC_T_TYPE); -extern int root_keyiter(void(*)(char *, voidp), voidp); -extern int softclock(void); extern int switch_option(char *); -extern int switch_to_logfile(char *logfile, int orig_umask); -extern int timeout(u_int, void (*fn)(voidp), voidp); -extern int valid_key(char *); -extern mnt_map *mapc_find(char *, char *, const char *); -extern mntfs *dup_mntfs(mntfs *); -extern mntfs *find_mntfs(am_ops *, am_opts *, char *, char *, char *, char *, char *); -extern mntfs *new_mntfs(void); -extern mntfs *realloc_mntfs(mntfs *, am_ops *, am_opts *, char *, char *, char *, char *, char *); +extern int switch_to_logfile(char *logfile, int orig_umask, int truncate_log); extern mntlist *read_mtab(char *, const char *); +#ifndef HAVE_TRANSPORT_TYPE_TLI extern struct sockaddr_in *amu_svc_getcaller(SVCXPRT *xprt); +#endif /* not HAVE_TRANSPORT_TYPE_TLI */ extern time_t time(time_t *); -extern void am_mounted(am_node *); -extern void am_unmounted(am_node *); -extern void amq_program_1(struct svc_req *rqstp, SVCXPRT *transp); -extern void amu_get_myaddress(struct in_addr *iap); +extern void amu_get_myaddress(struct in_addr *iap, const char *preferred_localhost); extern void amu_release_controlling_tty(void); extern void compute_automounter_nfs_args(nfs_args_t *nap, mntent_t *mntp); -extern void deslashify(char *); extern void discard_mntlist(mntlist *mp); -extern void do_task_notify(void); -extern void flush_mntfs(void); -extern void flush_nfs_fhandle_cache(fserver *); -extern void forcibly_timeout_mp(am_node *); -extern void free_map(am_node *); -extern void free_mntfs(voidp); extern void free_mntlist(mntlist *); -extern void free_opts(am_opts *); -extern void free_srvr(fserver *); -extern void fwd_reply(void); -extern void get_args(int argc, char *argv[]); extern void getwire(char **name1, char **number1); extern void going_down(int); -extern void host_normalize(char **); -extern void init_map(am_node *, char *); -extern void ins_que(qelem *, qelem *); -extern void insert_am(am_node *, am_node *); -extern void make_root_node(void); -extern void map_flush_srvr(fserver *); -extern void mapc_add_kv(mnt_map *, char *, char *); -extern void mapc_free(voidp); -extern void mapc_reload(void); -extern void mapc_showtypes(char *buf); -extern void mk_fattr(am_node *, nfsftype); extern void mnt_free(mntent_t *); -extern void mp_to_fh(am_node *, am_nfs_fh *); -extern void new_ttl(am_node *); -extern void nfs_program_2(struct svc_req *rqstp, SVCXPRT *transp); -extern void normalize_slash(char *); -extern void ops_showamfstypes(char *buf); -extern void ops_showfstypes(char *outbuf); extern void plog(int, const char *,...) __attribute__ ((__format__ (__printf__, 2, 3))); -extern void rem_que(qelem *); -extern void reschedule_timeout_mp(void); -extern void restart(void); extern void rmdirs(char *); extern void rpc_msg_init(struct rpc_msg *, u_long, u_long, u_long); -extern void run_task(task_fun, voidp, cb_fun, voidp); -extern void sched_task(cb_fun, voidp, voidp); extern void set_amd_program_number(int program); extern void show_opts(int ch, struct opt_tab *); -extern void show_rcs_info(const char *, char *); -extern void srvrlog(fserver *, char *); -extern void timeout_mp(voidp); -extern void umount_exported(void); extern void unregister_amq(void); -extern void untimeout(int); -extern void wakeup(voidp); -extern void wakeup_srvr(fserver *); -extern void wakeup_task(int, int, voidp); extern voidp xmalloc(int); extern voidp xrealloc(voidp, int); extern voidp xzalloc(int); +extern int check_pmap_up(char *host, struct sockaddr_in* sin); extern u_long get_nfs_version(char *host, struct sockaddr_in *sin, u_long nfs_version, const char *proto); +extern long get_server_pid(void); +extern void setup_sighandler(int signum, void (*handler)(int)); +extern time_t clocktime(nfstime *nt); + +#if defined(DEBUG) && (defined(HAVE_C99_VARARGS_MACROS) || defined(HAVE_GCC_VARARGS_MACROS)) +# ifdef HAVE_C99_VARARGS_MACROS +#define xsnprintf(str,size,fmt,...) _xsnprintf(__FILE__,__LINE__,(str),(size),(fmt),__VA_ARGS__) +# endif /* HAVE_C99_VARARGS_MACROS */ +# ifdef HAVE_GCC_VARARGS_MACROS +#define xsnprintf(str,size,fmt,args...) _xsnprintf(__FILE__,__LINE__,(str),(size),(fmt),args) +# endif /* HAVE_GCC_VARARGS_MACROS */ +extern int _xsnprintf(const char *filename, int lineno, char *str, size_t size, const char *format, ...); +#define xvsnprintf(str,size,fmt,ap) _xvsnprintf(__FILE__,__LINE__,(str),(size),(fmt),(ap)) +extern int _xvsnprintf(const char *filename, int lineno, char *str, size_t size, const char *format, va_list ap); +#else /* not DEBUG or no C99/GCC-style vararg cpp macros supported */ +extern int xsnprintf(char *str, size_t size, const char *format, ...); +extern int xvsnprintf(char *str, size_t size, const char *format, va_list ap); +#endif /* not DEBUG or no C99/GCC-style vararg cpp macros supported */ +#ifdef DEBUG +extern void _xstrlcat(const char *filename, int lineno, char *dst, const char *src, size_t len); +# define xstrlcat(d,s,l) _xstrlcat(__FILE__,__LINE__,(d),(s),(l)) +extern void _xstrlcpy(const char *filename, int lineno, char *dst, const char *src, size_t len); +# define xstrlcpy(d,s,l) _xstrlcpy(__FILE__,__LINE__,(d),(s),(l)) +#else /* not DEBUG */ +extern void xstrlcat(char *dst, const char *src, size_t len); +extern void xstrlcpy(char *dst, const char *src, size_t len); +#endif /* not DEBUG */ #ifdef MOUNT_TABLE_ON_FILE extern void rewrite_mtab(mntlist *, const char *); @@ -680,83 +367,30 @@ extern void write_mntent(mntent_t *, const char *); extern int syslogging; #endif /* defined(HAVE_SYSLOG_H) || defined(HAVE_SYS_SYSLOG_H) */ -#ifdef HAVE_TRANSPORT_TYPE_TLI - extern void compute_nfs_args(nfs_args_t *nap, mntent_t *mntp, int genflags, struct netconfig *nfsncp, struct sockaddr_in *ip_addr, u_long nfs_version, char *nfs_proto, am_nfs_handle_t *fhp, char *host_name, char *fs_name); -extern int create_amq_service(int *udp_soAMQp, SVCXPRT **udp_amqpp, struct netconfig **udp_amqncpp, int *tcp_soAMQp, SVCXPRT **tcp_amqpp, struct netconfig **tcp_amqncpp); +extern int create_amq_service(int *udp_soAMQp, SVCXPRT **udp_amqpp, struct netconfig **udp_amqncpp, int *tcp_soAMQp, SVCXPRT **tcp_amqpp, struct netconfig **tcp_amqncpp, u_short preferred_amq_port); extern int create_nfs_service(int *soNFSp, u_short *nfs_portp, SVCXPRT **nfs_xprtp, void (*dispatch_fxn)(struct svc_req *rqstp, SVCXPRT *transp)); +extern int amu_svc_register(SVCXPRT *, u_long, u_long, void (*)(struct svc_req *, SVCXPRT *), u_long, struct netconfig *); + +#ifdef HAVE_TRANSPORT_TYPE_TLI + extern int get_knetconfig(struct knetconfig **kncpp, struct netconfig *in_ncp, char *nc_protoname); extern struct netconfig *nfsncp; extern void free_knetconfig(struct knetconfig *kncp); -#else /* not HAVE_TRANSPORT_TYPE_TLI */ +#endif /* HAVE_TRANSPORT_TYPE_TLI */ -extern void compute_nfs_args(nfs_args_t *nap, mntent_t *mntp, int genflags, struct sockaddr_in *ip_addr, u_long nfs_version, char *nfs_proto, am_nfs_handle_t *fhp, char *host_name, char *fs_name); -extern enum clnt_stat pmap_ping(struct sockaddr_in *address); -extern int create_amq_service(int *udp_soAMQp, SVCXPRT **udp_amqpp, int *tcp_soAMQp, SVCXPRT **tcp_amqpp); -extern int create_nfs_service(int *soNFSp, u_short *nfs_portp, SVCXPRT **nfs_xprtp, void (*dispatch_fxn)(struct svc_req *rqstp, SVCXPRT *transp)); +#ifdef HAVE_FS_AUTOFS +extern int register_autofs_service(char *autofs_conftype, void (*autofs_dispatch)(struct svc_req *rqstp, SVCXPRT *xprt)); +extern int unregister_autofs_service(char *autofs_conftype); +#endif /* HAVE_FS_AUTOFS */ -#endif /* not HAVE_TRANSPORT_TYPE_TLI */ #ifndef HAVE_STRUCT_FHSTATUS_FHS_FH # define fhs_fh fhstatus_u.fhs_fhandle #endif /* not HAVE_STRUCT_FHSTATUS_FHS_FH */ -/**************************************************************************/ -/*** Generic file-system types, implemented as part of the native O/S. ***/ -/**************************************************************************/ - -/* - * Loopback File System - * Many systems can't support this, and in any case most of the - * functionality is available with Symlink FS. - */ -#ifdef HAVE_FS_LOFS -extern am_ops lofs_ops; -#endif /* HAVE_FS_LOFS */ - -/* - * CD-ROM File System (CD-ROM) - * (HSFS: High Sierra F/S on some machines) - * Many systems can't support this, and in any case most of the - * functionality is available with program FS. - */ -#ifdef HAVE_FS_CDFS -extern am_ops cdfs_ops; -#endif /* HAVE_FS_CDFS */ - -/* - * PC File System (MS-DOS) - * Many systems can't support this, and in any case most of the - * functionality is available with program FS. - */ -#ifdef HAVE_FS_PCFS -extern am_ops pcfs_ops; -#endif /* HAVE_FS_PCFS */ - -/* - * Caching File System (Solaris) - */ -#ifdef HAVE_FS_CACHEFS -extern am_ops cachefs_ops; -#endif /* HAVE_FS_CACHEFS */ - -/* - * Network File System - * Good, slow, NFS V.2. - */ -#ifdef HAVE_FS_NFS -extern am_ops nfs_ops; /* NFS */ -extern fserver *find_nfs_srvr (mntfs *); -extern int nfs_fmount(mntfs *mf); -extern int nfs_fumount(mntfs *mf); -extern int nfs_init(mntfs *mf); -extern qelem nfs_srvr_list; -extern void nfs_umounted(am_node *mp); -#endif /* HAVE_FS_NFS */ - - /* * Network File System: the new generation * NFS V.3 @@ -767,124 +401,6 @@ extern void nfs_umounted(am_node *mp); # endif /* not NFS_VERSION3 */ #endif /* HAVE_FS_NFS3 */ -/* - * Un*x File System - * Normal local disk file system. - */ -#ifdef HAVE_FS_UFS -extern am_ops ufs_ops; /* Un*x file system */ -#endif /* HAVE_FS_UFS */ - - -/**************************************************************************/ -/*** Automounter file-system types, implemented by amd. ***/ -/**************************************************************************/ - -/* - * Automount File System - */ -#ifdef HAVE_AMU_FS_AUTO -extern am_ops amfs_auto_ops; /* Automount file system (this!) */ -extern am_ops amfs_toplvl_ops; /* Top-level automount file system */ -extern am_ops amfs_root_ops; /* Root file system */ -extern qelem amfs_auto_srvr_list; -extern am_node *amfs_auto_lookuppn(am_node *mp, char *fname, int *error_return, int op); -extern am_node *next_nonerror_node(am_node *xp); -extern char *amfs_auto_match(am_opts *fo); -extern fserver *find_amfs_auto_srvr(mntfs *); -extern int amfs_auto_readdir(am_node *mp, nfscookie cookie, nfsdirlist *dp, nfsentry *ep, int count); -extern int amfs_auto_umount(am_node *mp); -extern int amfs_auto_fmount(am_node *mp); -extern int amfs_auto_fumount(am_node *mp); -#endif /* HAVE_AMU_FS_AUTO */ - -/* - * Toplvl Automount File System - */ -#ifdef HAVE_AMU_FS_TOPLVL -extern am_ops amfs_toplvl_ops; /* Toplvl Automount file system */ -extern int amfs_toplvl_mount(am_node *mp); -extern int amfs_toplvl_umount(am_node *mp); -extern void amfs_toplvl_mounted(mntfs *mf); -#endif /* HAVE_AMU_FS_TOPLVL */ - -/* - * Direct Automount File System - */ -#ifdef HAVE_AMU_FS_DIRECT -extern am_ops amfs_direct_ops; /* Direct Automount file system (this too) */ -#endif /* HAVE_AMU_FS_DIRECT */ - -/* - * Error File System - */ -#ifdef HAVE_AMU_FS_ERROR -extern am_ops amfs_error_ops; /* Error file system */ -extern am_node *amfs_error_lookuppn(am_node *mp, char *fname, int *error_return, int op); -extern int amfs_error_readdir(am_node *mp, nfscookie cookie, nfsdirlist *dp, nfsentry *ep, int count); -#endif /* HAVE_AMU_FS_ERROR */ - -/* - * Inheritance File System - */ -#ifdef HAVE_AMU_FS_INHERIT -extern am_ops amfs_inherit_ops; /* Inheritance file system */ -#endif /* HAVE_AMU_FS_INHERIT */ - -/* - * NFS mounts with local existence check. - */ -#ifdef HAVE_AMU_FS_NFSL -extern am_ops amfs_nfsl_ops; /* NFSL */ -#endif /* HAVE_AMU_FS_NFSL */ - -/* - * Multi-nfs mounts. - */ -#ifdef HAVE_AMU_FS_NFSX -extern am_ops amfs_nfsx_ops; /* NFSX */ -#endif /* HAVE_AMU_FS_NFSX */ - -/* - * NFS host - a whole tree. - */ -#ifdef HAVE_AMU_FS_HOST -extern am_ops amfs_host_ops; /* NFS host */ -#endif /* HAVE_AMU_FS_HOST */ - -/* - * Program File System - * This is useful for things like RVD. - */ -#ifdef HAVE_AMU_FS_PROGRAM -extern am_ops amfs_program_ops; /* Program File System */ -#endif /* HAVE_AMU_FS_PROGRAM */ - -/* - * Symbolic-link file system. - * A "filesystem" which is just a symbol link. - */ -#ifdef HAVE_AMU_FS_LINK -extern am_ops amfs_link_ops; /* Symlink FS */ -extern int amfs_link_fmount(mntfs *mf); -#endif /* HAVE_AMU_FS_LINK */ - -/* - * Symbolic-link file system, which also checks that the target of - * the symlink exists. - * A "filesystem" which is just a symbol link. - */ -#ifdef HAVE_AMU_FS_LINKX -extern am_ops amfs_linkx_ops; /* Symlink FS with existence check */ -#endif /* HAVE_AMU_FS_LINKX */ - -/* - * Union file system - */ -#ifdef HAVE_AMU_FS_UNION -extern am_ops amfs_union_ops; /* Union FS */ -#endif /* HAVE_AMU_FS_UNION */ - /**************************************************************************/ /*** DEBUGGING ***/ @@ -893,42 +409,39 @@ extern am_ops amfs_union_ops; /* Union FS */ /* * DEBUGGING: */ + #ifdef DEBUG -# define D_ALL (~0) -# define D_DAEMON 0x0001 /* Enter daemon mode */ +# define D_ALL (~(D_MTAB|D_HRTIME|D_XDRTRACE|D_DAEMON|D_FORK|D_AMQ)) +# define D_DAEMON 0x0001 /* Don't enter daemon mode */ # define D_TRACE 0x0002 /* Do protocol trace */ # define D_FULL 0x0004 /* Do full trace */ # define D_MTAB 0x0008 /* Use local mtab */ -# define D_AMQ 0x0010 /* Register amq program */ +# define D_AMQ 0x0010 /* Don't register amq program */ # define D_STR 0x0020 /* Debug string munging */ -# ifdef DEBUG_MEM -# define D_MEM 0x0040 /* Trace memory allocations */ -# endif /* DEBUG_MEM */ -# define D_FORK 0x0080 /* Fork server */ +# ifdef DEBUG_MEM +# define D_MEM 0x0040 /* Trace memory allocations */ +# else /* not DEBUG_MEM */ +# define D_MEM 0x0000 /* Dummy */ +# endif /* not DEBUG_MEM */ +# define D_FORK 0x0080 /* Don't fork server */ /* info service specific debugging (hesiod, nis, etc) */ # define D_INFO 0x0100 # define D_HRTIME 0x0200 /* Print high resolution time stamps */ # define D_XDRTRACE 0x0400 /* Trace xdr routines */ -# define D_READDIR 0x0800 /* show browsable_dir progress */ +# define D_READDIR 0x0800 /* Show browsable_dir progress */ /* - * Normally, don't enter daemon mode, don't register amq, and don't trace xdr + * Test mode is test mode: don't daemonize, don't register amq, don't fork, + * don't touch system mtab, etc. */ -# ifdef DEBUG_MEM -# define D_TEST (~(D_DAEMON|D_MEM|D_STR|D_XDRTRACE)) -# else /* not DEBUG_MEM */ -# define D_TEST (~(D_DAEMON|D_STR|D_XDRTRACE)) -# endif /* not DEBUG_MEM */ +# define D_TEST (~(D_MEM|D_STR|D_XDRTRACE)) -# define amuDebug(x) if (debug_flags & (x)) -# define dlog amuDebug(D_FULL) dplog -# define amuDebugNo(x) if (!(debug_flags & (x))) +# define amuDebug(x) (debug_flags & (x)) +# define dlog if (amuDebug(D_FULL)) dplog -/* debugging mount-table file to use */ -# ifndef DEBUG_MNTTAB -# define DEBUG_MNTTAB "./mnttab" -# endif /* not DEBUG_MNTTAB */ +/* my favorite debugging tool -Erez */ +#define EZKDBG plog(XLOG_INFO,"EZK:%s:%s:%d\n",__FILE__,__FUNCTION__,__LINE__) # ifdef DEBUG_MEM /* @@ -949,18 +462,25 @@ extern void malloc_verify(void); /* functions that depend solely on debugging */ extern void print_nfs_args(const nfs_args_t *nap, u_long nfs_version); extern int debug_option (char *opt); +extern void dplog(const char *fmt, ...) + __attribute__ ((__format__ (__printf__, 1, 2))); #else /* not DEBUG */ /* - * if not debugging, then simple perform free, and don't bother - * resetting the pointer. + * If not debugging, then also reset the pointer. + * It's safer -- and besides, free() should do that anyway. */ -# define XFREE(x) free(x) +# define XFREE(x) do { free((voidp)x); x = NULL;} while (0) + +#define amuDebug(x) (0) -#define amuDebug(x) if (0) -#define dlog if (0) dplog -#define amuDebugNo(x) if (0) +#ifdef __GNUC__ +#define dlog(fmt...) +#else /* not __GNUC__ */ +/* this define means that we CCP leaves code behind the (list,of,args) */ +#define dlog +#endif /* not __GNUC__ */ #define print_nfs_args(nap, nfs_version) #define debug_option(x) (1) @@ -969,8 +489,6 @@ extern int debug_option (char *opt); extern int debug_flags; /* Debug options */ extern struct opt_tab dbg_opt[]; -extern void dplog(const char *fmt, ...) - __attribute__ ((__format__ (__printf__, 1, 2))); /**************************************************************************/ /*** MISC (stuff left to autoconfiscate) ***/ diff --git a/contrib/amd/include/am_xdr_func.h b/contrib/amd/include/am_xdr_func.h index 6e3cdcea26a4..c4159188c799 100644 --- a/contrib/amd/include/am_xdr_func.h +++ b/contrib/amd/include/am_xdr_func.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,12 +36,147 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: am_xdr_func.h,v 1.3.2.6 2004/01/06 03:15:24 ezk Exp $ + * File: am-utils/include/am_xdr_func.h * */ +#ifdef HAVE_FS_NFS3 + +#define AM_FHSIZE3 64 /* size in bytes of a file handle (v3) */ +#define AM_MOUNTVERS3 ((unsigned long)(3)) + +/* NFSv3 handle */ +struct am_nfs_fh3 { + u_int am_fh3_length; + char am_fh3_data[AM_FHSIZE3]; +}; +typedef struct am_nfs_fh3 am_nfs_fh3; + +#define AM_NFSPROC3_LOOKUP ((u_long) 3) +enum am_nfsstat3 { + AM_NFS3_OK = 0, + AM_NFS3ERR_PERM = 1, + AM_NFS3ERR_NOENT = 2, + AM_NFS3ERR_IO = 5, + AM_NFS3ERR_NXIO = 6, + AM_NFS3ERR_ACCES = 13, + AM_NFS3ERR_EXIST = 17, + AM_NFS3ERR_XDEV = 18, + AM_NFS3ERR_NODEV = 19, + AM_NFS3ERR_NOTDIR = 20, + AM_NFS3ERR_ISDIR = 21, + AM_NFS3ERR_INVAL = 22, + AM_NFS3ERR_FBIG = 27, + AM_NFS3ERR_NOSPC = 28, + AM_NFS3ERR_ROFS = 30, + AM_NFS3ERR_MLINK = 31, + AM_NFS3ERR_NAMETOOLONG = 63, + AM_NFS3ERR_NOTEMPTY = 66, + AM_NFS3ERR_DQUOT = 69, + AM_NFS3ERR_STALE = 70, + AM_NFS3ERR_REMOTE = 71, + AM_NFS3ERR_BADHANDLE = 10001, + AM_NFS3ERR_NOT_SYNC = 10002, + AM_NFS3ERR_BAD_COOKIE = 10003, + AM_NFS3ERR_NOTSUPP = 10004, + AM_NFS3ERR_TOOSMALL = 10005, + AM_NFS3ERR_SERVERFAULT = 10006, + AM_NFS3ERR_BADTYPE = 10007, + AM_NFS3ERR_JUKEBOX = 10008 +}; +typedef enum am_nfsstat3 am_nfsstat3; + +typedef struct { + u_int fhandle3_len; + char *fhandle3_val; +} am_fhandle3; + +enum am_mountstat3 { + AM_MNT3_OK = 0, + AM_MNT3ERR_PERM = 1, + AM_MNT3ERR_NOENT = 2, + AM_MNT3ERR_IO = 5, + AM_MNT3ERR_ACCES = 13, + AM_MNT3ERR_NOTDIR = 20, + AM_MNT3ERR_INVAL = 22, + AM_MNT3ERR_NAMETOOLONG = 63, + AM_MNT3ERR_NOTSUPP = 10004, + AM_MNT3ERR_SERVERFAULT = 10006 +}; +typedef enum am_mountstat3 am_mountstat3; + +struct am_mountres3_ok { + am_fhandle3 fhandle; + struct { + u_int auth_flavors_len; + int *auth_flavors_val; + } auth_flavors; +}; +typedef struct am_mountres3_ok am_mountres3_ok; + +struct am_mountres3 { + am_mountstat3 fhs_status; + union { + am_mountres3_ok mountinfo; + } mountres3_u; +}; +typedef struct am_mountres3 am_mountres3; + +typedef char *am_filename3; + +struct am_diropargs3 { + am_nfs_fh3 dir; + am_filename3 name; +}; +typedef struct am_diropargs3 am_diropargs3; + +struct am_LOOKUP3args { + am_diropargs3 what; +}; +typedef struct am_LOOKUP3args am_LOOKUP3args; + +struct am_LOOKUP3resok { + am_nfs_fh3 object; +#if 0 + post_op_attr obj_attributes; + post_op_attr dir_attributes; +#endif +}; +typedef struct am_LOOKUP3resok am_LOOKUP3resok; + +struct am_LOOKUP3resfail { +#if 0 + post_op_attr dir_attributes; +#else + char dummy; /* cannot have an empty declaration */ +#endif +}; +typedef struct am_LOOKUP3resfail am_LOOKUP3resfail; + +struct am_LOOKUP3res { + am_nfsstat3 status; + union { + am_LOOKUP3resok ok; + am_LOOKUP3resfail fail; + } res_u; +}; +typedef struct am_LOOKUP3res am_LOOKUP3res; +#endif /* HAVE_FS_NFS3 */ + +/* + * Multi-protocol NFS file handle + */ +union am_nfs_handle { + /* placeholder for V4 file handle */ +#ifdef HAVE_FS_NFS3 + am_nfs_fh3 v3; /* NFS version 3 handle */ +#endif /* HAVE_FS_NFS3 */ + am_nfs_fh v2; /* NFS version 2 handle */ +}; +typedef union am_nfs_handle am_nfs_handle_t; + + /* * Definitions of all possible xdr functions that are otherwise * not defined elsewhere. @@ -110,17 +245,6 @@ bool_t xdr_mountbody(XDR *xdrs, mountbody *objp); #ifndef HAVE_XDR_MOUNTLIST bool_t xdr_mountlist(XDR *xdrs, mountlist *objp); #endif /* not HAVE_XDR_MOUNTLIST */ - -/* - * NFS3 XDR FUNCTIONS: - */ -#if defined(HAVE_FS_NFS3) && !defined(HAVE_XDR_MOUNTRES3) -bool_t xdr_fhandle3(XDR *xdrs, fhandle3 *objp); -bool_t xdr_mountstat3(XDR *xdrs, mountstat3 *objp); -bool_t xdr_mountres3_ok(XDR *xdrs, mountres3_ok *objp); -bool_t xdr_mountres3(XDR *xdrs, mountres3 *objp); -#endif /* defined(HAVE_FS_NFS3) && !defined(HAVE_XDR_MOUNTRES3) */ - #ifndef HAVE_XDR_NAME bool_t xdr_name(XDR *xdrs, name *objp); #endif /* not HAVE_XDR_NAME */ @@ -182,4 +306,22 @@ bool_t xdr_symlinkargs(XDR *xdrs, nfssymlinkargs *objp); bool_t xdr_writeargs(XDR *xdrs, nfswriteargs *objp); #endif /* not HAVE_XDR_WRITEARGS */ +/* + * NFS3 XDR FUNCTIONS: + */ +#ifdef HAVE_FS_NFS3 +bool_t xdr_am_fhandle3(XDR *xdrs, am_fhandle3 *objp); +bool_t xdr_am_mountstat3(XDR *xdrs, am_mountstat3 *objp); +bool_t xdr_am_mountres3_ok(XDR *xdrs, am_mountres3_ok *objp); +bool_t xdr_am_mountres3(XDR *xdrs, am_mountres3 *objp); +bool_t xdr_am_diropargs3(XDR *xdrs, am_diropargs3 *objp); +bool_t xdr_am_filename3(XDR *xdrs, am_filename3 *objp); +bool_t xdr_am_LOOKUP3args(XDR *xdrs, am_LOOKUP3args *objp); +bool_t xdr_am_LOOKUP3res(XDR *xdrs, am_LOOKUP3res *objp); +bool_t xdr_am_LOOKUP3resfail(XDR *xdrs, am_LOOKUP3resfail *objp); +bool_t xdr_am_LOOKUP3resok(XDR *xdrs, am_LOOKUP3resok *objp); +bool_t xdr_am_nfsstat3(XDR *xdrs, am_nfsstat3 *objp); +bool_t xdr_am_nfs_fh3(XDR *xdrs, am_nfs_fh3 *objp); +#endif /* HAVE_FS_NFS3 */ + #endif /* not _AM_XDR_FUNC_H */ diff --git a/contrib/amd/include/amq_defs.h b/contrib/amd/include/amq_defs.h index 118233026d99..75c465171033 100644 --- a/contrib/amd/include/amq_defs.h +++ b/contrib/amd/include/amq_defs.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: amq_defs.h,v 1.4.2.4 2004/01/06 03:15:24 ezk Exp $ + * File: am-utils/include/amq_defs.h * */ @@ -51,7 +50,7 @@ #ifndef AMQ_SIZE # define AMQ_SIZE 16384 #endif /* not AMQ_SIZE */ -#define AMQ_STRLEN 2048 +#define AMQ_STRLEN 16384 #define AMQ_PROGRAM ((u_long)300019) #define AMQ_VERSION ((u_long)1) #define AMQPROC_NULL ((u_long)0) @@ -64,6 +63,7 @@ #define AMQPROC_MOUNT ((u_long)7) #define AMQPROC_GETVERS ((u_long)8) #define AMQPROC_GETPID ((u_long)9) +#define AMQPROC_PAWD ((u_long)10) /* * TYPEDEFS diff --git a/contrib/amd/include/mount_headers1.h b/contrib/amd/include/mount_headers1.h index 0015528453e5..41f26e59f99d 100644 --- a/contrib/amd/include/mount_headers1.h +++ b/contrib/amd/include/mount_headers1.h @@ -1,3 +1,47 @@ +/* + * Copyright (c) 1997-2006 Erez Zadok + * Copyright (c) 1990 Jan-Simon Pendry + * Copyright (c) 1990 Imperial College of Science, Technology & Medicine + * Copyright (c) 1990 The Regents of the University of California. + * All rights reserved. + * + * This code is derived from software contributed to Berkeley by + * Jan-Simon Pendry at Imperial College, London. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * 3. All advertising materials mentioning features or use of this software + * must display the following acknowledgment: + * This product includes software developed by the University of + * California, Berkeley and its contributors. + * 4. Neither the name of the University nor the names of its contributors + * may be used to endorse or promote products derived from this software + * without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF + * SUCH DAMAGE. + * + * + * File: am-utils/include/mount_headers1.h + * + */ + + #ifdef HAVE_SYS_TYPES_H # include <sys/types.h> #endif /* HAVE_SYS_TYPES_H */ @@ -131,17 +175,12 @@ #ifdef HAVE_UFS_UFS_MOUNT_H # include <ufs/ufs_mount.h> #endif /* HAVE_UFS_UFS_MOUNT_H */ -#ifdef HAVE_UFS_UFS_UFSMOUNT_H -# ifndef MAXQUOTAS -# define MAXQUOTAS 2 -# endif /* not MAXQUOTAS */ -struct netexport { int this_is_SO_wrong; }; /* for bsdi-2.1 */ -/* netbsd-1.4 does't protect <ufs/ufs/ufsmount.h> */ -# ifndef _UFS_UFS_UFSMOUNT_H -# include <ufs/ufs/ufsmount.h> -# define _UFS_UFS_UFSMOUNT_H -# endif /* not _UFS_UFS_UFSMOUNT_H */ -#endif /* HAVE_UFS_UFS_UFSMOUNT_H */ +#ifdef HAVE_UFS_UFS_UFSMOUNT_H_off +# error do not include this file here because on *bsd it +# error causes errors with other header files. Instead, add it to the +# error specific conf/nfs_prot_*.h file. +# include <ufs/ufs/ufsmount.h> +#endif /* HAVE_UFS_UFS_UFSMOUNT_H_off */ #ifdef HAVE_CDFS_CDFS_MOUNT_H # include <cdfs/cdfs_mount.h> @@ -153,6 +192,16 @@ struct netexport { int this_is_SO_wrong; }; /* for bsdi-2.1 */ # include <isofs/cd9660/cd9660_mount.h> #endif /* HAVE_ISOFS_CD9660_CD9660_MOUNT_H */ +#ifdef HAVE_SYS_FS_PC_FS_H +# include <sys/fs/pc_fs.h> +#endif /* HAVE_SYS_FS_PC_FS_H */ +#ifdef HAVE_MSDOSFS_MSDOSFSMOUNT_H +# include <msdosfs/msdosfsmount.h> +#endif /* HAVE_MSDOSFS_MSDOSFSMOUNT_H */ +#ifdef HAVE_FS_MSDOSFS_MSDOSFSMOUNT_H +# include <fs/msdosfs/msdosfsmount.h> +#endif /* HAVE_FS_MSDOSFS_MSDOSFSMOUNT_H */ + #ifdef HAVE_RPC_RPC_H # include <rpc/rpc.h> #endif /* HAVE_RPC_RPC_H */ diff --git a/contrib/amd/include/mount_headers2.h b/contrib/amd/include/mount_headers2.h index bd9f567420b1..273e89cae10c 100644 --- a/contrib/amd/include/mount_headers2.h +++ b/contrib/amd/include/mount_headers2.h @@ -1,3 +1,47 @@ +/* + * Copyright (c) 1997-2006 Erez Zadok + * Copyright (c) 1990 Jan-Simon Pendry + * Copyright (c) 1990 Imperial College of Science, Technology & Medicine + * Copyright (c) 1990 The Regents of the University of California. + * All rights reserved. + * + * This code is derived from software contributed to Berkeley by + * Jan-Simon Pendry at Imperial College, London. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * 3. All advertising materials mentioning features or use of this software + * must display the following acknowledgment: + * This product includes software developed by the University of + * California, Berkeley and its contributors. + * 4. Neither the name of the University nor the names of its contributors + * may be used to endorse or promote products derived from this software + * without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF + * SUCH DAMAGE. + * + * + * File: am-utils/include/mount_headers2.h + * + */ + + #ifdef HAVE_RPCSVC_MOUNT_H # include <rpcsvc/mount.h> @@ -20,10 +64,24 @@ #endif /* HAVE_SYS_FS_NFS_CLNT_H */ #ifdef HAVE_LINUX_NFS_MOUNT_H -# define _LINUX_NFS_H -# define _LINUX_NFS2_H -# define _LINUX_NFS3_H -# define _LINUX_NFS_FS_H -# define _LINUX_IN_H +# ifndef _LINUX_NFS_H +# define _LINUX_NFS_H +# endif /* not _LINUX_NFS_H */ +# ifndef _LINUX_NFS2_H +# define _LINUX_NFS2_H +# endif /* not _LINUX_NFS2_H */ +# ifndef _LINUX_NFS3_H +# define _LINUX_NFS3_H +# endif /* not _LINUX_NFS3_H */ +# ifndef _LINUX_NFS_FS_H +# define _LINUX_NFS_FS_H +# endif /* not _LINUX_NFS_FS_H */ +# ifndef _LINUX_IN_H +# define _LINUX_IN_H +# endif /* not _LINUX_IN_H */ +# ifndef __KERNEL__ +# define __KERNEL__ +# endif /* __KERNEL__ */ # include <linux/nfs_mount.h> +# undef __KERNEL__ #endif /* HAVE_LINUX_NFS_MOUNT_H */ diff --git a/contrib/amd/ldap-id.ms b/contrib/amd/ldap-id.ms index 54ba0af4f320..3c0d30856645 100644 --- a/contrib/amd/ldap-id.ms +++ b/contrib/amd/ldap-id.ms @@ -28,31 +28,31 @@ A directory (X.500 and LDAPv3) schema for Berkely automounter .fi .in 3 This memo describes a directory (LDAP or X.500) schema for storing -amd (Berkely-style automounter) mount info maps. The schema is currently -beeing supported by the (beta version of the) am-utils version 6 package -[AMUTILS]. +amd (Berkely-style automounter) mount info maps. The schema is currently +beeing supported by the (beta version of the) am-utils version 6 package +[AMUTILS]. .ti 0 2. Overview and Rationale Directory services such as X.500 [X500] or LDAP [RFC2251] are a natural -choice of repository for amd mount map databases. All Object Identifiers -in this document are prefixed by amdSchema-id to be assigned later. The -relation between this schema and the automount schema elements in [HOWARD] +choice of repository for amd mount map databases. All Object Identifiers +in this document are prefixed by amdSchema-id to be assigned later. The +relation between this schema and the automount schema elements in [HOWARD] are mostly superficial. The model for the elements in [HOWARD] was the SUN -automounter which has quite a different syntax for mount maps. Furthermore -the intended usage of this schema differs from that of [HOWARD] in many +automounter which has quite a different syntax for mount maps. Furthermore +the intended usage of this schema differs from that of [HOWARD] in many respects. .ti 0 3. DSA requirements -Directory servers implementing this schema SHOULD maintain the -modifyTimestamp operational attribute. If not the amdMapCacheTtl +Directory servers implementing this schema SHOULD maintain the +modifyTimestamp operational attribute. If not the amdMapCacheTtl attribute SHOULD be set to 0 indicating to clients that caching of -map entries SHOULD be turned off. Clients wishing to use the amdMap -schema MAY use the modifyTimestamp information to set the ttl for -internal caching schemes. A value of 0 for the amdMapCacheTtl must +map entries SHOULD be turned off. Clients wishing to use the amdMap +schema MAY use the modifyTimestamp information to set the ttl for +internal caching schemes. A value of 0 for the amdMapCacheTtl must result in clients turning off any local caching. .ti 0 @@ -70,11 +70,11 @@ in BNF using definitions from [RFC2252]: amdlocationselection = amdlocation | amdlocationselection whsp amdlocation - + amdlocation = amdlocationinfo | "-" amdlocationinfo | "-" - + amdlocationinfo = seloropt | amdlocationinfo ";" seloropt | ";" @@ -87,7 +87,7 @@ in BNF using definitions from [RFC2252]: optass = keystring \":=\" printablestring -X.500 servers or LDAPv3 servers (supporting the binary attribute +X.500 servers or LDAPv3 servers (supporting the binary attribute option) may use the following syntax definition: AmdLocationList ::= SEQUENCE OF { @@ -103,21 +103,21 @@ option) may use the following syntax definition: not [2] NULL } } - + AmdLocationInfo ::= SET OF { CHOICE { selection [0] AmdSelection option [1] AmdOption } } - + AmdSelection ::= CHOICE { eq [0] AttributeAndValue ne [1] AttributeAndValue } AmdOption ::= AttributeAndValue - + AttributeAndValue ::= SEQUENCE { attribute IA5String value IA5String @@ -127,7 +127,7 @@ option) may use the following syntax definition: 5. Attribute types The following attribute types are defined in this document: - + amdMapName amdMapCacheTtl amdMapEntry @@ -136,21 +136,21 @@ The following attribute types are defined in this document: amdSchema-a OBJECT IDENTIFIER ::= { amdSchema-id 1 } - amdMapName + amdMapName ATTRIBUTE ::= { WITH SYNTAX IA5String EQUALITY MATCHING RULE caseIgoreExactMatch --ID { amdSchema-a 1 } - DESCRIPTION + DESCRIPTION "This attribute is the symbolic and in the naming context unique name of an amd map. This corresponds in the case of a flat file database to the name of the file or the mount-point of the map." } - - amdMapCacheTtl - ATTRIBUTE ::= { + + amdMapCacheTtl + ATTRIBUTE ::= { WITH SYNTAX Integer EQUALITY MATCHING RULE integerExactMatch --ID { amdSchema-a 2 } @@ -213,7 +213,7 @@ The following attribute types are defined in this document: using the syntax described above." } -.ti 0 +.ti 0 6. Object classes The following object classes are defined in this document: @@ -251,13 +251,13 @@ defined as follows: .ti 0 7. Examples - + .ti 0 8. Security Considerations Due to the security problems posed by NFS care should be taken not to -advertise exported filesystems. Therefore it is often desirable to limit +advertise exported filesystems. Therefore it is often desirable to limit access to entries carrying amd mount map information to those systems to which the corresponding filesystems have been exported. @@ -282,13 +282,13 @@ to which the corresponding filesystems have been exported. Names", RFC 2253, December 1997. [HOWARD] - Luke Howard, "An Approach for Using LDAP as a Network + Luke Howard, "An Approach for Using LDAP as a Network Information Service", draft-howard-nis-schema-??.txt, Internet draft. - [X500] + [X500] ITU something or other. - + .in 3 diff --git a/contrib/amd/ldap.schema b/contrib/amd/ldap.schema new file mode 100644 index 000000000000..9594d2fee8b6 --- /dev/null +++ b/contrib/amd/ldap.schema @@ -0,0 +1,52 @@ +# A schema for the Berkeley automounter (AMD) +# Authored by Erez Zadok and/or source maintainers +# Definition by Tim Colles <timc at dai.ed.ac.uk> +# Revised by Adam Morley <adam at gmi.com> + +# OID Base is 1.3.6.1.4.1.10180 +# +# Syntaxes are under 1.3.6.1.4.1.10180.3.175-199 +# Attribute types are under 1.3.6.1.4.1.10180.2.175-199 +# Object classes are under 1.3.6.1.4.1.10180.1.175-199 + +# Attribute Type Definitions + +attributetype ( 1.3.6.1.4.1.10180.2.175 + NAME 'amdmapTimestamp' + DESC 'Probably the time the map was last modified' + EQUALITY integerMatch + SYNTAX 1.3.6.1.4.1.1466.115.121.1.27 + SINGLE-VALUE ) + +attributetype ( 1.3.6.1.4.1.10180.2.176 + NAME 'amdmapName' + DESC 'The symbolic name of the map, ie. map_name' + EQUALITY caseIgnoreMatch + SYNTAX 1.3.6.1.4.1.1466.115.121.1.15 + SINGLE-VALUE ) + +attributetype ( 1.3.6.1.4.1.10180.2.177 + NAME 'amdmapKey' + DESC 'The key value for this entry' + EQUALITY caseIgnoreMatch + SYNTAX 1.3.6.1.4.1.1466.115.121.1.15 + SINGLE-VALUE ) + +attributetype ( 1.3.6.1.4.1.10180.2.178 + NAME 'amdmapValue' + DESC 'The mount information for this entry' + EQUALITY caseIgnoreMatch + SYNTAX 1.3.6.1.4.1.1466.115.121.1.15 + SINGLE-VALUE ) + +# Object Class Definitions + +objectclass ( 1.3.6.1.4.1.10180.1.175 NAME 'amdmapTimestamp' + SUP top STRUCTURAL + DESC 'Timestamp for an AMD map' + MUST ( cn $ amdmapName $ amdmapTimestamp ) ) + +objectclass ( 1.3.6.1.4.1.10180.1.176 NAME 'amdmap' + SUP top STRUCTURAL + DESC 'Defines an AMD map entry' + MUST ( cn $ amdmapName $ amdmapKey $ amdmapValue ) ) diff --git a/contrib/amd/libamu/amu.h b/contrib/amd/libamu/amu.h index 833d8c3e34ca..1e7834a15261 100644 --- a/contrib/amd/libamu/amu.h +++ b/contrib/amd/libamu/amu.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: amu.h,v 1.3.2.4 2004/01/06 03:15:24 ezk Exp $ + * File: am-utils/libamu/amu.h * */ @@ -75,4 +74,6 @@ extern amq_mount_info_list *amqproc_getmntfs_1(voidp argp, CLIENT *rqstp); extern int *amqproc_mount_1(voidp argp, CLIENT *rqstp); extern amq_string *amqproc_getvers_1(voidp argp, CLIENT *rqstp); +extern long get_server_pid(void); + #endif /* not _AMU_H */ diff --git a/contrib/amd/libamu/hasmntopt.c b/contrib/amd/libamu/hasmntopt.c index e6696edc9751..14cceb53b5cb 100644 --- a/contrib/amd/libamu/hasmntopt.c +++ b/contrib/amd/libamu/hasmntopt.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ n * modification, are permitted provided that the following conditions * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: hasmntopt.c,v 1.3.2.4 2004/01/06 03:15:24 ezk Exp $ + * File: am-utils/libamu/hasmntopt.c * */ @@ -49,7 +48,7 @@ n * modification, are permitted provided that the following conditions #include <amu.h> #ifndef MNTMAXSTR -# define MNTMAXSTR 128 +# define MNTMAXSTR 256 #endif /* not MNTMAXSTR */ @@ -59,7 +58,6 @@ n * modification, are permitted provided that the following conditions * * From: Piete Brooks <pb@cl.cam.ac.uk> */ - static char * nextmntopt(char **p) { @@ -69,7 +67,7 @@ nextmntopt(char **p) /* * Skip past white space */ - while (*cp && isspace(*cp)) + while (*cp && isspace((int) *cp)) cp++; /* @@ -98,18 +96,19 @@ nextmntopt(char **p) return rp; } + /* * replacement for hasmntopt if the system does not have it. */ char * -hasmntopt(mntent_t *mnt, char *opt) +amu_hasmntopt(mntent_t *mnt, char *opt) { char t[MNTMAXSTR]; char *f; char *o = t; int l = strlen(opt); - strcpy(t, mnt->mnt_opts); + xstrlcpy(t, mnt->mnt_opts, sizeof(t)); while (*(f = nextmntopt(&o))) if (NSTREQ(opt, f, l)) diff --git a/contrib/amd/libamu/misc_rpc.c b/contrib/amd/libamu/misc_rpc.c index 47b11ad0011b..de0a92036b7f 100644 --- a/contrib/amd/libamu/misc_rpc.c +++ b/contrib/amd/libamu/misc_rpc.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: misc_rpc.c,v 1.4.2.6 2004/01/06 03:15:24 ezk Exp $ + * File: am-utils/libamu/misc_rpc.c * */ @@ -93,7 +92,7 @@ pickup_rpc_reply(voidp pkt, int len, voidp where, XDRPROC_T_TYPE where_xdr) memset((voidp) &reply_msg, 0, sizeof(reply_msg)); memset((voidp) &reply_xdr, 0, sizeof(reply_xdr)); - reply_msg.acpted_rply.ar_results.where = (caddr_t) where; + reply_msg.acpted_rply.ar_results.where = where; reply_msg.acpted_rply.ar_results.proc = where_xdr; xdrmem_create(&reply_xdr, pkt, len, XDR_DECODE); diff --git a/contrib/amd/libamu/mount_fs.c b/contrib/amd/libamu/mount_fs.c index 3fecabe78069..74f064ede648 100644 --- a/contrib/amd/libamu/mount_fs.c +++ b/contrib/amd/libamu/mount_fs.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: mount_fs.c,v 1.11.2.12 2004/01/06 03:15:24 ezk Exp $ + * File: am-utils/libamu/mount_fs.c * */ @@ -50,9 +49,10 @@ /* ensure that mount table options are delimited by a comma */ -#define append_opts(old, new) { \ - if (*(old) != '\0') strcat(old, ","); \ - strcat(old, new); } +#define append_opts(old, l, new) { \ + if (*(old) != '\0') \ + xstrlcat(old, ",", l); \ + xstrlcat(old, new, l); } /* * Standard mount flags @@ -107,7 +107,9 @@ struct opt_tab mnt_flags[] = /* * Do not define MNT2_NFS_OPT_* entries here! This is for generic - * mount(2) options only, not for NFS mount options. + * mount(2) options only, not for NFS mount options. If you need to put + * something here, it's probably not the right place: see + * include/am_compat.h. */ {0, 0} @@ -122,7 +124,7 @@ compute_mount_flags(mntent_t *mntp) int flags = 0; #ifdef MNT2_GEN_OPT_NEWTYPE - flags = MNT2_GEN_OPT_NEWTYPE; + flags |= MNT2_GEN_OPT_NEWTYPE; #endif /* MNT2_GEN_OPT_NEWTYPE */ #ifdef MNT2_GEN_OPT_AUTOMOUNTED flags |= MNT2_GEN_OPT_AUTOMOUNTED; @@ -132,7 +134,7 @@ compute_mount_flags(mntent_t *mntp) * Crack basic mount options */ for (opt = mnt_flags; opt->opt; opt++) { - flags |= hasmntopt(mntp, opt->opt) ? opt->flag : 0; + flags |= amu_hasmntopt(mntp, opt->opt) ? opt->flag : 0; } return flags; @@ -157,31 +159,33 @@ compute_automounter_mount_flags(mntent_t *mntp) int -mount_fs(mntent_t *mnt, int flags, caddr_t mnt_data, int retry, MTYPE_TYPE type, u_long nfs_version, const char *nfs_proto, const char *mnttabname) +mount_fs(mntent_t *mnt, int flags, caddr_t mnt_data, int retry, MTYPE_TYPE type, u_long nfs_version, const char *nfs_proto, const char *mnttabname, int on_autofs) { int error = 0; #ifdef MOUNT_TABLE_ON_FILE -# ifdef MNTTAB_OPT_DEV - struct stat stb; -# endif /* MNTTAB_OPT_DEV */ char *zopts = NULL, *xopts = NULL; -# if defined(MNTTAB_OPT_DEV) || (defined(HAVE_FS_NFS3) && defined(MNTTAB_OPT_VERS)) || defined(MNTTAB_OPT_PROTO) - char optsbuf[48]; -# endif /* defined(MNTTAB_OPT_DEV) || (defined(HAVE_FS_NFS3) && defined(MNTTAB_OPT_VERS)) || defined(MNTTAB_OPT_PROTO) */ + size_t l; #endif /* MOUNT_TABLE_ON_FILE */ + char *mnt_dir = 0; + +#ifdef NEED_AUTOFS_SPACE_HACK + char *old_mnt_dir = 0; + /* perform space hack */ + if (on_autofs) { + old_mnt_dir = mnt->mnt_dir; + mnt->mnt_dir = mnt_dir = autofs_strdup_space_hack(old_mnt_dir); + } else +#endif /* NEED_AUTOFS_SPACE_HACK */ + mnt_dir = strdup(mnt->mnt_dir); -#ifdef DEBUG - dlog("%s fstype " MTYPE_PRINTF_TYPE " (%s) flags %#x (%s)", - mnt->mnt_dir, type, mnt->mnt_type, flags, mnt->mnt_opts); -#endif /* DEBUG */ + dlog("'%s' fstype " MTYPE_PRINTF_TYPE " (%s) flags %#x (%s)", + mnt_dir, type, mnt->mnt_type, flags, mnt->mnt_opts); again: - clock_valid = 0; - error = MOUNT_TRAP(type, mnt, flags, mnt_data); if (error < 0) { - plog(XLOG_ERROR, "%s: mount: %m", mnt->mnt_dir); + plog(XLOG_ERROR, "'%s': mount: %m", mnt_dir); /* * The following code handles conditions which shouldn't * occur. They are possible either because amd screws up @@ -189,33 +193,18 @@ again: * messed with the mount point. Both have been known to * happen. -- stolcke 2/22/95 */ - if (errno == ENOENT) { - /* - * Occasionally the mount point vanishes, probably - * due to some race condition. Just recreate it - * as necessary. - */ - errno = mkdirs(mnt->mnt_dir, 0555); - if (errno != 0 && errno != EEXIST) - plog(XLOG_ERROR, "%s: mkdirs: %m", mnt->mnt_dir); - else { - plog(XLOG_WARNING, "extra mkdirs required for %s", - mnt->mnt_dir); - error = MOUNT_TRAP(type, mnt, flags, mnt_data); - } - } else if (errno == EBUSY) { + if (errno == EBUSY) { /* * Also, sometimes unmount isn't called, e.g., because * our mountlist is garbled. This leaves old mount * points around which need to be removed before we * can mount something new in their place. */ - errno = umount_fs(mnt->mnt_dir, mnttabname); + errno = umount_fs(mnt_dir, mnttabname, on_autofs); if (errno != 0) - plog(XLOG_ERROR, "%s: umount: %m", mnt->mnt_dir); + plog(XLOG_ERROR, "'%s': umount: %m", mnt_dir); else { - plog(XLOG_WARNING, "extra umount required for %s", - mnt->mnt_dir); + plog(XLOG_WARNING, "extra umount required for '%s'", mnt_dir); error = MOUNT_TRAP(type, mnt, flags, mnt_data); } } @@ -225,8 +214,16 @@ again: sleep(1); goto again; } + +#ifdef NEED_AUTOFS_SPACE_HACK + /* Undo space hack */ + if (on_autofs) + mnt->mnt_dir = old_mnt_dir; +#endif /* NEED_AUTOFS_SPACE_HACK */ + if (error < 0) { - return errno; + error = errno; + goto out; } #ifdef MOUNT_TABLE_ON_FILE @@ -234,23 +231,28 @@ again: * Allocate memory for options: * dev=..., vers={2,3}, proto={tcp,udp} */ - zopts = (char *) xmalloc(strlen(mnt->mnt_opts) + 48); + l = strlen(mnt->mnt_opts) + 48; + zopts = (char *) xmalloc(l); /* copy standard options */ xopts = mnt->mnt_opts; - strcpy(zopts, xopts); + xstrlcpy(zopts, xopts, l); # ifdef MNTTAB_OPT_DEV - /* add the extra dev= field to the mount table */ - if (lstat(mnt->mnt_dir, &stb) == 0) { - if (sizeof(stb.st_dev) == 2) /* e.g. SunOS 4.1 */ - sprintf(optsbuf, "%s=%04lx", - MNTTAB_OPT_DEV, (u_long) stb.st_dev & 0xffff); - else /* e.g. System Vr4 */ - sprintf(optsbuf, "%s=%08lx", - MNTTAB_OPT_DEV, (u_long) stb.st_dev); - append_opts(zopts, optsbuf); + { + /* add the extra dev= field to the mount table */ + struct stat stb; + if (lstat(mnt_dir, &stb) == 0) { + char optsbuf[48]; + if (sizeof(stb.st_dev) == 2) /* e.g. SunOS 4.1 */ + xsnprintf(optsbuf, sizeof(optsbuf), "%s=%04lx", + MNTTAB_OPT_DEV, (u_long) stb.st_dev & 0xffff); + else /* e.g. System Vr4 */ + xsnprintf(optsbuf, sizeof(optsbuf), "%s=%08lx", + MNTTAB_OPT_DEV, (u_long) stb.st_dev); + append_opts(zopts, l, optsbuf); + } } # endif /* MNTTAB_OPT_DEV */ @@ -261,8 +263,10 @@ again: */ if (nfs_version == NFS_VERSION3 && hasmntval(mnt, MNTTAB_OPT_VERS) != NFS_VERSION3) { - sprintf(optsbuf, "%s=%d", MNTTAB_OPT_VERS, NFS_VERSION3); - append_opts(zopts, optsbuf); + char optsbuf[48]; + xsnprintf(optsbuf, sizeof(optsbuf), + "%s=%d", MNTTAB_OPT_VERS, NFS_VERSION3); + append_opts(zopts, l, optsbuf); } # endif /* defined(HAVE_FS_NFS3) && defined(MNTTAB_OPT_VERS) */ @@ -271,9 +275,10 @@ again: * add the extra proto={tcp,udp} field to the mount table, * unless already specified by user. */ - if (nfs_proto && !hasmntopt(mnt, MNTTAB_OPT_PROTO)) { - sprintf(optsbuf, "%s=%s", MNTTAB_OPT_PROTO, nfs_proto); - append_opts(zopts, optsbuf); + if (nfs_proto && !amu_hasmntopt(mnt, MNTTAB_OPT_PROTO)) { + char optsbuf[48]; + xsnprintf(optsbuf, sizeof(optsbuf), "%s=%s", MNTTAB_OPT_PROTO, nfs_proto); + append_opts(zopts, l, optsbuf); } # endif /* MNTTAB_OPT_PROTO */ @@ -289,14 +294,15 @@ again: # endif /* HAVE_MNTENT_T_MNT_CNODE */ # ifdef HAVE_MNTENT_T_MNT_RO - mnt->mnt_ro = (hasmntopt(mnt, MNTTAB_OPT_RO) != NULL); + mnt->mnt_ro = (amu_hasmntopt(mnt, MNTTAB_OPT_RO) != NULL); # endif /* HAVE_MNTENT_T_MNT_RO */ # ifdef HAVE_MNTENT_T_MNT_TIME # ifdef HAVE_MNTENT_T_MNT_TIME_STRING { /* allocate enough space for a long */ - char *str = (char *) xmalloc(13 * sizeof(char)); - sprintf(str, "%ld", time((time_t *) NULL)); + size_t l = 13 * sizeof(char); + char *str = (char *) xmalloc(l); + xsnprintf(str, l, "%ld", time((time_t *) NULL)); mnt->mnt_time = str; } # else /* not HAVE_MNTENT_T_MNT_TIME_STRING */ @@ -314,7 +320,126 @@ again: # endif /* MNTTAB_OPT_DEV */ #endif /* MOUNT_TABLE_ON_FILE */ - return 0; + out: + XFREE(mnt_dir); + return error; +} + + +/* + * Compute all NFS attribute cache related flags separately. Note that this + * function now computes attribute-cache flags for both Amd's automount + * points (NFS) as well as any normal NFS mount that Amd performs. Edit + * with caution. + */ +static void +compute_nfs_attrcache_flags(nfs_args_t *nap, mntent_t *mntp) +{ + int acval = 0; + int err_acval = 1; /* 1 means we found no 'actimeo' value */ +#if defined(HAVE_NFS_ARGS_T_ACREGMIN) || defined(HAVE_NFS_ARGS_T_ACREGMAX) || defined(HAVE_NFS_ARGS_T_ACDIRMIN) || defined(HAVE_NFS_ARGS_T_ACDIRMAX) + int err_acrdmm; /* for ac{reg,dir}{min,max} */ +#endif /* HAVE_NFS_ARGS_T_AC{REG,DIR}{MIN,MAX} */ + + /************************************************************************/ + /*** ATTRIBUTE CACHES ***/ + /************************************************************************/ + /* + * acval is set to 0 at the top of the function. If actimeo mount option + * exists and defined in mntopts, then its acval is set to it. + * If the value is non-zero, then we set all attribute cache fields to it. + * If acval is zero, it means it was never defined in mntopts or the + * actimeo mount option does not exist, in which case we check for + * individual mount options per attribute cache. + * Regardless of the value of acval, mount flags are set based directly + * on the values of the attribute caches. + */ +#ifdef MNTTAB_OPT_ACTIMEO + err_acval = hasmntvalerr(mntp, MNTTAB_OPT_ACTIMEO, &acval); /* attr cache timeout (sec) */ +#endif /* MNTTAB_OPT_ACTIMEO */ + + /*** acregmin ***/ +#ifdef HAVE_NFS_ARGS_T_ACREGMIN + err_acrdmm = 1; /* 1 means we found no acregmin value */ + if (!err_acval) { + nap->acregmin = acval; /* min ac timeout for reg files (sec) */ + } else { +# ifdef MNTTAB_OPT_ACREGMIN + err_acrdmm = hasmntvalerr(mntp, MNTTAB_OPT_ACREGMIN, (int *) &nap->acregmin); +# else /* not MNTTAB_OPT_ACREGMIN */ + nap->acregmin = 0; +# endif /* not MNTTAB_OPT_ACREGMIN */ + } + /* set this flag iff we changed acregmin (possibly to zero) */ +# ifdef MNT2_NFS_OPT_ACREGMIN + if (!err_acval || !err_acrdmm) + nap->flags |= MNT2_NFS_OPT_ACREGMIN; +# endif /* MNT2_NFS_OPT_ACREGMIN */ +#endif /* HAVE_NFS_ARGS_T_ACREGMIN */ + + /*** acregmax ***/ +#ifdef HAVE_NFS_ARGS_T_ACREGMAX + err_acrdmm = 1; /* 1 means we found no acregmax value */ + if (!err_acval) { + nap->acregmax = acval; /* max ac timeout for reg files (sec) */ + } else { +# ifdef MNTTAB_OPT_ACREGMAX + err_acrdmm = hasmntvalerr(mntp, MNTTAB_OPT_ACREGMAX, (int *) &nap->acregmax); +# else /* not MNTTAB_OPT_ACREGMAX */ + nap->acregmax = 0; +# endif /* not MNTTAB_OPT_ACREGMAX */ + } + /* set this flag iff we changed acregmax (possibly to zero) */ +# ifdef MNT2_NFS_OPT_ACREGMAX + if (!err_acval || !err_acrdmm) + nap->flags |= MNT2_NFS_OPT_ACREGMAX; +# endif /* MNT2_NFS_OPT_ACREGMAX */ +#endif /* HAVE_NFS_ARGS_T_ACREGMAX */ + + /*** acdirmin ***/ +#ifdef HAVE_NFS_ARGS_T_ACDIRMIN + err_acrdmm = 1; /* 1 means we found no acdirmin value */ + if (!err_acval) { + nap->acdirmin = acval; /* min ac timeout for dirs (sec) */ + } else { +# ifdef MNTTAB_OPT_ACDIRMIN + err_acrdmm = hasmntvalerr(mntp, MNTTAB_OPT_ACDIRMIN, (int *) &nap->acdirmin); +# else /* not MNTTAB_OPT_ACDIRMIN */ + nap->acdirmin = 0; +# endif /* not MNTTAB_OPT_ACDIRMIN */ + } + /* set this flag iff we changed acdirmin (possibly to zero) */ +# ifdef MNT2_NFS_OPT_ACDIRMIN + if (!err_acval || !err_acrdmm) + nap->flags |= MNT2_NFS_OPT_ACDIRMIN; +# endif /* MNT2_NFS_OPT_ACDIRMIN */ +#endif /* HAVE_NFS_ARGS_T_ACDIRMIN */ + + /*** acdirmax ***/ +#ifdef HAVE_NFS_ARGS_T_ACDIRMAX + err_acrdmm = 1; /* 1 means we found no acdirmax value */ + if (!err_acval) { + nap->acdirmax = acval; /* max ac timeout for dirs (sec) */ + } else { +# ifdef MNTTAB_OPT_ACDIRMAX + err_acrdmm = hasmntvalerr(mntp, MNTTAB_OPT_ACDIRMAX, (int *) &nap->acdirmax); +# else /* not MNTTAB_OPT_ACDIRMAX */ + nap->acdirmax = 0; +# endif /* not MNTTAB_OPT_ACDIRMAX */ + } + /* set this flag iff we changed acdirmax (possibly to zero) */ +# ifdef MNT2_NFS_OPT_ACDIRMAX + if (!err_acval || !err_acrdmm) + nap->flags |= MNT2_NFS_OPT_ACDIRMAX; +# endif /* MNT2_NFS_OPT_ACDIRMAX */ +#endif /* HAVE_NFS_ARGS_T_ACDIRMAX */ + + + /* don't cache attributes */ +#if defined(MNTTAB_OPT_NOAC) && defined(MNT2_NFS_OPT_NOAC) + if (amu_hasmntopt(mntp, MNTTAB_OPT_NOAC) != NULL) + nap->flags |= MNT2_NFS_OPT_NOAC; +#endif /* defined(MNTTAB_OPT_NOAC) && defined(MNT2_NFS_OPT_NOAC) */ } @@ -333,31 +458,28 @@ again: * fs_name: remote file system name to mount */ void -#ifdef HAVE_TRANSPORT_TYPE_TLI -compute_nfs_args(nfs_args_t *nap, mntent_t *mntp, int genflags, struct netconfig *nfsncp, struct sockaddr_in *ip_addr, u_long nfs_version, char *nfs_proto, am_nfs_handle_t *fhp, char *host_name, char *fs_name) -#else /* not HAVE_TRANSPORT_TYPE_TLI */ -compute_nfs_args(nfs_args_t *nap, mntent_t *mntp, int genflags, struct sockaddr_in *ip_addr, u_long nfs_version, char *nfs_proto, am_nfs_handle_t *fhp, char *host_name, char *fs_name) -#endif /* not HAVE_TRANSPORT_TYPE_TLI */ +compute_nfs_args(nfs_args_t *nap, + mntent_t *mntp, + int genflags, + struct netconfig *nfsncp, + struct sockaddr_in *ip_addr, + u_long nfs_version, + char *nfs_proto, + am_nfs_handle_t *fhp, + char *host_name, + char *fs_name) { - int acval = 0; -#ifdef HAVE_FS_NFS3 - static am_nfs_fh3 fh3; /* static, b/c gcc on aix corrupts stack */ -#endif /* HAVE_FS_NFS3 */ - /* initialize just in case */ memset((voidp) nap, 0, sizeof(nfs_args_t)); + /* compute all of the NFS attribute-cache flags */ + compute_nfs_attrcache_flags(nap, mntp); + /************************************************************************/ /*** FILEHANDLE DATA AND LENGTH ***/ /************************************************************************/ #ifdef HAVE_FS_NFS3 if (nfs_version == NFS_VERSION3) { - memset((voidp) &fh3, 0, sizeof(am_nfs_fh3)); - fh3.fh3_length = fhp->v3.mountres3_u.mountinfo.fhandle.fhandle3_len; - memmove(fh3.fh3_u.data, - fhp->v3.mountres3_u.mountinfo.fhandle.fhandle3_val, - fh3.fh3_length); - # if defined(HAVE_NFS_ARGS_T_FHSIZE) || defined(HAVE_NFS_ARGS_T_FH_LEN) /* * Some systems (Irix/bsdi3) have a separate field in nfs_args for @@ -365,9 +487,9 @@ compute_nfs_args(nfs_args_t *nap, mntent_t *mntp, int genflags, struct sockaddr_ * the file handle set in nfs_args be plain bytes, and not * include the length field. */ - NFS_FH_DREF(nap->NFS_FH_FIELD, &(fh3.fh3_u.data)); + NFS_FH_DREF(nap->NFS_FH_FIELD, &fhp->v3.am_fh3_data); # else /* not defined(HAVE_NFS_ARGS_T_FHSIZE) || defined(HAVE_NFS_ARGS_T_FH_LEN) */ - NFS_FH_DREF(nap->NFS_FH_FIELD, &fh3); + NFS_FH_DREF(nap->NFS_FH_FIELD, &fhp->v3); # endif /* not defined(HAVE_NFS_ARGS_T_FHSIZE) || defined(HAVE_NFS_ARGS_T_FH_LEN) */ # ifdef MNT2_NFS_OPT_NFSV3 nap->flags |= MNT2_NFS_OPT_NFSV3; @@ -377,12 +499,12 @@ compute_nfs_args(nfs_args_t *nap, mntent_t *mntp, int genflags, struct sockaddr_ # endif /* MNT2_NFS_OPT_VER3 */ } else #endif /* HAVE_FS_NFS3 */ - NFS_FH_DREF(nap->NFS_FH_FIELD, &(fhp->v2.fhs_fh)); + NFS_FH_DREF(nap->NFS_FH_FIELD, &fhp->v2); #ifdef HAVE_NFS_ARGS_T_FHSIZE # ifdef HAVE_FS_NFS3 if (nfs_version == NFS_VERSION3) - nap->fhsize = fh3.fh3_length; + nap->fhsize = fhp->v3.am_fh3_length; else # endif /* HAVE_FS_NFS3 */ nap->fhsize = FHSIZE; @@ -392,7 +514,7 @@ compute_nfs_args(nfs_args_t *nap, mntent_t *mntp, int genflags, struct sockaddr_ #ifdef HAVE_NFS_ARGS_T_FH_LEN # ifdef HAVE_FS_NFS3 if (nfs_version == NFS_VERSION3) - nap->fh_len = fh3.fh3_length; + nap->fh_len = fhp->v3.am_fh3_length; else # endif /* HAVE_FS_NFS3 */ nap->fh_len = FHSIZE; @@ -401,75 +523,17 @@ compute_nfs_args(nfs_args_t *nap, mntent_t *mntp, int genflags, struct sockaddr_ /************************************************************************/ /*** HOST NAME ***/ /************************************************************************/ + /* + * XXX: warning, using xstrlcpy in NFS_HN_DREF, which may corrupt a + * struct nfs_args, or truncate our concocted "hostname:/path" + * string prematurely. + */ NFS_HN_DREF(nap->hostname, host_name); #ifdef MNT2_NFS_OPT_HOSTNAME nap->flags |= MNT2_NFS_OPT_HOSTNAME; #endif /* MNT2_NFS_OPT_HOSTNAME */ /************************************************************************/ - /*** ATTRIBUTE CACHES ***/ - /************************************************************************/ - /* - * acval is set to 0 at the top of the function. If actimeo mount option - * exists and defined in mntopts, then it acval is set to it. - * If the value is non-zero, then we set all attribute cache fields to it. - * If acval is zero, it means it was never defined in mntopts or the - * actimeo mount option does not exist, in which case we check for - * individual mount options per attribute cache. - * Regardless of the value of acval, mount flags are set based directly - * on the values of the attribute caches. - */ -#ifdef MNTTAB_OPT_ACTIMEO - acval = hasmntval(mntp, MNTTAB_OPT_ACTIMEO); /* attr cache timeout (sec) */ -#endif /* MNTTAB_OPT_ACTIMEO */ - - if (acval) { -#ifdef HAVE_NFS_ARGS_T_ACREGMIN - nap->acregmin = acval; /* min ac timeout for reg files (sec) */ - nap->acregmax = acval; /* max ac timeout for reg files (sec) */ -#endif /* HAVE_NFS_ARGS_T_ACREGMIN */ -#ifdef HAVE_NFS_ARGS_T_ACDIRMIN - nap->acdirmin = acval; /* min ac timeout for dirs (sec) */ - nap->acdirmax = acval; /* max ac timeout for dirs (sec) */ -#endif /* HAVE_NFS_ARGS_T_ACDIRMIN */ - } else { -#ifdef MNTTAB_OPT_ACREGMIN - nap->acregmin = hasmntval(mntp, MNTTAB_OPT_ACREGMIN); -#endif /* MNTTAB_OPT_ACREGMIN */ -#ifdef MNTTAB_OPT_ACREGMAX - nap->acregmax = hasmntval(mntp, MNTTAB_OPT_ACREGMAX); -#endif /* MNTTAB_OPT_ACREGMAX */ -#ifdef MNTTAB_OPT_ACDIRMIN - nap->acdirmin = hasmntval(mntp, MNTTAB_OPT_ACDIRMIN); -#endif /* MNTTAB_OPT_ACDIRMIN */ -#ifdef MNTTAB_OPT_ACDIRMAX - nap->acdirmax = hasmntval(mntp, MNTTAB_OPT_ACDIRMAX); -#endif /* MNTTAB_OPT_ACDIRMAX */ - } /* end of "if (acval)" statement */ - -#ifdef MNT2_NFS_OPT_ACREGMIN - if (nap->acregmin) - nap->flags |= MNT2_NFS_OPT_ACREGMIN; -#endif /* MNT2_NFS_OPT_ACREGMIN */ -#ifdef MNT2_NFS_OPT_ACREGMAX - if (nap->acregmax) - nap->flags |= MNT2_NFS_OPT_ACREGMAX; -#endif /* MNT2_NFS_OPT_ACREGMAX */ -#ifdef MNT2_NFS_OPT_ACDIRMIN - if (nap->acdirmin) - nap->flags |= MNT2_NFS_OPT_ACDIRMIN; -#endif /* MNT2_NFS_OPT_ACDIRMIN */ -#ifdef MNT2_NFS_OPT_ACDIRMAX - if (nap->acdirmax) - nap->flags |= MNT2_NFS_OPT_ACDIRMAX; -#endif /* MNT2_NFS_OPT_ACDIRMAX */ - -#ifdef MNTTAB_OPT_NOAC /* don't cache attributes */ - if (hasmntopt(mntp, MNTTAB_OPT_NOAC) != NULL) - nap->flags |= MNT2_NFS_OPT_NOAC; -#endif /* MNTTAB_OPT_NOAC */ - - /************************************************************************/ /*** IP ADDRESS OF REMOTE HOST ***/ /************************************************************************/ if (ip_addr) { @@ -523,9 +587,9 @@ compute_nfs_args(nfs_args_t *nap, mntent_t *mntp, int genflags, struct sockaddr_ /************************************************************************/ #ifdef MNT2_NFS_OPT_NOCONN /* check if user specified to use unconnected or connected sockets */ - if (hasmntopt(mntp, MNTTAB_OPT_NOCONN) != NULL) + if (amu_hasmntopt(mntp, MNTTAB_OPT_NOCONN) != NULL) nap->flags |= MNT2_NFS_OPT_NOCONN; - else if (hasmntopt(mntp, MNTTAB_OPT_CONN) != NULL) + else if (amu_hasmntopt(mntp, MNTTAB_OPT_CONN) != NULL) nap->flags &= ~MNT2_NFS_OPT_NOCONN; else { /* @@ -553,7 +617,7 @@ compute_nfs_args(nfs_args_t *nap, mntent_t *mntp, int genflags, struct sockaddr_ #ifdef MNT2_NFS_OPT_RESVPORT # ifdef MNTTAB_OPT_RESVPORT - if (hasmntopt(mntp, MNTTAB_OPT_RESVPORT) != NULL) + if (amu_hasmntopt(mntp, MNTTAB_OPT_RESVPORT) != NULL) nap->flags |= MNT2_NFS_OPT_RESVPORT; # else /* not MNTTAB_OPT_RESVPORT */ nap->flags |= MNT2_NFS_OPT_RESVPORT; @@ -587,12 +651,16 @@ compute_nfs_args(nfs_args_t *nap, mntent_t *mntp, int genflags, struct sockaddr_ if (nap->rsize) nap->flags |= MNT2_NFS_OPT_RSIZE; #endif /* MNT2_NFS_OPT_RSIZE */ + if (nfs_version == NFS_VERSION && nap->rsize > 8192) + nap->rsize = 8192; nap->wsize = hasmntval(mntp, MNTTAB_OPT_WSIZE); #ifdef MNT2_NFS_OPT_WSIZE if (nap->wsize) nap->flags |= MNT2_NFS_OPT_WSIZE; #endif /* MNT2_NFS_OPT_WSIZE */ + if (nfs_version == NFS_VERSION && nap->wsize > 8192) + nap->wsize = 8192; nap->timeo = hasmntval(mntp, MNTTAB_OPT_TIMEO); #ifdef MNT2_NFS_OPT_TIMEO @@ -611,11 +679,13 @@ compute_nfs_args(nfs_args_t *nap, mntent_t *mntp, int genflags, struct sockaddr_ nap->flags |= MNT2_NFS_OPT_BIODS; #endif /* MNT2_NFS_OPT_BIODS */ - if (hasmntopt(mntp, MNTTAB_OPT_SOFT) != NULL) +#ifdef MNT2_NFS_OPT_SOFT + if (amu_hasmntopt(mntp, MNTTAB_OPT_SOFT) != NULL) nap->flags |= MNT2_NFS_OPT_SOFT; +#endif /* MNT2_NFS_OPT_SOFT */ #ifdef MNT2_NFS_OPT_SPONGY - if (hasmntopt(mntp, MNTTAB_OPT_SPONGY) != NULL) { + if (amu_hasmntopt(mntp, MNTTAB_OPT_SPONGY) != NULL) { nap->flags |= MNT2_NFS_OPT_SPONGY; if (nap->flags & MNT2_NFS_OPT_SOFT) { plog(XLOG_USER, "Mount opts soft and spongy are incompatible - soft ignored"); @@ -631,7 +701,7 @@ compute_nfs_args(nfs_args_t *nap, mntent_t *mntp, int genflags, struct sockaddr_ #endif /* defined(MNT2_GEN_OPT_RONLY) && defined(MNT2_NFS_OPT_RONLY) */ #ifdef MNTTAB_OPT_INTR - if (hasmntopt(mntp, MNTTAB_OPT_INTR) != NULL) + if (amu_hasmntopt(mntp, MNTTAB_OPT_INTR) != NULL) /* * Either turn on the "allow interrupts" option, or * turn off the "disallow interrupts" option" @@ -651,17 +721,17 @@ compute_nfs_args(nfs_args_t *nap, mntent_t *mntp, int genflags, struct sockaddr_ #endif /* MNTTAB_OPT_INTR */ #ifdef MNTTAB_OPT_NODEVS - if (hasmntopt(mntp, MNTTAB_OPT_NODEVS) != NULL) + if (amu_hasmntopt(mntp, MNTTAB_OPT_NODEVS) != NULL) nap->flags |= MNT2_NFS_OPT_NODEVS; #endif /* MNTTAB_OPT_NODEVS */ #ifdef MNTTAB_OPT_COMPRESS - if (hasmntopt(mntp, MNTTAB_OPT_COMPRESS) != NULL) + if (amu_hasmntopt(mntp, MNTTAB_OPT_COMPRESS) != NULL) nap->flags |= MNT2_NFS_OPT_COMPRESS; #endif /* MNTTAB_OPT_COMPRESS */ #ifdef MNTTAB_OPT_PRIVATE /* mount private, single-client tree */ - if (hasmntopt(mntp, MNTTAB_OPT_PRIVATE) != NULL) + if (amu_hasmntopt(mntp, MNTTAB_OPT_PRIVATE) != NULL) nap->flags |= MNT2_NFS_OPT_PRIVATE; #endif /* MNTTAB_OPT_PRIVATE */ @@ -676,33 +746,38 @@ compute_nfs_args(nfs_args_t *nap, mntent_t *mntp, int genflags, struct sockaddr_ #endif /* MNT2_NFS_OPT_PGTHRESH */ #if defined(MNT2_NFS_OPT_NOCTO) && defined(MNTTAB_OPT_NOCTO) - if (hasmntopt(mntp, MNTTAB_OPT_NOCTO) != NULL) + if (amu_hasmntopt(mntp, MNTTAB_OPT_NOCTO) != NULL) nap->flags |= MNT2_NFS_OPT_NOCTO; #endif /* defined(MNT2_NFS_OPT_NOCTO) && defined(MNTTAB_OPT_NOCTO) */ #if defined(MNT2_NFS_OPT_POSIX) && defined(MNTTAB_OPT_POSIX) - if (hasmntopt(mntp, MNTTAB_OPT_POSIX) != NULL) { + if (amu_hasmntopt(mntp, MNTTAB_OPT_POSIX) != NULL) { nap->flags |= MNT2_NFS_OPT_POSIX; nap->pathconf = NULL; } #endif /* MNT2_NFS_OPT_POSIX && MNTTAB_OPT_POSIX */ #if defined(MNT2_NFS_OPT_PROPLIST) && defined(MNTTAB_OPT_PROPLIST) - if (hasmntopt(mntp, MNTTAB_OPT_PROPLIST) != NULL) + if (amu_hasmntopt(mntp, MNTTAB_OPT_PROPLIST) != NULL) nap->flags |= MNT2_NFS_OPT_PROPLIST; #endif /* defined(MNT2_NFS_OPT_PROPLIST) && defined(MNTTAB_OPT_PROPLIST) */ #if defined(MNT2_NFS_OPT_MAXGRPS) && defined(MNTTAB_OPT_MAXGROUPS) nap->maxgrouplist = hasmntval(mntp, MNTTAB_OPT_MAXGROUPS); - if (nap->maxgrouplist != NULL) + if (nap->maxgrouplist != 0) nap->flags |= MNT2_NFS_OPT_MAXGRPS; #endif /* defined(MNT2_NFS_OPT_MAXGRPS) && defined(MNTTAB_OPT_MAXGROUPS) */ #if defined(MNT2_NFS_OPT_NONLM) && defined(MNTTAB_OPT_NOLOCK) - if (hasmntopt(mntp, MNTTAB_OPT_NOLOCK) != NULL) + if (amu_hasmntopt(mntp, MNTTAB_OPT_NOLOCK) != NULL) nap->flags |= MNT2_NFS_OPT_NONLM; #endif /* defined(MNT2_NFS_OPT_NONLM) && defined(MNTTAB_OPT_NOLOCK) */ +#if defined(MNT2_NFS_OPT_XLATECOOKIE) && defined(MNTTAB_OPT_XLATECOOKIE) + if (amu_hasmntopt(mntp, MNTTAB_OPT_XLATECOOKIE) != NULL) + nap->flags |= MNT2_NFS_OPT_XLATECOOKIE; +#endif /* defined(MNT2_NFS_OPT_XLATECOOKIE) && defined(MNTTAB_OPT_XLATECOOKIE) */ + #ifdef HAVE_NFS_ARGS_T_OPTSTR nap->optstr = mntp->mnt_opts; #endif /* HAVE_NFS_ARGS_T_OPTSTR */ @@ -761,28 +836,9 @@ compute_automounter_nfs_args(nfs_args_t *nap, mntent_t *mntp) nap->flags |= MNT2_NFS_OPT_DUMBTIMR; #endif /* MNT2_NFS_OPT_DUMBTIMR */ -#ifdef MNT2_NFS_OPT_NOAC - /* - * Don't cache attributes - they are changing under the kernel's feet. - * For example, IRIX5.2 will dispense with nfs lookup calls and hand stale - * filehandles to getattr unless we disable attribute caching on the - * automount points. - */ - nap->flags |= MNT2_NFS_OPT_NOAC; -#else /* not MNT2_NFS_OPT_NOAC */ - /* - * Setting these to 0 results in an error on some systems, which is why - * it's better to use "noac" if possible. - */ -# if defined(MNT2_NFS_OPT_ACREGMIN) && defined(MNT2_NFS_OPT_ACREGMAX) - nap->acregmin = nap->acregmax = 0; /* XXX: was 1, but why? */ - nap->flags |= MNT2_NFS_OPT_ACREGMIN | MNT2_NFS_OPT_ACREGMAX; -# endif /* defined(MNT2_NFS_OPT_ACREGMIN) && defined(MNT2_NFS_OPT_ACREGMAX) */ -# if defined(MNT2_NFS_OPT_ACDIRMIN) && defined(MNT2_NFS_OPT_ACDIRMAX) - nap->acdirmin = nap->acdirmax = 0; /* XXX: was 1, but why? */ - nap->flags |= MNT2_NFS_OPT_ACDIRMIN | MNT2_NFS_OPT_ACDIRMAX; -# endif /* defined(MNT2_NFS_OPT_ACDIRMIN) && defined(MNT2_NFS_OPT_ACDIRMAX) */ -#endif /* not MNT2_NFS_OPT_NOAC */ + /* compute all of the NFS attribute-cache flags */ + compute_nfs_attrcache_flags(nap, mntp); + /* * Provide a slight bit more security by requiring the kernel to use * reserved ports. @@ -798,7 +854,7 @@ compute_automounter_nfs_args(nfs_args_t *nap, mntent_t *mntp) static char * get_hex_string(u_int len, const char *fhdata) { - int i; + u_int i; static char buf[128]; /* better not go over it! */ char str[16]; short int arr[64]; @@ -808,9 +864,9 @@ get_hex_string(u_int len, const char *fhdata) buf[0] = '\0'; memset(&arr[0], 0, (64 * sizeof(short int))); memcpy(&arr[0], &fhdata[0], len); - for (i=0; i<len/sizeof(short int); i++) { - sprintf(str, "%04x", ntohs(arr[i])); - strcat(buf, str); + for (i=0; i<len/sizeof(unsigned short int); i++) { + xsnprintf(str, sizeof(str), "%04x", ntohs(arr[i])); + xstrlcat(buf, str, sizeof(buf)); } return buf; } @@ -823,7 +879,7 @@ get_hex_string(u_int len, const char *fhdata) void print_nfs_args(const nfs_args_t *nap, u_long nfs_version) { - int fhlen = 32; /* default: NFS V.2 file handle length is 32 */ + int fhlen = 32; /* default: NFS V.2 file handle length is 32 */ #ifdef HAVE_TRANSPORT_TYPE_TLI struct netbuf *nbp; struct knetconfig *kncp; @@ -850,7 +906,7 @@ print_nfs_args(const nfs_args_t *nap, u_long nfs_version) nbp->maxlen, nbp->len, get_hex_string(nbp->len, nbp->buf)); nbp = nap->syncaddr; - plog(XLOG_DEBUG, "NA->syncaddr {netbuf} 0x%x", (int) nbp); + plog(XLOG_DEBUG, "NA->syncaddr {netbuf} %p", nbp); kncp = nap->knconf; plog(XLOG_DEBUG, "NA->knconf->semantics %lu", (u_long) kncp->knc_semantics); plog(XLOG_DEBUG, "NA->knconf->protofmly \"%s\"", kncp->knc_protofmly); @@ -858,18 +914,26 @@ print_nfs_args(const nfs_args_t *nap, u_long nfs_version) plog(XLOG_DEBUG, "NA->knconf->rdev %lu", (u_long) kncp->knc_rdev); /* don't print knconf->unused field */ #else /* not HAVE_TRANSPORT_TYPE_TLI */ - sap = (struct sockaddr_in *) &nap->addr; +# ifdef NFS_ARGS_T_ADDR_IS_POINTER + sap = (struct sockaddr_in *) nap->addr; +# else /* not NFS_ARGS_T_ADDR_IS_POINTER */ + sap = (struct sockaddr_in *) &nap->addr; +# endif /* not NFS_ARGS_T_ADDR_IS_POINTER */ plog(XLOG_DEBUG, "NA->addr {sockaddr_in} (len=%d) = \"%s\"", (int) sizeof(struct sockaddr_in), get_hex_string(sizeof(struct sockaddr_in), (const char *)sap)); #ifdef HAVE_STRUCT_SOCKADDR_SA_LEN - plog(XLOG_DEBUG, "NA->addr.sin_len = \"%d\"", sap->sin_len); + /* as per POSIX, sin_len need not be set (used internally by kernel) */ + plog(XLOG_DEBUG, "NA->addr.sin_len = %d", sap->sin_len); #endif /* HAVE_STRUCT_SOCKADDR_SA_LEN */ - plog(XLOG_DEBUG, "NA->addr.sin_family = \"%d\"", sap->sin_family); - plog(XLOG_DEBUG, "NA->addr.sin_port = \"%d\"", sap->sin_port); + plog(XLOG_DEBUG, "NA->addr.sin_family = %d", sap->sin_family); + plog(XLOG_DEBUG, "NA->addr.sin_port = %d", sap->sin_port); plog(XLOG_DEBUG, "NA->addr.sin_addr = \"%s\"", get_hex_string(sizeof(struct in_addr), (const char *) &sap->sin_addr)); #endif /* not HAVE_TRANSPORT_TYPE_TLI */ +#ifdef HAVE_NFS_ARGS_T_ADDRLEN + plog(XLOG_DEBUG, "NA->addrlen = %d", nap->addrlen); +#endif /* ifdef HAVE_NFS_ARGS_T_ADDRLEN */ plog(XLOG_DEBUG, "NA->hostname = \"%s\"", nap->hostname ? nap->hostname : "null"); #ifdef HAVE_NFS_ARGS_T_NAMLEN diff --git a/contrib/amd/libamu/mtab.c b/contrib/amd/libamu/mtab.c index b323097b2dfb..50ba994733f0 100644 --- a/contrib/amd/libamu/mtab.c +++ b/contrib/amd/libamu/mtab.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: mtab.c,v 1.3.2.8 2004/01/06 03:15:24 ezk Exp $ + * File: am-utils/libamu/mtab.c * */ @@ -118,14 +117,14 @@ haseq(char *instr) /* * Utility routine which returns a pointer to whatever * follows an = in a mount option. Returns null if option - * doesn't exist or doesn't have an '='. Won't fall for opt,foo=. + * doesn't exist or doesn't have an '='. Won't fail for opt,foo=. */ char * hasmnteq(mntent_t *mnt, char *opt) { if (mnt && opt) { /* disallow null input pointers */ if ( *opt ) { /* disallow the null string as an opt */ - char *str = hasmntopt(mnt, opt); + char *str = amu_hasmntopt(mnt, opt); if ( str ) { /* option was there */ char *eq = str + strlen(opt); /* Look at char just after option */ if (*eq == '=') /* Is it '=' ? */ @@ -138,14 +137,93 @@ hasmnteq(mntent_t *mnt, char *opt) /* - * Utility routine which determines the value of a - * numeric option in the mount options (such as port=%d). - * Returns 0 if the option is not specified. + * Wrapper around hasmntvalerr(), which retains backwards compatibiliy with + * older use of hasmntval(). + * + * XXX: eventually, all use of hasmntval() should be replaced with + * hasmntvalerr(). */ int hasmntval(mntent_t *mnt, char *opt) { - char *str = hasmntopt(mnt, opt); + int err, val = 0; + + err = hasmntvalerr(mnt, opt, &val); + if (err) /* if there was an error (hasmntvalerr returned 1) */ + return 0; /* redundant: val==0 above, but leave here for clarity */ + /* otherwise there was no error */ + return val; +} + + +/* + * Utility routine which determines the value of a numeric option in the + * mount options (such as port=%d), and fills in the value in the argument + * valp (argument won't be touched if no value is set, for example due to an + * error). + * + * Returns non-zero (1) on error; returns 0 on success. + * + * XXX: eventually, all use of hasmntval() should be replaced with + * hasmntvalerr(). + */ +unsigned int +hasmntvalerr(mntent_t *mnt, char *opt, int *valp) +{ + char *str = amu_hasmntopt(mnt, opt); + int err = 1; /* 1 means no good value was set (an error) */ + char *eq, *endptr; + long int i; + + /* exit if no option specificed */ + if (!str) { + goto out; + } + + eq = hasmnteq(mnt, opt); + + if (!eq) { /* no argument to option ('=' sign was missing) */ + plog(XLOG_MAP, "numeric option to \"%s\" missing", opt); + goto out; + } + + /* if got here, then we had an '=' after option name */ + endptr = NULL; + i = strtol(eq, &endptr, 0); /* hex and octal allowed ;-) */ + if (!endptr || + (endptr != eq && (*endptr == ',' || *endptr == '\0'))) { + /* + * endptr set means strtol saw a non-digit. If the non-digit is a + * comma, it's probably the start of the next option. If the comma is + * the first char though, complain about it (foo=,bar is made + * noticeable by this). + * + * Similar reasoning for '\0' instead of comma, it's the end of the + * string. + */ + *valp = (int) i; /* set good value */ + err = 0; /* no error */ + } else { + /* whatever was after the '=' sign wasn't a number */ + plog(XLOG_MAP, "invalid numeric option in \"%s\": \"%s\"", opt, str); + /* fall through to error/exit processing */ + } + + out: + return err; +} + + +/* + * Utility routine which returns the string value of + * an option in the mount options (such as proto=udp). + * Returns NULL if the option is not specified. + * Returns malloc'ed string (caller must free!) + */ +char * +hasmntstr(mntent_t *mnt, char *opt) +{ + char *str = amu_hasmntopt(mnt, opt); if (str) { /* The option was there */ @@ -153,27 +231,20 @@ hasmntval(mntent_t *mnt, char *opt) if (eq) { /* and had an = after it */ - char *endptr = NULL; - long int i = strtol(eq, &endptr, 0); /* hex and octal allowed ;-) */ - - if (!endptr || - /* - * endptr set means strtol saw a non-digit. If the - * non-digit is a comma, it's probably the start of the next - * option. If the comma is the first char though, complain about - * it (foo=,bar is made noticeable by this). - * - * Similar reasoning for '\0' instead of comma, it's the end - * of the string. - */ - (endptr != eq && (*endptr == ',' || *endptr == '\0'))) - return((int) i); - /* whatever was after the '=' sign wasn't a number */ - plog(XLOG_MAP, "invalid numeric option in \"%s\": \"%s\"", opt, str); - } else { - /* No argument to option ('=' sign was missing) */ - plog(XLOG_MAP, "numeric option to \"%s\" missing", opt); + char *endptr = strchr(eq, ','); + + /* if saw no comma, return strdup'd string */ + if (!endptr) + return strdup(eq); + else { + /* else we need to copy only the chars needed */ + int len = endptr - eq; + char *buf = xmalloc(len + 1); + strncpy(buf, eq, len); + buf[len] = '\0'; + return buf; + } } } - return 0; + return NULL; } diff --git a/contrib/amd/libamu/nfs_prot_xdr.c b/contrib/amd/libamu/nfs_prot_xdr.c index cb3368bace86..df8a0b006b55 100644 --- a/contrib/amd/libamu/nfs_prot_xdr.c +++ b/contrib/amd/libamu/nfs_prot_xdr.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1989 Jan-Simon Pendry * Copyright (c) 1989 Imperial College of Science, Technology & Medicine * Copyright (c) 1989 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: nfs_prot_xdr.c,v 1.3.2.4 2004/01/06 03:15:24 ezk Exp $ + * File: am-utils/libamu/nfs_prot_xdr.c * */ diff --git a/contrib/amd/libamu/strerror.c b/contrib/amd/libamu/strerror.c index af10e7009960..49dd2fc3ce9f 100644 --- a/contrib/amd/libamu/strerror.c +++ b/contrib/amd/libamu/strerror.c @@ -1,6 +1,6 @@ /* - * Copyright (c) 2002-2004 Ion Badulescu - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 2002-2006 Ion Badulescu + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -38,7 +38,7 @@ * SUCH DAMAGE. * * - * $Id: strerror.c,v 1.2.2.3 2004/01/06 03:15:24 ezk Exp $ + * File: am-utils/libamu/strerror.c * */ @@ -58,7 +58,7 @@ strerror(int errnum) #ifdef HAVE_EXTERN_SYS_ERRLIST if (errnum < 0 || errnum >= (sizeof(sys_errlist) >> 2)) { static char errstr[30]; - sprintf(errstr, "Unknown error #%d", errnum); + xsnprintf(errstr, sizeof(errstr), "Unknown error #%d", errnum); return errstr; } return sys_errlist[error]; diff --git a/contrib/amd/libamu/strutil.c b/contrib/amd/libamu/strutil.c new file mode 100644 index 000000000000..5a1e759bff67 --- /dev/null +++ b/contrib/amd/libamu/strutil.c @@ -0,0 +1,270 @@ +/* + * Copyright (c) 1997-2006 Erez Zadok + * Copyright (c) 1990 Jan-Simon Pendry + * Copyright (c) 1990 Imperial College of Science, Technology & Medicine + * Copyright (c) 1990 The Regents of the University of California. + * All rights reserved. + * + * This code is derived from software contributed to Berkeley by + * Jan-Simon Pendry at Imperial College, London. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * 3. All advertising materials mentioning features or use of this software + * must display the following acknowledgment: + * This product includes software developed by the University of + * California, Berkeley and its contributors. + * 4. Neither the name of the University nor the names of its contributors + * may be used to endorse or promote products derived from this software + * without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF + * SUCH DAMAGE. + * + * + * File: am-utils/libamu/strutil.c + * + */ + +/* + * String Utilities. + */ + +#ifdef HAVE_CONFIG_H +# include <config.h> +#endif /* HAVE_CONFIG_H */ +#include <am_defs.h> +#include <amu.h> + + +char * +strnsave(const char *str, int len) +{ + char *sp = (char *) xmalloc(len + 1); + memmove(sp, str, len); + sp[len] = '\0'; + + return sp; +} + + +/* + * Concatenate three strings and store the result in the buffer pointed to + * by p, making p large enough to hold the strings + */ +char * +str3cat(char *p, char *s1, char *s2, char *s3) +{ + int l1 = strlen(s1); + int l2 = strlen(s2); + int l3 = strlen(s3); + + p = (char *) xrealloc(p, l1 + l2 + l3 + 1); + memmove(p, s1, l1); + memmove(p + l1, s2, l2); + memmove(p + l1 + l2, s3, l3 + 1); + return p; +} + + +/* + * Split s using ch as delimiter and qc as quote character + */ +char ** +strsplit(char *s, int ch, int qc) +{ + char **ivec; + int ic = 0; + int done = 0; + + ivec = (char **) xmalloc((ic + 1) * sizeof(char *)); + + while (!done) { + char *v; + + /* + * skip to split char + */ + while (*s && (ch == ' ' ? (isascii((unsigned char)*s) && isspace((unsigned char)*s)) : *s == ch)) + *s++ = '\0'; + + /* + * End of string? + */ + if (!*s) + break; + + /* + * remember start of string + */ + v = s; + + /* + * skip to split char + */ + while (*s && !(ch == ' ' ? (isascii((unsigned char)*s) && isspace((unsigned char)*s)) : *s == ch)) { + if (*s++ == qc) { + /* + * Skip past string. + */ + s++; + while (*s && *s != qc) + s++; + if (*s == qc) + s++; + } + } + + if (!*s) + done = 1; + *s++ = '\0'; + + /* + * save string in new ivec slot + */ + ivec[ic++] = v; + ivec = (char **) xrealloc((voidp) ivec, (ic + 1) * sizeof(char *)); + if (amuDebug(D_STR)) + plog(XLOG_DEBUG, "strsplit saved \"%s\"", v); + } + + if (amuDebug(D_STR)) + plog(XLOG_DEBUG, "strsplit saved a total of %d strings", ic); + + ivec[ic] = NULL; + + return ivec; +} + + +/* + * Use generic strlcpy to copy a string more carefully, null-terminating it + * as needed. However, if the copied string was truncated due to lack of + * space, then warn us. + * + * For now, xstrlcpy returns VOID because it doesn't look like anywhere in + * the Amd code do we actually use the return value of strncpy/strlcpy. + */ +void +#ifdef DEBUG +_xstrlcpy(const char *filename, int lineno, char *dst, const char *src, size_t len) +#else /* not DEBUG */ +xstrlcpy(char *dst, const char *src, size_t len) +#endif /* not DEBUG */ +{ + if (len == 0) + return; + if (strlcpy(dst, src, len) >= len) +#ifdef DEBUG + plog(XLOG_ERROR, "xstrlcpy(%s:%d): string \"%s\" truncated to \"%s\"", + filename, lineno, src, dst); +#else /* not DEBUG */ + plog(XLOG_ERROR, "xstrlcpy: string \"%s\" truncated to \"%s\"", src, dst); +#endif /* not DEBUG */ +} + + +/* + * Use generic strlcat to concatenate a string more carefully, + * null-terminating it as needed. However, if the copied string was + * truncated due to lack of space, then warn us. + * + * For now, xstrlcat returns VOID because it doesn't look like anywhere in + * the Amd code do we actually use the return value of strncat/strlcat. + */ +void +#ifdef DEBUG +_xstrlcat(const char *filename, int lineno, char *dst, const char *src, size_t len) +#else /* not DEBUG */ +xstrlcat(char *dst, const char *src, size_t len) +#endif /* not DEBUG */ +{ + if (len == 0) + return; + if (strlcat(dst, src, len) >= len) { + /* strlcat does not null terminate if the size of src is equal to len. */ + dst[strlen(dst) - 1] = '\0'; +#ifdef DEBUG + plog(XLOG_ERROR, "xstrlcat(%s:%d): string \"%s\" truncated to \"%s\"", + filename, lineno, src, dst); +#else /* not DEBUG */ + plog(XLOG_ERROR, "xstrlcat: string \"%s\" truncated to \"%s\"", src, dst); +#endif /* not DEBUG */ + } +} + + +/* our version of snprintf */ +int +#if defined(DEBUG) && (defined(HAVE_C99_VARARGS_MACROS) || defined(HAVE_GCC_VARARGS_MACROS)) +_xsnprintf(const char *filename, int lineno, char *str, size_t size, const char *format, ...) +#else /* not DEBUG or no C99/GCC-style vararg cpp macros supported */ +xsnprintf(char *str, size_t size, const char *format, ...) +#endif /* not DEBUG or no C99/GCC-style vararg cpp macros supported */ +{ + va_list ap; + int ret = 0; + + va_start(ap, format); +#if defined(DEBUG) && (defined(HAVE_C99_VARARGS_MACROS) || defined(HAVE_GCC_VARARGS_MACROS)) + ret = _xvsnprintf(filename, lineno, str, size, format, ap); +#else /* not DEBUG or no C99/GCC-style vararg cpp macros supported */ + ret = xvsnprintf(str, size, format, ap); +#endif /* not DEBUG or no C99/GCC-style vararg cpp macros supported */ + va_end(ap); + + return ret; +} + + +/* our version of vsnprintf */ +int +#if defined(DEBUG) && (defined(HAVE_C99_VARARGS_MACROS) || defined(HAVE_GCC_VARARGS_MACROS)) +_xvsnprintf(const char *filename, int lineno, char *str, size_t size, const char *format, va_list ap) +#else /* not DEBUG or no C99/GCC-style vararg cpp macros supported */ +xvsnprintf(char *str, size_t size, const char *format, va_list ap) +#endif /* not DEBUG or no C99/GCC-style vararg cpp macros supported */ +{ + int ret = 0; + +#ifdef HAVE_VSNPRINTF + ret = vsnprintf(str, size, format, ap); +#else /* not HAVE_VSNPRINTF */ + ret = vsprintf(str, format, ap); /* less secure version */ +#endif /* not HAVE_VSNPRINTF */ + /* + * If error or truncation, plog error. + * + * WARNING: we use the static 'maxtrunc' variable below to break out any + * possible infinite recursion between plog() and xvsnprintf(). If it + * ever happens, it'd indicate a bug in Amd. + */ + if (ret < 0 || (size_t) ret >= size) { /* error or truncation occured */ + static int maxtrunc; /* hack to avoid inifinite loop */ + if (++maxtrunc > 10) +#if defined(DEBUG) && (defined(HAVE_C99_VARARGS_MACROS) || defined(HAVE_GCC_VARARGS_MACROS)) + plog(XLOG_ERROR, "xvsnprintf(%s:%d): string %p truncated (ret=%d, format=\"%s\")", + filename, lineno, str, ret, format); +#else /* not DEBUG or no C99/GCC-style vararg cpp macros supported */ + plog(XLOG_ERROR, "xvsnprintf: string %p truncated (ret=%d, format=\"%s\")", + str, ret, format); +#endif /* not DEBUG or no C99/GCC-style vararg cpp macros supported */ + } + + return ret; +} diff --git a/contrib/amd/libamu/wire.c b/contrib/amd/libamu/wire.c index 093f1a64a9d4..c1852cdca7f1 100644 --- a/contrib/amd/libamu/wire.c +++ b/contrib/amd/libamu/wire.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: wire.c,v 1.8.2.10 2004/01/06 03:15:24 ezk Exp $ + * File: am-utils/libamu/wire.c * */ @@ -60,6 +59,7 @@ #include <am_defs.h> #include <amu.h> + #ifdef HAVE_IFADDRS_H #include <ifaddrs.h> #endif /* HAVE_IFADDRS_H */ @@ -101,31 +101,32 @@ print_wires(void) int bufcount = 0; int buf_size = 1024; - buf = SALLOC(1024); + buf = SALLOC(buf_size); /* initial allocation (may grow!) */ if (!buf) return NULL; if (!localnets) { - sprintf(buf, "No networks.\n"); + xstrlcpy(buf, "No networks\n", buf_size); return buf; } /* check if there's more than one network */ if (!localnets->ip_next) { - sprintf(buf, - "Network: wire=\"%s\" (netnumber=%s).\n", - localnets->ip_net_name, localnets->ip_net_num); + /* use buf_size for sizeof(buf) because of the realloc() below */ + xsnprintf(buf, buf_size, + "Network: wire=\"%s\" (netnumber=%s).\n", + localnets->ip_net_name, localnets->ip_net_num); return buf; } buf[0] = '\0'; /* null out buffer before appending */ for (i = 1, al = localnets; al; al = al->ip_next, i++) { - sprintf(s, "Network %d: wire=\"%s\" (netnumber=%s).\n", - i, al->ip_net_name, al->ip_net_num); + xsnprintf(s, sizeof(s), "Network %d: wire=\"%s\" (netnumber=%s).\n", + i, al->ip_net_name, al->ip_net_num); bufcount += strlen(s); if (bufcount > buf_size) { buf_size *= 2; buf = xrealloc(buf, buf_size); } - strcat(buf, s); + xstrlcat(buf, s, buf_size); } return buf; } @@ -199,7 +200,7 @@ getwire_lookup(u_long address, u_long netmask, int ishost) */ if (!np) { u_long short_subnet = subnet; - while(short_subnet && (short_subnet & 0x000000ff) == 0) + while (short_subnet && (short_subnet & 0x000000ff) == 0) short_subnet >>= 8; np = getnetbyaddr(short_subnet, AF_INET); if (np) @@ -210,18 +211,18 @@ getwire_lookup(u_long address, u_long netmask, int ishost) } if ((subnet & 0xffffff) == 0) { - sprintf(netNumberBuf, "%lu", C(subnet >> 24)); + xsnprintf(netNumberBuf, sizeof(netNumberBuf), "%lu", C(subnet >> 24)); } else if ((subnet & 0xffff) == 0) { - sprintf(netNumberBuf, "%lu.%lu", - C(subnet >> 24), C(subnet >> 16)); + xsnprintf(netNumberBuf, sizeof(netNumberBuf), "%lu.%lu", + C(subnet >> 24), C(subnet >> 16)); } else if ((subnet & 0xff) == 0) { - sprintf(netNumberBuf, "%lu.%lu.%lu", - C(subnet >> 24), C(subnet >> 16), - C(subnet >> 8)); + xsnprintf(netNumberBuf, sizeof(netNumberBuf), "%lu.%lu.%lu", + C(subnet >> 24), C(subnet >> 16), + C(subnet >> 8)); } else { - sprintf(netNumberBuf, "%lu.%lu.%lu.%lu", - C(subnet >> 24), C(subnet >> 16), - C(subnet >> 8), C(subnet)); + xsnprintf(netNumberBuf, sizeof(netNumberBuf), "%lu.%lu.%lu.%lu", + C(subnet >> 24), C(subnet >> 16), + C(subnet >> 8), C(subnet)); } /* fill in network number (string) */ @@ -237,7 +238,7 @@ getwire_lookup(u_long address, u_long netmask, int ishost) if (hp != NULL) s = (char *) hp->h_name; else - s = inet_dquad(buf, subnet); + s = inet_dquad(buf, sizeof(buf), subnet); } /* fill in network name (string) */ @@ -259,14 +260,14 @@ getwire_lookup(u_long address, u_long netmask, int ishost) * sizeof(buf) needs to be at least 16. */ char * -inet_dquad(char *buf, u_long addr) +inet_dquad(char *buf, size_t l, u_long addr) { addr = ntohl(addr); - sprintf(buf, "%ld.%ld.%ld.%ld", - ((addr >> 24) & 0xff), - ((addr >> 16) & 0xff), - ((addr >> 8) & 0xff), - ((addr >> 0) & 0xff)); + xsnprintf(buf, l, "%ld.%ld.%ld.%ld", + ((addr >> 24) & 0xff), + ((addr >> 16) & 0xff), + ((addr >> 8) & 0xff), + ((addr >> 0) & 0xff)); return buf; } @@ -279,16 +280,17 @@ int islocalnet(u_long addr) { addrlist *al; -#ifdef DEBUG - char buf[16]; -#endif /* DEBUG */ for (al = localnets; al; al = al->ip_next) if (((addr ^ al->ip_addr) & al->ip_mask) == 0) return TRUE; #ifdef DEBUG - plog(XLOG_INFO, "%s is on a remote network", inet_dquad(buf, addr)); + { + char buf[16]; + plog(XLOG_INFO, "%s is on a remote network", + inet_dquad(buf, sizeof(buf), addr)); + } #endif /* DEBUG */ return FALSE; @@ -319,15 +321,16 @@ is_network_member(const char *net) char *netstr = strdup(net), *maskstr; u_long netnum, masknum = 0; maskstr = strchr(netstr, '/'); + maskstr[0] = '\0'; /* null terminate netstr */ maskstr++; - maskstr[-1] = '\0'; /* null terminate netstr */ if (*maskstr == '\0') /* if empty string, make it NULL */ maskstr = NULL; /* check if netmask uses a dotted-quad or bit-length, or not defined at all */ if (maskstr) { if (strchr(maskstr, '.')) { + /* XXX: inet_addr is obsolste, convert to inet_aton() */ masknum = inet_addr(maskstr); - if (masknum < 0) /* can be invalid (-1) or all-1s */ + if (masknum == INADDR_NONE) /* can be invalid (-1) or all-1s */ masknum = 0xffffffff; } else if (NSTRCEQ(maskstr, "0x", 2)) { masknum = strtoul(maskstr, NULL, 16); @@ -354,6 +357,24 @@ is_network_member(const char *net) } +/* + * Determine whether a IP address (netnum) is one of the local interfaces, + * returns TRUE/FALSE. + * Does not include the loopback interface: caller needs to check that. + */ +int +is_interface_local(u_long netnum) +{ + addrlist *al; + + for (al = localnets; al; al = al->ip_next) { + if (al->ip_addr == netnum) + return TRUE; + } + return FALSE; +} + + #ifdef HAVE_GETIFADDRS void getwire(char **name1, char **number1) @@ -381,10 +402,10 @@ getwire(char **name1, char **number1) continue; /* - * If the interface is a loopback, or its not running + * If the interface is the loopback, or it's not running, * then ignore it. */ - if ((ifap->ifa_flags & IFF_LOOPBACK) != 0) + if (S2IN(ifap->ifa_addr) == htonl(INADDR_LOOPBACK)) continue; if ((ifap->ifa_flags & IFF_RUNNING) == 0) continue; @@ -395,7 +416,7 @@ getwire(char **name1, char **number1) al = getwire_lookup(S2IN(ifap->ifa_dstaddr), 0xffffffff, 1); /* append to the end of the list */ - if (!localnets) { + if (!localnets || tail == NULL) { localnets = tail = al; tail->ip_next = NULL; } else { @@ -439,12 +460,6 @@ getwire(char **name1, char **number1) u_long address; addrlist *al = NULL, *tail = NULL; char buf[GFBUFLEN]; -#if 0 - u_long net; - u_long mask; - u_long subnetshift; - char buf[GFBUFLEN], *s; -#endif #ifndef SIOCGIFFLAGS /* if cannot get interface flags, return nothing */ @@ -504,13 +519,11 @@ getwire(char **name1, char **number1) continue; /* - * If the interface is a loopback, or its not running + * If the interface is the loopback, or it's not running, * then ignore it. */ -#ifdef IFF_LOOPBACK - if ((ifr->ifr_flags & IFF_LOOPBACK) != 0) + if (address == htonl(INADDR_LOOPBACK)) continue; -#endif /* IFF_LOOPBACK */ /* * Fix for 0.0.0.0 loopback on SunOS 3.X which defines IFF_ROUTE * instead of IFF_LOOPBACK. diff --git a/contrib/amd/libamu/xdr_func.c b/contrib/amd/libamu/xdr_func.c index 1592a0e83057..6bd0254318c6 100644 --- a/contrib/amd/libamu/xdr_func.c +++ b/contrib/amd/libamu/xdr_func.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: xdr_func.c,v 1.4.2.8 2004/01/06 03:15:24 ezk Exp $ + * File: am-utils/libamu/xdr_func.c * */ @@ -51,10 +50,24 @@ #include <am_defs.h> #include <amu.h> +#ifdef __RPCSVC_MOUNT_H__ +# error IRIX6 should not include rpcsvc/mount.h +#endif /* __RPCSVC_MOUNT_H__ */ /* * MACROS: */ +#ifdef HAVE_FS_AUTOFS +# ifndef AUTOFS_MAXCOMPONENTLEN +# define AUTOFS_MAXCOMPONENTLEN 255 +# endif /* not AUTOFS_MAXCOMPONENTLEN */ +# ifndef AUTOFS_MAXOPTSLEN +# define AUTOFS_MAXOPTSLEN 255 +# endif /* not AUTOFS_MAXOPTSLEN */ +# ifndef AUTOFS_MAXPATHLEN +# define AUTOFS_MAXPATHLEN 1024 +# endif /* not AUTOFS_MAXPATHLEN */ +#endif /* HAVE_FS_AUTOFS */ /* forward definitions, are they needed? */ extern bool_t xdr_exportnode(XDR *xdrs, exportnode *objp); @@ -66,10 +79,8 @@ extern bool_t xdr_name(XDR *xdrs, name *objp); bool_t xdr_attrstat(XDR *xdrs, nfsattrstat *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_attrstat:"); -#endif /* DEBUG */ if (!xdr_nfsstat(xdrs, &objp->ns_status)) { return (FALSE); @@ -92,10 +103,8 @@ xdr_attrstat(XDR *xdrs, nfsattrstat *objp) bool_t xdr_createargs(XDR *xdrs, nfscreateargs *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_createargs:"); -#endif /* DEBUG */ if (!xdr_diropargs(xdrs, &objp->ca_where)) { return (FALSE); @@ -112,10 +121,8 @@ xdr_createargs(XDR *xdrs, nfscreateargs *objp) bool_t xdr_dirlist(XDR *xdrs, nfsdirlist *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_dirlist:"); -#endif /* DEBUG */ if (!xdr_pointer(xdrs, (char **) &objp->dl_entries, sizeof(nfsentry), (XDRPROC_T_TYPE) xdr_entry)) { return (FALSE); @@ -132,10 +139,8 @@ xdr_dirlist(XDR *xdrs, nfsdirlist *objp) bool_t xdr_diropargs(XDR *xdrs, nfsdiropargs *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_diropargs:"); -#endif /* DEBUG */ if (!xdr_nfs_fh(xdrs, &objp->da_fhandle)) { return (FALSE); @@ -152,10 +157,8 @@ xdr_diropargs(XDR *xdrs, nfsdiropargs *objp) bool_t xdr_diropokres(XDR *xdrs, nfsdiropokres *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_diropokres:"); -#endif /* DEBUG */ if (!xdr_nfs_fh(xdrs, &objp->drok_fhandle)) { return (FALSE); @@ -172,10 +175,8 @@ xdr_diropokres(XDR *xdrs, nfsdiropokres *objp) bool_t xdr_diropres(XDR *xdrs, nfsdiropres *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_diropres:"); -#endif /* DEBUG */ if (!xdr_nfsstat(xdrs, &objp->dr_status)) { return (FALSE); @@ -198,10 +199,8 @@ xdr_diropres(XDR *xdrs, nfsdiropres *objp) bool_t xdr_dirpath(XDR *xdrs, dirpath *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_dirpath:"); -#endif /* DEBUG */ if (!xdr_string(xdrs, objp, MNTPATHLEN)) { return (FALSE); @@ -215,10 +214,8 @@ xdr_dirpath(XDR *xdrs, dirpath *objp) bool_t xdr_entry(XDR *xdrs, nfsentry *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_entry:"); -#endif /* DEBUG */ if (!xdr_u_int(xdrs, &objp->ne_fileid)) { return (FALSE); @@ -241,10 +238,8 @@ xdr_entry(XDR *xdrs, nfsentry *objp) bool_t xdr_exportnode(XDR *xdrs, exportnode *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_exportnode:"); -#endif /* DEBUG */ if (!xdr_dirpath(xdrs, &objp->ex_dir)) { return (FALSE); @@ -264,10 +259,8 @@ xdr_exportnode(XDR *xdrs, exportnode *objp) bool_t xdr_exports(XDR *xdrs, exports *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_exports:"); -#endif /* DEBUG */ if (!xdr_pointer(xdrs, (char **) objp, sizeof(exportnode), (XDRPROC_T_TYPE) xdr_exportnode)) { return (FALSE); @@ -281,10 +274,8 @@ xdr_exports(XDR *xdrs, exports *objp) bool_t xdr_fattr(XDR *xdrs, nfsfattr *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_fattr:"); -#endif /* DEBUG */ if (!xdr_ftype(xdrs, &objp->na_type)) { return (FALSE); @@ -337,10 +328,8 @@ xdr_fattr(XDR *xdrs, nfsfattr *objp) bool_t xdr_fhandle(XDR *xdrs, fhandle objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_fhandle:"); -#endif /* DEBUG */ if (!xdr_opaque(xdrs, objp, NFS_FHSIZE)) { return (FALSE); @@ -354,10 +343,8 @@ xdr_fhandle(XDR *xdrs, fhandle objp) bool_t xdr_fhstatus(XDR *xdrs, fhstatus *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_fhstatus:"); -#endif /* DEBUG */ if (!xdr_u_int(xdrs, &objp->fhs_status)) { return (FALSE); @@ -374,10 +361,8 @@ xdr_fhstatus(XDR *xdrs, fhstatus *objp) bool_t xdr_filename(XDR *xdrs, filename *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_filename:"); -#endif /* DEBUG */ if (!xdr_string(xdrs, objp, NFS_MAXNAMLEN)) { return (FALSE); @@ -391,12 +376,12 @@ xdr_filename(XDR *xdrs, filename *objp) bool_t xdr_ftype(XDR *xdrs, nfsftype *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + enum_t local_obj = *objp; + + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_ftype:"); -#endif /* DEBUG */ - if (!xdr_enum(xdrs, (enum_t *) objp)) { + if (!xdr_enum(xdrs, &local_obj)) { return (FALSE); } return (TRUE); @@ -408,10 +393,8 @@ xdr_ftype(XDR *xdrs, nfsftype *objp) bool_t xdr_groupnode(XDR *xdrs, groupnode *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_groupnode:"); -#endif /* DEBUG */ if (!xdr_name(xdrs, &objp->gr_name)) { return (FALSE); @@ -428,10 +411,8 @@ xdr_groupnode(XDR *xdrs, groupnode *objp) bool_t xdr_groups(XDR *xdrs, groups *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_groups:"); -#endif /* DEBUG */ if (!xdr_pointer(xdrs, (char **) objp, sizeof(groupnode), (XDRPROC_T_TYPE) xdr_groupnode)) { return (FALSE); @@ -445,10 +426,8 @@ xdr_groups(XDR *xdrs, groups *objp) bool_t xdr_linkargs(XDR *xdrs, nfslinkargs *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_linkargs:"); -#endif /* DEBUG */ if (!xdr_nfs_fh(xdrs, &objp->la_fhandle)) { return (FALSE); @@ -465,10 +444,8 @@ xdr_linkargs(XDR *xdrs, nfslinkargs *objp) bool_t xdr_mountbody(XDR *xdrs, mountbody *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_mountbody:"); -#endif /* DEBUG */ if (!xdr_name(xdrs, &objp->ml_hostname)) { return (FALSE); @@ -488,10 +465,8 @@ xdr_mountbody(XDR *xdrs, mountbody *objp) bool_t xdr_mountlist(XDR *xdrs, mountlist *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_mountlist:"); -#endif /* DEBUG */ if (!xdr_pointer(xdrs, (char **) objp, sizeof(mountbody), (XDRPROC_T_TYPE) xdr_mountbody)) { return (FALSE); @@ -501,94 +476,12 @@ xdr_mountlist(XDR *xdrs, mountlist *objp) #endif /* not HAVE_XDR_MOUNTLIST */ -#if defined(HAVE_FS_NFS3) && !defined(HAVE_XDR_MOUNTRES3) -/* - * This ifdef is a hack: this whole file needs to be compiled - * only if the system has NFS V3 and does not have the xdr_mountres3 - * function. Autoconf should pick this source file to compile only - * if these two conditions apply. - */ - -bool_t -xdr_fhandle3(XDR *xdrs, fhandle3 *objp) -{ -#ifdef DEBUG - amuDebug(D_XDRTRACE) - plog(XLOG_DEBUG, "xdr_fhandle3:"); -#endif /* DEBUG */ - - if (!xdr_bytes(xdrs, - (char **) &objp->fhandle3_val, - (u_int *) &objp->fhandle3_len, - FHSIZE3)) - return (FALSE); - return (TRUE); -} - - -bool_t -xdr_mountstat3(XDR *xdrs, mountstat3 *objp) -{ -#ifdef DEBUG - amuDebug(D_XDRTRACE) - plog(XLOG_DEBUG, "xdr_mountstat3:"); -#endif /* DEBUG */ - - if (!xdr_enum(xdrs, (enum_t *)objp)) - return (FALSE); - return (TRUE); -} - - -bool_t -xdr_mountres3_ok(XDR *xdrs, mountres3_ok *objp) -{ -#ifdef DEBUG - amuDebug(D_XDRTRACE) - plog(XLOG_DEBUG, "xdr_mountres3_ok:"); -#endif /* DEBUG */ - - if (!xdr_fhandle3(xdrs, &objp->fhandle)) - return (FALSE); - if (!xdr_array(xdrs, - (char **)&objp->auth_flavors.auth_flavors_val, - (u_int *) &objp->auth_flavors.auth_flavors_len, - ~0, - sizeof (int), - (xdrproc_t) xdr_int)) - return (FALSE); - return (TRUE); -} - - -bool_t -xdr_mountres3(XDR *xdrs, mountres3 *objp) -{ -#ifdef DEBUG - amuDebug(D_XDRTRACE) - plog(XLOG_DEBUG, "xdr_mountres3:"); -#endif /* DEBUG */ - - if (!xdr_mountstat3(xdrs, &objp->fhs_status)) - return (FALSE); - - if (objp->fhs_status == 0) { /* 0 == MNT_OK or MNT3_OK */ - if (!xdr_mountres3_ok(xdrs, &objp->mountres3_u.mountinfo)) - return (FALSE); - } - return (TRUE); -} -#endif /* defined(HAVE_FS_NFS3) && !defined(HAVE_XDR_MOUNTRES3) */ - - #ifndef HAVE_XDR_NAME bool_t xdr_name(XDR *xdrs, name *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_name:"); -#endif /* DEBUG */ if (!xdr_string(xdrs, objp, MNTNAMLEN)) { return (FALSE); @@ -602,10 +495,8 @@ xdr_name(XDR *xdrs, name *objp) bool_t xdr_nfs_fh(XDR *xdrs, am_nfs_fh *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_nfs_fh:"); -#endif /* DEBUG */ if (!xdr_opaque(xdrs, (caddr_t) objp->fh_data, NFS_FHSIZE)) { return (FALSE); @@ -619,10 +510,8 @@ xdr_nfs_fh(XDR *xdrs, am_nfs_fh *objp) bool_t xdr_nfscookie(XDR *xdrs, nfscookie objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_nfscookie:"); -#endif /* DEBUG */ if (!xdr_opaque(xdrs, objp, NFS_COOKIESIZE)) { return (FALSE); @@ -636,10 +525,8 @@ xdr_nfscookie(XDR *xdrs, nfscookie objp) bool_t xdr_nfspath(XDR *xdrs, nfspath *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_nfspath:"); -#endif /* DEBUG */ if (!xdr_string(xdrs, objp, NFS_MAXPATHLEN)) { return (FALSE); @@ -653,12 +540,12 @@ xdr_nfspath(XDR *xdrs, nfspath *objp) bool_t xdr_nfsstat(XDR *xdrs, nfsstat *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + enum_t local_obj = *objp; + + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_nfsstat:"); -#endif /* DEBUG */ - if (!xdr_enum(xdrs, (enum_t *) objp)) { + if (!xdr_enum(xdrs, &local_obj)) { return (FALSE); } return (TRUE); @@ -670,10 +557,8 @@ xdr_nfsstat(XDR *xdrs, nfsstat *objp) bool_t xdr_nfstime(XDR *xdrs, nfstime *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_nfstime:"); -#endif /* DEBUG */ if (!xdr_u_int(xdrs, (u_int *) &objp->nt_seconds)) { return (FALSE); @@ -690,11 +575,8 @@ xdr_nfstime(XDR *xdrs, nfstime *objp) bool_t xdr_pointer(register XDR *xdrs, char **objpp, u_int obj_size, XDRPROC_T_TYPE xdr_obj) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_pointer:"); -#endif /* DEBUG */ - bool_t more_data; @@ -716,10 +598,8 @@ xdr_pointer(register XDR *xdrs, char **objpp, u_int obj_size, XDRPROC_T_TYPE xdr bool_t xdr_readargs(XDR *xdrs, nfsreadargs *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_readargs:"); -#endif /* DEBUG */ if (!xdr_nfs_fh(xdrs, &objp->ra_fhandle)) { return (FALSE); @@ -742,10 +622,8 @@ xdr_readargs(XDR *xdrs, nfsreadargs *objp) bool_t xdr_readdirargs(XDR *xdrs, nfsreaddirargs *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_readdirargs:"); -#endif /* DEBUG */ if (!xdr_nfs_fh(xdrs, &objp->rda_fhandle)) { return (FALSE); @@ -765,10 +643,8 @@ xdr_readdirargs(XDR *xdrs, nfsreaddirargs *objp) bool_t xdr_readdirres(XDR *xdrs, nfsreaddirres *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_readdirres:"); -#endif /* DEBUG */ if (!xdr_nfsstat(xdrs, &objp->rdr_status)) { return (FALSE); @@ -791,10 +667,8 @@ xdr_readdirres(XDR *xdrs, nfsreaddirres *objp) bool_t xdr_readlinkres(XDR *xdrs, nfsreadlinkres *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_readlinkres:"); -#endif /* DEBUG */ if (!xdr_nfsstat(xdrs, &objp->rlr_status)) { return (FALSE); @@ -817,10 +691,8 @@ xdr_readlinkres(XDR *xdrs, nfsreadlinkres *objp) bool_t xdr_readokres(XDR *xdrs, nfsreadokres *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_readokres:"); -#endif /* DEBUG */ if (!xdr_fattr(xdrs, &objp->raok_attributes)) { return (FALSE); @@ -840,10 +712,8 @@ xdr_readokres(XDR *xdrs, nfsreadokres *objp) bool_t xdr_readres(XDR *xdrs, nfsreadres *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_readres:"); -#endif /* DEBUG */ if (!xdr_nfsstat(xdrs, &objp->rr_status)) { return (FALSE); @@ -866,10 +736,8 @@ xdr_readres(XDR *xdrs, nfsreadres *objp) bool_t xdr_renameargs(XDR *xdrs, nfsrenameargs *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_renameargs:"); -#endif /* DEBUG */ if (!xdr_diropargs(xdrs, &objp->rna_from)) { return (FALSE); @@ -886,10 +754,8 @@ xdr_renameargs(XDR *xdrs, nfsrenameargs *objp) bool_t xdr_sattr(XDR *xdrs, nfssattr *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_sattr:"); -#endif /* DEBUG */ if (!xdr_u_int(xdrs, &objp->sa_mode)) { return (FALSE); @@ -918,10 +784,8 @@ xdr_sattr(XDR *xdrs, nfssattr *objp) bool_t xdr_sattrargs(XDR *xdrs, nfssattrargs *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_sattrargs:"); -#endif /* DEBUG */ if (!xdr_nfs_fh(xdrs, &objp->sag_fhandle)) { return (FALSE); @@ -938,10 +802,8 @@ xdr_sattrargs(XDR *xdrs, nfssattrargs *objp) bool_t xdr_statfsokres(XDR *xdrs, nfsstatfsokres *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_statfsokres:"); -#endif /* DEBUG */ if (!xdr_u_int(xdrs, &objp->sfrok_tsize)) { return (FALSE); @@ -967,10 +829,8 @@ xdr_statfsokres(XDR *xdrs, nfsstatfsokres *objp) bool_t xdr_statfsres(XDR *xdrs, nfsstatfsres *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_statfsres:"); -#endif /* DEBUG */ if (!xdr_nfsstat(xdrs, &objp->sfr_status)) { return (FALSE); @@ -993,10 +853,8 @@ xdr_statfsres(XDR *xdrs, nfsstatfsres *objp) bool_t xdr_symlinkargs(XDR *xdrs, nfssymlinkargs *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_symlinkargs:"); -#endif /* DEBUG */ if (!xdr_diropargs(xdrs, &objp->sla_from)) { return (FALSE); @@ -1016,10 +874,8 @@ xdr_symlinkargs(XDR *xdrs, nfssymlinkargs *objp) bool_t xdr_writeargs(XDR *xdrs, nfswriteargs *objp) { -#ifdef DEBUG - amuDebug(D_XDRTRACE) + if (amuDebug(D_XDRTRACE)) plog(XLOG_DEBUG, "xdr_writeargs:"); -#endif /* DEBUG */ if (!xdr_nfs_fh(xdrs, &objp->wra_fhandle)) { return (FALSE); @@ -1042,3 +898,201 @@ xdr_writeargs(XDR *xdrs, nfswriteargs *objp) return (TRUE); } #endif /* not HAVE_XDR_WRITEARGS */ + + +/* + * NFS V3 XDR FUNCTIONS: + */ +#ifdef HAVE_FS_NFS3 +bool_t +xdr_am_fhandle3(XDR *xdrs, am_fhandle3 *objp) +{ + if (amuDebug(D_XDRTRACE)) + plog(XLOG_DEBUG, "xdr_am_fhandle3:"); + + if (!xdr_bytes(xdrs, + (char **) &objp->fhandle3_val, + (u_int *) &objp->fhandle3_len, + AM_FHSIZE3)) + return (FALSE); + return (TRUE); +} + + +bool_t +xdr_am_mountstat3(XDR *xdrs, am_mountstat3 *objp) +{ + enum_t local_obj = *objp; + + if (amuDebug(D_XDRTRACE)) + plog(XLOG_DEBUG, "xdr_am_mountstat3:"); + + if (!xdr_enum(xdrs, &local_obj)) + return (FALSE); + return (TRUE); +} + + +bool_t +xdr_am_mountres3_ok(XDR *xdrs, am_mountres3_ok *objp) +{ + if (amuDebug(D_XDRTRACE)) + plog(XLOG_DEBUG, "xdr_am_mountres3_ok:"); + + if (!xdr_am_fhandle3(xdrs, &objp->fhandle)) + return (FALSE); + if (!xdr_array(xdrs, + (char **) ((voidp) &objp->auth_flavors.auth_flavors_val), + (u_int *) &objp->auth_flavors.auth_flavors_len, + ~0, + sizeof(int), + (XDRPROC_T_TYPE) xdr_int)) + return (FALSE); + return (TRUE); +} + + +bool_t +xdr_am_mountres3(XDR *xdrs, am_mountres3 *objp) +{ + if (amuDebug(D_XDRTRACE)) + plog(XLOG_DEBUG, "xdr_am_mountres3:"); + + if (!xdr_am_mountstat3(xdrs, &objp->fhs_status)) + return (FALSE); + + if (objp->fhs_status == AM_MNT3_OK) { + if (!xdr_am_mountres3_ok(xdrs, &objp->mountres3_u.mountinfo)) + return (FALSE); + } + return (TRUE); +} + + +bool_t +xdr_am_diropargs3(XDR *xdrs, am_diropargs3 *objp) +{ + if (amuDebug(D_XDRTRACE)) + plog(XLOG_DEBUG, "xdr_am_diropargs3:"); + + if (!xdr_am_nfs_fh3(xdrs, &objp->dir)) + return (FALSE); + if (!xdr_am_filename3(xdrs, &objp->name)) + return (FALSE); + return (TRUE); +} + + +bool_t +xdr_am_filename3(XDR *xdrs, am_filename3 *objp) +{ + if (amuDebug(D_XDRTRACE)) + plog(XLOG_DEBUG, "xdr_am_filename3:"); + + if (!xdr_string(xdrs, objp, ~0)) + return (FALSE); + return (TRUE); +} + + +bool_t +xdr_am_LOOKUP3args(XDR *xdrs, am_LOOKUP3args *objp) +{ + if (amuDebug(D_XDRTRACE)) + plog(XLOG_DEBUG, "xdr_am_LOOKUP3args:"); + + if (!xdr_am_diropargs3(xdrs, &objp->what)) + return (FALSE); + return (TRUE); +} + + +bool_t +xdr_am_LOOKUP3res(XDR *xdrs, am_LOOKUP3res *objp) +{ + if (amuDebug(D_XDRTRACE)) + plog(XLOG_DEBUG, "xdr_am_LOOKUP3res:"); + + if (!xdr_am_nfsstat3(xdrs, &objp->status)) + return (FALSE); + switch (objp->status) { + case AM_NFS3_OK: + if (!xdr_am_LOOKUP3resok(xdrs, &objp->res_u.ok)) + return (FALSE); + break; + default: + if (!xdr_am_LOOKUP3resfail(xdrs, &objp->res_u.fail)) + return (FALSE); + break; + } + return (TRUE); +} + + +bool_t +xdr_am_LOOKUP3resfail(XDR *xdrs, am_LOOKUP3resfail *objp) +{ + if (amuDebug(D_XDRTRACE)) + plog(XLOG_DEBUG, "xdr_am_LOOKUP3resfail:"); + + /* + * Don't xdr post_op_attr: amd doesn't need them, but they require many + * additional xdr functions. + */ +#if 0 + if (!xdr_post_op_attr(xdrs, &objp->dir_attributes)) + return (FALSE); +#endif + return (TRUE); +} + + +bool_t +xdr_am_LOOKUP3resok(XDR *xdrs, am_LOOKUP3resok *objp) +{ + if (amuDebug(D_XDRTRACE)) + plog(XLOG_DEBUG, "xdr_am_LOOKUP3resok:"); + + if (!xdr_am_nfs_fh3(xdrs, &objp->object)) + return (FALSE); + /* + * Don't xdr post_op_attr: amd doesn't need them, but they require many + * additional xdr functions. + */ +#if 0 + if (!xdr_post_op_attr(xdrs, &objp->obj_attributes)) + return (FALSE); + if (!xdr_post_op_attr(xdrs, &objp->dir_attributes)) + return (FALSE); +#endif + return (TRUE); +} + + +bool_t +xdr_am_nfs_fh3(XDR *xdrs, am_nfs_fh3 *objp) +{ + if (amuDebug(D_XDRTRACE)) + plog(XLOG_DEBUG, "xdr_am_nfs_fh3:"); + + if (!xdr_u_int(xdrs, &objp->am_fh3_length)) + return (FALSE); + if (objp->am_fh3_length > AM_FHSIZE3) + return (FALSE); + if (!xdr_opaque(xdrs, objp->am_fh3_data, objp->am_fh3_length)) + return (FALSE); + return (TRUE); +} + + +bool_t +xdr_am_nfsstat3(XDR *xdrs, am_nfsstat3 *objp) +{ + if (amuDebug(D_XDRTRACE)) + plog(XLOG_DEBUG, "xdr_am_nfsstat3:"); + + if (!xdr_enum(xdrs, (enum_t *)objp)) + return (FALSE); + return (TRUE); +} +#endif /* not HAVE_FS_NFS3 */ diff --git a/contrib/amd/libamu/xutil.c b/contrib/amd/libamu/xutil.c index 5095c23bf30a..3a33b9c0b149 100644 --- a/contrib/amd/libamu/xutil.c +++ b/contrib/amd/libamu/xutil.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,12 +36,15 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: xutil.c,v 1.11.2.13 2004/01/06 03:15:24 ezk Exp $ + * File: am-utils/libamu/xutil.c * */ +/* + * Miscellaneous Utilities: Logging, TTY, timers, signals, RPC, memory, etc. + */ + #ifdef HAVE_CONFIG_H # include <config.h> #endif /* HAVE_CONFIG_H */ @@ -56,13 +59,11 @@ FILE *logfp = NULL; static char *am_progname = "unknown"; /* "amd" */ -static char am_hostname[MAXHOSTNAMELEN + 1] = "unknown"; /* Hostname */ +static char am_hostname[MAXHOSTNAMELEN] = "unknown"; /* Hostname */ pid_t am_mypid = -1; /* process ID */ serv_state amd_state; /* amd's state */ int foreground = 1; /* 1 == this is the top-level server */ -#ifdef DEBUG int debug_flags = 0; -#endif /* DEBUG */ #ifdef HAVE_SYSLOG int syslogging; @@ -71,12 +72,11 @@ int xlog_level = XLOG_ALL & ~XLOG_MAP & ~XLOG_STATS; int xlog_level_init = ~0; static int amd_program_number = AMQ_PROGRAM; -time_t clock_valid = 0; -time_t xclock_valid = 0; - #ifdef DEBUG_MEM +# if defined(HAVE_MALLINFO) && defined(HAVE_MALLOC_VERIFY) static int mem_bytes; static int orig_mem_bytes; +# endif /* not defined(HAVE_MALLINFO) && defined(HAVE_MALLOC_VERIFY) */ #endif /* DEBUG_MEM */ /* forward definitions */ @@ -91,23 +91,21 @@ static void real_plog(int lvl, const char *fmt, va_list vargs) */ struct opt_tab dbg_opt[] = { - {"all", D_ALL}, /* All */ - {"amq", D_AMQ}, /* Register for AMQ program */ - {"daemon", D_DAEMON}, /* Enter daemon mode */ - {"fork", D_FORK}, /* Fork server (nofork = don't fork) */ + {"all", D_ALL}, /* All non-disruptive options */ + {"amq", D_AMQ}, /* Don't register for AMQ program */ + {"daemon", D_DAEMON}, /* Don't enter daemon mode */ + {"fork", D_FORK}, /* Don't fork server */ {"full", D_FULL}, /* Program trace */ #ifdef HAVE_CLOCK_GETTIME {"hrtime", D_HRTIME}, /* Print high resolution time stamps */ #endif /* HAVE_CLOCK_GETTIME */ /* info service specific debugging (hesiod, nis, etc) */ {"info", D_INFO}, -# ifdef DEBUG_MEM {"mem", D_MEM}, /* Trace memory allocations */ -# endif /* DEBUG_MEM */ {"mtab", D_MTAB}, /* Use local mtab file */ - {"readdir", D_READDIR}, /* check on browsable_dirs progress */ + {"readdir", D_READDIR}, /* Check on browsable_dirs progress */ {"str", D_STR}, /* Debug string munging */ - {"test", D_TEST}, /* Full debug - but no daemon */ + {"test", D_TEST}, /* Full debug - no daemon, no amq, local mtab */ {"trace", D_TRACE}, /* Protocol trace */ {"xdrtrace", D_XDRTRACE}, /* Trace xdr routines */ {0, 0} @@ -152,8 +150,7 @@ am_get_progname(void) void am_set_hostname(char *hn) { - strncpy(am_hostname, hn, MAXHOSTNAMELEN); - am_hostname[MAXHOSTNAMELEN] = '\0'; + xstrlcpy(am_hostname, hn, MAXHOSTNAMELEN); } @@ -172,6 +169,13 @@ am_set_mypid(void) } +long +get_server_pid() +{ + return (long) (foreground ? am_mypid : getppid()); +} + + voidp xmalloc(int len) { @@ -187,10 +191,8 @@ xmalloc(int len) do { p = (voidp) malloc((unsigned) len); if (p) { -#if defined(DEBUG) && defined(DEBUG_MEM) - amuDebug(D_MEM) - plog(XLOG_DEBUG, "Allocated size %d; block %#x", len, p); -#endif /* defined(DEBUG) && defined(DEBUG_MEM) */ + if (amuDebug(D_MEM)) + plog(XLOG_DEBUG, "Allocated size %d; block %p", len, p); return p; } if (retries > 0) { @@ -223,9 +225,8 @@ xzalloc(int len) voidp xrealloc(voidp ptr, int len) { -#if defined(DEBUG) && defined(DEBUG_MEM) - amuDebug(D_MEM) plog(XLOG_DEBUG, "Reallocated size %d; block %#x", len, ptr); -#endif /* defined(DEBUG) && defined(DEBUG_MEM) */ + if (amuDebug(D_MEM)) + plog(XLOG_DEBUG, "Reallocated size %d; block %p", len, ptr); if (len == 0) len = 1; @@ -244,20 +245,19 @@ xrealloc(voidp ptr, int len) } -#if defined(DEBUG) && defined(DEBUG_MEM) +#ifdef DEBUG_MEM void dxfree(char *file, int line, voidp ptr) { - amuDebug(D_MEM) - plog(XLOG_DEBUG, "Free in %s:%d: block %#x", file, line, ptr); + if (amuDebug(D_MEM)) + plog(XLOG_DEBUG, "Free in %s:%d: block %p", file, line, ptr); /* this is the only place that must NOT use XFREE()!!! */ free(ptr); ptr = NULL; /* paranoid */ } -#endif /* defined(DEBUG) && defined(DEBUG_MEM) */ -#ifdef DEBUG_MEM +# if defined(HAVE_MALLINFO) && defined(HAVE_MALLOC_VERIFY) static void checkup_mem(void) { @@ -280,6 +280,7 @@ checkup_mem(void) } malloc_verify(); } +# endif /* not defined(HAVE_MALLINFO) && defined(HAVE_MALLOC_VERIFY) */ #endif /* DEBUG_MEM */ @@ -289,16 +290,16 @@ checkup_mem(void) * 'e' never gets longer than maxlen characters. */ static const char * -expand_error(const char *f, char *e, int maxlen) +expand_error(const char *f, char *e, size_t maxlen) { const char *p; char *q; int error = errno; int len = 0; - for (p = f, q = e; (*q = *p) && len < maxlen; len++, q++, p++) { + for (p = f, q = e; (*q = *p) && (size_t) len < maxlen; len++, q++, p++) { if (p[0] == '%' && p[1] == 'm') { - strcpy(q, strerror(error)); + xstrlcpy(q, strerror(error), maxlen); len += strlen(q) - 1; q += strlen(q) - 1; p++; @@ -318,27 +319,27 @@ show_time_host_and_name(int lvl) static time_t last_t = 0; static char *last_ctime = 0; time_t t; -#ifdef HAVE_CLOCK_GETTIME +#if defined(HAVE_CLOCK_GETTIME) && defined(DEBUG) struct timespec ts; -#endif /* HAVE_CLOCK_GETTIME */ - char nsecs[11] = ""; /* '.' + 9 digits + '\0' */ +#endif /* defined(HAVE_CLOCK_GETTIME) && defined(DEBUG) */ + char nsecs[11]; /* '.' + 9 digits + '\0' */ char *sev; -#ifdef HAVE_CLOCK_GETTIME + nsecs[0] = '\0'; + +#if defined(HAVE_CLOCK_GETTIME) && defined(DEBUG) /* * Some systems (AIX 4.3) seem to implement clock_gettime() as stub * returning ENOSYS. */ if (clock_gettime(CLOCK_REALTIME, &ts) == 0) { t = ts.tv_sec; -#ifdef DEBUG - amuDebug(D_HRTIME) - sprintf(nsecs, ".%09ld", ts.tv_nsec); -#endif /* DEBUG */ + if (amuDebug(D_HRTIME)) + xsnprintf(nsecs, sizeof(nsecs), ".%09ld", ts.tv_nsec); } else -#endif /* HAVE_CLOCK_GETTIME */ - t = clocktime(); +#endif /* defined(HAVE_CLOCK_GETTIME) && defined(DEBUG) */ + t = clocktime(NULL); if (t != last_t) { last_ctime = ctime(&t); @@ -435,29 +436,20 @@ real_plog(int lvl, const char *fmt, va_list vargs) return; #ifdef DEBUG_MEM +# if defined(HAVE_MALLINFO) && defined(HAVE_MALLOC_VERIFY) checkup_mem(); +# endif /* not defined(HAVE_MALLINFO) && defined(HAVE_MALLOC_VERIFY) */ #endif /* DEBUG_MEM */ -#ifdef HAVE_VSNPRINTF - /* - * XXX: ptr is 1024 bytes long, but we may write to ptr[strlen(ptr) + 2] - * (to add an '\n', see code below) so we have to limit the string copy - * to 1023 (including the '\0'). - */ - vsnprintf(ptr, 1023, expand_error(fmt, efmt, 1024), vargs); - msg[1022] = '\0'; /* null terminate, to be sure */ -#else /* not HAVE_VSNPRINTF */ /* - * XXX: ptr is 1024 bytes long. It is possible to write into it - * more than 1024 bytes, if efmt is already large, and vargs expand - * as well. This is not as safe as using vsnprintf(). + * Note: xvsnprintf() may call plog() if a truncation happened, but the + * latter has some code to break out of an infinite loop. See comment in + * xsnprintf() below. */ - vsprintf(ptr, expand_error(fmt, efmt, 1023), vargs); - msg[1023] = '\0'; /* null terminate, to be sure */ -#endif /* not HAVE_VSNPRINTF */ + xvsnprintf(ptr, 1023, expand_error(fmt, efmt, 1024), vargs); ptr += strlen(ptr); - if (ptr[-1] == '\n') + if (*(ptr-1) == '\n') *--ptr = '\0'; #ifdef HAVE_SYSLOG @@ -505,7 +497,8 @@ real_plog(int lvl, const char *fmt, va_list vargs) switch (last_count) { case 0: /* never printed at all */ last_count = 1; - strncpy(last_msg, msg, 1024); + if (strlcpy(last_msg, msg, 1024) >= 1024) /* don't use xstrlcpy here (recursive!) */ + fprintf(stderr, "real_plog: string \"%s\" truncated to \"%s\"\n", last_msg, msg); last_lvl = lvl; show_time_host_and_name(lvl); /* mimic syslog header */ fwrite(msg, ptr - msg, 1, logfp); @@ -517,7 +510,8 @@ real_plog(int lvl, const char *fmt, va_list vargs) last_count++; } else { /* last msg printed once, new one differs */ /* last_count remains at 1 */ - strncpy(last_msg, msg, 1024); + if (strlcpy(last_msg, msg, 1024) >= 1024) /* don't use xstrlcpy here (recursive!) */ + fprintf(stderr, "real_plog: string \"%s\" truncated to \"%s\"\n", last_msg, msg); last_lvl = lvl; show_time_host_and_name(lvl); /* mimic syslog header */ fwrite(msg, ptr - msg, 1, logfp); @@ -531,7 +525,8 @@ real_plog(int lvl, const char *fmt, va_list vargs) * cycles like crazy. */ show_time_host_and_name(last_lvl); - sprintf(last_msg, "last message repeated %d times\n", last_count); + xsnprintf(last_msg, sizeof(last_msg), + "last message repeated %d times\n", last_count); fwrite(last_msg, strlen(last_msg), 1, logfp); fflush(logfp); last_count = 0; /* start from scratch */ @@ -542,9 +537,11 @@ real_plog(int lvl, const char *fmt, va_list vargs) last_count++; } else { /* last msg repeated+skipped, new one differs */ show_time_host_and_name(last_lvl); - sprintf(last_msg, "last message repeated %d times\n", last_count); + xsnprintf(last_msg, sizeof(last_msg), + "last message repeated %d times\n", last_count); fwrite(last_msg, strlen(last_msg), 1, logfp); - strncpy(last_msg, msg, 1024); + if (strlcpy(last_msg, msg, 1024) >= 1024) /* don't use xstrlcpy here (recursive!) */ + fprintf(stderr, "real_plog: string \"%s\" truncated to \"%s\"\n", last_msg, msg); last_count = 1; last_lvl = lvl; show_time_host_and_name(lvl); /* mimic syslog header */ @@ -667,6 +664,7 @@ switch_option(char *opt) return rc; } + #ifdef LOG_DAEMON /* * get syslog facility to use. @@ -771,7 +769,7 @@ get_syslog_facility(const char *logfile) * Change current logfile */ int -switch_to_logfile(char *logfile, int old_umask) +switch_to_logfile(char *logfile, int old_umask, int truncate_log) { FILE *new_logfp = stderr; @@ -789,9 +787,6 @@ switch_to_logfile(char *logfile, int old_umask) new_logfp = stderr; openlog(am_get_progname(), LOG_PID -# ifdef LOG_CONS - | LOG_CONS -# endif /* LOG_CONS */ # ifdef LOG_NOWAIT | LOG_NOWAIT # endif /* LOG_NOWAIT */ @@ -803,8 +798,10 @@ switch_to_logfile(char *logfile, int old_umask) plog(XLOG_WARNING, "syslog option not supported, logging unchanged"); #endif /* not HAVE_SYSLOG */ - } else { + } else { /* regular log file */ (void) umask(old_umask); + if (truncate_log) + truncate(logfile, 0); new_logfp = fopen(logfile, "a"); umask(0); } @@ -837,11 +834,14 @@ switch_to_logfile(char *logfile, int old_umask) void unregister_amq(void) { -#ifdef DEBUG - amuDebug(D_AMQ) -#endif /* DEBUG */ + if (!amuDebug(D_AMQ)) { /* find which instance of amd to unregister */ - pmap_unset(get_amd_program_number(), AMQ_VERSION); + u_long amd_prognum = get_amd_program_number(); + + if (pmap_unset(amd_prognum, AMQ_VERSION) != 1) + dlog("failed to de-register Amd program %lu, version %lu", + amd_prognum, AMQ_VERSION); + } } @@ -855,14 +855,21 @@ going_down(int rc) unregister_amq(); } } + +#ifdef MOUNT_TABLE_ON_FILE + /* + * Call unlock_mntlist to free any important resources such as an on-disk + * lock file (/etc/mtab~). + */ + unlock_mntlist(); +#endif /* MOUNT_TABLE_ON_FILE */ + if (foreground) { plog(XLOG_INFO, "Finishing with status %d", rc); } else { -#ifdef DEBUG dlog("background process exiting with status %d", rc); -#endif /* DEBUG */ } - + /* bye bye... */ exit(rc); } @@ -896,10 +903,7 @@ set_amd_program_number(int program) void amu_release_controlling_tty(void) { -#ifdef TIOCNOTTY int fd; -#endif /* TIOCNOTTY */ - int tempfd; /* * In daemon mode, leaving open file descriptors to terminals or pipes @@ -917,11 +921,15 @@ amu_release_controlling_tty(void) * * XXX We should also probably set the SIGPIPE handler to SIG_IGN. */ - tempfd = open("/dev/null", O_RDWR); - fflush(stdin); close(0); dup2(tempfd, 0); - fflush(stdout); close(1); dup2(tempfd, 1); - fflush(stderr); close(2); dup2(tempfd, 2); - close(tempfd); + fd = open("/dev/null", O_RDWR); + if (fd < 0) { + plog(XLOG_WARNING, "Could not open /dev/null for rw: %m"); + } else { + fflush(stdin); close(0); dup2(fd, 0); + fflush(stdout); close(1); dup2(fd, 1); + fflush(stderr); close(2); dup2(fd, 2); + close(fd); + } #ifdef HAVE_SETSID /* XXX: one day maybe use vhangup(2) */ @@ -951,3 +959,133 @@ amu_release_controlling_tty(void) plog(XLOG_ERROR, "unable to release controlling tty"); } + + +/* setup a single signal handler */ +void +setup_sighandler(int signum, void (*handler)(int)) +{ +#ifdef HAVE_SIGACTION + struct sigaction sa; + memset(&sa, 0, sizeof(sa)); + sa.sa_flags = 0; /* unnecessary */ + sa.sa_handler = handler; + sigemptyset(&(sa.sa_mask)); /* probably unnecessary too */ + sigaddset(&(sa.sa_mask), signum); + sigaction(signum, &sa, NULL); +#else /* not HAVE_SIGACTION */ + (void) signal(signum, handler); +#endif /* not HAVE_SIGACTION */ +} + + +/* + * Return current time in seconds. If passed a non-null argyument, then + * fill it in with the current time in seconds and microseconds (useful + * for mtime updates). + */ +time_t +clocktime(nfstime *nt) +{ + static struct timeval now; /* keep last time, as default */ + + if (gettimeofday(&now, NULL) < 0) { + plog(XLOG_ERROR, "clocktime: gettimeofday: %m"); + /* hack: force time to have incremented by at least 1 second */ + now.tv_sec++; + } + /* copy seconds and microseconds. may demote a long to an int */ + if (nt) { + nt->nt_seconds = (u_int) now.tv_sec; + nt->nt_useconds = (u_int) now.tv_usec; + } + return (time_t) now.tv_sec; +} + + +/* + * Make all the directories in the path. + */ +int +mkdirs(char *path, int mode) +{ + /* + * take a copy in case path is in readonly store + */ + char *p2 = strdup(path); + char *sp = p2; + struct stat stb; + int error_so_far = 0; + + /* + * Skip through the string make the directories. + * Mostly ignore errors - the result is tested at the end. + * + * This assumes we are root so that we can do mkdir in a + * mode 555 directory... + */ + while ((sp = strchr(sp + 1, '/'))) { + *sp = '\0'; + if (mkdir(p2, mode) < 0) { + error_so_far = errno; + } else { + dlog("mkdir(%s)", p2); + } + *sp = '/'; + } + + if (mkdir(p2, mode) < 0) { + error_so_far = errno; + } else { + dlog("mkdir(%s)", p2); + } + + XFREE(p2); + + return stat(path, &stb) == 0 && + (stb.st_mode & S_IFMT) == S_IFDIR ? 0 : error_so_far; +} + + +/* + * Remove as many directories in the path as possible. + * Give up if the directory doesn't appear to have + * been created by Amd (not mode dr-x) or an rmdir + * fails for any reason. + */ +void +rmdirs(char *dir) +{ + char *xdp = strdup(dir); + char *dp; + + do { + struct stat stb; + /* + * Try to find out whether this was + * created by amd. Do this by checking + * for owner write permission. + */ + if (stat(xdp, &stb) == 0 && (stb.st_mode & 0200) == 0) { + if (rmdir(xdp) < 0) { + if (errno != ENOTEMPTY && + errno != EBUSY && + errno != EEXIST && + errno != EROFS && + errno != EINVAL) + plog(XLOG_ERROR, "rmdir(%s): %m", xdp); + break; + } else { + dlog("rmdir(%s)", xdp); + } + } else { + break; + } + + dp = strrchr(xdp, '/'); + if (dp) + *dp = '\0'; + } while (dp && dp > xdp); + + XFREE(xdp); +} diff --git a/contrib/amd/mk-amd-map/mk-amd-map.8 b/contrib/amd/mk-amd-map/mk-amd-map.8 index 2e2436667088..f5cef608ea13 100644 --- a/contrib/amd/mk-amd-map/mk-amd-map.8 +++ b/contrib/amd/mk-amd-map/mk-amd-map.8 @@ -1,5 +1,5 @@ .\" -.\" Copyright (c) 1997-2004 Erez Zadok +.\" Copyright (c) 1997-2006 Erez Zadok .\" Copyright (c) 1993 Jan-Simon Pendry .\" Copyright (c) 1993 .\" The Regents of the University of California. All rights reserved. @@ -33,7 +33,7 @@ .\" SUCH DAMAGE. .\" .\" from: @(#)mk-amd-map.8 8.1 (Berkeley) 6/28/93 -.\" $Id: mk-amd-map.8,v 1.3.2.4 2004/01/06 03:15:24 ezk Exp $ +.\" $Id: mk-amd-map.8,v 1.9.2.1 2006/01/02 18:48:26 ezk Exp $ .\" .TH MK-AMD-MAP 8 "June 28, 1993" .SH NAME @@ -60,3 +60,23 @@ a database. This is usually used to merge continuation lines into one physical line. .SH SEE ALSO .BR amd (8). +.LP +``am-utils'' +.BR info (1) +entry. +.LP +.I "Linux NFS and Automounter Administration" +by Erez Zadok, ISBN 0-7821-2739-8, (Sybex, 2001). +.LP +.I http://www.am-utils.org +.LP +.I "Amd \- The 4.4 BSD Automounter" +.SH AUTHORS +Jan-Simon Pendry <jsp@doc.ic.ac.uk>, Department of Computing, Imperial College, London, UK. +.P +Erez Zadok <ezk@cs.sunysb.edu>, Computer Science Department, Stony Brook +University, New York, USA. +.P +Other authors and contributors to am-utils are listed in the +.B AUTHORS +file distributed with am-utils. diff --git a/contrib/amd/mk-amd-map/mk-amd-map.c b/contrib/amd/mk-amd-map/mk-amd-map.c index a9ae96567b6d..48d82b0bd0d7 100644 --- a/contrib/amd/mk-amd-map/mk-amd-map.c +++ b/contrib/amd/mk-amd-map/mk-amd-map.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: mk-amd-map.c,v 1.5.2.6 2004/01/06 03:15:25 ezk Exp $ + * File: am-utils/mk-amd-map/mk-amd-map.c */ /* @@ -223,7 +222,7 @@ main(int argc, char *argv[]) char maptpag[16], maptdir[16]; char *map_name_pag = (char *) NULL, *map_name_dir = (char *) NULL; #endif /* not HAVE_DB_SUFFIX */ - int len; + size_t l = 0; char *sl; int printit = 0; int usage = 0; @@ -272,13 +271,14 @@ main(int argc, char *argv[]) #endif /* DEBUG */ if (!printit) { - len = strlen(mapsrc); + /* enough space for ".db" or ".pag" or ".dir" appended */ + l = strlen(mapsrc) + 5; #ifdef HAVE_DB_SUFFIX - map_name_db = (char *) malloc(len + 4); + map_name_db = (char *) malloc(l); error = (map_name_db == NULL); #else /* not HAVE_DB_SUFFIX */ - map_name_pag = (char *) malloc(len + 5); - map_name_dir = (char *) malloc(len + 5); + map_name_pag = (char *) malloc(l); + map_name_dir = (char *) malloc(l); error = (map_name_pag == NULL || map_name_dir == NULL); #endif /* not HAVE_DB_SUFFIX */ if (error) { @@ -305,15 +305,15 @@ main(int argc, char *argv[]) /* remove existing temps (if any) */ #ifdef HAVE_DB_SUFFIX - sprintf(maptdb, "%s.db", maptmp); + xsnprintf(maptdb, sizeof(maptdb), "%s.db", maptmp); if (remove_file(maptdb) < 0) { fprintf(stderr, "Can't remove existing temporary file; "); perror(maptdb); exit(1); } #else /* not HAVE_DB_SUFFIX */ - sprintf(maptpag, "%s.pag", maptmp); - sprintf(maptdir, "%s.dir", maptmp); + xsnprintf(maptpag, sizeof(maptpag), "%s.pag", maptmp); + xsnprintf(maptdir, sizeof(maptdir), "%s.dir", maptmp); if (remove_file(maptpag) < 0 || remove_file(maptdir) < 0) { fprintf(stderr, "Can't remove existing temporary files; %s and ", maptpag); perror(maptdir); @@ -348,7 +348,8 @@ main(int argc, char *argv[]) /* all went well */ #ifdef HAVE_DB_SUFFIX - sprintf(map_name_db, "%s.db", mapsrc); + /* sizeof(map_name_db) is malloc'ed above */ + xsnprintf(map_name_db, l, "%s.db", mapsrc); if (rename(maptdb, map_name_db) < 0) { fprintf(stderr, "Couldn't rename %s to ", maptdb); perror(map_name_db); @@ -357,8 +358,9 @@ main(int argc, char *argv[]) exit(1); } #else /* not HAVE_DB_SUFFIX */ - sprintf(map_name_pag, "%s.pag", mapsrc); - sprintf(map_name_dir, "%s.dir", mapsrc); + /* sizeof(map_name_{pag,dir}) are malloc'ed above */ + xsnprintf(map_name_pag, l, "%s.pag", mapsrc); + xsnprintf(map_name_dir, l, "%s.dir", mapsrc); if (rename(maptpag, map_name_pag) < 0) { fprintf(stderr, "Couldn't rename %s to ", maptpag); perror(map_name_pag); diff --git a/contrib/amd/scripts/am-eject.in b/contrib/amd/scripts/am-eject.in index 1f7f14d7b176..8754a3bd4751 100644 --- a/contrib/amd/scripts/am-eject.in +++ b/contrib/amd/scripts/am-eject.in @@ -2,7 +2,7 @@ # auto-unmount floppy/cd directory before ejecting device # script taken from Debian Linux's amd # -# Package: am-utils-6.0 +# Package: am-utils-6.x # (Additional) author: Erez Zadok <ezk@cs.columbia.edu> # set path diff --git a/contrib/amd/scripts/amd.conf-sample b/contrib/amd/scripts/amd.conf-sample index 02ccbdfc345b..880a74ba7552 100644 --- a/contrib/amd/scripts/amd.conf-sample +++ b/contrib/amd/scripts/amd.conf-sample @@ -1,17 +1,20 @@ -# -*- text -*- # A SAMPLE CONFIGURATION FILE FOR AMD ############################################################################## # GLOBAL OPTIONS SECTION (must be first in amd.conf file) +# For most options, the default value is listed first, but see amd.conf(5) [ global ] # (amd -n) -normalize_hostnames = yes | no +normalize_hostnames = no | yes +# do we want to strip domain names from hostnames or not? +domain_strip = yes | no # (amd -p) -print_pid = yes | no +print_pid = no | yes pid_file = /dev/stdout | /var/run/amd.pid # (amd -r) -restart_mounts = yes | no +restart_mounts = no | yes unmount_on_exit = no | yes +forced_unmounts = no | yes # (amd -a) auto_dir = /a # duration in seconds that a looked up name remain cached (amd -c) @@ -20,6 +23,7 @@ cache_duration = 300 local_domain = cs.columbia.edu # (amd -k) karch = sun4m +# (amd -A) arch = sun4 # if you don't like autoconf picking up "sunos5" as the os-type, override it # (amd -O) @@ -31,12 +35,28 @@ full_os = linux-2.2.5 # OS vendor vendor = redhat # if you print_version after setting up "os", it will show it. (amd -v) -print_version = yes | no +print_version = no | yes # (amd -l) -log_file = /var/log/amd | syslog | syslog:facility -# NFS (RPC/UDP) retry interval, in tenths of secs (amd -t interval.counter) +log_file = /dev/stderr | /var/log/amd | syslog[:facility] +# should we truncate the log file on startup? +truncate_log = no | yes +# NFS (RPC) retry interval/counter, in tenths of secs (amd -t interval.counter) nfs_retry_interval = 8 nfs_retransmit_counter = 11 (eleven retransmission attempts) +# The next four are the same as the above two, but allow you to set global +# values for all UDP vs. TCP mounts separately. +nfs_retry_interval_udp = 16 +nfs_retransmit_counter_udp = 22 +nfs_retry_interval_tcp = 4 +nfs_retransmit_counter_tcp = 5 +# These two are specific to Amd's top-level (NFSv2/udp) mounts +# and they can also be set separately. +nfs_retry_interval_toplvl = 6 +nfs_retransmit_counter_toplvl = 8 +# NFS attribute cache value for Amd's automount points +# (some OSs use this parameter in units of seconds, and others in 0.1 seconds) +# See README.attrcache for important information about this parameter. +auto_attrcache = 0 # (amd -w) dismount_interval = 120 # (amd -y) @@ -46,38 +66,60 @@ log_options = fatal,error,user,warn,info,map,stats,all # (amd -D) debug_options = all,amq,daemon,fork,full,hrtime,info,mem,mtab,\ str,readdir,test,trace,xdrtrace +# path for mtab file during mtab debug mode +debug_mtab_file = /tmp/mnttab # (amd -S) -plock = no | yes -# selectors are not recognized by default in the /defaults entry -selectors_in_defaults = yes | no +plock = yes | no # should browsable maps show number of entries to df/statfs (default=no) -show_statfs_entries = yes | no +show_statfs_entries = no | yes # (hpux) cluster name (amd -C) cluster = ??? # LDAP (Lightweight Directory Access Protocol) options ldap_base = "ou=Marketing, o=AMD Ltd, c=US" ldap_hostports = ldap.your.domain:389 -ldap_cache_seconds = 0 (default) -ldap_cache_maxmem = 131072 (default) +ldap_cache_seconds = 0 +ldap_cache_maxmem = 131072 +ldap_proto_version = 2 # default base name for hesiod maps hesiod_base = automount -# these 5 options can be overridden by each map individually -browsable_dirs = yes | no | full -map_options = cache:=all -map_type = file|hesiod|ndbm|nis|nisplus|passwd|union|ldap -# regular amd (nfs) mount point (default) -# don't try the "autofs" type. It is not implemented yet. -mount_type = nfs -search_path = /etc/local:/etc/amdmaps:/misc/yp +# interval to check if a reload of any maps is needed +map_reload_interval = 3600 # alternate RPC program number to register with the port mapper portmap_program = 300019-300029 +# Ask for a different Amq RPC port (both UDP and TCP). +# If set to 0 (default), Amd will pick a port automatically. +preferred_amq_port = 1234 # use fully qualified host names -fully_qualified_hosts = yes | no +fully_qualified_hosts = no | yes # force NFS version or NFS protocol nfs_vers = 2 | 3 nfs_proto = udp | tcp +# perform Amq service checks via tcpwrappers (tcpd/libwrap) +use_tcpwrappers = yes | no # allow NFS requests from insecure (>=1024) ports -nfs_allow_insecure_port = yes | no +nfs_allow_insecure_port = no | yes +# accept local NFS packets from any local interface, not just 127.0.0.1 +nfs_allow_any_interface = no | yes +# address used for local NFS mount and RPC server (default to localhost) +localhost_address = foo.example.com | 192.168.1.2 +# number of seconds to timeout before map returns output +exec_map_timeout = 10 +# normalize multiple/trailing slashes or not? +normalize_slashes = yes | no + +############################################################################## +# these 8 global options can be overridden by each map individually +browsable_dirs = no | yes | full +map_options = cache:=all +map_type = file|hesiod|ndbm|nis|nisplus|passwd|union|ldap +# any string that will be used to override to the map /defaults entry +map_defaults = opts:=nosuid,rw,intr,bg,noquota;type:=link +mount_type = nfs | autofs +autofs_use_lofs = yes | no +search_path = /etc/local:/etc/amdmaps:/misc/yp +# selectors are not recognized by default in the /defaults entry +selectors_in_defaults = no | yes +############################################################################## ############################################################################## # DEFINE AN AMD MOUNT POINT @@ -88,9 +130,8 @@ map_options = cache:=all # if map type is not defined, will search all map types (default) map_type = file|hesiod|ndbm|nis|nisplus|passwd|union|ldap search_path = /etc/local:/etc/amdmaps:/misc/yp -# regular amd (nfs) mount point (default) -# don't try the "autofs" type. It is not implemented yet. -mount_type = nfs +# an amd or autofs mount point +mount_type = nfs | autofs browsable_dirs = yes | no # an optional tag to be used with amd -T tag. untagged entries are always # used. Tagged ones get used only if specified with "amd -T" @@ -99,9 +140,25 @@ tag = test ############################################################################## # DEFINE ANOTHER AMD MOUNT POINT [ /src ] -map_name = /usr/local/lib/amdmaps/amu.src +map_name = /usr/local/lib/amdmaps/amu.src # regular amd (nfs) mount point (default) -# don't try the "autofs" type. It is not implemented yet. -mount_type = nfs +mount_type = nfs +# any string that will be used as prefix to the map /defaults entry +# this overrides what's defined in [global] +map_defaults = type:=nfs + +############################################################################## +# DEFINE ANOTHER AMD MOUNT POINT +[ /test ] +map_name = /etc/lookup-entry.sh +# an executable map type +map_type = exec + +############################################################################## +# DEFINE A SUN SYNTAX MOUNT POINT +[ /proj ] +map_name = /etc/amd.proj +# does this map use Sun Automounter map syntax? +sun_map_syntax = yes ############################################################################## diff --git a/contrib/amd/scripts/amd.conf.5 b/contrib/amd/scripts/amd.conf.5 index 6e6b4ddc4770..36e08cd9a41b 100644 --- a/contrib/amd/scripts/amd.conf.5 +++ b/contrib/amd/scripts/amd.conf.5 @@ -1,5 +1,5 @@ .\" -.\" Copyright (c) 1997-2004 Erez Zadok +.\" Copyright (c) 1997-2006 Erez Zadok .\" Copyright (c) 1990 Jan-Simon Pendry .\" Copyright (c) 1990 Imperial College of Science, Technology & Medicine .\" Copyright (c) 1990 The Regents of the University of California. @@ -38,21 +38,21 @@ .\" .\" %W% (Berkeley) %G% .\" -.\" $Id: amd.conf.5,v 1.7.2.10 2004/01/21 04:04:58 ib42 Exp $ +.\" $Id: amd.conf.5,v 1.39.2.5 2006/04/21 01:12:04 ezk Exp $ .\" .TH AMD.CONF 5 "7 August 1997" .SH NAME -amd.conf \- amd configuration file +amd.conf \- Amd configuration file .SH SYNOPSIS .B amd.conf .SH DESCRIPTION The .B amd.conf -file is the configuration file for amd, as part of the am-utils suite. +file is the configuration file for Amd, as part of the am-utils suite. .P .B amd.conf contains runtime configuration information for the -.B amd +.B Amd automounter program. .\" ************************************************************************** .SH FILE FORMAT @@ -85,7 +85,7 @@ cache timeouts are numeric. .\" ************************************************************************** .SH SECTIONS .SS The [global] section -Parameters in this section either apply to amd as a whole, or to all other +Parameters in this section either apply to Amd as a whole, or to all other regular map sections which follow. There should be only one global section defined in one configuration file. .P @@ -99,7 +99,7 @@ For example, if the map section .B [/homes] is defined, then all parameters following it will be applied to the .I /homes -amd-managed mount point. +Amd-managed mount point. .\" ************************************************************************** .SH PARAMETERS .SS Parameters common to all sections @@ -111,34 +111,41 @@ sections that follow. .\" ************************************************************************** .TP .BR browsable_dirs " (string, default=no)" -If "yes", then amd's top-level mount points will be browsable to +If "yes," then Amd's top-level mount points will be browsable to .BR readdir (3) calls. This means you could run for example -.BR ls (3) +.BR ls (1) and see what keys are available to mount in that directory. Not all entries are made visible to readdir(3): the "/default" entry, wildcard entries, and those with a "/" in them are not included. If you specify "full" to this option, all but "/default" will be visible. Note that if you run a command which will attempt to .BR stat (2) -the entries, such as often done by "ls -l" or "ls -F", amd will attempt to +the entries, such as often done by "ls -l" or "ls -F," Amd will attempt to mount .I every -entry in that map. This is often called a ``mount storm''. +entry in that map. This is often called a ``mount storm.'' + +.TP +.BR map_defaults " (string, default to empty)" +This option sets a string to be used as the map's /defaults entry, +overriding any /defaults specified in the map. This allows local users to +override map defaults without modifying maps globally. .TP .BR map_options " (string, default no options)" This option is the same as specifying map options on the command line to -amd, such as "cache:=all". +Amd, such as "cache:=all". .TP .BR map_type " (string, default search all map types)" -If specified, amd will initialize the map only for the type given. This is -useful to avoid the default map search type used by amd which takes longer +If specified, Amd will initialize the map only for the type given. This is +useful to avoid the default map search type used by Amd which takes longer and can have undesired side-effects such as initializing NIS even if not used. Possible values are .nf +\fBexec\fR executable maps \fBfile\fR plain files \fBhesiod\fR Hesiod name service from MIT \fBldap\fR Lightweight Directory Access Protocol @@ -151,9 +158,17 @@ used. Possible values are .TP .BR mount_type " (string, default=nfs)" -All amd mount types must be NFS. That is, amd is an NFS server on the +All Amd mount types default to NFS. That is, Amd is an NFS server on the map mount points, for the local host it is running on. If "autofs" is -specified, amd will log an error and convert it to NFS. +specified, Amd will be an autofs server for those mount points. + +.TP +.BR autofs_use_lofs " (string, default=yes)" +When set to "yes" and using Autofs, Amd will use lofs-type (loopback) mounts +for type:=link mounts. This has the advantage of mounting in place, and +users get to the see the same pathname that they chdir'ed into. If this +option is set to "no," then Amd will use symlinks instead: that code is more +tested, but negates autofs's big advantage of in-place mounts. .TP .BR search_path " (string, default no search path)" @@ -161,45 +176,81 @@ This provides a (colon-delimited) search path for file maps. Using a search path, sites can allow for local map customizations and overrides, and can distributed maps in several locations as needed. +.TP +.BR selectors_in_defaults " (boolean, default=no)" +If "yes," then the /defaults entry of maps will search for and process any +selectors before setting defaults for all other keys in that map. Useful +when you want to set different options for a complete map based on some +parameters. For example, you may want to better the NFS performance over +slow slip-based networks as follows: + +.nf +/defaults \\ + wire==slip-net;opts:=intr,rsize=1024,wsize=1024 \\ + wire!=slip-net;opts:=intr,rsize=8192,wsize=8192 +.fi + +Deprecated form: selectors_on_default + .\" ************************************************************************** .SS Parameters applicable to the global section only .TP .BR arch " (string, default to compiled in value)" -Allows you to override the value of the +Same as the +.B \-A +option to Amd. Allows you to override the value of the .I arch -amd variable. +Amd variable. + +.TP +.BR auto_attrcache " (numeric, default=0)" +Specify in seconds (or units of 0.1 seconds, depending on the OS), what is +the (kernel-side) NFS attribute cache timeout for @i{Amd}'s own automount +points. A value of 0 is supposed to turn off attribute caching, meaning +that @i{Amd} will be consulted via a kernel-RPC each time someone stat()'s +the mount point (which could be abused as a denial-of-service attack). +Warning: some OSs are incapable of turning off the NFS attribute cache +reliably. On such systems, Amd may not work reliably under heavy load. See +the README.attrcache document in the Am-utils distribution for more details. .TP .BR auto_dir " (string, default=/a)" Same as the .B \-a -option to amd. This sets the private directory where amd will create +option to Amd. This sets the private directory where Amd will create sub-directories for its real mount points. .TP .BR cache_duration " (numeric, default=300)" Same as the .B \-c -option to amd. Sets the duration in seconds that looked up map entries -remain in the cache. +option to Amd. Sets the duration in seconds that looked-up or mounted map +entries remain in the cache. .TP .BR cluster " (string, default no cluster)" Same as the .B \-C -option to amd. Specifies the alternate HP-UX cluster to use. +option to Amd. Specifies the alternate HP-UX cluster to use. + +.TP +.BR debug_mtab_file " (string, default=/tmp/mnttab)" +Path to mtab file that is used by Amd to store a list of mounted +file systems during debug-mtab mode. This option only applies +to systems that store mtab information on disk. +.TP .TP .BR debug_options " (string, default no debug options)" Same as the .B \-D -option to amd. Specify any debugging options for amd. Works only if +option to Amd. Specify any debugging options for Amd. Works only if am-utils was configured for debugging using the --enable-debug option. The "mem" option, as well as all other options, can be turned on via --enable-debug=mem. Otherwise debugging options are ignored. Options are comma delimited, and can be preceded by the string "no" to negate their -meaning. You can get the list of supported debugging options by running amd +meaning. You can get the list of supported debugging options by running Amd \-H. Possible values are: .nf @@ -223,10 +274,45 @@ meaning. You can get the list of supported debugging options by running amd .BR dismount_interval " (numeric, default=120)" Same as the .B \-w -option to amd. Specify in seconds, the time between attempts to dismount +option to Amd. Specify in seconds, the time between attempts to dismount file systems that have exceeded their cached times. .TP +.BR domain_strip " (boolean, default=yes)" +If "yes," then the domain +name part referred to by ${rhost} is stripped off. This is +useful to keep logs and smaller. If "no," then the domain name +part is left changed. This is useful when using multiple domains with +the same maps (as you may have hosts whose domain-stripped name is +identical). + +.TP +.BR exec_map_timeout " (numeric, default=10)" +The timeout in seconds that +.I Amd +will wait for an executable map program before an answer is returned from +that program (or script). This value should be set to as small as possible +while still allowing normal replies to be returned before the timer expires, +because during the time that the executable map program is queried, +.I Amd +is essentially waiting and is thus not responding to any other queries. + +.TP +.BR forced_unmounts " (boolean, default=no)" +If set to "yes," and the client OS supports forced or lazy unmounts, then +.I Amd +will attempt to use them if it gets any of three serious error conditions +when trying to unmount an existing mount point or mount on top of one: EIO, +ESTALE, or EBUSY. + +This could be useful to recover from serious conditions such as hardware +failure of mounted disks, or NFS servers which are down permanently, were +migrated, or changed their IP address. Only "type:=toplvl" mounts hung with +EBUSY are forcibly unmounted using this option, which is useful to recover +from a hung +.IR Amd ). + +.TP .BR full_os " (string, default to compiled in value)" The full name of the operating system, along with its version. Allows you to override the compiled-in full name and version of the operating system. @@ -236,7 +322,7 @@ it to ``linux-2.2.5.'' .TP .BR fully_qualified_hosts " (string, default=no)" -If "yes", +If "yes," .I Amd will perform RPC authentication using fully-qualified host names. This is necessary for some systems, and especially when performing cross-domain @@ -252,13 +338,13 @@ Specify the base name for hesiod maps. .BR karch " (string, default to karch of the system)" Same as the .B \-k -option to amd. Allows you to override the kernel-architecture of your +option to Amd. Allows you to override the kernel-architecture of your system. Useful for example on Sun (Sparc) machines, where you can build one -amd binary, and run it on multiple machines, yet you want each one to get +Amd binary, and run it on multiple machines, yet you want each one to get the correct .I karch variable set (for example, sun4c, sun4m, sun4u, etc.) Note that if not -specified, amd will use uname(2) to figure out the kernel architecture of +specified, Amd will use uname(3) to figure out the kernel architecture of the machine. .TP @@ -268,7 +354,7 @@ values such as country and organization. .TP .BR ldap_cache_maxmem " (numeric, default=131072)" -Specify the maximum memory amd should use to cache LDAP entries. +Specify the maximum memory Amd should use to cache LDAP entries. .TP .BR ldap_cache_seconds " (numeric, default=0)" @@ -279,24 +365,36 @@ Specify the number of seconds to keep entries in the cache. Specify the LDAP host and port values. .TP +.BR ldap_proto_version " (numeric, default=2)" +Specify the version of the LDAP protocol to use. + +.TP .BR local_domain " (string, default no sub-domain)" Same as the .B \-d -option to amd. Specify the local domain name. If this option is not given +option to Amd. Specify the local domain name. If this option is not given the domain name is determined from the hostname, by removing the first component of the fully-qualified host name. .TP +.BR localhost_address " (string, default to localhost or 127.0.0.1)" +Specify the name or IP address for Amd to use when connecting the sockets +for the local NFS server and the RPC server. This defaults to 127.0.0.1 or +whatever the host reports as its local address. This parameter is useful on +hosts with multiple addresses where you want to force Amd to connect to a +specific address. + +.TP .BR log_file " (string, default=/dev/stderr)" Same as the .B \-l -option to amd. Specify a file name to log amd events to. +option to Amd. Specify a file name to log Amd events to. If the string .B /dev/stderr -is specified, amd will send its events to the standard error file descriptor. +is specified, Amd will send its events to the standard error file descriptor. If the string .B syslog -is given, amd will record its events with the system logger +is given, Amd will record its events with the system logger .BR syslogd (8). The default syslog facility used is LOG_DAEMON. If you wish to change it, append its name to the log file name, delimited by a @@ -304,7 +402,7 @@ single colon. For example, if .I logfile is the string .B syslog:local7 -then amd will log messages via +then Amd will log messages via .IR syslog (3) using the LOG_LOCAL7 facility (if it exists on the system). @@ -312,11 +410,14 @@ using the LOG_LOCAL7 facility (if it exists on the system). .BR log_options " (string, default no logging options)" Same as the .B \-x -option to amd. Specify any logging options for amd. Options are comma +option to Amd. Specify any logging options for Amd. Options are comma delimited, and can be preceded by the string "no" to negate their meaning. The "debug" logging option is only available if am-utils was configured with --enable-debug. You can get the list of supported debugging and logging -options by running amd \-H. Possible values are: +options by running +.B amd +.BR \-H . +Possible values are: .nf \fBall\fR all messages @@ -332,13 +433,39 @@ options by running amd \-H. Possible values are: .fi .TP -.BR nfs_vers " (numeric, default to trying version 3 then 2)" -By default, amd tries version 3 and then version 2. This option forces the -overall NFS protocol used to version 3 or 2. It overrides what is in the -amd maps, and is useful when amd is compiled with NFSv3 support that may not -be stable. With this option you can turn off the complete usage of NFSv3 -dynamically (without having to recompile amd) until such time as NFSv3 -support is desired again. +.BR map_reload_interval " (numeric, default=3600)" +The number of seconds that Amd will wait before it checks to see if any maps +have changed at their source (NIS servers, LDAP servers, files, etc.). Amd +will reload only those maps that have changed. + +.TP +.BR nfs_allow_any_interface " (string, default=no)" +Normally Amd accepts local NFS packets only from 127.0.0.1. If this +parameter is set to "yes" then Amd will accept local NFS packets from any +local interface; this is useful on hosts that may have multiple interfaces +where the system is forced to send all outgoing packets (even those bound to +the same host) via an address other than 127.0.0.1. + +.TP +.BR nfs_allow_insecure_port " (string, default=no)" +Normally Amd will refuse requests coming from unprivileged ports (i.e. +ports >= 1024 on Unix systems), so that only privileged users and the kernel +can send NFS requests to it. However, some kernels (certain versions of +Darwin, MacOS X, and Linux) have bugs that cause them to use unprivileged +ports in certain situations, which causes Amd to stop dead in its tracks. +This parameter allows Amd to operate normally even on such systems, at the +expense of a slight decrease in the security of its operations. If you see +messages like "ignoring request from foo:1234, port not reserved" in your +Amd log, try enabling this parameter and give it another go. + +.TP +.BR nfs_proto " (string, default to trying version tcp then udp)" +By default, Amd tries TCP and then UDP. This option forces the overall NFS +protocol used to TCP or UDP. It overrides what is in the Amd maps, and is +useful when Amd is compiled with NFSv3 support that may not be stable. With +this option you can turn off the complete usage of NFSv3 dynamically +(without having to recompile Amd) until such time as NFSv3 support is +desired again. .TP .BR nfs_retransmit_counter " (numeric, default=11)" @@ -346,9 +473,27 @@ Same as the .I retransmit part of the .BI \-t " timeout.retransmit" -option to amd. +option to Amd. Specifies the number of NFS retransmissions that the kernel will use to -communicate with amd. +communicate with Amd. + +.TP +.BR nfs_retransmit_counter_udp " (numeric, default=11)" +Same as the +.B nfs_retransmit_counter +option, but for all UDP mounts only. + +.TP +.BR nfs_retransmit_counter_tcp " (numeric, default=11)" +Same as the +.B nfs_retransmit_counter +option, but for all TCP mounts only. + +.TP +.BR nfs_retransmit_counter_toplvl " (numeric, default=11)" +Same as the +.B nfs_retransmit_counter +option, but only for Amd's top-level UDP mounts. .TP .BR nfs_retry_interval " (numeric, default=8)" @@ -356,11 +501,11 @@ Same as the .I timeout part of the .BI \-t " timeout.retransmit" -option to amd. Specifies the NFS timeout interval, in +option to Amd. Specifies the NFS timeout interval, in .I tenths -of seconds, between NFS/RPC retries (for UDP only). +of seconds, between NFS/RPC retries (for UDP and TCP). This is the value that the kernel will use to -communicate with amd. +communicate with Amd. Amd relies on the kernel RPC retransmit mechanism to trigger mount retries. The values of the @@ -371,31 +516,37 @@ parameters change the overall retry interval. Too long an interval gives poor interactive response; too short an interval causes excessive retries. .TP -.BR nfs_allow_insecure_port " (string, default=no). -Normally amd will refuse requests coming from unprivileged ports (i.e. -ports >= 1024 on Unix systems), so that only privileged users and the kernel -can send NFS requests to it. However, some kernels (certain versions of -Darwin, MacOS X, and Linux) have bugs that cause them to use unprivileged -ports in certain situations, which causes amd to stop dead in its -tracks. This parameter allows amd to operate normally even on such systems, -at the expense of a slight decrease in the security of its operations. If -you see messages like "ignoring request from foo:1234, port not reserved" -in your amd log, try enabling this parameter and give it another go. +.BR nfs_retry_interval_udp " (numeric, default=8)" +Same as the +.B nfs_retry_interval +option, but for all UDP mounts only. .TP -.BR nfs_proto " (string, default to trying version tcp then udp)" -By default, amd tries TCP and then UDP. This option forces the overall NFS -protocol used to TCP or UDP. It overrides what is in the amd maps, and is -useful when amd is compiled with NFSv3 support that may not be stable. With -this option you can turn off the complete usage of NFSv3 dynamically -(without having to recompile amd) until such time as NFSv3 support is -desired again. +.BR nfs_retry_interval_tcp " (numeric, default=8)" +Same as the +.B nfs_retry_interval +option, but for all TCP mounts only. + +.TP +.BR nfs_retry_interval_toplvl " (numeric, default=8)" +Same as the +.B nfs_retry_interval +option, but only for Amd's top-level UDP mounts. + +.TP +.BR nfs_vers " (numeric, default to trying version 3 then 2)" +By default, Amd tries version 3 and then version 2. This option forces the +overall NFS protocol used to version 3 or 2. It overrides what is in the +Amd maps, and is useful when Amd is compiled with NFSv3 support that may not +be stable. With this option you can turn off the complete usage of NFSv3 +dynamically (without having to recompile Amd) until such time as NFSv3 +support is desired again. .TP .BR nis_domain " (string, default to local NIS domain name)" Same as the .B \-y -option to amd. Specify an alternative NIS domain from which to fetch the +option to Amd. Specify an alternative NIS domain from which to fetch the NIS maps. The default is the system domain name. This option is ignored if NIS support is not available. @@ -403,15 +554,24 @@ NIS support is not available. .BR normalize_hostnames " (boolean, default=no)" Same as the .B \-n -option to amd. If "yes", then the name refereed to by ${rhost} is +option to Amd. If "yes," then the name refereed to by ${rhost} is normalized relative to the host database before being used. The effect is to translate aliases into ``official'' names. .TP +.BR normalize_slashes " (boolean, default=yes)" + +If "yes," then Amd will condense all multiple ``/'' (slash) characters into +one and remove all trailing slashes. If "no," then Amd will not touch +strings that may contain repeated or trailing slashes. The latter is +sometimes useful with SMB mounts, which often require multiple slash +characters in pathnames. + +.TP .BR os " (string, default to compiled in value)" Same as the .B \-O -option to amd. Allows you to override the compiled-in name of the operating +option to Amd. Allows you to override the compiled-in name of the operating system. Useful when the built-in name is not desired for backward compatibility reasons. For example, if the build in name is ``sunos5'', you can override it to ``sos5'', and use older maps which were written with the @@ -421,7 +581,7 @@ latter in mind. .BR osver " (string, default to compiled in value)" Same as the .B \-o -option to amd. Overrides the compiled-in version number of the operating +option to Amd. Overrides the compiled-in version number of the operating system. Useful when the built in version is not desired for backward compatibility reasons. For example, if the build in version is ``2.5.1'', you can override it to ``5.5.1'', and use older maps that were written with @@ -430,8 +590,8 @@ the latter in mind. .TP .BR pid_file " (string, default=/dev/stdout)" Specify a file to store the process ID of the running daemon into. If not -specified, amd will print its process id onto the standard output. Useful -for killing amd after it had run. Note that the PID of a running amd can +specified, Amd will print its process id onto the standard output. Useful +for killing Amd after it had run. Note that the PID of a running Amd can also be retrieved via .B amq .BR \-p . @@ -441,86 +601,97 @@ This file is used only if the print_pid option is on. .BR plock " (boolean, default=yes)" Same as the .B \-S -option to amd. -If "yes", lock the running executable pages of amd into memory. To improve -amd's performance, systems that support the +option to Amd. +If "yes," lock the running executable pages of Amd into memory. To improve +Amd's performance, systems that support the .BR plock (3) -call can lock the amd process into memory. This way there is less chance it -the operating system will schedule, page out, and swap the amd process as -needed. This improves amd's performance, at the cost of reserving the -memory used by the amd process (making it unavailable for other processes). +or +.BR mlockall (2) +call can lock the Amd process into memory. This way there is less chance it +the operating system will schedule, page out, and swap the Amd process as +needed. This improves Amd's performance, at the cost of reserving the +memory used by the Amd process (making it unavailable for other processes). .TP .BR portmap_program " (numeric, default=300019)" Specify an alternate Port-mapper RPC program number, other than the official -number. This is useful when running multiple amd processes. For example, -you can run another amd in "test" mode, without affecting the primary amd +number. This is useful when running multiple Amd processes. For example, +you can run another Amd in "test" mode, without affecting the primary Amd process in any way. For safety reasons, the alternate program numbers that can be specified must be in the range 300019-300029, inclusive. -.B amq +Amq has an option .B -P -which can be used to specify an alternate program number of an amd to -contact. In this way, amq can fully control any number of amd processes +which can be used to specify an alternate program number of an Amd to +contact. In this way, amq can fully control any number of Amd processes running on the same host. .TP +.BR preferred_amq_port " (numeric, default=0)" +Specify an alternate Port-mapper RPC port number for Amd's +Amq +service. This is used for both UDP and TCP. Setting this value to 0 (or +not defining it) will cause +Amd +to select an arbitrary port number. Setting the +Amq +RPC service port to a specific number is useful in firewalled or NAT'ed +environments, where you need to know which port +Amd +will listen on. + +.TP .BR print_pid " (boolean, default=no)" Same as the .B \-p -option to amd. If "yes", amd will print its process ID upon starting. +option to Amd. If "yes," Amd will print its process ID upon starting. .TP .BR print_version " (boolean, default=no)" Same as the .B \-v -option to amd, but the version prints and amd continues to run. If "yes", -amd will print its version information string, which includes some +option to Amd, but the version prints and Amd continues to run. If "yes," +Amd will print its version information string, which includes some configuration and compilation values. .TP .BR restart_mounts " (boolean, default=no)" Same as the .B \-r -option to amd. If "yes" -.B amd +option to Amd. If "yes" +Amd will scan the mount table to determine which file systems are currently mounted. Whenever one of these would have been auto-mounted, -.B amd +Amd inherits it. .TP -.BR selectors_in_defaults " (boolean, default=no)" -If "yes", then the /defaults entry of maps will search for and process any -selectors before setting defaults for all other keys in that map. Useful -when you want to set different options for a complete map based on some -parameters. For example, you may want to better the NFS performance over -slow slip-based networks as follows: - -.nf -/defaults \\ - wire==slip-net;opts:=intr,rsize=1024,wsize=1024 \\ - wire!=slip-net;opts:=intr,rsize=8192,wsize=8192 -.fi - -Deprecated form: selectors_on_default - -.TP .BR show_statfs_entries " (boolean), default=no)" -If "yes", then all maps which are browsable will also show the number of +If "yes," then all maps which are browsable will also show the number of entries (keys) they have when "df" runs. (This is accomplished by returning non-zero values to the statfs(2) system call). .TP +.BR truncate_log " (boolean), default=no)" +If "yes," then the log file (if it is a regular file), will be truncated +upon startup. + +.TP .BR unmount_on_exit " (boolean), default=no)" -If "yes", then amd will attempt to unmount all file systems which it knows -about. Normally amd leaves all (esp. NFS) mounted file systems intact. -Note that amd does not know about file systems mounted before it starts up, +If "yes," then Amd will attempt to unmount all file systems which it knows +about. Normally Amd leaves all (esp. NFS) mounted file systems intact. +Note that Amd does not know about file systems mounted before it starts up, unless the restart_mounts option or .B \-r flag are used. .TP +.BR use_tcpwrappers " (boolean), default=yes)" +If "yes," then Amd will use the tcpd/librwap tcpwrappers library +(if available) to control +access to Amd via the /etc/hosts.allow and /etc/hosts.deny files. + +.TP .BR vendor " (string, default to compiled in value)" The name of the vendor of the operating system. Overrides the compiled-in vendor name. Useful when the compiled-in name is not desired. For example, @@ -537,15 +708,15 @@ Name of the map where the keys are located. .TP .BR tag " (string, default no tag)" Each map entry in the configuration file can be tagged. If no tag is -specified, that map section will always be processed by amd. If it is -specified, then amd will process the map if the +specified, that map section will always be processed by Amd. If it is +specified, then Amd will process the map if the .B -T -option was given to amd, and the value given to that command-line option +option was given to Amd, and the value given to that command-line option matches that in the map section. .\" ************************************************************************** .SH EXAMPLES -Here is a real amd configuration file I use daily. +Here is a real Amd configuration file I use daily. .P .nf # GLOBAL OPTIONS SECTION @@ -561,7 +732,7 @@ plock = no selectors_in_defaults = yes # config.guess picks up "sunos5" and I don't want to edit my maps yet os = sos5 -# if you print_version after setting up "os", it will show it. +# if you print_version after setting up "os," it will show it. print_version = no map_type = file search_path = /etc/amdmaps:/usr/lib/amd:/usr/local/AMD/lib @@ -591,10 +762,22 @@ map_name = amd.tftpboot .SH "SEE ALSO" .BR amd (8), .BR amq (8), -.BR ctl-amd (8). +.BR ctl-amd (8), +.BR hosts_access (5). +.LP +``am-utils'' +.BR info (1) +entry. +.LP +.I "Linux NFS and Automounter Administration" +by Erez Zadok, ISBN 0-7821-2739-8, (Sybex, 2001). +.LP +.I http://www.am-utils.org +.LP +.I "Amd \- The 4.4 BSD Automounter" .SH AUTHORS -Erez Zadok <ezk@cs.columbia.edu>, Department of Computer Science, Columbia -University, New York, USA. +Erez Zadok <ezk@cs.sunysb.edu>, Computer Science Department, Stony Brook +University, Stony Brook, New York, USA. .P Other authors and contributors to am-utils are listed in the .B AUTHORS diff --git a/contrib/amd/scripts/amd2ldif.in b/contrib/amd/scripts/amd2ldif.in index 6d3c28a9b3bf..34cee97cc1c2 100755 --- a/contrib/amd/scripts/amd2ldif.in +++ b/contrib/amd/scripts/amd2ldif.in @@ -18,10 +18,12 @@ my $mapname = $ARGV[0] or die $usage; my $base = $ARGV[1] or die $usage; $time = time(); -print "dn: cn=amdmap timestamp, $base\n"; -printf "$tfmt", "cn", "amdmap timestamp"; +print "dn: cn=amdmap $mapname timestamp, $base\n"; +printf "$tfmt", "cn", "amdmap $mapname timestamp"; printf "$tfmt", "objectClass", "amdmapTimestamp"; +printf "$tfmt", "amdmapName", "$mapname"; printf "$tfmt", "amdmapTimestamp", $time; +printf "$tfmt", "amdmapName", $mapname; print "\n"; my $line = ""; diff --git a/contrib/amd/scripts/amd2sun.in b/contrib/amd/scripts/amd2sun.in index df69b09739cd..7616c83b915c 100755 --- a/contrib/amd/scripts/amd2sun.in +++ b/contrib/amd/scripts/amd2sun.in @@ -2,7 +2,7 @@ # convert amd maps to Sun automount maps # usage: amd2sun file # -# Package: am-utils-6.0 +# Package: am-utils-6.x # Author: "Mark D. Baushke" <mdb@cisco.com> print "# file created by amd2sun diff --git a/contrib/amd/scripts/automount2amd.8 b/contrib/amd/scripts/automount2amd.8 index e4fa9bcde2fe..bd3b61230ab6 100644 --- a/contrib/amd/scripts/automount2amd.8 +++ b/contrib/amd/scripts/automount2amd.8 @@ -1,5 +1,5 @@ .\" -.\" Copyright (c) 1997-2004 Erez Zadok +.\" Copyright (c) 1997-2006 Erez Zadok .\" Copyright (c) 1990 Jan-Simon Pendry .\" Copyright (c) 1990 Imperial College of Science, Technology & Medicine .\" Copyright (c) 1990 The Regents of the University of California. @@ -38,7 +38,7 @@ .\" .\" %W% (Berkeley) %G% .\" -.\" $Id: automount2amd.8,v 1.2.2.4 2004/01/06 03:15:25 ezk Exp $ +.\" $Id: automount2amd.8,v 1.8.2.1 2006/01/02 18:48:26 ezk Exp $ .\" .TH AUTOMOUNT2AMD 8L "24 May 1993" .SH NAME @@ -100,7 +100,22 @@ moon \ does not understand newer Sun Automount map syntax, those used by autofs. .SH "SEE ALSO" .BR conv2amd (8), amd (8). +.LP +``am-utils'' +.BR info (1) +entry. +.LP +.I "Linux NFS and Automounter Administration" +by Erez Zadok, ISBN 0-7821-2739-8, (Sybex, 2001). +.LP +.I http://www.am-utils.org +.LP +.I "Amd \- The 4.4 BSD Automounter" .SH AUTHORS -Original author Mike Walker <mike@tab00.larc.nasa.gov>. Script modified by -Erez Zadok <ezk@cs.columbia.edu>, Department of Computer Science, Columbia -University, New York, USA. +Original author Mike Walker <mike@tab00.larc.nasa.gov>. +Script modified by Erez Zadok <ezk@cs.sunysb.edu>, Computer Science +Department, Stony Brook University, Stony Brook, New York, USA. +.P +Other authors and contributors to am-utils are listed in the +.B AUTHORS +file distributed with am-utils. diff --git a/contrib/amd/scripts/automount2amd.in b/contrib/amd/scripts/automount2amd.in index e99c74b8dd9a..79a7b770d556 100755 --- a/contrib/amd/scripts/automount2amd.in +++ b/contrib/amd/scripts/automount2amd.in @@ -2,7 +2,7 @@ # # Convert Sun automount map format to amd format # -# Package: am-utils-6.0 +# Package: am-utils-6.x # Author: Mike Walker <mike@tab00.larc.nasa.gov> # Erez Zadok <ezk@cs.columbia.edu> # @@ -26,7 +26,7 @@ # # You should set the DOMAIN and DEFAULT variables to your preferences. # -# $Id: automount2amd.in,v 1.1 1999/08/16 01:16:36 ezk Exp $ +# $Id: automount2amd.in,v 1.2 2002/01/15 18:25:25 ezk Exp $ # require "ctime.pl"; diff --git a/contrib/amd/scripts/ctl-amd.in b/contrib/amd/scripts/ctl-amd.in index ffd696d80144..694b31a9764c 100755 --- a/contrib/amd/scripts/ctl-amd.in +++ b/contrib/amd/scripts/ctl-amd.in @@ -2,12 +2,12 @@ # control starting, stopping, or restarting amd. # usage: ctl-amd [start|stop|status|restart|condrestart|reload] # -# Package: am-utils-6.0 +# Package: am-utils-6.x # Author: Erez Zadok <ezk@cs.columbia.edu> # # chkconfig: - 72 28 # description: Runs the automount daemon that mounts devices and NFS hosts \ -# on demand. +# on demand. # processname: amd # config: /etc/amd.conf # @@ -60,16 +60,20 @@ fi return 1 } +# before running any real programs, chdir to / to avoid possible hangs on +# (NFS) mounts which may be restarting. +cd / + # search for amd.conf file -CF_FILE="${prefix}/etc/amd.conf" +CF_FILE="@sysconfdir@/amd.conf" # any local copy of the conf file overrides the "global" one if [ -f /etc/amd.conf ] then CF_FILE="/etc/amd.conf" fi -if [ -f ${prefix}/etc/amd.conf ] +if [ -f @sysconfdir@/amd.conf ] then - CF_FILE="${prefix}/etc/amd.conf" + CF_FILE="@sysconfdir@/amd.conf" fi if [ -f /etc/local/amd.conf ] then @@ -99,7 +103,7 @@ case "$1" in echo "killing amd..." killproc " amd" wait4amd2die - test -f /var/lock/subsys/amd && rm -f /var/lock/subsys/amd + rm -f /var/lock/subsys/amd ;; 'restart') @@ -117,14 +121,14 @@ case "$1" in 'condrestart') if [ -f /var/lock/subsys/amd ]; then - ctl-amd stop - ctl-amd start - fi + ctl-amd stop + ctl-amd start + fi ;; 'reload') - amq -f - ;; + amq -f + ;; 'status') # run amq -v to produce status @@ -139,13 +143,13 @@ case "$1" in # start_msg and stop_msg are for HPUX 'start_msg') - echo "Start am-utils 6.0 automounter" + echo "Start am-utils 6.1 automounter" ;; 'stop_msg') - echo "Stop am-utils 6.0 automounter" + echo "Stop am-utils 6.1 automounter" ;; *) - echo "Usage: @sbindir@/ctl-amd [start|stop|status|restart|condrestart|reload]" + echo "Usage: $0 [start|stop|status|restart|condrestart|reload]" ;; esac diff --git a/contrib/amd/scripts/ctl-hlfsd.in b/contrib/amd/scripts/ctl-hlfsd.in index 9642e2de8558..ee0dd27ca15a 100755 --- a/contrib/amd/scripts/ctl-hlfsd.in +++ b/contrib/amd/scripts/ctl-hlfsd.in @@ -2,7 +2,7 @@ # control starting, stopping, or restarting hlfsd. # usage: ctl-hlfsd [start | stop | restart] # -# Package: am-utils-6.0 +# Package: am-utils-6.x # Author: Erez Zadok <ezk@cs.columbia.edu> # # chkconfig: - 72 28 @@ -51,6 +51,10 @@ fi return 1 } +# before running any real programs, chdir to / to avoid possible hangs on (NFS) +# mounts. +cd / + # locate logs directory if [ -d /var/log ]; then logdir="/var/log" @@ -71,8 +75,8 @@ else fi # locate any optional password file -if [ -f ${prefix}/etc/passwd ]; then - PASSWD_FILE="-P ${prefix}/etc/passwd" +if [ -f @sysconfdir@/passwd ]; then + PASSWD_FILE="-P @sysconfdir@/passwd" else PASSWD_FILE="" fi @@ -84,8 +88,8 @@ case "$1" in # if [ -x @sbindir@/hlfsd -a -h $maildir ] then - echo @sbindir@/hlfsd ${PASSWD_FILE} -a $altmaildir -x all -D fork -l $logdir/hlfsd /mail/home .mailspool - @sbindir@/hlfsd ${PASSWD_FILE} -a $altmaildir -x all -D fork -l $logdir/hlfsd /mail/home .mailspool & + echo @sbindir@/hlfsd ${PASSWD_FILE} -a $altmaildir -x all -l $logdir/hlfsd /mail/home .mailspool + @sbindir@/hlfsd ${PASSWD_FILE} -a $altmaildir -x all -l $logdir/hlfsd /mail/home .mailspool & test -x /var/lock/subsys && touch /var/lock/subsys/hlfsd fi ;; diff --git a/contrib/amd/scripts/expn.1 b/contrib/amd/scripts/expn.1 index bb90c49ab705..f316247b4a9c 100644 --- a/contrib/amd/scripts/expn.1 +++ b/contrib/amd/scripts/expn.1 @@ -16,7 +16,7 @@ $sockaddr = 'S n a4 x8'; # system requirements: # must have 'nslookup' and 'hostname' programs. -# $Header: /home/cvsroot/am-utils/scripts/expn.1,v 1.1.1.1.2.3 2004/01/06 03:15:25 ezk Exp $ +# $Header: /home/cvsroot/am-utils/scripts/expn.1,v 1.4 2003/07/18 15:17:37 ezk Exp $ # TODO: # less magic should apply to command-line addresses @@ -1318,7 +1318,6 @@ it is possible to eliminate bugs. .SH ENVIRONMENT No environment variables are used. .SH FILES -.PD 0 .B /tmp/expn$$ .B temporary file used as input to .BR nslookup . diff --git a/contrib/amd/scripts/expn.in b/contrib/amd/scripts/expn.in index 7dbee4191214..9ae575729366 100755 --- a/contrib/amd/scripts/expn.in +++ b/contrib/amd/scripts/expn.in @@ -15,7 +15,7 @@ $SOCK_STREAM = &SOCK_STREAM; # system requirements: # must have 'nslookup' and 'hostname' programs. -# $Header: /home/cvsroot/am-utils/scripts/expn.in,v 1.2.2.2 2002/07/11 14:27:02 ezk Exp $ +# $Header: /home/cvsroot/am-utils/scripts/expn.in,v 1.5 2002/07/11 14:28:20 ezk Exp $ # TODO: # less magic should apply to command-line addresses diff --git a/contrib/amd/scripts/fix-amd-map.in b/contrib/amd/scripts/fix-amd-map.in index 6746462daa77..9bbc9b6a21bc 100755 --- a/contrib/amd/scripts/fix-amd-map.in +++ b/contrib/amd/scripts/fix-amd-map.in @@ -5,7 +5,7 @@ # takes any number of files on the command line, and produces # a fixed map on stdout. # -# Package: am-utils-6.0 +# Package: am-utils-6.x # Author: Erez Zadok <ezk@cs.columbia.edu> # diff --git a/contrib/amd/scripts/fixrmtab.in b/contrib/amd/scripts/fixrmtab.in index 33b7bcfdb6ce..23003806e4c0 100755 --- a/contrib/amd/scripts/fixrmtab.in +++ b/contrib/amd/scripts/fixrmtab.in @@ -5,7 +5,7 @@ # # usage: fixrmtab host1 host2 ... # -# Package: am-utils-6.0 +# Package: am-utils-6.x # Author: Andreas Stolcke <stolcke@icsi.berkeley.edu> #set -x diff --git a/contrib/amd/scripts/redhat-ctl-amd.in b/contrib/amd/scripts/redhat-ctl-amd.in index 4143cdda2421..4d00d472c24a 100755 --- a/contrib/amd/scripts/redhat-ctl-amd.in +++ b/contrib/amd/scripts/redhat-ctl-amd.in @@ -23,7 +23,9 @@ fi RETVAL=0 prog=amd -amd=@prefix@/sbin/amd +prefix=@prefix@ +exec_prefix=@exec_prefix@ +amd=@sbindir@/amd start() { echo -n "Starting $prog: " diff --git a/contrib/amd/scripts/test-attrcache.in b/contrib/amd/scripts/test-attrcache.in new file mode 100755 index 000000000000..061308b42dbe --- /dev/null +++ b/contrib/amd/scripts/test-attrcache.in @@ -0,0 +1,135 @@ +#!/bin/sh +# Script to test the attribute cache behavior of the local OS client. +# If this script fails, it means that Amd cannot turn off the attrcache +# reliably on this host, and Amd therefore may not run reliably. See +# the README.attrcache file distributed with this am-utils. +# -Erez Zadok, September 29, 2005 + +# set PATH (must install am-utils first) +prefix=@prefix@ +exec_prefix=@exec_prefix@ +PATH=@sbindir@:@bindir@:/usr/ucb:/usr/bin:/bin:${PATH} +export PATH + +# test if amd is running +amq -p > /dev/null 2>&1 +if test $? = 0 +then + echo "### Amd already running... please shutdown Amd first" + exit 1 +fi + +mapfile="/tmp/amd.testmap.$$" +logfile="/var/log/amd" +delay=1 +a=/a + +CreateMap1 () { + echo "### Creating correct map" + cat - >$mapfile <<EOF +a type:=link;fs:=/tmp/a +EOF +} + +CreateMap2 () { + echo "### Creating weird map" + cat - >$mapfile <<EOF +a type:=link;fs:=/tmp/b +EOF +} + +StopAMD () { + ctl-amd stop +# do not delete files we may need to use to debug Amd +# rm -f /tmp/a /tmp/b $mapfile $logfile +} + +touch /tmp/a +touch /tmp/b + +CreateMap1 +echo amd -x all -D all -r -l $logfile $a $mapfile -cache:=mapdefault,sync +amd -x all -D all -r -l $logfile $a $mapfile -cache:=mapdefault,sync +sleep 3 # give amd chance to start properly +amq +inode_a=`ls -lLi /tmp/a | awk '{print $1}'` +inode_b=`ls -lLi /tmp/b | awk '{print $1}'` +ls -lLi $a/a +ls -lLi $a/b +ls -l $mapfile + +# how many times to try until we call it a success... +maxtry=10 +while test $maxtry -gt 0 +do + echo "$maxtry tries left ..." + let maxtry=maxtry-1 + amq + CreateMap1 + sleep $delay + + ls -l $mapfile + echo "### looking at a... should get a" + ino=`ls -lLi $a/a | awk '{print $1}'` + if test -z "$ino" + then + ls -li $a/a + amq + amq -m + stat $a + echo "a link does not exist!" + StopAMD + exit 1 + fi + if test $ino -ne $inode_a + then + ls -li $a/a + amq + amq -m + stat $a + echo "a link does not point to A!" + StopAMD + exit 1 + fi + +# Here is the main trick we try: force amd to flush one entry, then +# change the amd map on disk, and then see if the kernel will have +# flushed the attribute cache; if it did, then Amd will see the +# correctly changed map entry. + + amq -u $a/a + sleep $delay + stat $a + + CreateMap2 + sleep $delay + + ls -l $mapfile + echo "### looking at a... should get b" + ino=`ls -lLi $a/a | awk '{print $1}'` + if test -z "$ino" + then + ls -li $a/a + amq + amq -m + stat $a + echo "a link does not exist!" + StopAMD + exit 1 + fi + if test $ino -ne $inode_b + then + ls -li $a/a + amq + amq -m + stat $a + echo "a link does not point to B!" + StopAMD + exit 1 + fi + + amq -u $a/a + sleep $delay + stat $a +done +StopAMD diff --git a/contrib/amd/scripts/wait4amd.in b/contrib/amd/scripts/wait4amd.in index 5fd503075672..5e6c33a579c4 100755 --- a/contrib/amd/scripts/wait4amd.in +++ b/contrib/amd/scripts/wait4amd.in @@ -3,7 +3,7 @@ # usage: wait4amd <hostname> [<command> [args ...]] # If only hostname is supplied, command defaults to rsh $hostname # -# Package: am-utils-6.0 +# Package: am-utils-6.x # Author: Erez Zadok <ezk@cs.columbia.edu> #set -x diff --git a/contrib/amd/scripts/wait4amd2die.in b/contrib/amd/scripts/wait4amd2die.in index d3541e78672c..94a08513f889 100755 --- a/contrib/amd/scripts/wait4amd2die.in +++ b/contrib/amd/scripts/wait4amd2die.in @@ -4,7 +4,7 @@ # If not specified, delay=5 seconds and count=6 (total 30 seconds) # If at end of total delay amd is till up, return 1; else return 0. # -# Package: am-utils-6.0 +# Package: am-utils-6.x # Author: Erez Zadok <ezk@cs.columbia.edu> #set -x @@ -20,14 +20,14 @@ if test -n "$1" then delay=$1 else - delay=5 + delay=3 fi # how many times to delay if test -n "$2" then count=$2 else - count=6 + count=10 fi i=1 diff --git a/contrib/amd/tasks b/contrib/amd/tasks index 3fc767d11679..24b6834cba6a 100644 --- a/contrib/amd/tasks +++ b/contrib/amd/tasks @@ -1,59 +1,37 @@ - AM-UTILS-6.0 TASKS TODO + AM-UTILS-6.1 TASKS TODO Please volunteer to do any of the following: -- complete testing of untested platforms in INSTALL file - ncr2 - sunos 3.5 - -- autofs support: see README.autofs for details. [done in 6.1] +- autofs support: see README.autofs for details. - deal with everything that has XXX on it in the sources - documentation update ("XXX: FILL IN" sections). -- hlfsd should be able to not use /var/alt_mail, but send code 75 back to - sendmail (telling it to re-queue the mail and retry later). - - compatibility with Sun's automount maps? should be easier via the amd.conf file to specify type of map - perhaps done at the same time autofs support is done. - convert to using my own rpcgen .x files for amq/amq/nfs (v2 and v3) -- support multiple "fail-over read-only" NFS mounts in Solaris 2.6+. - - use packaging info for various OSs (such as RPM, Redhat Package Manager) - $mindelay and $maxdelay in milliseconds - multiple nfsl should be matched if one matched and nfs mount failed. fall through. -- fall through syntax? opts:=nofail,fallthrough? +- support multiple "fail-over read-only" NFS mounts in Solaris 2.6+. - random nfs rhost:={srv1, srv2, srv3} - nfslx, same as nfsl, but using linkx -- find out why this sometimes works and sometimes not: - mcl -rhost:=minetta host!=${rhost};type:=nfs host==${rhost} - - loadable info_*, amfs_*, and ops_* modules (lazy evaluation). -- hlfsd for ~root/.mailspool (getpwnam("root")) - hlfsd should daemonize even if -DDEBUG, then use -D nofork - fixmount should use generic code from transp/transp_{tli,sockets}.c -- report netbsd/openbsd bugs in BUGS file - - reverse notion of -F and other cmd-line options, so they override the -amd.conf file (right now amd.conf overrides cmd-line options). - -- y2k compliance. - -- an un/install script for binaries - -- update README + amd.conf file (right now amd.conf overrides cmd-line options). - add am-utils URL and COPYRIGHT to all distributed scripts and sources and programs etc. also to amq -v output. @@ -61,31 +39,13 @@ amd.conf file (right now amd.conf overrides cmd-line options). - ion: browsable_dirs only works for nis if in [global] broken if it is file maps. -- all if statements should have an else clause because of Ultrix's /bin/sh. - -- look for obsolete AM_* macros and use newer AC_* ones -- use 3rd arg to AC_CHECK_TYPE (headers) - -- FreeBSD 3.1 doesn't have SYMTTL flag, so the mtime of the hlfsd symlink is - always new. This breaks hlfsd on FreeBSD 3.1, b/c the acregmin/max code - depends on the time that the symlink was created. Solution: best is to - support NOAC in the FreeBSD kernel, otherwise hlfsd will have to know not - to turn on this code in hlfsd/stubs.c: - - if (++slinkfattr.na_mtime.nt_useconds == 0) - ++slinkfattr.na_mtime.nt_seconds; - -- support nqnfs as per Jeffrey C Honig <jch@BSDI.COM>: "Besides having - NFSMNT_NQNFS set when you try to do the mount, NQNFS requires that you do - the nfssvc() call to create an nqnfs client daemon. I can't see any - obvious way to check if the server supports NQNFS." - - browsable 'auto' style maps. - mention signals in amd man page - ALLOWED_MOUNT_TIME of 40 seconds is way too long! -- need option to turn off pings of portmapper before trying a mount +- detecting down'ed hosts faster: use default portmap TTL variables? +- push get_nfs_version() down into a child process - type:=program should not require umount command. can use default umount(). it works for smbmount/umount. @@ -97,30 +57,55 @@ amd.conf file (right now amd.conf overrides cmd-line options). - support port=n, for machines that use NFS on a different port -- support WebNFS (cf. Solaris mount_nfs(1M) -o public) - - nfsl may be buggy when fs:= is specified explicitly (lockup?) -- detecting down'ed hosts faster: use default portmap TTL variables? - -- entries w/ $key in /defaults, see "defaults" instead of the actual - entry. [fixed in 6.1] - - y2k: amq /home (mounted time uses YY instead of YYYY) - new amd.conf option to disable amq listener altogether (security) + Should be available even if DEBUG is off. - new amd.conf option dynamic_system_params to recompute osver, karch, etc. from uname() dynamically. -- change uid (gid?) of hlfsd symlink each time, to circumvent symlink cache - on openbsd. - - solaris 8 doesn't pick up hsfs/pcfs/etc *_args structures and mount flags -- support opts:=loop for linux loopback mounts +- avoid having to compile ops_nfs3.o -- map reloading interval timer (do_mapc_reload = clocktime() + ONE_HOUR); - right now it's fixed to 3600 seconds. +- linux support for ext3 -- avoid having to compile ops_nfs3.o +- be able to pass generic mount options to systems w/ a mount(2) that + supports it (Linux). Perhaps genopt="foo,bar" syntax. + +- support several different nfs servers inside one nfsx entry + +- reimplement the "parallel mounting" for multiple matching sub-entries + +- fix amd.conf parser so it can parse key=value without spaces around the + "=" sign. Note this isn't so trivial because 'value' may include "=" + signs. + +- NFSv4 support (such a short "tasks" entry given how much work it is :-) + + +* documentation +- document what can and what can't be a top-level mount type (i.e. a + map-backed or map-holding type). Currently that's toplvl, auto, and + direct. +- document how to add a direct map to amd.conf. + +* autofs stuff +Linux: +- host mounts broken with autofs v3 +- nfsx status unknown +- local filesystems (ufs, etc) status unknown + +Solaris: +- host mounts status unknown +- nfsx status unknown +- local filesystems (ufs, etc) status unknown + +FreeBSD: +- just do it + +All: +- mntfs->mf_fo->opt_fs can contain garbage sometimes?? diff --git a/contrib/amd/vers.m4 b/contrib/amd/vers.m4 new file mode 100644 index 000000000000..7343910d5f2d --- /dev/null +++ b/contrib/amd/vers.m4 @@ -0,0 +1 @@ +[6.1.5]dnl diff --git a/contrib/amd/wire-test/wire-test.8 b/contrib/amd/wire-test/wire-test.8 index 0d2efe79eb30..539a849ae451 100644 --- a/contrib/amd/wire-test/wire-test.8 +++ b/contrib/amd/wire-test/wire-test.8 @@ -1,5 +1,5 @@ .\" -.\" Copyright (c) 1997-2004 Erez Zadok +.\" Copyright (c) 1997-2006 Erez Zadok .\" Copyright (c) 1990 Jan-Simon Pendry .\" Copyright (c) 1990 Imperial College of Science, Technology & Medicine .\" Copyright (c) 1990 The Regents of the University of California. @@ -38,7 +38,7 @@ .\" .\" %W% (Berkeley) %G% .\" -.\" $Id: wire-test.8,v 1.3.2.5 2004/01/06 03:15:25 ezk Exp $ +.\" $Id: wire-test.8,v 1.10.2.1 2006/01/02 18:48:26 ezk Exp $ .\" .TH WIRE-TEST 8 "26 Feb 1993" .SH NAME @@ -68,3 +68,21 @@ defaults to "localhost". .SH "SEE ALSO" .BR amd (8). +.LP +``am-utils'' +.BR info (1) +entry. +.LP +.I "Linux NFS and Automounter Administration" +by Erez Zadok, ISBN 0-7821-2739-8, (Sybex, 2001). +.LP +.I http://www.am-utils.org +.LP +.I "Amd \- The 4.4 BSD Automounter" +.SH AUTHORS +Erez Zadok <ezk@cs.sunysb.edu>, Computer Science Department, Stony Brook +University, Stony Brook, New York, USA. +.P +Other authors and contributors to am-utils are listed in the +.B AUTHORS +file distributed with am-utils. diff --git a/contrib/amd/wire-test/wire-test.c b/contrib/amd/wire-test/wire-test.c index f0a266309f63..bcaaf5a31519 100644 --- a/contrib/amd/wire-test/wire-test.c +++ b/contrib/amd/wire-test/wire-test.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997-2004 Erez Zadok + * Copyright (c) 1997-2006 Erez Zadok * Copyright (c) 1990 Jan-Simon Pendry * Copyright (c) 1990 Imperial College of Science, Technology & Medicine * Copyright (c) 1990 The Regents of the University of California. @@ -36,9 +36,8 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * %W% (Berkeley) %G% * - * $Id: wire-test.c,v 1.5.2.4 2004/01/06 03:15:25 ezk Exp $ + * File: am-utils/wire-test/wire-test.c * */ @@ -79,7 +78,7 @@ main(int argc, char **argv) } /* also print my IP address */ - amu_get_myaddress(&myipaddr); + amu_get_myaddress(&myipaddr, NULL); fprintf(stderr, "My IP address is 0x%x.\n", (unsigned int) htonl(myipaddr.s_addr)); /* @@ -98,6 +97,7 @@ main(int argc, char **argv) } ip = (struct sockaddr_in *) xmalloc(sizeof(struct sockaddr_in)); memset((voidp) ip, 0, sizeof(*ip)); + /* as per POSIX, sin_len need not be set (used internally by kernel) */ ip->sin_family = AF_INET; memmove((voidp) &ip->sin_addr, (voidp) hp->h_addr, sizeof(ip->sin_addr)); ip->sin_port = htons(NFS_PORT); |