aboutsummaryrefslogtreecommitdiff
path: root/usr.bin/ar/write.c
Commit message (Collapse)AuthorAgeFilesLines
* ar(1): Fix grammar error in write.cLO WEN-CHIEN2024-02-131-1/+1
| | | | | Event: Advanced UNIX Programming Course (Fall’23) at NTHU Pull Request: https://github.com/freebsd/freebsd-src/pull/1013
* Remove $FreeBSD$: one-line .c patternWarner Losh2023-08-161-2/+0
| | | | Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/
* spdx: The BSD-2-Clause-FreeBSD identifier is obsolete, drop -FreeBSDWarner Losh2023-05-121-1/+1
| | | | | | | | | The SPDX folks have obsoleted the BSD-2-Clause-FreeBSD identifier. Catch up to that fact and revert to their recommended match of BSD-2-Clause. Discussed with: pfg MFC After: 3 days Sponsored by: Netflix
* ar: diff reduction against ELF Tool ChainEd Maste2021-08-131-45/+6
| | | | | | | | | | | | | Remove ar_mode_* wrappers and call ar_read_archive / ar_write_archive directly. (This was originally committed in d20e9e02db3d but reverted due to a regression, now fixed with an update from cy@.) Obtained from: ELF Tool Chain Reviewed by: markj Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D31496
* ar: diff reduction against ELF Tool ChainEd Maste2021-08-131-34/+28
| | | | | | | | | | Drop exit status from bsdar_errc. ELF Tool Chain always returns EXIT_FAILURE in bsdar_errc. Recommit of one part of d20e9e02db3d / review D31496. Obtained from: ELF Tool Chain Sponsored by: The FreeBSD Foundation
* Revert "ar: diff reduction against ELF Tool Chain"Ed Maste2021-08-121-33/+78
| | | | | | | This reverts commit d20e9e02db3dde383c3de1ce8cec3a8c35b3eee6. It caused port build failures. Reported by: cy
* ar: diff reduction against ELF Tool ChainEd Maste2021-08-111-78/+33
| | | | | | | | | | | | | - Drop exit status from bsdar_errc. ELF Tool Chain always returns EXIT_FAILURE in bsdar_errc. - Remove ar_mode_* wrappers and call ar_read_archive / ar_write_archive directly. Obtained from: ELF Tool Chain Reviewed by: markj Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D31496
* ar: remove invalid extra param in bsdar_warnc callsEd Maste2021-08-111-6/+6
| | | | | | | | A number of warnings passed an exit status code to bsdar_warnc, but it does not take exit status (as a warning, it does not exit). MFC after: 1 week Sponsored by: The FreeBSD Foundation
* ar: provide error exit status upon failureEd Maste2021-08-101-20/+29
| | | | | | | | | | | | | | | Previously ar and ranlib returned with exit status 0 (success) in the case of a missing file or other error. Update to use error handling similar to that added by ELF Tool Chain after that project forked FreeBSD's ar. PR: PR257599 [exp-run] Reported by: Shawn Webb, gehmehgeh (on HardenedBSD IRC) Reviewed by: markj Obtained from: elftoolchain MFC after: 2 months Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D31402
* Fix some common typos in commentsGordon Bergling2021-03-131-2/+2
| | | | | | | | | | | - occured -> occurred - normaly -> normally - controling -> controlling - fileds -> fields - insterted -> inserted - outputing -> outputting MFC after: 1 week
* ar: use more correct size_t type for loop indexEd Maste2019-09-011-3/+3
| | | | | | | | Submitted by: cem MFC after: 1 week Notes: svn path=/head/; revision=351663
* ar: shuffle symbol offsets during conversion for 32-bit ar archivesEd Maste2019-04-221-19/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | During processing we maintain symbol offsets in the 64-bit s_so array, and when writing the archive convert to 32-bit if no offsets are greater than 4GB. However, this was somewhat inefficient as we looped over the array twice: first, converting to big endian and second, writing each 32-bit value one at a time (and incorrectly so on big-endian platforms). Instead, when writing a 32-bit archive shuffle convert symbol data to big endian (as required by the ar format) and shuffle to the beginning of the allocation at the same time. Also correct emission of the symbol count on big endian platforms. Further changes are planned, but this should fix powerpc64. Reported by: jhibbits, mlinimon Reviewed by: jhibbits, Gerald Aryeetey (earlier) Tested by: jhibbits MFC after: 10 days MFC with: r346079 Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D20007 Notes: svn path=/head/; revision=346582
* ar: use array notation to access s_soEd Maste2019-04-221-4/+4
| | | | | | | | | | | This is somewhat more readable than pointer arithmetic. Also remove an unnecessary cast while here. MFC after: 1 week Sponsored by: The FreeBSD Foundation Notes: svn path=/head/; revision=346569
* ar: test for writing 64-bit format only if symbol count is nonzeroEd Maste2019-04-221-3/+0
| | | | | | | | | | | This is a minor simplification; if we do not have any symbols the empty symbol table can be in 32-bit format. MFC after: 1 week Sponsored by: The FreeBSD Foundation Notes: svn path=/head/; revision=346568
* ar: implement support for /SYM64/ 64-bit archivesEd Maste2019-04-101-18/+45
| | | | | | | | | | | | PR: 234454 Submitted by: Gerald Aryeetey <aryeeteygerald_rogers.com> Reviewed by: imp (earlier) MFC after: 3 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D18793 Notes: svn path=/head/; revision=346079
* ar: detect and error out on 32-bit symbol table overflowEd Maste2018-12-281-0/+3
| | | | | | | | | | | | | | | | | BSD ar currently does not support the /SYM64/ 64-bit symbol table, and previously truncated to 32-bits, silently producing corrupted archives larger than 4GB. This is another overflow case in addtion to r342575. PR: 234454 Reported by: Aijaz Baig, imp MFC after: 2 weeks MFC with: r342575 Sponsored by: The FreeBSD Foundation Notes: svn path=/head/; revision=342580
* ar: detect and error out on 32-bit symbol table overflowEd Maste2018-12-281-1/+5
| | | | | | | | | | | | | | | | BSD ar currently does not support the /SYM64/ 64-bit symbol table, and previously truncated to 32-bits, silently producing corrupted archives larger than 4GB. Note that this is only a partial fix; additional checks will come. PR: 234454 Reported by: Aijaz Baig, imp MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Notes: svn path=/head/; revision=342575
* ar: report errno on warning/errorEd Maste2018-10-231-4/+5
| | | | | | | | | | | | | | Previously ar would report an error like "ar: fatal: Write error" without including additional errno information. Change warnings and errors to include archive_errno() so that the user may have some idea of the reason for the failure. Reviewed by: brooks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D17650 Notes: svn path=/head/; revision=339648
* usr.bin/ar: use standard 2-Clause FreeBSD licenseEd Maste2018-06-191-12/+12
| | | | | | | | | | | | | Many licenses on ar files contained small variations from the standard FreeBSD license text. To avoid license proliferation switch to the usual standard 2-clause FreeBSD license for those files where I have obtained permission from all of the listed copyright holders. Approved by: jkoshy, kaiw Differential Revision: https://reviews.freebsd.org/D14561 Notes: svn path=/head/; revision=335376
* various: general adoption of SPDX licensing ID tags.Pedro F. Giffuni2017-11-271-0/+2
| | | | | | | | | | | | | | | | | Mainly focus on files that use BSD 2-Clause license, however the tool I was using misidentified many licenses so this was mostly a manual - error prone - task. The Software Package Data Exchange (SPDX) group provides a specification to make it easier for automated tools to detect and summarize well known opensource licenses. We are gradually adopting the specification, noting that the tags are considered only advisory and do not, in any way, superceed or replace the license texts. No functional change intended. Notes: svn path=/head/; revision=326276
* ar: handle partial writes from archive_write_dataEd Maste2017-07-241-3/+10
| | | | | | | | | | | | | libarchive may limit a single archive_write_data call to handling 0x7fffffff bytes. Add a loop to handle partial writes. Reviewed by: kib, jhb MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D11715 Notes: svn path=/head/; revision=321436
* Make code compile when basename() is POSIX compliant.Ed Schouten2016-05-261-1/+6
| | | | | | | | | | | | | In addition to the previous change I made to ar.c, pull in another basename() related fix. This change is similar to the one made to the ELF Toolchain version of ar, with the difference that the ELF Toolchain version lacks error handling for the strdup() call. Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D6467 Notes: svn path=/head/; revision=300741
* Check archive_entry_new() result.Bryan Drewery2015-10-291-0/+9
| | | | | | | Coverity CID: 1331341 Notes: svn path=/head/; revision=290157
* speed up ar(1) on UFS file systemsEd Maste2015-06-291-0/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fault in the buffer prior to writing to workaround poor performance due to interaction with kernel fs deadlock avoidance code. See the comment prior to vn_io_fault_doio() in sys/kern/vfs_vnops.c for details of the issue. On my stable/10 desktop with a 16MB obj.o and "ar r out.a obj.o" I see the following run times (seconds): x ar.r284891 + ar.patched +----------------------------------------------------------------------+ |+ | |+ x| |+ xx| |A |A| +----------------------------------------------------------------------+ N Min Max Median Avg Stddev x 3 1.307 1.321 1.315 1.3143333 0.0070237692 + 3 0.020 0.023 0.022 0.021666667 0.0015275252 Difference at 95.0% confidence -1.29267 +/- 0.0115203 -98.3515% +/- 0.876513% (Student's t, pooled s = 0.00508265) Thanks to kib for diagnosing and explaining the issue and suggesting the workaround. Reviewed by: eadler, kib MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D2933 Notes: svn path=/head/; revision=284928
* Replace deprecated (or remove obsolete) libarchive 2.8 functionsMartin Matuska2013-03-221-4/+2
| | | | | | | with libarchive 3.0 counterparts Notes: svn path=/head/; revision=248612
* Don't try to free() an address returned by mmap(). This appears to beEd Maste2011-08-041-13/+20
| | | | | | | | | | | | triggered by the same .o being included twice on the command line. Found by: Nima Misaghian at Sandvine Reviewed by: kientzle, kaiw Approved by: re MFC after: 1 week Notes: svn path=/head/; revision=224650
* Correct typos in comments, no functional changes.Benedict Reuschling2011-05-201-5/+5
| | | | | | | | | Found by: codespell Reviewed by: kaiw MFC after: 1 week Notes: svn path=/head/; revision=222122
* Add -D (deterministic) option to ar.Tim Kientzle2010-10-091-5/+19
| | | | | | | | | | | | When set, it forces all timestamps and owners to zero and modes to 0644. Useful for producing libraries that are bitwise identical across multiple build runs. Submitted by: Erik Cederstrand Reviewed by: Kai Wang Notes: svn path=/head/; revision=213643
* Removed ar(1)'s support for compressed archives. This change removesKai Wang2010-05-171-28/+2
| | | | | | | | | | | | | | | | | ar(1)'s dependencies on compressor libraries -lz, -lbz2 and -llzma and fixes building HEAD on some versions of FreeBSD[78]. Option -j and -z is now accepted but ignored. Compressed ar(1) archives are not useful without a ld(1) that can read them. Also, the current ar(1) compression scheme prevents random access of archive members and needs to be redesigned anyway. Submitted by: kientzle (original patch) Reviewed by: delphij Discussed on: -current mailing list Notes: svn path=/head/; revision=208189
* Add support for option "-M", which is used to operate ar(1) in aKai Wang2008-09-201-41/+107
| | | | | | | | | | | | | | | | | | script mode like the MRI(Microtec Research Inc.) "librarian" program. Originally this option is provided by Binutils ar(1) to ease the transition for developers who are used to writing "librarian" scripts. We added this option to BSD ar(1) because: 1. Further improve the compatibility with Binutils ar(1). 2. There are still a few software using this -M option. (at least one in our ports collection) Suggested by: rink & erwin Notes: svn path=/head/; revision=183218
* GNU ar did NOT implment option -q as a synonym of -r as the manualKai Wang2008-03-111-3/+20
| | | | | | | | | | | | | | | | | | | | page stated, thus BSD ar(1) option -q, which was implemented based on the GNU ar manual page, turns out to be incompatible with GNU ar -q. This change will make BSD ar(1) -q a *REAL* GNU ar -q: 1. It will update symbol table. (same as unfixed version) 2. It will NOT compare new members spcified in the command line args with existing members, instead, append them directly. Reported by: Johannes 5 Joemann <joemann@beefree.free.de> Reported by: Timothy Bourke <timbob@bigpond.com> Tested by: Johannes 5 Joemann <joemann@beefree.free.de> Reviewed by: jkoshy Approved by: jkoshy (mentor) Notes: svn path=/head/; revision=177064
* - Do not malloc buffer for 0-size member when reading from archive.Kai Wang2008-03-021-11/+17
| | | | | | | | | | | | | | | | - Fix a malloc buffer overrun: Use a while loop to check whether the string buffer is big enough after resizing, since doubling once might not be enough when a very long member name or symbol name is provided. - Fix typo. Reported by: Michael Plass <mfp49_freebsd@plass-family.net> Tested by: Michael Plass <mfp49_freebsd@plass-family.net> Reviewed by: jkoshy Approved by: jkoshy Notes: svn path=/head/; revision=176728
* style(9) whitespace fix: A space is mandated after keyword 'return'.Kai Wang2008-02-241-5/+5
| | | | | | | | Submitted by: jkoshy Approved by: jkoshy (mentor) Notes: svn path=/head/; revision=176528
* Handle properly when insert zero size objects into the archive:Kai Wang2008-02-241-3/+9
| | | | | | | | | | | | | | | | | | | Do not mmap 0-size objects and do not try to extract symbol from 0-size objects, but do treat 0-size objects as qualified objects and accept them as an archive member. (A member with only the header part) Note that GNU binutils ar on FreeBSD ignores 0-size objects, but on Linux it accepts them. [1] But, since this is a rare usage, we can safely ignore the compatibility issue. Reported by: Michael Plass <mfp49_freebsd [AT] plass-family [DOT] net> Pointed out by: Michael Plass <mfp49_freebsd [AT] plass-family [DOT] net> [1] Reviewed by: Michael Plass <mfp49_freebsd [AT] plass-family [DOT] net> Reviewed by: jkoshy Approved by: jkoshy (mentor) Notes: svn path=/head/; revision=176525
* Import ar(1) front-end. (aka 'BSD' ar)Kai Wang2008-02-211-0/+784
Reviewed by: jkoshy Approved by: jkoshy (mentor) Tested by: erwin (ports build test on pointyhat) Sponsored by: Google Summer of Code 2007 Reviewed by (earlier version): Jaakko Heinonen <jh[AT]saunalahti.fi> Tested by (earlier version): Steve Kargl <sgk[AT]troutmask.apl.washington.edu> Tested by (earlier version): Martin Voros <martin_voros[AT]yahoo.com> Tested by (earlier version): swell.k[AT]gmail.com Tested by (earlier version): joel Tested by (earlier version): Alexey Shuvaev <shuvaev[AT]physik.uni-wuerzburg.de> Tested by (earlier version): Arjan van Leeuwen <avleeuwen[AT]gmail.com> Thanks to gabor@ for building ports for it. Thanks to erwin@ and kris@ for scheduling the ports build test on pointyhat. And thanks to many others for their feedback. Notes: svn path=/head/; revision=176434
generated by cgit v1.3 (git 2.53.0) at 2026-10-24 00:17:23 +0000