| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
| |
Switch up comparator mapping to avoid these kinds of errors, use a
simple array of (name, comparator) pairs rather than having to maintain
entries in two separate arrays that must have matching indices.
Reviewed by: obiwac
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D37083
|
| |
|
|
|
|
|
|
|
| |
The default delay between screen updates was incorrectly transfered
from roff(7) register that was used in previous version of man page.
Reviewed by: ziaee
Fixes: 9d6cce02a78c (initial pass to freebsdize)
Differential Revision: https://reviews.freebsd.org/D51503
|
| |
|
|
|
|
|
| |
MFC after: 3 days
Fixes: 32efd26355e2 (Add a THR column)
Reviewed by: bcr
Differential Revision: https://reviews.freebsd.org/D50754
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Change the origin from PZERO to PUSER.
Doing so allows users to immediately detect if some thread is running
under a high priority (kernel or realtime) or under a low one
(timesharing or idle).
MFC after: 1 month
Event: Kitchener-Waterloo Hackathon 202506
Sponsored by: The FreeBSD Foundation
|
| |
|
|
|
|
|
| |
Some of ARC statistic sysctls changed years ago, but those tools
are still using legacy shims, that are going to be removed.
MFC after: 3 days
|
| |
|
|
|
|
|
|
|
| |
top was added in 511d9c656578 for FreeBSD 2.2.2.
MFC after: 3 days
Reviewed by: carlavilla, imp, joerg
Approved by: carlavilla (mentor)
Differential Revision: https://reviews.freebsd.org/D49591
|
| |
|
|
|
|
|
| |
MFC after: 3 days
Reviewed by: carlavilla, imp
Approved by: carlavilla (mentor)
Differential Revision: https://reviews.freebsd.org/D49631
|
| |
|
|
|
|
|
|
|
|
| |
Switching between io and cpu sorting uses a great example in the usage.
[-m io | cpu]. Use that everywhere.
MFC after: 3 days
Reviewed by: mhorne
Approved by: mhorne (mentor)
Differential Revision: https://reviews.freebsd.org/D49515
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Organize key bindings by ascii(7) for consistency and maintainability,
mark them as Interactive Commands, wordsmith them, and sync their
organization between the manual and help screen.
MFC after: 3 days
PR: 282734
Fixes: c8aa5e526 (move command mapping to commands.c)
Reviewed by: imp, mhorne, Jim Brown <jpb@jimby.name>
Approved by: mhorne (mentor)
Differential Revision: https://reviews.freebsd.org/D49462
|
| |
|
|
|
|
|
|
|
|
|
|
| |
If the `setlocale()` call fails, emit a warning and sleep briefly so the
user has a chance to see the warning before we redraw the screen. Note
that we have no way of knowing exactly what is wrong, but at least we
can suggest that they check their environment.
MFC after: 1 week
Sponsored by: Klara, Inc.
Reviewed by: kevans
Differential Revision: https://reviews.freebsd.org/D49230
|
| |
|
|
|
|
|
| |
This is a residual of the $FreeBSD$ removal.
MFC After: 3 days (though I'll just run the command on the branches)
Sponsored by: Netflix
|
| |
|
|
|
|
|
|
|
|
| |
After top registers load average of at least 100 which then gets reduced to
below 100, there are left stray digits.
Supporting load over 100 requires increasing the width only to 6, but since
we support over 1000 CPU's now, let's increase it to 7.
Reviewed by: kib
Differential Revision: https://reviews.freebsd.org/D45284
|
| |
|
|
|
| |
PR: 275994
MFC after: 2 weeks
|
| |
|
|
| |
Remove /^\.\\"\s*\$FreeBSD\$$\n/
|
| |
|
|
| |
Remove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/
|
| |
|
|
| |
Remove /^/[*/]\s*\$FreeBSD\$.*\n/
|
| |
|
|
| |
Remove /^\s*\*+\s*\$FreeBSD\$.*$\n/
|
| |
|
|
| |
Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/
|
| |
|
|
|
|
|
|
|
| |
due to bad rebase.
Noted by: kevans
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Fixes: 6a5e6a50bd55c3fb4933abe1edaad3a928700c42ESC
|
| |
|
|
|
|
|
|
|
|
| |
Put it near/after the sleep state.
Noted by: Mark Millard <marklmi@yahoo.com>
Reviewed by: kevans
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D40607
|
| |
|
|
|
|
|
|
| |
Noted by: Mark Millard <marklmi@yahoo.com>
Reviewed by: kevans
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D40607
|
| |
|
|
|
|
|
|
|
|
|
| |
Also correct comments for individual state, duplicating the S* constants
descriptions from sys/proc.h [*].
Reviewed by: kevans (previous version)
Noted by: Mark Millard <marklmi@yahoo.com> [*]
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D40607
|
| |
|
|
|
|
|
| |
Reviewed by: kevans
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D40607
|
| |
|
|
|
|
|
| |
The code attempts to detect holes in the CPU ID space, but previously
this would only work for up to sizeof(long)*8 CPUs.
MFC after: 2 weeks
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
The 'pid' order was added, but the equivalent comparator was not back in
8b800d3af2d8c ("Add the PID column to the list of sort keys.").
`ordernames` indices need to match `compares` indices in order for this
to work.
A future commit will restructure all of this to make it less error prone
going forward (see D37083).
MFC after: 3 days
Reviewed by: pstef (D37083)
|
| |
|
|
|
|
| |
- s/accomodate/accommodate/
MFC after: 3 days
|
| |
|
|
| |
MFC after: 3 days
|
| |
|
|
|
|
| |
Describe -m argument as "mode" instead of "display".
MFC after: 3 days
|
| |
|
|
|
|
| |
While here, fix the indentation of the second line in the message.
MFC after: 3 days
|
| |
|
|
|
|
| |
While here, add a short sentence introducing the options.
MFC after: 3 days
|
| |
|
|
|
|
|
|
|
| |
B is listed as an interactive command to toggle the display of threads.
This is a typo introduced during the conversion of the manual page to
mdoc.
Fixes: 9d6cce02a78c967e69b603d503545c4b43d7765f
MFC after: 3 days
|
| |
|
|
| |
Differential Revision: https://reviews.freebsd.org/D32098
|
| |
|
|
|
|
|
|
| |
This fixes a -Wnested-extern error with GCC 9. There is an existing
extern declaration in top.h.
Reviewed by: imp, emaste
Differential Revision: https://reviews.freebsd.org/D31937
|
| |
|
|
|
| |
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/536/files
|
| |
|
|
|
|
| |
Obtained from: OpenBSD
Reviewed by: imp@
Pull Request: https://github.com/freebsd/freebsd-src/pull/479
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Unset VIS_SAFE flag as it turned out to be actually unsafe
for continuos top display as it's passing through sequences
resulting cursor movement (backspace, tab, carriage-return),
and explicitly set VIS_TAB for the same reason.
Reported by: Mark Millard <marklmi@yahoo.com>, swills
Tested by: Mark Millard <marklmi@yahoo.com>, swills
Notes:
svn path=/head/; revision=363207
|
| |
|
|
|
|
|
|
|
|
| |
The sysctl was removed by r76078 in 2001.
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Notes:
svn path=/head/; revision=362711
|
| |
|
|
|
|
|
|
|
| |
PR: 244153
Reported by: 0mp
MFC with: r359594
Notes:
svn path=/head/; revision=359597
|
| |
|
|
|
|
|
|
|
| |
PR: 244153
Submitted by: fehmi noyan isi <fnoyanisi@yahoo.com>
MFC after: 3 days
Notes:
svn path=/head/; revision=359594
|
| |
|
|
|
|
|
|
|
| |
Submitted by: Antranig Vartanian <antranigv@freebsd.am>
Reviewed by: imp, philip
Differential Revision: https://reviews.freebsd.org/D22871
Notes:
svn path=/head/; revision=355978
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise small quantities look nonsensical. For instance, when
swapping in a single page we would print "4096 In".
Fix code indentation while here.
MFC after: 1 week
Sponsored by: The FreeBSD Foundation
Notes:
svn path=/head/; revision=354829
|
| |
|
|
|
|
|
|
|
|
|
| |
This uses the same logic as with the -s option, first validating the
entered value, then storing the result in a struct timeval.
MFC after: 3 days
X-MFC-With: r352818
Notes:
svn path=/head/; revision=352819
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In r334906, the -s option was changed to allow fractional times, but
this only functioned correctly for batch mode. In interactive mode, any
delay below 1.0 would get floored to zero. This would put top(1) into a
tight loop, which could be difficult to interrupt.
Fix this by storing the -s option value (after validation) into a struct
timeval, and using that struct consistently for delaying with select(2).
Next up is to allow interactive entry of a fractional delay value.
MFC after: 3 days
Notes:
svn path=/head/; revision=352818
|
| |
|
|
|
|
|
|
|
|
|
| |
The description talks about 'number', while the final argument was
'count'. Since 'count' is already used for the count of displays,
change the final argument name to 'number'.
MFC after: 3 days
Notes:
svn path=/head/; revision=352804
|
| |
|
|
|
|
|
| |
locale to LC_CTYPE in the ENVIRONMENT section.
Notes:
svn path=/head/; revision=352568
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
depending on locale.
- add setlocale()
- remove printable() function
- add VIS_OCTAL and VIS_SAFE to the flag of strvisx() to display
non-printable characters that do not use C-style backslash sequences
in three digit octal sequence, or remove it
This change allows multibyte characters to be displayed according to
locale. If it is recognized as a non-display character according to the
locale, it is displayed in three digit octal sequence.
Reference:
https://www.mail-archive.com/svn-src-all@freebsd.org/msg165751.html
https://www.mail-archive.com/svn-src-all@freebsd.org/msg165766.html
https://www.mail-archive.com/svn-src-all@freebsd.org/msg165833.html
https://www.mail-archive.com/svn-src-all@freebsd.org/msg165846.html
https://www.mail-archive.com/svn-src-all@freebsd.org/msg165891.html
Submitted by: hrs
Differential Revision: https://reviews.freebsd.org/D16204
Notes:
svn path=/head/; revision=352558
|
| |
|
|
|
|
|
| |
MFC after: 2 weeks
Notes:
svn path=/head/; revision=349957
|
| |
|
|
|
|
|
|
|
|
|
| |
Submitted by: antranigv@freebsd.am
Reviewed by: bapt
MFC after: 1 month
Sponsored by: Klara Systems
Differential Revision: https://reviews.freebsd.org/D18928
Notes:
svn path=/head/; revision=349235
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
to no longer be displayed. This was because the reimplementation of
setup_buffer() did not copy the previous contents into any reallocated
buffer.
Reported by: James Wright <james.wright@jigsawdezign.com>
PR: 236947
MFC after: 3 days
Notes:
svn path=/head/; revision=345807
|