diff options
author | Jason E. Hale <jhale@FreeBSD.org> | 2023-11-06 19:53:12 +0000 |
---|---|---|
committer | Jason E. Hale <jhale@FreeBSD.org> | 2023-11-06 20:49:55 +0000 |
commit | 089da4a7a764183a8d63d22dedc12537f90b50db (patch) | |
tree | 020b593e7fd6bb8fc434ff5b2a2ce6f96faa83e8 | |
parent | 1e61d415572875f0b50591affd0bbf7bed9a948f (diff) | |
download | ports-089da4a7a764183a8d63d22dedc12537f90b50db.tar.gz ports-089da4a7a764183a8d63d22dedc12537f90b50db.zip |
www/qt6-webengine: Really disable PCH
Due to the way qt_evaluate_config_expression()[1] parses conditions,
De Morgan's Laws do not apply. This function is internal to the Qt
build process and this behavior may be by design for simplicity.
NOT (A OR B) defies logic and always evaluates to NOT A OR B, so we
must express this as NOT A AND NOT B instead to get the desired result.
Disabling PCH (pre-compiled headers) greatly decreases build time,
especially with ccache and should fix the build on arm64 (not tested).
../../../../../qtwebengine-everywhere-src-6.5.3/src/3rdparty/chromium/base/strings/string_util.h:51:3:
error: non-const lvalue reference to type '__builtin_va_list' cannot bind to a value of unrelated type 'va_list' (aka 'std::__va_list')
va_start(arguments, format);
^~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/sys/_stdarg.h:45:49: note: expanded from macro 'va_start'
#define va_start(ap, last) __builtin_va_start((ap), (last))
^~~~
[1] https://code.qt.io/cgit/qt/qtbase.git/tree/cmake/QtFeature.cmake?h=6.5.3#n84
-rw-r--r-- | www/qt6-webengine/files/patch-cmake_Functions.cmake | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/www/qt6-webengine/files/patch-cmake_Functions.cmake b/www/qt6-webengine/files/patch-cmake_Functions.cmake index 2ebeb4684add..919c24219f0b 100644 --- a/www/qt6-webengine/files/patch-cmake_Functions.cmake +++ b/www/qt6-webengine/files/patch-cmake_Functions.cmake @@ -23,7 +23,7 @@ extend_gn_list(gnArgArg ARGS enable_precompiled_headers - CONDITION BUILD_WITH_PCH AND NOT LINUX -+ CONDITION BUILD_WITH_PCH AND NOT (LINUX OR FREEBSD) ++ CONDITION BUILD_WITH_PCH AND NOT LINUX AND NOT FREEBSD ) extend_gn_list(gnArgArg ARGS dcheck_always_on |