diff options
author | Dimitry Andric <dim@FreeBSD.org> | 2024-09-15 11:55:03 +0000 |
---|---|---|
committer | Dimitry Andric <dim@FreeBSD.org> | 2024-09-28 09:53:51 +0000 |
commit | 2b65317363f625eceb125cad5864fd873a66562f (patch) | |
tree | c8d1f3c3d0c652651154d0906f00985211097a04 /devel/libffi/(developers-only) | |
parent | c42de78032ea24d6431412e2aec35383c3c66a34 (diff) | |
download | ports-main.tar.gz ports-main.zip |
As noted in the libc++ 19 release notes [1], std::char_traits<> is now
only provided for char, char8_t, char16_t, char32_t and wchar_t, and any
instantiation for other types will fail.
This causes graphics/libemf to fail to compile with clang 19 and libc++
19, resulting in errors similar to:
/usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned short>'
820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value,
| ^
libemf.cpp:982:30: note: in instantiation of template class 'std::basic_string<unsigned short>' requested here
982 | std::basic_string<WCHAR> filename_w( filename, filename + filename_count );
| ^
/usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here
23 | struct _LIBCPP_TEMPLATE_VIS char_traits;
| ^
libemf should really use char16_t for its 16-bit character type, but the
code is full of Windows assumptions that WCHAR is unsigned short. Since
std::basic_string<unsigned short> is no longer available, use
std::basic_string<char16_t> instead, and cast the result to the
appropriate type for GetEnhMetaFileW().
[1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals
PR: 281516
Approved by: maintainer timeout (~2 weeks)
MFH: 2024Q3
Diffstat (limited to 'devel/libffi/(developers-only)')
0 files changed, 0 insertions, 0 deletions