Cleanup multimedia/gxine

- Add NLS option
- Drop GNOME option which does not do anything anymore without
  gnome-screensaver which was removed in 2014
- Fix build of LIRC option

Submitted by:	ndowens@yahoo.com
Reviewed by:	mat, tobik
Differential Revision:	https://reviews.freebsd.org/D16978

2 files changed, 44 insertions, 53 deletions

diff --git a/multimedia/gxine/Makefile b/multimedia/gxine/Makefile
index b629a3413831..16b19199e1ef 100644
--- a/multimedia/gxine/Makefile
+++ b/multimedia/gxine/Makefile
@@ -3,7 +3,7 @@
 
 PORTNAME=	gxine
 PORTVERSION=	0.5.910
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	multimedia
 MASTER_SITES=	SF/xine/${PORTNAME}/${PORTVERSION}
 
@@ -11,43 +11,37 @@ MAINTAINER=	ports@FreeBSD.org
 COMMENT=	Alternative GUI for the Xine media player
 
 LICENSE=	GPLv2
+LICENSE_FILE=	${WRKSRC}/COPYING
 
 LIB_DEPENDS=	libnspr4.so:devel/nspr \
 		libmozjs185.so:lang/spidermonkey185 \
 		libxine.so:multimedia/libxine
 
-USES=		desktop-file-utils gettext gmake libtool pathfix pkgconfig tar:xz
+USES=		desktop-file-utils gmake gnome libtool pathfix pkgconfig tar:xz
 USE_GNOME=	gtk30
 GNU_CONFIGURE=	yes
-CONFIGURE_ARGS=	--without-hal --with-libintl-prefix=${LOCALBASE} --with-gtk3
-LLD_UNSAFE=	yes
+CONFIGURE_ARGS=	--without-hal --with-libintl-prefix=${LOCALBASE} \
+		--with-gtk3 --without-dbus --disable-integration-wizard 
 INSTALLS_ICONS=	yes
+LLD_UNSAFE=	yes
 
-CPPFLAGS+=	-I${LOCALBASE}/include
-LDFLAGS+=	-L${LOCALBASE}/lib -lm
+OPTIONS_DEFINE=	LIRC NLS WEBPLUGIN
+OPTIONS_SUB=	yes
 
-OPTIONS_DEFINE=		GNOME LIRC WEBPLUGIN
-OPTIONS_SUB=		yes
+WEBPLUGIN_DESC=	Build and/or install Web browser plugins
 
-GNOME_BUILD_DEPENDS=	gnome-screensaver:x11/gnome-screensaver
-GNOME_LIB_DEPENDS=	libdbus-glib-1.so:devel/dbus-glib
-GNOME_RUN_DEPENDS=	gnome-screensaver:x11/gnome-screensaver
-GNOME_CONFIGURE_ON=	--with-dbus
-GNOME_CONFIGURE_OFF=	--disable-integration-wizard --without-dbus
 LIRC_LIB_DEPENDS=	liblirc_client.so:comms/lirc
-LIRC_CONFIGURE_ON=	--enable-lirc
-LIRC_CONFIGURE_OFF=	--disable-lirc
-WEBPLUGIN_DESC=		Build and/or install Web browser plugins
-WEBPLUGIN_USE=		xorg=xaw
-WEBPLUGIN_USES=		webplugin:native
-WEBPLUGIN_CONFIGURE_OFF=	--without-browser-plugin
+LIRC_CONFIGURE_ENABLE=	lirc
+LIRC_USES=		localbase
 
-.include <bsd.port.options.mk>
+NLS_CONFIGURE_ENABLE=	nls
+NLS_USES=		gettext
 
-.if ${PORT_OPTIONS:MWEBPLUGIN}
-WEBPLUGIN_DIR=	${PREFIX}/lib/gxine
-WEBPLUGIN_FILES=gxineplugin.so
-.endif
+WEBPLUGIN_USE=			xorg=xaw
+WEBPLUGIN_USES=			webplugin:native
+WEBPLUGIN_CONFIGURE_WITH=	browser-plugin
+WEBPLUGIN_DIR=			${PREFIX}/lib/gxine
+WEBPLUGIN_FILES=		gxineplugin.so
 
 post-patch:
 	@${REINPLACE_CMD} -e \
@@ -58,10 +52,7 @@ post-patch:
 	@${REINPLACE_CMD} -e \
 		's|@MAKE_PNG_TRUE@|#|' ${WRKSRC}/pixmaps/Makefile.in
 
-post-install:
-	${CP} ${WRKSRC}/pixmaps/logo.mpv ${STAGEDIR}${PREFIX}/share/gxine
-.if ${PORT_OPTIONS:MWEBPLUGIN}
+post-install-WEBPLUGIN-on:
 	@${STRIP_CMD} ${STAGEDIR}${WEBPLUGIN_DIR}/${WEBPLUGIN_FILES}
-.endif
 
 .include <bsd.port.mk>
diff --git a/multimedia/gxine/pkg-plist b/multimedia/gxine/pkg-plist
index 5e4a4b20372f..3091114404cf 100644
--- a/multimedia/gxine/pkg-plist
+++ b/multimedia/gxine/pkg-plist
@@ -6,6 +6,7 @@ bin/gxine_client
 %%ETCDIR%%/startup
 %%ETCDIR%%/toolbar-fullscreen.xml
 %%ETCDIR%%/toolbar-window.xml
+%%WEBPLUGIN%%%%WEBPLUGIN_DIR%%/gxineplugin.so
 man/de/man1/gxine.1.gz
 man/de/man1/gxine_client.1.gz
 man/es/man1/gxine.1.gz
@@ -14,7 +15,6 @@ man/man1/gxine.1.gz
 man/man1/gxine_client.1.gz
 share/applications/gxine.desktop
 %%DATADIR%%/logo.jpg
-%%DATADIR%%/logo.mpv
 %%DATADIR%%/mediamarks
 %%DATADIR%%/pixmaps/gxine-icon.xpm
 %%DATADIR%%/pixmaps/nospeaker.png
@@ -30,28 +30,28 @@ share/applications/gxine.desktop
 %%DATADIR%%/pixmaps/splash.png
 %%DATADIR%%/pixmaps/subtitle.svg
 share/icons/hicolor/64x64/apps/gxine.png
-share/locale/cs/LC_MESSAGES/gxine.mo
-share/locale/cs/LC_MESSAGES/gxine.theme.mo
-share/locale/de/LC_MESSAGES/gxine.mo
-share/locale/de/LC_MESSAGES/gxine.theme.mo
-share/locale/es/LC_MESSAGES/gxine.mo
-share/locale/es/LC_MESSAGES/gxine.theme.mo
-share/locale/fi/LC_MESSAGES/gxine.mo
-share/locale/fi/LC_MESSAGES/gxine.theme.mo
-share/locale/fr/LC_MESSAGES/gxine.mo
-share/locale/fr/LC_MESSAGES/gxine.theme.mo
-share/locale/it/LC_MESSAGES/gxine.mo
-share/locale/it/LC_MESSAGES/gxine.theme.mo
-share/locale/ja/LC_MESSAGES/gxine.mo
-share/locale/ja/LC_MESSAGES/gxine.theme.mo
-share/locale/pl/LC_MESSAGES/gxine.mo
-share/locale/pl/LC_MESSAGES/gxine.theme.mo
-share/locale/ru/LC_MESSAGES/gxine.mo
-share/locale/ru/LC_MESSAGES/gxine.theme.mo
-share/locale/sv/LC_MESSAGES/gxine.mo
-share/locale/sv/LC_MESSAGES/gxine.theme.mo
-share/locale/uk/LC_MESSAGES/gxine.mo
-share/locale/uk/LC_MESSAGES/gxine.theme.mo
-share/locale/zh_CN/LC_MESSAGES/gxine.mo
-share/locale/zh_CN/LC_MESSAGES/gxine.theme.mo
+%%NLS%%share/locale/cs/LC_MESSAGES/gxine.mo
+%%NLS%%share/locale/cs/LC_MESSAGES/gxine.theme.mo
+%%NLS%%share/locale/de/LC_MESSAGES/gxine.mo
+%%NLS%%share/locale/de/LC_MESSAGES/gxine.theme.mo
+%%NLS%%share/locale/es/LC_MESSAGES/gxine.mo
+%%NLS%%share/locale/es/LC_MESSAGES/gxine.theme.mo
+%%NLS%%share/locale/fi/LC_MESSAGES/gxine.mo
+%%NLS%%share/locale/fi/LC_MESSAGES/gxine.theme.mo
+%%NLS%%share/locale/fr/LC_MESSAGES/gxine.mo
+%%NLS%%share/locale/fr/LC_MESSAGES/gxine.theme.mo
+%%NLS%%share/locale/it/LC_MESSAGES/gxine.mo
+%%NLS%%share/locale/it/LC_MESSAGES/gxine.theme.mo
+%%NLS%%share/locale/ja/LC_MESSAGES/gxine.mo
+%%NLS%%share/locale/ja/LC_MESSAGES/gxine.theme.mo
+%%NLS%%share/locale/pl/LC_MESSAGES/gxine.mo
+%%NLS%%share/locale/pl/LC_MESSAGES/gxine.theme.mo
+%%NLS%%share/locale/ru/LC_MESSAGES/gxine.mo
+%%NLS%%share/locale/ru/LC_MESSAGES/gxine.theme.mo
+%%NLS%%share/locale/sv/LC_MESSAGES/gxine.mo
+%%NLS%%share/locale/sv/LC_MESSAGES/gxine.theme.mo
+%%NLS%%share/locale/uk/LC_MESSAGES/gxine.mo
+%%NLS%%share/locale/uk/LC_MESSAGES/gxine.theme.mo
+%%NLS%%share/locale/zh_CN/LC_MESSAGES/gxine.mo
+%%NLS%%share/locale/zh_CN/LC_MESSAGES/gxine.theme.mo
 share/pixmaps/gxine.png