Clenup xfce ports:

- Add missing dependencies
- Remove unneeded patches
- Regenerate and rename legacy patches
- Add NLS option to ports providing such a knob, and missing the
  option
- Add INSTALL_TARGET=install-strip where missing
- Sort things
- Remove unneeded +=
- Cosmetic changes to OPTION related variables to improve readability
- Update WWW
- Silence portlint warnings about variables order
- Bump PORTREVISION where changing dependencies and/or adding
  install-strip

3 files changed, 16 insertions, 24 deletions

diff --git a/x11/xfce4-dashboard/Makefile b/x11/xfce4-dashboard/Makefile
index 5720dfc13190..70725db3068f 100644
--- a/x11/xfce4-dashboard/Makefile
+++ b/x11/xfce4-dashboard/Makefile
@@ -16,26 +16,29 @@ COMMENT=	GNOME shell like dashboard for the Xfce desktop
 LICENSE=	GPLv2
 
 LIB_DEPENDS=	libdbus-glib-1.so:devel/dbus-glib \
-	libdbus-1.so:devel/dbus \
-	libjson-glib-1.0.so:devel/json-glib \
-	libcogl.so:graphics/cogl \
-	libclutter-1.0.so:graphics/clutter
-
-GNU_CONFIGURE=	yes
-USES=	gettext-tools gmake localbase libtool pathfix perl5 pkgconfig \
-	tar:bzip2 xfce:gtk3
-USE_GNOME=	glib20 gtk30 libwnck3 cairo intltool intlhack
+		libdbus-1.so:devel/dbus \
+		libjson-glib-1.0.so:devel/json-glib \
+		libcogl.so:graphics/cogl \
+		libclutter-1.0.so:graphics/clutter
+
+USES=		gettext-tools gmake gnome localbase libtool pathfix perl5 pkgconfig \
+		tar:bzip2 xfce:gtk3
+USE_GNOME=	cairo glib20 gtk30 intlhack intltool libwnck3
 USE_XFCE=	garcon
 USE_XORG=	x11 xcomposite xdamage xext xfixes xi xinerama xrandr
-USE_GL=	egl gl
+USE_GL=		egl gl
+USE_LDCONFIG=	yes
+
+GNU_CONFIGURE=	yes
 INSTALLS_ICONS=	yes
 INSTALL_TARGET=	install-strip
 
 OPTIONS_DEFINE=	NLS
-NLS_USES=	gettext-runtime
-NLS_CONFIGURE_ENABLE=	nls
 OPTIONS_SUB=	yes
 
+NLS_CONFIGURE_ENABLE=	nls
+NLS_USES=	gettext-runtime
+
 post-patch:
 # Decrease default value of desaturation factor (0.0 -> no desaturation)
 # With some graphics cards, quick launch icons are totally black with
diff --git a/x11/xfce4-dashboard/files/patch-configure b/x11/xfce4-dashboard/files/patch-configure
deleted file mode 100644
index c060a55a7bcf..000000000000
--- a/x11/xfce4-dashboard/files/patch-configure
+++ /dev/null
@@ -1,11 +0,0 @@
---- configure.orig	2016-05-20 19:36:31 UTC
-+++ configure
-@@ -14443,7 +14443,7 @@ $as_echo "#define HAVE_LC_MESSAGES 1" >>
- 
-     fi
-   fi
--     USE_NLS=yes
-+     #USE_NLS=yes
- 
- 
-     gt_cv_have_gettext=no
diff --git a/x11/xfce4-dashboard/pkg-descr b/x11/xfce4-dashboard/pkg-descr
index 0b4d3179bd58..a99c566e697d 100644
--- a/x11/xfce4-dashboard/pkg-descr
+++ b/x11/xfce4-dashboard/pkg-descr
@@ -3,4 +3,4 @@ the Xfce desktop. It can be configured to run any keyboard shortcut and
 when executed provides an overview of applications currently open enabling
 the user to switch between different applications.
 
-WWW: http://goodies.xfce.org/projects/applications/xfdashboard/
+WWW: https://goodies.xfce.org/projects/applications/xfdashboard/start