aboutsummaryrefslogtreecommitdiff
path: root/sys/dev/fe
diff options
context:
space:
mode:
authorRobert Watson <rwatson@FreeBSD.org>2005-08-03 00:18:35 +0000
committerRobert Watson <rwatson@FreeBSD.org>2005-08-03 00:18:35 +0000
commit13b203d0d78cc08a7e0da8e8d5eb8c1a5d94ab69 (patch)
tree9a4e586ffbcd1450917ee5e388a4e1eb38254e32 /sys/dev/fe
parentbccb41014af4667b1cf2878456f5a8a854acf1f7 (diff)
downloadsrc-13b203d0d78cc08a7e0da8e8d5eb8c1a5d94ab69.tar.gz
src-13b203d0d78cc08a7e0da8e8d5eb8c1a5d94ab69.zip
Modify device drivers supporting multicast addresses to lock if_addr_mtx
over iteration of their multicast address lists when synchronizing the hardware address filter with the network stack-maintained list. Problem reported by: Ed Maste (emaste at phaedrus dot sandvine dot ca> MFC after: 1 week
Notes
Notes: svn path=/head/; revision=148654
Diffstat (limited to 'sys/dev/fe')
-rw-r--r--sys/dev/fe/if_fe.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/sys/dev/fe/if_fe.c b/sys/dev/fe/if_fe.c
index 643f3e432de5..8b54c011a7a3 100644
--- a/sys/dev/fe/if_fe.c
+++ b/sys/dev/fe/if_fe.c
@@ -2060,6 +2060,7 @@ fe_mcaf ( struct fe_softc *sc )
struct ifmultiaddr *ifma;
filter = fe_filter_nothing;
+ IF_ADDR_LOCK(sc->ifp);
TAILQ_FOREACH(ifma, &sc->ifp->if_multiaddrs, ifma_link) {
if (ifma->ifma_addr->sa_family != AF_LINK)
continue;
@@ -2072,6 +2073,7 @@ fe_mcaf ( struct fe_softc *sc )
filter.data[index >> 3] |= 1 << (index & 7);
}
+ IF_ADDR_UNLOCK(sc->ifp);
return ( filter );
}